[Intel-gfx] ✗ Fi.CI.BUILD: failure for series starting with [01/11] drm/i915/display: move needs_modeset to an inline in header

2020-12-10 Thread Patchwork
== Series Details == Series: series starting with [01/11] drm/i915/display: move needs_modeset to an inline in header URL : https://patchwork.freedesktop.org/series/84812/ State : failure == Summary == CALLscripts/checksyscalls.sh CALLscripts/atomic/check-atomics.sh DESCEND

[Intel-gfx] [RFC-v7 15/21] drm/i915/pxp: Implement ioctl action to set session in play

2020-12-10 Thread Huang, Sean Z
With this ioctl action, userspace driver can set the session in state "session in play", after dirver reserved the session slot/id from kernel PXP, and sent the TEE commands to activate the corresponding hardware session. Session state "session in play" means this session is ready for secure

[Intel-gfx] [RFC-v7 14/21] drm/i915/pxp: Implement ioctl action to reserve session slots

2020-12-10 Thread Huang, Sean Z
With this ioctl action, userspace driver can reserve one or multiple session slot/id assigned by kernel PXP, as the first step of PXP session establishment flow. The session info is stored in the session list structure. Signed-off-by: Huang, Sean Z --- drivers/gpu/drm/i915/Makefile

[Intel-gfx] [RFC-v7 21/21] drm/i915/pxp: Enable the PXP ioctl for protected session

2020-12-10 Thread Huang, Sean Z
In the previous commits, we have implemented the PXP ioctl functions. Now we enable those handlers and expose them as PXP ioctl, so allow the userspace driver can establish, set, or destory the protected session via this ioctl. Signed-off-by: Huang, Sean Z --- drivers/gpu/drm/i915/i915_drv.c

[Intel-gfx] [RFC-v7 11/21] drm/i915/uapi: introduce drm_i915_gem_create_ext

2020-12-10 Thread Huang, Sean Z
From: Bommu Krishnaiah Same old gem_create but with now with extensions support. This is needed to support various upcoming usecases. For now we use the extensions mechanism to support PAVP. Signed-off-by: Bommu Krishnaiah Signed-off-by: Matthew Auld Cc: Joonas Lahtinen

[Intel-gfx] [RFC-v7 17/21] drm/i915/pxp: Implement ioctl action to send TEE commands

2020-12-10 Thread Huang, Sean Z
Implement the ioctl action to allow userspace driver sends TEE commands via PXP ioctl, instead of TEE iotcl. So we can centralize those protection operations at PXP. Signed-off-by: Huang, Sean Z --- drivers/gpu/drm/i915/pxp/intel_pxp.c | 48 +---

[Intel-gfx] [RFC-v7 04/21] drm/i915/pxp: Create the arbitrary session after boot

2020-12-10 Thread Huang, Sean Z
Create the arbitrary session, with the fixed session id 0xf, after system boot, for the case that application allocates the protected buffer without establishing any protection session. Because the hardware requires at least one alive session for protected buffer creation. This arbitrary session

[Intel-gfx] [RFC-v7 18/21] drm/i915/pxp: Implement ioctl action to query PXP tag

2020-12-10 Thread Huang, Sean Z
Enable the PXP ioctl action to allow userspace driver to query the PXP tag, which is a 32-bit bitwise value indicating the current session info, including protection type, session id, and whether the session is enabled. Signed-off-by: Huang, Sean Z --- drivers/gpu/drm/i915/pxp/intel_pxp.c

[Intel-gfx] [RFC-v7 10/21] mei: pxp: export pavp client to me client bus

2020-12-10 Thread Huang, Sean Z
From: Vitaly Lubart Export PAVP client to work with i915_cp driver, for binding it uses kernel component framework. Signed-off-by: Vitaly Lubart Signed-off-by: Tomas Winkler --- drivers/misc/mei/Kconfig | 2 + drivers/misc/mei/Makefile | 1 + drivers/misc/mei/pxp/Kconfig |

[Intel-gfx] [RFC-v7 16/21] drm/i915/pxp: Implement ioctl action to terminate the session

2020-12-10 Thread Huang, Sean Z
Implement the PXP ioctl action to allow userspace driver to terminate the hardware session and cleanup its software session state. PXP sends the session termination command to GPU once receves this ioctl action. Signed-off-by: Huang, Sean Z --- drivers/gpu/drm/i915/pxp/intel_pxp.c | 10 +++

[Intel-gfx] [RFC-v7 13/21] drm/i915/pxp: Add plane decryption support

2020-12-10 Thread Huang, Sean Z
From: Anshuman Gupta Add support to enable/disable PLANE_SURF Decryption Request bit. It requires only to enable plane decryption support when following condition met. 1. PAVP session is enabled. 2. Buffer object is protected. v2: - Rebased to libva_cp-drm-tip_tgl_cp tree. - Used gen fb obj

[Intel-gfx] [RFC-v7 09/21] drm/i915/pxp: Expose session state for display protection flip

2020-12-10 Thread Huang, Sean Z
Implement the intel_pxp_gem_object_status() to allow i915 display querying the current PXP session state. In the design, display should not perform protection flip on the protected buffers if there is no PXP session alive. Signed-off-by: Huang, Sean Z --- drivers/gpu/drm/i915/pxp/intel_pxp.c |

[Intel-gfx] [RFC-v7 05/21] drm/i915/pxp: Func to send hardware session termination

2020-12-10 Thread Huang, Sean Z
Implement the functions to allow PXP to send a GPU command, in order to terminate the hardware session, so hardware can recycle this session slot for the next usage. Signed-off-by: Huang, Sean Z --- drivers/gpu/drm/i915/Makefile| 1 + drivers/gpu/drm/i915/pxp/intel_pxp_cmd.c | 156

[Intel-gfx] [RFC-v7 08/21] drm/i915/pxp: Enable PXP power management

2020-12-10 Thread Huang, Sean Z
During the power event S3+ sleep/resume, hardware will lose all the encryption keys for every hardware session, even though the software session state was marked as alive after resume. So to handle such case, PXP should terminate all the hardware sessions and cleanup all the software states after

[Intel-gfx] [RFC-v7 01/21] drm/i915/pxp: Introduce Intel PXP component

2020-12-10 Thread Huang, Sean Z
PXP (Protected Xe Path) is an i915 componment, available on GEN12+, that helps to establish the hardware protected session and manage the status of the alive software session, as well as its life cycle. This patch series is to allow the kernel space to create and manage a single hardware session

[Intel-gfx] [RFC-v7 20/21] drm/i915/pxp: Add PXP-related registers into allowlist

2020-12-10 Thread Huang, Sean Z
Add several PXP-related reg into allowlist to allow user space driver to read the those register values. Signed-off-by: Huang, Sean Z --- drivers/gpu/drm/i915/i915_reg.h | 6 drivers/gpu/drm/i915/intel_uncore.c | 50 - 2 files changed, 41 insertions(+), 15

[Intel-gfx] [RFC-v7 02/21] drm/i915/pxp: set KCR reg init during the boot time

2020-12-10 Thread Huang, Sean Z
Set the KCR init during the boot time, which is required by hardware, to allow us doing further protection operation such as sending commands to GPU or TEE. Signed-off-by: Huang, Sean Z --- drivers/gpu/drm/i915/pxp/intel_pxp.c | 8 1 file changed, 8 insertions(+) diff --git

[Intel-gfx] [RFC-v7 19/21] drm/i915/pxp: Termiante the session upon app crash

2020-12-10 Thread Huang, Sean Z
PXP should terminate the hardware session and cleanup the software state gracefully when the application has established the protection session, but doesn't close the session correctly due to some cases like application crash. Signed-off-by: Huang, Sean Z --- drivers/gpu/drm/i915/i915_drv.c

[Intel-gfx] [RFC-v7 12/21] drm/i915/pxp: User interface for Protected buffer

2020-12-10 Thread Huang, Sean Z
From: Bommu Krishnaiah This api allow user mode to create Protected buffer and context creation. Signed-off-by: Bommu Krishnaiah Cc: Telukuntla Sreedhar Cc: Kondapally Kalyan Cc: Gupta Anshuman Cc: Huang Sean Z --- drivers/gpu/drm/i915/gem/i915_gem_context.c | 15 ++--

[Intel-gfx] [RFC-v7 06/21] drm/i915/pxp: Enable PXP irq worker and callback stub

2020-12-10 Thread Huang, Sean Z
Create the irq worker that serves as callback handler, those callback stubs should be called while the hardware key teardown occurs. Signed-off-by: Huang, Sean Z --- drivers/gpu/drm/i915/gt/intel_gt_irq.c | 4 + drivers/gpu/drm/i915/i915_reg.h | 3 +-

[Intel-gfx] [RFC-v7 07/21] drm/i915/pxp: Destroy arb session upon teardown

2020-12-10 Thread Huang, Sean Z
Teardown is triggered when the display topology changes and no long meets the secure playback requirement, and hardware trashes all the encryption keys for display. So as a result, PXP should handle such case and terminate the type0 sessions, which including arb session Signed-off-by: Huang, Sean

[Intel-gfx] [RFC-v7 03/21] drm/i915/pxp: Implement funcs to create the TEE channel

2020-12-10 Thread Huang, Sean Z
Implement the funcs to create the TEE channel, so kernel can send the TEE commands directly to TEE for creating the arbitrary (defualt) session. Signed-off-by: Huang, Sean Z --- drivers/gpu/drm/i915/Makefile| 3 +- drivers/gpu/drm/i915/i915_drv.c | 1 +

[Intel-gfx] [RFC-v7 00/21] Introduce Intel PXP component - Mesa single session

2020-12-10 Thread Huang, Sean Z
PXP (Protected Xe Path) is an i915 componment, available on GEN12+ that helps to establish the hardware protected session and manage the status of the alive software session, as well as its life cycle. [commit #1 - #13] This patch series is to allow the kernel space to create and manage a single

[Intel-gfx] [PATCH 10/11] drm/i915: move pipe update code into crtc.

2020-12-10 Thread Dave Airlie
From: Dave Airlie Daniel suggested this should move here. Signed-off-by: Dave Airlie --- drivers/gpu/drm/i915/display/intel_crtc.c | 230 drivers/gpu/drm/i915/display/intel_sprite.c | 228 --- 2 files changed, 230 insertions(+), 228 deletions(-) diff

[Intel-gfx] [PATCH 07/11] drm/i915: split fdi code out from intel_display.c

2020-12-10 Thread Dave Airlie
From: Dave Airlie This just refactors out the fdi code to a separate file. Signed-off-by: Dave Airlie --- drivers/gpu/drm/i915/Makefile | 1 + drivers/gpu/drm/i915/display/intel_display.c | 685 +- .../drm/i915/display/intel_display_types.h| 9 +

[Intel-gfx] [PATCH 11/11] drm/i915: split fb scalable checks into g4x and skl versions

2020-12-10 Thread Dave Airlie
From: Dave Airlie This just cleans these up a bit. Signed-off-by: Dave Airlie --- drivers/gpu/drm/i915/display/intel_gen9_plane.c | 4 ++-- drivers/gpu/drm/i915/display/intel_sprite.c | 7 +++ 2 files changed, 5 insertions(+), 6 deletions(-) diff --git

[Intel-gfx] [PATCH 05/11] drm/i915: refactor some crtc code out of intel display.

2020-12-10 Thread Dave Airlie
From: Dave Airlie There may be more crtc code that can be pulled out, but this is a good start. RFC: maybe call the new file something different Signed-off-by: Dave Airlie --- drivers/gpu/drm/i915/Makefile| 1 + drivers/gpu/drm/i915/display/intel_crtc.c| 953

[Intel-gfx] [PATCH 08/11] drm/i915: migrate hsw fdi code to new file.

2020-12-10 Thread Dave Airlie
From: Dave Airlie Daniel asked for this, but it's a bit messy and I'm not sure how best to clean it up yet. Signed-off-by: Dave Airlie --- drivers/gpu/drm/i915/display/intel_crt.c | 1 + drivers/gpu/drm/i915/display/intel_ddi.c | 151 +--

[Intel-gfx] [PATCH 06/11] drm/i915: refactor pll code out into intel_dpll.c

2020-12-10 Thread Dave Airlie
From: Dave Airlie This pulls a large chunk of the pll calculation code out of intel_display.c to a new file. One function makse sense to be an inline, otherwise this is pretty much a straight copy cover. also all the remaining hooks for g45 and older end up the same now. Signed-off-by: Dave

[Intel-gfx] [PATCH 04/11] drm/i915: refactor cursor code out of i915_display.c

2020-12-10 Thread Dave Airlie
From: Dave Airlie This file is a monster, let's start simple, the cursor plane code seems pretty standalone, and splits out easily enough. Reviewed-by: Ville Syrjälä Signed-off-by: Dave Airlie --- drivers/gpu/drm/i915/Makefile| 1 +

[Intel-gfx] [RFC v3] refactor intel display a bit more

2020-12-10 Thread Dave Airlie
The first 4 patches are fixed up and reviewed, so it would be good if we could land those at least. I haven't had much time to rework the others, I've removed the legacy, and added header files and renamed some functions where it wasn't too intrusive. I think the file names probably do need

[Intel-gfx] [PATCH 03/11] drm/i915/display: fix misused comma

2020-12-10 Thread Dave Airlie
From: Dave Airlie There is no need for a comma use here. Reviewed-by: Ville Syrjälä Signed-off-by: Dave Airlie --- drivers/gpu/drm/i915/display/intel_display.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/display/intel_display.c

[Intel-gfx] [PATCH 02/11] drm/i915/display: move to_intel_frontbuffer to header

2020-12-10 Thread Dave Airlie
From: Dave Airlie This will be used for some refactoring in other files, so move it first. Signed-off-by: Dave Airlie Reviewed-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_display.c | 6 -- drivers/gpu/drm/i915/display/intel_display_types.h | 6 ++ 2 files changed,

[Intel-gfx] [PATCH 01/11] drm/i915/display: move needs_modeset to an inline in header

2020-12-10 Thread Dave Airlie
From: Dave Airlie This function is going to be used in a later change, so clean it up first before moving it. Reviewed-by: Ville Syrjälä Signed-off-by: Dave Airlie --- drivers/gpu/drm/i915/display/intel_display.c | 78 +-- .../drm/i915/display/intel_display_types.h| 6

Re: [Intel-gfx] [PATCH v7 18/18] drm/i915/hdcp: Enable HDCP 2.2 MST support

2020-12-10 Thread Ramalingam C
On 2020-12-10 at 11:56:40 +0530, Anshuman Gupta wrote: > Enable HDCP 2.2 over DP MST. > Authenticate and enable port encryption only once for > an active HDCP 2.2 session, once port is authenticated > and encrypted enable encryption for each stream that > requires encryption on this port. > >

Re: [Intel-gfx] [PATCH v7 17/18] drm/i915/hdcp: Support for HDCP 2.2 MST shim callbacks

2020-12-10 Thread Ramalingam C
On 2020-12-10 at 11:56:39 +0530, Anshuman Gupta wrote: > Add support for HDCP 2.2 DP MST shim callback. > This adds existing DP HDCP shim callback for Link Authentication > and Encryption and HDCP 2.2 stream encryption > callback. > > v2: > - Added a WARN_ON() instead of drm_err. [Uma] > -

Re: [Intel-gfx] [PATCH 1/2] drm/framebuffer: Format modifier for Intel Gen 12 render compression with Clear Color

2020-12-10 Thread Chery, Nanley G
> -Original Message- > From: Imre Deak > Sent: Tuesday, December 1, 2020 4:05 AM > To: Chery, Nanley G ; Chris Wilson wilson.co.uk>; Ville Syrjälä > Cc: Daniel Vetter ; intel-gfx@lists.freedesktop.org; Nikula, > Jani ; Daniel Vetter ; > Kondapally, Kalyan ; Pandiyan, Dhinakaran > ;

Re: [Intel-gfx] [PATCH v7 14/18] drm/i915/hdcp: MST streams support in hdcp port_data

2020-12-10 Thread Ramalingam C
On 2020-12-10 at 11:56:36 +0530, Anshuman Gupta wrote: > Add support for multiple mst stream in hdcp port data > which will be used by RepeaterAuthStreamManage msg and > HDCP 2.2 security f/w for m' validation. > > Security f/w doesn't have any provision to mark the > stream_type for each stream

Re: [Intel-gfx] [PATCH v7 09/18] drm/i915/hdcp: Enable Gen12 HDCP 1.4 DP MST support

2020-12-10 Thread Ramalingam C
On 2020-12-10 at 11:56:31 +0530, Anshuman Gupta wrote: > Enable HDCP 1.4 over DP MST for Gen12. > > v2: > - Enable HDCP for <= Gen12 platforms. [Ram] > > Cc: Ramalingam C > Tested-by: Karthik B S > Signed-off-by: Anshuman Gupta > --- > drivers/gpu/drm/i915/display/intel_dp_mst.c | 6 ++ >

Re: [Intel-gfx] [PATCH v7 08/18] drm/i915/hdcp: Enable HDCP 1.4 stream encryption

2020-12-10 Thread Ramalingam C
On 2020-12-10 at 11:56:30 +0530, Anshuman Gupta wrote: > Enable HDCP 1.4 DP MST stream encryption. IMHO tile of "Configure HDCP1.4 MST steram encryption status" would suit more. But i leave that to your call. > > Enable stream encryption once encryption is enabled on > the DP transport driving

Re: [Intel-gfx] [PATCH v7 04/18] drm/i915/hdcp: No HDCP when encoder is't initialized

2020-12-10 Thread Ramalingam C
On 2020-12-10 at 11:56:26 +0530, Anshuman Gupta wrote: > There can be situation when DP MST connector is created without > mst modeset being done, in those cases connector->encoder will be > NULL. MST connector->encoder initializes after modeset. > Don't enable HDCP in such cases to prevent any

[Intel-gfx] ✓ Fi.CI.IGT: success for Introduce Intel PXP component - Mesa single session (rev6)

2020-12-10 Thread Patchwork
== Series Details == Series: Introduce Intel PXP component - Mesa single session (rev6) URL : https://patchwork.freedesktop.org/series/84620/ State : success == Summary == CI Bug Log - changes from CI_DRM_9473_full -> Patchwork_19118_full

[Intel-gfx] ✓ Fi.CI.IGT: success for drm: Extract DPCD backlight helpers from i915, add support in nouveau (rev3)

2020-12-10 Thread Patchwork
== Series Details == Series: drm: Extract DPCD backlight helpers from i915, add support in nouveau (rev3) URL : https://patchwork.freedesktop.org/series/84754/ State : success == Summary == CI Bug Log - changes from CI_DRM_9473_full -> Patchwork_19117_full

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/display: Go softly softly on initial modeset failure

2020-12-10 Thread Patchwork
== Series Details == Series: drm/i915/display: Go softly softly on initial modeset failure URL : https://patchwork.freedesktop.org/series/84808/ State : failure == Summary == Applying: drm/i915/display: Go softly softly on initial modeset failure Using index info to reconstruct a base tree...

[Intel-gfx] [PATCH i-g-t] i915/gem_exec_fence: Check a submit chain

2020-12-10 Thread Chris Wilson
Submit a chain of spinners across all the engines, using the submit fence to launch them in parallel. Signed-off-by: Chris Wilson --- lib/igt_dummyload.c | 7 +- lib/igt_dummyload.h | 15 ++-- tests/i915/gem_exec_fence.c | 46 + 3

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/gt: Split logical ring contexts from execlist submission (rev2)

2020-12-10 Thread Patchwork
== Series Details == Series: drm/i915/gt: Split logical ring contexts from execlist submission (rev2) URL : https://patchwork.freedesktop.org/series/84752/ State : success == Summary == CI Bug Log - changes from CI_DRM_9473_full -> Patchwork_19116_full

Re: [Intel-gfx] [patch 27/30] xen/events: Only force affinity mask for percpu interrupts

2020-12-10 Thread Thomas Gleixner
On Thu, Dec 10 2020 at 18:20, boris ostrovsky wrote: > On 12/10/20 2:26 PM, Thomas Gleixner wrote: >> All event channel setups bind the interrupt on CPU0 or the target CPU for >> percpu interrupts and overwrite the affinity mask with the corresponding >> cpumask. That does not make sense. >> >>

[Intel-gfx] ✓ Fi.CI.BAT: success for Introduce Intel PXP component - Mesa single session (rev6)

2020-12-10 Thread Patchwork
== Series Details == Series: Introduce Intel PXP component - Mesa single session (rev6) URL : https://patchwork.freedesktop.org/series/84620/ State : success == Summary == CI Bug Log - changes from CI_DRM_9473 -> Patchwork_19118 Summary

Re: [Intel-gfx] [patch 24/30] xen/events: Remove unused bind_evtchn_to_irq_lateeoi()

2020-12-10 Thread Thomas Gleixner
On Thu, Dec 10 2020 at 18:19, boris ostrovsky wrote: > On 12/10/20 2:26 PM, Thomas Gleixner wrote: >> -EXPORT_SYMBOL_GPL(bind_evtchn_to_irq_lateeoi); > > include/xen/events.h also needs to be updated (and in the next patch for > xen_set_affinity_evtchn() as well). Darn, I lost that.

[Intel-gfx] ✗ Fi.CI.DOCS: warning for Introduce Intel PXP component - Mesa single session (rev6)

2020-12-10 Thread Patchwork
== Series Details == Series: Introduce Intel PXP component - Mesa single session (rev6) URL : https://patchwork.freedesktop.org/series/84620/ State : warning == Summary == $ make htmldocs 2>&1 > /dev/null | grep i915 Error: Cannot open file ./drivers/gpu/drm/i915/gt/intel_lrc.c WARNING:

Re: [Intel-gfx] [PATCH] drm/i915/display: Go softly softly on initial modeset failure

2020-12-10 Thread H.J. Lu
On Thu, Dec 10, 2020 at 3:13 PM Rodrigo Vivi wrote: > > On Thu, Dec 10, 2020 at 11:07:41PM +, Chris Wilson wrote: > > Reduce the module/device probe error into a mere debug to hide issues > > where the initial modeset is failing (after lies told by hw probe) and > > the system hangs with a

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Introduce Intel PXP component - Mesa single session (rev6)

2020-12-10 Thread Patchwork
== Series Details == Series: Introduce Intel PXP component - Mesa single session (rev6) URL : https://patchwork.freedesktop.org/series/84620/ State : warning == Summary == $ dim checkpatch origin/drm-tip 483cb19f6248 drm/i915/pxp: Introduce Intel PXP component -:111:

[Intel-gfx] ✓ Fi.CI.BAT: success for drm: Extract DPCD backlight helpers from i915, add support in nouveau (rev3)

2020-12-10 Thread Patchwork
== Series Details == Series: drm: Extract DPCD backlight helpers from i915, add support in nouveau (rev3) URL : https://patchwork.freedesktop.org/series/84754/ State : success == Summary == CI Bug Log - changes from CI_DRM_9473 -> Patchwork_19117

Re: [Intel-gfx] [PATCH] drm/i915/display: Go softly softly on initial modeset failure

2020-12-10 Thread Rodrigo Vivi
On Thu, Dec 10, 2020 at 11:07:41PM +, Chris Wilson wrote: > Reduce the module/device probe error into a mere debug to hide issues > where the initial modeset is failing (after lies told by hw probe) and > the system hangs with a livelock in cleaning up the failed commit. > > Reported-by: H.J.

[Intel-gfx] [PATCH] drm/i915/display: Go softly softly on initial modeset failure

2020-12-10 Thread Chris Wilson
Reduce the module/device probe error into a mere debug to hide issues where the initial modeset is failing (after lies told by hw probe) and the system hangs with a livelock in cleaning up the failed commit. Reported-by: H.J. Lu Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=210619 Fixes:

[Intel-gfx] ✗ Fi.CI.DOCS: warning for drm: Extract DPCD backlight helpers from i915, add support in nouveau (rev3)

2020-12-10 Thread Patchwork
== Series Details == Series: drm: Extract DPCD backlight helpers from i915, add support in nouveau (rev3) URL : https://patchwork.freedesktop.org/series/84754/ State : warning == Summary == $ make htmldocs 2>&1 > /dev/null | grep i915 Error: Cannot open file

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm: Extract DPCD backlight helpers from i915, add support in nouveau (rev3)

2020-12-10 Thread Patchwork
== Series Details == Series: drm: Extract DPCD backlight helpers from i915, add support in nouveau (rev3) URL : https://patchwork.freedesktop.org/series/84754/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm: Extract DPCD backlight helpers from i915, add support in nouveau (rev3)

2020-12-10 Thread Patchwork
== Series Details == Series: drm: Extract DPCD backlight helpers from i915, add support in nouveau (rev3) URL : https://patchwork.freedesktop.org/series/84754/ State : warning == Summary == $ dim checkpatch origin/drm-tip cfc42e455a86 drm/nouveau/kms/nv40-/backlight: Assign prop type once

Re: [Intel-gfx] [patch 19/30] PCI: mobiveil: Use irq_data_get_irq_chip_data()

2020-12-10 Thread Rob Herring
On Thu, Dec 10, 2020 at 1:42 PM Thomas Gleixner wrote: > > Going through a full irq descriptor lookup instead of just using the proper > helper function which provides direct access is suboptimal. > > In fact it _is_ wrong because the chip callback needs to get the chip data > which is relevant

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gt: Split logical ring contexts from execlist submission (rev2)

2020-12-10 Thread Patchwork
== Series Details == Series: drm/i915/gt: Split logical ring contexts from execlist submission (rev2) URL : https://patchwork.freedesktop.org/series/84752/ State : success == Summary == CI Bug Log - changes from CI_DRM_9473 -> Patchwork_19116

Re: [Intel-gfx] [patch 18/30] PCI: xilinx-nwl: Use irq_data_get_irq_chip_data()

2020-12-10 Thread Rob Herring
On Thu, Dec 10, 2020 at 1:42 PM Thomas Gleixner wrote: > > Going through a full irq descriptor lookup instead of just using the proper > helper function which provides direct access is suboptimal. > > In fact it _is_ wrong because the chip callback needs to get the chip data > which is relevant

[Intel-gfx] [RFC-v6 06/21] drm/i915/pxp: Enable PXP irq worker and callback stub

2020-12-10 Thread Huang, Sean Z
Create the irq worker that serves as callback handler, those callback stubs should be called while the hardware key teardown occurs. Signed-off-by: Huang, Sean Z --- drivers/gpu/drm/i915/gt/intel_gt_irq.c | 4 + drivers/gpu/drm/i915/i915_reg.h | 3 +-

[Intel-gfx] [RFC-v6 03/21] drm/i915/pxp: Implement funcs to create the TEE channel

2020-12-10 Thread Huang, Sean Z
Implement the funcs to create the TEE channel, so kernel can send the TEE commands directly to TEE for creating the arbitrary (defualt) session. Signed-off-by: Huang, Sean Z --- drivers/gpu/drm/i915/Makefile| 3 +- drivers/gpu/drm/i915/i915_drv.c | 1 +

[Intel-gfx] [RFC-v6 08/21] drm/i915/pxp: Enable PXP power management

2020-12-10 Thread Huang, Sean Z
During the power event S3+ sleep/resume, hardware will lose all the encryption keys for every hardware session, even though the software session state was marked as alive after resume. So to handle such case, PXP should terminate all the hardware sessions and cleanup all the software states after

[Intel-gfx] [RFC-v6 15/21] drm/i915/pxp: Implement ioctl action to set session in play

2020-12-10 Thread Huang, Sean Z
With this ioctl action, userspace driver can set the session in state "session in play", after dirver reserved the session slot/id from kernel PXP, and sent the TEE commands to activate the corresponding hardware session. Session state "session in play" means this session is ready for secure

[Intel-gfx] [RFC-v6 16/21] drm/i915/pxp: Implement ioctl action to terminate the session

2020-12-10 Thread Huang, Sean Z
Implement the PXP ioctl action to allow userspace driver to terminate the hardware session and cleanup its software session state. PXP sends the session termination command to GPU once receves this ioctl action. Signed-off-by: Huang, Sean Z --- drivers/gpu/drm/i915/pxp/intel_pxp.c | 10 +++

[Intel-gfx] [RFC-v6 10/21] mei: pxp: export pavp client to me client bus

2020-12-10 Thread Huang, Sean Z
From: Vitaly Lubart Export PAVP client to work with i915_cp driver, for binding it uses kernel component framework. Signed-off-by: Vitaly Lubart Signed-off-by: Tomas Winkler --- drivers/misc/mei/Kconfig | 2 + drivers/misc/mei/Makefile | 1 + drivers/misc/mei/pxp/Kconfig |

[Intel-gfx] [RFC-v6 17/21] drm/i915/pxp: Implement ioctl action to send TEE commands

2020-12-10 Thread Huang, Sean Z
Implement the ioctl action to allow userspace driver sends TEE commands via PXP ioctl, instead of TEE iotcl. So we can centralize those protection operations at PXP. Signed-off-by: Huang, Sean Z --- drivers/gpu/drm/i915/pxp/intel_pxp.c | 48 +---

[Intel-gfx] [RFC-v6 20/21] drm/i915/pxp: Add PXP-related registers into allowlist

2020-12-10 Thread Huang, Sean Z
Add several PXP-related reg into allowlist to allow user space driver to read the those register values. Signed-off-by: Huang, Sean Z --- drivers/gpu/drm/i915/i915_reg.h | 6 drivers/gpu/drm/i915/intel_uncore.c | 50 - 2 files changed, 41 insertions(+), 15

[Intel-gfx] [RFC-v6 07/21] drm/i915/pxp: Destroy arb session upon teardown

2020-12-10 Thread Huang, Sean Z
Teardown is triggered when the display topology changes and no long meets the secure playback requirement, and hardware trashes all the encryption keys for display. So as a result, PXP should handle such case and terminate the type0 sessions, which including arb session Signed-off-by: Huang, Sean

[Intel-gfx] [RFC-v6 01/21] drm/i915/pxp: Introduce Intel PXP component

2020-12-10 Thread Huang, Sean Z
PXP (Protected Xe Path) is an i915 componment, available on GEN12+, that helps to establish the hardware protected session and manage the status of the alive software session, as well as its life cycle. This patch series is to allow the kernel space to create and manage a single hardware session

[Intel-gfx] [RFC-v6 21/21] drm/i915/pxp: Enable the PXP ioctl for protected session

2020-12-10 Thread Huang, Sean Z
In the previous commits, we have implemented the PXP ioctl functions. Now we enable those handlers and expose them as PXP ioctl, so allow the userspace driver can establish, set, or destory the protected session via this ioctl. Signed-off-by: Huang, Sean Z --- drivers/gpu/drm/i915/i915_drv.c

[Intel-gfx] [RFC-v6 05/21] drm/i915/pxp: Func to send hardware session termination

2020-12-10 Thread Huang, Sean Z
Implement the functions to allow PXP to send a GPU command, in order to terminate the hardware session, so hardware can recycle this session slot for the next usage. Signed-off-by: Huang, Sean Z --- drivers/gpu/drm/i915/Makefile| 1 + drivers/gpu/drm/i915/pxp/intel_pxp_cmd.c | 156

[Intel-gfx] [RFC-v6 14/21] drm/i915/pxp: Implement ioctl action to reserve session slots

2020-12-10 Thread Huang, Sean Z
With this ioctl action, userspace driver can reserve one or multiple session slot/id assigned by kernel PXP, as the first step of PXP session establishment flow. The session info is stored in the session list structure. Signed-off-by: Huang, Sean Z --- drivers/gpu/drm/i915/Makefile

[Intel-gfx] [RFC-v6 09/21] drm/i915/pxp: Expose session state for display protection flip

2020-12-10 Thread Huang, Sean Z
Implement the intel_pxp_gem_object_status() to allow i915 display querying the current PXP session state. In the design, display should not perform protection flip on the protected buffers if there is no PXP session alive. Signed-off-by: Huang, Sean Z --- drivers/gpu/drm/i915/pxp/intel_pxp.c |

[Intel-gfx] [RFC-v6 02/21] drm/i915/pxp: set KCR reg init during the boot time

2020-12-10 Thread Huang, Sean Z
Set the KCR init during the boot time, which is required by hardware, to allow us doing further protection operation such as sending commands to GPU or TEE. Signed-off-by: Huang, Sean Z --- drivers/gpu/drm/i915/pxp/intel_pxp.c | 8 1 file changed, 8 insertions(+) diff --git

[Intel-gfx] [RFC-v6 00/21] Introduce Intel PXP component - Mesa single session

2020-12-10 Thread Huang, Sean Z
PXP (Protected Xe Path) is an i915 componment, available on GEN12+ that helps to establish the hardware protected session and manage the status of the alive software session, as well as its life cycle. [commit #1 - #13] This patch series is to allow the kernel space to create and manage a single

[Intel-gfx] [RFC-v6 19/21] drm/i915/pxp: Termiante the session upon app crash

2020-12-10 Thread Huang, Sean Z
PXP should terminate the hardware session and cleanup the software state gracefully when the application has established the protection session, but doesn't close the session correctly due to some cases like application crash. Signed-off-by: Huang, Sean Z --- drivers/gpu/drm/i915/i915_drv.c

[Intel-gfx] [RFC-v6 13/21] drm/i915/pxp: Add plane decryption support

2020-12-10 Thread Huang, Sean Z
From: Anshuman Gupta Add support to enable/disable PLANE_SURF Decryption Request bit. It requires only to enable plane decryption support when following condition met. 1. PAVP session is enabled. 2. Buffer object is protected. v2: - Rebased to libva_cp-drm-tip_tgl_cp tree. - Used gen fb obj

[Intel-gfx] [RFC-v6 18/21] drm/i915/pxp: Implement ioctl action to query PXP tag

2020-12-10 Thread Huang, Sean Z
Enable the PXP ioctl action to allow userspace driver to query the PXP tag, which is a 32-bit bitwise value indicating the current session info, including protection type, session id, and whether the session is enabled. Signed-off-by: Huang, Sean Z --- drivers/gpu/drm/i915/pxp/intel_pxp.c

[Intel-gfx] [RFC-v6 12/21] drm/i915/pxp: User interface for Protected buffer

2020-12-10 Thread Huang, Sean Z
From: Bommu Krishnaiah This api allow user mode to create Protected buffer and context creation. Signed-off-by: Bommu Krishnaiah Cc: Telukuntla Sreedhar Cc: Kondapally Kalyan Cc: Gupta Anshuman Cc: Huang Sean Z --- drivers/gpu/drm/i915/gem/i915_gem_context.c | 15 ++--

[Intel-gfx] [RFC-v6 04/21] drm/i915/pxp: Create the arbitrary session after boot

2020-12-10 Thread Huang, Sean Z
Create the arbitrary session, with the fixed session id 0xf, after system boot, for the case that application allocates the protected buffer without establishing any protection session. Because the hardware requires at least one alive session for protected buffer creation. This arbitrary session

[Intel-gfx] [RFC-v6 11/21] drm/i915/uapi: introduce drm_i915_gem_create_ext

2020-12-10 Thread Huang, Sean Z
From: Bommu Krishnaiah Same old gem_create but with now with extensions support. This is needed to support various upcoming usecases. For now we use the extensions mechanism to support PAVP. Signed-off-by: Bommu Krishnaiah Signed-off-by: Matthew Auld Cc: Joonas Lahtinen

[Intel-gfx] ✗ Fi.CI.DOCS: warning for drm/i915/gt: Split logical ring contexts from execlist submission (rev2)

2020-12-10 Thread Patchwork
== Series Details == Series: drm/i915/gt: Split logical ring contexts from execlist submission (rev2) URL : https://patchwork.freedesktop.org/series/84752/ State : warning == Summary == $ make htmldocs 2>&1 > /dev/null | grep i915 ./drivers/gpu/drm/i915/gt/intel_lrc.c:1: warning: 'Logical

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Add support for Intel's eDP backlight controls (rev4)

2020-12-10 Thread Patchwork
== Series Details == Series: drm/i915: Add support for Intel's eDP backlight controls (rev4) URL : https://patchwork.freedesktop.org/series/81702/ State : success == Summary == CI Bug Log - changes from CI_DRM_9472_full -> Patchwork_19113_full

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/gt: Split logical ring contexts from execlist submission (rev2)

2020-12-10 Thread Patchwork
== Series Details == Series: drm/i915/gt: Split logical ring contexts from execlist submission (rev2) URL : https://patchwork.freedesktop.org/series/84752/ State : warning == Summary == $ dim checkpatch origin/drm-tip 454579934182 drm/i915/gt: Split logical ring contexts from execlist

Re: [Intel-gfx] [PATCH 19/21] drm/i915/gt: Use indices for writing into relative timelines

2020-12-10 Thread Matthew Brost
On Thu, Dec 10, 2020 at 09:05:44PM +, Chris Wilson wrote: > Quoting Matthew Brost (2020-12-10 19:16:44) > > On Thu, Dec 10, 2020 at 08:02:38AM +, Chris Wilson wrote: > > > Relative timelines are relative to either the global or per-process > > > HWSP, and so we can replace the absolute

Re: [Intel-gfx] [PATCH 17/21] drm/i915/gt: Track timeline GGTT offset separately from subpage offset

2020-12-10 Thread Matthew Brost
On Thu, Dec 10, 2020 at 08:02:36AM +, Chris Wilson wrote: > Currently we know that the timeline status page is at most a page in > size, and so we can preserve the lower 12bits of the offset when > relocating the status page in the GGTT. If we want to use a larger > object, such as the context

Re: [Intel-gfx] [PATCH 21/21] drm/i915/gt: Use ppHWSP for unshared non-semaphore related timelines

2020-12-10 Thread Matthew Brost
On Thu, Dec 10, 2020 at 08:02:40AM +, Chris Wilson wrote: > When we are not using semaphores with a context/engine, we can simply > reuse the same seqno location across wraps, but we still require each > timeline to have its own address. For LRC submission, each context is > prefixed by a

Re: [Intel-gfx] [PATCH 18/21] drm/i915/gt: Add timeline "mode"

2020-12-10 Thread Matthew Brost
On Thu, Dec 10, 2020 at 09:00:53PM +, Chris Wilson wrote: > Quoting Matthew Brost (2020-12-10 19:28:06) > > On Thu, Dec 10, 2020 at 08:02:37AM +, Chris Wilson wrote: > > > diff --git a/drivers/gpu/drm/i915/gt/intel_timeline_types.h > > > b/drivers/gpu/drm/i915/gt/intel_timeline_types.h >

Re: [Intel-gfx] [PATCH 19/21] drm/i915/gt: Use indices for writing into relative timelines

2020-12-10 Thread Chris Wilson
Quoting Matthew Brost (2020-12-10 19:16:44) > On Thu, Dec 10, 2020 at 08:02:38AM +, Chris Wilson wrote: > > Relative timelines are relative to either the global or per-process > > HWSP, and so we can replace the absolute addressing with store-index > > variants for position invariance. > > >

Re: [Intel-gfx] [patch 17/30] NTB/msi: Use irq_has_action()

2020-12-10 Thread Logan Gunthorpe
On 2020-12-10 12:25 p.m., Thomas Gleixner wrote: > Use the proper core function. > > Signed-off-by: Thomas Gleixner > Cc: Jon Mason > Cc: Dave Jiang > Cc: Allen Hubbe > Cc: linux-...@googlegroups.com Looks good to me. Reviewed-by: Logan Gunthorpe > --- > drivers/ntb/msi.c |4 +---

Re: [Intel-gfx] [PATCH 18/21] drm/i915/gt: Add timeline "mode"

2020-12-10 Thread Chris Wilson
Quoting Matthew Brost (2020-12-10 19:28:06) > On Thu, Dec 10, 2020 at 08:02:37AM +, Chris Wilson wrote: > > diff --git a/drivers/gpu/drm/i915/gt/intel_timeline_types.h > > b/drivers/gpu/drm/i915/gt/intel_timeline_types.h > > index f187c5aac11c..32c51425a0c4 100644 > > ---

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/pmu: Stop peeking at kernel internals for counting interrupts

2020-12-10 Thread Patchwork
== Series Details == Series: drm/i915/pmu: Stop peeking at kernel internals for counting interrupts URL : https://patchwork.freedesktop.org/series/84800/ State : failure == Summary == CI Bug Log - changes from CI_DRM_9472 -> Patchwork_19114

[Intel-gfx] ✗ Fi.CI.BUILD: failure for genirq: Treewide hunt for irq descriptor abuse and assorted fixes

2020-12-10 Thread Patchwork
== Series Details == Series: genirq: Treewide hunt for irq descriptor abuse and assorted fixes URL : https://patchwork.freedesktop.org/series/84805/ State : failure == Summary == Applying: genirq: Move irq_has_action() into core code Applying: genirq: Move status flag checks to core Applying:

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm: Extract DPCD backlight helpers from i915, add support in nouveau (rev2)

2020-12-10 Thread Patchwork
== Series Details == Series: drm: Extract DPCD backlight helpers from i915, add support in nouveau (rev2) URL : https://patchwork.freedesktop.org/series/84754/ State : failure == Summary == CI Bug Log - changes from CI_DRM_9471_full -> Patchwork_19112_full

[Intel-gfx] ✗ Fi.CI.DOCS: warning for drm/i915/pmu: Stop peeking at kernel internals for counting interrupts

2020-12-10 Thread Patchwork
== Series Details == Series: drm/i915/pmu: Stop peeking at kernel internals for counting interrupts URL : https://patchwork.freedesktop.org/series/84800/ State : warning == Summary == $ make htmldocs 2>&1 > /dev/null | grep i915 Error: Cannot open file ./drivers/gpu/drm/i915/gt/intel_lrc.c

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Add support for Intel's eDP backlight controls (rev4)

2020-12-10 Thread Patchwork
== Series Details == Series: drm/i915: Add support for Intel's eDP backlight controls (rev4) URL : https://patchwork.freedesktop.org/series/81702/ State : success == Summary == CI Bug Log - changes from CI_DRM_9472 -> Patchwork_19113

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Correct location of Wa_1408615072 (rev2)

2020-12-10 Thread Patchwork
== Series Details == Series: drm/i915: Correct location of Wa_1408615072 (rev2) URL : https://patchwork.freedesktop.org/series/79370/ State : success == Summary == CI Bug Log - changes from CI_DRM_9471_full -> Patchwork_19111_full Summary

[Intel-gfx] ✗ Fi.CI.DOCS: warning for drm/i915: Add support for Intel's eDP backlight controls (rev4)

2020-12-10 Thread Patchwork
== Series Details == Series: drm/i915: Add support for Intel's eDP backlight controls (rev4) URL : https://patchwork.freedesktop.org/series/81702/ State : warning == Summary == $ make htmldocs 2>&1 > /dev/null | grep i915 Error: Cannot open file ./drivers/gpu/drm/i915/gt/intel_lrc.c WARNING:

  1   2   3   >