[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/2] drm/i915/dmabuf: don't trust the dma_buf->size

2021-01-22 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/dmabuf: don't trust the dma_buf->size URL : https://patchwork.freedesktop.org/series/86191/ State : success == Summary == CI Bug Log - changes from CI_DRM_9670_full -> Patchwork_19465_full

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/dmabuf: don't trust the dma_buf->size

2021-01-22 Thread Patchwork
== Series Details == Series: drm/i915/dmabuf: don't trust the dma_buf->size URL : https://patchwork.freedesktop.org/series/86190/ State : success == Summary == CI Bug Log - changes from CI_DRM_9670_full -> Patchwork_19464_full Summary

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/buddy: document the unused header bits

2021-01-22 Thread Patchwork
== Series Details == Series: drm/i915/buddy: document the unused header bits URL : https://patchwork.freedesktop.org/series/86189/ State : success == Summary == CI Bug Log - changes from CI_DRM_9670_full -> Patchwork_19463_full Summary

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [01/10] drm/i915/gt: SPDX cleanup

2021-01-22 Thread Patchwork
== Series Details == Series: series starting with [01/10] drm/i915/gt: SPDX cleanup URL : https://patchwork.freedesktop.org/series/86185/ State : success == Summary == CI Bug Log - changes from CI_DRM_9670_full -> Patchwork_19461_full

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [CI,1/9] drm/i915/gt: Show the per-engine runtime in sysfs

2021-01-22 Thread Patchwork
== Series Details == Series: series starting with [CI,1/9] drm/i915/gt: Show the per-engine runtime in sysfs URL : https://patchwork.freedesktop.org/series/86180/ State : success == Summary == CI Bug Log - changes from CI_DRM_9670_full -> Patchwork_19458_full

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [CI,v5,01/18] drm/i915/display/vrr: Create VRR file and add VRR capability check

2021-01-22 Thread Patchwork
== Series Details == Series: series starting with [CI,v5,01/18] drm/i915/display/vrr: Create VRR file and add VRR capability check URL : https://patchwork.freedesktop.org/series/86200/ State : success == Summary == CI Bug Log - changes from CI_DRM_9671 -> Patchwork_19471

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/selftests: Check for engine-reset errors in the middle of workarounds

2021-01-22 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Check for engine-reset errors in the middle of workarounds URL : https://patchwork.freedesktop.org/series/86179/ State : failure == Summary == CI Bug Log - changes from CI_DRM_9670_full -> Patchwork_19457_full

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [v1,1/2] drm/gma500: Convert to use new SCU IPC API

2021-01-22 Thread Patchwork
== Series Details == Series: series starting with [v1,1/2] drm/gma500: Convert to use new SCU IPC API URL : https://patchwork.freedesktop.org/series/86178/ State : success == Summary == CI Bug Log - changes from CI_DRM_9670_full -> Patchwork_19456_full

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [CI,v5,01/18] drm/i915/display/vrr: Create VRR file and add VRR capability check

2021-01-22 Thread Patchwork
== Series Details == Series: series starting with [CI,v5,01/18] drm/i915/display/vrr: Create VRR file and add VRR capability check URL : https://patchwork.freedesktop.org/series/86200/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used,

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [CI,v5,01/18] drm/i915/display/vrr: Create VRR file and add VRR capability check

2021-01-22 Thread Patchwork
== Series Details == Series: series starting with [CI,v5,01/18] drm/i915/display/vrr: Create VRR file and add VRR capability check URL : https://patchwork.freedesktop.org/series/86200/ State : warning == Summary == $ dim checkpatch origin/drm-tip aa71ea851089 drm/i915/display/vrr: Create VRR

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Start disabling pread/pwrite ioctl's for future platforms

2021-01-22 Thread Patchwork
== Series Details == Series: drm/i915: Start disabling pread/pwrite ioctl's for future platforms URL : https://patchwork.freedesktop.org/series/86199/ State : success == Summary == CI Bug Log - changes from CI_DRM_9671 -> Patchwork_19470

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/gt: Move the defer_request waiter active assertion (rev2)

2021-01-22 Thread Patchwork
== Series Details == Series: drm/i915/gt: Move the defer_request waiter active assertion (rev2) URL : https://patchwork.freedesktop.org/series/86176/ State : success == Summary == CI Bug Log - changes from CI_DRM_9670_full -> Patchwork_19455_full

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Remainder of dbuf state stuff (rev3)

2021-01-22 Thread Patchwork
== Series Details == Series: drm/i915: Remainder of dbuf state stuff (rev3) URL : https://patchwork.freedesktop.org/series/83114/ State : success == Summary == CI Bug Log - changes from CI_DRM_9671 -> Patchwork_19469 Summary ---

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: Remainder of dbuf state stuff (rev3)

2021-01-22 Thread Patchwork
== Series Details == Series: drm/i915: Remainder of dbuf state stuff (rev3) URL : https://patchwork.freedesktop.org/series/83114/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. -

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Remainder of dbuf state stuff (rev3)

2021-01-22 Thread Patchwork
== Series Details == Series: drm/i915: Remainder of dbuf state stuff (rev3) URL : https://patchwork.freedesktop.org/series/83114/ State : warning == Summary == $ dim checkpatch origin/drm-tip f49e0164bdf9 drm/i915: Extract intel_crtc_ddb_weight() f8f4731253f8 drm/i915: Pass the crtc to

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [CI,1/3] drm/i915: stop registering if drm_dev_register() fails

2021-01-22 Thread Patchwork
== Series Details == Series: series starting with [CI,1/3] drm/i915: stop registering if drm_dev_register() fails URL : https://patchwork.freedesktop.org/series/86196/ State : success == Summary == CI Bug Log - changes from CI_DRM_9670 -> Patchwork_19468

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [CI,01/10] drm/i915/gt: SPDX cleanup

2021-01-22 Thread Patchwork
== Series Details == Series: series starting with [CI,01/10] drm/i915/gt: SPDX cleanup URL : https://patchwork.freedesktop.org/series/86193/ State : success == Summary == CI Bug Log - changes from CI_DRM_9670 -> Patchwork_19467 Summary

[Intel-gfx] [CI v5 03/18] drm/i915: Store framestart_delay in dev_priv

2021-01-22 Thread Manasi Navare
From: Ville Syrjälä The vrr calculations will need to know the framestart delay value we use. Currently we program it always to zero, but should that change we probably want to stash it somewhere. Could stick it into the crtc_state I suppose, but since we never change it let's just stuff it

[Intel-gfx] [CI v5 16/18] drm/i915: Add vrr state dump

2021-01-22 Thread Manasi Navare
From: Ville Syrjälä Dump vrr state alongside everything else. Signed-off-by: Ville Syrjälä Reviewed-by: Manasi Navare --- drivers/gpu/drm/i915/display/intel_display.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/gpu/drm/i915/display/intel_display.c

[Intel-gfx] [CI v5 15/18] drm/i915/display: Helpers for VRR vblank min and max start

2021-01-22 Thread Manasi Navare
From: Ville Syrjälä With VRR the earliest the registers can get latched are at flipline decision boundary, calculate that as vrr_vmin_vblank_start() and the latest the regsiters can get latched are vmax decision boundary calculate that as vrr_vmax_vblank_start() v2: * Remove TODO and adjust

[Intel-gfx] [CI v5 12/18] drm/i915/display/vrr: Disable VRR in modeset disable path

2021-01-22 Thread Manasi Navare
This patch disables the VRR enable and VRR PUSH bits in the HW during commit modeset disable sequence. Thsi disable will happen when the port is disabled or when the userspace sets VRR prop to false and requests to disable VRR. v2: * Use intel_de_rmw (Jani N) v3: * Remove rmw (Ville) Cc: Ville

[Intel-gfx] [CI v5 10/18] drm/i915/display/vrr: Configure and enable VRR in modeset enable

2021-01-22 Thread Manasi Navare
This patch computes the VRR parameters from VRR crtc states and configures them in VRR registers during CRTC enable in the modeset enable sequence. v2: * Remove initialization to 0 (Jani N) * Use correct pipe %c (Jani N) v3: * Remove debug prints (Ville) * Use cpu_trans instead of pipe for

[Intel-gfx] [CI v5 17/18] drm/i915: Fix vblank timestamps with VRR

2021-01-22 Thread Manasi Navare
From: Ville Syrjälä To get sensible vblank timestamping behaviour we need to feed the vmax based timings to the vblank code, otherwise it'll chop off the scanline counter when it exceeds the minumum vtotal. Additionally with VRR we have three cases to consider when we generate the vblank

[Intel-gfx] [CI v5 09/18] drm/i915: Rename VRR_CTL reg fields

2021-01-22 Thread Manasi Navare
From: Ville Syrjälä Give the pipeline full line count bits more descriptive names Signed-off-by: Ville Syrjälä Signed-off-by: Manasi Navare Reviewed-by: Manasi Navare --- drivers/gpu/drm/i915/i915_reg.h | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git

[Intel-gfx] [CI v5 04/18] drm/i915: Extract intel_mode_vblank_start()

2021-01-22 Thread Manasi Navare
From: Ville Syrjälä We want to calculate the vblank_start for vblank evasion differently for vrr. To make that nicer lets first extract the current non-vrr case to a helper. Signed-off-by: Ville Syrjälä Reviewed-by: Manasi Navare --- drivers/gpu/drm/i915/display/intel_sprite.c | 14

[Intel-gfx] [CI v5 11/18] drm/i915/display/vrr: Send VRR push to flip the frame

2021-01-22 Thread Manasi Navare
VRR achieves vblank stretching using the HW PUSH functionality. So once the VRR is enabled during modeset then for each flip request from userspace, in the atomic tail pipe_update_end() we need to set the VRR push bit in HW for it to terminate the vblank at configured flipline or anytime after

[Intel-gfx] [CI v5 14/18] drm/i915/display: Add HW state readout for VRR

2021-01-22 Thread Manasi Navare
This functions gets the VRR config from the VRR registers to match the crtc state variables for VRR. v2: * Rebase (Manasi) * Use HAS_VRR (Jani N) v3: * Get pipeline_full, flipline (Ville) Cc: Jani Nikula Signed-off-by: Manasi Navare Reviewed-by: Ville Syrjälä ---

[Intel-gfx] [CI v5 07/18] drm/i915/display/dp: Do not enable PSR if VRR is enabled

2021-01-22 Thread Manasi Navare
Even though our HW supports PSR + VRR, the available panels do not work reliably with PSR and VRR together. So if user requested VRR and is supported by HW enable that and do not enable PSR in that case. Cc: Ville Syrjälä Cc: Gwan-gyeong Mun Cc: Imre Deak Signed-off-by: Manasi Navare

[Intel-gfx] [CI v5 18/18] drm/i915: Fix vblank evasion with vrr

2021-01-22 Thread Manasi Navare
From: Ville Syrjälä With vrr enabled the hardware no longer latches the registers automagically at vblank start. The point at which it will do the latching even when no push has been sent is the vmax decision boundary. That is the thing we need to evade to avoid our register latching to get

[Intel-gfx] [CI v5 13/18] drm/i915/display/vrr: Set IGNORE_MSA_PAR state in DP Sink

2021-01-22 Thread Manasi Navare
If VRR is enabled, the sink should ignore MSA parameters and regenerate incoming video stream without depending on these parameters. Hence set the MSA_TIMING_PAR_IGNORE_EN bit if VRR is enabled. Reset this bit on VRR disable. v2: * ACtually set the dpcd msa ignore bit (Ville) Cc: Ville Syrjälä

[Intel-gfx] [CI v5 01/18] drm/i915/display/vrr: Create VRR file and add VRR capability check

2021-01-22 Thread Manasi Navare
We create a new file for all VRR related helpers. Also add a function to check vrr capability based on platform support, DPCD bits and EDID monitor range. v2: * Remove author (Jani N) * Define HAS_VRR (Jani N) * Ensure intel_dp can be obtained from conn (Jani N) Cc: Ville Syrjälä Cc: Jani

[Intel-gfx] [CI v5 08/18] drm/i915/display: VRR + DRRS cannot be enabled together

2021-01-22 Thread Manasi Navare
From: Ville Syrjälä If VRR is enabled, DRRS cannot be enabled, so make this check in atomic check. Signed-off-by: Ville Syrjälä Reviewed-by: Manasi Navare --- drivers/gpu/drm/i915/display/intel_dp.c | 3 +++ 1 file changed, 3 insertions(+) diff --git

[Intel-gfx] [CI v5 02/18] drm/i915/display/dp: Attach and set drm connector VRR property

2021-01-22 Thread Manasi Navare
From: Aditya Swarup This function sets the VRR property for connector based on the platform support, EDID monitor range and DP sink DPCD capability of outputing video without msa timing information. v8: * Use HAS_VRR, remove drm_conn declaration (Jani N) * Fix typos in Comment (Jani N) v7: *

[Intel-gfx] [CI v5 05/18] drm/i915: Extract intel_crtc_scanlines_since_frame_timestamp()

2021-01-22 Thread Manasi Navare
From: Ville Syrjälä Extract intel_crtc_scanlines_since_frame_timestamp() from __intel_get_crtc_scanline_from_timestamp(). We'll reuse this for VRR vblank timestamps. Signed-off-by: Ville Syrjälä Reviewed-by: Manasi Navare --- drivers/gpu/drm/i915/i915_irq.c | 38

[Intel-gfx] [CI v5 06/18] drm/i915/display/dp: Compute VRR state in atomic_check

2021-01-22 Thread Manasi Navare
This forces a complete modeset if vrr drm crtc state goes from enabled to disabled and vice versa. This patch also computes vrr state variables from the mode timings and based on the vrr property set by userspace as well as hardware's vrr capability. v2: *Rebase v3: * Vmin = max (vtotal, vmin)

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [CI,01/10] drm/i915/gt: SPDX cleanup

2021-01-22 Thread Patchwork
== Series Details == Series: series starting with [CI,01/10] drm/i915/gt: SPDX cleanup URL : https://patchwork.freedesktop.org/series/86193/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. -

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915/dmabuf: don't trust the dma_buf->size

2021-01-22 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/dmabuf: don't trust the dma_buf->size URL : https://patchwork.freedesktop.org/series/86192/ State : success == Summary == CI Bug Log - changes from CI_DRM_9670 -> Patchwork_19466

[Intel-gfx] [PATCH 1/1] drm/i915: Start disabling pread/pwrite ioctl's for future platforms

2021-01-22 Thread Ashutosh Dixit
The guidance for i915 at this time is to start phasing out pread/pwrite ioctl's, the rationale being (a) the functionality can be done entirely in userspace with a combination of mmap + memcpy, and (b) no existing user mode clients actually use the pread/pwrite interface. In this patch we disable

[Intel-gfx] [PATCH 0/1] drm/i915: Start disabling pread/pwrite ioctl's for future platforms

2021-01-22 Thread Ashutosh Dixit
The guidance for i915 at this time is to start phasing out pread/pwrite ioctl's, the rationale being (a) the functionality can be done entirely in userspace with a combination of mmap + memcpy, and (b) no existing user mode clients actually use the pread/pwrite interface. In this patch we disable

[Intel-gfx] [PATCH i-g-t] i915: Exercise sysfs client properties

2021-01-22 Thread Chris Wilson
We store every client name, pid and runtime under sysfs. Better check that matches with the actual client. Signed-off-by: Chris Wilson --- lib/igt_sysfs.c| 36 +++ lib/igt_sysfs.h| 3 + tests/Makefile.sources | 3 + tests/i915/sysfs_clients.c | 450

Re: [Intel-gfx] [PATCH] drm/i915/uc: Use platform specific defaults for GuC/HuC enabling

2021-01-22 Thread Daniele Ceraolo Spurio
On 1/20/2021 12:31 PM, john.c.harri...@intel.com wrote: From: John Harrison The meaning of 'default' for the enable_guc module parameter has been updated to accurately reflect what is supported on current platforms. So start using the defaults instead of forcing everything off. Worth

[Intel-gfx] [PATCH i-g-t] i915: Exercise sysfs client properties

2021-01-22 Thread Chris Wilson
We store every client name, pid and runtime under sysfs. Better check that matches with the actual client. Signed-off-by: Chris Wilson --- lib/igt_sysfs.c| 36 lib/igt_sysfs.h| 3 + tests/Makefile.sources | 3 + tests/i915/sysfs_clients.c | 361

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915/dmabuf: don't trust the dma_buf->size

2021-01-22 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/dmabuf: don't trust the dma_buf->size URL : https://patchwork.freedesktop.org/series/86191/ State : success == Summary == CI Bug Log - changes from CI_DRM_9670 -> Patchwork_19465

[Intel-gfx] [PATCH v3 7/8] drm/i915: Encapsulate dbuf state handling harder

2021-01-22 Thread Ville Syrjala
From: Ville Syrjälä In order to make the dbuf state computation less fragile let's make it stand on its own feet by not requiring someone to peek into a crystall ball ahead of time to figure out which pipes need to be added to the state under which potential future conditions. Instead we compute

[Intel-gfx] [PATCH v3 8/8] drm/i915: Do a bit more initial readout for dbuf

2021-01-22 Thread Ville Syrjala
From: Ville Syrjälä Readout the dbuf related stuff during driver init/resume and stick it into our dbuf state. v2: Keep crtc_state->wm.skl.ddb Reviewed-by: Stanislav Lisovskiy Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_display.c | 4 --

[Intel-gfx] [PATCH v3 6/8] drm/i915: Extract intel_crtc_dbuf_weights()

2021-01-22 Thread Ville Syrjala
From: Ville Syrjälä Extract the code to calculate the weights used to chunk up the dbuf between pipes. There's still extra stuff in there that shouldn't be there and must be moved out, but that requires a bit more state to be tracked in the dbuf state. v2: Keep crtc_state->wm.skl.ddb

[Intel-gfx] [PATCH v3 5/8] drm/i915: Add pipe ddb entries into the dbuf state

2021-01-22 Thread Ville Syrjala
From: Ville Syrjälä The dbuf state will be where we collect all the inter-pipe dbuf allocation stuff. Start by adding the actual per-pipe ddb entries there. Originally the plan was to move them there outright, but that no longer works as we're no longer guaranteed to have a dbuf state when it

[Intel-gfx] [PATCH v3 4/8] drm/i915: Introduce skl_ddb_entry_for_slices()

2021-01-22 Thread Ville Syrjala
From: Ville Syrjälä Generalize icl_get_first_dbuf_slice_offset() into something that just gives us the start+end of the dbuf chunk covered by the specified slices as a standard ddb entry. Initial idea was to use it during readout as well, but we shall see. Reviewed-by: Stanislav Lisovskiy

[Intel-gfx] [PATCH v3 3/8] drm/i915: Introduce intel_dbuf_slice_size()

2021-01-22 Thread Ville Syrjala
From: Ville Syrjälä Put the code into a function with a descriptive name. Also relocate the code a bit help future work. Reviewed-by: Stanislav Lisovskiy Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/intel_pm.c | 36 +++-- drivers/gpu/drm/i915/intel_pm.h |

[Intel-gfx] [PATCH v3 2/8] drm/i915: Pass the crtc to skl_compute_dbuf_slices()

2021-01-22 Thread Ville Syrjala
From: Ville Syrjälä skl_compute_dbuf_slices() has no use for the crtc state, so just pass the crtc itself. Reviewed-by: Stanislav Lisovskiy Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/intel_pm.c | 22 ++ 1 file changed, 10 insertions(+), 12 deletions(-) diff

[Intel-gfx] [PATCH v3 1/8] drm/i915: Extract intel_crtc_ddb_weight()

2021-01-22 Thread Ville Syrjala
From: Ville Syrjälä skl_ddb_get_pipe_allocation_limits() doesn't care how the weights for distributing the ddb are caclculated for each pipe. Put that calculation into a separate function so that such mundane details are hidden from view. v2: s/adjusted_mode/pipe_mode/ Reviewed-by: Stanislav

[Intel-gfx] [PATCH v3 0/8] drm/i915: Remainder of dbuf state stuff

2021-01-22 Thread Ville Syrjala
From: Ville Syrjälä GLK blew up in ci in the glk_force_audio_cdclk() path. The reason being some reordering in intel_atomic_check() so we're no longer guaranteed to have a dbuf_state when we commit crtcs. So I changed the approach slightly to keep duplicate pipe ddb allocations in the crtc state

[Intel-gfx] [CI 3/3] drm/i915/display: move register functions to display/

2021-01-22 Thread Lucas De Marchi
Now that all display-related functions are grouped in i915_driver_register(), move them to display/ so we reduce the amount of display calls from the rest of the driver. Signed-off-by: Lucas De Marchi Reviewed-by: Chris Wilson --- drivers/gpu/drm/i915/display/intel_display.c | 54

[Intel-gfx] [CI 2/3] drm/i915: group display-related register calls

2021-01-22 Thread Lucas De Marchi
intel_gt_driver_register() may be called earlier than intel_opregion_register() and acpi_video_register(), so move it up. intel_display_debugfs_register() may be called later, together with the other display-related initializations. There is a slight change in behavior that sysfs files will show

[Intel-gfx] [CI 1/3] drm/i915: stop registering if drm_dev_register() fails

2021-01-22 Thread Lucas De Marchi
If drm_dev_register() fails there is no reason to continue registering the driver and initializing. Signed-off-by: Lucas De Marchi Reviewed-by: Chris Wilson --- drivers/gpu/drm/i915/i915_drv.c | 20 +++- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/dmabuf: don't trust the dma_buf->size

2021-01-22 Thread Patchwork
== Series Details == Series: drm/i915/dmabuf: don't trust the dma_buf->size URL : https://patchwork.freedesktop.org/series/86190/ State : success == Summary == CI Bug Log - changes from CI_DRM_9670 -> Patchwork_19464 Summary ---

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Decrease number of subplatform bits

2021-01-22 Thread Lucas De Marchi
On Thu, Jan 21, 2021 at 04:19:36PM +, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Commit 6ce1c33d6c36 ("drm/i915: Kill INTEL_SUBPLATFORM_AML") removed the only platform which used bit 2 so could also decrease the INTEL_SUBPLATFORM_BITS definition. This is not a fixes material but still

Re: [Intel-gfx] [PATCH] drm/i915/gem: Allow importing of shmemfs objects into any device

2021-01-22 Thread Ruhl, Michael J
>-Original Message- >From: Intel-gfx On Behalf Of >Matthew Auld >Sent: Wednesday, January 20, 2021 12:46 PM >To: Chris Wilson >Cc: Intel Graphics Development ; Auld, >Matthew >Subject: Re: [Intel-gfx] [PATCH] drm/i915/gem: Allow importing of shmemfs >objects into any device > >On Wed,

[Intel-gfx] ✗ Fi.CI.BUILD: warning for drm/i915/buddy: document the unused header bits

2021-01-22 Thread Patchwork
== Series Details == Series: drm/i915/buddy: document the unused header bits URL : https://patchwork.freedesktop.org/series/86189/ State : warning == Summary == CALLscripts/checksyscalls.sh CALLscripts/atomic/check-atomics.sh CHK include/generated/compile.h CC [M]

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/buddy: document the unused header bits

2021-01-22 Thread Patchwork
== Series Details == Series: drm/i915/buddy: document the unused header bits URL : https://patchwork.freedesktop.org/series/86189/ State : success == Summary == CI Bug Log - changes from CI_DRM_9670 -> Patchwork_19463 Summary ---

[Intel-gfx] [CI 05/10] drm/i915/gt: Remove a bonus newline

2021-01-22 Thread Chris Wilson
Trailing newlines before closing the function are best forgotten, or else checkpatch moans. Signed-off-by: Chris Wilson Reviewed-by: Michal Wajdeczko --- drivers/gpu/drm/i915/gt/intel_gt_clock_utils.c | 1 - drivers/gpu/drm/i915/gt/intel_rc6.c| 1 - 2 files changed, 2 deletions(-)

[Intel-gfx] [CI 03/10] drm/i915/gt: Remove repeated words from comments

2021-01-22 Thread Chris Wilson
Checkpatch spotted a few repeated words in the comment, genuine mistakes. Signed-off-by: Chris Wilson Reviewed-by: Michal Wajdeczko --- drivers/gpu/drm/i915/gt/intel_execlists_submission.c | 2 +- drivers/gpu/drm/i915/gt/intel_ggtt.c | 2 +-

[Intel-gfx] [CI 04/10] drm/i915/gt: Fixup misaligned function parameters

2021-01-22 Thread Chris Wilson
Remember to align parameters to the '(', thanks checkpatch Signed-off-by: Chris Wilson Reviewed-by: Michal Wajdeczko --- drivers/gpu/drm/i915/gt/intel_execlists_submission.c | 4 ++-- drivers/gpu/drm/i915/gt/intel_workarounds.c | 3 +-- 2 files changed, 3 insertions(+), 4 deletions(-)

[Intel-gfx] [CI 07/10] drm/i915/gt: Insert spaces into GEN3_L3LOG_SIZE/4

2021-01-22 Thread Chris Wilson
Checkpatch wants spaces, let's give it some spaces. Signed-off-by: Chris Wilson Reviewed-by: Michal Wajdeczko --- drivers/gpu/drm/i915/gt/intel_ring_submission.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/gt/intel_ring_submission.c

[Intel-gfx] [CI 08/10] drm/i915/gt: Replace unnecessary ',' with '; '

2021-01-22 Thread Chris Wilson
Checkpatch spotted a couple of commas where we can use the more common ';', and so not worry about the subtle implications of sequence points. Signed-off-by: Chris Wilson Reviewed-by: Michal Wajdeczko --- drivers/gpu/drm/i915/gt/gen6_ppgtt.h| 4 ++--

[Intel-gfx] [CI 10/10] drm/i915/gt: Replace 'return' with a fall-through

2021-01-22 Thread Chris Wilson
Checkpatch worries that the 'return' before an else clause might be redundant. In this case, it is avoiding hitting the MISSING_CASE() warning. Let us appease checkpatch by falling through to the end of the function, which typically means that we then clean up the unused wa_list. Signed-off-by:

[Intel-gfx] [CI 02/10] drm/i915/gt: Add some missing blank lines after declaration

2021-01-22 Thread Chris Wilson
Trivial checkpatch cleanup. Signed-off-by: Chris Wilson Reviewed-by: Michal Wajdeczko --- drivers/gpu/drm/i915/gt/debugfs_gt.c | 1 + drivers/gpu/drm/i915/gt/gen8_ppgtt.c | 1 + drivers/gpu/drm/i915/gt/intel_ggtt_fencing.c | 3 +++ drivers/gpu/drm/i915/gt/intel_renderstate.c |

[Intel-gfx] [CI 09/10] drm/i915/gt: Add a space before '('

2021-01-22 Thread Chris Wilson
Checkpatch noticed a while(0) and complains about the lack of space. Signed-off-by: Chris Wilson Reviewed-by: Michal Wajdeczko --- drivers/gpu/drm/i915/gt/intel_renderstate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/gt/intel_renderstate.c

[Intel-gfx] [CI 06/10] drm/i915/gt: Wrap macro arg in ()

2021-01-22 Thread Chris Wilson
Checkpatch noticed that ppgtt->pd should have been (ppgtt)->pd to avoid issues with macros. Signed-off-by: Chris Wilson Reviewed-by: Michal Wajdeczko --- drivers/gpu/drm/i915/gt/intel_lrc_reg.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[Intel-gfx] [CI 01/10] drm/i915/gt: SPDX cleanup

2021-01-22 Thread Chris Wilson
Clean up the SPDX licence declarations to comply with checkpatch. Signed-off-by: Chris Wilson Reviewed-by: Michal Wajdeczko --- drivers/gpu/drm/i915/gt/debugfs_gt.c | 1 - drivers/gpu/drm/i915/gt/gen6_renderstate.c| 20 + drivers/gpu/drm/i915/gt/gen7_renderstate.c

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [01/10] drm/i915/gt: SPDX cleanup

2021-01-22 Thread Patchwork
== Series Details == Series: series starting with [01/10] drm/i915/gt: SPDX cleanup URL : https://patchwork.freedesktop.org/series/86185/ State : success == Summary == CI Bug Log - changes from CI_DRM_9670 -> Patchwork_19461 Summary

[Intel-gfx] ✗ Fi.CI.BUILD: failure for drm/i915/hdcp: Fix return of value in uninitialized variable ret

2021-01-22 Thread Patchwork
== Series Details == Series: drm/i915/hdcp: Fix return of value in uninitialized variable ret URL : https://patchwork.freedesktop.org/series/86186/ State : failure == Summary == Applying: drm/i915/hdcp: Fix return of value in uninitialized variable ret Using index info to reconstruct a base

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [01/10] drm/i915/gt: SPDX cleanup

2021-01-22 Thread Patchwork
== Series Details == Series: series starting with [01/10] drm/i915/gt: SPDX cleanup URL : https://patchwork.freedesktop.org/series/86185/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. -

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [01/10] drm/i915/gt: SPDX cleanup

2021-01-22 Thread Patchwork
== Series Details == Series: series starting with [01/10] drm/i915/gt: SPDX cleanup URL : https://patchwork.freedesktop.org/series/86185/ State : warning == Summary == $ dim checkpatch origin/drm-tip 80d2e2637324 drm/i915/gt: SPDX cleanup 25941d069d19 drm/i915/gt: Add some missing blank lines

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/4] drm/i915: Nuke not needed members of dram_info (rev3)

2021-01-22 Thread Patchwork
== Series Details == Series: series starting with [1/4] drm/i915: Nuke not needed members of dram_info (rev3) URL : https://patchwork.freedesktop.org/series/86092/ State : failure == Summary == CI Bug Log - changes from CI_DRM_9670 -> Patchwork_19460

Re: [Intel-gfx] [PATCH 2/2] drm/i915: consolidate 2big error checking for object sizes

2021-01-22 Thread Chris Wilson
Quoting Matthew Auld (2021-01-22 18:15:14) > Throw it into a simple helper, and throw a warning if we encounter an > object which has been initialised with an object size that exceeds our > limit of INT_MAX pages. > > Suggested-by: Chris Wilson > Signed-off-by: Matthew Auld Reviewed-by: Chris

Re: [Intel-gfx] [PATCH 1/2] drm/i915/dmabuf: don't trust the dma_buf->size

2021-01-22 Thread Chris Wilson
Quoting Matthew Auld (2021-01-22 18:15:13) > At least for the time being, we need to limit our object sizes such that > the number of pages can fit within a 32b signed int. It looks like we > should also apply the same restriction to any imported dma-buf. > > Signed-off-by: Matthew Auld >From

[Intel-gfx] [PATCH 1/2] drm/i915/dmabuf: don't trust the dma_buf->size

2021-01-22 Thread Matthew Auld
At least for the time being, we need to limit our object sizes such that the number of pages can fit within a 32b signed int. It looks like we should also apply the same restriction to any imported dma-buf. Signed-off-by: Matthew Auld --- drivers/gpu/drm/i915/gem/i915_gem_dmabuf.c | 10

[Intel-gfx] [PATCH 2/2] drm/i915: consolidate 2big error checking for object sizes

2021-01-22 Thread Matthew Auld
Throw it into a simple helper, and throw a warning if we encounter an object which has been initialised with an object size that exceeds our limit of INT_MAX pages. Suggested-by: Chris Wilson Signed-off-by: Matthew Auld --- drivers/gpu/drm/i915/gem/i915_gem_dmabuf.c | 9 +--

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [CI,1/9] drm/i915/gt: Show the per-engine runtime in sysfs

2021-01-22 Thread Patchwork
== Series Details == Series: series starting with [CI,1/9] drm/i915/gt: Show the per-engine runtime in sysfs URL : https://patchwork.freedesktop.org/series/86180/ State : success == Summary == CI Bug Log - changes from CI_DRM_9670 -> Patchwork_19458

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/selftest: Fix potential memory leak

2021-01-22 Thread Patchwork
== Series Details == Series: drm/i915/selftest: Fix potential memory leak URL : https://patchwork.freedesktop.org/series/86181/ State : failure == Summary == Applying: drm/i915/selftest: Fix potential memory leak Using index info to reconstruct a base tree... M

Re: [Intel-gfx] linux-next: Tree for Jan 22 (drm/i915)

2021-01-22 Thread Randy Dunlap
On 1/21/21 11:06 PM, Stephen Rothwell wrote: > Hi all, > > Changes since 20210121: > > The drm-intel tree lost its build failure. > > The notifications tree gained conflicts against the keys tree. > > Non-merge commits (relative to Linus' tree): 4819 > 5269 files changed, 192976

Re: [Intel-gfx] [PATCH 2/2] drm/i915: consolidate 2big error checking for object sizes

2021-01-22 Thread Chris Wilson
Quoting Matthew Auld (2021-01-22 17:54:16) > On Fri, 22 Jan 2021 at 17:43, Chris Wilson wrote: > > > > Quoting Matthew Auld (2021-01-22 17:35:46) > > > Throw it into a simple helper, and throw a warning if we encounter an > > > object which has been initialised with an object size that exceeds

Re: [Intel-gfx] [PATCH 2/2] drm/i915: consolidate 2big error checking for object sizes

2021-01-22 Thread Matthew Auld
On Fri, 22 Jan 2021 at 17:43, Chris Wilson wrote: > > Quoting Matthew Auld (2021-01-22 17:35:46) > > Throw it into a simple helper, and throw a warning if we encounter an > > object which has been initialised with an object size that exceeds our > > limit of INT_MAX pages. > > > > Suggested-by:

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [CI,1/9] drm/i915/gt: Show the per-engine runtime in sysfs

2021-01-22 Thread Patchwork
== Series Details == Series: series starting with [CI,1/9] drm/i915/gt: Show the per-engine runtime in sysfs URL : https://patchwork.freedesktop.org/series/86180/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be

Re: [Intel-gfx] [PATCH 2/2] drm/i915: consolidate 2big error checking for object sizes

2021-01-22 Thread Chris Wilson
Quoting Matthew Auld (2021-01-22 17:35:46) > Throw it into a simple helper, and throw a warning if we encounter an > object which has been initialised with an object size that exceeds our > limit of INT_MAX pages. > > Suggested-by: Chris Wilson > Signed-off-by: Matthew Auld > --- >

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [CI,1/9] drm/i915/gt: Show the per-engine runtime in sysfs

2021-01-22 Thread Patchwork
== Series Details == Series: series starting with [CI,1/9] drm/i915/gt: Show the per-engine runtime in sysfs URL : https://patchwork.freedesktop.org/series/86180/ State : warning == Summary == $ dim checkpatch origin/drm-tip e718194c32ae drm/i915/gt: Show the per-engine runtime in sysfs

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/selftests: Check for engine-reset errors in the middle of workarounds

2021-01-22 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Check for engine-reset errors in the middle of workarounds URL : https://patchwork.freedesktop.org/series/86179/ State : success == Summary == CI Bug Log - changes from CI_DRM_9670 -> Patchwork_19457

[Intel-gfx] [PATCH 2/2] drm/i915: consolidate 2big error checking for object sizes

2021-01-22 Thread Matthew Auld
Throw it into a simple helper, and throw a warning if we encounter an object which has been initialised with an object size that exceeds our limit of INT_MAX pages. Suggested-by: Chris Wilson Signed-off-by: Matthew Auld --- drivers/gpu/drm/i915/gem/i915_gem_dmabuf.c | 9 +--

[Intel-gfx] [PATCH 1/2] drm/i915/dmabuf: don't trust the dma_buf->size

2021-01-22 Thread Matthew Auld
At least for the time being, we need to limit our object sizes such that the number of pages can fit within a 32b signed int. It looks like we should also apply the same restriction to any imported dma-buf. Signed-off-by: Matthew Auld --- drivers/gpu/drm/i915/gem/i915_gem_dmabuf.c | 10

Re: [Intel-gfx] [RFC-v23 13/13] drm/i915/pxp: Add plane decryption support

2021-01-22 Thread Gaurav, Kumar
a) How are you scheduling flips for ChromeOS HWDRM overlays(not primary planes)? b) For this you need to understand race. The race is between - Display HW detecting that there is HDCP display config change and deciding to destroy crypto context vs. Display HW flipping HWDRM protected surface.

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [v1,1/2] drm/gma500: Convert to use new SCU IPC API

2021-01-22 Thread Patchwork
== Series Details == Series: series starting with [v1,1/2] drm/gma500: Convert to use new SCU IPC API URL : https://patchwork.freedesktop.org/series/86178/ State : success == Summary == CI Bug Log - changes from CI_DRM_9670 -> Patchwork_19456

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/gen12: Add display render clear color decompression support (rev5)

2021-01-22 Thread Vudum, Lakshminarayana
Re-reported. -Original Message- From: Imre Deak Sent: Friday, January 22, 2021 6:34 AM To: intel-gfx@lists.freedesktop.org; Sripada, Radhakrishna ; Pandiyan, Dhinakaran ; Kahola, Mika ; Roper, Matthew D ; Chery, Nanley G ; Chris Wilson ; Daniel Vetter ; Nikula, Jani ; Vudum,

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/gen12: Add display render clear color decompression support (rev5)

2021-01-22 Thread Patchwork
== Series Details == Series: drm/i915/gen12: Add display render clear color decompression support (rev5) URL : https://patchwork.freedesktop.org/series/85877/ State : success == Summary == CI Bug Log - changes from CI_DRM_9650_full -> Patchwork_19433_full

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gt: Move the defer_request waiter active assertion (rev2)

2021-01-22 Thread Patchwork
== Series Details == Series: drm/i915/gt: Move the defer_request waiter active assertion (rev2) URL : https://patchwork.freedesktop.org/series/86176/ State : success == Summary == CI Bug Log - changes from CI_DRM_9670 -> Patchwork_19455

Re: [Intel-gfx] [PATCH 01/10] drm/i915/gt: SPDX cleanup

2021-01-22 Thread Chris Wilson
Quoting Michal Wajdeczko (2021-01-22 16:03:38) > > > On 22.01.2021 16:49, Chris Wilson wrote: > > Quoting Michal Wajdeczko (2021-01-22 15:43:26) > >> > >> > >> On 22.01.2021 16:06, Chris Wilson wrote: > >>> Clean up the SPDX licence declarations to comply with checkpatch. > >> > >> typo here and

Re: [Intel-gfx] [PATCH] drm/i915/buddy: document the unused header bits

2021-01-22 Thread Chris Wilson
Quoting Matthew Auld (2021-01-22 15:45:46) > The largest possible order is (63-12), given that our min chunk size is > 4K. With that we should only need at most 6 bits to represent all > possible orders, giving us back 4 bits for other potential uses. Include > a simple selftest to verify this. >

Re: [Intel-gfx] [PATCH 01/10] drm/i915/gt: SPDX cleanup

2021-01-22 Thread Michal Wajdeczko
On 22.01.2021 16:49, Chris Wilson wrote: > Quoting Michal Wajdeczko (2021-01-22 15:43:26) >> >> >> On 22.01.2021 16:06, Chris Wilson wrote: >>> Clean up the SPDX licence declarations to comply with checkpatch. >> >> typo here and in the commit message 04/10 > > s/paramters/parameters/ and

Re: [Intel-gfx] [PATCH] drm/i915/dmabuf: don't trust the dma_buf->size

2021-01-22 Thread Chris Wilson
Quoting Matthew Auld (2021-01-22 15:56:28) > At least for the time being, we need to limit our object sizes such that > the number of pages can fit within a 32b signed int. It looks like we > should also apply the same restriction to any imported dma-buf. > > Signed-off-by: Matthew Auld > --- >

[Intel-gfx] [PATCH] drm/i915/dmabuf: don't trust the dma_buf->size

2021-01-22 Thread Matthew Auld
At least for the time being, we need to limit our object sizes such that the number of pages can fit within a 32b signed int. It looks like we should also apply the same restriction to any imported dma-buf. Signed-off-by: Matthew Auld --- drivers/gpu/drm/i915/gem/i915_gem_dmabuf.c | 10

  1   2   >