[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/vbt: update DP max link rate table (rev4)

2021-02-17 Thread Patchwork
== Series Details == Series: drm/i915/vbt: update DP max link rate table (rev4) URL : https://patchwork.freedesktop.org/series/86539/ State : success == Summary == CI Bug Log - changes from CI_DRM_9783 -> Patchwork_19699 Summary ---

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/vbt: update DP max link rate table (rev4)

2021-02-17 Thread Patchwork
== Series Details == Series: drm/i915/vbt: update DP max link rate table (rev4) URL : https://patchwork.freedesktop.org/series/86539/ State : warning == Summary == $ dim checkpatch origin/drm-tip 3d1daa4bfb5d drm/i915/vbt: update DP max link rate table -:94: WARNING:LONG_LINE: line length of

[Intel-gfx] [PATCH v4] drm/i915/vbt: update DP max link rate table

2021-02-17 Thread Lee Shawn C
According to Bspec #20124, max link rate table for DP was updated at BDB version 230. Max link rate can support upto UHBR. After migrate to BDB v230, the definition for LBR, HBR2 and HBR3 were changed. For backward compatibility. If BDB version was from 216 to 229. Driver have to follow original

Re: [Intel-gfx] [PATCH v4] drm/i915/gen9bc: Handle TGP PCH during suspend/resume

2021-02-17 Thread Surendrakumar Upadhyay, TejaskumarX
> -Original Message- > From: Lyude Paul > Sent: 18 February 2021 02:49 > To: Deak, Imre > Cc: intel-gfx@lists.freedesktop.org; Surendrakumar Upadhyay, TejaskumarX > ; Roper, Matthew D > ; Jani Nikula ; > Joonas Lahtinen ; Vivi, Rodrigo > ; David Airlie ; Daniel Vetter > ; open list:DRM

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [v4] drm/i915/gen9bc: Handle TGP PCH during suspend/resume (rev2)

2021-02-17 Thread Patchwork
== Series Details == Series: series starting with [v4] drm/i915/gen9bc: Handle TGP PCH during suspend/resume (rev2) URL : https://patchwork.freedesktop.org/series/87148/ State : success == Summary == CI Bug Log - changes from CI_DRM_9783_full -> Patchwork_19697_full

Re: [Intel-gfx] [PATCH 3/3] drm/i915: Fix plane watermark mismatches

2021-02-17 Thread Ville Syrjälä
On Wed, Feb 17, 2021 at 05:24:03PM +, Souza, Jose wrote: > On Fri, 2021-02-12 at 23:13 +0200, Ville Syrjälä wrote: > > On Fri, Feb 12, 2021 at 07:44:22PM +, Souza, Jose wrote: > > > On Fri, 2021-02-12 at 20:35 +0200, Ville Syrjälä wrote: > > > > On Fri, Feb 12, 2021 at 10:22:01AM -0800,

Re: [Intel-gfx] [PATCH] drm/i915: Nuke INTEL_OUTPUT_FORMAT_INVALID

2021-02-17 Thread Ville Syrjälä
On Wed, Feb 17, 2021 at 04:37:20PM +, Souza, Jose wrote: > On Fri, 2021-02-05 at 22:23 +0200, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > We tend to use output_format!=RGB as a shorthand for YCbCr, but > > this fails if we have a disabled crtc where output_format==INVALID. > > We're

Re: [Intel-gfx] [PATCH v4] drm/i915/gen9bc: Handle TGP PCH during suspend/resume

2021-02-17 Thread Lyude Paul
On Wed, 2021-02-17 at 23:18 +0200, Imre Deak wrote: > On Wed, Feb 17, 2021 at 01:00:16PM -0500, Lyude Paul wrote: > > From: Tejas Upadhyay > > > > For Legacy S3 suspend/resume GEN9 BC needs to enable and > > setup TGP PCH. > > > > v2: > > * Move Wa_14010685332 into it's own function - vsyrjala

Re: [Intel-gfx] [PATCH v4] drm/i915/gen9bc: Handle TGP PCH during suspend/resume

2021-02-17 Thread Imre Deak
On Wed, Feb 17, 2021 at 01:00:16PM -0500, Lyude Paul wrote: > From: Tejas Upadhyay > > For Legacy S3 suspend/resume GEN9 BC needs to enable and > setup TGP PCH. > > v2: > * Move Wa_14010685332 into it's own function - vsyrjala > * Add TODO comment about figuring out if we can move this

Re: [Intel-gfx] [RFC PATCH 3/9] drm/i915/spi: add driver for on-die spi device

2021-02-17 Thread Winkler, Tomas
> > On Tue, 16 Feb 2021, Tomas Winkler wrote: > > Add the platform driver for i915 on-die spi device, exposed via mfd > > framework. > > > > Cc: Rodrigo Vivi > > Cc: Lucas De Marchi > > Signed-off-by: Tomas Winkler > > --- > > drivers/gpu/drm/i915/Kconfig | 2 + > >

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/bios: vbt child device rework

2021-02-17 Thread Patchwork
== Series Details == Series: drm/i915/bios: vbt child device rework URL : https://patchwork.freedesktop.org/series/87165/ State : success == Summary == CI Bug Log - changes from CI_DRM_9782_full -> Patchwork_19696_full Summary ---

Re: [Intel-gfx] [PATCH] drm/i915/display: Compute aux ch power domain during DDI initialization

2021-02-17 Thread Imre Deak
On Wed, Feb 17, 2021 at 09:50:13PM +0200, Souza, Jose wrote: > On Wed, 2021-02-17 at 21:38 +0200, Imre Deak wrote: > > On Wed, Feb 17, 2021 at 10:02:45AM -0800, José Roberto de Souza wrote: > > > [...] > > > diff --git a/drivers/gpu/drm/i915/display/intel_display_types.h > > >

Re: [Intel-gfx] [RFC PATCH 2/9] drm/i915/spi: intel_spi_region map

2021-02-17 Thread Winkler, Tomas
> On Tue, 16 Feb 2021, Tomas Winkler wrote: > > Add the dGFX spi region map and convey it via mfd cell platform data > > to the spi child device. > > > > Cc: Rodrigo Vivi > > Cc: Lucas De Marchi > > Signed-off-by: Tomas Winkler > > --- > > drivers/gpu/drm/i915/spi/intel_spi.c | 9 + >

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Wait for scanout to stop when sanitizing planes

2021-02-17 Thread Patchwork
== Series Details == Series: drm/i915: Wait for scanout to stop when sanitizing planes URL : https://patchwork.freedesktop.org/series/87162/ State : success == Summary == CI Bug Log - changes from CI_DRM_9782_full -> Patchwork_19695_full

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/display: Compute aux ch power domain during DDI initialization

2021-02-17 Thread Patchwork
== Series Details == Series: drm/i915/display: Compute aux ch power domain during DDI initialization URL : https://patchwork.freedesktop.org/series/87167/ State : failure == Summary == CI Bug Log - changes from CI_DRM_9783 -> Patchwork_19698

Re: [Intel-gfx] [PATCH 00/12] drm/i915/bios: vbt child device rework

2021-02-17 Thread Jani Nikula
On Wed, 17 Feb 2021, Lucas De Marchi wrote: > On Wed, Feb 17, 2021 at 07:03:30PM +0200, Jani Nikula wrote: >>I see the parsing and caching of child device data into >>i915->vbt.ddi_port_info[] slightly problematic. We keep adding data to >>it, and it just duplicates information. Start moving

Re: [Intel-gfx] [PATCH 04/12] drm/i915/bios: limit default outputs to ports A through F

2021-02-17 Thread Lucas De Marchi
On Wed, Feb 17, 2021 at 09:49:57PM +0200, Jani Nikula wrote: On Wed, 17 Feb 2021, Lucas De Marchi wrote: On Wed, Feb 17, 2021 at 09:23:00AM -0800, Lucas De Marchi wrote: On Wed, Feb 17, 2021 at 07:03:34PM +0200, Jani Nikula wrote: With the defaults limited to non-TypeC ports in commit

Re: [Intel-gfx] [PATCH 08/12] drm/i915/vbt: add helper functions to check output support

2021-02-17 Thread Jani Nikula
On Wed, 17 Feb 2021, Lucas De Marchi wrote: > On Wed, Feb 17, 2021 at 07:03:38PM +0200, Jani Nikula wrote: >>These will be exposed to the rest of the driver and replace other >>functions. Everything will operate on the child devices. >> >>Cc: Lucas De Marchi >>Cc: Ville Syrjälä >>Signed-off-by:

Re: [Intel-gfx] [PATCH 06/12] drm/i915/bios: rename display_device_data to intel_bios_encoder_data

2021-02-17 Thread Jani Nikula
On Wed, 17 Feb 2021, Lucas De Marchi wrote: > On Wed, Feb 17, 2021 at 07:03:36PM +0200, Jani Nikula wrote: >>Make the naming suitable for exposing to the rest of the driver as an >>opaque type. No functional changes. > > ack, but.. > >> >>Cc: Lucas De Marchi >>Cc: Ville Syrjälä >>Signed-off-by:

Re: [Intel-gfx] [PATCH] drm/i915/display: Compute aux ch power domain during DDI initialization

2021-02-17 Thread Souza, Jose
On Wed, 2021-02-17 at 21:38 +0200, Imre Deak wrote: > On Wed, Feb 17, 2021 at 10:02:45AM -0800, José Roberto de Souza wrote: > > Future platform will require a power domain that do not mach with aux > > ch id, so here already preparing code for that by dropping the > > functions that converts the

Re: [Intel-gfx] [PATCH 04/12] drm/i915/bios: limit default outputs to ports A through F

2021-02-17 Thread Jani Nikula
On Wed, 17 Feb 2021, Lucas De Marchi wrote: > On Wed, Feb 17, 2021 at 09:23:00AM -0800, Lucas De Marchi wrote: >>On Wed, Feb 17, 2021 at 07:03:34PM +0200, Jani Nikula wrote: >>>With the defaults limited to non-TypeC ports in commit 828ccb31cf41 >>>("drm/i915/icl: Add TypeC ports only if VBT is

Re: [Intel-gfx] [PATCH] drm/i915/display: Compute aux ch power domain during DDI initialization

2021-02-17 Thread Imre Deak
On Wed, Feb 17, 2021 at 10:02:45AM -0800, José Roberto de Souza wrote: > Future platform will require a power domain that do not mach with aux > ch id, so here already preparing code for that by dropping the > functions that converts the aux ch to power domains and initializaing > aux_power_domain

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [v4] drm/i915/gen9bc: Handle TGP PCH during suspend/resume (rev2)

2021-02-17 Thread Patchwork
== Series Details == Series: series starting with [v4] drm/i915/gen9bc: Handle TGP PCH during suspend/resume (rev2) URL : https://patchwork.freedesktop.org/series/87148/ State : success == Summary == CI Bug Log - changes from CI_DRM_9783 -> Patchwork_19697

Re: [Intel-gfx] [RFC PATCH 1/9] drm/i915/spi: add spi device for discrete graphics

2021-02-17 Thread Winkler, Tomas
> On Tue, Feb 16, 2021 at 08:19:17PM +0200, Tomas Winkler wrote: > >Enable access to internal spi on descrete devices via a child device. > >The spi child device is exposed via MFD framework. > > > >Cc: Rodrigo Vivi > >Cc: Lucas De Marchi # v3 > >Signed-off-by: Tomas Winkler > >--- > >

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/vbt: update DP max link rate table (rev3)

2021-02-17 Thread Patchwork
== Series Details == Series: drm/i915/vbt: update DP max link rate table (rev3) URL : https://patchwork.freedesktop.org/series/86539/ State : success == Summary == CI Bug Log - changes from CI_DRM_9782_full -> Patchwork_19694_full Summary

Re: [Intel-gfx] [RFC PATCH 0/9] drm/i915/spi: discrete graphics internal spi

2021-02-17 Thread Rodrigo Vivi
On Wed, Feb 17, 2021 at 03:35:19PM +0200, Jani Nikula wrote: > On Wed, 17 Feb 2021, "Winkler, Tomas" wrote: > >> > >> On Tue, 16 Feb 2021, Tomas Winkler wrote: > >> > Intel discrete graphic devices have internal spi storage, that holds > >> > firmware and oprom images. The spi device is exposed

Re: [Intel-gfx] [PATCH] drm/dp_mst: Tune down the WARN modesetting a port with full_pbn=0

2021-02-17 Thread Imre Deak
On Wed, Feb 17, 2021 at 01:07:11PM -0500, Lyude Paul wrote: > On Tue, 2021-02-16 at 14:34 +0200, Imre Deak wrote: > > It's possible to modeset a connector/mst port that has a 0 full_pbn > > value: if the sink on the port deasserts its HPD and a branch device > > reports this via a CSN with the

Re: [Intel-gfx] [PATCH v3 2/2] drm/i915/icp+: Use icp_hpd_irq_setup() instead of spt_hpd_irq_setup()

2021-02-17 Thread Rodrigo Vivi
On Tue, Feb 16, 2021 at 09:53:37PM -0500, Lyude Paul wrote: > While reviewing patches for handling workarounds related to gen9 bc, Imre > from Intel discovered that we're using spt_hpd_irq_setup() on ICP+ PCHs > despite it being almost the same as icp_hpd_irq_setup(). Since we need to > be calling

Re: [Intel-gfx] [PATCH] drm/dp_mst: Tune down the WARN modesetting a port with full_pbn=0

2021-02-17 Thread Lyude Paul
On Tue, 2021-02-16 at 14:34 +0200, Imre Deak wrote: > It's possible to modeset a connector/mst port that has a 0 full_pbn > value: if the sink on the port deasserts its HPD and a branch device > reports this via a CSN with the port's ddps=0 and pdt!=NONE the driver > clears full_pbn, but the

[Intel-gfx] [PATCH] drm/i915/display: Compute aux ch power domain during DDI initialization

2021-02-17 Thread José Roberto de Souza
Future platform will require a power domain that do not mach with aux ch id, so here already preparing code for that by dropping the functions that converts the aux ch to power domains and initializaing aux_power_domain during intel_ddi_init(). Cc: Uma Shankar Cc: Imre Deak Signed-off-by: José

[Intel-gfx] [PATCH v4] drm/i915/gen9bc: Handle TGP PCH during suspend/resume

2021-02-17 Thread Lyude Paul
From: Tejas Upadhyay For Legacy S3 suspend/resume GEN9 BC needs to enable and setup TGP PCH. v2: * Move Wa_14010685332 into it's own function - vsyrjala * Add TODO comment about figuring out if we can move this workaround - imre v3: * Rename cnp_irq_post_reset() to cnp_display_clock_wa() * Add

Re: [Intel-gfx] [PATCH 00/12] drm/i915/bios: vbt child device rework

2021-02-17 Thread Lucas De Marchi
On Wed, Feb 17, 2021 at 07:03:30PM +0200, Jani Nikula wrote: I see the parsing and caching of child device data into i915->vbt.ddi_port_info[] slightly problematic. We keep adding data to it, and it just duplicates information. Start moving towards a single point of truth, and getting the

Re: [Intel-gfx] [PATCH] drm/i915: Wait for scanout to stop when sanitizing planes

2021-02-17 Thread Chris Wilson
Quoting Ville Syrjala (2021-02-17 16:20:50) > From: Ville Syrjälä > > When we sanitize planes let's wait for the scanout to stop > before we let the subsequent code tear down the ggtt mappings > and whatnot. Cures an underrun on my ivb when I boot with > VT-d enabled and the BIOS fb gets thrown

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/bios: vbt child device rework

2021-02-17 Thread Patchwork
== Series Details == Series: drm/i915/bios: vbt child device rework URL : https://patchwork.freedesktop.org/series/87165/ State : success == Summary == CI Bug Log - changes from CI_DRM_9782 -> Patchwork_19696 Summary --- **SUCCESS**

Re: [Intel-gfx] [PATCH 08/12] drm/i915/vbt: add helper functions to check output support

2021-02-17 Thread Lucas De Marchi
On Wed, Feb 17, 2021 at 07:03:38PM +0200, Jani Nikula wrote: These will be exposed to the rest of the driver and replace other functions. Everything will operate on the child devices. Cc: Lucas De Marchi Cc: Ville Syrjälä Signed-off-by: Jani Nikula ---

Re: [Intel-gfx] [PATCH 06/12] drm/i915/bios: rename display_device_data to intel_bios_encoder_data

2021-02-17 Thread Lucas De Marchi
On Wed, Feb 17, 2021 at 07:03:36PM +0200, Jani Nikula wrote: Make the naming suitable for exposing to the rest of the driver as an opaque type. No functional changes. ack, but.. Cc: Lucas De Marchi Cc: Ville Syrjälä Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_bios.c

Re: [Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/3] drm/i915/display/adl_s: Fix dpclka_cfgcr0_clk_off mapping

2021-02-17 Thread Souza, Jose
On Fri, 2021-02-12 at 20:15 +, Patchwork wrote: Patch Details Series: series starting with [1/3] drm/i915/display/adl_s: Fix dpclka_cfgcr0_clk_off mapping URL:https://patchwork.freedesktop.org/series/87048/ State: success Details:

Re: [Intel-gfx] [PATCH 04/12] drm/i915/bios: limit default outputs to ports A through F

2021-02-17 Thread Lucas De Marchi
On Wed, Feb 17, 2021 at 09:23:00AM -0800, Lucas De Marchi wrote: On Wed, Feb 17, 2021 at 07:03:34PM +0200, Jani Nikula wrote: With the defaults limited to non-TypeC ports in commit 828ccb31cf41 ("drm/i915/icl: Add TypeC ports only if VBT is present"), this should be a no-op, but clarifies the

Re: [Intel-gfx] [PATCH 1/3] drm/i915/display/adl_s: Fix dpclka_cfgcr0_clk_off mapping

2021-02-17 Thread Souza, Jose
On Fri, 2021-02-12 at 23:17 +0200, Ville Syrjälä wrote: > On Fri, Feb 12, 2021 at 07:42:17PM +, Souza, Jose wrote: > > On Fri, 2021-02-12 at 21:20 +0200, Ville Syrjälä wrote: > > > On Fri, Feb 12, 2021 at 10:21:59AM -0800, José Roberto de Souza wrote: > > > > The cfgcr0/1_clk_off mapping is

Re: [Intel-gfx] [PATCH 3/3] drm/i915: Fix plane watermark mismatches

2021-02-17 Thread Souza, Jose
On Fri, 2021-02-12 at 23:13 +0200, Ville Syrjälä wrote: > On Fri, Feb 12, 2021 at 07:44:22PM +, Souza, Jose wrote: > > On Fri, 2021-02-12 at 20:35 +0200, Ville Syrjälä wrote: > > > On Fri, Feb 12, 2021 at 10:22:01AM -0800, José Roberto de Souza wrote: > > > > Found a system were firmware/BIOS

Re: [Intel-gfx] [PATCH 04/12] drm/i915/bios: limit default outputs to ports A through F

2021-02-17 Thread Lucas De Marchi
On Wed, Feb 17, 2021 at 07:03:34PM +0200, Jani Nikula wrote: With the defaults limited to non-TypeC ports in commit 828ccb31cf41 ("drm/i915/icl: Add TypeC ports only if VBT is present"), this should be a no-op, but clarifies the code and prepares for subsequent changes. Cc: Lucas De Marchi Cc:

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/bios: vbt child device rework

2021-02-17 Thread Patchwork
== Series Details == Series: drm/i915/bios: vbt child device rework URL : https://patchwork.freedesktop.org/series/87165/ State : warning == Summary == $ dim checkpatch origin/drm-tip eb3ee8e4100d drm/i915/bios: mass convert dev_priv to i915 -:1537: CHECK:PARENTHESIS_ALIGNMENT: Alignment

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Wait for scanout to stop when sanitizing planes

2021-02-17 Thread Patchwork
== Series Details == Series: drm/i915: Wait for scanout to stop when sanitizing planes URL : https://patchwork.freedesktop.org/series/87162/ State : success == Summary == CI Bug Log - changes from CI_DRM_9782 -> Patchwork_19695 Summary

Re: [Intel-gfx] [RFC PATCH 1/9] drm/i915/spi: add spi device for discrete graphics

2021-02-17 Thread Lucas De Marchi
On Tue, Feb 16, 2021 at 08:19:17PM +0200, Tomas Winkler wrote: Enable access to internal spi on descrete devices via a child device. The spi child device is exposed via MFD framework. Cc: Rodrigo Vivi Cc: Lucas De Marchi # v3 Signed-off-by: Tomas Winkler --- drivers/gpu/drm/i915/Kconfig

Re: [Intel-gfx] [PATCH v1 1/3] string: Consolidate yesno() helpers under string.h hood

2021-02-17 Thread Jani Nikula
On Wed, 17 Feb 2021, Petr Mladek wrote: > On Mon 2021-02-15 16:39:26, Andy Shevchenko wrote: >> +Cc: Sakari and printk people >> >> On Mon, Feb 15, 2021 at 4:28 PM Christian König >> wrote: >> > Am 15.02.21 um 15:21 schrieb Andy Shevchenko: >> > > We have already few similar implementation and

[Intel-gfx] [PATCH 10/12] drm/i915/bios: start using the intel_bios_encoder_data directly

2021-02-17 Thread Jani Nikula
Start using struct intel_bios_encoder_data directly. We'll start sanitizing the child device data directly as well, instead of the cached data in ddi_port_info[]. The one downside here is having to store a non-const pointer back to intel_bios_encoder_data. Eventually we'll be able to have a

[Intel-gfx] [PATCH 06/12] drm/i915/bios: rename display_device_data to intel_bios_encoder_data

2021-02-17 Thread Jani Nikula
Make the naming suitable for exposing to the rest of the driver as an opaque type. No functional changes. Cc: Lucas De Marchi Cc: Ville Syrjälä Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_bios.c | 30 +++ 1 file changed, 15 insertions(+), 15

[Intel-gfx] [PATCH 03/12] drm/i915/bios: limit default outputs by platform on missing VBT

2021-02-17 Thread Jani Nikula
Pre-DDI and non-CHV aren't using the information created here anyway, so don't bother setting the defaults for them. This should be a non-functional change, but is separated here to catch any regressions in a single commit. Cc: Lucas De Marchi Cc: Ville Syrjälä Signed-off-by: Jani Nikula ---

[Intel-gfx] [PATCH 07/12] drm/i915/bios: add i915 backpointer to intel_bios_encoder_data

2021-02-17 Thread Jani Nikula
We'll be needing it in the future. Cc: Lucas De Marchi Cc: Ville Syrjälä Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_bios.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/gpu/drm/i915/display/intel_bios.c b/drivers/gpu/drm/i915/display/intel_bios.c

[Intel-gfx] [PATCH 12/12] drm/i915/bios: add intel_bios_encoder_data to encoder, use for iboost

2021-02-17 Thread Jani Nikula
Add intel_bios_encoder_data pointer to encoder, and use it for hdmi and dp iboost. For starters, we only set the encoder->devdata for DDI encoders, i.e. we can only use it for data that is used by DDI encoders. Cc: Lucas De Marchi Cc: Ville Syrjälä Signed-off-by: Jani Nikula ---

[Intel-gfx] [PATCH 11/12] drm/i915/bios: start using intel_bios_encoder_data for Type-C USB and TBT

2021-02-17 Thread Jani Nikula
Cc: Lucas De Marchi Cc: Ville Syrjälä Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_bios.c | 20 drivers/gpu/drm/i915/display/intel_bios.h | 2 ++ drivers/gpu/drm/i915/display/intel_ddi.c | 4 ++-- 3 files changed, 12 insertions(+), 14 deletions(-)

[Intel-gfx] [PATCH 09/12] drm/i915/bios: save a higher level pointer in ddi_vbt_port_info[]

2021-02-17 Thread Jani Nikula
We'll be needing the intel_bios_encoder_data pointer going forward, and it's just easier to store the higher level pointer in the ddi_vbt_port_info[] array. Cc: Lucas De Marchi Cc: Ville Syrjälä Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_bios.c | 28

[Intel-gfx] [PATCH 08/12] drm/i915/vbt: add helper functions to check output support

2021-02-17 Thread Jani Nikula
These will be exposed to the rest of the driver and replace other functions. Everything will operate on the child devices. Cc: Lucas De Marchi Cc: Ville Syrjälä Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_bios.c | 66 ++- 1 file changed, 54

[Intel-gfx] [PATCH 04/12] drm/i915/bios: limit default outputs to ports A through F

2021-02-17 Thread Jani Nikula
With the defaults limited to non-TypeC ports in commit 828ccb31cf41 ("drm/i915/icl: Add TypeC ports only if VBT is present"), this should be a no-op, but clarifies the code and prepares for subsequent changes. Cc: Lucas De Marchi Cc: Ville Syrjälä Signed-off-by: Jani Nikula ---

[Intel-gfx] [PATCH 01/12] drm/i915/bios: mass convert dev_priv to i915

2021-02-17 Thread Jani Nikula
Time to just yank out the bandage. No functional changes. Cc: Lucas De Marchi Cc: Ville Syrjälä Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_bios.c | 766 +++--- 1 file changed, 383 insertions(+), 383 deletions(-) diff --git

[Intel-gfx] [PATCH 05/12] drm/i915/bios: create fake child devices on missing VBT

2021-02-17 Thread Jani Nikula
Instead of initialing data directly in ddi_port_info array, create fake child devices for default outputs when the VBT is missing. This makes further unification of output handling easier. This will make intel_bios_is_port_present() return true for the fake child devices. This may cause subtle

[Intel-gfx] [PATCH 02/12] drm/i915/bios: store bdb version in i915

2021-02-17 Thread Jani Nikula
We'll be needing the version in more places in the future, so avoid the need to pass it around. No functional changes. Cc: Lucas De Marchi Cc: Ville Syrjälä Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_bios.c | 28 +++ drivers/gpu/drm/i915/i915_drv.h

[Intel-gfx] [PATCH 00/12] drm/i915/bios: vbt child device rework

2021-02-17 Thread Jani Nikula
I see the parsing and caching of child device data into i915->vbt.ddi_port_info[] slightly problematic. We keep adding data to it, and it just duplicates information. Start moving towards a single point of truth, and getting the information directly from the child device data. One obstacle has

Re: [Intel-gfx] [PATCH v1 1/3] string: Consolidate yesno() helpers under string.h hood

2021-02-17 Thread Petr Mladek
On Mon 2021-02-15 16:39:26, Andy Shevchenko wrote: > +Cc: Sakari and printk people > > On Mon, Feb 15, 2021 at 4:28 PM Christian König > wrote: > > Am 15.02.21 um 15:21 schrieb Andy Shevchenko: > > > We have already few similar implementation and a lot of code that can > > > benefit > > > of

Re: [Intel-gfx] [PATCH] drm/i915: Nuke INTEL_OUTPUT_FORMAT_INVALID

2021-02-17 Thread Souza, Jose
On Fri, 2021-02-05 at 22:23 +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > We tend to use output_format!=RGB as a shorthand for YCbCr, but > this fails if we have a disabled crtc where output_format==INVALID. > We're now getting some fail from intel_color_check() when we have: >  

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/3] drm/i915: Wrap all access to i915_vma.node.start|size (rev3)

2021-02-17 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915: Wrap all access to i915_vma.node.start|size (rev3) URL : https://patchwork.freedesktop.org/series/87102/ State : success == Summary == CI Bug Log - changes from CI_DRM_9781_full -> Patchwork_19693_full

Re: [Intel-gfx] Issue with cec_register_adapter calling request_module() from an async context when called from intel_dp_detect

2021-02-17 Thread Hans Verkuil
On 17/02/2021 16:11, Sean Young wrote: > Hi, > > On Wed, Feb 17, 2021 at 04:04:11PM +0100, Hans de Goede wrote: >> On 2/17/21 3:32 PM, Sean Young wrote: >>> On Wed, Feb 17, 2021 at 01:41:46PM +0100, Hans Verkuil wrote: Hi Hans, On 17/02/2021 13:24, Hans de Goede wrote: > >

[Intel-gfx] [PATCH] drm/i915: Wait for scanout to stop when sanitizing planes

2021-02-17 Thread Ville Syrjala
From: Ville Syrjälä When we sanitize planes let's wait for the scanout to stop before we let the subsequent code tear down the ggtt mappings and whatnot. Cures an underrun on my ivb when I boot with VT-d enabled and the BIOS fb gets thrown out due to stolen being considered unusable with VT-d

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/vbt: update DP max link rate table (rev3)

2021-02-17 Thread Patchwork
== Series Details == Series: drm/i915/vbt: update DP max link rate table (rev3) URL : https://patchwork.freedesktop.org/series/86539/ State : success == Summary == CI Bug Log - changes from CI_DRM_9782 -> Patchwork_19694 Summary ---

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Enable -Wuninitialized

2021-02-17 Thread Patchwork
== Series Details == Series: drm/i915: Enable -Wuninitialized URL : https://patchwork.freedesktop.org/series/87153/ State : failure == Summary == CI Bug Log - changes from CI_DRM_9781_full -> Patchwork_19692_full Summary ---

Re: [Intel-gfx] [PATCH v3] drm/i915/vbt: update DP max link rate table

2021-02-17 Thread Ville Syrjälä
On Wed, Feb 17, 2021 at 11:39:35PM +0800, Lee Shawn C wrote: > According to Bspec #20124, max link rate table for DP was updated > at BDB version 230. Max link rate can support upto UHBR. > > After migrate to BDB v230, the definition for LBR, HBR2 and HBR3 > were changed. For backward

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/vbt: update DP max link rate table (rev3)

2021-02-17 Thread Patchwork
== Series Details == Series: drm/i915/vbt: update DP max link rate table (rev3) URL : https://patchwork.freedesktop.org/series/86539/ State : warning == Summary == $ dim checkpatch origin/drm-tip 6ab2d5e62da7 drm/i915/vbt: update DP max link rate table -:113: WARNING:LONG_LINE: line length of

Re: [Intel-gfx] [PATCH v2] drm/i915/vbt: update DP max link rate table

2021-02-17 Thread Lee, Shawn C
On Wed, Feb 17, 2021 at 1:22 p.m., Ville Syrjälä wrote: >On Wed, Feb 17, 2021 at 02:55:19PM +0800, Lee Shawn C wrote: >> According to Bspec #20124, max link rate table for DP was updated at >> BDB version 230. Max link rate can support upto UHBR. >> >> After migrate to BDB v230, the definition

[Intel-gfx] [PATCH v3] drm/i915/vbt: update DP max link rate table

2021-02-17 Thread Lee Shawn C
According to Bspec #20124, max link rate table for DP was updated at BDB version 230. Max link rate can support upto UHBR. After migrate to BDB v230, the definition for LBR, HBR2 and HBR3 were changed. For backward compatibility. If BDB version was from 216 to 229. Driver have to follow original

Re: [Intel-gfx] Issue with cec_register_adapter calling request_module() from an async context when called from intel_dp_detect

2021-02-17 Thread Hans de Goede
Hi, On 2/17/21 3:32 PM, Sean Young wrote: > On Wed, Feb 17, 2021 at 01:41:46PM +0100, Hans Verkuil wrote: >> Hi Hans, >> >> On 17/02/2021 13:24, Hans de Goede wrote: >>> >>> >>> Hi Hans, >>> >>> Fedora has a (opt-in) system to automatically collect backtraces from >>> software >>> crashing on

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/3] drm/i915: Wrap all access to i915_vma.node.start|size (rev3)

2021-02-17 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915: Wrap all access to i915_vma.node.start|size (rev3) URL : https://patchwork.freedesktop.org/series/87102/ State : success == Summary == CI Bug Log - changes from CI_DRM_9781 -> Patchwork_19693

Re: [Intel-gfx] [RFC PATCH 0/9] drm/i915/spi: discrete graphics internal spi

2021-02-17 Thread Winkler, Tomas
> > On Tue, 16 Feb 2021, Tomas Winkler wrote: > > Intel discrete graphic devices have internal spi storage, that holds > > firmware and oprom images. The spi device is exposed to the user space > > via mtd framework to be accessed during manufacturing. > > The device is hardware locked after

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Enable -Wuninitialized

2021-02-17 Thread Patchwork
== Series Details == Series: drm/i915: Enable -Wuninitialized URL : https://patchwork.freedesktop.org/series/87153/ State : success == Summary == CI Bug Log - changes from CI_DRM_9781 -> Patchwork_19692 Summary --- **SUCCESS** No

Re: [Intel-gfx] [RFC PATCH 0/9] drm/i915/spi: discrete graphics internal spi

2021-02-17 Thread Jani Nikula
On Wed, 17 Feb 2021, "Winkler, Tomas" wrote: >> >> On Tue, 16 Feb 2021, Tomas Winkler wrote: >> > Intel discrete graphic devices have internal spi storage, that holds >> > firmware and oprom images. The spi device is exposed to the user space >> > via mtd framework to be accessed during

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: Enable -Wuninitialized

2021-02-17 Thread Patchwork
== Series Details == Series: drm/i915: Enable -Wuninitialized URL : https://patchwork.freedesktop.org/series/87153/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. -

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Enable -Wuninitialized

2021-02-17 Thread Patchwork
== Series Details == Series: drm/i915: Enable -Wuninitialized URL : https://patchwork.freedesktop.org/series/87153/ State : warning == Summary == $ dim checkpatch origin/drm-tip a32effc3aaeb drm/i915: Enable -Wuninitialized -:20: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit

Re: [Intel-gfx] [PATCH v2] drm/i915/vbt: update DP max link rate table

2021-02-17 Thread Ville Syrjälä
On Wed, Feb 17, 2021 at 02:55:19PM +0800, Lee Shawn C wrote: > According to Bspec #20124, max link rate table for DP was updated > at BDB version 230. Max link rate can support upto UHBR. > > After migrate to BDB v230, the definition for LBR, HBR2 and HBR3 > were changed. For backward

Re: [Intel-gfx] [RFC PATCH 0/9] drm/i915/spi: discrete graphics internal spi

2021-02-17 Thread Winkler, Tomas
> > On Tue, 16 Feb 2021, Tomas Winkler wrote: > > Intel discrete graphic devices have internal spi storage, that holds > > firmware and oprom images. The spi device is exposed to the user space > > via mtd framework to be accessed during manufacturing. > > The device is hardware locked after

Re: [Intel-gfx] Issue with cec_register_adapter calling request_module() from an async context when called from intel_dp_detect

2021-02-17 Thread Hans Verkuil
Hi Hans, On 17/02/2021 13:24, Hans de Goede wrote: > > > Hi Hans, > > Fedora has a (opt-in) system to automatically collect backtraces from software > crashing on users systems. > > This includes collecting kernel backtraces (including once triggered by > WARN macros) while looking a the top

[Intel-gfx] Issue with cec_register_adapter calling request_module() from an async context when called from intel_dp_detect

2021-02-17 Thread Hans de Goede
Hi Hans, Fedora has a (opt-in) system to automatically collect backtraces from software crashing on users systems. This includes collecting kernel backtraces (including once triggered by WARN macros) while looking a the top 10 of the most reported backtrace during the last 2 weeks report from

[Intel-gfx] Issue with cec_register_adapter calling request_module() from an async context when called from intel_dp_detect

2021-02-17 Thread Hans de Goede
Hi Hans, Fedora has a (opt-in) system to automatically collect backtraces from software crashing on users systems. This includes collecting kernel backtraces (including once triggered by WARN macros) while looking a the top 10 of the most reported backtrace during the last 2 weeks report from

[Intel-gfx] [PATCH libdrm 2/2] intel: add INTEL_ADLS_IDS to the pciids list

2021-02-17 Thread Tejas Upadhyay
This enables drm_intel_bufmgr on ADLS Signed-off-by: Tejas Upadhyay --- intel/intel_chipset.c | 1 + 1 file changed, 1 insertion(+) diff --git a/intel/intel_chipset.c b/intel/intel_chipset.c index 439db3e5..8ec36f82 100644 --- a/intel/intel_chipset.c +++ b/intel/intel_chipset.c @@ -35,6 +35,7

[Intel-gfx] [PATCH libdrm 1/2] intel: sync i915_pciids.h with kernel

2021-02-17 Thread Tejas Upadhyay
Align with kernel commits: 0883d63b19bb ("drm/i915/adl_s: Add ADL-S platform info and PCI ids") 04057a1afc75 ("drm/i915: Sort EHL/JSL PCI IDs") 0e8e272f1368 ("drm/i915/ehl: Remove invalid PCI ID") 605f9c290c1a ("drm/i915: Sort ICL PCI IDs") 514dc424ce4f ("drm/i915: Sort CNL PCI IDs") 32d4ec9a1681

[Intel-gfx] [PATCH libdrm 0/2] Update i915_pciids.h and support ADLS

2021-02-17 Thread Tejas Upadhyay
This series adds : 1. sync up of i915_pciids.h with kernel 2. Support for ADLS platform Tejas Upadhyay (2): intel: sync i915_pciids.h with kernel intel: add INTEL_ADLS_IDS to the pciids list intel/i915_pciids.h | 177 -- intel/intel_chipset.c | 1

[Intel-gfx] [PATCH] drm/i915: Enable -Wuninitialized

2021-02-17 Thread Nathan Chancellor
-Wunintialized was disabled in commit c5627461490e ("drm/i915: Disable -Wuninitialized") because there were two warnings that were false positives. The first was due to DECLARE_WAIT_QUEUE_HEAD_ONSTACK, which was fixed in LLVM 9.0.0. The second was in busywait_stop, which was fixed in LLVM 10.0.0

Re: [Intel-gfx] [RFC PATCH 0/9] drm/i915/spi: discrete graphics internal spi

2021-02-17 Thread Jani Nikula
On Tue, 16 Feb 2021, Tomas Winkler wrote: > Intel discrete graphic devices have internal spi storage, that holds > firmware and oprom images. The spi device is exposed to the user space > via mtd framework to be accessed during manufacturing. > The device is hardware locked after manufacturing

Re: [Intel-gfx] [RFC PATCH 3/9] drm/i915/spi: add driver for on-die spi device

2021-02-17 Thread Jani Nikula
On Tue, 16 Feb 2021, Tomas Winkler wrote: > Add the platform driver for i915 on-die spi device, exposed via mfd > framework. > > Cc: Rodrigo Vivi > Cc: Lucas De Marchi > Signed-off-by: Tomas Winkler > --- > drivers/gpu/drm/i915/Kconfig | 2 + > drivers/gpu/drm/i915/Makefile

Re: [Intel-gfx] [RFC PATCH 2/9] drm/i915/spi: intel_spi_region map

2021-02-17 Thread Jani Nikula
On Tue, 16 Feb 2021, Tomas Winkler wrote: > Add the dGFX spi region map and convey it via mfd cell platform data > to the spi child device. > > Cc: Rodrigo Vivi > Cc: Lucas De Marchi > Signed-off-by: Tomas Winkler > --- > drivers/gpu/drm/i915/spi/intel_spi.c | 9 + >

Re: [Intel-gfx] [RFC PATCH 1/9] drm/i915/spi: add spi device for discrete graphics

2021-02-17 Thread Jani Nikula
On Tue, 16 Feb 2021, Tomas Winkler wrote: > Enable access to internal spi on descrete devices via a child device. > The spi child device is exposed via MFD framework. > > Cc: Rodrigo Vivi > Cc: Lucas De Marchi # v3 > Signed-off-by: Tomas Winkler > --- > drivers/gpu/drm/i915/Kconfig |

Re: [Intel-gfx] [RFC PATCH 0/9] drm/i915/spi: discrete graphics internal spi

2021-02-17 Thread Jani Nikula
On Tue, 16 Feb 2021, Tomas Winkler wrote: > Intel discrete graphic devices have internal spi storage, that holds > firmware and oprom images. The spi device is exposed to the user space > via mtd framework to be accessed during manufacturing. > The device is hardware locked after manufacturing

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Enable WaProgramMgsrForCorrectSliceSpecificMmioReads for Gen9 (rev2)

2021-02-17 Thread Tvrtko Ursulin
Hi, On 09/02/2021 11:37, Chiou, Cooper wrote: From this CI warning log, there are all known warning message in i915 driver and is not caused by my patch. Warning 1: <3> [69.081809] [drm:wa_verify [i915]] *ERROR* engine workaround lost on application! (reg[b004]=0x0, relevant bits were

[Intel-gfx] ✗ Fi.CI.BUILD: failure for drm/i915: Enable WaProgramMgsrForCorrectSliceSpecificMmioReads for Gen9 (rev3)

2021-02-17 Thread Patchwork
== Series Details == Series: drm/i915: Enable WaProgramMgsrForCorrectSliceSpecificMmioReads for Gen9 (rev3) URL : https://patchwork.freedesktop.org/series/81764/ State : failure == Summary == Applying: drm/i915: Enable WaProgramMgsrForCorrectSliceSpecificMmioReads for Gen9 error: corrupt

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/vbt: update DP max link rate table (rev2)

2021-02-17 Thread Patchwork
== Series Details == Series: drm/i915/vbt: update DP max link rate table (rev2) URL : https://patchwork.freedesktop.org/series/86539/ State : success == Summary == CI Bug Log - changes from CI_DRM_9779_full -> Patchwork_19690_full Summary

Re: [Intel-gfx] [PATCH] drm/i915: Enable WaProgramMgsrForCorrectSliceSpecificMmioReads for Gen9

2021-02-17 Thread Chiou, Cooper
Hi upstream committee, Please consider to merge this patch which resolved VP8 hardware encoding GPU hang critical issue on Gen9 sku and there is no any performance regression on this fix. Meanwhile it's critical for Chrome projects need your help to review to merge it. Thanks, Best Regards,

Re: [Intel-gfx] [RFC PATCH 0/9] drm/i915/spi: discrete graphics internal spi

2021-02-17 Thread Winkler, Tomas
> > )On Tue, Feb 16, 2021 at 7:26 PM Tomas Winkler > wrote: > > Because the graphic card may undergo reset at any time and basically > > hot unplug all its child devices, this series also provides a fix to > > the mtd framework to make the reset graceful. > > Well, just because MTD does not

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/vbt: update DP max link rate table (rev2)

2021-02-17 Thread Patchwork
== Series Details == Series: drm/i915/vbt: update DP max link rate table (rev2) URL : https://patchwork.freedesktop.org/series/86539/ State : success == Summary == CI Bug Log - changes from CI_DRM_9779 -> Patchwork_19690 Summary ---

Re: [Intel-gfx] [PATCH v3 1/2] drm/i915/gen9bc: Handle TGP PCH during suspend/resume

2021-02-17 Thread Imre Deak
On Tue, Feb 16, 2021 at 09:53:36PM -0500, Lyude Paul wrote: > From: Tejas Upadhyay > > For Legacy S3 suspend/resume GEN9 BC needs to enable and > setup TGP PCH. > > v2: > * Move Wa_14010685332 into it's own function - vsyrjala > * Add TODO comment about figuring out if we can move this