[Intel-gfx] [PATCH V3] drm/i915/adl_s: Update ADL-S PCI IDs

2021-08-17 Thread Tejas Upadhyay
Sync PCI IDs with Bspec. Bspec:53655 Changes since V2: - Upstream devices which are "POR" yes and "Ok to upstream" yes - James Asmus Changes since V1: - All POR and Non POR Ids needs to be upstreamed - James Asmus Signed-off-by: Tejas Upadhyay ---

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Use designated initializers for init/exit table

2021-08-17 Thread Patchwork
== Series Details == Series: drm/i915: Use designated initializers for init/exit table URL : https://patchwork.freedesktop.org/series/93768/ State : success == Summary == CI Bug Log - changes from CI_DRM_10491_full -> Patchwork_20840_full

[Intel-gfx] ✗ Fi.CI.BAT: failure for Drop frontbuffer rendering support from Skylake and newer

2021-08-17 Thread Patchwork
== Series Details == Series: Drop frontbuffer rendering support from Skylake and newer URL : https://patchwork.freedesktop.org/series/93769/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10491 -> Patchwork_20841 Summary

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/damage_helper: Fix handling of cursor dirty buffers

2021-08-17 Thread Patchwork
== Series Details == Series: drm/damage_helper: Fix handling of cursor dirty buffers URL : https://patchwork.freedesktop.org/series/93765/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10491_full -> Patchwork_20839_full

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Drop frontbuffer rendering support from Skylake and newer

2021-08-17 Thread Patchwork
== Series Details == Series: Drop frontbuffer rendering support from Skylake and newer URL : https://patchwork.freedesktop.org/series/93769/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Drop frontbuffer rendering support from Skylake and newer

2021-08-17 Thread Patchwork
== Series Details == Series: Drop frontbuffer rendering support from Skylake and newer URL : https://patchwork.freedesktop.org/series/93769/ State : warning == Summary == $ dim checkpatch origin/drm-tip c4bc916870ba drm/damage_helper: Fix handling of cursor dirty buffers 1080e192fe73

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Use designated initializers for init/exit table

2021-08-17 Thread Patchwork
== Series Details == Series: drm/i915: Use designated initializers for init/exit table URL : https://patchwork.freedesktop.org/series/93768/ State : success == Summary == CI Bug Log - changes from CI_DRM_10491 -> Patchwork_20840 Summary

[Intel-gfx] [PATCH 5/8] drm/i915/display: Share code between intel_edp_drrs_flush and invalidate

2021-08-17 Thread José Roberto de Souza
Both functions are pretty much equal, with minor changes that can be handled by a single parameter. Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/display/intel_drrs.c | 82 +-- 1 file changed, 32 insertions(+), 50 deletions(-) diff --git

[Intel-gfx] [PATCH 6/8] drm/i915/display: Prepare DRRS for frontbuffer rendering drop

2021-08-17 Thread José Roberto de Souza
Frontbuffer rendering will be dropped for modern platforms but before that we to prepare DRRS for it. intel_edp_drrs_flush and intel_edp_drrs_invalidate will not be called for platforms that will not support frontbuffer rendering so DRRS needs another way to be notified about to page flips so it

[Intel-gfx] [PATCH 7/8] drm/i915/display/skl+: Drop frontbuffer rendering support

2021-08-17 Thread José Roberto de Souza
By now all the userspace applications should have migrated to atomic or at least be calling DRM_IOCTL_MODE_DIRTYFB. With that we can kill frontbuffer rendering support in i915 for modern platforms. So here converting legacy APIs into atomic commits so it can be properly handled by driver i915.

[Intel-gfx] [PATCH 2/8] drm/i915/display: Drop PSR support from HSW and BDW

2021-08-17 Thread José Roberto de Souza
At this point is sure that HSW and BDW will never have PSR enabled by default, so here dropping it from device info and cleaning up code. v2: - enable psr support for display 9 Cc: Gwan-gyeong Mun Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/display/intel_psr.c | 97

[Intel-gfx] [PATCH 0/8] Drop frontbuffer rendering support from Skylake and newer

2021-08-17 Thread José Roberto de Souza
This will break some IGT tests, here(https://patchwork.freedesktop.org/series/93764/) I fixed the ones part of fast-feedback test list but probably there will be more tests needing fix. The first patch was also sent separated to intel-gfx and dri-devel. Cc: Gwan-gyeong Mun Cc: Daniel Vetter

[Intel-gfx] [PATCH 3/8] drm/i915/display: Move DRRS code its own file

2021-08-17 Thread José Roberto de Souza
intel_dp.c is a 5k lines monster, so moving DRRS out of it to reduce some lines from it. Cc: Jani Nikula Cc: Rodrigo Vivi Signed-off-by: José Roberto de Souza --- Documentation/gpu/i915.rst| 14 +- drivers/gpu/drm/i915/Makefile | 1 +

[Intel-gfx] [PATCH 8/8] drm/i915/display: Drop PSR frontbuffer rendering support

2021-08-17 Thread José Roberto de Souza
After commit "drm/i915/display/skl+: Drop frontbuffer rendering support" frontbuffer rendering is not supported for display 9 and newer and as PSR is only supported by default in display 9 and newer we can now drop all frontbuffer rendering support for PSR code. Some DC3CO code was commented with

[Intel-gfx] [PATCH 4/8] drm/i915/display: Some code improvements and code style fixes for DRRS

2021-08-17 Thread José Roberto de Souza
It started as a code style fix for the lines above 100 col but it turned out to simplyfications to intel_dp_set_drrs_state(). Now it receives the desired refresh rate type, high or low. Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/display/intel_drrs.c | 60

[Intel-gfx] [PATCH 1/8] drm/damage_helper: Fix handling of cursor dirty buffers

2021-08-17 Thread José Roberto de Souza
Cursors don't have a framebuffer so the fb comparisson was always failing and atomic state was being committed without any plane state. So here checking if objects match when checking cursors. Fixes: b9fc5e01d1ce ("drm: Add helper to implement legacy dirtyfb") Cc: Daniel Vetter Cc: Rob Clark

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/damage_helper: Fix handling of cursor dirty buffers

2021-08-17 Thread Patchwork
== Series Details == Series: drm/damage_helper: Fix handling of cursor dirty buffers URL : https://patchwork.freedesktop.org/series/93765/ State : success == Summary == CI Bug Log - changes from CI_DRM_10491 -> Patchwork_20839 Summary

Re: [Intel-gfx] [PATCH 1/1] drm/i915: Check if engine has heartbeat when closing a context

2021-08-17 Thread John Harrison
On 8/9/2021 23:36, Daniel Vetter wrote: On Mon, Aug 09, 2021 at 04:12:52PM -0700, John Harrison wrote: On 8/6/2021 12:46, Daniel Vetter wrote: Seen this fly by and figured I dropped a few thoughts in here. At the likely cost of looking a bit out of whack :-) On Fri, Aug 6, 2021 at 8:01 PM

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm + usb-type-c: Add support for out-of-band hotplug notification (v4 resend)

2021-08-17 Thread Patchwork
== Series Details == Series: drm + usb-type-c: Add support for out-of-band hotplug notification (v4 resend) URL : https://patchwork.freedesktop.org/series/93762/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10491_full -> Patchwork_20838_full

Re: [Intel-gfx] [PATCH 0/1] Fix gem_ctx_persistence failures with GuC submission

2021-08-17 Thread John Harrison
On 8/9/2021 23:38, Daniel Vetter wrote: On Wed, Jul 28, 2021 at 05:33:59PM -0700, Matthew Brost wrote: Should fix below failures with GuC submission for the following tests: gem_exec_balancer --r noheartbeat gem_ctx_persistence --r heartbeat-close Not going to fix: gem_ctx_persistence --r

[Intel-gfx] [PATCH] drm/i915: Use designated initializers for init/exit table

2021-08-17 Thread Kees Cook
The kernel builds with -Werror=designated-init, and __designated_init is used by CONFIG_GCC_PLUGIN_RANDSTRUCT for automatically selected (all function pointer) structures. Include the field names in the init/exit table. Avoids warnings like: drivers/gpu/drm/i915/i915_module.c:59:4: error:

[Intel-gfx] ✓ Fi.CI.IGT: success for GPD Win Max display fixes (rev4)

2021-08-17 Thread Patchwork
== Series Details == Series: GPD Win Max display fixes (rev4) URL : https://patchwork.freedesktop.org/series/90483/ State : success == Summary == CI Bug Log - changes from CI_DRM_10491_full -> Patchwork_20837_full Summary ---

[Intel-gfx] [PATCH] drm/damage_helper: Fix handling of cursor dirty buffers

2021-08-17 Thread José Roberto de Souza
Cursors don't have a framebuffer so the fb comparisson was always failing and atomic state was being committed without any plane state. So here checking if objects match when checking cursors. Fixes: b9fc5e01d1ce ("drm: Add helper to implement legacy dirtyfb") Cc: Daniel Vetter Cc: Rob Clark

[Intel-gfx] ✓ Fi.CI.BAT: success for drm + usb-type-c: Add support for out-of-band hotplug notification (v4 resend)

2021-08-17 Thread Patchwork
== Series Details == Series: drm + usb-type-c: Add support for out-of-band hotplug notification (v4 resend) URL : https://patchwork.freedesktop.org/series/93762/ State : success == Summary == CI Bug Log - changes from CI_DRM_10491 -> Patchwork_20838

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm + usb-type-c: Add support for out-of-band hotplug notification (v4 resend)

2021-08-17 Thread Patchwork
== Series Details == Series: drm + usb-type-c: Add support for out-of-band hotplug notification (v4 resend) URL : https://patchwork.freedesktop.org/series/93762/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be

[Intel-gfx] ✓ Fi.CI.BAT: success for GPD Win Max display fixes (rev4)

2021-08-17 Thread Patchwork
== Series Details == Series: GPD Win Max display fixes (rev4) URL : https://patchwork.freedesktop.org/series/90483/ State : success == Summary == CI Bug Log - changes from CI_DRM_10491 -> Patchwork_20837 Summary --- **SUCCESS**

[Intel-gfx] [PATCH 8/8] usb: typec: altmodes/displayport: Notify drm subsys of hotplug events

2021-08-17 Thread Hans de Goede
Use the new drm_connector_oob_hotplug_event() functions to let drm/kms drivers know about DisplayPort over Type-C hotplug events. Reviewed-by: Heikki Krogerus Tested-by: Heikki Krogerus Signed-off-by: Hans de Goede --- Changes in v3: - Only call drm_connector_oob_hotplug_event() on hpd status

[Intel-gfx] [PATCH 7/8] usb: typec: altmodes/displayport: Make dp_altmode_notify() more generic

2021-08-17 Thread Hans de Goede
Make dp_altmode_notify() handle the dp->data.conf == 0 case too, rather then having separate code-paths for this in various places which call it. Reviewed-by: Heikki Krogerus Tested-by: Heikki Krogerus Signed-off-by: Hans de Goede --- drivers/usb/typec/altmodes/displayport.c | 35

[Intel-gfx] [PATCH 6/8] drm/i915/dp: Add support for out-of-bound hotplug events

2021-08-17 Thread Hans de Goede
On some Cherry Trail devices, DisplayPort over Type-C is supported through a USB-PD microcontroller (e.g. a fusb302) + a mux to switch the superspeed datalines between USB-3 and DP (e.g. a pi3usb30532). The kernel in this case does the PD/alt-mode negotiation itself, rather then everything being

[Intel-gfx] [PATCH 5/8] drm/i915: Associate ACPI connector nodes with connector entries (v2)

2021-08-17 Thread Hans de Goede
From: Heikki Krogerus On Intel platforms we know that the ACPI connector device node order will follow the order the driver (i915) decides. The decision is made using the custom Intel ACPI OpRegion (intel_opregion.c), though the driver does not actually know that the values it sends to ACPI

[Intel-gfx] [PATCH 4/8] drm/connector: Add support for out-of-band hotplug notification (v3)

2021-08-17 Thread Hans de Goede
Add a new drm_connector_oob_hotplug_event() function and oob_hotplug_event drm_connector_funcs member. On some hardware a hotplug event notification may come from outside the display driver / device. An example of this is some USB Type-C setups where the hardware muxes the DisplayPort data and

[Intel-gfx] [PATCH 3/8] drm/connector: Add drm_connector_find_by_fwnode() function (v3)

2021-08-17 Thread Hans de Goede
Add a function to find a connector based on a fwnode. This will be used by the new drm_connector_oob_hotplug_event() function which is added by the next patch in this patch-set. Changes in v2: - Complete rewrite to use a global connector list in drm_connector.c rather then using a

[Intel-gfx] [PATCH 2/8] drm/connector: Add a fwnode pointer to drm_connector and register with ACPI (v2)

2021-08-17 Thread Hans de Goede
Add a fwnode pointer to struct drm_connector and register an acpi_bus_type for the connectors with the ACPI subsystem (when CONFIG_ACPI is enabled). The adding of the fwnode pointer allows drivers to associate a fwnode that represents a connector with that connector. When the new fwnode pointer

[Intel-gfx] [PATCH 0/8] drm + usb-type-c: Add support for out-of-band hotplug notification (v4 resend)

2021-08-17 Thread Hans de Goede
Hi all, Here is a rebased-resend of v4 of my patchset making DP over Type-C work on devices where the Type-C controller does not drive the HPD pin on the GPU, but instead we need to forward HPD events from the Type-C controller to the DRM driver. Changes in v4 resend: - Rebase on top of latest

[Intel-gfx] [PATCH 1/8] drm/connector: Give connector sysfs devices there own device_type

2021-08-17 Thread Hans de Goede
Give connector sysfs devices there own device_type, this allows us to check if a device passed to functions dealing with generic devices is a drm_connector or not. A check like this is necessary in the drm_connector_acpi_bus_match() function added in the next patch in this series. Tested-by:

Re: [Intel-gfx] [PATCH 22/22] drm/i915/guc: Add GuC kernel doc

2021-08-17 Thread Daniel Vetter
On Tue, Aug 17, 2021 at 10:41 PM Michal Wajdeczko wrote: > On 17.08.2021 19:34, Daniel Vetter wrote: > > On Tue, Aug 17, 2021 at 07:27:18PM +0200, Michal Wajdeczko wrote: > >> On 17.08.2021 19:20, Daniel Vetter wrote: > >>> On Tue, Aug 17, 2021 at 09:36:49AM -0700, Matthew Brost wrote: > On

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for GPD Win Max display fixes (rev4)

2021-08-17 Thread Patchwork
== Series Details == Series: GPD Win Max display fixes (rev4) URL : https://patchwork.freedesktop.org/series/90483/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. -

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for GPD Win Max display fixes (rev4)

2021-08-17 Thread Patchwork
== Series Details == Series: GPD Win Max display fixes (rev4) URL : https://patchwork.freedesktop.org/series/90483/ State : warning == Summary == $ dim checkpatch origin/drm-tip b615ccdfa166 drm/i915/opregion: add support for mailbox #5 EDID -:24: WARNING:COMMIT_LOG_LONG_LINE: Possible

[Intel-gfx] [PATCH v3 2/2] drm: Add orientation quirk for GPD Win Max

2021-08-17 Thread Anisse Astier
Panel is 800x1280, but mounted on a laptop form factor, sideways. Reviewed-by: Hans de Goede Signed-off-by: Anisse Astier --- drivers/gpu/drm/drm_panel_orientation_quirks.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c

[Intel-gfx] [PATCH v3 1/2] drm/i915/opregion: add support for mailbox #5 EDID

2021-08-17 Thread Anisse Astier
The ACPI OpRegion Mailbox #5 ASLE extension may contain an EDID to be used for the embedded display. Add support for using it via by adding the EDID to the list of available modes on the connector, and use it for eDP when available. If a panel's EDID is broken, there may be an override EDID set

[Intel-gfx] [PATCH v3 0/2] GPD Win Max display fixes

2021-08-17 Thread Anisse Astier
This patch series is for making the GPD Win Max display usable with Linux. The GPD Win Max is a small laptop, and its eDP panel does not send an EDID over DPCD; the EDID is instead available in the intel opregion, in mailbox #5 [1] The first patch is based on Jani's patch series [2] adding

Re: [Intel-gfx] [PATCH 22/22] drm/i915/guc: Add GuC kernel doc

2021-08-17 Thread Michal Wajdeczko
On 17.08.2021 19:34, Daniel Vetter wrote: > On Tue, Aug 17, 2021 at 07:27:18PM +0200, Michal Wajdeczko wrote: >> >> >> On 17.08.2021 19:20, Daniel Vetter wrote: >>> On Tue, Aug 17, 2021 at 09:36:49AM -0700, Matthew Brost wrote: On Tue, Aug 17, 2021 at 01:11:41PM +0200, Daniel Vetter wrote:

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/adl_p: Also disable underrun recovery with MSO

2021-08-17 Thread Patchwork
== Series Details == Series: drm/i915/adl_p: Also disable underrun recovery with MSO URL : https://patchwork.freedesktop.org/series/93732/ State : success == Summary == CI Bug Log - changes from CI_DRM_10490_full -> Patchwork_20835_full

Re: [Intel-gfx] [PATCH 02/22] drm/i915/guc: Fix outstanding G2H accounting

2021-08-17 Thread Matthew Brost
On Tue, Aug 17, 2021 at 11:39:29AM +0200, Daniel Vetter wrote: > On Mon, Aug 16, 2021 at 06:51:19AM -0700, Matthew Brost wrote: > > A small race that could result in incorrect accounting of the number > > of outstanding G2H. Basically prior to this patch we did not increment > > the number of

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/sched dependency handling and implicit sync fixes (rev4)

2021-08-17 Thread Patchwork
== Series Details == Series: drm/sched dependency handling and implicit sync fixes (rev4) URL : https://patchwork.freedesktop.org/series/93415/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10490_full -> Patchwork_20836_full

Re: [Intel-gfx] [PATCH 22/22] drm/i915/guc: Add GuC kernel doc

2021-08-17 Thread Daniel Vetter
On Tue, Aug 17, 2021 at 07:27:18PM +0200, Michal Wajdeczko wrote: > > > On 17.08.2021 19:20, Daniel Vetter wrote: > > On Tue, Aug 17, 2021 at 09:36:49AM -0700, Matthew Brost wrote: > >> On Tue, Aug 17, 2021 at 01:11:41PM +0200, Daniel Vetter wrote: > >>> On Mon, Aug 16, 2021 at 06:51:39AM -0700,

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Ditch the i915_gem_ww_ctx loop member (rev2)

2021-08-17 Thread Patchwork
== Series Details == Series: drm/i915: Ditch the i915_gem_ww_ctx loop member (rev2) URL : https://patchwork.freedesktop.org/series/93711/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10490_full -> Patchwork_20834_full

Re: [Intel-gfx] [PATCH 22/22] drm/i915/guc: Add GuC kernel doc

2021-08-17 Thread Michal Wajdeczko
On 17.08.2021 19:20, Daniel Vetter wrote: > On Tue, Aug 17, 2021 at 09:36:49AM -0700, Matthew Brost wrote: >> On Tue, Aug 17, 2021 at 01:11:41PM +0200, Daniel Vetter wrote: >>> On Mon, Aug 16, 2021 at 06:51:39AM -0700, Matthew Brost wrote: Add GuC kernel doc for all structures added thus

Re: [Intel-gfx] [PATCH 22/22] drm/i915/guc: Add GuC kernel doc

2021-08-17 Thread Daniel Vetter
On Tue, Aug 17, 2021 at 09:36:49AM -0700, Matthew Brost wrote: > On Tue, Aug 17, 2021 at 01:11:41PM +0200, Daniel Vetter wrote: > > On Mon, Aug 16, 2021 at 06:51:39AM -0700, Matthew Brost wrote: > > > Add GuC kernel doc for all structures added thus far for GuC submission > > > and update the main

Re: [Intel-gfx] [PATCH 19/22] drm/i915/guc: Proper xarray usage for contexts_lookup

2021-08-17 Thread Matthew Brost
On Tue, Aug 17, 2021 at 07:13:33PM +0200, Daniel Vetter wrote: > On Tue, Aug 17, 2021 at 08:26:28AM -0700, Matthew Brost wrote: > > On Tue, Aug 17, 2021 at 12:27:29PM +0200, Daniel Vetter wrote: > > > On Mon, Aug 16, 2021 at 06:51:36AM -0700, Matthew Brost wrote: > > > > Lock the xarray and take

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/adl_p: Also disable underrun recovery with MSO

2021-08-17 Thread Vudum, Lakshminarayana
Re-reported. -Original Message- From: Roper, Matthew D Sent: Tuesday, August 17, 2021 9:26 AM To: intel-gfx@lists.freedesktop.org Cc: Vudum, Lakshminarayana Subject: Re: ✗ Fi.CI.BAT: failure for drm/i915/adl_p: Also disable underrun recovery with MSO On Tue, Aug 17, 2021 at

Re: [Intel-gfx] [PATCH 19/22] drm/i915/guc: Proper xarray usage for contexts_lookup

2021-08-17 Thread Daniel Vetter
On Tue, Aug 17, 2021 at 08:26:28AM -0700, Matthew Brost wrote: > On Tue, Aug 17, 2021 at 12:27:29PM +0200, Daniel Vetter wrote: > > On Mon, Aug 16, 2021 at 06:51:36AM -0700, Matthew Brost wrote: > > > Lock the xarray and take ref to the context if needed. > > > > > > v2: > > > (Checkpatch) > > >

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/adl_p: Also disable underrun recovery with MSO

2021-08-17 Thread Patchwork
== Series Details == Series: drm/i915/adl_p: Also disable underrun recovery with MSO URL : https://patchwork.freedesktop.org/series/93732/ State : success == Summary == CI Bug Log - changes from CI_DRM_10490 -> Patchwork_20835 Summary

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/sched dependency handling and implicit sync fixes (rev4)

2021-08-17 Thread Patchwork
== Series Details == Series: drm/sched dependency handling and implicit sync fixes (rev4) URL : https://patchwork.freedesktop.org/series/93415/ State : success == Summary == CI Bug Log - changes from CI_DRM_10490 -> Patchwork_20836 Summary

Re: [Intel-gfx] [PATCH 08/22] drm/i915/guc: Don't enable scheduling on a banned context, guc_id invalid, not registered

2021-08-17 Thread Matthew Brost
On Tue, Aug 17, 2021 at 11:47:53AM +0200, Daniel Vetter wrote: > On Mon, Aug 16, 2021 at 06:51:25AM -0700, Matthew Brost wrote: > > When unblocking a context, do not enable scheduling if the context is > > banned, guc_id invalid, or not registered. > > > > Fixes: 62eaf0ae217d ("drm/i915/guc:

Re: [Intel-gfx] [PATCH 22/22] drm/i915/guc: Add GuC kernel doc

2021-08-17 Thread Matthew Brost
On Tue, Aug 17, 2021 at 01:11:41PM +0200, Daniel Vetter wrote: > On Mon, Aug 16, 2021 at 06:51:39AM -0700, Matthew Brost wrote: > > Add GuC kernel doc for all structures added thus far for GuC submission > > and update the main GuC submission section with the new interface > > details. > > > >

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/sched dependency handling and implicit sync fixes (rev4)

2021-08-17 Thread Patchwork
== Series Details == Series: drm/sched dependency handling and implicit sync fixes (rev4) URL : https://patchwork.freedesktop.org/series/93415/ State : warning == Summary == $ dim checkpatch origin/drm-tip 0d891258e40a drm/sched: Split drm_sched_job_init -:240: WARNING:UNSPECIFIED_INT: Prefer

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/adl_p: Also disable underrun recovery with MSO

2021-08-17 Thread Matt Roper
On Tue, Aug 17, 2021 at 04:02:14PM +, Patchwork wrote: > == Series Details == > > Series: drm/i915/adl_p: Also disable underrun recovery with MSO > URL : https://patchwork.freedesktop.org/series/93732/ > State : failure > > == Summary == > > CI Bug Log - changes from CI_DRM_10490 ->

Re: [Intel-gfx] [PATCH 14/22] drm/i915: Allocate error capture in atomic context

2021-08-17 Thread Matthew Brost
On Tue, Aug 17, 2021 at 12:06:16PM +0200, Daniel Vetter wrote: > On Mon, Aug 16, 2021 at 06:51:31AM -0700, Matthew Brost wrote: > > Error captures can now be done in a work queue processing G2H messages. > > These messages need to be completely done being processed in the reset > > path, to avoid

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/adl_p: Also disable underrun recovery with MSO

2021-08-17 Thread Patchwork
== Series Details == Series: drm/i915/adl_p: Also disable underrun recovery with MSO URL : https://patchwork.freedesktop.org/series/93732/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10490 -> Patchwork_20835 Summary

Re: [Intel-gfx] [PATCH v2] drm: avoid races with modesetting rights

2021-08-17 Thread Desmond Cheong Zhi Xi
On 16/8/21 9:59 pm, Daniel Vetter wrote: On Mon, Aug 16, 2021 at 12:31 PM Desmond Cheong Zhi Xi wrote: On 16/8/21 5:04 pm, Daniel Vetter wrote: On Mon, Aug 16, 2021 at 10:53 AM Desmond Cheong Zhi Xi wrote: On 16/8/21 2:47 am, kernel test robot wrote: Hi Desmond, Thank you for the patch!

Re: [Intel-gfx] [PATCH 06/22] drm/i915/execlists: Do not propagate errors to dependent fences

2021-08-17 Thread Daniel Vetter
On Tue, Aug 17, 2021 at 5:13 PM Matthew Brost wrote: > On Tue, Aug 17, 2021 at 11:21:27AM +0200, Daniel Vetter wrote: > > On Mon, Aug 16, 2021 at 06:51:23AM -0700, Matthew Brost wrote: > > > Progagating errors to dependent fences is wrong, don't do it. Selftest > > > in following patch exposes

Re: [Intel-gfx] [PATCH 18/22] drm/i915/guc: Rework and simplify locking

2021-08-17 Thread Matthew Brost
On Tue, Aug 17, 2021 at 12:15:21PM +0200, Daniel Vetter wrote: > On Mon, Aug 16, 2021 at 06:51:35AM -0700, Matthew Brost wrote: > > Rework and simplify the locking with GuC subission. Drop > > sched_state_no_lock and move all fields under the guc_state.sched_state > > and protect all these fields

Re: [Intel-gfx] [PATCH 19/22] drm/i915/guc: Proper xarray usage for contexts_lookup

2021-08-17 Thread Matthew Brost
On Tue, Aug 17, 2021 at 12:27:29PM +0200, Daniel Vetter wrote: > On Mon, Aug 16, 2021 at 06:51:36AM -0700, Matthew Brost wrote: > > Lock the xarray and take ref to the context if needed. > > > > v2: > > (Checkpatch) > > - Add new line after declaration > > > > Signed-off-by: Matthew Brost >

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Ditch the i915_gem_ww_ctx loop member (rev2)

2021-08-17 Thread Patchwork
== Series Details == Series: drm/i915: Ditch the i915_gem_ww_ctx loop member (rev2) URL : https://patchwork.freedesktop.org/series/93711/ State : success == Summary == CI Bug Log - changes from CI_DRM_10490 -> Patchwork_20834 Summary

Re: [Intel-gfx] [PATCH 06/22] drm/i915/execlists: Do not propagate errors to dependent fences

2021-08-17 Thread Matthew Brost
On Tue, Aug 17, 2021 at 11:21:27AM +0200, Daniel Vetter wrote: > On Mon, Aug 16, 2021 at 06:51:23AM -0700, Matthew Brost wrote: > > Progagating errors to dependent fences is wrong, don't do it. Selftest > > in following patch exposes this bug. > > Please explain what "this bug" is, it's hard to

Re: [Intel-gfx] [PATCH 05/22] drm/i915/guc: Workaround reset G2H is received after schedule done G2H

2021-08-17 Thread Matthew Brost
On Tue, Aug 17, 2021 at 11:32:56AM +0200, Daniel Vetter wrote: > On Mon, Aug 16, 2021 at 06:51:22AM -0700, Matthew Brost wrote: > > If the context is reset as a result of the request cancelation the > > context reset G2H is received after schedule disable done G2H which is > > likely the wrong

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Ditch the i915_gem_ww_ctx loop member (rev2)

2021-08-17 Thread Patchwork
== Series Details == Series: drm/i915: Ditch the i915_gem_ww_ctx loop member (rev2) URL : https://patchwork.freedesktop.org/series/93711/ State : warning == Summary == $ dim checkpatch origin/drm-tip 32dc940d3e7e drm/i915: Ditch the i915_gem_ww_ctx loop member -:70: CHECK:MACRO_ARG_REUSE:

[Intel-gfx] ✗ Fi.CI.IGT: failure for Clean up GuC CI failures, simplify locking, and kernel DOC (rev2)

2021-08-17 Thread Patchwork
== Series Details == Series: Clean up GuC CI failures, simplify locking, and kernel DOC (rev2) URL : https://patchwork.freedesktop.org/series/93704/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10490_full -> Patchwork_20833_full

[Intel-gfx] ✓ Fi.CI.BAT: success for Clean up GuC CI failures, simplify locking, and kernel DOC (rev2)

2021-08-17 Thread Patchwork
== Series Details == Series: Clean up GuC CI failures, simplify locking, and kernel DOC (rev2) URL : https://patchwork.freedesktop.org/series/93704/ State : success == Summary == CI Bug Log - changes from CI_DRM_10490 -> Patchwork_20833

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Clean up GuC CI failures, simplify locking, and kernel DOC (rev2)

2021-08-17 Thread Patchwork
== Series Details == Series: Clean up GuC CI failures, simplify locking, and kernel DOC (rev2) URL : https://patchwork.freedesktop.org/series/93704/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Clean up GuC CI failures, simplify locking, and kernel DOC (rev2)

2021-08-17 Thread Patchwork
== Series Details == Series: Clean up GuC CI failures, simplify locking, and kernel DOC (rev2) URL : https://patchwork.freedesktop.org/series/93704/ State : warning == Summary == $ dim checkpatch origin/drm-tip b9583f1b134e drm/i915/guc: Fix blocked context accounting 5703206b5f51

Re: [Intel-gfx] [PATCH 22/22] drm/i915/guc: Add GuC kernel doc

2021-08-17 Thread Daniel Vetter
On Mon, Aug 16, 2021 at 06:51:39AM -0700, Matthew Brost wrote: > Add GuC kernel doc for all structures added thus far for GuC submission > and update the main GuC submission section with the new interface > details. > > Signed-off-by: Matthew Brost There's quite a bit more, e.g. intel_guc_ct,

Re: [Intel-gfx] [PATCH 19/22] drm/i915/guc: Proper xarray usage for contexts_lookup

2021-08-17 Thread Daniel Vetter
On Mon, Aug 16, 2021 at 06:51:36AM -0700, Matthew Brost wrote: > Lock the xarray and take ref to the context if needed. > > v2: > (Checkpatch) > - Add new line after declaration > > Signed-off-by: Matthew Brost > --- > .../gpu/drm/i915/gt/uc/intel_guc_submission.c | 84 --- >

Re: [Intel-gfx] [PATCH 18/22] drm/i915/guc: Rework and simplify locking

2021-08-17 Thread Daniel Vetter
On Mon, Aug 16, 2021 at 06:51:35AM -0700, Matthew Brost wrote: > Rework and simplify the locking with GuC subission. Drop > sched_state_no_lock and move all fields under the guc_state.sched_state > and protect all these fields with guc_state.lock . This requires > changing the locking hierarchy

Re: [Intel-gfx] [PATCH 17/22] drm/i915/guc: Move guc_blocked fence to struct guc_state

2021-08-17 Thread Daniel Vetter
On Mon, Aug 16, 2021 at 06:51:34AM -0700, Matthew Brost wrote: > Move guc_blocked fence to struct guc_state as the lock which protects > the fence lives there. > > s/ce->guc_blocked/ce->guc_state.blocked_fence/g > > Signed-off-by: Matthew Brost General comment, but latest when your combine

Re: [Intel-gfx] [PATCH 16/22] drm/i915/guc: Release submit fence from an IRQ

2021-08-17 Thread Daniel Vetter
On Mon, Aug 16, 2021 at 06:51:33AM -0700, Matthew Brost wrote: > A subsequent patch will flip the locking hierarchy from > ce->guc_state.lock -> sched_engine->lock to sched_engine->lock -> > ce->guc_state.lock. As such we need to release the submit fence for a > request from an IRQ to break a lock

Re: [Intel-gfx] [PATCH 15/22] drm/i915/guc: Flush G2H work queue during reset

2021-08-17 Thread Daniel Vetter
On Mon, Aug 16, 2021 at 06:51:32AM -0700, Matthew Brost wrote: > It isn't safe to scrub for missing G2H or continue with the reset until > all G2H processing is complete. Flush the G2H work queue during reset to > ensure it is done running. > > Fixes: eb5e7da736f3 ("drm/i915/guc: Reset

Re: [Intel-gfx] [PATCH 14/22] drm/i915: Allocate error capture in atomic context

2021-08-17 Thread Daniel Vetter
On Mon, Aug 16, 2021 at 06:51:31AM -0700, Matthew Brost wrote: > Error captures can now be done in a work queue processing G2H messages. > These messages need to be completely done being processed in the reset > path, to avoid races in the missing G2H cleanup, which create a > dependency on memory

Re: [Intel-gfx] [PATCH 08/22] drm/i915/guc: Don't enable scheduling on a banned context, guc_id invalid, not registered

2021-08-17 Thread Daniel Vetter
On Tue, Aug 17, 2021 at 11:47:53AM +0200, Daniel Vetter wrote: > On Mon, Aug 16, 2021 at 06:51:25AM -0700, Matthew Brost wrote: > > When unblocking a context, do not enable scheduling if the context is > > banned, guc_id invalid, or not registered. > > > > Fixes: 62eaf0ae217d ("drm/i915/guc:

Re: [Intel-gfx] [PATCH 08/22] drm/i915/guc: Don't enable scheduling on a banned context, guc_id invalid, not registered

2021-08-17 Thread Daniel Vetter
On Mon, Aug 16, 2021 at 06:51:25AM -0700, Matthew Brost wrote: > When unblocking a context, do not enable scheduling if the context is > banned, guc_id invalid, or not registered. > > Fixes: 62eaf0ae217d ("drm/i915/guc: Support request cancellation") > Signed-off-by: Matthew Brost > Cc: > --- >

Re: [Intel-gfx] [PATCH 02/22] drm/i915/guc: Fix outstanding G2H accounting

2021-08-17 Thread Daniel Vetter
On Mon, Aug 16, 2021 at 06:51:19AM -0700, Matthew Brost wrote: > A small race that could result in incorrect accounting of the number > of outstanding G2H. Basically prior to this patch we did not increment > the number of outstanding G2H if we encoutered a GT reset while sending > a H2G. This was

Re: [Intel-gfx] [PATCH 05/22] drm/i915/guc: Workaround reset G2H is received after schedule done G2H

2021-08-17 Thread Daniel Vetter
On Mon, Aug 16, 2021 at 06:51:22AM -0700, Matthew Brost wrote: > If the context is reset as a result of the request cancelation the > context reset G2H is received after schedule disable done G2H which is > likely the wrong order. The schedule disable done G2H release the > waiting request

Re: [Intel-gfx] [PATCH 06/22] drm/i915/execlists: Do not propagate errors to dependent fences

2021-08-17 Thread Daniel Vetter
On Mon, Aug 16, 2021 at 06:51:23AM -0700, Matthew Brost wrote: > Progagating errors to dependent fences is wrong, don't do it. Selftest > in following patch exposes this bug. Please explain what "this bug" is, it's hard to read minds, especially at a distance in spacetime :-) > Fixes:

Re: [Intel-gfx] [PATCH v6 10/15] drm/i915/pxp: interfaces for using protected objects

2021-08-17 Thread Daniel Vetter
On Mon, Aug 16, 2021 at 08:58:49AM -0700, Daniele Ceraolo Spurio wrote: > > > On 8/16/2021 8:15 AM, Daniel Vetter wrote: > > On Fri, Aug 13, 2021 at 08:18:02AM -0700, Daniele Ceraolo Spurio wrote: > > > > > > On 8/13/2021 7:37 AM, Daniel Vetter wrote: > > > > On Wed, Jul 28, 2021 at 07:01:01PM

[Intel-gfx] [PATCH] drm/msm: Improve drm/sched point of no return rules

2021-08-17 Thread Daniel Vetter
Originally drm_sched_job_init was the point of no return, after which drivers really should submit a job. I've split that up, which allows us to fix this issue pretty easily. Only thing we have to take care of is to not skip to error paths after that. Other drivers do this the same for out-fence

[Intel-gfx] [PATCH] drm/sched: Split drm_sched_job_init

2021-08-17 Thread Daniel Vetter
This is a very confusingly named function, because not just does it init an object, it arms it and provides a point of no return for pushing a job into the scheduler. It would be nice if that's a bit clearer in the interface. But the real reason is that I want to push the dependency tracking

Re: [Intel-gfx] [PATCH 05/10] drm/i915/bios: Enable parse of two integrated panels eDP data

2021-08-17 Thread Jani Nikula
On Wed, 21 Jul 2021, José Roberto de Souza wrote: > +struct vbt_edp_info * > +intel_bios_edp_info(struct intel_encoder *encoder) > +{ > + struct drm_i915_private *i915 = to_i915(encoder->base.dev); > + > + return >vbt.ddi_port_info[encoder->port].edp; > +} Btw, I also have WIP to

Re: [Intel-gfx] [PATCH 12/22] drm/i915/guc: Don't touch guc_state.sched_state without a lock

2021-08-17 Thread kernel test robot
-220020 base: git://anongit.freedesktop.org/drm-intel for-linux-next config: i386-randconfig-a006-20210817 (attached as .config) compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 2c6448cdc2f68f8c28fd0bd9404182b81306e6e6) reproduce (this is a W=1 build): wget https