Re: [Intel-gfx] [PATCH] drm/i915/guc/slpc: remove unneeded clflush calls

2021-09-20 Thread Lucas De Marchi
On Wed, Sep 15, 2021 at 12:29:12PM -0700, John Harrison wrote: On 9/15/2021 12:24, Belgaumkar, Vinay wrote: On 9/14/2021 12:51 PM, Lucas De Marchi wrote: The clflush calls here aren't doing anything since we are not writting something and flushing the cache lines to be visible to GuC. Here the

Re: [Intel-gfx] [PATCH 3/3] drm/i915: remove some debug-only registers from MCHBAR

2021-09-20 Thread Lucas De Marchi
On Tue, Sep 07, 2021 at 02:56:21PM -0700, Lucas De Marchi wrote: On Tue, Jul 06, 2021 at 04:44:30PM -0700, Lucas De Marchi wrote: On Thu, Nov 05, 2020 at 10:02:27AM +0200, Joonas Lahtinen wrote: Quoting Lucas De Marchi (2020-11-05 03:04:22) On Wed, Nov 04, 2020 at 11:55:15AM +0200, Joonas

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/display: Fix the dsc check while selecting min_cdclk (rev3)

2021-09-20 Thread Patchwork
== Series Details == Series: drm/i915/display: Fix the dsc check while selecting min_cdclk (rev3) URL : https://patchwork.freedesktop.org/series/94683/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10615_full -> Patchwork_21104_full

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for Check SFC fusing on Xe_HP (rev4)

2021-09-20 Thread Matt Roper
On Tue, Sep 21, 2021 at 02:13:42AM +, Patchwork wrote: > == Series Details == > > Series: Check SFC fusing on Xe_HP (rev4) > URL : https://patchwork.freedesktop.org/series/94808/ > State : failure > > == Summary == > > CI Bug Log - changes from CI_DRM_10613_full -> Patchwork_21099_full >

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/display: Fix the dsc check while selecting min_cdclk (rev3)

2021-09-20 Thread Patchwork
== Series Details == Series: drm/i915/display: Fix the dsc check while selecting min_cdclk (rev3) URL : https://patchwork.freedesktop.org/series/94683/ State : success == Summary == CI Bug Log - changes from CI_DRM_10615 -> Patchwork_21104

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/tc: Fix TypeC connect/disconnect sequences

2021-09-20 Thread Patchwork
== Series Details == Series: drm/i915/tc: Fix TypeC connect/disconnect sequences URL : https://patchwork.freedesktop.org/series/94878/ State : success == Summary == CI Bug Log - changes from CI_DRM_10615_full -> Patchwork_21102_full

[Intel-gfx] ✗ Fi.CI.IGT: failure for Check SFC fusing on Xe_HP (rev4)

2021-09-20 Thread Patchwork
== Series Details == Series: Check SFC fusing on Xe_HP (rev4) URL : https://patchwork.freedesktop.org/series/94808/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10613_full -> Patchwork_21099_full Summary ---

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [v3,1/3] drm/i915/display: Disable frontbuffer rendering when PSR2 selective fetch is enabled

2021-09-20 Thread Patchwork
== Series Details == Series: series starting with [v3,1/3] drm/i915/display: Disable frontbuffer rendering when PSR2 selective fetch is enabled URL : https://patchwork.freedesktop.org/series/94879/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10615 -> Patchwork_21103

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [v3,1/3] drm/i915/display: Disable frontbuffer rendering when PSR2 selective fetch is enabled

2021-09-20 Thread Patchwork
== Series Details == Series: series starting with [v3,1/3] drm/i915/display: Disable frontbuffer rendering when PSR2 selective fetch is enabled URL : https://patchwork.freedesktop.org/series/94879/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [v3,1/3] drm/i915/display: Disable frontbuffer rendering when PSR2 selective fetch is enabled

2021-09-20 Thread Patchwork
== Series Details == Series: series starting with [v3,1/3] drm/i915/display: Disable frontbuffer rendering when PSR2 selective fetch is enabled URL : https://patchwork.freedesktop.org/series/94879/ State : warning == Summary == $ dim checkpatch origin/drm-tip 32149725ef4a drm/i915/display:

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/tc: Fix TypeC connect/disconnect sequences

2021-09-20 Thread Patchwork
== Series Details == Series: drm/i915/tc: Fix TypeC connect/disconnect sequences URL : https://patchwork.freedesktop.org/series/94878/ State : success == Summary == CI Bug Log - changes from CI_DRM_10615 -> Patchwork_21102 Summary ---

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for Check SFC fusing on Xe_HP (rev4)

2021-09-20 Thread Vudum, Lakshminarayana
Created a new issue for the regression failures and re-reported. https://gitlab.freedesktop.org/drm/intel/-/issues/4179 Lakshmi. -Original Message- From: Roper, Matthew D Sent: Monday, September 20, 2021 1:25 PM To: intel-gfx@lists.freedesktop.org Cc: Vudum, Lakshminarayana Subject:

[Intel-gfx] ✓ Fi.CI.BAT: success for Check SFC fusing on Xe_HP (rev4)

2021-09-20 Thread Patchwork
== Series Details == Series: Check SFC fusing on Xe_HP (rev4) URL : https://patchwork.freedesktop.org/series/94808/ State : success == Summary == CI Bug Log - changes from CI_DRM_10613 -> Patchwork_21099 Summary --- **SUCCESS**

[Intel-gfx] ✗ Fi.CI.BAT: failure for Check SFC fusing on Xe_HP (rev4)

2021-09-20 Thread Patchwork
== Series Details == Series: Check SFC fusing on Xe_HP (rev4) URL : https://patchwork.freedesktop.org/series/94808/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10613 -> Patchwork_21099 Summary --- **FAILURE**

[Intel-gfx] [PATCH v3 2/3] drm/i915/display: Only keep PSR enabled if there is active planes

2021-09-20 Thread José Roberto de Souza
PSR always had a requirement to only be enabled if there is active planes but not following that never caused any issues. But that changes in Alderlake-P, leaving PSR enabled without active planes causes transcoder/port underruns. Similar behavior was fixed during the pipe disable sequence by

[Intel-gfx] [PATCH v3 3/3] drm/i915/display/psr: Do full fetch when handling biplanar formats

2021-09-20 Thread José Roberto de Souza
From: Gwan-gyeong Mun We are still missing the PSR2 selective fetch handling of biplanar formats but until proper handle is added we can workaround it by doing full frames fetch when state has biplanar formats. We need the second check because an update in a regular format could intersect with

[Intel-gfx] [PATCH v3 1/3] drm/i915/display: Disable frontbuffer rendering when PSR2 selective fetch is enabled

2021-09-20 Thread José Roberto de Souza
By now all the userspace applications should have migrated to atomic or at least be calling DRM_IOCTL_MODE_DIRTYFB. But we still can't kill frontbuffer rendering support for good as we have some performance issues to be solved in desktop environments that do not use compositors. But PSR2

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/tc: Fix TypeC connect/disconnect sequences

2021-09-20 Thread Patchwork
== Series Details == Series: drm/i915/tc: Fix TypeC connect/disconnect sequences URL : https://patchwork.freedesktop.org/series/94878/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. -

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/tc: Fix TypeC connect/disconnect sequences

2021-09-20 Thread Patchwork
== Series Details == Series: drm/i915/tc: Fix TypeC connect/disconnect sequences URL : https://patchwork.freedesktop.org/series/94878/ State : warning == Summary == $ dim checkpatch origin/drm-tip 9d2a21b4286f drm/i915/tc: Fix TypeC port init/resume time sanitization 8cf6d77baac7

[Intel-gfx] [PATCH 12/13] drm/i915/tc: Drop extra TC cold blocking from intel_tc_port_connected()

2021-09-20 Thread Imre Deak
After the previous patch the driver holds a power domain blocking TC-cold whenever the port is locked, so we can remove the extra blocking around the lock/unlock sequence. Cc: José Roberto de Souza Signed-off-by: Imre Deak --- drivers/gpu/drm/i915/display/intel_tc.c | 4 1 file changed, 4

[Intel-gfx] [PATCH 11/13] drm/i915/tc: Fix TypeC PHY connect/disconnect logic on ADL-P

2021-09-20 Thread Imre Deak
So far TC-cold was blocked only for the duration of TypeC mode resets. The DP-alt and legacy modes require TC-cold to be blocked also whenever the port is in use (AUX transfers, enable modeset), and this was ensured by the held PHY ownership flag. On ADL-P this doesn't work, since the PHY

[Intel-gfx] [PATCH 06/13] drm/i915/tc: Don't keep legacy TypeC ports in connected state w/o a sink

2021-09-20 Thread Imre Deak
A follow-up patch will disconnect/reconnect PHYs around AUX transfers and modeset enable/disables. To prepare for that and make things consistent for all TypeC modes stop connecting the PHY in legacy mode without a sink being connected. This was done before since in legacy mode the PHY is

[Intel-gfx] [PATCH 13/13] drm/i915/tc: Fix system hang on ADL-P during TypeC PHY disconnect

2021-09-20 Thread Imre Deak
The PHY ownership release->AUX PW disable steps during a modeset disable->PHY disconnect sequence can hang the system if the PHY disconnect happens after disabling the PHY's PLL. The spec doesn't require a specific order for these two steps, so this issue is still being root caused by HW/FW teams.

[Intel-gfx] [PATCH 09/13] drm/i915/tc: Avoid using legacy AUX PW in TBT mode

2021-09-20 Thread Imre Deak
For the ADL-P TBT mode the spec doesn't require blocking TC-cold by using the legacy AUX power domain. To avoid the timeouts that this would cause during PHY disconnect/reconnect sequences (which will be more frequent after a follow-up change) use the TC_COLD_OFF power domain in TBT mode on all

[Intel-gfx] [PATCH 10/13] drm/i915/icl/tc: Remove the ICL special casing during TC-cold blocking

2021-09-20 Thread Imre Deak
While a TypeC port mode is locked a DISPLAY_CORE power domain reference is held, which implies a runtime PM ref. By removing the ICL !legacy port special casing, a TC_COLD_OFF power domain reference will be taken for such ports, which also translates to a runtime PM ref on that platform. A

[Intel-gfx] [PATCH 03/13] drm/i915/tc: Remove waiting for PHY complete during releasing ownership

2021-09-20 Thread Imre Deak
Waiting for the PHY complete flag to clear when releasing the PHY ownership was add in commit ddec362724f9 ("drm/i915: Wait for TypeC PHY complete flag to clear in safe mode") This isn't required by the spec, the vague idea was to make the handshake with the firmware more robust, without actual

[Intel-gfx] [PATCH 07/13] drm/i915/tc: Add a mode for the TypeC PHY's disconnected state

2021-09-20 Thread Imre Deak
A follow-up change will start to disconnect/re-connect PHYs around AUX transfers and modeset enable/disables. To prepare for that add a new TypeC PHY disconnected mode, to help tracking the TC-cold blocking power domain status (no power domain in disconnected state, mode dependent power domain in

[Intel-gfx] [PATCH 08/13] drm/i915/tc: Refactor TC-cold block/unblock helpers

2021-09-20 Thread Imre Deak
A follow-up change will select the TC-cold blocking power domain based on the TypeC mode, prepare for that here. Also bring intel_tc_cold_requires_aux_pw() earlier to its logical place for readability. No functional change. Cc: José Roberto de Souza Signed-off-by: Imre Deak ---

[Intel-gfx] [PATCH 05/13] drm/i915/tc: Add/use helpers to retrieve TypeC port properties

2021-09-20 Thread Imre Deak
Instead of directly accessing the TypeC port internal struct members, add/use helpers to retrieve the corresponding properties. No functional change. Cc: José Roberto de Souza Signed-off-by: Imre Deak --- drivers/gpu/drm/i915/display/intel_ddi.c | 31 +++

[Intel-gfx] [PATCH 04/13] drm/i915/tc: Check for DP-alt, legacy sinks before taking PHY ownership

2021-09-20 Thread Imre Deak
On ADL-P the PHY ready/complete flag is always set even in TBT-alt mode. To avoid taking the PHY ownership and the following spurious "PHY sudden disconnect" messages on this platform when connecting the PHY in TBT mode, check if there is any DP-alt or legacy sink connected before taking the

[Intel-gfx] [PATCH 01/13] drm/i915/tc: Fix TypeC port init/resume time sanitization

2021-09-20 Thread Imre Deak
Atm during driver loading and system resume TypeC ports are accessed before their HW/SW state is synced. Move the TypeC port sanitization to the encoder's sync_state hook to fix this. Fixes: f9e76a6e68d3 ("drm/i915: Add an encoder hook to sanitize its state during init/resume") Cc: José Roberto

[Intel-gfx] [PATCH 02/13] drm/i915/adlp/tc: Fix PHY connected check for Thunderbolt mode

2021-09-20 Thread Imre Deak
On ADL-P the PHY ready (aka status complete on other platforms) flag is always set, besides when a DP-alt, legacy sink is connected also when a TBT sink is connected or nothing is connected. So assume the PHY to be connected when both the TBT live status and PHY ready flags are set. Cc: José

[Intel-gfx] [PATCH 00/13] drm/i915/tc: Fix TypeC connect/disconnect sequences

2021-09-20 Thread Imre Deak
This patchset fixes two issues on ADL-P related to the TypeC PHY connect/disconnect sequences in patch 11 and 13 and a few other minor TypeC issues I noticed on the way. The fix in patch 11 requires some refactoring and it affects all TypeC platforms; this was the way that made sense to me to keep

Re: [Intel-gfx] [PATCH 21/27] drm/i915/doc: Update parallel submit doc to point to i915_drm.h

2021-09-20 Thread John Harrison
On 8/20/2021 15:44, Matthew Brost wrote: Update parallel submit doc to point to i915_drm.h Signed-off-by: Matthew Brost Reviewed-by: John Harrison --- Documentation/gpu/rfc/i915_parallel_execbuf.h | 122 -- Documentation/gpu/rfc/i915_scheduler.rst | 4 +- 2

Re: [Intel-gfx] [PATCH 20/27] drm/i915/guc: Connect UAPI to GuC multi-lrc interface

2021-09-20 Thread John Harrison
On 8/20/2021 15:44, Matthew Brost wrote: Introduce 'set parallel submit' extension to connect UAPI to GuC multi-lrc interface. Kernel doc in new uAPI should explain it all. IGT: https://patchwork.freedesktop.org/patch/447008/?series=93071=1 media UMD: link to come Is this link still not

[Intel-gfx] [PATCH 2/2] Add drm buddy manager support to amdgpu driver

2021-09-20 Thread Arunpravin
Replace drm_mm with drm buddy manager for VRAM memory management Signed-off-by: Arunpravin --- .../gpu/drm/amd/amdgpu/amdgpu_res_cursor.h| 78 +-- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.h | 3 +- drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.c | 216 ++ 3 files

[Intel-gfx] [PATCH 1/2] Enable buddy memory manager support

2021-09-20 Thread Arunpravin
Port Intel buddy system manager to drm root folder Add CPU mappable/non-mappable region support to the drm buddy manager Signed-off-by: Arunpravin --- drivers/gpu/drm/Makefile| 2 +- drivers/gpu/drm/drm_buddy.c | 465 include/drm/drm_buddy.h | 154

Re: [Intel-gfx] [PATCH 19/27] drm/i915: Fix bug in user proto-context creation that leaked contexts

2021-09-20 Thread John Harrison
On 8/20/2021 15:44, Matthew Brost wrote: Set number of engines before attempting to create contexts so the function free_engines can clean up properly. Fixes: d4433c7600f7 ("drm/i915/gem: Use the proto-context to handle create parameters (v5)") Signed-off-by: Matthew Brost Cc: ---

Re: [Intel-gfx] [PATCH 18/27] drm/i915/guc: Update debugfs for GuC multi-lrc

2021-09-20 Thread John Harrison
On 8/20/2021 15:44, Matthew Brost wrote: Display the workqueue status in debugfs for GuC contexts that are in parent-child relationship. Signed-off-by: Matthew Brost --- .../gpu/drm/i915/gt/uc/intel_guc_submission.c | 51 ++- 1 file changed, 37 insertions(+), 14

Re: [Intel-gfx] [PATCH 17/27] drm/i915/guc: Implement multi-lrc reset

2021-09-20 Thread John Harrison
On 8/20/2021 15:44, Matthew Brost wrote: Update context and full GPU reset to work with multi-lrc. The idea is parent context tracks all the active requests inflight for itself and its' children. The parent context owns the reset replaying / canceling its' -> its requests as needed.

Re: [Intel-gfx] [PULL] drm-misc-next

2021-09-20 Thread Rob Herring
On Thu, Sep 16, 2021 at 2:31 AM Maxime Ripard wrote: > > Hi Dave, Daniel, > > Here's the first drm-misc-next PR for 5.16 > > Thanks! > Maxime > > drm-misc-next-2021-09-16: > drm-misc-next for $kernel-version: > > UAPI Changes: > > Cross-subsystem Changes: > - dma-buf: Avoid a warning with some

Re: [Intel-gfx] [PATCH 16/27] drm/i915/guc: Insert submit fences between requests in parent-child relationship

2021-09-20 Thread John Harrison
On 8/20/2021 15:44, Matthew Brost wrote: The GuC must receive requests in the order submitted for contexts in a parent-child relationship to function correctly. To ensure this, insert a submit fence between the current request and last request submitted for requests / contexts in a parent child

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/bdb: Fix version check

2021-09-20 Thread Patchwork
== Series Details == Series: drm/i915/bdb: Fix version check URL : https://patchwork.freedesktop.org/series/94871/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10614 -> Patchwork_21101 Summary --- **FAILURE**

[Intel-gfx] i915 Updates - ADLP DMC v2.12

2021-09-20 Thread Srivatsa, Anusha
Hi josh, Ben, Kyle Kindly add the below i915 changes to linux-firmware: linux-firmware: add frimware for mediatek bluetooth chip (MT7922) (2021-09-13 11:35:49 -0400) are available in the Git repository at: git://anongit.freedesktop.org/drm/drm-firmware adlp_dmc_2_12 for you to fetch changes

Re: [Intel-gfx] [PATCH 15/27] drm/i915/guc: Implement multi-lrc submission

2021-09-20 Thread John Harrison
On 8/20/2021 15:44, Matthew Brost wrote: Implement multi-lrc submission via a single workqueue entry and single H2G. The workqueue entry contains an updated tail value for each request, of all the contexts in the multi-lrc submission, and updates these values simultaneously. As such, the tasklet

Re: [Intel-gfx] [PATCH 03/15] dmr/msm: cleanup: drm_modeset_lock_all_ctx() --> DRM_MODESET_LOCK_ALL_BEGIN()

2021-09-20 Thread Fernando Ramos
On 21/09/20 09:54AM, kernel test robot wrote: > > [auto build test ERROR on drm-exynos/exynos-drm-next] > [also build test ERROR on tegra-drm/drm/tegra/for-next linus/master v5.15-rc2 > next-20210917] I forgot to #include for those platforms and didn't notice because I only tried to build for

Re: [Intel-gfx] [PATCH 9/9] drm/i915: Add privacy-screen support

2021-09-20 Thread Lyude Paul
On Thu, 2021-09-16 at 12:32 +0200, Hans de Goede wrote: > > I'm fine with refactoring this a bit and adding > an intel_modeset_probe_defer() helper for this, I assume I should also > move the vga_switcheroo_client_probe_defer(pdev) check there? > > As you suggested yourself in your reply to the

Re: [Intel-gfx] [PATCH v1] drm/i915/bdb: Fix version check

2021-09-20 Thread Souza, Jose
On Mon, 2021-09-20 at 16:11 +0200, Lukasz Majczak wrote: > With patch "drm/i915/vbt: Fix backlight parsing for VBT 234+" > the size of bdb_lfp_backlight_data structure has been increased, > causing if-statement in the parse_lfp_backlight function > that comapres this structure size to the one

Re: [Intel-gfx] [PATCH] drm/i915: fix blank screen booting crashes

2021-09-20 Thread Matthew Brost
On Mon, Sep 20, 2021 at 08:42:42AM +0100, Tvrtko Ursulin wrote: > > On 20/09/2021 08:38, Jani Nikula wrote: > > On Mon, 20 Sep 2021, Tvrtko Ursulin wrote: > > > On 18/09/2021 00:38, Matthew Brost wrote: > > > > From: Hugh Dickins > > > > > > > > 5.15-rc1 crashes with blank screen when booting

Re: [Intel-gfx] [PATCH] drm/i915: fix blank screen booting crashes

2021-09-20 Thread Matthew Brost
On Mon, Sep 20, 2021 at 08:28:13AM +0100, Tvrtko Ursulin wrote: > > On 18/09/2021 00:38, Matthew Brost wrote: > > From: Hugh Dickins > > > > 5.15-rc1 crashes with blank screen when booting up on two ThinkPads > > using i915. Bisections converge convincingly, but arrive at different > > and

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for Check SFC fusing on Xe_HP (rev4)

2021-09-20 Thread Matt Roper
On Mon, Sep 20, 2021 at 06:55:52PM +, Patchwork wrote: > == Series Details == > > Series: Check SFC fusing on Xe_HP (rev4) > URL : https://patchwork.freedesktop.org/series/94808/ > State : failure > > == Summary == > > CI Bug Log - changes from CI_DRM_10613 -> Patchwork_21099 >

[Intel-gfx] [PATCH v1] drm/i915/bdb: Fix version check

2021-09-20 Thread Lukasz Majczak
With patch "drm/i915/vbt: Fix backlight parsing for VBT 234+" the size of bdb_lfp_backlight_data structure has been increased, causing if-statement in the parse_lfp_backlight function that comapres this structure size to the one retrieved from BDB, always to fail for older revisions. This patch

Re: [Intel-gfx] [PATCH 2/2] Add drm buddy manager support to amdgpu driver

2021-09-20 Thread Alex Deucher
On Mon, Sep 20, 2021 at 3:21 PM Arunpravin wrote: > > Replace drm_mm with drm buddy manager for > VRAM memory management Would be good to document why we are doing this and what advantages it brings over the old drm_mm code. Alex > > Signed-off-by: Arunpravin > --- >

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Suspend / resume backup- and restore of LMEM. (rev6)

2021-09-20 Thread Patchwork
== Series Details == Series: drm/i915: Suspend / resume backup- and restore of LMEM. (rev6) URL : https://patchwork.freedesktop.org/series/94278/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10613 -> Patchwork_21100

Re: [Intel-gfx] [PATCH 1/2] Enable buddy memory manager support

2021-09-20 Thread Alex Deucher
On Mon, Sep 20, 2021 at 3:21 PM Arunpravin wrote: Please prefix the patch subject with drm. E.g., drm: Enable buddy memory manager support Same for the second patch, but make it drm/amdgpu instead. Alex > > Port Intel buddy system manager to drm root folder > Add CPU mappable/non-mappable

Re: [Intel-gfx] [PATCH] drm/i915: Make wa list per-gt

2021-09-20 Thread Yokoyama, Caz
On Fri, 2021-09-17 at 10:08 -0700, Matt Roper wrote: > From: Venkata Sandeep Dhanalakota > > Support for multiple GT's within a single i915 device will be > arriving > soon. Since each GT may have its own fusing and require different > workarounds, we need to make the GT workaround functions

Re: [Intel-gfx] [PATCH 1/3] drm/i915/display/dmc: Set DC_STATE_DEBUG_MASK_CORES after firmware load

2021-09-20 Thread Imre Deak
On Sat, Sep 18, 2021 at 12:06:01AM +0300, Imre Deak wrote: > On Fri, Sep 17, 2021 at 01:52:39PM -0700, José Roberto de Souza wrote: > > Specification asks for DC_STATE_DEBUG_MASK_CORES to be set for all > > platforms that supports DMC, not only for geminilake and broxton. > > According to the

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Suspend / resume backup- and restore of LMEM. (rev6)

2021-09-20 Thread Patchwork
== Series Details == Series: drm/i915: Suspend / resume backup- and restore of LMEM. (rev6) URL : https://patchwork.freedesktop.org/series/94278/ State : warning == Summary == $ dim checkpatch origin/drm-tip 5fe8cae9d0ac drm/i915/ttm: Implement a function to copy the contents of two

[Intel-gfx] ✗ Fi.CI.BAT: failure for Check SFC fusing on Xe_HP (rev4)

2021-09-20 Thread Patchwork
== Series Details == Series: Check SFC fusing on Xe_HP (rev4) URL : https://patchwork.freedesktop.org/series/94808/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10613 -> Patchwork_21099 Summary --- **FAILURE**

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Check SFC fusing on Xe_HP (rev4)

2021-09-20 Thread Patchwork
== Series Details == Series: Check SFC fusing on Xe_HP (rev4) URL : https://patchwork.freedesktop.org/series/94808/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. -

Re: [Intel-gfx] [PATCH 3/3] drm/i915/display: Match PSR2 selective fetch sequences with specification

2021-09-20 Thread Gwan-gyeong Mun
Looks good to me. Tested-by: Gwan-gyeong Mun Reviewed-by: Gwan-gyeong Mun On 9/17/21 11:52 PM, José Roberto de Souza wrote: We were not completely following the selective fetch programming sequence, here some things we were doing wrong: - not programming plane selective fetch a

Re: [Intel-gfx] [PATCH v2 6/9] vfio/mdev: Add mdev available instance checking to the core

2021-09-20 Thread Cornelia Huck
On Thu, Sep 09 2021, Jason Gunthorpe wrote: > Many of the mdev drivers use a simple counter for keeping track of the > available instances. Move this code to the core code and store the counter > in the mdev_type. Implement it using correct locking, fixing mdpy. > > Drivers provide a

Re: [Intel-gfx] [PATCH v10 09/17] drm/i915/pxp: Implement PXP irq handler

2021-09-20 Thread Rodrigo Vivi
On Mon, Sep 20, 2021 at 04:18:10PM +, Teres Alexis, Alan Previn wrote: > > On Mon, 2021-09-20 at 12:04 -0400, Rodrigo Vivi wrote: > > On Fri, Sep 17, 2021 at 09:20:00PM -0700, Alan Previn wrote: > > > From: "Huang, Sean Z" > > > > > > The HW will generate a teardown interrupt when session

Re: [Intel-gfx] [PATCH v1] drm/i915/bdb: Fix version check

2021-09-20 Thread Jani Nikula
On Mon, 20 Sep 2021, Lukasz Majczak wrote: > With patch "drm/i915/vbt: Fix backlight parsing for VBT 234+" > the size of bdb_lfp_backlight_data structure has been increased, > causing if-statement in the parse_lfp_backlight function > that comapres this structure size to the one retrieved from

Re: [Intel-gfx] [PATCH v2 4/9] vfio/ccw: Make the FSM complete and synchronize it to the mdev

2021-09-20 Thread Jason Gunthorpe
On Mon, Sep 20, 2021 at 02:19:18PM +0200, Cornelia Huck wrote: > On Thu, Sep 09 2021, Jason Gunthorpe wrote: > > > The subchannel should be left in a quiescent state unless the VFIO device > > FD is opened. When the FD is opened bring the chanel to active and allow > > the VFIO device to

Re: [Intel-gfx] [PATCH v10 09/17] drm/i915/pxp: Implement PXP irq handler

2021-09-20 Thread Teres Alexis, Alan Previn
On Mon, 2021-09-20 at 12:04 -0400, Rodrigo Vivi wrote: > On Fri, Sep 17, 2021 at 09:20:00PM -0700, Alan Previn wrote: > > From: "Huang, Sean Z" > > > > The HW will generate a teardown interrupt when session termination is > > required, which requires i915 to submit a terminating batch. Once the

Re: [Intel-gfx] [PATCH v10 10/17] drm/i915/pxp: interfaces for using protected objects

2021-09-20 Thread Teres Alexis, Alan Previn
On Mon, 2021-09-20 at 12:09 -0400, Rodrigo Vivi wrote: > On Fri, Sep 17, 2021 at 09:20:01PM -0700, Alan Previn wrote: > > From: Daniele Ceraolo Spurio > > > > This api allow user mode to create protected buffers and to mark > > contexts as making use of such objects. Only when using contexts >

Re: [Intel-gfx] [PATCH v10 10/17] drm/i915/pxp: interfaces for using protected objects

2021-09-20 Thread Rodrigo Vivi
On Fri, Sep 17, 2021 at 09:20:01PM -0700, Alan Previn wrote: > From: Daniele Ceraolo Spurio > > This api allow user mode to create protected buffers and to mark > contexts as making use of such objects. Only when using contexts > marked in such a way is the execution guaranteed to work as

Re: [Intel-gfx] [PATCH v10 09/17] drm/i915/pxp: Implement PXP irq handler

2021-09-20 Thread Rodrigo Vivi
On Fri, Sep 17, 2021 at 09:20:00PM -0700, Alan Previn wrote: > From: "Huang, Sean Z" > > The HW will generate a teardown interrupt when session termination is > required, which requires i915 to submit a terminating batch. Once the HW > is done with the termination it will generate another

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/gt: Add "intel_" as prefix in set_mocs_index() (rev3)

2021-09-20 Thread Vudum, Lakshminarayana
Re-reported. -Original Message- From: Roper, Matthew D Sent: Monday, September 20, 2021 8:26 AM To: intel-gfx@lists.freedesktop.org Cc: Siddiqui, Ayaz A ; Vudum, Lakshminarayana ; Kijanczuk, Damian Subject: Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/gt: Add "intel_" as prefix

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Make wa list per-gt (rev2)

2021-09-20 Thread Vudum, Lakshminarayana
Reported. -Original Message- From: Roper, Matthew D Sent: Monday, September 20, 2021 7:53 AM To: intel-gfx@lists.freedesktop.org Cc: Vudum, Lakshminarayana ; Kijanczuk, Damian Subject: Re: ✗ Fi.CI.IGT: failure for drm/i915: Make wa list per-gt (rev2) On Sat, Sep 18, 2021 at

[Intel-gfx] [PATCH v4 6/6] drm/i915: Reduce the number of objects subject to memcpy recover

2021-09-20 Thread Thomas Hellström
We really only need memcpy restore for objects that affect the operability of the migrate context. That is, primarily the page-table objects of the migrate VM. Add an object flag, I915_BO_ALLOC_PM_EARLY for objects that need early restores using memcpy and a way to assign LMEM page-table object

[Intel-gfx] [PATCH v4 5/6] drm/i915: Don't back up pinned LMEM context images and rings during suspend

2021-09-20 Thread Thomas Hellström
Pinned context images are now reset during resume. Don't back them up, and assuming that rings can be assumed empty at suspend, don't back them up either. Introduce a new object flag, I915_BO_ALLOC_PM_VOLATILE meaning that an object is allowed to lose its content on suspend. v3: - Slight

[Intel-gfx] [PATCH v4 4/6] drm/i915/gt: Register the migrate contexts with their engines

2021-09-20 Thread Thomas Hellström
Pinned contexts, like the migrate contexts need reset after resume since their context image may have been lost. Also the GuC needs to register pinned contexts. Add a list to struct intel_engine_cs where we add all pinned contexts on creation, and traverse that list at resume time to reset the

[Intel-gfx] [PATCH v4 3/6] drm/i915 Implement LMEM backup and restore for suspend / resume

2021-09-20 Thread Thomas Hellström
Just evict unpinned objects to system. For pinned LMEM objects, make a backup system object and blit the contents to that. Backup is performed in three steps, 1: Opportunistically evict evictable objects using the gpu blitter. 2: After gt idle, evict evictable objects using the gpu blitter. This

[Intel-gfx] [PATCH v4 2/6] drm/i915/gem: Implement a function to process all gem objects of a region

2021-09-20 Thread Thomas Hellström
An upcoming common pattern is to traverse the region object list and perform certain actions on all objects in a region. It's a little tricky to get the list locking right, in particular since a gem object may change region unless it's pinned or the object lock is held. Define a function that

[Intel-gfx] [PATCH v4 1/6] drm/i915/ttm: Implement a function to copy the contents of two TTM-based objects

2021-09-20 Thread Thomas Hellström
When backing up or restoring contents of pinned objects at suspend / resume time we need to allocate a new object as the backup. Add a function to facilitate copies between the two. Some data needs to be copied before the migration context is ready for operation, so make sure we can disable

[Intel-gfx] [PATCH v4 0/6] drm/i915: Suspend / resume backup- and restore of LMEM.

2021-09-20 Thread Thomas Hellström
Implement backup and restore of LMEM during suspend / resume. What complicates things a bit is handling of pinned LMEM memory during suspend and the fact that we might be dealing with unmappable LMEM in the future, which makes us want to restrict the number of pinned objects that need memcpy

Re: [Intel-gfx] [PATCH] drm/i915: Make wa list per-gt

2021-09-20 Thread Rodrigo Vivi
On Fri, Sep 17, 2021 at 10:08:45AM -0700, Matt Roper wrote: > From: Venkata Sandeep Dhanalakota > > Support for multiple GT's within a single i915 device will be arriving > soon. Since each GT may have its own fusing and require different > workarounds, we need to make the GT workaround

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/gt: Add "intel_" as prefix in set_mocs_index() (rev3)

2021-09-20 Thread Patchwork
== Series Details == Series: drm/i915/gt: Add "intel_" as prefix in set_mocs_index() (rev3) URL : https://patchwork.freedesktop.org/series/94721/ State : success == Summary == CI Bug Log - changes from CI_DRM_10605_full -> Patchwork_21088_full

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Make wa list per-gt (rev2)

2021-09-20 Thread Patchwork
== Series Details == Series: drm/i915: Make wa list per-gt (rev2) URL : https://patchwork.freedesktop.org/series/94811/ State : success == Summary == CI Bug Log - changes from CI_DRM_10605_full -> Patchwork_21091_full Summary ---

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/gt: Add "intel_" as prefix in set_mocs_index() (rev3)

2021-09-20 Thread Matt Roper
On Fri, Sep 17, 2021 at 11:42:09PM +, Patchwork wrote: > == Series Details == > > Series: drm/i915/gt: Add "intel_" as prefix in set_mocs_index() (rev3) > URL : https://patchwork.freedesktop.org/series/94721/ > State : failure > > == Summary == > > CI Bug Log - changes from

Re: [Intel-gfx] [PATCH v2] kernel/locking: Add context to ww_mutex_trylock.

2021-09-20 Thread Joonas Lahtinen
Quoting Peter Zijlstra (2021-09-17 16:13:19) > On Thu, Sep 16, 2021 at 03:28:11PM +0200, Peter Zijlstra wrote: > > On Thu, Sep 16, 2021 at 03:00:39PM +0200, Maarten Lankhorst wrote: > > > > > > For merge logistics, can we pls have a stable branch? I expect that the > > > > i915 patches will be

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Make wa list per-gt (rev2)

2021-09-20 Thread Matt Roper
On Sat, Sep 18, 2021 at 01:46:39AM +, Patchwork wrote: > == Series Details == > > Series: drm/i915: Make wa list per-gt (rev2) > URL : https://patchwork.freedesktop.org/series/94811/ > State : failure > > == Summary == > > CI Bug Log - changes from CI_DRM_10605_full ->

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/guc, docs: Fix pdfdocs build error by removing nested grid

2021-09-20 Thread Patchwork
== Series Details == Series: drm/i915/guc, docs: Fix pdfdocs build error by removing nested grid URL : https://patchwork.freedesktop.org/series/94858/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10611 -> Patchwork_21098

[Intel-gfx] [PATCH] drm/i915/guc, docs: Fix pdfdocs build error by removing nested grid

2021-09-20 Thread Akira Yokosawa
Nested grids in grid-table cells are not specified as proper ReST constructs. Commit 572f2a5cd974 ("drm/i915/guc: Update firmware to v62.0.0") added a couple of kerneldoc tables of the form: +---+---+--+ | 1 | 31:0 |

Re: [Intel-gfx] [PATCH 21/26] drm: use new iterator in drm_gem_plane_helper_prepare_fb v2

2021-09-20 Thread Christian König
Am 17.09.21 um 16:55 schrieb Daniel Vetter: On Fri, Sep 17, 2021 at 02:35:08PM +0200, Christian König wrote: Makes the handling a bit more complex, but avoids the use of dma_resv_get_excl_unlocked(). v2: add missing rcu_read_lock()/unlock() Signed-off-by: Christian König ---

Re: [Intel-gfx] [PATCH 01/26] dma-buf: add dma_resv_for_each_fence_unlocked v2

2021-09-20 Thread Christian König
Am 20.09.21 um 10:43 schrieb Tvrtko Ursulin: On 17/09/2021 14:23, Daniel Vetter wrote: On Fri, Sep 17, 2021 at 02:34:48PM +0200, Christian König wrote: Abstract the complexity of iterating over all the fences in a dma_resv object. The new loop handles the whole RCU and retry dance and returns

Re: [Intel-gfx] [PATCH 14/26] drm/i915: use the new iterator in i915_sw_fence_await_reservation v3

2021-09-20 Thread Christian König
Am 20.09.21 um 10:47 schrieb Tvrtko Ursulin: On 20/09/2021 09:45, Tvrtko Ursulin wrote: On 17/09/2021 13:35, Christian König wrote: Simplifying the code a bit. v2: use dma_resv_for_each_fence instead, according to Tvrtko the lock is held here anyway. v3: back to using

Re: [Intel-gfx] [PATCH 03/26] dma-buf: use new iterator in dma_resv_copy_fences

2021-09-20 Thread Christian König
Am 17.09.21 um 16:35 schrieb Daniel Vetter: On Fri, Sep 17, 2021 at 02:34:50PM +0200, Christian König wrote: This makes the function much simpler since the complex retry logic is now handled else where. Signed-off-by: Christian König --- drivers/dma-buf/dma-resv.c | 86

Re: [Intel-gfx] [PATCH 20/26] drm: use new iterator in drm_gem_fence_array_add_implicit v2

2021-09-20 Thread Christian König
Am 17.09.21 um 16:53 schrieb Daniel Vetter: On Fri, Sep 17, 2021 at 02:35:07PM +0200, Christian König wrote: Simplifying the code a bit. v2: add missing rcu_read_lock()/unlock() Signed-off-by: Christian König This will be gone as soon as I can land the last conversion patches. Plus it's

[Intel-gfx] Have you attended XDC 2021? Give us your feedback!

2021-09-20 Thread Samuel Iglesias Gonsálvez
Hi, First of all, thanks organizers for such a great conference. It was smooth and, although there were some issues as it is usual in any conference, they were fixed promptly :-) I would like also to thank all of you for attending and participating either via submitting talks, watching them or

Re: [Intel-gfx] [PATCH 05/26] dma-buf: use new iterator in dma_resv_wait_timeout

2021-09-20 Thread Christian König
Am 17.09.21 um 16:43 schrieb Daniel Vetter: On Fri, Sep 17, 2021 at 02:34:52PM +0200, Christian König wrote: This makes the function much simpler since the complex retry logic is now handled elsewhere. Signed-off-by: Christian König --- drivers/dma-buf/dma-resv.c | 68

Re: [Intel-gfx] [PATCH 13/26] drm/i915: use the new iterator in i915_gem_busy_ioctl

2021-09-20 Thread Christian König
Am 20.09.21 um 10:45 schrieb Tvrtko Ursulin: On 17/09/2021 13:35, Christian König wrote: This makes the function much simpler since the complex retry logic is now handled else where. Signed-off-by: Christian König ---   drivers/gpu/drm/i915/gem/i915_gem_busy.c | 32  

Re: [Intel-gfx] [PATCH v2 4/9] vfio/ccw: Make the FSM complete and synchronize it to the mdev

2021-09-20 Thread Cornelia Huck
On Thu, Sep 09 2021, Jason Gunthorpe wrote: > The subchannel should be left in a quiescent state unless the VFIO device > FD is opened. When the FD is opened bring the chanel to active and allow > the VFIO device to operate. When the device FD is closed then quiesce the > channel. > > To make

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/debugfs: Do not report currently active engine when describing objects (rev2)

2021-09-20 Thread Patchwork
== Series Details == Series: drm/i915/debugfs: Do not report currently active engine when describing objects (rev2) URL : https://patchwork.freedesktop.org/series/94691/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10609 -> Patchwork_21097

Re: [Intel-gfx] [PATCH v2 2/9] vfio/ccw: Pass vfio_ccw_private not mdev_device to various functions

2021-09-20 Thread Cornelia Huck
On Thu, Sep 09 2021, Jason Gunthorpe wrote: > mdev_device should only be used in functions assigned to ops callbacks, > interior functions should use the struct vfio_ccw_private instead of > repeatedly trying to get it from the mdev. > > Signed-off-by: Jason Gunthorpe > --- >

Re: [Intel-gfx] [PATCH v3 6/6] drm/i915: Reduce the number of objects subject to memcpy recover

2021-09-20 Thread Thomas Hellström
On Mon, 2021-09-20 at 12:05 +0100, Matthew Auld wrote: > On 14/09/2021 20:31, Thomas Hellström wrote: > > We really only need memcpy restore for objects that affect the > > operability of the migrate context. That is, primarily the page- > > table > > objects of the migrate VM. > > > > Add an

Re: [Intel-gfx] [PATCH v3 6/6] drm/i915: Reduce the number of objects subject to memcpy recover

2021-09-20 Thread Matthew Auld
On 14/09/2021 20:31, Thomas Hellström wrote: We really only need memcpy restore for objects that affect the operability of the migrate context. That is, primarily the page-table objects of the migrate VM. Add an object flag, I915_BO_ALLOC_PM_EARLY for objects that need early restores using

Re: [Intel-gfx] [PATCH v3 3/6] drm/i915 Implement LMEM backup and restore for suspend / resume

2021-09-20 Thread Thomas Hellström
On Mon, 2021-09-20 at 11:49 +0100, Matthew Auld wrote: > On 14/09/2021 20:31, Thomas Hellström wrote: > > Just evict unpinned objects to system. For pinned LMEM objects, > > make a backup system object and blit the contents to that. > > > > Backup is performed in three steps, > > 1:

  1   2   >