== Series Details ==
Series: series starting with [1/2] drm/i915: Extend the async flip VT-d w/a to
skl/bxt
URL : https://patchwork.freedesktop.org/series/95300/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10668_full -> Patchwork_21210_full
== Series Details ==
Series: drm/i915/display: Wait PSR2 get out of deep sleep to update pipe
URL : https://patchwork.freedesktop.org/series/95309/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10670 -> Patchwork_21213
== Series Details ==
Series: drm/i915: incidental -EPERM considered harmful (rev2)
URL : https://patchwork.freedesktop.org/series/95268/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10668_full -> Patchwork_21209_full
== Series Details ==
Series: drm/i915: Stop using I915_TILING_* in client blit selftest
URL : https://patchwork.freedesktop.org/series/95308/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10670 -> Patchwork_21212
Summary
Applied to drm-misc-next.
Thanks
On 09/28, Harry Wentland wrote:
> On 2021-09-27 15:23, Fangzhi Zuo wrote:
> > Include FEC, DSC, Link Training related headers.
> >
> > Change since v2
> > - Align with the spec for DP_DSC_SUPPORT_AND_DSC_DECODER_COUNT
> >
> > Signed-off-by: Fangzhi Zuo
>
>
Alderlake-P was getting 'max time under evasion' messages when PSR2
is enabled, this is due PIPE_SCANLINE/PIPEDSL returning 0 over a
period of time longer than VBLANK_EVASION_TIME_US.
For PSR1 we had the same issue so intel_psr_wait_for_idle() was
implemented to wait for PSR1 to get into idle
The I915_TILING_* definitions in the uapi header are intended solely for
tiling modes that are visible to the old de-tiling fence ioctls. Since
modern hardware does not support de-tiling fences, we should not add new
definitions for new tiling types going forward. However we do want the
client
== Series Details ==
Series: drm/i915/gt: move remaining debugfs interfaces into gt (rev7)
URL : https://patchwork.freedesktop.org/series/75333/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_10670 -> Patchwork_21211
== Series Details ==
Series: drm/i915/gt: move remaining debugfs interfaces into gt (rev7)
URL : https://patchwork.freedesktop.org/series/75333/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
8fdbaf0abd82 drm/i915/gt: move remaining debugfs interfaces into gt
-:112:
The following interfaces:
i915_wedged
i915_forcewake_user
i915_gem_interrupt
are dependent on gt values. Put them inside gt/ and drop the
"i915_" prefix name. This would be the new structure:
dri/0/gt
|
+-- forcewake_user
|
+-- interrupt_info
|
\-- reset
Signed-off-by: Andi
== Series Details ==
Series: drm/i915: Update memory bandwidth formulae (rev4)
URL : https://patchwork.freedesktop.org/series/95138/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10666_full -> Patchwork_21208_full
Summary
On Fri, Aug 20, 2021 at 03:44:43PM -0700, Matthew Brost wrote:
Did a review offline with John Harrison, adding notes for what we found.
> Allow multiple batch buffers to be submitted in a single execbuf IOCTL
> after a context has been configured with the 'set_parallel' extension.
> The number
On Sun, Sep 26, 2021 at 10:10:05PM +0200, Michal Wajdeczko wrote:
> We assumed that for all modern GENs the PTEs and register space are
> split in the GTTMMADR BAR, but while it is true, we should rather use
> fixed offset as it is defined in the specification.
>
> Bspec: 4409, 4457, 4604, 11181,
== Series Details ==
Series: series starting with [v2,1/9] drm/i915/display/psr: Handle plane and
pipe restrictions at every page flip (rev2)
URL : https://patchwork.freedesktop.org/series/95242/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10666_full ->
== Series Details ==
Series: series starting with [1/2] drm/i915: Extend the async flip VT-d w/a to
skl/bxt
URL : https://patchwork.freedesktop.org/series/95300/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10668 -> Patchwork_21210
== Series Details ==
Series: series starting with [1/2] drm/i915: Extend the async flip VT-d w/a to
skl/bxt
URL : https://patchwork.freedesktop.org/series/95300/
State : warning
== Summary ==
$ dim sparse --fast origin/drm-tip
Sparse version: v0.6.2
Fast mode used, each commit won't be
On Thu, 2021-09-30 at 20:36 +, Patchwork wrote:
Patch Details
Series: drm/i915/bdb: Fix version check (rev3)
URL:https://patchwork.freedesktop.org/series/94871/
State: success
Details:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21205/index.html
CI Bug Log - changes from
== Series Details ==
Series: drm/i915: incidental -EPERM considered harmful (rev2)
URL : https://patchwork.freedesktop.org/series/95268/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10668 -> Patchwork_21209
Summary
== Series Details ==
Series: drm/i915/bdb: Fix version check (rev3)
URL : https://patchwork.freedesktop.org/series/94871/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10666_full -> Patchwork_21205_full
Summary
---
== Series Details ==
Series: series starting with [1/4] drm/i915: Clear leftover DP
vswing/preemphasis values before modeset
URL : https://patchwork.freedesktop.org/series/95275/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10666_full -> Patchwork_21204_full
From: Ville Syrjälä
Looks like skl/bxt/derivatives also need the plane stride
stretch w/a when using async flips and VT-d is enabled, or
else we get corruption on screen. To my surprise this was
even documented in bspec, but only as a note on the
CHICHKEN_PIPESL register description rather than
From: Ville Syrjälä
Since the VT-d vs. async flip issues are plaguing a wider range
of supported hw let's try to minimize the impact on normal
operation by flipping the relevant chicken bits on and off
as needed. I presume there is some power/perf impact on since
this is reducing some
Le 30/09/2021 à 16:21, Daniel Vetter a écrit :
On Sat, Sep 25, 2021 at 08:46:12PM +0800, Cai Huoqing wrote:
Replace direction definition PCI_DMA_BIDIRECTIONAL
with DMA_BIDIRECTIONAL, because it helps to enhance readability
and avoid possible inconsistency.
Signed-off-by: Cai Huoqing
Applied
== Series Details ==
Series: drm/i915: Update memory bandwidth formulae (rev4)
URL : https://patchwork.freedesktop.org/series/95138/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10666 -> Patchwork_21208
Summary
---
On Thu, Sep 30, 2021 at 06:15:46PM +0100, Tvrtko Ursulin wrote:
> (Note I did not copy
> everyone on all patches but just the cover letter for context and the rest
> should be available from the mailing list.)
In general, if you can't be arsed to send it to me, I can't be arsed to
dig it
On Thu, Sep 30, 2021 at 06:15:47PM +0100, Tvrtko Ursulin wrote:
> void set_user_nice(struct task_struct *p, long nice)
> {
> bool queued, running;
> - int old_prio;
> + int old_prio, ret;
> struct rq_flags rf;
> struct rq *rq;
>
> @@ -6913,6 +6945,9 @@ void
== Series Details ==
Series: drm/i915/ttm: Rework object initialization slightly (rev4)
URL : https://patchwork.freedesktop.org/series/95107/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10666_full -> Patchwork_21203_full
On Thu, 2021-09-30 at 10:35 +0300, Gwan-gyeong Mun wrote:
>
> On 9/30/21 3:14 AM, José Roberto de Souza wrote:
> > The Wa_14014971508 is required to fix scanout when a feature that i915
> > do not support is enabled and this feature is not planned to be enabled
> > for adlp.
> >
> > Keeping this
On Thu, 2021-09-30 at 10:17 +0300, Gwan-gyeong Mun wrote:
>
> On 9/30/21 3:14 AM, José Roberto de Souza wrote:
> > When PSR2 selective fetch is enabled writes to CURSURFLIVE alone do
> > not causes the panel to be updated when doing frontbuffer rendering.
> >
> > From what I was able to figure
On Thu, 2021-09-30 at 15:46 +0200, Lukasz Majczak wrote:
> With patch "drm/i915/vbt: Fix backlight parsing for VBT 234+"
> the size of bdb_lfp_backlight_data structure has been increased,
> causing if-statement in the parse_lfp_backlight function
> that comapres this structure size to the one
The formulae has been updated to include more variables. Make
sure the code carries the same.
Bspec: 64631
v2: Make GEN11 follow the default route and fix calculation of
maxdebw(RK)
v3: Fix div by zero on default case
Correct indent for fallthrough(Jani)
v4: Fix div by zero on gen11.
Looks good to me.
Reviewed-by: Gwan-gyeong Mun
On 9/30/21 10:56 AM, Ville Syrjälä wrote:
On Wed, Sep 29, 2021 at 05:14:05PM -0700, José Roberto de Souza wrote:
Legacy cursor APIs are handled by intel_legacy_cursor_update(), that
calls drm_atomic_helper_update_plane() when going through the
== Series Details ==
Series: series starting with [v2,1/9] drm/i915/display/psr: Handle plane and
pipe restrictions at every page flip (rev2)
URL : https://patchwork.freedesktop.org/series/95242/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10666 -> Patchwork_21206
== Series Details ==
Series: CPU + GPU synchronised priority scheduling
URL : https://patchwork.freedesktop.org/series/95294/
State : failure
== Summary ==
fatal: empty ident name (for <>) not allowed
Applying: effective and consolidated user experience. In other words why user
would not be
From: Tvrtko Ursulin
Make GEM contexts keep a reference to i915_drm_client for the whole of
of their lifetime which will come handy in following patches.
v2: Don't bother supporting selftests contexts from debugfs. (Chris)
v3 (Lucas): Finish constructing ctx before adding it to the list
v4
From: Tvrtko Ursulin
We soon want to start answering questions like how much GPU time is the
context belonging to a client which exited still using.
To enable this we start tracking all context belonging to a client on a
separate list.
Signed-off-by: Tvrtko Ursulin
Reviewed-by: Aravind
From: Tvrtko Ursulin
A simple hash table of registered clients indexed by the task struct
pointer is kept to be used in a following patch.
Signed-off-by: Tvrtko Ursulin
---
drivers/gpu/drm/i915/gem/i915_gem_context.c | 2 ++
drivers/gpu/drm/i915/i915_drm_client.c | 31
From: Tvrtko Ursulin
Tracking DRM clients more explicitly will allow later patches to
accumulate past and current GPU usage in a centralised place and also
consolidate access to owning task pid/name.
Unique client id is also assigned for the purpose of distinguishing/
consolidating between
From: Tvrtko Ursulin
This is a somewhat early sketch of one of my ideas intended for early feedback
from the core scheduler experts. First and last two patches in the series are
the most interesting ones for people outside of i915. (Note I did not copy
everyone on all patches but just the cover
From: Tvrtko Ursulin
Implement a simple notifier chain via which interested parties can track
when process nice value changes. Simple because it is global so each user
would have to track which tasks it is interested in.
To use register_user_nice_notifier and unregister_user_nice_notifier
From: Tvrtko Ursulin
Introduce the concept of context nice value which exactly matches the
process nice, and also make use of the task user nice notifier chain to be
able to dynamically adjust GPU scheduling. Apart from runtime adjustments
context also inherits the nice value when created.
== Series Details ==
Series: series starting with [v2,1/9] drm/i915/display/psr: Handle plane and
pipe restrictions at every page flip (rev2)
URL : https://patchwork.freedesktop.org/series/95242/
State : warning
== Summary ==
$ dim sparse --fast origin/drm-tip
Sparse version: v0.6.2
Fast
== Series Details ==
Series: series starting with [1/3] drm/i915: Use standard form -EDEADLK check
URL : https://patchwork.freedesktop.org/series/95267/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10665_full -> Patchwork_21201_full
== Series Details ==
Series: drm/i915/bdb: Fix version check (rev3)
URL : https://patchwork.freedesktop.org/series/94871/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10666 -> Patchwork_21205
Summary
---
On Thu, Sep 30, 2021 at 07:19:06PM +0300, Imre Deak wrote:
> On Thu, Sep 30, 2021 at 07:16:10PM +0300, Ville Syrjälä wrote:
> > On Thu, Sep 30, 2021 at 07:09:03PM +0300, Imre Deak wrote:
> > > On Thu, Sep 30, 2021 at 04:43:09PM +0300, Ville Syrjala wrote:
> > > > From: Ville Syrjälä
> > > >
> >
On Thu, Sep 30, 2021 at 07:16:10PM +0300, Ville Syrjälä wrote:
> On Thu, Sep 30, 2021 at 07:09:03PM +0300, Imre Deak wrote:
> > On Thu, Sep 30, 2021 at 04:43:09PM +0300, Ville Syrjala wrote:
> > > From: Ville Syrjälä
> > >
> > > Setting DP_PORT_EN in intel_dp->DP is already handled by
> > >
On Thu, Sep 30, 2021 at 07:09:03PM +0300, Imre Deak wrote:
> On Thu, Sep 30, 2021 at 04:43:09PM +0300, Ville Syrjala wrote:
> > From: Ville Syrjälä
> >
> > Setting DP_PORT_EN in intel_dp->DP is already handled by
> > intel_dp_enable_port() so there is no point in setting it also
> > from the
On Thu, Sep 30, 2021 at 04:43:09PM +0300, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> Setting DP_PORT_EN in intel_dp->DP is already handled by
> intel_dp_enable_port() so there is no point in setting it also
> from the link training code.
>
> For DDI platforms a bit with that name doesn't
On Thu, Sep 30, 2021 at 04:43:10PM +0300, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> Get rid of the local copies and pointers of intel_dp->DP and
> instead just poke at it directly. Makes it much easier to see
> where it actually gets used/modified.
>
> Cc: Imre Deak
> Signed-off-by: Ville
== Series Details ==
Series: series starting with [1/4] drm/i915: Clear leftover DP
vswing/preemphasis values before modeset
URL : https://patchwork.freedesktop.org/series/95275/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10666 -> Patchwork_21204
On Thu, Sep 30, 2021 at 11:01:36PM +0900, Masahiro Yamada wrote:
On Thu, Sep 30, 2021 at 3:34 AM Lucas De Marchi
wrote:
The check for config value doesn't really belong to i915_utils.h - we
are trying to eliminate that utils helper and share them when possible
with other drivers and
On Thu, Sep 30, 2021 at 04:43:08PM +0300, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> I want intel_dp->DP to be fully populated by the time the
> initial vswing programming happens. To that end move the
> intel_ddi_init_dp_buf_reg() call to an earlier spot.
>
> Additionally we don't want
== Series Details ==
Series: drm/i915/fdi: use -EAGAIN instead of local special return value
URL : https://patchwork.freedesktop.org/series/95260/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10665_full -> Patchwork_21200_full
On Thu, Sep 30, 2021 at 01:46:21PM +0300, Jani Nikula wrote:
On Wed, 29 Sep 2021, Lucas De Marchi wrote:
It took me some time to understand the need for IS_ACTIVE and why we
couldn't use kconfig.h.
For anyone else wondering, the clues are in babaab2f4738 ("drm/i915:
Encapsulate kconfig
== Series Details ==
Series: drm/i915/ttm: Rework object initialization slightly (rev4)
URL : https://patchwork.freedesktop.org/series/95107/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10666 -> Patchwork_21203
Summary
On Thu, Sep 30, 2021 at 11:00:06AM +0100, Steven Price wrote:
On 29/09/2021 19:33, Lucas De Marchi wrote:
Like the IS_ENABLED() counterpart, we can make IS_CONFIG_NONZERO() to
return the right thing when the config is not defined rather than a
build error, with the limitation that it can't be
On Thu, Sep 30, 2021 at 04:43:07PM +0300, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> Currently we clear the leftover vswing/preemphasis values only
> at the start of link training. That means the initial vswing
> programming performed during modeset is going to use stale values
> left over
On Thu, Sep 30, 2021 at 3:34 AM Lucas De Marchi
wrote:
>
> The check for config value doesn't really belong to i915_utils.h - we
> are trying to eliminate that utils helper and share them when possible
> with other drivers and subsystems.
>
> Rationale for having such macro is in commit
>
With patch "drm/i915/vbt: Fix backlight parsing for VBT 234+"
the size of bdb_lfp_backlight_data structure has been increased,
causing if-statement in the parse_lfp_backlight function
that comapres this structure size to the one retrieved from BDB,
always to fail for older revisions.
This patch
On 30 September, 2021 - Sebastian Andrzej Siewior wrote:
> On 2021-09-29 18:07:00 [+0200], Anton Lundin wrote:
> > Hi.
> Hi,
>
> > While I was chasing some other bugs I tested 5.15-rc3-rt5 and noted your
> > code e446c2038b58 ("drm/i915/gt: Use spin_lock_irq() instead of
> > local_irq_disable()
== Series Details ==
Series: drm/i915: incidental -EPERM considered harmful
URL : https://patchwork.freedesktop.org/series/95268/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_10666 -> Patchwork_21202
Summary
---
On Wed, Sep 29, 2021 at 01:32:41AM +0300, Jani Nikula wrote:
> If drm_modeset_lock() returns -EDEADLK, the caller is supposed to drop
> all currently held locks using drm_modeset_backoff(). Failing to do so
> will result in warnings and backtraces on the paths trying to lock a
> contended lock.
On Sat, Sep 25, 2021 at 08:46:12PM +0800, Cai Huoqing wrote:
> Replace direction definition PCI_DMA_BIDIRECTIONAL
> with DMA_BIDIRECTIONAL, because it helps to enhance readability
> and avoid possible inconsistency.
>
> Signed-off-by: Cai Huoqing
Applied to drm-intel-gt-next, thanks for the
== Series Details ==
Series: series starting with [1/3] drm/i915: Use standard form -EDEADLK check
URL : https://patchwork.freedesktop.org/series/95267/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10665 -> Patchwork_21201
From: Ville Syrjälä
Currently we clear the leftover vswing/preemphasis values only
at the start of link training. That means the initial vswing
programming performed during modeset is going to use stale values
left over from the previous link training sequence, and then at
the start of link
From: Ville Syrjälä
Setting DP_PORT_EN in intel_dp->DP is already handled by
intel_dp_enable_port() so there is no point in setting it also
from the link training code.
For DDI platforms a bit with that name doesn't even exist. The
counterpart is DDI_BUF_CTL_ENABLE, which is already set up by
From: Ville Syrjälä
Get rid of the local copies and pointers of intel_dp->DP and
instead just poke at it directly. Makes it much easier to see
where it actually gets used/modified.
Cc: Imre Deak
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/i915/display/g4x_dp.c | 45
From: Ville Syrjälä
I want intel_dp->DP to be fully populated by the time the
initial vswing programming happens. To that end move the
intel_ddi_init_dp_buf_reg() call to an earlier spot.
Additionally we don't want intel_ddi_init_dp_buf_reg() to
set DDI_BUF_CTL_ENABLE since the port should only
On 2021-09-29 18:07:00 [+0200], Anton Lundin wrote:
> Hi.
Hi,
> While I was chasing some other bugs I tested 5.15-rc3-rt5 and noted your
> code e446c2038b58 ("drm/i915/gt: Use spin_lock_irq() instead of
> local_irq_disable() + spin_lock()") and noted that this patch created a
> lot of visual
== Series Details ==
Series: drm/i915/display: move modeset asserts out of intel_display.c
URL : https://patchwork.freedesktop.org/series/95258/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10664_full -> Patchwork_21199_full
On Wed, Sep 29, 2021 at 05:14:02PM -0700, José Roberto de Souza wrote:
> From: Gwan-gyeong Mun
>
> We are still missing the PSR2 selective fetch handling of multi-planar
> formats but until proper handle is added we can workaround it by
> doing full frames fetch when state has such formats.
>
>
On 2021-09-30 14:27, Matthew Auld wrote:
> On 30/09/2021 11:04, Michel Dänzer wrote:
>> On 2021-09-29 13:54, Thomas Hellström wrote:
>>> On Mon, 2021-09-27 at 12:41 +0100, Matthew Auld wrote:
This should let us do an accelerated copy directly to the shmem pages
when temporarily moving
== Series Details ==
Series: drm/i915/fdi: use -EAGAIN instead of local special return value
URL : https://patchwork.freedesktop.org/series/95260/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10665 -> Patchwork_21200
On 30/09/2021 11:04, Michel Dänzer wrote:
On 2021-09-29 13:54, Thomas Hellström wrote:
On Mon, 2021-09-27 at 12:41 +0100, Matthew Auld wrote:
This should let us do an accelerated copy directly to the shmem pages
when temporarily moving lmem-only objects, where the i915-gem
shrinker
can later
On Thu, Sep 30, 2021 at 02:24:36PM +0300, Jani Nikula wrote:
> Avoid using the incidental -EPERM.
>
> Signed-off-by: Jani Nikula
> ---
> drivers/gpu/drm/i915/intel_dram.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_dram.c
>
We may end up in i915_ttm_bo_destroy() in an error path before the
object is fully initialized. In that case it's not correct to call
__i915_gem_free_object(), because that function
a) Assumes the gem object refcount is 0, which it isn't.
b) frees the placements which are owned by the caller until
I pushed those to drm-misc-next and fixed the i915 merge fallout in drm-tip.
Maybe take another look at the resolution in drm-tip if you have time.
Christian.
Am 29.09.21 um 15:26 schrieb Matthew Auld:
It covers more than just ttm_bo_type_sg usage, like with say dma-buf,
since one other user
Hi Daniel, Dave,
Here's this week PR for drm-misc-next
Maxime
drm-misc-next-2021-09-30:
drm-misc-next for 5.16:
UAPI Changes:
- virtio: UAPI additions to support context init
Cross-subsystem Changes:
Core Changes:
- bridge: documentation improvements
- mipi-dsi: new
Avoid using the incidental -EPERM.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_hdmi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/display/intel_hdmi.c
b/drivers/gpu/drm/i915/display/intel_hdmi.c
index 1bc33766ed39..468a107aaabc
Avoid using the incidental -EPERM.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/intel_dram.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_dram.c
b/drivers/gpu/drm/i915/intel_dram.c
index 91866520c173..a506a2196de4 100644
---
Avoid using the incidental -EPERM. Also remove useless comment.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/icl_dsi.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/icl_dsi.c
b/drivers/gpu/drm/i915/display/icl_dsi.c
index
Avoid using the incidental -EPERM. Return the -EIO directly from
i915_get_bridge_dev() instead of converting return values later.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/i915_drv.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git
Having two functions for this seems like excess duplication and
parameter juggling. Merge them together.
While at it, drop the extra error message, as wait_for_payload_credits()
already prints an error, and switch from incidental -EPERM (i.e. -1) to
actual error codes.
Signed-off-by: Jani Nikula
Pass a const pointer instead of passing 32 bytes of struct
mipi_dsi_packet by value.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/icl_dsi.c | 24
1 file changed, 12 insertions(+), 12 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/icl_dsi.c
I think using return -1 to indicate errors in kernel is generally a bad
idea. There are specific cases, such as returning invalid indexes, where
it might be justified, but functions that are expected to return actual
kernel error codes should return actual kernel error codes, not
incidental
== Series Details ==
Series: drm/i915/display: move modeset asserts out of intel_display.c
URL : https://patchwork.freedesktop.org/series/95258/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10664 -> Patchwork_21199
On Thu, 30 Sep 2021, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> Unify how we check for -EDEADLK vs. other errors from
> crtc vs. encoder compute_config() calls.
On the series,
Reviewed-by: Jani Nikula
>
> Signed-off-by: Ville Syrjälä
> ---
>
On Wed, 29 Sep 2021, Lucas De Marchi wrote:
> It took me some time to understand the need for IS_ACTIVE and why we
> couldn't use kconfig.h.
For anyone else wondering, the clues are in babaab2f4738 ("drm/i915:
Encapsulate kconfig constant values inside boolean predicates").
But this series
Op 29-09-2021 om 16:50 schreef Thomas Hellström (Intel):
>
> On 9/29/21 10:59, Maarten Lankhorst wrote:
>> Ensure i915_vma_pin_iomap and vma_unpin are done with dpt->obj lock held.
>>
>> I don't think there's much of a point in merging intel_dpt_pin() with
>> intel_pin_fb_obj_dpt(), they touch
From: Ville Syrjälä
"CRTC fixup failed" is probably leftovers from pre-atomic days
when there was an actual fixup() function. Let's unify the debug
messages between encoder vs. crtc compute_config() calls.
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/i915/display/intel_display.c | 2 +-
1
From: Ville Syrjälä
Check for the zero length front porch already in intel_mode_valid()
so that we get the same validation for both get_modes() and setcrtc()/etc.
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/i915/display/intel_display.c | 15 ---
1 file changed, 8
From: Ville Syrjälä
Unify how we check for -EDEADLK vs. other errors from
crtc vs. encoder compute_config() calls.
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/i915/display/intel_display.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git
== Series Details ==
Series: drm/i915/display: move modeset asserts out of intel_display.c
URL : https://patchwork.freedesktop.org/series/95258/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
25961813c19b drm/i915/fdi: move fdi modeset asserts to intel_fdi.c
-:133:
On Thu, 30 Sep 2021, Ville Syrjälä wrote:
> On Thu, Sep 30, 2021 at 12:22:58PM +0300, Jani Nikula wrote:
>
>> diff --git a/drivers/gpu/drm/i915/display/intel_fdi.c
>> b/drivers/gpu/drm/i915/display/intel_fdi.c
>> index af01d1fa761e..02d3294bad7b 100644
>> ---
On 2021-09-29 13:54, Thomas Hellström wrote:
> On Mon, 2021-09-27 at 12:41 +0100, Matthew Auld wrote:
>> This should let us do an accelerated copy directly to the shmem pages
>> when temporarily moving lmem-only objects, where the i915-gem
>> shrinker
>> can later kick in to swap out the pages, if
drm-misc-fixes-2021-09-30:
drm-misc-fixes for v5.15:
- Not sure if drm-misc-fixes-2021-09-08 tag was pulled, assuming it is.
- Power management fixes for vc4.
- Compiler fix for vc4.
- Cursor fix for nouveau.
- Fix ttm buffer moves for ampere gpu's by adding minimal acceleration support.
- Small
On 29/09/2021 19:33, Lucas De Marchi wrote:
> Like the IS_ENABLED() counterpart, we can make IS_CONFIG_NONZERO() to
> return the right thing when the config is not defined rather than a
> build error, with the limitation that it can't be used on preprocessor
> context.
>
> The trick here is that
On Thu, Sep 30, 2021 at 12:32:29PM +0300, Jani Nikula wrote:
> Using standard -EAGAIN should be perfectly fine instead of using a
> special case value.
Can't immediately spot any uses of -EAGAIN which would conflict here.
Reviewed-by: Ville Syrjälä
>
> Signed-off-by: Jani Nikula
> ---
>
On Thu, Sep 30, 2021 at 12:22:58PM +0300, Jani Nikula wrote:
> diff --git a/drivers/gpu/drm/i915/display/intel_fdi.c
> b/drivers/gpu/drm/i915/display/intel_fdi.c
> index af01d1fa761e..02d3294bad7b 100644
> --- a/drivers/gpu/drm/i915/display/intel_fdi.c
> +++
Using standard -EAGAIN should be perfectly fine instead of using a
special case value.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_display.c | 11 +--
drivers/gpu/drm/i915/display/intel_fdi.c | 2 +-
drivers/gpu/drm/i915/display/intel_fdi.h | 1 -
3 files
1 - 100 of 121 matches
Mail list logo
