[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/gvt: clean up kernel-doc in gtt.c

2021-10-02 Thread Patchwork
== Series Details == Series: drm/i915/gvt: clean up kernel-doc in gtt.c URL : https://patchwork.freedesktop.org/series/95382/ State : warning == Summary == $ dim checkpatch origin/drm-tip 95e817a1f93a drm/i915/gvt: clean up kernel-doc in gtt.c -:8: WARNING:COMMIT_LOG_LONG_LINE: Possible

[Intel-gfx] [PATCH] drm/i915/gvt: clean up kernel-doc in gtt.c

2021-10-02 Thread Randy Dunlap
Fix kernel-doc warnings in gtt.c: gtt.c:1152: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst * Check if can do 2M page gtt.c:1152: warning: missing initial short description on line: * Check if can do 2M page gtt.c:2209:

Re: [Intel-gfx] [PATCH v2 00/17] drm: cleanup: Use DRM_MODESET_LOCK_ALL_* helpers where possible

2021-10-02 Thread Fernando Ramos
On 21/10/02 09:13AM, Fernando Ramos wrote: > > Sean, could you revert the whole patch series? I'll have a deeper look into > the > patch set and come up with a v3 where all these issues will be addressed. > Hi Sean, I now understand the nature of the issue that caused the problem with i915

Re: [Intel-gfx] [PATCH 01/24] drm/i915/uncore: split the fw get function into separate vfunc

2021-10-02 Thread Ville Syrjälä
On Wed, Sep 29, 2021 at 01:57:45AM +0300, Jani Nikula wrote: > From: Dave Airlie > > constify it while here. drop the put function since it was never > overloaded and always has done the same thing, no point in > indirecting it for show. > > Reviewed-by: Jani Nikula > Signed-off-by: Dave

[Intel-gfx] ✓ Fi.CI.IGT: success for drm: Add privacy-screen class and connector properties (rev5)

2021-10-02 Thread Patchwork
== Series Details == Series: drm: Add privacy-screen class and connector properties (rev5) URL : https://patchwork.freedesktop.org/series/79259/ State : success == Summary == CI Bug Log - changes from CI_DRM_10680_full -> Patchwork_21229_full

[Intel-gfx] ✓ Fi.CI.BAT: success for drm: Add privacy-screen class and connector properties (rev5)

2021-10-02 Thread Patchwork
== Series Details == Series: drm: Add privacy-screen class and connector properties (rev5) URL : https://patchwork.freedesktop.org/series/79259/ State : success == Summary == CI Bug Log - changes from CI_DRM_10680 -> Patchwork_21229

Re: [Intel-gfx] [PATCH v2 00/17] drm: cleanup: Use DRM_MODESET_LOCK_ALL_* helpers where possible

2021-10-02 Thread Fernando Ramos
On 21/10/02 09:13AM, Fernando Ramos wrote: > On 21/10/02 05:30AM, Ville Syrjälä wrote: > > On Sat, Oct 02, 2021 at 01:05:47AM +0300, Ville Syrjälä wrote: > > > On Fri, Oct 01, 2021 at 04:48:15PM -0400, Sean Paul wrote: > > > > On Fri, Oct 01, 2021 at 10:00:50PM +0300, Ville Syrjälä wrote: > > > >

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm: Add privacy-screen class and connector properties (rev5)

2021-10-02 Thread Patchwork
== Series Details == Series: drm: Add privacy-screen class and connector properties (rev5) URL : https://patchwork.freedesktop.org/series/79259/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. - +

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm: Add privacy-screen class and connector properties (rev5)

2021-10-02 Thread Patchwork
== Series Details == Series: drm: Add privacy-screen class and connector properties (rev5) URL : https://patchwork.freedesktop.org/series/79259/ State : warning == Summary == $ dim checkpatch origin/drm-tip fa9e8ab5d112 drm/connector: Add support for privacy-screen properties (v4) -:151:

Re: [Intel-gfx] [BUG 5.15-rc3] kernel BUG at drivers/gpu/drm/i915/i915_sw_fence.c:245!

2021-10-02 Thread Linus Torvalds
On Sat, Oct 2, 2021 at 5:17 AM Steven Rostedt wrote: > > On Sat, 2 Oct 2021 03:17:29 -0700 (PDT) > Hugh Dickins wrote: > > > Yes (though bisection doesn't work right on this one): the fix > > Interesting, as it appeared to be very reliable. But I didn't do the > "try before / after" on the

[Intel-gfx] [PATCH 06/10] platform/x86: thinkpad_acpi: Add hotkey_notify_extended_hotkey() helper

2021-10-02 Thread Hans de Goede
Factor the extended hotkey handling out of hotkey_notify_hotkey() and into a new hotkey_notify_extended_hotkey() helper. This is a preparation patch for adding support the privacy-screen hotkey toggle (which needs some special handling, it should NOT send an evdev key-event to userspace...).

[Intel-gfx] [PATCH 08/10] platform/x86: thinkpad_acpi: Register a privacy-screen device

2021-10-02 Thread Hans de Goede
Register a privacy-screen device on laptops with a privacy-screen, this exports the PrivacyGuard features to user-space using a standardized vendor-agnostic sysfs interface. Note the sysfs interface is read-only. Registering a privacy-screen device with the new privacy-screen class code will also

[Intel-gfx] [PATCH 09/10] drm/i915: Add intel_modeset_probe_defer() helper

2021-10-02 Thread Hans de Goede
The upcoming privacy-screen support adds another check for deferring probe till some other drivers have bound first. Factor out the current vga_switcheroo_client_probe_defer() check into an intel_modeset_probe_defer() helper, so that further probe-deferral checks can be added there.

[Intel-gfx] [PATCH 10/10] drm/i915: Add privacy-screen support (v2)

2021-10-02 Thread Hans de Goede
Add support for eDP panels with a built-in privacy screen using the new drm_privacy_screen class. Changes in v2: - Call drm_connector_update_privacy_screen() from intel_enable_ddi_dp() / intel_ddi_update_pipe_dp() instead of adding a for_each_new_connector_in_state() loop to

[Intel-gfx] [PATCH 07/10] platform/x86: thinkpad_acpi: Get privacy-screen / lcdshadow ACPI handles only once

2021-10-02 Thread Hans de Goede
Get the privacy-screen / lcdshadow ACPI handles once and cache them, instead of retrieving them every time we need them. Reviewed-by: Emil Velikov Reviewed-by: Lyude Paul Signed-off-by: Hans de Goede --- drivers/platform/x86/thinkpad_acpi.c | 18 -- 1 file changed, 8

[Intel-gfx] [PATCH 05/10] drm/connector: Add a drm_connector privacy-screen helper functions (v2)

2021-10-02 Thread Hans de Goede
Add 2 drm_connector privacy-screen helper functions: 1. drm_connector_attach_privacy_screen_provider(), this function creates and attaches the standard privacy-screen properties and registers a generic notifier for generating sysfs-connector-status-events on external changes to the privacy-screen

[Intel-gfx] [PATCH 04/10] drm/privacy-screen: Add notifier support (v2)

2021-10-02 Thread Hans de Goede
Add support for privacy-screen consumers to register a notifier to be notified of external (e.g. done by the hw itself on a hotkey press) state changes. Changes in v2: - Drop WARN_ON(mutex_is_locked(>lock)) check in drm_privacy_screen_call_notifier_chain() it may be locked by another thread,

[Intel-gfx] [PATCH 03/10] drm/privacy-screen: Add X86 specific arch init code

2021-10-02 Thread Hans de Goede
Add X86 specific arch init code, which fills the privacy-screen lookup table by checking for various vendor specific ACPI interfaces for controlling the privacy-screen. This initial version only checks for the Lenovo Thinkpad specific ACPI methods for privacy-screen control. Reviewed-by: Emil

[Intel-gfx] [PATCH 02/10] drm: Add privacy-screen class (v4)

2021-10-02 Thread Hans de Goede
On some new laptops the LCD panel has a builtin electronic privacy-screen. We want to export this functionality as a property on the drm connector object. But often this functionality is not exposed on the GPU but on some other (ACPI) device. This commit adds a privacy-screen class allowing the

[Intel-gfx] [PATCH 00/10] drm: Add privacy-screen class and connector properties

2021-10-02 Thread Hans de Goede
Hi all, Here is a new version of my privacy-screen series, addressing the (few) review-remarks from the version posted on September 6th. This new version contains the following changes: - drm: Add privacy-screen class (v4) - Make drm_privacy_screen_set_sw_state() skip calling out to the hw if

[Intel-gfx] [PATCH 01/10] drm/connector: Add support for privacy-screen properties (v4)

2021-10-02 Thread Hans de Goede
From: Rajat Jain Add support for generic electronic privacy screen properties, that can be added by systems that have an integrated EPS. Changes in v2 (Hans de Goede) - Create 2 properties, "privacy-screen sw-state" and "privacy-screen hw-state", to deal with devices where the OS might be

[Intel-gfx] ✓ Fi.CI.IGT: success for kernel BUG at drivers/gpu/drm/i915/i915_sw_fence.c:245!

2021-10-02 Thread Patchwork
== Series Details == Series: kernel BUG at drivers/gpu/drm/i915/i915_sw_fence.c:245! URL : https://patchwork.freedesktop.org/series/95368/ State : success == Summary == CI Bug Log - changes from CI_DRM_10680_full -> Patchwork_21228_full

Re: [Intel-gfx] [BUG 5.15-rc3] kernel BUG at drivers/gpu/drm/i915/i915_sw_fence.c:245!

2021-10-02 Thread Steven Rostedt
On Sat, 2 Oct 2021 03:17:29 -0700 (PDT) Hugh Dickins wrote: > Yes (though bisection doesn't work right on this one): the fix Interesting, as it appeared to be very reliable. But I didn't do the "try before / after" on the patch. >

[Intel-gfx] ✓ Fi.CI.BAT: success for kernel BUG at drivers/gpu/drm/i915/i915_sw_fence.c:245!

2021-10-02 Thread Patchwork
== Series Details == Series: kernel BUG at drivers/gpu/drm/i915/i915_sw_fence.c:245! URL : https://patchwork.freedesktop.org/series/95368/ State : success == Summary == CI Bug Log - changes from CI_DRM_10680 -> Patchwork_21228 Summary

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for kernel BUG at drivers/gpu/drm/i915/i915_sw_fence.c:245!

2021-10-02 Thread Patchwork
== Series Details == Series: kernel BUG at drivers/gpu/drm/i915/i915_sw_fence.c:245! URL : https://patchwork.freedesktop.org/series/95368/ State : warning == Summary == $ dim checkpatch origin/drm-tip 234e2c966647 kernel BUG at drivers/gpu/drm/i915/i915_sw_fence.c:245! -:75:

Re: [Intel-gfx] [PATCH v2 0/4] drm/dp, drm/i915: Finish basic PWM support for VESA backlight helpers

2021-10-02 Thread Hans de Goede
Hi Lyude, On 10/2/21 12:53 AM, Lyude Paul wrote: > When I originally moved all of the VESA backlight code in i915 into DRM > helpers, one of the things I didn't have the hardware or time for > testing was machines that used a combination of PWM and DPCD in order to > control their backlights.

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/dp, drm/i915: Finish basic PWM support for VESA backlight helpers (rev3)

2021-10-02 Thread Patchwork
== Series Details == Series: drm/dp, drm/i915: Finish basic PWM support for VESA backlight helpers (rev3) URL : https://patchwork.freedesktop.org/series/95127/ State : success == Summary == CI Bug Log - changes from CI_DRM_10680_full -> Patchwork_21227_full

Re: [Intel-gfx] [PATCH v2 00/17] drm: cleanup: Use DRM_MODESET_LOCK_ALL_* helpers where possible

2021-10-02 Thread Fernando Ramos
On 21/10/02 05:30AM, Ville Syrjälä wrote: > On Sat, Oct 02, 2021 at 01:05:47AM +0300, Ville Syrjälä wrote: > > On Fri, Oct 01, 2021 at 04:48:15PM -0400, Sean Paul wrote: > > > On Fri, Oct 01, 2021 at 10:00:50PM +0300, Ville Syrjälä wrote: > > > > On Fri, Oct 01, 2021 at 02:36:55PM -0400, Sean Paul

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/display: Wait PSR2 get out of deep sleep to update pipe (rev2)

2021-10-02 Thread Patchwork
== Series Details == Series: drm/i915/display: Wait PSR2 get out of deep sleep to update pipe (rev2) URL : https://patchwork.freedesktop.org/series/95309/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10680_full -> Patchwork_21225_full

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Update memory bandwidth formulae (rev5)

2021-10-02 Thread Patchwork
== Series Details == Series: drm/i915: Update memory bandwidth formulae (rev5) URL : https://patchwork.freedesktop.org/series/95138/ State : success == Summary == CI Bug Log - changes from CI_DRM_10680_full -> Patchwork_21224_full Summary

[Intel-gfx] [BUG 5.15-rc3] kernel BUG at drivers/gpu/drm/i915/i915_sw_fence.c:245!

2021-10-02 Thread Steven Rostedt
When I tried to test patches applied to v5.15-rc3, I hit this bug (and hence can not test my code), on 32 bit x86. [ cut here ] kernel BUG at drivers/gpu/drm/i915/i915_sw_fence.c:245! invalid opcode: [#1] SMP PTI CPU: 3 PID: 1 Comm: swapper/0 Not tainted