[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: split out i915_reg_read_ioctl() to i915_ioctl.[ch]

2022-01-20 Thread Patchwork
== Series Details == Series: drm/i915: split out i915_reg_read_ioctl() to i915_ioctl.[ch] URL : https://patchwork.freedesktop.org/series/99096/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: split out i915_reg_read_ioctl() to i915_ioctl.[ch]

2022-01-20 Thread Patchwork
== Series Details == Series: drm/i915: split out i915_reg_read_ioctl() to i915_ioctl.[ch] URL : https://patchwork.freedesktop.org/series/99096/ State : warning == Summary == $ dim checkpatch origin/drm-tip 74252406bb4c drm/i915: split out i915_reg_read_ioctl() to i915_ioctl.[ch] -:57: WARNING:

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Sanitycheck PCI BARs on probe

2022-01-20 Thread Patchwork
== Series Details == Series: drm/i915: Sanitycheck PCI BARs on probe URL : https://patchwork.freedesktop.org/series/99094/ State : failure == Summary == CI Bug Log - changes from CI_DRM_1 -> Patchwork_22038 Summary --- **FAILURE*

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/locking: fix drm_modeset_acquire_ctx kernel-doc

2022-01-20 Thread Patchwork
== Series Details == Series: drm/locking: fix drm_modeset_acquire_ctx kernel-doc URL : https://patchwork.freedesktop.org/series/99090/ State : failure == Summary == CI Bug Log - changes from CI_DRM_1_full -> Patchwork_22035_full Summary

Re: [Intel-gfx] [PATCH] drm/i915: split out i915_reg_read_ioctl() to i915_ioctl.[ch]

2022-01-20 Thread Tvrtko Ursulin
On 20/01/2022 11:33, Jani Nikula wrote: Add new files i915_ioctl.[ch] to hold small ioctls that are out of place everywhere else, and not big enough to warrant a file of their own. For starters, it's just for i915_reg_read_ioctl() that's a bit high level for a low level implementation that int

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [RESEND,1/7] drm/i915/mst: fix intel_dp_mst_hpd_irq() indentation (rev2)

2022-01-20 Thread Patchwork
== Series Details == Series: series starting with [RESEND,1/7] drm/i915/mst: fix intel_dp_mst_hpd_irq() indentation (rev2) URL : https://patchwork.freedesktop.org/series/98788/ State : success == Summary == CI Bug Log - changes from CI_DRM_1 -> Patchwork_22037

Re: [Intel-gfx] [PATCH v2 4/4] drm/i915/uapi: document behaviour for DG2 64K support

2022-01-20 Thread Ramalingam C
On 2022-01-18 at 17:50:37 +, Robert Beckett wrote: > From: Matthew Auld > > On discrete platforms like DG2, we need to support a minimum page size > of 64K when dealing with device local-memory. This is quite tricky for > various reasons, so try to document the new implicit uapi for this. >

Re: [Intel-gfx] [PATCH] drm/locking: fix drm_modeset_acquire_ctx kernel-doc

2022-01-20 Thread Jani Nikula
On Thu, 20 Jan 2022, Daniel Vetter wrote: > On Thu, Jan 20, 2022 at 10:49 AM Jani Nikula wrote: >> >> The stack_depot member was added without kernel-doc, leading to below >> warning. Fix it. >> >> ./include/drm/drm_modeset_lock.h:74: warning: Function parameter or >> member 'stack_depot' not des

Re: [Intel-gfx] [PATCH v2 1/4] drm/i915: enforce min GTT alignment for discrete cards

2022-01-20 Thread Ramalingam C
On 2022-01-18 at 17:50:34 +, Robert Beckett wrote: > From: Matthew Auld > > For local-memory objects we need to align the GTT addresses > to 64K, both for the ppgtt and ggtt. > > We need to support vm->min_alignment > 4K, depending > on the vm itself and the type of object we are inserting.

Re: [Intel-gfx] [PATCH] drm/locking: fix drm_modeset_acquire_ctx kernel-doc

2022-01-20 Thread Stephen Rothwell
Hi Jani, On Thu, 20 Jan 2022 11:48:56 +0200 Jani Nikula wrote: > > The stack_depot member was added without kernel-doc, leading to below > warning. Fix it. > > ./include/drm/drm_modeset_lock.h:74: warning: Function parameter or > member 'stack_depot' not described in 'drm_modeset_acquire_ctx' >

[Intel-gfx] [PATCH] drm/i915: split out i915_reg_read_ioctl() to i915_ioctl.[ch]

2022-01-20 Thread Jani Nikula
Add new files i915_ioctl.[ch] to hold small ioctls that are out of place everywhere else, and not big enough to warrant a file of their own. For starters, it's just for i915_reg_read_ioctl() that's a bit high level for a low level implementation that intel_uncore.[ch] is. Suggested-by: Tvrtko Ursu

Re: [Intel-gfx] [PATCH RESEND 7/7] drm/i915/mst: only ack the ESI we actually handled

2022-01-20 Thread Shankar, Uma
> -Original Message- > From: Nikula, Jani > Sent: Thursday, January 20, 2022 4:32 PM > To: Shankar, Uma ; intel-gfx@lists.freedesktop.org > Subject: Re: [Intel-gfx] [PATCH RESEND 7/7] drm/i915/mst: only ack the ESI we > actually handled > > On Thu, 20 Jan 2022, "Shankar, Uma" wrote: >

Re: [Intel-gfx] [PATCH v2] drm/i915/mst: only ack the ESI we actually handled

2022-01-20 Thread Shankar, Uma
> -Original Message- > From: Intel-gfx On Behalf Of Jani > Nikula > Sent: Thursday, January 20, 2022 4:31 PM > To: Nikula, Jani ; intel-gfx@lists.freedesktop.org > Subject: [Intel-gfx] [PATCH v2] drm/i915/mst: only ack the ESI we actually > handled > > Seems odd that we clear all eve

Re: [Intel-gfx] [PATCH] drm/locking: fix drm_modeset_acquire_ctx kernel-doc

2022-01-20 Thread Daniel Vetter
On Thu, Jan 20, 2022 at 10:49 AM Jani Nikula wrote: > > The stack_depot member was added without kernel-doc, leading to below > warning. Fix it. > > ./include/drm/drm_modeset_lock.h:74: warning: Function parameter or > member 'stack_depot' not described in 'drm_modeset_acquire_ctx' > > Reported-by

Re: [Intel-gfx] [PATCH RESEND 2/7] drm/i915/mst: abstract intel_dp_ack_sink_irq_esi()

2022-01-20 Thread Shankar, Uma
> -Original Message- > From: Intel-gfx On Behalf Of Jani > Nikula > Sent: Wednesday, January 12, 2022 4:33 PM > To: intel-gfx@lists.freedesktop.org > Cc: Nikula, Jani > Subject: [Intel-gfx] [PATCH RESEND 2/7] drm/i915/mst: abstract > intel_dp_ack_sink_irq_esi() > > Smaller functions

Re: [Intel-gfx] [PATCH RESEND 1/7] drm/i915/mst: fix intel_dp_mst_hpd_irq() indentation

2022-01-20 Thread Shankar, Uma
> -Original Message- > From: Intel-gfx On Behalf Of Jani > Nikula > Sent: Wednesday, January 12, 2022 4:33 PM > To: intel-gfx@lists.freedesktop.org > Cc: Nikula, Jani > Subject: [Intel-gfx] [PATCH RESEND 1/7] drm/i915/mst: fix > intel_dp_mst_hpd_irq() > indentation > > Remove extra

[Intel-gfx] [PATCH] drm/i915: Sanitycheck PCI BARs on probe

2022-01-20 Thread Piorkowski, Piotr
From: Piotr Piórkowski For proper operation of i915 we need usable PCI BARs: - GTTMMADDR BAR 0 (1 for GEN2) - GFXMEM BAR 2. Lets check before we start the i915 probe that these BARs are set, and that they have a size greater than 0. Signed-off-by: Piotr Piórkowski Cc: Michal Wajdeczko Cc: Ja

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/mst: DP MST ESI handling improvements (rev2)

2022-01-20 Thread Patchwork
== Series Details == Series: drm/i915/mst: DP MST ESI handling improvements (rev2) URL : https://patchwork.freedesktop.org/series/98479/ State : success == Summary == CI Bug Log - changes from CI_DRM_1 -> Patchwork_22036 Summary ---

Re: [Intel-gfx] [PATCH RESEND 7/7] drm/i915/mst: only ack the ESI we actually handled

2022-01-20 Thread Jani Nikula
On Thu, 20 Jan 2022, "Shankar, Uma" wrote: >> -Original Message- >> From: Intel-gfx On Behalf Of Jani >> Nikula >> Sent: Wednesday, January 12, 2022 4:33 PM >> To: intel-gfx@lists.freedesktop.org >> Cc: Nikula, Jani >> Subject: [Intel-gfx] [PATCH RESEND 7/7] drm/i915/mst: only ack the E

[Intel-gfx] [PATCH v2] drm/i915/mst: only ack the ESI we actually handled

2022-01-20 Thread Jani Nikula
Seems odd that we clear all event status indicators if we've only handled some. Only clear the ones we've handled. v2: ack DOWN_REP and UP_REQ only if they were set in esi (Ville) Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_dp.c | 20 1 file changed, 1

Re: [Intel-gfx] [PATCH 5/6] drm/i915: Move GT registers to their own header file

2022-01-20 Thread kernel test robot
Hi Matt, Thank you for the patch! Yet something to improve: [auto build test ERROR on drm-tip/drm-tip] [cannot apply to drm-intel/for-linux-next v5.16 next-20220120] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--bas

Re: [Intel-gfx] [PATCH RESEND 7/7] drm/i915/mst: only ack the ESI we actually handled

2022-01-20 Thread Shankar, Uma
> -Original Message- > From: Intel-gfx On Behalf Of Jani > Nikula > Sent: Wednesday, January 12, 2022 4:33 PM > To: intel-gfx@lists.freedesktop.org > Cc: Nikula, Jani > Subject: [Intel-gfx] [PATCH RESEND 7/7] drm/i915/mst: only ack the ESI we > actually > handled > > Seems odd that

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/locking: fix drm_modeset_acquire_ctx kernel-doc

2022-01-20 Thread Patchwork
== Series Details == Series: drm/locking: fix drm_modeset_acquire_ctx kernel-doc URL : https://patchwork.freedesktop.org/series/99090/ State : success == Summary == CI Bug Log - changes from CI_DRM_1 -> Patchwork_22035 Summary ---

Re: [Intel-gfx] [PATCH RESEND 6/7] drm/i915/mst: ack sink irq ESI for link status changes

2022-01-20 Thread Shankar, Uma
> -Original Message- > From: Intel-gfx On Behalf Of Jani > Nikula > Sent: Wednesday, January 12, 2022 4:33 PM > To: intel-gfx@lists.freedesktop.org > Cc: Nikula, Jani > Subject: [Intel-gfx] [PATCH RESEND 6/7] drm/i915/mst: ack sink irq ESI for > link status > changes > > Only specif

Re: [Intel-gfx] [PATCH RESEND 5/7] drm/i915/mst: read link status only when requested by sink in ESI

2022-01-20 Thread Shankar, Uma
> -Original Message- > From: Intel-gfx On Behalf Of Jani > Nikula > Sent: Wednesday, January 12, 2022 4:33 PM > To: intel-gfx@lists.freedesktop.org > Cc: Nikula, Jani > Subject: [Intel-gfx] [PATCH RESEND 5/7] drm/i915/mst: read link status only > when > requested by sink in ESI > >

Re: [Intel-gfx] [PATCH RESEND 4/7] drm/i915/mst: abstract handling of link status in DP MST

2022-01-20 Thread Shankar, Uma
> -Original Message- > From: Intel-gfx On Behalf Of Jani > Nikula > Sent: Wednesday, January 12, 2022 4:33 PM > To: intel-gfx@lists.freedesktop.org > Cc: Nikula, Jani > Subject: [Intel-gfx] [PATCH RESEND 4/7] drm/i915/mst: abstract handling of > link > status in DP MST > > We'll wan

Re: [Intel-gfx] [PATCH RESEND 3/7] drm/i915/mst: debug log 4 bytes of ESI right after reading

2022-01-20 Thread Shankar, Uma
> -Original Message- > From: Intel-gfx On Behalf Of Jani > Nikula > Sent: Wednesday, January 12, 2022 4:33 PM > To: intel-gfx@lists.freedesktop.org > Cc: Nikula, Jani > Subject: [Intel-gfx] [PATCH RESEND 3/7] drm/i915/mst: debug log 4 bytes of > ESI right > after reading > > For wha

Re: [Intel-gfx] [PATCH 2/2] drm/i915/uncore: rename i915_reg_read_ioctl intel_uncore_reg_read_ioctl

2022-01-20 Thread Tvrtko Ursulin
On 19/01/2022 11:12, Jani Nikula wrote: On Wed, 05 Jan 2022, Tvrtko Ursulin wrote: On 05/01/2022 13:18, Jani Nikula wrote: On Wed, 05 Jan 2022, Tvrtko Ursulin wrote: On 05/01/2022 10:32, Jani Nikula wrote: On Wed, 05 Jan 2022, Tvrtko Ursulin wrote: On 05/01/2022 10:05, Jani Nikula wrote

Re: [Intel-gfx] [PATCH 2/7] drm/i915/mst: abstract intel_dp_ack_sink_irq_esi()

2022-01-20 Thread Shankar, Uma
> -Original Message- > From: Nikula, Jani > Sent: Thursday, January 20, 2022 4:02 PM > To: Shankar, Uma ; intel-gfx@lists.freedesktop.org > Subject: RE: [Intel-gfx] [PATCH 2/7] drm/i915/mst: abstract > intel_dp_ack_sink_irq_esi() > > On Thu, 20 Jan 2022, "Shankar, Uma" wrote: > >>

Re: [Intel-gfx] [PATCH 2/7] drm/i915/mst: abstract intel_dp_ack_sink_irq_esi()

2022-01-20 Thread Jani Nikula
On Thu, 20 Jan 2022, "Shankar, Uma" wrote: >> -Original Message- >> From: Intel-gfx On Behalf Of Jani >> Nikula >> Sent: Tuesday, January 4, 2022 11:10 PM >> To: intel-gfx@lists.freedesktop.org >> Cc: Nikula, Jani >> Subject: [Intel-gfx] [PATCH 2/7] drm/i915/mst: abstract >> intel_dp_a

[Intel-gfx] [PATCH v2] drm/i915/mst: only ack the ESI we actually handled

2022-01-20 Thread Jani Nikula
Seems odd that we clear all event status indicators if we've only handled some. Only clear the ones we've handled. v2: ack DOWN_REP and UP_REQ only if they were set in esi (Ville) Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_dp.c | 20 1 file changed, 1

Re: [Intel-gfx] [PATCH 6/7] drm: Document fdinfo format specification

2022-01-20 Thread Tvrtko Ursulin
On 19/01/2022 15:08, Daniel Vetter wrote: On Thu, Jan 06, 2022 at 04:55:35PM +, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Proposal to standardise the fdinfo text format as optionally output by DRM drivers. Idea is that a simple but, well defined, spec will enable generic userspace tool

Re: [Intel-gfx] [PATCH 2/7] drm/i915/mst: abstract intel_dp_ack_sink_irq_esi()

2022-01-20 Thread Shankar, Uma
> -Original Message- > From: Intel-gfx On Behalf Of Jani > Nikula > Sent: Tuesday, January 4, 2022 11:10 PM > To: intel-gfx@lists.freedesktop.org > Cc: Nikula, Jani > Subject: [Intel-gfx] [PATCH 2/7] drm/i915/mst: abstract > intel_dp_ack_sink_irq_esi() > > Smaller functions make the

Re: [Intel-gfx] [PATCH 1/7] drm/i915/mst: fix intel_dp_mst_hpd_irq() indentation

2022-01-20 Thread Shankar, Uma
> -Original Message- > From: Intel-gfx On Behalf Of Jani > Nikula > Sent: Tuesday, January 4, 2022 11:10 PM > To: intel-gfx@lists.freedesktop.org > Cc: Nikula, Jani > Subject: [Intel-gfx] [PATCH 1/7] drm/i915/mst: fix intel_dp_mst_hpd_irq() > indentation > > Remove extra indentation.

Re: [Intel-gfx] [PATCH 0/6] drm/i915: Extend parse_ddi_port() to all g4x+ platforms

2022-01-20 Thread Jani Nikula
On Thu, 20 Jan 2022, Ville Syrjälä wrote: > On Fri, Dec 17, 2021 at 05:53:57PM +0200, Ville Syrjala wrote: >> From: Ville Syrjälä >> >> Quick attempt at unifying the VBT DDI parsing to all g4x+ >> platforms. >> >> Note that we'll still use the hardware straps as the primary >> source of port p

[Intel-gfx] [PULL] drm-intel-next-fixes

2022-01-20 Thread Tvrtko Ursulin
Hi Dave and Daniel, A couple display fixes for the merge window. One for EHL and one for ADL-P, and both in the are of voltage swing programming. Regards, Tvrtko --- drm-intel-next-fixes-2022-01-20: - Latest updates for the EHL display voltage swing table (José Roberto de Souza) - Additional

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/locking: fix drm_modeset_acquire_ctx kernel-doc

2022-01-20 Thread Patchwork
== Series Details == Series: drm/locking: fix drm_modeset_acquire_ctx kernel-doc URL : https://patchwork.freedesktop.org/series/99090/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

Re: [Intel-gfx] [PATCH 6/6] drm/i915: Only include i915_reg.h from .c files

2022-01-20 Thread Jani Nikula
On Wed, 19 Jan 2022, Matt Roper wrote: > Several of our i915 header files, have been including i915_reg.h. This > means that any change to i915_reg.h will trigger a full rebuild of > pretty much every file of the driver, even those that don't have any > kind of register access. Let's delete the

Re: [Intel-gfx] [PATCH] drm/i915: Fix vma resource freeing

2022-01-20 Thread Matthew Auld
On 19/01/2022 17:47, Thomas Hellström wrote: In some cases we use leftover kfree() instead of i915_vma_resource_free(). Fix this. Fixes: Fixes: 2f6b90da9192 ("drm/i915: Use vma resources for async unbinding") Reported-by: Robert Beckett Cc: Matthew Auld Signed-off-by: Thomas Hellström Review

Re: [Intel-gfx] [PATCH 2/6] drm/i915/perf: Express OA register ranges with i915_range

2022-01-20 Thread Jani Nikula
On Wed, 19 Jan 2022, Matt Roper wrote: > Let's use 'struct i915_range' to express sets of b-counter and mux > registers in the perf code. This makes the code more similar to how we > handle things like multicast register ranges, forcewake tables, shadow > tables, etc. and also lets us avoid needi

Re: [Intel-gfx] linux-next: build warning after merge of the drm-misc tree

2022-01-20 Thread Jani Nikula
On Thu, 20 Jan 2022, Stephen Rothwell wrote: > Hi all, > > On Fri, 15 Oct 2021 21:01:04 +1100 Stephen Rothwell > wrote: >> >> After merging the drm-misc tree, today's linux-next build (htmldocs) >> produced this warning: >> >> include/drm/drm_modeset_lock.h:74: warning: Function parameter or me

[Intel-gfx] [PATCH] drm/locking: fix drm_modeset_acquire_ctx kernel-doc

2022-01-20 Thread Jani Nikula
The stack_depot member was added without kernel-doc, leading to below warning. Fix it. ./include/drm/drm_modeset_lock.h:74: warning: Function parameter or member 'stack_depot' not described in 'drm_modeset_acquire_ctx' Reported-by: Stephen Rothwell Fixes: cd06ab2fd48f ("drm/locking: add backtrac

Re: [Intel-gfx] [PATCH 0/3] lib/string_helpers: Add a few string helpers

2022-01-20 Thread Jani Nikula
On Thu, 20 Jan 2022, Petr Mladek wrote: > On Wed 2022-01-19 16:16:12, Jani Nikula wrote: >> On Wed, 19 Jan 2022, Petr Mladek wrote: >> > On Tue 2022-01-18 23:24:47, Lucas De Marchi wrote: >> >> d. This doesn't bring onoff() helper as there are some places in the >> >>kernel with onoff as vari

Re: [Intel-gfx] [PATCH 0/3] lib/string_helpers: Add a few string helpers

2022-01-20 Thread David Laight
... > Yeah, and I am sorry for bikeshedding. Honestly, I do not know what is > better. This is why I do not want to block this series when others > like this. > > My main motivation is to point out that: > > enabledisable(enable) > > might be, for some people, more eye bleeding than > >

[Intel-gfx] ✗ Fi.CI.IGT: failure for Second round of i915_reg.h splitting

2022-01-20 Thread Patchwork
== Series Details == Series: Second round of i915_reg.h splitting URL : https://patchwork.freedesktop.org/series/99079/ State : failure == Summary == CI Bug Log - changes from CI_DRM_1_full -> Patchwork_22034_full Summary --- **F

<    1   2