Re: [Intel-gfx] [PATCH 13/20] drm/i915/ttm: mappable migration on fault

2022-02-02 Thread Thomas Hellström
On 1/26/22 16:21, Matthew Auld wrote: The end goal is to have userspace tell the kernel what buffers will require CPU access, however if we ever reach the CPU fault handler, and the current resource is not mappable, then we should attempt to migrate the buffer to the mappable portion of LMEM,

[Intel-gfx] ✗ Fi.CI.BAT: failure for linux-next: manual merge of the drm-intel-gt tree with the drm-intel tree (rev2)

2022-02-02 Thread Patchwork
== Series Details == Series: linux-next: manual merge of the drm-intel-gt tree with the drm-intel tree (rev2) URL : https://patchwork.freedesktop.org/series/99294/ State : failure == Summary == Applying: linux-next: manual merge of the drm-intel-gt tree with the drm-intel tree Using index

[Intel-gfx] linux-next: manual merge of the drm-intel-gt tree with the drm-intel tree

2022-02-02 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the drm-intel-gt tree got a conflict in: drivers/gpu/drm/i915/i915_reg.h between commit: 0d6419e9c855 ("drm/i915: Move GT registers to their own header file") from the drm-intel tree and commit: 270677026261 ("drm/i915/dg2: Add Wa_14015227452") from

[Intel-gfx] linux-next: manual merge of the drm-intel tree with the drm-intel-fixes tree

2022-02-02 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the drm-intel tree got a conflict in: drivers/gpu/drm/i915/i915_reg.h between commit: b3f74938d656 ("drm/i915/pmu: Use PM timestamp instead of RING TIMESTAMP for reference") from the drm-intel-fixes tree and commit: 22ba60f617bd ("drm/i915: Move

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: opportunistically apply ALLOC_CONTIGIOUS

2022-02-02 Thread Patchwork
== Series Details == Series: drm/i915: opportunistically apply ALLOC_CONTIGIOUS URL : https://patchwork.freedesktop.org/series/99631/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11180_full -> Patchwork_22161_full Summary

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Disable unused power wells left enabled by BIOS (rev2)

2022-02-02 Thread Patchwork
== Series Details == Series: drm/i915: Disable unused power wells left enabled by BIOS (rev2) URL : https://patchwork.freedesktop.org/series/99615/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11180_full -> Patchwork_22160_full

Re: [Intel-gfx] [PATCH] drm/i915: Flip guc_id allocation partition

2022-02-02 Thread Michal Wajdeczko
On 13.01.2022 17:27, Matthew Brost wrote: > Move the multi-lrc guc_id from the lower allocation partition (0 to > number of multi-lrc guc_ids) to upper allocation partition (number of > single-lrc to max guc_ids). > > This will help when a native driver transitions to a PF after driver > load

Re: [Intel-gfx] [PATCH 1/6] drm: add writeback pointers to drm_connector

2022-02-02 Thread kernel test robot
Hi Kandpal, Thank you for the patch! Yet something to improve: [auto build test ERROR on drm/drm-next] [also build test ERROR on drm-intel/for-linux-next drm-tip/drm-tip v5.17-rc2 next-20220202] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: opportunistically apply ALLOC_CONTIGIOUS

2022-02-02 Thread Patchwork
== Series Details == Series: drm/i915: opportunistically apply ALLOC_CONTIGIOUS URL : https://patchwork.freedesktop.org/series/99631/ State : success == Summary == CI Bug Log - changes from CI_DRM_11180 -> Patchwork_22161 Summary ---

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Disable unused power wells left enabled by BIOS (rev2)

2022-02-02 Thread Patchwork
== Series Details == Series: drm/i915: Disable unused power wells left enabled by BIOS (rev2) URL : https://patchwork.freedesktop.org/series/99615/ State : success == Summary == CI Bug Log - changes from CI_DRM_11180 -> Patchwork_22160

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: Disable unused power wells left enabled by BIOS (rev2)

2022-02-02 Thread Patchwork
== Series Details == Series: drm/i915: Disable unused power wells left enabled by BIOS (rev2) URL : https://patchwork.freedesktop.org/series/99615/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Fix vma lifetime (rev2)

2022-02-02 Thread Patchwork
== Series Details == Series: drm/i915: Fix vma lifetime (rev2) URL : https://patchwork.freedesktop.org/series/99618/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11178 -> Patchwork_22159 Summary --- **FAILURE**

[Intel-gfx] [PATCH] drm/i915: opportunistically apply ALLOC_CONTIGIOUS

2022-02-02 Thread Matthew Auld
It looks like this code was accidentally dropped at some point(in a slightly different form), so add it back. The gist is that if we know the allocation will be one single chunk, then we can just annotate the BO with I915_BO_ALLOC_CONTIGUOUS, even if the user doesn't bother. In the future this

Re: [Intel-gfx] [PATCH v3 1/3] drm: Stop spamming log with drm_cache message

2022-02-02 Thread Rodrigo Vivi
On Tue, Feb 01, 2022 at 09:41:33AM -0800, Lucas De Marchi wrote: > On Tue, Feb 01, 2022 at 09:12:05AM -0800, Jose Souza wrote: > > On Mon, 2022-01-31 at 08:59 -0800, Lucas De Marchi wrote: > > > Only x86 and in some cases PPC have support added in drm_cache.c for the > > > clflush class of

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: Fix vma lifetime (rev2)

2022-02-02 Thread Patchwork
== Series Details == Series: drm/i915: Fix vma lifetime (rev2) URL : https://patchwork.freedesktop.org/series/99618/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

Re: [Intel-gfx] [PATCH v2 4/4] drm/i915/: Re-work clflush_write32

2022-02-02 Thread Michael Cheng
As far as I know, we haven't gotten to the arm implementation yet, since we are trying to get i915 compile for arm without using random ifdefs and dummy functions. "Noob question - why is i915 the only driver calling it? Do other GPUs never need to flush CPU cache?" Unfortunately I don't

Re: [Intel-gfx] [RFC 0/2] Compile out integrated

2022-02-02 Thread Lucas De Marchi
On Wed, Feb 02, 2022 at 10:26:46AM +, Tvrtko Ursulin wrote: On 01/02/2022 17:28, Lucas De Marchi wrote: On Tue, Feb 01, 2022 at 07:09:14PM +0200, Jani Nikula wrote: On Tue, 01 Feb 2022, Lucas De Marchi wrote: On Tue, Feb 01, 2022 at 11:15:31AM +, Tvrtko Ursulin wrote: From: Tvrtko

Re: [Intel-gfx] [PATCH v2 1/2] drm/i915/vga: switch to use VGA definitions from video/vga.h

2022-02-02 Thread Jani Nikula
On Wed, 02 Feb 2022, Ville Syrjälä wrote: > On Wed, Feb 02, 2022 at 01:25:08PM +0200, Jani Nikula wrote: >> The video/vga.h has macros for the VGA registers. Switch to use them. >> >> v2: Use direct 0x01 instead of the confusing VGA_SEQ_CLOCK_MODE (Ville) >> >> Suggested-by: Matt Roper >> Cc:

Re: [Intel-gfx] [PATCH 5/6] drm/rcar_du: changes to rcar-du driver resulting from drm_writeback_connector structure changes

2022-02-02 Thread Jani Nikula
On Wed, 02 Feb 2022, Dmitry Baryshkov wrote: > On Wed, 2 Feb 2022 at 16:15, Jani Nikula wrote: >> >> On Wed, 02 Feb 2022, Laurent Pinchart >> wrote: >> > Hi Kandpal, >> > >> > Thank you for the patch. >> > >> > On Wed, Feb 02, 2022 at 02:24:28PM +0530, Kandpal Suraj wrote: >> >> Changing

Re: [Intel-gfx] [PATCH 5/6] drm/rcar_du: changes to rcar-du driver resulting from drm_writeback_connector structure changes

2022-02-02 Thread Jani Nikula
On Wed, 02 Feb 2022, Laurent Pinchart wrote: > Hi Jani, > > On Wed, Feb 02, 2022 at 03:15:03PM +0200, Jani Nikula wrote: >> On Wed, 02 Feb 2022, Laurent Pinchart wrote: >> > On Wed, Feb 02, 2022 at 02:24:28PM +0530, Kandpal Suraj wrote: >> >> Changing rcar_du driver to accomadate the change of >>

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: fix null pointer dereference

2022-02-02 Thread Patchwork
== Series Details == Series: drm/i915: fix null pointer dereference URL : https://patchwork.freedesktop.org/series/99621/ State : success == Summary == CI Bug Log - changes from CI_DRM_11177_full -> Patchwork_22158_full Summary ---

[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [v2,1/2] drm/i915/vga: switch to use VGA definitions from video/vga.h

2022-02-02 Thread Patchwork
== Series Details == Series: series starting with [v2,1/2] drm/i915/vga: switch to use VGA definitions from video/vga.h URL : https://patchwork.freedesktop.org/series/99617/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11177_full -> Patchwork_22156_full

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: fix null pointer dereference

2022-02-02 Thread Patchwork
== Series Details == Series: drm/i915: fix null pointer dereference URL : https://patchwork.freedesktop.org/series/99621/ State : success == Summary == CI Bug Log - changes from CI_DRM_11177 -> Patchwork_22158 Summary ---

Re: [Intel-gfx] [PATCH v2] dma-buf-map: Rename to iosys-map

2022-02-02 Thread Sumit Semwal
Hello Lucas, On Wed, 2 Feb 2022 at 15:08, Lucas De Marchi wrote: > > On Wed, Feb 02, 2022 at 10:25:28AM +0100, Christian König wrote: > >Am 02.02.22 um 10:11 schrieb Lucas De Marchi: > >>[SNIP] > >>diff --git a/MAINTAINERS b/MAINTAINERS > >>index d03ad8da1f36..112676f11792 100644 > >>---

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Fix vma lifetime

2022-02-02 Thread Patchwork
== Series Details == Series: drm/i915: Fix vma lifetime URL : https://patchwork.freedesktop.org/series/99618/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11177 -> Patchwork_22157 Summary --- **FAILURE** Serious

Re: [Intel-gfx] [PATCH 01/21] MAINTAINERS: Add entry for fbdev core

2022-02-02 Thread Alex Deucher
Acked-by: Alex Deucher On Wed, Feb 2, 2022 at 6:31 AM Maxime Ripard wrote: > > On Mon, Jan 31, 2022 at 10:05:32PM +0100, Daniel Vetter wrote: > > Ever since Tomi extracted the core code in 2014 it's been defacto me > > maintaining this, with help from others from dri-devel and sometimes > >

Re: [Intel-gfx] [PATCH 12/20] drm/i915/ttm: make eviction mappable aware

2022-02-02 Thread Thomas Hellström
On 1/26/22 16:21, Matthew Auld wrote: If we need to make room for some some mappable object, then we should only victimize objects that have one or pages that occupy the visible portion of LMEM. Let's also create a new priority hint for objects that are placed in mappable memory, where we know

Re: [Intel-gfx] [PATCH 1/6] drm: add writeback pointers to drm_connector

2022-02-02 Thread Dmitry Baryshkov
On Wed, 2 Feb 2022 at 11:46, Kandpal Suraj wrote: > > Changing drm_connector and drm_encoder feilds to pointers in > drm_writeback_connector as the elements of struct > drm_writeback_connector are: > struct drm_writeback_connector { > struct drm_connector base; > struct

[Intel-gfx] [PATCH v1] drm/i915: fix null pointer dereference

2022-02-02 Thread Lukasz Bartosik
From: Łukasz Bartosik Asus chromebook CX550 crashes during boot on v5.17-rc1 kernel. The root cause is null pointer defeference of bi_next in tgl_get_bw_info() in drivers/gpu/drm/i915/display/intel_bw.c. BUG: kernel NULL pointer dereference, address: 002e PGD 0 P4D 0 Oops: 0002 [#1]

Re: [Intel-gfx] [PATCH 11/20] drm/i915/ttm: tweak priority hint selection

2022-02-02 Thread Thomas Hellström
On 1/26/22 16:21, Matthew Auld wrote: For some reason we are selecting PRIO_HAS_PAGES when we don't have mm.pages, and vice versa. Perhaps something else is going on here. Signed-off-by: Matthew Auld Cc: Thomas Hellström LGTM. Should we add a Fixes: tag here? Reviewed-by: Thomas

Re: [Intel-gfx] [PATCH 5/6] drm/rcar_du: changes to rcar-du driver resulting from drm_writeback_connector structure changes

2022-02-02 Thread Ville Syrjälä
On Wed, Feb 02, 2022 at 03:15:03PM +0200, Jani Nikula wrote: > On Wed, 02 Feb 2022, Laurent Pinchart > wrote: > > Hi Kandpal, > > > > Thank you for the patch. > > > > On Wed, Feb 02, 2022 at 02:24:28PM +0530, Kandpal Suraj wrote: > >> Changing rcar_du driver to accomadate the change of > >>

Re: [Intel-gfx] [PATCH 5/6] drm/rcar_du: changes to rcar-du driver resulting from drm_writeback_connector structure changes

2022-02-02 Thread Laurent Pinchart
Hi Jani, On Wed, Feb 02, 2022 at 03:15:03PM +0200, Jani Nikula wrote: > On Wed, 02 Feb 2022, Laurent Pinchart wrote: > > On Wed, Feb 02, 2022 at 02:24:28PM +0530, Kandpal Suraj wrote: > >> Changing rcar_du driver to accomadate the change of > >> drm_writeback_connector.base and

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: Fix vma lifetime

2022-02-02 Thread Patchwork
== Series Details == Series: drm/i915: Fix vma lifetime URL : https://patchwork.freedesktop.org/series/99618/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [v2,1/2] drm/i915/vga: switch to use VGA definitions from video/vga.h

2022-02-02 Thread Patchwork
== Series Details == Series: series starting with [v2,1/2] drm/i915/vga: switch to use VGA definitions from video/vga.h URL : https://patchwork.freedesktop.org/series/99617/ State : success == Summary == CI Bug Log - changes from CI_DRM_11177 -> Patchwork_22156

Re: [Intel-gfx] [PATCH 2/2] drm/i915/gem: Don't try to map and fence large scanout buffers (v5)

2022-02-02 Thread Tvrtko Ursulin
On 02/02/2022 01:11, Vivek Kasireddy wrote: On platforms capable of allowing 8K (7680 x 4320) modes, pinning 2 or more framebuffers/scanout buffers results in only one that is mappable/ fenceable. Therefore, pageflipping between these 2 FBs where only one is mappable/fenceable creates

Re: [Intel-gfx] [PATCH 5/6] drm/rcar_du: changes to rcar-du driver resulting from drm_writeback_connector structure changes

2022-02-02 Thread Jani Nikula
On Wed, 02 Feb 2022, Laurent Pinchart wrote: > Hi Kandpal, > > Thank you for the patch. > > On Wed, Feb 02, 2022 at 02:24:28PM +0530, Kandpal Suraj wrote: >> Changing rcar_du driver to accomadate the change of >> drm_writeback_connector.base and drm_writeback_connector.encoder >> to a pointer the

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [v2,1/2] drm/i915/vga: switch to use VGA definitions from video/vga.h

2022-02-02 Thread Patchwork
== Series Details == Series: series starting with [v2,1/2] drm/i915/vga: switch to use VGA definitions from video/vga.h URL : https://patchwork.freedesktop.org/series/99617/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/4] drm/i915: Move PIPE_CHICKEN RMW out from the vblank evade critical section

2022-02-02 Thread Patchwork
== Series Details == Series: series starting with [1/4] drm/i915: Move PIPE_CHICKEN RMW out from the vblank evade critical section URL : https://patchwork.freedesktop.org/series/99616/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11177 -> Patchwork_22155

Re: [Intel-gfx] [PATCH 5/6] drm/rcar_du: changes to rcar-du driver resulting from drm_writeback_connector structure changes

2022-02-02 Thread Laurent Pinchart
Hi Kandpal, Thank you for the patch. On Wed, Feb 02, 2022 at 02:24:28PM +0530, Kandpal Suraj wrote: > Changing rcar_du driver to accomadate the change of > drm_writeback_connector.base and drm_writeback_connector.encoder > to a pointer the reason for which is explained in the > Patch(drm: add

Re: [Intel-gfx] [RFC 0/2] Compile out integrated

2022-02-02 Thread Jani Nikula
On Wed, 02 Feb 2022, Tvrtko Ursulin wrote: > On 02/02/2022 11:20, Jani Nikula wrote: >> On Wed, 02 Feb 2022, Tvrtko Ursulin wrote: >>> On 01/02/2022 17:28, Lucas De Marchi wrote: On Tue, Feb 01, 2022 at 07:09:14PM +0200, Jani Nikula wrote: > On Tue, 01 Feb 2022, Lucas De Marchi wrote:

[Intel-gfx] [RFC PATCH] drm/i915: Fix vma lifetime

2022-02-02 Thread Thomas Hellström
It's unclear what reference the initial vma refcount refers to. A vma can have multiple weak references, the object vma list, the vm's bound list and the gt's closed_list, and that initial vma refcount can be put from lookups of all these lists. The problem is that if another user is also holding

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm writeback connector changes

2022-02-02 Thread Patchwork
== Series Details == Series: drm writeback connector changes URL : https://patchwork.freedesktop.org/series/99610/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11177_full -> Patchwork_22152_full Summary ---

Re: [Intel-gfx] [RFC 0/2] Compile out integrated

2022-02-02 Thread Tvrtko Ursulin
On 02/02/2022 11:20, Jani Nikula wrote: On Wed, 02 Feb 2022, Tvrtko Ursulin wrote: On 01/02/2022 17:28, Lucas De Marchi wrote: On Tue, Feb 01, 2022 at 07:09:14PM +0200, Jani Nikula wrote: On Tue, 01 Feb 2022, Lucas De Marchi wrote: On Tue, Feb 01, 2022 at 11:15:31AM +, Tvrtko Ursulin

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Disable unused power wells left enabled by BIOS

2022-02-02 Thread Patchwork
== Series Details == Series: drm/i915: Disable unused power wells left enabled by BIOS URL : https://patchwork.freedesktop.org/series/99615/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11177 -> Patchwork_22154 Summary

Re: [Intel-gfx] [PATCH] drm/i915: Disable unused power wells left enabled by BIOS

2022-02-02 Thread Imre Deak
On Wed, Feb 02, 2022 at 01:00:46PM +0200, Ville Syrjälä wrote: > On Wed, Feb 02, 2022 at 12:42:49PM +0200, Imre Deak wrote: > > Make sure all unused power wells left enabled by BIOS get disabled > > during driver loading and system resume. > > > > Closes:

Re: [Intel-gfx] [RFC 0/2] Compile out integrated

2022-02-02 Thread Tvrtko Ursulin
On 01/02/2022 11:15, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Quicky and dirty hack based on some old ideas. Thought maybe the approach might interest the Arm port guys. But with IS_GEN_RANGE removed easy gains are not so big so meh.. Maybe some more easy wins with IS_DISPLAY_VER but I

Re: [Intel-gfx] [PATCH 01/21] MAINTAINERS: Add entry for fbdev core

2022-02-02 Thread Maxime Ripard
On Mon, Jan 31, 2022 at 10:05:32PM +0100, Daniel Vetter wrote: > Ever since Tomi extracted the core code in 2014 it's been defacto me > maintaining this, with help from others from dri-devel and sometimes > Linus (but those are mostly merge conflicts): > > $ git shortlog -ns

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: Disable unused power wells left enabled by BIOS

2022-02-02 Thread Patchwork
== Series Details == Series: drm/i915: Disable unused power wells left enabled by BIOS URL : https://patchwork.freedesktop.org/series/99615/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

Re: [Intel-gfx] [PATCH v2 1/2] drm/i915/vga: switch to use VGA definitions from video/vga.h

2022-02-02 Thread Ville Syrjälä
On Wed, Feb 02, 2022 at 01:25:08PM +0200, Jani Nikula wrote: > The video/vga.h has macros for the VGA registers. Switch to use them. > > v2: Use direct 0x01 instead of the confusing VGA_SEQ_CLOCK_MODE (Ville) > > Suggested-by: Matt Roper > Cc: Ville Syrjälä > Signed-off-by: Jani Nikula

Re: [Intel-gfx] [PATCH 3/4] drm/i915/vga: switch to use VGA definitions from video/vga.h

2022-02-02 Thread Jani Nikula
On Wed, 02 Feb 2022, Ville Syrjälä wrote: >> I dropped the ball here a bit. If I respin the same patches, but with >> the above line changed to one of these, is it okay? Which do you prefer? >> >> 1) outb(VGA_SEQ_CLOCK_MODE, VGA_SEQ_I); /* SR01 */ >> >> 2) #define SR01 VGA_SEQ_CLOCK_MODE >>

[Intel-gfx] [PATCH v2 2/2] drm/i915: remove VGA register definitions

2022-02-02 Thread Jani Nikula
The only user of the VGA registers has switched to using the definitions in linux/vga.h, so these have become redundant. Remove them. Suggested-by: Matt Roper Cc: Ville Syrjälä Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/i915_reg.h | 41 - 1 file

[Intel-gfx] [PATCH v2 1/2] drm/i915/vga: switch to use VGA definitions from video/vga.h

2022-02-02 Thread Jani Nikula
The video/vga.h has macros for the VGA registers. Switch to use them. v2: Use direct 0x01 instead of the confusing VGA_SEQ_CLOCK_MODE (Ville) Suggested-by: Matt Roper Cc: Ville Syrjälä Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_vga.c | 9 + 1 file changed, 5

Re: [Intel-gfx] [RFC 0/2] Compile out integrated

2022-02-02 Thread Jani Nikula
On Wed, 02 Feb 2022, Tvrtko Ursulin wrote: > On 01/02/2022 17:28, Lucas De Marchi wrote: >> On Tue, Feb 01, 2022 at 07:09:14PM +0200, Jani Nikula wrote: >>> On Tue, 01 Feb 2022, Lucas De Marchi wrote: On Tue, Feb 01, 2022 at 11:15:31AM +, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin

Re: [Intel-gfx] [PATCH 01/21] MAINTAINERS: Add entry for fbdev core

2022-02-02 Thread Tomi Valkeinen
On 31/01/2022 23:05, Daniel Vetter wrote: Ever since Tomi extracted the core code in 2014 it's been defacto me maintaining this, with help from others from dri-devel and sometimes Linus (but those are mostly merge conflicts): $ git shortlog -ns drivers/video/fbdev/core/ | head -n5 35

Re: [Intel-gfx] [PATCH 1/6] drm: add writeback pointers to drm_connector

2022-02-02 Thread kernel test robot
Hi Kandpal, Thank you for the patch! Yet something to improve: [auto build test ERROR on drm/drm-next] [also build test ERROR on drm-intel/for-linux-next drm-tip/drm-tip v5.17-rc2 next-20220202] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch

[Intel-gfx] [PATCH 4/4] drm/i915: Drop pointless i830 PIPECONF read

2022-02-02 Thread Ville Syrjala
From: Ville Syrjälä Reading the PIPECONF enable bit out from the hardware in i9xx_set_pipeconf() on i830 is pointless as the bit should always be set since we keep both pipes constantly running on i830. Drop the pointless read and just always keep the bit set. Signed-off-by: Ville Syrjälä ---

[Intel-gfx] [PATCH 3/4] drm/i915: Make the CHV CGM CSC register writes lockless

2022-02-02 Thread Ville Syrjala
From: Ville Syrjälä The CHV CGM CSC registers are single buffered and so we may have to write them from the vblank worker, which imposes very tight dealines. Drop the pointless locking for the register accessess to reduce the overhead. All the other registers we bash from the vblank worker

[Intel-gfx] [PATCH 1/4] drm/i915: Move PIPE_CHICKEN RMW out from the vblank evade critical section

2022-02-02 Thread Ville Syrjala
From: Ville Syrjälä We don't want any RMWs in the part of the commit that happens under vblank evasion. Eventually we want to use the DSB to handle that and it can't read registers at all. Also reads are just slowing us down needlessly. Let's move the whole PIPE_CHICKEN stuff out from the

[Intel-gfx] [PATCH 2/4] drm/i915: Make the pipe/output CSC register writes lockless

2022-02-02 Thread Ville Syrjala
From: Ville Syrjälä The pipe/output CSC register writes don't need to be locked since all the registers are suitably isolated to their own cachelines. So eliminate the locks to reduce the overhead during the vblank evade critical section. Signed-off-by: Ville Syrjälä ---

Re: [Intel-gfx] [PATCH 01/21] MAINTAINERS: Add entry for fbdev core

2022-02-02 Thread Daniel Stone
On Mon, 31 Jan 2022 at 21:06, Daniel Vetter wrote: > Ever since Tomi extracted the core code in 2014 it's been defacto me > maintaining this, with help from others from dri-devel and sometimes > Linus (but those are mostly merge conflicts): > > $ git shortlog -ns drivers/video/fbdev/core/ | head

[Intel-gfx] ✗ Fi.CI.BAT: failure for dma-buf-map: Rename to iosys-map

2022-02-02 Thread Patchwork
== Series Details == Series: dma-buf-map: Rename to iosys-map URL : https://patchwork.freedesktop.org/series/99612/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11177 -> Patchwork_22153 Summary --- **FAILURE**

Re: [Intel-gfx] [PATCH] drm/i915: Disable unused power wells left enabled by BIOS

2022-02-02 Thread Ville Syrjälä
On Wed, Feb 02, 2022 at 12:42:49PM +0200, Imre Deak wrote: > Make sure all unused power wells left enabled by BIOS get disabled > during driver loading and system resume. > > Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/5028 > Signed-off-by: Imre Deak > --- >

Re: [Intel-gfx] [PATCH i-g-t] intel_gpu_top: Improve error message when insufficient privilege

2022-02-02 Thread Tvrtko Ursulin
On 01/02/2022 16:10, Dixit, Ashutosh wrote: On Tue, 01 Feb 2022 07:19:46 -0800, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Print out end user friendly help text when the running user has insufficient privilege for accessing system wide performance counters. Reviewed-by: Ashutosh Dixit

[Intel-gfx] [PATCH] drm/i915: Disable unused power wells left enabled by BIOS

2022-02-02 Thread Imre Deak
Make sure all unused power wells left enabled by BIOS get disabled during driver loading and system resume. Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/5028 Signed-off-by: Imre Deak --- drivers/gpu/drm/i915/display/intel_display.c | 2 ++

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for dma-buf-map: Rename to iosys-map

2022-02-02 Thread Patchwork
== Series Details == Series: dma-buf-map: Rename to iosys-map URL : https://patchwork.freedesktop.org/series/99612/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for dma-buf-map: Rename to iosys-map

2022-02-02 Thread Patchwork
== Series Details == Series: dma-buf-map: Rename to iosys-map URL : https://patchwork.freedesktop.org/series/99612/ State : warning == Summary == $ dim checkpatch origin/drm-tip b6a44abcc53f dma-buf-map: Rename to iosys-map -:194: WARNING:AVOID_BUG: Avoid crashing the kernel - try using

[Intel-gfx] ✓ Fi.CI.BAT: success for drm writeback connector changes

2022-02-02 Thread Patchwork
== Series Details == Series: drm writeback connector changes URL : https://patchwork.freedesktop.org/series/99610/ State : success == Summary == CI Bug Log - changes from CI_DRM_11177 -> Patchwork_22152 Summary --- **SUCCESS** No

Re: [Intel-gfx] [RFC 0/2] Compile out integrated

2022-02-02 Thread Tvrtko Ursulin
On 01/02/2022 17:28, Lucas De Marchi wrote: On Tue, Feb 01, 2022 at 07:09:14PM +0200, Jani Nikula wrote: On Tue, 01 Feb 2022, Lucas De Marchi wrote: On Tue, Feb 01, 2022 at 11:15:31AM +, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Quicky and dirty hack based on some old ideas. Thought

Re: [Intel-gfx] [PATCH 10/20] drm/i915/selftests: mock test io_size

2022-02-02 Thread Thomas Hellström
On 1/26/22 16:21, Matthew Auld wrote: Check that mappable vs non-mappable matches our expectations. Signed-off-by: Matthew Auld Cc: Thomas Hellström Reviewed-by: Thomas Hellström --- .../drm/i915/selftests/intel_memory_region.c | 143 ++ 1 file changed, 143

Re: [Intel-gfx] [PATCH 5/8] drm/i915/dp: rewrite DP 2.0 128b/132b link training based on errata

2022-02-02 Thread Jani Nikula
On Thu, 27 Jan 2022, Ville Syrjälä wrote: > On Tue, Jan 25, 2022 at 07:03:43PM +0200, Jani Nikula wrote: > >> +static bool >> +intel_dp_128b132b_lane_cds(struct intel_dp *intel_dp, >> + const struct intel_crtc_state *crtc_state, >> + int lttpr_count)

Re: [Intel-gfx] [PATCH 3/4] drm/i915/vga: switch to use VGA definitions from video/vga.h

2022-02-02 Thread Ville Syrjälä
On Wed, Feb 02, 2022 at 11:17:11AM +0200, Jani Nikula wrote: > On Wed, 12 Jan 2022, Ville Syrjälä wrote: > > On Tue, Jan 11, 2022 at 10:55:44AM +0200, Jani Nikula wrote: > >> On Mon, 10 Jan 2022, Ville Syrjälä wrote: > >> > On Mon, Jan 10, 2022 at 11:57:39AM +0200, Jani Nikula wrote: > >> >> The

Re: [Intel-gfx] [PATCH 5/8] drm/i915/dp: rewrite DP 2.0 128b/132b link training based on errata

2022-02-02 Thread Jani Nikula
On Wed, 26 Jan 2022, Ville Syrjälä wrote: > On Tue, Jan 25, 2022 at 07:03:43PM +0200, Jani Nikula wrote: >> The DP 2.0 errata completely overhauls the 128b/132b link training, with >> no provisions for backward compatibility with the original DP 2.0 >> specification. >> >> The changes are too

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm writeback connector changes

2022-02-02 Thread Patchwork
== Series Details == Series: drm writeback connector changes URL : https://patchwork.freedesktop.org/series/99610/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

Re: [Intel-gfx] [PATCH v2] dma-buf-map: Rename to iosys-map

2022-02-02 Thread Lucas De Marchi
On Wed, Feb 02, 2022 at 10:25:28AM +0100, Christian König wrote: Am 02.02.22 um 10:11 schrieb Lucas De Marchi: [SNIP] diff --git a/MAINTAINERS b/MAINTAINERS index d03ad8da1f36..112676f11792 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -5675,7 +5675,6 @@ T:git

Re: [Intel-gfx] [PATCH 3/4] drm/i915/vga: switch to use VGA definitions from video/vga.h

2022-02-02 Thread Jani Nikula
On Wed, 12 Jan 2022, Ville Syrjälä wrote: > On Tue, Jan 11, 2022 at 10:55:44AM +0200, Jani Nikula wrote: >> On Mon, 10 Jan 2022, Ville Syrjälä wrote: >> > On Mon, Jan 10, 2022 at 11:57:39AM +0200, Jani Nikula wrote: >> >> The video/vga.h has macros for the VGA registers. Switch to use them. >>

[Intel-gfx] [PATCH v2] dma-buf-map: Rename to iosys-map

2022-02-02 Thread Lucas De Marchi
Rename struct dma_buf_map to struct iosys_map and corresponding APIs. Over time dma-buf-map grew up to more functionality than the one used by dma-buf: in fact it's just a shim layer to abstract system memory, that can be accessed via regular load and store, from IO memory, that needs to be

[Intel-gfx] [PATCH 6/6] drm/arm: changes to malidp driver resulting from drm_writeback_connector structure changes

2022-02-02 Thread Kandpal Suraj
Changing malidp driver to accomadate the change of drm_writeback_connector.base and drm_writeback_connector.encoder to a pointer the reason for which is explained in the Patch(drm: add writeback pointers to drm_connector). Signed-off-by: Kandpal Suraj --- drivers/gpu/drm/arm/malidp_crtc.c | 2

[Intel-gfx] [PATCH 5/6] drm/rcar_du: changes to rcar-du driver resulting from drm_writeback_connector structure changes

2022-02-02 Thread Kandpal Suraj
Changing rcar_du driver to accomadate the change of drm_writeback_connector.base and drm_writeback_connector.encoder to a pointer the reason for which is explained in the Patch(drm: add writeback pointers to drm_connector). Signed-off-by: Kandpal Suraj --- drivers/gpu/drm/rcar-du/rcar_du_crtc.h

[Intel-gfx] [PATCH 4/6] drm/vc4: vc4 driver changes to accommodate changes done in drm_writeback_connector structure

2022-02-02 Thread Kandpal Suraj
Changing vc4 driver to accomadate the change of drm_writeback_connector.base and drm_writeback_connector.encoder to a pointer the reason for which is explained in the Patch(drm: add writeback pointers to drm_connector). Signed-off-by: Kandpal Suraj --- drivers/gpu/drm/vc4/vc4_txp.c | 20

[Intel-gfx] [PATCH 3/6] drm/vkms: change vkms driver to use drm_writeback_connector.base pointer

2022-02-02 Thread Kandpal Suraj
Changing vkms driver to accomadate the change of drm_writeback_connector.base to a pointer the reason for which is explained in the Patch(drm: add writeback pointers to drm_connector). Signed-off-by: Kandpal Suraj --- drivers/gpu/drm/vkms/vkms_writeback.c | 9 ++--- 1 file changed, 6

[Intel-gfx] [PATCH 2/6] drm/arm/komeda : change driver to use drm_writeback_connector.base pointer

2022-02-02 Thread Kandpal Suraj
Making changes to komeda driver because we had to change drm_writeback_connector.base into a pointer the reason for which is expained in the Patch (drm: add writeback pointers to drm_connector). Signed-off-by: Kandpal Suraj Reviewed-by: Carsten Haitzler ---

[Intel-gfx] [PATCH 1/6] drm: add writeback pointers to drm_connector

2022-02-02 Thread Kandpal Suraj
Changing drm_connector and drm_encoder feilds to pointers in drm_writeback_connector as the elements of struct drm_writeback_connector are: struct drm_writeback_connector { struct drm_connector base; struct drm_encoder encoder; Similarly the elements of intel_encoder and

[Intel-gfx] [PATCH 0/6] drm writeback connector changes

2022-02-02 Thread Kandpal Suraj
This patch series contains drm_writeback_connector structure change i.e change of drm_connector and drm_encoder fields to a pointer the reason for which is explained in patch(1/6) drm: add writeback pointers to drm_connector and the accompanying changes to the different drivers that were effected

[Intel-gfx] [PATCH v2 6/6] drm/arm: changes to malidp driver resulting from drm_writeback_connector structure changes

2022-02-02 Thread Kandpal Suraj
Changing malidp driver to accomadate the change of drm_writeback_connector.base and drm_writeback_connector.encoder to a pointer the reason for which is explained in the Patch(drm: add writeback pointers to drm_connector). Signed-off-by: Kandpal Suraj --- drivers/gpu/drm/arm/malidp_crtc.c | 2

[Intel-gfx] [PATCH v2 5/6] drm/rcar_du: changes to rcar-du driver resulting from drm_writeback_connector structure changes

2022-02-02 Thread Kandpal Suraj
Changing rcar_du driver to accomadate the change of drm_writeback_connector.base and drm_writeback_connector.encoder to a pointer the reason for which is explained in the Patch(drm: add writeback pointers to drm_connector). Signed-off-by: Kandpal Suraj --- drivers/gpu/drm/rcar-du/rcar_du_crtc.h

[Intel-gfx] [PATCH v2 4/6] drm/vc4: vc4 driver changes to accommodate changes done in drm_writeback_connector structure

2022-02-02 Thread Kandpal Suraj
Changing vc4 driver to accomadate the change of drm_writeback_connector.base and drm_writeback_connector.encoder to a pointer the reason for which is explained in the Patch(drm: add writeback pointers to drm_connector). Signed-off-by: Kandpal Suraj --- drivers/gpu/drm/vc4/vc4_txp.c | 20

[Intel-gfx] [PATCH v2 3/6] drm/vkms: change vkms driver to use drm_writeback_connector.base pointer

2022-02-02 Thread Kandpal Suraj
Changing vkms driver to accomadate the change of drm_writeback_connector.base to a pointer the reason for which is explained in the Patch(drm: add writeback pointers to drm_connector). Signed-off-by: Kandpal Suraj --- drivers/gpu/drm/vkms/vkms_writeback.c | 9 ++--- 1 file changed, 6

[Intel-gfx] [PATCH v2 2/6] drm/arm/komeda : change driver to use drm_writeback_connector.base pointer

2022-02-02 Thread Kandpal Suraj
Making changes to komeda driver because we had to change drm_writeback_connector.base into a pointer the reason for which is expained in the Patch (drm: add writeback pointers to drm_connector). Signed-off-by: Kandpal Suraj --- drivers/gpu/drm/arm/display/komeda/komeda_crtc.c | 2 +-

[Intel-gfx] [PATCH v2 1/6] drm: add writeback pointers to drm_connector

2022-02-02 Thread Kandpal Suraj
Changing drm_connector and drm_encoder feilds to pointers in drm_writeback_connector as the elements of struct drm_writeback_connector are: struct drm_writeback_connector { struct drm_connector base; struct drm_encoder encoder; Similarly the elements of intel_encoder and