[Intel-gfx] [PATCH v8 5/5] drm/i915/uapi: document behaviour for DG2 64K support

2022-02-08 Thread Robert Beckett
From: Matthew Auld On discrete platforms like DG2, we need to support a minimum page size of 64K when dealing with device local-memory. This is quite tricky for various reasons, so try to document the new implicit uapi for this. v3: fix typos and less emphasis v2: Fixed suggestions on

[Intel-gfx] [PATCH v8 3/5] drm/i915: support 64K GTT pages for discrete cards

2022-02-08 Thread Robert Beckett
From: Matthew Auld discrete cards optimise 64K GTT pages for local-memory, since everything should be allocated at 64K granularity. We say goodbye to sparse entries, and instead get a compact 256B page-table for 64K pages, which should be more cache friendly. 4K pages for local-memory are no

[Intel-gfx] [PATCH v8 1/5] drm/i915: add needs_compact_pt flag

2022-02-08 Thread Robert Beckett
From: Ramalingam C Add a new platform flag, needs_compact_pt, to mark the requirement of compact pt layout support for the ppGTT when using 64K GTT pages. With this flag has_64k_pages will only indicate requirement of 64K GTT page sizes or larger for device local memory access. v6: *

[Intel-gfx] [PATCH v8 2/5] drm/i915: enforce min GTT alignment for discrete cards

2022-02-08 Thread Robert Beckett
From: Matthew Auld For local-memory objects we need to align the GTT addresses to 64K, both for the ppgtt and ggtt. We need to support vm->min_alignment > 4K, depending on the vm itself and the type of object we are inserting. With this in mind update the GTT selftests to take this into

[Intel-gfx] [PATCH v8 0/5] discrete card 64K page support

2022-02-08 Thread Robert Beckett
This series continues support for 64K pages for discrete cards. It supersedes the 64K patches from https://patchwork.freedesktop.org/series/95686/#rev4 Changes since that series: - set min alignment for DG2 to 2MB in i915_address_space_init - replace coloring with simpler 2MB VA alignment for

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: move the DRIVER_* macros to i915_driver.[ch] (rev2)

2022-02-08 Thread Patchwork
== Series Details == Series: drm/i915: move the DRIVER_* macros to i915_driver.[ch] (rev2) URL : https://patchwork.freedesktop.org/series/99671/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11203_full -> Patchwork_22210_full

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/dp, drm/i915: 128b/132b updates (rev6)

2022-02-08 Thread Patchwork
== Series Details == Series: drm/dp, drm/i915: 128b/132b updates (rev6) URL : https://patchwork.freedesktop.org/series/99324/ State : success == Summary == CI Bug Log - changes from CI_DRM_11203 -> Patchwork_22212 Summary ---

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/dp, drm/i915: 128b/132b updates (rev6)

2022-02-08 Thread Patchwork
== Series Details == Series: drm/dp, drm/i915: 128b/132b updates (rev6) URL : https://patchwork.freedesktop.org/series/99324/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

Re: [Intel-gfx] [PATCH 11/21] fbcon: Extract fbcon_open/release helpers

2022-02-08 Thread Daniel Vetter
On Tue, Feb 08, 2022 at 07:24:03PM +0100, Sam Ravnborg wrote: > Hi Daniel, > > On Tue, Feb 08, 2022 at 02:48:29PM +0100, Daniel Vetter wrote: > > On Thu, Feb 03, 2022 at 10:15:14PM +0100, Sam Ravnborg wrote: > > > Hi Daniel, > > > > > > On Mon, Jan 31, 2022 at 10:05:42PM +0100, Daniel Vetter

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/dp, drm/i915: 128b/132b updates (rev6)

2022-02-08 Thread Patchwork
== Series Details == Series: drm/dp, drm/i915: 128b/132b updates (rev6) URL : https://patchwork.freedesktop.org/series/99324/ State : warning == Summary == $ dim checkpatch origin/drm-tip b1c38d738be2 drm/dp: add drm_dp_128b132b_read_aux_rd_interval() 2b74cd3aa4a7 drm/dp: add 128b/132b link

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: move intel_hws_csb_write_index() out of i915_drv.h

2022-02-08 Thread Patchwork
== Series Details == Series: drm/i915: move intel_hws_csb_write_index() out of i915_drv.h URL : https://patchwork.freedesktop.org/series/99853/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11203 -> Patchwork_22211 Summary

[Intel-gfx] [PATCH 05/12] drm/i915: Protect lockdep functions with #ifdef

2022-02-08 Thread Namhyung Kim
With upcoming lock tracepoints config, it'd define some of lockdep functions without enabling CONFIG_LOCKDEP actually. The existing code assumes those functions will be removed by the preprocessor but it's not the case anymore. Let's protect the code with #ifdef's explicitly. Cc: Jani Nikula

[Intel-gfx] [RFC RESEND 00/12] locking: Separate lock tracepoints from lockdep/lock_stat (v1.1)

2022-02-08 Thread Namhyung Kim
Hello, (Resending with Paul's correct email address, sorry!) There have been some requests for low-overhead kernel lock contention monitoring. The kernel has CONFIG_LOCK_STAT to provide such an infra either via /proc/lock_stat or tracepoints directly. However it's not light-weight and hard to

Re: [Intel-gfx] [PATCH v5 06/10] drm/i915/guc: Update GuC's log-buffer-state access for error capture.

2022-02-08 Thread Teres Alexis, Alan Previn
Hi Matt, thank you for taking the time to review the codes. Answering your question inline below. On Fri, 2022-02-04 at 10:19 -0800, Matthew Brost wrote: > On Wed, Jan 26, 2022 at 02:48:18AM -0800, Alan Previn wrote: > > GuC log buffer regions for debug-log-events, crash-dumps and > >

Re: [Intel-gfx] [PATCH 05/12] drm/i915: Protect lockdep functions with #ifdef

2022-02-08 Thread Namhyung Kim
Hello, On Tue, Feb 8, 2022 at 10:51 AM Jani Nikula wrote: > > On Tue, 08 Feb 2022, Namhyung Kim wrote: > > With upcoming lock tracepoints config, it'd define some of lockdep > > functions without enabling CONFIG_LOCKDEP actually. The existing code > > assumes those functions will be removed by

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: move intel_hws_csb_write_index() out of i915_drv.h

2022-02-08 Thread Patchwork
== Series Details == Series: drm/i915: move intel_hws_csb_write_index() out of i915_drv.h URL : https://patchwork.freedesktop.org/series/99853/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: move intel_hws_csb_write_index() out of i915_drv.h

2022-02-08 Thread Patchwork
== Series Details == Series: drm/i915: move intel_hws_csb_write_index() out of i915_drv.h URL : https://patchwork.freedesktop.org/series/99853/ State : warning == Summary == $ dim checkpatch origin/drm-tip 8ed7bbe053b5 drm/i915: move intel_hws_csb_write_index() out of i915_drv.h -:51:

Re: [Intel-gfx] [RFC 00/12] locking: Separate lock tracepoints from lockdep/lock_stat (v1)

2022-02-08 Thread Namhyung Kim
Oops, I used the wrong email address of Paul. Sorry about that! I'll resend with a new address soon. Thanks, Namhyung On Tue, Feb 8, 2022 at 10:42 AM Namhyung Kim wrote: > > Hello, > > There have been some requests for low-overhead kernel lock contention > monitoring. The kernel has

Re: [Intel-gfx] [PATCH v2 1/1] drm/i915: Add fallback inside memcpy_from_wc functions

2022-02-08 Thread Lucas De Marchi
On Mon, Feb 07, 2022 at 09:43:08PM +0530, Balasubramani Vivekanandan wrote: memcpy_from_wc functions can fail if SSE4.1 is not supported or the supplied addresses are not 16-byte aligned. It was then upto to the caller to use memcpy as fallback. Now fallback to memcpy is implemented inside

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: move the DRIVER_* macros to i915_driver.[ch] (rev2)

2022-02-08 Thread Patchwork
== Series Details == Series: drm/i915: move the DRIVER_* macros to i915_driver.[ch] (rev2) URL : https://patchwork.freedesktop.org/series/99671/ State : success == Summary == CI Bug Log - changes from CI_DRM_11203 -> Patchwork_22210

Re: [Intel-gfx] [PATCH 21/21] fbdev: Make registered_fb[] private to fbmem.c

2022-02-08 Thread Sam Ravnborg
Hi Daniel, On Mon, Jan 31, 2022 at 10:05:52PM +0100, Daniel Vetter wrote: > Well except when the olpc dcon fbdev driver is enabled, that thing > digs around in there in rather unfixable ways. > > Cc oldc_dcon maintainers as fyi. > > Cc: Jens Frederich > Cc: Jon Nettleton > Cc: Greg

Re: [Intel-gfx] [PATCH 19/21] fbcon: Maintain a private array of fb_info

2022-02-08 Thread Sam Ravnborg
Hi Daniel, On Tue, Feb 08, 2022 at 03:03:28PM +0100, Daniel Vetter wrote: > On Fri, Feb 04, 2022 at 09:15:40PM +0100, Sam Ravnborg wrote: > > Hi Daniel, > > > > On Mon, Jan 31, 2022 at 10:05:50PM +0100, Daniel Vetter wrote: > > > Accessing the one in fbmem.c without taking the right locks is a

Re: [Intel-gfx] [PATCH] drm/i915/guc: Fix flag query to not modify state

2022-02-08 Thread John Harrison
On 2/8/2022 01:39, Tvrtko Ursulin wrote: On 08/02/2022 02:07, john.c.harri...@intel.com wrote: From: John Harrison A flag query helper was actually writing to the flags word rather than just reading. Fix that. Also update the function's comment as it was out of date. Fixes: 0f7976506de61

Re: [Intel-gfx] [PATCH 05/12] drm/i915: Protect lockdep functions with #ifdef

2022-02-08 Thread Jani Nikula
On Tue, 08 Feb 2022, Namhyung Kim wrote: > With upcoming lock tracepoints config, it'd define some of lockdep > functions without enabling CONFIG_LOCKDEP actually. The existing code > assumes those functions will be removed by the preprocessor but it's > not the case anymore. Let's protect the

[Intel-gfx] [PATCH 05/12] drm/i915: Protect lockdep functions with #ifdef

2022-02-08 Thread Namhyung Kim
With upcoming lock tracepoints config, it'd define some of lockdep functions without enabling CONFIG_LOCKDEP actually. The existing code assumes those functions will be removed by the preprocessor but it's not the case anymore. Let's protect the code with #ifdef's explicitly. Cc: Jani Nikula

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: move the DRIVER_* macros to i915_driver.[ch] (rev2)

2022-02-08 Thread Patchwork
== Series Details == Series: drm/i915: move the DRIVER_* macros to i915_driver.[ch] (rev2) URL : https://patchwork.freedesktop.org/series/99671/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] [RFC 00/12] locking: Separate lock tracepoints from lockdep/lock_stat (v1)

2022-02-08 Thread Namhyung Kim
Hello, There have been some requests for low-overhead kernel lock contention monitoring. The kernel has CONFIG_LOCK_STAT to provide such an infra either via /proc/lock_stat or tracepoints directly. However it's not light-weight and hard to be used in production. So I'm trying to separate out

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: split out intel_vtd.[ch] from i915_drv.h

2022-02-08 Thread Patchwork
== Series Details == Series: drm/i915: split out intel_vtd.[ch] from i915_drv.h URL : https://patchwork.freedesktop.org/series/99852/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11203 -> Patchwork_22209 Summary ---

Re: [Intel-gfx] [PATCH 18/21] fbcon: untangle fbcon_exit

2022-02-08 Thread Sam Ravnborg
On Tue, Feb 08, 2022 at 02:58:21PM +0100, Daniel Vetter wrote: > On Fri, Feb 04, 2022 at 09:06:38PM +0100, Sam Ravnborg wrote: > > Hi Daniel, > > > > On Mon, Jan 31, 2022 at 10:05:49PM +0100, Daniel Vetter wrote: > > > There's a bunch of confusions going on here: > > > - The deferred fbcon setup

Re: [Intel-gfx] [PATCH 13/21] fbcon: move more common code into fb_open()

2022-02-08 Thread Sam Ravnborg
On Tue, Feb 08, 2022 at 02:53:59PM +0100, Daniel Vetter wrote: > On Fri, Feb 04, 2022 at 08:35:31PM +0100, Sam Ravnborg wrote: > > On Mon, Jan 31, 2022 at 10:05:44PM +0100, Daniel Vetter wrote: > > > No idea why con2fb_acquire_newinfo() initializes much less than > > > fbcon_startup(), but so be

Re: [Intel-gfx] [PATCH 11/21] fbcon: Extract fbcon_open/release helpers

2022-02-08 Thread Sam Ravnborg
Hi Daniel, On Tue, Feb 08, 2022 at 02:48:29PM +0100, Daniel Vetter wrote: > On Thu, Feb 03, 2022 at 10:15:14PM +0100, Sam Ravnborg wrote: > > Hi Daniel, > > > > On Mon, Jan 31, 2022 at 10:05:42PM +0100, Daniel Vetter wrote: > > > There's two minor behaviour changes in here: > > > - in error

Re: [Intel-gfx] [PATCH 10/21] fb: Delete fb_info->queue

2022-02-08 Thread Sam Ravnborg
Hi Daniel, On Tue, Feb 08, 2022 at 02:46:33PM +0100, Daniel Vetter wrote: > On Thu, Feb 03, 2022 at 10:31:00PM +0100, Sam Ravnborg wrote: > > On Mon, Jan 31, 2022 at 10:05:41PM +0100, Daniel Vetter wrote: > > > It was only used by fbcon, and that now switched to its own, > > > private work. > > >

Re: [Intel-gfx] [PATCH] drm/i915/psr: Disable PSR2 selective fetch for all TGL steps

2022-02-08 Thread Lyude Paul
On Tue, 2022-02-08 at 13:06 +, Souza, Jose wrote: > On Mon, 2022-02-07 at 16:38 -0500, Lyude Paul wrote: > > As we've unfortunately started to come to expect from PSR on Intel > > platforms, PSR2 selective fetch is not at all ready to be enabled on > > Tigerlake as it results in severe

Re: [Intel-gfx] [PATCH 06/21] fbcon: delete delayed loading code

2022-02-08 Thread Sam Ravnborg
Hi Daniel, On Tue, Feb 08, 2022 at 02:42:25PM +0100, Daniel Vetter wrote: > On Thu, Feb 03, 2022 at 09:45:29PM +0100, Sam Ravnborg wrote: > > Hi Daniel, > > > > On Mon, Jan 31, 2022 at 10:05:37PM +0100, Daniel Vetter wrote: > > > Before > > > > > > commit

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: split out intel_vtd.[ch] from i915_drv.h

2022-02-08 Thread Patchwork
== Series Details == Series: drm/i915: split out intel_vtd.[ch] from i915_drv.h URL : https://patchwork.freedesktop.org/series/99852/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: split out intel_vtd.[ch] from i915_drv.h

2022-02-08 Thread Patchwork
== Series Details == Series: drm/i915: split out intel_vtd.[ch] from i915_drv.h URL : https://patchwork.freedesktop.org/series/99852/ State : warning == Summary == $ dim checkpatch origin/drm-tip 019a148267a5 drm/i915: split out intel_vtd.[ch] from i915_drv.h -:321: WARNING:FILE_PATH_CHANGES:

Re: [Intel-gfx] [PATCH 7/8] drm/i915: Disable tracing points on PREEMPT_RT

2022-02-08 Thread Sebastian Andrzej Siewior
On 2021-12-14 11:58:37 [-0500], Steven Rostedt wrote: > On Tue, 14 Dec 2021 18:34:50 +0200 > Ville Syrjälä wrote: > > > Looks lightly tedious. Can't we have "slow" (or whatever) versions of > > the trace macros so we could just declare these the same was as before > > without having to manually

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/dp, drm/i915: 128b/132b updates (rev5)

2022-02-08 Thread Patchwork
== Series Details == Series: drm/dp, drm/i915: 128b/132b updates (rev5) URL : https://patchwork.freedesktop.org/series/99324/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11202 -> Patchwork_22208 Summary ---

[Intel-gfx] [PATCH] drm/i915: move intel_hws_csb_write_index() out of i915_drv.h

2022-02-08 Thread Jani Nikula
Underscore prefix the index macros, and place INTEL_HWS_CSB_WRITE_INDEX() as a macro next to them, to declutter i915_drv.h. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/gt/intel_engine.h | 6 -- drivers/gpu/drm/i915/gt/intel_execlists_submission.c | 2 +-

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/dp, drm/i915: 128b/132b updates (rev5)

2022-02-08 Thread Patchwork
== Series Details == Series: drm/dp, drm/i915: 128b/132b updates (rev5) URL : https://patchwork.freedesktop.org/series/99324/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/dp, drm/i915: 128b/132b updates (rev5)

2022-02-08 Thread Patchwork
== Series Details == Series: drm/dp, drm/i915: 128b/132b updates (rev5) URL : https://patchwork.freedesktop.org/series/99324/ State : warning == Summary == $ dim checkpatch origin/drm-tip 20e6f540b666 drm/dp: add drm_dp_128b132b_read_aux_rd_interval() 33af01e431af drm/dp: add 128b/132b link

[Intel-gfx] [PATCH v4 2/2] drm/i915/vtd: rename functions to have the usual prefix

2022-02-08 Thread Jani Nikula
The prefix should tell where the function is to be found and where it belongs. Cc: Daniel Vetter Cc: Ville Syrjälä Cc: Tvrtko Ursulin Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_fb_pin.c | 2 +- drivers/gpu/drm/i915/gem/i915_gem_shrinker.c | 2 +-

[Intel-gfx] [PATCH v4 1/2] drm/i915: split out intel_vtd.[ch] from i915_drv.h

2022-02-08 Thread Jani Nikula
Perhaps a bit contrived, but we need to reduce the size of i915_drv.h from all the accumulated cruft. v4: Rebase v3: Rebase v2: Turns out asm/hypervisor.h is not self-contained Cc: Daniel Vetter Cc: Ville Syrjälä Cc: Tvrtko Ursulin Signed-off-by: Jani Nikula ---

[Intel-gfx] [PATCH v4 0/2] drm/i915: split out intel_vtd.[ch] from i915_drv.h

2022-02-08 Thread Jani Nikula
Another rebase & resend of [1]. [1] https://patchwork.freedesktop.org/series/98789/ Jani Nikula (2): drm/i915: split out intel_vtd.[ch] from i915_drv.h drm/i915/vtd: rename functions to have the usual prefix drivers/gpu/drm/i915/Makefile| 1 +

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/doc: pull in drm_buddy.c

2022-02-08 Thread Patchwork
== Series Details == Series: drm/doc: pull in drm_buddy.c URL : https://patchwork.freedesktop.org/series/99849/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11201 -> Patchwork_22207 Summary --- **FAILURE**

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/buddy: fixup potential uaf

2022-02-08 Thread Patchwork
== Series Details == Series: drm/buddy: fixup potential uaf URL : https://patchwork.freedesktop.org/series/99842/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11201_full -> Patchwork_22205_full Summary ---

Re: [Intel-gfx] [PATCH v6 6/6] drm: Add arch arm64 for drm_clflush_virt_range

2022-02-08 Thread Michael Cheng
Ah, thanks for asking this question. It seems like I was not thinking correctly. We are trying to flush dcache lines within this function and not the tlb. On 2022-02-08 2:20 a.m., Tvrtko Ursulin wrote: On 07/02/2022 20:11, Michael Cheng wrote: Use flush_tlb_kernel_range when invoking

[Intel-gfx] [PATCH v3] drm/i915/mst: update slot information for 128b/132b

2022-02-08 Thread Jani Nikula
128b/132b supports using 64 slots starting from 0, while 8b/10b reserves slot 0 for metadata. Commit d6c6a76f80a1 ("drm: Update MST First Link Slot Information Based on Encoding Format") added support for updating the topology state accordingly, and commit 41724ea273cd ("drm/amd/display: Add DP

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/dp, drm/i915: 128b/132b updates (rev4)

2022-02-08 Thread Patchwork
== Series Details == Series: drm/dp, drm/i915: 128b/132b updates (rev4) URL : https://patchwork.freedesktop.org/series/99324/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11201 -> Patchwork_22206 Summary ---

Re: [Intel-gfx] [PATCH v6 1/3] i915/gvt: Introduce the mmio table to support VFIO new mdev API

2022-02-08 Thread Jani Nikula
On Tue, 08 Feb 2022, Zhi Wang wrote: > From: Zhi Wang > > To support the new mdev interfaces and the re-factor patches from > Christoph, which moves the GVT-g code into a dedicated module, the GVT-g > initialization path has to be separated into two phases: > > a) Early initialization. > > The

[Intel-gfx] [PATCH] drm/doc: pull in drm_buddy.c

2022-02-08 Thread Matthew Auld
Make sure we pull in the kernel-doc for this. Reported-by: Daniel Vetter Signed-off-by: Matthew Auld Cc: Arunpravin Cc: Christian König --- Documentation/gpu/drm-mm.rst | 9 + 1 file changed, 9 insertions(+) diff --git a/Documentation/gpu/drm-mm.rst b/Documentation/gpu/drm-mm.rst

Re: [Intel-gfx] [PATCH v2 6/8] drm/i915/dp: add 128b/132b support to link status checks

2022-02-08 Thread Ville Syrjälä
On Thu, Feb 03, 2022 at 11:03:55AM +0200, Jani Nikula wrote: > Abstract link status check to a function that takes 128b/132b and 8b/10b > into account, and use it. Also dump link status on failures. > > Cc: Uma Shankar > Cc: Ville Syrjälä > Signed-off-by: Jani Nikula > --- >

Re: [Intel-gfx] [PATCH v2 7/8] drm/i915/mst: update slot information for 128b/132b

2022-02-08 Thread Ville Syrjälä
On Thu, Feb 03, 2022 at 11:03:56AM +0200, Jani Nikula wrote: > 128b/132b supports using 64 slots starting from 0, while 8b/10b reserves > slot 0 for metadata. > > Commit d6c6a76f80a1 ("drm: Update MST First Link Slot Information Based > on Encoding Format") added support for updating the topology

[Intel-gfx] [PULL] drm-intel-next

2022-02-08 Thread Rodrigo Vivi
Hi Dave and Daniel, Here goes the first and probably biggest request towards 5.18. Another request will come in about 2 weeks. drm-intel-next-2022-02-08: Cross-subsystem Changes: dma-buf: - dma-buf-map: Rename to iosys-map (Lucas) Core Changes: - drm: -

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/dp, drm/i915: 128b/132b updates (rev4)

2022-02-08 Thread Patchwork
== Series Details == Series: drm/dp, drm/i915: 128b/132b updates (rev4) URL : https://patchwork.freedesktop.org/series/99324/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/dp, drm/i915: 128b/132b updates (rev4)

2022-02-08 Thread Patchwork
== Series Details == Series: drm/dp, drm/i915: 128b/132b updates (rev4) URL : https://patchwork.freedesktop.org/series/99324/ State : warning == Summary == $ dim checkpatch origin/drm-tip dda5c759f6bc drm/dp: add drm_dp_128b132b_read_aux_rd_interval() 0053fa9bdcc3 drm/dp: add 128b/132b link

Re: [Intel-gfx] [PATCH 1/3] i915/gvt: Introduce the mmio_table.c to support VFIO new mdev API

2022-02-08 Thread kernel test robot
Hi Zhi, I love your patch! Perhaps something to improve: [auto build test WARNING on drm-tip/drm-tip] [also build test WARNING on next-20220208] [cannot apply to drm-intel/for-linux-next v5.17-rc3] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch

Re: [Intel-gfx] [PATCH v4] drm/i915/dp: rewrite DP 2.0 128b/132b link training based on errata

2022-02-08 Thread Ville Syrjälä
On Tue, Feb 08, 2022 at 04:32:09PM +0200, Jani Nikula wrote: > The DP 2.0 errata completely overhauls the 128b/132b link training, with > no provisions for backward compatibility with the original DP 2.0 > specification. > > The changes are too intrusive to consider reusing the same code for both

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/buddy: fixup potential uaf

2022-02-08 Thread Patchwork
== Series Details == Series: drm/buddy: fixup potential uaf URL : https://patchwork.freedesktop.org/series/99842/ State : success == Summary == CI Bug Log - changes from CI_DRM_11201 -> Patchwork_22205 Summary --- **SUCCESS** No

[Intel-gfx] [PATCH v4] drm/i915/dp: rewrite DP 2.0 128b/132b link training based on errata

2022-02-08 Thread Jani Nikula
The DP 2.0 errata completely overhauls the 128b/132b link training, with no provisions for backward compatibility with the original DP 2.0 specification. The changes are too intrusive to consider reusing the same code for both 8b/10b and 128b/132b, mainly because the LTTPR channel equalisation is

Re: [Intel-gfx] [PATCH 01/21] MAINTAINERS: Add entry for fbdev core

2022-02-08 Thread Daniel Vetter
On Mon, Jan 31, 2022 at 10:05:32PM +0100, Daniel Vetter wrote: > Ever since Tomi extracted the core code in 2014 it's been defacto me > maintaining this, with help from others from dri-devel and sometimes > Linus (but those are mostly merge conflicts): > > $ git shortlog -ns

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Fix mbus join config lookup

2022-02-08 Thread Jani Nikula
On Mon, 07 Feb 2022, Ville Syrjala wrote: > From: Ville Syrjälä > > The bogus loop from compute_dbuf_slices() was copied into > check_mbus_joined() as well. So this lookup is wrong as well. > Fix it. > > Cc: sta...@vger.kernel.org > Fixes: f4dc00863226 ("drm/i915/adl_p: MBUS programming") >

Re: [Intel-gfx] [PATCH 1/2] drm/i195: Fix dbuf slice config lookup

2022-02-08 Thread Jani Nikula
On Mon, 07 Feb 2022, Ville Syrjala wrote: > From: Ville Syrjälä > > Apparently I totally fumbled the loop condition when I > removed the ARRAY_SIZE() stuff from the dbuf slice config > lookup. Comparing the loop index with the active_pipes bitmask > is utter nonsense, what we want to do is check

Re: [Intel-gfx] [PATCH 21/21] fbdev: Make registered_fb[] private to fbmem.c

2022-02-08 Thread Daniel Vetter
On Fri, Feb 04, 2022 at 09:30:56AM +0100, Geert Uytterhoeven wrote: > Hi Daniel, > > Thanks for your patch! > > On Tue, Feb 1, 2022 at 9:50 PM Daniel Vetter wrote: > > Well except when the olpc dcon fbdev driver is enabled, that thing > > digs around in there in rather unfixable ways. > >

[Intel-gfx] ✗ Fi.CI.IGT: failure for GuC HWCONFIG with documentation (rev2)

2022-02-08 Thread Patchwork
== Series Details == Series: GuC HWCONFIG with documentation (rev2) URL : https://patchwork.freedesktop.org/series/99787/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11200_full -> Patchwork_22202_full Summary ---

Re: [Intel-gfx] [PATCH 19/21] fbcon: Maintain a private array of fb_info

2022-02-08 Thread Daniel Vetter
On Fri, Feb 04, 2022 at 09:15:40PM +0100, Sam Ravnborg wrote: > Hi Daniel, > > On Mon, Jan 31, 2022 at 10:05:50PM +0100, Daniel Vetter wrote: > > Accessing the one in fbmem.c without taking the right locks is a bad > > idea. Instead maintain our own private copy, which is fully protected > > by

Re: [Intel-gfx] [PATCH 18/21] fbcon: untangle fbcon_exit

2022-02-08 Thread Daniel Vetter
On Fri, Feb 04, 2022 at 09:06:38PM +0100, Sam Ravnborg wrote: > Hi Daniel, > > On Mon, Jan 31, 2022 at 10:05:49PM +0100, Daniel Vetter wrote: > > There's a bunch of confusions going on here: > > - The deferred fbcon setup notifier should only be cleaned up from > > fb_console_exit(), to be

Re: [Intel-gfx] [PATCH 16/21] fbcon: Move console_lock for register/unlink/unregister

2022-02-08 Thread Daniel Vetter
On Fri, Feb 04, 2022 at 08:54:24PM +0100, Sam Ravnborg wrote: > Hi Daniel. > > On Mon, Jan 31, 2022 at 10:05:47PM +0100, Daniel Vetter wrote: > > Ideally console_lock becomes an implementation detail of fbcon.c and > > doesn't show up anywhere in fbmem.c. We're still pretty far from that, > > but

Re: [Intel-gfx] [PATCH 13/21] fbcon: move more common code into fb_open()

2022-02-08 Thread Daniel Vetter
On Fri, Feb 04, 2022 at 08:35:31PM +0100, Sam Ravnborg wrote: > On Mon, Jan 31, 2022 at 10:05:44PM +0100, Daniel Vetter wrote: > > No idea why con2fb_acquire_newinfo() initializes much less than > > fbcon_startup(), but so be it. From a quick look most of the > > un-initialized stuff should be

Re: [Intel-gfx] [PATCH 11/21] fbcon: Extract fbcon_open/release helpers

2022-02-08 Thread Daniel Vetter
On Thu, Feb 03, 2022 at 10:15:14PM +0100, Sam Ravnborg wrote: > Hi Daniel, > > On Mon, Jan 31, 2022 at 10:05:42PM +0100, Daniel Vetter wrote: > > There's two minor behaviour changes in here: > > - in error paths we now consistently call fb_ops->fb_release > > - fb_release really can't fail

Re: [Intel-gfx] [PATCH 10/21] fb: Delete fb_info->queue

2022-02-08 Thread Daniel Vetter
On Thu, Feb 03, 2022 at 10:31:00PM +0100, Sam Ravnborg wrote: > On Mon, Jan 31, 2022 at 10:05:41PM +0100, Daniel Vetter wrote: > > It was only used by fbcon, and that now switched to its own, > > private work. > > > > Signed-off-by: Daniel Vetter > > Cc: Helge Deller > > Cc:

Re: [Intel-gfx] [PATCH 06/21] fbcon: delete delayed loading code

2022-02-08 Thread Daniel Vetter
On Thu, Feb 03, 2022 at 09:45:29PM +0100, Sam Ravnborg wrote: > Hi Daniel, > > On Mon, Jan 31, 2022 at 10:05:37PM +0100, Daniel Vetter wrote: > > Before > > > > commit 6104c37094e729f3d4ce65797002112735d49cd1 > > Author: Daniel Vetter > > Date: Tue Aug 1 17:32:07 2017 +0200 > > > >

Re: [Intel-gfx] [PATCH v2 5/8] drm/i915/dp: rewrite DP 2.0 128b/132b link training based on errata

2022-02-08 Thread Jani Nikula
On Tue, 08 Feb 2022, Ville Syrjälä wrote: > On Tue, Feb 08, 2022 at 02:12:33PM +0200, Jani Nikula wrote: >> On Tue, 08 Feb 2022, Ville Syrjälä wrote: >> > On Tue, Feb 08, 2022 at 11:17:22AM +0200, Jani Nikula wrote: >> >> On Fri, 04 Feb 2022, Ville Syrjälä wrote: >> >> > On Thu, Feb 03, 2022 at

[Intel-gfx] [PATCH v3] drm/i915/dp: rewrite DP 2.0 128b/132b link training based on errata

2022-02-08 Thread Jani Nikula
The DP 2.0 errata completely overhauls the 128b/132b link training, with no provisions for backward compatibility with the original DP 2.0 specification. The changes are too intrusive to consider reusing the same code for both 8b/10b and 128b/132b, mainly because the LTTPR channel equalisation is

Re: [Intel-gfx] [PATCH v4] dma-buf-map: Rename to iosys-map

2022-02-08 Thread Hans Verkuil
On 2/4/22 18:05, Lucas De Marchi wrote: > Rename struct dma_buf_map to struct iosys_map and corresponding APIs. > Over time dma-buf-map grew up to more functionality than the one used by > dma-buf: in fact it's just a shim layer to abstract system memory, that > can be accessed via regular load

Re: [Intel-gfx] [PATCH] drm/buddy: fixup potential uaf

2022-02-08 Thread Daniel Vetter
On Tue, Feb 08, 2022 at 11:38:15AM +, Matthew Auld wrote: > If we are unlucky and somehow can't allocate enough memory when > splitting blocks, where we temporarily end up with the given block and > its buddy on the respective free list, then we need to ensure we delete > both blocks, and not

Re: [Intel-gfx] [PATCH v3] dma-buf-map: Rename to iosys-map

2022-02-08 Thread Daniel Vetter
On Thu, Feb 03, 2022 at 12:56:14AM -0800, Lucas De Marchi wrote: > Rename struct dma_buf_map to struct iosys_map and corresponding APIs. > Over time dma-buf-map grew up to more functionality than the one used by > dma-buf: in fact it's just a shim layer to abstract system memory, that > can be

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/guc: Refactor ADS access to use iosys_map (rev2)

2022-02-08 Thread Patchwork
== Series Details == Series: drm/i915/guc: Refactor ADS access to use iosys_map (rev2) URL : https://patchwork.freedesktop.org/series/99711/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11200_full -> Patchwork_22201_full

Re: [Intel-gfx] [PATCH] drm/i915/psr: Disable PSR2 selective fetch for all TGL steps

2022-02-08 Thread Souza, Jose
On Mon, 2022-02-07 at 16:38 -0500, Lyude Paul wrote: > As we've unfortunately started to come to expect from PSR on Intel > platforms, PSR2 selective fetch is not at all ready to be enabled on > Tigerlake as it results in severe flickering issues - at least on this > ThinkPad X1 Carbon 9th

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Refactor the display power domain mappings (rev2)

2022-02-08 Thread Patchwork
== Series Details == Series: drm/i915: Refactor the display power domain mappings (rev2) URL : https://patchwork.freedesktop.org/series/99476/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11200 -> Patchwork_22204 Summary

Re: [Intel-gfx] [PATCH v2 5/8] drm/i915/dp: rewrite DP 2.0 128b/132b link training based on errata

2022-02-08 Thread Ville Syrjälä
On Tue, Feb 08, 2022 at 02:12:33PM +0200, Jani Nikula wrote: > On Tue, 08 Feb 2022, Ville Syrjälä wrote: > > On Tue, Feb 08, 2022 at 11:17:22AM +0200, Jani Nikula wrote: > >> On Fri, 04 Feb 2022, Ville Syrjälä wrote: > >> > On Thu, Feb 03, 2022 at 11:03:54AM +0200, Jani Nikula wrote: > >> >> + >

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: Refactor the display power domain mappings (rev2)

2022-02-08 Thread Patchwork
== Series Details == Series: drm/i915: Refactor the display power domain mappings (rev2) URL : https://patchwork.freedesktop.org/series/99476/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Refactor the display power domain mappings (rev2)

2022-02-08 Thread Patchwork
== Series Details == Series: drm/i915: Refactor the display power domain mappings (rev2) URL : https://patchwork.freedesktop.org/series/99476/ State : warning == Summary == $ dim checkpatch origin/drm-tip fa34bdc13d82 drm/i915: Fix the VDSC_PW2 power domain enum value 69200c39d539 drm/i915:

[Intel-gfx] ✓ Fi.CI.BAT: success for GuC HWCONFIG with documentation (rev2)

2022-02-08 Thread Patchwork
== Series Details == Series: GuC HWCONFIG with documentation (rev2) URL : https://patchwork.freedesktop.org/series/99787/ State : success == Summary == CI Bug Log - changes from CI_DRM_11200 -> Patchwork_22202 Summary ---

[Intel-gfx] ✗ Fi.CI.BUILD: failure for series starting with [v6,1/3] i915/gvt: Introduce the mmio table to support VFIO new mdev API

2022-02-08 Thread Patchwork
== Series Details == Series: series starting with [v6,1/3] i915/gvt: Introduce the mmio table to support VFIO new mdev API URL : https://patchwork.freedesktop.org/series/99838/ State : failure == Summary == CALLscripts/checksyscalls.sh CALLscripts/atomic/check-atomics.sh DESCEND

Re: [Intel-gfx] [PATCH v2 5/8] drm/i915/dp: rewrite DP 2.0 128b/132b link training based on errata

2022-02-08 Thread Jani Nikula
On Tue, 08 Feb 2022, Ville Syrjälä wrote: > On Tue, Feb 08, 2022 at 11:17:22AM +0200, Jani Nikula wrote: >> On Fri, 04 Feb 2022, Ville Syrjälä wrote: >> > On Thu, Feb 03, 2022 at 11:03:54AM +0200, Jani Nikula wrote: >> >> + >> >> + if (timeout) { >> >> +

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for GuC HWCONFIG with documentation (rev2)

2022-02-08 Thread Patchwork
== Series Details == Series: GuC HWCONFIG with documentation (rev2) URL : https://patchwork.freedesktop.org/series/99787/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for GuC HWCONFIG with documentation (rev2)

2022-02-08 Thread Patchwork
== Series Details == Series: GuC HWCONFIG with documentation (rev2) URL : https://patchwork.freedesktop.org/series/99787/ State : warning == Summary == $ dim checkpatch origin/drm-tip 0d55eb6c8da5 drm/i915/guc: Add fetch of hwconfig table -:78: WARNING:FILE_PATH_CHANGES: added, moved or

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/guc: Refactor ADS access to use iosys_map (rev2)

2022-02-08 Thread Patchwork
== Series Details == Series: drm/i915/guc: Refactor ADS access to use iosys_map (rev2) URL : https://patchwork.freedesktop.org/series/99711/ State : success == Summary == CI Bug Log - changes from CI_DRM_11200 -> Patchwork_22201 Summary

[Intel-gfx] [PATCH] drm/buddy: fixup potential uaf

2022-02-08 Thread Matthew Auld
If we are unlucky and somehow can't allocate enough memory when splitting blocks, where we temporarily end up with the given block and its buddy on the respective free list, then we need to ensure we delete both blocks, and not just the buddy, before potentially freeing them. v2: rebase on

[Intel-gfx] [PATCH v2 21/26] drm/i915: Sanitize the ADL-S power well definition

2022-02-08 Thread Imre Deak
Instead of the skip_mask special casing of the ADL-S power well descriptors, add a power well descriptor list for ADL-S as well reusing the TGL descriptors, w/o the TC-cold power well. ADL-S doesn't have TypeC PHYs, so a better way would be having ADL-S specific AUX descriptors, but I left

[Intel-gfx] [PATCH v2 26/26] drm/i915: Remove the XELPD specific AUX and DDI power domains

2022-02-08 Thread Imre Deak
The spec calls the XELPD_D/E ports just D/E, the platform prefix in the domain names was only needed by the port->domain mapping relying on matching enum values for the whole port/domain range (and the corresponding aliasing between the platform specific domain enums). Since a previous patch we

[Intel-gfx] [PATCH v2 23/26] drm/i915: Remove the aliasing of power domain enum values

2022-02-08 Thread Imre Deak
Aliasing the intel_display_power_domain enum values was required because of the u64 power domain mask size limit. This makes the dmesg/debugfs printouts of the domain names somewhat unclear, for instance domain names for port D are shown on D12+ platforms where the corresponding port is called

[Intel-gfx] [PATCH v2 24/26] drm/i915: Remove the ICL specific TBT power domains

2022-02-08 Thread Imre Deak
The spec calls the ICL TBT AUX power well instances TBT1-4 (similarly to all later platforms), align the power domain names with the spec. Signed-off-by: Imre Deak --- .../gpu/drm/i915/display/intel_display_power.c | 10 +- .../gpu/drm/i915/display/intel_display_power.h | 4

[Intel-gfx] [PATCH v2 22/26] drm/i915: Sanitize the port -> DDI/AUX power domain mapping for each platform

2022-02-08 Thread Imre Deak
Atm the port -> DDI and AUX power domain mapping is specified by relying on the aliasing of the platform specific intel_display_power_domain enum values. For instance D12+ platforms refer to the 'D' port and power domain instances, which doesn't match the bspec terminology, on these platforms the

[Intel-gfx] [PATCH v2 19/26] drm/i915: Allow platforms to share power well descriptors

2022-02-08 Thread Imre Deak
Some power wells - like always-on and skl+/icl+ PW_1 - with the same name, domain list, flags, ops are used by multiple platforms, so allow platforms to reuse the descriptors of such power wells. This change also lets the follow up patches to simplify the DG1/RKL power well definitions, and

[Intel-gfx] [PATCH v2 20/26] drm/i915: Simplify the DG1 power well descriptors

2022-02-08 Thread Imre Deak
Simplify the definition of DG1 power wells by reusing the identical RKL DDI/AUX descriptors. This reorders the DG1 DDI/AUX vs. PW4/5 power wells, but this shouldn't make a difference (it is the order on RKL and the DDI/AUX power wells don't have a dependency on PW4/5). Signed-off-by: Imre Deak

[Intel-gfx] [PATCH v2 25/26] drm/i915: Remove duplicate DDI/AUX power domain mappings

2022-02-08 Thread Imre Deak
The DDI and AUX domain -> power well mappings are identical for a few platforms/power well instances, reuse the mappings of earlier platforms for these removing the duplicate mapping of new platforms. Signed-off-by: Imre Deak --- .../i915/display/intel_display_power_map.c| 89

[Intel-gfx] [PATCH v2 18/26] drm/i915: Simplify power well definitions by adding power well instances

2022-02-08 Thread Imre Deak
All the port specific AUX/DDI_IO power wells share the same power well ops struct and flags, so we can save some space and simplify the definition of these by listing for all such power wells only the params specific to them (name, domains, power well register index, id). Move these params to a

[Intel-gfx] [PATCH v2 17/26] drm/i915: Convert the u64 power well domains mask to a bitmap

2022-02-08 Thread Imre Deak
To remove the aliasing of the power domain enum values in a follow-up patch in this patchset (requiring a bigger mask) and allow for defining additional power domains in the future (at least some upcoming TypeC changes requires this) convert the u64 i915_power_well_desc::domains mask to a bitmap.

<    1   2   3   >