== Series Details ==
Series: drm/i915/dg2: Don't try to process TBT interrupts
URL : https://patchwork.freedesktop.org/series/100011/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_11215_full -> Patchwork_22253_full
Summary
== Series Details ==
Series: drm/i915/dg2: add Wa_14014947963 (rev2)
URL : https://patchwork.freedesktop.org/series/9/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_11215_full -> Patchwork_22252_full
Summary
---
== Series Details ==
Series: drm/i915/dg2: Don't try to process TBT interrupts
URL : https://patchwork.freedesktop.org/series/100011/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_11215 -> Patchwork_22253
Summary
---
== Series Details ==
Series: drm/i915/dg2: Don't try to process TBT interrupts
URL : https://patchwork.freedesktop.org/series/100011/
State : warning
== Summary ==
$ dim sparse --fast origin/drm-tip
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
Hi Paul,
On Thu, Feb 10, 2022 at 12:10 PM Paul E. McKenney wrote:
>
> On Thu, Feb 10, 2022 at 02:27:11PM -0500, Waiman Long wrote:
> > On 2/10/22 14:14, Paul E. McKenney wrote:
> > > On Thu, Feb 10, 2022 at 10:13:53AM +0100, Peter Zijlstra wrote:
> > > > On Wed, Feb 09, 2022 at 04:32:58PM -0800,
== Series Details ==
Series: drm/i915/dg2: add Wa_14014947963 (rev2)
URL : https://patchwork.freedesktop.org/series/9/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_11215 -> Patchwork_22252
Summary
---
On Thu, Feb 10, 2022 at 1:14 AM Peter Zijlstra wrote:
>
> On Wed, Feb 09, 2022 at 04:32:58PM -0800, Namhyung Kim wrote:
> > On Wed, Feb 9, 2022 at 1:09 AM Peter Zijlstra wrote:
> > >
> > > On Tue, Feb 08, 2022 at 10:41:56AM -0800, Namhyung Kim wrote:
> > >
> > > > Eventually I'm mostly
From: Matt Roper
DG2 is the first platform, that supports TC but not TBT.
interrupt code is updated to avoid trying to process
TBT-specific bits and registers.
Cc: Swathi Dhanavanthri
Signed-off-by: Matt Roper
Signed-off-by: Ramalingam C
---
drivers/gpu/drm/i915/i915_drv.h | 1 +
== Series Details ==
Series: drm/i915/dg2: add Wa_14014947963 (rev2)
URL : https://patchwork.freedesktop.org/series/9/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
14684d204805 drm/i915/dg2: add Wa_14014947963
-:37: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open
From: Clint Taylor
BSPEC: 46123
v2: Address review feedback [MattR]
v3: move register definition to gt_regs [MattR]
Cc: Matt Roper
Signed-off-by: Clint Taylor
---
drivers/gpu/drm/i915/gt/intel_gt_regs.h | 3 +++
drivers/gpu/drm/i915/gt/intel_workarounds.c | 5 +
2 files changed, 8
== Series Details ==
Series: drm/i915/dg2: add Wa_14014947963
URL : https://patchwork.freedesktop.org/series/9/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_11214_full -> Patchwork_22249_full
Summary
---
== Series Details ==
Series: drm/i915/guc: Do not complain about stale reset notifications
URL : https://patchwork.freedesktop.org/series/2/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_11214_full -> Patchwork_22247_full
== Series Details ==
Series: Move #define wbvind_on_all_cpus
URL : https://patchwork.freedesktop.org/series/1/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_11214_full -> Patchwork_22246_full
Summary
---
== Series Details ==
Series: Splitting up platform-specific calls (rev2)
URL : https://patchwork.freedesktop.org/series/99126/
State : failure
== Summary ==
Applying: i915/drm: Split out x86 and arm64 functionality
.git/rebase-apply/patch:64: new blank line at EOF.
+
warning: 1 line adds
Some x86 checks are unnecessary on arm64 systems, so they
are being split out to avoid being used.
We are starting the split with run_as_guest(), which has
an x86-specific usage, while on arm64, we aren't using it.
The split reflects the way the kernel currently handles
platform-specific
In this RFC I would like to ask the community their thoughts
on how we can best handle splitting architecture-specific
calls.
I would like to address the following:
1. How do we want to split architecture calls? Different object files
per platform? Separate function calls within the same object
On Wed, Jan 26, 2022 at 02:48:20AM -0800, Alan Previn wrote:
Add a flags parameter through all of the coredump creation
functions. Add a bitmask flag to indicate if the top
level gpu_coredump event is triggered in response to
a GuC context reset notification.
Using that flag, ensure all
Hi all,
Today's linux-next merge of the drm-intel tree got a conflict in:
drivers/gpu/drm/i915/i915_module.c
between commit:
6387a3c4b0c4 ("drm: move the buddy allocator from i915 into common drm")
from the drm tree and commit:
24524e3f43cf ("drm/i915: move the DRIVER_* macros to
== Series Details ==
Series: drm/i915/dg1: Update DMC_DEBUG3 register (rev3)
URL : https://patchwork.freedesktop.org/series/99942/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_11214 -> Patchwork_22250
Summary
---
On Wed, Jan 26, 2022 at 02:48:19AM -0800, Alan Previn wrote:
- Upon the G2H Notify-Err-Capture event, parse through the
GuC Log Buffer (error-capture-region) and dynamically allocate
capture-nodes, A single node represents a single "engine-
instance-capture-dump" and contains at least 3
== Series Details ==
Series: drm/i915/dg1: Update DMC_DEBUG3 register (rev3)
URL : https://patchwork.freedesktop.org/series/99942/
State : warning
== Summary ==
$ dim sparse --fast origin/drm-tip
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
== Series Details ==
Series: drm/i915/dg2: add Wa_14014947963
URL : https://patchwork.freedesktop.org/series/9/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_11214 -> Patchwork_22249
Summary
---
**SUCCESS**
On Thu, Feb 10, 2022 at 04:13:42PM -0800, clinton.a.tay...@intel.com wrote:
> From: Clint Taylor
>
> BSPEC: 46123
> v2: Address review feedback [MattR]
> Cc: Matt Roper
> Signed-off-by: Clint Taylor
> ---
> drivers/gpu/drm/i915/gt/intel_workarounds.c | 5 +
>
Current DMC_DEBUG3(_MMIO(0x101090)) address is for TGL,
it is wrong for DG1. Just like commit 5bcc95ca382e
("drm/i915/dg1: Update DMC_DEBUG register"), correct
this issue for DG1 platform to avoid wrong register
being read.
BSpec: 49788
v2: fix "not wrong" typo. (Jani)
Reviewed-by: Matt Roper
== Series Details ==
Series: drm/i915/dg2: add Wa_14014947963
URL : https://patchwork.freedesktop.org/series/9/
State : warning
== Summary ==
$ dim sparse --fast origin/drm-tip
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
== Series Details ==
Series: drm/i915/dg2: add Wa_14014947963
URL : https://patchwork.freedesktop.org/series/9/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
90de6a9c3128 drm/i915/dg2: add Wa_14014947963
-:22: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open
From: Clint Taylor
BSPEC: 46123
v2: Address review feedback [MattR]
Cc: Matt Roper
Signed-off-by: Clint Taylor
---
drivers/gpu/drm/i915/gt/intel_workarounds.c | 5 +
drivers/gpu/drm/i915/i915_reg.h | 2 ++
2 files changed, 7 insertions(+)
diff --git
== Series Details ==
Series: drm/i915: Move MCHBAR registers to their own header
URL : https://patchwork.freedesktop.org/series/8/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_11214 -> Patchwork_22248
Summary
---
== Series Details ==
Series: series starting with [1/2] drm/i915/display: Group PSR2 prog sequences
and workarounds
URL : https://patchwork.freedesktop.org/series/99989/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_11214_full -> Patchwork_22245_full
On Tue, Feb 08, 2022 at 02:45:13AM -0800, Lucas De Marchi wrote:
> Use iosys_map to write the policies update so access to IO and system
> memory is abstracted away.
>
> Cc: Matt Roper
> Cc: Thomas Hellström
> Cc: Daniel Vetter
> Cc: John Harrison
> Cc: Matthew Brost
> Cc: Daniele Ceraolo
== Series Details ==
Series: drm/i915: Move MCHBAR registers to their own header
URL : https://patchwork.freedesktop.org/series/8/
State : warning
== Summary ==
$ dim sparse --fast origin/drm-tip
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
== Series Details ==
Series: drm/i915: Move MCHBAR registers to their own header
URL : https://patchwork.freedesktop.org/series/8/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
312d630a44d8 drm/i915: Move MCHBAR registers to their own header
-:430:
== Series Details ==
Series: Use drm_clflush* instead of clflush (rev9)
URL : https://patchwork.freedesktop.org/series/99450/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_11214_full -> Patchwork_22244_full
Summary
---
== Series Details ==
Series: drm/i915/guc: Do not complain about stale reset notifications
URL : https://patchwork.freedesktop.org/series/2/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_11214 -> Patchwork_22247
Registers that exist within the MCH BAR and are mirrored into the GPU's
MMIO space are a good candidate to separate out into their own header.
For reference, the mirror of the MCH BAR lives at the following
locations in the graphics MMIO space:
* Pre-gen6: 0x1 - 0x13000
*
On Tue, Feb 08, 2022 at 02:45:12AM -0800, Lucas De Marchi wrote:
> Now the map is saved during creation, so use it to initialize the
> golden context, reading from shmem and writing to either system or IO
> memory.
>
> v2: Do not use a map iterator: add an offset to keep track of
> destination
>
On Tue, Feb 08, 2022 at 02:45:11AM -0800, Lucas De Marchi wrote:
> Add helpers on top of iosys_map_read_field() /
> iosys_map_write_field() functions so they always use the right
> arguments and make code easier to read.
>
> Cc: Matt Roper
> Cc: Thomas Hellström
> Cc: Daniel Vetter
> Cc: John
On Tue, Feb 08, 2022 at 02:45:10AM -0800, Lucas De Marchi wrote:
> Convert intel_guc_ads_create() and initialization to use iosys_map
> rather than plain pointer and save it in the guc struct. This will help
> with additional updates to the ads_blob after the
> creation/initialization by
== Series Details ==
Series: Move #define wbvind_on_all_cpus
URL : https://patchwork.freedesktop.org/series/1/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_11214 -> Patchwork_22246
Summary
---
**SUCCESS**
No
== Series Details ==
Series: Move #define wbvind_on_all_cpus
URL : https://patchwork.freedesktop.org/series/1/
State : warning
== Summary ==
$ dim sparse --fast origin/drm-tip
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
== Series Details ==
Series: Move #define wbvind_on_all_cpus
URL : https://patchwork.freedesktop.org/series/1/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
8fdf2f52d823 drm/i915/gt: Move wbvind_on_all_cpus #define
-:6: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped
From: John Harrison
It is possible for reset notifications to arrive for a context that is
in the process of being banned. So don't flag these as an error, just
report it as informational (because it is still useful to know that
resets are happening even if they are being ignored).
== Series Details ==
Series: drm/i915/dg1: Update DMC_DEBUG3 register (rev2)
URL : https://patchwork.freedesktop.org/series/99942/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_11214_full -> Patchwork_22243_full
Summary
Move wbvind_on_all_cpus to intel_gt.h. This will allow other wbind_on_all_cpus
calls to benefit from the #define logic, and prevent compiler errors
when building for non-x86 architectures.
Signed-off-by: Michael Cheng
---
drivers/gpu/drm/i915/gem/i915_gem_pm.c | 7 ---
This series moves the #define wbvind_on_all_cpus logic to intel_gt.h. This way
all calls to wbvind_on_all_cpus benefit from the logic, and fixes compile
errors on non-x86 platforms.
Michael Cheng (1):
drm/i915/gt: Move wbvind_on_all_cpus #define
drivers/gpu/drm/i915/gem/i915_gem_pm.c | 7
== Series Details ==
Series: drm/i915/opregion: fixes and cleanups, RESEND (rev2)
URL : https://patchwork.freedesktop.org/series/99961/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_11214_full -> Patchwork_22242_full
On 2/10/22 03:10, Tvrtko Ursulin wrote:
On 09/02/2022 05:25, Casey Bowman wrote:
On 2/7/22 07:36, Tvrtko Ursulin wrote:
On 20/01/2022 22:16, Casey Bowman wrote:
In this RFC I would like to ask the community their thoughts
on how we can best handle splitting architecture-specific
calls.
== Series Details ==
Series: series starting with [1/2] drm/i915/display: Group PSR2 prog sequences
and workarounds
URL : https://patchwork.freedesktop.org/series/99989/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_11214 -> Patchwork_22245
== Series Details ==
Series: drm/i915: drm_i915.h cleanup
URL : https://patchwork.freedesktop.org/series/99979/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_11214_full -> Patchwork_22241_full
Summary
---
== Series Details ==
Series: series starting with [1/2] drm/i915/display: Group PSR2 prog sequences
and workarounds
URL : https://patchwork.freedesktop.org/series/99989/
State : warning
== Summary ==
$ dim sparse --fast origin/drm-tip
Sparse version: v0.6.2
Fast mode used, each commit won't
== Series Details ==
Series: Use drm_clflush* instead of clflush (rev9)
URL : https://patchwork.freedesktop.org/series/99450/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_11214 -> Patchwork_22244
Summary
---
On 2/10/22 14:14, Paul E. McKenney wrote:
On Thu, Feb 10, 2022 at 10:13:53AM +0100, Peter Zijlstra wrote:
On Wed, Feb 09, 2022 at 04:32:58PM -0800, Namhyung Kim wrote:
On Wed, Feb 9, 2022 at 1:09 AM Peter Zijlstra wrote:
On Tue, Feb 08, 2022 at 10:41:56AM -0800, Namhyung Kim wrote:
> -Original Message-
> From: Roper, Matthew D
> Sent: Thursday, February 10, 2022 10:51 AM
> To: Srivatsa, Anusha
> Cc: intel-gfx@lists.freedesktop.org
> Subject: Re: [Intel-gfx] [PATCH] drm/i915/dg1: Update DMC_DEBUG3 register
>
> On Thu, Feb 10, 2022 at 08:44:30AM -0800, Anusha
== Series Details ==
Series: Use drm_clflush* instead of clflush (rev9)
URL : https://patchwork.freedesktop.org/series/99450/
State : warning
== Summary ==
$ dim sparse --fast origin/drm-tip
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
== Series Details ==
Series: Use drm_clflush* instead of clflush (rev9)
URL : https://patchwork.freedesktop.org/series/99450/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
ea63269ee004 drm: Add arch arm64 for drm_clflush_virt_range
-:40: WARNING:LINE_SPACING: Missing a blank
On Thu, Feb 10, 2022 at 08:44:30AM -0800, Anusha Srivatsa wrote:
> DMC_DEBUGU3 changes from DG1+
This looks to be the same thing as the patch that Chuansheng Liu sent:
https://patchwork.freedesktop.org/patch/473272/?series=99942=1
Matt
>
> Bspec: 49788
> Signed-off-by: Anusha Srivatsa
> ---
PSR2 workaround required when mode has delayed vblank.
BSpec: 52890
BSpec: 49421
Cc: Jouni Högander
Signed-off-by: José Roberto de Souza
---
drivers/gpu/drm/i915/display/intel_psr.c | 40 ++--
drivers/gpu/drm/i915/i915_reg.h | 13 +---
2 files changed, 46
Grouping inside of the same if all the programing sequences and
workarounds of PSR2.
The order of programing changed in intel_psr_enable_source() but
it will not affect PSR2 as at this point PSR2_ENABLE is still disabled.
Cc: Jouni Högander
Signed-off-by: José Roberto de Souza
---
Re-work intel_write_status_page to use drm_clflush_virt_range. This
will prevent compiler errors when building for non-x86 architectures.
Signed-off-by: Michael Cheng
---
drivers/gpu/drm/i915/gt/intel_engine.h | 13 -
1 file changed, 4 insertions(+), 9 deletions(-)
diff --git
Use drm_clflush_virt_range instead of clflushopt and remove the memory
barrier, since drm_clflush_virt_range takes care of that.
Signed-off-by: Michael Cheng
---
drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c | 8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git
Drop invalidate_csb_entries and directly call drm_clflush_virt_range.
This allows for one less function call, and prevent complier errors when
building for non-x86 architectures.
v2(Michael Cheng): Drop invalidate_csb_entries function and directly
invoke drm_clflush_virt_range.
Add arm64 support for drm_clflush_virt_range. dcache_clean_inval_poc
performs a flush by first performing a clean, follow by an invalidation
operation.
v2 (Michael Cheng): Use correct macro for cleaning and invalidation the
dcache.
v3 (Michael Cheng): Remove ifdef for
This patch series re-work a few i915 functions to use drm_clflush_virt_range
instead of calling clflush or clflushopt directly. This will prevent errors
when building for non-x86 architectures.
Replace all occurrence of cache_clflush_range with drm_clflush_virt_range.
This will prevent compile errors on non-x86 platforms.
Signed-off-by: Michael Cheng
---
drivers/gpu/drm/i915/gt/gen8_ppgtt.c | 12 ++--
drivers/gpu/drm/i915/gt/intel_execlists_submission.c | 2 +-
Use drm_clflush_virt_range instead of directly invoking clflush. This
will prevent compiler errors when building for non-x86 architectures.
v2(Michael Cheng): Remove extra clflush
v3(Michael Cheng): Remove memory barrier since drm_clflush_virt_range
takes care of it.
== Series Details ==
Series: drm/i915/dg1: Update DMC_DEBUG3 register (rev2)
URL : https://patchwork.freedesktop.org/series/99942/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_11214 -> Patchwork_22243
Summary
---
== Series Details ==
Series: drm/i915/dg1: Update DMC_DEBUG3 register (rev2)
URL : https://patchwork.freedesktop.org/series/99942/
State : warning
== Summary ==
$ dim sparse --fast origin/drm-tip
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
On 08/02/2022 11:20, Arunpravin wrote:
On 04/02/22 6:53 pm, Christian König wrote:
Am 04.02.22 um 12:22 schrieb Arunpravin:
On 28/01/22 7:48 pm, Matthew Auld wrote:
On Thu, 27 Jan 2022 at 14:11, Arunpravin
wrote:
- Remove drm_mm references and replace with drm buddy functionalities
- Add
On 10/02/2022 15:45, Jani Nikula wrote:
I've sent parts of this before. Another rebase round.
All look good to me.
Acked-by: Tvrtko Ursulin
Going forward you can maybe impress the readers even more by including
the before/after of your header tree / depth counter script. :)
Regards,
== Series Details ==
Series: drm/i915/opregion: fixes and cleanups, RESEND (rev2)
URL : https://patchwork.freedesktop.org/series/99961/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_11214 -> Patchwork_22242
Summary
---
On 10/02/2022 16:44, Anusha Srivatsa wrote:
DMC_DEBUGU3 changes from DG1+
Bspec: 49788
Signed-off-by: Anusha Srivatsa
---
drivers/gpu/drm/i915/display/intel_display_debugfs.c | 6 --
drivers/gpu/drm/i915/i915_reg.h | 1 +
2 files changed, 5 insertions(+), 2
== Series Details ==
Series: drm/i915/fbc: Fix the plane end Y offset check
URL : https://patchwork.freedesktop.org/series/99958/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_11212_full -> Patchwork_22238_full
Summary
== Series Details ==
Series: drm/i915/opregion: fixes and cleanups, RESEND (rev2)
URL : https://patchwork.freedesktop.org/series/99961/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
a8ab1a151539 drm/i915/opregion: check port number bounds for SWSCI display
power state
== Series Details ==
Series: drm/i915: drm_i915.h cleanup
URL : https://patchwork.freedesktop.org/series/99979/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_11214 -> Patchwork_22241
Summary
---
**SUCCESS**
No
DMC_DEBUGU3 changes from DG1+
Bspec: 49788
Signed-off-by: Anusha Srivatsa
---
drivers/gpu/drm/i915/display/intel_display_debugfs.c | 6 --
drivers/gpu/drm/i915/i915_reg.h | 1 +
2 files changed, 5 insertions(+), 2 deletions(-)
diff --git
== Series Details ==
Series: drm/i915: drm_i915.h cleanup
URL : https://patchwork.freedesktop.org/series/99979/
State : warning
== Summary ==
$ dim sparse --fast origin/drm-tip
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
== Series Details ==
Series: drm/i915: drm_i915.h cleanup
URL : https://patchwork.freedesktop.org/series/99979/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
2e49d59d1b68 drm/i915: split out i915_gem_internal.h from i915_drv.h
-:50: WARNING:FILE_PATH_CHANGES: added, moved or
On Thu, 10 Feb 2022, Ville Syrjälä wrote:
> On Thu, Feb 10, 2022 at 12:36:46PM +0200, Jani Nikula wrote:
>> Start debug logging about the presence of the new Mailbox #2 for
>> backlight. Actual support is to be added later.
>>
>> Cc: Ville Syrjälä
>> Signed-off-by: Jani Nikula
>> ---
>>
Opregion Mailbox #2 is obsolete for SWSCI usage in opregion v2.x, and
repurposed in opregion v3.x. Warn about obsole mailbox presence in v2.x,
and ignore with an error for v3.x.
v2: Demote drm_warn() to drm_dbg() on opregion v2.x
Cc: Ville Syrjälä
Signed-off-by: Jani Nikula
---
On 27/01/2022 14:11, Arunpravin wrote:
- Make drm_buddy_alloc a single function to handle
range allocation and non-range allocation demands
- Implemented a new function alloc_range() which allocates
the requested power-of-two block comply with range limitations
- Moved order computation
Group and sort includes in i915_drv.h similar to other places.
Cc: Tvrtko Ursulin
Cc: Daniel Vetter
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/i915_drv.h | 16 +++-
1 file changed, 7 insertions(+), 9 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_drv.h
It's fairly difficult to ensure these are actually not needed due to
indirect includes via other files. However, it's easier to add them back
as needed and, most importantly, where needed instead of exhaustively
proving they're unnecessary.
Cc: Tvrtko Ursulin
Cc: Daniel Vetter
Signed-off-by:
Include drm_fourcc.h, drm_plane.h, and drm_color_mgmt.h where needed, so
we can drop the includes for drm_atomic.h and drm_fourcc.h from
i915_drv.h, reducing the build dependencies.
Cc: Tvrtko Ursulin
Cc: Daniel Vetter
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/gem/i915_gem_create.c
Don't include shmem_fs.h in i915_drv.h, reducing the build dependencies.
Cc: Tvrtko Ursulin
Cc: Daniel Vetter
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/gem/i915_gem_shmem.c | 1 +
drivers/gpu/drm/i915/gem/i915_gem_ttm.c | 2 ++
drivers/gpu/drm/i915/i915_drv.h | 1 -
3
Include it only in files that use it.
Cc: Tvrtko Ursulin
Cc: Daniel Vetter
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/gem/i915_gem_clflush.c | 2 ++
drivers/gpu/drm/i915/gem/i915_gem_context.c | 1 +
drivers/gpu/drm/i915/gem/i915_gem_mman.c| 2 ++
Limit the scope of struct drm_i915_file_private to the files that
actually need it.
Cc: Tvrtko Ursulin
Cc: Daniel Vetter
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/gem/i915_gem_context.c | 1 +
.../gpu/drm/i915/gem/i915_gem_execbuffer.c| 1 +
It doesn't help much, as i915_drv.h includes i915_gpu_error.h, but it's
a step in the right direction.
Cc: Tvrtko Ursulin
Cc: Daniel Vetter
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/i915_drv.h | 11 ---
drivers/gpu/drm/i915/i915_gpu_error.h | 11 +++
2 files
Move the function next to the only user. Arguably it's perhaps not the
best place, but it's much better than having a static inline in a
header.
Cc: Tvrtko Ursulin
Cc: Daniel Vetter
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/gem/i915_gem_context.c | 15 +++
Move the function next to the only user.
Cc: Tvrtko Ursulin
Cc: Daniel Vetter
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/gt/intel_engine_cs.c | 11 ---
drivers/gpu/drm/i915/i915_debugfs.c | 11 +++
drivers/gpu/drm/i915/i915_drv.h | 2 --
3 files
We already have the gem/i915_gem_domain.c file.
Cc: Tvrtko Ursulin
Cc: Daniel Vetter
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_dpt.c| 4 +++-
drivers/gpu/drm/i915/display/intel_fb_pin.c | 1 +
drivers/gpu/drm/i915/gem/i915_gem_domain.c | 5 +++--
We already have the gem/i915_gem_create.c file.
Cc: Tvrtko Ursulin
Cc: Daniel Vetter
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/gem/i915_gem_create.c | 1 +
drivers/gpu/drm/i915/gem/i915_gem_create.h | 17 +
drivers/gpu/drm/i915/i915_driver.c | 1 +
We already have the gem/i915_gem_dmabuf.c file.
Cc: Tvrtko Ursulin
Cc: Daniel Vetter
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/gem/i915_gem_dmabuf.c | 1 +
drivers/gpu/drm/i915/gem/i915_gem_dmabuf.h | 18 ++
drivers/gpu/drm/i915/gem/i915_gem_object.c | 2 ++
Remove the duplicates.
Cc: Tvrtko Ursulin
Cc: Daniel Vetter
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/i915_drv.h | 3 ---
drivers/gpu/drm/i915/i915_gem.c | 1 +
2 files changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_drv.h
We already have the i915_gem_internal.c file.
Cc: Tvrtko Ursulin
Cc: Daniel Vetter
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_dsb.c | 2 ++
drivers/gpu/drm/i915/display/intel_overlay.c | 1 +
drivers/gpu/drm/i915/gem/i915_gem_internal.c | 1 +
I've sent parts of this before. Another rebase round.
Jani Nikula (14):
drm/i915: split out i915_gem_internal.h from i915_drv.h
drm/i915: remove leftover i915_gem_pm.h declarations from i915_drv.h
drm/i915: split out gem/i915_gem_dmabuf.h from i915_drv.h
drm/i915: split out
== Series Details ==
Series: drm/i915/opregion: fixes and cleanups, RESEND
URL : https://patchwork.freedesktop.org/series/99961/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_11213 -> Patchwork_22239
Summary
---
> -Original Message-
> From: Ville Syrjala
> Sent: Thursday, February 10, 2022 12:31 PM
> To: intel-gfx@lists.freedesktop.org
> Cc: Kahola, Mika
> Subject: [PATCH] drm/i915/fbc: Fix the plane end Y offset check
>
> From: Ville Syrjälä
>
> We lost the required >>16 when I refactored
== Series Details ==
Series: Initial support for small BAR recovery (rev3)
URL : https://patchwork.freedesktop.org/series/99370/
State : failure
== Summary ==
Applying: drm/i915: add io_size plumbing
Applying: drm/i915/ttm: require mappable by default
Applying: drm/i915: add
== Series Details ==
Series: drm/i915/opregion: fixes and cleanups, RESEND
URL : https://patchwork.freedesktop.org/series/99961/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
c30930dcbba4 drm/i915/opregion: check port number bounds for SWSCI display
power state
e7b41b2e3f18
Patches: 1, 2, 3, 5, 6, 11 are Acked-by: Nirmoy Das
Patches: 5,6 are Reviewed-by: Nirmoy Das
Sorry for partial reviews, I still need to go through more i915 code.
Regards,
Nirmoy
On 10/02/2022 13:12, Matthew Auld wrote:
Starting from DG2 we will have resizable BAR support for device
1 - 100 of 158 matches
Mail list logo
