Re: [Intel-gfx] [PATCH] ALSA: hda/i915: Fix one too many pci_dev_put()

2022-04-18 Thread Takashi Iwai
On Mon, 18 Apr 2022 06:50:32 +0200, Lucas De Marchi wrote: > > On Sun, Apr 17, 2022 at 01:13:49PM +0300, Kai Vehmanen wrote: > >Hi, > > > >On Fri, 15 Apr 2022, Lucas De Marchi wrote: > > > >> pci_get_class() will already unref the pci device passed as argument. > >> So if it's unconditionally

Re: [Intel-gfx] [PATCH v3 2/2] drm/i915/display/psr: Clear more PSR state during disable

2022-04-18 Thread Hogander, Jouni
On Thu, 2022-04-14 at 08:11 -0700, José Roberto de Souza wrote: > After commit 805f04d42a6b ("drm/i915/display/psr: Use continuos full > frame to handle frontbuffer invalidations") was merged we started to > get some drm_WARN_ON(_priv->drm, !(tmp & > PSR2_MAN_TRK_CTL_ENABLE)) > in tests that are

[Intel-gfx] ✗ Fi.CI.IGT: failure for GSC support (rev6)

2022-04-18 Thread Patchwork
== Series Details == Series: GSC support (rev6) URL : https://patchwork.freedesktop.org/series/102160/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11512_full -> Patchwork_102160v6_full Summary --- **FAILURE**

Re: [Intel-gfx] [PATCH v2 2/7] mei: add support for graphics system controller (gsc) devices

2022-04-18 Thread Ceraolo Spurio, Daniele
On 4/18/2022 5:07 PM, Daniele Ceraolo Spurio wrote: From: Tomas Winkler GSC is a graphics system controller, based on CSE, it provides a chassis controller for graphics discrete cards, as well as it supports media protection on selected devices. mei_gsc binds to a auxiliary devices exposed

Re: [Intel-gfx] [PATCH 4/8] drm/i915/pcode: Add a couple of pcode helpers

2022-04-18 Thread Dixit, Ashutosh
On Fri, 15 Apr 2022 03:31:19 -0700, Rodrigo Vivi wrote: > > On Wed, Apr 13, 2022 at 11:11:05AM -0700, Ashutosh Dixit wrote: > > Add a couple of helpers to help formatting pcode commands and improve code > > readability. > > > > Cc: Mike Ruhl > > Cc: Rodrigo Vivi > > Original-author: Dale B

[Intel-gfx] ✓ Fi.CI.BAT: success for GSC support (rev6)

2022-04-18 Thread Patchwork
== Series Details == Series: GSC support (rev6) URL : https://patchwork.freedesktop.org/series/102160/ State : success == Summary == CI Bug Log - changes from CI_DRM_11512 -> Patchwork_102160v6 Summary --- **SUCCESS** No

Re: [Intel-gfx] [PATCH 2/6] drm/i915/guc: Enable Wa_22011802037 for gen12 GuC based platforms

2022-04-18 Thread Ceraolo Spurio, Daniele
On 4/15/2022 3:40 PM, Umesh Nerlige Ramappa wrote: Initiating a reset when the command streamer is not idle or in the middle of executing an MI_FORCE_WAKE can result in a hang. Multiple command streamers can be part of a single reset domain, so resetting one would mean resetting all command

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for GSC support (rev6)

2022-04-18 Thread Patchwork
== Series Details == Series: GSC support (rev6) URL : https://patchwork.freedesktop.org/series/102160/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for GSC support (rev6)

2022-04-18 Thread Patchwork
== Series Details == Series: GSC support (rev6) URL : https://patchwork.freedesktop.org/series/102160/ State : warning == Summary == Error: dim checkpatch failed 7387efdbcddf drm/i915/gsc: add gsc as a mei auxiliary device Traceback (most recent call last): File "scripts/spdxcheck.py", line

[Intel-gfx] [PATCH v2 7/7] HAX: drm/i915: force INTEL_MEI_GSC on for CI

2022-04-18 Thread Daniele Ceraolo Spurio
After the new config option is merged we'll enable it by default in the CI config, but for now just force it on via the i915 Kconfig so we can get pre-merge CI results for it. Signed-off-by: Daniele Ceraolo Spurio --- drivers/gpu/drm/i915/Kconfig.debug | 1 + 1 file changed, 1 insertion(+)

[Intel-gfx] [PATCH v2 5/7] mei: gsc: retrieve the firmware version

2022-04-18 Thread Daniele Ceraolo Spurio
From: Alexander Usyskin Add a hook to retrieve the firmware version of the GSC devices to bus-fixup. GSC has a different MKHI clients GUIDs but the same message structure to retrieve the firmware version as MEI so mei_fwver() can be reused. CC: Ashutosh Dixit Signed-off-by: Alexander Usyskin

[Intel-gfx] [PATCH v2 4/7] mei: gsc: add runtime pm handlers

2022-04-18 Thread Daniele Ceraolo Spurio
From: Tomas Winkler Implement runtime handlers for mei-gsc, to track idle state of the device properly. CC: Rodrigo Vivi Signed-off-by: Tomas Winkler Signed-off-by: Alexander Usyskin Reviewed-by: Rodrigo Vivi --- drivers/misc/mei/gsc-me.c | 67 ++- 1

[Intel-gfx] [PATCH v2 3/7] mei: gsc: setup char driver alive in spite of firmware handshake failure

2022-04-18 Thread Daniele Ceraolo Spurio
From: Alexander Usyskin Setup char device in spite of firmware handshake failure. In order to provide host access to the firmware status registers and other information required for the manufacturing process. Signed-off-by: Alexander Usyskin Signed-off-by: Tomas Winkler Reviewed-by: Daniele

[Intel-gfx] [PATCH v2 6/7] drm/i915/dg2: add gsc with special gsc bar offsets

2022-04-18 Thread Daniele Ceraolo Spurio
From: Tomas Winkler DG2 uses different GSC offsets on memory bar and uses PXP head (HECI1). v2 (Daniele): Rebased to before the ATS patches Signed-off-by: Alexander Usyskin Signed-off-by: Tomas Winkler Reviewed-by: Daniele Ceraolo Spurio #v1 Signed-off-by: Daniele Ceraolo Spurio ---

[Intel-gfx] [PATCH v2 2/7] mei: add support for graphics system controller (gsc) devices

2022-04-18 Thread Daniele Ceraolo Spurio
From: Tomas Winkler GSC is a graphics system controller, based on CSE, it provides a chassis controller for graphics discrete cards, as well as it supports media protection on selected devices. mei_gsc binds to a auxiliary devices exposed by Intel discrete driver i915. v2: fix error check in

[Intel-gfx] [PATCH v2 1/7] drm/i915/gsc: add gsc as a mei auxiliary device

2022-04-18 Thread Daniele Ceraolo Spurio
From: Tomas Winkler GSC is a graphics system controller, it provides a chassis controller for graphics discrete cards. There are two MEI interfaces in GSC: HECI1 and HECI2. Both interfaces are on the BAR0 at offsets 0x00258000 and 0x00259000. GSC is a GT Engine (class 4: instance 6). HECI1

[Intel-gfx] [PATCH v2 0/7] GSC support

2022-04-18 Thread Daniele Ceraolo Spurio
This includes the fully reviewed DG1 series plus one reviewed patch from the ATS/DG2 series that adds the DG2 defs. This is the bare minimum required to start adding some of the HuC code needed for DG2, where HuC loading goes via the GSC. Note that the versioning of this series does not match

[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [1/2] drm/i915/display/drrs: Split the DRRS status per connector

2022-04-18 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/display/drrs: Split the DRRS status per connector URL : https://patchwork.freedesktop.org/series/102793/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11512_full -> Patchwork_102793v1_full

Re: [Intel-gfx] [PATCH 3/6] drm/i915/guc: Enable GuC based workarounds for DG2

2022-04-18 Thread Ceraolo Spurio, Daniele
On 4/15/2022 3:40 PM, Umesh Nerlige Ramappa wrote: From: John Harrison There are some workarounds for DG2 that are implemented in the GuC firmware. However, the KMD is required to enable these by setting the appropriate flag as GuC does not know what platform it is running on.

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915/display/drrs: Split the DRRS status per connector

2022-04-18 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/display/drrs: Split the DRRS status per connector URL : https://patchwork.freedesktop.org/series/102793/ State : success == Summary == CI Bug Log - changes from CI_DRM_11512 -> Patchwork_102793v1

[Intel-gfx] [PATCH 1/2] drm/i915/display/drrs: Split the DRRS status per connector

2022-04-18 Thread José Roberto de Souza
Instead of keep the DRRS status of all connectors/pipe into a single i915_drrs_status what makes user-space parsing terrible moving each eDP connector status to its own folder. As legacy support still returning the DRRS status of the first eDP connector in the main i915_drrs_status. Cc: Ville

[Intel-gfx] [PATCH 2/2] drm/i915/display/drrs: Remove repeated DRRS in i915_drrs_status

2022-04-18 Thread José Roberto de Souza
User-space parsing of i915_drrs_status is already broken so lets use this oportunity to drop those repeated "DRRS". It is the DRRS status debugfs so all of this information is related to DRRS and there is no need to mention it each time. Cc: Ville Syrjälä Signed-off-by: José Roberto de Souza

Re: [Intel-gfx] [PATCH] drm/i915: Fix DISP_POS_Y and DISP_HEIGHT defines

2022-04-18 Thread Souza, Jose
On Mon, 2022-04-18 at 17:09 +0200, Hans de Goede wrote: > Commit 428cb15d5b00 ("drm/i915: Clean up pre-skl primary plane registers") > introduced DISP_POS_Y and DISP_HEIGHT defines but accidentally set these > their masks to REG_GENMASK(31, 0) instead of REG_GENMASK(31, 16). > > This breaks the

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Fix DISP_POS_Y and DISP_HEIGHT defines

2022-04-18 Thread Patchwork
== Series Details == Series: drm/i915: Fix DISP_POS_Y and DISP_HEIGHT defines URL : https://patchwork.freedesktop.org/series/102785/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11509_full -> Patchwork_102785v1_full

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Fix DISP_POS_Y and DISP_HEIGHT defines

2022-04-18 Thread Patchwork
== Series Details == Series: drm/i915: Fix DISP_POS_Y and DISP_HEIGHT defines URL : https://patchwork.freedesktop.org/series/102785/ State : success == Summary == CI Bug Log - changes from CI_DRM_11509 -> Patchwork_102785v1 Summary ---

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: Fix DISP_POS_Y and DISP_HEIGHT defines

2022-04-18 Thread Patchwork
== Series Details == Series: drm/i915: Fix DISP_POS_Y and DISP_HEIGHT defines URL : https://patchwork.freedesktop.org/series/102785/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] [PATCH] drm/i915: Fix DISP_POS_Y and DISP_HEIGHT defines

2022-04-18 Thread Hans de Goede
Commit 428cb15d5b00 ("drm/i915: Clean up pre-skl primary plane registers") introduced DISP_POS_Y and DISP_HEIGHT defines but accidentally set these their masks to REG_GENMASK(31, 0) instead of REG_GENMASK(31, 16). This breaks the primary display pane on at least pineview machines, fix the mask to

[Intel-gfx] ✓ Fi.CI.IGT: success for DGFX OpRegion (rev4)

2022-04-18 Thread Patchwork
== Series Details == Series: DGFX OpRegion (rev4) URL : https://patchwork.freedesktop.org/series/99738/ State : success == Summary == CI Bug Log - changes from CI_DRM_11509_full -> Patchwork_99738v4_full Summary --- **SUCCESS**

[Intel-gfx] ✓ Fi.CI.BAT: success for DGFX OpRegion (rev4)

2022-04-18 Thread Patchwork
== Series Details == Series: DGFX OpRegion (rev4) URL : https://patchwork.freedesktop.org/series/99738/ State : success == Summary == CI Bug Log - changes from CI_DRM_11509 -> Patchwork_99738v4 Summary --- **SUCCESS** No

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for DGFX OpRegion (rev4)

2022-04-18 Thread Patchwork
== Series Details == Series: DGFX OpRegion (rev4) URL : https://patchwork.freedesktop.org/series/99738/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for DGFX OpRegion (rev4)

2022-04-18 Thread Patchwork
== Series Details == Series: DGFX OpRegion (rev4) URL : https://patchwork.freedesktop.org/series/99738/ State : warning == Summary == Error: dim checkpatch failed f20709da5fa0 drm/i915/opregion: Add intel_opregion_init() wrapper 78a0ce03f189 drm/i915/opregion: Abstract opregion function

Re: [Intel-gfx] [PATCH 1/1] drm/i915/guc: Convert slpc to iosys_map

2022-04-18 Thread Balasubramani Vivekanandan
On 16.03.2022 18:26, Mullati Siva wrote: > From: Siva Mullati > > Convert slpc shared data to use iosys_map rather than > plain pointer and save it in the intel_guc_slpc struct. > This will help with in read and update slpc shared data > after the slpc init by abstracting the IO vs system

[Intel-gfx] [PATCH v4 6/6] drm/i915/dgfx: Get VBT from rvda

2022-04-18 Thread Anshuman Gupta
Since OpRegion ver 2.1 MBOX3 RVDA field is Relative address of Raw VBT data from OpRegion Base. Populate the opreion->rvda accordingly. As Intel DGFX cards supports OpRegion version 2.2 or greater, RVDA as an absolute VBT physical address (Ver 2.0) doesn't applicable to DGFX cards. v2: - Add

[Intel-gfx] [PATCH v4 5/6] drm/i915/dgfx: OPROM OpRegion Setup

2022-04-18 Thread Anshuman Gupta
On igfx cards ACPI OpRegion retrieve through ASLS. System BIOS writes ASLS address to pci config space(0xFC) but on discrete cards OpRegion is part of PCI Option ROM(OPROM) along with other firmware images, i915 is interested only in Code Signature System(CSS) and OpRegion + VBT image. DGFX Cards

[Intel-gfx] [PATCH v4 4/6] drm/i915/opregion: Cond dgfx opregion func registration

2022-04-18 Thread Anshuman Gupta
DGFX ASLS and OPROM OpRegion are only supported on the GFX Cards, which supports Display Engine. Register opregion function accordingly using the HAS_DISPLAY(). And early return intel_opregion_setup() if no opregion func to avoid NULL pointer oops. v2: - Change the commit log. v3: - Use nested

[Intel-gfx] [PATCH v4 3/6] drm/i915/opregion: Add dgfx opregion func

2022-04-18 Thread Anshuman Gupta
Adding DGFX opregion dummy functions. These will be setup later to support dgfx opregion. Signed-off-by: Anshuman Gupta --- drivers/gpu/drm/i915/display/intel_opregion.c | 34 +-- 1 file changed, 32 insertions(+), 2 deletions(-) diff --git

[Intel-gfx] [PATCH v4 2/6] drm/i915/opregion: Abstract opregion function

2022-04-18 Thread Anshuman Gupta
Abstract opregion operations like get opregion base, get rvda and opregion cleanup in form of i915_opregion_ops. This will be required to converge igfx and dgfx opregion. v2: - Keep only function pointer abstraction stuff. [Jani] - Add alloc_rvda error handling. v3: - Added necessary credit to

[Intel-gfx] [PATCH v4 1/6] drm/i915/opregion: Add intel_opregion_init() wrapper

2022-04-18 Thread Anshuman Gupta
Adding intel_opregion_init() wrapper function, which encapsulates intel_opregion_setup() and will be used for other opregion specific initialization. Signed-off-by: Anshuman Gupta --- drivers/gpu/drm/i915/display/intel_opregion.c | 12 +++- drivers/gpu/drm/i915/display/intel_opregion.h

[Intel-gfx] [PATCH v4 0/6] DGFX OpRegion

2022-04-18 Thread Anshuman Gupta
This series setup DGFX OpRegion. v2 has addressed the review comment to keep only opregion abstraction stuff in "Abstract opregion function" opregion patch and some other error handling as mentioned in the patches commitlog. v3 has addressed review comment from Manasi. v4 has addressed

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/rpl-p: Add PCI IDs (rev2)

2022-04-18 Thread Patchwork
== Series Details == Series: drm/i915/rpl-p: Add PCI IDs (rev2) URL : https://patchwork.freedesktop.org/series/102701/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11509_full -> Patchwork_102701v2_full Summary ---

Re: [Intel-gfx] [PATCH 1/1] drm/i915/guc: Convert ct buffer to iosys_map

2022-04-18 Thread Balasubramani Vivekanandan
On 04.04.2022 15:01, Mullati Siva wrote: > From: Siva Mullati > > Convert CT commands and descriptors to use iosys_map rather > than plain pointer and save it in the intel_guc_ct_buffer struct. > This will help with ct_write and ct_read for cmd send and receive > after the initialization by

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/rpl-p: Add PCI IDs (rev2)

2022-04-18 Thread Patchwork
== Series Details == Series: drm/i915/rpl-p: Add PCI IDs (rev2) URL : https://patchwork.freedesktop.org/series/102701/ State : success == Summary == CI Bug Log - changes from CI_DRM_11509 -> Patchwork_102701v2 Summary ---

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/rpl-p: Add PCI IDs (rev2)

2022-04-18 Thread Patchwork
== Series Details == Series: drm/i915/rpl-p: Add PCI IDs (rev2) URL : https://patchwork.freedesktop.org/series/102701/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/rpl-p: Add PCI IDs (rev2)

2022-04-18 Thread Patchwork
== Series Details == Series: drm/i915/rpl-p: Add PCI IDs (rev2) URL : https://patchwork.freedesktop.org/series/102701/ State : warning == Summary == Error: dim checkpatch failed b1fab34e082a drm/i915/rpl-p: Add PCI IDs -:119: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed

[Intel-gfx] [PATCH V2] drm/i915/rpl-p: Add PCI IDs

2022-04-18 Thread Tejas Upadhyay
From: Matt Atwood Adding initial PCI ids for RPL-P. RPL-P behaves identically to ADL-P from i915's point of view. Changes since V1 : - SUBPLATFORM ADL_N and RPL_P clash as both are ADLP based - Matthew R Bspec: 55376 Signed-off-by: Matt Atwood Signed-off-by: Madhumitha