Re: [Intel-gfx] [PATCH v2 05/12] drm/i915/pvc: Remove additional 3D flags from PIPE_CONTROL

On Fri, May 06, 2022 at 10:23:41AM -0700, Lucas De Marchi wrote: > On Thu, May 05, 2022 at 02:38:05PM -0700, Matt Roper wrote: > > From: Stuart Summers > > > > Although we already strip 3D-specific flags from PIPE_CONTROL > > instructions when submitting to a compute engine, there are some > >

Re: [Intel-gfx] [PATCH 3/8] drm/i915/pcode: Extend pcode functions for multiple gt's

On Tue, 10 May 2022 00:43:29 -0700, Jani Nikula wrote: > On Tue, 10 May 2022, Tvrtko Ursulin wrote: > > On 29/04/2022 20:56, Ashutosh Dixit wrote: > >> diff --git a/drivers/gpu/drm/i915/i915_driver.c > >> b/drivers/gpu/drm/i915/i915_driver.c > >> index 90b0ce5051af..bc49eff38c6a 100644 > >> ---

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/reset: Add additional steps for Wa_22011802037 for execlist backend

== Series Details == Series: drm/i915/reset: Add additional steps for Wa_22011802037 for execlist backend URL : https://patchwork.freedesktop.org/series/103837/ State : success == Summary == CI Bug Log - changes from CI_DRM_11630_full -> Patchwork_103837v1_full

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/gem: Flush TLBs for all the tiles

== Series Details == Series: drm/i915/gem: Flush TLBs for all the tiles URL : https://patchwork.freedesktop.org/series/103831/ State : success == Summary == CI Bug Log - changes from CI_DRM_11630_full -> Patchwork_103831v1_full Summary

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/display: disable HPD workers before display driver unregister (rev2)

== Series Details == Series: drm/i915/display: disable HPD workers before display driver unregister (rev2) URL : https://patchwork.freedesktop.org/series/103811/ State : success == Summary == CI Bug Log - changes from CI_DRM_11630_full -> Patchwork_103811v2_full

[Intel-gfx] ✗ Fi.CI.BAT: failure for Clear TLB caches in all tiles when object is removed

== Series Details == Series: Clear TLB caches in all tiles when object is removed URL : https://patchwork.freedesktop.org/series/103846/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11631 -> Patchwork_103846v1 Summary

[Intel-gfx] ✓ Fi.CI.IGT: success for ttm for internal (rev3)

== Series Details == Series: ttm for internal (rev3) URL : https://patchwork.freedesktop.org/series/103492/ State : success == Summary == CI Bug Log - changes from CI_DRM_11630_full -> Patchwork_103492v3_full Summary --- **SUCCESS**

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Clear TLB caches in all tiles when object is removed

== Series Details == Series: Clear TLB caches in all tiles when object is removed URL : https://patchwork.freedesktop.org/series/103846/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. -

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Clear TLB caches in all tiles when object is removed

== Series Details == Series: Clear TLB caches in all tiles when object is removed URL : https://patchwork.freedesktop.org/series/103846/ State : warning == Summary == Error: dim checkpatch failed f8c5bb9dff90 drm/i915/gt: Ignore TLB invalidations on idle engines -:22: CHECK:MACRO_ARG_REUSE:

[Intel-gfx] [PATCH v4 0/3] Clear TLB caches in all tiles when object is removed

Hi, Maybe I should not send patches this late at night as I end up messing things up and spamming sleeping people. Sorry for this version 4. The real fix is in patch 2. The rest is a helper that adds the with_intel_gt_pm_if_awake() (from Chris) and one more check on the status of the engine

[Intel-gfx] [PATCH v4 3/3] drm/i915/gt: Skip TLB invalidation if the engine is not awake

We want to check if the engine is awake first before invalidating its cache. Suggested-by: Chris Wilson Signed-off-by: Andi Shyti --- drivers/gpu/drm/i915/gt/intel_gt.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/i915/gt/intel_gt.c

[Intel-gfx] [PATCH v4 2/3] drm/i915/gem: Flush TLBs for all the tiles when clearing an obj

During object cleanup we invalidate the TLBs but we do it only for gt0. Invalidate the caches for all the tiles. Reported-by: Chris Wilson Signed-off-by: Andi Shyti --- drivers/gpu/drm/i915/gem/i915_gem_pages.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git

[Intel-gfx] [PATCH v4 1/3] drm/i915/gt: Ignore TLB invalidations on idle engines

From: Chris Wilson As an extension of the current skip TLB invalidations if the device is powered down, we recognised that prior to any engine activity, all the TLBs are explicitly invalidated. Thus anytime we know the engine is asleep, we can skip invalidating the TLBs on that engine.

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/dmc: Add MMIO range restrictions

== Series Details == Series: drm/i915/dmc: Add MMIO range restrictions URL : https://patchwork.freedesktop.org/series/103844/ State : success == Summary == CI Bug Log - changes from CI_DRM_11631 -> Patchwork_103844v1 Summary ---

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/display: disable HPD workers before display driver unregister (rev4)

== Series Details == Series: drm/i915/display: disable HPD workers before display driver unregister (rev4) URL : https://patchwork.freedesktop.org/series/103811/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11631 -> Patchwork_103811v4

[Intel-gfx] [CI] drm/i915/dmc: Add MMIO range restrictions

Bspec has added some steps that check forDMC MMIO range before programming them v2: Fix for CI v3: move register defines to .h (Anusha) - Check MMIO restrictions per pipe - Add MMIO restricton for v1 dmc header as well (Lucas) v4: s/_PICK/_PICK_EVEN and use it only for Pipe DMC scenario. - clean

[Intel-gfx] ✓ Fi.CI.IGT: success for Fixes for selective fetch area calculation (rev3)

== Series Details == Series: Fixes for selective fetch area calculation (rev3) URL : https://patchwork.freedesktop.org/series/103659/ State : success == Summary == CI Bug Log - changes from CI_DRM_11629_full -> Patchwork_103659v3_full

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/reset: Add additional steps for Wa_22011802037 for execlist backend

== Series Details == Series: drm/i915/reset: Add additional steps for Wa_22011802037 for execlist backend URL : https://patchwork.freedesktop.org/series/103837/ State : success == Summary == CI Bug Log - changes from CI_DRM_11630 -> Patchwork_103837v1

Re: [Intel-gfx] ✓ Fi.CI.IGT: success for i915: Introduce Ponte Vecchio (rev3)

On Fri, May 06, 2022 at 04:29:37AM +, Patchwork wrote: > == Series Details == > > Series: i915: Introduce Ponte Vecchio (rev3) > URL : https://patchwork.freedesktop.org/series/103443/ > State : success > > == Summary == > > CI Bug Log - changes from CI_DRM_11613_full ->

[Intel-gfx] [PATCH v3] drm/i915/display: disable HPD workers before display driver unregister

Handling HPD during driver removal is pointless, and can cause different use-after-free/concurrency issues: 1. Setup of deferred fbdev after fbdev unregistration. 2. Access to DP-AUX after DP-AUX removal. Below stacktraces of both cases observed on CI: [272.634530] general protection fault,

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/reset: Add additional steps for Wa_22011802037 for execlist backend

== Series Details == Series: drm/i915/reset: Add additional steps for Wa_22011802037 for execlist backend URL : https://patchwork.freedesktop.org/series/103837/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gem: Flush TLBs for all the tiles

== Series Details == Series: drm/i915/gem: Flush TLBs for all the tiles URL : https://patchwork.freedesktop.org/series/103831/ State : success == Summary == CI Bug Log - changes from CI_DRM_11630 -> Patchwork_103831v1 Summary ---

[Intel-gfx] ✗ Fi.CI.BUILD: failure for Clear TLB caches in all tiles when object is removed

== Series Details == Series: Clear TLB caches in all tiles when object is removed URL : https://patchwork.freedesktop.org/series/103835/ State : failure == Summary == Error: make failed CALLscripts/checksyscalls.sh CALLscripts/atomic/check-atomics.sh DESCEND objtool CHK

[Intel-gfx] [PATCH] drm/i915/reset: Add additional steps for Wa_22011802037 for execlist backend

From: Umesh Nerlige Ramappa For execlists backend, current implementation of Wa_22011802037 is to stop the CS before doing a reset of the engine. This WA was further extended to wait for any pending MI FORCE WAKEUPs before issuing a reset. Add the extended steps in the execlist path of reset.

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/display: disable HPD workers before display driver unregister (rev2)

== Series Details == Series: drm/i915/display: disable HPD workers before display driver unregister (rev2) URL : https://patchwork.freedesktop.org/series/103811/ State : success == Summary == CI Bug Log - changes from CI_DRM_11630 -> Patchwork_103811v2

[Intel-gfx] [PATCH v2 3/3] drm/i915/gt: Skip TLB invalidation if the engine is not awake

We want to check if the engine is awake first before invalidating its cache. Suggested-by: Chris Wilson Signed-off-by: Andi Shyti --- drivers/gpu/drm/i915/gt/intel_gt.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/i915/gt/intel_gt.c

[Intel-gfx] [PATCH v2 2/3] drm/i915/gem: Flush TLBs for all the tiles when clearing an obj

During object cleanup we invalidate the TLBs but we do it only for gt0. Invalidate the caches for all the tiles. Reported-by: Chris Wilson Signed-off-by: Andi Shyti --- drivers/gpu/drm/i915/gem/i915_gem_pages.c | 12 +--- drivers/gpu/drm/i915/gt/intel_gt_pm.h | 2 +- 2 files

[Intel-gfx] [PATCH v2 1/3] drm/i915/gt: Ignore TLB invalidations on idle engines

From: Chris Wilson As an extension of the current skip TLB invalidations if the device is powered down, we recognised that prior to any engine activity, all the TLBs are explicitly invalidated. Thus anytime we know the engine is asleep, we can skip invalidating the TLBs on that engine.

[Intel-gfx] [PATCH v2 0/3] Clear TLB caches in all tiles when object is removed

Hi, The real fix is in patch 2. The rest is a helper that adds the with_intel_gt_pm_if_awake() (from Chris) and one more check on the status of the engine before accessing it for clearing the TLB. Andi Andi Shyti (2): drm/i915/gem: Flush TLBs for all the tiles when clearing an obj

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/display: disable HPD workers before display driver unregister (rev2)

== Series Details == Series: drm/i915/display: disable HPD workers before display driver unregister (rev2) URL : https://patchwork.freedesktop.org/series/103811/ State : warning == Summary == Error: dim checkpatch failed b60c70c594dc drm/i915/display: disable HPD workers before display

[Intel-gfx] ✓ Fi.CI.BAT: success for ttm for internal (rev3)

== Series Details == Series: ttm for internal (rev3) URL : https://patchwork.freedesktop.org/series/103492/ State : success == Summary == CI Bug Log - changes from CI_DRM_11630 -> Patchwork_103492v3 Summary --- **SUCCESS** No

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Fix 'mixing different enum types' warnings in intel_display_power.c (rev2)

== Series Details == Series: drm/i915: Fix 'mixing different enum types' warnings in intel_display_power.c (rev2) URL : https://patchwork.freedesktop.org/series/103803/ State : success == Summary == CI Bug Log - changes from CI_DRM_11628_full -> Patchwork_103803v2_full

[Intel-gfx] [PATCH] drm/i915/gem: Flush TLBs for all the tiles

During object cleanup we invalidate the TLBs but we do it only for gt0. Invalidate the caches for all the tiles. Reported-by: Chris Wilson Signed-off-by: Andi Shyti --- drivers/gpu/drm/i915/gem/i915_gem_pages.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/display: disable HPD workers before display driver unregister

== Series Details == Series: drm/i915/display: disable HPD workers before display driver unregister URL : https://patchwork.freedesktop.org/series/103811/ State : success == Summary == CI Bug Log - changes from CI_DRM_11628_full -> Patchwork_103811v1_full

[Intel-gfx] [PATCH v2] drm/i915/display: disable HPD workers before display driver unregister

Handling HPD during driver removal is pointless, and can cause different use-after-free/concurrency issues: 1. Setup of deffered fbdev after fbdev unregistration. 2. Access to DP-AUX after DP-AUX removal. Below stacktraces of both cases observed on CI: [272.634530] general protection fault,

[Intel-gfx] ✓ Fi.CI.BAT: success for Fixes for selective fetch area calculation (rev3)

== Series Details == Series: Fixes for selective fetch area calculation (rev3) URL : https://patchwork.freedesktop.org/series/103659/ State : success == Summary == CI Bug Log - changes from CI_DRM_11629 -> Patchwork_103659v3 Summary

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/gt: Fix use of static in macro mismatch

== Series Details == Series: drm/i915/gt: Fix use of static in macro mismatch URL : https://patchwork.freedesktop.org/series/103806/ State : success == Summary == CI Bug Log - changes from CI_DRM_11628_full -> Patchwork_103806v1_full

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Fixes for selective fetch area calculation (rev3)

== Series Details == Series: Fixes for selective fetch area calculation (rev3) URL : https://patchwork.freedesktop.org/series/103659/ State : warning == Summary == Error: dim checkpatch failed ece060bdc2d4 drm/print: Add drm_debug_once* macros -:34: CHECK:MACRO_ARG_REUSE: Macro argument reuse

Re: [Intel-gfx] [PATCH v3 1/3] drm/print: Add drm_debug_once* macros

On Tue, 2022-05-10 at 21:33 +0300, Jouni Högander wrote: > Add drm_debug_once* macros to allow printing out one time debug > messages which can be still controlled via drm.debug parameter. Reviewed-by: José Roberto de Souza > > Cc: José Roberto de Souza > Cc: Mika Kahola > Cc: Mark Pearson

Re: [Intel-gfx] [PATCH v3 3/3] drm/i915: Ensure damage clip area is within pipe area

On Tue, 2022-05-10 at 21:33 +0300, Jouni Högander wrote: > Current update area calculation is not handling situation where > e.g. cursor plane is fully or partially outside pipe area. > > Fix this by checking damage area against pipe_src area using > drm_rect_intersect. > > v2: Set x1 and x2 in

Re: [Intel-gfx] [PATCH v3 2/3] drm/i915/psr: Use full update In case of area calculation fails

On Tue, 2022-05-10 at 21:33 +0300, Jouni Högander wrote: > Currently we have some corner cases where area calculation fails. For > these sel fetch area calculation ends up having update area as y1 = 0, > y2 = 4. Instead of these values safer option is full update. > > One of such for example is

[Intel-gfx] [PATCH v3 3/3] drm/i915: Ensure damage clip area is within pipe area

Current update area calculation is not handling situation where e.g. cursor plane is fully or partially outside pipe area. Fix this by checking damage area against pipe_src area using drm_rect_intersect. v2: Set x1 and x2 in damaged_area initialization v3: Move drm_rect_intersect into

[Intel-gfx] [PATCH v3 2/3] drm/i915/psr: Use full update In case of area calculation fails

Currently we have some corner cases where area calculation fails. For these sel fetch area calculation ends up having update area as y1 = 0, y2 = 4. Instead of these values safer option is full update. One of such for example is big fb with offset. We don't have usable offset in

[Intel-gfx] [PATCH v3 1/3] drm/print: Add drm_debug_once* macros

Add drm_debug_once* macros to allow printing out one time debug messages which can be still controlled via drm.debug parameter. Cc: José Roberto de Souza Cc: Mika Kahola Cc: Mark Pearson Signed-off-by: Jouni Högander --- include/drm/drm_print.h | 29 + 1 file

[Intel-gfx] [PATCH v3 0/3] Fixes for selective fetch area calculation

Currently selective fetch area calculation ends up as bogus area in at least following cases: 1. Updated plane is partially or fully outside pipe area 2. Big fb with only part of memory area used for plane These end up as y1 = 0, y2 = 4 or y2 being outside pipe area. This patch set addresses

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Fix 'mixing different enum types' warnings in intel_display_power.c (rev2)

== Series Details == Series: drm/i915: Fix 'mixing different enum types' warnings in intel_display_power.c (rev2) URL : https://patchwork.freedesktop.org/series/103803/ State : success == Summary == CI Bug Log - changes from CI_DRM_11628 -> Patchwork_103803v2

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: Fix 'mixing different enum types' warnings in intel_display_power.c (rev2)

== Series Details == Series: drm/i915: Fix 'mixing different enum types' warnings in intel_display_power.c (rev2) URL : https://patchwork.freedesktop.org/series/103803/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/display: disable HPD workers before display driver unregister

== Series Details == Series: drm/i915/display: disable HPD workers before display driver unregister URL : https://patchwork.freedesktop.org/series/103811/ State : success == Summary == CI Bug Log - changes from CI_DRM_11628 -> Patchwork_103811v1

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Eliminate PIPECONF RMWs from .color_commit() (rev5)

== Series Details == Series: drm/i915: Eliminate PIPECONF RMWs from .color_commit() (rev5) URL : https://patchwork.freedesktop.org/series/102666/ State : success == Summary == CI Bug Log - changes from CI_DRM_11627_full -> Patchwork_102666v5_full

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/display: disable HPD workers before display driver unregister

== Series Details == Series: drm/i915/display: disable HPD workers before display driver unregister URL : https://patchwork.freedesktop.org/series/103811/ State : warning == Summary == Error: dim checkpatch failed ca003eeff722 drm/i915/display: disable HPD workers before display driver

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gt: Fix use of static in macro mismatch

== Series Details == Series: drm/i915/gt: Fix use of static in macro mismatch URL : https://patchwork.freedesktop.org/series/103806/ State : success == Summary == CI Bug Log - changes from CI_DRM_11628 -> Patchwork_103806v1 Summary ---

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/gt: Fix use of static in macro mismatch

== Series Details == Series: drm/i915/gt: Fix use of static in macro mismatch URL : https://patchwork.freedesktop.org/series/103806/ State : warning == Summary == Error: dim checkpatch failed 443b7d161fd5 drm/i915/gt: Fix use of static in macro mismatch -:27: WARNING:LONG_LINE: line length of

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/gem: Make drop_pages() return bool (rev2)

== Series Details == Series: drm/i915/gem: Make drop_pages() return bool (rev2) URL : https://patchwork.freedesktop.org/series/103466/ State : success == Summary == CI Bug Log - changes from CI_DRM_11627_full -> Patchwork_103466v2_full

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Fix 'mixing different enum types' warnings in intel_display_power.c

== Series Details == Series: drm/i915: Fix 'mixing different enum types' warnings in intel_display_power.c URL : https://patchwork.freedesktop.org/series/103803/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11628 -> Patchwork_103803v1

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: Fix 'mixing different enum types' warnings in intel_display_power.c

== Series Details == Series: drm/i915: Fix 'mixing different enum types' warnings in intel_display_power.c URL : https://patchwork.freedesktop.org/series/103803/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked

[Intel-gfx] [PATCH] drm/i915/display: disable HPD workers before display driver unregister

Handling HPD during driver removal is pointless, and can cause different use-after-free/concurrency issues: 1. Setup of deffered fbdev after fbdev unregistration. 2. Access to DP-AUX after DP-AUX removal. Below stacktraces of both cases observed on CI: [272.634530] general protection fault,

[Intel-gfx] [PATCH] drm/i915/gt: Fix use of static in macro mismatch

The INTEL_GT_RPS_SYSFS_ATTR was creating to different structures but. When called with the "static" keyword this is affecting only the first structure, while the second is created as non static. Move the static keyword inside the macros to affect both the structures. Reported-by: Jani Nikula

Re: [Intel-gfx] [PATCH 6/8] drm/i915/gt: Fix memory leaks in per-gt sysfs

On 10/05/2022 11:41, Andrzej Hajda wrote: On 10.05.2022 11:48, Tvrtko Ursulin wrote: On 10/05/2022 10:39, Andrzej Hajda wrote: On 10.05.2022 10:18, Tvrtko Ursulin wrote: On 10/05/2022 08:58, Andrzej Hajda wrote: Hi Tvrtko, On 10.05.2022 09:28, Tvrtko Ursulin wrote: On 29/04/2022 20:56,

Re: [Intel-gfx] [PATCH v2 25/25] drm/edid: convert version_greater() to drm_edid

LGTM Reviewed-by: Ankit Nautiyal Regards, Ankit On 5/9/2022 5:33 PM, Jani Nikula wrote: We'll need to propagate drm_edid everywhere. Also make version_greater() a function for type safety. Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 29 + 1

Re: [Intel-gfx] [PATCH v2 24/25] drm/displayid: convert to drm_edid

LGTM Reviewed-by: Ankit Nautiyal Regards, Ankit On 5/9/2022 5:33 PM, Jani Nikula wrote: We'll need to propagate drm_edid everywhere. v2: Rebase Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_displayid.c | 16 drivers/gpu/drm/drm_edid.c | 17 ++---

[Intel-gfx] [PATCH] drm/i915: Fix 'mixing different enum types' warnings in intel_display_power.c

Fix the following sparse warnings: drivers/gpu/drm/i915/display/intel_display_power.c:2431:34: warning: mixing different enum types: drivers/gpu/drm/i915/display/intel_display_power.c:2431:34:unsigned int enum intel_display_power_domain

Re: [Intel-gfx] [V2 0/3] Expose max and current bpc via debugfs

Hi Jani, Can you please help to push this series to drm-next? CI result: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102502v7/index.html? I'll merge IGT changes [1] first, so that we won't break the CI. [1]: https://patchwork.freedesktop.org/series/102387/ - Bhanu On Mon-11-04-2022

Re: [Intel-gfx] [PATCH 7/8] drm/i915/gt: Expose per-gt RPS defaults in sysfs

Hi Ashutosh, > > +static ssize_t > > +default_min_freq_mhz_show(struct kobject *kobj, struct kobj_attribute > > *attr, char *buf) > > +{ > > + struct intel_gt *gt = kobj_to_gt(kobj->parent); > > + > > + return sysfs_emit(buf, "%d\n", gt->rps_defaults.min_freq); I guess this is %u. > > +} >

[Intel-gfx] [PATCH 14/15] drm/edid: Extract drm_edid_decode_mfg_id()

From: Ville Syrjälä Make the PNPID decoding available for other users. Cc: dri-de...@lists.freedesktop.org Reviewed-by: Jani Nikula Signed-off-by: Ville Syrjälä --- include/drm/drm_edid.h | 21 + 1 file changed, 17 insertions(+), 4 deletions(-) diff --git

[Intel-gfx] [PATCH 15/15] drm/i915/bios: Dump PNPID and panel name

From: Ville Syrjälä Dump the panel PNPID and name from the VBT. Reviewed-by: Jani Nikula Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_bios.c | 24 +++ 1 file changed, 24 insertions(+) diff --git a/drivers/gpu/drm/i915/display/intel_bios.c

[Intel-gfx] [PATCH 13/15] drm/i915/bios: Determine panel type via PNPID match

From: Ville Syrjälä Apparently when the VBT panel_type==0xff we should trawl through the PNPID table and check for a match against the EDID. If a match is found the index gives us the panel_type. Tried to match the Windows behaviour here with first looking for an exact match, and if one isn't

[Intel-gfx] [PATCH 12/15] drm/i915/bios: Split VBT data into per-panel vs. global parts

From: Ville Syrjälä Move the panel specific VBT parsing to happen during the output probing stage. Needs to be done because the VBT parsing will need to look at the EDID to determine the correct panel_type on some machines. We split the parsed VBT data (i915->vbt) along the same boundary. For

[Intel-gfx] [PATCH 11/15] drm/i915/bios: Split VBT parsing to global vs. panel specific parts

From: Ville Syrjälä Parsing the panel specific data (anything that depends on panel_type) from VBT is currently happening too early. Split the whole thing into global vs. panel specific parts so that we can start doing the panel specific parsing at a later time. v2: Clarify that this is about

[Intel-gfx] [PATCH 10/15] drm/i915/bios: Split parse_driver_features() into two parts

From: Ville Syrjälä We use the "driver features" block for two different kinds of data: global data, and per panel data. Split the function into two parts along that line so that we can start doing the parsing in two different locations. Reviewed-by: Jani Nikula Signed-off-by: Ville Syrjälä

[Intel-gfx] [PATCH 09/15] drm/i915/pps: Keep VDD enabled during eDP probe

From: Ville Syrjälä Disable the delayed VDD off work during the eDP probe. If we never turn off the VDD then we can't violate the panel's power sequencing delays despite not having read them out yet from the VBT. This is mostly a belt+suspenders type of thing since the the timeout we'd use for

[Intel-gfx] [PATCH 08/15] drm/i915/pps: Reinit PPS delays after VBT has been fully parsed

From: Ville Syrjälä During the eDP probe we may not yet know the panel_type used to index the VBT panel tables. So the initial eDP probe will have to be done without that, and thus we won't yet have the PPS delays from the VBT. Once the VBT has been fully parse we should reinit the PPS delays to

[Intel-gfx] [PATCH 07/15] drm/i915/pps: Split PPS init+sanitize in two

From: Ville Syrjälä Split the PPS init to something we do at the start of the eDP probe and a second part we do at the end. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_dp.c | 2 ++ drivers/gpu/drm/i915/display/intel_pps.c | 30

[Intel-gfx] [PATCH 06/15] drm/i915/pps: Stash away original BIOS programmed PPS delays

From: Ville Syrjälä In order to do the panel VBT parsing after the EDID read (needed to determine panel_type from PNPID) we need to stash away the original BIOS programmed PPS delays so that we can consult them again when we reinit the PPS delays after the VBT parsing has been done.

[Intel-gfx] [PATCH 05/15] drm/i915/pps: Don't apply quirks/etc. to the VBT PPS delays if they haven't been initialized

From: Ville Syrjälä Skip QUIRK_INCREASE_T12_DELAY and the t11_t12 adjustment of the VBT PPS delays if we've not yet initialized them. Will be important later when the PPS delay init can happen before VBT parsing. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_pps.c | 3

[Intel-gfx] [PATCH 04/15] drm/i915/pps: Introduce pps_delays_valid()

From: Ville Syrjälä Add a small helper that determines if the PPS delays have been initialized or not. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_pps.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/display/intel_pps.c

[Intel-gfx] [PATCH 03/15] drm/i915/pps: Split pps_init_delays() into distinct parts

From: Ville Syrjälä Split each of the hw/vbt/spec PPS delay initialization into separate functions to make the whole thing less cluttered. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_pps.c | 66 +--- 1 file changed, 48 insertions(+), 18 deletions(-)

[Intel-gfx] [PATCH 02/15] drm/i915: Extract intel_edp_fixup_vbt_bpp()

From: Ville Syrjälä We have the same "override eDP VBT bpp with the current bpp" code duplciated in two places. Extract it to a helper function. TODO: Having this in .get_config() is pretty ugly. Should probably try to move it somewhere else (setup_hw_state()/etc.)... Signed-off-by: Ville

[Intel-gfx] [PATCH 01/15] drm/i915: Pass intel_connector to intel_vrr_is_capable()

From: Ville Syrjälä Pass intel_connector instead of drm_connector to intel_vrr_is_capable(). Will result in less ugly casts. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_dp.c | 2 +- drivers/gpu/drm/i915/display/intel_vrr.c | 14 +++---

[Intel-gfx] [PATCH 00/15] drm/i915/bios: PNPID->panel_type matching

From: Ville Syrjälä Handle VBT panel_type=0xff, ie. extract the panel PNPID from the EDID and match it againts the VBT panel PNPIDs to determine the actual panel_type. We need to massage the PPS init code a bit to make sure it works sensible without having access to the VBT power sequencing

Re: [Intel-gfx] [PATCH 6/8] drm/i915/gt: Fix memory leaks in per-gt sysfs

On 10.05.2022 11:48, Tvrtko Ursulin wrote: On 10/05/2022 10:39, Andrzej Hajda wrote: On 10.05.2022 10:18, Tvrtko Ursulin wrote: On 10/05/2022 08:58, Andrzej Hajda wrote: Hi Tvrtko, On 10.05.2022 09:28, Tvrtko Ursulin wrote: On 29/04/2022 20:56, Ashutosh Dixit wrote: All kmalloc'd

Re: [Intel-gfx] [PATCH v2 23/25] drm/edid: add drm_edid helper for drm_update_tile_info()

LGTM. Reviewed-by: Ankit Nautiyal Regards, Ankit On 5/9/2022 5:33 PM, Jani Nikula wrote: We'll need to propagate drm_edid everywhere. v2: Handle NULL EDID pointer (Ville, CI) Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 14 +++--- 1 file changed, 11

Re: [Intel-gfx] [PATCH v2 22/25] drm/edid: convert drm_edid_iter_begin() to drm_edid

LGTM. Reviewed-by: Ankit Nautiyal Regards, Ankit On 5/9/2022 5:33 PM, Jani Nikula wrote: We'll need to propagate drm_edid everywhere. v2: Rebase Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-)

Re: [Intel-gfx] [PATCH v2 21/25] drm/edid: convert cea_db_iter_edid_begin() to drm_edid

LGTM. Reviewed-by: Ankit Nautiyal Regards, Ankit On 5/9/2022 5:33 PM, Jani Nikula wrote: We'll need to propagate drm_edid everywhere. v2: Handle NULL drm_edid Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 21 +++-- 1 file changed, 11 insertions(+), 10

Re: [Intel-gfx] [PATCH v2 20/25] drm/edid: add drm_edid helper for drm_detect_monitor_audio()

LGTM. Reviewed-by: Ankit Nautiyal Regards, Ankit On 5/9/2022 5:33 PM, Jani Nikula wrote: We'll need to propagate drm_edid everywhere. v2: Handle NULL EDID pointer (Ville, CI) Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 37 ++--- 1 file

Re: [Intel-gfx] [PATCH v2 19/25] drm/edid: add drm_edid helper for drm_detect_hdmi_monitor()

LGTM. Reviewed-by: Ankit Nautiyal Regards, Ankit On 5/9/2022 5:33 PM, Jani Nikula wrote: We'll need to propagate drm_edid everywhere. v2: Handle NULL EDID pointer (Ville, CI) Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 33 - 1 file

Re: [Intel-gfx] [PATCH v2 18/25] drm/edid: add drm_edid helper for drm_edid_to_speaker_allocation()

LGTM Reviewed-by: Ankit Nautiyal Regards, Ankit On 5/9/2022 5:33 PM, Jani Nikula wrote: We'll need to propagate drm_edid everywhere.' v2: Handle NULL EDID pointer (Ville, CI) Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 37 +++-- 1 file

[Intel-gfx] ✗ Fi.CI.IGT: failure for Update GuC relay logging debugfs

== Series Details == Series: Update GuC relay logging debugfs URL : https://patchwork.freedesktop.org/series/103767/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11626_full -> Patchwork_103767v1_full Summary ---

Re: [Intel-gfx] [PATCH v2 17/25] drm/edid: add drm_edid helper for drm_edid_to_sad()

On 5/9/2022 5:33 PM, Jani Nikula wrote: We'll need to propagate drm_edid everywhere. v2: Handle NULL EDID pointer (Ville, CI) Signed-off-by: Jani Nikula LGTM. Reviewed-by: Ankit Nautiyal Regards, Ankit --- drivers/gpu/drm/drm_edid.c | 34 +- 1

Re: [Intel-gfx] [PATCH 6/8] drm/i915/gt: Fix memory leaks in per-gt sysfs

On 10/05/2022 10:39, Andrzej Hajda wrote: On 10.05.2022 10:18, Tvrtko Ursulin wrote: On 10/05/2022 08:58, Andrzej Hajda wrote: Hi Tvrtko, On 10.05.2022 09:28, Tvrtko Ursulin wrote: On 29/04/2022 20:56, Ashutosh Dixit wrote: All kmalloc'd kobjects need a kobject_put() to free memory. For

Re: [Intel-gfx] [PATCH 6/8] drm/i915/gt: Fix memory leaks in per-gt sysfs

On 10.05.2022 10:18, Tvrtko Ursulin wrote: On 10/05/2022 08:58, Andrzej Hajda wrote: Hi Tvrtko, On 10.05.2022 09:28, Tvrtko Ursulin wrote: On 29/04/2022 20:56, Ashutosh Dixit wrote: All kmalloc'd kobjects need a kobject_put() to free memory. For example in previous code,

Re: [Intel-gfx] [PATCH v2 16/25] drm/edid: convert drm_for_each_detailed_block() to drm_edid

LGTM. Reviewed-by: Ankit Nautiyal Regards, Ankit On 5/9/2022 5:33 PM, Jani Nikula wrote: We'll need to propagate drm_edid everywhere. v2: Fix checkpatch warning on superfluous parens Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 36 ++-- 1

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Eliminate PIPECONF RMWs from .color_commit() (rev5)

== Series Details == Series: drm/i915: Eliminate PIPECONF RMWs from .color_commit() (rev5) URL : https://patchwork.freedesktop.org/series/102666/ State : success == Summary == CI Bug Log - changes from CI_DRM_11627 -> Patchwork_102666v5

Re: [Intel-gfx] [PATCH v2 15/25] drm/edid: convert get_monitor_name() to drm_edid

LGTM. Reviewed-by: Ankit Nautiyal Regards, Ankit On 5/9/2022 5:33 PM, Jani Nikula wrote: We'll need to propagate drm_edid everywhere. v2: Drop incorrect NULL name check (Dan Carpenter) Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 24 1 file

Re: [Intel-gfx] [PATCH 2/3] drm/i915: remove single-use GEM_DEBUG_EXEC()

On Thu, 05 May 2022, Tvrtko Ursulin wrote: > On 04/05/2022 19:37, Jani Nikula wrote: >> Reduce the magic of what's going on in GEM_DEBUG_EXEC() by expanding it >> inline and being explicit about it. It's as single use case anyway, so >> the macro feels overkill. >> >> Cc: Tvrtko Ursulin >>

Re: [Intel-gfx] [PATCH v2 14/25] drm/edid: convert mode_in_range() and drm_monitor_supports_rb() to drm_edid

LGTM. Reviewed-by: Ankit Nautiyal Regards, Ankit On 5/9/2022 5:33 PM, Jani Nikula wrote: We'll need to propagate drm_edid everywhere. Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 27 ++- 1 file changed, 14 insertions(+), 13 deletions(-) diff

Re: [Intel-gfx] [PATCH v2 13/25] drm/edid: convert drm_mode_std() and children to drm_edid

LGTM. Reviewed-by: Ankit Nautiyal Regards, Ankit On 5/9/2022 5:33 PM, Jani Nikula wrote: We'll need to propagate drm_edid everywhere. Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 52 -- 1 file changed, 27 insertions(+), 25 deletions(-)

Re: [Intel-gfx] [PATCH v2 12/25] drm/edid: convert drm_cvt_modes_for_range() to drm_edid

LGTM. Reviewed-by: Ankit Nautiyal Regards, Ankit On 5/9/2022 5:33 PM, Jani Nikula wrote: We'll need to propagate drm_edid everywhere. Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: Eliminate PIPECONF RMWs from .color_commit() (rev5)

== Series Details == Series: drm/i915: Eliminate PIPECONF RMWs from .color_commit() (rev5) URL : https://patchwork.freedesktop.org/series/102666/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

Re: [Intel-gfx] [PATCH v2 11/25] drm/edid: convert drm_gtf_modes_for_range() to drm_edid

LGTM. Reviewed-by: Ankit Nautiyal Regards, Ankit On 5/9/2022 5:33 PM, Jani Nikula wrote: We'll need to propagate drm_edid everywhere. Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git

Re: [Intel-gfx] [PATCH v2 10/25] drm/edid: convert drm_dmt_modes_for_range() to drm_edid

LGTM. Reviewed-by: Ankit Nautiyal Regards, Ankit On 5/9/2022 5:33 PM, Jani Nikula wrote: We'll need to propagate drm_edid everywhere. Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git

  1   2   >