Re: [Intel-gfx] [PATCH v2 3/3] drm/i915/display: Implement seamless mode switch

2022-05-25 Thread Srinivas, Vidya
> -Original Message- > From: Srinivas, Vidya > Sent: Wednesday, May 25, 2022 2:50 PM > To: Jani Nikula ; Souza, Jose > ; intel-gfx@lists.freedesktop.org > Cc: Sean Paul ; Syrjala, Ville > > Subject: RE: [Intel-gfx] [PATCH v2 3/3] drm/i915/display: Implement seamless > mode switch > >

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/hwconfig: Future-proof platform checks

2022-05-25 Thread Patchwork
== Series Details == Series: drm/i915/hwconfig: Future-proof platform checks URL : https://patchwork.freedesktop.org/series/104338/ State : success == Summary == CI Bug Log - changes from CI_DRM_11696_full -> Patchwork_104338v1_full

Re: [Intel-gfx] [PATCH 03/10] drm/i915/uapi: expose the avail tracking

2022-05-25 Thread kernel test robot
Hi Matthew, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on drm-tip/drm-tip] [also build test WARNING on v5.18 next-20220525] [cannot apply to drm-intel/for-linux-next drm/drm-next] [If your patch is applied to the wrong git tree, kindly drop us a note

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/hwconfig: Report no hwconfig support on ADL-N

2022-05-25 Thread Vudum, Lakshminarayana
Filed a new issue https://gitlab.freedesktop.org/drm/intel/-/issues/6085 igt@kms_cursor_crc@pipe-a-cursor-256x256-sliding - incomplete - No warnings/errors Thanks, Lakshmi. -Original Message- From: Roper, Matthew D Sent: Tuesday, May 24, 2022 4:56 PM To:

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/hwconfig: Future-proof platform checks

2022-05-25 Thread Vudum, Lakshminarayana
Filed a new issue https://gitlab.freedesktop.org/drm/intel/-/issues/6086 igt@kms_atomic_transition@modeset-transition-nonblocking-fencing@1x-outputs - incomplete - No warnings/errors Thanks, Lakshmi. -Original Message- From: Roper, Matthew D Sent: Wednesday, May 25, 2022 8:23 AM To:

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/hwconfig: Report no hwconfig support on ADL-N

2022-05-25 Thread Patchwork
== Series Details == Series: drm/i915/hwconfig: Report no hwconfig support on ADL-N URL : https://patchwork.freedesktop.org/series/104270/ State : success == Summary == CI Bug Log - changes from CI_DRM_11690_full -> Patchwork_104270v1_full

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/tc: Prevent system hang when modesetting disconnected Type-C ports (rev2)

2022-05-25 Thread Patchwork
== Series Details == Series: drm/i915/tc: Prevent system hang when modesetting disconnected Type-C ports (rev2) URL : https://patchwork.freedesktop.org/series/104019/ State : success == Summary == CI Bug Log - changes from CI_DRM_11701 -> Patchwork_104019v2

Re: [Intel-gfx] [PATCH v4 1/1] drm/i915/reset: Fix error_state_read ptr + offset use

2022-05-25 Thread John Harrison
On 3/10/2022 16:43, Alan Previn wrote: Fix our pointer offset usage in error_state_read when there is no i915_gpu_coredump but buf offset is non-zero. Fixes: 0e39037b3165 ("drm/i915: Cache the error string") This fixes a kernel page fault can happen when multiple tests are running concurrently

[Intel-gfx] [PATCH v2 1/1] drm/i915/tc: Don't default disconnected legacy Type-C ports to TBT mode (v2)

2022-05-25 Thread Vivek Kasireddy
Commit 30e114ef4b16 ("drm/i915/tc: Check for DP-alt, legacy sinks before taking PHY ownership") defaults any disconnected Type-C ports to TBT-alt mode which presents a problem (which could most likely result in a system hang) when userspace forces a modeset on a Type-C port that is wired for

[Intel-gfx] [PATCH v2 0/1] drm/i915/tc: Prevent system hang when modesetting disconnected Type-C ports (v2)

2022-05-25 Thread Vivek Kasireddy
The following patch tries to prevent a system hang when a modeset is forced by userspace (Weston) on legacy Type-C ports that are disconnected. This issue was accidentally discovered while trying to modeset one of the HDMI ports on the TGL based Gigabyte system

Re: [Intel-gfx] [PATCH v1 2/2] drm/i915: Reject the atomic modeset if an associated Type-C port is disconnected

2022-05-25 Thread Kasireddy, Vivek
Hi Imre, > On Tue, May 24, 2022 at 11:29:54AM +0300, Kasireddy, Vivek wrote: > > Hi Imre, > > > > > On Fri, May 20, 2022 at 10:28:31AM +0300, Kasireddy, Vivek wrote: > > > > Hi Imre, > > > > [...] > > > > > > > > @@ -131,6 +137,20 @@ int > > > > > > > >

Re: [Intel-gfx] [PATCH 08/10] drm/i915/uapi: disable capturing objects on recoverable contexts

2022-05-25 Thread kernel test robot
Hi Matthew, Thank you for the patch! Yet something to improve: [auto build test ERROR on drm-tip/drm-tip] [also build test ERROR on v5.18 next-20220525] [cannot apply to drm-intel/for-linux-next drm/drm-next] [If your patch is applied to the wrong git tree, kindly drop us a note. And when

Re: [Intel-gfx] [PATCH] drm/i915/hwconfig: Future-proof platform checks

2022-05-25 Thread Lucas De Marchi
On Tue, May 24, 2022 at 04:59:06PM -0700, Matt Roper wrote: PVC also has a hwconfig table. Actually the current expectation is that all future platforms will have hwconfig, so let's just change the condition to an IP version check so that we don't need to keep updating this for each new

[Intel-gfx] ✗ Fi.CI.BUILD: failure for drm/syncobj: flatten dma_fence_chains on transfer (rev2)

2022-05-25 Thread Patchwork
== Series Details == Series: drm/syncobj: flatten dma_fence_chains on transfer (rev2) URL : https://patchwork.freedesktop.org/series/100110/ State : failure == Summary == Error: patch https://patchwork.freedesktop.org/api/1.0/series/100110/revisions/2/mbox/ not applied Applying:

Re: [Intel-gfx] [PATCH] drm/syncobj: flatten dma_fence_chains on transfer

2022-05-25 Thread Lucas De Marchi
On Wed, May 25, 2022 at 12:38:51PM +0200, Christian König wrote: Am 25.05.22 um 11:35 schrieb Lionel Landwerlin: On 25/05/2022 12:26, Lionel Landwerlin wrote: On 25/05/2022 11:24, Christian König wrote: Am 25.05.22 um 08:47 schrieb Lionel Landwerlin: On 09/02/2022 20:26, Christian König

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/hwconfig: Future-proof platform checks

2022-05-25 Thread Patchwork
== Series Details == Series: drm/i915/hwconfig: Future-proof platform checks URL : https://patchwork.freedesktop.org/series/104338/ State : success == Summary == CI Bug Log - changes from CI_DRM_11696_full -> Patchwork_104338v1_full

[Intel-gfx] ✓ Fi.CI.BAT: success for small BAR uapi bits

2022-05-25 Thread Patchwork
== Series Details == Series: small BAR uapi bits URL : https://patchwork.freedesktop.org/series/104369/ State : success == Summary == CI Bug Log - changes from CI_DRM_11700 -> Patchwork_104369v1 Summary --- **SUCCESS** No

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/hwconfig: Future-proof platform checks

2022-05-25 Thread Matt Roper
On Wed, May 25, 2022 at 08:23:19AM -0700, Matt Roper wrote: > On Wed, May 25, 2022 at 06:41:11AM +, Patchwork wrote: > > == Series Details == > > > > Series: drm/i915/hwconfig: Future-proof platform checks > > URL : https://patchwork.freedesktop.org/series/104338/ > > State : failure > > >

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for small BAR uapi bits

2022-05-25 Thread Patchwork
== Series Details == Series: small BAR uapi bits URL : https://patchwork.freedesktop.org/series/104369/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for small BAR uapi bits

2022-05-25 Thread Patchwork
== Series Details == Series: small BAR uapi bits URL : https://patchwork.freedesktop.org/series/104369/ State : warning == Summary == Error: dim checkpatch failed 66b32284c514 drm/doc: add rfc section for small BAR uapi -:39: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does

Re: [Intel-gfx] [PATCH] drm/i915/hwconfig: Future-proof platform checks

2022-05-25 Thread John Harrison
On 5/24/2022 16:59, Matt Roper wrote: PVC also has a hwconfig table. Actually the current expectation is that all future platforms will have hwconfig, so let's just change the condition to an IP version check so that we don't need to keep updating this for each new platform that shows up. Cc:

[Intel-gfx] [PATCH 10/10] HAX: force small BAR on dg2

2022-05-25 Thread Matthew Auld
Just for CI. Signed-off-by: Matthew Auld --- drivers/gpu/drm/i915/gt/intel_region_lmem.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/gpu/drm/i915/gt/intel_region_lmem.c b/drivers/gpu/drm/i915/gt/intel_region_lmem.c index 6c6f8cbd7321..119e53f5d9b1 100644 ---

[Intel-gfx] [PATCH 09/10] drm/i915: turn on small BAR support

2022-05-25 Thread Matthew Auld
With the uAPI in place we should now have enough in place to ensure a working system on small BAR configurations. Signed-off-by: Matthew Auld Cc: Thomas Hellström Cc: Lionel Landwerlin Cc: Tvrtko Ursulin Cc: Jon Bloomfield Cc: Daniel Vetter Cc: Jordan Justen Cc: Kenneth Graunke Cc: Akeem

[Intel-gfx] [PATCH 08/10] drm/i915/uapi: disable capturing objects on recoverable contexts

2022-05-25 Thread Matthew Auld
A non-recoverable context must be used if the user wants proper error capture on discrete platforms. In the future the kernel may want to blit the contents of some objects when later doing the capture stage. Testcase: igt@gem_exec_capture@capture-recoverable-discrete Signed-off-by: Matthew Auld

[Intel-gfx] [PATCH 07/10] drm/i915/error: skip non-mappable pages

2022-05-25 Thread Matthew Auld
Skip capturing any lmem pages that can't be copied using the CPU. This in now only best effort on platforms that have small BAR. Testcase: igt@gem-exec-capture@capture-invisible Signed-off-by: Matthew Auld Cc: Thomas Hellström Cc: Lionel Landwerlin Cc: Tvrtko Ursulin Cc: Jon Bloomfield Cc:

[Intel-gfx] [PATCH 06/10] drm/i915/uapi: add NEEDS_CPU_ACCESS hint

2022-05-25 Thread Matthew Auld
If set, force the allocation to be placed in the mappable portion of I915_MEMORY_CLASS_DEVICE. One big restriction here is that system memory (i.e I915_MEMORY_CLASS_SYSTEM) must be given as a potential placement for the object, that way we can always spill the object into system memory if we can't

[Intel-gfx] [PATCH 05/10] drm/i915/uapi: apply ALLOC_GPU_ONLY by default

2022-05-25 Thread Matthew Auld
On small BAR configurations, when dealing with I915_MEMORY_CLASS_DEVICE allocations, we assume that by default, all userspace allocations should be placed in the non-CPU visible portion. Note that dumb buffers are not included here, since these are not "GPU accelerated" and likely need CPU

[Intel-gfx] [PATCH 04/10] drm/i915: remove intel_memory_region avail

2022-05-25 Thread Matthew Auld
No longer used. Signed-off-by: Matthew Auld Cc: Thomas Hellström Cc: Lionel Landwerlin Cc: Tvrtko Ursulin Cc: Jon Bloomfield Cc: Daniel Vetter Cc: Jordan Justen Cc: Kenneth Graunke Cc: Akeem G Abodunrin --- drivers/gpu/drm/i915/intel_memory_region.c | 4 +---

[Intel-gfx] [PATCH 03/10] drm/i915/uapi: expose the avail tracking

2022-05-25 Thread Matthew Auld
Vulkan would like to have a rough measure of how much device memory can in theory be allocated. Also add unallocated_cpu_visible_size to track the visible portion, in case the device is using small BAR. Testcase: igt@i915_query@query-regions-unallocated Testcase:

[Intel-gfx] [PATCH 02/10] drm/i915/uapi: add probed_cpu_visible_size

2022-05-25 Thread Matthew Auld
Userspace wants to know the size of CPU visible portion of device local-memory, and on small BAR devices the probed_size is no longer enough. In Vulkan, for example, it would like to know the size in bytes for CPU visible VkMemoryHeap. We already track the io_size for each region, so it's just

[Intel-gfx] [PATCH 01/10] drm/doc: add rfc section for small BAR uapi

2022-05-25 Thread Matthew Auld
Add an entry for the new uapi needed for small BAR on DG2+. v2: - Some spelling fixes and other small tweaks. (Akeem & Thomas) - Rework error capture interactions, including no longer needing NEEDS_CPU_ACCESS for objects marked for capture. (Thomas) - Add probed_cpu_visible_size.

[Intel-gfx] [PATCH 00/10] small BAR uapi bits

2022-05-25 Thread Matthew Auld
Test-with: 20220525183702.490989-1-matthew.a...@intel.com -- 2.34.3

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Media freq factor and per-gt enhancements/fixes (rev10)

2022-05-25 Thread Patchwork
== Series Details == Series: drm/i915: Media freq factor and per-gt enhancements/fixes (rev10) URL : https://patchwork.freedesktop.org/series/102665/ State : success == Summary == CI Bug Log - changes from CI_DRM_11698 -> Patchwork_102665v10

[Intel-gfx] [PATCH i-g-t 3/9] tests/i915/gem_create: exercise NEEDS_CPU_ACCESS

2022-05-25 Thread Matthew Auld
Add some basic tests for this new flag. Signed-off-by: Matthew Auld Cc: Thomas Hellström --- tests/i915/gem_create.c | 309 +++- 1 file changed, 308 insertions(+), 1 deletion(-) diff --git a/tests/i915/gem_create.c b/tests/i915/gem_create.c index

[Intel-gfx] [PATCH i-g-t 4/9] lib/i915: add gem_create_with_cpu_access_in_memory_regions

2022-05-25 Thread Matthew Auld
Most users shouldn't care about such an interface, but where required, this should be useful to aid in setting NEEDS_CPU_ACCESS for a given BO. Underneath we try to smooth over needing to provide an explicit SMEM region, or if this is SMEM-only, we don't want the kernel to throw an error.

[Intel-gfx] [PATCH i-g-t 6/9] tests/i915/query: sanity check the unallocated tracking

2022-05-25 Thread Matthew Auld
Signed-off-by: Matthew Auld Cc: Thomas Hellström --- tests/i915/i915_query.c | 273 +++- 1 file changed, 272 insertions(+), 1 deletion(-) diff --git a/tests/i915/i915_query.c b/tests/i915/i915_query.c index 6b036241..77cbd93e 100644 ---

[Intel-gfx] [PATCH i-g-t 5/9] tests/i915/query: sanity check the probed_cpu_visible_size

2022-05-25 Thread Matthew Auld
Add some basic sanity checks for this, like checking if this falls within the probed_size. On older kernels the value reported here should be zero. Signed-off-by: Matthew Auld Cc: Thomas Hellström --- tests/i915/i915_query.c | 19 --- 1 file changed, 16 insertions(+), 3

[Intel-gfx] [PATCH i-g-t 2/9] lib/i915: wire up optional flags for gem_create_ext

2022-05-25 Thread Matthew Auld
For now limit to direct callers. Signed-off-by: Matthew Auld Cc: Thomas Hellström --- lib/i915/gem_create.c | 9 ++--- lib/i915/gem_create.h | 5 +++-- lib/i915/intel_memory_region.c | 2 +- tests/i915/gem_create.c| 24

[Intel-gfx] [PATCH i-g-t 0/9] small BAR uapi bits

2022-05-25 Thread Matthew Auld
-- 2.34.3

[Intel-gfx] [PATCH i-g-t 1/9] lib/i915_drm_local: Add I915_GEM_CREATE_EXT_FLAG_NEEDS_CPU_ACCESS

2022-05-25 Thread Matthew Auld
For now dump into i915_drm_local.h. Once the uapi on the kernel side is merged, and is part of drm-next, we can sync the kernel headers and remove this. Signed-off-by: Matthew Auld Cc: Thomas Hellström --- lib/i915/i915_drm_local.h | 21 + 1 file changed, 21 insertions(+)

[Intel-gfx] [PATCH i-g-t 9/9] lib/i915: request CPU_ACCESS for fb objects

2022-05-25 Thread Matthew Auld
kms_frontbuffer_tracking@basic falls over if the fb needs to be migrated from non-mappable device memory, to the mappable part, due to being temporarily pinned for scanout, when hitting the CPU fault handler, which just gives us SIGBUS. If the device has a small BAR let's attempt to use the

[Intel-gfx] [PATCH i-g-t 8/9] tests/i915/capture: handle uapi changes

2022-05-25 Thread Matthew Auld
We should mark the objects that need to be captured with NEEDS_CPU_ACCESS to ensure we can capture them if they are allocated in lmem. We also need to consider that capture only properly works on non-recoverable context, for discrete platforms. We can now also expect CPU invisible objects to be

[Intel-gfx] [PATCH i-g-t 7/9] lib/i915/intel_memory_region: plumb through the cpu_size

2022-05-25 Thread Matthew Auld
Will be useful later. Signed-off-by: Matthew Auld Cc: Thomas Hellström --- lib/i915/intel_memory_region.c | 2 ++ lib/i915/intel_memory_region.h | 1 + 2 files changed, 3 insertions(+) diff --git a/lib/i915/intel_memory_region.c b/lib/i915/intel_memory_region.c index da81650d..2dd4c156 100644

Re: [Intel-gfx] [PATCH 23/26] drm/i915: Require an exact DP link freq match for the DG2 PLL

2022-05-25 Thread Matt Roper
On Wed, May 25, 2022 at 02:30:55PM +0300, Jani Nikula wrote: > On Tue, 03 May 2022, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > No idea why the DG2 PLL DP link frequency calculation is allowing > > a non-exact match. That makes no sense so get rid of it. > > Cc: Matt. > > This also

Re: [Intel-gfx] [PATCH] drm/i915/dg2: Catch and log more unexpected values in DG1_MSTR_TILE_INTR

2022-05-25 Thread Lucas De Marchi
On Wed, May 25, 2022 at 05:03:13PM +0100, Tvrtko Ursulin wrote: On 24/05/2022 18:51, Matt Roper wrote: On Tue, May 24, 2022 at 10:43:39AM +0100, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Catch and log any garbage in the register, including no tiles marked, or multiple tiles marked.

Re: [Intel-gfx] [PATCH] drm/i915/dg2: Catch and log more unexpected values in DG1_MSTR_TILE_INTR

2022-05-25 Thread Matt Roper
On Wed, May 25, 2022 at 05:03:13PM +0100, Tvrtko Ursulin wrote: > > On 24/05/2022 18:51, Matt Roper wrote: > > On Tue, May 24, 2022 at 10:43:39AM +0100, Tvrtko Ursulin wrote: > > > From: Tvrtko Ursulin > > > > > > Catch and log any garbage in the register, including no tiles marked, or > > >

Re: [Intel-gfx] [PATCH] drm/i915/dg2: Catch and log more unexpected values in DG1_MSTR_TILE_INTR

2022-05-25 Thread Tvrtko Ursulin
On 24/05/2022 18:51, Matt Roper wrote: On Tue, May 24, 2022 at 10:43:39AM +0100, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Catch and log any garbage in the register, including no tiles marked, or multiple tiles marked. Signed-off-by: Tvrtko Ursulin Cc: Matt Roper --- We caught garbage

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/hwconfig: Future-proof platform checks

2022-05-25 Thread Matt Roper
On Wed, May 25, 2022 at 06:41:11AM +, Patchwork wrote: > == Series Details == > > Series: drm/i915/hwconfig: Future-proof platform checks > URL : https://patchwork.freedesktop.org/series/104338/ > State : failure > > == Summary == > > CI Bug Log - changes from CI_DRM_11696_full ->

Re: [Intel-gfx] [PATCH 00/14] drm/kms: Stop registering multiple /sys/class/backlight devs for a single display

2022-05-25 Thread Daniel Vetter
On Wed, May 18, 2022 at 01:12:33PM +0300, Jani Nikula wrote: > On Wed, 18 May 2022, Hans de Goede wrote: > > Hi, > > > > On 5/18/22 10:44, Jani Nikula wrote: > >> On Tue, 17 May 2022, Hans de Goede wrote: > >>> Hi All, > >>> > >>> As mentioned in my RFC titled "drm/kms: control display

Re: [Intel-gfx] [RFC PATCH v2 00/27] DRM.debug on DYNAMIC_DEBUG, add trace events

2022-05-25 Thread Daniel Vetter
On Mon, May 16, 2022 at 04:56:13PM -0600, Jim Cromie wrote: > DRM.debug API is 23 macros, issuing 10 exclusive categories of debug > messages. By rough count, they are used 5140 times in the kernel. > These all call drm_dbg or drm_devdbg, which call drm_debug_enabled(), > which checks bits in

Re: [Intel-gfx] [PATCH v3] drm/i915/dg2: Support 4k@30 on HDMI

2022-05-25 Thread Matt Roper
On Wed, May 25, 2022 at 01:34:01PM +0530, Ankit Nautiyal wrote: > From: Vandita Kulkarni > > This patch adds a fix to support 297MHz of dot clock by calculating > the pll values using synopsis algorithm. > This will help to support 4k@30 mode for HDMI monitors on DG2. > > v2: As per the

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/dg2: Support 4k@30 on HDMI (rev3)

2022-05-25 Thread Patchwork
== Series Details == Series: drm/i915/dg2: Support 4k@30 on HDMI (rev3) URL : https://patchwork.freedesktop.org/series/103862/ State : success == Summary == CI Bug Log - changes from CI_DRM_11698_full -> Patchwork_103862v3_full Summary

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Individualize fences before adding to dma_resv obj (rev5)

2022-05-25 Thread Patchwork
== Series Details == Series: drm/i915: Individualize fences before adding to dma_resv obj (rev5) URL : https://patchwork.freedesktop.org/series/104074/ State : success == Summary == CI Bug Log - changes from CI_DRM_11698 -> Patchwork_104074v5

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: Media freq factor and per-gt enhancements/fixes (rev10)

2022-05-25 Thread Patchwork
== Series Details == Series: drm/i915: Media freq factor and per-gt enhancements/fixes (rev10) URL : https://patchwork.freedesktop.org/series/102665/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Media freq factor and per-gt enhancements/fixes (rev10)

2022-05-25 Thread Patchwork
== Series Details == Series: drm/i915: Media freq factor and per-gt enhancements/fixes (rev10) URL : https://patchwork.freedesktop.org/series/102665/ State : warning == Summary == Error: dim checkpatch failed 64b997bebbd8 drm/i915/gt: Add media freq factor to per-gt sysfs 3f974c2ce37c

[Intel-gfx] [PATCH 3/4] drm/i915/gt: Add media RP0/RPn to per-gt sysfs

2022-05-25 Thread Ashutosh Dixit
From: Dale B Stimson Retrieve RP0 and RPn freq for media IP from PCODE and display in per-gt sysfs. This patch adds the following files to gt/gtN sysfs: * media_RP0_freq_mhz * media_RPn_freq_mhz v2: Fixed commit author (Rodrigo) v3: Convert to new uncore interface for pcode functions v4: Adapt

[Intel-gfx] [PATCH 1/4] drm/i915/gt: Add media freq factor to per-gt sysfs

2022-05-25 Thread Ashutosh Dixit
Expose new sysfs to program and retrieve media freq factor. Factor values of 0 (dynamic), 0.5 and 1.0 are supported via a u8.8 fixed point representation (corresponding to integer values of 0, 128 and 256 respectively). Media freq factor is converted to media_ratio_mode for GuC. It is programmed

[Intel-gfx] [PATCH 4/4] drm/i915/gt: Fix memory leaks in per-gt sysfs

2022-05-25 Thread Ashutosh Dixit
All kmalloc'd kobjects need a kobject_put() to free memory. For example in previous code, kobj_gt_release() never gets called. The requirement of kobject_put() now results in a slightly different code organization. v2: s/gtn/gt/ (Andi) Fixes: b770bcfae9ad ("drm/i915/gt: create per-tile sysfs

[Intel-gfx] [PATCH 2/4] drm/i915/pcode: Init pcode on different gt's

2022-05-25 Thread Ashutosh Dixit
Extend pcode initialization to pcode on different gt's. Cc: Tvrtko Ursulin Cc: Jani Nikula Signed-off-by: Ashutosh Dixit Reviewed-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/i915_driver.c | 20 ++-- 1 file changed, 18 insertions(+), 2 deletions(-) diff --git

[Intel-gfx] [PATCH 0/4] drm/i915: Media freq factor and per-gt enhancements/fixes

2022-05-25 Thread Ashutosh Dixit
Some recent Intel dGfx platforms allow media IP to work at a different frequency from the base GT. This patch series exposes sysfs controls for this functionality in the new per-gt sysfs. Some enhancements and fixes to previous per-gt functionality are also included to complete the new

Re: [Intel-gfx] [PATCH v6 0/7] drm/i915: Media freq factor and per-gt enhancements/fixes

2022-05-25 Thread Dixit, Ashutosh
On Mon, 23 May 2022 01:57:51 -0700, Tvrtko Ursulin wrote: > > On 13/05/2022 02:36, Ashutosh Dixit wrote: > > Some recent Intel dGfx platforms allow media IP to work at a different > > frequency from the base GT. This patch series exposes sysfs controls for > > this functionality in the new per-gt

Re: [Intel-gfx] [PATCH 23/26] drm/i915: Require an exact DP link freq match for the DG2 PLL

2022-05-25 Thread Jani Nikula
On Tue, 03 May 2022, Ville Syrjala wrote: > From: Ville Syrjälä > > No idea why the DG2 PLL DP link frequency calculation is allowing > a non-exact match. That makes no sense so get rid of it. Cc: Matt. This also makes the hdmi link rate check in the same function redundant. Reviewed-by: Jani

Re: [Intel-gfx] [PATCH 12/26] drm/i915: Feed the DPLL output freq back into crtc_state

2022-05-25 Thread Ville Syrjälä
On Wed, May 25, 2022 at 01:53:38PM +0300, Jani Nikula wrote: > On Tue, 03 May 2022, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > Fill port_clock and hw.adjusted_mode.crtc_clock with the actual > > frequency we're going to be getting from the hardware. This will > > let us accurately

Re: [Intel-gfx] [PATCH 22/26] drm/i915: Allow M/N change during fastset on bdw+

2022-05-25 Thread Jani Nikula
On Tue, 03 May 2022, Ville Syrjala wrote: > From: Ville Syrjälä > > On BDW+ M/N are double buffered and so we can easily reprogram them > during a fastset. So for eDP panels that support seamless DRRS we > can just change these without a full modeset. > > For earlier platforms we'd need to play

Re: [Intel-gfx] [PATCH 21/26] drm/i915: Add intel_panel_highest_mode()

2022-05-25 Thread Jani Nikula
On Tue, 03 May 2022, Ville Syrjala wrote: > From: Ville Syrjälä > > Add a function to get the fixed_mode with the highest clock. > The plan is to use this for the link bw calculation on seamless > DRRS panels so that we alwasy end up with the same link params > regardless of the requested

Re: [Intel-gfx] [PATCH 20/26] drm/i915: Check hw.enable and hw.active in intel_pipe_config_compare()

2022-05-25 Thread Jani Nikula
On Tue, 03 May 2022, Ville Syrjala wrote: > From: Ville Syrjälä > > Don't see a real reson not to check hw.active and hw.enable in > intel_pipe_config_compare(). We do have some checks for them > at a higher level, but I think better check them also in > intel_pipe_config_compare() in case

Re: [Intel-gfx] [PATCH 19/26] drm/i915: Skip intel_modeset_pipe_config_late() if the pipe is not enabled

2022-05-25 Thread Jani Nikula
On Tue, 03 May 2022, Ville Syrjala wrote: > From: Ville Syrjälä > > No sense in calling intel_modeset_pipe_config_late() for a disabled > pipe. > > Signed-off-by: Ville Syrjälä Reviewed-by: Jani Nikula > --- > drivers/gpu/drm/i915/display/intel_display.c | 8 +--- > 1 file changed, 5

Re: [Intel-gfx] [PATCH 18/26] drm/i915: Nuke fastet state copy hacks

2022-05-25 Thread Jani Nikula
On Tue, 03 May 2022, Ville Syrjala wrote: > From: Ville Syrjälä > > Now that we no longer do the fuzzy clock and M/N checks we can > get rid of the fastset state copy hacks. > > Signed-off-by: Ville Syrjälä Reviewed-by: Jani Nikula > --- > drivers/gpu/drm/i915/display/intel_display.c | 28

Re: [Intel-gfx] [PATCH 17/26] drm/i915: Set active dpll early for icl+

2022-05-25 Thread Jani Nikula
On Tue, 03 May 2022, Ville Syrjala wrote: > From: Ville Syrjälä > > To make the fastboot checks at least somewhat sensible let's mark > the expected DPLL as the active one right after we finished the > state computation. Otherwise intel_pipe_config_compare() will > always be comparing things

Re: [Intel-gfx] [PATCH 16/26] drm/i915: Make all clock checks non-fuzzy

2022-05-25 Thread Jani Nikula
On Tue, 03 May 2022, Ville Syrjala wrote: > From: Ville Syrjälä > > Now that we backfeed the actual DPLL frequency into the > compute crtc state all our clocks should come out exact. /me looks at where intel_fuzzy_clock_check() is still used, and it's of course DSI. Maybe we could move the

Re: [Intel-gfx] [PATCH 15/26] drm/i915: Make M/N checks non-fuzzy

2022-05-25 Thread Jani Nikula
On Tue, 03 May 2022, Ville Syrjala wrote: > From: Ville Syrjälä > > Now that we no longer fuzz M/N during fastset these should > match exctly. > > TODO: we may need to do something for fastboot here as the > VBIOS/GOP may not compute M/N exactly the same way we do. > Though I guess we could try

Re: [Intel-gfx] [PATCH 14/26] drm/i915: Skip FDI vs. dotclock sanity check during readout

2022-05-25 Thread Jani Nikula
On Tue, 03 May 2022, Ville Syrjala wrote: > From: Ville Syrjälä > > The VBIOS/GOP may not program the FDI M/n vs. dotclock entirely > consistently. Eg. on a SNB Thinkpad X220 LVDS I see dotclock of > 69.286 MHz (the best the DPLL can do) vs. FDI M/N 69.3 MHz > (matches what the EDID actually

Re: [Intel-gfx] [PATCH 13/26] drm/i915: Compute clocks earlier

2022-05-25 Thread Jani Nikula
On Tue, 03 May 2022, Ville Syrjala wrote: > From: Ville Syrjälä > > Do the DPLL computation before fastset checks. This should > allow us to get rid of all that horrible fuzzy clock handling > for fastsets. Who knows how many bugs there are caused by our > state not actually matching what the

Re: [Intel-gfx] [PATCH 12/15] drm/i915/bios: Split VBT data into per-panel vs. global parts

2022-05-25 Thread Jani Nikula
On Wed, 25 May 2022, Ville Syrjälä wrote: > On Wed, May 25, 2022 at 11:44:05AM +0300, Jani Nikula wrote: >> On Tue, 10 May 2022, Ville Syrjala wrote: >> > From: Ville Syrjälä >> > >> > Move the panel specific VBT parsing to happen during the >> > output probing stage. Needs to be done because

Re: [Intel-gfx] [PATCH 12/26] drm/i915: Feed the DPLL output freq back into crtc_state

2022-05-25 Thread Jani Nikula
On Tue, 03 May 2022, Ville Syrjala wrote: > From: Ville Syrjälä > > Fill port_clock and hw.adjusted_mode.crtc_clock with the actual > frequency we're going to be getting from the hardware. This will > let us accurately compute all derived state that depends on those. This patch (and to be

Re: [Intel-gfx] [PATCH 12/15] drm/i915/bios: Split VBT data into per-panel vs. global parts

2022-05-25 Thread Ville Syrjälä
On Wed, May 25, 2022 at 11:44:05AM +0300, Jani Nikula wrote: > On Tue, 10 May 2022, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > Move the panel specific VBT parsing to happen during the > > output probing stage. Needs to be done because the VBT > > parsing will need to look at the EDID

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/dg2: Support 4k@30 on HDMI (rev3)

2022-05-25 Thread Patchwork
== Series Details == Series: drm/i915/dg2: Support 4k@30 on HDMI (rev3) URL : https://patchwork.freedesktop.org/series/103862/ State : success == Summary == CI Bug Log - changes from CI_DRM_11698 -> Patchwork_103862v3 Summary ---

[Intel-gfx] [PATCH v6] drm/i915: Individualize fences before adding to dma_resv obj

2022-05-25 Thread Nirmoy Das
_i915_vma_move_to_active() can receive > 1 fences for multiple batch buffers submission. Because dma_resv_add_fence() can only accept one fence at a time, change _i915_vma_move_to_active() to be aware of multiple fences so that it can add individual fences to the dma resv object. v6: fix

Re: [Intel-gfx] [PATCH] drm/syncobj: flatten dma_fence_chains on transfer

2022-05-25 Thread Lionel Landwerlin
On 25/05/2022 12:26, Lionel Landwerlin wrote: On 25/05/2022 11:24, Christian König wrote: Am 25.05.22 um 08:47 schrieb Lionel Landwerlin: On 09/02/2022 20:26, Christian König wrote: It is illegal to add a dma_fence_chain as timeline point. Flatten out the fences into a dma_fence_array

Re: [Intel-gfx] [PATCH] drm/syncobj: flatten dma_fence_chains on transfer

2022-05-25 Thread Lionel Landwerlin
On 25/05/2022 11:24, Christian König wrote: Am 25.05.22 um 08:47 schrieb Lionel Landwerlin: On 09/02/2022 20:26, Christian König wrote: It is illegal to add a dma_fence_chain as timeline point. Flatten out the fences into a dma_fence_array instead. Signed-off-by: Christian König ---  

Re: [Intel-gfx] [PATCH v2 3/3] drm/i915/display: Implement seamless mode switch

2022-05-25 Thread Srinivas, Vidya
> -Original Message- > From: Jani Nikula > Sent: Wednesday, May 25, 2022 2:26 PM > To: Srinivas, Vidya ; Souza, Jose > ; intel-gfx@lists.freedesktop.org > Cc: Sean Paul ; Syrjala, Ville > > Subject: Re: [Intel-gfx] [PATCH v2 3/3] drm/i915/display: Implement seamless > mode switch > >

Re: [Intel-gfx] [PATCH v2 3/3] drm/i915/display: Implement seamless mode switch

2022-05-25 Thread Jani Nikula
On Wed, 25 May 2022, "Srinivas, Vidya" wrote: > Hello, > > Apologies for bothering. May we kindly know if this solution is approved? > I have provided the Tested-by. Thanks much. IIUC the more complete solution is [1]. BR, Jani. [1] https://patchwork.freedesktop.org/series/103491/ > >

Re: [Intel-gfx] [PATCH 2/2] x86/pat: add functions to query specific cache mode availability

2022-05-25 Thread Thorsten Leemhuis
On 25.05.22 10:37, Jan Beulich wrote: > On 25.05.2022 09:45, Thorsten Leemhuis wrote: >> On 24.05.22 20:32, Chuck Zmudzinski wrote: >>> On 5/21/22 6:47 AM, Thorsten Leemhuis wrote: I'm not a developer and I'm don't known the details of this thread and the backstory of the regression, but

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/edid: expand on struct drm_edid usage

2022-05-25 Thread Jani Nikula
On Tue, 24 May 2022, "Sarvela, Tomi P" wrote: > Both links work. Patchwork posting is done before results are synced to > upstream service. This is noticeable with 404 if the transfer is slow. > The issue is known and will be fixed when priorities allow. Right, I was just being impatient hitting

Re: [Intel-gfx] [PATCH 00/15] drm/i915/bios: PNPID->panel_type matching

2022-05-25 Thread Jani Nikula
On Tue, 10 May 2022, Ville Syrjala wrote: > From: Ville Syrjälä > > Handle VBT panel_type=0xff, ie. extract the panel PNPID from > the EDID and match it againts the VBT panel PNPIDs to determine > the actual panel_type. > > We need to massage the PPS init code a bit to make sure it > works

Re: [Intel-gfx] [PATCH 12/15] drm/i915/bios: Split VBT data into per-panel vs. global parts

2022-05-25 Thread Jani Nikula
On Tue, 10 May 2022, Ville Syrjala wrote: > From: Ville Syrjälä > > Move the panel specific VBT parsing to happen during the > output probing stage. Needs to be done because the VBT > parsing will need to look at the EDID to determine > the correct panel_type on some machines. > > We split the

[Intel-gfx] [PATCH v3] drm/i915/dg2: Support 4k@30 on HDMI

2022-05-25 Thread Ankit Nautiyal
From: Vandita Kulkarni This patch adds a fix to support 297MHz of dot clock by calculating the pll values using synopsis algorithm. This will help to support 4k@30 mode for HDMI monitors on DG2. v2: As per the algorithm, set MPLLB VCO range control bits to 3, in register SNPS_PHY_MPLLB_DIV for

[Intel-gfx] ✗ Fi.CI.BUILD: failure for drm/i915/dg2: Support 4k@30 on HDMI (rev2)

2022-05-25 Thread Patchwork
== Series Details == Series: drm/i915/dg2: Support 4k@30 on HDMI (rev2) URL : https://patchwork.freedesktop.org/series/103862/ State : failure == Summary == Error: make failed CALLscripts/checksyscalls.sh CALLscripts/atomic/check-atomics.sh DESCEND objtool CHK

[Intel-gfx] [PATCH v2] drm/i915/dg2: Support 4k@30 on HDMI

2022-05-25 Thread Ankit Nautiyal
From: Vandita Kulkarni This patch adds a fix to support 297MHz of dot clock by calculating the pll values using synopsis algorithm. This will help to support 4k@30 mode for HDMI monitors on DG2. v2: As per the algorithm, set MPLLB VCO range control bits to 3, in register SNPS_PHY_MPLLB_DIV for

Re: [Intel-gfx] [PATCH 2/2] x86/pat: add functions to query specific cache mode availability

2022-05-25 Thread Thorsten Leemhuis
On 24.05.22 20:32, Chuck Zmudzinski wrote: > On 5/21/22 6:47 AM, Thorsten Leemhuis wrote: >> On 20.05.22 16:48, Chuck Zmudzinski wrote: >>> On 5/20/2022 10:06 AM, Jan Beulich wrote: On 20.05.2022 15:33, Chuck Zmudzinski wrote: > On 5/20/2022 5:41 AM, Jan Beulich wrote: >> On

Re: [Intel-gfx] [PATCH] drm/i915/dg2: Support 4k@30 on HDMI

2022-05-25 Thread Nautiyal, Ankit K
On 5/21/2022 12:50 AM, Matt Roper wrote: On Wed, May 11, 2022 at 02:01:21PM +0530, Ankit Nautiyal wrote: From: Vandita Kulkarni This patch adds a fix to support 297MHz of dot clock by calculating the pll values using synopsis algorithm. This will help to support 4k@30 mode for HDMI monitors

Re: [Intel-gfx] [PATCH] drm/syncobj: flatten dma_fence_chains on transfer

2022-05-25 Thread Lionel Landwerlin
On 09/02/2022 20:26, Christian König wrote: It is illegal to add a dma_fence_chain as timeline point. Flatten out the fences into a dma_fence_array instead. Signed-off-by: Christian König --- drivers/gpu/drm/drm_syncobj.c | 61 --- 1 file changed, 56

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/hwconfig: Future-proof platform checks

2022-05-25 Thread Patchwork
== Series Details == Series: drm/i915/hwconfig: Future-proof platform checks URL : https://patchwork.freedesktop.org/series/104338/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11696_full -> Patchwork_104338v1_full