Re: [Intel-gfx] [PATCH] drm/i915/guc: Use drm_err instead of pr_err

2022-06-10 Thread kernel test robot
Hi, Thank you for the patch! Yet something to improve: [auto build test ERROR on v5.19-rc1] [also build test ERROR on next-20220610] [cannot apply to drm-intel/for-linux-next] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/bios: calculate panel type as per child device index in VBT

2022-06-10 Thread Patchwork
== Series Details == Series: drm/i915/bios: calculate panel type as per child device index in VBT URL : https://patchwork.freedesktop.org/series/104943/ State : success == Summary == CI Bug Log - changes from CI_DRM_11749_full -> Patchwork_104943v1_full

[Intel-gfx] [PATCH 2/2] drm/i915/gt: Cleanup interface for MCR operations

2022-06-10 Thread Matt Roper
Let's replace the assortment of intel_gt_* and intel_uncore_* functions that operate on MCR registers with a cleaner set of interfaces: * intel_gt_mcr_read -- unicast read from specific instance * intel_gt_mcr_read_any[_fw] -- unicast read from any non-terminated instance * intel_gt_mcr_

[Intel-gfx] [PATCH 0/2] i915: Extract, polish, and document multicast handling

2022-06-10 Thread Matt Roper
Multicast/replicated (MCR) registers on Intel hardware are a purely GT-specific concept. Rather than leaving MCR register handling spread across several places throughout the driver (intel_uncore.c, intel_gt.c, etc.) with confusing combinations of handler functions living in different namespaces,

[Intel-gfx] [PATCH 1/2] drm/i915/gt: Move multicast register handling to a dedicated file

2022-06-10 Thread Matt Roper
Handling of multicast/replicated registers is spread across intel_gt.c and intel_uncore.c today. As multicast handling and the related steering logic gets more complicated with the addition of new platforms and new rules it makes sense to centralize it all in one place. For now the existing funct

Re: [Intel-gfx] [PATCH 3/3] drm/i915/hwmon: Add HWMON current voltage support

2022-06-10 Thread Dixit, Ashutosh
On Mon, 23 May 2022 04:08:41 -0700, Badal Nilawar wrote: > > +static int > +i915_in_read(struct i915_hwmon_drvdata *ddat, u32 attr, long *val) > +{ > + struct i915_hwmon *hwmon = ddat->dd_hwmon; > + intel_wakeref_t wakeref; > + u32 reg_value; > + > + switch (attr) { > + case hwm

Re: [Intel-gfx] [PATCH 3/3] drm/i915/hwmon: Add HWMON current voltage support

2022-06-10 Thread Dixit, Ashutosh
On Fri, 10 Jun 2022 15:35:23 -0700, Dixit, Ashutosh wrote: > > On Mon, 23 May 2022 04:08:41 -0700, Badal Nilawar wrote: > > > > @@ -370,6 +386,41 @@ i915_power_write(struct i915_hwmon_drvdata *ddat, u32 > > attr, int chan, long val) > > return ret; > > } > > > > +static umode_t > > +i915_in_i

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/3] iosys-map: Add per-word read

2022-06-10 Thread Patchwork
== Series Details == Series: series starting with [1/3] iosys-map: Add per-word read URL : https://patchwork.freedesktop.org/series/105011/ State : success == Summary == CI Bug Log - changes from CI_DRM_11753 -> Patchwork_105011v1 Summary -

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/3] iosys-map: Add per-word read

2022-06-10 Thread Patchwork
== Series Details == Series: series starting with [1/3] iosys-map: Add per-word read URL : https://patchwork.freedesktop.org/series/105011/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/3] iosys-map: Add per-word read

2022-06-10 Thread Patchwork
== Series Details == Series: series starting with [1/3] iosys-map: Add per-word read URL : https://patchwork.freedesktop.org/series/105011/ State : warning == Summary == Error: dim checkpatch failed 553952dee006 iosys-map: Add per-word read -:69: ERROR:SPACING: spaces required around that ':'

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/pvc: Adjust EU per SS according to HAS_ONE_EU_PER_FUSE_BIT()

2022-06-10 Thread Patchwork
== Series Details == Series: drm/i915/pvc: Adjust EU per SS according to HAS_ONE_EU_PER_FUSE_BIT() URL : https://patchwork.freedesktop.org/series/105010/ State : success == Summary == CI Bug Log - changes from CI_DRM_11753 -> Patchwork_105010v1 =

[Intel-gfx] [PATCH] drm/i915/guc/slpc: Add a new SLPC selftest

2022-06-10 Thread Vinay Belgaumkar
This test will validate we can achieve actual frequency of RP0. Pcode grants frequencies based on what GuC is requesting. However, thermal throttling can limit what is being granted. Add a test to request for max, but don't fail the test if RP0 is not granted due to throttle reasons. Also optimize

[Intel-gfx] [PATCH 3/3] iosys-map: Fix typo in documentation

2022-06-10 Thread Lucas De Marchi
It's one argument, vaddr_iomem, not 2 (vaddr and _iomem). Signed-off-by: Lucas De Marchi --- include/linux/iosys-map.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/iosys-map.h b/include/linux/iosys-map.h index 793e5cd50dbf..d092d30f5812 100644 --- a/include/l

[Intel-gfx] [PATCH 1/3] iosys-map: Add per-word read

2022-06-10 Thread Lucas De Marchi
Instead of always falling back to memcpy_fromio() for any size, prefer using read{b,w,l}(). When reading struct members it's common to read individual integer variables individually. Going through memcpy_fromio() for each of them poses a high penalty. Employ a similar trick as __seqprop() by using

[Intel-gfx] [PATCH 2/3] iosys-map: Add per-word write

2022-06-10 Thread Lucas De Marchi
Like was done for read, provide the equivalent for write. Even if current users are not in the hot path, this should future-proof it. Signed-off-by: Lucas De Marchi --- include/linux/iosys-map.h | 20 +--- 1 file changed, 17 insertions(+), 3 deletions(-) diff --git a/include/lin

[Intel-gfx] [PATCH] drm/i915/pvc: Adjust EU per SS according to HAS_ONE_EU_PER_FUSE_BIT()

2022-06-10 Thread Matt Roper
If we're treating each bit in the EU fuse register as a single EU instead of a pair of EUs, then that also cuts the number of potential EUs per subslice in half. Fixes: 5ac342ef84d7 ("drm/i915/pvc: Add SSEU changes") Signed-off-by: Matt Roper --- drivers/gpu/drm/i915/gt/intel_sseu.c | 2 +- 1 fi

Re: [Intel-gfx] [PATCH 3/3] drm/i915/hwmon: Add HWMON current voltage support

2022-06-10 Thread Dixit, Ashutosh
On Mon, 23 May 2022 04:08:41 -0700, Badal Nilawar wrote: > > @@ -370,6 +386,41 @@ i915_power_write(struct i915_hwmon_drvdata *ddat, u32 > attr, int chan, long val) > return ret; > } > > +static umode_t > +i915_in_is_visible(const struct i915_hwmon_drvdata *ddat, u32 attr) > +{ > + struc

[Intel-gfx] ✗ Fi.CI.BUILD: failure for drm/i915/guc/slpc: Add a new SLPC selftest

2022-06-10 Thread Patchwork
== Series Details == Series: drm/i915/guc/slpc: Add a new SLPC selftest URL : https://patchwork.freedesktop.org/series/105005/ State : failure == Summary == Error: make failed CALLscripts/checksyscalls.sh CALLscripts/atomic/check-atomics.sh DESCEND objtool CHK include/gener

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: ttm for internal (rev2)

2022-06-10 Thread Patchwork
== Series Details == Series: drm/i915: ttm for internal (rev2) URL : https://patchwork.freedesktop.org/series/104909/ State : success == Summary == CI Bug Log - changes from CI_DRM_11749_full -> Patchwork_104909v2_full Summary --- **

[Intel-gfx] [PATCH] drm/i915/guc/slpc: Add a new SLPC selftest

2022-06-10 Thread Vinay Belgaumkar
This test will validate we can achieve actual frequency of RP0. Pcode grants frequencies based on what GuC is requesting. However, thermal throttling can limit what is being granted. Add a test to request for max, but don't fail the test if RP0 is not granted due to throttle reasons. Also optimize

Re: [Intel-gfx] [PATCH v2 08/15] drm/probe-helper: add drm_connector_helper_get_modes()

2022-06-10 Thread Ville Syrjälä
On Wed, Jun 08, 2022 at 10:50:38AM +0300, Jani Nikula wrote: > Add a helper function to be used as the "default" .get_modes() > hook. This also works as an example of what the driver .get_modes() > hooks are supposed to do regarding the new drm_edid_read*() and > drm_edid_connector_update() calls.

Re: [Intel-gfx] [PATCH v2 05/15] drm/edid: add new interfaces around struct drm_edid

2022-06-10 Thread Ville Syrjälä
On Wed, Jun 08, 2022 at 10:50:35AM +0300, Jani Nikula wrote: > Add new functions drm_edid_read(), drm_edid_read_ddc(), and > drm_edid_read_custom() to replace drm_get_edid() and drm_do_get_edid() > for reading the EDID. The transition is expected to happen over a fairly > long time. > > Note that

Re: [Intel-gfx] [PATCH v2 07/15] drm/probe-helper: abstract .get_modes() connector helper call

2022-06-10 Thread Ville Syrjälä
On Wed, Jun 08, 2022 at 10:50:37AM +0300, Jani Nikula wrote: > Abstract the .get_modes() connector helper call, including the > override/firmware EDID fallback, for clarity. > > Signed-off-by: Jani Nikula Reviewed-by: Ville Syrjälä > --- > drivers/gpu/drm/drm_probe_helper.c | 29 +

Re: [Intel-gfx] [PATCH v2 05/15] drm/edid: add new interfaces around struct drm_edid

2022-06-10 Thread Ville Syrjälä
On Wed, Jun 08, 2022 at 10:50:35AM +0300, Jani Nikula wrote: > Add new functions drm_edid_read(), drm_edid_read_ddc(), and > drm_edid_read_custom() to replace drm_get_edid() and drm_do_get_edid() > for reading the EDID. The transition is expected to happen over a fairly > long time. > > Note that

Re: [Intel-gfx] [PATCH v2 04/15] drm/edid: keep track of alloc size in drm_do_get_edid()

2022-06-10 Thread Ville Syrjälä
On Wed, Jun 08, 2022 at 10:50:34AM +0300, Jani Nikula wrote: > We'll want to return the allocated buffer size in the future. Keep track > of it. > > Signed-off-by: Jani Nikula Reviewed-by: Ville Syrjälä > --- > drivers/gpu/drm/drm_edid.c | 27 +++ > 1 file changed, 19

Re: [Intel-gfx] [PATCH v2 14/15] drm/edid: take HF-EEODB extension count into account

2022-06-10 Thread Ville Syrjälä
On Wed, Jun 08, 2022 at 10:50:44AM +0300, Jani Nikula wrote: > Take the HF-EEODB extension count override into account. > > Signed-off-by: Jani Nikula > --- > drivers/gpu/drm/drm_edid.c | 13 + > 1 file changed, 13 insertions(+) > > diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/

Re: [Intel-gfx] [PATCH v2 13/15] drm/edid: add HF-EEODB support to EDID read and allocation

2022-06-10 Thread Ville Syrjälä
On Wed, Jun 08, 2022 at 10:50:43AM +0300, Jani Nikula wrote: > HDMI 2.1 section 10.3.6 defines an HDMI Forum EDID Extension Override > Data Block, which may contain a different extension count than the base > block claims. Add support for reading more EDID data if available. The > extra blocks aren

Re: [Intel-gfx] [PATCH v2 12/15] drm/edid: do invalid block filtering in-place

2022-06-10 Thread Ville Syrjälä
On Wed, Jun 08, 2022 at 10:50:42AM +0300, Jani Nikula wrote: > Rewrite edid_filter_invalid_blocks() to filter invalid blocks > in-place. The main motivation is to not rely on passed in information on > invalid block count or the allocation size, which will be helpful in > follow-up work on HF-EEODB

Re: [Intel-gfx] [PATCH v2 11/15] drm/i915/bios: convert intel_bios_init_panel() to drm_edid

2022-06-10 Thread Ville Syrjälä
On Wed, Jun 08, 2022 at 10:50:41AM +0300, Jani Nikula wrote: > Try to use struct drm_edid where possible, even if having to fall back > to looking into struct edid down low via drm_edid_raw(). > > Signed-off-by: Jani Nikula Reviewed-by: Ville Syrjälä > --- > drivers/gpu/drm/i915/display/intel

Re: [Intel-gfx] [PATCH v2 09/15] drm/edid: add drm_edid_raw() to access the raw EDID data

2022-06-10 Thread Ville Syrjälä
On Wed, Jun 08, 2022 at 10:50:39AM +0300, Jani Nikula wrote: > Unfortunately, there are still plenty of interfaces around that require > a struct edid pointer, and it's impossible to change them all at > once. Add an accessor to the raw EDID data to help the transition. > > While there are no such

Re: [Intel-gfx] [PATCH v2 10/15] drm/i915/edid: convert DP, HDMI and LVDS to drm_edid

2022-06-10 Thread Ville Syrjälä
On Wed, Jun 08, 2022 at 10:50:40AM +0300, Jani Nikula wrote: > Convert all the connectors that use cached connector edid and > detect_edid to drm_edid. > > Signed-off-by: Jani Nikula > --- > .../gpu/drm/i915/display/intel_connector.c| 4 +- > .../drm/i915/display/intel_display_types.h|

Re: [Intel-gfx] [PATCH v2 06/15] drm/edid: add drm_edid_connector_update()

2022-06-10 Thread Ville Syrjälä
On Wed, Jun 08, 2022 at 10:50:36AM +0300, Jani Nikula wrote: > Add a new function drm_edid_connector_update() to replace the > combination of calls drm_connector_update_edid_property() and > drm_add_edid_modes(). Usually they are called in the drivers in this > order, however the former needs infor

Re: [Intel-gfx] [PATCH v2 02/15] drm/edid: abstract cea data block collection size

2022-06-10 Thread Ville Syrjälä
On Wed, Jun 08, 2022 at 10:50:32AM +0300, Jani Nikula wrote: > Add a function to get the cea data block collection size. > > Cc: Ville Syrjälä > Signed-off-by: Jani Nikula Reviewed-by: Ville Syrjälä > --- > drivers/gpu/drm/drm_edid.c | 24 +--- > 1 file changed, 21 insert

Re: [Intel-gfx] [PATCH v2 01/15] drm/edid: fix CTA data block collection size for CTA version 3

2022-06-10 Thread Ville Syrjälä
On Wed, Jun 08, 2022 at 10:50:31AM +0300, Jani Nikula wrote: > The CTA Data Block Collection is valid only for CTA extension version > 3. In versions 1 and 2, it is a reserved block, which we ignore. > > The DTD start offset (byte 2, or d in CTA-861 spec), which determines > the CTA Data Block Col

Re: [Intel-gfx] [PATCH v7] drm/i915/display: disable HPD workers before display driver unregister

2022-06-10 Thread Ville Syrjälä
On Fri, Jun 10, 2022 at 06:00:24PM +0200, Andrzej Hajda wrote: > Handling HPD during driver removal is pointless, and can cause different > use-after-free/concurrency issues: > 1. Setup of deferred fbdev after fbdev unregistration. > 2. Access to DP-AUX after DP-AUX removal. > > Below stacktraces

Re: [Intel-gfx] [PATCH 3/3] drm/i915/bios: split ddi port parsing and debug printing

2022-06-10 Thread Ville Syrjälä
On Fri, Jun 10, 2022 at 05:10:27PM +0300, Jani Nikula wrote: > Split ddi port parsing and debug printing to clarify the functional > parts of parse_ddi_port(), which are quite small nowadays. > > Signed-off-by: Jani Nikula > --- > drivers/gpu/drm/i915/display/intel_bios.c | 65 +-

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/display: disable HPD workers before display driver unregister (rev9)

2022-06-10 Thread Patchwork
== Series Details == Series: drm/i915/display: disable HPD workers before display driver unregister (rev9) URL : https://patchwork.freedesktop.org/series/103811/ State : success == Summary == CI Bug Log - changes from CI_DRM_11753 -> Patchwork_103811v9

Re: [Intel-gfx] [PATCH 2/3] drm/i915: Fix i915_vma_pin_iomap()

2022-06-10 Thread Matthew Auld
On Fri, 10 Jun 2022 at 15:53, Matthew Auld wrote: > > On Fri, 10 Jun 2022 at 13:12, Juha-Pekka Heikkila > wrote: > > > > From: CQ Tang > > > > Display might allocate a smem object and call > > i915_vma_pin_iomap(), the existing code will fail. > > > > This fix was suggested by Chris P Wilson, th

Re: [Intel-gfx] [RFC v3 1/3] drm/doc/rfc: VM_BIND feature design document

2022-06-10 Thread Niranjana Vishwanathapura
On Fri, Jun 10, 2022 at 11:18:14AM +0300, Lionel Landwerlin wrote: On 10/06/2022 10:54, Niranjana Vishwanathapura wrote: On Fri, Jun 10, 2022 at 09:53:24AM +0300, Lionel Landwerlin wrote: On 09/06/2022 22:31, Niranjana Vishwanathapura wrote: On Thu, Jun 09, 2022 at 05:49:09PM +0300, Lionel Lan

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/bios: minor cleanups

2022-06-10 Thread Patchwork
== Series Details == Series: drm/i915/bios: minor cleanups URL : https://patchwork.freedesktop.org/series/104988/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11753 -> Patchwork_104988v1 Summary --- **FAILURE** S

Re: [Intel-gfx] [PATCH] iosys-map: Add word-sized reads

2022-06-10 Thread Lucas De Marchi
On Fri, Jun 10, 2022 at 09:20:18AM +0200, Christian König wrote: Am 10.06.22 um 01:20 schrieb Lucas De Marchi: Instead of always falling back to memcpy_fromio() for any size, prefer using read{b,w,l}(). When reading struct members it's common to read individual integer variables individually. Go

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/3] drm/i915/display: Add smem fallback allocation for dpt

2022-06-10 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915/display: Add smem fallback allocation for dpt URL : https://patchwork.freedesktop.org/series/104983/ State : success == Summary == CI Bug Log - changes from CI_DRM_11753 -> Patchwork_104983v1

[Intel-gfx] ✓ Fi.CI.BAT: success for Disable connector polling for a headless sku (rev3)

2022-06-10 Thread Patchwork
== Series Details == Series: Disable connector polling for a headless sku (rev3) URL : https://patchwork.freedesktop.org/series/104711/ State : success == Summary == CI Bug Log - changes from CI_DRM_11753 -> Patchwork_104711v3 Summary -

Re: [Intel-gfx] [PATCH v2] drm/i915/bios: calculate panel type as per child device index in VBT

2022-06-10 Thread Ville Syrjälä
On Fri, Jun 10, 2022 at 01:54:12PM +0300, Jani Nikula wrote: > On Thu, 09 Jun 2022, Animesh Manna wrote: > > Each LFP may have different panel type which is stored in LFP data > > data block. Based on the child device index respective panel-type/ > > panel-type2 field will be used. > > > > v1: Ini

Re: [Intel-gfx] [PATCH 2/3] drm/i915: Update i915 uapi documentation

2022-06-10 Thread Niranjana Vishwanathapura
On Fri, Jun 10, 2022 at 12:01:24PM +0100, Matthew Auld wrote: On 10/06/2022 08:07, Niranjana Vishwanathapura wrote: Add some missing i915 upai documentation which the new i915 VM_BIND feature documentation will be refer to. Signed-off-by: Niranjana Vishwanathapura Reviewed-by: Matthew Auld

Re: [Intel-gfx] [PATCH 3/3] drm/doc/rfc: VM_BIND uapi definition

2022-06-10 Thread Niranjana Vishwanathapura
On Fri, Jun 10, 2022 at 01:56:58AM -0700, Matthew Brost wrote: On Fri, Jun 10, 2022 at 01:53:40AM -0700, Matthew Brost wrote: On Fri, Jun 10, 2022 at 12:07:11AM -0700, Niranjana Vishwanathapura wrote: > VM_BIND and related uapi definitions > > Signed-off-by: Niranjana Vishwanathapura > --- > D

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/3] drm/i915/display: Add smem fallback allocation for dpt

2022-06-10 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915/display: Add smem fallback allocation for dpt URL : https://patchwork.freedesktop.org/series/104983/ State : warning == Summary == Error: dim checkpatch failed d360b10b6a41 drm/i915/display: Add smem fallback allocation for dpt

Re: [Intel-gfx] [PATCH 3/3] drm/doc/rfc: VM_BIND uapi definition

2022-06-10 Thread Niranjana Vishwanathapura
On Fri, Jun 10, 2022 at 05:48:39PM +0300, Lionel Landwerlin wrote: On 10/06/2022 13:37, Tvrtko Ursulin wrote: On 10/06/2022 08:07, Niranjana Vishwanathapura wrote: VM_BIND and related uapi definitions Signed-off-by: Niranjana Vishwanathapura ---   Documentation/gpu/rfc/i915_vm_bind.h | 490

[Intel-gfx] [PATCH v7] drm/i915/display: disable HPD workers before display driver unregister

2022-06-10 Thread Andrzej Hajda
Handling HPD during driver removal is pointless, and can cause different use-after-free/concurrency issues: 1. Setup of deferred fbdev after fbdev unregistration. 2. Access to DP-AUX after DP-AUX removal. Below stacktraces of both cases observed on CI: [272.634530] general protection fault, proba

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Disable connector polling for a headless sku (rev3)

2022-06-10 Thread Patchwork
== Series Details == Series: Disable connector polling for a headless sku (rev3) URL : https://patchwork.freedesktop.org/series/104711/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] How to convert drivers/gpu/drm/i915/ to use local workqueue?

2022-06-10 Thread Tetsuo Handa
Hello. Like commit c4f135d643823a86 ("workqueue: Wrap flush_workqueue() using a macro") explains, we are removing flush_scheduled_work() calls. And now drivers/gpu/drm/i915/display/intel_display.c drivers/gpu/drm/i915/gt/selftest_execlists.c are the last flush_scheduled_work() callers which

[Intel-gfx] ✗ Fi.CI.BUILD: failure for drm/doc/rfc: i915 VM_BIND feature design + uapi

2022-06-10 Thread Patchwork
== Series Details == Series: drm/doc/rfc: i915 VM_BIND feature design + uapi URL : https://patchwork.freedesktop.org/series/104962/ State : failure == Summary == Error: make failed CALLscripts/checksyscalls.sh CALLscripts/atomic/check-atomics.sh DESCEND objtool CHK include/

Re: [Intel-gfx] [PATCH 2/3] drm/i915: Fix i915_vma_pin_iomap()

2022-06-10 Thread Matthew Auld
On Fri, 10 Jun 2022 at 13:12, Juha-Pekka Heikkila wrote: > > From: CQ Tang > > Display might allocate a smem object and call > i915_vma_pin_iomap(), the existing code will fail. > > This fix was suggested by Chris P Wilson, that we pin > the smem with i915_gem_object_pin_map_unlocked(). > > v2 (j

Re: [Intel-gfx] [PATCH 3/3] drm/doc/rfc: VM_BIND uapi definition

2022-06-10 Thread Lionel Landwerlin
On 10/06/2022 13:37, Tvrtko Ursulin wrote: On 10/06/2022 08:07, Niranjana Vishwanathapura wrote: VM_BIND and related uapi definitions Signed-off-by: Niranjana Vishwanathapura ---   Documentation/gpu/rfc/i915_vm_bind.h | 490 +++   1 file changed, 490 insertions(+)   c

Re: [Intel-gfx] [PATCH 1/3] drm/i915/display: Add smem fallback allocation for dpt

2022-06-10 Thread Matthew Auld
On Fri, 10 Jun 2022 at 13:12, Juha-Pekka Heikkila wrote: > > Add fallback smem allocation for dpt if stolen memory > allocation failed. > > Signed-off-by: Juha-Pekka Heikkila Reviewed-by: Matthew Auld

Re: [Intel-gfx] [PATCH 3/3] drm/i915: don't leak lmem mapping in vma_evict

2022-06-10 Thread Matthew Auld
On Fri, 10 Jun 2022 at 13:12, Juha-Pekka Heikkila wrote: > > Don't leak lmem mapping in vma_evict, move __i915_vma_iounmap outside > i915_vma_is_map_and_fenceable > > Signed-off-by: Juha-Pekka Heikkila Reviewed-by: Matthew Auld

Re: [Intel-gfx] [PATCH] iosys-map: Add word-sized reads

2022-06-10 Thread kernel test robot
Hi Lucas, Thank you for the patch! Yet something to improve: [auto build test ERROR on drm-tip/drm-tip] [also build test ERROR on linus/master v5.19-rc1 next-20220610] [cannot apply to tegra-drm/drm/tegra/for-next] [If your patch is applied to the wrong git tree, kindly drop us a note. And when

[Intel-gfx] [PATCH 2/3] drm/i915/bios: no need to pass i915 to parse_ddi_port()

2022-06-10 Thread Jani Nikula
i915 is available via devdata, grab it there instead of passing. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_bios.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_bios.c b/drivers/gpu/drm/i915/display/intel_bios

[Intel-gfx] [PATCH 3/3] drm/i915/bios: split ddi port parsing and debug printing

2022-06-10 Thread Jani Nikula
Split ddi port parsing and debug printing to clarify the functional parts of parse_ddi_port(), which are quite small nowadays. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_bios.c | 65 +-- 1 file changed, 37 insertions(+), 28 deletions(-) diff --git a/dr

[Intel-gfx] [PATCH 1/3] drm/i915/bios: use dvi and hdmi support helpers

2022-06-10 Thread Jani Nikula
Improve clarity by using the helpers we have. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_bios.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_bios.c b/drivers/gpu/drm/i915/display/intel_bios.c index aaea27fe5d16

[Intel-gfx] [PATCH 0/3] drm/i915/bios: minor cleanups

2022-06-10 Thread Jani Nikula
Just a few cleanups. Jani Nikula (3): drm/i915/bios: use dvi and hdmi support helpers drm/i915/bios: no need to pass i915 to parse_ddi_port() drm/i915/bios: split ddi port parsing and debug printing drivers/gpu/drm/i915/display/intel_bios.c | 73 +-- 1 file changed, 41

[Intel-gfx] [PATCH 3/3] drm/i915: don't leak lmem mapping in vma_evict

2022-06-10 Thread Juha-Pekka Heikkila
Don't leak lmem mapping in vma_evict, move __i915_vma_iounmap outside i915_vma_is_map_and_fenceable Signed-off-by: Juha-Pekka Heikkila --- drivers/gpu/drm/i915/i915_vma.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_vma.c b/drivers/gpu/drm/i915

[Intel-gfx] [PATCH 1/3] drm/i915/display: Add smem fallback allocation for dpt

2022-06-10 Thread Juha-Pekka Heikkila
Add fallback smem allocation for dpt if stolen memory allocation failed. Signed-off-by: Juha-Pekka Heikkila --- drivers/gpu/drm/i915/display/intel_dpt.c | 16 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_dpt.c b/drivers/gpu/d

[Intel-gfx] [PATCH 2/3] drm/i915: Fix i915_vma_pin_iomap()

2022-06-10 Thread Juha-Pekka Heikkila
From: CQ Tang Display might allocate a smem object and call i915_vma_pin_iomap(), the existing code will fail. This fix was suggested by Chris P Wilson, that we pin the smem with i915_gem_object_pin_map_unlocked(). v2 (jheikkil): Change i915_gem_object_pin_map_unlocked to i915_ge

Re: [Intel-gfx] [PATCH 2/3] drm/i915: Update i915 uapi documentation

2022-06-10 Thread Matthew Auld
On 10/06/2022 08:07, Niranjana Vishwanathapura wrote: Add some missing i915 upai documentation which the new i915 VM_BIND feature documentation will be refer to. Signed-off-by: Niranjana Vishwanathapura Reviewed-by: Matthew Auld This one looks to be standalone. If no objections should we go

Re: [Intel-gfx] [PATCH v2] drm/i915/bios: calculate panel type as per child device index in VBT

2022-06-10 Thread Jani Nikula
On Thu, 09 Jun 2022, Animesh Manna wrote: > Each LFP may have different panel type which is stored in LFP data > data block. Based on the child device index respective panel-type/ > panel-type2 field will be used. > > v1: Initial rfc verion. > v2: Based on review comments from Jani, > - Used panel

Re: [Intel-gfx] [PATCH 3/3] drm/doc/rfc: VM_BIND uapi definition

2022-06-10 Thread Tvrtko Ursulin
On 10/06/2022 08:07, Niranjana Vishwanathapura wrote: VM_BIND and related uapi definitions Signed-off-by: Niranjana Vishwanathapura --- Documentation/gpu/rfc/i915_vm_bind.h | 490 +++ 1 file changed, 490 insertions(+) create mode 100644 Documentation/gpu/rfc/i915_

Re: [Intel-gfx] [RFC v3 3/3] drm/doc/rfc: VM_BIND uapi definition

2022-06-10 Thread Matthew Auld
On 10/06/2022 11:16, Tvrtko Ursulin wrote: On 09/06/2022 19:53, Niranjana Vishwanathapura wrote: On Thu, Jun 09, 2022 at 09:36:48AM +0100, Matthew Auld wrote: On 08/06/2022 22:32, Niranjana Vishwanathapura wrote: On Wed, Jun 08, 2022 at 10:12:05AM +0100, Matthew Auld wrote: On 08/06/2022 08:

Re: [Intel-gfx] [PATCH i-g-t] i915/gem_exec_balancer: fix parallel_ordering with no-reloc

2022-06-10 Thread Das, Nirmoy
wrong mailing list, Ignore this. On 6/10/2022 12:20 PM, Nirmoy Das wrote: Make sure to allocate ahnd so that spinner starts with no-reloc execbuf otherwise this will fail on platforms with relocation disabled. Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/6117 Signed-off-by: Nirmoy

[Intel-gfx] [PATCH i-g-t] i915/gem_exec_balancer: fix parallel_ordering with no-reloc

2022-06-10 Thread Nirmoy Das
Make sure to allocate ahnd so that spinner starts with no-reloc execbuf otherwise this will fail on platforms with relocation disabled. Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/6117 Signed-off-by: Nirmoy Das --- tests/i915/gem_exec_balancer.c | 3 +++ 1 file changed, 3 insertion

Re: [Intel-gfx] [PATCH i-g-t] tests/kms_async_flips: first async flip discarded on i915

2022-06-10 Thread Karthik B S
On 6/10/2022 1:18 PM, Arun R Murthy wrote: The i915 KMD will use the first async flip to update the watermarks as per the watermark optimization in DISPLAY13. Hence the actual async flip will happen from the subsequent flips. For alternate sync async test, a dummy async flip has to be done to all

Re: [Intel-gfx] [RFC v3 3/3] drm/doc/rfc: VM_BIND uapi definition

2022-06-10 Thread Tvrtko Ursulin
On 09/06/2022 19:53, Niranjana Vishwanathapura wrote: On Thu, Jun 09, 2022 at 09:36:48AM +0100, Matthew Auld wrote: On 08/06/2022 22:32, Niranjana Vishwanathapura wrote: On Wed, Jun 08, 2022 at 10:12:05AM +0100, Matthew Auld wrote: On 08/06/2022 08:17, Tvrtko Ursulin wrote: On 07/06/2022 2

Re: [Intel-gfx] linux-next: build failure after merge of the drm-misc tree

2022-06-10 Thread Javier Martinez Canillas
Hello Stephen, On 6/10/22 06:49, Stephen Rothwell wrote: > Hi all, > > After merging the drm-misc tree, today's linux-next build (powerpc > allyesconfig) failed like this: > > drivers/firmware/efi/sysfb_efi.c:29:10: fatal error: asm/efi.h: No such file > or directory >29 | #include >

Re: [Intel-gfx] [PATCH 3/3] drm/doc/rfc: VM_BIND uapi definition

2022-06-10 Thread Matthew Brost
On Fri, Jun 10, 2022 at 01:53:40AM -0700, Matthew Brost wrote: > On Fri, Jun 10, 2022 at 12:07:11AM -0700, Niranjana Vishwanathapura wrote: > > VM_BIND and related uapi definitions > > > > Signed-off-by: Niranjana Vishwanathapura > > > > --- > > Documentation/gpu/rfc/i915_vm_bind.h | 490 ++

Re: [Intel-gfx] [PATCH 3/3] drm/doc/rfc: VM_BIND uapi definition

2022-06-10 Thread Matthew Brost
On Fri, Jun 10, 2022 at 12:07:11AM -0700, Niranjana Vishwanathapura wrote: > VM_BIND and related uapi definitions > > Signed-off-by: Niranjana Vishwanathapura > --- > Documentation/gpu/rfc/i915_vm_bind.h | 490 +++ > 1 file changed, 490 insertions(+) > create mode 100644

[Intel-gfx] [PATCH v3 3/3] drm/i915: Do not start connector polling on headless sku

2022-06-10 Thread Jouni Högander
Connector polling is waking up the polled device. Polling is unnecessary if our device is known to not have display. Fix this and save some power by disabling starting connector polling when we are having headless sku. Use information from opregion. v2: Move headless sku check into INTEL_DISPLAY_

[Intel-gfx] [PATCH v3 0/3] Disable connector polling for a headless sku

2022-06-10 Thread Jouni Högander
This patch set disables connector polling when entering runtime suspend for headless sku to prevent waking it up again when poll is performed. v3: - dummy intel_opregion_headless_sku is now static inline v2: - integrate headless check into INTEL_DISPLAY_ENABLED Cc: Jani Nikula Cc: José Roberto

[Intel-gfx] [PATCH v3 2/3] drm/i915: Do not start connector polling if display is disabled

2022-06-10 Thread Jouni Högander
Currently we are starting connector polling if display is disabled using disable_display module parameter. Polling is just returning always "not connected" state. This can be optimized by not starting polling at all. Signed-off-by: Jouni Högander Reviewed-by: Jani Nikula --- drivers/gpu/drm/i91

[Intel-gfx] [PATCH v3 1/3] drm/i915/opregion: add function to check if headless sku

2022-06-10 Thread Jouni Högander
Export headless sku bit (bit 13) from opregion->header->pcon as an interface to check if our device is headless configuration. This is mainly targeted for hybrid gfx systems. E.g. when display is not supposed to be connected discrete graphics card it's opregion can inform this is headless graphics

Re: [Intel-gfx] [RFC v3 3/3] drm/doc/rfc: VM_BIND uapi definition

2022-06-10 Thread Matthew Brost
On Tue, May 17, 2022 at 11:32:12AM -0700, Niranjana Vishwanathapura wrote: > VM_BIND and related uapi definitions > > v2: Ensure proper kernel-doc formatting with cross references. > Also add new uapi and documentation as per review comments > from Daniel. > > Signed-off-by: Niranjana Vis

Re: [Intel-gfx] [RFC v3 1/3] drm/doc/rfc: VM_BIND feature design document

2022-06-10 Thread Lionel Landwerlin
On 10/06/2022 10:54, Niranjana Vishwanathapura wrote: On Fri, Jun 10, 2022 at 09:53:24AM +0300, Lionel Landwerlin wrote: On 09/06/2022 22:31, Niranjana Vishwanathapura wrote: On Thu, Jun 09, 2022 at 05:49:09PM +0300, Lionel Landwerlin wrote:   On 09/06/2022 00:55, Jason Ekstrand wrote:     On

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/reset: Add additional steps for Wa_22011802037 for execlist backend (rev2)

2022-06-10 Thread Patchwork
== Series Details == Series: drm/i915/reset: Add additional steps for Wa_22011802037 for execlist backend (rev2) URL : https://patchwork.freedesktop.org/series/103837/ State : success == Summary == CI Bug Log - changes from CI_DRM_11750 -> Patchwork_103837v2 ==

Re: [Intel-gfx] [PATCH v2 1/3] drm/i915/opregion: add function to check if headless sku

2022-06-10 Thread Jani Nikula
On Fri, 10 Jun 2022, Jouni Högander wrote: > Export headless sku bit (bit 13) from opregion->header->pcon as an > interface to check if our device is headless configuration. > > This is mainly targeted for hybrid gfx systems. E.g. when display > is not supposed to be connected discrete graphics ca

[Intel-gfx] ✓ Fi.CI.BAT: success for HuC loading for DG2

2022-06-10 Thread Patchwork
== Series Details == Series: HuC loading for DG2 URL : https://patchwork.freedesktop.org/series/104949/ State : success == Summary == CI Bug Log - changes from CI_DRM_11750 -> Patchwork_104949v1 Summary --- **SUCCESS** No regressi

Re: [Intel-gfx] [RFC v3 1/3] drm/doc/rfc: VM_BIND feature design document

2022-06-10 Thread Niranjana Vishwanathapura
On Fri, Jun 10, 2022 at 09:53:24AM +0300, Lionel Landwerlin wrote: On 09/06/2022 22:31, Niranjana Vishwanathapura wrote: On Thu, Jun 09, 2022 at 05:49:09PM +0300, Lionel Landwerlin wrote:   On 09/06/2022 00:55, Jason Ekstrand wrote:     On Wed, Jun 8, 2022 at 4:44 PM Niranjana Vishwanathapura

[Intel-gfx] [PATCH i-g-t] tests/kms_async_flips: first async flip discarded on i915

2022-06-10 Thread Arun R Murthy
The i915 KMD will use the first async flip to update the watermarks as per the watermark optimization in DISPLAY13. Hence the actual async flip will happen from the subsequent flips. For alternate sync async test, a dummy async flip has to be done to allow the KMD to perform the watermark related u

Re: [Intel-gfx] [PATCH 1/2] drm/i915/opregion: add function to check if headless sku

2022-06-10 Thread Hogander, Jouni
On Mon, 2022-06-06 at 13:15 +, Souza, Jose wrote: > On Mon, 2022-06-06 at 11:16 +0300, Jani Nikula wrote: > > On Mon, 06 Jun 2022, "Hogander, Jouni" > > wrote: > > > On Fri, 2022-06-03 at 16:32 +, Souza, Jose wrote: > > > > On Fri, 2022-06-03 at 13:14 +, Hogander, Jouni wrote: > > > >

[Intel-gfx] [PATCH v2 3/3] drm/i915: Do not start connector polling on headless sku

2022-06-10 Thread Jouni Högander
Connector polling is waking up the polled device. Polling is unnecessary if our device is known to not have display. Fix this and save some power by disabling starting connector polling when we are having headless sku. Use information from opregion. v2: Move headless sku check into INTEL_DISPLAY_

[Intel-gfx] [PATCH v2 2/3] drm/i915: Do not start connector polling if display is disabled

2022-06-10 Thread Jouni Högander
Currently we are starting connector polling if display is disabled using disable_display module parameter. Polling is just returning always "not connected" state. This can be optimized by not starting polling at all. Signed-off-by: Jouni Högander --- drivers/gpu/drm/i915/display/intel_hotplug.c

[Intel-gfx] [PATCH v2 1/3] drm/i915/opregion: add function to check if headless sku

2022-06-10 Thread Jouni Högander
Export headless sku bit (bit 13) from opregion->header->pcon as an interface to check if our device is headless configuration. This is mainly targeted for hybrid gfx systems. E.g. when display is not supposed to be connected discrete graphics card it's opregion can inform this is headless graphics

[Intel-gfx] [PATCH v2 0/3] Disable connector polling for a headless sku

2022-06-10 Thread Jouni Högander
This patch set disables connector polling when entering runtime suspend for headless sku to prevent waking it up again when poll is performed. v2: - integrate headless check into INTEL_DISPLAY_ENABLED Cc: Jani Nikula Cc: José Roberto de Souza Cc: Imre Deak Cc: Anshuman Gupta Jouni Högander

[Intel-gfx] [PATCH 0/3] drm/doc/rfc: i915 VM_BIND feature design + uapi

2022-06-10 Thread Niranjana Vishwanathapura
This is the i915 driver VM_BIND feature design RFC patch series along with the required uapi definition and description of intended use cases. This series is an updated version of the below RFC series. It address the review feedback by adding execbuf3 ioctl for vm_bind, adding multiple queues supp

[Intel-gfx] [PATCH 3/3] drm/doc/rfc: VM_BIND uapi definition

2022-06-10 Thread Niranjana Vishwanathapura
VM_BIND and related uapi definitions Signed-off-by: Niranjana Vishwanathapura --- Documentation/gpu/rfc/i915_vm_bind.h | 490 +++ 1 file changed, 490 insertions(+) create mode 100644 Documentation/gpu/rfc/i915_vm_bind.h diff --git a/Documentation/gpu/rfc/i915_vm_bind.h

[Intel-gfx] [PATCH 2/3] drm/i915: Update i915 uapi documentation

2022-06-10 Thread Niranjana Vishwanathapura
Add some missing i915 upai documentation which the new i915 VM_BIND feature documentation will be refer to. Signed-off-by: Niranjana Vishwanathapura --- include/uapi/drm/i915_drm.h | 203 1 file changed, 158 insertions(+), 45 deletions(-) diff --git a/includ

[Intel-gfx] [PATCH 1/3] drm/doc/rfc: VM_BIND feature design document

2022-06-10 Thread Niranjana Vishwanathapura
VM_BIND design document with description of intended use cases. Signed-off-by: Niranjana Vishwanathapura --- Documentation/driver-api/dma-buf.rst | 2 + Documentation/gpu/rfc/i915_vm_bind.rst | 309 + Documentation/gpu/rfc/index.rst| 4 + 3 files changed, 31

[Intel-gfx] ✓ Fi.CI.BAT: success for iosys-map: Add word-sized reads

2022-06-10 Thread Patchwork
== Series Details == Series: iosys-map: Add word-sized reads URL : https://patchwork.freedesktop.org/series/104947/ State : success == Summary == CI Bug Log - changes from CI_DRM_11750 -> Patchwork_104947v1 Summary --- **SUCCESS**