[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [CI,1/2] iosys-map: Add per-word read (rev2)

== Series Details == Series: series starting with [CI,1/2] iosys-map: Add per-word read (rev2) URL : https://patchwork.freedesktop.org/series/105746/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

Re: [Intel-gfx] [PATCH 2/2] drm/i915/fbdev: suspend HPD before fbdev unregistration

> void intel_fbdev_unregister(struct drm_i915_private *dev_priv) { > struct intel_fbdev *ifbdev = dev_priv->fbdev; @@ -573,6 +594,8 @@ > void intel_fbdev_unregister(struct drm_i915_private *dev_priv) > if (!ifbdev) > return; > > +

Re: [Intel-gfx] [PATCH] drm/i915/reset: Handle reset timeouts under unrelated kernel hangs

On Tue, 28 Jun 2022 12:17:41 -0700, Ashutosh Dixit wrote: > > From: Chris Wilson > > When resuming after hibernate sometimes we see hangs in unrelated kernel > subsystems. These hangs often result in the following i915 trace: > > i915 :00:02.0: [drm] \ > *ERROR* intel_gt_reset_global

Re: [Intel-gfx] [Linaro-mm-sig] [PATCH] drm/i915: Remove __dma_fence_is_chain()

On 6/29/22 01:35, Rob Clark wrote: From: Rob Clark drive-by cleanup Signed-off-by: Rob Clark Reviewed-by: Thomas Hellström --- drivers/gpu/drm/i915/gem/i915_gem_wait.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git

Re: [Intel-gfx] [PATCH] drm/i915/dp: Check for Low voltage IO only for eDP

> On 6/29/2022 8:55 AM, Murthy, Arun R wrote: > >> - if (intel_dp_is_edp(intel_dp) || is_low_voltage_sku(dev_priv, phy)) > >> + if (intel_dp_is_edp(intel_dp)) > >>return 54; > > Shouldn't the low voltage check be for both eDP and is low voltage sku? > > For JSP/EHL there is SOC

Re: [Intel-gfx] [PATCH] drm/i915/dp: Check for Low voltage IO only for eDP

Hi Arun, Thanks for the comments. Please find my response inline: On 6/29/2022 8:55 AM, Murthy, Arun R wrote: - if (intel_dp_is_edp(intel_dp) || is_low_voltage_sku(dev_priv, phy)) + if (intel_dp_is_edp(intel_dp)) return 54; Shouldn't the low voltage check be

Re: [Intel-gfx] [PATCH 1/2] drm/i915/hpd: postpone HPD cancel work after last user suspension

> -Original Message- > From: Intel-gfx On Behalf Of > Andrzej Hajda > Sent: Thursday, June 23, 2022 10:08 PM > To: Jani Nikula ; Ville Syrjälä > > Cc: Hajda, Andrzej ; intel- > g...@lists.freedesktop.org; dri-de...@lists.freedesktop.org; Vivi, Rodrigo > > Subject: [Intel-gfx] [PATCH

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Remove __dma_fence_is_chain()

== Series Details == Series: drm/i915: Remove __dma_fence_is_chain() URL : https://patchwork.freedesktop.org/series/105760/ State : success == Summary == CI Bug Log - changes from CI_DRM_11822 -> Patchwork_105760v1 Summary ---

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: use DISPLAY_VER() instead of accessing match_info directly (rev2)

== Series Details == Series: drm/i915: use DISPLAY_VER() instead of accessing match_info directly (rev2) URL : https://patchwork.freedesktop.org/series/105734/ State : success == Summary == CI Bug Log - changes from CI_DRM_11822 -> Patchwork_105734v2

Re: [Intel-gfx] [PATCH] drm/i915/dp: Check for Low voltage IO only for eDP

> - if (intel_dp_is_edp(intel_dp) || is_low_voltage_sku(dev_priv, phy)) > + if (intel_dp_is_edp(intel_dp)) > return 54; Shouldn't the low voltage check be for both eDP and is low voltage sku? Thanks and Regards, Arun R Murthy

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/guc: ADL-N should use the same GuC FW as ADL-S (rev3)

== Series Details == Series: drm/i915/guc: ADL-N should use the same GuC FW as ADL-S (rev3) URL : https://patchwork.freedesktop.org/series/105444/ State : success == Summary == CI Bug Log - changes from CI_DRM_11822 -> Patchwork_105444v3

[Intel-gfx] linux-next: manual merge of the drm-misc tree with Linus' tree

Hi all, Today's linux-next merge of the drm-misc tree got a conflict in: drivers/gpu/drm/vc4/vc4_drv.c between commit: 538f6061 ("drm/vc4: drv: Register a different driver on BCM2711") from Linus' tree and commit: da8e393e23ef ("drm/vc4: drv: Adopt the dma configuration from the

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [CI,1/2] iosys-map: Add per-word read

+Lakshmi Can't see how these would be related. Searching recent failure I found this very similar one: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11814/shard-glk7/pstore24-1656384153_Oops_1.txt Lucas De Marchi On Tue, Jun 28, 2022 at 3:49 PM Patchwork wrote: > *Patch Details* > *Series:*

[Intel-gfx] [PATCH] drm/i915: Remove __dma_fence_is_chain()

From: Rob Clark drive-by cleanup Signed-off-by: Rob Clark --- drivers/gpu/drm/i915/gem/i915_gem_wait.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/gpu/drm/i915/gem/i915_gem_wait.c b/drivers/gpu/drm/i915/gem/i915_gem_wait.c index

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/reset: Handle reset timeouts under unrelated kernel hangs

== Series Details == Series: drm/i915/reset: Handle reset timeouts under unrelated kernel hangs URL : https://patchwork.freedesktop.org/series/105748/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11820 -> Patchwork_105748v1

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/reset: Handle reset timeouts under unrelated kernel hangs

== Series Details == Series: drm/i915/reset: Handle reset timeouts under unrelated kernel hangs URL : https://patchwork.freedesktop.org/series/105748/ State : warning == Summary == Error: dim checkpatch failed ac39982eb930 drm/i915/reset: Handle reset timeouts under unrelated kernel hangs

Re: [Intel-gfx] [PATCH RESEND] drm: i915: fix a possible refcount leak in intel_dp_add_mst_connector()

Ah-nevermind! Seems like someone already pushed this for you :) On Tue, 2022-06-28 at 18:55 -0400, Lyude Paul wrote: > Nice catch! > > Reviewed-by: Lyude Paul > > Will push to drm-intel-next > > On Fri, 2022-06-24 at 10:28 +0800, Hangyu Hua wrote: > > If drm_connector_init fails,

Re: [Intel-gfx] [PATCH RESEND] drm: i915: fix a possible refcount leak in intel_dp_add_mst_connector()

Nice catch! Reviewed-by: Lyude Paul Will push to drm-intel-next On Fri, 2022-06-24 at 10:28 +0800, Hangyu Hua wrote: > If drm_connector_init fails, intel_connector_free will be called to take > care of proper free. So it is necessary to drop the refcount of port > before intel_connector_free.

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [CI,1/2] iosys-map: Add per-word read

== Series Details == Series: series starting with [CI,1/2] iosys-map: Add per-word read URL : https://patchwork.freedesktop.org/series/105746/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11820 -> Patchwork_105746v1

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [CI,1/2] iosys-map: Add per-word read

== Series Details == Series: series starting with [CI,1/2] iosys-map: Add per-word read URL : https://patchwork.freedesktop.org/series/105746/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [CI,1/2] iosys-map: Add per-word read

== Series Details == Series: series starting with [CI,1/2] iosys-map: Add per-word read URL : https://patchwork.freedesktop.org/series/105746/ State : warning == Summary == Error: dim checkpatch failed 52de7a46693f iosys-map: Add per-word read -:93: ERROR:SPACING: spaces required around that

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/guc/slpc: Add a new SLPC selftest (rev5)

== Series Details == Series: drm/i915/guc/slpc: Add a new SLPC selftest (rev5) URL : https://patchwork.freedesktop.org/series/105005/ State : success == Summary == CI Bug Log - changes from CI_DRM_11820 -> Patchwork_105005v5 Summary

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: use DISPLAY_VER() instead of accessing match_info directly

== Series Details == Series: drm/i915: use DISPLAY_VER() instead of accessing match_info directly URL : https://patchwork.freedesktop.org/series/105734/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11820 -> Patchwork_105734v1

Re: [Intel-gfx] [PATCH v6 14/22] dma-buf: Introduce new locking convention

On 5/30/22 15:57, Dmitry Osipenko wrote: On 5/30/22 16:41, Christian König wrote: Hi Dmitry, Am 30.05.22 um 15:26 schrieb Dmitry Osipenko: Hello Christian, On 5/30/22 09:50, Christian König wrote: Hi Dmitry, First of all please separate out this patch from the rest of the series, since

Re: [Intel-gfx] [PATCH 2/3] drm/i915/ttm: don't overwrite cache_dirty after setting coherency

On 14/06/2022 18:55, Matthew Auld wrote: On Tue, 14 Jun 2022 at 02:14, Adrian Larumbe wrote: When i915_gem_object_set_cache_level sets the GEM object's cache_dirty to true, in the case of TTM that will sometimes be overwritten when getting the object's pages, more specifically for

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/edid: expand on struct drm_edid usage (rev7)

== Series Details == Series: drm/edid: expand on struct drm_edid usage (rev7) URL : https://patchwork.freedesktop.org/series/104309/ State : success == Summary == CI Bug Log - changes from CI_DRM_11820 -> Patchwork_104309v7 Summary ---

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/edid: expand on struct drm_edid usage (rev7)

== Series Details == Series: drm/edid: expand on struct drm_edid usage (rev7) URL : https://patchwork.freedesktop.org/series/104309/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/edid: expand on struct drm_edid usage (rev7)

== Series Details == Series: drm/edid: expand on struct drm_edid usage (rev7) URL : https://patchwork.freedesktop.org/series/104309/ State : warning == Summary == Error: dim checkpatch failed a51b7acd926d drm/edid: move drm_connector_update_edid_property() to drm_edid.c 42329ce39f03 drm/edid:

[Intel-gfx] ✗ Fi.CI.BAT: failure for Delay disabling scheduling on a context (rev2)

== Series Details == Series: Delay disabling scheduling on a context (rev2) URL : https://patchwork.freedesktop.org/series/96167/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11820 -> Patchwork_96167v2 Summary ---

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Delay disabling scheduling on a context (rev2)

== Series Details == Series: Delay disabling scheduling on a context (rev2) URL : https://patchwork.freedesktop.org/series/96167/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Delay disabling scheduling on a context (rev2)

== Series Details == Series: Delay disabling scheduling on a context (rev2) URL : https://patchwork.freedesktop.org/series/96167/ State : warning == Summary == Error: dim checkpatch failed 09acc7bdc695 drm/i915/selftests: Use correct selfest calls for live tests 2b07a6d7f9ea drm/i915/guc: Add

Re: [Intel-gfx] [PATCH v6 01/22] drm/gem: Properly annotate WW context on drm_gem_lock_reservations() error

Hi, On 5/27/22 01:50, Dmitry Osipenko wrote: Use ww_acquire_fini() in the error code paths. Otherwise lockdep thinks that lock is held when lock's memory is freed after the drm_gem_lock_reservations() error. The WW needs to be annotated as "freed" s /WW/ww_acquire_context/ ? s

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/guc: ADL-N should use the same GuC FW as ADL-S (rev2)

== Series Details == Series: drm/i915/guc: ADL-N should use the same GuC FW as ADL-S (rev2) URL : https://patchwork.freedesktop.org/series/105444/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11816_full -> Patchwork_105444v2_full

[Intel-gfx] [PATCH] drm/i915/reset: Handle reset timeouts under unrelated kernel hangs

From: Chris Wilson When resuming after hibernate sometimes we see hangs in unrelated kernel subsystems. These hangs often result in the following i915 trace: i915 :00:02.0: [drm] \ *ERROR* intel_gt_reset_global timed out, cancelling all in-flight rendering. implying our reset task

[Intel-gfx] [CI 1/2] iosys-map: Add per-word read

Instead of always falling back to memcpy_fromio() for any size, prefer using read{b,w,l}(). When reading struct members it's common to read individual integer variables individually. Going through memcpy_fromio() for each of them poses a high penalty. Employ a similar trick as __seqprop() by

[Intel-gfx] [CI 2/2] iosys-map: Add per-word write

Like was done for read, provide the equivalent for write. Even if current users are not in the hot path, this should future-proof it. v2: - Remove default from _Generic() - callers wanting to write more than u64 should use iosys_map_memcpy_to() - Add WRITE_ONCE() cases dereferencing the

Re: [Intel-gfx] [CI 1/3] drm-tip: 2022y-06m-27d-16h-18m-47s UTC integration manifest

On Tue, Jun 28, 2022 at 11:47:45AM -0700, Lucas De Marchi wrote: From: Ville Syrjälä Sorry for the noise. This should NOT be the patch 1, of course. It went here beacuse my local and remote branch were out of sync (and drm-tip/drm-tip.. then includes it) This is intended for CI, but it will

[Intel-gfx] [CI 3/3] iosys-map: Add per-word write

Like was done for read, provide the equivalent for write. Even if current users are not in the hot path, this should future-proof it. v2: - Remove default from _Generic() - callers wanting to write more than u64 should use iosys_map_memcpy_to() - Add WRITE_ONCE() cases dereferencing the

[Intel-gfx] [CI 1/3] drm-tip: 2022y-06m-27d-16h-18m-47s UTC integration manifest

From: Ville Syrjälä --- integration-manifest | 26 ++ 1 file changed, 26 insertions(+) create mode 100644 integration-manifest diff --git a/integration-manifest b/integration-manifest new file mode 100644 index ..baffa2a57cd4 --- /dev/null +++

[Intel-gfx] [CI 2/3] iosys-map: Add per-word read

Instead of always falling back to memcpy_fromio() for any size, prefer using read{b,w,l}(). When reading struct members it's common to read individual integer variables individually. Going through memcpy_fromio() for each of them poses a high penalty. Employ a similar trick as __seqprop() by

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/gt: handle null ptr at sg traversing

== Series Details == Series: drm/i915/gt: handle null ptr at sg traversing URL : https://patchwork.freedesktop.org/series/105683/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11816_full -> Patchwork_105683v1_full Summary

Re: [Intel-gfx] [PATCH][next] treewide: uapi: Replace zero-length arrays with flexible-array members

On Tue, Jun 28, 2022 at 09:27:21AM +0200, Geert Uytterhoeven wrote: > Hi Gustavo, > > Thanks for your patch! > > On Mon, Jun 27, 2022 at 8:04 PM Gustavo A. R. Silva > wrote: > > There is a regular need in the kernel to provide a way to declare > > having a dynamically sized set of trailing

Re: [Intel-gfx] [PATCH][next] treewide: uapi: Replace zero-length arrays with flexible-array members

On Mon, Jun 27, 2022 at 09:40:52PM -0300, Jason Gunthorpe wrote: > On Mon, Jun 27, 2022 at 08:27:37PM +0200, Daniel Borkmann wrote: > > [...] > > Fyi, this breaks BPF CI: > > > > https://github.com/kernel-patches/bpf/runs/7078719372?check_suite_focus=true > > > > [...] > >

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/dg2: Add performance workaround 18019455067 (rev2)

== Series Details == Series: drm/i915/dg2: Add performance workaround 18019455067 (rev2) URL : https://patchwork.freedesktop.org/series/105512/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11816_full -> Patchwork_105512v2_full

Re: [Intel-gfx] [PATCH v6 00/22] Add generic memory shrinker to VirtIO-GPU and Panfrost DRM drivers

On Tue, Jun 28, 2022 at 5:51 AM Dmitry Osipenko wrote: > > On 6/28/22 15:31, Robin Murphy wrote: > > ->8- > > [ 68.295951] == > > [ 68.295956] WARNING: possible circular locking dependency detected > > [ 68.295963] 5.19.0-rc3+ #400

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: ttm for stolen (rev5)

On 28/06/2022 09:46, Tvrtko Ursulin wrote: On 27/06/2022 18:08, Robert Beckett wrote: On 22/06/2022 10:05, Tvrtko Ursulin wrote: On 21/06/2022 20:11, Robert Beckett wrote: On 21/06/2022 18:37, Patchwork wrote: *Patch Details* *Series:*    drm/i915: ttm for stolen (rev5) *URL:*   

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/dp: wait on timeout before retry

== Series Details == Series: drm/i915/dp: wait on timeout before retry URL : https://patchwork.freedesktop.org/series/105660/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11816_full -> Patchwork_105660v1_full Summary

Re: [Intel-gfx] [PATCH 5/6] drm/i915/gt: Serialize GRDOM access between multiple engine resets

Hi, On 27/06/2022 10:00, Mauro Carvalho Chehab (by way of Mauro Carvalho Chehab ) wrote: Hi Tvrtko, On Fri, 24 Jun 2022 09:34:21 +0100 Tvrtko Ursulin wrote: On 23/06/2022 12:17, Andi Shyti wrote: Hi Mauro, On Wed, Jun 15, 2022 at 04:27:39PM +0100, Mauro Carvalho Chehab wrote: From:

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/guc/slpc: Add a new SLPC selftest (rev4)

From: Patchwork Sent: Monday, June 27, 2022 10:00 PM To: Belgaumkar, Vinay Cc: intel-gfx@lists.freedesktop.org Subject: ✗ Fi.CI.BAT: failure for drm/i915/guc/slpc: Add a new SLPC selftest (rev4) Patch Details Series: drm/i915/guc/slpc: Add a new SLPC selftest (rev4) URL:

Re: [Intel-gfx] [PATCH 01/16] drm/i915: use GRAPHICS_VER() instead of accessing match_info directly

On Thu, 23 Jun 2022, Ville Syrjälä wrote: > On Mon, Jun 20, 2022 at 11:37:40AM +0300, Jani Nikula wrote: >> We've just set up device info in i915_driver_create() so we can use >> GRAPHICS_VER() intead of looking at match_info directly. >> >> Signed-off-by: Jani Nikula >> --- >>

[Intel-gfx] [PATCH v2] drm/i915: use DISPLAY_VER() instead of accessing match_info directly

We've just set up device info in i915_driver_create() so we can use DISPLAY_VER() intead of looking at match_info directly. Semantically we want to check the display version instead of the graphics version, and for the earlier platforms they are always the same. v2: Use DISPLAY_VER() instead of

Re: [Intel-gfx] [PATCH 5/6] drm/i915/gt: Serialize GRDOM access between multiple engine resets

Hi Tvrtko, On Fri, 24 Jun 2022 09:34:21 +0100 Tvrtko Ursulin wrote: > On 23/06/2022 12:17, Andi Shyti wrote: > > Hi Mauro, > > > > On Wed, Jun 15, 2022 at 04:27:39PM +0100, Mauro Carvalho Chehab wrote: > >> From: Chris Wilson > >> > >> Don't allow two engines to be reset in parallel, as

Re: [Intel-gfx] [PATCH i-g-t 1/3] tests/i915/gem_eio: fix uaf

On 6/28/22 3:47 PM, Matthew Auld wrote: On 28/06/2022 11:24, Gwan-gyeong Mun wrote: Looks good to me. Reviewed-by: Gwan-gyeong Mun However, the use after free build issue did not occur only with the "$ meson build && ninja -C build" build command guided by the igt README.md. How did you

Re: [Intel-gfx] [PATCH v3 3/3] drm/doc/rfc: VM_BIND uapi definition

Thanks, Oak > -Original Message- > From: Tvrtko Ursulin > Sent: June 28, 2022 4:58 AM > To: Zeng, Oak ; Landwerlin, Lionel G > ; Vishwanathapura, Niranjana > > Cc: Zanoni, Paulo R ; intel- > g...@lists.freedesktop.org; dri-de...@lists.freedesktop.org; Hellstrom, > Thomas ; Wilson,

[Intel-gfx] [PATCH i-g-t 3/3] tests/amdgpu/amdgpu_command_submission: fix uaf

../lib/amdgpu/amd_command_submission.c: In function ‘amdgpu_command_submission_write_linear_helper’: ../lib/amdgpu/amd_command_submission.c:201:13: warning: pointer ‘ring_context’ used after ‘free’ [-Wuse-after-free] 201 | r = amdgpu_cs_ctx_free(ring_context->context_handle); |

[Intel-gfx] [PATCH i-g-t 2/3] tests/kms_cursor_crc: fix truncated warning

Looks reasonable to just increase the size of 'name' to avoid the potential truncation: ../tests/kms_cursor_crc.c: In function ‘run_size_tests.constprop’: ../tests/kms_cursor_crc.c:699:50: warning: ‘%d’ directive output may be truncated writing between 1 and 11 bytes into a region of size

[Intel-gfx] [PATCH i-g-t 1/3] lib/igt_device_scan: fix dangling pointer

It looks like the linkto is out of scope: ../lib/igt_device_scan.c: In function ‘igt_device_add_attr’: ../lib/igt_device_scan.c:368:57: warning: dangling pointer ‘v’ to ‘linkto’ may be used [-Wdangling-pointer=] 368 | g_hash_table_insert(dev->attrs_ht, strdup(key), strdup(v)); |

Re: [Intel-gfx] [PATCH i-g-t 1/3] tests/i915/gem_eio: fix uaf

On 28/06/2022 11:24, Gwan-gyeong Mun wrote: Looks good to me. Reviewed-by: Gwan-gyeong Mun However, the use after free build issue did not occur only with the "$ meson build && ninja -C build" build command guided by the igt README.md. How did you check it? Hmm, I assume it's just a

Re: [Intel-gfx] [PATCH i-g-t 2/3] tests/i915/kms_mmap_write_crc: handle missing gem_get_caching()

Looks good to me. Reviewed-by: Gwan-gyeong Mun On 6/27/22 7:10 PM, Matthew Auld wrote: The kernel is meant to force the caching level for the object to CACHE_NONE or CACHE_WT when first scanning out the object, since the display engine is not coherent (assuming userspace hasn't already done

Re: [Intel-gfx] [PATCH] drm/fourcc: Document the Intel CCS modifiers' CC plane expected pitch

On Sat, Jun 25, 2022 at 12:38:50AM +0300, Chery, Nanley G wrote: > +Jordan (FYI) > > I think the commit message has an extra "color" next to "CC". IIUC, i915 calls all the planes contained in a framebuffer "color planes" for consistency (so main-, aux-, CC color planes). > With or without that

[Intel-gfx] [PATCH i-g-t] tests/i915/kms_big_fb: trigger async flip with a dummy flip

In oder to trigger the async flip, a dummy flip is required after sync flip so as to update the watermarks for async in KMD which happens as part of this dummy flip. Thereafter async memory update will act as a trigger register. Capturing the CRC is done after the async flip as async flip at some

Re: [Intel-gfx] [PATCH] drm/i915: Fix error code in icl_compute_combo_phy_dpll()

On Fri, Jun 24, 2022 at 12:55:52PM +, Souza, Jose wrote: > On Fri, 2022-06-24 at 09:39 +0300, Dan Carpenter wrote: > > This function is supposed to return zero or negative error codes but it > > accidentally returns true on failure. > > Reviewed-by: José Roberto de Souza Thanks for the

Re: [Intel-gfx] [PATCH i-g-t 1/3] tests/i915/gem_eio: fix uaf

Looks good to me. Reviewed-by: Gwan-gyeong Mun However, the use after free build issue did not occur only with the "$ meson build && ninja -C build" build command guided by the igt README.md. How did you check it? Br, G.G. On 6/27/22 7:10 PM, Matthew Auld wrote:

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t 1/3] tests/i915/gem_eio: fix uaf

The series is Reviewed-by: Nirmoy Das On 6/27/2022 6:10 PM, Matthew Auld wrote: ../tests/i915/gem_eio.c:277:20: warning: pointer ‘ctx’ used after ‘free’ [-Wuse-after-free] 277 | igt_assert(igt_sysfs_printf(ctx->debugfs, "i915_drop_caches", ../lib/igt_core.h:667:20: note: in

Re: [Intel-gfx] [PATCH] drm/i915/gt: handle null ptr at sg traversing

On 2022-06-28 at 10:40:56 +0100, Matthew Auld wrote: > On 27/06/2022 18:35, Ramalingam C wrote: > > When calculating the starting address for ccs data in smem scatterlist, > > handle the NULL pointer returned from sg_next, incase of scatterlist > > less than required size.. > > Do we have some

Re: [Intel-gfx] [PATCH] drm/i915/gt: handle null ptr at sg traversing

On 27/06/2022 18:35, Ramalingam C wrote: When calculating the starting address for ccs data in smem scatterlist, handle the NULL pointer returned from sg_next, incase of scatterlist less than required size.. Do we have some more information on how we can hit this? Is this a programmer error?

Re: [Intel-gfx] [PATCH v3 3/3] drm/doc/rfc: VM_BIND uapi definition

On 27/06/2022 19:58, Zeng, Oak wrote: Thanks, Oak -Original Message- From: Tvrtko Ursulin Sent: June 27, 2022 4:30 AM To: Zeng, Oak ; Landwerlin, Lionel G ; Vishwanathapura, Niranjana Cc: Zanoni, Paulo R ; intel- g...@lists.freedesktop.org; dri-de...@lists.freedesktop.org;

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: ttm for stolen (rev5)

On 27/06/2022 18:08, Robert Beckett wrote: On 22/06/2022 10:05, Tvrtko Ursulin wrote: On 21/06/2022 20:11, Robert Beckett wrote: On 21/06/2022 18:37, Patchwork wrote: *Patch Details* *Series:*    drm/i915: ttm for stolen (rev5) *URL:*    https://patchwork.freedesktop.org/series/101396/

Re: [Intel-gfx] [PATCH][next] treewide: uapi: Replace zero-length arrays with flexible-array members

Hi Gustavo, Thanks for your patch! On Mon, Jun 27, 2022 at 8:04 PM Gustavo A. R. Silva wrote: > There is a regular need in the kernel to provide a way to declare > having a dynamically sized set of trailing elements in a structure. > Kernel code should always use “flexible array members”[1] for

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [CI,1/2] iosys-map: Add per-word read (rev2)

== Series Details == Series: series starting with [CI,1/2] iosys-map: Add per-word read (rev2) URL : https://patchwork.freedesktop.org/series/105692/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11816 -> Patchwork_105692v2