Re: [Intel-gfx] [RFC 1/1] drm/i915/dgfx: Avoid parent bridge rpm on mmap mappings

2022-08-09 Thread Gupta, Anshuman
> -Original Message- > From: Vivi, Rodrigo > Sent: Tuesday, August 9, 2022 8:36 PM > To: Gupta, Anshuman > Cc: intel-gfx@lists.freedesktop.org; dan...@ffwll.ch; Wilson, Chris P > ; dri-de...@lists.freedesktop.org > Subject: Re: [Intel-gfx] [RFC 1/1] drm/i915/dgfx: Avoid parent bridge

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/pxp: don't start pxp without mei_pxp bind (rev2)

2022-08-09 Thread Patchwork
== Series Details == Series: drm/i915/pxp: don't start pxp without mei_pxp bind (rev2) URL : https://patchwork.freedesktop.org/series/107099/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11977_full -> Patchwork_107099v2_full

Re: [Intel-gfx] [PATCH 2/2] drm/i915/hdcp: replace BIT() with REG_BIT() in register definitions

2022-08-09 Thread Murthy, Arun R
> -Original Message- > From: Intel-gfx On Behalf Of Jani > Nikula > Sent: Thursday, August 4, 2022 3:29 PM > To: intel-gfx@lists.freedesktop.org > Cc: Nikula, Jani > Subject: [Intel-gfx] [PATCH 2/2] drm/i915/hdcp: replace BIT() with REG_BIT() > in register definitions > > Registers

Re: [Intel-gfx] [PATCH 1/2] drm/i915/hdcp: split out hdcp registers to a separate file

2022-08-09 Thread Murthy, Arun R
> -Original Message- > From: Intel-gfx On Behalf Of Jani > Nikula > Sent: Thursday, August 4, 2022 3:29 PM > To: intel-gfx@lists.freedesktop.org > Cc: Nikula, Jani > Subject: [Intel-gfx] [PATCH 1/2] drm/i915/hdcp: split out hdcp registers to a > separate file > > Reduce the bloat of

Re: [Intel-gfx] [PATCH] drm/i915/d13: Fix unclaimed accesses while loading PIPEDMC-C/D

2022-08-09 Thread Murthy, Arun R
> -Original Message- > From: Intel-gfx On Behalf Of Imre > Deak > Sent: Monday, August 8, 2022 4:01 PM > To: intel-gfx@lists.freedesktop.org > Subject: [Intel-gfx] [PATCH] drm/i915/d13: Fix unclaimed accesses while > loading PIPEDMC-C/D > > At the moment on DG2 at least loading the DMC

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/display/dp_mst: Drop Radeon MST support, make MST atomic-only (rev2)

2022-08-09 Thread Patchwork
== Series Details == Series: drm/display/dp_mst: Drop Radeon MST support, make MST atomic-only (rev2) URL : https://patchwork.freedesktop.org/series/107073/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11977_full -> Patchwork_107073v2_full

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/guc/slpc: Allow SLPC to use efficient frequency

2022-08-09 Thread Patchwork
== Series Details == Series: drm/i915/guc/slpc: Allow SLPC to use efficient frequency URL : https://patchwork.freedesktop.org/series/107101/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11977 -> Patchwork_107101v1 Summary

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/pxp: don't start pxp without mei_pxp bind

2022-08-09 Thread Patchwork
== Series Details == Series: drm/i915/pxp: don't start pxp without mei_pxp bind URL : https://patchwork.freedesktop.org/series/107099/ State : success == Summary == CI Bug Log - changes from CI_DRM_11977_full -> Patchwork_107099v1_full

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/pxp: don't start pxp without mei_pxp bind (rev2)

2022-08-09 Thread Patchwork
== Series Details == Series: drm/i915/pxp: don't start pxp without mei_pxp bind (rev2) URL : https://patchwork.freedesktop.org/series/107099/ State : success == Summary == CI Bug Log - changes from CI_DRM_11977 -> Patchwork_107099v2

[Intel-gfx] [PATCH] drm/i915/guc/slpc: Allow SLPC to use efficient frequency

2022-08-09 Thread Vinay Belgaumkar
Host Turbo operates at efficient frequency when GT is not idle unless the user or workload has forced it to a higher level. Replicate the same behavior in SLPC by allowing the algorithm to use efficient frequency. We had disabled it during boot due to concerns that it might break kernel ABI for

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/display/dp_mst: Drop Radeon MST support, make MST atomic-only (rev2)

2022-08-09 Thread Patchwork
== Series Details == Series: drm/display/dp_mst: Drop Radeon MST support, make MST atomic-only (rev2) URL : https://patchwork.freedesktop.org/series/107073/ State : success == Summary == CI Bug Log - changes from CI_DRM_11977 -> Patchwork_107073v2

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/pxp: don't start pxp without mei_pxp bind

2022-08-09 Thread Patchwork
== Series Details == Series: drm/i915/pxp: don't start pxp without mei_pxp bind URL : https://patchwork.freedesktop.org/series/107099/ State : success == Summary == CI Bug Log - changes from CI_DRM_11977 -> Patchwork_107099v1 Summary

[Intel-gfx] [RFC v3] drm/display/dp_mst: Add helpers for serializing SST <-> MST transitions

2022-08-09 Thread Lyude Paul
There's another kind of situation where we could potentially race with nonblocking modesets and MST, especially if we were to only use the locking provided by atomic modesetting: * Display 1 begins as enabled on DP-1 in SST mode * Display 1 switches to MST mode, exposes one sink in MST mode *

Re: [Intel-gfx] [PATCH] drm/i915/pxp: don't start pxp without mei_pxp bind

2022-08-09 Thread Ceraolo Spurio, Daniele
On 8/9/2022 4:20 PM, Juston Li wrote: On Tue, Aug 9, 2022 at 4:10 PM Ceraolo Spurio, Daniele wrote: On 8/9/2022 3:57 PM, Juston Li wrote: pxp will not start correctly until after mei_pxp bind completes and intel_pxp_init_hw() is called. Signed-off-by: Juston Li ---

Re: [Intel-gfx] [PATCH] drm/i915/pxp: don't start pxp without mei_pxp bind

2022-08-09 Thread Juston Li
On Tue, Aug 9, 2022 at 4:10 PM Ceraolo Spurio, Daniele wrote: > > > > On 8/9/2022 3:57 PM, Juston Li wrote: > > pxp will not start correctly until after mei_pxp bind completes and > > intel_pxp_init_hw() is called. > > > > Signed-off-by: Juston Li > > --- > >

Re: [Intel-gfx] [PATCH] drm/i915/pxp: don't start pxp without mei_pxp bind

2022-08-09 Thread Ceraolo Spurio, Daniele
On 8/9/2022 3:57 PM, Juston Li wrote: pxp will not start correctly until after mei_pxp bind completes and intel_pxp_init_hw() is called. Signed-off-by: Juston Li --- drivers/gpu/drm/i915/pxp/intel_pxp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [Intel-gfx] [PATCH v5] drm/i915: stop using swiotlb

2022-08-09 Thread h...@lst.de
On Tue, Aug 09, 2022 at 12:36:50PM +0100, Tvrtko Ursulin wrote: > > Digging through git history at least running as Xen dom0 looks to have been > impacted, but commits such as abb0deacb5a6 ("drm/i915: Fallback to single > PAGE_SIZE segments for DMA remapping") are older and suggest problem was

Re: [Intel-gfx] [PATCH v5] drm/i915: stop using swiotlb

2022-08-09 Thread h...@lst.de
On Mon, Aug 08, 2022 at 03:48:02PM +, Hellstrom, Thomas wrote: > This whole thing looks a bit strange to me since with SWIOTLB actually > used for i915, the driver should malfunction anyway as it doesn't do > any dma_sync_sg_for_cpu() or dma_sync_sg_for_device(), Yeah, I can't actually see

Re: [Intel-gfx] [PATCH 21/23] drm/i915/dmc: MTL DMC debugfs entries

2022-08-09 Thread Srivatsa, Anusha
> -Original Message- > From: Intel-gfx On Behalf Of Matt > Roper > Sent: Tuesday, August 2, 2022 11:23 AM > To: Sripada, Radhakrishna > Cc: intel-gfx@lists.freedesktop.org > Subject: Re: [Intel-gfx] [PATCH 21/23] drm/i915/dmc: MTL DMC debugfs > entries > > On Wed, Jul 27, 2022 at

Re: [Intel-gfx] [PATCH 6/7] drm/i915: Add module param for enabling TTM in sysmem region

2022-08-09 Thread Jani Nikula
On Tue, 09 Aug 2022, Adrian Larumbe wrote: > On 03.08.2022 17:22, Jani Nikula wrote: >>On Tue, 02 Aug 2022, Adrian Larumbe wrote: >>> Introduces a new module parameter, 'use_pool_alloc', which defaults to >>> 'false'. Its goal is to make the driver fall back on TTM for setting up >>> the system

Re: [Intel-gfx] How to convert drivers/gpu/drm/i915/ to use local workqueue?

2022-08-09 Thread Tvrtko Ursulin
Hi, On 05/08/2022 14:14, Tetsuo Handa wrote: On 2022/06/30 22:09, Tvrtko Ursulin wrote: On the i915 specifics, the caller in drivers/gpu/drm/i915/gt/selftest_execlists.c I am pretty sure can be removed. It is synchronized with the error capture side of things which is not required for the

Re: [Intel-gfx] [PATCH v5 00/33] DYNDBG: opt-in class'd debug for modules, use in drm.

2022-08-09 Thread Daniel Vetter
[Catching up on mails] Did you see the feedback form Steven from tracing side of things? Does this version have that taken into account already? I think once we have that and acks from dyndbg maintainers then I think we should just land this and polish from there? Maybe some acks from drm

Re: [Intel-gfx] [PATCH 6/7] drm/i915: Add module param for enabling TTM in sysmem region

2022-08-09 Thread Adrian Larumbe
On 03.08.2022 17:22, Jani Nikula wrote: >On Tue, 02 Aug 2022, Adrian Larumbe wrote: >> Introduces a new module parameter, 'use_pool_alloc', which defaults to >> 'false'. Its goal is to make the driver fall back on TTM for setting up >> the system memory region, so that object allocation will be

Re: [Intel-gfx] [RFC 1/1] drm/i915/dgfx: Avoid parent bridge rpm on mmap mappings

2022-08-09 Thread Rodrigo Vivi
On Mon, Aug 08, 2022 at 04:05:55PM +0530, Anshuman Gupta wrote: > As per PCIe Spec Section 5.3, > When a Type 1 Function associated with a Switch/Root > Port (a “virtual bridge”) is in a non-D0 power state, > it will emulate the behavior of a conventional PCI bridge > in its handling of Memory,

Re: [Intel-gfx] [PATCH] drm/fb-helper: Remove helpers to change frame buffer config

2022-08-09 Thread Daniel Vetter
On Sat, Jul 02, 2022 at 08:05:54PM +0200, Helge Deller wrote: > On 6/29/22 12:56, Geert Uytterhoeven wrote: > > The DRM fbdev emulation layer does not support pushing back > > changes to fb_var_screeninfo to KMS. > > > > However, drm_fb_helper still implements the fb_ops.fb_check_var() and > >

Re: [Intel-gfx] [Linaro-mm-sig] [PATCH v2 2/5] drm/gem: Take reservation lock for vmap/vunmap operations

2022-08-09 Thread Christian König
Am 25.07.22 um 17:18 schrieb Dmitry Osipenko: The new common dma-buf locking convention will require buffer importers to hold the reservation lock around mapping operations. Make DRM GEM core to take the lock around the vmapping operations and update QXL and i915 drivers to use the locked

Re: [Intel-gfx] [Linaro-mm-sig] [PATCH v2 1/5] dma-buf: Add _unlocked postfix to function names

2022-08-09 Thread Christian König
Am 25.07.22 um 17:18 schrieb Dmitry Osipenko: Add _unlocked postfix to the dma-buf API function names in a preparation to move all non-dynamic dma-buf users over to the dynamic locking specification. This patch only renames API functions, preparing drivers to the common locking convention. Later

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [v5,1/6] drm/ttm: Add new callbacks to ttm res mgr

2022-08-09 Thread Patchwork
== Series Details == Series: series starting with [v5,1/6] drm/ttm: Add new callbacks to ttm res mgr URL : https://patchwork.freedesktop.org/series/107088/ State : success == Summary == CI Bug Log - changes from CI_DRM_11975_full -> Patchwork_107088v1_full

Re: [Intel-gfx] [PATCH v5] drm/i915: stop using swiotlb

2022-08-09 Thread Tvrtko Ursulin
On 08/08/2022 16:48, Hellstrom, Thomas wrote: Hi, [back from vacation] On Tue, 2022-07-26 at 16:39 +0100, Robert Beckett wrote: Calling swiotlb functions directly is nowadays considered harmful. See https://lore.kernel.org/intel-gfx/20220711082614.ga29...@lst.de/ Replace

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/ttm: Fix dummy res NULL ptr deref bug (rev3)

2022-08-09 Thread Patchwork
== Series Details == Series: drm/ttm: Fix dummy res NULL ptr deref bug (rev3) URL : https://patchwork.freedesktop.org/series/106727/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11975 -> Patchwork_106727v3 Summary ---

[Intel-gfx] [PATCH i-g-t v2] tests/gem_lmem_swapping: add some coverage for big objects

2022-08-09 Thread Matthew Auld
Everything we are testing here unfortunately fits within one packet (8M) which means we have zero coverage when we need to split the copy over multiple packets (including the aux CCS state). v2: - Add some coverage for 2G objects, just to see if something blows up with overflowing int. (Ram)

Re: [Intel-gfx] [PATCH v2 11/39] drm/i915: i915_gem_ttm_pm.c: fix kernel-doc markups

2022-08-09 Thread Rodrigo Vivi
On Wed, Jul 13, 2022 at 09:11:59AM +0100, Mauro Carvalho Chehab wrote: > The documentation for the flags field is missing there. It sounds > that some last-time change converted some bools into flags, but > the kernel-doc change didn't follow it. > > Fix those warnings: > >

Re: [Intel-gfx] [PATCH v2 35/39] docs: gpu: i915.rst: add the remaining kernel-doc markup files

2022-08-09 Thread Rodrigo Vivi
On Wed, Jul 13, 2022 at 09:12:23AM +0100, Mauro Carvalho Chehab wrote: > There are other files with kernel-doc markups: > > $ git grep -l "/\*\*" $(git ls-files|grep drivers/gpu/drm/i915/) > >kernel-doc-files > $ for i in $(cat kernel-doc-files); do if [ "$(git grep $i >

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [v5,1/6] drm/ttm: Add new callbacks to ttm res mgr

2022-08-09 Thread Patchwork
== Series Details == Series: series starting with [v5,1/6] drm/ttm: Add new callbacks to ttm res mgr URL : https://patchwork.freedesktop.org/series/107088/ State : success == Summary == CI Bug Log - changes from CI_DRM_11975 -> Patchwork_107088v1

Re: [Intel-gfx] [PATCH v2 39/39] drm/i915: add GuC functions to the documentation

2022-08-09 Thread Rodrigo Vivi
On Wed, Jul 13, 2022 at 09:12:27AM +0100, Mauro Carvalho Chehab wrote: > Currently, functions inside GuC aren't presented as part of the > GuC documentation. > > Add them. > > Signed-off-by: Mauro Carvalho Chehab could be squashed to the other guc patch, but anyways: Reviewed-by: Rodrigo Vivi

Re: [Intel-gfx] [PATCH v2 31/39] docs: gpu: i915.rst: GuC: add more kernel-doc markups

2022-08-09 Thread Rodrigo Vivi
On Wed, Jul 13, 2022 at 09:12:19AM +0100, Mauro Carvalho Chehab wrote: > There are several documented GuC kAPI that aren't currently part > of the docs. Add them, as this allows identifying issues with > badly-formatted tags. > > Signed-off-by: Mauro Carvalho Chehab Reviewed-by: Rodrigo Vivi >

Re: [Intel-gfx] [PATCH v2 38/39] drm/i915: add descriptions for some RPM macros at intel_gt_pm.h

2022-08-09 Thread Rodrigo Vivi
On Wed, Jul 13, 2022 at 09:12:26AM +0100, Mauro Carvalho Chehab wrote: > The intel_gt_pm.h file contains some convenient macros to be used > in GT code in order to get/put runtime PM references and for > checking them. > > Add descriptions based on the ones at intel_wakeref.h and >

Re: [Intel-gfx] [PATCH v2 36/39] drm/i915 i915_gem_object_types.h: document struct i915_lut_handle

2022-08-09 Thread Rodrigo Vivi
On Wed, Jul 13, 2022 at 09:12:24AM +0100, Mauro Carvalho Chehab wrote: > commit d1b48c1e7184 ("drm/i915: Replace execbuf vma ht with an idr") > added a rbtree list to allow searching for obj/ctx. > > Document it. > > Signed-off-by: Mauro Carvalho Chehab Reviewed-by: Rodrigo Vivi > --- > > To

Re: [Intel-gfx] [PATCH v2 37/39] drm/i915: document struct drm_i915_gem_object

2022-08-09 Thread Rodrigo Vivi
On Wed, Jul 13, 2022 at 09:12:25AM +0100, Mauro Carvalho Chehab wrote: > This is a large struct used to describe gem objects. It is > currently partially documented. Finish its documentation, filling > the gaps from git logs. > > Signed-off-by: Mauro Carvalho Chehab Reviewed-by: Rodrigo Vivi >

Re: [Intel-gfx] [PATCH v2 33/39] docs: gpu: i915.rst: PM: add more kernel-doc markups

2022-08-09 Thread Rodrigo Vivi
On Wed, Jul 13, 2022 at 09:12:21AM +0100, Mauro Carvalho Chehab wrote: > Both intel_runtime_pm.h and intel_pm.c contains kAPI for > runtime PM. So, add them to the documentation. > > Signed-off-by: Mauro Carvalho Chehab Reviewed-by: Rodrigo Vivi > --- > > To avoid mailbombing on a large

Re: [Intel-gfx] [PATCH v2 34/39] docs: gpu: i915.rst: GEM/TTM: add more kernel-doc markups

2022-08-09 Thread Rodrigo Vivi
On Wed, Jul 13, 2022 at 09:12:22AM +0100, Mauro Carvalho Chehab wrote: > There are several documented GEM/TTM kAPI that aren't currently part > of the docs. Add them, as this allows identifying issues with > badly-formatted tags. > > Signed-off-by: Mauro Carvalho Chehab Reviewed-by: Rodrigo

Re: [Intel-gfx] [PATCH v2 30/39] docs: gpu: i915.rst: gt: add more kernel-doc markups

2022-08-09 Thread Rodrigo Vivi
On Wed, Jul 13, 2022 at 09:12:18AM +0100, Mauro Carvalho Chehab wrote: > There are several documented GT kAPI that aren't currently part > of the docs. Add them, as this allows identifying issues with > badly-formatted tags. > > Signed-off-by: Mauro Carvalho Chehab > --- > > To avoid

Re: [Intel-gfx] [PATCH v2 19/39] drm/i915: i915_gem_region.h: fix i915_gem_apply_to_region_ops doc

2022-08-09 Thread Rodrigo Vivi
On Wed, Jul 13, 2022 at 09:12:07AM +0100, Mauro Carvalho Chehab wrote: > The kernel-doc markup for i915_gem_apply_to_region_ops() has some > issues: > > 1. The field should be marked as @process_obj; > 2. The callback parameters aren't document properly, as sphinx >will consider them to be

Re: [Intel-gfx] [PATCH v2 29/39] docs: gpu: i915.rst: display: add kernel-doc markups

2022-08-09 Thread Rodrigo Vivi
On Wed, Jul 13, 2022 at 09:12:17AM +0100, Mauro Carvalho Chehab wrote: > There are several documented kAPI at the display side that > aren't currently part of the docs. Add them, as this allows > identifying issues with badly-formatted tags. > > Signed-off-by: Mauro Carvalho Chehab same here,

Re: [Intel-gfx] [PATCH v2 32/39] docs: gpu: i915.rst: GVT: add more kernel-doc markups

2022-08-09 Thread Rodrigo Vivi
On Wed, Jul 13, 2022 at 09:12:20AM +0100, Mauro Carvalho Chehab wrote: > There are several documented GVT kAPI that aren't currently part > of the docs. Add them, as this allows identifying issues with > badly-formatted tags. > > Signed-off-by: Mauro Carvalho Chehab I haven't checked if these

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [v5,1/6] drm/ttm: Add new callbacks to ttm res mgr

2022-08-09 Thread Patchwork
== Series Details == Series: series starting with [v5,1/6] drm/ttm: Add new callbacks to ttm res mgr URL : https://patchwork.freedesktop.org/series/107088/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

Re: [Intel-gfx] [PATCH v2 18/39] drm/i915: intel_pm.c: fix some ascii artwork at kernel-doc

2022-08-09 Thread Rodrigo Vivi
On Wed, Jul 13, 2022 at 09:12:06AM +0100, Mauro Carvalho Chehab wrote: > Preserving ascii artwork on kernel-docs is tricky, as it needs > to respect both the Sphinx rules and be properly parsed by > kernel-doc script. > > The Sphinx syntax require code-blocks, which is: > > :: > >

Re: [Intel-gfx] [PATCH v5 6/6] drm/ttm: Switch to using the new res callback

2022-08-09 Thread Christian König
Am 09.08.22 um 11:22 schrieb Arunpravin Paneer Selvam: Apply new intersect and compatible callback instead of having a generic placement range verfications. v2: Added a separate callback for compatiblilty checks (Christian) We need to move parts of this patch earlier or the i915 will

Re: [Intel-gfx] [PATCH v2 15/39] drm/i915: intel_dp_link_training.c: fix kernel-doc markup

2022-08-09 Thread Rodrigo Vivi
On Wed, Jul 13, 2022 at 09:12:03AM +0100, Mauro Carvalho Chehab wrote: > The return code table is not properly marked, causing warnings > and being badly parsed by Sphinx: > > Documentation/gpu/i915:130: > ./drivers/gpu/drm/i915/display/intel_dp_link_training.c:183: WARNING: Block > quote

Re: [Intel-gfx] [PATCH v5 1/7] drm: Move and add a few utility macros into drm util header

2022-08-09 Thread Gwan-gyeong Mun
On 8/4/22 12:06 PM, Andi Shyti wrote: Hi Jani, It moves overflows_type utility macro into drm util header from i915_utils header. The overflows_type can be used to catch the truncation between data types. And it adds safe_conversion() macro which performs a type conversion (cast) of an source

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/display: avoid abnormal pixel output when turn eDP display off (rev2)

2022-08-09 Thread Patchwork
== Series Details == Series: drm/i915/display: avoid abnormal pixel output when turn eDP display off (rev2) URL : https://patchwork.freedesktop.org/series/106910/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11975 -> Patchwork_106910v2

Re: [Intel-gfx] [PATCH v3 1/3] drm/i915: pass a pointer for tlb seqno at vma_invalidate_tlb()

2022-08-09 Thread Mauro Carvalho Chehab
On Tue, 9 Aug 2022 00:15:14 + "Vivi, Rodrigo" wrote: > On Tue, 2022-08-09 at 01:09 +0200, Andi Shyti wrote: > > Hi Rodrigo, > > > > On Mon, Aug 08, 2022 at 03:04:13PM -0400, Rodrigo Vivi wrote: > > > On Mon, Aug 08, 2022 at 06:37:58PM +0200, Andi Shyti wrote: > > > > Hi Mauro, > > > > > >