[Intel-gfx] [PATCH i-g-t] i915/guc: Disable i915_pm_rps when SLPC is enabled

2022-08-18 Thread Vinay Belgaumkar
These tests were specifically designed for host Turbo. Skip them when SLPC is enabled as they fail frequently. We will look to keep adding to SLPC test coverage with these scenarios. Bug: https://gitlab.freedesktop.org/drm/intel/-/issues/3963 Bug:

Re: [Intel-gfx] [PATCH v2 09/15] drm/i915/pxp: add huc authentication and loading command

2022-08-18 Thread kernel test robot
Hi Daniele, I love your patch! Perhaps something to improve: [auto build test WARNING on drm-tip/drm-tip] url: https://github.com/intel-lab-lkp/linux/commits/Daniele-Ceraolo-Spurio/drm-i915-HuC-loading-for-DG2/20220819-070704 base: git://anongit.freedesktop.org/drm/drm-tip drm-tip config:

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/2] drm/i915/dsc/mtl: Update the DSC minor version (rev2)

2022-08-18 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/dsc/mtl: Update the DSC minor version (rev2) URL : https://patchwork.freedesktop.org/series/107366/ State : success == Summary == CI Bug Log - changes from CI_DRM_11997_full -> Patchwork_107366v2_full

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: HuC loading for DG2

2022-08-18 Thread Patchwork
== Series Details == Series: drm/i915: HuC loading for DG2 URL : https://patchwork.freedesktop.org/series/107477/ State : success == Summary == CI Bug Log - changes from CI_DRM_12002 -> Patchwork_107477v1 Summary --- **SUCCESS**

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: HuC loading for DG2

2022-08-18 Thread Patchwork
== Series Details == Series: drm/i915: HuC loading for DG2 URL : https://patchwork.freedesktop.org/series/107477/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: HuC loading for DG2

2022-08-18 Thread Patchwork
== Series Details == Series: drm/i915: HuC loading for DG2 URL : https://patchwork.freedesktop.org/series/107477/ State : warning == Summary == Error: dim checkpatch failed d4bf856f76e1 HAX: mei: GSC support for XeHP SDV and DG2 platform Traceback (most recent call last): File

[Intel-gfx] [PATCH i-g-t] i915/guc: Disable i915_pm_rps when SLPC is enabled

2022-08-18 Thread Vinay Belgaumkar
These tests were specifically designed for host Turbo. Skip them when SLPC is enabled as they fail frequently. We will look to keep adding to SLPC test coverage with these scenarios. Bug: https://gitlab.freedesktop.org/drm/intel/-/issues/3963 Bug:

[Intel-gfx] [PATCH v2 08/21] drm/i915/mtl: Add VBT port and AUX_CH mapping

2022-08-18 Thread Radhakrishna Sripada
From: Imre Deak Add the proper VBT port,AUX_CH -> i915 port,AUX_CH mapping which just follows the ADL_P one. Reviewed-by: Matt Roper Signed-off-by: Imre Deak Signed-off-by: Radhakrishna Sripada --- drivers/gpu/drm/i915/display/intel_bios.c | 14 +++--- 1 file changed, 7

[Intel-gfx] [PATCH v2 11/21] drm/i915/mtl: Add DP AUX support on TypeC ports

2022-08-18 Thread Radhakrishna Sripada
From: Imre Deak On MTL TypeC ports the AUX_CH_CTL and AUX_CH_DATA addresses have changed wrt. previous platforms, adjust the code accordingly. Signed-off-by: Imre Deak Signed-off-by: Radhakrishna Sripada --- drivers/gpu/drm/i915/display/intel_dp_aux.c | 45 -

[Intel-gfx] [PATCH v2 06/21] drm/i915/mtl: Add PCH support

2022-08-18 Thread Radhakrishna Sripada
Add support for Meteorpoint(MTP) PCH used with Meteorlake. Cc: Matt Roper Reviewed-by: Anusha Srivatsa Signed-off-by: Clint Taylor Signed-off-by: Radhakrishna Sripada --- drivers/gpu/drm/i915/intel_pch.c | 9 - drivers/gpu/drm/i915/intel_pch.h | 4 2 files changed, 12

[Intel-gfx] [PATCH v2 13/21] drm/i915: Extract wm latency adjustment to its own function

2022-08-18 Thread Radhakrishna Sripada
Watermark latency is adjusted in cases when latency is 0us for level greater than 1, the subsequent levels are disabled. Extract this logic into its own function. Suggested-by: Matt Roper Signed-off-by: Radhakrishna Sripada --- drivers/gpu/drm/i915/intel_pm.c | 88

[Intel-gfx] [PATCH v2 14/21] drm/i915/mtl: memory latency data from LATENCY_LPX_LPY for WM

2022-08-18 Thread Radhakrishna Sripada
Since Xe LPD+, Memory latency data are in LATENCY_LPX_LPY registers instead of GT driver mailbox. v2: Use the extracted wm latency adjustment function(Matt) Bspec: 64608 Cc: Matt Roper Original Author: Caz Yokoyama Signed-off-by: Radhakrishna Sripada --- drivers/gpu/drm/i915/i915_reg.h | 7

[Intel-gfx] [PATCH v2 19/21] drm/i915/display/mtl: Extend MBUS programming

2022-08-18 Thread Radhakrishna Sripada
From: José Roberto de Souza Display version 14 also supports MBUS joining just like ADL-P and also it does not need MBUS initialization, so extending ADL-P code paths to display version 14 and higher. Bspec: 49213 Reviewed-by: Matt Roper Signed-off-by: José Roberto de Souza Signed-off-by:

[Intel-gfx] [PATCH v2 17/21] drm/i915/mtl: Update MBUS_DBOX credits

2022-08-18 Thread Radhakrishna Sripada
Display version 14 platforms have different credits values compared to ADL-P. Update the credits based on pipe usage. v2: Simplify DBOX BW Credit definition(MattR) Bspec: 49213 Cc: Jose Roberto de Souza Cc: Matt Roper Original Author: Caz Yokoyama Signed-off-by: José Roberto de Souza

[Intel-gfx] [PATCH v2 03/21] drm/i915/mtl: MMIO range is now 4MB

2022-08-18 Thread Radhakrishna Sripada
From: Matt Roper Previously only dgfx platforms had a 4MB MMIO range, but starting with MTL we now use the larger range for all platforms. Bspec: 63834, 63830 Signed-off-by: Matt Roper Signed-off-by: Radhakrishna Sripada --- drivers/gpu/drm/i915/intel_uncore.c | 11 ++- 1 file

[Intel-gfx] [PATCH v2 04/21] drm/i915/mtl: Don't mask off CCS according to DSS fusing

2022-08-18 Thread Radhakrishna Sripada
From: Matt Roper Unlike the Xe_HP platforms, MTL only has a single CCS engine; the quad-based engine masking logic does not apply to this platform (or presumably any future platforms that only have 0 or 1 CCS). Signed-off-by: Matt Roper Signed-off-by: Radhakrishna Sripada ---

[Intel-gfx] [PATCH v2 16/21] drm/i915/mtl: Update memory bandwidth parameters

2022-08-18 Thread Radhakrishna Sripada
Like ADL_P, Meteorlake has different memory characteristics from past platforms. Update the values used by our memory bandwidth calculations accordingly. Bspec: 64631 Reviewed-by: Matt Roper Signed-off-by: Radhakrishna Sripada Signed-off-by: José Roberto de Souza ---

[Intel-gfx] [PATCH v2 20/21] drm/i915/mtl: Update CHICKEN_TRANS* register addresses

2022-08-18 Thread Radhakrishna Sripada
From: Madhumitha Tolakanahalli Pradeep In Display version 14, Transcoder Chicken Registers are moved from DPRZ to DRPOS to reduce register signal crossings for Unit Interface Optimization. This patch modifies the CHICKEN_TRANS macro to add a DISPLAY_VER check for calculating the correct

[Intel-gfx] [PATCH v2 10/21] drm/i915/mtl: Add display power wells

2022-08-18 Thread Radhakrishna Sripada
From: Imre Deak Add support for display power wells on MTL. The differences from XE_LPD: - The AUX HW block is moved to the PICA block, where the registers are on an always-on power well and the functionality needs to be powered on/off via the AUX_CH_CTL register: [1], [2] - The DDI IO power

[Intel-gfx] [PATCH v2 18/21] drm/i915/mtl: Reuse adl-p DBUF calculations

2022-08-18 Thread Radhakrishna Sripada
Meteorlake uses a similar DBUF calculations as ADL-P. Reuse the call flow for meteorlake. Bspec: 49255 Original Author: Caz Yokoyama Reviewed-by: Matt Roper Signed-off-by: Radhakrishna Sripada --- drivers/gpu/drm/i915/intel_pm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[Intel-gfx] [PATCH v2 07/21] drm/i915/mtl: Add gmbus and gpio support

2022-08-18 Thread Radhakrishna Sripada
Add tables to map the GMBUS pin pairs to GPIO registers and port to DDC. >From spec we have registers GPIO_CTL[1-5] mapped to native display phys and GPIO_CTL[9-14] are mapped to TC ports. BSpec: 49306 Original Author: Brian J Lovin Signed-off-by: Radhakrishna Sripada ---

[Intel-gfx] [PATCH v2 05/21] drm/i915/mtl: Define engine context layouts

2022-08-18 Thread Radhakrishna Sripada
From: Matt Roper The part of the media and blitter engine contexts that we care about for setting up an initial state are the same on MTL as they were on DG2 (and PVC), so we need to update the driver conditions to re-use the DG2 context table. For render/compute engines, the part of the

[Intel-gfx] [PATCH v2 09/21] drm/i915/mtl: Add support for MTL in Display Init sequences

2022-08-18 Thread Radhakrishna Sripada
The initialization sequence for Meteorlake reuses the sequence for icelake for most parts. Some changes viz. reset PICA handshake are added. Bspec: 49189 Reviewed-by: Matt Roper Signed-off-by: Radhakrishna Sripada --- drivers/gpu/drm/i915/display/intel_display_power.c | 3 +++

[Intel-gfx] [PATCH v2 21/21] drm/i915/mtl: Do not update GV point, mask value

2022-08-18 Thread Radhakrishna Sripada
No need to update mask value/restrict because "Pcode only wants to use GV bandwidth value, not the mask value." for Display version greater than 14. Bspec: 646365 Cc: Matt Roper Original Author: Caz Yokoyama Signed-off-by: Radhakrishna Sripada --- drivers/gpu/drm/i915/intel_pm.c | 18

[Intel-gfx] [PATCH v2 01/21] drm/i915: Read graphics/media/display arch version from hw

2022-08-18 Thread Radhakrishna Sripada
From: Matt Roper Going forward, the hardware teams no longer consider new platforms to have a "generation" in the way we've defined it for past platforms. Instead, each IP block (graphics, media, display) will have their own architecture major.minor versions and stepping ID's which should be

[Intel-gfx] [PATCH v2 02/21] drm/i915: Parse and set stepping for platforms with GMD

2022-08-18 Thread Radhakrishna Sripada
From: José Roberto de Souza The GMD step field do not properly match the current stepping convention that we use(STEP_A0, STEP_A1, STEP_B0...). One platform could have { arch = 12, rel = 70, step = 1 } and the actual stepping is STEP_B0 but without the translation of the step field would mean

[Intel-gfx] [PATCH v2 00/21] Initial Meteorlake Support

2022-08-18 Thread Radhakrishna Sripada
The PCI Id's and platform definition are posted earlier. This series adds handful of early enablement patches including support for display power wells, VBT and AUX Channel mapping, PCH and gmbus support, dbus, mbus, sagv and memory bandwidth support. This series also add the support for a new

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/mtl: Introduce FBC B (rev3)

2022-08-18 Thread Patchwork
== Series Details == Series: drm/i915/mtl: Introduce FBC B (rev3) URL : https://patchwork.freedesktop.org/series/107365/ State : success == Summary == CI Bug Log - changes from CI_DRM_11997_full -> Patchwork_107365v3_full Summary ---

[Intel-gfx] [PATCH v2 15/15] HAX: drm/i915: force INTEL_MEI_GSC and INTEL_MEI_PXP on for CI

2022-08-18 Thread Daniele Ceraolo Spurio
Both are required for HuC loading. Signed-off-by: Daniele Ceraolo Spurio --- drivers/gpu/drm/i915/Kconfig.debug | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/i915/Kconfig.debug b/drivers/gpu/drm/i915/Kconfig.debug index e7fd3e76f8a2..a6576ffbc4dc 100644 ---

[Intel-gfx] [PATCH v2 11/15] drm/i915/huc: track delayed HuC load with a fence

2022-08-18 Thread Daniele Ceraolo Spurio
Given that HuC load is delayed on DG2, this patch adds support for a fence that can be used to wait for load completion. No waiters are added in this patch (they're coming up in the next one), to keep the focus of the patch on the tracking logic. The full HuC loading flow on boot DG2 is as

[Intel-gfx] [PATCH v2 13/15] drm/i915/huc: better define HuC status getparam possible return values.

2022-08-18 Thread Daniele Ceraolo Spurio
The current HuC status getparam return values are a bit confusing in regards to what happens in some scenarios. In particular, most of the error cases cause the ioctl to return an error, but a couple of them, INIT_FAIL and LOAD_FAIL, are not explicitly handled and neither is their expected return

[Intel-gfx] [PATCH v2 12/15] drm/i915/huc: stall media submission until HuC is loaded

2022-08-18 Thread Daniele Ceraolo Spurio
Wait on the fence to be signalled to avoid the submissions finding HuC not yet loaded. Signed-off-by: Daniele Ceraolo Spurio Cc: Tony Ye Reviewed-by: Alan Previn --- drivers/gpu/drm/i915/gt/uc/intel_huc.h | 6 ++ drivers/gpu/drm/i915/i915_request.c| 24 2

[Intel-gfx] [PATCH v2 09/15] drm/i915/pxp: add huc authentication and loading command

2022-08-18 Thread Daniele Ceraolo Spurio
From: Tomas Winkler Add support for loading HuC via a pxp stream command. Signed-off-by: Tomas Winkler Signed-off-by: Vitaly Lubart Signed-off-by: Daniele Ceraolo Spurio Cc: Alan Previn Reviewed-by: Alan Previn --- drivers/gpu/drm/i915/Makefile | 3 +-

[Intel-gfx] [PATCH v2 06/15] mei: pxp: support matching with a gfx discrete card

2022-08-18 Thread Daniele Ceraolo Spurio
From: Tomas Winkler With on-boards graphics card, both i915 and MEI are in the same device hierarchy with the same parent, while for discrete gfx card the MEI is its child device. Adjust the match function for that scenario by matching MEI parent device with i915. V2: 1. More detailed commit

[Intel-gfx] [PATCH v2 10/15] drm/i915/dg2: setup HuC loading via GSC

2022-08-18 Thread Daniele Ceraolo Spurio
The GSC will perform both the load and teh authentication, so we just need to check the auth bit after the GSC has replied. Since we require the PXP module to load the HuC, the earliest we can trigger the load is during the pxp_bind operation. Note that GSC-loaded HuC survives GT reset, so we

[Intel-gfx] [PATCH v2 05/15] mei: pxp: add command streamer API to the PXP driver

2022-08-18 Thread Daniele Ceraolo Spurio
From: Vitaly Lubart The discrete graphics card with GSC firmware using command streamer API hence it requires to enhance pxp module with the new gsc_command() handler. The handler is implemented via mei_pxp_gsc_command() which is just just a thin wrapper around mei_cldev_send_gsc_command() V2:

[Intel-gfx] [PATCH v2 08/15] drm/i915/pxp: implement function for sending tee stream command

2022-08-18 Thread Daniele Ceraolo Spurio
From: Vitaly Lubart Command to be sent via the stream interface are written to a local memory page, whose address is then provided to the GSC. The interface supports providing a full sg with multiple pages for both input and output messages, but since for now we only aim to support short and

[Intel-gfx] [PATCH v2 14/15] drm/i915/huc: define gsc-compatible HuC fw for DG2

2022-08-18 Thread Daniele Ceraolo Spurio
The fw name is different and we need to record the fact that the blob is gsc-loaded, so add a new macro to help. Note: A-step DG2 G10 does not support HuC loading via GSC and would require a separate firmware to be loaded the legacy way, but that's not a production stepping so we're not going to

[Intel-gfx] [PATCH v2 07/15] drm/i915/pxp: load the pxp module when we have a gsc-loaded huc

2022-08-18 Thread Daniele Ceraolo Spurio
The mei_pxp module is required to send the command to load authenticate the HuC to the GSC even if pxp is not in use for protected content management. Signed-off-by: Daniele Ceraolo Spurio Cc: Alan Previn Reviewed-by: Alan Previn --- drivers/gpu/drm/i915/Makefile| 10 +++---

[Intel-gfx] [PATCH v2 02/15] mei: add support to GSC extended header

2022-08-18 Thread Daniele Ceraolo Spurio
From: Tomas Winkler GSC extend header is of variable size and data is provided in a sgl list inside the header and not in the data buffers, need to enable the path. Signed-off-by: Tomas Winkler Signed-off-by: Daniele Ceraolo Spurio Cc: Vitaly Lubart --- drivers/misc/mei/client.c| 55

[Intel-gfx] [PATCH v2 03/15] mei: bus: enable sending gsc commands

2022-08-18 Thread Daniele Ceraolo Spurio
From: Tomas Winkler GSC command is and extended header containing a scatter gather list and without a data buffer. Using MEI_CL_IO_SGL flag, the caller send the GSC command as a data and the function internally moves it to the extended header. Signed-off-by: Tomas Winkler Signed-off-by:

[Intel-gfx] [PATCH v2 04/15] mei: bus: extend bus API to support command streamer API

2022-08-18 Thread Daniele Ceraolo Spurio
From: Vitaly Lubart Add mei bus API for sending gsc commands: mei_cldev_send_gsc_command() The GSC commands are originated in the graphics stack and are in form of SGL DMA buffers. The GSC commands are synchronous, the response is received in the same call on the out sg list buffers. The

[Intel-gfx] [PATCH v2 01/15] HAX: mei: GSC support for XeHP SDV and DG2 platform

2022-08-18 Thread Daniele Ceraolo Spurio
This is a squash of the GSC support for XeHP SDV and DG2 series, which is being reviewed separately at: https://patchwork.freedesktop.org/series/106638/ Signed-off-by: Daniele Ceraolo Spurio --- drivers/gpu/drm/i915/gt/intel_gsc.c | 118 +---

[Intel-gfx] [PATCH v2 00/15] drm/i915: HuC loading for DG2

2022-08-18 Thread Daniele Ceraolo Spurio
On DG2, HuC loading is performed by the GSC, via a PXP command. The load operation itself is relatively simple (just send a message to the GSC with the physical address of the HuC in LMEM), but there are timing changes that requires special attention. In particular, to send a PXP command we need

Re: [Intel-gfx] [PATCH] gpu: move from strlcpy with unused retval to strscpy

2022-08-18 Thread Laurent Pinchart
Hi Wolfram, Thank you for the patch. On Thu, Aug 18, 2022 at 11:00:07PM +0200, Wolfram Sang wrote: > Follow the advice of the below link and prefer 'strscpy' in this > subsystem. Conversion is 1:1 because the return value is not used. > Generated by a coccinelle script. > > Link: >

[Intel-gfx] Requests For Proposals for hosting XDC 2023 are now open

2022-08-18 Thread Lyude Paul
Hello everyone! The X.org board is soliciting proposals to host XDC in 2023. Since XDC 2022 is being held in North America this year, XDC 2023 is expected to be in Europe. However, the board is open to other locations, especially if there's an interesting co-location with another conference. If

Re: [Intel-gfx] [PATCH 01/39] drm/i915: add display sub-struct to drm_i915_private

2022-08-18 Thread Lucas De Marchi
On Wed, Aug 17, 2022 at 11:07:46AM +0300, Jani Nikula wrote: On Wed, 17 Aug 2022, Jani Nikula wrote: On Tue, 16 Aug 2022, Lucas De Marchi wrote: On Thu, Aug 11, 2022 at 06:07:12PM +0300, Jani Nikula wrote: In another long-overdue cleanup, add a display sub-struct to drm_i915_private, and

Re: [Intel-gfx] [PATCH 2/2] drm/i915/guc: Add delay to disable scheduling after pin count goes to zero

2022-08-18 Thread John Harrison
On 8/16/2022 19:05, Alan Previn wrote: From: Matthew Brost Add a delay, configurable via debugfs (default 34ms), to disable scheduling of a context after the pin count goes to zero. Disable scheduling is a costly operation as it requires synchronizing with the GuC. So the idea is that a delay

[Intel-gfx] [PATCH i-g-t] i915/guc: Disable i915_pm_rps when SLPC is enabled

2022-08-18 Thread Vinay Belgaumkar
These tests were specifically designed for host Turbo. Skip them when SLPC is enabled as they fail frequently. We will look to keep adding to SLPC test coverage with these scenarios. Bug: https://gitlab.freedesktop.org/drm/intel/-/issues/3963 Bug:

Re: [Intel-gfx] [PATCH i-g-t] i915/guc: Disable i915_pm_rps when SLPC is enabled

2022-08-18 Thread Vivi, Rodrigo
On Thu, 2022-08-18 at 13:42 -0700, Vinay Belgaumkar wrote: > These tests were specifically designed for host Turbo. Skip > them when SLPC is enabled as they fail frequently. We will look > to keep adding to SLPC test coverage with these scenarios. > > Bug:

[Intel-gfx] [PATCH i-g-t] i915/guc: Disable i915_pm_rps when SLPC is enabled

2022-08-18 Thread Vinay Belgaumkar
These tests were specifically designed for host Turbo. Skip them when SLPC is enabled as they fail frequently. We will look to keep adding to SLPC test coverage with these scenarios. Bug: https://gitlab.freedesktop.org/drm/intel/-/issues/3963 Bug:

[Intel-gfx] [PATCH 7/7] drm/i915/hwmon: Extend power/energy for XEHPSDV

2022-08-18 Thread Badal Nilawar
From: Dale B Stimson Extend hwmon power/energy for XEHPSDV especially per gt level energy usage. v2: Update to latest HWMON spec (Ashutosh) Signed-off-by: Ashutosh Dixit Signed-off-by: Dale B Stimson Signed-off-by: Badal Nilawar Acked-by: Guenter Roeck ---

[Intel-gfx] [PATCH 1/7] drm/i915/hwmon: Add HWMON infrastructure

2022-08-18 Thread Badal Nilawar
From: Dale B Stimson The i915 HWMON module will be used to expose voltage, power and energy values for dGfx. Here we set up i915 hwmon infrastructure including i915 hwmon registration, basic data structures and functions. v2: - Create HWMON infra patch (Ashutosh) - Fixed review comments

[Intel-gfx] [PATCH 5/7] drm/i915/hwmon: Expose card reactive critical power

2022-08-18 Thread Badal Nilawar
From: Ashutosh Dixit Expose the card reactive critical (I1) power. I1 is exposed as power1_crit in microwatts (typically for client products) or as curr1_crit in milliamperes (typically for server). v2: Add curr1_crit functionality (Ashutosh) v3: - Use HWMON_CHANNEL_INFO to define

[Intel-gfx] [PATCH 4/7] drm/i915/hwmon: Show device level energy usage

2022-08-18 Thread Badal Nilawar
From: Dale B Stimson Use i915 HWMON to display device level energy input. v2: - Updated the date and kernel version in feature description Signed-off-by: Dale B Stimson Signed-off-by: Ashutosh Dixit Signed-off-by: Riana Tauro Signed-off-by: Badal Nilawar Acked-by: Guenter Roeck ---

[Intel-gfx] [PATCH 2/7] drm/i915/hwmon: Add HWMON current voltage support

2022-08-18 Thread Badal Nilawar
From: Riana Tauro Use i915 HWMON subsystem to display current input voltage. v2: - Updated date and kernel version in feature description - Fixed review comments (Ashutosh) v3: Use macro HWMON_CHANNEL_INFO to define hwmon channel (Guenter) v4: - Fixed review comments (Ashutosh) - Use

[Intel-gfx] [PATCH 0/7] drm/i915: Add HWMON support

2022-08-18 Thread Badal Nilawar
This series adds the HWMON support for DGFX v2: - Reorganized series. Created first patch as infrastructure patch followed by feature patches. (Ashutosh) - Fixed review comments (Jani) - Fixed review comments (Ashutosh) v3: - Fixed review comments from Guenter - Exposed energy

[Intel-gfx] [PATCH 1/2] drm/i915/bios: Validate fp_timing terminator presence

2022-08-18 Thread Ville Syrjala
From: Ville Syrjälä Validate the LFP data block a bit hardwer by making sure the fp_timing terminators (0x) are where we expect them to be. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_bios.c | 60 --- 1 file changed, 32 insertions(+), 28

[Intel-gfx] [PATCH 0/2] drm/i915/bios: Rethink LFP data pointer generation

2022-08-18 Thread Ville Syrjala
From: Ville Syrjälä Turns out the current code for generating the LFP data pointers doensn't work with certain VBTs, so switch to just hardcoding the fp_timing table size, and make the validator a bit more strict just to be extra safe. Ville Syrjälä (2): drm/i915/bios: Validate fp_timing

[Intel-gfx] [PATCH v3 26/31] platform/x86: samsung-laptop: Move acpi_backlight=[vendor|native] quirks to ACPI video_detect.c

2022-08-18 Thread Hans de Goede
acpi_video_set_dmi_backlight_type() is troublesome because it may end up getting called after other backlight drivers have already called acpi_video_get_backlight_type() resulting in the other drivers already being registered even though they should not. Move all the

[Intel-gfx] [PATCH v3 27/31] ACPI: video: Remove acpi_video_set_dmi_backlight_type()

2022-08-18 Thread Hans de Goede
acpi_video_set_dmi_backlight_type() is troublesome because it may end up getting called after other backlight drivers have already called acpi_video_get_backlight_type() resulting in the other drivers already being registered even though they should not. In case of the acpi_video backlight,

[Intel-gfx] [PATCH v3 29/31] ACPI: video: Drop NL5x?U, PF4NU1F and PF5?U?? acpi_backlight=native quirks

2022-08-18 Thread Hans de Goede
acpi_backlight=native is the default for these, but as the comment explains the quirk was still necessary because even briefly registering the acpi_video0 backlight; and then unregistering it once the native driver showed up, was leading to issues. After the "ACPI: video: Make backlight class

[Intel-gfx] [PATCH v3 31/31] drm/todo: Add entry about dealing with brightness control on devices with > 1 panel

2022-08-18 Thread Hans de Goede
Add an entry summarizing the discussion about dealing with brightness control on devices with more then 1 internal panel. The original discussion can be found here: https://lore.kernel.org/dri-devel/20220517152331.16217-1-hdego...@redhat.com/ Signed-off-by: Hans de Goede ---

[Intel-gfx] [PATCH v3 24/31] platform/x86: asus-wmi: Move acpi_backlight=vendor quirks to ACPI video_detect.c

2022-08-18 Thread Hans de Goede
Remove the asus-wmi quirk_entry.wmi_backlight_power quirk-flag, which called acpi_video_set_dmi_backlight_type(acpi_backlight_vendor) and replace it with acpi/video_detect.c video_detect_dmi_table[] entries using the video_detect_force_vendor callback. acpi_video_set_dmi_backlight_type() is

[Intel-gfx] [PATCH v3 28/31] ACPI: video: Drop "Samsung X360" acpi_backlight=native quirk

2022-08-18 Thread Hans de Goede
acpi_backlight=native is the default for the "Samsung X360", but as the comment explains the quirk was still necessary because even briefly registering the acpi_video0 backlight; and then unregistering it once the native driver showed up, was leading to issues. After the "ACPI: video: Make

[Intel-gfx] [PATCH v3 30/31] ACPI: video: Fix indentation of video_detect_dmi_table[] entries

2022-08-18 Thread Hans de Goede
The video_detect_dmi_table[] uses an unusual indentation for before the ".name = ..." named struct initializers. Instead of being indented with an extra tab compared to the previous line's '{' these are indented to with only a single space to allow for long DMI_MATCH() lines without wrapping.

[Intel-gfx] [PATCH v3 22/31] platform/x86: acer-wmi: Move backlight DMI quirks to acpi/video_detect.c

2022-08-18 Thread Hans de Goede
Move the backlight DMI quirks to acpi/video_detect.c, so that the driver no longer needs to call acpi_video_set_dmi_backlight_type(). acpi_video_set_dmi_backlight_type() is troublesome because it may end up getting called after other backlight drivers have already called

[Intel-gfx] [PATCH v3 23/31] platform/x86: asus-wmi: Drop DMI chassis-type check from backlight handling

2022-08-18 Thread Hans de Goede
Remove this check from the asus-wmi backlight handling: /* Some Asus desktop boards export an acpi-video backlight interface, stop this from showing up */ chassis_type = dmi_get_system_info(DMI_CHASSIS_TYPE); if (chassis_type && !strcmp(chassis_type, "3"))

[Intel-gfx] [PATCH v3 20/31] platform/x86: apple-gmux: Stop calling acpi/video.h functions

2022-08-18 Thread Hans de Goede
Now that acpi_video_get_backlight_type() has apple-gmux detection (using apple_gmux_present()), it is no longer necessary for the apple-gmux code to manually remove possibly conflicting drivers. So remove the handling for this from the apple-gmux driver. Signed-off-by: Hans de Goede ---

[Intel-gfx] [PATCH v3 16/31] ACPI: video: Refactor acpi_video_get_backlight_type() a bit

2022-08-18 Thread Hans de Goede
Refactor acpi_video_get_backlight_type() so that the heuristics / detection steps are stricly in order of descending precedence. Also move the comments describing the steps to when the various steps are actually done, to avoid the comments getting out of sync with the code. Acked-by: Rafael J.

[Intel-gfx] [PATCH v3 21/31] platform/x86: toshiba_acpi: Stop using acpi_video_set_dmi_backlight_type()

2022-08-18 Thread Hans de Goede
acpi_video_set_dmi_backlight_type() is troublesome because it may end up getting called after other backlight drivers have already called acpi_video_get_backlight_type() resulting in the other drivers already being registered even though they should not. In case of the acpi_video backlight,

[Intel-gfx] [PATCH v3 19/31] platform/x86: nvidia-wmi-ec-backlight: Use acpi_video_get_backlight_type()

2022-08-18 Thread Hans de Goede
Add an acpi_video_get_backlight_type() == acpi_backlight_nvidia_wmi_ec check. This will make nvidia-wmi-ec-backlight properly honor the user selecting a different backlight driver through the acpi_backlight=... kernel commandline option. Since the auto-detect code check for

[Intel-gfx] [PATCH v3 18/31] ACPI: video: Add Apple GMUX brightness control detection

2022-08-18 Thread Hans de Goede
On Apple laptops with an Apple GMUX using this for brightness control, should take precedence of any other brightness control methods. Add apple-gmux detection to acpi_video_get_backlight_type() using the already existing apple_gmux_present() helper function. This will allow removig the (ab)use

[Intel-gfx] [PATCH v3 17/31] ACPI: video: Add Nvidia WMI EC brightness control detection (v2)

2022-08-18 Thread Hans de Goede
On some new laptop designs a new Nvidia specific WMI interface is present which gives info about panel brightness control and may allow controlling the brightness through this interface when the embedded controller is used for brightness control. When this WMI interface is present and indicates

[Intel-gfx] [PATCH v3 14/31] drm/radeon: Register ACPI video backlight when skipping radeon backlight registration

2022-08-18 Thread Hans de Goede
Typically the acpi_video driver will initialize before radeon, which used to cause /sys/class/backlight/acpi_video0 to get registered and then radeon would register its own radeon_bl# device later. After which the drivers/acpi/video_detect.c code unregistered the acpi_video0 device to avoid there

[Intel-gfx] [PATCH v3 15/31] platform/x86: nvidia-wmi-ec-backlight: Move fw interface definitions to a header

2022-08-18 Thread Hans de Goede
Move the WMI interface definitions to a header, so that the definitions can be shared with drivers/acpi/video_detect.c . Suggested-by: Daniel Dadap Signed-off-by: Hans de Goede --- MAINTAINERS | 1 + .../platform/x86/nvidia-wmi-ec-backlight.c| 66

[Intel-gfx] [PATCH v3 11/31] drm/i915: Call acpi_video_register_backlight() (v2)

2022-08-18 Thread Hans de Goede
On machins without an i915 opregion the acpi_video driver immediately probes the ACPI video bus and used to also immediately register acpi_video# backlight devices when supported. Once the drm/kms driver then loaded later and possibly registered a native backlight device then the

[Intel-gfx] [PATCH v3 13/31] drm/amdgpu: Register ACPI video backlight when skipping amdgpu backlight registration

2022-08-18 Thread Hans de Goede
Typically the acpi_video driver will initialize before amdgpu, which used to cause /sys/class/backlight/acpi_video0 to get registered and then amdgpu would register its own amdgpu_bl# device later. After which the drivers/acpi/video_detect.c code unregistered the acpi_video0 device to avoid there

[Intel-gfx] [PATCH v3 08/31] ACPI: video: Simplify acpi_video_unregister_backlight()

2022-08-18 Thread Hans de Goede
When acpi_video_register() has not run yet the video_bus_head will be empty, so there is no need to check the register_count flag first. Acked-by: Rafael J. Wysocki Signed-off-by: Hans de Goede --- drivers/acpi/acpi_video.c | 12 1 file changed, 4 insertions(+), 8 deletions(-)

[Intel-gfx] [PATCH v3 04/31] drm/radeon: Don't register backlight when another backlight should be used (v3)

2022-08-18 Thread Hans de Goede
Before this commit when we want userspace to use the acpi_video backlight device we register both the GPU's native backlight device and acpi_video's firmware acpi_video# backlight device. This relies on userspace preferring firmware type backlight devices over native ones. Registering 2 backlight

[Intel-gfx] [PATCH v3 10/31] ACPI: video: Remove code to unregister acpi_video backlight when a native backlight registers

2022-08-18 Thread Hans de Goede
Remove the code to unregister acpi_video backlight devices when a native backlight device gets registered later. Now that the acpi_video backlight device registration is a separate step which runs later, after the drm/kms driver is done setting up its own native backlight device, it is no longer

[Intel-gfx] [PATCH v3 05/31] drm/nouveau: Don't register backlight when another backlight should be used

2022-08-18 Thread Hans de Goede
Before this commit when we want userspace to use the acpi_video backlight device we register both the GPU's native backlight device and acpi_video's firmware acpi_video# backlight device. This relies on userspace preferring firmware type backlight devices over native ones. Registering 2 backlight

[Intel-gfx] [PATCH v3 06/31] ACPI: video: Drop backlight_device_get_by_type() call from acpi_video_get_backlight_type()

2022-08-18 Thread Hans de Goede
All x86/ACPI kms drivers which register native/BACKLIGHT_RAW type backlight devices call acpi_video_backlight_use_native() now. This sets __acpi_video_get_backlight_type()'s internal static native_available flag. This makes the backlight_device_get_by_type(BACKLIGHT_RAW) check unnecessary.

[Intel-gfx] [PATCH v3 03/31] drm/amdgpu: Don't register backlight when another backlight should be used (v3)

2022-08-18 Thread Hans de Goede
Before this commit when we want userspace to use the acpi_video backlight device we register both the GPU's native backlight device and acpi_video's firmware acpi_video# backlight device. This relies on userspace preferring firmware type backlight devices over native ones. Registering 2 backlight

[Intel-gfx] [PATCH v3 07/31] ACPI: video: Remove acpi_video_bus from list before tearing it down

2022-08-18 Thread Hans de Goede
Move the list_del removing an acpi_video_bus from video_bus_head on teardown to before the teardown is done, to avoid code iterating over the video_bus_head list seeing acpi_video_bus objects on there which are (partly) torn down already. Acked-by: Rafael J. Wysocki Signed-off-by: Hans de Goede

[Intel-gfx] [PATCH v3 09/31] ACPI: video: Make backlight class device registration a separate step (v2)

2022-08-18 Thread Hans de Goede
On x86/ACPI boards the acpi_video driver will usually initialize before the kms driver (except i915). This causes /sys/class/backlight/acpi_video0 to show up and then the kms driver registers its own native backlight device after which the drivers/acpi/video_detect.c code unregisters the

[Intel-gfx] [PATCH v3 02/31] drm/i915: Don't register backlight when another backlight should be used

2022-08-18 Thread Hans de Goede
Before this commit when we want userspace to use the acpi_video backlight device we register both the GPU's native backlight device and acpi_video's firmware acpi_video# backlight device. This relies on userspace preferring firmware type backlight devices over native ones. Registering 2 backlight

[Intel-gfx] [PATCH v3 01/31] ACPI: video: Add acpi_video_backlight_use_native() helper

2022-08-18 Thread Hans de Goede
ATM on x86 laptops where we want userspace to use the acpi_video backlight device we often register both the GPU's native backlight device and acpi_video's firmware acpi_video# backlight device. This relies on userspace preferring firmware type backlight devices over native ones, but registering 2

[Intel-gfx] [PATCH v3 00/31] drm/kms: Stop registering multiple /sys/class/backlight devs for a single display

2022-08-18 Thread Hans de Goede
Hi All, As mentioned in my RFC titled "drm/kms: control display brightness through drm_connector properties": https://lore.kernel.org/dri-devel/0d188965-d809-81b5-74ce-7d30c49fe...@redhat.com/ The first step towards this is to deal with some existing technical debt in backlight handling on

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/pxp: don't start pxp without mei_pxp bind (rev3)

2022-08-18 Thread Patchwork
== Series Details == Series: drm/i915/pxp: don't start pxp without mei_pxp bind (rev3) URL : https://patchwork.freedesktop.org/series/107099/ State : success == Summary == CI Bug Log - changes from CI_DRM_11998 -> Patchwork_107099v3

[Intel-gfx] [PATCH v3] drm/i915/pxp: don't start pxp without mei_pxp bind

2022-08-18 Thread Juston Li
pxp will not start correctly until after mei_pxp bind completes and intel_pxp_init_hw() is called. Wait for the bind to complete before proceeding with startup. This fixes a race condition during bootup where we observed a small window for pxp commands to be sent, starting pxp before mei_pxp bind

Re: [Intel-gfx] [PULL] gvt-fixes

2022-08-18 Thread Vivi, Rodrigo
On Thu, 2022-08-18 at 17:27 +0300, Jani Nikula wrote: On Thu, 18 Aug 2022, Jani Nikula mailto:jani.nik...@intel.com>> wrote: On Wed, 17 Aug 2022, "Colin King (gmail)" mailto:colin.i.k...@gmail.com>> wrote: On 17/08/2022 21:07, Vivi, Rodrigo wrote: On Tue, 2022-08-16 at 12:43 +0800, Zhenyu Wang

Re: [Intel-gfx] [PATCH i-g-t 1/3] tests/gem_exec_fence: Fix wrong engine checked for store_dword capability

2022-08-18 Thread Janusz Krzysztofik
Hi Mauro, Thanks for reviewing this series, I've just pushed it. On Wednesday, 17 August 2022 14:53:48 CEST Mauro Carvalho Chehab wrote: > Hi Janusz, > > On Fri, 12 Aug 2022 11:53:44 +0200 > Janusz Krzysztofik wrote: > > It seems that there is a numeration issue on this series, as the patches

Re: [Intel-gfx] [v1.1 01/23] drm/i915: Read graphics/media/display arch version from hw

2022-08-18 Thread Balasubramani Vivekanandan
On 27.07.2022 20:46, Radhakrishna Sripada wrote: > From: Matt Roper > > Going forward, the hardware teams no longer consider new platforms to > have a "generation" in the way we've defined it for past platforms. > Instead, each IP block (graphics, media, display) will have their own >

Re: [Intel-gfx] [PULL] gvt-fixes

2022-08-18 Thread Jani Nikula
On Thu, 18 Aug 2022, Jani Nikula wrote: > On Wed, 17 Aug 2022, "Colin King (gmail)" wrote: >> On 17/08/2022 21:07, Vivi, Rodrigo wrote: >>> On Tue, 2022-08-16 at 12:43 +0800, Zhenyu Wang wrote: On 2022.08.16 12:05:08 +0800, Zhenyu Wang wrote: > On 2022.08.15 19:32:45 -0400, Rodrigo Vivi

[Intel-gfx] ✗ Fi.CI.BAT: failure for Enable Pipewriteback

2022-08-18 Thread Patchwork
== Series Details == Series: Enable Pipewriteback URL : https://patchwork.freedesktop.org/series/107440/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11997 -> Patchwork_107440v1 Summary --- **FAILURE** Serious

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Enable Pipewriteback

2022-08-18 Thread Patchwork
== Series Details == Series: Enable Pipewriteback URL : https://patchwork.freedesktop.org/series/107440/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Enable Pipewriteback

2022-08-18 Thread Patchwork
== Series Details == Series: Enable Pipewriteback URL : https://patchwork.freedesktop.org/series/107440/ State : warning == Summary == Error: dim checkpatch failed c89414f4d5ea drm/i915: Define WD trancoder for i915 -:68: CHECK:LINE_SPACING: Please don't use multiple blank lines #68: FILE:

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915/dsc/mtl: Update the DSC minor version (rev2)

2022-08-18 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/dsc/mtl: Update the DSC minor version (rev2) URL : https://patchwork.freedesktop.org/series/107366/ State : success == Summary == CI Bug Log - changes from CI_DRM_11997 -> Patchwork_107366v2

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/2] drm/i915/dsc/mtl: Update the DSC minor version (rev2)

2022-08-18 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/dsc/mtl: Update the DSC minor version (rev2) URL : https://patchwork.freedesktop.org/series/107366/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked

  1   2   >