[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/debugfs: Fix perf_limit_reasons debugfs

2022-09-16 Thread Patchwork
== Series Details == Series: drm/i915/debugfs: Fix perf_limit_reasons debugfs URL : https://patchwork.freedesktop.org/series/108686/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12148_full -> Patchwork_108686v1_full

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/gt: Bump the reset-failure timeout to 60s (rev2)

2022-09-16 Thread Patchwork
== Series Details == Series: drm/i915/gt: Bump the reset-failure timeout to 60s (rev2) URL : https://patchwork.freedesktop.org/series/108677/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12148_full -> Patchwork_108677v2_full

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/debugfs: Fix perf_limit_reasons debugfs

2022-09-16 Thread Patchwork
== Series Details == Series: drm/i915/debugfs: Fix perf_limit_reasons debugfs URL : https://patchwork.freedesktop.org/series/108686/ State : success == Summary == CI Bug Log - changes from CI_DRM_12148 -> Patchwork_108686v1 Summary ---

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/debugfs: Fix perf_limit_reasons debugfs

2022-09-16 Thread Patchwork
== Series Details == Series: drm/i915/debugfs: Fix perf_limit_reasons debugfs URL : https://patchwork.freedesktop.org/series/108686/ State : warning == Summary == Error: dim checkpatch failed 86d50030a683 drm/i915/debugfs: Fix perf_limit_reasons debugfs -:10: WARNING:COMMIT_LOG_LONG_LINE:

[Intel-gfx] [PATCH] drm/i915/debugfs: Fix perf_limit_reasons debugfs

2022-09-16 Thread Ashutosh Dixit
Register GT0_PERF_LIMIT_REASONS (0x1381a8) is available only for Gen11+. On Gen < 5 igt@debugfs_test@read_all_entries results in the following oops: <1> [88.829420] BUG: unable to handle page fault for address: c9bb81a8 <1> [88.829438] #PF: supervisor read access in kernel mode <1>

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: WARN if a port should use VBT provided vswing tables

2022-09-16 Thread Patchwork
== Series Details == Series: drm/i915: WARN if a port should use VBT provided vswing tables URL : https://patchwork.freedesktop.org/series/108678/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12147_full -> Patchwork_108678v1_full

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for Introduce struct cdclk_step

2022-09-16 Thread Dixit, Ashutosh
On Fri, 16 Sep 2022 18:35:13 -0700, Patchwork wrote: > Hi Lakshmi, > Series: Introduce struct cdclk_step > URL: https://patchwork.freedesktop.org/series/108685/ > State: failure > Details: > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108685v1/index.html > > CI Bug Log - changes

[Intel-gfx] ✗ Fi.CI.BAT: failure for Introduce struct cdclk_step

2022-09-16 Thread Patchwork
== Series Details == Series: Introduce struct cdclk_step URL : https://patchwork.freedesktop.org/series/108685/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12148 -> Patchwork_108685v1 Summary --- **FAILURE**

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Introduce struct cdclk_step

2022-09-16 Thread Patchwork
== Series Details == Series: Introduce struct cdclk_step URL : https://patchwork.freedesktop.org/series/108685/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Introduce struct cdclk_step

2022-09-16 Thread Patchwork
== Series Details == Series: Introduce struct cdclk_step URL : https://patchwork.freedesktop.org/series/108685/ State : warning == Summary == Error: dim checkpatch failed 23515dff4937 drm/i915/display Add dg2_prog_squash_ctl() helper 4380da21d9ee drm/i915/display: add cdclk action struct to

[Intel-gfx] [PATCH 6/6] drm/i915/display: Dump the new cdclk config values

2022-09-16 Thread Anusha Srivatsa
Add a helper function to get stringify values of the desired cdclk action and dump it with rest of the cdclk config values Signed-off-by: Anusha Srivatsa --- drivers/gpu/drm/i915/display/intel_cdclk.c | 18 -- 1 file changed, 16 insertions(+), 2 deletions(-) diff --git

[Intel-gfx] [PATCH 1/6] drm/i915/display Add dg2_prog_squash_ctl() helper

2022-09-16 Thread Anusha Srivatsa
Modularising steps and moving them out of bxt_set_cdclk(). Signed-off-by: Anusha Srivatsa --- drivers/gpu/drm/i915/display/intel_cdclk.c | 23 +- 1 file changed, 14 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_cdclk.c

[Intel-gfx] [PATCH 5/6] drm/i915/display: Embed the new struct steps for modeset

2022-09-16 Thread Anusha Srivatsa
Populate the new struct steps for the legacy modeset case. Signed-off-by: Anusha Srivatsa --- drivers/gpu/drm/i915/display/intel_cdclk.c | 18 +- drivers/gpu/drm/i915/display/intel_cdclk.h | 2 +- 2 files changed, 14 insertions(+), 6 deletions(-) diff --git

[Intel-gfx] [PATCH 2/6] drm/i915/display: add cdclk action struct to cdclk_config

2022-09-16 Thread Anusha Srivatsa
The struct has the action to be performed - squash, crawl or modeset and the corresponding cdclk which is the desired cdclk. This is the structure that gets populated during atomic check once it is determined what the cdclk change looks like Signed-off-by: Anusha Srivatsa ---

[Intel-gfx] [PATCH 3/6] drm/i915/display: Embed the new struct steps for squashing

2022-09-16 Thread Anusha Srivatsa
Populate the new struct steps for squash case. Signed-off-by: Anusha Srivatsa --- drivers/gpu/drm/i915/display/intel_cdclk.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/display/intel_cdclk.c b/drivers/gpu/drm/i915/display/intel_cdclk.c index

[Intel-gfx] [PATCH 4/6] drm/i915/display: Embed the new struct steps for crawling

2022-09-16 Thread Anusha Srivatsa
Populate the new struct steps for crawl case. Signed-off-by: Anusha Srivatsa --- drivers/gpu/drm/i915/display/intel_cdclk.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/display/intel_cdclk.c b/drivers/gpu/drm/i915/display/intel_cdclk.c index

[Intel-gfx] [PATCH 0/6] Introduce struct cdclk_step

2022-09-16 Thread Anusha Srivatsa
This is a prep series for the actual cdclk refactoring that will be sent following this. Idea is to have a struct - cdclk_step that holds the following: - cdclk action (squash, crawl or modeset) - cdclk frequency which gets populated in atomic check. Driver uses the populated values during atomic

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Improvements to stolen memory setup (rev3)

2022-09-16 Thread Patchwork
== Series Details == Series: drm/i915: Improvements to stolen memory setup (rev3) URL : https://patchwork.freedesktop.org/series/108620/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12146_full -> Patchwork_108620v3_full

[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [1/3] drm/i915: Nuke stale plane cdclk ratio FIXMEs

2022-09-16 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915: Nuke stale plane cdclk ratio FIXMEs URL : https://patchwork.freedesktop.org/series/108670/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12146_full -> Patchwork_108670v1_full

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gt: Bump the reset-failure timeout to 60s (rev2)

2022-09-16 Thread Patchwork
== Series Details == Series: drm/i915/gt: Bump the reset-failure timeout to 60s (rev2) URL : https://patchwork.freedesktop.org/series/108677/ State : success == Summary == CI Bug Log - changes from CI_DRM_12148 -> Patchwork_108677v2

[Intel-gfx] ✗ Fi.CI.BUILD: failure for drm/i915/display: Don't disable DDI/Transcoder when setting phy test pattern (rev3)

2022-09-16 Thread Patchwork
== Series Details == Series: drm/i915/display: Don't disable DDI/Transcoder when setting phy test pattern (rev3) URL : https://patchwork.freedesktop.org/series/108636/ State : failure == Summary == Error: patch https://patchwork.freedesktop.org/api/1.0/series/108636/revisions/3/mbox/ not

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/atomic: Lockless blocking commits

2022-09-16 Thread Patchwork
== Series Details == Series: drm/atomic: Lockless blocking commits URL : https://patchwork.freedesktop.org/series/108669/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12146_full -> Patchwork_108669v1_full Summary ---

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: WARN if a port should use VBT provided vswing tables

2022-09-16 Thread Patchwork
== Series Details == Series: drm/i915: WARN if a port should use VBT provided vswing tables URL : https://patchwork.freedesktop.org/series/108678/ State : success == Summary == CI Bug Log - changes from CI_DRM_12147 -> Patchwork_108678v1

Re: [Intel-gfx] [PATCH 18/19] drm/i915/guc: Support OA when Wa_16011777198 is enabled

2022-09-16 Thread Umesh Nerlige Ramappa
On Fri, Sep 16, 2022 at 02:41:01PM -0700, Dixit, Ashutosh wrote: On Tue, 23 Aug 2022 13:41:54 -0700, Umesh Nerlige Ramappa wrote: From: Vinay Belgaumkar There is a w/a to reset RCS/CCS before it goes into RC6. This breaks OA. Fix it by disabling RC6. Need to mention DG2 in the commit

Re: [Intel-gfx] [PATCH 18/19] drm/i915/guc: Support OA when Wa_16011777198 is enabled

2022-09-16 Thread Dixit, Ashutosh
On Tue, 23 Aug 2022 13:41:54 -0700, Umesh Nerlige Ramappa wrote: > > From: Vinay Belgaumkar > > There is a w/a to reset RCS/CCS before it goes into RC6. This breaks > OA. Fix it by disabling RC6. Need to mention DG2 in the commit message? > Signed-off-by: Vinay Belgaumkar > --- >

Re: [Intel-gfx] [PATCH v2] drm/i915/display: Don't disable DDI/Transcoder when setting phy test pattern

2022-09-16 Thread Taylor, Clinton A
Reviewed-by: Clint Taylor -Clint From: Intel-gfx on behalf of Khaled Almahallawy Sent: Friday, September 16, 2022 2:25 PM To: intel-gfx@lists.freedesktop.org Subject: [Intel-gfx] [PATCH v2] drm/i915/display: Don't disable DDI/Transcoder when setting phy

[Intel-gfx] [PATCH v2] drm/i915/display: Don't disable DDI/Transcoder when setting phy test pattern

2022-09-16 Thread Khaled Almahallawy
Bspecs has updated recently to remove the restriction to disable DDI/Transcoder before setting PHY test pattern. This update is to address PHY compliance test failures observed on a port with LTTPR. The issue is that when Transc. is disabled, the main link signals fed to LTTPR will be dropped

[Intel-gfx] [CI] PR for new GuC v70.5.1 and GuC/HuC with new names

2022-09-16 Thread John . C . Harrison
The following changes since commit f09bebf31b0590bdc875d7236aa705279510cfd0: amdgpu: update yellow carp DMCUB firmware (2022-09-13 08:02:23 -0400) are available in the Git repository at: git://anongit.freedesktop.org/drm/drm-firmware guc_70.5.1_huc_nover for you to fetch changes up to

Re: [Intel-gfx] [PATCH 16/19] drm/i915/perf: Apply Wa_18013179988

2022-09-16 Thread Dixit, Ashutosh
On Fri, 16 Sep 2022 13:25:17 -0700, Umesh Nerlige Ramappa wrote: > > On Fri, Sep 16, 2022 at 12:57:19PM -0700, Dixit, Ashutosh wrote: > > On Fri, 16 Sep 2022 11:56:04 -0700, Umesh Nerlige Ramappa wrote: > >> > >> On Thu, Sep 15, 2022 at 10:16:30PM -0700, Dixit, Ashutosh wrote: > >> > On Tue, 23

[Intel-gfx] [PATCH] drm/i915/gt: Bump the reset-failure timeout to 60s

2022-09-16 Thread Ashutosh Dixit
From: Chris Wilson If attempting to perform a GT reset takes long than 5 seconds (including resetting the display for gen3/4), then we declare all hope lost and discard all user work and wedge the device to prevent further misbehaviour. 5 seconds is too short a time for such drastic action, as

[Intel-gfx] [PATCH v2] drm/i915: WARN if a port should use VBT provided vswing tables

2022-09-16 Thread Ville Syrjala
From: Ville Syrjälä We don't parse the VBT vswing/preemphassis tables at all currently. Let's WARN if a port wants to use them so we get a heads up that whether we really need to implement this stuff or not. My current stash contains no VBTs with this bit set. v2: Move to print_ddi_port()

Re: [Intel-gfx] [topic/core-for-CI] Revert "iommu/dma: Fix race condition during iova_domain initialization"

2022-09-16 Thread Lucas De Marchi
On Fri, Sep 16, 2022 at 02:24:00PM +0200, Karolina Drobnik wrote: On 14.09.2022 17:54, Robin Murphy wrote: On 2022-09-14 16:01, Lucas De Marchi wrote: On Wed, Sep 14, 2022 at 02:40:45PM +0200, Karolina Drobnik wrote: This reverts commit ac9a5d522bb80be50ea84965699e1c8257d745ce. This change

Re: [Intel-gfx] [PATCH 16/19] drm/i915/perf: Apply Wa_18013179988

2022-09-16 Thread Umesh Nerlige Ramappa
On Fri, Sep 16, 2022 at 12:57:19PM -0700, Dixit, Ashutosh wrote: On Fri, 16 Sep 2022 11:56:04 -0700, Umesh Nerlige Ramappa wrote: On Thu, Sep 15, 2022 at 10:16:30PM -0700, Dixit, Ashutosh wrote: > On Tue, 23 Aug 2022 13:41:52 -0700, Umesh Nerlige Ramappa wrote: >> > > Hi Umesh, > >> OA reports

[Intel-gfx] [PATCH] drm/i915/gt: Bump the reset-failure timeout to 60s

2022-09-16 Thread Ashutosh Dixit
From: Chris Wilson If attempting to perform a GT reset takes long than 5 seconds (including resetting the display for gen3/4), then we declare all hope lost and discard all user work and wedge the device to prevent further misbehaviour. 5 seconds is too short a time for such drastic action, as

Re: [Intel-gfx] [PATCH 16/19] drm/i915/perf: Apply Wa_18013179988

2022-09-16 Thread Dixit, Ashutosh
On Fri, 16 Sep 2022 11:56:04 -0700, Umesh Nerlige Ramappa wrote: > > On Thu, Sep 15, 2022 at 10:16:30PM -0700, Dixit, Ashutosh wrote: > > On Tue, 23 Aug 2022 13:41:52 -0700, Umesh Nerlige Ramappa wrote: > >> > > > > Hi Umesh, > > > >> OA reports in the OA buffer contain an OA timestamp field that

Re: [Intel-gfx] [PATCH 1/1] drm/i915/uc: Update to latest GuC and use new-format GuC/HuC names

2022-09-16 Thread John Harrison
On 9/16/2022 02:10, Tvrtko Ursulin wrote: On 15/09/2022 21:03, John Harrison wrote: On 9/15/2022 01:59, Tvrtko Ursulin wrote: Hi, On 15/09/2022 00:46, john.c.harri...@intel.com wrote: From: John Harrison Going forwards, the intention is for GuC firmware files to be named for their major

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Improvements to stolen memory setup (rev3)

2022-09-16 Thread Patchwork
== Series Details == Series: drm/i915: Improvements to stolen memory setup (rev3) URL : https://patchwork.freedesktop.org/series/108620/ State : success == Summary == CI Bug Log - changes from CI_DRM_12146 -> Patchwork_108620v3 Summary

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [CI,1/2] drm/i915/hotplug: move hotplug storm debugfs to intel_hotplug.c

2022-09-16 Thread Patchwork
== Series Details == Series: series starting with [CI,1/2] drm/i915/hotplug: move hotplug storm debugfs to intel_hotplug.c URL : https://patchwork.freedesktop.org/series/108656/ State : success == Summary == CI Bug Log - changes from CI_DRM_12145_full -> Patchwork_108656v1_full

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Improvements to stolen memory setup (rev3)

2022-09-16 Thread Patchwork
== Series Details == Series: drm/i915: Improvements to stolen memory setup (rev3) URL : https://patchwork.freedesktop.org/series/108620/ State : warning == Summary == Error: dim checkpatch failed bb8b354377a8 drm/i915: Add missing mask when reading GEN12_DSMBASE d7d097ac0186 drm/i915: Split

Re: [Intel-gfx] [PATCH 16/19] drm/i915/perf: Apply Wa_18013179988

2022-09-16 Thread Umesh Nerlige Ramappa
On Fri, Sep 16, 2022 at 08:22:40AM -0700, Dixit, Ashutosh wrote: On Thu, 15 Sep 2022 22:16:30 -0700, Dixit, Ashutosh wrote: On Tue, 23 Aug 2022 13:41:52 -0700, Umesh Nerlige Ramappa wrote: > Hi Umesh, > OA reports in the OA buffer contain an OA timestamp field that helps > user calculate

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/3] drm/i915: Nuke stale plane cdclk ratio FIXMEs

2022-09-16 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915: Nuke stale plane cdclk ratio FIXMEs URL : https://patchwork.freedesktop.org/series/108670/ State : success == Summary == CI Bug Log - changes from CI_DRM_12146 -> Patchwork_108670v1

Re: [Intel-gfx] [PATCH 16/19] drm/i915/perf: Apply Wa_18013179988

2022-09-16 Thread Umesh Nerlige Ramappa
On Thu, Sep 15, 2022 at 10:16:30PM -0700, Dixit, Ashutosh wrote: On Tue, 23 Aug 2022 13:41:52 -0700, Umesh Nerlige Ramappa wrote: Hi Umesh, OA reports in the OA buffer contain an OA timestamp field that helps user calculate delta between 2 OA reports. The calculation relies on the CS

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/3] drm/i915: Nuke stale plane cdclk ratio FIXMEs

2022-09-16 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915: Nuke stale plane cdclk ratio FIXMEs URL : https://patchwork.freedesktop.org/series/108670/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/atomic: Lockless blocking commits

2022-09-16 Thread Patchwork
== Series Details == Series: drm/atomic: Lockless blocking commits URL : https://patchwork.freedesktop.org/series/108669/ State : success == Summary == CI Bug Log - changes from CI_DRM_12146 -> Patchwork_108669v1 Summary ---

Re: [Intel-gfx] [PATCH v5 0/2] Fix TLB invalidate issues with Broadwell [preempt-rt regression]

2022-09-16 Thread Paul Gortmaker
[[PATCH v5 0/2] Fix TLB invalidate issues with Broadwell] On 12/07/2022 (Tue 16:21) Mauro Carvalho Chehab wrote: > i915 selftest hangcheck is causing the i915 driver timeouts, as reported > by Intel CI bot: > >

Re: [Intel-gfx] [PATCH 14/19] drm/i915/perf: Add Wa_1608133521:dg2

2022-09-16 Thread Umesh Nerlige Ramappa
On Thu, Sep 15, 2022 at 06:21:55PM -0700, Dixit, Ashutosh wrote: On Tue, 23 Aug 2022 13:41:50 -0700, Umesh Nerlige Ramappa wrote: DG2 introduces 64 bit counters and OA reports that have 64 bit values for fields in the report header - report_id, timestamp, context_id and gpu ticks. i915 uses

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/atomic: Lockless blocking commits

2022-09-16 Thread Patchwork
== Series Details == Series: drm/atomic: Lockless blocking commits URL : https://patchwork.freedesktop.org/series/108669/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Add HWMON support (rev6)

2022-09-16 Thread Patchwork
== Series Details == Series: drm/i915: Add HWMON support (rev6) URL : https://patchwork.freedesktop.org/series/104278/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12146 -> Patchwork_104278v6 Summary ---

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Add HWMON support (rev6)

2022-09-16 Thread Patchwork
== Series Details == Series: drm/i915: Add HWMON support (rev6) URL : https://patchwork.freedesktop.org/series/104278/ State : warning == Summary == Error: dim checkpatch failed 5f9791e75d29 drm/i915/hwmon: Add HWMON infrastructure Traceback (most recent call last): File

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: Add HWMON support (rev6)

2022-09-16 Thread Patchwork
== Series Details == Series: drm/i915: Add HWMON support (rev6) URL : https://patchwork.freedesktop.org/series/104278/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] [PATCH v2 2/3] drm/i915: Split i915_gem_init_stolen()

2022-09-16 Thread Lucas De Marchi
Add some helpers: adjust_stolen(), request_smem_stolen_() and init_reserved_stolen() that are now called by i915_gem_init_stolen() to initialize each part of the Data Stolen Memory region. Main goal is to split the reserved part within the stolen, also known as WOPCM, as its calculation changes

[Intel-gfx] [PATCH v2 1/3] drm/i915: Add missing mask when reading GEN12_DSMBASE

2022-09-16 Thread Lucas De Marchi
DSMBASE register is defined so BDSM bitfield contains the bits 63 to 20 of the base address of stolen. For the supported platforms bits 0-19 are zero but that may not be true in future. Add the missing mask. v2: Use REG_GENMASK64() Acked-by: Aravind Iddamsetty Reviewed-by: Caz Yokoyama

[Intel-gfx] [PATCH v2 3/3] drm/i915/dgfx: Make failure to setup stolen non-fatal

2022-09-16 Thread Lucas De Marchi
There is no reason to consider the setup of Data Stolen Memory fatal on dgfx and non-fatal on integrated. Move the debug and error propagation around so both have the same behavior: non-fatal. Before this change, loading i915 on a system with TGL + DG2 would result in just TGL succeeding the

[Intel-gfx] [PATCH v2 0/3] drm/i915: Improvements to stolen memory setup

2022-09-16 Thread Lucas De Marchi
Better split, document, and make the code paths for integrated and discrete more similar. v2: - s/GENMASK/REG_GENMASK64/ where appropriate - Fix comment Signed-off-by: Lucas De Marchi --- Lucas De Marchi (3): drm/i915: Add missing mask when reading GEN12_DSMBASE drm/i915: Split

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/gem: Really move i915_gem_context.link under ref protection (rev4)

2022-09-16 Thread Patchwork
== Series Details == Series: drm/i915/gem: Really move i915_gem_context.link under ref protection (rev4) URL : https://patchwork.freedesktop.org/series/105975/ State : success == Summary == CI Bug Log - changes from CI_DRM_12145_full -> Patchwork_105975v4_full

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/display: remove ipc_enabled from struct drm_i915_private

2022-09-16 Thread Patchwork
== Series Details == Series: drm/i915/display: remove ipc_enabled from struct drm_i915_private URL : https://patchwork.freedesktop.org/series/108654/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12145_full -> Patchwork_108654v1_full

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/gem: Really move i915_gem_context.link under ref protection (rev4)

2022-09-16 Thread Janusz Krzysztofik
On Friday, 16 September 2022 17:12:30 CEST Patchwork wrote: > == Series Details == > > Series: drm/i915/gem: Really move i915_gem_context.link under ref protection > (rev4) > URL : https://patchwork.freedesktop.org/series/105975/ > State : failure > > == Summary == > > CI Bug Log - changes

[Intel-gfx] [PATCH 3/3] drm/i915: Mark FBC B gone if pipe B is gone

2022-09-16 Thread Ville Syrjala
From: Ville Syrjälä If pipe B is fused off we also shouldn't have FBC B. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/intel_device_info.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/i915/intel_device_info.c b/drivers/gpu/drm/i915/intel_device_info.c index

[Intel-gfx] [PATCH 1/3] drm/i915: Nuke stale plane cdclk ratio FIXMEs

2022-09-16 Thread Ville Syrjala
From: Ville Syrjälä The plane ratio stuff got implemented in commit bb6ae9e653dc ("drm/i915: Allow planes to declare their minimum acceptable cdclk") so these FIXMEs have no business being here. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_cdclk.c | 8 1 file

[Intel-gfx] [PATCH 2/3] drm/i915/fbc: Remove stale FIXME

2022-09-16 Thread Ville Syrjala
From: Ville Syrjälä Remove the old tales about 90/270 degree rotation effectively preventing FBC. That hasn't been true since we stopped demanding the fence is present in commit 691f7ba58d52 ("drm/i915/display/fbc: Make fences a nice-to-have for GEN9+") Signed-off-by: Ville Syrjälä ---

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/psr: Do not re-activate PSR if there was a PSR aux error

2022-09-16 Thread Patchwork
== Series Details == Series: drm/i915/psr: Do not re-activate PSR if there was a PSR aux error URL : https://patchwork.freedesktop.org/series/108653/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12145_full -> Patchwork_108653v1_full

[Intel-gfx] [PATCH 4/4] drm/i915: Make blocking commits lockless

2022-09-16 Thread Ville Syrjala
From: Ville Syrjälä Make blocking commits execute locklessly (just as nonblocking commits do) by scheduling them onto the workqueues as well. There will be a later flush_work() done by whoever called the commit hook to make sure the blocking behaviour of the ioctl/etc. is preserved. I also

[Intel-gfx] [PATCH 3/4] drm/atomic: Allow lockless blocking commits

2022-09-16 Thread Ville Syrjala
From: Ville Syrjälä The easiest way to execute blocking commits locklessly is to just schedule them onto the workqueue excatly as we do for nonblocking commits. And to preserve the blocking behaviour of the ioctl we just flush the work before exiting the kernel. We do need to reorder the

[Intel-gfx] [PATCH 2/4] drm/i915: Don't reuse commit_work for the cleanup

2022-09-16 Thread Ville Syrjala
From: Ville Syrjälä Currently we reuse the commit_work for a later cleanup step. Let's not do that so that atomic ioctl handler won't accidentally wait for the cleanup work when it really wants to just wait on the commit_tail() part. We'll just add another work struct for the cleanup. Cc:

[Intel-gfx] [PATCH 1/4] drm/atomic: Treat a nonblocking commit following a blocking commit as blocking commit

2022-09-16 Thread Ville Syrjala
From: Ville Syrjälä Currently a nonblocking commit will actually block if it is preceded by a blocking commit. It just happens block on the mutex rather than on the completion. I shall call these as not-actually-nonblocking commits. I would like to make blocking commits execute locklessly, just

[Intel-gfx] [PATCH 0/4] drm/atomic: Lockless blocking commits

2022-09-16 Thread Ville Syrjala
From: Ville Syrjälä I've talked about making blocking commits lockless a few times in the past, so here's finally an attempt at it. The main benefit I see from this is that TEST_ONLY commits no longer getting blocked on the mutexes by parallel blocking commits. I have a small test here that

Re: [Intel-gfx] [PATCH v1 3/4] drm/i915: Split i915_gem_init_stolen()

2022-09-16 Thread Lucas De Marchi
On Fri, Sep 16, 2022 at 05:50:33PM +0530, Iddamsetty, Aravind wrote: On 16-09-2022 02:09, Lucas De Marchi wrote: Add some helpers: adjust_stolen(), request_smem_stolen_() and init_reserved_stolen() that are now called by i915_gem_init_stolen() to initialize each part of the Data Stolen Memory

[Intel-gfx] ✓ Fi.CI.IGT: success for Fix HFVSDB parsing (rev2)

2022-09-16 Thread Patchwork
== Series Details == Series: Fix HFVSDB parsing (rev2) URL : https://patchwork.freedesktop.org/series/107144/ State : success == Summary == CI Bug Log - changes from CI_DRM_12145_full -> Patchwork_107144v2_full Summary ---

Re: [Intel-gfx] [PATCH 0/3] i915: freq caps and perf_limit_reasons changes for MTL

2022-09-16 Thread Rodrigo Vivi
On Sat, Sep 10, 2022 at 07:38:41AM -0700, Ashutosh Dixit wrote: > Since https://patchwork.freedesktop.org/series/107908/ is now merged, > rebase this series on latest drm-tip and post a clean series. pushed to drm-intel-gt-next thansk for the patches > > Ashutosh Dixit (2): > drm/i915/mtl:

Re: [Intel-gfx] [PATCH 1/1] drm/i915/guc: Delay disabling guc_id scheduling for better hysteresis

2022-09-16 Thread Ceraolo Spurio, Daniele
On 9/16/2022 1:58 AM, Tvrtko Ursulin wrote: On 16/09/2022 08:53, Teres Alexis, Alan Previn wrote: On Thu, 2022-09-15 at 09:48 +0100, Tvrtko Ursulin wrote: On 15/09/2022 03:12, Alan Previn wrote: From: Matthew Brost Add a delay, configurable via debugfs (default 34ms), to disable ---

Re: [Intel-gfx] [PATCH] drm/i915: fix device info for devices without display

2022-09-16 Thread Lucas De Marchi
On Fri, Sep 16, 2022 at 11:26:42AM +0300, Jani Nikula wrote: Commit 00c6cbfd4e8a ("drm/i915: move pipe_mask and cpu_transcoder_mask to runtime info") moved the pipe_mask member from struct intel_device_info to intel_runtime_info, but overlooked some of our platforms initializing device info

Re: [Intel-gfx] [PATCH 16/19] drm/i915/perf: Apply Wa_18013179988

2022-09-16 Thread Dixit, Ashutosh
On Thu, 15 Sep 2022 22:16:30 -0700, Dixit, Ashutosh wrote: > > On Tue, 23 Aug 2022 13:41:52 -0700, Umesh Nerlige Ramappa wrote: > > > > Hi Umesh, > > > OA reports in the OA buffer contain an OA timestamp field that helps > > user calculate delta between 2 OA reports. The calculation relies on the

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/gem: Really move i915_gem_context.link under ref protection (rev4)

2022-09-16 Thread Patchwork
== Series Details == Series: drm/i915/gem: Really move i915_gem_context.link under ref protection (rev4) URL : https://patchwork.freedesktop.org/series/105975/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12145_full -> Patchwork_105975v4_full

Re: [Intel-gfx] ✓ Fi.CI.IGT: success for Further multi-gt handling (rev2)

2022-09-16 Thread Matt Roper
On Fri, Sep 16, 2022 at 06:38:28AM +, Patchwork wrote: > == Series Details == > > Series: Further multi-gt handling (rev2) > URL : https://patchwork.freedesktop.org/series/108577/ > State : success > > == Summary == > > CI Bug Log - changes from CI_DRM_12143_full ->

[Intel-gfx] [PATCH 7/7] drm/i915/hwmon: Extend power/energy for XEHPSDV

2022-09-16 Thread Badal Nilawar
From: Dale B Stimson Extend hwmon power/energy for XEHPSDV especially per gt level energy usage. v2: Update to latest HWMON spec (Ashutosh) v3: Fixed review comments (Ashutosh) Signed-off-by: Ashutosh Dixit Signed-off-by: Dale B Stimson Signed-off-by: Badal Nilawar Acked-by: Guenter Roeck

[Intel-gfx] [PATCH 6/7] drm/i915/hwmon: Expose power1_max_interval

2022-09-16 Thread Badal Nilawar
From: Ashutosh Dixit Expose power1_max_interval, that is the tau corresponding to PL1. Some bit manipulation is needed because of the format of PKG_PWR_LIM_1_TIME in GT0_PACKAGE_RAPL_LIMIT register (1.x * power(2,y)). v2: Update date and kernel version in Documentation (Badal) v3: Cleaned up

[Intel-gfx] [PATCH 5/7] drm/i915/hwmon: Expose card reactive critical power

2022-09-16 Thread Badal Nilawar
From: Ashutosh Dixit Expose the card reactive critical (I1) power. I1 is exposed as power1_crit in microwatts (typically for client products) or as curr1_crit in milliamperes (typically for server). v2: Add curr1_crit functionality (Ashutosh) v3: - Use HWMON_CHANNEL_INFO to define

[Intel-gfx] [PATCH 1/7] drm/i915/hwmon: Add HWMON infrastructure

2022-09-16 Thread Badal Nilawar
From: Dale B Stimson The i915 HWMON module will be used to expose voltage, power and energy values for dGfx. Here we set up i915 hwmon infrastructure including i915 hwmon registration, basic data structures and functions. v2: - Create HWMON infra patch (Ashutosh) - Fixed review comments

[Intel-gfx] [PATCH 4/7] drm/i915/hwmon: Show device level energy usage

2022-09-16 Thread Badal Nilawar
From: Dale B Stimson Use i915 HWMON to display device level energy input. v2: - Updated the date and kernel version in feature description v3: - Cleaned up hwm_energy function and removed unused function i915_hwmon_energy_status_get (Ashutosh) - Updated date, kernel version in

[Intel-gfx] [PATCH 3/7] drm/i915/hwmon: Power PL1 limit and TDP setting

2022-09-16 Thread Badal Nilawar
From: Dale B Stimson Use i915 HWMON to display/modify dGfx power PL1 limit and TDP setting. v2: - Fix review comments (Ashutosh) - Do not restore power1_max upon module unload/load sequence because on production systems modules are always loaded and not unloaded/reloaded (Ashutosh)

[Intel-gfx] [PATCH 2/7] drm/i915/hwmon: Add HWMON current voltage support

2022-09-16 Thread Badal Nilawar
From: Riana Tauro Use i915 HWMON subsystem to display current input voltage. v2: - Updated date and kernel version in feature description - Fixed review comments (Ashutosh) v3: Use macro HWMON_CHANNEL_INFO to define hwmon channel (Guenter) v4: - Fixed review comments (Ashutosh) - Use

[Intel-gfx] [PATCH 0/7] drm/i915: Add HWMON support

2022-09-16 Thread Badal Nilawar
This series adds the HWMON support for DGFX Test-with: 20220914140721.3500129-1-riana.ta...@intel.com v2: - Reorganized series. Created first patch as infrastructure patch followed by feature patches. (Ashutosh) - Fixed review comments (Jani) - Fixed review comments (Ashutosh) v3: -

Re: [Intel-gfx] [PATCH] drm/i915: Split GAM and MSLICE steering

2022-09-16 Thread Matt Roper
On Fri, Sep 16, 2022 at 10:02:32AM +0100, Tvrtko Ursulin wrote: > > On 16/09/2022 02:43, Matt Roper wrote: > > Although the bspec lists several MMIO ranges as "MSLICE," it turns out > > that a subset of these are of a "GAM" subclass that has unique rules and > > doesn't followed regular mslice

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/2] drm/i915/pps: Add get_pps_idx() hook as part of pps_get_register() cleanup

2022-09-16 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/pps: Add get_pps_idx() hook as part of pps_get_register() cleanup URL : https://patchwork.freedesktop.org/series/108643/ State : success == Summary == CI Bug Log - changes from CI_DRM_12145_full -> Patchwork_108643v1_full

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [CI,1/2] drm/i915/hotplug: move hotplug storm debugfs to intel_hotplug.c

2022-09-16 Thread Patchwork
== Series Details == Series: series starting with [CI,1/2] drm/i915/hotplug: move hotplug storm debugfs to intel_hotplug.c URL : https://patchwork.freedesktop.org/series/108656/ State : success == Summary == CI Bug Log - changes from CI_DRM_12145 -> Patchwork_108656v1

Re: [Intel-gfx] [PATCH v3 01/37] drm/i915: fix kernel-doc trivial warnings on i915/*.[ch] files

2022-09-16 Thread Gwan-gyeong Mun
On 9/9/22 10:34 AM, Mauro Carvalho Chehab wrote: There are several trivial warnings there, due to trivial things: - lack of function name at the kerneldoc markup; - renamed functions; - wrong parameter syntax. Fix such warnings:

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [CI,1/2] drm/i915/hotplug: move hotplug storm debugfs to intel_hotplug.c

2022-09-16 Thread Patchwork
== Series Details == Series: series starting with [CI,1/2] drm/i915/hotplug: move hotplug storm debugfs to intel_hotplug.c URL : https://patchwork.freedesktop.org/series/108656/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be

Re: [Intel-gfx] [PATCH] drm/i915/psr: Do not re-activate PSR if there was a PSR aux error

2022-09-16 Thread Hogander, Jouni
On Fri, 2022-09-16 at 13:22 +, Souza, Jose wrote: > On Fri, 2022-09-16 at 14:08 +0300, Jouni Högander wrote: > > If there is a PSR aux error sink is marked as not reliable > > and PSR is permantently disabled. > > > > Current code is activating PSR again even there was PSR aux error. > > Fix

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: fix device info for devices without display

2022-09-16 Thread Patchwork
== Series Details == Series: drm/i915: fix device info for devices without display URL : https://patchwork.freedesktop.org/series/108642/ State : success == Summary == CI Bug Log - changes from CI_DRM_12145_full -> Patchwork_108642v1_full

Re: [Intel-gfx] [PATCH] drm/i915/psr: Do not re-activate PSR if there was a PSR aux error

2022-09-16 Thread Souza, Jose
On Fri, 2022-09-16 at 14:08 +0300, Jouni Högander wrote: > If there is a PSR aux error sink is marked as not reliable > and PSR is permantently disabled. > > Current code is activating PSR again even there was PSR aux error. > Fix this by skipping intel_psr_activate when PSR aux error is >

[Intel-gfx] [CI 1/2] drm/i915/hotplug: move hotplug storm debugfs to intel_hotplug.c

2022-09-16 Thread Jani Nikula
The debugfs should be where the implementation details are. v2: Rebase Signed-off-by: Jani Nikula Reviewed-by: Ville Syrjälä --- .../drm/i915/display/intel_display_debugfs.c | 160 + drivers/gpu/drm/i915/display/intel_hotplug.c | 166 ++

[Intel-gfx] [CI 2/2] drm/i915/hotplug: refactor hotplug init slightly

2022-09-16 Thread Jani Nikula
Rename intel_hpd_init_work() to the more generic intel_hpd_init_early(), and move the hotplug storm initialization there. This lets us move the HPD_STORM_DEFAULT_THRESHOLD macro to intel_hotplug.c too. Signed-off-by: Jani Nikula Reviewed-by: Ville Syrjälä ---

Re: [Intel-gfx] [PATCH v3 02/37] drm/i915: display: fix kernel-doc markup warnings

2022-09-16 Thread Gwan-gyeong Mun
Looks good to me. Reviewed-by: Gwan-gyeong Mun On 9/9/22 10:34 AM, Mauro Carvalho Chehab wrote: There are a couple of issues at i915 display kernel-doc markups: drivers/gpu/drm/i915/display/intel_display_debugfs.c:2238: warning: Function parameter or member 'intel_connector' not

Re: [Intel-gfx] [topic/core-for-CI] Revert "iommu/dma: Fix race condition during iova_domain initialization"

2022-09-16 Thread Karolina Drobnik
On 14.09.2022 17:54, Robin Murphy wrote: On 2022-09-14 16:01, Lucas De Marchi wrote: On Wed, Sep 14, 2022 at 02:40:45PM +0200, Karolina Drobnik wrote: This reverts commit ac9a5d522bb80be50ea84965699e1c8257d745ce. This change introduces a regression on Alder Lake that completely blocks

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/display: remove ipc_enabled from struct drm_i915_private

2022-09-16 Thread Patchwork
== Series Details == Series: drm/i915/display: remove ipc_enabled from struct drm_i915_private URL : https://patchwork.freedesktop.org/series/108654/ State : success == Summary == CI Bug Log - changes from CI_DRM_12145 -> Patchwork_108654v1

Re: [Intel-gfx] [PATCH v1 3/4] drm/i915: Split i915_gem_init_stolen()

2022-09-16 Thread Iddamsetty, Aravind
On 16-09-2022 02:09, Lucas De Marchi wrote: > Add some helpers: adjust_stolen(), request_smem_stolen_() and > init_reserved_stolen() that are now called by i915_gem_init_stolen() to > initialize each part of the Data Stolen Memory region. Main goal is to > split the reserved part, also known as

[Intel-gfx] [PULL] drm-intel-next

2022-09-16 Thread Jani Nikula
Hi Dave & Daniel - The final feature pull for v6.1. drm-intel-next-2022-09-16-1: drm/i915 feature pull #2 for v6.1: Features and functionality: - More Meteorlake platform enabling (Radhakrishna, Imre, Madhumitha) - Allow seamless M/N changes on eDP panels that support it (Ville) - Switch DSC

Re: [Intel-gfx] [PATCH v3 2/2] drm/i915/gem: Really move i915_gem_context.link under ref protection

2022-09-16 Thread Gwan-gyeong Mun
Reviewed-by: Gwan-gyeong Mun On 9/16/22 12:24 PM, Janusz Krzysztofik wrote: From: Chris Wilson i915_perf assumes that it can use the i915_gem_context reference to protect its i915->gem.contexts.list iteration. However, this requires that we do not remove the context from the list until after

Re: [Intel-gfx] [PATCH v3 1/2] drm/i915/gem: Flush contexts on driver release

2022-09-16 Thread Gwan-gyeong Mun
Reviewed-by: Gwan-gyeong Mun On 9/16/22 12:24 PM, Janusz Krzysztofik wrote: Due to i915_perf assuming that it can use the i915_gem_context reference to protect its i915->gem.contexts.list iteration, we need to defer removal of the context from the list until last reference to the context is

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/display: remove ipc_enabled from struct drm_i915_private

2022-09-16 Thread Patchwork
== Series Details == Series: drm/i915/display: remove ipc_enabled from struct drm_i915_private URL : https://patchwork.freedesktop.org/series/108654/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

  1   2   >