Re: [Intel-gfx] [PATCH v2 1/2] drm/i915/guc: Properly initialise kernel contexts

2022-11-04 Thread Lucas De Marchi
On Wed, Nov 02, 2022 at 12:21:08PM -0700, john.c.harri...@intel.com wrote: From: John Harrison If a context has already been registered prior to first submission then context init code was not being called. The noticeable effect of that was the scheduling priority was left at zero (meaning

[Intel-gfx] ✗ Fi.CI.IGT: failure for KUnit issues - Was: [igt-dev] [PATCH RFC v2 8/8] drm/i915: check if current->mm is not NULL (rev2)

2022-11-04 Thread Patchwork
== Series Details == Series: KUnit issues - Was: [igt-dev] [PATCH RFC v2 8/8] drm/i915: check if current->mm is not NULL (rev2) URL : https://patchwork.freedesktop.org/series/110492/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12342_full -> Patchwork_110492v2_full

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Set PROBE_PREFER_ASYNCHRONOUS

2022-11-04 Thread Brian Norris
On Fri, Nov 04, 2022 at 02:38:03PM +, Matthew Auld wrote: > On Thu, 3 Nov 2022 at 00:14, Brian Norris wrote: > > I'm still curious about the reported failures, but maybe they require > > some particular sequence of tests? I also don't have the full > > igt-gpu-tools set running, so maybe they

[Intel-gfx] ✓ Fi.CI.BAT: success for Fix live busy stats selftest failure

2022-11-04 Thread Patchwork
== Series Details == Series: Fix live busy stats selftest failure URL : https://patchwork.freedesktop.org/series/110557/ State : success == Summary == CI Bug Log - changes from CI_DRM_12346 -> Patchwork_110557v1 Summary ---

[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [CI,1/2] Revert "freezer, sched: Rewrite core freezer logic fix"

2022-11-04 Thread Patchwork
== Series Details == Series: series starting with [CI,1/2] Revert "freezer, sched: Rewrite core freezer logic fix" URL : https://patchwork.freedesktop.org/series/110529/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12342_full -> Patchwork_110529v1_full

Re: [Intel-gfx] [PATCH 1/2] drm/i915/gt: Add GT oriented dmesg output

2022-11-04 Thread Ceraolo Spurio, Daniele
On 11/4/2022 10:25 AM, john.c.harri...@intel.com wrote: From: John Harrison When trying to analyse bug reports from CI, customers, etc. it can be difficult to work out exactly what is happening on which GT in a multi-GT system. So add GT oriented debug/error message wrappers. If used

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Fix live busy stats selftest failure

2022-11-04 Thread Patchwork
== Series Details == Series: Fix live busy stats selftest failure URL : https://patchwork.freedesktop.org/series/110557/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

Re: [Intel-gfx] [CI 11/15] drm/i915/huc: track delayed HuC load with a fence

2022-11-04 Thread Ceraolo Spurio, Daniele
On 11/4/2022 5:38 PM, Ceraolo Spurio, Daniele wrote: On 11/4/2022 4:26 PM, Brian Norris wrote: Hi, On Wed, Oct 19, 2022 at 10:54:34AM +0100, Tvrtko Ursulin wrote: Don't know if this is real or not yet, hit it while running selftests a bit. Something to keep an eye on. [ 2928.370577]

Re: [Intel-gfx] [CI 11/15] drm/i915/huc: track delayed HuC load with a fence

2022-11-04 Thread Ceraolo Spurio, Daniele
On 11/4/2022 4:26 PM, Brian Norris wrote: Hi, On Wed, Oct 19, 2022 at 10:54:34AM +0100, Tvrtko Ursulin wrote: Don't know if this is real or not yet, hit it while running selftests a bit. Something to keep an eye on. [ 2928.370577] ODEBUG: init destroyed (active state 0) object type:

[Intel-gfx] [PATCH 2/2] drm/i915/selftest: Bump up sample period for busy stats selftest

2022-11-04 Thread Umesh Nerlige Ramappa
Engine busyness samples around a 10ms period is failing with busyness ranging approx. from 87% to 115%. The expected range is +/- 5% of the sample period. When determining busyness of active engine, the GuC based engine busyness implementation relies on a 64 bit timestamp register read. The

[Intel-gfx] [PATCH 1/2] i915/uncore: Acquire fw before loop in intel_uncore_read64_2x32

2022-11-04 Thread Umesh Nerlige Ramappa
PMU reads the GT timestamp as a 2x32 mmio read and since upper and lower 32 bit registers are read in a loop, there is a latency involved between getting the GT timestamp and the CPU timestamp. As part of the resolution, refactor intel_uncore_read64_2x32 to acquire forcewake and uncore lock prior

[Intel-gfx] [PATCH 0/2] Fix live busy stats selftest failure

2022-11-04 Thread Umesh Nerlige Ramappa
Engine busyness samples around a 10ms period is failing with busyness ranging approx. from 87% to 115%. The expected range is +/- 5% of the sample period. When determining busyness of active engine, the GuC based engine busyness implementation relies on a 64 bit timestamp register read. The

Re: [Intel-gfx] [RFC][PATCH v3 00/33] timers: Use timer_shutdown*() before freeing timers

2022-11-04 Thread Guenter Roeck
On Fri, Nov 04, 2022 at 01:40:53AM -0400, Steven Rostedt wrote: > > Back in April, I posted an RFC patch set to help mitigate a common issue > where a timer gets armed just before it is freed, and when the timer > goes off, it crashes in the timer code without any evidence of who the > culprit

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915/display: Do both crawl and squash when changing cdclk

2022-11-04 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/display: Do both crawl and squash when changing cdclk URL : https://patchwork.freedesktop.org/series/110554/ State : success == Summary == CI Bug Log - changes from CI_DRM_12346 -> Patchwork_110554v1

Re: [Intel-gfx] [CI 11/15] drm/i915/huc: track delayed HuC load with a fence

2022-11-04 Thread Brian Norris
Hi, On Wed, Oct 19, 2022 at 10:54:34AM +0100, Tvrtko Ursulin wrote: > Don't know if this is real or not yet, hit it while running selftests a bit. > Something to keep an eye on. > > [ 2928.370577] ODEBUG: init destroyed (active state 0) object type: > i915_sw_fence hint:

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2] drm/i915/display: Do both crawl and squash when changing cdclk

2022-11-04 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/display: Do both crawl and squash when changing cdclk URL : https://patchwork.freedesktop.org/series/110554/ State : warning == Summary == Error: dim checkpatch failed a2db805524d6 drm/i915/display: Do both crawl and squash

[Intel-gfx] [PATCH 2/2] drm/i915/display: Add CDCLK Support for MTL

2022-11-04 Thread Anusha Srivatsa
As per bSpec MTL has 38.4 MHz Reference clock. Adding the cdclk tables and cdclk_funcs that MTL will use. v2: Revert to using bxt_get_cdclk() BSpec: 65243 Cc: Clint Taylor Signed-off-by: Anusha Srivatsa Reviewed-by: Clint Taylor --- drivers/gpu/drm/i915/display/intel_cdclk.c | 22

[Intel-gfx] [PATCH 1/2] drm/i915/display: Do both crawl and squash when changing cdclk

2022-11-04 Thread Anusha Srivatsa
From: Ville Syrjälä For MTL, changing cdclk from between certain frequencies has both squash and crawl. Use the current cdclk config and the new(desired) cdclk config to construtc a mid cdclk config. Set the cdclk twice: - Current cdclk -> mid cdclk - mid cdclk -> desired cdclk v2: Add check in

Re: [Intel-gfx] [mm-unstable PATCH v7 2/8] mm/hugetlb: make pud_huge() and follow_huge_pud() aware of non-present pud entry

2022-11-04 Thread Ville Syrjälä
On Sat, Nov 05, 2022 at 12:59:30AM +0900, Naoya Horiguchi wrote: > On Wed, Nov 02, 2022 at 10:51:40PM +0200, Ville Syrjälä wrote: > > On Thu, Jul 14, 2022 at 01:24:14PM +0900, Naoya Horiguchi wrote: > > > +/* > > > + * pud_huge() returns 1 if @pud is hugetlb related entry, that is normal > > > + *

Re: [Intel-gfx] [RFC][PATCH v3 00/33] timers: Use timer_shutdown*() before freeing timers

2022-11-04 Thread Guenter Roeck
On Fri, Nov 04, 2022 at 04:38:34PM -0400, Steven Rostedt wrote: > On Fri, 4 Nov 2022 15:42:09 -0400 > Steven Rostedt wrote: > [ ... ] > > > drivers/clocksource/timer-fttmr010.c: fttmr010->timer_shutdown(evt); > > drivers/clocksource/timer-fttmr010.c: fttmr010->timer_shutdown(evt); > >

Re: [Intel-gfx] [RFC][PATCH v3 00/33] timers: Use timer_shutdown*() before freeing timers

2022-11-04 Thread Guenter Roeck
On Fri, Nov 04, 2022 at 03:42:09PM -0400, Steven Rostedt wrote: > On Fri, 4 Nov 2022 12:22:32 -0700 > Guenter Roeck wrote: > > > Unfortunately the renaming caused some symbol conflicts. > > > > Global definition: timer_shutdown > > > > File Line > > 0 time.c93 static

Re: [Intel-gfx] [RFC][PATCH v3 00/33] timers: Use timer_shutdown*() before freeing timers

2022-11-04 Thread Steven Rostedt
On Fri, 4 Nov 2022 15:42:09 -0400 Steven Rostedt wrote: > $ git grep '\btimer_shutdown' > arch/arm/mach-spear/time.c:static inline void timer_shutdown(struct > clock_event_device *evt) > arch/arm/mach-spear/time.c: timer_shutdown(evt); > arch/arm/mach-spear/time.c: timer_shutdown(evt);

Re: [Intel-gfx] [PATCH 07/10] vfio-iommufd: Support iommufd for physical VFIO devices

2022-11-04 Thread Jason Gunthorpe
On Tue, Nov 01, 2022 at 08:21:20AM +, Tian, Kevin wrote: > > From: Jason Gunthorpe > > Sent: Wednesday, October 26, 2022 2:51 AM > > > > +int vfio_iommufd_bind(struct vfio_device *vdev, struct iommufd_ctx *ictx) > > +{ > > + u32 ioas_id; > > + u32 device_id; > > + int ret; > > + > > +

Re: [Intel-gfx] [RFC][PATCH v3 00/33] timers: Use timer_shutdown*() before freeing timers

2022-11-04 Thread Linus Torvalds
On Fri, Nov 4, 2022 at 12:42 PM Steven Rostedt wrote: > > Linus, should I also add any patches that has already been acked by the > respective maintainer? No, I'd prefer to keep only the ones that are 100% unambiguously not changing any semantics. Linus

Re: [Intel-gfx] KUnit issues - Was: [igt-dev] [PATCH RFC v2 8/8] drm/i915: check if current->mm is not NULL

2022-11-04 Thread Daniel Latypov
On Thu, Nov 3, 2022 at 8:23 AM Mauro Carvalho Chehab wrote: > > Hi, > > I'm facing a couple of issues when testing KUnit with the i915 driver. > > The DRM subsystem and the i915 driver has, for a long time, his own > way to do unit tests, which seems to be added before KUnit. > > I'm now checking

Re: [Intel-gfx] [PATCH v5] overflow: Introduce overflows_type() and castable_to_type()

2022-11-04 Thread Rasmus Villemoes
On 24/10/2022 22.11, Gwan-gyeong Mun wrote: > From: Kees Cook > > Implement a robust overflows_type() macro to test if a variable or > constant value would overflow another variable or type. This can be > used as a constant expression for static_assert() (which requires a > constant

Re: [Intel-gfx] KUnit issues - Was: [igt-dev] [PATCH RFC v2 8/8] drm/i915: check if current->mm is not NULL

2022-11-04 Thread Daniel Latypov
On Fri, Nov 4, 2022 at 12:50 AM Mauro Carvalho Chehab wrote: > > On Thu, 3 Nov 2022 15:43:26 -0700 > Daniel Latypov wrote: > > > On Thu, Nov 3, 2022 at 8:23 AM Mauro Carvalho Chehab > > wrote: > > > > > > Hi, > > > > > > I'm facing a couple of issues when testing KUnit with the i915 driver. > >

Re: [Intel-gfx] [PATCH v7 0/9] dyndbg: drm.debug adaptation

2022-11-04 Thread Jason Baron
On 10/31/22 6:11 PM, jim.cro...@gmail.com wrote: On Mon, Oct 31, 2022 at 7:07 AM Ville Syrjälä wrote: On Sun, Oct 30, 2022 at 08:42:52AM -0600, jim.cro...@gmail.com wrote: On Thu, Oct 27, 2022 at 2:10 PM Ville Syrjälä wrote: On Thu, Oct 27, 2022 at 01:55:39PM -0600, jim.cro...@gmail.com

Re: [Intel-gfx] [mm-unstable PATCH v7 2/8] mm/hugetlb: make pud_huge() and follow_huge_pud() aware of non-present pud entry

2022-11-04 Thread Naoya Horiguchi
On Wed, Nov 02, 2022 at 10:51:40PM +0200, Ville Syrjälä wrote: > On Thu, Jul 14, 2022 at 01:24:14PM +0900, Naoya Horiguchi wrote: > > +/* > > + * pud_huge() returns 1 if @pud is hugetlb related entry, that is normal > > + * hugetlb entry or non-present (migration or hwpoisoned) hugetlb entry. > >

Re: [Intel-gfx] [PATCH v5 1/3] drm: Use XArray instead of IDR for minors

2022-11-04 Thread Oded Gabbay
On Mon, Sep 12, 2022 at 12:17 AM Michał Winiarski wrote: > > IDR is deprecated, and since XArray manages its own state with internal > locking, it simplifies the locking on DRM side. > Additionally, don't use the IRQ-safe variant, since operating on drm > minor is not done in IRQ context. > >

Re: [Intel-gfx] [PATCH v2 7/7] vfio: Remove vfio_free_device

2022-11-04 Thread Anthony Krowiak
Reviewed-by: Tony Krowiak : vfio_ap part On 11/2/22 11:01 AM, Eric Farman wrote: With the "mess" sorted out, we should be able to inline the vfio_free_device call introduced by commit cb9ff3f3b84c ("vfio: Add helpers for unifying vfio_device life cycle") and remove them from driver release

Re: [Intel-gfx] [PATCH 05/10] vfio: Use IOMMU_CAP_ENFORCE_CACHE_COHERENCY for vfio_file_enforced_coherent()

2022-11-04 Thread Jason Gunthorpe
On Thu, Nov 03, 2022 at 04:38:16AM +, Tian, Kevin wrote: > > From: Jason Gunthorpe > > Sent: Tuesday, November 1, 2022 8:26 PM > > And this: > > > > /* > > * If the device does not have > > IOMMU_CAP_ENFORCE_CACHE_COHERENCY then > > * any domain later attached to it will also

Re: [Intel-gfx] [RFC][PATCH v3 00/33] timers: Use timer_shutdown*() before freeing timers

2022-11-04 Thread Steven Rostedt
On Fri, 4 Nov 2022 12:22:32 -0700 Guenter Roeck wrote: > Unfortunately the renaming caused some symbol conflicts. > > Global definition: timer_shutdown > > File Line > 0 time.c93 static inline void timer_shutdown(struct > clock_event_device *evt) > 1 arm_arch_timer.c

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for Fix for two GuC issues (rev2)

2022-11-04 Thread John Harrison
On 11/2/2022 21:45, Patchwork wrote: Project List - Patchwork *Patch Details* *Series:* Fix for two GuC issues (rev2) *URL:* https://patchwork.freedesktop.org/series/110269/ *State:*failure *Details:* https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110269v2/index.html CI

Re: [Intel-gfx] [RFC][PATCH v3 00/33] timers: Use timer_shutdown*() before freeing timers

2022-11-04 Thread Guenter Roeck
On Fri, Nov 04, 2022 at 01:40:53AM -0400, Steven Rostedt wrote: > > Back in April, I posted an RFC patch set to help mitigate a common issue > where a timer gets armed just before it is freed, and when the timer > goes off, it crashes in the timer code without any evidence of who the > culprit

Re: [Intel-gfx] [PATCH 2/2] drm/i915/mtl: Enable Idle Messaging for GSC CS

2022-11-04 Thread Belgaumkar, Vinay
On 10/31/2022 8:36 PM, Badal Nilawar wrote: From: Vinay Belgaumkar By defaut idle mesaging is disabled for GSC CS so to unblock RC6 entry on media tile idle messaging need to be enabled. C6 entry instead of RC6. Also *needs*. Bspec: 71496 Cc: Daniele Ceraolo Spurio Signed-off-by: Vinay

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/mtl: Add Wa_14017073508 for SAMedia

2022-11-04 Thread Patchwork
== Series Details == Series: drm/i915/mtl: Add Wa_14017073508 for SAMedia URL : https://patchwork.freedesktop.org/series/110502/ State : success == Summary == CI Bug Log - changes from CI_DRM_12339_full -> Patchwork_110502v1_full Summary

Re: [Intel-gfx] [RFC][PATCH v3 13/33] timers: drm: Use timer_shutdown_sync() before freeing timer

2022-11-04 Thread Steven Rostedt
On Fri, 4 Nov 2022 08:48:28 + Tvrtko Ursulin wrote: > If it stays all DRM drivers in one patch then I guess it needs to go via > drm-misc, which for i915 would be okay I think in this case since patch > is extremely unlikely to clash with anything. Or split it up per driver > and then we

Re: [Intel-gfx] [PATCH v2 1/2] drm/i915/guc: Properly initialise kernel contexts

2022-11-04 Thread John Harrison
On 11/4/2022 11:53, Ceraolo Spurio, Daniele wrote: On 11/2/2022 12:21 PM, john.c.harri...@intel.com wrote: From: John Harrison If a context has already been registered prior to first submission then context init code was not being called. The noticeable effect of that was the scheduling

Re: [Intel-gfx] [PATCH v2 1/2] drm/i915/guc: Properly initialise kernel contexts

2022-11-04 Thread Ceraolo Spurio, Daniele
On 11/2/2022 12:21 PM, john.c.harri...@intel.com wrote: From: John Harrison If a context has already been registered prior to first submission then context init code was not being called. The noticeable effect of that was the scheduling priority was left at zero (meaning super high

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/guc: Remove excessive line feeds in state dumps

2022-11-04 Thread John Harrison
On 10/31/2022 18:26, Patchwork wrote: Project List - Patchwork *Patch Details* *Series:* drm/i915/guc: Remove excessive line feeds in state dumps *URL:* https://patchwork.freedesktop.org/series/110343/ *State:*failure *Details:*

[Intel-gfx] ✓ Fi.CI.BAT: success for Add GT oriented dmesg output

2022-11-04 Thread Patchwork
== Series Details == Series: Add GT oriented dmesg output URL : https://patchwork.freedesktop.org/series/110550/ State : success == Summary == CI Bug Log - changes from CI_DRM_12344 -> Patchwork_110550v1 Summary --- **SUCCESS**

[Intel-gfx] ✗ Fi.CI.IGT: failure for mei: add timeout to send

2022-11-04 Thread Patchwork
== Series Details == Series: mei: add timeout to send URL : https://patchwork.freedesktop.org/series/110495/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12339_full -> Patchwork_110495v1_full Summary ---

Re: [Intel-gfx] [PATCH v2] drm/i915/mtl: Add Wa_14017073508 for SAMedia

2022-11-04 Thread Rodrigo Vivi
On Fri, Nov 04, 2022 at 12:15:59AM +0530, Badal Nilawar wrote: > This workaround is added for Media tile of MTL A step. It is to help > pcode workaround which handles the hardware issue seen during package C2/C3 > transitions due to RC6 entry/exit transitions on Media tile. As a part of >

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Add GT oriented dmesg output

2022-11-04 Thread Patchwork
== Series Details == Series: Add GT oriented dmesg output URL : https://patchwork.freedesktop.org/series/110550/ State : warning == Summary == Error: dim checkpatch failed 3c6bc62f46e5 drm/i915/gt: Add GT oriented dmesg output -:22: CHECK:MACRO_ARG_REUSE: Macro argument reuse '_gt' - possible

Re: [Intel-gfx] [PATCH] drm/i915: Don't wait forever in drop_caches

2022-11-04 Thread John Harrison
On 11/4/2022 03:01, Tvrtko Ursulin wrote: On 03/11/2022 19:16, John Harrison wrote: On 11/3/2022 02:38, Tvrtko Ursulin wrote: On 03/11/2022 09:18, Tvrtko Ursulin wrote: On 03/11/2022 01:33, John Harrison wrote: On 11/2/2022 07:20, Tvrtko Ursulin wrote: On 02/11/2022 12:12, Jani Nikula

Re: [Intel-gfx] [PATCH v2 5/5] drm/i915/mtl: don't expose GSC command streamer to the user

2022-11-04 Thread Matt Roper
On Wed, Nov 02, 2022 at 10:10:47AM -0700, Daniele Ceraolo Spurio wrote: > There is no userspace user for this CS yet, we only need it for internal > kernel ops (e.g. HuC, PXP), so don't expose it. > > v2: even if it's not exposed, rename the engine so it is easier to > identify in the debug logs

[Intel-gfx] [PATCH 0/2] Add GT oriented dmesg output

2022-11-04 Thread John . C . Harrison
From: John Harrison When trying to analyse bug reports from CI, customers, etc. it can be difficult to work out exactly what is happening on which GT in a multi-GT system. So add GT oriented debug/error message wrappers. If used instead of the drm_ equivalents, you get the same output but with a

[Intel-gfx] [PATCH 2/2] drm/i915/uc: Update the gt/uc code to use GT_ERR and friends

2022-11-04 Thread John . C . Harrison
From: John Harrison Use the new GT oriented output message helpers where possible. Signed-off-by: John Harrison --- drivers/gpu/drm/i915/gt/uc/intel_guc.c| 25 +++-- drivers/gpu/drm/i915/gt/uc/intel_guc_ads.c| 9 +- .../gpu/drm/i915/gt/uc/intel_guc_capture.c| 50 --

[Intel-gfx] [PATCH 1/2] drm/i915/gt: Add GT oriented dmesg output

2022-11-04 Thread John . C . Harrison
From: John Harrison When trying to analyse bug reports from CI, customers, etc. it can be difficult to work out exactly what is happening on which GT in a multi-GT system. So add GT oriented debug/error message wrappers. If used instead of the drm_ equivalents, you get the same output but with a

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/fb-helper: Untangle fbdev emulation and helpers (rev3)

2022-11-04 Thread Patchwork
== Series Details == Series: drm/fb-helper: Untangle fbdev emulation and helpers (rev3) URL : https://patchwork.freedesktop.org/series/109942/ State : success == Summary == CI Bug Log - changes from CI_DRM_12339_full -> Patchwork_109942v3_full

Re: [Intel-gfx] [RFC][PATCH v3 00/33] timers: Use timer_shutdown*() before freeing timers

2022-11-04 Thread Linus Torvalds
On Thu, Nov 3, 2022 at 10:48 PM Steven Rostedt wrote: > > Ideally, I would have the first patch go into this rc cycle, which is mostly > non functional as it will allow the other patches to come in via the > respective > subsystems in the next merge window. Ack. I also wonder if we could do

[Intel-gfx] ✓ Fi.CI.BAT: success for vfio-ccw parent rework (rev3)

2022-11-04 Thread Patchwork
== Series Details == Series: vfio-ccw parent rework (rev3) URL : https://patchwork.freedesktop.org/series/109899/ State : success == Summary == CI Bug Log - changes from CI_DRM_12344 -> Patchwork_109899v3 Summary --- **SUCCESS**

Re: [Intel-gfx] [PATCH v5 02/31] drm/i915: Don't register backlight when another backlight should be used (v2)

2022-11-04 Thread Hans de Goede
Hi Matthew, Rafael, On 10/27/22 14:09, Rafael J. Wysocki wrote: > On Thu, Oct 27, 2022 at 12:37 PM Hans de Goede wrote: >> >> Hi, >> >> On 10/27/22 11:52, Matthew Garrett wrote: >>> On Thu, Oct 27, 2022 at 11:39:38AM +0200, Hans de Goede wrote: >>> The *only* behavior which actually is new

[Intel-gfx] ✗ Fi.CI.DOCS: warning for vfio-ccw parent rework (rev3)

2022-11-04 Thread Patchwork
== Series Details == Series: vfio-ccw parent rework (rev3) URL : https://patchwork.freedesktop.org/series/109899/ State : warning == Summary == Error: make htmldocs had i915 warnings ./drivers/gpu/drm/i915/i915_perf_types.h:319: warning: Function parameter or member 'lock' not described in

[Intel-gfx] ✗ Fi.CI.IGT: failure for Add KUnit support for i915 driver

2022-11-04 Thread Patchwork
== Series Details == Series: Add KUnit support for i915 driver URL : https://patchwork.freedesktop.org/series/110483/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12339_full -> Patchwork_110483v1_full Summary ---

Re: [Intel-gfx] [PATCH] drm/i915/selftest: Bump up sample period for busy stats selftest

2022-11-04 Thread Tvrtko Ursulin
On 04/11/2022 14:58, Umesh Nerlige Ramappa wrote: On Fri, Nov 04, 2022 at 08:29:38AM +, Tvrtko Ursulin wrote: On 03/11/2022 18:08, Umesh Nerlige Ramappa wrote: On Thu, Nov 03, 2022 at 12:28:46PM +, Tvrtko Ursulin wrote: On 03/11/2022 00:11, Umesh Nerlige Ramappa wrote: Engine

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Set PROBE_PREFER_ASYNCHRONOUS

2022-11-04 Thread Matthew Auld
On Thu, 3 Nov 2022 at 00:14, Brian Norris wrote: > > On Wed, Nov 02, 2022 at 12:18:37PM +, Matthew Auld wrote: > > On Tue, 1 Nov 2022 at 21:58, Brian Norris wrote: > > > > > > On Fri, Oct 28, 2022 at 5:24 PM Patchwork > > > wrote: > > > > > > > > Patch Details > > > > Series:drm/i915: Set

Re: [Intel-gfx] [PATCH] drm/i915/selftest: Bump up sample period for busy stats selftest

2022-11-04 Thread Umesh Nerlige Ramappa
On Fri, Nov 04, 2022 at 08:29:38AM +, Tvrtko Ursulin wrote: On 03/11/2022 18:08, Umesh Nerlige Ramappa wrote: On Thu, Nov 03, 2022 at 12:28:46PM +, Tvrtko Ursulin wrote: On 03/11/2022 00:11, Umesh Nerlige Ramappa wrote: Engine busyness samples around a 10ms period is failing with

Re: [Intel-gfx] [PATCH] i915/pmu: Use a faster read for 2x32 mmio reads

2022-11-04 Thread Umesh Nerlige Ramappa
On Thu, Nov 03, 2022 at 10:10:14PM -0700, Dixit, Ashutosh wrote: On Thu, 03 Nov 2022 11:07:05 -0700, Umesh Nerlige Ramappa wrote: Hi Umesh, PMU reads the GT timestamp as a 2x32 mmio read and since upper and lower 32 bit registers are read in a loop, there is a latency involved in getting

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Set PROBE_PREFER_ASYNCHRONOUS

2022-11-04 Thread Matthew Auld
On Thu, 3 Nov 2022 at 00:14, Brian Norris wrote: > > On Wed, Nov 02, 2022 at 12:18:37PM +, Matthew Auld wrote: > > On Tue, 1 Nov 2022 at 21:58, Brian Norris wrote: > > > > > > On Fri, Oct 28, 2022 at 5:24 PM Patchwork > > > wrote: > > > > > > > > Patch Details > > > > Series:drm/i915: Set

[Intel-gfx] [PATCH v3 7/7] vfio: Remove vfio_free_device

2022-11-04 Thread Eric Farman
With the "mess" sorted out, we should be able to inline the vfio_free_device call introduced by commit cb9ff3f3b84c ("vfio: Add helpers for unifying vfio_device life cycle") and remove them from driver release callbacks. Signed-off-by: Eric Farman Reviewed-by: Jason Gunthorpe Reviewed-by: Kevin

[Intel-gfx] [PATCH v3 1/7] vfio/ccw: create a parent struct

2022-11-04 Thread Eric Farman
Move the stuff associated with the mdev parent (and thus the subchannel struct) into its own struct, and leave the rest in the existing private structure. The subchannel will point to the parent, and the parent will point to the private, for the areas where one or both are needed. Further

[Intel-gfx] [PATCH v3 6/7] vfio/ccw: replace vfio_init_device with _alloc_

2022-11-04 Thread Eric Farman
Now that we have a reasonable separation of structs that follow the subchannel and mdev lifecycles, there's no reason we can't call the official vfio_alloc_device routine for our private data, and behave like everyone else. Signed-off-by: Eric Farman Reviewed-by: Kevin Tian Acked-by: Alex

[Intel-gfx] [PATCH v3 4/7] vfio/ccw: move private to mdev lifecycle

2022-11-04 Thread Eric Farman
Now that the mdev parent data is split out into its own struct, it is safe to move the remaining private data to follow the mdev probe/remove lifecycle. The mdev parent data will remain where it is, and follow the subchannel and the css driver interfaces. Signed-off-by: Eric Farman Reviewed-by:

[Intel-gfx] [PATCH v3 2/7] vfio/ccw: remove private->sch

2022-11-04 Thread Eric Farman
These places all rely on the ability to jump from a private struct back to the subchannel struct. Rather than keeping a copy in our back pocket, let's use the relationship provided by the vfio_device embedded within the private. Signed-off-by: Eric Farman Reviewed-by: Matthew Rosato ---

[Intel-gfx] [PATCH v3 5/7] vfio/ccw: remove release completion

2022-11-04 Thread Eric Farman
There's enough separation between the parent and private structs now, that it is fine to remove the release completion hack. Signed-off-by: Eric Farman Reviewed-by: Kevin Tian Reviewed-by: Matthew Rosato --- drivers/s390/cio/vfio_ccw_ops.c | 14 +-

[Intel-gfx] [PATCH v3 3/7] vfio/ccw: move private initialization to callback

2022-11-04 Thread Eric Farman
There's already a device initialization callback that is used to initialize the release completion workaround that was introduced by commit ebb72b765fb49 ("vfio/ccw: Use the new device life cycle helpers"). Move the other elements of the vfio_ccw_private struct that require distinct

[Intel-gfx] [PATCH v3 0/7] vfio-ccw parent rework

2022-11-04 Thread Eric Farman
Hi Alex, Here's the (last?) update to the vfio-ccw lifecycle changes that I've sent recently, and were previously discussed at various points [1][2]. Patches 1-5 rework the behavior of the vfio-ccw driver's private struct. In summary, the mdev pieces are split out of vfio_ccw_private and into a

[Intel-gfx] ✓ Fi.CI.BAT: success for KUnit issues - Was: [igt-dev] [PATCH RFC v2 8/8] drm/i915: check if current->mm is not NULL (rev2)

2022-11-04 Thread Patchwork
== Series Details == Series: KUnit issues - Was: [igt-dev] [PATCH RFC v2 8/8] drm/i915: check if current->mm is not NULL (rev2) URL : https://patchwork.freedesktop.org/series/110492/ State : success == Summary == CI Bug Log - changes from CI_DRM_12342 -> Patchwork_110492v2

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for KUnit issues - Was: [igt-dev] [PATCH RFC v2 8/8] drm/i915: check if current->mm is not NULL (rev2)

2022-11-04 Thread Patchwork
== Series Details == Series: KUnit issues - Was: [igt-dev] [PATCH RFC v2 8/8] drm/i915: check if current->mm is not NULL (rev2) URL : https://patchwork.freedesktop.org/series/110492/ State : warning == Summary == Error: dim checkpatch failed 1bcd7d5d971a KUnit issues - Was: [igt-dev] [PATCH

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [CI,1/2] Revert "freezer, sched: Rewrite core freezer logic fix"

2022-11-04 Thread Patchwork
== Series Details == Series: series starting with [CI,1/2] Revert "freezer, sched: Rewrite core freezer logic fix" URL : https://patchwork.freedesktop.org/series/110529/ State : success == Summary == CI Bug Log - changes from CI_DRM_12342 -> Patchwork_110529v1

Re: [Intel-gfx] KUnit issues - Was: [igt-dev] [PATCH RFC v2 8/8] drm/i915: check if current->mm is not NULL

2022-11-04 Thread Mauro Carvalho Chehab
On Fri, 4 Nov 2022 08:49:55 +0100 Mauro Carvalho Chehab wrote: > On Thu, 3 Nov 2022 15:43:26 -0700 > Daniel Latypov wrote: > > > On Thu, Nov 3, 2022 at 8:23 AM Mauro Carvalho Chehab > > wrote: > > > > > > Hi, > > > > > > I'm facing a couple of issues when testing KUnit with the i915 driver.

[Intel-gfx] ✗ Fi.CI.DOCS: warning for series starting with [CI,1/2] Revert "freezer, sched: Rewrite core freezer logic fix"

2022-11-04 Thread Patchwork
== Series Details == Series: series starting with [CI,1/2] Revert "freezer, sched: Rewrite core freezer logic fix" URL : https://patchwork.freedesktop.org/series/110529/ State : warning == Summary == Error: make htmldocs had i915 warnings ./drivers/gpu/drm/i915/i915_perf_types.h:319:

Re: [Intel-gfx] [PATCH v2 4/7] vfio/ccw: move private to mdev lifecycle

2022-11-04 Thread Eric Farman
On Thu, 2022-11-03 at 19:22 -0400, Matthew Rosato wrote: > On 11/2/22 11:01 AM, Eric Farman wrote: > > Now that the mdev parent data is split out into its own struct, > > it is safe to move the remaining private data to follow the > > mdev probe/remove lifecycle. The mdev parent data will remain >

Re: [Intel-gfx] [PATCH v2 0/7] vfio-ccw parent rework

2022-11-04 Thread Eric Farman
On Thu, 2022-11-03 at 19:43 -0400, Matthew Rosato wrote: > On 11/3/22 5:56 PM, Alex Williamson wrote: > > On Wed,  2 Nov 2022 16:01:45 +0100 > > Eric Farman wrote: > > > > > Hi all, > > > > > > Here is an update to the vfio-ccw lifecycle changes that have > > > been discussed > > > in various

Re: [Intel-gfx] [PATCH 2/9] drm/i915: Use kmap_local_page() in gem/i915_gem_pyhs.c

2022-11-04 Thread Zhao Liu
On Sat, Oct 29, 2022 at 03:32:08PM +0200, Fabio M. De Francesco wrote: > Date: Sat, 29 Oct 2022 15:32:08 +0200 > From: "Fabio M. De Francesco" > Subject: Re: [PATCH 2/9] drm/i915: Use kmap_local_page() in > gem/i915_gem_pyhs.c > > On luned? 17 ottobre 2022 11:37:18 CEST Zhao Liu wrote: > >

[Intel-gfx] [PATCH CI 2/2] freezer, sched: Rewrite core freezer logic v2

2022-11-04 Thread Ville Syrjala
From: Peter Zijlstra On Wed, Nov 02, 2022 at 06:57:51PM +0200, Ville Syrjälä wrote: > On Thu, Oct 27, 2022 at 06:53:23PM +0200, Peter Zijlstra wrote: > > On Thu, Oct 27, 2022 at 04:09:01PM +0300, Ville Syrjälä wrote: > > > On Wed, Oct 26, 2022 at 01:43:00PM +0200, Peter Zijlstra wrote: > > > > >

[Intel-gfx] [PATCH CI 1/2] Revert "freezer, sched: Rewrite core freezer logic fix"

2022-11-04 Thread Ville Syrjala
From: Ville Syrjälä This reverts commit f3387d5883ad92e9a54306fa3dff97d4f0581d78. --- kernel/sched/core.c | 49 - 1 file changed, 17 insertions(+), 32 deletions(-) diff --git a/kernel/sched/core.c b/kernel/sched/core.c index

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/2] drm/i915/pps: Add get_pps_idx() hook as part of pps_get_register() cleanup (rev2)

2022-11-04 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/pps: Add get_pps_idx() hook as part of pps_get_register() cleanup (rev2) URL : https://patchwork.freedesktop.org/series/109820/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12342 -> Patchwork_109820v2

Re: [Intel-gfx] [PATCH 1/9] drm/i915: Use kmap_local_page() in gem/i915_gem_object.c

2022-11-04 Thread Zhao Liu
On Thu, Nov 03, 2022 at 08:22:04PM +0100, Fabio M. De Francesco wrote: > Date: Thu, 03 Nov 2022 20:22:04 +0100 > From: "Fabio M. De Francesco" > Subject: Re: [PATCH 1/9] drm/i915: Use kmap_local_page() in > gem/i915_gem_object.c > > On gioved? 3 novembre 2022 17:51:23 CET Ira Weiny wrote: > >

Re: [Intel-gfx] [PATCH 1/9] drm/i915: Use kmap_local_page() in gem/i915_gem_object.c

2022-11-04 Thread Zhao Liu
On Thu, Nov 03, 2022 at 09:51:23AM -0700, Ira Weiny wrote: > Date: Thu, 3 Nov 2022 09:51:23 -0700 > From: Ira Weiny > Subject: Re: [PATCH 1/9] drm/i915: Use kmap_local_page() in > gem/i915_gem_object.c > > On Sat, Oct 29, 2022 at 01:17:03PM +0200, Fabio M. De Francesco wrote: > > On luned? 17

Re: [Intel-gfx] [PATCH 1/9] drm/i915: Use kmap_local_page() in gem/i915_gem_object.c

2022-11-04 Thread Zhao Liu
On Sat, Oct 29, 2022 at 01:17:03PM +0200, Fabio M. De Francesco wrote: > Date: Sat, 29 Oct 2022 13:17:03 +0200 > From: "Fabio M. De Francesco" > Subject: Re: [PATCH 1/9] drm/i915: Use kmap_local_page() in > gem/i915_gem_object.c > > On luned? 17 ottobre 2022 11:37:17 CEST Zhao Liu wrote: > >

Re: [Intel-gfx] [PATCH 0/9] drm/i915: Replace kmap_atomic() with kmap_local_page()

2022-11-04 Thread Zhao Liu
On Sat, Oct 29, 2022 at 09:12:27AM +0200, Fabio M. De Francesco wrote: > Date: Sat, 29 Oct 2022 09:12:27 +0200 > From: "Fabio M. De Francesco" > Subject: Re: [PATCH 0/9] drm/i915: Replace kmap_atomic() with > kmap_local_page() Hi Fabio, thanks for your review!! (I'm sorry I missed the previous

Re: [Intel-gfx] [PATCH v3 23/23] drm/fb-helper: Clarify use of last_close and output_poll_changed

2022-11-04 Thread Javier Martinez Canillas
On 11/3/22 16:14, Thomas Zimmermann wrote: > Clarify documentation in the use of struct drm_driver.last_close and > struct drm_mode_config_funcs.output_poll_changed. Those callbacks should > not be said for fbdev implementations on top of struct drm_client_funcs. > > Signed-off-by: Thomas

Re: [Intel-gfx] [PATCH v3 20/23] drm/fb-helper: Set flag in struct drm_fb_helper for leaking physical addresses

2022-11-04 Thread Javier Martinez Canillas
On 11/3/22 16:14, Thomas Zimmermann wrote: > Uncouple the parameter drm_leak_fbdev_smem from the implementation by > setting a flag in struct drm_fb_helper. This will help to move the > generic fbdev emulation into its own source file, while keeping the > parameter in drm_fb_helper.c. No

Re: [Intel-gfx] [PATCH] drm/i915/dsc: Add is_dsc_supported()

2022-11-04 Thread Jani Nikula
On Thu, 03 Nov 2022, "Navare, Manasi" wrote: > On Thu, Nov 03, 2022 at 11:32:22AM +0530, Swati Sharma wrote: >> Lets use RUNTIME_INFO->has_dsc since platforms supporting dsc has this >> flag enabled. >> >> This is done based on the review comments received on >>

[Intel-gfx] ✓ Fi.CI.IGT: success for Add DP MST DSC support to i915 (rev16)

2022-11-04 Thread Patchwork
== Series Details == Series: Add DP MST DSC support to i915 (rev16) URL : https://patchwork.freedesktop.org/series/101492/ State : success == Summary == CI Bug Log - changes from CI_DRM_12337_full -> Patchwork_101492v16_full Summary

Re: [Intel-gfx] [PATCH] drm/i915: Don't wait forever in drop_caches

2022-11-04 Thread Tvrtko Ursulin
On 03/11/2022 19:16, John Harrison wrote: On 11/3/2022 02:38, Tvrtko Ursulin wrote: On 03/11/2022 09:18, Tvrtko Ursulin wrote: On 03/11/2022 01:33, John Harrison wrote: On 11/2/2022 07:20, Tvrtko Ursulin wrote: On 02/11/2022 12:12, Jani Nikula wrote: On Tue, 01 Nov 2022,

Re: [Intel-gfx] [PATCH 11/11] drm/i915: Create resized LUTs for ivb+ split gamma mode

2022-11-04 Thread Ville Syrjälä
On Fri, Nov 04, 2022 at 10:49:39AM +0530, Nautiyal, Ankit K wrote: > Patch looks good to me. > > Minor suggestions inline: > > On 10/26/2022 5:09 PM, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > Currently when opeating in split gamma mode we do the > nitpick: 'operating' typo. > > "skip

Re: [Intel-gfx] [RFC][PATCH v3 13/33] timers: drm: Use timer_shutdown_sync() before freeing timer

2022-11-04 Thread Tvrtko Ursulin
Hi, On 04/11/2022 05:41, Steven Rostedt wrote: From: "Steven Rostedt (Google)" Before a timer is freed, timer_shutdown_sync() must be called. Link: https://lore.kernel.org/all/20220407161745.7d675...@gandalf.local.home/ Cc: "Noralf Trønnes" Cc: David Airlie Cc: Daniel Vetter Cc: Jani

Re: [Intel-gfx] [PATCH] drm/i915/selftest: Bump up sample period for busy stats selftest

2022-11-04 Thread Tvrtko Ursulin
On 03/11/2022 18:08, Umesh Nerlige Ramappa wrote: On Thu, Nov 03, 2022 at 12:28:46PM +, Tvrtko Ursulin wrote: On 03/11/2022 00:11, Umesh Nerlige Ramappa wrote: Engine busyness samples around a 10ms period is failing with busyness ranging approx. from 87% to 115%. The expected range is

Re: [Intel-gfx] [PATCH] mei: add timeout to send

2022-11-04 Thread Tvrtko Ursulin
Hi, Not really driver I looked at before but since you copied me some comments below. On 03/11/2022 15:55, Alexander Usyskin wrote: When driver wakes up the firmware from the low power stand, it is sending a memory ready message. The send is done via synchronous/blocking function to ensure

Re: [Intel-gfx] [PATCH] drm/i915/mtl: Media GT and Render GT share common GGTT

2022-11-04 Thread Iddamsetty, Aravind
Hi Lucas, > -Original Message- > From: De Marchi, Lucas > Sent: Friday, November 4, 2022 12:36 PM > To: Iddamsetty, Aravind > Cc: intel-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org > Subject: Re: [Intel-gfx] [PATCH] drm/i915/mtl: Media GT and Render GT share > common GGTT

Re: [Intel-gfx] KUnit issues - Was: [igt-dev] [PATCH RFC v2 8/8] drm/i915: check if current->mm is not NULL

2022-11-04 Thread Mauro Carvalho Chehab
On Thu, 3 Nov 2022 15:43:26 -0700 Daniel Latypov wrote: > On Thu, Nov 3, 2022 at 8:23 AM Mauro Carvalho Chehab > wrote: > > > > Hi, > > > > I'm facing a couple of issues when testing KUnit with the i915 driver. > > > > The DRM subsystem and the i915 driver has, for a long time, his own > > way

[Intel-gfx] ✗ Fi.CI.BUILD: failure for drm/i915/mtl: Media GT and Render GT share common GGTT (rev2)

2022-11-04 Thread Patchwork
== Series Details == Series: drm/i915/mtl: Media GT and Render GT share common GGTT (rev2) URL : https://patchwork.freedesktop.org/series/110321/ State : failure == Summary == Error: patch https://patchwork.freedesktop.org/api/1.0/series/110321/revisions/2/mbox/ not applied Applying:

Re: [Intel-gfx] [PATCH] drm/i915/mtl: Media GT and Render GT share common GGTT

2022-11-04 Thread Lucas De Marchi
On Mon, Oct 31, 2022 at 06:01:11PM +0530, Aravind Iddamsetty wrote: On XE_LPM+ platforms the media engines are carved out into a separate GT but have a common GGTMMADR address range which essentially makes the GGTT address space to be shared between media and render GT. BSPEC: 63834 Cc: Matt