[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Avoid full proxy f_ops debug attributes

2023-01-10 Thread Patchwork
== Series Details == Series: drm/i915: Avoid full proxy f_ops debug attributes URL : https://patchwork.freedesktop.org/series/112625/ State : success == Summary == CI Bug Log - changes from CI_DRM_12569_full -> Patchwork_112625v1_full Summa

[Intel-gfx] [PATCH v3 4/4] drm/i915: Clean up page shift operation

2023-01-10 Thread Somalapuram Amaranath
Remove page shift operations as ttm_resource moved from num_pages to size_t size in bytes. Signed-off-by: Somalapuram Amaranath --- drivers/gpu/drm/i915/i915_scatterlist.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_scatterlist.c b/drivers

[Intel-gfx] [PATCH v3 3/4] drm/amdgpu: Clean up page shift operation and GWS and OA

2023-01-10 Thread Somalapuram Amaranath
Remove page shift operations as ttm_resource moved from num_pages to size_t size in bytes. Signed-off-by: Somalapuram Amaranath --- drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 4 +--- drivers/gpu/drm/amd/amdgpu/amdgpu_res_cursor.h | 12 ++-- 2 files changed, 7 insertions(+), 9 dele

[Intel-gfx] [PATCH v3 1/4] drm/ttm: Clean up page shift operation

2023-01-10 Thread Somalapuram Amaranath
Remove page shift operations as ttm_resource moved from num_pages to size_t size in bytes. v1 -> v2: fix missing page shift to fpfn and lpfn v2 -> v3: separate patch’s based on driver module Signed-off-by: Somalapuram Amaranath --- drivers/gpu/drm/ttm/ttm_range_manager.c | 13 ++--- 1 fi

[Intel-gfx] [PATCH v3 2/4] drm/gem: Remove BUG_ON in drm_gem_private_object_init

2023-01-10 Thread Somalapuram Amaranath
ttm_resource allocate size in bytes to support less than page size Signed-off-by: Somalapuram Amaranath --- drivers/gpu/drm/drm_gem.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/drm_gem.c b/drivers/gpu/drm/drm_gem.c index 59a0bb5ebd85..ee8b5c2b6c60 100644 --- a/drivers/g

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Enable YCbCr420 for VDSC

2023-01-10 Thread Patchwork
== Series Details == Series: Enable YCbCr420 for VDSC URL : https://patchwork.freedesktop.org/series/112653/ State : warning == Summary == Error: dim checkpatch failed 85568f88bfda drm/dp_helper: Add helper to check if the sink supports given format with DSC 27809b830b41 drm/i915/dp: Check if

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Add missing check and destroy for alloc_workqueue

2023-01-10 Thread Patchwork
== Series Details == Series: drm/i915: Add missing check and destroy for alloc_workqueue URL : https://patchwork.freedesktop.org/series/112623/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12569_full -> Patchwork_112623v1_full =

[Intel-gfx] [PATCH v6 9/9] drm/i915: Code styling fixes

2023-01-10 Thread Suraj Kandpal
From: Swati Sharma Removed extra newlines and did few styling fixes. Signed-off-by: Swati Sharma --- drivers/gpu/drm/i915/display/intel_display_debugfs.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_display_debugfs.c b/drivers/gp

[Intel-gfx] [PATCH v6 8/9] drm/i915/dsc: Allow DSC only with YCbCr420 format when forced from debugfs

2023-01-10 Thread Suraj Kandpal
From: Swati Sharma If force_dsc_ycbcr420_en is set through debugfs allow DSC iff output_format is INTEL_OUTPUT_FORMAT_YCBCR420. Signed-off-by: Swati Sharma --- drivers/gpu/drm/i915/display/intel_dp.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/i915/display/intel_dp.

[Intel-gfx] [PATCH v6 7/9] drm/i915/dsc: Add debugfs entry to validate DSC YCbCr420

2023-01-10 Thread Suraj Kandpal
From: Swati Sharma DSC_YCBCR420_Sink_Support entry is added to i915_dsc_fec_support_show to depict if sink supports DSC YCbCr420. Also, new debugfs entry is created to enforce YCbCr420 output format. This is required because of our driver policy. If a mode is supported in both RGB and YCbCr420 ou

[Intel-gfx] [PATCH v6 5/9] drm/i915: Fill in native_420 field

2023-01-10 Thread Suraj Kandpal
Now that we have laid the groundwork for YUV420 Enablement we fill up native_420 field in vdsc_cfg and add appropriate checks wherever required. ---v2 -adding native_422 field as 0 [Vandita] -filling in second_line_bpg_offset, second_line_offset_adj and nsl_bpg_offset in vds_cfg when native_420 is

[Intel-gfx] [PATCH v6 6/9] drm/i915/vdsc: Check slice design requirement

2023-01-10 Thread Suraj Kandpal
Add function to check if slice design requirements are being met as defined in the below link section Slice Design Requirement https://gfxspecs.intel.com/Predator/Home/Index/49259 Signed-off-by: Suraj Kandpal --- drivers/gpu/drm/i915/display/intel_vdsc.c | 32 +++ 1 file cha

[Intel-gfx] [PATCH v6 4/9] drm/i915: Enable YCbCr420 for VDSC

2023-01-10 Thread Suraj Kandpal
Implementation of VDSC for YCbCr420. Signed-off-by: Suraj Kandpal --- .../gpu/drm/i915/display/intel_qp_tables.c| 187 -- .../gpu/drm/i915/display/intel_qp_tables.h| 4 +- drivers/gpu/drm/i915/display/intel_vdsc.c | 4 +- 3 files changed, 180 insertions(+), 15 del

[Intel-gfx] [PATCH v6 3/9] drm/i915: Adding the new registers for DSC

2023-01-10 Thread Suraj Kandpal
Adding new DSC register which are introducted MTL onwards Signed-off-by: Suraj Kandpal --- drivers/gpu/drm/i915/i915_reg.h | 28 1 file changed, 28 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h index 8b2cf980f323..69a64

[Intel-gfx] [PATCH v6 2/9] drm/i915/dp: Check if DSC supports the given output_format

2023-01-10 Thread Suraj Kandpal
From: Ankit Nautiyal Go with DSC only if the given output_format is supported. v2: Use drm helper to get DSC format support for sink. Signed-off-by: Ankit Nautiyal --- drivers/gpu/drm/i915/display/intel_dp.c | 30 + 1 file changed, 30 insertions(+) diff --git a/driver

[Intel-gfx] [PATCH v6 1/9] drm/dp_helper: Add helper to check if the sink supports given format with DSC

2023-01-10 Thread Suraj Kandpal
From: Ankit Nautiyal Add helper function to check if the DP sink supports DSC with the given output format. Signed-off-by: Ankit Nautiyal --- include/drm/display/drm_dp_helper.h | 7 +++ 1 file changed, 7 insertions(+) diff --git a/include/drm/display/drm_dp_helper.h b/include/drm/displa

[Intel-gfx] [PATCH v6 0/9] Enable YCbCr420 for VDSC

2023-01-10 Thread Suraj Kandpal
This patch series aims to enable the YCbCr420 format for DSC. Changes are mostly compute params related for hdmi,dp and dsi along with the addition of new rc_tables for native_420 and corresponding changes to macros used to fetch them. ---v2 -add fields missed for vdsc_cfg [Vandita] -add correspon

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/guc: Replace zero-length arrays with flexible-array members

2023-01-10 Thread Patchwork
== Series Details == Series: drm/i915/guc: Replace zero-length arrays with flexible-array members URL : https://patchwork.freedesktop.org/series/112621/ State : success == Summary == CI Bug Log - changes from CI_DRM_12569_full -> Patchwork_112621v1_full

[Intel-gfx] ✓ Fi.CI.IGT: success for ACPI: Fix selecting the wrong ACPI fwnode for the iGPU on some Dell laptops (rev3)

2023-01-10 Thread Patchwork
== Series Details == Series: ACPI: Fix selecting the wrong ACPI fwnode for the iGPU on some Dell laptops (rev3) URL : https://patchwork.freedesktop.org/series/112572/ State : success == Summary == CI Bug Log - changes from CI_DRM_12569_full -> Patchwork_112572v3_full =

Re: [Intel-gfx] [PATCH v9 10/23] drm/i915/vm_bind: Add out fence support

2023-01-10 Thread Zanoni, Paulo R
On Mon, 2022-12-12 at 15:15 -0800, Niranjana Vishwanathapura wrote: > Add support for handling out fence for vm_bind call. > > v2: Reset vma->vm_bind_fence.syncobj to NULL at the end > of vm_bind call. > v3: Remove vm_unbind out fence uapi which is not supported yet. > v4: Return error if I915

[Intel-gfx] ✗ Fi.CI.BUILD: failure for drm/i915/pxp: Add MTL PXP Support

2023-01-10 Thread Patchwork
== Series Details == Series: drm/i915/pxp: Add MTL PXP Support URL : https://patchwork.freedesktop.org/series/112647/ State : failure == Summary == Error: make failed CALLscripts/checksyscalls.sh DESCEND objtool CC [M] drivers/gpu/drm/i915/gt/intel_gt_irq.o In file included from dri

Re: [Intel-gfx] [RFC PATCH 04/20] drm/sched: Convert drm scheduler to use a work queue rather than kthread

2023-01-10 Thread Matthew Brost
On Tue, Jan 10, 2023 at 04:39:00PM +, Matthew Brost wrote: > On Tue, Jan 10, 2023 at 11:28:08AM +, Tvrtko Ursulin wrote: > > > > > > On 09/01/2023 17:27, Jason Ekstrand wrote: > > > > [snip] > > > > > >>> AFAICT it proposes to have 1:1 between *userspace* created > > > contexts

[Intel-gfx] [PATCH 2/2 v2] drm/i915: Replace alloc*workqueue with DRM helpers

2023-01-10 Thread Jiasheng Jiang
Replace alloc*workqueue with DRM helpers in order to avoid memory leak Because in `drivers/gpu/drm/i915/i915_driver.c`, if intel_modeset_init_noirq fails, its workqueues will not be destroyed. And drop the destroy_workqueue in intel_modeset_driver_remove_noirq to avoid double free. Moreover, check

[Intel-gfx] [PATCH 7/9] drm/i915/pxp: MTL-KCR interrupt ctrl's are in GT-0

2023-01-10 Thread Alan Previn
Despite KCR subsystem being in the media-tile (close to the GSC-CS), the IRQ controls for it are on GT-0 with other global IRQ controls. Thus, add a helper for KCR hw interrupt enable/disable functions to get the correct gt structure (for uncore) for MTL. In the helper, we get GT-0's handle for un

[Intel-gfx] [PATCH 8/9] drm/i915/pxp: On MTL, KCR enabling doesn't wait on tee component

2023-01-10 Thread Alan Previn
On legacy platforms, KCR HW enabling is done at the time the mei component interface is bound. It's also disabled during unbind. However, for MTL onwards, we don't depend on the tee-component operation before we can start sending GSC-CS firmware messages. Thus, immediately enable KCR HW on PXP's i

[Intel-gfx] [PATCH 6/9] drm/i915/pxp: Add ARB session creation with new PXP API Ver4.3

2023-01-10 Thread Alan Previn
Add MTL's function for ARB session creation using PXP firmware version 4.3 ABI structure format. Before checking the return status, look at the GSC-CS-Mem-Header's pending-bit which means the GSC firmware is busy and we should resubmit. Signed-off-by: Alan Previn --- .../drm/i915/pxp/intel_pxp_

[Intel-gfx] [PATCH 5/9] drm/i915/pxp: Add GSC-CS backend to send GSC fw messages

2023-01-10 Thread Alan Previn
Add GSC engine based method for sending PXP firmware packets to the GSC firmware for MTL (and future) products. Use the newly added helpers to populate the GSC-CS memory header and send the message packet to the FW by dispatching the GSC_HECI_CMD_PKT instruction on the GSC engine. Signed-off-by: A

[Intel-gfx] [PATCH 8/9] drm/i915/pxp: On MTL, KCR HW can be enabled instantly

2023-01-10 Thread Alan Previn
On legacy platforms, KCR HW enabling is done at the time the mei component interface is loaded. It's also disabled during unbind. For MTL onwards, we don't need a separate component driver to send FW messages via GSC-CS. Thus, immediately enable KCR HW on PXP's init, fini and resume. Signed-off-b

[Intel-gfx] [PATCH 7/9] drm/i915/pxp: MTL-KCR is in media-tile but IRQ-ctrl's in root

2023-01-10 Thread Alan Previn
Add a helper for KCR hw interrupt enable/disable functions. For MTL onwards, it will get the GT-0's handle including the uncore fw bits and use that despite the pxp->ctrl_gt being the media-tile. No difference for legacy of course. Signed-off-by: Alan Previn --- drivers/gpu/drm/i915/pxp/intel_px

[Intel-gfx] [PATCH 9/9] drm/i915/pxp: Enable PXP with MTL-GSC-CS

2023-01-10 Thread Alan Previn
Enable PXP with MTL-GSC-CS: add the has_pxp into device info and increase the timeouts for new GSC-CS + firmware specs. Signed-off-by: Alan Previn --- drivers/gpu/drm/i915/i915_pci.c | 1 + drivers/gpu/drm/i915/pxp/intel_pxp_session.c | 2 +- 2 files changed, 2 insertions(+), 1 dele

[Intel-gfx] [PATCH 4/9] drm/i915/pxp: Add MTL helpers to submit Heci-Cmd-Packet to GSC

2023-01-10 Thread Alan Previn
Add helper functions into (new) common heci-packet-submission files to handle generating the MTL GSC-CS Memory-Header and emitting of the Heci-Cmd-Packet instructions that gets submitted to the engine. NOTE1: This common functions for heci-packet-submission will be used by different i915 callers:

[Intel-gfx] [PATCH 5/9] drm/i915/pxp: Add GSC-CS backend-teelink for send-message function

2023-01-10 Thread Alan Previn
Populate the backend-teelink abstraction layer using GSC-CS engine for MTL (and future) products. The PXP backend for sending messages Signed-off-by: Alan Previn --- drivers/gpu/drm/i915/pxp/intel_pxp_gsccs.c | 92 ++ 1 file changed, 92 insertions(+) diff --git a/drivers/gpu

[Intel-gfx] [PATCH 3/9] drm/i915/pxp: Add MTL hw-plumbing enabling for KCR operation

2023-01-10 Thread Alan Previn
Add MTL hw-plumbing enabling for KCR operation under PXP which includes: 1. Updating 'pick-gt' to get the media tile for KCR interrupt handling 2. Adding MTL's KCR registers for PXP operation (init, status-checking, etc.). While doing #2, lets create a separate registers header file for PXP

[Intel-gfx] [PATCH 2/9] drm/i915/pxp: Add GSC-CS back-end resource init and cleanup

2023-01-10 Thread Alan Previn
For MTL, PXP transport back-end uses the GSC engine to submit HECI packets for PXP arb session management. The command submission that uses non-priveleged mode requires us to allocate (or free) a set of execution submission resources (buffer-object, batch-buffer and context). Thus, do this one time

[Intel-gfx] [PATCH 1/9] drm/i915/pxp: Add MTL PXP GSC-CS back-end skeleton

2023-01-10 Thread Alan Previn
Add MTL PXP GSC-CS back-end stub functions hook them up from PXP front-end and PXP session management functions. Signed-off-by: Alan Previn --- drivers/gpu/drm/i915/Makefile| 1 + drivers/gpu/drm/i915/pxp/intel_pxp.c | 19 +--- drivers/gpu/drm/i915/pxp/intel_

[Intel-gfx] [PATCH 0/9] drm/i915/pxp: Add MTL PXP Support

2023-01-10 Thread Alan Previn
This series enables PXP on MTL. On ADL/TGL platforms, we rely on the mei driver via the i915-mei PXP component interface to establish a connection to the security firmware via the HECI device interface. That interface is used to create and teardown the PXP ARB session. PXP ARB session is created wh

Re: [Intel-gfx] [PATCH v2] drm/i915/display: assume some pixelrate for src smaller than 1

2023-01-10 Thread Imre Deak
On Tue, Jan 10, 2023 at 11:27:33PM +0200, Imre Deak wrote: > On Sun, Jan 08, 2023 at 01:30:44PM +0200, Juha-Pekka Heikkila wrote: > > intel_adjusted_rate() didn't take into account src rectangle > > can be less than 1 in with or height. > > Thanks for catching this. > > > Signed-off-by: Juha-Pekk

Re: [Intel-gfx] [PATCH v7 2/2] drm/i915/mtl: update scaler source and destination limits for MTL

2023-01-10 Thread Sripada, Radhakrishna
Merged the two patches. Thanks for the review and the patch. Regards, Radhakrishna(RK) Sripada > -Original Message- > From: Intel-gfx On Behalf Of > Lisovskiy, Stanislav > Sent: Sunday, January 8, 2023 11:32 PM > To: Coelho, Luciano > Cc: intel-gfx@lists.freedesktop.org > Subject: Re: [

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gvt: Avoid full proxy f_ops debug attributes

2023-01-10 Thread Patchwork
== Series Details == Series: drm/i915/gvt: Avoid full proxy f_ops debug attributes URL : https://patchwork.freedesktop.org/series/112630/ State : success == Summary == CI Bug Log - changes from CI_DRM_12569 -> Patchwork_112630v1 Summary ---

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/gvt: Avoid full proxy f_ops debug attributes

2023-01-10 Thread Patchwork
== Series Details == Series: drm/i915/gvt: Avoid full proxy f_ops debug attributes URL : https://patchwork.freedesktop.org/series/112630/ State : warning == Summary == Error: dim checkpatch failed 4c95e9b71212 drm/i915/gvt: Avoid full proxy f_ops for scan_nonprivbb debug attributes -:21: WARN

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Avoid full proxy f_ops debug attributes

2023-01-10 Thread Patchwork
== Series Details == Series: drm/i915: Avoid full proxy f_ops debug attributes URL : https://patchwork.freedesktop.org/series/112625/ State : success == Summary == CI Bug Log - changes from CI_DRM_12569 -> Patchwork_112625v1 Summary ---

Re: [Intel-gfx] [PATCH v2] drm/i915/display: assume some pixelrate for src smaller than 1

2023-01-10 Thread Imre Deak
On Sun, Jan 08, 2023 at 01:30:44PM +0200, Juha-Pekka Heikkila wrote: > intel_adjusted_rate() didn't take into account src rectangle > can be less than 1 in with or height. Thanks for catching this. > Signed-off-by: Juha-Pekka Heikkila > --- > drivers/gpu/drm/i915/display/intel_atomic_plane.c |

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Implement workaround for DP2 UHBR bandwidth check (rev2)

2023-01-10 Thread Patchwork
== Series Details == Series: drm/i915: Implement workaround for DP2 UHBR bandwidth check (rev2) URL : https://patchwork.freedesktop.org/series/112345/ State : success == Summary == CI Bug Log - changes from CI_DRM_12567_full -> Patchwork_112345v2_full ==

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: Avoid full proxy f_ops debug attributes

2023-01-10 Thread Patchwork
== Series Details == Series: drm/i915: Avoid full proxy f_ops debug attributes URL : https://patchwork.freedesktop.org/series/112625/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. +./arch/x86/include/asm/b

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Avoid full proxy f_ops debug attributes

2023-01-10 Thread Patchwork
== Series Details == Series: drm/i915: Avoid full proxy f_ops debug attributes URL : https://patchwork.freedesktop.org/series/112625/ State : warning == Summary == Error: dim checkpatch failed 96ecad527e9e drm/i915/display: Avoid full proxy f_ops for DRRS debug attributes -:21: WARNING:COMMIT_

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Add missing check and destroy for alloc_workqueue

2023-01-10 Thread Patchwork
== Series Details == Series: drm/i915: Add missing check and destroy for alloc_workqueue URL : https://patchwork.freedesktop.org/series/112623/ State : success == Summary == CI Bug Log - changes from CI_DRM_12569 -> Patchwork_112623v1 Summa

Re: [Intel-gfx] [PATCH] drm/i915/display: Check source height is > 0

2023-01-10 Thread Drew Davenport
On Tue, Jan 03, 2023 at 12:42:43PM +0200, Juha-Pekka Heikkila wrote: > Hi Drew, Hi Juha-Pekka, sorry for the late response since I was on vacation. > > this is good find. I went looking where the problem is in and saw what you > probably also saw earlier. > > I was wondering if diff below would

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/guc: Replace zero-length arrays with flexible-array members

2023-01-10 Thread Patchwork
== Series Details == Series: drm/i915/guc: Replace zero-length arrays with flexible-array members URL : https://patchwork.freedesktop.org/series/112621/ State : success == Summary == CI Bug Log - changes from CI_DRM_12569 -> Patchwork_112621v1 ==

Re: [Intel-gfx] [PATCH][next] drm/i915/guc: Replace zero-length arrays with flexible-array members

2023-01-10 Thread Gustavo A. R. Silva
On Tue, Jan 10, 2023 at 02:28:11PM -0500, Rodrigo Vivi wrote: > > On Tue, Jan 10, 2023 at 10:44:53AM -0600, Gustavo A. R. Silva wrote: > > Zero-length arrays are deprecated[1] and we are moving towards > > adopting C99 flexible-array members, instead. So, replace zero-length > > arrays in a couple

[Intel-gfx] ✓ Fi.CI.BAT: success for ACPI: Fix selecting the wrong ACPI fwnode for the iGPU on some Dell laptops (rev3)

2023-01-10 Thread Patchwork
== Series Details == Series: ACPI: Fix selecting the wrong ACPI fwnode for the iGPU on some Dell laptops (rev3) URL : https://patchwork.freedesktop.org/series/112572/ State : success == Summary == CI Bug Log - changes from CI_DRM_12569 -> Patchwork_112572v3 ===

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Do not cover all future platforms in TLB invalidation (rev3)

2023-01-10 Thread Patchwork
== Series Details == Series: drm/i915: Do not cover all future platforms in TLB invalidation (rev3) URL : https://patchwork.freedesktop.org/series/112484/ State : success == Summary == CI Bug Log - changes from CI_DRM_12566_full -> Patchwork_112484v3_full ==

Re: [Intel-gfx] [PATCH][next] drm/i915/guc: Replace zero-length arrays with flexible-array members

2023-01-10 Thread Rodrigo Vivi
On Tue, Jan 10, 2023 at 10:44:53AM -0600, Gustavo A. R. Silva wrote: > Zero-length arrays are deprecated[1] and we are moving towards > adopting C99 flexible-array members, instead. So, replace zero-length > arrays in a couple of structures (three, actually) with flex-array > members. > > This h

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for ACPI: Fix selecting the wrong ACPI fwnode for the iGPU on some Dell laptops (rev3)

2023-01-10 Thread Patchwork
== Series Details == Series: ACPI: Fix selecting the wrong ACPI fwnode for the iGPU on some Dell laptops (rev3) URL : https://patchwork.freedesktop.org/series/112572/ State : warning == Summary == Error: dim checkpatch failed 7f834ef56961 ACPI: Fix selecting the wrong ACPI fwnode for the iGPU

Re: [Intel-gfx] [PATCH] drm/i915: Implement workaround for DP2 UHBR bandwidth check

2023-01-10 Thread Rodrigo Vivi
On Tue, Jan 10, 2023 at 02:33:38PM +0200, Stanislav Lisovskiy wrote: > According to spec, we should check if output_bpp * pixel_rate is less > than DDI clock * 72, if UHBR is used. > > HSDES: 1406899791 > BSPEC: 49259 > > v2: - Removed wrong comment(Rodrigo Vivi) > - Added HSDES to the commit

Re: [Intel-gfx] [RFC PATCH 04/20] drm/sched: Convert drm scheduler to use a work queue rather than kthread

2023-01-10 Thread Matthew Brost
On Tue, Jan 10, 2023 at 04:50:55PM +, Tvrtko Ursulin wrote: > > On 10/01/2023 15:55, Matthew Brost wrote: > > On Tue, Jan 10, 2023 at 12:19:35PM +, Tvrtko Ursulin wrote: > > > > > > On 10/01/2023 11:28, Tvrtko Ursulin wrote: > > > > > > > > > > > > On 09/01/2023 17:27, Jason Ekstrand wr

Re: [Intel-gfx] [PATCH v2 2/2] drm/i915/fbc: Avoid full proxy f_ops for FBC debug attributes

2023-01-10 Thread Rodrigo Vivi
On Tue, Jan 10, 2023 at 11:45:40PM +0530, Deepak R Varma wrote: > Using DEFINE_SIMPLE_ATTRIBUTE macro with the debugfs_create_file() > function adds the overhead of introducing a proxy file operation > functions to wrap the original read/write inside file removal protection > functions. This adds s

Re: [Intel-gfx] [PATCH v2 1/2] drm/i915/display: Avoid full proxy f_ops for DRRS debug attributes

2023-01-10 Thread Rodrigo Vivi
On Tue, Jan 10, 2023 at 11:45:02PM +0530, Deepak R Varma wrote: > Using DEFINE_SIMPLE_ATTRIBUTE macro with the debugfs_create_file() > function adds the overhead of introducing a proxy file operation > functions to wrap the original read/write inside file removal protection > functions. This adds s

Re: [Intel-gfx] [PATCH 2/2] drm/i915/gvt: Avoid full proxy f_ops for vgpu_status debug attributes

2023-01-10 Thread Rodrigo Vivi
On Wed, Jan 11, 2023 at 12:00:12AM +0530, Deepak R Varma wrote: > Using DEFINE_SIMPLE_ATTRIBUTE macro with the debugfs_create_file() > function adds the overhead of introducing a proxy file operation > functions to wrap the original read/write inside file removal protection > functions. This adds s

[Intel-gfx] [PATCH 2/2] drm/i915/gvt: Avoid full proxy f_ops for vgpu_status debug attributes

2023-01-10 Thread Deepak R Varma
Using DEFINE_SIMPLE_ATTRIBUTE macro with the debugfs_create_file() function adds the overhead of introducing a proxy file operation functions to wrap the original read/write inside file removal protection functions. This adds significant overhead in terms of introducing and managing the proxy facto

[Intel-gfx] [PATCH 1/2] drm/i915/gvt: Avoid full proxy f_ops for scan_nonprivbb debug attributes

2023-01-10 Thread Deepak R Varma
Using DEFINE_SIMPLE_ATTRIBUTE macro with the debugfs_create_file() function adds the overhead of introducing a proxy file operation functions to wrap the original read/write inside file removal protection functions. This adds significant overhead in terms of introducing and managing the proxy facto

[Intel-gfx] [PATCH 0/2] drm/i915/gvt: Avoid full proxy f_ops debug attributes

2023-01-10 Thread Deepak R Varma
This patch series proposes to replace a combination of DEFINE_SIMPLE_ATTRIBUTE() + debugfs_create_file() by a combination of DEFINE_DEBUGFS_ATTRIBUTE() + debugfs_create_file_unsafe(). The change reduced overhead in terms of managing the full proxy f_ops at runtime. The patches 1 & 2 covers for the

[Intel-gfx] [PATCH v2 2/2] drm/i915/fbc: Avoid full proxy f_ops for FBC debug attributes

2023-01-10 Thread Deepak R Varma
Using DEFINE_SIMPLE_ATTRIBUTE macro with the debugfs_create_file() function adds the overhead of introducing a proxy file operation functions to wrap the original read/write inside file removal protection functions. This adds significant overhead in terms of introducing and managing the proxy facto

[Intel-gfx] [PATCH v2 1/2] drm/i915/display: Avoid full proxy f_ops for DRRS debug attributes

2023-01-10 Thread Deepak R Varma
Using DEFINE_SIMPLE_ATTRIBUTE macro with the debugfs_create_file() function adds the overhead of introducing a proxy file operation functions to wrap the original read/write inside file removal protection functions. This adds significant overhead in terms of introducing and managing the proxy facto

[Intel-gfx] [PATCH 0/2 v2] drm/i915: Avoid full proxy f_ops debug attributes

2023-01-10 Thread Deepak R Varma
This patch series proposes to replace a combination of DEFINE_SIMPLE_ATTRIBUTE() + debugfs_create_file() by a combination of DEFINE_DEBUGFS_ATTRIBUTE() + debugfs_create_file_unsafe(). The change reduced overhead in terms of managing the full proxy f_ops at runtime. The patches 1 & 2 covers for the

Re: [Intel-gfx] [PATCH] drm/i915: Add missing check and destroy for alloc_workqueue

2023-01-10 Thread Jiasheng Jiang
On Sat, Jan 07, 2023 at 02:29:22AM +0800, Daniel Vetter wrote: >On Fri, Jan 06, 2023 at 05:09:34PM +0800, Jiasheng Jiang wrote: >> Add checks for the return value of alloc_workqueue and >> alloc_ordered_workqueue as they may return NULL pointer and cause NULL >> pointer dereference. >> Moreover, de

[Intel-gfx] [PATCH] drm/i915: Add missing check and destroy for alloc_workqueue

2023-01-10 Thread Jiasheng Jiang
Add checks for the return value of alloc_workqueue and alloc_ordered_workqueue as they may return NULL pointer and cause NULL pointer dereference. Moreover, destroy them when fails later in order to avoid memory leak. Because in `drivers/gpu/drm/i915/i915_driver.c`, if intel_modeset_init_noirq fail

[Intel-gfx] [PATCH][next] drm/i915/guc: Replace zero-length arrays with flexible-array members

2023-01-10 Thread Gustavo A. R. Silva
Zero-length arrays are deprecated[1] and we are moving towards adopting C99 flexible-array members, instead. So, replace zero-length arrays in a couple of structures (three, actually) with flex-array members. This helps with the ongoing efforts to tighten the FORTIFY_SOURCE routines on memcpy() an

[Intel-gfx] [PATCH 2/2] drm/i915: Replace alloc*workqueue with DRM helpers

2023-01-10 Thread Jiasheng Jiang
Replace alloc*workqueue with DRM helpers in order to avoid memory leak. Moreover, check the return value since the workqueue may be NULL and cause NULL pointer dereference. Fixes: c26a058680dc ("drm/i915: Use a high priority wq for nonblocking plane updates") Fixes: 757fffcfdffb ("drm/i915: Put a

Re: [Intel-gfx] [PATCH 1/5] linux/minmax.h: add non-atomic version of xchg

2023-01-10 Thread Mark Rutland
On Thu, Jan 05, 2023 at 03:57:25PM +0100, Daniel Vetter wrote: > It's more fun, for the atomic functions which don't have the atomic_ > prefix in their names, the __ prefixed versions provide the non-atomic > implementation. This pattern was started with the long * bitops stuff for > managing real

Re: [Intel-gfx] [PATCH] drm/i915: Remove i915_drm_suspend_mode

2023-01-10 Thread Rodrigo Vivi
On Tue, Jan 10, 2023 at 11:59:02AM +0100, Maarten Lankhorst wrote: > enum i915_drm_suspend_mode suspend_mode is only used in > intel_display_power, while we only care about whether we perform a > s2idle. Remove it and use a simple bool. > > Signed-off-by: Maarten Lankhorst Reviewed-by: Rodrigo V

Re: [Intel-gfx] [PATCH] drm/i915/gt: Cover rest of SVG unit MCR registers

2023-01-10 Thread Matt Roper
On Thu, Jan 05, 2023 at 10:37:01AM -0300, Gustavo Sousa wrote: > CHICKEN_RASTER_{1,2} got overlooked with the move done in a9e69428b1b4 > ("drm/i915: Define MCR registers explicitly"). Registers from the SVG > unit became multicast as of Xe_HP graphics. > > BSpec: 66534 > Fixes: a9e69428b1b4 ("drm

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Remove i915_drm_suspend_mode

2023-01-10 Thread Patchwork
== Series Details == Series: drm/i915: Remove i915_drm_suspend_mode URL : https://patchwork.freedesktop.org/series/112607/ State : success == Summary == CI Bug Log - changes from CI_DRM_12565_full -> Patchwork_112607v1_full Summary ---

Re: [Intel-gfx] [RFC PATCH 04/20] drm/sched: Convert drm scheduler to use a work queue rather than kthread

2023-01-10 Thread Tvrtko Ursulin
On 10/01/2023 15:55, Matthew Brost wrote: On Tue, Jan 10, 2023 at 12:19:35PM +, Tvrtko Ursulin wrote: On 10/01/2023 11:28, Tvrtko Ursulin wrote: On 09/01/2023 17:27, Jason Ekstrand wrote: [snip] >>> AFAICT it proposes to have 1:1 between *userspace* created     contexts (per

Re: [Intel-gfx] [RFC PATCH 04/20] drm/sched: Convert drm scheduler to use a work queue rather than kthread

2023-01-10 Thread Matthew Brost
On Tue, Jan 10, 2023 at 11:28:08AM +, Tvrtko Ursulin wrote: > > > On 09/01/2023 17:27, Jason Ekstrand wrote: > > [snip] > > > >>> AFAICT it proposes to have 1:1 between *userspace* created > > contexts (per > > >>> context _and_ engine) and drm_sched. I am not sure avoiding >

[Intel-gfx] ✓ Fi.CI.IGT: success for Enable HDCP2.x via GSC CS (rev7)

2023-01-10 Thread Patchwork
== Series Details == Series: Enable HDCP2.x via GSC CS (rev7) URL : https://patchwork.freedesktop.org/series/111876/ State : success == Summary == CI Bug Log - changes from CI_DRM_12565_full -> Patchwork_111876v7_full Summary --- **S

Re: [Intel-gfx] [PATCH v3] drm/i915/display/misc: use intel_de_rmw if possible

2023-01-10 Thread Rodrigo Vivi
On Tue, Jan 10, 2023 at 12:36:56PM +0100, Andrzej Hajda wrote: > The helper makes the code more compact and readable. next time, please add the revision comments here so we know what changed from one version to the next. > > Signed-off-by: Andrzej Hajda > --- > drivers/gpu/drm/i915/display/g4x

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Implement workaround for DP2 UHBR bandwidth check (rev2)

2023-01-10 Thread Patchwork
== Series Details == Series: drm/i915: Implement workaround for DP2 UHBR bandwidth check (rev2) URL : https://patchwork.freedesktop.org/series/112345/ State : success == Summary == CI Bug Log - changes from CI_DRM_12567 -> Patchwork_112345v2

Re: [Intel-gfx] [RFC 2/2] drm/i915/display: Add 480 MHz CDCLK steps for RPL-U

2023-01-10 Thread Jani Nikula
On Tue, 10 Jan 2023, Matt Roper wrote: > On Tue, Jan 10, 2023 at 11:06:14AM +0200, Jani Nikula wrote: >> On Sat, 07 Jan 2023, Chaitanya Kumar Borah >> wrote: >> > @@ -3353,6 +3374,8 @@ void intel_init_cdclk_hooks(struct drm_i915_private >> > *dev_priv) >> >/* Wa_22011320316:adl-p[a0

Re: [Intel-gfx] [PATCH v4] drm/i915: Do not cover all future platforms in TLB invalidation

2023-01-10 Thread Matt Roper
On Tue, Jan 10, 2023 at 11:35:33AM +, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > Revert to the original explicit approach and document the reasoning > behind it. > > v2: > * DG2 needs to be covered too. (Matt) > > v3: > * Full version check for Gen12 to avoid catching all future pla

Re: [Intel-gfx] [RFC PATCH 04/20] drm/sched: Convert drm scheduler to use a work queue rather than kthread

2023-01-10 Thread Matthew Brost
On Tue, Jan 10, 2023 at 12:19:35PM +, Tvrtko Ursulin wrote: > > On 10/01/2023 11:28, Tvrtko Ursulin wrote: > > > > > > On 09/01/2023 17:27, Jason Ekstrand wrote: > > > > [snip] > > > > > >>> AFAICT it proposes to have 1:1 between *userspace* created > > >     contexts (per > > >

Re: [Intel-gfx] [PATCH] drm: Alloc high address for drm buddy topdown flag

2023-01-10 Thread Matthew Auld
On 10/01/2023 12:02, Matthew Auld wrote: On 07/01/2023 15:15, Arunpravin Paneer Selvam wrote: As we are observing low numbers in viewperf graphics benchmark, we are strictly not allowing the top down flag enabled allocations to steal the memory space from cpu visible region. The approach is, we

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [v2,1/9] drm/i915/display/core: use intel_de_rmw if possible (rev3)

2023-01-10 Thread Patchwork
== Series Details == Series: series starting with [v2,1/9] drm/i915/display/core: use intel_de_rmw if possible (rev3) URL : https://patchwork.freedesktop.org/series/112438/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12567 -> Patchwork_112438v3 =

Re: [Intel-gfx] [RFC 2/2] drm/i915/display: Add 480 MHz CDCLK steps for RPL-U

2023-01-10 Thread Matt Roper
On Tue, Jan 10, 2023 at 11:06:14AM +0200, Jani Nikula wrote: > On Sat, 07 Jan 2023, Chaitanya Kumar Borah > wrote: > > A new step of 480MHz has been added on SKUs that have a RPL-U > > device id to support 120Hz displays more efficiently. Use a > > new quirk to identify the machine for which this

Re: [Intel-gfx] [PATCH 1/4] vfio-mdev: allow building the samples into the kernel

2023-01-10 Thread Christoph Hellwig
On Tue, Jan 10, 2023 at 09:54:51AM -0500, Anthony Krowiak wrote: >> +tristate "Build VFIO mtty example mediated device sample code" >> +depends on VFIO_MDEV > > > Admittedly, I'm not very fluent with Kconfig, but in patch 2 you stated, > "VFIO_MDEV is just a library with helpers for the dr

Re: [Intel-gfx] [PATCH 1/4] vfio-mdev: allow building the samples into the kernel

2023-01-10 Thread Anthony Krowiak
On 1/10/23 10:27 AM, Christoph Hellwig wrote: On Tue, Jan 10, 2023 at 09:54:51AM -0500, Anthony Krowiak wrote: + tristate "Build VFIO mtty example mediated device sample code" + depends on VFIO_MDEV Admittedly, I'm not very fluent with Kconfig, but in patch 2 you stated, "VFIO_MD

[Intel-gfx] [PATCH v2] ACPI: Fix selecting the wrong ACPI fwnode for the iGPU on some Dell laptops

2023-01-10 Thread Hans de Goede
The Dell Latitude E6430 both with and without the optional NVidia dGPU has a bug in its ACPI tables which is causing Linux to assign the wrong ACPI fwnode / companion to the pci_device for the i915 iGPU. Specifically under the PCI root bridge there are these 2 ACPI Device()s : Scope (_SB.PCI0)

Re: [Intel-gfx] [PATCH] ACPI: Fix selecting the wrong ACPI fwnode for the iGPU on some Dell laptops

2023-01-10 Thread Hans de Goede
Hi Rafael, On 1/10/23 14:33, Rafael J. Wysocki wrote: > On Monday, January 9, 2023 9:57:21 PM CET Hans de Goede wrote: >> The Dell Latitude E6430 both with and without the optional NVidia dGPU >> has a bug in its ACPI tables which is causing Linux to assign the wrong >> ACPI fwnode / companion to

Re: [Intel-gfx] [PATCH] drm: Alloc high address for drm buddy topdown flag

2023-01-10 Thread Arunpravin Paneer Selvam
Hi Matthew, On 1/10/2023 5:32 PM, Matthew Auld wrote: On 07/01/2023 15:15, Arunpravin Paneer Selvam wrote: As we are observing low numbers in viewperf graphics benchmark, we are strictly not allowing the top down flag enabled allocations to steal the memory space from cpu visible region. The a

Re: [Intel-gfx] [PATCH] Copy highest enabled wm level to disabled wm levels for gen >= 12

2023-01-10 Thread Lisovskiy, Stanislav
On Tue, Dec 20, 2022 at 01:19:54PM +0200, Ville Syrjälä wrote: > On Mon, Dec 19, 2022 at 09:29:19AM +0200, Stanislav Lisovskiy wrote: > > There was a specific SW workaround requested, which should prevent > > some watermark issues happening, which requires copying highest > > enabled wm level to th

Re: [Intel-gfx] [PATCH 1/4] vfio-mdev: allow building the samples into the kernel

2023-01-10 Thread Anthony Krowiak
On 1/10/23 4:10 AM, Christoph Hellwig wrote: There is nothing in the vfio-mdev sample drivers that requires building them as modules, so remove that restriction. Signed-off-by: Christoph Hellwig --- samples/Kconfig | 16 1 file changed, 8 insertions(+), 8 deletions(-) dif

Re: [Intel-gfx] [PATCH 2/4] vfio-mdev: turn VFIO_MDEV into a selectable symbol

2023-01-10 Thread Anthony Krowiak
Reviewed-by: Tony Krowiak On 1/10/23 4:10 AM, Christoph Hellwig wrote: VFIO_MDEV is just a library with helpers for the drivers. Stop making it a user choice and just select it by the drivers that use the helpers. Signed-off-by: Christoph Hellwig --- Documentation/s390/vfio-ap.rst| 1 -

Re: [Intel-gfx] [PATCH 4/4] vfio-mdev: remove an non-existing driver from vfio-mediated-device

2023-01-10 Thread Anthony Krowiak
LGTM Reviewed-by: Tony Krowiak On 1/10/23 4:10 AM, Christoph Hellwig wrote: The nvidia mdev driver does not actually exist anywhere in the tree. Signed-off-by: Christoph Hellwig --- Documentation/driver-api/vfio-mediated-device.rst | 8 +--- 1 file changed, 1 insertion(+), 7 deletions

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Do not cover all future platforms in TLB invalidation (rev3)

2023-01-10 Thread Patchwork
== Series Details == Series: drm/i915: Do not cover all future platforms in TLB invalidation (rev3) URL : https://patchwork.freedesktop.org/series/112484/ State : success == Summary == CI Bug Log - changes from CI_DRM_12566 -> Patchwork_112484v3

Re: [Intel-gfx] [RFC PATCH 04/20] drm/sched: Convert drm scheduler to use a work queue rather than kthread

2023-01-10 Thread Jason Ekstrand
On Tue, Jan 10, 2023 at 5:28 AM Tvrtko Ursulin < tvrtko.ursu...@linux.intel.com> wrote: > > > On 09/01/2023 17:27, Jason Ekstrand wrote: > > [snip] > > > >>> AFAICT it proposes to have 1:1 between *userspace* created > > contexts (per > > >>> context _and_ engine) and drm_sched. I am

Re: [Intel-gfx] [RFC DO NOT MERGE] treewide: use __xchg in most obvious places

2023-01-10 Thread Andy Shevchenko
On Tue, Jan 10, 2023 at 01:46:37PM +0100, Andrzej Hajda wrote: > On 10.01.2023 12:07, Andy Shevchenko wrote: > > On Tue, Jan 10, 2023 at 11:53:06AM +0100, Andrzej Hajda wrote: ... > > > + return __xchg(&p_chain->p_prod_elem, > > > + (void *)(((u8 *)p_chain->p_prod_elem) + > > > p_c

Re: [Intel-gfx] [PATCH] ACPI: Fix selecting the wrong ACPI fwnode for the iGPU on some Dell laptops

2023-01-10 Thread Rafael J. Wysocki
On Monday, January 9, 2023 9:57:21 PM CET Hans de Goede wrote: > The Dell Latitude E6430 both with and without the optional NVidia dGPU > has a bug in its ACPI tables which is causing Linux to assign the wrong > ACPI fwnode / companion to the pci_device for the i915 iGPU. > > Specifically under th

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Remove i915_drm_suspend_mode

2023-01-10 Thread Patchwork
== Series Details == Series: drm/i915: Remove i915_drm_suspend_mode URL : https://patchwork.freedesktop.org/series/112607/ State : success == Summary == CI Bug Log - changes from CI_DRM_12565 -> Patchwork_112607v1 Summary --- **SUCCE

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/display: drop redundant display/ from #includes (rev5)

2023-01-10 Thread Patchwork
== Series Details == Series: drm/i915/display: drop redundant display/ from #includes (rev5) URL : https://patchwork.freedesktop.org/series/111803/ State : success == Summary == CI Bug Log - changes from CI_DRM_12562_full -> Patchwork_111803v5_full =

Re: [Intel-gfx] [RFC DO NOT MERGE] treewide: use __xchg in most obvious places

2023-01-10 Thread Andrzej Hajda
On 10.01.2023 12:07, Andy Shevchenko wrote: On Tue, Jan 10, 2023 at 11:53:06AM +0100, Andrzej Hajda wrote: This patch tries to show usability of __xchg helper. It is not intended to be merged, but I can convert it to proper patchset if necessary. There are many more places where __xchg can be u

Re: [Intel-gfx] [RFC PATCH 00/20] Initial Xe driver submission

2023-01-10 Thread Boris Brezillon
+Frank, who's also working on the pvr uAPI. Hi, On Thu, 22 Dec 2022 14:21:07 -0800 Matthew Brost wrote: > The code has been organized such that we have all patches that touch areas > outside of drm/xe first for review, and then the actual new driver in a > separate > commit. The code which is

  1   2   >