Re: [Intel-gfx] [PATCH] drm/i915: Fix memory leaks in scatterlist

2023-02-01 Thread Harish Chegondi
On Wed, Feb 01, 2023 at 03:28:01PM -0800, Matt Atwood wrote: > This patch fixes memory leaks on error escapes in i915_scatterlist.c > > Fixes: c3bfba9a2225 ("drm/i915: Check for integer truncation on scatterlist > creation") > Cc: Chris Wilson > Signed-off-by: Matt Atwood Reviewed-by: Harish

Re: [Intel-gfx] [PATCH v3] drm/i915: Consolidate TLB invalidation flow

2023-02-01 Thread Andrzej Hajda
On 01.02.2023 17:51, Tvrtko Ursulin wrote: From: Tvrtko Ursulin As the logic for selecting the register and corresponsing values grew, the code become a bit unsightly. Consolidate by storing the required values at engine init time in the engine itself, and by doing so minimise the amount of

Re: [Intel-gfx] [PATCHv3] drm/i915: Support Async Flip on Linear buffers

2023-02-01 Thread Murthy, Arun R
Gentle Reminder! The patch is pending since a long time. Thanks and Regards, Arun R Murthy --- > -Original Message- > From: Murthy, Arun R > Sent: Monday, January 23, 2023 12:14 PM > To: 'Ville Syrjälä' > Cc: 'intel-gfx@lists.freedesktop.org' ; > Syrjala, Ville >

Re: [Intel-gfx] [PATCH v2] vfio: fix deadlock between group lock and kvm lock

2023-02-01 Thread Liu, Yi L
> -Original Message- > From: Alex Williamson > Sent: Thursday, February 2, 2023 12:15 PM > To: Liu, Yi L > Cc: Matthew Rosato ; pbonz...@redhat.com; > j...@nvidia.com; coh...@redhat.com; far...@linux.ibm.com; > pmo...@linux.ibm.com; borntrae...@linux.ibm.com; > fran...@linux.ibm.com;

Re: [Intel-gfx] [PATCH v2] vfio: fix deadlock between group lock and kvm lock

2023-02-01 Thread Alex Williamson
On Thu, 2 Feb 2023 03:46:59 + "Liu, Yi L" wrote: > > From: Alex Williamson > > Sent: Thursday, February 2, 2023 7:28 AM > > > > On Wed, 1 Feb 2023 14:20:10 -0500 > > Matthew Rosato wrote: > > > > > After 51cdc8bc120e, we have another deadlock scenario between the > > > kvm->lock and

Re: [Intel-gfx] [PATCH v2] vfio: fix deadlock between group lock and kvm lock

2023-02-01 Thread Tian, Kevin
> From: Alex Williamson > Sent: Thursday, February 2, 2023 7:28 AM > > > > +#ifdef CONFIG_HAVE_KVM > > +static bool vfio_kvm_get_kvm_safe(struct vfio_device *device, struct kvm > *kvm) > > I'm tempted to name these vfio_device_get_kvm_safe() and only pass the > vfio_device, where of course we

Re: [Intel-gfx] [PATCH v2] vfio: fix deadlock between group lock and kvm lock

2023-02-01 Thread Tian, Kevin
> From: Liu, Yi L > Sent: Thursday, February 2, 2023 11:47 AM > > > ret = vfio_device_open(device, device->group->iommufd, > > > device->group->kvm); > > > > We're using device->group->kvm outside of kvm_ref_lock here, it should > > be using device->kvm. > > Existing

Re: [Intel-gfx] [PATCH v2] vfio: fix deadlock between group lock and kvm lock

2023-02-01 Thread Liu, Yi L
> From: Alex Williamson > Sent: Thursday, February 2, 2023 7:28 AM > > On Wed, 1 Feb 2023 14:20:10 -0500 > Matthew Rosato wrote: > > > After 51cdc8bc120e, we have another deadlock scenario between the > > kvm->lock and the vfio group_lock with two different codepaths acquiring > > the locks

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/hwmon: Enable PL1 power limit

2023-02-01 Thread Patchwork
== Series Details == Series: drm/i915/hwmon: Enable PL1 power limit URL : https://patchwork.freedesktop.org/series/113578/ State : success == Summary == CI Bug Log - changes from CI_DRM_12681 -> Patchwork_113578v1 Summary ---

Re: [Intel-gfx] [PATCH] vfio: fix deadlock between group lock and kvm lock

2023-02-01 Thread Liu, Yi L
> From: Matthew Rosato > Sent: Wednesday, February 1, 2023 10:43 PM > > On 2/1/23 7:43 AM, Liu, Yi L wrote: > >> From: Jason Gunthorpe > >> Sent: Wednesday, February 1, 2023 4:26 AM > >> > >> On Tue, Jan 31, 2023 at 03:06:35PM -0500, Matthew Rosato wrote: > >>> @@ -799,13 +794,14 @@ > >>

[Intel-gfx] [PATCH] drm/i915/hwmon: Enable PL1 power limit

2023-02-01 Thread Ashutosh Dixit
Previous documentation suggested that PL1 power limit is always enabled. However we now find this not to be the case on some platforms (such as ATSM). Therefore enable PL1 power limit during hwmon initialization. Signed-off-by: Ashutosh Dixit --- drivers/gpu/drm/i915/i915_hwmon.c | 5 + 1

Re: [Intel-gfx] [PATCH v10 00/23] drm/i915/vm_bind: Add VM_BIND functionality

2023-02-01 Thread Zanoni, Paulo R
On Tue, 2023-01-17 at 23:15 -0800, Niranjana Vishwanathapura wrote: > DRM_I915_GEM_VM_BIND/UNBIND ioctls allows UMD to bind/unbind GEM > buffer objects (BOs) or sections of a BOs at specified GPU virtual > addresses on a specified address space (VM). Multiple mappings can map > to the same

[Intel-gfx] ✓ Fi.CI.IGT: success for vfio: fix deadlock between group lock and kvm lock (rev3)

2023-02-01 Thread Patchwork
== Series Details == Series: vfio: fix deadlock between group lock and kvm lock (rev3) URL : https://patchwork.freedesktop.org/series/113535/ State : success == Summary == CI Bug Log - changes from CI_DRM_12681_full -> Patchwork_113535v3_full

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Fix memory leaks in scatterlist

2023-02-01 Thread Patchwork
== Series Details == Series: drm/i915: Fix memory leaks in scatterlist URL : https://patchwork.freedesktop.org/series/113576/ State : success == Summary == CI Bug Log - changes from CI_DRM_12681 -> Patchwork_113576v1 Summary ---

[Intel-gfx] ✓ Fi.CI.BAT: success for vfio: fix deadlock between group lock and kvm lock (rev3)

2023-02-01 Thread Patchwork
== Series Details == Series: vfio: fix deadlock between group lock and kvm lock (rev3) URL : https://patchwork.freedesktop.org/series/113535/ State : success == Summary == CI Bug Log - changes from CI_DRM_12681 -> Patchwork_113535v3

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/4] drm/i915/pvc: Annotate two more workaround/tuning registers as MCR

2023-02-01 Thread Patchwork
== Series Details == Series: series starting with [1/4] drm/i915/pvc: Annotate two more workaround/tuning registers as MCR URL : https://patchwork.freedesktop.org/series/113573/ State : success == Summary == CI Bug Log - changes from CI_DRM_12681_full -> Patchwork_113573v1_full

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for vfio: fix deadlock between group lock and kvm lock (rev3)

2023-02-01 Thread Patchwork
== Series Details == Series: vfio: fix deadlock between group lock and kvm lock (rev3) URL : https://patchwork.freedesktop.org/series/113535/ State : warning == Summary == Error: dim checkpatch failed c2474b730a36 vfio: fix deadlock between group lock and kvm lock -:23:

[Intel-gfx] [PATCH] drm/i915: Fix memory leaks in scatterlist

2023-02-01 Thread Matt Atwood
This patch fixes memory leaks on error escapes in i915_scatterlist.c Fixes: c3bfba9a2225 ("drm/i915: Check for integer truncation on scatterlist creation") Cc: Chris Wilson Signed-off-by: Matt Atwood --- drivers/gpu/drm/i915/i915_scatterlist.c | 8 ++-- 1 file changed, 6 insertions(+), 2

Re: [Intel-gfx] [PATCH v2] vfio: fix deadlock between group lock and kvm lock

2023-02-01 Thread Alex Williamson
On Wed, 1 Feb 2023 14:20:10 -0500 Matthew Rosato wrote: > After 51cdc8bc120e, we have another deadlock scenario between the > kvm->lock and the vfio group_lock with two different codepaths acquiring > the locks in different order. Specifically in vfio_open_device, vfio > holds the vfio

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/4] drm/i915/pvc: Annotate two more workaround/tuning registers as MCR

2023-02-01 Thread Patchwork
== Series Details == Series: series starting with [1/4] drm/i915/pvc: Annotate two more workaround/tuning registers as MCR URL : https://patchwork.freedesktop.org/series/113573/ State : success == Summary == CI Bug Log - changes from CI_DRM_12681 -> Patchwork_113573v1

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/4] drm/i915/pvc: Annotate two more workaround/tuning registers as MCR

2023-02-01 Thread Patchwork
== Series Details == Series: series starting with [1/4] drm/i915/pvc: Annotate two more workaround/tuning registers as MCR URL : https://patchwork.freedesktop.org/series/113573/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be

[Intel-gfx] [PATCH 4/4] drm/i915/selftest: Use forcewake to sanity check engine wa lists

2023-02-01 Thread Matt Roper
Although register information in the bspec includes a field that is supposed to reflect a register's reset characteristics (i.e., whether a register maintains its value through engine resets), it's been discovered that this information is incorrect for some register ranges (i.e., registers that

[Intel-gfx] [PATCH 2/4] drm/i915/gen11: Wa_1408615072/Wa_1407596294 should be on GT list

2023-02-01 Thread Matt Roper
The UNSLICE_UNIT_LEVEL_CLKGATE register programmed by this workaround has 'BUS' style reset, indicating that it does not lose its value on engine resets. Furthermore, this register is part of the GT forcewake domain rather than the RENDER domain, so it should not be impacted by RCS engine resets.

[Intel-gfx] [PATCH 1/4] drm/i915/pvc: Annotate two more workaround/tuning registers as MCR

2023-02-01 Thread Matt Roper
XEHPC_LNCFMISCCFGREG0 and XEHPC_L3SCRUB are both in MCR register ranges on PVC (with HALFBSLICE and L3BANK replication respectively), so they should be explicitly declared as MCR registers and use MCR-aware workaround handlers. The workarounds/tuning settings should still be applied properly on

[Intel-gfx] [PATCH 3/4] drm/i915/xehp: LNCF/LBCF workarounds should be on the GT list

2023-02-01 Thread Matt Roper
Although registers in the L3 bank/node configuration ranges are marked as having "DEV" reset characteristics in the bspec, this appears to be a hold-over from pre-Xe_HP platforms. In reality, these registers maintain their values across engine resets, meaning that workarounds and tuning settings

Re: [Intel-gfx] linux-next: manual merge of the usb tree with the drm-intel-fixes tree

2023-02-01 Thread Rodrigo Vivi
On Wed, Feb 01, 2023 at 10:37:06AM -0800, John Harrison wrote: > On 2/1/2023 07:31, Rodrigo Vivi wrote: > > On Wed, Feb 01, 2023 at 03:11:31PM +1100, Stephen Rothwell wrote: > > > Hi all, > > > > > > On Tue, 31 Jan 2023 10:27:29 -0800 John Harrison > > > wrote: > > > > On 1/31/2023 04:44, Andy

[Intel-gfx] ✓ Fi.CI.IGT: success for vfio: fix deadlock between group lock and kvm lock (rev2)

2023-02-01 Thread Patchwork
== Series Details == Series: vfio: fix deadlock between group lock and kvm lock (rev2) URL : https://patchwork.freedesktop.org/series/113535/ State : success == Summary == CI Bug Log - changes from CI_DRM_12680_full -> Patchwork_113535v2_full

[Intel-gfx] ✓ Fi.CI.BAT: success for vfio: fix deadlock between group lock and kvm lock (rev2)

2023-02-01 Thread Patchwork
== Series Details == Series: vfio: fix deadlock between group lock and kvm lock (rev2) URL : https://patchwork.freedesktop.org/series/113535/ State : success == Summary == CI Bug Log - changes from CI_DRM_12680 -> Patchwork_113535v2

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Consolidate TLB invalidation flow

2023-02-01 Thread Patchwork
== Series Details == Series: drm/i915: Consolidate TLB invalidation flow URL : https://patchwork.freedesktop.org/series/113563/ State : success == Summary == CI Bug Log - changes from CI_DRM_12680_full -> Patchwork_113563v1_full Summary

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/quirks: Add inverted backlight quirk for HP 14-r206nv

2023-02-01 Thread Patchwork
== Series Details == Series: drm/i915/quirks: Add inverted backlight quirk for HP 14-r206nv URL : https://patchwork.freedesktop.org/series/113568/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12680 -> Patchwork_113568v1

[Intel-gfx] [PATCH v2] vfio: fix deadlock between group lock and kvm lock

2023-02-01 Thread Matthew Rosato
After 51cdc8bc120e, we have another deadlock scenario between the kvm->lock and the vfio group_lock with two different codepaths acquiring the locks in different order. Specifically in vfio_open_device, vfio holds the vfio group_lock when issuing device->ops->open_device but some drivers (like

Re: [Intel-gfx] [PATCH] drm/i915/quirks: Add inverted backlight quirk for HP 14-r206nv

2023-02-01 Thread Jani Nikula
On Wed, 01 Feb 2023, Mavroudis Chatzilaridis wrote: > This laptop uses inverted backlight PWM. Thus, without this quirk, > backlight brightness decreases as the brightness value increases and > vice versa. > > Signed-off-by: Mavroudis Chatzilaridis Thanks for the patch, but this really needs a

Re: [Intel-gfx] [PATCH i-g-t 2/2] tests/i915/perf: Exercise barrier race

2023-02-01 Thread Janusz Krzysztofik
Hi Kamil, On Wednesday, 1 February 2023 19:21:57 CET Kamil Konieczny wrote: > Hi Janusz, > > please send patches to igt ML and add other addresses to cc: > I have one nit, see below. > > On 2023-01-31 at 10:17:31 +0100, Janusz Krzysztofik wrote: > > Add a new subtest focused on exercising

[Intel-gfx] [PATCH] drm/i915/quirks: Add inverted backlight quirk for HP 14-r206nv

2023-02-01 Thread Mavroudis Chatzilaridis
This laptop uses inverted backlight PWM. Thus, without this quirk, backlight brightness decreases as the brightness value increases and vice versa. Signed-off-by: Mavroudis Chatzilaridis --- drivers/gpu/drm/i915/display/intel_quirks.c | 2 ++ 1 file changed, 2 insertions(+) diff --git

Re: [Intel-gfx] [RFC] drm/i915: make dev_priv usage explitic in some macros

2023-02-01 Thread Coelho, Luciano
On Wed, 2023-02-01 at 10:07 -0800, Lucas De Marchi wrote: > On Wed, Feb 01, 2023 at 09:20:42AM -0800, Coelho, Luciano wrote: > > On Wed, 2023-02-01 at 19:09 +0200, Jani Nikula wrote: > > > On Wed, 01 Feb 2023, Luca Coelho wrote: > > > > There are a few macros (e.g. DPLL()) that implicitly use

Re: [Intel-gfx] [PATCH] drm/i915/guc: Improve debug message on context reset notification

2023-02-01 Thread John Harrison
On 1/31/2023 13:44, Michal Wajdeczko wrote: Just recently we switched over to new GuC oriented log macros but in the meantime yet another message was added that we missed to update. While around improve that new message by adding engine name and use existing helpers to check for context state.

Re: [Intel-gfx] linux-next: manual merge of the usb tree with the drm-intel-fixes tree

2023-02-01 Thread John Harrison
On 2/1/2023 07:31, Rodrigo Vivi wrote: On Wed, Feb 01, 2023 at 03:11:31PM +1100, Stephen Rothwell wrote: Hi all, On Tue, 31 Jan 2023 10:27:29 -0800 John Harrison wrote: On 1/31/2023 04:44, Andy Shevchenko wrote: On Tue, Jan 31, 2023 at 01:03:05PM +1100, Stephen Rothwell wrote: Today's

Re: [Intel-gfx] [PATCH i-g-t 2/2] tests/i915/perf: Exercise barrier race

2023-02-01 Thread Kamil Konieczny
Hi Janusz, please send patches to igt ML and add other addresses to cc: I have one nit, see below. On 2023-01-31 at 10:17:31 +0100, Janusz Krzysztofik wrote: > Add a new subtest focused on exercising interaction between perf open / > close operations, which replace active barriers with perf

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Consolidate TLB invalidation flow

2023-02-01 Thread Patchwork
== Series Details == Series: drm/i915: Consolidate TLB invalidation flow URL : https://patchwork.freedesktop.org/series/113563/ State : success == Summary == CI Bug Log - changes from CI_DRM_12680 -> Patchwork_113563v1 Summary ---

Re: [Intel-gfx] [RFC] drm/i915: make dev_priv usage explitic in some macros

2023-02-01 Thread Lucas De Marchi
On Wed, Feb 01, 2023 at 09:20:42AM -0800, Coelho, Luciano wrote: On Wed, 2023-02-01 at 19:09 +0200, Jani Nikula wrote: On Wed, 01 Feb 2023, Luca Coelho wrote: > There are a few macros (e.g. DPLL()) that implicitly use dev_priv, by > using other macros that implcitily use dev_priv. > > In an

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Consolidate TLB invalidation flow

2023-02-01 Thread Patchwork
== Series Details == Series: drm/i915: Consolidate TLB invalidation flow URL : https://patchwork.freedesktop.org/series/113563/ State : warning == Summary == Error: dim checkpatch failed c0fc33d4e83f drm/i915: Consolidate TLB invalidation flow -:99: CHECK:PARENTHESIS_ALIGNMENT: Alignment

Re: [Intel-gfx] [PATCH 3/4] drm/i915: Keep sagv status updated on icl+

2023-02-01 Thread Lisovskiy, Stanislav
On Tue, Jan 31, 2023 at 02:21:26AM +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > On icl+ SAGV is controlled by masking of the QGV points. > Reduce the QGV point mask to the same kind of enabled vs. > disable information that we had on previous platforms. > Will be useful in answering the

Re: [Intel-gfx] [PATCH 1/4] drm/i915: Don't do the WM0->WM1 copy w/a if WM1 is already enabled

2023-02-01 Thread Lisovskiy, Stanislav
On Tue, Jan 31, 2023 at 02:21:24AM +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > Due to a workaround we have to make sure the WM1 watermarks block/lines > values are sensible even when WM1 is disabled. To that end we copy those > values from WM0. > > However since we now keep each wm

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: add guard page to ggtt->error_capture

2023-02-01 Thread Patchwork
== Series Details == Series: drm/i915: add guard page to ggtt->error_capture URL : https://patchwork.freedesktop.org/series/113560/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12680 -> Patchwork_113560v1 Summary ---

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Move common mmio base out of private macros

2023-02-01 Thread Ville Syrjälä
On Wed, Feb 01, 2023 at 09:26:29AM -0800, Lucas De Marchi wrote: > On Wed, Feb 01, 2023 at 02:09:54PM +0200, Ville Syrjälä wrote: > >On Wed, Feb 01, 2023 at 11:59:19AM +0200, Jani Nikula wrote: > >> On Tue, 31 Jan 2023, Lucas De Marchi wrote: > >> > Instead of using the common

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Move common mmio base out of private macros

2023-02-01 Thread Lucas De Marchi
On Wed, Feb 01, 2023 at 02:09:54PM +0200, Ville Syrjälä wrote: On Wed, Feb 01, 2023 at 11:59:19AM +0200, Jani Nikula wrote: On Tue, 31 Jan 2023, Lucas De Marchi wrote: > Instead of using the common DISPLAY_MMIO_BASE(dev_priv) in all single > macros, only use them in the macros that are to be

Re: [Intel-gfx] [PATCH v10 04/23] drm/i915/vm_bind: Support partially mapped vma resource

2023-02-01 Thread Andi Shyti
Hi Niranjana, On Tue, Jan 17, 2023 at 11:15:50PM -0800, Niranjana Vishwanathapura wrote: > As persistent vmas can be partialled mapped to an object, > remove restriction which require vma resource sg table to > be just pointer to object's sg table. > > Reviewed-by: Matthew Auld > Signed-off-by:

Re: [Intel-gfx] [PATCH v10 03/23] drm/i915/vm_bind: Expose i915_gem_object_max_page_size()

2023-02-01 Thread Andi Shyti
Hi Niranjana, On Tue, Jan 17, 2023 at 11:15:49PM -0800, Niranjana Vishwanathapura wrote: > Expose i915_gem_object_max_page_size() function non-static > which will be used by the vm_bind feature. > > Reviewed-by: Matthew Auld > Signed-off-by: Niranjana Vishwanathapura > Signed-off-by: Andi

Re: [Intel-gfx] [RFC] drm/i915: make dev_priv usage explitic in some macros

2023-02-01 Thread Coelho, Luciano
On Wed, 2023-02-01 at 19:09 +0200, Jani Nikula wrote: > On Wed, 01 Feb 2023, Luca Coelho wrote: > > There are a few macros (e.g. DPLL()) that implicitly use dev_priv, by > > using other macros that implcitily use dev_priv. > > > > In an effort to align all definitions of struct drm_i915_private

Re: [Intel-gfx] [RFC] drm/i915: make dev_priv usage explitic in some macros

2023-02-01 Thread Lucas De Marchi
On Wed, Feb 01, 2023 at 07:09:12PM +0200, Jani Nikula wrote: On Wed, 01 Feb 2023, Luca Coelho wrote: There are a few macros (e.g. DPLL()) that implicitly use dev_priv, by using other macros that implcitily use dev_priv. In an effort to align all definitions of struct drm_i915_private to be

Re: [Intel-gfx] [PATCH v10 02/23] drm/i915/vm_bind: Add __i915_sw_fence_await_reservation()

2023-02-01 Thread Andi Shyti
Hi Niranjana, On Tue, Jan 17, 2023 at 11:15:48PM -0800, Niranjana Vishwanathapura wrote: > Add function __i915_sw_fence_await_reservation() for > asynchronous wait on a dma-resv object with specified > dma_resv_usage. This is required for async vma unbind > with vm_bind. > > Reviewed-by: Matthew

Re: [Intel-gfx] [RFC] drm/i915: make dev_priv usage explitic in some macros

2023-02-01 Thread Jani Nikula
On Wed, 01 Feb 2023, Luca Coelho wrote: > There are a few macros (e.g. DPLL()) that implicitly use dev_priv, by > using other macros that implcitily use dev_priv. > > In an effort to align all definitions of struct drm_i915_private to be > declared as i915 instead of arbitrarily using either i915

Re: [Intel-gfx] [RFC] drm/i915: make dev_priv usage explitic in some macros

2023-02-01 Thread Coelho, Luciano
On Wed, 2023-02-01 at 17:10 +0100, Andrzej Hajda wrote: > On 01.02.2023 14:53, Luca Coelho wrote: > > There are a few macros (e.g. DPLL()) that implicitly use dev_priv, by > > using other macros that implcitily use dev_priv. > > > > In an effort to align all definitions of struct drm_i915_private

[Intel-gfx] [PATCH v3] drm/i915: Consolidate TLB invalidation flow

2023-02-01 Thread Tvrtko Ursulin
From: Tvrtko Ursulin As the logic for selecting the register and corresponsing values grew, the code become a bit unsightly. Consolidate by storing the required values at engine init time in the engine itself, and by doing so minimise the amount of invariant platform and engine checks during

Re: [Intel-gfx] [RFC] drm/i915: make dev_priv usage explitic in some macros

2023-02-01 Thread Andrzej Hajda
On 01.02.2023 14:53, Luca Coelho wrote: There are a few macros (e.g. DPLL()) that implicitly use dev_priv, by using other macros that implcitily use dev_priv. In an effort to align all definitions of struct drm_i915_private to be declared as i915 instead of arbitrarily using either i915 or

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t 0/2] tests/i915/perf: Add stress / race exercises

2023-02-01 Thread Janusz Krzysztofik
Hi Ashutosh, On Tuesday, 31 January 2023 19:36:50 CET Dixit, Ashutosh wrote: > On Tue, 31 Jan 2023 09:36:30 -0800, Janusz Krzysztofik wrote: > > > > Since Chris' subtest didn't help in triggering the list corruption, I've > > developed a new subtest that can do it. Since it is almost identical

Re: [Intel-gfx] linux-next: manual merge of the usb tree with the drm-intel-fixes tree

2023-02-01 Thread Rodrigo Vivi
On Wed, Feb 01, 2023 at 03:11:31PM +1100, Stephen Rothwell wrote: > Hi all, > > On Tue, 31 Jan 2023 10:27:29 -0800 John Harrison > wrote: > > > > On 1/31/2023 04:44, Andy Shevchenko wrote: > > > On Tue, Jan 31, 2023 at 01:03:05PM +1100, Stephen Rothwell wrote: > > >> > > >> Today's linux-next

[Intel-gfx] [PATCH] drm/i915: add guard page to ggtt->error_capture

2023-02-01 Thread Andrzej Hajda
Some platforms (ADL, RPL, DG2) during CPU read of mapped GTT pages tries to prefetch data beyond page table boundary. If the next PTE in GTT points to invalid address it can cause DMAR errors. Adding guard PTE pointing to scratch page solves the issue in case of ggtt->error_capture.

Re: [Intel-gfx] [PATCH v2 02/17] drm/display/dp_mst: Handle old/new payload states in drm_dp_remove_payload()

2023-02-01 Thread Imre Deak
On Tue, Jan 31, 2023 at 06:13:10PM -0500, Lyude Paul wrote: > On Tue, 2023-01-31 at 17:05 +0200, Imre Deak wrote: > > Atm, drm_dp_remove_payload() uses the same payload state to both get the > > vc_start_slot required for the payload removal DPCD message and to > > deduct time_slots from

Re: [Intel-gfx] [PATCH] vfio: fix deadlock between group lock and kvm lock

2023-02-01 Thread Matthew Rosato
On 2/1/23 7:43 AM, Liu, Yi L wrote: >> From: Jason Gunthorpe >> Sent: Wednesday, February 1, 2023 4:26 AM >> >> On Tue, Jan 31, 2023 at 03:06:35PM -0500, Matthew Rosato wrote: >>> @@ -799,13 +794,14 @@ >> EXPORT_SYMBOL_GPL(vfio_file_enforced_coherent); >>> void vfio_file_set_kvm(struct file

Re: [Intel-gfx] [PATCH v2 16/17] drm/i915/dp_mst: Add workaround for a DELL P2715Q payload allocation problem

2023-02-01 Thread Imre Deak
On Tue, Jan 31, 2023 at 05:47:11PM -0500, Lyude Paul wrote: > On Tue, 2023-01-31 at 17:05 +0200, Imre Deak wrote: > > The DELL P2715Q monitor's MST hub has a payload allocation problem, > > LMAO hello yet again, Dell P2715Q. It's been a while. > > > where the VCPI used to reserve the last two

Re: [Intel-gfx] [PATCH] vfio: fix deadlock between group lock and kvm lock

2023-02-01 Thread Matthew Rosato
On 2/1/23 7:42 AM, Liu, Yi L wrote: >> From: Matthew Rosato ... >> +if (device->kvm) { >> +vfio_kvm_put_kvm(device); >> +device->put_kvm = NULL; > > Can "device->put_kvm = NULL;" be part of vfio_kvm_put_kvm()? Sure

Re: [Intel-gfx] [PATCH] vfio: fix deadlock between group lock and kvm lock

2023-02-01 Thread Matthew Rosato
On 2/1/23 1:13 AM, Tian, Kevin wrote: >> From: Matthew Rosato >> Sent: Wednesday, February 1, 2023 4:07 AM >> >> -device->kvm = kvm; >> +/* >> + * Get the KVM pointer currently associated with the group, if there >> + * is one, and obtain a reference now that will be held until

Re: [Intel-gfx] [PATCH v2 17/17] drm/i915/dp_mst: Verify the HW state of MST encoders

2023-02-01 Thread Imre Deak
On Wed, Feb 01, 2023 at 11:41:47AM +0200, Jani Nikula wrote: > On Tue, 31 Jan 2023, Imre Deak wrote: > > Read out and verify an MST encoder's HW state after any of the > > MST connectors driven by the encoder is modeset. > > > > Cc: Ville Syrjälä > > Signed-off-by: Imre Deak > > --- > >

Re: [Intel-gfx] [RFC] drm/i915: make dev_priv usage explitic in some macros

2023-02-01 Thread Luca Coelho
On Wed, 2023-02-01 at 15:53 +0200, Luca Coelho wrote: > There are a few macros (e.g. DPLL()) that implicitly use dev_priv, by > using other macros that implcitily use dev_priv. > > In an effort to align all definitions of struct drm_i915_private to be > declared as i915 instead of arbitrarily

[Intel-gfx] ✗ Fi.CI.BUILD: failure for drm/i915: make dev_priv usage explitic in some macros

2023-02-01 Thread Patchwork
== Series Details == Series: drm/i915: make dev_priv usage explitic in some macros URL : https://patchwork.freedesktop.org/series/113555/ State : failure == Summary == Error: patch https://patchwork.freedesktop.org/api/1.0/series/113555/revisions/1/mbox/ not applied Applying: drm/i915: make

[Intel-gfx] [RFC] drm/i915: make dev_priv usage explitic in some macros

2023-02-01 Thread Luca Coelho
There are a few macros (e.g. DPLL()) that implicitly use dev_priv, by using other macros that implcitily use dev_priv. In an effort to align all definitions of struct drm_i915_private to be declared as i915 instead of arbitrarily using either i915 or dev_priv, we need to make these macros

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Implement UHBR bandwidth check

2023-02-01 Thread Ville Syrjälä
On Wed, Feb 01, 2023 at 01:00:59PM +0200, Lisovskiy, Stanislav wrote: > On Tue, Jan 31, 2023 at 05:41:45PM +0200, Ville Syrjälä wrote: > > On Tue, Jan 31, 2023 at 05:20:44PM +0200, Lisovskiy, Stanislav wrote: > > > On Tue, Jan 31, 2023 at 05:00:30PM +0200, Ville Syrjälä wrote: > > > > On Mon, Jan

Re: [Intel-gfx] [PATCH] vfio: fix deadlock between group lock and kvm lock

2023-02-01 Thread Liu, Yi L
> From: Jason Gunthorpe > Sent: Wednesday, February 1, 2023 4:26 AM > > On Tue, Jan 31, 2023 at 03:06:35PM -0500, Matthew Rosato wrote: > > @@ -799,13 +794,14 @@ > EXPORT_SYMBOL_GPL(vfio_file_enforced_coherent); > > void vfio_file_set_kvm(struct file *file, struct kvm *kvm) > > { > >

Re: [Intel-gfx] [PATCH] vfio: fix deadlock between group lock and kvm lock

2023-02-01 Thread Liu, Yi L
> From: Matthew Rosato > Sent: Wednesday, February 1, 2023 4:07 AM > > After 51cdc8bc120e, we have another deadlock scenario between the > kvm->lock and the vfio group_lock with two different codepaths acquiring > the locks in different order. Specifically in vfio_open_device, vfio > holds the

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Move common mmio base out of private macros

2023-02-01 Thread Ville Syrjälä
On Wed, Feb 01, 2023 at 11:59:19AM +0200, Jani Nikula wrote: > On Tue, 31 Jan 2023, Lucas De Marchi wrote: > > Instead of using the common DISPLAY_MMIO_BASE(dev_priv) in all single > > macros, only use them in the macros that are to be used outside the > > header. This reduces the use of the

[Intel-gfx] [PULL] drm-intel-gt-next

2023-02-01 Thread Tvrtko Ursulin
Hi Dave, Daniel, Here goes the final pull request for 6.3. Aside a few fixes, the reset is split between refactoring of the workarounds code and correcting some workaround placement to correctly align for new platforms, and converting the GuC code to use dedicated logging macros, as was done for

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Implement UHBR bandwidth check

2023-02-01 Thread Lisovskiy, Stanislav
On Tue, Jan 31, 2023 at 05:41:45PM +0200, Ville Syrjälä wrote: > On Tue, Jan 31, 2023 at 05:20:44PM +0200, Lisovskiy, Stanislav wrote: > > On Tue, Jan 31, 2023 at 05:00:30PM +0200, Ville Syrjälä wrote: > > > On Mon, Jan 16, 2023 at 01:19:37PM +0200, Stanislav Lisovskiy wrote: > > > > According to

[Intel-gfx] ✓ Fi.CI.IGT: success for Enable HDCP2.x via GSC CS (rev10)

2023-02-01 Thread Patchwork
== Series Details == Series: Enable HDCP2.x via GSC CS (rev10) URL : https://patchwork.freedesktop.org/series/111876/ State : success == Summary == CI Bug Log - changes from CI_DRM_12676_full -> Patchwork_111876v10_full Summary ---

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Move common mmio base out of private macros

2023-02-01 Thread Jani Nikula
On Tue, 31 Jan 2023, Lucas De Marchi wrote: > Instead of using the common DISPLAY_MMIO_BASE(dev_priv) in all single > macros, only use them in the macros that are to be used outside the > header. This reduces the use of the implicit dev_priv, making it easier > to remove it later. > >

[Intel-gfx] ✓ Fi.CI.BAT: success for Enable HDCP2.x via GSC CS (rev10)

2023-02-01 Thread Patchwork
== Series Details == Series: Enable HDCP2.x via GSC CS (rev10) URL : https://patchwork.freedesktop.org/series/111876/ State : success == Summary == CI Bug Log - changes from CI_DRM_12676 -> Patchwork_111876v10 Summary ---

Re: [Intel-gfx] [PATCH v2 17/17] drm/i915/dp_mst: Verify the HW state of MST encoders

2023-02-01 Thread Jani Nikula
On Tue, 31 Jan 2023, Imre Deak wrote: > Read out and verify an MST encoder's HW state after any of the > MST connectors driven by the encoder is modeset. > > Cc: Ville Syrjälä > Signed-off-by: Imre Deak > --- > drivers/gpu/drm/i915/display/intel_ddi.c | 91 +-- >

[Intel-gfx] [PATCH v10 4/6] drm/i915/hdcp: Refactor HDCP API structures

2023-02-01 Thread Suraj Kandpal
It requires to move intel specific HDCP API structures to i915_hdcp_interface.h from driver/misc/mei/hdcp/mei_hdcp.h so that any content protection fw interfaces can use these structures. Cc: Tomas Winkler Cc: Rodrigo Vivi Cc: Uma Shankar Cc: Ankit Nautiyal Signed-off-by: Anshuman Gupta

[Intel-gfx] [PATCH v10 6/6] drm/i915/mtl: Add HDCP GSC interface

2023-02-01 Thread Suraj Kandpal
MTL uses GSC command streamer i.e gsc cs to send HDCP/PXP commands to GSC f/w. It requires to keep hdcp display driver agnostic to content protection f/w (ME/GSC fw) in the form of i915_hdcp_fw_ops generic ops. Adding HDCP GSC CS interface by leveraging the i915_hdcp_fw_ops generic ops instead of

[Intel-gfx] [PATCH v10 5/6] drm/i915/mtl: Add function to send command to GSC CS

2023-02-01 Thread Suraj Kandpal
Add function that takes care of sending command to gsc cs. We start of with allocation of memory for our command intel_hdcp_gsc_message that contains gsc cs memory header as directed in specs followed by the actual payload hdcp message that we want to send. Spec states that we need to poll pending

[Intel-gfx] [PATCH v10 1/6] drm/i915/gsc: Create GSC request submission mechanism

2023-02-01 Thread Suraj Kandpal
HDCP and PXP will require a common function to allow it to submit commands to the gsc cs. Also adding the gsc mtl header that needs to be added on to the existing payloads of HDCP and PXP. --v4 -Seprate gsc load and heci cmd submission into different functions in different files for better

[Intel-gfx] [PATCH v10 3/6] i915/hdcp: HDCP2.x Refactoring to agnostic hdcp

2023-02-01 Thread Suraj Kandpal
As now we have more then one type of content protection secrity firmware. Let change the i915_hdcp_interface.h header naming convention to suit generic f/w type. %s/MEI_/HDCP_ %s/mei_dev/hdcp_dev As interface to CP FW can be either a non i915 component or i915 intergral component, change

[Intel-gfx] [PATCH v10 2/6] drm/i915/hdcp: Keep hdcp agonstic naming convention

2023-02-01 Thread Suraj Kandpal
From: Anshuman Gupta Change the include/drm/i915_mei_hdcp_interface.h to include/drm/i915_hdcp_interface.h --v6 -make each patch build individually [Jani] --v8 -change ME FW to ME/GSC FW [Ankit] -fix formatting issue [Ankit] Cc: Tomas Winkler Cc: Rodrigo Vivi Cc: Uma Shankar Cc: Ankit

[Intel-gfx] [PATCH v10 0/6] Enable HDCP2.x via GSC CS

2023-02-01 Thread Suraj Kandpal
These patches enable HDCP2.x on machines MTL and above. >From MTL onwards CSME is spilt into GSC and CSC and now we use GSC CS instead of MEI to talk to firmware to start HDCP authentication --v2 -Fixing some checkpatch changes which I forgot before sending out the series --v3 -Drop cp and fw to

Re: [Intel-gfx] [PATCH v9 5/6] drm/i915/mtl: Add function to send command to GSC CS

2023-02-01 Thread Kandpal, Suraj
> From: Teres Alexis, Alan Previn > Sent: Wednesday, February 1, 2023 2:18 PM > To: Kandpal, Suraj ; intel- > g...@lists.freedesktop.org > Cc: Shankar, Uma ; Nautiyal, Ankit K > ; Ceraolo Spurio, Daniele > ; Gupta, Anshuman > > Subject: Re: [PATCH v9 5/6] drm/i915/mtl: Add function to send

Re: [Intel-gfx] [PATCH v9 5/6] drm/i915/mtl: Add function to send command to GSC CS

2023-02-01 Thread Teres Alexis, Alan Previn
Conditional Rb with below fix in intel_hdcp_gsc_free_message: Reviewed-by: Alan Previn On Tue, 2023-01-31 at 12:03 +0530, Kandpal, Suraj wrote: > Add function that takes care of sending command to gsc cs. We start > of with allocation of memory for our command intel_hdcp_gsc_message that >