> -Original Message-
> From: Liu, Yi L
> Subject: [PATCH v5 00/10] Enhance vfio PCI hot reset for vfio cdev device
>
> VFIO_DEVICE_PCI_HOT_RESET requires user to pass an array of group fds to
> prove that it owns all devices affected by resetting the calling device. While
> for cdev
> -Original Message-
> From: Liu, Yi L
> Subject: [PATCH v11 00/23] Add vfio_device cdev for iommufd support
>
> Existing VFIO provides group-centric user APIs for userspace. Userspace
> opens the /dev/vfio/$group_id first before getting device fd and hence
> getting access to device.
On Wed, May 17, 2023 at 08:18:01PM -0700, Matt Roper wrote:
Rather than embeddeding the display's device info within the main device
info structure, just provide a pointer to the display-specific
structure. This is in preparation for moving the display device info
definitions into the display
On Wed, May 17, 2023 at 08:18:00PM -0700, Matt Roper wrote:
Moving display-specific substruture definitions will help keep display
more self-contained and make it easier to re-use in other drivers (i.e.,
Xe) in the future.
Signed-off-by: Matt Roper
---
== Series Details ==
Series: i915: Move display identification/probing under display/
URL : https://patchwork.freedesktop.org/series/117931/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_13162 -> Patchwork_117931v1
Summary
== Series Details ==
Series: i915: Move display identification/probing under display/
URL : https://patchwork.freedesktop.org/series/117931/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
== Series Details ==
Series: i915: Move display identification/probing under display/
URL : https://patchwork.freedesktop.org/series/117931/
State : warning
== Summary ==
Error: dim checkpatch failed
9c8f732467ae drm/i915/display: Move display device info to header under display/
Traceback
Rather than selecting the display IP and feature flags at the same time
the general PCI probing happens, move this step into the display code
itself so that it can be more easily re-used outside of i915 (i.e., by
the Xe driver).
Signed-off-by: Matt Roper
---
drivers/gpu/drm/i915/Makefile
Since i915's display code will soon be shared by two DRM drivers (i915
and Xe), it makes sense for the display code itself to be responsible
for recognizing the platform it's running on rather than relying on the
making the top-level DRM driver handle this. This also becomes more
important for
Moving display-specific substruture definitions will help keep display
more self-contained and make it easier to re-use in other drivers (i.e.,
Xe) in the future.
Signed-off-by: Matt Roper
---
.../drm/i915/display/intel_display_device.h | 60 +++
Move the runtime info specific to display into display-specific
structures as has already been done with the constant display info.
Signed-off-by: Matt Roper
---
drivers/gpu/drm/i915/display/intel_crtc.c | 2 +-
drivers/gpu/drm/i915/display/intel_cursor.c | 2 +-
For platforms with GMD_ID support (i.e., everything MTL and beyond),
identification of the display IP present should be based on the contents
of the GMD_ID register rather than a PCI devid match.
Note that since GMD_ID readout requires access to the PCI BAR, a slight
change to the driver init
Rather than embeddeding the display's device info within the main device
info structure, just provide a pointer to the display-specific
structure. This is in preparation for moving the display device info
definitions into the display code itself and for eventually allowing the
pointer to be
On Wed, 17 May 2023 13:55:41 -0700, Umesh Nerlige Ramappa wrote:
>
> From: Tvrtko Ursulin
>
> Reserve some bits in the counter config namespace which will carry the
> tile id and prepare the code to handle this.
>
> No per tile counters have been added yet.
>
> v2:
> - Fix checkpatch issues
> -
== Series Details ==
Series: series starting with [v5,1/2] drm/i915/mtl: Add MTL performance tuning
changes
URL : https://patchwork.freedesktop.org/series/117923/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_13161 -> Patchwork_117923v1
== Series Details ==
Series: series starting with [v5,1/2] drm/i915/mtl: Add MTL performance tuning
changes
URL : https://patchwork.freedesktop.org/series/117923/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked
MTL reuses the tuning parameters for DG2. Extend the dg2
performance tuning parameters to MTL.
v2: Add DRAW_WATERMARK tuning parameter.
v3: Limit DRAW_WATERMARK tuning to non A0 step.
v4: Reorder platform checks.
Restrict Blend fill caching optimization to Render GT.
v5: Move mtl tuning
Like DG2, MTL a-step hardware is subject to Wa_16014892111 which
requires that any changes made to the DRAW_WATERMARK register be
done via an INDIRECT_CTX batch buffer rather than through a regular
context workaround.
The bspec gives the same non-default recommended tuning value
for
== Series Details ==
Series: drm/i915: move DSC RC tables to drm_dsc_helper.c (rev8)
URL : https://patchwork.freedesktop.org/series/114473/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_13158_full -> Patchwork_114473v8_full
== Series Details ==
Series: Enhance vfio PCI hot reset for vfio cdev device (rev3)
URL : https://patchwork.freedesktop.org/series/116991/
State : failure
== Summary ==
Error: patch
https://patchwork.freedesktop.org/api/1.0/series/116991/revisions/3/mbox/ not
applied
Applying: vfio-iommufd:
On Sat, 13 May 2023 06:21:35 -0700
Yi Liu wrote:
> This makes VFIO_DEVICE_GET_PCI_HOT_RESET_INFO ioctl to use the iommufd_ctx
s/makes/allows/?
s/to//
> of the cdev device to check the ownership of the other affected devices.
>
> This returns devid for each of the affected devices. If it is
== Series Details ==
Series: Add MTL PMU support for multi-gt
URL : https://patchwork.freedesktop.org/series/117913/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
== Series Details ==
Series: Add MTL PMU support for multi-gt
URL : https://patchwork.freedesktop.org/series/117913/
State : warning
== Summary ==
Error: dim checkpatch failed
210d9b13e02b drm/i915/pmu: Change bitmask of enabled events to u32
1c19f595d54a drm/i915/pmu: Support PMU for all
== Series Details ==
Series: drm/i915/mtl: do not enable render power-gating on MTL (rev2)
URL : https://patchwork.freedesktop.org/series/117883/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_13160 -> Patchwork_117883v2
On 5/17/2023 1:59 PM, John Harrison wrote:
On 4/28/2023 11:58, Daniele Ceraolo Spurio wrote:
Now that each FW has its own reserved area, we can keep them always
pinned and skip the pin/unpin dance on reset. This will make things
easier for the 2-step HuC authentication, which requires the FW
On 5/2/2023 08:27, Daniele Ceraolo Spurio wrote:
The new binaries that support the 2-step authentication have contain the
have contain?
legacy-style binary, which we can use for loading the HuC via DMA. To
find out where this is located in the image, we need to parse the meu
'meu manifest'
On 4/28/2023 11:58, Daniele Ceraolo Spurio wrote:
Now that each FW has its own reserved area, we can keep them always
pinned and skip the pin/unpin dance on reset. This will make things
easier for the 2-step HuC authentication, which requires the FW to be
pinned in GGTT after the xfer is
From: Tvrtko Ursulin
We do not want to have timers per tile and waste CPU cycles and energy via
multiple wake-up sources, for a relatively un-important task of PMU
sampling, so keeping a single timer works well. But we also do not want
the first GT which goes idle to turn off the timer.
Add
From: Tvrtko Ursulin
Trivial prep work for full multi-tile enablement later.
Signed-off-by: Tvrtko Ursulin
Signed-off-by: Vinay Belgaumkar
Reviewed-by: Umesh Nerlige Ramappa
Signed-off-by: Umesh Nerlige Ramappa
---
drivers/gpu/drm/i915/gt/intel_gt_pm.c | 4 ++--
From: Tvrtko Ursulin
Reserve some bits in the counter config namespace which will carry the
tile id and prepare the code to handle this.
No per tile counters have been added yet.
v2:
- Fix checkpatch issues
- Use 4 bits for gt id in non-engine counters. Drop FIXME.
- Set MAX GTs to 4. Drop
From: Tvrtko Ursulin
As we have more and more engines do not waste time sampling the ones no-
one is monitoring.
Signed-off-by: Tvrtko Ursulin
Reviewed-by: Umesh Nerlige Ramappa
Signed-off-by: Umesh Nerlige Ramappa
---
drivers/gpu/drm/i915/i915_pmu.c | 3 +++
1 file changed, 3 insertions(+)
With MTL, frequency and rc6 counters are specific to a gt. Export these
counters via gt-specific events to the user space.
v2: Remove aggregation support from kernel
v3: Review comments (Ashutosh, Tvrtko)
v4:
- Include R-b for 6/6
- Add Test-with
- Fix versioning info in cover letter
v5:
-
From: Tvrtko Ursulin
Having it as u64 was a confusing (but harmless) mistake.
Also add some asserts to make sure the internal field does not overflow
in the future.
v2: Fix WARN_ON firing for INTERRUPT event (Umesh)
Signed-off-by: Tvrtko Ursulin
Signed-off-by: Umesh Nerlige Ramappa
From: Tvrtko Ursulin
Given how the metrics are already exported, we also need to run sampling
over engines from all GTs.
Problem of GT frequencies is left for later.
Signed-off-by: Tvrtko Ursulin
Reviewed-by: Umesh Nerlige Ramappa
Signed-off-by: Umesh Nerlige Ramappa
---
From: Tvrtko Ursulin
Start exporting frequency and RC6 counters from all tiles.
Existing counters keep their names and config values and new one use the
namespace added in the previous patch, with the "-gtN" added to their
names.
Interrupts counter is an odd one off. Because it is the global
== Series Details ==
Series: series starting with [CI,DO_NOT_MERGE,1/3] drm/i915/mtl: do not enable
render power-gating on MTL
URL : https://patchwork.freedesktop.org/series/117912/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_13160 -> Patchwork_117912v1
== Series Details ==
Series: series starting with [CI,DO_NOT_MERGE,1/3] drm/i915/mtl: do not enable
render power-gating on MTL
URL : https://patchwork.freedesktop.org/series/117912/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit
== Series Details ==
Series: series starting with [CI,DO_NOT_MERGE,1/3] drm/i915/mtl: do not enable
render power-gating on MTL
URL : https://patchwork.freedesktop.org/series/117912/
State : warning
== Summary ==
Error: dim checkpatch failed
51fd4c7e1efa drm/i915/mtl: do not enable render
On Wed, 17 May 2023 13:15:14 -0700, Umesh Nerlige Ramappa wrote:
>
> Leaving it as is. @Ashutosh, okay to use your R-b without any changes to
> this patch?
Yes.
Reviewed-by: Ashutosh Dixit
On Wed, May 17, 2023 at 09:25:03AM -0700, Dixit, Ashutosh wrote:
On Wed, 17 May 2023 01:26:15 -0700, Tvrtko Ursulin wrote:
On 17/05/2023 07:55, Umesh Nerlige Ramappa wrote:
> On Tue, May 16, 2023 at 05:25:50PM -0700, Dixit, Ashutosh wrote:
>> On Tue, 16 May 2023 16:35:28 -0700, Umesh Nerlige
the right lineage number for 1401266.
> > Besides, 1401266 is for DG2 anyway.
> >
> > Let's keep the way Adrzej put with the BSPec reference besides the
> > lineage.
>
> Makes sense, didn't realize 1401266 is much older.
>
> Thanks!
>
> >
> > >
> > > > +
Multiple CI tests fails with forcewake ack timeouts
if render power gating is enabled.
BSpec 52698 clearly states it should be 0 for MTL.
Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/4983
Signed-off-by: Andrzej Hajda
---
drivers/gpu/drm/i915/gt/intel_rc6.c | 5 +++--
1 file
The test examines if running spinners do not interfere with forcewake.
Signed-off-by: Andrzej Hajda
---
drivers/gpu/drm/i915/selftests/intel_uncore.c | 85 +++
1 file changed, 85 insertions(+)
diff --git a/drivers/gpu/drm/i915/selftests/intel_uncore.c
Multiple CI tests fails with forcewake timeouts. Disabling power
gating for render and media solves the issue.
References: https://gitlab.freedesktop.org/drm/intel/-/issues/4983
Signed-off-by: Andrzej Hajda
---
drivers/gpu/drm/i915/gt/intel_rc6.c | 3 +++
1 file changed, 3 insertions(+)
diff
On Sat, 13 May 2023 06:21:34 -0700
Yi Liu wrote:
> to check if any device within the given iommu_group has been bound with
Nit, I find these commit logs where the subject line is intended to
flow into the commit log to form a complete sentence difficult to read.
I expect complete thoughts
== Series Details ==
Series: drm/i915/mtl: do not enable render power-gating on MTL
URL : https://patchwork.freedesktop.org/series/117883/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_13160 -> Patchwork_117883v1
Summary
Quoting Radhakrishna Sripada (2023-05-16 21:40:45-03:00)
>MTL reuses the tuning parameters for DG2. Extend the dg2
>performance tuning parameters to MTL.
>
>v2: Add DRAW_WATERMARK tuning parameter.
>v3: Limit DRAW_WATERMARK tuning to non A0 step.
>v4: Reorder platform checks.
>Restrict Blend
On Sat, 13 May 2023 06:21:33 -0700
Yi Liu wrote:
> There are drivers that need to search vfio_device within a given dev_set.
> e.g. vfio-pci. So add a helper.
>
> Signed-off-by: Yi Liu
> ---
> drivers/vfio/pci/vfio_pci_core.c | 8 +++-
> drivers/vfio/vfio_main.c | 15
> On 16/05/2023 19:11, fei.y...@intel.com wrote:
>> From: Fei Yang
>>
>> To comply with the design that buffer objects shall have immutable
>> cache setting through out their life cycle, {set, get}_caching ioctl's
>> are no longer supported from MTL onward. With that change caching
>> policy can
Hi Dave & Daniel,
Here goes drm-intel-fixes for v6.4-rc3.
Just one missing null check addition for HDCP code.
Regards, Joonas
***
drm-intel-fixes-2023-05-17:
Add missing null check for HDCP code.
The following changes since commit f1fcbaa18b28dec10281551dfe6ed3a3ed80e3d6:
Linux 6.4-rc2
On Wed, May 17, 2023 at 12:40:32PM -0600, Alex Williamson wrote:
> On Wed, 17 May 2023 15:22:27 -0300
> Jason Gunthorpe wrote:
>
> > On Wed, May 17, 2023 at 12:15:17PM -0600, Alex Williamson wrote:
> >
> > > > +int vfio_iommufd_physical_devid(struct vfio_device *vdev)
> > > > +{
> > > > +
On Wed, 17 May 2023 15:22:27 -0300
Jason Gunthorpe wrote:
> On Wed, May 17, 2023 at 12:15:17PM -0600, Alex Williamson wrote:
>
> > > +int vfio_iommufd_physical_devid(struct vfio_device *vdev)
> > > +{
> > > + if (vdev->iommufd_device)
> > > + return
== Series Details ==
Series: drm/i915/gem: Use large rings for compute contexts (rev2)
URL : https://patchwork.freedesktop.org/series/117814/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_13160 -> Patchwork_117814v2
On Wed, May 17, 2023 at 12:15:17PM -0600, Alex Williamson wrote:
> > +int vfio_iommufd_physical_devid(struct vfio_device *vdev)
> > +{
> > + if (vdev->iommufd_device)
> > + return iommufd_device_to_id(vdev->iommufd_device);
> > + if (vdev->noiommu_access)
> > + return
On Wed, May 17, 2023 at 11:26:09AM -0600, Alex Williamson wrote:
> It's not clear to me why we need a separate iommufd_access for
> noiommu.
The point was to allocate an ID for the device so we can use that ID
with the other interfaces in all cases.
Otherwise it is a too weird special case that
Hi Bagas,
On Fri, Feb 03, 2023 at 05:02:15PM +0700, Bagas Sanjaya wrote:
> Stephen Rothwell reported htmldocs warning:
>
> include/media/v4l2-subdev.h:1088: warning: Function parameter or member
> 'privacy_led' not described in 'v4l2_subdev'
>
> Describe privacy_led field to fix the warning.
>
On Sat, 13 May 2023 06:21:32 -0700
Yi Liu wrote:
> This is needed by the vfio-pci driver to report affected devices in the
> hot reset for a given device.
>
> Signed-off-by: Yi Liu
> ---
> drivers/iommu/iommufd/device.c | 24
> drivers/vfio/iommufd.c | 20
== Series Details ==
Series: drm/i915/gt: Add workaround 14016712196 (rev2)
URL : https://patchwork.freedesktop.org/series/117661/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_13160 -> Patchwork_117661v2
Summary
---
On Sat, 13 May 2023 06:21:27 -0700
Yi Liu wrote:
> This binds noiommu device to iommufd and creates iommufd_access for this
> bond. This is useful for adding an iommufd-based device ownership check
> for VFIO_DEVICE_PCI_HOT_RESET since this model requires all the other
> affected devices bound
Ping! This appears to be unmerged. Let me know if there's anything wrong
with the PR.
Am 11.05.23 um 09:28 schrieb Maxime Ripard:
Hi,
Here's the first drm-misc-next PR for 6.5
Please note that I'll be off for about a month starting next week, and
Thomas has kindly agreed to fill in.
Thanks!
On Wed, 17 May 2023 01:26:15 -0700, Tvrtko Ursulin wrote:
>
>
> On 17/05/2023 07:55, Umesh Nerlige Ramappa wrote:
> > On Tue, May 16, 2023 at 05:25:50PM -0700, Dixit, Ashutosh wrote:
> >> On Tue, 16 May 2023 16:35:28 -0700, Umesh Nerlige Ramappa wrote:
> >>>
> >>
> >> Hi Umesh/Tvrtko,
> >>
> >>
== Series Details ==
Series: series starting with [CI,DO_NOT_MERGE,1/2] drm/i915/mtl: do not enable
render power-gating on MTL (rev2)
URL : https://patchwork.freedesktop.org/series/117839/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_13154_full -> Patchwork_117839v2_full
pg_enable =
GEN9_MEDIA_PG_ENABLE |
---
base-commit: 01d3dd92d1b71421f6ee85e1bea829e0a917d979
change-id: 20230517-mtl_disable_render_pg-b9f9f1567f9e
^ unwanted artifacts ? Otherwise this looks good to me.
Reviewed-by: Nirmoy Das
with the artifacts removed:
Reviewed
red.
+ if (IS_METEORLAKE(gt->i915) ||
+ IS_DG2_GRAPHICS_STEP(gt->i915, G10, STEP_A0, STEP_C0) ||
IS_DG2_GRAPHICS_STEP(gt->i915, G11, STEP_A0, STEP_B0))
pg_enable =
GEN9_MEDIA_PG_ENABLE |
---
base-commit: 01d3dd92d1b71421f6ee85e1bea829e0a917d979
change-
; + if (IS_METEORLAKE(gt->i915) ||
> > + IS_DG2_GRAPHICS_STEP(gt->i915, G10, STEP_A0, STEP_C0)
> > ||
> > IS_DG2_GRAPHICS_STEP(gt->i915, G11, STEP_A0, STEP_B0))
> > pg_enable =
> > GEN9_MEDIA_PG_ENABL
== Series Details ==
Series: drm/i915/color: register & get config abstractions
URL : https://patchwork.freedesktop.org/series/117875/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_13159 -> Patchwork_117875v1
Summary
(gt->i915, G11, STEP_A0, STEP_B0))
pg_enable =
GEN9_MEDIA_PG_ENABLE |
---
base-commit: 01d3dd92d1b71421f6ee85e1bea829e0a917d979
change-id: 20230517-mtl_disable_render_pg-b9f9f1567f9e
^ unwanted artifacts ? Otherwise this looks good to me.
Reviewed-by
== Series Details ==
Series: drm/i915/color: register & get config abstractions
URL : https://patchwork.freedesktop.org/series/117875/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
== Series Details ==
Series: drm/i915/color: register & get config abstractions
URL : https://patchwork.freedesktop.org/series/117875/
State : warning
== Summary ==
Error: dim checkpatch failed
88392f9a0c53 drm/i915/regs: split out intel_color_regs.h
Traceback (most recent call last):
File
On Tue, May 16, 2023, Yan Zhao wrote:
> hi Sean
>
> Do you think it's necessary to double check that struct page pointers
> are also contiguous?
No, the virtual address space should be irrelevant. The only way it would be
problematic is if something in dma_map_page() expected to be able to
|
---
base-commit: 01d3dd92d1b71421f6ee85e1bea829e0a917d979
change-id: 20230517-mtl_disable_render_pg-b9f9f1567f9e
Best regards,
--
Andrzej Hajda
From: Chris Wilson
Allow compute contexts to submit the maximal amount of work without
blocking userspace.
The original size for user LRC ring's (SZ_16K) was chosen to minimise
memory consumption, without being so small as to frequently stall in the
middle of workloads. With the main consumers
Wa_14016712196 implementation for mtl
Bspec: 72197
V2:
- Fix kernel test robot warnings
Reported-by: kernel test robot
Closes:
https://lore.kernel.org/oe-kbuild-all/202305121525.3ewdgoby-...@intel.com/
Signed-off-by: Tejas Upadhyay
---
drivers/gpu/drm/i915/gt/gen8_engine_cs.c | 41
On Thu, 27 Apr 2023, Vinod Govindapillai wrote:
> From: Mika Kahola
>
> Display14 introduces a new way to instruct the PUnit with
> power and bandwidth requirements of DE. Add the functionality
> to program the registers and handle waits using interrupts.
> The current wait time for timeouts is
On Tue, 16 May 2023, "Kandpal, Suraj" wrote:
>>
>> The "fastset mismatch" debug logging has been slightly confusing, leading
>> people to believe some error happened. Change it to the more informative
>> "fastset requirement not met", and add a final message about this leading to
>> full modeset.
Abstract the register access better. The DSPCNTR read could be moved to
either i9xx_plane.c or intel_color.c. The latter feels better, even if
the register is written in the former.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_color.c | 25
Abstract the platform specific register access better.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_color.c | 26 +---
drivers/gpu/drm/i915/display/intel_display.c | 12 +
2 files changed, 23 insertions(+), 15 deletions(-)
diff --git
Abstract the platform specific register access better.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_color.c | 17 +
drivers/gpu/drm/i915/display/intel_display.c | 6 --
2 files changed, 17 insertions(+), 6 deletions(-)
diff --git
Abstract the platform specific register access better. The separate
hsw_read_gamma_mode() will make more sense with the following changes.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_color.c | 20
drivers/gpu/drm/i915/display/intel_display.c | 3 ---
Add color .get_config hook to read config other than LUTs and CSCs, and
start off with CHV CGM pipe mode to abstract the platform specific
register access better.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_color.c | 16
Declutter i915_regs.h.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/hsw_ips.c| 1 +
drivers/gpu/drm/i915/display/intel_color.c| 1 +
.../gpu/drm/i915/display/intel_color_regs.h | 272 ++
drivers/gpu/drm/i915/display/intel_display.c | 1 +
Move the color related registers to intel_color_regs.h and move the
color config reads to intel_color_get_config() to declutter i915_reg.h
and intel_display.c, respectively.
BR,
Jani.
Jani Nikula (6):
drm/i915/regs: split out intel_color_regs.h
drm/i915/color: move CHV CGM pipe mode read to
== Series Details ==
Series: series starting with [v4,1/2] drm/i915/mtl: Add MTL performance tuning
changes
URL : https://patchwork.freedesktop.org/series/117847/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_13154_full -> Patchwork_117847v1_full
On 17/05/2023 13:42, Kandpal, Suraj wrote:
The array of rc_parameters contains a mixture of parameters from DSC 1.1
and DSC 1.2 standards. Split these tow configuration arrays in preparation to
adding more configuration data.
Signed-off-by: Dmitry Baryshkov
LGTM.
Reviewed-by: Suraj Kandpal
== Series Details ==
Series: drm/i915: move DSC RC tables to drm_dsc_helper.c (rev8)
URL : https://patchwork.freedesktop.org/series/114473/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_13158 -> Patchwork_114473v8
Summary
== Series Details ==
Series: drm/i915: move DSC RC tables to drm_dsc_helper.c (rev8)
URL : https://patchwork.freedesktop.org/series/114473/
State : warning
== Summary ==
Error: dim checkpatch failed
eb2b41f3d443 drm/i915/dsc: change DSC param tables to follow the DSC model
8da238066157
== Series Details ==
Series: Add MTL PMU support for multi-gt
URL : https://patchwork.freedesktop.org/series/117843/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_13154_full -> Patchwork_117843v1_full
Summary
---
On Fri, 2023-05-12 at 13:16 +0100, Tvrtko Ursulin wrote:
> On 12/05/2023 10:54, Coelho, Luciano wrote:
> > On Fri, 2023-05-12 at 10:32 +0100, Tvrtko Ursulin wrote:
> > > On 12/05/2023 10:10, Coelho, Luciano wrote:
> > > > On Fri, 2023-05-12 at 10:04 +0100, Tvrtko Ursulin wrote:
> > > > > On
== Series Details ==
Series: drm/i915: Allow user to set cache at BO creation (rev9)
URL : https://patchwork.freedesktop.org/series/116870/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_13154_full -> Patchwork_116870v9_full
>
> The array of rc_parameters contains a mixture of parameters from DSC 1.1
> and DSC 1.2 standards. Split these tow configuration arrays in preparation to
> adding more configuration data.
>
> Signed-off-by: Dmitry Baryshkov
LGTM.
Reviewed-by: Suraj Kandpal
> ---
>
Include RC parameters for YCbCr 4:2:2 and 4:2:0 configurations.
Reviewed-by: Suraj Kandpal
Signed-off-by: Dmitry Baryshkov
---
drivers/gpu/drm/display/drm_dsc_helper.c | 450 +++
include/drm/display/drm_dsc_helper.h | 2 +
2 files changed, 452 insertions(+)
diff
Move DSC RC tables to DRM DSC helper. No additional code changes
and/or cleanups are a part of this commit, it will be cleaned up in the
followup commits.
Reviewed-by: Jani Nikula
Signed-off-by: Dmitry Baryshkov
---
drivers/gpu/drm/display/drm_dsc_helper.c | 372 ++
The array of rc_parameters contains a mixture of parameters from DSC 1.1
and DSC 1.2 standards. Split these tow configuration arrays in
preparation to adding more configuration data.
Signed-off-by: Dmitry Baryshkov
---
drivers/gpu/drm/display/drm_dsc_helper.c | 139 ++
Next commits are going to add support for additional RC parameter lookup
tables. These tables are going to use different bpp/bpc combinations,
thus it makes little sense to keep the 2d array for RC parameters.
Switch to using the flat array.
Reviewed-by: Jani Nikula
Signed-off-by: Dmitry
The rc_buf_thresh values are common to all DSC implementations. Move
them to the common helper together with the code to propagate them to
the drm_dsc_config.
Reviewed-by: Jani Nikula
Reviewed-by: Marijn Suijten
Signed-off-by: Dmitry Baryshkov
---
drivers/gpu/drm/display/drm_dsc_helper.c |
After cross-checking DSC models (20150914, 20161212, 20210623) change
values in rc_parameters tables to follow config files present inside
the DSC model. Handle two places, where i915 tables diverged from the
model, by patching the rc values in the code.
Note: I left one case uncorrected,
Stop using an interim structure rc_parameters for storing calculated
params and then setting drm_dsc_config using that structure. Instead put
calculated params into the struct drm_dsc_config directly.
Reviewed-by: Jani Nikula
Signed-off-by: Dmitry Baryshkov
---
DSC model contains pre-SCR RC parameters for other bpp/bpc combinations,
include them here for completeness. The values were generated from the
'pre_scr_cfg_files_for_reference' files found in DSC models 20210623.
The same fileset is a part of DSC model 20161212.
Reviewed-by: Jessica Zhang
Other platforms (msm) will benefit from sharing the DSC config setup
functions. This series moves parts of static DSC config data from the
i915 driver to the common helpers to be used by other drivers.
Note: the RC parameters were cross-checked against config files found in
DSC model 2021062,
On 17/05/2023 06:10, Kandpal, Suraj wrote:
The array of rc_parameters contains a mixture of parameters from DSC 1.1
and DSC 1.2 standards. Split these tow configuration arrays in preparation to
adding more configuration data.
Signed-off-by: Dmitry Baryshkov
---
1 - 100 of 112 matches
Mail list logo
