[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Allow user to set cache at BO creation (rev10)

2023-05-18 Thread Patchwork
== Series Details == Series: drm/i915: Allow user to set cache at BO creation (rev10) URL : https://patchwork.freedesktop.org/series/116870/ State : success == Summary == CI Bug Log - changes from CI_DRM_13165 -> Patchwork_116870v10 Summary

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: Allow user to set cache at BO creation (rev10)

2023-05-18 Thread Patchwork
== Series Details == Series: drm/i915: Allow user to set cache at BO creation (rev10) URL : https://patchwork.freedesktop.org/series/116870/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] [PATCH v10 2/2] drm/i915: Allow user to set cache at BO creation

2023-05-18 Thread fei . yang
From: Fei Yang To comply with the design that buffer objects shall have immutable cache setting through out their life cycle, {set, get}_caching ioctl's are no longer supported from MTL onward. With that change caching policy can only be set at object creation time. The current code applies a def

[Intel-gfx] [PATCH v10 0/2] drm/i915: Allow user to set cache at BO creation

2023-05-18 Thread fei . yang
From: Fei Yang This series introduce a new extension for GEM_CREATE, 1. end support for set caching ioctl [PATCH 1/2] 2. add set_pat extension for gem_create [PATCH 2/2] v2: drop one patch that was merged separately commit 341ad0e8e254 ("drm/i915/mtl: Add PTE encode function") v3: rebased on

[Intel-gfx] [PATCH v10 1/2] drm/i915/mtl: end support for set caching ioctl

2023-05-18 Thread fei . yang
From: Fei Yang The design is to keep Buffer Object's caching policy immutable through out its life cycle. This patch ends the support for set caching ioctl from MTL onward. While doing that we also set BO's to be 1-way coherent at creation time because GPU is no longer automatically snooping CPU

Re: [Intel-gfx] [PATCH v5 1/7] drm/i915/pmu: Change bitmask of enabled events to u32

2023-05-18 Thread Dixit, Ashutosh
On Thu, 18 May 2023 02:07:55 -0700, Tvrtko Ursulin wrote: > > On 17/05/2023 17:25, Dixit, Ashutosh wrote: > > On Wed, 17 May 2023 01:26:15 -0700, Tvrtko Ursulin wrote: > >> > >> > >> On 17/05/2023 07:55, Umesh Nerlige Ramappa wrote: > >>> On Tue, May 16, 2023 at 05:25:50PM -0700, Dixit, Ashutosh wr

Re: [Intel-gfx] [PATCH v3 03/28] drm/i915/gvt: Verify hugepages are contiguous in physical address space

2023-05-18 Thread Yan Zhao
On Thu, May 18, 2023 at 11:04:46AM -0700, Sean Christopherson wrote: > On Thu, May 18, 2023, Yan Zhao wrote: > > On Wed, May 17, 2023 at 07:50:26AM -0700, Sean Christopherson wrote: > > > On Tue, May 16, 2023, Yan Zhao wrote: > > > > hi Sean > > > > > > > > Do you think it's necessary to double ch

Re: [Intel-gfx] [RESEND PATCH] drm/i915: constify pointers to hwmon_channel_info

2023-05-18 Thread Andi Shyti
Hi Krzysztof, On Thu, May 11, 2023 at 07:54:46PM +0200, Krzysztof Kozlowski wrote: > Statically allocated array of pointers to hwmon_channel_info can be made > const for safety. > > Acked-by: Jani Nikula > Signed-off-by: Krzysztof Kozlowski Reviewed-by: Andi Shyti Andi

Re: [Intel-gfx] [PATCH] drm/i915/mtl: Fix expected reg value for Thunderbolt PLL disabling

2023-05-18 Thread Sripada, Radhakrishna
Thank you for the patch and review. Merged the patch. - Radhakrishna(RK) Sripada > -Original Message- > From: Intel-gfx On Behalf Of Imre > Deak > Sent: Friday, May 12, 2023 7:12 AM > To: Kahola, Mika > Cc: intel-gfx@lists.freedesktop.org > Subject: Re: [Intel-gfx] [PATCH] drm/i915/mtl:

Re: [Intel-gfx] [PATCH v4 1/2] drm/i915/mtl: Add MTL performance tuning changes

2023-05-18 Thread Sripada, Radhakrishna
Thank you for the reviews. Pushed the patches. - Radhakrishna Sripada > -Original Message- > From: Sousa, Gustavo > Sent: Wednesday, May 17, 2023 12:27 PM > To: Sripada, Radhakrishna ; intel- > g...@lists.freedesktop.org > Cc: Justen, Jordan L ; Sripada, Radhakrishna > ; Kalvala, Haridha

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for C20 Computed HDMI TMDS pixel clocks (rev3)

2023-05-18 Thread Taylor, Clinton A
On Thu, 2023-05-18 at 19:31 +, Patchwork wrote: > Patch Details > Series: C20 Computed HDMI TMDS pixel clocks (rev3) > URL: https://patchwork.freedesktop.org/series/117399/ > State:failure > Details: > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117399v3/index.html >

[Intel-gfx] ✗ Fi.CI.IGT: failure for HDCP Cleanup

2023-05-18 Thread Patchwork
== Series Details == Series: HDCP Cleanup URL : https://patchwork.freedesktop.org/series/117938/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13162_full -> Patchwork_117938v1_full Summary --- **FAILURE** Serious

Re: [Intel-gfx] [PATCH v5 09/10] vfio/pci: Extend VFIO_DEVICE_GET_PCI_HOT_RESET_INFO for vfio device cdev

2023-05-18 Thread Alex Williamson
On Thu, 18 May 2023 13:21:57 + "Liu, Yi L" wrote: > > From: Alex Williamson > > Sent: Thursday, May 18, 2023 6:02 AM > > > > On Sat, 13 May 2023 06:21:35 -0700 > > Yi Liu wrote: > > > > > This makes VFIO_DEVICE_GET_PCI_HOT_RESET_INFO ioctl to use the > > > iommufd_ctx > > > > s/make

Re: [Intel-gfx] [PATCH v5 09/10] vfio/pci: Extend VFIO_DEVICE_GET_PCI_HOT_RESET_INFO for vfio device cdev

2023-05-18 Thread Alex Williamson
On Thu, 18 May 2023 13:31:47 + "Liu, Yi L" wrote: > > From: Liu, Yi L > > Sent: Thursday, May 18, 2023 9:22 PM > > > > > From: Alex Williamson > > > Sent: Thursday, May 18, 2023 6:02 AM > > > > > > On Sat, 13 May 2023 06:21:35 -0700 > > > Yi Liu wrote: > > > > > > > static int vfio_h

Re: [Intel-gfx] [PATCH v5 06/10] vfio-iommufd: Add helper to retrieve iommufd_ctx and devid for vfio_device

2023-05-18 Thread Alex Williamson
On Thu, 18 May 2023 13:25:59 + "Liu, Yi L" wrote: > > From: Alex Williamson > > Sent: Thursday, May 18, 2023 2:15 AM > > > > On Sat, 13 May 2023 06:21:32 -0700 > > Yi Liu wrote: > > > > > This is needed by the vfio-pci driver to report affected devices in the > > > hot reset for a given

Re: [Intel-gfx] [PATCH v5 07/10] vfio: Add helper to search vfio_device in a dev_set

2023-05-18 Thread Alex Williamson
On Thu, 18 May 2023 12:31:07 + "Liu, Yi L" wrote: > > From: Alex Williamson > > Sent: Thursday, May 18, 2023 3:13 AM > > > > On Sat, 13 May 2023 06:21:33 -0700 > > Yi Liu wrote: > > > > > There are drivers that need to search vfio_device within a given dev_set. > > > e.g. vfio-pci. So a

Re: [Intel-gfx] [PATCH v5 01/10] vfio-iommufd: Create iommufd_access for noiommu devices

2023-05-18 Thread Alex Williamson
On Thu, 18 May 2023 12:23:29 + "Liu, Yi L" wrote: > > From: Jason Gunthorpe > > Sent: Thursday, May 18, 2023 2:21 AM > > > > On Wed, May 17, 2023 at 11:26:09AM -0600, Alex Williamson wrote: > > > > > It's not clear to me why we need a separate iommufd_access for > > > noiommu. > > > >

[Intel-gfx] ✗ Fi.CI.BAT: failure for C20 Computed HDMI TMDS pixel clocks (rev3)

2023-05-18 Thread Patchwork
== Series Details == Series: C20 Computed HDMI TMDS pixel clocks (rev3) URL : https://patchwork.freedesktop.org/series/117399/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13164 -> Patchwork_117399v3 Summary --- **F

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for C20 Computed HDMI TMDS pixel clocks (rev3)

2023-05-18 Thread Patchwork
== Series Details == Series: C20 Computed HDMI TMDS pixel clocks (rev3) URL : https://patchwork.freedesktop.org/series/117399/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for C20 Computed HDMI TMDS pixel clocks (rev3)

2023-05-18 Thread Patchwork
== Series Details == Series: C20 Computed HDMI TMDS pixel clocks (rev3) URL : https://patchwork.freedesktop.org/series/117399/ State : warning == Summary == Error: dim checkpatch failed eb47be209dd5 drm/i915: Add 16bit register/mask operators -:29: CHECK:MACRO_ARG_REUSE: Macro argument reuse '

[Intel-gfx] ✗ Fi.CI.BUILD: failure for series starting with [CI,DO_NOT_MERGE,1/3] drm/i915/mtl: do not enable render power-gating on MTL (rev2)

2023-05-18 Thread Patchwork
== Series Details == Series: series starting with [CI,DO_NOT_MERGE,1/3] drm/i915/mtl: do not enable render power-gating on MTL (rev2) URL : https://patchwork.freedesktop.org/series/117912/ State : failure == Summary == Error: patch https://patchwork.freedesktop.org/api/1.0/series/117912/revi

Re: [Intel-gfx] [PATCH v3 03/28] drm/i915/gvt: Verify hugepages are contiguous in physical address space

2023-05-18 Thread Sean Christopherson
On Thu, May 18, 2023, Yan Zhao wrote: > On Wed, May 17, 2023 at 07:50:26AM -0700, Sean Christopherson wrote: > > On Tue, May 16, 2023, Yan Zhao wrote: > > > hi Sean > > > > > > Do you think it's necessary to double check that struct page pointers > > > are also contiguous? > > > > No, the virtual

Re: [Intel-gfx] [PATCH v2] drm/i915/mtl: do not enable render power-gating on MTL

2023-05-18 Thread Andrzej Hajda
On 18.05.2023 18:11, Rodrigo Vivi wrote: On Thu, May 18, 2023 at 05:33:55PM +0200, Andrzej Hajda wrote: On 18.05.2023 17:09, Rodrigo Vivi wrote: On Thu, May 18, 2023 at 04:50:52PM +0200, Andrzej Hajda wrote: Multiple CI tests fails with forcewake ack timeouts if render power gating is enab

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/mtl: do not enable render power-gating on MTL (rev3)

2023-05-18 Thread Patchwork
== Series Details == Series: drm/i915/mtl: do not enable render power-gating on MTL (rev3) URL : https://patchwork.freedesktop.org/series/117883/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13163 -> Patchwork_117883v3 Sum

Re: [Intel-gfx] [PATCH v2] drm/i915/mtl: do not enable render power-gating on MTL

2023-05-18 Thread Rodrigo Vivi
On Thu, May 18, 2023 at 05:33:55PM +0200, Andrzej Hajda wrote: > > > On 18.05.2023 17:09, Rodrigo Vivi wrote: > > On Thu, May 18, 2023 at 04:50:52PM +0200, Andrzej Hajda wrote: > > > Multiple CI tests fails with forcewake ack timeouts if render > > > power gating is enabled. > > > BSpec 52698 sta

[Intel-gfx] ✓ Fi.CI.IGT: success for i915: Move display identification/probing under display/

2023-05-18 Thread Patchwork
== Series Details == Series: i915: Move display identification/probing under display/ URL : https://patchwork.freedesktop.org/series/117931/ State : success == Summary == CI Bug Log - changes from CI_DRM_13162_full -> Patchwork_117931v1_full

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: avoid flush_scheduled_work() usage (rev5)

2023-05-18 Thread Patchwork
== Series Details == Series: drm/i915: avoid flush_scheduled_work() usage (rev5) URL : https://patchwork.freedesktop.org/series/114608/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13163 -> Patchwork_114608v5 Summary -

Re: [Intel-gfx] [PATCH v2] drm/i915/mtl: do not enable render power-gating on MTL

2023-05-18 Thread Andrzej Hajda
On 18.05.2023 17:09, Rodrigo Vivi wrote: On Thu, May 18, 2023 at 04:50:52PM +0200, Andrzej Hajda wrote: Multiple CI tests fails with forcewake ack timeouts if render power gating is enabled. BSpec 52698 states it should be 0 for MTL, but apparently this info is outdated. Anyway since the patc

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: avoid flush_scheduled_work() usage (rev5)

2023-05-18 Thread Patchwork
== Series Details == Series: drm/i915: avoid flush_scheduled_work() usage (rev5) URL : https://patchwork.freedesktop.org/series/114608/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

Re: [Intel-gfx] [PATCH v2] drm/i915/mtl: do not enable render power-gating on MTL

2023-05-18 Thread Rodrigo Vivi
On Thu, May 18, 2023 at 04:50:52PM +0200, Andrzej Hajda wrote: > Multiple CI tests fails with forcewake ack timeouts if render > power gating is enabled. > BSpec 52698 states it should be 0 for MTL, but apparently > this info is outdated. Anyway since the patch makes MTL pass basic > tests added FI

Re: [Intel-gfx] [PATCH 1/6] drm/i915/regs: split out intel_color_regs.h

2023-05-18 Thread Gustavo Sousa
Quoting Jani Nikula (2023-05-17 09:38:16-03:00) >Declutter i915_regs.h. > >Signed-off-by: Jani Nikula I don't think I'm experienced enough to tell these are all the defines necessary to be moved, but with respect to the code move, it looks good to me. Thus, Acked-by: Gustavo Sousa >--- > drive

[Intel-gfx] [PATCH v2] drm/i915/mtl: do not enable render power-gating on MTL

2023-05-18 Thread Andrzej Hajda
Multiple CI tests fails with forcewake ack timeouts if render power gating is enabled. BSpec 52698 states it should be 0 for MTL, but apparently this info is outdated. Anyway since the patch makes MTL pass basic tests added FIXME tag informing this is temporary workaround. v2: added FIXME tag Clo

[Intel-gfx] [PATCH v4] drm/i915: avoid flush_scheduled_work() usage

2023-05-18 Thread Tetsuo Handa
Like commit c4f135d643823a86 ("workqueue: Wrap flush_workqueue() using a macro") says, flush_scheduled_work() is dangerous and will be forbidden. i915 became the last flush_scheduled_work() user, but developers cannot find time for auditing which work items does this flush_scheduled_work() need to

Re: [Intel-gfx] [PATCH] drm/i915/mtl: do not enable render power-gating on MTL

2023-05-18 Thread Andi Shyti
Hi Andrzej and Rodrigo, > > On 5/17/2023 5:25 PM, Vivi, Rodrigo wrote: > > > On Wed, 2023-05-17 at 17:12 +0200, Das, Nirmoy wrote: > > > > On 5/17/2023 3:59 PM, Andrzej Hajda wrote: > > > > > Multiple CI tests fails with forcewake ack timeouts > > > > > if render power gating is enabled. > > > > >

Re: [Intel-gfx] [PATCH v5 09/10] vfio/pci: Extend VFIO_DEVICE_GET_PCI_HOT_RESET_INFO for vfio device cdev

2023-05-18 Thread Liu, Yi L
> From: Alex Williamson > Sent: Thursday, May 18, 2023 6:02 AM > > On Sat, 13 May 2023 06:21:35 -0700 > Yi Liu wrote: > > > This makes VFIO_DEVICE_GET_PCI_HOT_RESET_INFO ioctl to use the iommufd_ctx > > s/makes/allows/? > > s/to// > > > of the cdev device to check the ownership of the other

Re: [Intel-gfx] [PATCH v5 09/10] vfio/pci: Extend VFIO_DEVICE_GET_PCI_HOT_RESET_INFO for vfio device cdev

2023-05-18 Thread Liu, Yi L
> From: Liu, Yi L > Sent: Thursday, May 18, 2023 9:22 PM > > > From: Alex Williamson > > Sent: Thursday, May 18, 2023 6:02 AM > > > > On Sat, 13 May 2023 06:21:35 -0700 > > Yi Liu wrote: > > > > static int vfio_hot_reset_devid(struct vfio_device *vdev, > > struc

Re: [Intel-gfx] [v2, 11/12] drm/fbdev-generic: Implement dedicated fbdev I/O helpers

2023-05-18 Thread Thomas Zimmermann
Hi Am 18.05.23 um 14:46 schrieb Sui Jingfeng: Hi, On 2023/5/17 15:07, Thomas Zimmermann wrote: Hi Am 17.05.23 um 03:58 schrieb Sui Jingfeng: Hi, Thomas After apply your patch set, the kernel with arch/loongarch/configs/loongson3_defconfig can not finish compile anymore.  gcc complains:

Re: [Intel-gfx] [PATCH v5 06/10] vfio-iommufd: Add helper to retrieve iommufd_ctx and devid for vfio_device

2023-05-18 Thread Liu, Yi L
> From: Alex Williamson > Sent: Thursday, May 18, 2023 2:15 AM > > On Sat, 13 May 2023 06:21:32 -0700 > Yi Liu wrote: > > > This is needed by the vfio-pci driver to report affected devices in the > > hot reset for a given device. > > > > Signed-off-by: Yi Liu > > --- > > drivers/iommu/iommufd

Re: [Intel-gfx] [PATCH 12/13] drm/i915/dp: Get optimal link config to have best compressed bpp

2023-05-18 Thread Nautiyal, Ankit K
Thanks Stan and Ville for the review comments. I agree can have some documentation about the values used, instead of magic numbers. Also, Ville's approach for dsc_{sink,source}_{min,max}_bpp() seems good, and that can be used as helpers in MST case too. Will add the changes in the next vers

Re: [Intel-gfx] [PATCH 04/13] drm/i915/dp: Update Bigjoiner interface bits for computing compressed bpp

2023-05-18 Thread Nautiyal, Ankit K
On 5/15/2023 7:21 PM, Ville Syrjälä wrote: On Fri, May 12, 2023 at 11:54:08AM +0530, Ankit Nautiyal wrote: In Bigjoiner check for DSC, bigjoiner interface bits for DP for DISPLAY > 13 is 36 (Bspec: 49259). v2: Corrected Display ver to 13. v3: Follow convention for conditional statement. (Vil

Re: [Intel-gfx] [PATCH 05/13] drm/i915/intel_cdclk: Add vdsc with bigjoiner constraints on min_cdlck

2023-05-18 Thread Nautiyal, Ankit K
Thanks Ville and Stan for the comments. I agree with the changes in _plane_min_cdclk and intel_pixel_rate_to_cdclk regarding PPC. But I am a little confused for about the pixel clock. Please find my comments inline: On 5/16/2023 3:41 PM, Lisovskiy, Stanislav wrote: On Mon, May 15, 2023 at

Re: [Intel-gfx] [v2, 11/12] drm/fbdev-generic: Implement dedicated fbdev I/O helpers

2023-05-18 Thread Sui Jingfeng
Hi, On 2023/5/17 15:07, Thomas Zimmermann wrote: Hi Am 17.05.23 um 03:58 schrieb Sui Jingfeng: Hi, Thomas After apply your patch set, the kernel with arch/loongarch/configs/loongson3_defconfig can not finish compile anymore.  gcc complains:    AR  drivers/gpu/built-in.a    AR  d

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [v5,1/2] drm/i915/mtl: Add MTL performance tuning changes

2023-05-18 Thread Patchwork
== Series Details == Series: series starting with [v5,1/2] drm/i915/mtl: Add MTL performance tuning changes URL : https://patchwork.freedesktop.org/series/117923/ State : success == Summary == CI Bug Log - changes from CI_DRM_13161_full -> Patchwork_117923v1_full =

Re: [Intel-gfx] [PATCH v5 08/10] iommufd: Add iommufd_ctx_has_group()

2023-05-18 Thread Liu, Yi L
> From: Alex Williamson > Sent: Thursday, May 18, 2023 3:40 AM > > On Sat, 13 May 2023 06:21:34 -0700 > Yi Liu wrote: > > > to check if any device within the given iommu_group has been bound with > > Nit, I find these commit logs where the subject line is intended to > flow into the commit log

Re: [Intel-gfx] [PATCH v5 07/10] vfio: Add helper to search vfio_device in a dev_set

2023-05-18 Thread Liu, Yi L
> From: Alex Williamson > Sent: Thursday, May 18, 2023 3:13 AM > > On Sat, 13 May 2023 06:21:33 -0700 > Yi Liu wrote: > > > There are drivers that need to search vfio_device within a given dev_set. > > e.g. vfio-pci. So add a helper. > > > > Signed-off-by: Yi Liu > > --- > > drivers/vfio/pci/

Re: [Intel-gfx] [PATCH v5 01/10] vfio-iommufd: Create iommufd_access for noiommu devices

2023-05-18 Thread Liu, Yi L
> From: Jason Gunthorpe > Sent: Thursday, May 18, 2023 2:21 AM > > On Wed, May 17, 2023 at 11:26:09AM -0600, Alex Williamson wrote: > > > It's not clear to me why we need a separate iommufd_access for > > noiommu. > > The point was to allocate an ID for the device so we can use that ID > with t

Re: [Intel-gfx] [PATCH 5/5] drm/i915/display: Handle GMD_ID identification in display code

2023-05-18 Thread Andrzej Hajda
On 18.05.2023 05:18, Matt Roper wrote: For platforms with GMD_ID support (i.e., everything MTL and beyond), identification of the display IP present should be based on the contents of the GMD_ID register rather than a PCI devid match. Note that since GMD_ID readout requires access to the PCI BAR

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/mtl: do not enable render power-gating on MTL (rev2)

2023-05-18 Thread Patchwork
== Series Details == Series: drm/i915/mtl: do not enable render power-gating on MTL (rev2) URL : https://patchwork.freedesktop.org/series/117883/ State : success == Summary == CI Bug Log - changes from CI_DRM_13160_full -> Patchwork_117883v2_full ===

[Intel-gfx] ✗ Fi.CI.BUILD: failure for series starting with [1/6] drm/i915/display: Add support for global histogram

2023-05-18 Thread Patchwork
== Series Details == Series: series starting with [1/6] drm/i915/display: Add support for global histogram URL : https://patchwork.freedesktop.org/series/117948/ State : failure == Summary == Error: patch https://patchwork.freedesktop.org/api/1.0/series/117948/revisions/1/mbox/ not applied

Re: [Intel-gfx] [PATCH 4/5] drm/i915/display: Make display responsible for probing its own IP

2023-05-18 Thread Andrzej Hajda
On 18.05.2023 05:18, Matt Roper wrote: Rather than selecting the display IP and feature flags at the same time the general PCI probing happens, move this step into the display code itself so that it can be more easily re-used outside of i915 (i.e., by the Xe driver). Signed-off-by: Matt Roper -

[Intel-gfx] [PATCH 6/6] drm/i915/display: Enable global hist Selective fetch

2023-05-18 Thread Arun R Murthy
This patch enables support for selective fetch in global histogram. User can provide the selective fetch co-ordinates and only that region will be used in generating the histogram. Signed-off-by: Arun R Murthy --- .../gpu/drm/i915/display/intel_global_hist.c | 65 +++ .../gpu/dr

[Intel-gfx] [PATCH 4/6] drm/i915/display: Add crtc properties for global histogram

2023-05-18 Thread Arun R Murthy
CRTC properties have been added for enable/disable histogram, reading the histogram data and writing the IET data. "GLOBAL_HIST_EN" is the crtc property to enable/disable the global histogram and takes a value 0/1 accordingly. "Global Histogram" is a crtc property to read the binary histogram data.

[Intel-gfx] [PATCH 5/6] drm/i915/display: crtc property for global hist selective fetch

2023-05-18 Thread Arun R Murthy
User can provide the selective fetch co-ordinates for global histogram using crtc blob property. This patch adds the crtc blob property. The selective fetch can be done only on the y co-ordinate and cannot be done on the x co-ordinate. Signed-off-by: Arun R Murthy --- drivers/gpu/drm/i915/displa

[Intel-gfx] [PATCH 3/6] drm/i915/display: global histogram restrictions

2023-05-18 Thread Arun R Murthy
For global histogram the panel should be edp and should have pwm based backlight controller. Flags are updated accordingly. Reviewed-by: Uma Shankar Signed-off-by: Arun R Murthy --- drivers/gpu/drm/i915/display/intel_modeset_setup.c | 12 1 file changed, 12 insertions(+) diff --gi

[Intel-gfx] [PATCH 1/6] drm/i915/display: Add support for global histogram

2023-05-18 Thread Arun R Murthy
API are added to enable/disable histogram. Upon generation of histogram interrupt its notified to the usespace. User can then use this histogram and generate a LUT which is then fed back to the enahancement block. Histogram is an image statistics based on the input pixel stream. LUT is a look up ta

[Intel-gfx] [PATCH 2/6] drm/i915/display: global histogram irq handler

2023-05-18 Thread Arun R Murthy
With the enablement of global histogram, upon generation of histogram, an interrupt is triggered. This patch handles the irq. Reviewed-by: Uma Shankar Signed-off-by: Arun R Murthy --- drivers/gpu/drm/i915/i915_irq.c | 6 +- drivers/gpu/drm/i915/i915_reg.h | 5 +++-- 2 files changed, 8 inser

Re: [Intel-gfx] [PATCH v3 03/28] drm/i915/gvt: Verify hugepages are contiguous in physical address space

2023-05-18 Thread Yan Zhao
On Wed, May 17, 2023 at 07:50:26AM -0700, Sean Christopherson wrote: > On Tue, May 16, 2023, Yan Zhao wrote: > > hi Sean > > > > Do you think it's necessary to double check that struct page pointers > > are also contiguous? > > No, the virtual address space should be irrelevant. The only way it

Re: [Intel-gfx] [PATCH v5 1/7] drm/i915/pmu: Change bitmask of enabled events to u32

2023-05-18 Thread Tvrtko Ursulin
On 17/05/2023 17:25, Dixit, Ashutosh wrote: On Wed, 17 May 2023 01:26:15 -0700, Tvrtko Ursulin wrote: On 17/05/2023 07:55, Umesh Nerlige Ramappa wrote: On Tue, May 16, 2023 at 05:25:50PM -0700, Dixit, Ashutosh wrote: On Tue, 16 May 2023 16:35:28 -0700, Umesh Nerlige Ramappa wrote: Hi U

Re: [Intel-gfx] [PATCH 3/5] drm/i915/display: Move display runtime info to display structure

2023-05-18 Thread Andrzej Hajda
On 18.05.2023 05:18, Matt Roper wrote: Move the runtime info specific to display into display-specific structures as has already been done with the constant display info. Signed-off-by: Matt Roper --- drivers/gpu/drm/i915/display/intel_crtc.c | 2 +- drivers/gpu/drm/i915/display/intel_

Re: [Intel-gfx] [PATCH 5/5] drm/i915/display: Handle GMD_ID identification in display code

2023-05-18 Thread kernel test robot
Hi Matt, kernel test robot noticed the following build warnings: [auto build test WARNING on drm-tip/drm-tip] url: https://github.com/intel-lab-lkp/linux/commits/Matt-Roper/drm-i915-display-Move-display-device-info-to-header-under-display/20230518-112007 base: git

[Intel-gfx] ✓ Fi.CI.BAT: success for HDCP Cleanup

2023-05-18 Thread Patchwork
== Series Details == Series: HDCP Cleanup URL : https://patchwork.freedesktop.org/series/117938/ State : success == Summary == CI Bug Log - changes from CI_DRM_13162 -> Patchwork_117938v1 Summary --- **SUCCESS** No regressions fou

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for HDCP Cleanup

2023-05-18 Thread Patchwork
== Series Details == Series: HDCP Cleanup URL : https://patchwork.freedesktop.org/series/117938/ State : warning == Summary == Error: dim checkpatch failed ca74af1c86b5 drm/i915/hdcp: Rename dev_priv to i915 af1ce8f61009 drm/i915/hdcp: Move away from master naming to arbiter -:229: CHECK:ALLOC

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for HDCP Cleanup

2023-05-18 Thread Patchwork
== Series Details == Series: HDCP Cleanup URL : https://patchwork.freedesktop.org/series/117938/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/gem: Use large rings for compute contexts (rev2)

2023-05-18 Thread Patchwork
== Series Details == Series: drm/i915/gem: Use large rings for compute contexts (rev2) URL : https://patchwork.freedesktop.org/series/117814/ State : success == Summary == CI Bug Log - changes from CI_DRM_13160_full -> Patchwork_117814v2_full ===