[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: simplify switch to if-elseif

2023-05-23 Thread Patchwork
== Series Details == Series: drm/i915: simplify switch to if-elseif URL : https://patchwork.freedesktop.org/series/118216/ State : success == Summary == CI Bug Log - changes from CI_DRM_13177_full -> Patchwork_118216v1_full Summary ---

[Intel-gfx] ✓ Fi.CI.BAT: success for Add rc_range_params for YUV420 (rev2)

2023-05-23 Thread Patchwork
== Series Details == Series: Add rc_range_params for YUV420 (rev2) URL : https://patchwork.freedesktop.org/series/118204/ State : success == Summary == CI Bug Log - changes from CI_DRM_13180 -> Patchwork_118204v2 Summary ---

[Intel-gfx] [PATCH v2 1/2] drm/i915/dsc: Move rc param calculation for native_420

2023-05-23 Thread Suraj Kandpal
Move rc_param calculation for native_420 into calculate_rc_parameter. second_line_bpg_offset and second_line_offset_adj are both rc params and it would be better to have these calculated where all the other rc parameters are calculated. --v2 -Add the reason for commit in commit message [Jani]

Re: [Intel-gfx] [PATCH v11 19/23] vfio: Add VFIO_DEVICE_BIND_IOMMUFD

2023-05-23 Thread Liu, Yi L
> From: Tian, Kevin > Sent: Wednesday, May 24, 2023 10:39 AM > > > From: Liu, Yi L > > Sent: Wednesday, May 24, 2023 10:21 AM > > > > > > > > > > vfio_device_open_file() > > > > { > > > > dev_warn(device->dev, "vfio-noiommu device opened by user " > > > >"(%s:%d)\n",

Re: [Intel-gfx] [PATCH v11 19/23] vfio: Add VFIO_DEVICE_BIND_IOMMUFD

2023-05-23 Thread Tian, Kevin
> From: Liu, Yi L > Sent: Wednesday, May 24, 2023 10:21 AM > > > > > > > vfio_device_open_file() > > > { > > > dev_warn(device->dev, "vfio-noiommu device opened by user " > > > "(%s:%d)\n", current->comm, task_pid_nr(current)); > > > } > > > > There needs to be a taint when

Re: [Intel-gfx] [PATCH v11 19/23] vfio: Add VFIO_DEVICE_BIND_IOMMUFD

2023-05-23 Thread Liu, Yi L
> From: Alex Williamson > Sent: Tuesday, May 23, 2023 11:51 PM > > On Tue, 23 May 2023 01:41:36 + > "Liu, Yi L" wrote: > > > > From: Alex Williamson > > > Sent: Tuesday, May 23, 2023 6:01 AM > > > > > > On Sat, 13 May 2023 06:28:23 -0700 > > > Yi Liu wrote: > > > > > > > This adds ioctl

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Replace all non-returning strlcpy with strscpy

2023-05-23 Thread Patchwork
== Series Details == Series: drm/i915: Replace all non-returning strlcpy with strscpy URL : https://patchwork.freedesktop.org/series/118212/ State : success == Summary == CI Bug Log - changes from CI_DRM_13176_full -> Patchwork_118212v1_full

Re: [Intel-gfx] [PATCH v11 20/23] vfio: Add VFIO_DEVICE_[AT|DE]TACH_IOMMUFD_PT

2023-05-23 Thread Liu, Yi L
> From: Alex Williamson > Sent: Tuesday, May 23, 2023 11:50 PM > > On Tue, 23 May 2023 01:20:17 + > "Liu, Yi L" wrote: > > > > From: Alex Williamson > > > Sent: Tuesday, May 23, 2023 6:16 AM > > > > > > On Sat, 13 May 2023 06:28:24 -0700 > > > Yi Liu wrote: > > > > > > > This adds ioctl

[Intel-gfx] ✓ Fi.CI.IGT: success for Add rc_range_params for YUV420

2023-05-23 Thread Patchwork
== Series Details == Series: Add rc_range_params for YUV420 URL : https://patchwork.freedesktop.org/series/118204/ State : success == Summary == CI Bug Log - changes from CI_DRM_13176_full -> Patchwork_118204v1_full Summary ---

[Intel-gfx] ✓ Fi.CI.BAT: success for i915: Move display identification/probing under display/ (rev4)

2023-05-23 Thread Patchwork
== Series Details == Series: i915: Move display identification/probing under display/ (rev4) URL : https://patchwork.freedesktop.org/series/117931/ State : success == Summary == CI Bug Log - changes from CI_DRM_13180 -> Patchwork_117931v4

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for i915: Move display identification/probing under display/ (rev4)

2023-05-23 Thread Patchwork
== Series Details == Series: i915: Move display identification/probing under display/ (rev4) URL : https://patchwork.freedesktop.org/series/117931/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for i915: Move display identification/probing under display/ (rev4)

2023-05-23 Thread Patchwork
== Series Details == Series: i915: Move display identification/probing under display/ (rev4) URL : https://patchwork.freedesktop.org/series/117931/ State : warning == Summary == Error: dim checkpatch failed 7ffe6d000c98 drm/i915/display: Move display device info to header under display/

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/color: register & get config abstractions (rev2)

2023-05-23 Thread Patchwork
== Series Details == Series: drm/i915/color: register & get config abstractions (rev2) URL : https://patchwork.freedesktop.org/series/117875/ State : success == Summary == CI Bug Log - changes from CI_DRM_13176_full -> Patchwork_117875v2_full

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/perf: Clear out entire reports after reading if not power of 2 size (rev3)

2023-05-23 Thread Patchwork
== Series Details == Series: drm/i915/perf: Clear out entire reports after reading if not power of 2 size (rev3) URL : https://patchwork.freedesktop.org/series/118151/ State : success == Summary == CI Bug Log - changes from CI_DRM_13180 -> Patchwork_118151v3

[Intel-gfx] ✓ Fi.CI.BAT: success for i915: Move display identification/probing under display/ (rev3)

2023-05-23 Thread Patchwork
== Series Details == Series: i915: Move display identification/probing under display/ (rev3) URL : https://patchwork.freedesktop.org/series/117931/ State : success == Summary == CI Bug Log - changes from CI_DRM_13180 -> Patchwork_117931v3

Re: [Intel-gfx] [PATCH] i915/perf: Avoid reading OA reports before they land

2023-05-23 Thread Umesh Nerlige Ramappa
On Tue, May 23, 2023 at 11:20:54AM -0700, Dixit, Ashutosh wrote: On Mon, 22 May 2023 15:08:42 -0700, Umesh Nerlige Ramappa wrote: Hi Umesh, On Mon, May 22, 2023 at 01:20:12PM -0700, Dixit, Ashutosh wrote: > On Fri, 19 May 2023 15:56:42 -0700, Umesh Nerlige Ramappa wrote: >> >> On DG2,

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/pmu: couple of cleanups

2023-05-23 Thread Patchwork
== Series Details == Series: drm/i915/pmu: couple of cleanups URL : https://patchwork.freedesktop.org/series/118225/ State : success == Summary == CI Bug Log - changes from CI_DRM_13177 -> Patchwork_118225v1 Summary --- **SUCCESS**

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: simplify switch to if-elseif

2023-05-23 Thread Patchwork
== Series Details == Series: drm/i915: simplify switch to if-elseif URL : https://patchwork.freedesktop.org/series/118216/ State : success == Summary == CI Bug Log - changes from CI_DRM_13177 -> Patchwork_118216v1 Summary ---

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Replace all non-returning strlcpy with strscpy

2023-05-23 Thread Patchwork
== Series Details == Series: drm/i915: Replace all non-returning strlcpy with strscpy URL : https://patchwork.freedesktop.org/series/118212/ State : success == Summary == CI Bug Log - changes from CI_DRM_13176 -> Patchwork_118212v1 Summary

[Intel-gfx] ✓ Fi.CI.BAT: success for Add rc_range_params for YUV420

2023-05-23 Thread Patchwork
== Series Details == Series: Add rc_range_params for YUV420 URL : https://patchwork.freedesktop.org/series/118204/ State : success == Summary == CI Bug Log - changes from CI_DRM_13176 -> Patchwork_118204v1 Summary --- **SUCCESS**

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/color: register & get config abstractions (rev2)

2023-05-23 Thread Patchwork
== Series Details == Series: drm/i915/color: register & get config abstractions (rev2) URL : https://patchwork.freedesktop.org/series/117875/ State : success == Summary == CI Bug Log - changes from CI_DRM_13176 -> Patchwork_117875v2

[Intel-gfx] [PATCH] drm/i915/perf: Clear out entire reports after reading if not power of 2 size

2023-05-23 Thread Ashutosh Dixit
Clearing out report id and timestamp as means to detect unlanded reports only works if report size is power of 2. That is, only when report size is a sub-multiple of the OA buffer size can we be certain that reports will land at the same place each time in the OA buffer (after rewind). If report

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for i915: Move display identification/probing under display/ (rev3)

2023-05-23 Thread Patchwork
== Series Details == Series: i915: Move display identification/probing under display/ (rev3) URL : https://patchwork.freedesktop.org/series/117931/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for i915: Move display identification/probing under display/ (rev3)

2023-05-23 Thread Patchwork
== Series Details == Series: i915: Move display identification/probing under display/ (rev3) URL : https://patchwork.freedesktop.org/series/117931/ State : warning == Summary == Error: dim checkpatch failed d9e8003baa3d drm/i915/display: Move display device info to header under display/

[Intel-gfx] [linux-next:master] BUILD REGRESSION 9f925874281f7e8855855d6210d6e29d844e4307

2023-05-23 Thread kernel test robot
tree/branch: INFO setup_repo_specs: /db/releases/20230524001904/lkp-src/repo/*/linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master branch HEAD: 9f925874281f7e8855855d6210d6e29d844e4307 Add linux-next specific files for 20230523 Error/Warning reports: https

[Intel-gfx] [CI v3 6/6] drm/i915/display: Move feature test macros to intel_display_device.h

2023-05-23 Thread Matt Roper
It makes sense to keep the display feature test macros centralized within the display code. Signed-off-by: Matt Roper Reviewed-by: Andrzej Hajda --- .../drm/i915/display/intel_display_device.h | 39 drivers/gpu/drm/i915/i915_drv.h | 60 --- 2 files

[Intel-gfx] [CI v3 5/6] drm/i915/display: Handle GMD_ID identification in display code

2023-05-23 Thread Matt Roper
For platforms with GMD_ID support (i.e., everything MTL and beyond), identification of the display IP present should be based on the contents of the GMD_ID register rather than a PCI devid match. Note that since GMD_ID readout requires access to the PCI BAR, a slight change to the driver init

[Intel-gfx] [CI v3 4/6] drm/i915/display: Make display responsible for probing its own IP

2023-05-23 Thread Matt Roper
Rather than selecting the display IP and feature flags at the same time the general PCI probing happens, move this step into the display code itself so that it can be more easily re-used outside of i915 (i.e., by the Xe driver). v2: - Make intel_display_device_probe() always return a non-NULL

[Intel-gfx] [CI v3 3/6] drm/i915/display: Move display runtime info to display structure

2023-05-23 Thread Matt Roper
Move the runtime info specific to display into display-specific structures as has already been done with the constant display info. v2: - Rename __runtime to __runtime_defaults for more clarity on the purpose. (Andrzej) - Move introduction of DISPLAY_INFO() to previous patch. (Andrzej) -

[Intel-gfx] [CI v3 0/6] i915: Move display identification/probing under display/

2023-05-23 Thread Matt Roper
Since i915's display code will soon be shared by two DRM drivers (i915 and Xe), it makes sense for the display code itself to be responsible for recognizing the platform it's running on rather than relying on the making the top-level DRM driver handle this. This also becomes more important for

[Intel-gfx] [CI v3 2/6] drm/i915: Convert INTEL_INFO()->display to a pointer

2023-05-23 Thread Matt Roper
Rather than embeddeding the display's device info within the main device info structure, just provide a pointer to the display-specific structure. This is in preparation for moving the display device info definitions into the display code itself and for eventually allowing the pointer to be

[Intel-gfx] [CI v3 1/6] drm/i915/display: Move display device info to header under display/

2023-05-23 Thread Matt Roper
Moving display-specific substructure definitions will help keep display more self-contained and make it easier to re-use in other drivers (i.e., Xe) in the future. Signed-off-by: Matt Roper Reviewed-by: Andrzej Hajda Reviewed-by: Lucas De Marchi --- .../drm/i915/display/intel_display_device.h

Re: [Intel-gfx] [Freedreno] [PATCH v3 11/12] drm/fbdev-generic: Implement dedicated fbdev I/O helpers

2023-05-23 Thread Thomas Zimmermann
Am 22.05.23 um 20:46 schrieb Thomas Zimmermann: [...] Looking at this patch makes me wonder if we should have implemented fb_dirty for the MSM driver. We have drm_framebuffer_funcs::dirty() implemented (by wrapping the drm_atomic_helper_dirtyfb()). I think so. You'd need something similar

Re: [Intel-gfx] [PATCH] i915/perf: Avoid reading OA reports before they land

2023-05-23 Thread Dixit, Ashutosh
On Mon, 22 May 2023 15:08:42 -0700, Umesh Nerlige Ramappa wrote: > Hi Umesh, > On Mon, May 22, 2023 at 01:20:12PM -0700, Dixit, Ashutosh wrote: > > On Fri, 19 May 2023 15:56:42 -0700, Umesh Nerlige Ramappa wrote: > >> > >> On DG2, capturing OA reports while running heavy render workloads > >>

Re: [Intel-gfx] [PATCH] drm/i915/perf: Clear out entire reports after reading if not power of 2 size

2023-05-23 Thread Umesh Nerlige Ramappa
On Mon, May 22, 2023 at 02:50:51PM -0700, Dixit, Ashutosh wrote: On Mon, 22 May 2023 14:34:18 -0700, Umesh Nerlige Ramappa wrote: On Mon, May 22, 2023 at 01:17:49PM -0700, Ashutosh Dixit wrote: > Clearing out report id and timestamp as means to detect unlanded reports > only works if report

Re: [Intel-gfx] [PATCH] drm/i915: Wait for active retire before i915_active_fini()

2023-05-23 Thread Das, Nirmoy
pushed to drm-intel-next with a minor fix (s/References:/Closes:) On 5/22/2023 2:42 PM, Nirmoy Das wrote: i915_active_fini() finalizes the debug object, which can occur before the active retires and deactivates the debug object. Wait for one final time before calling i915_active_fini();

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/pmu: couple of cleanups

2023-05-23 Thread Patchwork
== Series Details == Series: drm/i915/pmu: couple of cleanups URL : https://patchwork.freedesktop.org/series/118225/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

Re: [Intel-gfx] [PATCH v11 19/23] vfio: Add VFIO_DEVICE_BIND_IOMMUFD

2023-05-23 Thread Alex Williamson
On Tue, 23 May 2023 01:41:36 + "Liu, Yi L" wrote: > > From: Alex Williamson > > Sent: Tuesday, May 23, 2023 6:01 AM > > > > On Sat, 13 May 2023 06:28:23 -0700 > > Yi Liu wrote: > > > > > This adds ioctl for userspace to bind device cdev fd to iommufd. > > > > > >

Re: [Intel-gfx] [PATCH v11 20/23] vfio: Add VFIO_DEVICE_[AT|DE]TACH_IOMMUFD_PT

2023-05-23 Thread Alex Williamson
On Tue, 23 May 2023 01:20:17 + "Liu, Yi L" wrote: > > From: Alex Williamson > > Sent: Tuesday, May 23, 2023 6:16 AM > > > > On Sat, 13 May 2023 06:28:24 -0700 > > Yi Liu wrote: > > > > > This adds ioctl for userspace to attach device cdev fd to and detach > > > from IOAS/hw_pagetable

Re: [Intel-gfx] [PATCH] drm/i915/pmu: Turn off the timer to sample frequencies when GT is parked

2023-05-23 Thread Dixit, Ashutosh
On Fri, 12 May 2023 01:59:08 -0700, Tvrtko Ursulin wrote: > Hi Tvrtko, > On 12/05/2023 02:53, Ashutosh Dixit wrote: > > pmu_needs_timer() keeps the timer running even when GT is parked, > > ostensibly to sample requested/actual frequencies. However > > frequency_sample() has the following: > > >

[Intel-gfx] [PATCH i-g-t] intel_gpu_top: Fix frequency and rc6 counters

2023-05-23 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Need to reset aggregated counters before adding to them otherwise numbers will grow endlessly. Signed-off-by: Tvrtko Ursulin Fixes: 3dadeff69d4a ("intel_gpu_top: Switch pmu_counter to use aggregated values") Cc: Umesh Nerlige Ramappa Cc: Ashutosh Dixit ---

[Intel-gfx] [PATCH 2/2] drm/i915/pmu: Make PMU sample array two-dimensional

2023-05-23 Thread Ashutosh Dixit
No functional changes but we can remove some unsightly index computation and read/write functions if we convert the PMU sample array from a one-dimensional to a two-dimensional array. Suggested-by: Tvrtko Ursulin Signed-off-by: Ashutosh Dixit --- drivers/gpu/drm/i915/i915_pmu.c | 60

[Intel-gfx] [PATCH 1/2] drm/i915/pmu: Turn off the timer to sample frequencies when GT is parked

2023-05-23 Thread Ashutosh Dixit
pmu_needs_timer() keeps the timer running even when GT is parked, ostensibly to sample requested/actual frequencies. However frequency_sample() has the following: /* Report 0/0 (actual/requested) frequency while parked. */ if (!intel_gt_pm_get_if_awake(gt)) return;

[Intel-gfx] [PATCH 0/2] drm/i915/pmu: couple of cleanups

2023-05-23 Thread Ashutosh Dixit
Ashutosh Dixit (2): drm/i915/pmu: Turn off the timer to sample frequencies when GT is parked drm/i915/pmu: Make PMU sample array two-dimensional drivers/gpu/drm/i915/i915_pmu.c | 72 +++-- drivers/gpu/drm/i915/i915_pmu.h | 2 +- 2 files changed, 24

Re: [Intel-gfx] [PATCH 2/6] drm/i915/uc/gsc: fixes and updates for GSC memory allocation

2023-05-23 Thread Ceraolo Spurio, Daniele
On 5/22/2023 5:13 PM, Teres Alexis, Alan Previn wrote: On Fri, 2023-05-05 at 09:04 -0700, Ceraolo Spurio, Daniele wrote: A few fixes/updates are required around the GSC memory allocation and it is easier to do them all at the same time. The changes are as follows: alan:snip @@ -109,38

Re: [Intel-gfx] [PATCH v6 7/7] drm/i915/mtl: Add support for PM DEMAND

2023-05-23 Thread Gustavo Sousa
Quoting Vinod Govindapillai (2023-05-22 20:07:59-03:00) >From: Mika Kahola > >MTL introduces a new way to instruct the PUnit with >power and bandwidth requirements of DE. Add the functionality >to program the registers and handle waits using interrupts. >The current wait time for timeouts is

Re: [Intel-gfx] [Intel-xe] [PATCH v2 5/6] drm/i915/display: Handle GMD_ID identification in display code

2023-05-23 Thread Matt Roper
On Tue, May 23, 2023 at 04:02:46PM +0300, Jani Nikula wrote: > On Mon, 22 May 2023, Matt Roper wrote: > > For platforms with GMD_ID support (i.e., everything MTL and beyond), > > identification of the display IP present should be based on the contents > > of the GMD_ID register rather than a PCI

Re: [Intel-gfx] [PATCH] drm/i915/perf: Clear out entire reports after reading if not power of 2 size

2023-05-23 Thread Lionel Landwerlin
On 22/05/2023 23:17, Ashutosh Dixit wrote: Clearing out report id and timestamp as means to detect unlanded reports only works if report size is power of 2. That is, only when report size is a sub-multiple of the OA buffer size can we be certain that reports will land at the same place each time

Re: [Intel-gfx] [PATCH] drm/i915: simplify switch to if-elseif

2023-05-23 Thread Jani Nikula
On Tue, 23 May 2023, Tom Rix wrote: > clang with W=1 reports > drivers/gpu/drm/i915/display/intel_display.c:6012:3: error: unannotated > fall-through between switch labels [-Werror,-Wimplicit-fallthrough] > case I915_FORMAT_MOD_X_TILED: > ^ > > Only one case and

Re: [Intel-gfx] [PATCH v6 2/7] drm/i915: update the QGV point frequency calculations

2023-05-23 Thread Jani Nikula
On Tue, 23 May 2023, "Govindapillai, Vinod" wrote: > On Tue, 2023-05-23 at 12:01 +0300, Jani Nikula wrote: >> On Tue, 23 May 2023, Vinod Govindapillai >> wrote: >> > From MTL onwwards, pcode locks the QGV point based on peak BW of >> > the intended QGV point passed by the driver. So the peak

Re: [Intel-gfx] [PATCH v2 0/6] i915: Move display identification/probing under display/

2023-05-23 Thread Jani Nikula
On Mon, 22 May 2023, Matt Roper wrote: > Since i915's display code will soon be shared by two DRM drivers (i915 > and Xe), it makes sense for the display code itself to be responsible > for recognizing the platform it's running on rather than relying on the > making the top-level DRM driver

Re: [Intel-gfx] [PATCH v6 4/7] drm/i915: extract intel_bw_check_qgv_points()

2023-05-23 Thread Govindapillai, Vinod
On Tue, 2023-05-23 at 12:05 +0300, Jani Nikula wrote: > On Tue, 23 May 2023, Vinod Govindapillai > wrote: > > Extract intel_bw_check_qgv_points() from intel_bw_atomic_check > > to facilitate future platform variations in handling SAGV > > configurations. > > > > Signed-off-by: Vinod

Re: [Intel-gfx] [Intel-xe] [PATCH v2 5/6] drm/i915/display: Handle GMD_ID identification in display code

2023-05-23 Thread Jani Nikula
On Mon, 22 May 2023, Matt Roper wrote: > For platforms with GMD_ID support (i.e., everything MTL and beyond), > identification of the display IP present should be based on the contents > of the GMD_ID register rather than a PCI devid match. > > Note that since GMD_ID readout requires access to

Re: [Intel-gfx] [Intel-xe] [PATCH v2 4/6] drm/i915/display: Make display responsible for probing its own IP

2023-05-23 Thread Jani Nikula
On Mon, 22 May 2023, Matt Roper wrote: > +static const struct intel_display_device_info xe_lpdp_display = { > + XE_LPD_FEATURES, > + .has_cdclk_crawl = 1, > + .has_cdclk_squash = 1, > + > + .__runtime_defaults.ip.ver = 14, > + .__runtime_defaults.fbc_mask = BIT(INTEL_FBC_A) |

[Intel-gfx] [PATCH] drm/i915: simplify switch to if-elseif

2023-05-23 Thread Tom Rix
clang with W=1 reports drivers/gpu/drm/i915/display/intel_display.c:6012:3: error: unannotated fall-through between switch labels [-Werror,-Wimplicit-fallthrough] case I915_FORMAT_MOD_X_TILED: ^ Only one case and the default does anything in this switch, so it

Re: [Intel-gfx] [Intel-xe] [PATCH v2 2/6] drm/i915: Convert INTEL_INFO()->display to a pointer

2023-05-23 Thread Jani Nikula
On Mon, 22 May 2023, Matt Roper wrote: > diff --git a/drivers/gpu/drm/i915/intel_device_info.c > b/drivers/gpu/drm/i915/intel_device_info.c > index 4e23be2995bf..d0bf626d0360 100644 > --- a/drivers/gpu/drm/i915/intel_device_info.c > +++ b/drivers/gpu/drm/i915/intel_device_info.c > @@ -138,7

Re: [Intel-gfx] [PATCH v2 3/6] drm/i915/display: Move display runtime info to display structure

2023-05-23 Thread Jani Nikula
On Mon, 22 May 2023, Matt Roper wrote: > diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h > index 9612c2ac4b00..7a8a12d12790 100644 > --- a/drivers/gpu/drm/i915/i915_drv.h > +++ b/drivers/gpu/drm/i915/i915_drv.h > @@ -205,6 +205,7 @@ struct drm_i915_private { > >

Re: [Intel-gfx] [PATCH v6 2/7] drm/i915: update the QGV point frequency calculations

2023-05-23 Thread Govindapillai, Vinod
On Tue, 2023-05-23 at 12:01 +0300, Jani Nikula wrote: > On Tue, 23 May 2023, Vinod Govindapillai > wrote: > > From MTL onwwards, pcode locks the QGV point based on peak BW of > > the intended QGV point passed by the driver. So the peak BW > > calculation must match the value expected by the

[Intel-gfx] [PATCH] drm/i915: Replace all non-returning strlcpy with strscpy

2023-05-23 Thread Azeem Shaikh
strlcpy() reads the entire source buffer first. This read may exceed the destination size limit. This is both inefficient and can lead to linear read overflows if a source string is not NUL-terminated [1]. In an effort to remove strlcpy() completely [2], replace strlcpy() here with strscpy(). No

Re: [Intel-gfx] [PATCH v5 8/8] drm/i915/display: provision to suppress drm_warn in intel_get_crtc_new_encoder

2023-05-23 Thread Saarinen, Jani
Hi, > -Original Message- > From: Intel-gfx On Behalf Of Jani > Nikula > Sent: Tuesday, May 23, 2023 2:49 PM > To: Lisovskiy, Stanislav ; Govindapillai, Vinod > > Cc: intel-gfx@lists.freedesktop.org; Syrjala, Ville > Subject: Re: [Intel-gfx] [PATCH v5 8/8] drm/i915/display: provision

Re: [Intel-gfx] [PATCH v5 8/8] drm/i915/display: provision to suppress drm_warn in intel_get_crtc_new_encoder

2023-05-23 Thread Jani Nikula
On Mon, 22 May 2023, "Lisovskiy, Stanislav" wrote: > On Fri, May 12, 2023 at 02:17:50AM +0300, Vinod Govindapillai wrote: >> While configuring pmdemand parameters, there could be >> intel_get_crtc_new_encoder call where encoders could be 0. To avoid >> invoking drm_warn in such cases, use a

Re: [Intel-gfx] [PATCH 1/2] drm/i915/dsc: Move rc param calculation for native_420

2023-05-23 Thread Jani Nikula
On Tue, 23 May 2023, Suraj Kandpal wrote: > Move rc_param calculation for native_420 into calculate_rc_parameter. Why? Please always answer the question "why" in the commit message, even if briefly. > > Cc: Ankit Nautiyal > Signed-off-by: Suraj Kandpal > --- >

Re: [Intel-gfx] [PATCH 3/4] drm/i915: Add helpers for managing rps thresholds

2023-05-23 Thread Andi Shyti
Hi Tvrtko, > > > + /* Force reset. */ > > > + rps->last_freq = -1; > > > + mutex_lock(>power.mutex); > > > + rps->power.mode = -1; > > > + mutex_unlock(>power.mutex); > > > + > > > + intel_rps_set(rps, clamp(rps->cur_freq, > > > + rps->min_freq_softlimit, > > > +

Re: [Intel-gfx] [PATCH i-g-t 2/2] intel_gpu_top: Move client name last

2023-05-23 Thread Kamil Konieczny
On 2023-05-15 at 14:36:30 +0100, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > Move client name to be the right most field which visually aligns better > with top(1) and prepares for inserting memory usage fields somewhere in > the middle. > > Signed-off-by: Tvrtko Ursulin > Cc: Rob Clark

[Intel-gfx] [PATCH i-g-t] tests/i915_pm_rps: Exercise sysfs thresholds

2023-05-23 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Exercise a bunch of up and down rps thresholds to verify hardware is happy with them all. To limit the overall runtime relies on probability and number of runs to approach complete coverage. Signed-off-by: Tvrtko Ursulin Cc: Rodrigo Vivi --- tests/i915/i915_pm_rps.c |

Re: [Intel-gfx] [PATCH i-g-t 1/2] gputop: Move client name last

2023-05-23 Thread Kamil Konieczny
On 2023-05-15 at 14:36:29 +0100, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > Move client name to be the right most field which visually aligns better > with top(1) and prepares for inserting memory usage fields somewhere in > the middle. > > Signed-off-by: Tvrtko Ursulin > Cc: Rob Clark

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/color: register & get config abstractions (rev2)

2023-05-23 Thread Patchwork
== Series Details == Series: drm/i915/color: register & get config abstractions (rev2) URL : https://patchwork.freedesktop.org/series/117875/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/color: register & get config abstractions (rev2)

2023-05-23 Thread Patchwork
== Series Details == Series: drm/i915/color: register & get config abstractions (rev2) URL : https://patchwork.freedesktop.org/series/117875/ State : warning == Summary == Error: dim checkpatch failed 930bc469b869 drm/i915/regs: split out intel_color_regs.h Traceback (most recent call last):

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/perf: Clear out entire reports after reading if not power of 2 size (rev2)

2023-05-23 Thread Patchwork
== Series Details == Series: drm/i915/perf: Clear out entire reports after reading if not power of 2 size (rev2) URL : https://patchwork.freedesktop.org/series/118151/ State : success == Summary == CI Bug Log - changes from CI_DRM_13175_full -> Patchwork_118151v2_full

[Intel-gfx] [PATCH 0/2] Add rc_range_params for YUV420

2023-05-23 Thread Suraj Kandpal
Calculations for YUV420 were missing from calculate_rc_param, add them be in line with DSC 1.2a specs. Signed-off-by: Suraj Kandpal Suraj Kandpal (2): drm/i915/dsc: Move rc param calculation for native_420 drm/i915/dsc: Add rc_range_parameter calculation for YCBCR420

[Intel-gfx] [PATCH 2/2] drm/i915/dsc: Add rc_range_parameter calculation for YCBCR420

2023-05-23 Thread Suraj Kandpal
Some rc_range_parameter calculations were missed for YCBCR420, add them to calculate_rc_param() Cc: Vandita Kulkarni Cc: Ankit Nautiyal Cc: Uma Shankar Signed-off-by: Suraj Kandpal --- drivers/gpu/drm/i915/display/intel_vdsc.c | 139 -- 1 file changed, 102 insertions(+),

[Intel-gfx] [PATCH 1/2] drm/i915/dsc: Move rc param calculation for native_420

2023-05-23 Thread Suraj Kandpal
Move rc_param calculation for native_420 into calculate_rc_parameter. Cc: Ankit Nautiyal Signed-off-by: Suraj Kandpal --- drivers/gpu/drm/i915/display/intel_vdsc.c | 28 +-- 1 file changed, 16 insertions(+), 12 deletions(-) diff --git

Re: [Intel-gfx] [PATCH 3/6] drm/i915/display: global histogram restrictions

2023-05-23 Thread Jani Nikula
On Thu, 18 May 2023, Arun R Murthy wrote: > For global histogram the panel should be edp and should have pwm based > backlight controller. Flags are updated accordingly. > > Reviewed-by: Uma Shankar > Signed-off-by: Arun R Murthy > --- > drivers/gpu/drm/i915/display/intel_modeset_setup.c | 12

Re: [Intel-gfx] [PATCH 2/6] drm/i915/display: global histogram irq handler

2023-05-23 Thread Jani Nikula
On Thu, 18 May 2023, Arun R Murthy wrote: > With the enablement of global histogram, upon generation of histogram, > an interrupt is triggered. This patch handles the irq. > > Reviewed-by: Uma Shankar > Signed-off-by: Arun R Murthy This needs a rebase I think. > --- >

Re: [Intel-gfx] [PATCH 1/6] drm/i915/display: Add support for global histogram

2023-05-23 Thread Jani Nikula
On Thu, 18 May 2023, Arun R Murthy wrote: > API are added to enable/disable histogram. Upon generation of histogram > interrupt its notified to the usespace. User can then use this histogram > and generate a LUT which is then fed back to the enahancement block. > Histogram is an image statistics

Re: [Intel-gfx] [RESEND PATCH] drm/i915: constify pointers to hwmon_channel_info

2023-05-23 Thread Jani Nikula
On Wed, 17 May 2023, Jani Nikula wrote: > On Wed, 17 May 2023, Krzysztof Kozlowski > wrote: >> On 17/05/2023 11:28, Jani Nikula wrote: >>> On Thu, 11 May 2023, Krzysztof Kozlowski >>> wrote: Statically allocated array of pointers to hwmon_channel_info can be made const for safety.

Re: [Intel-gfx] [PATCH i-g-t 0/2] gputop/intel_gpu_top: Move name to be the last field

2023-05-23 Thread Tvrtko Ursulin
On 15/05/2023 15:14, Rob Clark wrote: On Mon, May 15, 2023 at 6:36 AM Tvrtko Ursulin wrote: From: Tvrtko Ursulin Rob, I thought maybe when you add memory stats the same field order like top(1) would feel more natural? That is client name comes last and is left justified. All other stats

Re: [Intel-gfx] [PATCH 3/4] drm/i915: Add helpers for managing rps thresholds

2023-05-23 Thread Tvrtko Ursulin
On 23/05/2023 00:09, Andi Shyti wrote: Hi Tvrtko, On Mon, May 22, 2023 at 12:59:27PM +0100, Tvrtko Ursulin wrote: From: Tvrtko Ursulin In preparation for exposing via sysfs add helpers for managing rps thresholds. v2: * Force sw and hw re-programming on threshold change. Signed-off-by:

Re: [Intel-gfx] [PATCH v6 4/7] drm/i915: extract intel_bw_check_qgv_points()

2023-05-23 Thread Jani Nikula
On Tue, 23 May 2023, Vinod Govindapillai wrote: > Extract intel_bw_check_qgv_points() from intel_bw_atomic_check > to facilitate future platform variations in handling SAGV > configurations. > > Signed-off-by: Vinod Govindapillai > Reviewed-by: Stanislav Lisovskiy > --- >

Re: [Intel-gfx] [PATCH 12/13] drm/i915/dp: Get optimal link config to have best compressed bpp

2023-05-23 Thread Lisovskiy, Stanislav
On Tue, May 16, 2023 at 02:40:27PM +0300, Ville Syrjälä wrote: > On Tue, May 16, 2023 at 01:43:44PM +0300, Lisovskiy, Stanislav wrote: > > On Fri, May 12, 2023 at 11:54:16AM +0530, Ankit Nautiyal wrote: > > > Currently, we take the max lane, rate and pipe bpp, to get the maximum > > > compressed

Re: [Intel-gfx] [PATCH v6 2/7] drm/i915: update the QGV point frequency calculations

2023-05-23 Thread Jani Nikula
On Tue, 23 May 2023, Vinod Govindapillai wrote: > From MTL onwwards, pcode locks the QGV point based on peak BW of > the intended QGV point passed by the driver. So the peak BW > calculation must match the value expected by the pcode. Update > the calculations as per the Bspec. > > v2: use

Re: [Intel-gfx] [PATCH v10 0/2] drm/i915: Allow user to set cache at BO creation

2023-05-23 Thread Andi Shyti
Hi Fei, finally... pushed in drm-intel-gt-next! :) Andi On Thu, May 18, 2023 at 10:11:01PM -0700, fei.y...@intel.com wrote: > From: Fei Yang > > This series introduce a new extension for GEM_CREATE, > 1. end support for set caching ioctl [PATCH 1/2] > 2. add set_pat extension for gem_create

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/perf: Clear out entire reports after reading if not power of 2 size (rev2)

2023-05-23 Thread Patchwork
== Series Details == Series: drm/i915/perf: Clear out entire reports after reading if not power of 2 size (rev2) URL : https://patchwork.freedesktop.org/series/118151/ State : success == Summary == CI Bug Log - changes from CI_DRM_13175 -> Patchwork_118151v2

[Intel-gfx] ✓ Fi.CI.IGT: success for HDCP Cleanup (rev3)

2023-05-23 Thread Patchwork
== Series Details == Series: HDCP Cleanup (rev3) URL : https://patchwork.freedesktop.org/series/117938/ State : success == Summary == CI Bug Log - changes from CI_DRM_13175_full -> Patchwork_117938v3_full Summary --- **SUCCESS**

Re: [Intel-gfx] [PATCH v2 6/6] drm/i915/display: Move feature test macros to intel_display_device.h

2023-05-23 Thread Andrzej Hajda
On 22.05.2023 22:23, Matt Roper wrote: It makes sense to keep the display feature test macros centralized within the display code. Signed-off-by: Matt Roper Reviewed-by: Andrzej Hajda Regards Andrzej --- .../drm/i915/display/intel_display_device.h | 40 +

Re: [Intel-gfx] [PATCH v2 5/6] drm/i915/display: Handle GMD_ID identification in display code

2023-05-23 Thread Andrzej Hajda
On 22.05.2023 22:23, Matt Roper wrote: For platforms with GMD_ID support (i.e., everything MTL and beyond), identification of the display IP present should be based on the contents of the GMD_ID register rather than a PCI devid match. Note that since GMD_ID readout requires access to the PCI

Re: [Intel-gfx] [PATCH v2 4/6] drm/i915/display: Make display responsible for probing its own IP

2023-05-23 Thread Andrzej Hajda
On 22.05.2023 22:23, Matt Roper wrote: Rather than selecting the display IP and feature flags at the same time the general PCI probing happens, move this step into the display code itself so that it can be more easily re-used outside of i915 (i.e., by the Xe driver). v2: - Make

Re: [Intel-gfx] [PATCH v2 3/6] drm/i915/display: Move display runtime info to display structure

2023-05-23 Thread Andrzej Hajda
On 22.05.2023 22:23, Matt Roper wrote: Move the runtime info specific to display into display-specific structures as has already been done with the constant display info. v2: - Rename __runtime to __runtime_defaults for more clarity on the purpose. (Andrzej) - Move introduction of

Re: [Intel-gfx] [PATCH v2 2/6] drm/i915: Convert INTEL_INFO()->display to a pointer

2023-05-23 Thread Andrzej Hajda
On 22.05.2023 22:23, Matt Roper wrote: Rather than embeddeding the display's device info within the main device info structure, just provide a pointer to the display-specific structure. This is in preparation for moving the display device info definitions into the display code itself and for

Re: [Intel-gfx] [PATCH v11 00/23] Add vfio_device cdev for iommufd support

2023-05-23 Thread Duan, Zhenzhong
>-Original Message- >From: Liu, Yi L >Sent: Saturday, May 13, 2023 9:28 PM >To: alex.william...@redhat.com; j...@nvidia.com; Tian, Kevin > >Cc: j...@8bytes.org; robin.mur...@arm.com; coh...@redhat.com; >eric.au...@redhat.com; nicol...@nvidia.com; k...@vger.kernel.org;

[Intel-gfx] ✓ Fi.CI.BAT: success for HDCP Cleanup (rev3)

2023-05-23 Thread Patchwork
== Series Details == Series: HDCP Cleanup (rev3) URL : https://patchwork.freedesktop.org/series/117938/ State : success == Summary == CI Bug Log - changes from CI_DRM_13175 -> Patchwork_117938v3 Summary --- **SUCCESS** No

[Intel-gfx] ✓ Fi.CI.IGT: success for i915: Move display identification/probing under display/ (rev2)

2023-05-23 Thread Patchwork
== Series Details == Series: i915: Move display identification/probing under display/ (rev2) URL : https://patchwork.freedesktop.org/series/117931/ State : success == Summary == CI Bug Log - changes from CI_DRM_13175_full -> Patchwork_117931v2_full

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for HDCP Cleanup (rev3)

2023-05-23 Thread Patchwork
== Series Details == Series: HDCP Cleanup (rev3) URL : https://patchwork.freedesktop.org/series/117938/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for HDCP Cleanup (rev3)

2023-05-23 Thread Patchwork
== Series Details == Series: HDCP Cleanup (rev3) URL : https://patchwork.freedesktop.org/series/117938/ State : warning == Summary == Error: dim checkpatch failed 813ec8b0c18f drm/i915/hdcp: Rename dev_priv to i915 ec41ffc3bde5 drm/i915/hdcp: Move away from master naming to arbiter -:248: