[Intel-gfx] ✓ Fi.CI.BAT: success for HDCP MST aux issue fix (rev6)

2023-08-28 Thread Patchwork
== Series Details == Series: HDCP MST aux issue fix (rev6) URL : https://patchwork.freedesktop.org/series/122267/ State : success == Summary == CI Bug Log - changes from CI_DRM_13570 -> Patchwork_122267v6 Summary --- **SUCCESS**

Re: [Intel-gfx] [PATCH v15 00/23] Add generic memory shrinker to VirtIO-GPU and Panfrost DRM drivers

2023-08-28 Thread Dmitry Osipenko
On 8/28/23 18:24, Helen Mae Koike Fornazier wrote: > On Monday, August 28, 2023 11:37 -03, "Helen Mae Koike Fornazier" > wrote: > >> On Sunday, August 27, 2023 14:54 -03, Dmitry Osipenko >> wrote: >> >>> This series: >>> >>> 1. Adds common drm-shmem memory shrinker >>> 2. Enables shrinker

Re: [Intel-gfx] [PATCH v15 17/23] drm/shmem-helper: Add and use drm_gem_shmem_resv_assert_held() helper

2023-08-28 Thread Dmitry Osipenko
On 8/28/23 13:12, Boris Brezillon wrote: > On Sun, 27 Aug 2023 20:54:43 +0300 > Dmitry Osipenko wrote: > >> In a preparation of adding drm-shmem memory shrinker, move all reservation >> locking lockdep checks to use new drm_gem_shmem_resv_assert_held() that >> will resolve spurious lockdep

Re: [Intel-gfx] [PATCH v15 12/23] drm/shmem-helper: Add and use pages_pin_count

2023-08-28 Thread Dmitry Osipenko
On 8/28/23 14:46, Boris Brezillon wrote: > On Sun, 27 Aug 2023 20:54:38 +0300 > Dmitry Osipenko wrote: > >> Add separate pages_pin_count for tracking of whether drm-shmem pages are >> moveable or not. With the addition of memory shrinker support to drm-shmem, >> the pages_use_count will no

Re: [Intel-gfx] [PATCH v15 10/23] locking/refcount, kref: Add kref_put_ww_mutex()

2023-08-28 Thread Dmitry Osipenko
On 8/28/23 12:26, Boris Brezillon wrote: > On Sun, 27 Aug 2023 20:54:36 +0300 > Dmitry Osipenko wrote: > >> Introduce kref_put_ww_mutex() helper that will handle the wait-wound >> mutex auto-locking on kref_put(). This helper is wanted by DRM drivers >> that extensively use dma-reservation

Re: [Intel-gfx] [Intel-xe] [PATCH 3/4] drm/i915/lnl: support FBC on any plane

2023-08-28 Thread Matt Roper
On Mon, Aug 28, 2023 at 09:20:34AM +0300, Vinod Govindapillai wrote: > In LNL onwards, FBC can be associated to the first three planes. The title of this patch shouldn't say "any plane" when the reality is that only the first three support FBC (the upper two do not). > The FBC will be enabled

Re: [Intel-gfx] [Intel-xe] [PATCH 2/4] drm/i915/lnl: update FBC debugfs to include plane information

2023-08-28 Thread Matt Roper
On Mon, Aug 28, 2023 at 09:20:33AM +0300, Vinod Govindapillai wrote: > In future platforms, FBC can be supported on planes other than "future platforms" on a patch labelled "drm/i915/lnl" makes it sound like this is something that shows up beyond LNL, which isn't really the case. The "future" is

Re: [Intel-gfx] [Intel-xe] [PATCH 1/4] drm/i915/lnl: FBC can be enabled with PSR2

2023-08-28 Thread Matt Roper
On Mon, Aug 28, 2023 at 09:20:32AM +0300, Vinod Govindapillai wrote: > FBC restriction with PSR2 can be removed from LNL onwards > > Signed-off-by: Vinod Govindapillai > --- > drivers/gpu/drm/i915/display/intel_fbc.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git

[Intel-gfx] ✗ Fi.CI.BAT: failure for Test MTL DMC v2.16 (rev2)

2023-08-28 Thread Patchwork
== Series Details == Series: Test MTL DMC v2.16 (rev2) URL : https://patchwork.freedesktop.org/series/122986/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13572 -> Patchwork_122986v2 Summary --- **FAILURE**

Re: [Intel-gfx] [PATCH v5] drm/i915: Avoid circular locking dependency when flush delayed work on gt reset

2023-08-28 Thread John Harrison
On 8/23/2023 10:37, John Harrison wrote: On 8/23/2023 09:00, Daniel Vetter wrote: On Tue, Aug 22, 2023 at 11:53:24AM -0700, John Harrison wrote: On 8/11/2023 11:20, Zhanjun Dong wrote: This attempts to avoid circular locking dependency between flush delayed work and intel_gt_reset. When

Re: [Intel-gfx] [PATCH] drm/i915/cx0: Check and increase msgbus timeout threshold

2023-08-28 Thread Sripada, Radhakrishna
Hi Gustavo, > -Original Message- > From: Sousa, Gustavo > Sent: Monday, August 28, 2023 2:46 PM > To: Sripada, Radhakrishna ; intel- > g...@lists.freedesktop.org > Subject: RE: [Intel-gfx] [PATCH] drm/i915/cx0: Check and increase msgbus > timeout threshold > > Quoting Sripada,

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/cx0: Check and increase msgbus timeout threshold

2023-08-28 Thread Patchwork
== Series Details == Series: drm/i915/cx0: Check and increase msgbus timeout threshold URL : https://patchwork.freedesktop.org/series/122982/ State : success == Summary == CI Bug Log - changes from CI_DRM_13571_full -> Patchwork_122982v1_full

[Intel-gfx] [PATCH 1/1] [CI] Test MTL DMC v2.16

2023-08-28 Thread Gustavo Sousa
NOT TO BE REVIEWED/MERGED. Hardcode DMC path to i915/mtl_dmc_ver2_16.bin for CI purposes. Signed-off-by: Gustavo Sousa --- drivers/gpu/drm/i915/display/intel_dmc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/display/intel_dmc.c

[Intel-gfx] [PATCH 0/1] [CI] Test MTL DMC v2.16

2023-08-28 Thread Gustavo Sousa
The following changes since commit db99828b2466119dc068d564066192347105: copy-firmware: Introduce 'RawFile' keyword (2023-08-28 07:18:15 -0400) are available in the Git repository at: git://anongit.freedesktop.org/drm/drm-firmware CI-dmc-mtl_2.16 for you to fetch changes up to

Re: [Intel-gfx] [PATCH] drm/i915/cx0: Check and increase msgbus timeout threshold

2023-08-28 Thread Gustavo Sousa
Quoting Sripada, Radhakrishna (2023-08-28 17:30:19-03:00) >Hi Gustavo, Hi, RK. Thanks for the feedback! Please, see my replies below. > >> -Original Message- >> From: Intel-gfx On Behalf Of >> Gustavo >> Sousa >> Sent: Monday, August 28, 2023 10:34 AM >> To:

Re: [Intel-gfx] [PATCH] drm/i915/guc: fix compile issue of guc_klvs_abi.h

2023-08-28 Thread Michal Wajdeczko
On 25.08.2023 07:50, Linyu Yuan wrote: > > On 8/25/2023 1:37 PM, Jani Nikula wrote: >> On Fri, 25 Aug 2023, Linyu Yuan wrote: >>> GCC report GUC_KLV_0_KEY and GUC_KLV_0_LEN is not constant when do >>> preprocessing. >> Please paste the actual compiler warning. > > >   CC 

Re: [Intel-gfx] [PATCH v6 1/4] drm: Use XArray instead of IDR for minors

2023-08-28 Thread Michał Winiarski
On Fri, Aug 25, 2023 at 12:59:26PM -0400, James Zhu wrote: > > On 2023-07-24 17:14, Michał Winiarski wrote: > > IDR is deprecated, and since XArray manages its own state with internal > > locking, it simplifies the locking on DRM side. > > Additionally, don't use the IRQ-safe variant, since

Re: [Intel-gfx] [PATCH v2 2/3] drm/i915/guc: Close deregister-context race against CT-loss

2023-08-28 Thread Teres Alexis, Alan Previn
Additional update from the most recent testing. When relying solely on guc_lrc_desc_unpin getting a failure from deregister_context as a means for identifying that we are in the "deregister-context-vs-suspend-late" race, it is too late a location to handle this safely. This is because one of

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/gt: Wait longer for tasks in migrate selftest

2023-08-28 Thread Patchwork
== Series Details == Series: drm/i915/gt: Wait longer for tasks in migrate selftest URL : https://patchwork.freedesktop.org/series/122984/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13571 -> Patchwork_122984v1 Summary

Re: [Intel-gfx] [PATCH] drm/i915/cx0: Check and increase msgbus timeout threshold

2023-08-28 Thread Sripada, Radhakrishna
Hi Gustavo, > -Original Message- > From: Intel-gfx On Behalf Of Gustavo > Sousa > Sent: Monday, August 28, 2023 10:34 AM > To: intel-gfx@lists.freedesktop.org > Subject: [Intel-gfx] [PATCH] drm/i915/cx0: Check and increase msgbus timeout > threshold > > We have experienced timeout

Re: [Intel-gfx] [PATCH v2] drm: Update file owner during use

2023-08-28 Thread Rob Clark
On Wed, Jun 21, 2023 at 2:48 AM Tvrtko Ursulin wrote: > > From: Tvrtko Ursulin > > With the typical model where the display server opens the file descriptor > and then hands it over to the client(*), we were showing stale data in > debugfs. > > Fix it by updating the drm_file->pid on ioctl

[Intel-gfx] [PATCH 0/1] drm/i915/gt: Wait longer for tasks in migrate selftest

2023-08-28 Thread Jonathan Cavitt
The thread_global_copy subtest of the live migrate selftest creates a large number of threads and waits 10ms for them all to start. This is not enough time to wait for the threaded tasks to start, as some may need to wait for additional ring space to be granted. Threads that do so are at risk of

[Intel-gfx] [PATCH 1/1] drm/i915/gt: Wait longer for tasks in migrate selftest

2023-08-28 Thread Jonathan Cavitt
The thread_global_copy subtest of the live migrate selftest creates a large number of threads and waits 10ms for them all to start. This is not enough time to wait for the threaded tasks to start, as some may need to wait for additional ring space to be granted. Threads that do so are at risk of

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/cx0: Check and increase msgbus timeout threshold

2023-08-28 Thread Patchwork
== Series Details == Series: drm/i915/cx0: Check and increase msgbus timeout threshold URL : https://patchwork.freedesktop.org/series/122982/ State : success == Summary == CI Bug Log - changes from CI_DRM_13571 -> Patchwork_122982v1

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/cx0: Check and increase msgbus timeout threshold

2023-08-28 Thread Patchwork
== Series Details == Series: drm/i915/cx0: Check and increase msgbus timeout threshold URL : https://patchwork.freedesktop.org/series/122982/ State : warning == Summary == Error: dim checkpatch failed 7a4474bf6960 drm/i915/cx0: Check and increase msgbus timeout threshold -:107:

Re: [Intel-gfx] [PATCH 4/6] drm/i915: Enable VRR later during fastsets

2023-08-28 Thread Manasi Navare
On Sun, Aug 27, 2023 at 10:41 PM Ville Syrjala wrote: > > From: Ville Syrjälä > > In order to reconcile seamless M/N updates with VRR we'll > need to defer the fastset VRR enable to happen after the > seamless M/N update (which happens during the vblank evade > critical section). So just push

Re: [Intel-gfx] [PATCH 3/6] drm/i915: Extract intel_crtc_vblank_evade_scanlines()

2023-08-28 Thread Manasi Navare
This looks good to me, Reviewed-by: Manasi Navare Manasi On Sun, Aug 27, 2023 at 10:41 PM Ville Syrjala wrote: > > From: Ville Syrjälä > > Pull the vblank evasion scanline calculations into their own helper > to declutter intel_pipe_update_start() a bit. > > Cc: Manasi Navare >

Re: [Intel-gfx] [PATCH 2/6] drm/i915: Change intel_pipe_update_{start, end}() calling convention

2023-08-28 Thread Manasi Navare
On Sun, Aug 27, 2023 at 10:41 PM Ville Syrjala wrote: > > From: Ville Syrjälä > > We'll need to also look at the old crtc state in > intel_pipe_update_start() so change the calling convention to > just plumb in the full atomic state instead. I am guessing we would need the old crtc state to

Re: [Intel-gfx] [PATCH] drm/i915/mtl: Update workaround 14016712196

2023-08-28 Thread Nirmoy Das
On 8/28/2023 8:34 AM, Tejas Upadhyay wrote: Now this workaround is permanent workaround on MTL and DG2, earlier we used to apply on MTL A0 step only. VLK-45480 Please remove the internal VLK reference. Otherwise this is Acked-by: Nirmoy Das Fixes: d922b80b1010 ("drm/i915/gt: Add

Re: [Intel-gfx] [PATCH 1/6] drm/i915: Move psr unlock out from the pipe update critical section

2023-08-28 Thread Manasi Navare
By doing psr_unlock after the vblank evade, are we ensuring that even when VRR params change during the pipe update, psr unlock will happen after the actual vblank based on newly programmed VRR params? Manasi On Sun, Aug 27, 2023 at 10:41 PM Ville Syrjala wrote: > > From: Ville Syrjälä > > Do

[Intel-gfx] [PATCH] drm/i915/cx0: Check and increase msgbus timeout threshold

2023-08-28 Thread Gustavo Sousa
We have experienced timeout issues when accessing C20 SRAM registers. Experimentation showed that bumping the message bus timer threshold helped on getting display Type-C connection on the C20 PHY to work. While the timeout is still under investigation with the HW team, having logic to allow

Re: [Intel-gfx] [PATCH 5/6] drm/i915: Adjust seamless_m_n flag behaviour

2023-08-28 Thread Golani, Mitulkumar Ajitkumar
Hi Ville, > -Original Message- > From: Intel-gfx On Behalf Of Ville > Syrjala > Sent: 28 August 2023 11:12 > To: intel-gfx@lists.freedesktop.org > Subject: [Intel-gfx] [PATCH 5/6] drm/i915: Adjust seamless_m_n flag > behaviour > > From: Ville Syrjälä > > Make the seamless_m_n flag

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/guc: fix compile issue of guc_klvs_abi.h

2023-08-28 Thread Patchwork
== Series Details == Series: drm/i915/guc: fix compile issue of guc_klvs_abi.h URL : https://patchwork.freedesktop.org/series/122971/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13571_full -> Patchwork_122971v1_full

Re: [Intel-gfx] [PATCH v15 00/23] Add generic memory shrinker to VirtIO-GPU and Panfrost DRM drivers

2023-08-28 Thread Helen Mae Koike Fornazier
On Monday, August 28, 2023 11:37 -03, "Helen Mae Koike Fornazier" wrote: > On Sunday, August 27, 2023 14:54 -03, Dmitry Osipenko > wrote: > > > This series: > > > > 1. Adds common drm-shmem memory shrinker > > 2. Enables shrinker for VirtIO-GPU driver > > 3. Switches Panfrost driver

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/gt: Fix reservation address in ggtt_reserve_guc_top

2023-08-28 Thread Patchwork
== Series Details == Series: drm/i915/gt: Fix reservation address in ggtt_reserve_guc_top URL : https://patchwork.freedesktop.org/series/122970/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13571_full -> Patchwork_122970v1_full

Re: [Intel-gfx] [PATCH v15 00/23] Add generic memory shrinker to VirtIO-GPU and Panfrost DRM drivers

2023-08-28 Thread Helen Mae Koike Fornazier
On Sunday, August 27, 2023 14:54 -03, Dmitry Osipenko wrote: > This series: > > 1. Adds common drm-shmem memory shrinker > 2. Enables shrinker for VirtIO-GPU driver > 3. Switches Panfrost driver to the common shrinker Hi Dmitry, Would you mind testing with drm-ci? We virt-io tests

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/guc: fix compile issue of guc_klvs_abi.h

2023-08-28 Thread Patchwork
== Series Details == Series: drm/i915/guc: fix compile issue of guc_klvs_abi.h URL : https://patchwork.freedesktop.org/series/122971/ State : success == Summary == CI Bug Log - changes from CI_DRM_13571 -> Patchwork_122971v1 Summary

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/guc: fix compile issue of guc_klvs_abi.h

2023-08-28 Thread Patchwork
== Series Details == Series: drm/i915/guc: fix compile issue of guc_klvs_abi.h URL : https://patchwork.freedesktop.org/series/122971/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gt: Fix reservation address in ggtt_reserve_guc_top

2023-08-28 Thread Patchwork
== Series Details == Series: drm/i915/gt: Fix reservation address in ggtt_reserve_guc_top URL : https://patchwork.freedesktop.org/series/122970/ State : success == Summary == CI Bug Log - changes from CI_DRM_13571 -> Patchwork_122970v1

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/gt: Fix reservation address in ggtt_reserve_guc_top

2023-08-28 Thread Patchwork
== Series Details == Series: drm/i915/gt: Fix reservation address in ggtt_reserve_guc_top URL : https://patchwork.freedesktop.org/series/122970/ State : warning == Summary == Error: dim checkpatch failed 483b43d16420 drm/i915/gt: Fix reservation address in ggtt_reserve_guc_top -:14:

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/psr: Add psr sink error status into sink status debugfs

2023-08-28 Thread Patchwork
== Series Details == Series: drm/i915/psr: Add psr sink error status into sink status debugfs URL : https://patchwork.freedesktop.org/series/122965/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13571_full -> Patchwork_122965v1_full

[Intel-gfx] [PATCH] drm/i915/guc: fix compile issue of guc_klvs_abi.h

2023-08-28 Thread Linyu Yuan
GCC report GUC_KLV_0_KEY and GUC_KLV_0_LEN is not constant when do preprocessing. Change to use GENMASK() to avoid the issue. Signed-off-by: Linyu Yuan --- drivers/gpu/drm/i915/gt/uc/abi/guc_klvs_abi.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [Intel-gfx] [PATCH 0/4] drm/amd/display: stop using drm_edid_override_connector_update()

2023-08-28 Thread Alex Hung
On 2023-08-22 06:01, Jani Nikula wrote: Over the past years I've been trying to unify the override and firmware EDID handling as well as EDID property updates. It won't work if drivers do their own random things. Let's check how to replace these references by appropriate ones or fork the

Re: [Intel-gfx] [PATCH] drm/i915/guc: fix compile issue of guc_klvs_abi.h

2023-08-28 Thread Linyu Yuan
On 8/25/2023 1:37 PM, Jani Nikula wrote: On Fri, 25 Aug 2023, Linyu Yuan wrote: GCC report GUC_KLV_0_KEY and GUC_KLV_0_LEN is not constant when do preprocessing. Please paste the actual compiler warning.   CC  drivers/gpu/drm/i915/gt/uc/intel_guc_submission.o In file included from

[Intel-gfx] [PATCH] drm/i915/gt: Fix reservation address in ggtt_reserve_guc_top

2023-08-28 Thread Javier Pello
There is an assertion in ggtt_reserve_guc_top that the global GTT is of size at least GUC_GGTT_TOP, which is not the case on a 32-bit platform; see commit 562d55d991b39ce376c492df2f7890fd6a541ffc ("drm/i915/bdw: Only use 2g GGTT for 32b platforms"). If GEM_BUG_ON is enabled, this triggers a BUG();

Re: [Intel-gfx] [PATCH v15 12/23] drm/shmem-helper: Add and use pages_pin_count

2023-08-28 Thread Boris Brezillon
On Sun, 27 Aug 2023 20:54:38 +0300 Dmitry Osipenko wrote: > Add separate pages_pin_count for tracking of whether drm-shmem pages are > moveable or not. With the addition of memory shrinker support to drm-shmem, > the pages_use_count will no longer determine whether pages are hard-pinned > in

Re: [Intel-gfx] [PATCH v15 09/23] drm/shmem-helper: Remove obsoleted is_iomem test

2023-08-28 Thread Boris Brezillon
On Sun, 27 Aug 2023 20:54:35 +0300 Dmitry Osipenko wrote: > Everything that uses the mapped buffer should by agnostic to is_iomem. ^be > The only reason for the is_iomem test is that we're setting shmem->vaddr > to the returned map->vaddr. Now

Re: [Intel-gfx] [PATCH v15 08/23] drm/shmem-helper: Refactor locked/unlocked functions

2023-08-28 Thread Boris Brezillon
On Sun, 27 Aug 2023 20:54:34 +0300 Dmitry Osipenko wrote: > Add locked and remove unlocked postfixes from drm-shmem function names, > making names consistent with the drm/gem core code. > > Suggested-by: Boris Brezillon > Signed-off-by: Dmitry Osipenko Reviewed-by: Boris Brezillon > --- >

Re: [Intel-gfx] [PATCH v15 04/23] drm/gem: Add _locked postfix to functions that have unlocked counterpart

2023-08-28 Thread Boris Brezillon
On Sun, 27 Aug 2023 20:54:30 +0300 Dmitry Osipenko wrote: > Add _locked postfix to drm_gem functions that have unlocked counterpart > functions to make GEM functions naming more consistent and intuitive in > regards to the locking requirements. > > Suggested-by: Boris Brezillon >

Re: [Intel-gfx] [PATCH v15 03/23] drm/gem: Change locked/unlocked postfix of drm_gem_v/unmap() function names

2023-08-28 Thread Boris Brezillon
On Sun, 27 Aug 2023 20:54:29 +0300 Dmitry Osipenko wrote: > Make drm/gem API function names consistent by having locked function > use the _locked postfix in the name, while the unlocked variants don't > use the _unlocked postfix. Rename drm_gem_v/unmap() function names to > make them consistent

Re: [Intel-gfx] [PATCH v15 01/23] drm/shmem-helper: Fix UAF in error path when freeing SGT of imported GEM

2023-08-28 Thread Boris Brezillon
On Sun, 27 Aug 2023 20:54:27 +0300 Dmitry Osipenko wrote: > Freeing drm-shmem GEM right after creating it using > drm_gem_shmem_prime_import_sg_table() frees SGT of the imported dma-buf > and then dma-buf frees this SGT second time. > > The v3d_prime_import_sg_table() is example of a error code

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/mtl: Update workaround 14016712196

2023-08-28 Thread Patchwork
== Series Details == Series: drm/i915/mtl: Update workaround 14016712196 URL : https://patchwork.freedesktop.org/series/122959/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13570_full -> Patchwork_122959v1_full Summary

Re: [Intel-gfx] PR for GSC FW release 102.0.0.1655 for MTL

2023-08-28 Thread Josh Boyer
On Wed, Aug 23, 2023 at 2:43 PM Daniele Ceraolo Spurio wrote: > > The following changes since commit 0e048b061bde79ad735c7b7b5161ee1bd3400150: > > Merge branch 'for-upstream' of > https://github.com/CirrusLogic/linux-firmware (2023-08-14 13:03:41 -0400) > > are available in the Git repository

Re: [Intel-gfx] [PATCH v15 02/23] drm/shmem-helper: Use flag for tracking page count bumped by get_pages_sgt()

2023-08-28 Thread Boris Brezillon
On Sun, 27 Aug 2023 20:54:28 +0300 Dmitry Osipenko wrote: > Use separate flag for tracking page count bumped by shmem->sgt to avoid > imbalanced page counter during of drm_gem_shmem_free() time. It's fragile > to assume that populated shmem->pages at a freeing time means that the > count was

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/psr: Add psr sink error status into sink status debugfs

2023-08-28 Thread Patchwork
== Series Details == Series: drm/i915/psr: Add psr sink error status into sink status debugfs URL : https://patchwork.freedesktop.org/series/122965/ State : success == Summary == CI Bug Log - changes from CI_DRM_13571 -> Patchwork_122965v1

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/psr: Add psr sink error status into sink status debugfs

2023-08-28 Thread Patchwork
== Series Details == Series: drm/i915/psr: Add psr sink error status into sink status debugfs URL : https://patchwork.freedesktop.org/series/122965/ State : warning == Summary == Error: dim sparse failed /home/kbuild2/linux/maintainer-tools/dim: line 50: /home/kbuild2/.dimrc: No such file or

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/psr: Add psr sink error status into sink status debugfs

2023-08-28 Thread Patchwork
== Series Details == Series: drm/i915/psr: Add psr sink error status into sink status debugfs URL : https://patchwork.freedesktop.org/series/122965/ State : warning == Summary == Error: dim checkpatch failed /home/kbuild2/linux/maintainer-tools/dim: line 50: /home/kbuild2/.dimrc: No such

Re: [Intel-gfx] [PATCH v15 11/23] dma-resv: Add kref_put_dma_resv()

2023-08-28 Thread Christian König
Am 27.08.23 um 19:54 schrieb Dmitry Osipenko: Add simple kref_put_dma_resv() helper that wraps around kref_put_ww_mutex() for drivers that needs to lock dma-resv on kref_put(). It's not possible to easily add this helper to kref.h because of the headers inclusion dependency, hence add it to

Re: [Intel-gfx] [PATCH v15 17/23] drm/shmem-helper: Add and use drm_gem_shmem_resv_assert_held() helper

2023-08-28 Thread Boris Brezillon
On Sun, 27 Aug 2023 20:54:43 +0300 Dmitry Osipenko wrote: > In a preparation of adding drm-shmem memory shrinker, move all reservation > locking lockdep checks to use new drm_gem_shmem_resv_assert_held() that > will resolve spurious lockdep warning about wrong locking order vs > fs_reclam code

Re: [Intel-gfx] [Intel-xe] [PATCH 3/4] drm/i915/lnl: support FBC on any plane

2023-08-28 Thread Govindapillai, Vinod
On Mon, 2023-08-28 at 12:00 +0300, Jani Nikula wrote: > On Mon, 28 Aug 2023, Vinod Govindapillai > wrote: > > diff --git a/drivers/gpu/drm/i915/i915_reg.h > > b/drivers/gpu/drm/i915/i915_reg.h > > index aefad14ab27a..b207774f3c33 100644 > > --- a/drivers/gpu/drm/i915/i915_reg.h > > +++

Re: [Intel-gfx] [PATCH v15 16/23] drm/shmem-helper: Use kref for vmap_use_count

2023-08-28 Thread Boris Brezillon
On Sun, 27 Aug 2023 20:54:42 +0300 Dmitry Osipenko wrote: > Use kref helper for vmap_use_count to make refcounting consistent with > pages_use_count and pages_pin_count that use kref. This will allow to > optimize unlocked vmappings by skipping reservation locking if refcnt > 1. The core is

Re: [Intel-gfx] [PATCH v15 12/23] drm/shmem-helper: Add and use pages_pin_count

2023-08-28 Thread Boris Brezillon
On Sun, 27 Aug 2023 20:54:38 +0300 Dmitry Osipenko wrote: > Add separate pages_pin_count for tracking of whether drm-shmem pages are > moveable or not. With the addition of memory shrinker support to drm-shmem, > the pages_use_count will no longer determine whether pages are hard-pinned > in

[Intel-gfx] ✗ Fi.CI.BAT: failure for HDCP MST aux issue fix (rev6)

2023-08-28 Thread Patchwork
== Series Details == Series: HDCP MST aux issue fix (rev6) URL : https://patchwork.freedesktop.org/series/122267/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13570 -> Patchwork_122267v6 Summary --- **FAILURE**

Re: [Intel-gfx] [PATCH v15 10/23] locking/refcount, kref: Add kref_put_ww_mutex()

2023-08-28 Thread Boris Brezillon
On Sun, 27 Aug 2023 20:54:36 +0300 Dmitry Osipenko wrote: > Introduce kref_put_ww_mutex() helper that will handle the wait-wound > mutex auto-locking on kref_put(). This helper is wanted by DRM drivers > that extensively use dma-reservation locking which in turns uses ww-mutex. > >

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for HDCP MST aux issue fix (rev6)

2023-08-28 Thread Patchwork
== Series Details == Series: HDCP MST aux issue fix (rev6) URL : https://patchwork.freedesktop.org/series/122267/ State : warning == Summary == Error: dim sparse failed /home/kbuild2/linux/maintainer-tools/dim: line 50: /home/kbuild2/.dimrc: No such file or directory

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for HDCP MST aux issue fix (rev6)

2023-08-28 Thread Patchwork
== Series Details == Series: HDCP MST aux issue fix (rev6) URL : https://patchwork.freedesktop.org/series/122267/ State : warning == Summary == Error: dim checkpatch failed /home/kbuild2/linux/maintainer-tools/dim: line 50: /home/kbuild2/.dimrc: No such file or directory

[Intel-gfx] ✗ Fi.CI.IGT: failure for fbc on any plane

2023-08-28 Thread Patchwork
== Series Details == Series: fbc on any plane URL : https://patchwork.freedesktop.org/series/122958/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13569_full -> Patchwork_122958v1_full Summary --- **FAILURE**

Re: [Intel-gfx] [Intel-xe] [PATCH 3/4] drm/i915/lnl: support FBC on any plane

2023-08-28 Thread Jani Nikula
On Mon, 28 Aug 2023, Vinod Govindapillai wrote: > diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h > index aefad14ab27a..b207774f3c33 100644 > --- a/drivers/gpu/drm/i915/i915_reg.h > +++ b/drivers/gpu/drm/i915/i915_reg.h > @@ -1327,6 +1327,10 @@ > #define

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/mtl: Update workaround 14016712196

2023-08-28 Thread Patchwork
== Series Details == Series: drm/i915/mtl: Update workaround 14016712196 URL : https://patchwork.freedesktop.org/series/122959/ State : success == Summary == CI Bug Log - changes from CI_DRM_13570 -> Patchwork_122959v1 Summary ---

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/mtl: Update workaround 14016712196

2023-08-28 Thread Patchwork
== Series Details == Series: drm/i915/mtl: Update workaround 14016712196 URL : https://patchwork.freedesktop.org/series/122959/ State : warning == Summary == Error: dim sparse failed /home/kbuild2/linux/maintainer-tools/dim: line 50: /home/kbuild2/.dimrc: No such file or directory

[Intel-gfx] [PATCH] drm/i915/psr: Add psr sink error status into sink status debugfs

2023-08-28 Thread Jouni Högander
Normally PSR errors detected by the panel are triggering HPD interrupt and seen as error in dmesg. Some panels are not triggering the interrupt even it is requested and they are detecting error. Due to this it would be good to have possibility to check panel detected errors. Add PSR error status

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: VRR and M/N stuff

2023-08-28 Thread Patchwork
== Series Details == Series: drm/i915: VRR and M/N stuff URL : https://patchwork.freedesktop.org/series/122955/ State : success == Summary == CI Bug Log - changes from CI_DRM_13569_full -> Patchwork_122955v1_full Summary ---

[Intel-gfx] ✓ Fi.CI.BAT: success for fbc on any plane

2023-08-28 Thread Patchwork
== Series Details == Series: fbc on any plane URL : https://patchwork.freedesktop.org/series/122958/ State : success == Summary == CI Bug Log - changes from CI_DRM_13569 -> Patchwork_122958v1 Summary --- **SUCCESS** No

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for fbc on any plane

2023-08-28 Thread Patchwork
== Series Details == Series: fbc on any plane URL : https://patchwork.freedesktop.org/series/122958/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. +./arch/x86/include/asm/bitops.h:117:1: warning:

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for fbc on any plane

2023-08-28 Thread Patchwork
== Series Details == Series: fbc on any plane URL : https://patchwork.freedesktop.org/series/122958/ State : warning == Summary == Error: dim checkpatch failed /home/kbuild2/linux/maintainer-tools/dim: line 50: /home/kbuild2/.dimrc: No such file or directory

[Intel-gfx] ✗ Fi.CI.BAT: failure for Add DSC PPS readout (rev12)

2023-08-28 Thread Patchwork
== Series Details == Series: Add DSC PPS readout (rev12) URL : https://patchwork.freedesktop.org/series/120456/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13569 -> Patchwork_120456v12 Summary --- **FAILURE**

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Add DSC PPS readout (rev12)

2023-08-28 Thread Patchwork
== Series Details == Series: Add DSC PPS readout (rev12) URL : https://patchwork.freedesktop.org/series/120456/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. +./arch/x86/include/asm/bitops.h:117:1:

[Intel-gfx] [PATCH v4 2/4] drm/i915/hdcp: Propagate aux info in DP HDCP functions

2023-08-28 Thread Suraj Kandpal
We were propagating dig_port info to dp hdcp2 specific functions. Let us clean that up and send intel_connector in the following functions: intel_dp_hdcp2_wait_for_msg, get_receiver_id_list_rx_info, intel_dp_hdcp2_read_rx_status. This optimises mst scenarios where aux ends up being remote and not

[Intel-gfx] [PATCH v3 2/4] drm/i915/hdcp: Propagate aux info in DP HDCP functions

2023-08-28 Thread Suraj Kandpal
We were propagating dig_port info to dp hdcp2 specific functions. Let us clean that up and send intel_connector in the following functions: intel_dp_hdcp2_wait_for_msg, get_receiver_id_list_rx_info, intel_dp_hdcp2_read_rx_status. This optimises mst scenarios where aux ends up being remote and not

[Intel-gfx] [PATCH v3 4/4] drm/i915/hdcp: Adjust timeout for read in DPMST Scenario

2023-08-28 Thread Suraj Kandpal
For dpmst hdcp scenario increase the message timeout based on the number of ports connected as each port needs to be validated and each will take the prescribed amount of time for the respective msg_id and total timeout will be original_timeout * num_ports. --v2 -Add justification for Adjusting

[Intel-gfx] [PATCH v3 3/4] drm/i915/hdcp: Send the correct aux for DPMST HDCP scenario

2023-08-28 Thread Suraj Kandpal
Up until now we were sending the base aux stored in dig_port which is not correct as this causes an issue when monitor is connected via a DPMST hub causing it to be remote hence we end up seeing AUX failures so let's send the remote aux in case of DPMST. Signed-off-by: Suraj Kandpal Reviewed-by:

[Intel-gfx] [PATCH v3 1/4] drm/i915/hdcp: Use intel_connector argument in intel_hdcp_shim

2023-08-28 Thread Suraj Kandpal
Update intel_hdcp_shim funcs specifically read_2_2_message, write_2_2_message and config_stream_type to use intel_connector argument instead of intel_digital_port as this will help in getting correct aux later for dp mst scenarios also already hdcp funcs derive digital_port from connector and then

[Intel-gfx] [PATCH v3 0/4] HDCP MST aux issue fix

2023-08-28 Thread Suraj Kandpal
Up until now all dp hdcp specific function derived the aux from dig_port which gave the aux of the primary port but with DPMST when a MST hub comes into picture the monitor becomes remote and what we need is a corresponding aux which is also remote. These set of patches aim to fix up just that.

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: VRR and M/N stuff

2023-08-28 Thread Patchwork
== Series Details == Series: drm/i915: VRR and M/N stuff URL : https://patchwork.freedesktop.org/series/122955/ State : success == Summary == CI Bug Log - changes from CI_DRM_13569 -> Patchwork_122955v1 Summary --- **SUCCESS** No

[Intel-gfx] [PATCH] drm/i915/mtl: Update workaround 14016712196

2023-08-28 Thread Tejas Upadhyay
Now this workaround is permanent workaround on MTL and DG2, earlier we used to apply on MTL A0 step only. VLK-45480 Fixes: d922b80b1010 ("drm/i915/gt: Add workaround 14016712196") Signed-off-by: Tejas Upadhyay --- drivers/gpu/drm/i915/gt/gen8_engine_cs.c | 7 +++ 1 file changed, 3

[Intel-gfx] [PATCH 4/4] drm/i915/lnl: FBC is supported with per pixel alpha

2023-08-28 Thread Vinod Govindapillai
For LNL onwards, FBC can be supported on planes with per pixel alpha Bspec: 69560 Signed-off-by: Vinod Govindapillai --- drivers/gpu/drm/i915/display/intel_fbc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/display/intel_fbc.c

[Intel-gfx] [PATCH 3/4] drm/i915/lnl: support FBC on any plane

2023-08-28 Thread Vinod Govindapillai
In LNL onwards, FBC can be associated to the first three planes. The FBC will be enabled for first FBC capable visible plane until the userspace can select one of these FBC capable plane explicitly Bspec: 69560 Signed-off-by: Vinod Govindapillai --- drivers/gpu/drm/i915/display/intel_fbc.c

[Intel-gfx] [PATCH 2/4] drm/i915/lnl: update FBC debugfs to include plane information

2023-08-28 Thread Vinod Govindapillai
In future platforms, FBC can be supported on planes other than the primary plane. So update the debugfs entry for FBC status to have the plane ID included. Signed-off-by: Vinod Govindapillai --- drivers/gpu/drm/i915/display/intel_fbc.c | 14 +++--- 1 file changed, 11 insertions(+), 3

[Intel-gfx] [PATCH 1/4] drm/i915/lnl: FBC can be enabled with PSR2

2023-08-28 Thread Vinod Govindapillai
FBC restriction with PSR2 can be removed from LNL onwards Signed-off-by: Vinod Govindapillai --- drivers/gpu/drm/i915/display/intel_fbc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_fbc.c b/drivers/gpu/drm/i915/display/intel_fbc.c

[Intel-gfx] [PATCH 0/4] fbc on any plane

2023-08-28 Thread Vinod Govindapillai
In LNL, FBC can be supported in planes other than the primary planes. Vinod Govindapillai (4): drm/i915/lnl: FBC can be enabled with PSR2 drm/i915/lnl: update FBC debugfs to include plane information drm/i915/lnl: support FBC on any plane drm/i915/lnl: FBC is supported with per pixel

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: VRR and M/N stuff

2023-08-28 Thread Patchwork
== Series Details == Series: drm/i915: VRR and M/N stuff URL : https://patchwork.freedesktop.org/series/122955/ State : warning == Summary == Error: dim sparse failed /home/kbuild2/linux/maintainer-tools/dim: line 50: /home/kbuild2/.dimrc: No such file or directory