Re: [PATCH 2/7] drm/i915/hdcp: HDCP Capability for the downstream device

2024-01-24 Thread Nautiyal, Ankit K
On 1/24/2024 6:50 PM, Nautiyal, Ankit K wrote: On 1/12/2024 1:11 PM, Suraj Kandpal wrote: Currently we are only checking capability of remote device and not immediate downstream device but during capability check we need are concerned with only the HDCP capability of downstream device.

Re: [PATCH] drm/i915/guc: Remove usage of the deprecated ida_simple_xx() API

2024-01-24 Thread Matthew Brost
On Sun, Jan 14, 2024 at 04:15:34PM +0100, Christophe JAILLET wrote: > ida_alloc() and ida_free() should be preferred to the deprecated > ida_simple_get() and ida_simple_remove(). > > Note that the upper limit of ida_simple_get() is exclusive, but the one of > ida_alloc_range() is inclusive. So a

Re: [RFC PATCH] drm/i915: Add GETPARAM for GuC submission version

2024-01-24 Thread Kenneth Graunke
On Wednesday, January 24, 2024 12:55:56 AM PST Tvrtko Ursulin wrote: > > On 24/01/2024 08:19, Joonas Lahtinen wrote: > > Add reporting of the GuC submissio/VF interface version via GETPARAM > > properties. Mesa intends to use this information to check for old > > firmware versions with known bugs

Re: linux-next: Tree for Jan 23 (drm/xe/)

2024-01-24 Thread Randy Dunlap
On 1/24/24 01:17, Jani Nikula wrote: > On Tue, 23 Jan 2024, Randy Dunlap wrote: >> On 1/22/24 18:29, Stephen Rothwell wrote: >>> Hi all, >>> >>> News: there will be no linux-next release on Friday >>> >>> Changes since 20240122: >>> >> >> on ARM64, when >> DRM_I915 is not set >> DRM_XE=m >>

Re: [RFC PATCH] drm/i915: Add GETPARAM for GuC submission version

2024-01-24 Thread John Harrison
On 1/24/2024 00:55, Tvrtko Ursulin wrote: On 24/01/2024 08:19, Joonas Lahtinen wrote: Add reporting of the GuC submissio/VF interface version via GETPARAM properties. Mesa intends to use this information to check for old firmware versions with known bugs before enabling features like async

Re: Re: [PATCH 1/3] bits: introduce fixed-type genmasks

2024-01-24 Thread Gustavo Sousa
Quoting Yury Norov (2024-01-24 12:27:58-03:00) >On Wed, Jan 24, 2024 at 08:03:53AM -0600, Lucas De Marchi wrote: >> On Wed, Jan 24, 2024 at 09:58:26AM +0200, Jani Nikula wrote: >> > On Tue, 23 Jan 2024, Lucas De Marchi wrote: >> > > From: Yury Norov >> > > >> > > Generalize __GENMASK() to

Re: Re: [PATCH 1/3] bits: introduce fixed-type genmasks

2024-01-24 Thread Lucas De Marchi
On Wed, Jan 24, 2024 at 09:58:26AM +0200, Jani Nikula wrote: On Tue, 23 Jan 2024, Lucas De Marchi wrote: From: Yury Norov Generalize __GENMASK() to support different types, and implement fixed-types versions of GENMASK() based on it. The fixed-type version allows more strict checks to the

✗ Fi.CI.BAT: failure for drm/i915: Fix VMA UAF on destroy against deactivate race (rev2)

2024-01-24 Thread Patchwork
== Series Details == Series: drm/i915: Fix VMA UAF on destroy against deactivate race (rev2) URL : https://patchwork.freedesktop.org/series/129026/ State : failure == Summary == CI Bug Log - changes from CI_DRM_14168 -> Patchwork_129026v2

✗ Fi.CI.SPARSE: warning for drm/i915: Fix VMA UAF on destroy against deactivate race (rev2)

2024-01-24 Thread Patchwork
== Series Details == Series: drm/i915: Fix VMA UAF on destroy against deactivate race (rev2) URL : https://patchwork.freedesktop.org/series/129026/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

Re: [RFC PATCH] drm/i915: Add GETPARAM for GuC submission version

2024-01-24 Thread Souza, Jose
On Wed, 2024-01-24 at 10:19 +0200, Joonas Lahtinen wrote: > Add reporting of the GuC submissio/VF interface version via GETPARAM > properties. Mesa intends to use this information to check for old > firmware versions with known bugs before enabling features like async > compute. > Reviewed-by:

Re: [PATCH] drm/i915: limit eDP MSO pipe only for display version 20 and below

2024-01-24 Thread Gustavo Sousa
Hi, Luca! Quoting Luca Coelho (2024-01-24 05:52:29-03:00) >The pipes that can be used for eDP MSO are limited to pipe A (and >sometimes also pipe B) only for display version 20 and below. > >Modify the function that returns the pipe mask for eDP MSO so that >these limitations only apply to

Re: [PATCH 2/7] drm/i915/hdcp: HDCP Capability for the downstream device

2024-01-24 Thread Nautiyal, Ankit K
On 1/12/2024 1:11 PM, Suraj Kandpal wrote: Currently we are only checking capability of remote device and not immediate downstream device but during capability check we need are concerned with only the HDCP capability of downstream device. During i915_display_info reporting we need HDCP

[PATCH v5 3/3] Revert "drm/i915: Wait for active retire before i915_active_fini()"

2024-01-24 Thread Janusz Krzysztofik
This reverts commit 7a2280e8dcd2f1f436db9631287c0b21cf6a92b0, obsoleted by "drm/i915/vma: Fix UAF on destroy against retire race". Signed-off-by: Janusz Krzysztofik Cc: Nirmoy Das --- drivers/gpu/drm/i915/i915_vma.c | 2 -- 1 file changed, 2 deletions(-) diff --git

[PATCH v5 2/3] drm/i915: Remove extra multi-gt pm-references

2024-01-24 Thread Janusz Krzysztofik
There was an attempt to fix an issue of illegal attempts to free a still active i915 VMA object when parking a GT believed to be idle, reported by CI on 2-GT Meteor Lake. As a solution, an extra wakeref for a Primary GT was acquired from i915_gem_do_execbuffer() -- see commit f56fe3e91787

[PATCH v5 1/3] drm/i915/vma: Fix UAF on destroy against retire race

2024-01-24 Thread Janusz Krzysztofik
Object debugging tools were sporadically reporting illegal attempts to free a still active i915 VMA object when parking a GT believed to be idle. [161.359441] ODEBUG: free active (active state 0) object: 88811643b958 object type: i915_active hint: __i915_vma_active+0x0/0x50 [i915]

[PATCH v5 0/3] drm/i915: Fix VMA UAF on destroy against deactivate race

2024-01-24 Thread Janusz Krzysztofik
Object debugging tools were sporadically reporting illegal attempts to free a still active i915 VMA object when parking a GT believed to be idle. [161.359441] ODEBUG: free active (active state 0) object: 88811643b958 object type: i915_active hint: __i915_vma_active+0x0/0x50 [i915]

Re: [PATCH 1/7] drm/i915/hdcp: Move to direct reads for HDCP

2024-01-24 Thread Nautiyal, Ankit K
On 1/12/2024 1:11 PM, Suraj Kandpal wrote: Even for MST scenarios we need to do direct reads only on the immediate downstream device the rest of the authentication is taken care by that device. Remote reads will only be used to check capability of the monitors in MST topology. I think it

Re: [PATCH] mm: Remove double faults once write a device pfn

2024-01-24 Thread Alistair Popple
"Zhou, Xianrong" writes: > [AMD Official Use Only - General] > >> > The vmf_insert_pfn_prot could cause unnecessary double faults on a >> > device pfn. Because currently the vmf_insert_pfn_prot does not >> > make the pfn writable so the pte entry is normally read-only or >> >

✗ Fi.CI.BAT: failure for drm/i915: limit eDP MSO pipe only for display version 20 and below

2024-01-24 Thread Patchwork
== Series Details == Series: drm/i915: limit eDP MSO pipe only for display version 20 and below URL : https://patchwork.freedesktop.org/series/129123/ State : failure == Summary == CI Bug Log - changes from CI_DRM_14168 -> Patchwork_129123v1

Re: [PATCH v2 2/4] drm/i915/psr: Add alpm_parameters struct

2024-01-24 Thread Hogander, Jouni
On Wed, 2024-01-24 at 09:28 +, Murthy, Arun R wrote: > > > > -Original Message- > > From: Hogander, Jouni > > Sent: Wednesday, January 24, 2024 2:55 PM > > To: Murthy, Arun R ; > > intel-gfx@lists.freedesktop.org > > Subject: Re: [PATCH v2 2/4] drm/i915/psr: Add alpm_parameters > >

RE: [PATCH v2 2/4] drm/i915/psr: Add alpm_parameters struct

2024-01-24 Thread Murthy, Arun R
> -Original Message- > From: Hogander, Jouni > Sent: Wednesday, January 24, 2024 2:55 PM > To: Murthy, Arun R ; intel-gfx@lists.freedesktop.org > Subject: Re: [PATCH v2 2/4] drm/i915/psr: Add alpm_parameters struct > > On Wed, 2024-01-24 at 09:17 +, Murthy, Arun R wrote: > > > > >

Re: [PATCH v2 2/4] drm/i915/psr: Add alpm_parameters struct

2024-01-24 Thread Hogander, Jouni
On Wed, 2024-01-24 at 09:17 +, Murthy, Arun R wrote: > > > > -Original Message- > > From: Intel-gfx On Behalf > > Of Jouni > > Högander > > Sent: Friday, January 5, 2024 7:45 PM > > To: intel-gfx@lists.freedesktop.org > > Subject: [PATCH v2 2/4] drm/i915/psr: Add alpm_parameters

Re: linux-next: Tree for Jan 23 (drm/xe/)

2024-01-24 Thread Jani Nikula
On Tue, 23 Jan 2024, Randy Dunlap wrote: > On 1/22/24 18:29, Stephen Rothwell wrote: >> Hi all, >> >> News: there will be no linux-next release on Friday >> >> Changes since 20240122: >> > > on ARM64, when > DRM_I915 is not set > DRM_XE=m > DEBUG_FS is not set > >

RE: [PATCH v2 2/4] drm/i915/psr: Add alpm_parameters struct

2024-01-24 Thread Murthy, Arun R
> -Original Message- > From: Intel-gfx On Behalf Of Jouni > Högander > Sent: Friday, January 5, 2024 7:45 PM > To: intel-gfx@lists.freedesktop.org > Subject: [PATCH v2 2/4] drm/i915/psr: Add alpm_parameters struct > > Add new alpm_parameters struct into intel_psr for all calculated

Re: [PATCH] drm/i915/psr: Request modeset on initial commit to compute PSR state

2024-01-24 Thread Jani Nikula
On Tue, 23 Jan 2024, Ville Syrjälä wrote: > On Tue, Jan 23, 2024 at 07:57:00AM +, Hogander, Jouni wrote: >> On Tue, 2024-01-23 at 09:41 +0200, Ville Syrjälä wrote: >> > On Tue, Jan 23, 2024 at 09:11:03AM +0200, Jouni Högander wrote: >> > > We want to request full modeset in initial fast check

✗ Fi.CI.BAT: failure for drm/i915/fbc: Allow FBC with CCS modifiers on SKL+ (rev3)

2024-01-24 Thread Patchwork
== Series Details == Series: drm/i915/fbc: Allow FBC with CCS modifiers on SKL+ (rev3) URL : https://patchwork.freedesktop.org/series/129075/ State : failure == Summary == CI Bug Log - changes from CI_DRM_14168 -> Patchwork_129075v3

Re: [RFC PATCH] drm/i915: Add GETPARAM for GuC submission version

2024-01-24 Thread Tvrtko Ursulin
On 24/01/2024 08:19, Joonas Lahtinen wrote: Add reporting of the GuC submissio/VF interface version via GETPARAM properties. Mesa intends to use this information to check for old firmware versions with known bugs before enabling features like async compute. There was

[PATCH] drm/i915: limit eDP MSO pipe only for display version 20 and below

2024-01-24 Thread Luca Coelho
The pipes that can be used for eDP MSO are limited to pipe A (and sometimes also pipe B) only for display version 20 and below. Modify the function that returns the pipe mask for eDP MSO so that these limitations only apply to version 20 and below, enabling all pipes otherwise. Bspec: 68923 Cc:

✗ Fi.CI.BAT: failure for drm/i915: Add GETPARAM for GuC submission version

2024-01-24 Thread Patchwork
== Series Details == Series: drm/i915: Add GETPARAM for GuC submission version URL : https://patchwork.freedesktop.org/series/129122/ State : failure == Summary == CI Bug Log - changes from CI_DRM_14168 -> Patchwork_129122v1 Summary

✗ Fi.CI.SPARSE: warning for drm/i915: Add GETPARAM for GuC submission version

2024-01-24 Thread Patchwork
== Series Details == Series: drm/i915: Add GETPARAM for GuC submission version URL : https://patchwork.freedesktop.org/series/129122/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

Re: [Intel-gfx] [PATCH v7] drm/i915: handle uncore spinlock when not available

2024-01-24 Thread Sebastian Andrzej Siewior
On 2023-12-01 12:00:32 [+0200], Luca Coelho wrote: > To handle this, split the spin_lock/unlock_irqsave/restore() into > spin_lock/unlock() followed by a call to local_irq_save/restore() and On PREEMPT_RT spinlock_t becomes a sleeping lock so this split is not working. See

[RFC PATCH] drm/i915: Add GETPARAM for GuC submission version

2024-01-24 Thread Joonas Lahtinen
Add reporting of the GuC submissio/VF interface version via GETPARAM properties. Mesa intends to use this information to check for old firmware versions with known bugs before enabling features like async compute. Signed-off-by: Joonas Lahtinen Cc: Kenneth Graunke Cc: Jose Souza Cc: Sagar

Re: [PATCH 3/3] drm/i915: Convert REG_GENMASK* to fixed-width GENMASK_*

2024-01-24 Thread Jani Nikula
On Tue, 23 Jan 2024, Lucas De Marchi wrote: > Now that include/linux/bits.h implements fixed-width GENMASK_*, use them > to implement the i915/xe specific macros. Converting each driver to use > the generic macros are left for later, when/if other driver-specific > macros are also generalized.