Re: GuC issue

2024-02-08 Thread natur . produkt
Hello, Please see my comments below. piątek, 9 lutego 2024 2:45 AM, John Harrison napisał(a): > > > Hello, > > What platform is this on? And which GuC firmware version are you using? It's TGL. I'm using tgl_guc_70.1.1.bin firmware blob. > > One thing you made need to do is force maximum

Re: GuC issue

2024-02-08 Thread John Harrison
Hello, What platform is this on? And which GuC firmware version are you using? One thing you made need to do is force maximum GT frequency during GuC load. That is something the i915 driver does. If the system decides the GPU is idle and drops the frequency to minimum then it can take

Re: [PATCH 3/4] drm/xe/hdcp: Enable HDCP for XE

2024-02-08 Thread Daniele Ceraolo Spurio
On 2/7/2024 3:35 AM, Suraj Kandpal wrote: Enable HDCP for Xe by defining functions which take care of interaction of HDCP as a client with the GSC CS interface. --v2 -add kfree at appropriate place [Daniele] -forward declare drm_i915_private [Daniele] I don't see the forward declaration,

Re: [PATCH 2/4] drm/xe: Use gsc_proxy_init_done to check proxy status

2024-02-08 Thread Daniele Ceraolo Spurio
On 2/7/2024 3:35 AM, Suraj Kandpal wrote: Expose gsc_proxy_init_done so that we can check if gsc proxy has been initialized or not. Signed-off-by: Suraj Kandpal --- drivers/gpu/drm/xe/display/xe_hdcp_gsc.c | 25 ++-- drivers/gpu/drm/xe/xe_gsc_proxy.c| 2 +-

✓ Fi.CI.BAT: success for series starting with [v6,1/3] drm/buddy: Implement tracking clear page feature

2024-02-08 Thread Patchwork
== Series Details == Series: series starting with [v6,1/3] drm/buddy: Implement tracking clear page feature URL : https://patchwork.freedesktop.org/series/129685/ State : success == Summary == CI Bug Log - changes from CI_DRM_14245 -> Patchwork_129685v1

✗ Fi.CI.SPARSE: warning for series starting with [v6,1/3] drm/buddy: Implement tracking clear page feature

2024-02-08 Thread Patchwork
== Series Details == Series: series starting with [v6,1/3] drm/buddy: Implement tracking clear page feature URL : https://patchwork.freedesktop.org/series/129685/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked

✓ Fi.CI.BAT: success for drm/i915/dp: Limit SST link rate to <=8.1Gbps

2024-02-08 Thread Patchwork
== Series Details == Series: drm/i915/dp: Limit SST link rate to <=8.1Gbps URL : https://patchwork.freedesktop.org/series/129682/ State : success == Summary == CI Bug Log - changes from CI_DRM_14245 -> Patchwork_129682v1 Summary ---

✓ Fi.CI.BAT: success for drm/i915: drm_dbg_kms() conversions and cleanups

2024-02-08 Thread Patchwork
== Series Details == Series: drm/i915: drm_dbg_kms() conversions and cleanups URL : https://patchwork.freedesktop.org/series/129677/ State : success == Summary == CI Bug Log - changes from CI_DRM_14244 -> Patchwork_129677v1 Summary ---

✗ Fi.CI.SPARSE: warning for drm/i915: drm_dbg_kms() conversions and cleanups

2024-02-08 Thread Patchwork
== Series Details == Series: drm/i915: drm_dbg_kms() conversions and cleanups URL : https://patchwork.freedesktop.org/series/129677/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

✗ Fi.CI.CHECKPATCH: warning for drm/i915: drm_dbg_kms() conversions and cleanups

2024-02-08 Thread Patchwork
== Series Details == Series: drm/i915: drm_dbg_kms() conversions and cleanups URL : https://patchwork.freedesktop.org/series/129677/ State : warning == Summary == Error: dim checkpatch failed 56fa1f3dbdc1 drm/i915: Correct for_each_old_global_obj_in_state() arguments -:27:

Re: Re: [PATCH v3 3/3] drm/i915: Convert REG_GENMASK* to fixed-width GENMASK_*

2024-02-08 Thread Lucas De Marchi
On Thu, Feb 08, 2024 at 09:07:32PM +0100, Andi Shyti wrote: Hi Lucas, ... +#define REG_GENMASK(__high, __low) GENMASK_U32(__high, __low) +#define REG_GENMASK64(__high, __low) GENMASK_U64(__high, __low) +#define REG_GENMASK16(__high, __low) GENMASK_U16(__high, __low) +#define

Re: Re: [PATCH v3 2/3] bits: Introduce fixed-type BIT

2024-02-08 Thread Lucas De Marchi
On Thu, Feb 08, 2024 at 09:04:45PM +0100, Andi Shyti wrote: Hi Lucas, looks good, just one idea... ... +#define BIT_U8(b) ((u8)(BIT_INPUT_CHECK(u8, b) + BIT(b))) +#define BIT_U16(b) ((u16)(BIT_INPUT_CHECK(u16, b) + BIT(b))) +#define BIT_U32(b)

Re: [PATCH] Revert "drm/i915/mtl: Update workaround 14018778641"

2024-02-08 Thread Andi Shyti
Hi Tejas, On Wed, Jan 17, 2024 at 10:50:42AM +0530, Tejas Upadhyay wrote: > Applying WA 14018778641 only on Compute engine has impact on Chrome > related apps. Reverting this patch and applying WA to all engines is > helping with performance on Chrome related apps. > > Signed-off-by: Tejas

✓ Fi.CI.BAT: success for drm/i915/selftests: Increasing the sleep time for live_rc6_manual (rev2)

2024-02-08 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Increasing the sleep time for live_rc6_manual (rev2) URL : https://patchwork.freedesktop.org/series/129664/ State : success == Summary == CI Bug Log - changes from CI_DRM_14244 -> Patchwork_129664v2

Re: [PATCH v3 3/3] drm/i915: Convert REG_GENMASK* to fixed-width GENMASK_*

2024-02-08 Thread Andi Shyti
Hi Lucas, ... > +#define REG_GENMASK(__high, __low) GENMASK_U32(__high, __low) > +#define REG_GENMASK64(__high, __low) GENMASK_U64(__high, __low) > +#define REG_GENMASK16(__high, __low) GENMASK_U16(__high, __low) > +#define REG_GENMASK8(__high, __low) GENMASK_U8(__high, __low) I was hoping

Re: [PATCH v3 2/3] bits: Introduce fixed-type BIT

2024-02-08 Thread Andi Shyti
Hi Lucas, looks good, just one idea... ... > +#define BIT_U8(b)((u8)(BIT_INPUT_CHECK(u8, b) + BIT(b))) > +#define BIT_U16(b) ((u16)(BIT_INPUT_CHECK(u16, b) + BIT(b))) > +#define BIT_U32(b) ((u32)(BIT_INPUT_CHECK(u32, b) + BIT(b))) > +#define BIT_U64(b)

Re: [PATCH v3 1/3] bits: introduce fixed-type genmasks

2024-02-08 Thread Andi Shyti
Hi Lucas and Yury, On Wed, Feb 07, 2024 at 11:45:19PM -0800, Lucas De Marchi wrote: > From: Yury Norov > > Generalize __GENMASK() to support different types, and implement > fixed-types versions of GENMASK() based on it. The fixed-type version > allows more strict checks to the min/max values

✓ Fi.CI.BAT: success for drm/i915: Prevent HW access during init from connector hooks (rev2)

2024-02-08 Thread Patchwork
== Series Details == Series: drm/i915: Prevent HW access during init from connector hooks (rev2) URL : https://patchwork.freedesktop.org/series/129584/ State : success == Summary == CI Bug Log - changes from CI_DRM_14244 -> Patchwork_129584v2

✗ Fi.CI.CHECKPATCH: warning for drm/i915: Prevent HW access during init from connector hooks (rev2)

2024-02-08 Thread Patchwork
== Series Details == Series: drm/i915: Prevent HW access during init from connector hooks (rev2) URL : https://patchwork.freedesktop.org/series/129584/ State : warning == Summary == Error: dim checkpatch failed 2691a2787eb6 drm/i915: Prevent HW access during init from SDVO TV get_modes hook

Re: [PATCH] drm/i915: Add flex arrays to struct i915_syncmap

2024-02-08 Thread Gustavo A. R. Silva
On 2/8/24 12:13, Erick Archer wrote: The "struct i915_syncmap" uses a dynamically sized set of trailing elements. It can use an "u32" array or a "struct i915_syncmap *" array. So, use the preferred way in the kernel declaring flexible arrays [1]. Because there are two possibilities for the

Re: [PATCH v2] drm/i915: Add GuC submission interface version query

2024-02-08 Thread Souza, Jose
On Thu, 2024-02-08 at 07:19 -0800, José Roberto de Souza wrote: > On Thu, 2024-02-08 at 14:59 +, Tvrtko Ursulin wrote: > > On 08/02/2024 14:30, Souza, Jose wrote: > > > On Thu, 2024-02-08 at 08:25 +, Tvrtko Ursulin wrote: > > > > From: Tvrtko Ursulin > > > > > > > > Add a new query to

Re: [RFC] drm/i915: Add GuC submission interface version query

2024-02-08 Thread John Harrison
On 2/8/2024 00:41, Tvrtko Ursulin wrote: On 07/02/2024 19:34, John Harrison wrote: On 2/7/2024 10:49, Tvrtko Ursulin wrote: On 07/02/2024 18:12, John Harrison wrote: On 2/7/2024 03:56, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Add a new query to the GuC submission interface version. Mesa

Re: [PATCH 2/2] xfs: disable large folio support in xfile_create

2024-02-08 Thread Darrick J. Wong
On Wed, Feb 07, 2024 at 05:56:21PM -0800, Andrew Morton wrote: > On Thu, 11 Jan 2024 18:22:50 -0800 "Darrick J. Wong" > wrote: > > > On Thu, Jan 11, 2024 at 10:45:53PM +, Matthew Wilcox wrote: > > > On Thu, Jan 11, 2024 at 02:00:53PM -0800, Andrew Morton wrote: > > > > On Wed, 10 Jan 2024

Re: [PATCH] drm/i915/dp: Limit SST link rate to <=8.1Gbps

2024-02-08 Thread Jani Nikula
On Thu, 08 Feb 2024, Ville Syrjala wrote: > From: Ville Syrjälä > > Limit the link rate to HBR3 or below (<=8.1Gbps) in SST mode. > UHBR (10Gbps+) link rates require 128b/132b channel encoding > which we have not yet hooked up into the SST/no-sideband codepaths. > > Cc: sta...@vger.kernel.org >

Re: [PATCH 00/13] drm/i915: drm_dbg_kms() conversions and cleanups

2024-02-08 Thread Jani Nikula
On Thu, 08 Feb 2024, Ville Syrjala wrote: > From: Ville Syrjälä > > Convert a bunch of lingering DRM_DEBUG_KMS() & co. to the > per-device drm_dbg_kms() variants. The stuff remining after this > are DVO encoder drivers, DMI match functions, and ACPI/DSM stuff. > > And also include a bit of other

[PATCH v6 1/3] drm/buddy: Implement tracking clear page feature

2024-02-08 Thread Arunpravin Paneer Selvam
- Add tracking clear page feature. - Driver should enable the DRM_BUDDY_CLEARED flag if it successfully clears the blocks in the free path. On the otherhand, DRM buddy marks each block as cleared. - Track the available cleared pages size - If driver requests cleared memory we prefer cleared

[PATCH v6 3/3] drm/buddy: Add defragmentation support

2024-02-08 Thread Arunpravin Paneer Selvam
Add a function to support defragmentation. v1: Defragment the memory beginning from min_order till the required memory space is available. Signed-off-by: Arunpravin Paneer Selvam Suggested-by: Matthew Auld --- drivers/gpu/drm/drm_buddy.c | 67 +++--

[PATCH v6 2/3] drm/amdgpu: Enable clear page functionality

2024-02-08 Thread Arunpravin Paneer Selvam
Add clear page support in vram memory region. v1:(Christian) - Dont handle clear page as TTM flag since when moving the BO back in from GTT again we don't need that. - Make a specialized version of amdgpu_fill_buffer() which only clears the VRAM areas which are not already cleared -

[PATCH] drm/i915/dp: Limit SST link rate to <=8.1Gbps

2024-02-08 Thread Ville Syrjala
From: Ville Syrjälä Limit the link rate to HBR3 or below (<=8.1Gbps) in SST mode. UHBR (10Gbps+) link rates require 128b/132b channel encoding which we have not yet hooked up into the SST/no-sideband codepaths. Cc: sta...@vger.kernel.org Signed-off-by: Ville Syrjälä ---

Re: [PATCH v2] drm/i915: Add GuC submission interface version query

2024-02-08 Thread Souza, Jose
On Thu, 2024-02-08 at 14:59 +, Tvrtko Ursulin wrote: > On 08/02/2024 14:30, Souza, Jose wrote: > > On Thu, 2024-02-08 at 08:25 +, Tvrtko Ursulin wrote: > > > From: Tvrtko Ursulin > > > > > > Add a new query to the GuC submission interface version. > > > > > > Mesa intends to use this

Re: [PATCH 02/19] drm/dp: Add support for DP tunneling

2024-02-08 Thread Ville Syrjälä
On Wed, Feb 07, 2024 at 11:02:27PM +0200, Imre Deak wrote: > On Wed, Feb 07, 2024 at 10:48:53PM +0200, Imre Deak wrote: > > On Wed, Feb 07, 2024 at 10:02:18PM +0200, Ville Syrjälä wrote: > > > > [...] > > > > +static int > > > > +drm_dp_tunnel_atomic_check_group_bw(struct drm_dp_tunnel_group_state

[PATCH 13/13] drm/i915/dvo: Use sizeof(*variable) instead of sizeof(type)

2024-02-08 Thread Ville Syrjala
From: Ville Syrjälä Prefer sizeof(*variable) to sizeof(type) to make it a bit harder to screw things up. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/dvo_ch7017.c | 2 +- drivers/gpu/drm/i915/display/dvo_ch7xxx.c | 2 +- drivers/gpu/drm/i915/display/dvo_ivch.c | 2 +-

[PATCH 12/13] drm/i915/dvo/ns2501: Nuke pointless casts

2024-02-08 Thread Ville Syrjala
From: Ville Syrjälä The dvo 'dev_priv' is void* so no need for and explicit cast. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/dvo_ns2501.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/display/dvo_ns2501.c

[PATCH 11/13] drm/i915/wm: Use per-device debugs ilk wm code

2024-02-08 Thread Ville Syrjala
From: Ville Syrjälä Switch to drm_dbg_kms() in the ilk wm code so we see which device generated the debugs. Need to plumb i915 a bit deeper to make that happen. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/i9xx_wm.c | 26 +++--- 1 file changed, 15

[PATCH 10/13] drm/i915/wm: Use per-device debugs in pre-ilk wm code

2024-02-08 Thread Ville Syrjala
From: Ville Syrjälä Switch to drm_dbg_kms() in the pre-ilk wm code so we see which device generated the debugs. Need to plumb i915 a bit deeper to make that happen. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/i9xx_wm.c | 28 -- 1 file changed, 17

[PATCH 09/13] drm/i915/wm: Pass the whole i916 to intel_get_cxsr_latency()

2024-02-08 Thread Ville Syrjala
From: Ville Syrjälä Just pass the whole i915 to intel_get_cxsr_latency() instead of having each caller dig out bits and pieces. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/i9xx_wm.c | 27 ++ 1 file changed, 10 insertions(+), 17 deletions(-) diff

[PATCH 08/13] drm/i915/hdcp: Use per-device debugs

2024-02-08 Thread Ville Syrjala
From: Ville Syrjälä Switch to per-device debugs in the hdcp code so we see at least which device is involved. Should proably also print the connector/encoder/etc. in there, but left that for the future. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_dp_hdcp.c | 12

[PATCH 07/13] drm/i915/bios: Use per-device debugs for VBT related stuff

2024-02-08 Thread Ville Syrjala
From: Ville Syrjälä Switch to drm_dbg_kms() in the VBT code so we see which device generated the debugs. Need to plumb i915 a bit deeper to make that happen. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_bios.c | 73 ++-

[PATCH 05/13] drm/i915/fb: Use per-device debugs

2024-02-08 Thread Ville Syrjala
From: Ville Syrjälä Switch to drm_dbg_kms() in the fb code so we see which device generated the debugs. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_fb.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_fb.c

[PATCH 06/13] drm/i915/bios: Switch to kms debugs

2024-02-08 Thread Ville Syrjala
From: Ville Syrjälä The VBT code is all about displays, so switch to UT_KMS debugs from UT_DRIVER. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_bios.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git

[PATCH 04/13] drm/i915/color: Use per-device debugs

2024-02-08 Thread Ville Syrjala
From: Ville Syrjälä Switch to drm_dbg_kms() in the LUT validation code so we see which device generated the debugs. Need to plumb i915 a bit deeper to make that happen. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_color.c | 11 ++- 1 file changed, 6

[PATCH 03/13] drm/i915/sdvo: Fix up code alignment

2024-02-08 Thread Ville Syrjala
From: Ville Syrjälä Realign a bunch of code that has become messy. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_sdvo.c | 104 +++--- 1 file changed, 52 insertions(+), 52 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_sdvo.c

[PATCH 01/13] drm/i915: Correct for_each_old_global_obj_in_state() arguments

2024-02-08 Thread Ville Syrjala
From: Ville Syrjälä for_each_old_global_obj_in_state() gives us the old state, not the new state. Correct the name of the macro argument. Note that while the argument was misnamed the macro did work correctly regardless. Signed-off-by: Ville Syrjälä ---

[PATCH 02/13] drm/i915/sdvo: Convert to per-device debugs

2024-02-08 Thread Ville Syrjala
From: Ville Syrjälä Use drm_dbg_kms() instead of DRM_DEBUG_KMS() in the sdvo code to get the device name into the debug prints. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_sdvo.c | 113 +- 1 file changed, 66 insertions(+), 47 deletions(-) diff

[PATCH 00/13] drm/i915: drm_dbg_kms() conversions and cleanups

2024-02-08 Thread Ville Syrjala
From: Ville Syrjälä Convert a bunch of lingering DRM_DEBUG_KMS() & co. to the per-device drm_dbg_kms() variants. The stuff remining after this are DVO encoder drivers, DMI match functions, and ACPI/DSM stuff. And also include a bit of other house cleaning I spotted. Ville Syrjälä (13):

Re: [PATCH v2] drm/i915: Add GuC submission interface version query

2024-02-08 Thread Tvrtko Ursulin
On 08/02/2024 14:30, Souza, Jose wrote: On Thu, 2024-02-08 at 08:25 +, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Add a new query to the GuC submission interface version. Mesa intends to use this information to check for old firmware versions with a known bug where using the render and

Re: [PATCH] drm/buddy: Fix alloc_range() error handling code

2024-02-08 Thread Matthew Auld
On 08/02/2024 14:17, Matthew Auld wrote: On 08/02/2024 13:47, Arunpravin Paneer Selvam wrote: Hi Matthew, On 2/8/2024 7:00 PM, Matthew Auld wrote: On 07/02/2024 17:44, Arunpravin Paneer Selvam wrote: Few users have observed display corruption when they boot the machine to KDE Plasma or

Re: [PATCH v2] drm/i915: Add GuC submission interface version query

2024-02-08 Thread Souza, Jose
On Thu, 2024-02-08 at 08:25 +, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > Add a new query to the GuC submission interface version. > > Mesa intends to use this information to check for old firmware versions > with a known bug where using the render and compute command streamers >

Re: [PATCH] drm/buddy: Fix alloc_range() error handling code

2024-02-08 Thread Matthew Auld
On 08/02/2024 13:47, Arunpravin Paneer Selvam wrote: Hi Matthew, On 2/8/2024 7:00 PM, Matthew Auld wrote: On 07/02/2024 17:44, Arunpravin Paneer Selvam wrote: Few users have observed display corruption when they boot the machine to KDE Plasma or playing games. We have root caused the problem

RE: [PATCH] drm/i915/selftests: Increasing the sleep time for live_rc6_manual

2024-02-08 Thread Gupta, Anshuman
> -Original Message- > From: Anirban, Sk > Sent: Thursday, February 8, 2024 5:04 PM > To: intel-gfx@lists.freedesktop.org > Cc: Gupta, Anshuman ; Poosa, Karthik > ; Anirban, Sk > Subject: [PATCH] drm/i915/selftests: Increasing the sleep time for > Sometimes gt_pm live_rc6_manual

Re: [PATCH] drm/buddy: Fix alloc_range() error handling code

2024-02-08 Thread Mario Limonciello
On 2/8/2024 06:06, Arunpravin Paneer Selvam wrote: Hi Christian, On 2/8/2024 12:27 PM, Christian König wrote: Am 07.02.24 um 18:44 schrieb Arunpravin Paneer Selvam: Few users have observed display corruption when they boot the machine to KDE Plasma or playing games. We have root caused the

Re: [PATCH] drm/buddy: Fix alloc_range() error handling code

2024-02-08 Thread Arunpravin Paneer Selvam
Hi Matthew, On 2/8/2024 7:00 PM, Matthew Auld wrote: On 07/02/2024 17:44, Arunpravin Paneer Selvam wrote: Few users have observed display corruption when they boot the machine to KDE Plasma or playing games. We have root caused the problem that whenever alloc_range() couldn't find the required

Re: [PATCH] drm/buddy: Fix alloc_range() error handling code

2024-02-08 Thread Matthew Auld
On 07/02/2024 17:44, Arunpravin Paneer Selvam wrote: Few users have observed display corruption when they boot the machine to KDE Plasma or playing games. We have root caused the problem that whenever alloc_range() couldn't find the required memory blocks the function was returning SUCCESS in

[PULL] drm-intel-fixes

2024-02-08 Thread Joonas Lahtinen
Hi Dave & Sima, Here goes drm-intel-fixes, which is just the gvt-fixes PR for this week. Regards, Joonas *** drm-intel-fixes-2024-02-08: - Just includes gvt-fixes-2024-02-05 The following changes since commit 54be6c6c5ae8e0d93a6c4641cb7528eb0b6ba478: Linux 6.8-rc3 (2024-02-04 12:20:36

Re: [PATCH] drm/buddy: Fix alloc_range() error handling code

2024-02-08 Thread Arunpravin Paneer Selvam
Hi Christian, On 2/8/2024 12:27 PM, Christian König wrote: Am 07.02.24 um 18:44 schrieb Arunpravin Paneer Selvam: Few users have observed display corruption when they boot the machine to KDE Plasma or playing games. We have root caused the problem that whenever alloc_range() couldn't find the

[PULL] drm-misc-fixes

2024-02-08 Thread Maxime Ripard
Hi, Here's this week drm-misc-fixes PR Maxime drm-misc-fixes-2024-02-08: A null pointer dereference fix for v3d, a TTM pool initialization fix, several fixes for nouveau around register size, DMA buffer leaks and API consistency, a multiple fixes for ivpu around MMU setup, initialization and

[PATCH v2 1/2] drm/i915: Prevent HW access during init from SDVO TV get_modes hook

2024-02-08 Thread Imre Deak
Prevent accessing the HW from the SDVO/TV get_modes connector hook. Returning 0 from the hook will make the caller - drm_helper_probe_single_connector_modes() - return a default/EDID override mode list to users. This matches the case where intel_sdvo_get_tv_modes() fails to retrieve the current

[PATCH] drm/i915/selftests: Increasing the sleep time for live_rc6_manual

2024-02-08 Thread Sk Anirban
From: Anirban Sk To rule out the sporadic failure, updating the sleep time (time period to measure the power). Signed-off-by: Anirban Sk --- drivers/gpu/drm/i915/gt/selftest_rc6.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/gt/selftest_rc6.c

[PULL] drm-xe-fixes

2024-02-08 Thread Thomas Hellstrom
Dave, Sima The drm-xe-fixes pull for -rc4. Thanks, Thomas drm-xe-fixes-2024-02-08: Driver Changes: - Fix a loop in an error path - Fix a missing dma-fence reference - Fix a retry path on userptr REMAP - Workaround for a false gcc warning - Fix missing map of the usm batch buffer in the

Re: [PATCH v3] drm/i915/dsc: Fix the macro that calculates DSCC_/DSCA_ PPS reg address

2024-02-08 Thread Jani Nikula
On Mon, 05 Feb 2024, Manasi Navare wrote: > Commit bd077259d0a9 ("drm/i915/vdsc: Add function to read any PPS register") > defines > a new macro to calculate the DSC PPS register addresses with PPS number as an > input. This macro correctly calculates the addresses till PPS 11 since the >

Re: [PATCH 1/1] drm/i915/display: On Xe2 always enable decompression with tile4

2024-02-08 Thread Jani Nikula
On Fri, 02 Feb 2024, Juha-Pekka Heikkila wrote: > With Xe2 always treat tile4 as if it was using flat ccs. > > Signed-off-by: Juha-Pekka Heikkila > Reviewed-by: Mika Kahola > --- > drivers/gpu/drm/i915/display/skl_universal_plane.c | 5 + > 1 file changed, 5 insertions(+) > > diff --git

Re: ✗ Fi.CI.IGT: failure for Enable ccs compressed framebuffers on Xe2 (rev5)

2024-02-08 Thread Juha-Pekka Heikkila
these reported regressions have nothing to do with my changes On 6.2.2024 4.14, Patchwork wrote: *Patch Details* *Series:* Enable ccs compressed framebuffers on Xe2 (rev5) *URL:* https://patchwork.freedesktop.org/series/129471/ *State:*

✗ Fi.CI.BAT: failure for drm/i915: Add GuC submission interface version query (rev2)

2024-02-08 Thread Patchwork
== Series Details == Series: drm/i915: Add GuC submission interface version query (rev2) URL : https://patchwork.freedesktop.org/series/129627/ State : failure == Summary == CI Bug Log - changes from CI_DRM_14241 -> Patchwork_129627v2

Re: [PATCH v2 2/4] eventfd: simplify eventfd_signal()

2024-02-08 Thread Christian Brauner
On Wed, Feb 07, 2024 at 03:34:59PM +0100, Paolo Bonzini wrote: > On Wed, Nov 22, 2023 at 1:49 PM Christian Brauner wrote: > > > > Ever since the evenfd type was introduced back in 2007 in commit > > e1ad7468c77d ("signal/timer/event: eventfd core") the eventfd_signal() > > function only ever

RE: [PATCH 2/2] drm/i915/lnl: Program PKGC_LATENCY register

2024-02-08 Thread Jani Nikula
On Mon, 05 Feb 2024, "Kandpal, Suraj" wrote: >> On Mon, 05 Feb 2024, Suraj Kandpal wrote: >> > + if (wm_latency[i] == 0) >> > + break; >> > + else if (wm_latency[i] > max_value) >> > + max_value = wm_latency[i]; >> > + } >> > + >> > + if

✗ Fi.CI.SPARSE: warning for drm/i915: Add GuC submission interface version query (rev2)

2024-02-08 Thread Patchwork
== Series Details == Series: drm/i915: Add GuC submission interface version query (rev2) URL : https://patchwork.freedesktop.org/series/129627/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

✗ Fi.CI.CHECKPATCH: warning for drm/i915: Add GuC submission interface version query (rev2)

2024-02-08 Thread Patchwork
== Series Details == Series: drm/i915: Add GuC submission interface version query (rev2) URL : https://patchwork.freedesktop.org/series/129627/ State : warning == Summary == Error: dim checkpatch failed ce49f663d199 drm/i915: Add GuC submission interface version query -:90:

Re: [PATCH v3 3/3] drm/i915: Convert REG_GENMASK* to fixed-width GENMASK_*

2024-02-08 Thread Jani Nikula
On Wed, 07 Feb 2024, Lucas De Marchi wrote: > Now that include/linux/bits.h implements fixed-width GENMASK_*, use them > to implement the i915/xe specific macros. Converting each driver to use > the generic macros are left for later, when/if other driver-specific > macros are also generalized. >

Re: [RFC] drm/i915: Add GuC submission interface version query

2024-02-08 Thread Tvrtko Ursulin
On 07/02/2024 19:34, John Harrison wrote: On 2/7/2024 10:49, Tvrtko Ursulin wrote: On 07/02/2024 18:12, John Harrison wrote: On 2/7/2024 03:56, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Add a new query to the GuC submission interface version. Mesa intends to use this information to

✓ Fi.CI.BAT: success for Fixed-type GENMASK/BIT (rev2)

2024-02-08 Thread Patchwork
== Series Details == Series: Fixed-type GENMASK/BIT (rev2) URL : https://patchwork.freedesktop.org/series/129116/ State : success == Summary == CI Bug Log - changes from CI_DRM_14241 -> Patchwork_129116v2 Summary --- **SUCCESS**

✗ Fi.CI.CHECKPATCH: warning for Fixed-type GENMASK/BIT (rev2)

2024-02-08 Thread Patchwork
== Series Details == Series: Fixed-type GENMASK/BIT (rev2) URL : https://patchwork.freedesktop.org/series/129116/ State : warning == Summary == Error: dim checkpatch failed 0a7165f6a0f1 bits: introduce fixed-type genmasks -:72: CHECK:MACRO_ARG_REUSE: Macro argument reuse 't' - possible

✗ Fi.CI.SPARSE: warning for Fixed-type GENMASK/BIT (rev2)

2024-02-08 Thread Patchwork
== Series Details == Series: Fixed-type GENMASK/BIT (rev2) URL : https://patchwork.freedesktop.org/series/129116/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[PATCH v2] drm/i915: Add GuC submission interface version query

2024-02-08 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Add a new query to the GuC submission interface version. Mesa intends to use this information to check for old firmware versions with a known bug where using the render and compute command streamers simultaneously can cause GPU hangs due issues in firmware scheduling.