✗ Fi.CI.IGT: failure for drm/i915/cdclk: Rename intel_cdclk_needs_modeset to intel_cdclk_clock_changed

2024-02-14 Thread Patchwork
== Series Details == Series: drm/i915/cdclk: Rename intel_cdclk_needs_modeset to intel_cdclk_clock_changed URL : https://patchwork.freedesktop.org/series/129908/ State : failure == Summary == CI Bug Log - changes from CI_DRM_14274_full -> Patchwork_129908v1_full

✓ Fi.CI.BAT: success for XE HDCP Enablement (rev5)

2024-02-14 Thread Patchwork
== Series Details == Series: XE HDCP Enablement (rev5) URL : https://patchwork.freedesktop.org/series/129456/ State : success == Summary == CI Bug Log - changes from CI_DRM_14276 -> Patchwork_129456v5 Summary --- **SUCCESS** No

✗ Fi.CI.SPARSE: warning for XE HDCP Enablement (rev5)

2024-02-14 Thread Patchwork
== Series Details == Series: XE HDCP Enablement (rev5) URL : https://patchwork.freedesktop.org/series/129456/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. - +./arch/x86/include/asm/bitops.h:116:1:

Re: [PATCH 10/12] drm/i915/hdcp: Don't enable HDCP directly from check_link

2024-02-14 Thread Nautiyal, Ankit K
On 2/15/2024 10:35 AM, Suraj Kandpal wrote: Whenever LIC fails instead of moving from ENABLED to DESIRED CP property we directly enable HDCP without informing the userspace of this failure in link integrity check. Now we will just update the value to DESIRED send the event to userspace and

[PATCH 4/5] drm/xe/hdcp: Enable HDCP for XE

2024-02-14 Thread Suraj Kandpal
Enable HDCP for Xe by defining functions which take care of interaction of HDCP as a client with the GSC CS interface. --v2 -add kfree at appropriate place [Daniele] -remove useless define [Daniele] -move host session logic to xe_gsc_submit.c [Daniele] -call xe_gsc_check_and_update_pending

✓ Fi.CI.BAT: success for HDCP MST Type1 fixes

2024-02-14 Thread Patchwork
== Series Details == Series: HDCP MST Type1 fixes URL : https://patchwork.freedesktop.org/series/129925/ State : success == Summary == CI Bug Log - changes from CI_DRM_14276 -> Patchwork_129925v1 Summary --- **SUCCESS** No

✗ Fi.CI.SPARSE: warning for HDCP MST Type1 fixes

2024-02-14 Thread Patchwork
== Series Details == Series: HDCP MST Type1 fixes URL : https://patchwork.freedesktop.org/series/129925/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. +./arch/x86/include/asm/bitops.h:116:1: warning:

[PATCH 12/12] drm/i915/hdcp: Read Rxcaps for robustibility

2024-02-14 Thread Suraj Kandpal
We see some monitors and docks report incorrect hdcp version and capability in first few reads so we read rx_caps three times before we conclude the monitor's or docks HDCP capability --v2 -Add comment to justify the 3 time read loop for hdcp capability[Ankit] Signed-off-by: Suraj Kandpal

[PATCH 11/12] drm/i915/hdcp: Allocate stream id after HDCP AKE stage

2024-02-14 Thread Suraj Kandpal
Allocate stream id after HDCP AKE stage and not before so that it can also be done during link integrity check. Right now for MST scenarios LIC fails after hdcp enablement for this reason. Signed-off-by: Suraj Kandpal --- drivers/gpu/drm/i915/display/intel_hdcp.c | 126 +++--- 1

[PATCH 10/12] drm/i915/hdcp: Don't enable HDCP directly from check_link

2024-02-14 Thread Suraj Kandpal
Whenever LIC fails instead of moving from ENABLED to DESIRED CP property we directly enable HDCP without informing the userspace of this failure in link integrity check. Now we will just update the value to DESIRED send the event to userspace and then continue with the normal flow of HDCP

[PATCH 07/12] drm/i915/hdcp: HDCP Capability for the downstream device

2024-02-14 Thread Suraj Kandpal
Currently we are only checking capability of remote device and not immediate downstream device but during capability check we need are concerned with only the HDCP capability of downstream device. During i915_display_info reporting we need HDCP Capability for both the monitors and downstream

[PATCH 09/12] drm/i915/hdcp: Extract hdcp structure from correct connector

2024-02-14 Thread Suraj Kandpal
Currently intel_hdcp is not being extracted from primary connector this patch fixes that. Fixes: 524240b231ea ("drm/i915/hdcp: Propagate aux info in DP HDCP functions") Signed-off-by: Suraj Kandpal Reviewed-by: Ankit Nautiyal --- drivers/gpu/drm/i915/display/intel_dp_hdcp.c | 7 +-- 1 file

[PATCH 08/12] drm/i915/hdcp: Remove additional timing for reading mst hdcp message

2024-02-14 Thread Suraj Kandpal
Now that we have moved back to direct reads the additional timing is not required hence this can be removed. --v2 -Add Fixes tag [Ankit] Fixes: 3974f9c17bb9 ("drm/i915/hdcp: Adjust timeout for read in DPMST Scenario") Signed-off-by: Suraj Kandpal Reviewed-by: Ankit Nautiyal ---

[PATCH 06/12] drm/i915/hdcp: Add new remote capability check shim function

2024-02-14 Thread Suraj Kandpal
Create a remote HDCP capability shim function which can read the remote monitor HDCP capability when in MST configuration. --v2 -Add an assertion to make sure only mst encoder call this remote_cap function [Ankit] --v3 -rename remote_hdcp_cap to remote_hdcp_capability [Jani] Signed-off-by:

[PATCH 05/12] drm/i915/hdcp: Rename hdcp capable functions

2024-02-14 Thread Suraj Kandpal
Rename hdcp_capable and hdcp_2_2_capable to hdcp_get_capability and hdcp_2_2_get_capability to properly reflect what these functions are doing. Signed-off-by: Suraj Kandpal --- .../drm/i915/display/intel_display_debugfs.c | 4 ++-- .../drm/i915/display/intel_display_types.h| 8 +++

[PATCH 04/12] drm/i915/hdcp: Pass drm_dp_aux to read_bcaps function

2024-02-14 Thread Suraj Kandpal
Pass drm_dp_aux to intel_dp_hdcp_read_bcaps function so as to aid in reading the bcaps for the remote monitor later on. Signed-off-by: Suraj Kandpal Reviewed-by: Ankit Nautiyal --- drivers/gpu/drm/i915/display/intel_dp_hdcp.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-)

[PATCH 03/12] drm/i915/hdcp: Refactor intel_dp_hdcp2_capable

2024-02-14 Thread Suraj Kandpal
Break intel_dp_hdcp2_capable so that the common the code can be reused for the remote capability check. Signed-off-by: Suraj Kandpal Reviewed-by: Ankit Nautiyal --- drivers/gpu/drm/i915/display/intel_dp_hdcp.c | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git

[PATCH 01/12] drm/i915/hdcp: Move to direct reads for HDCP

2024-02-14 Thread Suraj Kandpal
Even for MST scenarios we need to do direct reads only on the immediate downstream device the rest of the authentication is taken care by that device. Remote reads will only be used to check capability of the monitors in MST topology. --v2 -Add fixes tag [Ankit] -Derive aux where needed rather

[PATCH 02/12] drm/i915/hdcp: Move source hdcp2 checks into its own function

2024-02-14 Thread Suraj Kandpal
Move checks on the source side for HDCP2.2 into its own function so that they can be used in the HDCP remote capability check function. Signed-off-by: Suraj Kandpal Reviewed-by: Ankit Nautiyal --- drivers/gpu/drm/i915/display/intel_hdcp.c | 20 +--- 1 file changed, 17

[PATCH 00/12] HDCP MST Type1 fixes

2024-02-14 Thread Suraj Kandpal
We were seeing a blank screen whenever Type1 content was played. This was due to extra timing which was taken as we had moved to remote read and writes previously for MST scenario, which in turn was done as we were not able to do direct read and writes to the immediate downstream device. The

✗ Fi.CI.IGT: failure for drm/i915: Update ADL-N PCI IDs

2024-02-14 Thread Patchwork
== Series Details == Series: drm/i915: Update ADL-N PCI IDs URL : https://patchwork.freedesktop.org/series/129901/ State : failure == Summary == CI Bug Log - changes from CI_DRM_14273_full -> Patchwork_129901v1_full Summary ---

Re: [PATCH 2/2] i915/pmu: Cleanup pending events on unbind

2024-02-14 Thread kernel test robot
Hi Umesh, kernel test robot noticed the following build warnings: [auto build test WARNING on drm-intel/for-linux-next] [also build test WARNING on drm-intel/for-linux-next-fixes drm-tip/drm-tip linus/master v6.8-rc4 next-20240214] [If your patch is applied to the wrong git tree, kindly drop us

[CI] PR for new GuC v70.20.0

2024-02-14 Thread John . C . Harrison
The following changes since commit fbef4d381e3d0143427e1a8c924be8e738c0fc2d: Merge branch 'main' into 'main' (2024-02-08 12:24:01 +) are available in the Git repository at: git://anongit.freedesktop.org/drm/drm-firmware guc_70.20.0_with_pvc for you to fetch changes up to

Re: [PATCH 4/5] drm/i915: Add PLL .compare_hw_state() vfunc

2024-02-14 Thread Ville Syrjälä
On Tue, Feb 13, 2024 at 04:15:00PM +, Kahola, Mika wrote: > > -Original Message- > > From: Intel-gfx On Behalf Of > > Ville Syrjala > > Sent: Friday, February 9, 2024 8:38 PM > > To: intel-gfx@lists.freedesktop.org > > Subject: [PATCH 4/5] drm/i915: Add PLL .compare_hw_state() vfunc

Re: PR for new GuC v70.19.2

2024-02-14 Thread John Harrison
Hello, Please disregard this pull request if hasn't already been processed. We need to send out an update to bump to a newer version. Thanks, John. On 2/1/2024 17:12, john.c.harri...@intel.com wrote: The following changes since commit 1a9518c73c4b54854c9cd8f416fd3b8f8e3456e7: Merge

✗ Fi.CI.SPARSE: warning for Add support for getting EDID over ACPI to DRM

2024-02-14 Thread Patchwork
== Series Details == Series: Add support for getting EDID over ACPI to DRM URL : https://patchwork.freedesktop.org/series/129920/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

Re: [PATCH v6 3/5] drm: Add support to get EDID from ACPI

2024-02-14 Thread Ville Syrjälä
On Wed, Feb 14, 2024 at 03:57:54PM -0600, Mario Limonciello wrote: > Some manufacturers have intentionally put an EDID that differs from > the EDID on the internal panel on laptops. Drivers that prefer to > fetch this EDID can set a bit on the drm_connector to indicate that > the DRM EDID helpers

✓ Fi.CI.BAT: success for drm/i915/cdclk: Rename intel_cdclk_needs_modeset to intel_cdclk_clock_changed

2024-02-14 Thread Patchwork
== Series Details == Series: drm/i915/cdclk: Rename intel_cdclk_needs_modeset to intel_cdclk_clock_changed URL : https://patchwork.freedesktop.org/series/129908/ State : success == Summary == CI Bug Log - changes from CI_DRM_14274 -> Patchwork_129908v1

✗ Fi.CI.SPARSE: warning for drm/i915/cdclk: Rename intel_cdclk_needs_modeset to intel_cdclk_clock_changed

2024-02-14 Thread Patchwork
== Series Details == Series: drm/i915/cdclk: Rename intel_cdclk_needs_modeset to intel_cdclk_clock_changed URL : https://patchwork.freedesktop.org/series/129908/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked

[PATCH v6 4/5] drm/amd: Fetch the EDID from _DDC if available for eDP

2024-02-14 Thread Mario Limonciello
Some manufacturers have intentionally put an EDID that differs from the EDID on the internal panel on laptops. Attempt to fetch this EDID if it exists and prefer it over the EDID that is provided by the panel. If a user prefers to use the EDID from the panel, offer a module parameter that would

[PATCH v6 5/5] drm/nouveau: Use drm_edid_read_acpi() helper

2024-02-14 Thread Mario Limonciello
Rather than inventing a wrapper to acpi_video_get_edid() use the one provided by drm. This fixes two problems: 1. A memory leak that the memory provided by the ACPI call was never freed. 2. Validation of the BIOS provided blob. Convert the usage in nouveau_connector_detect_lvds() to use struct

[PATCH v6 1/5] drm: Stop using `select ACPI_VIDEO` in all drivers

2024-02-14 Thread Mario Limonciello
Many DRM drivers (ab)use `select ACPI_VIDEO` and to avoid problems will then select all the dependencies for ACPI_VIDEO. This creates a soft dependency, but makes it very hard to use ACPI_VIDEO in DRM core. Switch everything else over to use `depends on ACPI_VIDEO` instead. Signed-off-by: Mario

[PATCH v6 3/5] drm: Add support to get EDID from ACPI

2024-02-14 Thread Mario Limonciello
Some manufacturers have intentionally put an EDID that differs from the EDID on the internal panel on laptops. Drivers that prefer to fetch this EDID can set a bit on the drm_connector to indicate that the DRM EDID helpers should try to fetch it and it is preferred if it's present.

[PATCH v6 2/5] drm: Stop using `select BACKLIGHT_CLASS_DEVICE`

2024-02-14 Thread Mario Limonciello
Many drivers ab(use) `select BACKLIGHT_CLASS_DEVICE` to avoid dependency problems. This however makes it impossible for DRM core to be able to add a dependency on ACPI_VIDEO. Switch users of `select BACKLIGHT_CLASS_DEVICE` to `depends on BACKLIGHT_CLASS_DEVICE`. Signed-off-by: Mario Limonciello

[PATCH v6 0/5] Add support for getting EDID over ACPI to DRM

2024-02-14 Thread Mario Limonciello
This series adds the ability to fetch the EDID through ACPI for laptop panels. Drivers need to opt into the behavior. In this series it's enabled by default for all eDP or LVDS panels with AMDGPU and certain panels for Nouveau. Mario Limonciello (5): drm: Stop using `select ACPI_VIDEO` in all

Re: [PATCH] drm/i915: Update ADL-N PCI IDs

2024-02-14 Thread Matt Roper
On Wed, Feb 14, 2024 at 03:05:42PM +, Bhadane, Dnyaneshwar wrote: > > > > -Original Message- > > From: Intel-gfx On Behalf Of > > Gustavo Sousa > > Sent: Wednesday, February 14, 2024 8:17 PM > > To: intel-gfx@lists.freedesktop.org > > Subject: [PATCH] drm/i915: Update ADL-N PCI IDs

Re: [PATCH] drm/i915/cdclk: Rename intel_cdclk_needs_modeset to intel_cdclk_clock_changed

2024-02-14 Thread Ville Syrjälä
On Wed, Feb 14, 2024 at 05:27:20PM -0300, Gustavo Sousa wrote: > Looks like the name and description of intel_cdclk_needs_modeset() > became inaccurate as of commit 59f9e9cab3a1 ("drm/i915: Skip modeset for > cdclk changes if possible"), when it became possible to update the cdclk > without

Re: [PATCH] drm/i915/cdclk: Rename intel_cdclk_needs_modeset to intel_cdclk_params_changed

2024-02-14 Thread Gustavo Sousa
Quoting Ville Syrjälä (2024-02-14 17:15:51-03:00) >On Wed, Feb 14, 2024 at 05:08:48PM -0300, Gustavo Sousa wrote: >> Quoting Gustavo Sousa (2024-02-03 10:32:18-03:00) >> >Quoting Ville Syrjälä (2024-02-02 17:06:02-03:00) >> >>On Fri, Feb 02, 2024 at 09:58:37PM +0200, Ville Syrjälä wrote: >> >>> On

[PATCH] drm/i915/cdclk: Rename intel_cdclk_needs_modeset to intel_cdclk_clock_changed

2024-02-14 Thread Gustavo Sousa
Looks like the name and description of intel_cdclk_needs_modeset() became inaccurate as of commit 59f9e9cab3a1 ("drm/i915: Skip modeset for cdclk changes if possible"), when it became possible to update the cdclk without requiring disabling the pipes when only changing the cd2x divider was enough.

✓ Fi.CI.BAT: success for drm/i915: Update ADL-N PCI IDs

2024-02-14 Thread Patchwork
== Series Details == Series: drm/i915: Update ADL-N PCI IDs URL : https://patchwork.freedesktop.org/series/129901/ State : success == Summary == CI Bug Log - changes from CI_DRM_14273 -> Patchwork_129901v1 Summary --- **SUCCESS**

Re: [PATCH] drm/i915/cdclk: Rename intel_cdclk_needs_modeset to intel_cdclk_params_changed

2024-02-14 Thread Ville Syrjälä
On Wed, Feb 14, 2024 at 05:08:48PM -0300, Gustavo Sousa wrote: > Quoting Gustavo Sousa (2024-02-03 10:32:18-03:00) > >Quoting Ville Syrjälä (2024-02-02 17:06:02-03:00) > >>On Fri, Feb 02, 2024 at 09:58:37PM +0200, Ville Syrjälä wrote: > >>> On Fri, Feb 02, 2024 at 10:12:08AM -0300, Gustavo Sousa

Re: [PATCH] drm/i915/cdclk: Rename intel_cdclk_needs_modeset to intel_cdclk_params_changed

2024-02-14 Thread Gustavo Sousa
Quoting Gustavo Sousa (2024-02-03 10:32:18-03:00) >Quoting Ville Syrjälä (2024-02-02 17:06:02-03:00) >>On Fri, Feb 02, 2024 at 09:58:37PM +0200, Ville Syrjälä wrote: >>> On Fri, Feb 02, 2024 at 10:12:08AM -0300, Gustavo Sousa wrote: >>> > Looks like the name and description of

Re: [PATCH] drm/i915/cdclk: Rename intel_cdclk_needs_modeset to intel_cdclk_params_changed

2024-02-14 Thread Ville Syrjälä
On Wed, Feb 14, 2024 at 04:56:50PM -0300, Gustavo Sousa wrote: > Hi, Ville. > > Sorry for taking long to get back to this. > > Quoting Ville Syrjälä (2024-02-05 12:34:57-03:00) > >On Sat, Feb 03, 2024 at 10:25:18AM -0300, Gustavo Sousa wrote: > >> Quoting Ville Syrjälä (2024-02-02

Re: [PATCH] drm/i915/cdclk: Rename intel_cdclk_needs_modeset to intel_cdclk_params_changed

2024-02-14 Thread Gustavo Sousa
Hi, Ville. Sorry for taking long to get back to this. Quoting Ville Syrjälä (2024-02-05 12:34:57-03:00) >On Sat, Feb 03, 2024 at 10:25:18AM -0300, Gustavo Sousa wrote: >> Quoting Ville Syrjälä (2024-02-02 16:58:37-03:00) >> >On Fri, Feb 02, 2024 at 10:12:08AM -0300, Gustavo Sousa wrote: >> >>

✗ Fi.CI.BAT: failure for series starting with [v2,1/2] drm/buddy: Fix alloc_range() error handling code

2024-02-14 Thread Patchwork
== Series Details == Series: series starting with [v2,1/2] drm/buddy: Fix alloc_range() error handling code URL : https://patchwork.freedesktop.org/series/129895/ State : failure == Summary == CI Bug Log - changes from CI_DRM_14273 -> Patchwork_129895v1

✗ Fi.CI.SPARSE: warning for series starting with [v2,1/2] drm/buddy: Fix alloc_range() error handling code

2024-02-14 Thread Patchwork
== Series Details == Series: series starting with [v2,1/2] drm/buddy: Fix alloc_range() error handling code URL : https://patchwork.freedesktop.org/series/129895/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2

Re: [PATCH 2/2] i915/pmu: Cleanup pending events on unbind

2024-02-14 Thread Umesh Nerlige Ramappa
On Wed, Feb 14, 2024 at 08:21:21AM +, Tvrtko Ursulin wrote: On 13/02/2024 18:03, Umesh Nerlige Ramappa wrote: Once a user opens an fd for a perf event, if the driver undergoes a function level reset (FLR), the resources are not cleaned up as expected. For this discussion FLR is defined as

Re: [PATCH] drm/dp: move intel_dp_vsc_sdp_pack() to generic helper

2024-02-14 Thread Dmitry Baryshkov
On Wed, 14 Feb 2024 at 20:08, Abhinav Kumar wrote: > > > > On 2/14/2024 10:02 AM, Ville Syrjälä wrote: > > On Wed, Feb 14, 2024 at 09:17:34AM -0800, Abhinav Kumar wrote: > >> > >> > >> On 2/14/2024 12:15 AM, Dmitry Baryshkov wrote: > >>> On Wed, 14 Feb 2024 at 01:45, Abhinav Kumar > >>> wrote:

Re: [PATCH v2 4/6] drm/i915/mst: use the MST mode detected previously

2024-02-14 Thread Jani Nikula
On Wed, 14 Feb 2024, Ville Syrjälä wrote: > On Tue, Feb 13, 2024 at 01:30:59PM +0200, Jani Nikula wrote: >> Drop the duplicate read of DP_MSTM_CAP DPCD register, and the duplicate >> logic for choosing MST mode, and store the chosen mode in struct >> intel_dp. Rename intel_dp_configure_mst() to

Re: [PATCH v2 5/6] drm/i915/mst: add intel_dp_mst_disconnect()

2024-02-14 Thread Ville Syrjälä
On Tue, Feb 13, 2024 at 01:31:00PM +0200, Jani Nikula wrote: > Abstract the MST mode disconnect to a separate function. > > Cc: Arun R Murthy > Cc: Ville Syrjälä > Signed-off-by: Jani Nikula Reviewed-by: Ville Syrjälä > --- > drivers/gpu/drm/i915/display/intel_dp.c | 24

Re: [PATCH v2 4/6] drm/i915/mst: use the MST mode detected previously

2024-02-14 Thread Ville Syrjälä
On Tue, Feb 13, 2024 at 01:30:59PM +0200, Jani Nikula wrote: > Drop the duplicate read of DP_MSTM_CAP DPCD register, and the duplicate > logic for choosing MST mode, and store the chosen mode in struct > intel_dp. Rename intel_dp_configure_mst() to intel_dp_mst_configure() > while at it. > > Cc:

Re: [PATCH v2 3/6] drm/i915/mst: abstract choosing the MST mode to use

2024-02-14 Thread Ville Syrjälä
On Tue, Feb 13, 2024 at 01:30:58PM +0200, Jani Nikula wrote: > Clarify the conditions for choosing the MST mode to use by adding a new > function intel_dp_mst_mode_choose(). This also prepares for being able > to extend the MST modes to single-stream sideband messaging. > > Cc: Arun R Murthy >

Re: [PATCH v2 2/6] drm/i915/mst: improve debug logging of DP MST mode detect

2024-02-14 Thread Ville Syrjälä
On Tue, Feb 13, 2024 at 01:30:57PM +0200, Jani Nikula wrote: > Rename intel_dp_can_mst() to intel_dp_mst_detect(), and move all DP MST > detect debug logging there. Debug log the sink's MST capability, > including single-stream sideband messaging support, and the decision > whether to enable MST

Re: [PATCH v2 1/6] drm/mst: read sideband messaging cap

2024-02-14 Thread Ville Syrjälä
On Tue, Feb 13, 2024 at 01:30:56PM +0200, Jani Nikula wrote: > Amend drm_dp_read_mst_cap() to return an enum, indicating "SST", "SST > with sideband messaging", or "MST". Modify all call sites to take the > new return value into account. > > v2: > - Rename enumerators (Ville) > > Cc: Arun R

Re: [PATCH] drm/dp: move intel_dp_vsc_sdp_pack() to generic helper

2024-02-14 Thread Abhinav Kumar
On 2/14/2024 10:02 AM, Ville Syrjälä wrote: On Wed, Feb 14, 2024 at 09:17:34AM -0800, Abhinav Kumar wrote: On 2/14/2024 12:15 AM, Dmitry Baryshkov wrote: On Wed, 14 Feb 2024 at 01:45, Abhinav Kumar wrote: intel_dp_vsc_sdp_pack() can be re-used by other DRM drivers as well. Lets move

Re: [PATCH 4/5] drm/i915: Add PLL .compare_hw_state() vfunc

2024-02-14 Thread Jani Nikula
On Wed, 14 Feb 2024, Ville Syrjälä wrote: > On Wed, Feb 14, 2024 at 03:50:49PM +0200, Jani Nikula wrote: >> As follow-up, would be great to see this move towards drm_printer based >> approach, similar to pipe_config_dp_vsc_sdp_mismatch(). Reduces >> duplication. > > Why did we convert just that

Re: [PATCH] drm/dp: move intel_dp_vsc_sdp_pack() to generic helper

2024-02-14 Thread Ville Syrjälä
On Wed, Feb 14, 2024 at 09:17:34AM -0800, Abhinav Kumar wrote: > > > On 2/14/2024 12:15 AM, Dmitry Baryshkov wrote: > > On Wed, 14 Feb 2024 at 01:45, Abhinav Kumar > > wrote: > >> > >> intel_dp_vsc_sdp_pack() can be re-used by other DRM drivers as well. > >> Lets move this to drm_dp_helper to

Re: ✗ Fi.CI.IGT: failure for drm/i915/display: update pll values in sync with Bspec for MTL (rev2)

2024-02-14 Thread Matt Roper
On Wed, Feb 14, 2024 at 10:50:20AM -, Patchwork wrote: > == Series Details == > > Series: drm/i915/display: update pll values in sync with Bspec for MTL (rev2) > URL : https://patchwork.freedesktop.org/series/129878/ > State : failure > > == Summary == > > CI Bug Log - changes from

Re: [PATCH] drm/dp: move intel_dp_vsc_sdp_pack() to generic helper

2024-02-14 Thread Abhinav Kumar
On 2/14/2024 12:15 AM, Dmitry Baryshkov wrote: On Wed, 14 Feb 2024 at 01:45, Abhinav Kumar wrote: intel_dp_vsc_sdp_pack() can be re-used by other DRM drivers as well. Lets move this to drm_dp_helper to achieve this. Signed-off-by: Abhinav Kumar My preference would be to have packing

Re: [PATCH 4/5] drm/xe/hdcp: Enable HDCP for XE

2024-02-14 Thread Daniele Ceraolo Spurio
On 2/13/2024 9:33 PM, Kandpal, Suraj wrote: interaction of HDCP as a client with the GSC CS interface. --v2 -add kfree at appropriate place [Daniele] -remove useless define [Daniele] -move host session logic to xe_gsc_submit.c [Daniele] -call xe_gsc_check_and_update_pending directly in an if

Re: [RFC 1/4] drm/i915/display/dp: Add DP fallback on LT

2024-02-14 Thread Ville Syrjälä
On Wed, Feb 14, 2024 at 01:23:42PM +0200, Jani Nikula wrote: > On Wed, 14 Feb 2024, "Murthy, Arun R" wrote: > >> -Original Message- > >> From: Nikula, Jani > >> Sent: Tuesday, February 13, 2024 11:41 PM > >> To: Murthy, Arun R ; > >> intel-gfx@lists.freedesktop.org > >> Cc: Deak, Imre ;

Re: [RFC 3/4] drm/i915/dp: use link rate and lane count in intel_dp struct

2024-02-14 Thread Ville Syrjälä
On Wed, Feb 14, 2024 at 02:30:35PM +, Murthy, Arun R wrote: > > > -Original Message- > > From: Nikula, Jani > > Sent: Wednesday, February 14, 2024 5:07 PM > > To: Murthy, Arun R ; > > intel-gfx@lists.freedesktop.org > > Cc: Deak, Imre ; Syrjala, Ville > > ; > > Shankar, Uma > >

Re: [PATCH 4/5] drm/i915: Add PLL .compare_hw_state() vfunc

2024-02-14 Thread Ville Syrjälä
On Wed, Feb 14, 2024 at 03:50:49PM +0200, Jani Nikula wrote: > On Fri, 09 Feb 2024, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > Chunk up the humenguous dpll_hw_state comparison check into per-platform > > variants, implemented in the dpll_mgr. This is step one in allowing > > each

RE: [PATCH] drm/i915: Update ADL-N PCI IDs

2024-02-14 Thread Bhadane, Dnyaneshwar
> -Original Message- > From: Intel-gfx On Behalf Of > Gustavo Sousa > Sent: Wednesday, February 14, 2024 8:17 PM > To: intel-gfx@lists.freedesktop.org > Subject: [PATCH] drm/i915: Update ADL-N PCI IDs > > Extend the list of ADL-N PCI IDs to contain two new entries. > > Bspec: 68397 >

RE: [RFC 1/4] drm/i915/display/dp: Add DP fallback on LT

2024-02-14 Thread Jani Nikula
On Wed, 14 Feb 2024, "Murthy, Arun R" wrote: >> >> And with the current code, DP_CAP_ANSI_128B132B does not decide >> >> whether we use DP MST or not. So this will also cover 8b/10b fallback >> >> for displays that support 128b/132b but have DP_MSTM_CAP == 0. >> > >> > Yes, the series doent

[PATCH] drm/i915: Update ADL-N PCI IDs

2024-02-14 Thread Gustavo Sousa
Extend the list of ADL-N PCI IDs to contain two new entries. Bspec: 68397 Signed-off-by: Gustavo Sousa --- include/drm/i915_pciids.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/include/drm/i915_pciids.h b/include/drm/i915_pciids.h index 07779a11758e..28a96aa1e08f

RE: [RFC 3/4] drm/i915/dp: use link rate and lane count in intel_dp struct

2024-02-14 Thread Murthy, Arun R
> -Original Message- > From: Nikula, Jani > Sent: Wednesday, February 14, 2024 5:07 PM > To: Murthy, Arun R ; intel-gfx@lists.freedesktop.org > Cc: Deak, Imre ; Syrjala, Ville > ; > Shankar, Uma > Subject: RE: [RFC 3/4] drm/i915/dp: use link rate and lane count in intel_dp > struct >

RE: [RFC 4/4] drm/i915/display/dp: On LT failure retry LT

2024-02-14 Thread Murthy, Arun R
> -Original Message- > From: Nikula, Jani > Sent: Wednesday, February 14, 2024 5:01 PM > To: Murthy, Arun R ; intel-gfx@lists.freedesktop.org > Cc: Deak, Imre ; Syrjala, Ville > ; > Shankar, Uma > Subject: RE: [RFC 4/4] drm/i915/display/dp: On LT failure retry LT > > On Wed, 14 Feb

RE: [RFC 1/4] drm/i915/display/dp: Add DP fallback on LT

2024-02-14 Thread Murthy, Arun R
> -Original Message- > From: Nikula, Jani > Sent: Wednesday, February 14, 2024 4:54 PM > To: Murthy, Arun R ; intel-gfx@lists.freedesktop.org > Cc: Deak, Imre ; Syrjala, Ville > ; > Shankar, Uma > Subject: RE: [RFC 1/4] drm/i915/display/dp: Add DP fallback on LT > > On Wed, 14 Feb

✗ Fi.CI.IGT: failure for HDCP Type1 MST fixes

2024-02-14 Thread Patchwork
== Series Details == Series: HDCP Type1 MST fixes URL : https://patchwork.freedesktop.org/series/129884/ State : failure == Summary == CI Bug Log - changes from CI_DRM_14268_full -> Patchwork_129884v1_full Summary --- **FAILURE**

Re: [PATCH] drm/i915: Add bigjoiner force enable option to debugfs

2024-02-14 Thread Rodrigo Vivi
On Wed, Feb 14, 2024 at 11:56:10AM +0200, Lisovskiy, Stanislav wrote: > On Tue, Feb 13, 2024 at 10:33:56AM -0500, Rodrigo Vivi wrote: > > On Tue, Feb 13, 2024 at 05:21:26PM +0200, Lisovskiy, Stanislav wrote: > > > On Tue, Feb 13, 2024 at 05:11:37PM +0200, Shankar, Uma wrote: > > > > > > > > > >

Re: [PATCH 4/5] drm/i915: Add PLL .compare_hw_state() vfunc

2024-02-14 Thread Jani Nikula
On Fri, 09 Feb 2024, Ville Syrjala wrote: > From: Ville Syrjälä > > Chunk up the humenguous dpll_hw_state comparison check into per-platform > variants, implemented in the dpll_mgr. This is step one in allowing > each platform (or perhaps even PLL) type to have a custom hw state > structure

[PATCH v2 2/2] drm/tests/drm_buddy: add alloc_contiguous test

2024-02-14 Thread Arunpravin Paneer Selvam
From: Matthew Auld Sanity check DRM_BUDDY_CONTIGUOUS_ALLOCATION. v2: Fix checkpatch warnings. Closes: https://gitlab.freedesktop.org/drm/amd/-/issues/3097 Signed-off-by: Matthew Auld Cc: Arunpravin Paneer Selvam Cc: Limonciello Cc: Christian König Reviewed-by: Arunpravin Paneer Selvam

[PATCH v2 1/2] drm/buddy: Fix alloc_range() error handling code

2024-02-14 Thread Arunpravin Paneer Selvam
Few users have observed display corruption when they boot the machine to KDE Plasma or playing games. We have root caused the problem that whenever alloc_range() couldn't find the required memory blocks the function was returning SUCCESS in some of the corner cases. The right approach would be if

✗ Fi.CI.BAT: failure for Introduce drm sharpening property

2024-02-14 Thread Patchwork
== Series Details == Series: Introduce drm sharpening property URL : https://patchwork.freedesktop.org/series/129888/ State : failure == Summary == CI Bug Log - changes from CI_DRM_14269 -> Patchwork_129888v1 Summary --- **FAILURE**

RE: [PATCH 06/10] drm/i915/spi: spi register with mtd

2024-02-14 Thread Usyskin, Alexander
Hi Miquel Intel Gfx in infinite wisdom decided to create another driver - Xe and the spi driver part of this series should be moved to some common location. Should it be drivers/mtd or drivers/spi, or some other place? -- Thanks, Sasha > > Hi Alexander, > > + Michael and Tudor > > Folks,

✗ Fi.CI.SPARSE: warning for Introduce drm sharpening property

2024-02-14 Thread Patchwork
== Series Details == Series: Introduce drm sharpening property URL : https://patchwork.freedesktop.org/series/129888/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

✗ Fi.CI.CHECKPATCH: warning for Introduce drm sharpening property

2024-02-14 Thread Patchwork
== Series Details == Series: Introduce drm sharpening property URL : https://patchwork.freedesktop.org/series/129888/ State : warning == Summary == Error: dim checkpatch failed f800fb698aab drm: Introduce sharpeness mode property 3f3bad5af877 drm/i915/display/: Compute the scaler filter

✗ Fi.CI.IGT: failure for drm/i915: Add GuC submission interface version query (rev3)

2024-02-14 Thread Patchwork
== Series Details == Series: drm/i915: Add GuC submission interface version query (rev3) URL : https://patchwork.freedesktop.org/series/129627/ State : failure == Summary == CI Bug Log - changes from CI_DRM_14268_full -> Patchwork_129627v3_full

RE: [RFC 3/4] drm/i915/dp: use link rate and lane count in intel_dp struct

2024-02-14 Thread Jani Nikula
On Wed, 14 Feb 2024, "Murthy, Arun R" wrote: >> -Original Message- >> From: Nikula, Jani >> Sent: Tuesday, February 13, 2024 11:43 PM >> To: Murthy, Arun R ; intel-gfx@lists.freedesktop.org >> Cc: Deak, Imre ; Syrjala, Ville >> ; >> Shankar, Uma ; Murthy, Arun R >> >> Subject: Re: [RFC

RE: [RFC 4/4] drm/i915/display/dp: On LT failure retry LT

2024-02-14 Thread Jani Nikula
On Wed, 14 Feb 2024, "Murthy, Arun R" wrote: >> -Original Message- >> From: Nikula, Jani >> Sent: Tuesday, February 13, 2024 11:45 PM >> To: Murthy, Arun R ; intel-gfx@lists.freedesktop.org >> Cc: Deak, Imre ; Syrjala, Ville >> ; >> Shankar, Uma ; Murthy, Arun R >> >> Subject: Re: [RFC

[RFC 5/5] drm/i915/display: Load the lut values and enable sharpness

2024-02-14 Thread Nemesa Garg
Load the lut values during pipe enable. Signed-off-by: Nemesa Garg --- drivers/gpu/drm/i915/display/intel_crtc.c| 3 +++ drivers/gpu/drm/i915/display/intel_display.c | 12 +++- drivers/gpu/drm/i915/display/skl_scaler.c| 11 ++- 3 files changed, 24 insertions(+), 2

[RFC 4/5] drm/i915/display/: Add registers and compute the strength

2024-02-14 Thread Nemesa Garg
Add new registers and related bits. Compute the strength value and tap value based on display mode. Signed-off-by: Nemesa Garg --- .../drm/i915/display/intel_display_types.h| 1 + .../drm/i915/display/intel_sharpen_filter.c | 84 +++

[RFC 3/5] drm/i915/dispaly/: Enable the second scaler

2024-02-14 Thread Nemesa Garg
The strength value should be greater than zero to set to the scaler flag true and if the second scaler is free then it can be used for sharpening purpose. Signed-off-by: Nemesa Garg --- drivers/gpu/drm/i915/display/intel_display.c | 7 +- .../drm/i915/display/intel_display_types.h| 1 +

[RFC 2/5] drm/i915/display/: Compute the scaler filter coefficients

2024-02-14 Thread Nemesa Garg
Scaler coefficient values are based on experiments and vary for different tap value/win size. These values are normalized by taking the sum of all values and then dividing each value with a sum. Signed-off-by: Nemesa Garg --- drivers/gpu/drm/i915/Makefile | 1 +

[RFC 1/5] drm: Introduce sharpeness mode property

2024-02-14 Thread Nemesa Garg
This allows the user to set the intensity so as to get the sharpness effect. It is useful in scenario when the output is blurry and user want to sharpen the pixels. Signed-off-by: Nemesa Garg --- drivers/gpu/drm/drm_atomic_uapi.c | 4 drivers/gpu/drm/drm_crtc.c| 17

[RFC 0/5] Introduce drm sharpening property

2024-02-14 Thread Nemesa Garg
Many a times images are blurred or upscaled content is also not as crisp as original rendered image. Traditional sharpening techniques often apply a uniform level of enhancement across entire image, which sometimes result in over-sharpening of some areas and potential loss of natural

RE: [RFC 1/4] drm/i915/display/dp: Add DP fallback on LT

2024-02-14 Thread Jani Nikula
On Wed, 14 Feb 2024, "Murthy, Arun R" wrote: >> -Original Message- >> From: Nikula, Jani >> Sent: Tuesday, February 13, 2024 11:41 PM >> To: Murthy, Arun R ; intel-gfx@lists.freedesktop.org >> Cc: Deak, Imre ; Syrjala, Ville >> ; >> Shankar, Uma ; Murthy, Arun R >> >> Subject: Re: [RFC

Re: [PULL] drm-intel-next

2024-02-14 Thread Jani Nikula
On Wed, 07 Feb 2024, Jani Nikula wrote: > Hi Dave & Sima - > > drm-intel-next-2024-02-07: > drm/i915 feature pull for v6.9: Ping, this hasn't been merged yet. BR, Jani. -- Jani Nikula, Intel

✗ Fi.CI.IGT: failure for drm/i915/display: update pll values in sync with Bspec for MTL (rev2)

2024-02-14 Thread Patchwork
== Series Details == Series: drm/i915/display: update pll values in sync with Bspec for MTL (rev2) URL : https://patchwork.freedesktop.org/series/129878/ State : failure == Summary == CI Bug Log - changes from CI_DRM_14268_full -> Patchwork_129878v2_full

Re: [PATCH 2/2] drm/i915/lnl: Program PKGC_LATENCY register

2024-02-14 Thread Govindapillai, Vinod
Hi Suraj, +Ville - please comment if you see anything wrong with my explanation here I think there could be a problem with the current logic and a possibility for underrun. As per the bspec we need to configure highest latency to soc. As per this patch, skl_program_dpkgc_latency() is called

✓ Fi.CI.BAT: success for HDCP Type1 MST fixes

2024-02-14 Thread Patchwork
== Series Details == Series: HDCP Type1 MST fixes URL : https://patchwork.freedesktop.org/series/129884/ State : success == Summary == CI Bug Log - changes from CI_DRM_14268 -> Patchwork_129884v1 Summary --- **SUCCESS** No

✗ Fi.CI.SPARSE: warning for HDCP Type1 MST fixes

2024-02-14 Thread Patchwork
== Series Details == Series: HDCP Type1 MST fixes URL : https://patchwork.freedesktop.org/series/129884/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. +./arch/x86/include/asm/bitops.h:116:1: warning:

Re: [PATCH] drm/i915: Add bigjoiner force enable option to debugfs

2024-02-14 Thread Lisovskiy, Stanislav
On Tue, Feb 13, 2024 at 10:33:56AM -0500, Rodrigo Vivi wrote: > On Tue, Feb 13, 2024 at 05:21:26PM +0200, Lisovskiy, Stanislav wrote: > > On Tue, Feb 13, 2024 at 05:11:37PM +0200, Shankar, Uma wrote: > > > > > > > > > > -Original Message- > > > > From: Rodrigo Vivi > > > > Sent:

✓ Fi.CI.BAT: success for drm/i915: Add GuC submission interface version query (rev3)

2024-02-14 Thread Patchwork
== Series Details == Series: drm/i915: Add GuC submission interface version query (rev3) URL : https://patchwork.freedesktop.org/series/129627/ State : success == Summary == CI Bug Log - changes from CI_DRM_14268 -> Patchwork_129627v3

✗ Fi.CI.SPARSE: warning for drm/i915: Add GuC submission interface version query (rev3)

2024-02-14 Thread Patchwork
== Series Details == Series: drm/i915: Add GuC submission interface version query (rev3) URL : https://patchwork.freedesktop.org/series/129627/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

✗ Fi.CI.CHECKPATCH: warning for drm/i915: Add GuC submission interface version query (rev3)

2024-02-14 Thread Patchwork
== Series Details == Series: drm/i915: Add GuC submission interface version query (rev3) URL : https://patchwork.freedesktop.org/series/129627/ State : warning == Summary == Error: dim checkpatch failed 955eeb673e69 drm/i915: Add GuC submission interface version query -:95:

Re: [PATCH 17/28] drm/i915: Define segmented Lut and add capabilities to colorop

2024-02-14 Thread Pekka Paalanen
On Wed, 14 Feb 2024 07:28:37 + "Shankar, Uma" wrote: > > -Original Message- > > From: dri-devel On Behalf Of Pekka > > Paalanen > > Sent: Tuesday, February 13, 2024 3:07 PM > > To: Shankar, Uma > > Cc: intel-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org; > >

RE: [PATCH 5/5] drm/i915: Enable fastboot across the board

2024-02-14 Thread Kahola, Mika
> -Original Message- > From: Intel-gfx On Behalf Of Ville > Syrjala > Sent: Friday, February 9, 2024 8:38 PM > To: intel-gfx@lists.freedesktop.org > Subject: [PATCH 5/5] drm/i915: Enable fastboot across the board > > From: Ville Syrjälä > > There's nothing magical about vlv+ platforms

[PATCH 11/12] drm/i915/hdcp: Allocate stream id after HDCP AKE stage

2024-02-14 Thread Suraj Kandpal
Allocate stream id after HDCP AKE stage and not before so that it can also be done during link integrity check. Right now for MST scenarios LIC fails after hdcp enablement for this reason. Signed-off-by: Suraj Kandpal --- drivers/gpu/drm/i915/display/intel_hdcp.c | 126 +++--- 1

  1   2   >