As of now whenerver HDR is switched on we use the PWM to change the
backlight as opposed to AUX based backlight changes in terms of nits.
This patch writes to the appropriate DPCD registers to enable aux
based backlight using values in nits.
--v2
-Fix max_cll and max_fall assignment [Jani]
-Fix
Hi Dave and Sima,
Here are the drm-xe fixes for the 6.9 cycle. Just 3 fixes: one trivial
fix for error path handling, one to avoid pinning all VMAs in
drm_gpuvm_exec_lock() when num_batch_buffer passed to xe_exec is 0 and
the other to allow userspace to free userptr while still having
bindings.
== Series Details ==
Series: drm/xe/display: fix type of intel_uncore_read*() functions
URL : https://patchwork.freedesktop.org/series/131122/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_14429_full -> Patchwork_131122v1_full
On Tue, Mar 12, 2024 at 04:43:06PM -0700, John Harrison wrote:
> On 3/12/2024 09:24, Matt Roper wrote:
> > On Thu, Mar 07, 2024 at 06:01:29PM -0800, john.c.harri...@intel.com wrote:
> > > From: John Harrison
> > >
> > > An existing workaround has been extended in both platforms affected
> > >
On Tue, Mar 12, 2024 at 04:51:45PM -0700, Lucas De Marchi wrote:
> With both XEHPSDV and PVC removed (as platforms, most of their code
> remain used by others), there's no need to handle !RCS_MASK() as
> other platforms don't ever have fused-off render. Remove those code
> paths and the special WA
On Tue, Mar 12, 2024 at 04:51:42PM -0700, Lucas De Marchi wrote:
> All the platforms that inherit the media/graphics version
> from XE_HPM_FEATURES / XE_HP_FEATURES just override it to another
> version. Just set the version directly in the respective struct
> and remove the versions from the
On Tue, Mar 12, 2024 at 04:51:41PM -0700, Lucas De Marchi wrote:
> Now that DG2 is the only user of this forcewake table, remove the macro
> and use FORCEWAKE_RENDER explicitly for range 0xd800 - 0xd87f.
>
> Suggested-by: Matt Roper
> Signed-off-by: Lucas De Marchi
Reviewed-by: Matt Roper
>
== Series Details ==
Series: drm/i915/gt: Report full vm address range (rev2)
URL : https://patchwork.freedesktop.org/series/131095/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_14433 -> Patchwork_131095v2
Summary
---
== Series Details ==
Series: drm/i915/gt: Report full vm address range (rev2)
URL : https://patchwork.freedesktop.org/series/131095/
State : warning
== Summary ==
Error: dim checkpatch failed
de74046741ce drm/i915/gt: Report full vm address range
-:20: WARNING:BAD_SIGN_OFF: Duplicate
== Series Details ==
Series: drm/i915: cleanup dead code (rev2)
URL : https://patchwork.freedesktop.org/series/131049/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_14433 -> Patchwork_131049v2
Summary
---
== Series Details ==
Series: drm/i915: cleanup dead code (rev2)
URL : https://patchwork.freedesktop.org/series/131049/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
== Series Details ==
Series: drm/i915: cleanup dead code (rev2)
URL : https://patchwork.freedesktop.org/series/131049/
State : warning
== Summary ==
Error: dim checkpatch failed
8c0c8bf0df8f drm/i915: Drop dead code for xehpsdv
-:918: WARNING:LINE_CONTINUATIONS: Avoid unnecessary line
== Series Details ==
Series: series starting with [01/11] drm/xe: Introduce
xe_pm_runtime_get_noresume for inner callers
URL : https://patchwork.freedesktop.org/series/131141/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_14433 -> Patchwork_131141v1
== Series Details ==
Series: series starting with [01/11] drm/xe: Introduce
xe_pm_runtime_get_noresume for inner callers
URL : https://patchwork.freedesktop.org/series/131141/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be
== Series Details ==
Series: Enable LNL display (rev2)
URL : https://patchwork.freedesktop.org/series/130689/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_14421_full -> Patchwork_130689v2_full
Summary
---
== Series Details ==
Series: Disable automatic load CCS load balancing (rev10)
URL : https://patchwork.freedesktop.org/series/129951/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_14433 -> Patchwork_129951v10
Summary
Illipilli, TejasreeX would like to recall the message, "✗ Fi.CI.IGT: failure
for drm/i915/dp: Increase idle pattern wait timeout to 2ms (rev4)".
On Thu, 14 Mar 2024 09:57:57 -0700
Alison Schofield wrote:
> On Fri, Feb 23, 2024 at 12:56:34PM -0500, Steven Rostedt wrote:
> > From: "Steven Rostedt (Google)"
> >
> > [
> >This is a treewide change. I will likely re-create this patch again in
> >the second week of the merge window of
== Series Details ==
Series: Disable automatic load CCS load balancing (rev10)
URL : https://patchwork.freedesktop.org/series/129951/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
== Series Details ==
Series: Disable automatic load CCS load balancing (rev10)
URL : https://patchwork.freedesktop.org/series/129951/
State : warning
== Summary ==
Error: dim checkpatch failed
67800c9b3ada drm/i915/gt: Disable HW load balancing for CCS
6b604822e329 drm/i915/gt: Do not
On Thu, Mar 14, 2024 at 10:10:13AM -0400, Rodrigo Vivi wrote:
> This patch brings no functional change. Since at this point of
> the code we are already asserting a wakeref was held, it means
> that we are with runtime_pm 'in_use' and in practical terms we
> are only bumping the pm_runtime usage
Hi,
On Thu, Mar 14, 2024 at 10:10:12AM -0400, Rodrigo Vivi wrote:
> The i915-display will start using the intel_runtime_pm_noresume.
> So we need to add the compat header before it.
Or "So we need to add it to the compat header before"?
>
> Signed-off-by: Rodrigo Vivi
> ---
>
On Fri, Feb 23, 2024 at 12:56:34PM -0500, Steven Rostedt wrote:
> From: "Steven Rostedt (Google)"
>
> [
>This is a treewide change. I will likely re-create this patch again in
>the second week of the merge window of v6.9 and submit it then. Hoping
>to keep the conflicts that it will
On 3/12/2024 3:55 PM, Jonathan Cavitt wrote:
We cannot write requests to objects without struct pages, so escape
early if the requests are bound to objects that lack them.
Signed-off-by: Jonathan Cavitt
---
v2: s/vma-obj/vma->obj
drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c | 7 +++
On 3/14/2024 3:04 PM, Lionel Landwerlin wrote:
Hi Andi,
In Mesa we've been relying on I915_CONTEXT_PARAM_GTT_SIZE so as long
as that is adjusted by the kernel
What do you mean by adjusted by, should it be a aligned size?
I915_CONTEXT_PARAM_GTT_SIZE ioctl is returning vm->total which is
On Wed, 2024-03-13 at 16:01 +0200, Ville Syrjälä wrote:
> On Wed, Mar 13, 2024 at 03:32:21PM +0200, Jouni Högander wrote:
> > Increasing number of fast wake sync pulses seem to fix problems
> > with
> > certain PSR panels. This should be ok for other panels as well as
> > the eDP
> > specification
Let's simply convert all the current callers towards direct
xe_pm_runtime access and remove this extra layer of indirection.
v2: Convert all the current callers instead of a big refactor
at once.
Signed-off-by: Rodrigo Vivi
Reviewed-by: Matthew Auld
---
drivers/gpu/drm/xe/display/xe_fb_pin.c
At this point mem_access references should be only used as inner
points of the execution and a get with synchronous resume previously
called at an outer point.
So, before killing mem_acces in favor of direct accsess, let's
ensure that we first convert them towards the new _noresume
variant that
Now that assert_mem_access is relying directly on the pm_runtime state
instead of the counters, there's no reason why we cannot use
the pm_runtime functions directly.
Signed-off-by: Rodrigo Vivi
Reviewed-by: Matthew Auld
---
drivers/gpu/drm/xe/xe_device.c | 17 -
This is not needed any longer, now that we have all the protection
in place with the runtime pm itself.
Signed-off-by: Rodrigo Vivi
Reviewed-by: Matthew Auld
---
drivers/gpu/drm/xe/xe_device.c | 8
drivers/gpu/drm/xe/xe_device.h | 1 -
drivers/gpu/drm/xe/xe_pm.c | 3 ---
3 files
The gem page fault is one of the outer bound protections where
we want to ensure that the hardware is in D0 before proceeding
with memory access. Let's convert it towards the xe_pm_runtime
functions directly so we can then convert the mem_access to be
inner protection only and then Kill it for
We need to convert so we can continue to kill the mem_access.
At this point we should be protected by the display wakerefs already,
so let's use the noresume variant.
Signed-off-by: Rodrigo Vivi
---
drivers/gpu/drm/xe/display/xe_hdcp_gsc.c | 4 ++--
1 file changed, 2 insertions(+), 2
xe_pm_init is the very last thing during the xe_pci_probe(),
hence these protections are useless from the point of view
of ensuring that the device is awake.
Let's remove it so we continue towards the goal of killing
xe_device_mem_access.
v2: Adding more cases
v3: Provide a separate fix for
The mem_access itself is not holding any lock, but attempting
to train lockdep with possible scarring locks happening during
runtime pm. We are going soon to kill the mem_access get and put
helpers in favor of direct xe_pm_runtime calls, so let's just
move this lock around to where it now belongs.
This patch brings no functional change. Since at this point of
the code we are already asserting a wakeref was held, it means
that we are with runtime_pm 'in_use' and in practical terms we
are only bumping the pm_runtime usage counter and moving on.
However, xe driver has a lockdep annotation
The i915-display will start using the intel_runtime_pm_noresume.
So we need to add the compat header before it.
Signed-off-by: Rodrigo Vivi
---
drivers/gpu/drm/xe/compat-i915-headers/i915_drv.h | 8
1 file changed, 8 insertions(+)
diff --git
Let's ensure that we have an option for inner callers that will
raise WARN if device is not active and not protected by outer callers.
Make this also a void function forcing every caller to unconditionally
put the reference back afterwards.
This will be very important for cases where we want to
Hi Andi,
In Mesa we've been relying on I915_CONTEXT_PARAM_GTT_SIZE so as long as
that is adjusted by the kernel, we should be able to continue working
without issues.
Acked-by: Lionel Landwerlin
Thanks,
-Lionel
On 13/03/2024 21:39, Andi Shyti wrote:
Commit 9bb66c179f50 ("drm/i915:
Hi Jonathan,
On Tue, Mar 12, 2024 at 07:55:06AM -0700, Jonathan Cavitt wrote:
> We cannot write requests to objects without struct pages, so escape
> early if the requests are bound to objects that lack them.
>
> Signed-off-by: Jonathan Cavitt
is this a fix? Do you need
Fixes: 544460c33821
== Series Details ==
Series: drm/i915: Fix VMA UAF on destroy against deactivate race (rev8)
URL : https://patchwork.freedesktop.org/series/129026/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_14430 -> Patchwork_129026v8
== Series Details ==
Series: drm/i915: Fix VMA UAF on destroy against deactivate race (rev8)
URL : https://patchwork.freedesktop.org/series/129026/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
Quoting Rodrigo Vivi (2024-03-08 16:58:04)
> On Fri, Mar 08, 2024 at 04:46:43PM +0200, Joonas Lahtinen wrote:
> > Add standalone includes for BUG_ON and BUILD_BUG_ON to avoid build failure
> > after linux-next include refactoring.
>
> any lore link so we can use with a 'Closes:' tag?
> and
On Thu, 07 Mar 2024, Jani Nikula wrote:
> Switch a handful of places over to drm device based logging and WARNs,
> unify connector and crtc logging, etc.
Ping for review, please. :)
>
> Jani Nikula (6):
> drm/modes: add drm_mode_print() to dump mode in drm_printer
> drm/probe-helper:
On Thursday, 14 March 2024 11:29:38 CET Kamil Konieczny wrote:
> Hi Janusz,
> On 2024-02-27 at 16:10:41 +0100, Janusz Krzysztofik wrote:
> > Up to now we were loading a KUnit test module in test execution mode only
> > once per subtest, in background, and then, in parallel with execution of
> >
On Wed, Mar 13, 2024 at 10:06:30PM +, Chris Bainbridge wrote:
> Fix a regression when using nouveau and unplugging a StarTech MSTDP122DP
> DisplayPort 1.2 MST hub (the same regression does not appear when using
> a Cable Matters DisplayPort 1.4 MST hub). Trace:
>
> divide error: [#1]
Hi Janusz,
On 2024-02-27 at 16:10:41 +0100, Janusz Krzysztofik wrote:
> Up to now we were loading a KUnit test module in test execution mode only
> once per subtest, in background, and then, in parallel with execution of
> test cases while the module was loading, we were looking through dmesg for
On Mon, 11 Mar 2024, Gustavo Sousa wrote:
> Quoting Shekhar Chauhan (2024-03-11 01:15:04-03:00)
>>The driver currently waits 1ms for idle patterns,
>>but for Xe2LPD and possibly future display IPs,
>>it requires a 1640us (rounded up to 2ms) timeout
>>whilst waiting for idle patterns for MST
On 3/13/2024 9:26 AM, Mitul Golani wrote:
Compute vrr_vsync_start/end, which sets the position
for hardware to send the Vsync at a fixed position
relative to the end of the Vblank.
--v2:
- Updated VSYNC_START/END macros to VRR_VSYNC_START/END. (Ankit)
- Updated bit fields of
== Series Details ==
Series: drm/i915/display: DMC wakelock implementation
URL : https://patchwork.freedesktop.org/series/131124/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_14429 -> Patchwork_131124v1
Summary
---
== Series Details ==
Series: drm/i915/display: DMC wakelock implementation
URL : https://patchwork.freedesktop.org/series/131124/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
== Series Details ==
Series: drm/i915/display: DMC wakelock implementation
URL : https://patchwork.freedesktop.org/series/131124/
State : warning
== Summary ==
Error: dim checkpatch failed
80db5bb4bd35 drm/i915/display: add support for DMC wakelocks
Traceback (most recent call last):
File
Hi Dave, Sima,
here's the PR for drm-misc-next-fixes for this week. There's a fix
for nouveau BOs and quite a few fixes for get_modes() functions.
Best regards
Thomas
drm-misc-next-fixes-2024-03-14:
Short summary of fixes pull:
probe-helper:
- never return negative values from .get_modes()
== Series Details ==
Series: drm/xe/display: fix type of intel_uncore_read*() functions
URL : https://patchwork.freedesktop.org/series/131122/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_14429 -> Patchwork_131122v1
We only need DMC wakelocks when we allow DC5 and DC6 states. Add the
calls to enable and disable DMC wakelock accordingly.
Signed-off-by: Luca Coelho
---
drivers/gpu/drm/i915/display/intel_display_power_well.c | 7 +++
drivers/gpu/drm/i915/display/intel_dmc.c| 4
2
This feature should be disabled by default until properly tested and
mature. Add a module parameter to enable the feature for testing,
while keeping it disabled by default for now.
Signed-off-by: Luca Coelho
---
drivers/gpu/drm/i915/display/intel_display_params.c | 5 +
Only allow running DMC wakelock code if the display version is 20 or
greater.
Signed-off-by: Luca Coelho
---
drivers/gpu/drm/i915/display/intel_dmc_wl.c | 12
1 file changed, 12 insertions(+)
diff --git a/drivers/gpu/drm/i915/display/intel_dmc_wl.c
In order to reduce the DC5->DC2 restore time, wakelocks have been
introduced in DMC so the driver can tell it when registers and other
memory areas are going to be accessed and keep their respective blocks
awake.
Implement this in the driver by adding the concept of DMC wakelocks.
When the driver
Hi,
This is the fourth version of my series, the second as a proper
patchset. Now sent for the drm-tip (intel-gfx).
The changes comparing to v1 are just addressing Gustavo's comments.
The major changes are:
* Enable/disable the wakelocks on DC5-6 entry and exit instead of on
DMC load and
Some of the backported intel_uncore_read*() functions used the wrong
types. Change the function declarations accordingly.
Reviewed-by: Gustavo Sousa
Signed-off-by: Luca Coelho
---
drivers/gpu/drm/xe/compat-i915-headers/intel_uncore.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
59 matches
Mail list logo
