[PATCH 02/13] drm/i915/spi: add spi device for discrete graphics

2024-03-28 Thread Alexander Usyskin
Enable access to internal spi on DGFX devices via a child device. The spi child device is exposed via auxiliary bus. CC: Rodrigo Vivi CC: Lucas De Marchi Signed-off-by: Tomas Winkler Signed-off-by: Alexander Usyskin --- drivers/gpu/drm/i915/Makefile| 4 ++

[PATCH 01/13] spi: add auxiliary device for intel dg spi

2024-03-28 Thread Alexander Usyskin
Add auxilary bus device structure for Intel Discrete Graphics SPI device. Signed-off-by: Alexander Usyskin --- include/linux/intel_dg_spi_aux.h | 27 +++ 1 file changed, 27 insertions(+) create mode 100644 include/linux/intel_dg_spi_aux.h diff --git

[PATCH 00/13] spi: add driver for Intel discrete graphics

2024-03-28 Thread Alexander Usyskin
Add driver for access to Intel discrete graphics card internal SPI device. Expose device on auxiliary bus by i915 and Xe drivers and provide spi driver to register this device with MTD framework. This is a rewrite of "drm/i915/spi: spi access for discrete graphics" series with connection to the

RE: [PATCH 10/13] drm/i915: Use old mbus_join value when increasing CDCLK

2024-03-28 Thread Shankar, Uma
> -Original Message- > From: Intel-gfx On Behalf Of Ville > Syrjala > Sent: Wednesday, March 27, 2024 11:16 PM > To: intel-gfx@lists.freedesktop.org > Subject: [PATCH 10/13] drm/i915: Use old mbus_join value when increasing > CDCLK > > From: Stanislav Lisovskiy > > In order to make

RE: [PATCH 09/13] drm/i915: Add debugs for mbus joining and dbuf ratio programming

2024-03-28 Thread Shankar, Uma
> -Original Message- > From: Intel-gfx On Behalf Of Ville > Syrjala > Sent: Wednesday, March 27, 2024 11:16 PM > To: intel-gfx@lists.freedesktop.org > Subject: [PATCH 09/13] drm/i915: Add debugs for mbus joining and dbuf ratio > programming Looks Good to me. Reviewed-by: Uma Shankar

RE: [PATCH 08/13] drm/i915: Extract intel_dbuf_mdclk_min_tracker_update()

2024-03-28 Thread Shankar, Uma
> -Original Message- > From: Intel-gfx On Behalf Of Ville > Syrjala > Sent: Wednesday, March 27, 2024 11:16 PM > To: intel-gfx@lists.freedesktop.org > Subject: [PATCH 08/13] drm/i915: Extract > intel_dbuf_mdclk_min_tracker_update() > > From: Ville Syrjälä > > Extact the stuff that

RE: [PATCH 07/13] drm/i915: Extract intel_dbuf_mbus_join_update()

2024-03-28 Thread Shankar, Uma
> -Original Message- > From: Intel-gfx On Behalf Of Ville > Syrjala > Sent: Wednesday, March 27, 2024 11:16 PM > To: intel-gfx@lists.freedesktop.org > Subject: [PATCH 07/13] drm/i915: Extract intel_dbuf_mbus_join_update() > > From: Ville Syrjälä > > Extact the stuff that writes the

RE: [PATCH 06/13] drm/i915: Relocate intel_mbus_dbox_update()

2024-03-28 Thread Shankar, Uma
> -Original Message- > From: Intel-gfx On Behalf Of Ville > Syrjala > Sent: Wednesday, March 27, 2024 11:16 PM > To: intel-gfx@lists.freedesktop.org > Subject: [PATCH 06/13] drm/i915: Relocate intel_mbus_dbox_update() > > From: Ville Syrjälä > > intel_mbus_dbox_update() will become

RE: [PATCH 05/13] drm/i915: Loop over all active pipes in intel_mbus_dbox_update

2024-03-28 Thread Shankar, Uma
> -Original Message- > From: Intel-gfx On Behalf Of Ville > Syrjala > Sent: Wednesday, March 27, 2024 11:16 PM > To: intel-gfx@lists.freedesktop.org > Subject: [PATCH 05/13] drm/i915: Loop over all active pipes in > intel_mbus_dbox_update > > From: Stanislav Lisovskiy > > We need to

RE: [PATCH 04/13] drm/i915/cdclk: Indicate whether CDCLK change happens during pre or post plane update

2024-03-28 Thread Shankar, Uma
> -Original Message- > From: Intel-gfx On Behalf Of Ville > Syrjala > Sent: Wednesday, March 27, 2024 11:16 PM > To: intel-gfx@lists.freedesktop.org > Subject: [PATCH 04/13] drm/i915/cdclk: Indicate whether CDCLK change happens > during pre or post plane update > > From: Ville Syrjälä

RE: [PATCH 03/13] drm/i915/cdclk: Drop tgl/dg2 cdclk bump hacks

2024-03-28 Thread Shankar, Uma
> -Original Message- > From: Intel-gfx On Behalf Of Ville > Syrjala > Sent: Wednesday, March 27, 2024 11:16 PM > To: intel-gfx@lists.freedesktop.org > Subject: [PATCH 03/13] drm/i915/cdclk: Drop tgl/dg2 cdclk bump hacks > > From: Ville Syrjälä > > No ever figured out why bumping the

RE: [PATCH 02/13] drm/i915/cdclk: Fix voltage_level programming edge case

2024-03-28 Thread Shankar, Uma
> -Original Message- > From: Intel-gfx On Behalf Of Ville > Syrjala > Sent: Wednesday, March 27, 2024 11:16 PM > To: intel-gfx@lists.freedesktop.org > Subject: [PATCH 02/13] drm/i915/cdclk: Fix voltage_level programming edge case > > From: Ville Syrjälä > > Currently we only consider

RE: [PATCH 01/13] drm/i915/cdclk: Fix CDCLK programming order when pipes are active

2024-03-28 Thread Shankar, Uma
> -Original Message- > From: Intel-gfx On Behalf Of Ville > Syrjala > Sent: Wednesday, March 27, 2024 11:16 PM > To: intel-gfx@lists.freedesktop.org > Subject: [PATCH 01/13] drm/i915/cdclk: Fix CDCLK programming order when > pipes are active > > From: Ville Syrjälä > > Currently we

RE: [PATCH v2 1/3] drm/i915/cdclk: Fix CDCLK programming order when pipes are active

2024-03-28 Thread Shankar, Uma
> -Original Message- > From: Intel-gfx On Behalf Of Ville > Syrjala > Sent: Wednesday, March 27, 2024 3:40 AM > To: intel-gfx@lists.freedesktop.org > Subject: [PATCH v2 1/3] drm/i915/cdclk: Fix CDCLK programming order when > pipes are active > > From: Ville Syrjälä > > Currently we

Re: [RESEND v3 2/2] drm: Add CONFIG_DRM_WERROR

2024-03-28 Thread Jani Nikula
On Wed, 27 Mar 2024, Nathan Chancellor wrote: > On Wed, Mar 27, 2024 at 09:59:01AM +0200, Jani Nikula wrote: >> An alternative would be to "depends on !COMPILE_TEST" that we have in >> i915, but then some folks want to have COMPILE_TEST in drm, because some >> drivers are otherwise hard for

Re: [PATCH i-g-t] lib/kunit: Read results from debugfs

2024-03-28 Thread Kamil Konieczny
Hi Janusz, On 2024-03-27 at 23:26:03 +0100, Janusz Krzysztofik wrote: > On Wednesday, 27 March 2024 18:27:50 CET Kamil Konieczny wrote: > > Hi Janusz, > > On 2024-03-27 at 12:22:54 +0100, Janusz Krzysztofik wrote: > > > KUnit can provide KTAP reports from test modules via debugfs files, one > > >

[PULL] drm-misc-next

2024-03-28 Thread Maarten Lankhorst
Hi Dave, Sima, Happy easter!! Cheers, ~Maarten drm-misc-next-2024-03-28: drm-misc-next for v6.10-rc1: The deal of a lifetime! You get ALL of the previous drm-misc-next-2024-03-21-1 tag!! But WAIT, there's MORE! Cross-subsystem Changes: - Assorted DT binding updates. Core Changes: - Clarify

Re: [PATCH v3 1/4] drm/i915/display: add support for DMC wakelocks

2024-03-28 Thread Luca Coelho
On Thu, 2024-03-21 at 07:43 +, Shankar, Uma wrote: > > > -Original Message- > > From: Coelho, Luciano > > Sent: Monday, March 18, 2024 7:08 PM > > To: intel-gfx@lists.freedesktop.org > > Cc: intel...@lists.freedesktop.org; Shankar, Uma ; > > ville.syrj...@linux.intel.com; Nikula,

Re: [PATCHv2] drm/xe/display: check for error on drmm_mutex_init

2024-03-28 Thread Andi Shyti
Hi Arun, > > On Thu, Mar 28, 2024 at 12:33:09PM +0200, Jani Nikula wrote: > > > On Thu, 28 Mar 2024, Andi Shyti wrote: > > > >> - drmm_mutex_init(>drm, >sb_lock); > > > >> - drmm_mutex_init(>drm, >display.backlight.lock); > > > >> - drmm_mutex_init(>drm, >display.audio.mutex); > >

Re: [PATCH] drm/i915: use fine grained -Woverride-init disable

2024-03-28 Thread Arnd Bergmann
On Thu, Mar 28, 2024, at 11:46, Jani Nikula wrote: > On Thu, 28 Mar 2024, "Arnd Bergmann" wrote: >> On Thu, Mar 28, 2024, at 11:24, Jani Nikula wrote: >>> Use localized __diag_push(), __diag_ignore_all() with rationale, and >>> __diag_pop() for specific initializations instead of blanket

RE: [PATCHv2] drm/xe/display: check for error on drmm_mutex_init

2024-03-28 Thread Murthy, Arun R
> -Original Message- > From: Andi Shyti > Sent: Thursday, March 28, 2024 4:16 PM > To: Jani Nikula > Cc: Andi Shyti ; Murthy, Arun R > ; intel-gfx@lists.freedesktop.org; intel- > x...@lists.freedesktop.org > Subject: Re: [PATCHv2] drm/xe/display: check for error on drmm_mutex_init > >

Re: [PATCH] drm/i915/gem: Calculate object page offset for partial memory mapping

2024-03-28 Thread Andi Shyti
Hi Nirmoy, On Tue, Mar 26, 2024 at 01:05:37PM +0100, Nirmoy Das wrote: > On 3/26/2024 12:12 PM, Andi Shyti wrote: > > > > diff --git a/drivers/gpu/drm/i915/gem/i915_gem_mman.c > > > > b/drivers/gpu/drm/i915/gem/i915_gem_mman.c > > > > index a2195e28b625..57a2dda2c3cc 100644 > > > > ---

RE: [PATCH 2/2] drm/i915/hdcp: Fix get remote hdcp capability function

2024-03-28 Thread Borah, Chaitanya Kumar
> -Original Message- > From: Borah, Chaitanya Kumar > Sent: Thursday, March 28, 2024 3:56 PM > To: Kandpal, Suraj ; intel-gfx@lists.freedesktop.org > Subject: RE: [PATCH 2/2] drm/i915/hdcp: Fix get remote hdcp capability > function > > Hello, > > > -Original Message- > > From:

Re: [PATCH] drm/i915: use fine grained -Woverride-init disable

2024-03-28 Thread Jani Nikula
On Thu, 28 Mar 2024, "Arnd Bergmann" wrote: > On Thu, Mar 28, 2024, at 11:24, Jani Nikula wrote: >> Use localized __diag_push(), __diag_ignore_all() with rationale, and >> __diag_pop() for specific initializations instead of blanket disabling >> of -Woverride-init across several files. >> >> Note

Re: [PATCH] drm/i915: use fine grained -Woverride-init disable

2024-03-28 Thread Arnd Bergmann
On Thu, Mar 28, 2024, at 11:24, Jani Nikula wrote: > Use localized __diag_push(), __diag_ignore_all() with rationale, and > __diag_pop() for specific initializations instead of blanket disabling > of -Woverride-init across several files. > > Note that we've tried this before with commit

Re: [PATCHv2] drm/xe/display: check for error on drmm_mutex_init

2024-03-28 Thread Andi Shyti
Hi Jani, On Thu, Mar 28, 2024 at 12:33:09PM +0200, Jani Nikula wrote: > On Thu, 28 Mar 2024, Andi Shyti wrote: > >> - drmm_mutex_init(>drm, >sb_lock); > >> - drmm_mutex_init(>drm, >display.backlight.lock); > >> - drmm_mutex_init(>drm, >display.audio.mutex); > >> - drmm_mutex_init(>drm,

Re: [PATCHv2] drm/xe/display: check for error on drmm_mutex_init

2024-03-28 Thread Jani Nikula
On Thu, 28 Mar 2024, Andi Shyti wrote: > Hi Arun, > > ... > >> -drmm_mutex_init(>drm, >sb_lock); >> -drmm_mutex_init(>drm, >display.backlight.lock); >> -drmm_mutex_init(>drm, >display.audio.mutex); >> -drmm_mutex_init(>drm, >display.wm.wm_mutex); >> -drmm_mutex_init(>drm,

RE: [PATCH 2/2] drm/i915/hdcp: Fix get remote hdcp capability function

2024-03-28 Thread Borah, Chaitanya Kumar
Hello, > -Original Message- > From: Kandpal, Suraj > Sent: Wednesday, March 27, 2024 10:14 AM > To: intel-gfx@lists.freedesktop.org > Cc: Borah, Chaitanya Kumar ; Kandpal, > Suraj > Subject: [PATCH 2/2] drm/i915/hdcp: Fix get remote hdcp capability function > > HDCP 1.x capability

[PATCH] drm/i915: use fine grained -Woverride-init disable

2024-03-28 Thread Jani Nikula
Use localized __diag_push(), __diag_ignore_all() with rationale, and __diag_pop() for specific initializations instead of blanket disabling of -Woverride-init across several files. Note that we've tried this before with commit 88e9664434c9 ("drm/i915: use localized __diag_ignore_all() instead of

RE: [PATCH 1/2] drm/i915/display: Initialize capability variables

2024-03-28 Thread Borah, Chaitanya Kumar
Hello > -Original Message- > From: Kandpal, Suraj > Sent: Wednesday, March 27, 2024 10:14 AM > To: intel-gfx@lists.freedesktop.org > Cc: Borah, Chaitanya Kumar ; Kandpal, > Suraj > Subject: [PATCH 1/2] drm/i915/display: Initialize capability variables > > Initialize HDCP capability

Re: [PATCH] drm/i915/hwmon: Remove i915_hwmon_unregister() during driver unbind

2024-03-28 Thread Krzysztofik, Janusz
Hi Ashutosh, On Wednesday, 27 March 2024 21:37:19 CET Dixit, Ashutosh wrote: > On Wed, 27 Mar 2024 02:15:27 -0700, Krzysztofik, Janusz wrote: > > > > Hi Janusz, > > > For me, that still doesn't explain why you think that i915->hwmon reset to > > NULL on i915 driver unregister can be the root

Re: [RFC 0/5] Introduce drm sharpening property

2024-03-28 Thread Pekka Paalanen
On Wed, 27 Mar 2024 13:29:16 +0200 Pekka Paalanen wrote: > On Wed, 27 Mar 2024 07:11:48 + > "Garg, Nemesa" wrote: > > > > -Original Message- > > > From: Pekka Paalanen > > > Sent: Wednesday, March 13, 2024 3:07 PM > > > To: Garg, Nemesa > > > Cc: Simon Ser ;

RE: [PATCH] drm/i915/gt: Limit the reserved VM space to only the platforms that need it

2024-03-28 Thread Mrozek, Michal
Commit 9bb66c179f50 ("drm/i915: Reserve some kernel space per vm") reduces the available VM space of one page in order to apply Wa_16018031267 and Wa_16018063123. This page was reserved indiscrimitely in all platforms even when not needed. Limit it to DG2 onwards. Fixes: 9bb66c179f50

✗ Fi.CI.SPARSE: warning for Disable automatic load CCS load balancing (rev13)

2024-03-28 Thread Patchwork
== Series Details == Series: Disable automatic load CCS load balancing (rev13) URL : https://patchwork.freedesktop.org/series/129951/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

✗ Fi.CI.CHECKPATCH: warning for Disable automatic load CCS load balancing (rev13)

2024-03-28 Thread Patchwork
== Series Details == Series: Disable automatic load CCS load balancing (rev13) URL : https://patchwork.freedesktop.org/series/129951/ State : warning == Summary == Error: dim checkpatch failed 1047fc2e60be drm/i915/gt: Disable HW load balancing for CCS 241a653471f2 drm/i915/gt: Do not

RE: [PATCH 4/5] drm/i915/display: Add definition for MCURSOR_MODE_64_2B

2024-03-28 Thread Kahola, Mika
> -Original Message- > From: Hogander, Jouni > Sent: Tuesday, March 19, 2024 2:33 PM > To: intel-gfx@lists.freedesktop.org > Cc: Kahola, Mika ; Hogander, Jouni > > Subject: [PATCH 4/5] drm/i915/display: Add definition for MCURSOR_MODE_64_2B > > MCURSOR_MODE_64_2B is used in

RE: [PATCH 3/5] drm/i915/display/intel_psr: Fix intel_psr2_sel_fetch_et_alignment usage

2024-03-28 Thread Kahola, Mika
> -Original Message- > From: Hogander, Jouni > Sent: Tuesday, March 19, 2024 2:33 PM > To: intel-gfx@lists.freedesktop.org > Cc: Kahola, Mika ; Hogander, Jouni > > Subject: [PATCH 3/5] drm/i915/display/intel_psr: Fix > intel_psr2_sel_fetch_et_alignment usage > > Currently we are not

RE: [PATCH 01/13] drm/i915/cdclk: Fix CDCLK programming order when pipes are active

2024-03-28 Thread Murthy, Arun R
> -Original Message- > From: Intel-gfx On Behalf Of Ville > Syrjala > Sent: Wednesday, March 27, 2024 11:16 PM > To: intel-gfx@lists.freedesktop.org > Subject: [PATCH 01/13] drm/i915/cdclk: Fix CDCLK programming order when > pipes are active > > From: Ville Syrjälä > > Currently we

Re: [PATCH] drm/i915/gt: Limit the reserved VM space to only the platforms that need it

2024-03-28 Thread Andi Shyti
Hi Nirmoy, On Thu, Mar 28, 2024 at 09:54:12AM +0100, Nirmoy Das wrote: > On 3/27/2024 9:05 PM, Andi Shyti wrote: > > Commit 9bb66c179f50 ("drm/i915: Reserve some kernel space per > > vm") reduces the available VM space of one page in order to apply > > Wa_16018031267 and Wa_16018063123. > > > >

Re: [PATCH] drm/i915/gt: Limit the reserved VM space to only the platforms that need it

2024-03-28 Thread Nirmoy Das
Hi Andi, On 3/27/2024 9:05 PM, Andi Shyti wrote: Commit 9bb66c179f50 ("drm/i915: Reserve some kernel space per vm") reduces the available VM space of one page in order to apply Wa_16018031267 and Wa_16018063123. This page was reserved indiscrimitely in all platforms even when not needed. Limit

Re: [PATCH] drm/i915/gem: Replace dev_priv with i915

2024-03-28 Thread Tvrtko Ursulin
On 28/03/2024 07:18, Andi Shyti wrote: Anyone using 'dev_priv' instead of 'i915' in a cleaned-up area should be fined and required to do community service for a few days. I thought I had cleaned up the 'gem/' directory in the past, but still, old aficionados of the 'dev_priv' name keep

Re: [PATCH] drm/i915/gem: Replace dev_priv with i915

2024-03-28 Thread Andi Shyti
Hi, On Thu, Mar 28, 2024 at 08:18:33AM +0100, Andi Shyti wrote: > Anyone using 'dev_priv' instead of 'i915' in a cleaned-up area > should be fined and required to do community service for a few > days. Not to scare people off, I would add another sentence in between: "Using 'i915' instead of

Re: [PATCHv2] drm/xe/display: check for error on drmm_mutex_init

2024-03-28 Thread Andi Shyti
Hi Arun, ... > - drmm_mutex_init(>drm, >sb_lock); > - drmm_mutex_init(>drm, >display.backlight.lock); > - drmm_mutex_init(>drm, >display.audio.mutex); > - drmm_mutex_init(>drm, >display.wm.wm_mutex); > - drmm_mutex_init(>drm, >display.pps.mutex); > - drmm_mutex_init(>drm,

[PATCHv2] drm/xe/display: check for error on drmm_mutex_init

2024-03-28 Thread Arun R Murthy
Check return value for drmm_mutex_init as it can fail and return on failure. Signed-off-by: Arun R Murthy --- drivers/gpu/drm/xe/display/xe_display.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/xe/display/xe_display.c

✗ Fi.CI.SPARSE: warning for drm/i915/gem: Replace dev_priv with i915

2024-03-28 Thread Patchwork
== Series Details == Series: drm/i915/gem: Replace dev_priv with i915 URL : https://patchwork.freedesktop.org/series/131736/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

✗ Fi.CI.CHECKPATCH: warning for drm/i915/gem: Replace dev_priv with i915

2024-03-28 Thread Patchwork
== Series Details == Series: drm/i915/gem: Replace dev_priv with i915 URL : https://patchwork.freedesktop.org/series/131736/ State : warning == Summary == Error: dim checkpatch failed 377e6b1d48e2 drm/i915/gem: Replace dev_priv with i915 -:38: WARNING:LONG_LINE: line length of 101 exceeds 100

[PATCH v8 3/3] drm/i915/gt: Enable only one CCS for compute workload

2024-03-28 Thread Andi Shyti
Enable only one CCS engine by default with all the compute sices allocated to it. While generating the list of UABI engines to be exposed to the user, exclude any additional CCS engines beyond the first instance. This change can be tested with igt i915_query. Fixes: d2eae8e98d59 ("drm/i915/dg2:

[PATCH v8 2/3] drm/i915/gt: Do not generate the command streamer for all the CCS

2024-03-28 Thread Andi Shyti
We want a fixed load CCS balancing consisting in all slices sharing one single user engine. For this reason do not create the intel_engine_cs structure with its dedicated command streamer for CCS slices beyond the first. Fixes: d2eae8e98d59 ("drm/i915/dg2: Drop force_probe requirement")

[PATCH v8 1/3] drm/i915/gt: Disable HW load balancing for CCS

2024-03-28 Thread Andi Shyti
The hardware should not dynamically balance the load between CCS engines. Wa_14019159160 recommends disabling it across all platforms. Fixes: d2eae8e98d59 ("drm/i915/dg2: Drop force_probe requirement") Signed-off-by: Andi Shyti Cc: Chris Wilson Cc: Joonas Lahtinen Cc: Matt Roper Cc: # v6.2+

[PATCH v8 0/3] Disable automatic load CCS load balancing

2024-03-28 Thread Andi Shyti
Hi, I think we are at the end of it and hopefully this is the last version. Thanks Matt for having followed this series until here. This series does basically two things: 1. Disables automatic load balancing as adviced by the hardware workaround. 2. Assigns all the CCS slices to one single

Re: [PATCH v7 2/3] drm/i915/gt: Do not generate the command streamer for all the CCS

2024-03-28 Thread Andi Shyti
Hi Matt, > > + /* > > +* Do not create the command streamer for CCS slices beyond the first. > > +* All the workload submitted to the first engine will be shared among > > +* all the slices. > > +* > > +* Once the user will be allowed to customize the CCS mode, then this > >

[PATCH] drm/i915/gem: Replace dev_priv with i915

2024-03-28 Thread Andi Shyti
Anyone using 'dev_priv' instead of 'i915' in a cleaned-up area should be fined and required to do community service for a few days. I thought I had cleaned up the 'gem/' directory in the past, but still, old aficionados of the 'dev_priv' name keep sneaking it in. Signed-off-by: Andi Shyti Cc:

<    1   2