On Mon, Apr 08, 2024 at 03:54:44PM GMT, Jani Nikula wrote:
The raw register reads/writes are there as micro-optimizations to avoid
multiple pointer indirections on uncore->regs. Presumably this is useful
when there are plenty of register reads/writes in the same
function. However, the display
== Series Details ==
Series: drm/i915/dg2: wait for HuC load completion before running selftests
(rev2)
URL : https://patchwork.freedesktop.org/series/132300/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_14597 -> Patchwork_132300v2
LGTM,
Reviewed-by: Radhakrishna Sripada
> -Original Message-
> From: Intel-xe On Behalf Of Jani
> Nikula
> Sent: Monday, April 8, 2024 5:55 AM
> To: intel-gfx@lists.freedesktop.org; intel...@lists.freedesktop.org
> Cc: Nikula, Jani ; De Marchi, Lucas
>
> Subject: [PATCH 2/2]
LGTM,
Reviewed-by: Radhakrishna Sripada
> -Original Message-
> From: Intel-gfx On Behalf Of Jani
> Nikula
> Sent: Monday, April 8, 2024 5:55 AM
> To: intel-gfx@lists.freedesktop.org; intel...@lists.freedesktop.org
> Cc: Nikula, Jani ; De Marchi, Lucas
>
> Subject: [PATCH 1/2]
On 2024-01-15 11:05, Andri Yngvason wrote:
> From: Werner Sembach
>
> Remove unnecessary SIGNAL_TYPE_HDMI_TYPE_A check that was performed in the
> drm_mode_is_420_only() case, but not in the drm_mode_is_420_also() &&
> force_yuv420_output case.
>
> Without further knowledge if YCbCr 4:2:0 is
I'm a bit late to the game but I don't think this is merged
yet.
On 2024-01-15 11:05, Andri Yngvason wrote:
> From: Werner Sembach
>
> Add a new general drm property "force color format" which can be used
> by userspace to tell the graphics driver which color format to use.
>
> Possible
tree/branch:
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
branch HEAD: 4eab358930711bbeb85bf5ee267d0d42d3394c2c Add linux-next specific
files for 20240417
Error/Warning reports:
https://lore.kernel.org/oe-kbuild-all/202404171743.hfpscodv-...@intel.com
https
== Series Details ==
Series: drm/i915: BXT/GLK per-lane vswing and PHY reg cleanup (rev3)
URL : https://patchwork.freedesktop.org/series/132390/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_14597 -> Patchwork_132390v3
== Series Details ==
Series: drm/i915: BXT/GLK per-lane vswing and PHY reg cleanup (rev3)
URL : https://patchwork.freedesktop.org/series/132390/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
== Series Details ==
Series: drm/i915: BXT/GLK per-lane vswing and PHY reg cleanup (rev3)
URL : https://patchwork.freedesktop.org/series/132390/
State : warning
== Summary ==
Error: dim checkpatch failed
95fc61527473 drm/i915/dpio: Clean up bxt/glk PHY registers
e50c7e29b0ff drm/i915/dpio:
== Series Details ==
Series: drm/i915/hwmon: Get rid of devm (rev6)
URL : https://patchwork.freedesktop.org/series/132400/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_14596 -> Patchwork_132400v6
Summary
---
== Series Details ==
Series: drm/i915/dp: Few MTL/DSC and a UHBR monitor fix (rev4)
URL : https://patchwork.freedesktop.org/series/131386/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_14596 -> Patchwork_131386v4
Summary
== Series Details ==
Series: drm/i915/dp: Few MTL/DSC and a UHBR monitor fix (rev4)
URL : https://patchwork.freedesktop.org/series/131386/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
== Series Details ==
Series: drm/i915/dp: Few MTL/DSC and a UHBR monitor fix (rev4)
URL : https://patchwork.freedesktop.org/series/131386/
State : warning
== Summary ==
Error: dim checkpatch failed
8b46862b3906 drm/i915/dp: Fix DSC line buffer depth programming
0f942ddfee52 drm/i915/dp_mst:
On Wednesday, 17 April 2024 11:37:55 CEST Kamil Konieczny wrote:
> Hi Janusz,
> On 2024-04-15 at 19:31:59 +0200, Janusz Krzysztofik wrote:
> > KUnit can provide KTAP reports from test modules via debugfs files, one
> > per test suite. Using that source of test results instead of extracting
> >
Hi Andi,
On 2024-04-12 at 02:42:55 +0200, Andi Shyti wrote:
> From: Chris Wilson
>
> Based on a test case developed by Lionel Landwerlin, this exercises
> creation of partial mmaps using both direct methods of a partial mmap()
> (where the mmap() only covers a portion of the object) and
>
Hi John,
On 4/17/2024 2:37 AM, John Harrison wrote:
On 4/15/2024 09:44, Nirmoy Das wrote:
Currently intel_gt_reset() happens as follows:
reset_prepare() ---> Sends GDRST to GuC, GuC is in GS_MIA_IN_RESET
do_reset()
__intel_gt_reset()
*_engine_reset_prepare() -->RESET_CTL expects
On Wed, 17 Apr 2024, Thomas Zimmermann wrote:
>> Many thanks! Just to double check, do you want me to move patch 5
>> earlier and squash patches 6&7?
>
> Your choice. Either is fine by me.
I jumped at the easy option and merged this as-is. :)
Thanks again,
Jani.
--
Jani Nikula, Intel
From: Ville Syrjälä
Extract the BXT/GLK DPIO PHY register definitions into their own file.
v2: Adjust gvt accordingly
Reviewed-by: Jani Nikula
Signed-off-by: Ville Syrjälä
---
.../gpu/drm/i915/display/bxt_dpio_phy_regs.h | 273 ++
From: Ville Syrjälä
Add consistent definitions for the per-lane PHY TX registers
on bxt/glk. The current situation is a slight mess with some
registers having a LN0 define, while others have a parametrized
per-lane definition.
v2: Adjust gvt accordingly
Reviewed-by: Jani Nikula
Signed-off-by:
On Wed, 17 Apr 2024 01:28:48 -0700, Andi Shyti wrote:
>
Hi Andi,
> > @@ -839,16 +837,38 @@ void i915_hwmon_register(struct drm_i915_private
> > *i915)
> > if (!hwm_gt_is_visible(ddat_gt, hwmon_energy,
> > hwmon_energy_input, 0))
> > continue;
> >
> > -
When both hwmon and hwmon drvdata (on which hwmon depends) are device
managed resources, the expectation, on device unbind, is that hwmon will be
released before drvdata. However, in i915 there are two separate code
paths, which both release either drvdata or hwmon and either can be
released
== Series Details ==
Series: drm/i915: better high level abstraction for display (rev3)
URL : https://patchwork.freedesktop.org/series/130805/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_14594 -> Patchwork_130805v3
On Wed, Apr 17, 2024 at 04:02:47PM +0300, Jani Nikula wrote:
> Now that the intel_de_ functions and DISPLAY_VER() accept struct
> intel_display *, use it more.
>
> Cc: Luca Coelho
> Signed-off-by: Jani Nikula
Reviewed-by: Rodrigo Vivi
> ---
> drivers/gpu/drm/i915/display/intel_dmc_wl.c | 24
On Wed, Apr 17, 2024 at 04:02:45PM +0300, Jani Nikula wrote:
> Convert the dmc wakelock interface to struct intel_display instead of
> struct drm_i915_private. We'll want to convert the intel_de interfaces,
> and there's a bit of coupling between the two, so start here.
>
> Cc: Luca Coelho
>
== Series Details ==
Series: drm/i915: better high level abstraction for display (rev3)
URL : https://patchwork.freedesktop.org/series/130805/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
== Series Details ==
Series: drm/i915: better high level abstraction for display (rev3)
URL : https://patchwork.freedesktop.org/series/130805/
State : warning
== Summary ==
Error: dim checkpatch failed
36717544b8f3 drm/i915/display: add intel_display -> drm_device backpointer
1c60fd31e388
Enabling the 5k@60Hz uncompressed mode on the MediaTek/Dell U3224KBA
monitor results in a blank screen, at least on MTL platforms on UHBR
link rates with some (<30) uncompressed bpp values. Enabling compression
fixes the problem, so do that for now. Windows enables DSC always if the
sink supports
Factor out a function to check for 128b/132b channel coding support used
by a follow-up patch in the patchset.
v2: s/drm_dp_uhbr_channel_coding_supported()/drm_dp128b132b_supported()
(Jani)
Cc: dri-de...@lists.freedesktop.org
Cc: Jani Nikula
Reviewed-by: Ankit Nautiyal
Reviewed-by: Manasi
Hi Mario,
On Thu, Feb 15, 2024 at 8:04 PM Mario Limonciello
wrote:
> On 2/15/2024 12:47, Ville Syrjälä wrote:
> > On Thu, Feb 15, 2024 at 12:20:56PM -0600, Mario Limonciello wrote:
> >> On 2/14/2024 17:13, Ville Syrjälä wrote:
> >>> On Wed, Feb 14, 2024 at 03:57:54PM -0600, Mario Limonciello
On Wed, Apr 17, 2024 at 04:02:46PM +0300, Jani Nikula wrote:
> It would be too much noise to convert the intel_de_* functions from
> using struct drm_i915_private to struct intel_display all at once. Add
> generic wrappers using __to_intel_display() to accept both.
>
> v2: Take the intel_dmc_wl_*
On Wed, Apr 17, 2024 at 04:02:44PM +0300, Jani Nikula wrote:
> Rename __intel_wait_for_register_nowl() to
> __intel_de_wait_for_register_nowl() to be in line with the rest of
> intel_de.h.
>
> Cc: Luca Coelho
> Signed-off-by: Jani Nikula
Reviewed-by: Rodrigo Vivi
> ---
>
On Wed, Apr 17, 2024 at 04:02:42PM +0300, Jani Nikula wrote:
> Use the generic __to_intel_display() to allow passing either struct
> drm_i915_private * or struct intel_display * to the feature test macros.
>
> Signed-off-by: Jani Nikula
Reviewed-by: Rodrigo Vivi
> ---
>
Hi Sima and Dave,
Here goes our biggest pull request of this round.
Likely a small pull request coming end of next week as well.
I had to bypass dim on missed link tag in a patch that was a urgent revert
and ended up without the patchwork link.
(Which btw I'm proposing an option to dim for
On 4/12/2024 2:42 AM, Andi Shyti wrote:
From: Chris Wilson
Based on a test case developed by Lionel Landwerlin, this exercises
creation of partial mmaps using both direct methods of a partial mmap()
(where the mmap() only covers a portion of the object) and
munmap() to do the same.
On Tue, 16 Apr 2024, Rodrigo Vivi wrote:
> On Tue, Apr 09, 2024 at 03:26:48PM +0300, Jani Nikula wrote:
>> It would be too much noise to convert the intel_de_* functions from
>> using struct drm_i915_private to struct intel_display all at once. Add
>> generic wrappers using __to_intel_display()
On Tue, 16 Apr 2024, Rodrigo Vivi wrote:
> On Tue, Apr 09, 2024 at 03:26:47PM +0300, Jani Nikula wrote:
>> Use the generic __to_intel_display() to allow passing either struct
>> drm_i915_private * or struct intel_display * to the feature test macros.
>>
>> Unfortunately, this requires including
On Mon, Apr 15, 2024 at 03:39:41PM +0300, Jani Nikula wrote:
> On Fri, 12 Apr 2024, Ville Syrjala wrote:
> > From: Ville Syrjälä
> >
> > Since all of this lives in intel_dpio_phy.c let's rename the
> > bxt/glk functions to have bxt_dpio_phy_ namespace.
>
> Seems like intel_dpio_phy.c could be
On Wed, 17 Apr 2024, Jani Nikula wrote:
> On Tue, 16 Apr 2024, Rodrigo Vivi wrote:
>> On Tue, Apr 09, 2024 at 03:26:46PM +0300, Jani Nikula wrote:
>>> Add generic __to_intel_display() macro that accepts either struct
>>> xe_device * or struct intel_display *. This is to be used for
>>>
Now that the intel_de_ functions and DISPLAY_VER() accept struct
intel_display *, use it more.
Cc: Luca Coelho
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_dmc_wl.c | 24 +
1 file changed, 10 insertions(+), 14 deletions(-)
diff --git
It would be too much noise to convert the intel_de_* functions from
using struct drm_i915_private to struct intel_display all at once. Add
generic wrappers using __to_intel_display() to accept both.
v2: Take the intel_dmc_wl_* changes into account
Cc: Luca Coelho
Reviewed-by: Rodrigo Vivi # v1
Convert the dmc wakelock interface to struct intel_display instead of
struct drm_i915_private. We'll want to convert the intel_de interfaces,
and there's a bit of coupling between the two, so start here.
Cc: Luca Coelho
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_de.h
Rename __intel_wait_for_register_nowl() to
__intel_de_wait_for_register_nowl() to be in line with the rest of
intel_de.h.
Cc: Luca Coelho
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_de.h | 6 +++---
drivers/gpu/drm/i915/display/intel_dmc_wl.c | 14 +++---
2
Use struct intel_display instead of struct drm_i915_private for
quirks. Also do drive-by conversions in call sites of intel_has_quirk().
Reviewed-by: Rodrigo Vivi
Signed-off-by: Jani Nikula
---
.../gpu/drm/i915/display/intel_backlight.c| 40 ++---
Use the generic __to_intel_display() to allow passing either struct
drm_i915_private * or struct intel_display * to the feature test macros.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_display_device.h | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git
Add generic __to_intel_display() macro that accepts either struct
drm_i915_private * or struct intel_display *. This is to be used for
transitional stuff that eventually needs to be converted to use struct
intel_display *, and therefore is not part of to_intel_display().
Add new
Convert various pointers to struct intel_display * using _Generic().
Add some macro magic to make adding new conversions easier, and somewhat
abstract the need to cast each generic association. The cast is required
because all associations needs to compile, regardless of the type and
the generic
As a baby step towards making struct intel_display the main data
structure for display, add a backpointer to struct drm_device that can
be used instead of >drm.
Reviewed-by: Rodrigo Vivi
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_display_core.h | 3 +++
v4 of [1].
Had to do some rebasing and add some more patches to accommodate dmc
wakelock changes and their impact on intel_de.h. As a byproduct, convert
intel_dmc_wl.[ch] to struct intel_display as well.
With the __to_intel_display() shoved into a separate file, no changes
are needed in xe side
On 4/17/2024 3:40 AM, Imre Deak wrote:
The DSC DPT interface BW limit check should take into account the link
clock's (aka DDI clock in bspec) channel coding efficiency overhead.
Bspec suggests that the FEC overhead needs to be applied, however HW
people claim this isn't the case, nor is any
Hi,
https://patchwork.freedesktop.org/series/129123/ - Re-reported.
Thanks,
Tejasree
From: I915-ci-infra On Behalf Of
Luca Coelho
Sent: Wednesday, April 17, 2024 12:49 PM
To: i915-ci-in...@lists.freedesktop.org
Cc: Coelho, Luciano ; intel-gfx@lists.freedesktop.org
Subject: Re: ✗ Fi.CI.BAT:
== Series Details ==
Series: drm/i915: limit eDP MSO pipe only for display version 20 and below
(rev4)
URL : https://patchwork.freedesktop.org/series/129123/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_14583 -> Patchwork_129123v4
== Series Details ==
Series: drm/i915/hdcp: Disable HDCP Line Rekeying for HDCP2.2 on HDMI (rev3)
URL : https://patchwork.freedesktop.org/series/132479/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_14593 -> Patchwork_132479v3
On Wed, Apr 17, 2024 at 12:21:58PM +0300, Jani Nikula wrote:
> On Wed, 17 Apr 2024, Imre Deak wrote:
> > Factor out a function to check for UHBR channel coding support used by a
> > follow-up patch in the patchset.
> >
> > Cc: dri-de...@lists.freedesktop.org
> > Reviewed-by: Ankit Nautiyal
> >
On Wed, Apr 17, 2024 at 12:39:40PM +0300, Jani Nikula wrote:
> On Wed, 17 Apr 2024, Imre Deak wrote:
> > Enabling the 5k@60Hz uncompressed mode on the MediaTek/Dell U3224KBA
> > monitor results in a blank screen, at least on MTL platforms on UHBR
> > link rates with some (<30) uncompressed bpp
On Wed, 17 Apr 2024, Luca Coelho wrote:
> On Wed, 2024-04-17 at 12:42 +0300, Jani Nikula wrote:
>> On Mon, 15 Apr 2024, Luca Coelho wrote:
>> > Thanks a lot for your reviews! Now I just need to get someone to merge
>> > this series, since I don't have commit rights to the repo yet.
>>
>> Thanks
> -Original Message-
> From: Sebastian Wick
> Sent: Wednesday, April 17, 2024 3:54 PM
> To: Kandpal, Suraj
> Cc: intel-gfx@lists.freedesktop.org; Borah, Chaitanya Kumar
> ; Shankar, Uma
> ; Nautiyal, Ankit K ;
> Murthy, Arun R ; Nikula, Jani
> ; Kumar, Naveen1
> Subject: Re: [5/6]
Hi
Am 17.04.24 um 10:21 schrieb Jani Nikula:
On Tue, 16 Apr 2024, Thomas Zimmermann wrote:
Hi
Am 16.04.24 um 14:27 schrieb Jani Nikula:
On Tue, 16 Apr 2024, Thomas Zimmermann wrote:
Hi
Am 16.04.24 um 11:20 schrieb Jani Nikula:
Repurpose drm_edid_are_equal() to be more helpful for its
On Wed, Apr 17, 2024 at 04:58:06AM +, Kandpal, Suraj wrote:
>
>
> > -Original Message-
> > From: Sebastian Wick
> > Sent: Tuesday, April 16, 2024 7:10 PM
> > To: Kandpal, Suraj
> > Cc: intel-gfx@lists.freedesktop.org; Borah, Chaitanya Kumar
> > ; Shankar, Uma
> > ; Nautiyal, Ankit
Disable HDCP Line Rekeying when HDCP ver > 1.4 and when we are
on HDMI TMDS operation for DISPLAY_VER >= 14.
--v2
-Wa to be mentioned in comments not in commit message [Jani]
-Remove blankline [Jani]
--v3
-No need to write what is being done in comments when code
is self explanatory [Jani]
On Tue, 16 Apr 2024, Rodrigo Vivi wrote:
> On Tue, Apr 09, 2024 at 03:26:46PM +0300, Jani Nikula wrote:
>> Add generic __to_intel_display() macro that accepts either struct
>> xe_device * or struct intel_display *. This is to be used for
>> transitional stuff that eventually needs to be converted
On Wed, 2024-04-17 at 12:42 +0300, Jani Nikula wrote:
> On Mon, 15 Apr 2024, Luca Coelho wrote:
> > Thanks a lot for your reviews! Now I just need to get someone to merge
> > this series, since I don't have commit rights to the repo yet.
>
> Thanks for the patches and review, merged to
On Mon, 15 Apr 2024, Luca Coelho wrote:
> Thanks a lot for your reviews! Now I just need to get someone to merge
> this series, since I don't have commit rights to the repo yet.
Thanks for the patches and review, merged to drm-intel-next with a
slightly heavy heart because it sets me back with
On Wed, 17 Apr 2024, Imre Deak wrote:
> Enabling the 5k@60Hz uncompressed mode on the MediaTek/Dell U3224KBA
> monitor results in a blank screen, at least on MTL platforms on UHBR
> link rates with some (<30) uncompressed bpp values. Enabling compression
> fixes the problem, so do that for now.
Hi Janusz,
On 2024-04-15 at 19:31:59 +0200, Janusz Krzysztofik wrote:
> KUnit can provide KTAP reports from test modules via debugfs files, one
> per test suite. Using that source of test results instead of extracting
> them from dmesg, where they may be interleaved with other kernel messages,
>
On Wed, 17 Apr 2024, Imre Deak wrote:
> Factor out a function to check for UHBR channel coding support used by a
> follow-up patch in the patchset.
>
> Cc: dri-de...@lists.freedesktop.org
> Reviewed-by: Ankit Nautiyal
> Reviewed-by: Manasi Navare
> Acked-by: Maarten Lankhorst
> Signed-off-by:
On Thu, 28 Mar 2024, "Suesens, Sebastian" wrote:
> Hello,
>
> I enabled the CMA (CONFIG_CMA=y) for an x86 machine on Linux kernel v5.10 and
> v5.15 When I boot the system the CMA reserved memory, but when the graphic
> card driver i915 or hda_intel is loaded the system crashed.
> I see that
== Series Details ==
Series: Add support for partial mapping (rev8)
URL : https://patchwork.freedesktop.org/series/131817/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_14592 -> Patchwork_131817v8
Summary
---
== Series Details ==
Series: Add support for partial mapping (rev8)
URL : https://patchwork.freedesktop.org/series/131817/
State : warning
== Summary ==
Error: dim checkpatch failed
ab5423884e51 drm/i915/gem: Increment vma offset when mapping fb objects
392a8980f647 drm/i915/gem: Do not look
Hi Ashutosh,
> @@ -839,16 +837,38 @@ void i915_hwmon_register(struct drm_i915_private *i915)
> if (!hwm_gt_is_visible(ddat_gt, hwmon_energy,
> hwmon_energy_input, 0))
> continue;
>
> - hwmon_dev = devm_hwmon_device_register_with_info(dev,
>
On Tue, 16 Apr 2024, Thomas Zimmermann wrote:
> Hi
>
> Am 16.04.24 um 14:27 schrieb Jani Nikula:
>> On Tue, 16 Apr 2024, Thomas Zimmermann wrote:
>>> Hi
>>>
>>> Am 16.04.24 um 11:20 schrieb Jani Nikula:
Repurpose drm_edid_are_equal() to be more helpful for its single user,
and rename
== Series Details ==
Series: drm/i915/hwmon: Get rid of devm (rev5)
URL : https://patchwork.freedesktop.org/series/132400/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_14592 -> Patchwork_132400v5
Summary
---
Hi,
The skip in igt@kms_cursor_legacy@basic-flip-before-cursor-atomic on
fi-rkl-11600 is not related to my patch. There doesn't seem to be any
displays connected to that machine at the moment and all runs are
failing, for example the latest run with CI_DRM_14591.
Same thing with the other "new"
== Series Details ==
Series: drm/i915/pps: Disable DPLS_GATING around pps sequence (rev2)
URL : https://patchwork.freedesktop.org/series/132495/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_14591 -> Patchwork_132495v2
74 matches
Mail list logo
