Hi Andi,
[...]
> > --- a/drivers/gpu/drm/drm_mode_config.c
> > +++ b/drivers/gpu/drm/drm_mode_config.c
> > @@ -471,7 +471,7 @@ int drmm_mode_config_init(struct drm_device *dev)
> > ret = drm_modeset_lock(&dev->mode_config.connection_mutex,
> >&modeset
== Series Details ==
Series: drm/i915/xe3: Restrict PTL intel_encoder_is_c10phy() to only PHY A
URL : https://patchwork.freedesktop.org/series/154220/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_17155 -> Patchwork_154220v1
On PTL, no combo PHY is connected to PORT B. However, PORT B can
still be used for Type-C and will utilize the C20 PHY for eDP
over Type-C. In such configurations, VBTs also enumerate PORT B.
This leads to issues where PORT B is incorrectly identified as using the
C10 PHY, due to the assumption th
On 9/2/2025 8:14 AM, Zhanjun Dong wrote:
Boolean flag access from interrupt context might have synchronous issueis
on multiple processor platform, flags modified by one core might be read
as an old value by another core. This issue on interrupt enable flag might
causes interrupt misses or leak
On Fri, 05 Sep 2025, Ville Syrjälä wrote:
> On Wed, Sep 03, 2025 at 11:31:59PM +0300, Jani Nikula wrote:
>> Add new helper intel_fbdev_fb_pitch_align() in preparation for further
>> refactoring. The alignment is different for i915 and xe.
>>
>> Signed-off-by: Jani Nikula
>> ---
>> drivers/gpu/d
== Series Details ==
Series: drm/i915/wm: some clean-ups and a bit of refactoring
URL : https://patchwork.freedesktop.org/series/154166/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_17150 -> Patchwork_154166v1
Summary
Hi Daniel,
On 28.08.2025 10:04, Daniel Almeida wrote:
> Add an initial test suit covering query device properties, allocating
> memory, binding and unbinding VA ranges through VM_BIND and submitting a
> simple piece of work through GROUP_SUBMIT.
> ---
> lib/igt_panthor.c | 136 +++
== Series Details ==
Series: drm/i915/display: add intel_display_device_present() (rev3)
URL : https://patchwork.freedesktop.org/series/149535/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_17150 -> Patchwork_149535v3
Summa
== Series Details ==
Series: drm/i915: Remove legacy struct_mutex usage (rev4)
URL : https://patchwork.freedesktop.org/series/152533/
State : failure
== Summary ==
Address 'luiz.me...@estudante.ufscar.br' is not on the allowlist, which
prevents CI from being triggered for this patch.
If you w
There are two unsafe scenarios in that function:
1) drm_format_info_block_width/height() may return 0 and cause
division by 0 down the line. Return early if any of these values
are 0.
2) dma_addr calculations are carried out using 32-bit
arithmetic, which could cause a truncation of the values
be
Following the error path in that function may lead to usage of
uninitialized struct i915_gem_ww_ctx object, so move call to
i915_gem_ww_ctx_init() a bit earlier.
Fixes: 15b6c9249870 ("drm/i915: Move i915_vma_lock in the selftests to avoid
lock inversion, v3.")
Cc: Maarten Lankhorst
Cc: # v5.10+
Isolate the code that handles method selection and calculation, so
skl_compute_plane_wm() doesn't get too long.
Signed-off-by: Luca Coelho
---
drivers/gpu/drm/i915/display/skl_watermark.c | 51
1 file changed, 31 insertions(+), 20 deletions(-)
diff --git a/drivers/gpu/drm/i
On Mon, 08 Sep 2025, Krzysztof Karas wrote:
> Krzysztof Karas (6):
> drm/i915/gem: Avoid accessing uninitialized context in
> emit_rpcs_query()
> drm/i915: Add default case for the switch in igt_smoke_tiling()
i915 and drm changes should be sent separately when the changes have no
depende
> -Original Message-
> From: Intel-xe On Behalf Of Ankit
> Nautiyal
> Sent: Sunday, September 7, 2025 1:02 PM
> To: intel-gfx@lists.freedesktop.org; intel...@lists.freedesktop.org
> Cc: ville.syrj...@linux.intel.com; Nautiyal, Ankit K
>
> Subject: [PATCH 01/14] drm/i915/vrr: Use crtc_
On Fri, Sep 5, 2025 at 3:24 PM Zihuan Zhang wrote:
>
> Replace the manual cpufreq_cpu_put() with __free(put_cpufreq_policy)
> annotation for policy references. This reduces the risk of reference
> counting mistakes and aligns the code with the latest kernel style.
>
> No functional change intended
On Mon, Sep 8, 2025 at 11:16 AM Zihuan Zhang wrote:
>
>
> 在 2025/9/6 04:17, Rafael J. Wysocki 写道:
> > On Fri, Sep 5, 2025 at 3:24 PM Zihuan Zhang wrote:
> >> Replace the manual cpufreq_cpu_put() with __free(put_cpufreq_policy)
> >> annotation for policy references. This reduces the risk of refere
This patch completes the removal of struct_mutex from the driver.
Remove the related TODO item, as the transition away from struct_mutex
is now complete.
Also clean up references to struct_mutex in i915.rst to avoid outdated
documentation.
Signed-off-by: Luiz Otavio Mello
Reviewed-by: Rodrigo V
Applied this one, actually. Thank you.
Applied, thanks.
-next label are you on? next-20250908 should no longer have that
> commit.
Ah, sorry - it was Friday's -next but I only saw the report this
morning. Sorry for the noise.
signature.asc
Description: PGP signature
On Thu, 04 Sep 2025, Ville Syrjälä wrote:
> On Wed, Sep 03, 2025 at 11:32:04PM +0300, Jani Nikula wrote:
>> With the bo creation helper in place, we can lift
>> intel_framebuffer_create() part to common code.
>>
>> Signed-off-by: Jani Nikula
>> ---
>> drivers/gpu/drm/i915/display/intel_fbdev.c
On Mon, Sep 01, 2025 at 05:03:40PM +0200, David Hildenbrand wrote:
> We can just cleanup the code by calculating the #refs earlier,
> so we can just inline what remains of record_subpages().
>
> Calculate the number of references/pages ahead of times, and record them
> only once all our tests pass
On Mon, 08 Sep 2025, Jani Nikula wrote:
> On Mon, 08 Sep 2025, Krzysztof Karas wrote:
>> Fields hdiplay and vdisplay are defined as u16. Their
>> multiplication causes implicit promotion to signed 32-bit value,
>> which may overflow and cause undefined behavior.
>>
>> The same goes for vpos, whic
The intel_guc_log->relay.lock is currently initialized in
intel_guc_log_init_early(), but it lacks a corresponding destructor,
which can lead to a memory leak.
This patch replaces the use of mutex_init() with drmm_mutex_init(),
which ensures the lock is properly destroyed when the driver is
unload
On Mon, Sep 08, 2025 at 03:55:18PM +0300, Jani Nikula wrote:
On Fri, 05 Sep 2025, Ville Syrjälä wrote:
On Wed, Sep 03, 2025 at 11:31:59PM +0300, Jani Nikula wrote:
Add new helper intel_fbdev_fb_pitch_align() in preparation for further
refactoring. The alignment is different for i915 and xe.
S
Move pointer related utilities from i915_utils.h to a separate new
i915_ptr_util.h header. Clean up related includes.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/gt/intel_context_types.h | 1 -
drivers/gpu/drm/i915/gt/intel_timeline.h | 1 +
drivers/gpu/drm/i915/i915_ptr_util.h
Move waiting related utilities from i915_utils.h to separate new file
i915_wait_util.h. Clean up related includes.
Note: Many of the various wait macro usages could likely be refactored
to use poll_timeout_us().
Signed-off-by: Jani Nikula
---
.../drm/i915/gt/intel_execlists_submission.c | 1
Move list related utilities from i915_utils.h to separate new file
i915_list_util.h. Clean up related includes.
Note: Arguably none of this should exist in i915 in the first place. At
least isolate it better.
Signed-off-by: Jani Nikula
---
.../drm/i915/gt/intel_execlists_submission.c | 1 +
.
Neither intel_guc.h nor i915_gem.h need i915_utils.h anymore. Just drop
the includes.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/gt/uc/intel_guc.h | 1 -
drivers/gpu/drm/i915/i915_gem.h| 2 --
2 files changed, 3 deletions(-)
diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc.h
On 08/09/2025 14:15, Luiz Otavio Mello wrote:
Move legacy BKL struct_mutex from drm_device to drm_i915_private, which
is the last remaining user.
Signed-off-by: Luiz Otavio Mello
Reviewed-by: Rodrigo Vivi
---
drivers/gpu/drm/drm_drv.c | 2 --
drivers/gpu/drm/i915/gt/uc/i
I tried to look but can't find any reason why here was needed
GRAPHICS_VER(), probably was something that's not anymore. In any case
as Jani wrote GRAPHICS_VER() need to be removed from display code and
if something breaks from this I think it will come to my list of
things to fix..
Reviewed-by: J
On Sat, Sep 06, 2025 at 08:56:48AM +0200, David Hildenbrand wrote:
> On 06.09.25 03:05, John Hubbard wrote:
> >
> > Probably a similar sentiment as Lorenzo here...the above diffs make the code
> > *worse* to read. In fact, I recall adding record_subpages() here long ago,
> > specifically to help cl
On Thu, 04 Sep 2025, Ville Syrjälä wrote:
> On Wed, Sep 03, 2025 at 11:32:03PM +0300, Jani Nikula wrote:
>> xe does xe_bo_unpin_map_no_vm() on the failure path. Add a common helper
>> to enable further refactoring.
>>
>> Signed-off-by: Jani Nikula
>> ---
>> drivers/gpu/drm/i915/display/intel_fb
On Mon, 2025-09-08 at 09:43 -0300, Gustavo Sousa wrote:
> Quoting Luca Coelho (2025-09-08 04:35:33-03:00)
> > There are currently two booleans to define three tiling modes, which
> > is bad practice because it allows representing an invalid mode. In
> > order to simplify this, convert these two bo
Quoting Luca Coelho (2025-09-08 04:35:34-03:00)
>Make the code a bit clearer by using a switch-case to check the tiling
>mode in skl_compute_plane_wm(), because all the possible states and
>the calculations they use are explicitly handled.
>
>Signed-off-by: Luca Coelho
>---
> drivers/gpu/drm/i915/
On Thu, 04 Sep 2025, Kees Cook wrote:
> On Thu, Sep 04, 2025 at 10:34:04AM +0300, Jani Nikula wrote:
>> On Wed, 03 Sep 2025, Kees Cook wrote:
>> > On Fri, Aug 29, 2025 at 08:46:01PM +0300, Jani Nikula wrote:
>> >> Move the range_overflows() and range_end_overflows() along with the _t
>> >> varian
Quoting Luca Coelho (2025-09-08 04:35:33-03:00)
>There are currently two booleans to define three tiling modes, which
>is bad practice because it allows representing an invalid mode. In
>order to simplify this, convert these two booleans into one
>enumeration with three possible tiling modes.
>
>A
The struct_mutex field in drm_i915_private is no longer used anywhere in
the driver. This patch removes it completely to clean up unused code and
avoid confusion.
Signed-off-by: Luiz Otavio Mello
Reviewed-by: Rodrigo Vivi
---
drivers/gpu/drm/i915/i915_driver.c | 2 --
drivers/gpu/drm/i915/i915_
On Fri, 2025-08-29 at 20:46 +0300, Jani Nikula wrote:
> Move the range_overflows() and range_end_overflows() along with the
> _t
> variants over from drm/i915 and drm/buddy to overflow.h.
>
> Cc: Kees Cook
> Cc: Gustavo A. R. Silva
> Cc: linux-harden...@vger.kernel.org
> Signed-off-by: Jani Niku
On Fri, 2025-08-29 at 20:46 +0300, Jani Nikula wrote:
> Document the macros in preparation for making them more generally
> available.
>
> Cc: Kees Cook
> Cc: Gustavo A. R. Silva
> Cc: linux-harden...@vger.kernel.org
> Signed-off-by: Jani Nikula
Reviewed-by: Jouni Högander
> ---
> drivers/g
The struct_mutex will be removed from the DRM subsystem, as it was a
legacy BKL that was only used by i915 driver. After review, it was
concluded that its usage was no longer necessary
This patch update a comment about struct_mutex in i915/display, in order
to prevent future misunderstandings.
*
Remove the use of struct_mutex from intel_guc_log.c and replace it with
a dedicated lock, guc_lock, defined within the intel_guc_log struct.
The struct_mutex was previously used to protect concurrent access and
modification of intel_guc_log->level in intel_guc_log_set_level().
However, it was
Remove struct_mutex from ivb_parity_work() function.
The ivb_parity_work runs in a workqueue so it cannot race with itself.
Also, it is not protecting anything with the other remaining usage of
struct_mutex.
Signed-off-by: Luiz Otavio Mello
Suggested-by: Rodrigo Vivi
Reviewed-by: Rodrigo Vivi
Move legacy BKL struct_mutex from drm_device to drm_i915_private, which
is the last remaining user.
Signed-off-by: Luiz Otavio Mello
Reviewed-by: Rodrigo Vivi
---
drivers/gpu/drm/drm_drv.c | 2 --
drivers/gpu/drm/i915/gt/uc/intel_guc_log.c | 4 ++--
drivers/gpu/drm/i915/i915_
This patch series completes the long-standing effort to eliminate usage
of the legacy struct_mutex from i915 driver.
Historically, struct_mutex was used to serialize access to global driver
state across the DRM subsystem. Over time, it has been gradually
replaced by more fine-grained and localized
On Thu, 04 Sep 2025, Jocelyn Falempe wrote:
> On 02/09/2025 19:51, Jani Nikula wrote:
>> Split out intel_panic functionality separate from intel_bo abstraction,
>> and lift the framebuffer allocation back to where it belongs in
>> intel_fb.c.
>>
>> There's more that should be improved, ideally ma
Hi Krzysztof
On Mon Sep 8, 2025 at 9:25 AM UTC, Krzysztof Karas wrote:
> There are two unsafe scenarios in that function:
> 1) drm_format_info_block_width/height() may return 0 and cause
> division by 0 down the line. Return early if any of these values
> are 0.
> 2) dma_addr calculations are ca
> -Original Message-
> From: Shankar, Uma
> Sent: Thursday, September 4, 2025 3:24 PM
> To: intel-gfx@lists.freedesktop.org; intel...@lists.freedesktop.org
> Cc: ville.syrj...@linux.intel.com; Govindapillai, Vinod
> ; Cavitt, Jonathan ;
> Shankar, Uma ; Srinivas, Vidya
>
> Subject: [v4
Hi Krzysztof,
On Mon, Sep 08, 2025 at 09:23:56AM +, Krzysztof Karas wrote:
> To calm down static analysers define a default case and break
> out of the test.
>
> Cc: Chris Wilson
> Signed-off-by: Krzysztof Karas
> ---
> drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c | 4 +++-
> 1 file
On Sun, 07 Sep 2025, Juha-Pekka Heikkilä wrote:
> On Thu, Sep 4, 2025 at 7:56 PM Matt Atwood wrote:
>>
>> On Thu, Sep 04, 2025 at 01:53:01PM -0300, Gustavo Sousa wrote:
>> > Quoting Matt Atwood (2025-09-03 14:08:21-03:00)
>> > >The checks in plane_has_modifier() should check against display versi
On Wed, 03 Sep 2025, "Nautiyal, Ankit K" wrote:
> On 9/3/2025 3:40 PM, Jani Nikula wrote:
>> The encoder name deduction has become a bit cumbersome within
>> intel_ddi_init(). Split it out to a separate function to declutter
>> intel_ddi_init(), even if that means having to use a temp seq buffer f
On Fri, 05 Sep 2025, Matt Roper wrote:
> On Fri, Sep 05, 2025 at 01:41:49PM +0300, Jani Nikula wrote:
>> for_each_set_bit() expects size to be in bits, not bytes. The abox mask
>> iteration uses bytes, but it works by coincidence, because the local
>> variable holding the mask is unsigned long, an
On Mon, 08 Sep 2025, Krzysztof Karas wrote:
> Fields hdiplay and vdisplay are defined as u16. Their
> multiplication causes implicit promotion to signed 32-bit value,
> which may overflow and cause undefined behavior.
>
> The same goes for vpos, which is multiplied by signed integer.
>
> Prevent p
Fields hdiplay and vdisplay are defined as u16. Their
multiplication causes implicit promotion to signed 32-bit value,
which may overflow and cause undefined behavior.
The same goes for vpos, which is multiplied by signed integer.
Prevent possible undefined behavior by explicitly casting one of
t
On Mon, Sep 08, 2025 at 05:12:37PM +0800, Zihuan Zhang wrote:
> > From: Documentation/process/submitting-patches.rst
> >
> > Don't get discouraged - or impatient
> >
> >
> > After you have submitted your change, be patient and wait. Reviewers are
> > busy peo
To calm down static analysers define a default case and break
out of the test.
Cc: Chris Wilson
Signed-off-by: Krzysztof Karas
---
drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/gem/selftests/i915_ge
Krzysztof Karas (6):
drm/i915/gem: Avoid accessing uninitialized context in
emit_rpcs_query()
drm/i915: Add default case for the switch in igt_smoke_tiling()
drm: Remove drm_modeset_backoff() return code
drm: Avoid suspicious operations in drm_fb_dma_get_gem_addr()
drm: Do not attempt
On 8/13/2025 10:50 AM, Nemesa Garg wrote:
From display 14 onward do not enable the cursor
size reduction bit as it has been defeatured.
Bspec: 50372
Signed-off-by: Nemesa Garg
LGTM
Reviewed-by: Chaitanya Kumar Borah
---
drivers/gpu/drm/i915/display/intel_cursor.c | 2 +-
1 file cha
> -Original Message-
> From: Intel-xe On Behalf Of Ankit
> Nautiyal
> Sent: Sunday, September 7, 2025 1:03 PM
> To: intel-gfx@lists.freedesktop.org; intel...@lists.freedesktop.org
> Cc: ville.syrj...@linux.intel.com; Nautiyal, Ankit K
>
> Subject: [PATCH 11/14] drm/i915/dsb: Align fli
Roughly, what I am thinking (limiting it to pte+pmd case) about is the
following:
The code below looks much cleaner, that's great!
Great, I (or Aristeu if he has capacity) will clean this all up soon.
--
Cheers
David / dhildenb
There are currently two booleans to define three tiling modes, which
is bad practice because it allows representing an invalid mode. In
order to simplify this, convert these two booleans into one
enumeration with three possible tiling modes.
Additionally, introduce the concept of Y "family" of ti
There's no need to have a forward-declaration for skl_sagv_disable(),
so move the intel_sagv_init() function below the called function to
prevent it.
Signed-off-by: Luca Coelho
---
drivers/gpu/drm/i915/display/skl_watermark.c | 60 ++--
1 file changed, 29 insertions(+), 31 deleti
Make the code a bit clearer by using a switch-case to check the tiling
mode in skl_compute_plane_wm(), because all the possible states and
the calculations they use are explicitly handled.
Signed-off-by: Luca Coelho
---
drivers/gpu/drm/i915/display/skl_watermark.c | 24 +---
1 fi
This FIXME has been there forever and apparently the _proper code_ has
never been added, and, since it's a very old platform alreday, most
likely never will. It hasn't been a problem to keep the workaround
for all cases, so let's drop the FIXME tag.
Signed-off-by: Luca Coelho
---
drivers/gpu/dr
On Fri, 2025-09-05 at 10:27 +0300, Jouni Högander wrote:
> We are currently observing crc failures after we started using dsb
> for PSR
> updates as well. This seems to happen because PSR HW is still sending
> couple of updates using old framebuffers on wake-up.
>
> On non-dsb commit we are waitin
On Sat, 2025-09-06 at 15:39 +0200, Michał Grzelak wrote:
> On Wed, 27 Aug 2025 09:08:09 +0300, Jouni Högander wrote:
> > Currently return value of drm_dpcd_readb is not checked when
> > reading sink
> > Panel Replay Selective Update capabilities.
> >
> > Fix this and switch to drm_dpcd_read_byte.
66 matches
Mail list logo
