(>connector, tc->bridge.encoder);
The sii902x driver sets the bus_formats in get_modes, but it's a fixed
value and we may as well do it in bridge's attach op.
For the bridge drivers:
Reviewed-by: Archit Taneja <arch...@codeaurora.org>
Thanks,
Archit
_
since that's the
mode the user provided and it matches the plane crtc coordinates
the user also provided.
Once everyone agrees on this we can move the clip handling into
drm_atomic_helper_check_plane_state().
For this and the msm change in patch # 15/15:
Reviewed-by: Archit Taneja <arch...
drivers:
Acked-by: Archit Taneja <arch...@codeaurora.org>
Thanks,
Archit
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
On 07/25/2017 01:31 PM, Daniel Vetter wrote:
It's dead code, the core handles all this directly now. This also
allows us to unexport drm_atomic_helper_plane_set_property.
Reviewed-by: Archit Taneja <arch...@codeaurora.org>
Signed-off-by: Daniel Vetter <daniel.vet...@intel.com&g
On 07/25/2017 01:31 PM, Daniel Vetter wrote:
It's dead code because this is now handled in the core.
Reviewed-by: Archit Taneja <arch...@codeaurora.org>
Signed-off-by: Daniel Vetter <daniel.vet...@intel.com>
Cc: Boris Brezillon <boris.brezil...@free-electrons.com>
it actually work ...
Reviewed-by: Archit Taneja <arch...@codeaurora.org>
Signed-off-by: Daniel Vetter <daniel.vet...@intel.com>
---
drivers/gpu/drm/drm_atomic.c| 60 ++--
drivers/gpu/drm/drm_connector.c | 6 +-
drivers/gpu/drm/drm_crtc_help
| 1 -
drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 1 -
drivers/gpu/drm/bridge/tc358767.c | 1 -
drivers/gpu/drm/bridge/ti-tfp410.c | 1 -
For bridge changes:
Acked-by: Archit Taneja <arch...@codeaurora.org>
Archit
--
Qualcomm Inno
ive instead of
crtc_state->enable when waiting for completion.
Tested-by: Archit Taneja <arch...@codeaurora.org>
Signed-off-by: Maarten Lankhorst <maarten.lankho...@linux.intel.com>
Cc: Rob Clark <robdcl...@gmail.com>
Cc: Archit Taneja <arch...@codeaurora.org>
Cc: Vincent
On 07/18/2017 01:20 PM, Daniel Vetter wrote:
On Tue, Jul 18, 2017 at 10:15:25AM +0300, Jani Nikula wrote:
The refactoring dropped a cd to the drm-rerere dir, leading to "cp:
cannot stat 'rr-cache/*': No such file or directory" on dim ub.
Reported-by: Archit Taneja <arch...@c
future.
Reviewed-by: Archit Taneja <arch...@codeaurora.org>
v4:
- fix state->crtc NULL check (Archit Taneja)
v3:
- fix iteration on the wrong crtc state
- put back code to forbid updates if there is a queued update for
the same plane (Ville Syrjälä)
atomic.
Tested-by: Archit Taneja <arch...@codeaurora.org>
v4: add missing atomic async commit call to msm_atomic_commit(Archit Taneja)
v3: move size checks back to drivers (Ville Syrjälä)
v2: move fb setting to core and use new state (Eric Anholt)
Cc: Rob Clark <robdcl...@gmail.com>
Cc: A
On 05/26/2017 01:21 AM, Gustavo Padovan wrote:
From: Gustavo Padovan <gustavo.pado...@collabora.com>
After converting legacy cursor updates to atomic async commits
mdp5_cursor_plane_funcs just duplicates mdp5_plane_funcs now.
Tested-by: Archit Taneja <arch...@codeaurora.org&g
ard and lots more
people it'll take a while to get there. For now this is good enough I
think.
All true.
Reviewed-by: Daniel Stone <dani...@collabora.com>
Thanks for this, Daniel!
Reviewed-by: Sumit Semwal <sumit.sem...@linaro.org>
Acked-by: Archit Taneja <arch...@codeaurora.o
On 02/22/2017 05:31 AM, Pandiyan, Dhinakaran wrote:
On Fri, 2017-02-17 at 15:37 +0530, Archit Taneja wrote:
On 02/16/2017 05:43 AM, Pandiyan, Dhinakaran wrote:
On Wed, 2017-02-15 at 16:53 +0530, Archit Taneja wrote:
Hi,
On 02/09/2017 12:08 PM, Dhinakaran Pandiyan wrote:
It is necessary
On 02/16/2017 05:43 AM, Pandiyan, Dhinakaran wrote:
On Wed, 2017-02-15 at 16:53 +0530, Archit Taneja wrote:
Hi,
On 02/09/2017 12:08 PM, Dhinakaran Pandiyan wrote:
It is necessary to track states for objects other than connector, crtc
and plane for atomic modesets. But adding objects like DP
Hi,
On 02/09/2017 12:08 PM, Dhinakaran Pandiyan wrote:
It is necessary to track states for objects other than connector, crtc
and plane for atomic modesets. But adding objects like DP MST link
bandwidth to drm_atomic_state would mean that a non-core object will be
modified by the core helper
drive-by polish where it makes sense, I read a lot
of docs ...
This seems like a leftover from the older version of the patch, which
we decided to not take. I guess we could drop it.
Archit
Cc: Archit Taneja <arch...@codeaurora.org>
Cc: Jani Nikula <jani.nik...@linux.intel.com&g
drive-by polish where it makes sense, I read a lot
of docs ...
Cc: Archit Taneja <arch...@codeaurora.org>
Cc: Jani Nikula <jani.nik...@linux.intel.com>
Cc: Chris Wilson <ch...@chris-wilson.co.uk>
Signed-off-by: Daniel Vetter <daniel.vet...@intel.com>
---
drivers/g
On 12/13/2016 07:22 PM, Maarten Lankhorst wrote:
Op 13-12-16 om 14:01 schreef Archit Taneja:
Hi,
On 12/12/2016 4:04 PM, Maarten Lankhorst wrote:
Do something similar to vc4, only allow updating the cursor state
in-place through a fastpath when the watermarks are unaffected. This
will allow
Hi,
On 12/12/2016 4:04 PM, Maarten Lankhorst wrote:
Do something similar to vc4, only allow updating the cursor state
in-place through a fastpath when the watermarks are unaffected. This
will allow cursor movement to be smooth, but changing cursor size or
showing/hiding cursor will still fall
On 11/28/2016 05:03 PM, Jani Nikula wrote:
Update all nightly repos that have a corresponding local remote.
Cc: Archit Taneja <arch...@codeaurora.org>
Signed-off-by: Jani Nikula <jani.nik...@intel.com>
Tested-by: Archit Taneja <arch...@codeaurora.org>
---
dim | 9
On 10/24/2016 03:45 PM, Ville Syrjälä wrote:
On Mon, Oct 24, 2016 at 03:33:18PM +0530, Archit Taneja wrote:
Hi Ville,
On 10/22/2016 12:52 AM, ville.syrj...@linux.intel.com wrote:
From: Ville Syrjälä <ville.syrj...@linux.intel.com>
The global mode_config.rotation_property is goin
ches look fine to me.
Thanks,
Archit
v2: Drop the BIT()
Cc: Rob Clark <robdcl...@gmail.com>
Cc: Jilai Wang <jil...@codeaurora.org>
Cc: Archit Taneja <arch...@codeaurora.org>
Signed-off-by: Ville Syrjälä <ville.syrj...@linux.intel.com>
Reviewed-by: Rob Clark <robdcl...@gmail.
some warning over them.
Fixes: 532b36712ddf ("drm/doc: Polish for drm_plane.[hc]")
Cc: Archit Taneja <arch...@codeaurora.org>
Cc: Sean Paul <seanp...@chromium.org>
Signed-off-by: Daniel Vetter <daniel.vet...@intel.com>
Reviewed-by: Archit Taneja <arch...@cod
On 09/19/2016 06:43 PM, Daniel Vetter wrote:
On Fri, Sep 02, 2016 at 03:00:38PM +0530, Archit Taneja wrote:
On 8/31/2016 9:39 PM, Daniel Vetter wrote:
Big thing is untangling and carefully documenting the different uapi
types of planes. I also sprinkled a few more cross references around
On 8/31/2016 9:39 PM, Daniel Vetter wrote:
Big thing is untangling and carefully documenting the different uapi
types of planes. I also sprinkled a few more cross references around
to make this easier to discover.
As usual, remove the kerneldoc for internal functions which are not
exported.
On 8/31/2016 9:39 PM, Daniel Vetter wrote:
We don't want to burry the bridge structures kerneldoc in drm_crtc.h.
Cc: Archit Taneja <archit.tan...@gmail.com>
Reviewed-by: Archit Taneja <arch...@codeaurora.org>
Signed-off-by: Daniel Vetter <daniel.vet...@intel.com>
---
On 08/26/2016 01:10 AM, Daniel Vetter wrote:
On Thu, Aug 25, 2016 at 05:55:18PM +0530, Archit Taneja wrote:
On 08/18/2016 02:26 AM, Daniel Vetter wrote:
+void drm_mode_object_unregister(struct drm_device *dev,
+ struct drm_mode_object *object);
Alignment issue
decoded values in the corresponding state
s/aray/array
Otherwise:
Reviewed-by: Archit Taneja <arch...@codeaurora.org>
Archit
+* structure. The decoding is done using the ->atomic_get_property and
+* ->atomic_set_property hooks of the corresponding object. Hence atomic
+
)
Cc: Daniel Stone <dan...@fooishbar.org>
Signed-off-by: Daniel Vetter <daniel.vet...@intel.com>
checkpatch throws a few errors on usage of spaces instead of tabs,
probably stuff that existed before, but it would be nice to get
rid of them now. Otherwise:
Reviewed-by: Archit
@ffwll.ch>
Reviewed-by: Archit Taneja <arch...@codeaurora.org>
Archit
---
drivers/gpu/drm/drm_property.c | 23 +--
1 file changed, 5 insertions(+), 18 deletions(-)
diff --git a/drivers/gpu/drm/drm_property.c b/drivers/gpu/drm/drm_property.c
index 162cc9032ae5..b
On 08/18/2016 02:26 AM, Daniel Vetter wrote:
It's part of the drm fourcc handling code, mapping the old depth/bpp
values to new fourcc codes.
Reviewed-by: Archit Taneja <arch...@codeaurora.org>
Cc: Laurent Pinchart <laurent.pinch...@ideasonboard.com>
Signed-off-by: D
). Please "
+ "increase DRM_OBJECT_MAX_PROPERTY by 1 for each time "
+ "you see this message on the same object type.\n",
+ obj->type);
+ return;
+ }
+
+ obj->propert
On 08/18/2016 02:26 AM, Daniel Vetter wrote:
It's only used in drm_mode_object_get_properties, and we can compute
it there directly with a bit of code shuffling.
Reviewed-by: Archit Taneja <arch...@codeaurora.org>
Signed-off-by: Daniel Vetter <daniel.vet...@ffwll.ch>
---
dri
On 08/18/2016 02:25 AM, Daniel Vetter wrote:
- Move missing bits into struct drm_encoder docs.
- Explain that encoders are 95% internal and only 5% uapi, and that in
general the uapi part is broken.
- Remove verbose comments for functions not exposed to drivers.
Signed-off-by: Daniel
return !!(encoder->possible_crtcs & drm_crtc_mask(crtc));
+}
+
+static inline struct drm_encoder *drm_encoder_find(struct drm_device *dev,
+ uint32_t id)
and here.
+{
+ struct drm_mode_object *mo;
+ mo = drm_mode_object_find(dev, id, DRM_MODE_OBJECT_ENCODER);
checkpatch --
() and not suffer
from any backwards compatibility issues with drivers not following the
more rigorous init ordering.
Tested-by: Archit Taneja <arch...@codeaurora.org>
Signed-off-by: Chris Wilson <ch...@chris-wilson.co.uk>
Cc: Daniel Vetter <daniel.vet...@ffwll.ch>
Cc:
us.
Works fine with msm.
Tested-by: Archit Taneja <arch...@codeaurora.org>
Thanks,
Archit
Signed-off-by: Boris Brezillon <boris.brezil...@free-electrons.com>
---
drivers/gpu/drm/msm/edp/edp_connector.c| 10 --
drivers/gpu/drm/msm/hdmi/hdmi_connector.
now all in the drm_bridge_funcs kerneldoc in much more detail.
- Use & to reference structs so that kerneldoc automatically inserts
hyperlinks.
Reviewed-by: Archit Taneja <arch...@codeaurora.org>
Cc: Eric Anholt <e...@anholt.net>
Cc: Archit Taneja <arch...@codeaur
On 08/26/2015 10:42 AM, Archit Taneja wrote:
On 08/25/2015 07:15 PM, Daniel Vetter wrote:
Faster than recompiling.
Note that restore_fbdev_mode_unlocked is a bit special and the only
one which returns an error code when fbdev isn't there - i915 needs
that one to not fall over with some
On 08/26/2015 05:07 PM, Daniel Vetter wrote:
On Wed, Aug 26, 2015 at 01:34:58PM +0200, Daniel Vetter wrote:
On Wed, Aug 26, 2015 at 02:14:37PM +0530, Archit Taneja wrote:
On 08/26/2015 10:42 AM, Archit Taneja wrote:
On 08/25/2015 07:15 PM, Daniel Vetter wrote:
Faster than recompiling
On 08/26/2015 05:04 PM, Daniel Vetter wrote:
On Wed, Aug 26, 2015 at 02:14:37PM +0530, Archit Taneja wrote:
On 08/26/2015 10:42 AM, Archit Taneja wrote:
On 08/25/2015 07:15 PM, Daniel Vetter wrote:
Faster than recompiling.
Note that restore_fbdev_mode_unlocked is a bit special
On 08/25/2015 07:15 PM, Daniel Vetter wrote:
Faster than recompiling.
Note that restore_fbdev_mode_unlocked is a bit special and the only
one which returns an error code when fbdev isn't there - i915 needs
that one to not fall over with some additional fbcon related restore
code. Everyone
On 07/28/2015 04:55 PM, Daniel Vetter wrote:
On Tue, Jul 28, 2015 at 07:10:30PM +0800, kbuild test robot wrote:
tree: git://anongit.freedesktop.org/drm-intel topic/drm-misc
head: 109cd1d0fe187769f5e8ea414b9479b1c33b1d9f
commit: 9c4b750e97facd19749a44e0c8eeb9d2a78dd55f [8/30]
Hi,
On 07/14/2015 08:22 AM, Stephen Rothwell wrote:
Hi all,
After merging the drm-misc tree, today's linux-next build (x86_64
allmodconfig) failed like this:
drivers/gpu/drm/virtio/virtgpu_drm_bus.c: In function
'virtio_pci_kick_out_firmware_fb':
45 matches
Mail list logo