[Intel-gfx] [PATCH i-g-t 2/5] tests: Build gem_concurrent_all with meson

...and add it to test-list-full.txt just like we do when building with autotools. Signed-off-by: Arkadiusz Hiler --- tests/meson.build | 13 + 1 file changed, 13 insertions(+) diff --git a/tests/meson.build b/tests/meson.build index 54a1a3c7..8e3cd390 100644 --- a/tests/meson.build

[Intel-gfx] [PATCH i-g-t 3/5] tests: Remove ddx_intel_after_fbdev

It's not a even a proper test. Suggested-by: Petri Latvala Signed-off-by: Arkadiusz Hiler --- tests/Makefile.sources | 4 -- tests/ddx_intel_after_fbdev | 73 - 2 files changed, 77 deletions(-) delete mode 100755 tests/ddx_intel_after_fbdev diff

[Intel-gfx] [PATCH i-g-t 5/5] Get rid of GNU Autotools

Autotools have been deprecated in favor of Meson since early 2019. Cc: Daniel Vetter Cc: Petri Latvala Cc: Tomi Sarvela Signed-off-by: Arkadiusz Hiler --- Makefile.am | 44 --- autogen.sh | 17 - benchmarks/Makefile.am | 28

[Intel-gfx] [PATCH i-g-t 4/5] .gitlab-ci: Don't test Autotools

Signed-off-by: Arkadiusz Hiler --- .gitlab-ci.yml | 18 -- Dockerfile.build-debian | 8 2 files changed, 26 deletions(-) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index e226d9d7..2b03fc98 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -154,17 +154,6

[Intel-gfx] [PATCH i-g-t 1/5] benchmarks: Build gem_exec_tracer with meson

Seems it has been overlooked during mesonification. It's a shared module that's meant to be LD_PRELOAD-ed to intercept EXECBUFFER2 calls for the purpose of replaying them later. Signed-off-by: Arkadiusz Hiler --- benchmarks/meson.build | 8 1 file changed, 8 insertions(+) diff --git

Re: [Intel-gfx] [PATCH i-g-t 0/2] minor improvements to the kms_cursor_crc doc and some comments cleanup

On Wed, Jun 24, 2020 at 06:54:00AM -0300, Melissa Wen wrote: > Hi, > > I was studying the code of kms_cursor_crc test, and I just adjusted some > comments > and added descriptions for subtests. > > Melissa Wen (2): > lib/igt_fb: change comments with fd description > test/kms_cursor_crc:

Re: [Intel-gfx] [PATCH i-g-t 2/2] test/kms_cursor_crc: align the start of the CRC capture to a vblank

On Mon, Jun 22, 2020 at 01:38:26PM -0300, Melissa Wen wrote: > When running subtests in sequence using vkms, the beginning of CRC capture > process does not match the simulated vblank timing. This mismatch leads to > an endless busy wait and, consequently, timeout failures for the remaining >

Re: [Intel-gfx] [PATCH i-g-t 1/2] test/kms_cursor_crc: release old pipe_crc before create a new one

nitalized only once per each tested pipe in run_tests_on_pipe() - igt_pipe_crc_new() can be costly on some real panels. Anyway, Reviewed-by: Arkadiusz Hiler > data->pipe_crc = igt_pipe_crc_new(data->drm_fd, data->pipe, > INTEL_PIPE_CRC_

Re: [Intel-gfx] [igt-dev] [RFC PATCH i-g-t v2 1/8] tests/core_hotunplug: Duplicate debug messages in dmesg

On Fri, Jun 26, 2020 at 12:18:00PM +0200, Janusz Krzysztofik wrote: > Hi Michał, > > Thanks for review. > > On Thu, 2020-06-25 at 17:27 +0200, Michał Winiarski wrote: > > Quoting Janusz Krzysztofik (2020-06-22 18:44:08) > > > The purpose of debug messages displayed by the test is to make > > >

Re: [Intel-gfx] [PATCH] drm/i915/display: Increase the DDI idle timeout to 500us

On Thu, Mar 19, 2020 at 11:20:34AM +0200, Arkadiusz Hiler wrote: > Bspec says that we should timeout after 500us. Let's match this in the > code. It may help with few of the timeouts we see here and there. Plese disregard. it's 500us when waiting on non-idle and only 8 (16 for BXT) fo

[Intel-gfx] [PATCH] drm/i915/display: Increase the DDI idle timeout to 500us

Bspec says that we should timeout after 500us. Let's match this in the code. It may help with few of the timeouts we see here and there. Bspec: 22243, 49190 Issue: https://gitlab.freedesktop.org/drm/intel/issues/1069 Suggested-by: Uma Shankar Cc: Imre Deak Signed-off-by: Arkadiusz Hiler

Re: [Intel-gfx] ✗ Fi.CI.DOCS: warning for Consider DBuf bandwidth when calculating CDCLK (rev2)

On Wed, Mar 18, 2020 at 10:43:29AM +0200, Lisovskiy, Stanislav wrote: > Wonder, how we end up merging _stuff_ with failed IGT and loads of warnings.. > > https://patchwork.freedesktop.org/series/74738/ > > ... while I get beaten for each and every single warning in my patches  True. This

Re: [Intel-gfx] ✗ Fi.CI.DOCS: warning for Consider DBuf bandwidth when calculating CDCLK (rev2)

On Tue, Mar 17, 2020 at 12:43:40PM +0200, Lisovskiy, Stanislav wrote: > What is this weird DOC warning about? "Error: Cannot open file ./drivers/gpu/ > drm/i915/i915_gem_fence_reg.c" > > - wondering, how is that related to this patch. Looks like you were unlucky and your series got tested with

Re: [Intel-gfx] [CI] PR for TGL DMC v2.06

On Fri, Feb 28, 2020 at 06:52:01PM +, Souza, Jose wrote: > On Fri, 2020-02-28 at 12:21 +0200, Petri Latvala wrote: > > On Thu, Feb 27, 2020 at 11:42:03PM +, Souza, Jose wrote: > > > The following changes since commit > > > efcfa03ae6100dfe523ebf612e03c3a90fc4c794: > > > > > >

Re: [Intel-gfx] [PATCH] drm/i915/mst: fix pipe and vblank enable

On Mon, Feb 10, 2020 at 01:43:47PM +0200, Lisovskiy, Stanislav wrote: > On Mon, 2020-02-10 at 13:32 +0200, Jani Nikula wrote: > > On Wed, 05 Feb 2020, Jani Nikula wrote: > > > Commit 21fd23ac222f ("drm/i915: move pipe, pch and vblank enable to > > > encoders on DDI platforms") pushed pipe and

Re: [Intel-gfx] ✗ Fi.CI.BUILD: warning for Enable second DBuf slice for ICL and TGL (rev13)

On Wed, Jan 15, 2020 at 05:49:42PM +0200, Lisovskiy, Stanislav wrote: > There is some kind of build failure happening with all recent series: > > > CALLscripts/checksyscalls.sh > CALLscripts/atomic/check-atomics.sh > CHK include/generated/compile.h > Kernel: arch/x86/boot/bzImage

Re: [Intel-gfx] [ANNOUNCEMENT] Documenting tests with igt_describe()

On Tue, Nov 19, 2019 at 02:37:17PM +0200, Lionel Landwerlin wrote: > On 08/11/2019 11:04, Arkadiusz Hiler wrote: > > On Thu, Nov 07, 2019 at 09:09:34PM +, Chris Wilson wrote: > > > Quoting Arkadiusz Hiler (2019-11-07 17:38:20) > > > > We don't want you to transla

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t] i915/gem_blits: Use common igt_fls()

On Sat, Nov 09, 2019 at 03:10:02PM +, Chris Wilson wrote: > igt_aux.h already provides the optimal igt_fls(), so use that in > preference to open coding the brute force version. > > Reported-by: Stuart Summers > Signed-off-by: Chris Wilson > Cc: Stuart Summers Reviewed-b

Re: [Intel-gfx] [ANNOUNCEMENT] Documenting tests with igt_describe()

On Thu, Nov 07, 2019 at 09:09:34PM +, Chris Wilson wrote: > Quoting Arkadiusz Hiler (2019-11-07 17:38:20) > > We don't want you to translate C into English, we want you to provide a bit > > of > > that extra information that you would have put in the comments anyway. >

[Intel-gfx] [ANNOUNCEMENT] Documenting tests with igt_describe()

. [0]: https://gitlab.freedesktop.org/drm/igt-gpu-tools/blob/master/CONTRIBUTING.md#L19 [1]: https://drm.pages.freedesktop.org/igt-gpu-tools/igt-gpu-tools-Core.html#igt-describe Signed-off-by: Arkadiusz Hiler Signed-off-by: Petri Latvala ## FAQ Q: How is this being enforced? A: If your patch

Re: [Intel-gfx] [PATCH] drm/i915/lmem: add the fake lmem region

On Wed, Nov 06, 2019 at 11:17:29AM +, Chris Wilson wrote: > Quoting Arkadiusz Hiler (2019-11-06 08:30:37) > > On Tue, Nov 05, 2019 at 01:05:20PM +, Matthew Auld wrote: > > > On Thu, 31 Oct 2019 at 20:40, Chris Wilson > > > wrote: > > > > > >

Re: [Intel-gfx] [PATCH] drm/i915/lmem: add the fake lmem region

On Tue, Nov 05, 2019 at 01:05:20PM +, Matthew Auld wrote: > On Thu, 31 Oct 2019 at 20:40, Chris Wilson wrote: > > > > Quoting Arkadiusz Hiler (2019-10-31 12:40:35) > > > On Wed, Oct 30, 2019 at 10:22:37PM +, Matthew Auld wrote: > > > > On Tue

Re: [Intel-gfx] [PATCH] drm/i915/lmem: add the fake lmem region

On Wed, Oct 30, 2019 at 10:22:37PM +, Matthew Auld wrote: > On Tue, 29 Oct 2019 at 16:51, Matthew Auld wrote: > > > > Intended for upstream testing so that we can still exercise the LMEM > > plumbing and !i915_ggtt_has_aperture paths. Smoke tested on Skull Canyon > > device. This works by

[Intel-gfx] [PATCH] CI: Test revert some of the documentation fixes

This reverts commit 900554dc6bfc996ad07b9e187bbfd3864cd5bed0 to make sure that Fi.CI.DOCS complains :-) --- drivers/gpu/drm/i915/display/intel_dpll_mgr.h | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_dpll_mgr.h

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [1/9] drm/i915: Expose 10:10:10 XRGB formats on SNB-BDW sprites (rev2)

On Tue, Oct 15, 2019 at 12:25:59PM +0300, Petri Latvala wrote: > On Tue, Oct 15, 2019 at 09:41:20AM +0300, Arkadiusz Hiler wrote: > > On Mon, Oct 14, 2019 at 10:23:42PM +0300, Ville Syrjälä wrote: > > > On Wed, Oct 09, 2019 at 09:12:23PM -, Patchwork wrote: > &g

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [1/9] drm/i915: Expose 10:10:10 XRGB formats on SNB-BDW sprites (rev2)

On Mon, Oct 14, 2019 at 10:23:42PM +0300, Ville Syrjälä wrote: > On Wed, Oct 09, 2019 at 09:12:23PM -, Patchwork wrote: > > == Series Details == > > > > Series: series starting with [1/9] drm/i915: Expose 10:10:10 XRGB formats > > on SNB-BDW sprites (rev2) > > URL :

[Intel-gfx] [PATCH 1/1] drm/i915: Get the correct wakeref for reading HOTPLUG_EN et al.

+0x51/0x80 vfs_read+0x9e/0x160 ksys_read+0x8f/0xe0 do_syscall_64+0x55/0x1c0 entry_SYSCALL_64_after_hwframe+0x49/0xbe Cc: Chris Wilson Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=109824 Signed-off-by: Arkadiusz Hiler --- drivers/gpu/drm/i915/i915_debugfs.c | 4 +++- 1 file

[Intel-gfx] [PATCH 0/1] Fix i915_interrupt_info debugfs with display off on VLV

Cover letter to use https://intel-gfx-ci.01.org/test-with.html https://patchwork.freedesktop.org/patch/330337/?series=66602 Test-with: 20190912123320.13131-1-arkadiusz.hi...@intel.com Arkadiusz Hiler (1): drm/i915: Get the correct wakeref for reading HOTPLUG_EN et al. drivers/gpu/drm/i915

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t] i915/gem_mmap_gtt: Race mmap offset generation against closure

On Mon, Aug 26, 2019 at 04:20:00PM +0100, Chris Wilson wrote: > Signed-off-by: Chris Wilson > Cc: Abdiel Janulgue > --- > tests/i915/gem_mmap_gtt.c | 98 +++ > 1 file changed, 98 insertions(+) > > diff --git a/tests/i915/gem_mmap_gtt.c

Re: [Intel-gfx] [PATCH 1/1] drm/i915/uc: Turn on GuC/HuC auto mode again

On Thu, Aug 22, 2019 at 09:31:07AM +0200, Michal Wajdeczko wrote: > On Thu, 22 Aug 2019 08:40:33 +0200, Arkadiusz Hiler > wrote: > > > On Mon, Aug 19, 2019 at 11:09:15AM +0300, Martin Peres wrote: > > > On 18/08/2019 18:51, Michal Wajdeczko wrote: > > > >

Re: [Intel-gfx] [PATCH i-g-t 5/5] tests/kms_selftest: Integrate kernel selftest test-drm_modeset

On Wed, Jul 03, 2019 at 12:37:46PM +0200, Daniel Vetter wrote: > On Tue, Jun 25, 2019 at 05:37:01PM +0200, Daniel Vetter wrote: > > On Tue, Jun 25, 2019 at 09:01:32AM +0300, Arkadiusz Hiler wrote: > > > On Thu, Jun 20, 2019 at 03:20:02PM +0200, Daniel Vetter wrote: > >

Re: [Intel-gfx] [PATCH i-g-t] gitlab-ci: add tests for MIPS

On Thu, Jun 27, 2019 at 05:51:32PM +0300, Ser, Simon wrote: > On Thu, 2019-06-27 at 14:30 +0100, Guillaume Tucker wrote: > > Use the libatomic1:mips package only in the Debian Stretch Docker > > image for MIPS and add Gitlab CI step to run tests on MIPS. > > > > Signed-off-by: Guillaume Tucker >

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t] i915/gem_pread/pwrite: Rename "basic"

On Thu, Jun 27, 2019 at 08:18:36AM +, Ser, Simon wrote: > On Thu, 2019-06-27 at 08:36 +0100, Chris Wilson wrote: > > The "basic" subtests perform no verification that the read/write work, > > only function as mere API exercisers and loose benchmarks. Rename them > > to reflect that they are

Re: [Intel-gfx] [PATCH i-g-t v3 1/1] gitlab-ci: add build and tests for MIPS

On Thu, Jun 27, 2019 at 04:14:53PM +0300, Ser, Simon wrote: > On Thu, 2019-06-27 at 11:02 +0100, Guillaume Tucker wrote: > > On 27/06/2019 08:02, Ser, Simon wrote: > > > On Tue, 2019-06-25 at 14:08 +0100, Guillaume Tucker wrote: > > > > On 18/06/2019 13:42, Guillaume Tucker wrote: > > > > > Add

Re: [Intel-gfx] [PATCH i-g-t 5/5] tests/kms_selftest: Integrate kernel selftest test-drm_modeset

On Thu, Jun 20, 2019 at 03:20:02PM +0200, Daniel Vetter wrote: > On Tue, Oct 16, 2018 at 03:23:41PM -0700, Deepak Rawat wrote: > > Call kernel selftest module test-drm_modeset for testing KMS. > > > > v2: > > - Add test alphabetically. > > - Add test to meson build. > > > > v3: Rename to

Re: [Intel-gfx] [PATCH i-g-t v2] gitlab-ci: add build for MIPS

On Thu, Jun 13, 2019 at 03:01:06PM +0100, Guillaume Tucker wrote: > Add Docker image and Gitlab CI steps to run builds for the MIPS > architecture using Debian Stretch with backports. > > Signed-off-by: Guillaume Tucker > --- > .gitlab-ci.yml | 28 >

Re: [Intel-gfx] [PATCH i-g-t] i915/gem_exec_balancer: Fix typo in memcpy

On Thu, Jun 06, 2019 at 06:22:49PM +0100, Chris Wilson wrote: > Fixes: c26e76418f49 ("tests/gem_exec_balancer: Manually calculate VLA struct > sizes") > Signed-off-by: Chris Wilson > Cc: Arkadiusz Hiler Reviewed-by: Arkadiusz Hiler ___

Re: [Intel-gfx] [PATCH i-g-t] gitlab-ci: add build for MIPS

On Wed, Jun 05, 2019 at 09:18:09PM +0100, Guillaume Tucker wrote: > Add Docker image and Gitlab CI steps to run builds for the MIPS > architecture using Debian Buster. > > Signed-off-by: Guillaume Tucker > --- > .gitlab-ci.yml | 28 > Dockerfile.debian-mips

Re: [Intel-gfx] [PATCH i-g-t 2/4] gitlab-ci: add libatomic to Fedora docker image

tool \ > + gcc flex bison libatomic meson ninja-build xdotool \ > 'pkgconfig(libdrm)' \ > 'pkgconfig(pciaccess)' \ > 'pkgconfig(libkmod)' \ Reviewed-by: Arkadiusz Hiler I wonder how does the libatomic gets installed implicitly in Debian. _

Re: [Intel-gfx] [PATCH i-g-t 1/4] tests: add libatomic dependency

> Signed-off-by: Guillaume Tucker Reviewed-by: Arkadiusz Hiler This points out that we need some cleanups in tests/meson.build, as it's getting a bit messy with some of the test using igt_desp and others test_deps, but that's out of the sope of this series. Seems like for autotools we already ha

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: adding state checker for gamma lut values (rev6)

On Thu, Apr 18, 2019 at 10:31:32AM +, Patchwork wrote: > == Series Details == > > Series: drm/i915: adding state checker for gamma lut values (rev6) > URL : https://patchwork.freedesktop.org/series/58039/ > State : failure Hey, This series is a rerun, which means that someone went to

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t] lib: Rework __kms_addfb() function

On Wed, Apr 10, 2019 at 12:34:07PM +0100, Chris Wilson wrote: > Quoting Arkadiusz Hiler (2019-04-10 12:28:08) > > On Wed, Apr 03, 2019 at 07:24:39PM -0300, Rodrigo Siqueira wrote: > > > The function __kms_addfb() and drmModeAddFB2WithModifiers() have a > > > similar c

Re: [Intel-gfx] [PATCH i-g-t] lib: Rework __kms_addfb() function

On Wed, Apr 03, 2019 at 07:24:39PM -0300, Rodrigo Siqueira wrote: > The function __kms_addfb() and drmModeAddFB2WithModifiers() have a > similar code. Due to this similarity, this commit replace part of the > code inside __kms_addfb() by using drmModeAddFB2WithModifiers(). igt master % grep

Re: [Intel-gfx] [PATCH v6 0/3] drm & vgaarb: handle vgacon removal in vgaarb.

On Fri, Mar 01, 2019 at 07:12:04AM +0100, Gerd Hoffmann wrote: > Hi, > > > > Hmm, I see the test results in patchwork, but I can't remember having > > > seen a mail. > > > So the next question: where the results are sent to? > > From page above sent by Arek: > > " Since we accept patches

Re: [Intel-gfx] [PATCH v6 0/3] drm & vgaarb: handle vgacon removal in vgaarb.

On Thu, Feb 28, 2019 at 11:52:39AM +0100, Daniel Vetter wrote: > Adding intel-gfx and CI folks. > > On Thu, Feb 28, 2019 at 9:22 AM Gerd Hoffmann wrote: > > Quick question on the Intel CI: How does it work? I've seen it sending > > mails. Does it report failures only, i.e. no news is good

Re: [Intel-gfx] [PATCH i-g-t 8/8] kms_fence_pin_leak: Move beneath i915/

On Mon, Feb 18, 2019 at 02:08:12PM +, Chris Wilson wrote: > Quoting Arkadiusz Hiler (2019-02-18 14:01:11) > > On Mon, Feb 18, 2019 at 01:43:50PM +, Chris Wilson wrote: > > > Quoting Chris Wilson (2019-02-18 13:42:48) > > > > Quoting Arkadiusz Hiler (2019-02

Re: [Intel-gfx] [PATCH i-g-t 8/8] kms_fence_pin_leak: Move beneath i915/

On Mon, Feb 18, 2019 at 01:43:50PM +, Chris Wilson wrote: > Quoting Chris Wilson (2019-02-18 13:42:48) > > Quoting Arkadiusz Hiler (2019-02-18 13:37:07) > > > On Sun, Feb 17, 2019 at 02:35:56PM +, Chris Wilson wrote: > > > > kms_fence_pin_leak tests sm

Re: [Intel-gfx] [PATCH i-g-t 8/8] kms_fence_pin_leak: Move beneath i915/

y: Chris Wilson > Cc: Arkadiusz Hiler > Cc: Petri Latvala > Acked-by: Petri Latvala > --- > tests/Makefile.sources| 5 - > tests/{ => i915}/kms_fence_pin_leak.c | 0 > tests/meson.build | 2 +- > 3 files changed, 5 insertions(+)

Re: [Intel-gfx] [PATCH i-g-t 5/7] Make string commands dynamic allocate

On Sat, Jul 07, 2018 at 08:23:30PM -0300, Rodrigo Siqueira wrote: > This patch fix the following GCC warning: > > intel_gvtg_test.c: In function ‘create_guest’: > intel_gvtg_test.c:127:50: warning: ‘%s’ directive writing up to 4095 > bytes into a region of size 4077 [-Wformat-overflow=] > [..] >

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t 2/7] Cast void * pointer used in arithmetic to uint32_t*

On Tue, Jul 10, 2018 at 03:09:25PM +0100, Chris Wilson wrote: > Quoting Arkadiusz Hiler (2018-07-10 14:58:49) > > On Sat, Jul 07, 2018 at 08:22:38PM -0300, Rodrigo Siqueira wrote: > > > This commit fixes the GCC warning: > > > > > > warning: pointer of type ‘v

Re: [Intel-gfx] [PATCH i-g-t 4/7] Fix truncate string in the snprintf

On Sat, Jul 07, 2018 at 08:23:17PM -0300, Rodrigo Siqueira wrote: > This patch fix the following GCC warning: > > intel_reg.c: In function ‘dump_decode’: > warning: ‘snprintf’ output may be truncated before the last format character > [-Wformat-truncation=] >snprintf(decode, sizeof(decode),

Re: [Intel-gfx] [PATCH i-g-t 2/7] Cast void * pointer used in arithmetic to uint32_t*

On Sat, Jul 07, 2018 at 08:22:38PM -0300, Rodrigo Siqueira wrote: > This commit fixes the GCC warning: > > warning: pointer of type ‘void *’ used in arithmetic [-Wpointer-arith] > memset(ptr + offsets[0], full_range ? 0x00 : 0x10, > ^ > warning: pointer of type ‘void *’ used

Re: [Intel-gfx] [PATCH i-g-t 1/7] Remove parameter aliases with another argument

On Sat, Jul 07, 2018 at 08:22:25PM -0300, Rodrigo Siqueira wrote: > This commit fixes the following GCC warning: > > warning: passing argument 2 to restrict-qualified parameter aliases with > argument 1 [-Wrestrict] > return (readlink (buf, buf, sizeof (buf)) != -1 && > > This commit fixes the

Re: [Intel-gfx] [PATCH 1/4] drm/i915: fix guest virtual PCH detection on non-PCH systems

On Wed, Jun 13, 2018 at 10:16:07AM -0700, Lucas De Marchi wrote: > On Wed, Jun 13, 2018 at 10:09 AM Lucas De Marchi > wrote: > > > > On Wed, Jun 13, 2018 at 1:11 AM Arkadiusz Hiler > > wrote: > > > > > > On Wed, Jun 13, 2018 at 09:49:09AM +0300, Jani

Re: [Intel-gfx] [PATCH 1/4] drm/i915: fix guest virtual PCH detection on non-PCH systems

On Wed, Jun 13, 2018 at 09:49:09AM +0300, Jani Nikula wrote: > On Tue, 12 Jun 2018, Lucas De Marchi wrote: > > On Fri, Jun 8, 2018 at 5:34 AM Jani Nikula wrote: > >> > >> On Thu, 31 May 2018, Lucas De Marchi wrote: > >> > On Thu, May 31, 2018 at 02:56:21PM +0300, Jani Nikula wrote: > >> >>

Re: [Intel-gfx] [PATCH i-g-t 2/3] Remove extra '\0' in strncpy in igt_save_module_param

Title is slightly missleading. We don't remove extra NULL characer from anywhere. We just account for it by subtracting 1 from the destination buffer size. So maybe "Account for NULL character when using strncpy"? On Tue, May 29, 2018 at 09:46:55PM -0300, Rodrigo Siqueira wrote: > This patch fix

Re: [Intel-gfx] [PATCH i-g-t 3/3] Move declaration to the top of the code

ions > and code [-Wdeclaration-after-statement] [..] > igt_color_encoding.c: In function ‘ycbcr_to_rgb_matrix’: > igt_color_encoding.c:72:2: warning: ISO C90 forbids mixed declarations > and code [-Wdeclaration-after-statement] [..] > > Signed-off-by: Rodrigo Sique

Re: [Intel-gfx] [PATCH i-g-t 1/3] Avoid truncate string in __igt_lsof_fds

On Tue, May 29, 2018 at 09:46:38PM -0300, Rodrigo Siqueira wrote: > Note that 'proc_path' parameter in __igt_lsof_fds receives a string > which was initialized with the size of PATH_MAX and the local variable > 'path' has the same size, but it also have to append: '/', '\0', and the > directory

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for linux-next: build failure after merge of the drm-intel tree

On Tue, May 08, 2018 at 11:40:52AM +1000, Stephen Rothwell wrote: > Hi all, > > On Tue, 08 May 2018 01:36:25 - Patchwork > wrote: > > > > == Series Details == > > > > Series: linux-next: build failure after merge of the drm-intel tree > > URL :

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Call i915_perf_fini() on init_hw error unwind

On Sat, Apr 14, 2018 at 09:18:52AM +, Patchwork wrote: > == Series Details == > > Series: drm/i915: Call i915_perf_fini() on init_hw error unwind > URL : https://patchwork.freedesktop.org/series/41711/ > State : failure > > == Summary == > > CHK include/config/kernel.release > CHK

Re: [Intel-gfx] [CI] drm/i915: Split GPU commands definitions into separate header

On Wed, Mar 14, 2018 at 10:19:21AM +, Chris Wilson wrote: > Quoting Chris Wilson (2018-03-13 23:19:20) > > From: Michal Wajdeczko > > > > We should not mix MMIO with MI_INSTR definitions. > > > > v2: sanitize comment, change include order (Chris) > > > >

Re: [Intel-gfx] [PATCH v2 0/4] drm/i915: misc fixes in headers (RESEND)

On Thu, Mar 08, 2018 at 04:22:55PM +0100, Michal Wajdeczko wrote: > On Thu, 08 Mar 2018 13:58:48 +0100, Petri Latvala > wrote: > > > On Thu, Mar 08, 2018 at 02:20:41PM +0200, Jani Nikula wrote: > > > On Thu, 08 Mar 2018, Chris Wilson wrote: > >

Re: [Intel-gfx] i915 vs checkpatch

On Thu, Mar 01, 2018 at 11:17:50PM +, Chris Wilson wrote: > Quoting Arkadiusz Hiler (2018-03-01 09:47:06) > > Hey all, > > > > Since not so long ago our CI is running and reporting sparse and > > checkpatch. Sparse is doing just fine but I had to disable checkp

Re: [Intel-gfx] i915 vs checkpatch

On Mon, Mar 05, 2018 at 01:10:21PM +0200, Jani Nikula wrote: > On Mon, 05 Mar 2018, Daniel Vetter wrote: > > I'd recommend not making checkpatch ever fail CI, but at most warning. > > Agreed. But we want the automated warnings on the list, neutrally from a > bot instead of a

[Intel-gfx] i915 vs checkpatch

Hey all, Since not so long ago our CI is running and reporting sparse and checkpatch. Sparse is doing just fine but I had to disable checkpatch for the time being - too much "false" positives causing people to complain. It's simply confusing to see one thing in the code, and fitting your change

Re: [Intel-gfx] [PATCH igt v2] tests: Add a random load generator

On Mon, Jan 22, 2018 at 11:14:01AM +0200, Chris Wilson wrote: > Apply a random load to one or all engines in order to apply stress to > RPS as it tries to constantly adjust the GPU frequency to meet the > changing workload. Doing some IGT archeology here. Seems like both 'all' and 'pulse'

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t 1/2] tests/testdisplay: Explicitly use GLIB_CFLAGS

On Tue, Feb 27, 2018 at 03:38:58PM +0200, Petri Latvala wrote: > On Mon, Feb 05, 2018 at 12:56:10PM +0100, Thierry Reding wrote: > > From: Thierry Reding > > > > testdisplay.h includes the glib.h header file but the Makefile does not > > explicitly pass a -I option with the

Re: [Intel-gfx] [PATCH igt 1/2] lib: Export kmsg()

n.co.uk> Reviewed-by: Arkadiusz Hiler <arkadiusz.hi...@intel.com> both patches and pushed. ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for tests/kms_rotation_crc: Remove hardcoding of platforms in igt_require()

On Tue, Feb 13, 2018 at 01:38:21AM +, Patchwork wrote: > == Series Details == > > Series: tests/kms_rotation_crc: Remove hardcoding of platforms in > igt_require() > URL : https://patchwork.freedesktop.org/series/38108/ > State : failure > > == Summary == > > Test kms_rotation_crc: >

Re: [Intel-gfx] ✓ Fi.CI.IGT: success for igt/gem_ctx_isolation: Check isolation of registers between contexts (rev11)

On Wed, Feb 21, 2018 at 11:19:07AM +, Patchwork wrote: > == Series Details == > > Series: igt/gem_ctx_isolation: Check isolation of registers between contexts > (rev11) > URL : https://patchwork.freedesktop.org/series/32531/ > State : success

Re: [Intel-gfx] ✗ Fi.CI.SPARSE: warning for Adding NV12 support (rev10)

On Wed, Feb 14, 2018 at 02:07:49PM +0100, Maarten Lankhorst wrote: > Op 14-02-18 om 13:37 schreef Patchwork: > > == Series Details == > > > > Series: Adding NV12 support (rev10) > > URL : https://patchwork.freedesktop.org/series/28103/ > > State : warning > > > > == Summary == > > > > $ dim

Re: [Intel-gfx] [PATCH i-g-t 1/4] meson: Build cnl_compute_wrpll

On Tue, Jan 16, 2018 at 01:13:03PM +0200, Petri Latvala wrote: > Signed-off-by: Petri Latvala <petri.latv...@intel.com> Reviewed-by: Arkadiusz Hiler <arkadiusz.hi...@intel.com> one the whole series -- Cheers, Arek ___ Intel-gfx mailing

Re: [Intel-gfx] [PATCH 14/27] drm/i915/icl: Set graphics mode register for gen11

On Tue, Jan 09, 2018 at 09:28:22PM -0200, Paulo Zanoni wrote: > From: kgardine Please fix this to use Kelvin's full name when pushing. Both here and in the s-o-b line. It may trigger this rule causing a rejection somewhere up the merge chain:

Re: [Intel-gfx] [PATCH igt 1/4] igt/gem_busy: Remove repeated use of igt_spin_batch_new

on <ch...@chris-wilson.co.uk> Reviewed-by: Arkadiusz Hiler <arkadiusz.hi...@intel.com> on the whole series and pushed ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH igt] igt/kms_flip: Do igt_require_gem() just once

y: Chris Wilson <ch...@chris-wilson.co.uk> Reviewed-by: Arkadiusz Hiler <arkadiusz.hi...@intel.com> and pushed ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH igt] lib: Convert sw_sync to use sync_file uapi imported from the kernel

On Tue, Dec 19, 2017 at 03:00:03PM +, Chris Wilson wrote: > Similar to how we are now importing the drm uapi directly into igt, we > also would like to have a copy of auxiliary uAPI such as sync_file. > > Signed-off-by: Chris Wilson <ch...@chris-wilson.co.uk> Reviewed-b

Re: [Intel-gfx] [PATCH igt 2/2] igt/kms_frontbuffer_tracking: Access via GGTT is not guaranteed to be tracked

been that any access to the frontbuffer should be followed by a fb-dirty > > ioctl, so always apply and expect the driver to ellide no-ops. > > > > Signed-off-by: Chris Wilson <ch...@chris-wilson.co.uk> > > Ping? Reviewed-by: Arkadiusz Hiler <arkadius

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for igt/pm_rps: Always allocate spin[0]

On Mon, Dec 11, 2017 at 04:18:40PM +, Patchwork wrote: > == Series Details == > > Series: igt/pm_rps: Always allocate spin[0] > URL : https://patchwork.freedesktop.org/series/35176/ > State : failure > > == Summary == > > Test gem_tiled_swapping: > Subgroup non-threaded: >

Re: [Intel-gfx] [PATCH igt v2] igt/gem_linear_blits: Compute GTT size using 4G limit

ture_size(fd) / (1024*1024) / 2; > > + count = gem_aperture_size(fd); > > + if (count >> 32) > > + count = MAX_32b; > > + count = 3 * count / (1024*1024) / 2; Having that in 4 places may just

Re: [Intel-gfx] [PATCH i-g-t] intel_vbt_decode: Typo fixes

On Fri, Dec 15, 2017 at 02:59:36PM -0500, Adam Jackson wrote: > Signed-off-by: Adam Jackson > --- > tools/intel_vbt_decode.c | 4 ++-- > tools/intel_vbt_defs.h | 6 +++--- > 2 files changed, 5 insertions(+), 5 deletions(-) This mail was rejected by Patchwork because of

Re: [Intel-gfx] ✓ Fi.CI.IGT: success for igt/core_suspend: Exercise igt_system_suspend_autoresume() (rev2)

On Fri, Dec 08, 2017 at 11:30:07PM +, Patchwork wrote: > == Series Details == > > Series: igt/core_suspend: Exercise igt_system_suspend_autoresume() (rev2) > URL : https://patchwork.freedesktop.org/series/31986/ > State : success > > == Summary ==

Re: [Intel-gfx] [PATCH i-g-t 4/4] run-tests.sh: Allow users to override IGT_TEST_ROOT

On Wed, Dec 13, 2017 at 02:58:16PM +0200, Petri Latvala wrote: > Signed-off-by: Petri Latvala <petri.latv...@intel.com> > Cc: Arkadiusz Hiler <arkadiusz.hi...@intel.com> Reviewed-by: Arkadiusz Hiler <arkadiusz.hi...@intel.com> __

Re: [Intel-gfx] ✗ Fi.CI.IGT: warning for test/kms_plane_lowres: Fix display_commit_mode() so it returns the crc (rev4)

On Wed, Dec 13, 2017 at 11:08:39AM +, Patchwork wrote: > == Series Details == > > Series: test/kms_plane_lowres: Fix display_commit_mode() so it returns the > crc (rev4) > URL : https://patchwork.freedesktop.org/series/34749/ > State : warning > > == Summary == > > Test pm_rc6_residency:

Re: [Intel-gfx] [PATCH i-g-t] lib/i915_pciids.h: synchronize with kernel header

S_GT1_IDS(info), \ + INTEL_CFL_S_GT2_IDS(info), \ + INTEL_CFL_H_GT2_IDS(info), \ + INTEL_CFL_U_GT3_IDS(info) + /* CNL U 2+2 */ #define INTEL_CNL_U_GT2_IDS(info) \ INTEL_VGA_DEVICE(0x5A52, info), \ ------

Re: [Intel-gfx] [PATCH v3 i-g-t] test/kms_plane_lowres: Fix display_commit_mode() so it returns the crc

On Tue, Dec 12, 2017 at 02:10:56PM +0200, Arkadiusz Hiler wrote: > On Tue, Dec 12, 2017 at 11:59:13AM +0100, Maarten Lankhorst wrote: > > From: Arkadiusz Hiler <arkadiusz.hi...@intel.com> > > > > Compiler complained on crc_lowres and crc_hires2 being u

Re: [Intel-gfx] [PATCH v3 i-g-t] test/kms_plane_lowres: Fix display_commit_mode() so it returns the crc

On Tue, Dec 12, 2017 at 11:59:13AM +0100, Maarten Lankhorst wrote: > From: Arkadiusz Hiler <arkadiusz.hi...@intel.com> > > Compiler complained on crc_lowres and crc_hires2 being uninitialized > and indeed, display_commit_mode() seems to have intention of retruning &

[Intel-gfx] [PATCH i-g-t v2] test/kms_plane_lowres: Fix display_commit_mode() so it returns the crc

(), to be overwritten. Let's fix that! Also add missing hires crc comparison (M. Kahola). v2: make display_commit_mode return just the last CRC Cc: Mika Kahola <mika.kah...@intel.com> Cc: Maarten Lankhorst <maarten.lankho...@linux.intel.com> Signed-off-by: Arkadiusz Hiler <arkadiusz.

Re: [Intel-gfx] [PATCH i-g-t] igt: Make dependency on libunwind mandatory

On Fri, Dec 01, 2017 at 01:46:39PM +, Chris Wilson wrote: > Quoting Arkadiusz Hiler (2017-12-01 13:19:54) > > With Android support gone there is not much reason for keeping libunwind > > dependency optional. This also deals (cheaply!) with ifdefs covering > > huge porti

[Intel-gfx] [PATCH i-g-t] igt: Make dependency on libunwind mandatory

son.co.uk> Signed-off-by: Arkadiusz Hiler <arkadiusz.hi...@intel.com> --- configure.ac | 12 ++-- lib/igt_core.c | 13 - meson.build| 2 +- 3 files changed, 7 insertions(+), 20 deletions(-) diff --git a/configure.ac b/configure.ac index 84c6e646..6908f742 100644

[Intel-gfx] [PATCH i-g-t] test/kms_plane_lowres: Fix display_commit_mode() so it returns the crc

(), to be overwritten. Let's fix that! Also add missing hires crc comparison (M. Kahola). Cc: Mika Kahola <mika.kah...@intel.com> Cc: Maarten Lankhorst <maarten.lankho...@linux.intel.com> Signed-off-by: Arkadiusz Hiler <arkadiusz.hi...@intel.com> --- tests/kms_plane_lowres.c | 14

Re: [Intel-gfx] [PATCH i-g-t 2/2] Revert "lib/igt_aux: Make procps optional"

On Wed, Nov 29, 2017 at 12:07:06PM +0100, Daniel Vetter wrote: > On Fri, Nov 24, 2017 at 05:17:48PM +0200, Arkadiusz Hiler wrote: > > This reverts commit d7d3f4e87b827152f00bdf89a67871736672b492 > > and gets rid of the config option from the meson.build. > > > > It was

Re: [Intel-gfx] [QUERY] How many CI mails is too many?

ks to the patchwork and intel-gfx-ci grids provided (so no need to hunt for those). The results also stores nicely in the online mailing list archives if we send it to the intel-gfx@fdo. Searchability and easy categorization is an added bonus if you subscribe to dozen or so mailing lists. Cheers

[Intel-gfx] [QUERY] How many CI mails is too many?

Hey all, For some time already CI sends out 1-2 mails per series per (re)run, i.e. BAT results and "full IGT" results (if BAT has not failed). Recently we have added 32bit build check, and if that fails it sends out additional mail In-Reply-To the series. I am working on adding some static

[Intel-gfx] [PATCH i-g-t 2/2] Revert "lib/igt_aux: Make procps optional"

This reverts commit d7d3f4e87b827152f00bdf89a67871736672b492 and gets rid of the config option from the meson.build. It was needed only for the Android support. Signed-off-by: Arkadiusz Hiler <arkadiusz.hi...@intel.com> --- configure.ac | 6 +- lib/igt_aux.

[Intel-gfx] [PATCH i-g-t 1/2] igt: Remove Android support

the illusion of providing any support. Cc: Daniel Vetter <daniel.vet...@intel.com> Cc: Kalyan Kondapally <kalyan.kondapa...@intel.com> Cc: Petri Latvala <petri.latv...@intel.com> Cc: Radoslaw Szwichtenberg <radoslaw.szwichtenb...@intel.com> Signed-off-by: Arkadiusz Hiler &l

Re: [Intel-gfx] [PATCH i-g-t] lib/igt_core: Move write_stderr out of LIBUNWIND ifdef

On Fri, Nov 24, 2017 at 10:51:38AM +, Chris Wilson wrote: > Quoting Arkadiusz Hiler (2017-11-24 10:32:07) > > write_stderr() and __write_stderr() are defined behind ifdef on > > HAVE_LIBUNWIND, but do no depend on the lib in any way. > > Hmm, we keep getting caugh

[Intel-gfx] [PATCH i-g-t] lib/igt_core: Move write_stderr out of LIBUNWIND ifdef

without libunwind. Cc: Tvrtko Ursulin <tvrtko.ursu...@linux.intel.com> Signed-off-by: Arkadiusz Hiler <arkadiusz.hi...@intel.com> --- lib/igt_core.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/lib/igt_core.c b/lib/igt_core.c index 4fe48c

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Avoid enum conversion warning

On Thu, Nov 23, 2017 at 08:58:47AM +, Patchwork wrote: > == Series Details == > > Series: drm/i915: Avoid enum conversion warning > URL : https://patchwork.freedesktop.org/series/34269/ > State : failure > > == Summary == This change does not apply cleanly on top of the commit below: >

Re: [Intel-gfx] [PATCH igt] lib: Dump /sys/kernel/debug/suspend_stats after suspend failure

pend: 1 failed_suspend_late: 0 failed_suspend_noirq: 0 failed_resume: 0 failed_resume_early: 0 failed_resume_noirq: 0 failures: last_failed_dev: last_failed_errno:-16 0 last_failed_step: suspend Reviewed-by: Arkadiusz Hiler <arkadiusz.hi...@intel.com> and pushed -- Cheers, Arek ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH i-g-t] tests/debugfs_test: Pretty print subdirectories

gt; (debugfs_test:1360) DEBUG: Reading file "control" > > Signed-off-by: Maarten Lankhorst <maarten.lankho...@linux.intel.com> Reviewed-by: Arkadiusz Hiler <arkadiusz.hi...@intel.com> and pushed, since the test results are clean on this binary. Thanks! -- Cheer

  1   2   3   4   5   6   >