[Intel-gfx] [PATCH 5/5] drm/i915/uc: Simplify fw_path

and 2. Cc: Anusha Srivatsa <anusha.sriva...@intel.com> Cc: Tvrtko Ursulin <tvrtko.ursu...@intel.com> Cc: Michal Winiarski <michal.winiar...@intel.com> Signed-off-by: Arkadiusz Hiler <arkadiusz.hi...@intel.com> --- drivers/gpu/drm/i915/intel_guc_loader.c | 28 +++--

[Intel-gfx] [PATCH 4/5] drm/i915/guc: Simplify intel_guc_init_hw()

intel.com> Cc: Michal Wajdeczko <michal.wajdec...@intel.com> Cc: Daniele Ceraolo Spurio <daniele.ceraolospu...@intel.com> Signed-off-by: Arkadiusz Hiler <arkadiusz.hi...@intel.com> --- drivers/gpu/drm/i915/i915_gem.c | 2 +- drivers/gpu/drm

[Intel-gfx] [PATCH 2/5] drm/i915/uc: Introduce intel_uc_init()

We will be able to bulk call all firmware _init() function from single point and offset some general logic there as needed Cc: Anusha Srivatsa <anusha.sriva...@intel.com> Cc: Michal Winiarski <michal.winiar...@intel.com> Cc: Michal Wajdeczko <michal.wajdec...@intel.com> Signed

[Intel-gfx] [PATCH 3/5] drm/i915/guc: Extract param logic form guc_init

<michal.winiar...@intel.com> Cc: Michal Wajdeczko <michal.wajdec...@intel.com> Cc: Daniele Ceraolo Spurio <daniele.ceraolospu...@intel.com> Signed-off-by: Arkadiusz Hiler <arkadiusz.hi...@intel.com> --- drivers/gpu/drm/i915/i915_drv.c | 2 ++ drivers/gpu/drm/i915

[Intel-gfx] [PATCH v2 0/5] GuC Scrub vol. 1

loading but had WA implementations and had the code thatenabled submission baked it. This is first the part of effort to clean it up. Cc: Joonas Lahtinen <joonas.lahti...@linux.intel.com> Arkadiusz Hiler (5): drm/i915/uc: Rename intel_?uc_{setup,load}() to _init_hw() drm/i915/uc: Int

[Intel-gfx] [PATCH 1/5] drm/i915/uc: Rename intel_?uc_{setup, load}() to _init_hw()

em_init_hw(). Cc: Anusha Srivatsa <anusha.sriva...@intel.com> Cc: Michal Winiarski <michal.winiar...@intel.com> Cc: Michal Wajdeczko <michal.wajdec...@intel.com> Signed-off-by: Arkadiusz Hiler <arkadiusz.hi...@intel.com> --- drivers/gpu/drm/i915/i915_gem.c

Re: [Intel-gfx] [PATCH v2 1/1] drm/i915: Do RPM Wake during GuC/HuC status read

On Mon, Feb 06, 2017 at 10:34:31AM +0530, Kamble, Sagar A wrote: > > > On 2/4/2017 7:40 PM, Arkadiusz Hiler wrote: > > On Fri, Feb 03, 2017 at 01:58:33PM +0530, Sagar Arun Kamble wrote: > > > HUC_STATUS, GUC_STATUS, SOFT_SCRATCH registers are read in debugfs > > &g

Re: [Intel-gfx] [PATCH v2 1/1] drm/i915: Do RPM Wake during GuC/HuC status read

isW) > > Cc: Arkadiusz Hiler <arkadiusz.hi...@intel.com> > Cc: Anusha Srivatsa <anusha.sriva...@intel.com> > Cc: Fiedorowicz, Lukasz <lukasz.fiedorow...@intel.com> > Signed-off-by: Sagar Arun Kamble <sagar.a.kam...@intel.com> > --- > drivers/gpu/drm/i915/i91

Re: [Intel-gfx] [RFC] drm/i915/guc: Move GuC log related functions into dedicated file

intel.com> > > > Cc: Chris Wilson <ch...@chris-wilson.co.uk> Reviewed-by: Arkadiusz Hiler <arkadiusz.hi...@intel.com> > > > > Looks clean enough. I don't expect any objections, anyone? > > No objections whatsoever, just the opposite! Agreed. We can just drop

Re: [Intel-gfx] [PATCH] drm/i915/huc: Support HuC authentication

; v17: rebased. Cleanup the intel_guc_auth_huc() by removing checks > already performed in earlier functions. Make comments more descriptive. > v18: rebased. Changed the bias for pinning the HuC object.Add return > values with errors. > > Cc: Chris Wilson <ch...@chris-wilson.co

Re: [Intel-gfx] [PATCH 1/8] drm/i915/guc: Make the GuC fw loading helper functions general

v15: rebased. Remove sections of code that were commented and no longer > required. > v16: rebased. Remove uc_fw_ prefix from path and obj fields > in intel_uc_fw struct as suggested by Michal. > > Cc: Michal Wajdeczko <michal.wajdec...@intel.com> > Cc: Arkadiusz Hiler <

Re: [Intel-gfx] [PATCH 7/8] drm/i915/huc: Support HuC authentication

ON_ > AUTHENTICATE_HUC > v14: rebased. > v15: rebased. Add newline on DRM_ERRORs that already dont have one. > v16: rebased. Replace wait_for with intel_wait_for_register() since > the latter employs sleep optimisations for quick responses- as pointed > out by Chris Wilson.

Re: [Intel-gfx] [PATCH 7/8] drm/i915/huc: Support HuC authentication

ON_ > AUTHENTICATE_HUC > v14: rebased. > v15: rebased. Add newline on DRM_ERRORs that already dont have one. > v16: rebased. Replace wait_for with intel_wait_for_register() since > the latter employs sleep optimisations for quick responses- as pointed > out by Chris Wilson.

Re: [Intel-gfx] [PATCH 3/8] drm/i915/huc: Add HuC fw loading support

On Tue, Jan 03, 2017 at 06:59:11PM +, Srivatsa, Anusha wrote: > > > >-Original Message- > >From: Intel-gfx [mailto:intel-gfx-boun...@lists.freedesktop.org] On Behalf Of > >Srivatsa, Anusha > >Sent: Monday, January 2, 2017 4:09 PM > >To: Wajdeczko, Michal

Re: [Intel-gfx] [PATCH 2/8] drm/i915/huc: Unified css_header struct for GuC and HuC

FW_TYPE_HUC: > + uc_fw->major_ver_found = css->huc.sw_version >> 16; > + uc_fw->minor_ver_found = css->huc.sw_version & 0x; > + break; > + > + default: > + DRM_ERROR("Unknown firmware type %d\n&

Re: [Intel-gfx] [PATCH 05/26] drm/i915/guc: Exclude the upper end of the Global GTT for the GuC

name to reflect that it is unmappable similar to the region at the > bottom of the GGTT, and couple it into the assertion that we don't feed > unmappable addresses to the GuC. > > Signed-off-by: Chris Wilson <ch...@chris-wilson.co.uk> > Cc: Michal Wajdeczko <michal.wajdec...@intel.c

Re: [Intel-gfx] [PATCH 4/5] drm/i915/guc: Extract param logic form guc_init

On Fri, Dec 23, 2016 at 01:19:18PM -0800, Daniele Ceraolo Spurio wrote: > > > On 15/12/16 07:47, Arkadiusz Hiler wrote: > > Let intel_guc_init() focus on determining and fetching the correct > > firmware. > > > > This patch introduces intel_sanitiz

Re: [Intel-gfx] [PATCH 2/5] drm/i915/guc: Introduce intel_uc_init()

Srivatsa <anusha.sriva...@intel.com> > >Cc: Jeff McGee <jeff.mc...@intel.com> > >Cc: Michal Winiarski <michal.winiar...@intel.com> > >Signed-off-by: Arkadiusz Hiler <arkadiusz.hi...@intel.com> > >--- > > drivers/gpu/drm/i915/i915_drv.c | 2 +- >

Re: [Intel-gfx] [PATCH 3/8] drm/i915/huc: Add HuC fw loading support

> > Cc: Tvrtko Ursulin <tvrtko.ursu...@intel.com> > Tested-by: Xiang Haihao <haihao.xi...@intel.com> > Signed-off-by: Anusha Srivatsa <anusha.sriva...@intel.com> > Signed-off-by: Alex Dai <yu@intel.com> > Signed-off-by: Peter Antoine <peter.anto...@

Re: [Intel-gfx] [PATCH 4/8] drm/i915/huc: Add BXT HuC Loading Support

ebased. Rename BXT_FW_MAJOR to BXT_HUC_FW_ > v6: rebased. > > Cc: Tvrtko Ursulin <tvrtko.ursu...@linux.intel.com> > Signed-off-by: Anusha Srivatsa <anusha.sriva...@intel.com> Reviewed-by: Arkadiusz Hiler <arkadiusz.hi...@intel.com> -- Cheers, Arek ___

Re: [Intel-gfx] [PATCH 5/8] drm/i915/HuC: Add KBL huC loading Support

> > Cc: Tvrtko Ursulin <tvrtko.ursu...@linux.intel.com> > Signed-off-by: Anusha Srivatsa <anusha.sriva...@intel.com> Reviewed-by: Arkadiusz Hiler <arkadiusz.hi...@intel.com> -- Cheers, Arek ___ Intel-gfx mailing list Intel-gfx@

Re: [Intel-gfx] [PATCH 8/8] drm/i915/get_params: Add HuC status to getparams

v8: rebased. Add a comment to specify that I915_READ(reg) > does not read garbage value. The register HUC_STATUS2 is force > woken and no rpm is needed. > > Signed-off-by: Peter Antoine <peter.anto...@intel.com> Where is your s-o-b? other than that:

Re: [Intel-gfx] [PATCH 2/8] drm/i915/huc: Unified css_header struct for GuC and HuC

On Thu, Dec 22, 2016 at 03:12:18PM -0800, Anusha Srivatsa wrote: > From: Peter Antoine > > HuC firmware css header has almost exactly same definition as GuC > firmware except for the sw_version. Also, add a new member fw_type > into intel_uc_fw to indicate what kind of

Re: [Intel-gfx] [PATCH 1/8] drm/i915/guc: Make the GuC fw loading helper functions general

rebased. Remove sections of code that were commented and no longer > required. > > Signed-off-by: Anusha Srivatsa <anusha.sriva...@intel.com> > Signed-off-by: Alex Dai <yu@intel.com> > Signed-off-by: Peter Antoine <peter.anto...@intel.com> Reviewed-by: Arkadiusz

Re: [Intel-gfx] [PATCH] drm/i915/guc: Reserve the upper end of the Global GTT for the GuC

On Thu, Dec 22, 2016 at 03:18:08PM +, Chris Wilson wrote: > On Thu, Dec 22, 2016 at 03:53:15PM +0100, Arkadiusz Hiler wrote: > > On Wed, Dec 21, 2016 at 07:35:04PM +0100, Srivatsa, Anusha wrote: > > > With enable_guc_loading=2 and enable_guc_submission=0 I get HuC > >

Re: [Intel-gfx] [PATCH] drm/i915/guc: Reserve the upper end of the Global GTT for the GuC

o exclude it from our drm_mm to prevent us using it. > >> > > > >> > > Signed-off-by: Chris Wilson <ch...@chris-wilson.co.uk> > >> > > Cc: Michal Wajdeczko <michal.wajdec...@intel.com> > >> > > Cc: Arkadiusz Hiler <arkadiusz.hi...

Re: [Intel-gfx] [PATCH] drm/i915/guc: Reserve the upper end of the Global GTT for the GuC

chal.wajdec...@intel.com> > Cc: Arkadiusz Hiler <arkadiusz.hi...@intel.com> Tested-by: Arkadiusz Hiler <arkadiusz.hi...@intel.com> Fixes the issue with GuC loading with submission on. -- Cheers, Arek ___ Intel-gfx mailing

Re: [Intel-gfx] [PATCH 3/8] drm/i915/huc: Add HuC fw loading support

On Fri, Dec 16, 2016 at 04:13:14PM +, Tvrtko Ursulin wrote: > > On 15/12/2016 22:29, anushasr wrote: > > From: Anusha Srivatsa > > > > The HuC loading process is similar to GuC. The intel_uc_fw_fetch() > > is used for both cases. > > > > HuC loading needs to be

Re: [Intel-gfx] [PATCH 8/8] drm/i915/get_params: Add HuC status to getparams

On Fri, Dec 16, 2016 at 04:12:36PM +, Chris Wilson wrote: > On Fri, Dec 16, 2016 at 03:43:46PM +0100, Arkadiusz Hiler wrote: > > On Thu, Dec 15, 2016 at 10:42:53PM +, Chris Wilson wrote: > > > On Thu, Dec 15, 2016 at 02:29:50PM -0800, anushasr wrote: > > > > F

Re: [Intel-gfx] [PATCH 7/8] drm/i915/huc: Support HuC authentication

On Thu, Dec 15, 2016 at 02:29:49PM -0800, anushasr wrote: > From: Peter Antoine > > The HuC authentication is done by host2guc call. The HuC RSA keys > are sent to GuC for authentication. > > v2: rebased on top of drm-intel-nightly. > changed name format and upped

Re: [Intel-gfx] Guc parameter Handling

On Thu, Dec 15, 2016 at 10:36:40PM +, Srivatsa, Anusha wrote: > Hi All, > > I was wondering if we intend to keep -1 and 2 for the > enable_guc_submission parameter. Since now we are gating guc loads if > either guc_submission or enable_huc parameter is set, why have a > -1(platform default)

Re: [Intel-gfx] [PATCH 8/8] drm/i915/get_params: Add HuC status to getparams

> Signed-off-by: Peter Antoine <peter.anto...@intel.com> > Reviewed-by: Arkadiusz Hiler <arkadiusz.hi...@intel.com> You've retained my rb without asking me. With the changes you've made and confirmation that MEDIA FW that I915_READ() assumes: Reviewed-by: Arkadiusz Hiler <ar

Re: [Intel-gfx] [PATCH 8/8] drm/i915/get_params: Add HuC status to getparams

_STATUS. > > Remove intel_is_huc_valid() since it is used only in one place. > > Put the case of I915_PARAM_HAS_HUC() in the right place. > > > > Signed-off-by: Peter Antoine <peter.anto...@intel.com> > > Reviewed-by: Arkadiusz Hiler <arkadiusz.hi...@intel.com> > >

Re: [Intel-gfx] [PATCH 1/5] drm/i915/guc: Rename _setup() to _load()

On Thu, Dec 15, 2016 at 03:57:01PM +, Chris Wilson wrote: > On Thu, Dec 15, 2016 at 04:47:04PM +0100, Arkadiusz Hiler wrote: > > GuC historically has two "startup" functions called _init() and _setup() > > > > Then HuC came with it's _init() and _load(

Re: [Intel-gfx] [PATCH 1/5] drm/i915/guc: Rename _setup() to _load()

On Thu, Dec 15, 2016 at 05:22:53PM +0100, Michal Wajdeczko wrote: > On Thu, Dec 15, 2016 at 04:47:04PM +0100, Arkadiusz Hiler wrote: > > GuC historically has two "startup" functions called _init() and _setup() > > > > Then HuC came with it's _init() and _load(

Re: [Intel-gfx] [PATCH 3/5] drm/i915/guc: Simplify intel_guc_load()

On Thu, Dec 15, 2016 at 02:26:29PM -0800, Daniele Ceraolo Spurio wrote: > > > On 15/12/16 07:47, Arkadiusz Hiler wrote: > > Current version of intel_guc_load() does a lot: > > - cares about submission > > - loads huc > > - implement WA > > >

Re: [Intel-gfx] [PATCH 3/5] drm/i915/guc: Simplify intel_guc_load()

On Thu, Dec 15, 2016 at 05:38:16PM +0100, Michal Wajdeczko wrote: > On Thu, Dec 15, 2016 at 04:47:06PM +0100, Arkadiusz Hiler wrote: > > Current version of intel_guc_load() does a lot: > > - cares about submission > > - loads huc > > - implement WA > &g

[Intel-gfx] [PATCH 2/5] drm/i915/guc: Introduce intel_uc_init()

We will be able to bulk call all firmware _init() function from single point and offset some general logic there. Cc: Anusha Srivatsa <anusha.sriva...@intel.com> Cc: Jeff McGee <jeff.mc...@intel.com> Cc: Michal Winiarski <michal.winiar...@intel.com> Signed-off-by: Arkadiusz H

[Intel-gfx] [PATCH 0/5] GuC Scrub vol. 1

it. This is first the part of effort to clean it up. Arkadiusz Hiler (5): drm/i915/guc: Rename _setup() to _load() drm/i915/guc: Introduce intel_uc_init() drm/i915/guc: Simplify intel_guc_load() drm/i915/guc: Extract param logic form guc_init drm/i915/guc: Simplify guc_fw_path drivers

[Intel-gfx] [PATCH 3/5] drm/i915/guc: Simplify intel_guc_load()

; Cc: Michal Winiarski <michal.winiar...@intel.com> Signed-off-by: Arkadiusz Hiler <arkadiusz.hi...@intel.com> --- drivers/gpu/drm/i915/i915_gem.c | 2 +- drivers/gpu/drm/i915/intel_guc_loader.c | 126 +--- drivers/gpu/drm/i915/

[Intel-gfx] [PATCH 5/5] drm/i915/guc: Simplify guc_fw_path

and 2 for later handling. Cc: Anusha Srivatsa <anusha.sriva...@intel.com> Cc: Jeff McGee <jeff.mc...@intel.com> Cc: Michal Winiarski <michal.winiar...@intel.com> Signed-off-by: Arkadiusz Hiler <arkadiusz.hi...@intel.com> --- drivers/gpu/drm/i915/intel_guc_loader.c | 22 ++

[Intel-gfx] [PATCH 1/5] drm/i915/guc: Rename _setup() to _load()

a Srivatsa <anusha.sriva...@intel.com> Cc: Jeff McGee <jeff.mc...@intel.com> Cc: Michal Winiarski <michal.winiar...@intel.com> Signed-off-by: Arkadiusz Hiler <arkadiusz.hi...@intel.com> --- drivers/gpu/drm/i915/i915_gem.c | 2 +- drivers/gpu/drm/i915/intel_guc_loade

[Intel-gfx] [PATCH 4/5] drm/i915/guc: Extract param logic form guc_init

to support HuC case as well. Cc: Anusha Srivatsa <anusha.sriva...@intel.com> Cc: Jeff McGee <jeff.mc...@intel.com> Cc: Michal Winiarski <michal.winiar...@intel.com> Signed-off-by: Arkadiusz Hiler <arkadiusz.hi...@intel.com> --- drivers/gpu/drm/i915

Re: [Intel-gfx] [PATCH 8/8] drm/i915/get_params: Add HuC status to getparams

t; v2: removed the forewakes as the registers are already force-woken. > > (T.Ursulin) > > v4: rebased. > > v5: rebased on top of drm-tip. > > v6: rebased. Removed any reference to intel_huc.h > > > > Signed-off-by: Peter Antoine <peter.anto...@int

Re: [Intel-gfx] [PATCH 8/8] drm/i915/get_params: Add HuC status to getparams

On Mon, Dec 12, 2016 at 03:17:16PM +, Chris Wilson wrote: > On Mon, Dec 12, 2016 at 03:52:05PM +0100, Arkadiusz Hiler wrote: > > On Mon, Dec 12, 2016 at 02:21:41PM +, Chris Wilson wrote: > > > As for userspace simply asking where huc is enabled, we already have > &g

Re: [Intel-gfx] [PATCH 8/8] drm/i915/get_params: Add HuC status to getparams

On Mon, Dec 12, 2016 at 02:21:41PM +, Chris Wilson wrote: > On Mon, Dec 12, 2016 at 03:13:17PM +0100, Arkadiusz Hiler wrote: > > On Fri, Dec 09, 2016 at 01:59:45PM +0100, Michal Wajdeczko wrote: > > > On Thu, Dec 08, 2016 at 03:02:19PM -0800, anushasr wrote: > >

Re: [Intel-gfx] [PATCH 8/8] drm/i915/get_params: Add HuC status to getparams

gt; > v2: removed the forewakes as the registers are already force-woken. > > (T.Ursulin) > > v4: rebased. > > v5: rebased on top of drm-tip. > > v6: rebased. Removed any reference to intel_huc.h > > > > Signed-off-by: Peter Antoine <peter.anto...@int

Re: [Intel-gfx] [PATCH 2/8] drm/i915/huc: Unified css_header struct for GuC and HuC

On Fri, Dec 09, 2016 at 09:42:06PM +, Srivatsa, Anusha wrote: > > > >-Original Message- > >From: Michal Wajdeczko [mailto:michal.wajdec...@linux.intel.com] > >Sent: Friday, December 9, 2016 3:56 AM > >To: Srivatsa, Anusha > >Cc:

Re: [Intel-gfx] [PATCH 3/8] drm/i915/huc: Add HuC fw loading support

On Fri, Dec 09, 2016 at 11:56:20PM +, Srivatsa, Anusha wrote: > > > >-Original Message- > >From: Michal Wajdeczko [mailto:michal.wajdec...@linux.intel.com] > >Sent: Friday, December 9, 2016 4:18 AM > >To: Srivatsa, Anusha > >Cc:

Re: [Intel-gfx] [PATCH 1/8] drm/i915/guc: Make the GuC fw loading helper functions general

On Fri, Dec 09, 2016 at 02:06:29PM +0100, Michal Wajdeczko wrote: > On Fri, Dec 09, 2016 at 12:49:02PM +0100, Arkadiusz Hiler wrote: > > On Fri, Dec 09, 2016 at 12:28:52PM +0100, Michal Wajdeczko wrote: > > > On Thu, Dec 08, 2016 at 03:02:12PM -0800, anushasr wrote: > >

Re: [Intel-gfx] [PATCH 3/8] drm/i915/huc: Add HuC fw loading support

On Fri, Dec 09, 2016 at 12:34:55PM +0100, Arkadiusz Hiler wrote: > On Fri, Dec 09, 2016 at 11:10:03AM +, Chris Wilson wrote: > > On Fri, Dec 09, 2016 at 11:56:10AM +0100, Arkadiusz Hiler wrote: > > > On Thu, Dec 08, 2016 at 03:02:14PM -0800, anushasr wrote: > > > &

Re: [Intel-gfx] [PATCH 1/8] drm/i915/guc: Make the GuC fw loading helper functions general

On Fri, Dec 09, 2016 at 12:28:52PM +0100, Michal Wajdeczko wrote: > On Thu, Dec 08, 2016 at 03:02:12PM -0800, anushasr wrote: > > From: Peter Antoine > > > > Rename some of the GuC fw loading code to make them more general. We > > will utilise them for HuC loading as

Re: [Intel-gfx] [PATCH 3/8] drm/i915/huc: Add HuC fw loading support

On Fri, Dec 09, 2016 at 11:10:03AM +, Chris Wilson wrote: > On Fri, Dec 09, 2016 at 11:56:10AM +0100, Arkadiusz Hiler wrote: > > On Thu, Dec 08, 2016 at 03:02:14PM -0800, anushasr wrote: > > > -static u32 guc_wopcm_size(struct drm_i915_private *dev_priv) > > >

Re: [Intel-gfx] [PATCH 3/8] drm/i915/huc: Add HuC fw loading support

On Thu, Dec 08, 2016 at 03:02:14PM -0800, anushasr wrote: > From: Anusha Srivatsa > > The HuC loading process is similar to GuC. The intel_uc_fw_fetch() > is used for both cases. > > HuC loading needs to be before GuC loading. The WOPCM setting must > be done early

Re: [Intel-gfx] [PATCH 7/8] drm/i915/huc: Support HuC authentication

AUTHENTICATE_HUC > > Tested-by: Xiang Haihao <haihao.xi...@intel.com> > Signed-off-by: Anusha Srivatsa <anusha.sriva...@intel.com> > Signed-off-by: Alex Dai <yu@intel.com> > Signed-off-by: Peter Antoine <peter.anto...@intel.com> Reviewed-by: Arkadiusz

Re: [Intel-gfx] [PATCH 2/8] drm/i915/huc: Unified css_header struct for GuC and HuC

.@intel.com> > Signed-off-by: Anusha Srivatsa <anusha.sriva...@intel.com> > Signed-off-by: Alex Dai <yu@intel.com> > Signed-off-by: Peter Antoine <peter.anto...@intel.com> Reviewed-by: Arkadiusz Hiler <arkadiusz.hi...@intel.com> > --- &g

Re: [Intel-gfx] [PATCH 1/8] drm/i915/guc: Make the GuC fw loading helper functions general

va...@intel.com> > Signed-off-by: Alex Dai <yu....@intel.com> > Signed-off-by: Peter Antoine <peter.anto...@intel.com> Reviewed-by: Arkadiusz Hiler <arkadiusz.hi...@intel.com> -- Cheers, Arek ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] ✗ Fi.CI.BAT: warning for drm/i915/guc: Drop comment on fwif autogeneration

On Mon, Dec 05, 2016 at 06:59:01PM +, Patchwork wrote: > == Series Details == > > Series: drm/i915/guc: Drop comment on fwif autogeneration > URL : https://patchwork.freedesktop.org/series/16373/ > State : warning > > == Summary == > > Series 16373v1 drm/i915/guc: Drop comment on fwif

Re: [Intel-gfx] [PATCH] drm/i915/guc: Drop comment on fwif autogeneration

and naming conventions. > > > >Cc: Anusha Srivatsa <anusha.sriva...@intel.com> > >Cc: Jeff Mcgee <jeff.mc...@intel.com> > >Cc: Sagar A. Kamble <sagar.a.kam...@intel.com> > >Signed-off-by: Arkadiusz Hiler <arkadiusz.hi...@intel.com> &

[Intel-gfx] [PATCH] drm/i915/guc: Drop comment on fwif autogeneration

it comes to structure reuse (HuC/GuC) and naming conventions. Cc: Anusha Srivatsa <anusha.sriva...@intel.com> Cc: Jeff Mcgee <jeff.mc...@intel.com> Cc: Sagar A. Kamble <sagar.a.kam...@intel.com> Signed-off-by: Arkadiusz Hiler <arkadiusz.hi...@intel.com> --- drivers/gpu/drm/i

Re: [Intel-gfx] [PATCH 8/8] drm/i915/get_params: Add HuC status to getparams

ebased. > v5: rebased on top of drm-tip. > > Signed-off-by: Peter Antoine <peter.anto...@intel.com> Reviewed-by: Arkadiusz Hiler <arkadiusz.hi...@intel.com> > --- > drivers/gpu/drm/i915/i915_drv.c | 5 + > drivers/gpu/drm/i915/intel_huc.h| 1 + > d

Re: [Intel-gfx] [PATCH 7/8] drm/i915/huc: Support HuC authentication

On Wed, Nov 30, 2016 at 03:31:33PM -0800, Anusha Srivatsa wrote: > From: Peter Antoine > > The HuC authentication is done by host2guc call. The HuC RSA keys > are sent to GuC for authentication. > > v2: rebased on top of drm-intel-nightly. > changed name format and

Re: [Intel-gfx] [PATCH 2/8] drm/i915/huc: Unified css_header struct for GuC and HuC

On Wed, Nov 30, 2016 at 03:31:28PM -0800, Anusha Srivatsa wrote: > From: Peter Antoine > > HuC firmware css header has almost exactly same definition as GuC > firmware except for the sw_version. Also, add a new member fw_type > into intel_uc_fw to indicate what kind of

Re: [Intel-gfx] ✗ Fi.CI.BAT: warning for series starting with [CI,1/5] drm/i915: Rename intel_guc.h to intel_uc.h

On Mon, Nov 28, 2016 at 12:53:27PM +, Patchwork wrote: > == Series Details == > > Series: series starting with [CI,1/5] drm/i915: Rename intel_guc.h to > intel_uc.h > URL : https://patchwork.freedesktop.org/series/16034/ > State : warning > > == Summary == > > Series 16034v1 Series

[Intel-gfx] [PATCH 3/5] drm/i915/guc: Move guc_{send, recv}() to intel_uc.c

intel_guc_send usages Cc: Chris Wilson <ch...@chris-wilson.co.uk> Cc: Michal Winiarski <michal.winiar...@intel.com> Signed-off-by: Arkadiusz Hiler <arkadiusz.hi...@intel.com> Reviewed-by: Chris Wilson <ch...@chris-wilson.co.uk> --- drivers/gpu/drm/i915/Makefile

[Intel-gfx] [PATCH 5/5] drm/i915/guc: Remove spurious include

Cc: Chris Wilson <ch...@chris-wilson.co.uk> Cc: Michal Winiarski <michal.winiar...@intel.com> Signed-off-by: Arkadiusz Hiler <arkadiusz.hi...@intel.com> Reviewed-by: Chris Wilson <ch...@chris-wilson.co.uk> --- drivers/gpu/drm/i915/i915_guc_submission.c | 1 - 1 file chan

[Intel-gfx] [PATCH 4/5] drm/i915/guc: Init send_mutex in intel_uc_init_early()

gt; Cc: Michal Winiarski <michal.winiar...@intel.com> Signed-off-by: Arkadiusz Hiler <arkadiusz.hi...@intel.com> Reviewed-by: Chris Wilson <ch...@chris-wilson.co.uk> --- drivers/gpu/drm/i915/i915_drv.c| 2 ++ drivers/gpu/drm/i915/i915_guc_submission.c | 1 - drivers

[Intel-gfx] [PATCH 1/5] drm/i915: Rename intel_guc.h to intel_uc.h

GuC is not the only one micro controller we have. There are also HuC and DMC. Making the file more general will help with code organization. Cc: Chris Wilson <ch...@chris-wilson.co.uk> Cc: Michal Winiarski <michal.winiar...@intel.com> Signed-off-by: Arkadiusz Hiler <arkadiusz.

[Intel-gfx] [PATCH 2/5] drm/i915/guc: Drop guc2host/host2guc from names

omes send_mutex v2: drop unnecessary backslashes and use BIT() instead of '<<' v3: shortened enum names and INTEL_GUC_STATUS_* Cc: Chris Wilson <ch...@chris-wilson.co.uk> Cc: Michal Winiarski <michal.winiar...@intel.com> Signed-off-by: Arkadiusz Hiler <arkadiusz.hi...@intel.com&g

[Intel-gfx] [PATCH v3 0/5] GuC code reorganization

were renamed and moved around. v2: host2guc and guc2host renaming, init mutex in intel_uc_init() v3: another round of review, general code scrub and slight renaming Arkadiusz Hiler (5): drm/i915: Rename intel_guc.h to intel_uc.h drm/i915/guc: Drop guc2host/host2guc from names drm/i915/guc

Re: [Intel-gfx] [PATCH 0/8] HuC Loading Patches

On Wed, Nov 23, 2016 at 02:27:35PM -0800, Anusha Srivatsa wrote: > These patches add HuC loading support. The userspace > patches that check for a fully loaded HuC firmware and use > it can be found at: > https://lists.freedesktop.org/archives/libva/2016-September/004554.html >

[Intel-gfx] [PATCH v2] drm/i915/guc: Move guc_{send, recv}() to intel_uc.c

intel_guc_send uses Cc: Chris Wilson <ch...@chris-wilson.co.uk> Cc: Michal Winiarski <michal.winiar...@intel.com> Signed-off-by: Arkadiusz Hiler <arkadiusz.hi...@intel.com> --- drivers/gpu/drm/i915/Makefile | 3 +- drivers/gpu/drm/i915/i915_guc_

[Intel-gfx] [PATCH v3] drm/i915/guc: Drop guc2host/host2guc from names

omes send_mutex v2: drop unnecessary backslashes and use BIT() instead of '<<' v3: shortened enum names and INTEL_GUC_STATUS_* Cc: Chris Wilson <ch...@chris-wilson.co.uk> Cc: Michal Winiarski <michal.winiar...@intel.com> Signed-off-by: Arkadiusz Hiler <arkadiusz.hi...@intel.com&g

[Intel-gfx] [PATCH v2] drm/i915/guc: Drop guc2host/host2guc from names

tead of '<<' Cc: Chris Wilson <ch...@chris-wilson.co.uk> Cc: Michal Winiarski <michal.winiar...@intel.com> Signed-off-by: Arkadiusz Hiler <arkadiusz.hi...@intel.com> --- drivers/gpu/drm/i915/i915_guc_reg.h| 4 +- drivers/gpu/drm/i91

[Intel-gfx] [PATCH v2] drm/i915/guc: Init send_mutex in intel_uc_init_early()

gt; Cc: Michal Winiarski <michal.winiar...@intel.com> Signed-off-by: Arkadiusz Hiler <arkadiusz.hi...@intel.com> Reviewed-by: Chris Wilson <ch...@chris-wilson.co.uk> --- drivers/gpu/drm/i915/i915_drv.c| 2 ++ drivers/gpu/drm/i915/i915_guc_submission.c | 1 - drivers

[Intel-gfx] [PATCH 1/5] drm/i915: Rename intel_guc.h to intel_uc.h

GuC is not the only one micro controller we have. There are also HuC and DMC. Making the file more general will help with code organization. Cc: Chris Wilson <ch...@chris-wilson.co.uk> Cc: Michal Winiarski <michal.winiar...@intel.com> Signed-off-by: Arkadiusz Hiler <arkadiusz.

[Intel-gfx] [PATCH 4/5] drm/i915/guc: Init send_mutex in intel_uc_init()

al.winiar...@intel.com> Signed-off-by: Arkadiusz Hiler <arkadiusz.hi...@intel.com> --- drivers/gpu/drm/i915/i915_drv.c| 1 + drivers/gpu/drm/i915/i915_guc_submission.c | 1 - drivers/gpu/drm/i915/intel_uc.c| 5 + drivers/gpu/drm/i915/intel_uc.h| 1 +

[Intel-gfx] [PATCH 3/5] drm/i915/guc: Move guc_{send, recv}() to intel_uc.c

gt; Cc: Michal Winiarski <michal.winiar...@intel.com> Signed-off-by: Arkadiusz Hiler <arkadiusz.hi...@intel.com> --- drivers/gpu/drm/i915/Makefile | 3 +- drivers/gpu/drm/i915/i915_guc_submission.c | 131 +++ drivers/gpu/drm/i915/intel_uc.

[Intel-gfx] [PATCH 2/5] drm/i915/guc: Drop guc2host/host2guc from names

Cc: Michal Winiarski <michal.winiar...@intel.com> Signed-off-by: Arkadiusz Hiler <arkadiusz.hi...@intel.com> --- drivers/gpu/drm/i915/i915_guc_reg.h| 4 +- drivers/gpu/drm/i915/i915_guc_submission.c | 91 +++--- drivers/gpu/drm/i915/i915_irq.c

[Intel-gfx] [PATCH v2 0/5] GuC code reorganization

were renamed and moved around. v2: host2guc and guc2host renaming, init mutex in intel_uc_init() Arkadiusz Hiler (5): drm/i915: Rename intel_guc.h to intel_uc.h drm/i915/guc: Drop guc2host/host2guc from names drm/i915/guc: Move guc_{send,recv}() to intel_uc.c drm/i915/guc: Init send_mutex

[Intel-gfx] [PATCH 5/5] drm/i915/guc: Remove spurious include

Cc: Chris Wilson <ch...@chris-wilson.co.uk> Cc: Michal Winiarski <michal.winiar...@intel.com> Signed-off-by: Arkadiusz Hiler <arkadiusz.hi...@intel.com> Reviewed-by: Chris Wilson <ch...@chris-wilson.co.uk> --- drivers/gpu/drm/i915/i915_guc_submission.c | 1 - 1 file chan

[Intel-gfx] [PATCH 4/4] drm/i915/guc: Remove spurious include

Signed-off-by: Arkadiusz Hiler <arkadiusz.hi...@intel.com> Cc: Chris Wilson <ch...@chris-wilson.co.uk> Cc: Michal Winiarski <michal.winiar...@intel.com> --- drivers/gpu/drm/i915/i915_guc_submission.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_g

[Intel-gfx] [PATCH 1/4] drm/i915: Rename intel_guc.h to intel_uc.h

GuC is not the only one micro controller we have. There are also HuC and DMC. Making the file more general will help with code organization. Signed-off-by: Arkadiusz Hiler <arkadiusz.hi...@intel.com> Cc: Chris Wilson <ch...@chris-wilson.co.uk> Cc: Michal Winiarski <michal.wini

[Intel-gfx] [PATCH 3/4] drm/i915/guc: Init action_lock in the loader

Action_lock is a mutex used to serialise communication with GuC. Since some functions which utilize the mutex (host2guc_*()) are no longer limited to submission, initialization should be handled as a part of GuC setup. Signed-off-by: Arkadiusz Hiler <arkadiusz.hi...@intel.com> Cc: Chris

[Intel-gfx] [PATCH 2/4] drm/i915/guc: Move host2guc_*() to intel_uc.c

host2guc_*() series of functions were introduced in the i915_guc_submission.c and their scope was limited only to that file. Those are not submission specific though. Signed-off-by: Arkadiusz Hiler <arkadiusz.hi...@intel.com> Cc: Chris Wilson <ch...@chris-wilson.co.uk> Cc: Mich

[Intel-gfx] [PATCH 0/4] GuC code reorganization

With HuC being imminent we could benefit from some code reorganization. There will be more uC than just GuC so we should name files accordingly. There is also need to use host2guc_*() family of functions, which are currently limited to submission only. Arkadiusz Hiler (4): drm/i915: Rename

Re: [Intel-gfx] [PATCH 1/8] drm/i915/guc: Make the GuC fw loading helper functions general. Always initialize action_lock

On Thu, Nov 24, 2016 at 09:28:14AM +0100, Arkadiusz Hiler wrote: > On Wed, Nov 23, 2016 at 02:27:36PM -0800, Anusha Srivatsa wrote: > > From: Peter Antoine <peter.anto...@intel.com> > > > > Rename some of the GuC fw loading code to make them more general. We > >

Re: [Intel-gfx] [PATCH 1/8] drm/i915/guc: Make the GuC fw loading helper functions general. Always initialize action_lock

gned-off-by: Peter Antoine <peter.anto...@intel.com> > Reviewed-by: Dave Gordon <david.s.gor...@intel.com> > Reviewed-by: Jeff McGee <jeff.mc...@intel.com> > Reviewed-by: Carlos Santa <carlos.sa...@intel.com> > Tested-by: Carlos Santa <carlos.sa...@intel.com>

Re: [Intel-gfx] [PATCH] drm/i915/guc: Always initialize action_lock

Arkadiusz <arkadiusz.hi...@intel.com> > >Cc: intel-gfx@lists.freedesktop.org > >Subject: Re: [Intel-gfx] [PATCH] drm/i915/guc: Always initialize action_lock > > > >On Tue, Nov 22, 2016 at 05:22:47PM +0100, Arkadiusz Hiler wrote: > >> Action lock is not being ini

Re: [Intel-gfx] [PATCH] drm/i915/guc: Always initialize action_lock

On Wed, Nov 23, 2016 at 10:07:27AM +, Chris Wilson wrote: > On Wed, Nov 23, 2016 at 10:41:42AM +0100, Arkadiusz Hiler wrote: > > On Tue, Nov 22, 2016 at 05:05:32PM +, Chris Wilson wrote: > > > On Tue, Nov 22, 2016 at 05:22:47PM +0100, Arkadiusz Hiler wrote: > > >

Re: [Intel-gfx] [PATCH] drm/i915/guc: Always initialize action_lock

On Tue, Nov 22, 2016 at 05:05:32PM +, Chris Wilson wrote: > On Tue, Nov 22, 2016 at 05:22:47PM +0100, Arkadiusz Hiler wrote: > > Action lock is not being initialized if the GuC submission is disabled > > (i.e. i915.guc_submission=0). > > > > host2guc_action(), whi

[Intel-gfx] [PATCH] drm/i915/guc: Always initialize action_lock

to use the host2guc_action no matter whether submission is enabled or not. Cc: Anusha Srivatsa <anusha.sriva...@intel.com> Cc: Jeff McGee <jeff.mc...@intel.com> Signed-off-by: Arkadiusz Hiler <arkadiusz.hi...@intel.com> --- drivers/gpu/drm/i915/i915_guc_submission.c | 3 ++-

[Intel-gfx] [PATCH v2] drm/i915: Whitelist TIMESTAMP register from BLT ring for gen9+

From: Andrzej Lawrynowicz <andrzej.lawrynow...@intel.com> Since gen9 timestamp can be read from BLT ring (TIMESTAMP_BCSUNIT). Add this register to reg_read ioctl whitelist. v2: commit message change (Arkadiusz Hiler) Cc: Chris Wilson <ch...@chris-wilson.co.uk> Cc: Arkadiusz Hiler &

[Intel-gfx] [PATCH] drm/i915: fix comment on I915_{READ,WRITE}_FW

,put} instead of plain ones Cc: Chris Wilson <ch...@chris-wilson.co.uk> Cc: Matthew Auld <matthew.a...@intel.com> Cc: Mika Kuoppala <mika.kuopp...@linux.intel.com> Signed-off-by: Arkadiusz Hiler <arkadiusz.hi...@intel.com> --- drivers/gpu/drm/i915/i915_drv.h | 28 +++

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: fix comment on I915_{READ,WRITE}_FW (rev2)

On Tue, Oct 25, 2016 at 04:27:26PM +0200, Saarinen, Jani wrote: > > == Series Details == > > > > Series: drm/i915: fix comment on I915_{READ,WRITE}_FW (rev2) > > URL : https://patchwork.freedesktop.org/series/14334/ > > State : failure > > > > == Summary == > > > > Series 14334v2 drm/i915:

[Intel-gfx] [PATCH v2] drm/i915: fix comment on I915_{READ, WRITE}_FW

,put} instead of plain ones Cc: Chris Wilson <ch...@chris-wilson.co.uk> Cc: Matthew Auld <matthew.a...@intel.com> Cc: Mika Kuoppala <mika.kuopp...@linux.intel.com> Signed-off-by: Arkadiusz Hiler <arkadiusz.hi...@intel.com> --- drivers/gpu/drm/i915/i915_drv.h | 28 +++

[Intel-gfx] [PATCH] drm/i915: fix comment on I915_{READ,WRITE}_FW

w Auld <matthew.a...@intel.com> Cc: Mika Kuoppala <mika.kuopp...@linux.intel.com> Signed-off-by: Arkadiusz Hiler <arkadiusz.hi...@intel.com> --- drivers/gpu/drm/i915/i915_drv.h | 28 +--- 1 file changed, 25 insertions(+), 3 deletions(-) diff --git a/drivers

Re: [Intel-gfx] [PATCH] drm/i915: fix comment referencing imaginary functions

On Fri, Oct 21, 2016 at 02:57:28PM +0100, Chris Wilson wrote: > On Fri, Oct 21, 2016 at 04:00:10PM +0300, Mika Kuoppala wrote: > > Chris Wilson <ch...@chris-wilson.co.uk> writes: > > > > > On Fri, Oct 21, 2016 at 02:16:46PM +0200, Arkadiusz Hiler wrote: > > &

Re: [Intel-gfx] [PATCH] drm/i915: fix comment referencing imaginary functions

d never have > for that matter(according to git). Let's fix that by replacing them with > intel_uncore_forcewake_{get, put}. > > Cc: Chris Wilson <ch...@chris-wilson.co.uk> > Signed-off-by: Matthew Auld <matthew.a...@intel.com> Reviewed-by: Arkadiusz Hiler <arkadiusz

[Intel-gfx] [PATCH v3] drm/i915/gvt: Implement WaForceWakeRenderDuringMmioTLBInvalidate

and I915_WRITE_FW as we are handling forcewake on in the code path References: HSD#2136899, HSD#1404391274 Cc: Mika Kuoppala <mika.kuopp...@intel.com> Cc: Zhenyu Wang <zhen...@linux.intel.com> Signed-off-by: Arkadiusz Hiler <arkadiusz.hi...@intel.com> --- drivers/gpu/drm/i915

<    1   2   3   4   5   6   >