-Original Message-
From: Vivi, Rodrigo
Sent: Friday, October 11, 2024 2:41 PM
To: intel-gfx@lists.freedesktop.org
Cc: Vivi, Rodrigo ; Stephen Rothwell
; Cavitt, Jonathan ; Andi
Shyti
Subject: [PATCH] drm/i915: Fix irq related documentation
>
> Also update the function names
-Original Message-
From: Deak, Imre
Sent: Wednesday, October 9, 2024 2:26 PM
To: Cavitt, Jonathan
Cc: intel...@lists.freedesktop.org; intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH v2 1/4] drm/i915/dp: Assume panel power is off if runtime
suspended
>
> On Wed, Oct 09, 2024
he resumed state.
>
> Testcase: igt/kms_pm_rpm/unverisal-planes
> Signed-off-by: Imre Deak
LGTM.
Reviewed-by: Jonathan Cavitt
-Jonathan Cavitt
> ---
> drivers/gpu/drm/i915/display/intel_dp.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/dr
struct device *kdev; /* points to i915->drm.dev */"
So, "intel_runtime_pm_suspended(&i915->runtime_pm)" seems
to be logically equivalent to
"pm_runtime_suspended(i915->drm.dev)", which would mean we
wouldn't need to declare the new helper function
"intel_
npin_vma(struct i915_vma *vma, unsigned long flags)
> @@ -372,11 +381,15 @@ int intel_plane_pin_fb(struct intel_plane_state
> *plane_state)
> struct drm_gem_object *obj = intel_fb_bo(fb);
> struct xe_bo *bo = gem_to_xe_bo(obj);
> struct i915_vma *vma;
&
-Original Message-
From: Intel-xe On Behalf Of Juha-Pekka
Heikkila
Sent: Wednesday, October 9, 2024 8:20 AM
To: intel...@lists.freedesktop.org; intel-gfx@lists.freedesktop.org
Cc: Juha-Pekka Heikkila
Subject: [PATCH 1/2] drm/xe: add interface to request physical alignment for
buffer obj
Fixes: aa451abcffb5 ("drm/i915/display: Prevent DC6 while vblank is enabled
> for Panel Replay")
> Signed-off-by: Jouni Högander
> Suggested-by: Ville Syrjälä
LGTM.
Reviewed-by: Jonathan Cavitt
-Jonathan Cavitt
> ---
> drivers/gpu/drm/i915/display/intel_display_i
w counter named as vblank_wa_pipes.
>
> v2:
> - s/vblank_wa_pipes/vblank_wa_num_pipes/
> - use int as a type for the counter
>
> Signed-off-by: Jouni Högander
LGTM.
Reviewed-by: Jonathan Cavitt
-Jonathan Cavitt
> ---
> drivers/gpu/drm/i915/display/intel_display_cor
kernel options in drm_fb_helper.o, so leave this
> file in the KMS-helper module for now.
>
> v3:
> - fix commit changelog
> v2:
> - keep client code in core
> - protect lib with DRM_CLIENT_LIB
> - remove duplicate line from Makefile (Jocelyn)
>
> Signed-off-by: Thomas
ient_debugfs_init() if DRM_CLIENT=n (kernel
> test robot)
>
> Signed-off-by: Thomas Zimmermann
> Cc: Alex Deucher
> Cc: "Christian König"
> Cc: Xinhui Pan
LGTM.
Reviewed-by: Jonathan Cavitt
-Jonathan Cavitt
> ---
> drivers/gpu/drm/Kconfig
iew this
patch before deciding to push.
Reviewed-by: Jonathan Cavitt
-Jonathan Cavitt
> ---
> drivers/gpu/drm/radeon/radeon_device.c | 19 ++-
> drivers/gpu/drm/radeon/radeon_fbdev.c | 6 --
> drivers/gpu/drm/radeon/radeon_mode.h | 3 ---
> 3 files change
is is okay.
I'd wait for an expert on nouveau to respond first before
jumping to push.
Reviewed-by: Jonathan Cavitt
-Jonathan Cavitt
> ---
> drivers/gpu/drm/nouveau/nouveau_display.c | 8 +++-
> 1 file changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/drivers
t my place to say this is okay.
I'd wait for an expert on the amdgpu to respond first before
jumping to push.
Reviewed-by: Jonathan Cavitt
-Jonathan Cavitt
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 22 +++---
> 1 file changed, 11 insertions(+), 1
-Original Message-
From: Intel-xe On Behalf Of Thomas
Zimmermann
Sent: Tuesday, October 8, 2024 4:59 AM
To: sim...@ffwll.ch; airl...@gmail.com; javi...@redhat.com; jfale...@redhat.com
Cc: dri-de...@lists.freedesktop.org; amd-...@lists.freedesktop.org;
intel-gfx@lists.freedesktop.org; int
> - rename new files to drm_client_event.{c,h}
>
> Signed-off-by: Thomas Zimmermann
> Cc: Jani Nikula
> Cc: Rodrigo Vivi
> Cc: Joonas Lahtinen
> Cc: Tvrtko Ursulin
> Cc: Karol Herbst
> Cc: Lyude Paul
> Cc: Danilo Krummrich
LGTM.
Reviewed-by: Jonathan Cavitt
-Jona
Thomas Zimmermann
LGTM.
Reviewed-by: Jonathan Cavitt
-Jonathan Cavitt
> ---
> drivers/gpu/drm/drm_fb_helper.c | 31 --
> drivers/gpu/drm/drm_internal.h | 7 +
> drivers/gpu/drm/drm_kms_helper_common.c | 35 +
> 3 files
gt; core DRM module.
>
> Signed-off-by: Thomas Zimmermann
LGTM.
Reviewed-by: Jonathan Cavitt
-Jonathan Cavitt
> ---
> drivers/gpu/drm/Kconfig | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig
> ind
gned-off-by: Thomas Zimmermann
> Reported-by: kernel test robot
> Closes:
> https://lore.kernel.org/oe-kbuild-all/202410050241.mox9qrjp-...@intel.com/
> Fixes: 808a40b69468 ("drm/fbdev-dma: Implement damage handling and deferred
> I/O")
> Cc: Thomas Zimmermann
> Cc
; Signed-off-by: Thomas Zimmermann
> Cc: Lucas De Marchi
> Cc: "Thomas Hellström"
> Cc: Rodrigo Vivi
LGTM.
Reviewed-by: Jonathan Cavitt
-Jonathan Cavitt
> ---
> drivers/gpu/drm/xe/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/dr
from i915.
>
> Signed-off-by: Thomas Zimmermann
> Cc: Jani Nikula
> Cc: Joonas Lahtinen
> Cc: Rodrigo Vivi
> Cc: Tvrtko Ursulin
LGTM.
Reviewed-by: Jonathan Cavitt
-Jonathan Cavitt
> ---
> drivers/gpu/drm/i915/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> d
on path.
Again, none of this is blocking, so there's no need to upend everything
and start over. I just felt I needed to state some of these things as a
part of due diligence.
Reviewed-by: Jonathan Cavitt
-Jonathan Cavitt
>
>
> Rodrigo Vivi (31):
> drm/i915: Remove vga and gm
isplay_driver side.
>
> Xe display power management functions are now only a wrapper
> checking for xe's display probe parameter.
>
> Signed-off-by: Rodrigo Vivi
LGTM.
Reviewed-by: Jonathan Cavitt
-Jonathan Cavitt
> ---
> .../drm/i915/display/intel_display_driver
-d3cold rpm
>
> On the regular igfx runtime pm sequence where d3cold is not
> possible, the proper calls to power display are required.
>
> Align with i915.
>
> Signed-off-by: Rodrigo Vivi
LGTM.
Reviewed-by: Jonathan Cavitt
-Jonathan Cavitt
> ---
> drivers/gpu/drm/
calling xe_display_flush_cleanup_work here is no
longer necessary. With no other use cases, this function
can safely be removed.
"""
Just a suggestion. Not blocking.
Reviewed-by: Jonathan Cavitt
-Jonathan Cavitt
> Signed-off-by: Rodrigo Vivi
> ---
> drivers/gpu
e runtime_pm sequences can be reconciled, it is needed to
> ensure that the Xe's IRQ are disabled before the display.
>
> Signed-off-by: Rodrigo Vivi
LGTM.
Reviewed-by: Jonathan Cavitt
-Jonathan Cavitt
> ---
> drivers/gpu/drm/xe/xe_pm.c | 3 +--
> 1 file changed, 1 in
non-d3cold
>
> Opregion needs to be notified about the power transition even when
> not going to d3cold. This aligns with i915 sequence.
>
> Signed-off-by: Rodrigo Vivi
LGTM.
Reviewed-by: Jonathan Cavitt
-Jonathan Cavitt
> ---
> drivers/gpu/drm/xe/display/xe_display
resume
>
> Continuing the alignment with i915 runtime pm sequence. Add
> this missing call.
>
> Signed-off-by: Rodrigo Vivi
LGTM.
Reviewed-by: Jonathan Cavitt
-Jonathan Cavitt
> ---
> drivers/gpu/drm/xe/display/xe_display.c | 2 ++
> 1 file changed, 2 insertions(+)
&
>
> Align placement of HDP poll calls with i915.
>
> Signed-off-by: Rodrigo Vivi
LGTM.
Reviewed-by: Jonathan Cavitt
-Jonathan Cavitt
> ---
> drivers/gpu/drm/xe/display/xe_display.c | 7 +++
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a
every runtime
resume
>
> We need to ensure this is called on every kind of runtime
> resume and not only on d3cold is possible. Aligning with
> the hpd sequence from i915.
>
> Cc: Vinod Govindapillai
> Signed-off-by: Rodrigo Vivi
LGTM.
Reviewed-by: Jonathan Cav
= xe->d3cold.allowed ?
xe_pcode_ready(xe, true) : 0;
if (err)
goto out;
xe_display_pm_runtime_resume_early(xe);
err = xe->d3cold.allowed ?
xe_bo_restore_kernel(xe) : 0;
if (err)
goto out;
"""
IMO I don't think either of these new options are particular upgrades to
the current implementation. If anything, they're probably just side-grades.
So I won't force the issue.
Reviewed-by: Jonathan Cavitt
-Jonathan Cavitt
>
> + if (xe->d3cold.allowed) {
> /*
>* This only restores pinned memory which is the memory
>* required for the GT(s) to resume.
> --
> 2.46.0
>
>
intel_display_driver
>
> Continue moving more display stuff from i915_driver to intel_display.
> With the end goal of reconciling xe and i915 sequences.
>
> Signed-off-by: Rodrigo Vivi
LGTM.
Reviewed-by: Jonathan Cavitt
-Jonathan Cavitt
> ---
> .../drm/i915/display/intel_di
intel_driver
>
> Move dsm register/unregister calls from the drivers to under
> intel_display_driver register/unregister.
>
> Signed-off-by: Rodrigo Vivi
LGTM.
Reviewed-by: Jonathan Cavitt
-Jonathan Cavitt
> ---
> drivers/gpu/drm/i915/display/intel_display_driver.c | 4
&g
> Then, use directly all the intel_display_driver functions for
> a full alignment.
>
> Signed-off-by: Rodrigo Vivi
LGTM.
Reviewed-by: Jonathan Cavitt
-Jonathan Cavitt
> ---
> drivers/gpu/drm/xe/display/xe_display.c | 25 ++---
> drivers/gpu/drm/xe/display
ddition and use of xe_display_pm_resume_noirq and
xe_display_pm_resume_noaccel
I won't say these changes need to be separated, but it might
be worth considering.
Reviewed-by: Jonathan Cavitt
-Jonathan Cavitt
> ---
> drivers/gpu/drm/xe/display/xe_display.c | 23 ---
; Some functions are not yet called from Xe. Move them to a
> separate function that will be only used in i915 for now.
>
> Signed-off-by: Rodrigo Vivi
s/be only/only be
But otherwise:
Reviewed-by: Jonathan Cavitt
-Jonathan Cavitt
> ---
> drivers/gpu/drm/i915/display/intel_
intel_display
>
> Consolidate the intel_power_domains calls under
> intel_display_driver.
>
> Signed-off-by: Rodrigo Vivi
LGTM. I'd suggest splitting this patch into i915 and xe parts,
but for this patch in particular it might be a bit difficult.
Reviewed-by: Jonathan Cavi
for i915 and xe).
But I'll trust your judgement here.
Reviewed-by: Jonathan Cavitt
-Jonathan Cavitt
> ---
> drivers/gpu/drm/i915/display/intel_display_power.c | 6 +-
> drivers/gpu/drm/i915/display/intel_display_power.h | 2 +-
> drivers/gpu/drm/i915/i915_driver.c
g some consistency to register/unregister order at the
> same time it aligns with i915 sequence order.
>
> Signed-off-by: Rodrigo Vivi
LGTM.
Reviewed-by: Jonathan Cavitt
-Jonathan Cavitt
> ---
> drivers/gpu/drm/xe/display/xe_display.c | 2 +-
> 1 file changed, 1 insertion(+),
drm_mode_config_reset(dev);
> + intel_display_driver_resume_nogem(display);
>
> i915_gem_resume(dev_priv);
>
> diff --git a/drivers/gpu/drm/xe/display/xe_fb_pin.c
> b/drivers/gpu/drm/xe/display/xe_fb_pin.c
> index 49dc91bdbcb0..c26a47dac332 100644
> --- a/drivers/gpu/drm/xe/display/xe_fb_pin.c
> +++ b/drivers/gpu/drm/xe/display/xe_fb_pin.c
> @@ -412,3 +412,7 @@ u64 intel_dpt_offset(struct i915_vma *dpt_vma)
> void intel_dpt_suspend(struct xe_device *xe)
> {
> }
> +
> +void intel_dpt_resume(struct xe_device *xe)
> +{
> +}
See my note on patch 8. Otherwise:
Reviewed-by: Jonathan Cavitt
-Jonathan Cavitt
> --
> 2.46.0
>
>
5 and xe.
I won't block on it, though.
Reviewed-by: Jonathan Cavitt
-Jonathan Cavitt
> ---
> .../gpu/drm/i915/display/intel_display_driver.c | 9 +
> drivers/gpu/drm/i915/i915_driver.c| 12
> drivers/gpu/drm/xe/display/xe_display.c
ave its definition
removed, which is not the case. I can't think of any
better alternatives, though, so I won't block on it.
Reviewed-by: Jonathan Cavitt
-Jonathan Cavitt
Reviewed-by: Jonathan Cavitt
> ---
> drivers/gpu/drm/i915/i915_driver.c | 2 --
> 1 file changed, 2 dele
t looks like everything here is being gated by HAS_DISPLAY, when
it wasn't before in i915_drm_resume or xe_display_pm_resume. Is this
correct behavior?
I'll trust your judgement on this.
Reviewed-by: Jonathan Cavitt
-Jonathan Cavitt
> }
>
> void intel_display_driver_shutdown(str
g scheme? Something like:
xe_display_enable_d3cold
xe_display_disable_d3cold
Also, we're going to need to move these functions in patch 31 later, so perhaps
it
would be for the best to put these functions in the correct place from the
start?
I won't block on this, but do consider renamin
15 and only initialize hotplugs after the display driver
> access has been resumed.
>
> Signed-off-by: Rodrigo Vivi
LGTM.
Reviewed-by: Jonathan Cavitt
-Jonathan Cavitt
> ---
> drivers/gpu/drm/xe/display/xe_display.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
&
; +++ b/drivers/gpu/drm/xe/display/xe_fb_pin.c
> @@ -408,3 +408,7 @@ u64 intel_dpt_offset(struct i915_vma *dpt_vma)
> {
> return 0;
> }
> +
> +void intel_dpt_suspend(struct xe_device *xe)
> +{
> +}
I can't really tell why this is being disabled here. Maybe this can be broken
into a separate patch with an explanation for why this is being done?
Something similar is done in patch 14 with intel_dpt_resume, so perhaps
both changes can be collected together in the same patch?
I won't block on it, but I am curious.
Reviewed-by: Jonathan Cavitt
-Jonathan Cavitt
> --
> 2.46.0
>
>
e.
Reviewed-by: Jonathan Cavitt
-Jonathan Cavitt
> ---
> drivers/gpu/drm/i915/display/intel_display_driver.c | 6 ++
> drivers/gpu/drm/i915/i915_driver.c | 4
> drivers/gpu/drm/xe/display/xe_display.c | 7 ---
> 3 files changed, 6 insertio
Start the xe-i915-display reconciliation by using the same
> shutdown sequences.
>
> Signed-off-by: Rodrigo Vivi
LGTM.
Reviewed-by: Jonathan Cavitt
-Jonathan Cavitt
> ---
> drivers/gpu/drm/xe/display/xe_display.c | 46 +++--
> drivers/gpu/drm/xe/d
_atomic_helper_shutdown.
> }
>
> - xe_display_flush_cleanup_work(xe);
And I'm guessing we're removing this line because it's a duplicate in the new
execution path now?
I won't block on it.
Reviewed-by: Jonathan Cavitt
-Jonathan Cavitt
> intel_dp_mst_suspend(xe);
> intel_hpd_cancel_work(xe);
>
> --
> 2.46.0
>
>
intel_encoder_suspend_all(&i915->display);
> - intel_encoder_shutdown_all(&i915->display);
> -
> - intel_dmc_suspend(&i915->display);
> + intel_display_driver_shutdown_noirq(i915);
>
> i915_gem_suspend(i915);
>
> - /*
> -
27;ve been squashed together, but I think this separation is fine, as
this patch does do something distinct from the prior one (component
relocation vs. suspend depreciation).
LGTM.
Reviewed-by: Jonathan Cavitt
-Jonathan Cavitt
> ---
> .../gpu/drm/i915/display/i9xx_display_sr.c| 40
gt; Cc: Jani Nikula
> Signed-off-by: Rodrigo Vivi
LGTM.
Reviewed-by: Jonathan Cavitt
-Jonathan Cavitt
> ---
> drivers/gpu/drm/i915/Makefile | 2 +-
> .../gpu/drm/i915/display/i9xx_display_sr.c| 95
> .../gpu/drm/i915/display/i9xx_display
i915_restore_display
>
> Restrict this function to only save and restore registers
> functionality. Then, that can be moved out later to under
> display with a proper name.
>
> Cc: Jani Nikula
> Signed-off-by: Rodrigo Vivi
LGTM.
Reviewed-by: Jonathan Cavitt
-Jonathan Cavitt
e patch?
Not blocking, just curious.
Reviewed-by: Jonathan Cavitt
-Jonathan Cavitt
> ---
> drivers/gpu/drm/xe/display/xe_display.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/xe/display/xe_display.c
> b/drivers/gpu/drm/xe/display/xe_display.c
>
given the second
patch's
commit message mentioning that HPD interrupts are getting disabled in the
suspend path. However, I just looked, and it seems like this is the way it has
been
since the beginning, so I'm going to trust that it's supposed to be this way.
Reviewed-by: Jonatha
-Original Message-
From: Intel-gfx On Behalf Of Mitul
Golani
Sent: Tuesday, October 1, 2024 6:47 AM
To: intel-gfx@lists.freedesktop.org
Cc: Nikula, Jani ; Syrjala, Ville
; Nautiyal, Ankit K ;
Shankar, Uma
Subject: [PATCH v13 3/3] drm/i915/panelreplay: Panel replay workaround with VRR
>
gt; + struct intel_display *display = to_intel_display(crtc_state);
> + struct drm_display_mode *adjusted_mode = &crtc_state->hw.adjusted_mode;
> +
> + if (!intel_vrr_possible(crtc_state))
> + return;
>
> - /*
> - * For XE_LPD+, we use guar
ink this can be compressed to:
"""
return !!(crtc_state->vrr.flipline);
"""
But otherwise:
Reviewed-by: Jonathan Cavitt
-Jonathan Cavitt
> +}
> +
> void
> intel_vrr_check_modeset(struct intel_atomic_state *state)
> {
> @@ -281,7 +
iv);
> void gen6_rps_reset_ei(struct drm_i915_private *dev_priv);
> u32 gen6_sanitize_rps_pm_mask(const struct drm_i915_private *i915, u32 mask);
>
> -void intel_runtime_pm_disable_interrupts(struct drm_i915_private *dev_priv);
> -void intel_runtime_pm_enable_interrupts(struct drm
functions over to using the driver version of irqs_enabled, while the
second patch would remove the duplicates.
Or perhaps the two patches could be merged?
Not blocking, just a suggestion.
Reviewed-by: Jonathan Cavitt
-Jonathan Cavitt
> ---
> drivers/gpu/drm/i915/i915_drv.h | 1 +
that got removed.
>
> But the driver one already existed under a different
> name.
>
> Cc: Jani Nikula
> Signed-off-by: Rodrigo Vivi
LGTM.
Reviewed-by: Jonathan Cavitt
-Jonathan Cavitt
> ---
> drivers/gpu/drm/i915/i915_drv.h | 2 --
> drivers/gpu/drm/i915/i915_irq.
i Nikula
> Cc: Lucas De Marchi
> Signed-off-by: Rodrigo Vivi
Apropos of nothing, it would be nice if we could decouple the Xe display driver
from the i915 driver, but I don't think this is the best place to do that.
LGTM.
Reviewed-by: Jonathan Cavitt
-Jonathan Cavitt
> ---
&g
nded up introducing the encoder
> suspend calls in the runtime routines as well, causing the circular
> locking dependency.
>
> Closes: https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/2304
> Fixes: b1d90a862c89 ("drm/xe: Use the encoder suspend helper also used by the
>
eset_worker+0xa2/0x250 [xe]
>
> v2: Also move get and get the right Fixes tag (Himal, Brost)
>
> Fixes: fb74b205cdd2 ("drm/xe: Introduce a simple wedged state")
> Cc: Himal Prasad Ghimiray
> Cc: Matthew Brost
> Signed-off-by: Rodrigo Vivi
LGTM.
Reviewed-by: Jonat
s well as its last users were removed
> in commit 326e30e4624c ("drm/i915: Drop dead code for pvc"). Follow
> through with removing the unused macros and struct member and debug
> logging.
>
> Suggested-by: Matt Roper
> Signed-off-by: Jani Nikula
LGTM.
Reviewed-by:
rio
> Cc: Alan Previn
> Cc: John Harrison
> Cc: Rodrigo Vivi
LGTM.
Reviewed-by: Jonathan Cavitt
-Jonathan Cavitt
> ---
> drivers/gpu/drm/i915/gt/uc/intel_gsc_uc.c | 2 +-
> drivers/gpu/drm/i915/gt/uc/intel_uc_fw.h | 5 +
> 2 files changed, 6 insertions(+), 1 dele
commit
> e89950553385 ("drm/i915: do not clean GT table on error path"), its
> declaration in the header file remained. Remove it.
>
> Signed-off-by: Luca Coelho
Verified: intel_gt_release_all is no longer in use.
Reviewed-by: Jonathan Cavitt
-Jonathan Cavitt
> ---
>
cking on it, though.
Reviewed-by: Jonathan Cavitt
-Jonathan Cavitt
>
> Signed-off-by: Jesus Narvaez
> ---
> drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_s
-Original Message-
From: Andi Shyti
Sent: Wednesday, August 7, 2024 2:10 AM
To: intel-gfx ; dri-devel
Cc: Chris Wilson ; Das, Nirmoy
; Cavitt, Jonathan ; Andi
Shyti
Subject: [PATCH] drm/i915/gt: Mark the GT as dead when mmio is unreliable
>
> From: Chris Wilson
>
&
-Original Message-
From: Andi Shyti
Sent: Wednesday, August 7, 2024 3:46 AM
To: intel-gfx ; dri-devel
Cc: Niemiec, Krzysztof ; Andi Shyti
; Cavitt, Jonathan
Subject: [PATCH] drm/i915/gem: Improve pfn calculation readability in
vm_fault_gtt()
>
> By moving the pfn calculation
)
> is i915_probe_error(). Switch that to use drm_dbg() and drm_err()
> instead, dropping the request to report bugs in the few remaining
> specific cases.
LGTM.
Reviewed-by: Jonathan Cavitt
-Jonathan Cavitt
>
> Signed-off-by: Jani Nikula
> ---
> drivers/gpu
intk.
In practice, it would be better to use drm level error reporting
wherever possible, so replace all uses of i915_report_error with
the equivalent drm_err call. Doing so leaves i915_report_error
with no users, so remove it.
"""
With this change:
Reviewed-by: Jonathan Cavitt
-Jon
se the
> regular drm_notice() and drm_info() calls.
>
> Signed-off-by: Jani Nikula
LGTM.
Reviewed-by: Jonathan Cavitt
-Jonathan Cavitt
> ---
> drivers/gpu/drm/i915/i915_utils.c | 10 +-
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/
drm/i915/kernel/-/issues/11255
> Signed-off-by: David Gow
Thank you for the thorough write-up of this issue.
Reviewed-by: Jonathan Cavitt
-Jonathan Cavitt
> ---
> drivers/gpu/drm/i915/gem/i915_gem_ttm.c | 12 +++-
> 1 file changed, 7 insertions(+), 5 deletions(-)
&g
.
>
> Thanks to Justin Brewer for bisecting the issue.
>
> Fixes: a78a8da51b36 ("drm/ttm: replace busy placement with flags v6")
> Fixes: 4a0e7b3c3753 ("drm/i915: fix applying placement flag")
> Link: https://gitlab.freedesktop.org/drm/i915/kernel/-
it might be best to invert the conditional check
like such:
oa_freq_hz = oa_period > NSEC_PER_SEC ? 0 :
div_u64(NSEC_PER_SEC, (u32)oa_period);
I think this is just a matter of preference, though. The explicit if-else
block is definitely clearer.
Reviewed-by: Jonathan Cavitt
-Jonathan Cavitt
>
> --
> 2.45.2
>
>
>
> trace_i915_gem_object_fault(obj, page_offset, true, write);
>
> @@ -402,12 +441,14 @@ static vm_fault_t vm_fault_gtt(struct vm_fault *vmf)
> if (ret)
> goto err_unpin;
>
> + set_address_limits(area, vma, obj_offset, &start, &end);
is ensures that the VMA
> offset is correctly aligned with the corresponding offset within
> the GGTT aperture.
>
> Increment vm_pgoff by the start of the vma_node with the offset=
> provided by the user.
>
> Suggested-by: Chris Wilson
> Signed-off-by: Andi Shyt
-Original Message-
From: Tvrtko Ursulin
Sent: Monday, July 29, 2024 1:21 AM
To: Dan Carpenter
Cc: Cavitt, Jonathan ;
intel-gfx@lists.freedesktop.org; Gupta, saurabhg ;
chris.p.wil...@linux.intel.com
Subject: Re: [PATCH] drm/i915: Allow NULL memory region
>
>
> On 26/07/2
-Original Message-
From: Nirmoy Das
Sent: Wednesday, July 17, 2024 8:22 AM
To: Cavitt, Jonathan ;
intel-gfx@lists.freedesktop.org
Cc: Gupta, saurabhg ; dan.carpen...@linaro.org;
chris.p.wil...@linux.intel.com; Andi Shyti
Subject: Re: [PATCH] drm/i915: Allow NULL memory region
-Original Message-
From: Nirmoy Das
Sent: Wednesday, July 17, 2024 8:06 AM
To: Cavitt, Jonathan ;
intel-gfx@lists.freedesktop.org
Cc: Gupta, saurabhg ; dan.carpen...@linaro.org;
chris.p.wil...@linux.intel.com; Andi Shyti
Subject: Re: [PATCH] drm/i915: Allow NULL memory region
, Jonathan
Sent: Friday, July 12, 2024 12:17 PM
To: Dan Carpenter
Cc: intel-gfx@lists.freedesktop.org; Chris Wilson
; Shyti, Andi ; Cavitt,
Jonathan
Subject: RE: [bug report] drm/i915/gem: Downgrade stolen lmem setup warning
Hello. This issue should be resolved by the commit "drm/i915/gem: R
for your patience.
-Jonathan Cavitt
-Original Message-
From: Dan Carpenter
Sent: Friday, July 12, 2024 7:04 AM
To: Cavitt, Jonathan
Cc: intel-gfx@lists.freedesktop.org
Subject: [bug report] drm/i915/gem: Downgrade stolen lmem setup warning
Hello Jonathan Cavitt,
Commit 05da7d9f717b (&
ccurately built,
so fixing it here makes the most sense to me, especially if it's causing
problems.
Reviewed-by: Jonathan Cavitt
-Jonathan Cavitt
> So, add a fix to not consider preemption
> during dequeuing for gen8 platforms.
>
> v2: Simplify can_preempt() function (Tvrtko Ursu
-Original Message-
From: Auld, Matthew
Sent: Wednesday, June 19, 2024 7:31 AM
To: intel...@lists.freedesktop.org
Cc: Cavitt, Jonathan ; Roper, Matthew D
; De Marchi, Lucas ;
Govindapillai, Vinod ;
intel-gfx@lists.freedesktop.org
Subject: [PATCH 2/2] drm/i915: disable fbc due to
-Original Message-
From: Andi Shyti
Sent: Monday, June 17, 2024 11:43 AM
To: intel-gfx ; dri-devel
Cc: Andi Shyti ; Cavitt, Jonathan
; De Marchi, Lucas
Subject: [PATCH v2 0/2] Sparse errors on the i915_gem_stolen
>
> Hi Jonathan,
>
> Commit 05da7d9f717b ("drm/i9
>
> -Original Message-
From: Vivi, Rodrigo
Sent: Friday, June 14, 2024 12:46 PM
To: Cavitt, Jonathan
Cc: Andi Shyti ; intel-gfx
; dri-devel ;
Harrison, John C
Subject: Re: [PATCH] drm/i915/gt/uc: Fix typo in comment
>
> On Fri, Jun 14, 2024 at 03:23:54PM +0000, Cavi
-Original Message-
From: Andi Shyti
Sent: Friday, June 14, 2024 8:22 AM
To: Andi Shyti
Cc: intel-gfx ; dri-devel
; Harrison, John C
; Cavitt, Jonathan
Subject: Re: [PATCH] drm/i915/gt/uc: Fix typo in comment
>
> I guess sparse and potential CI errors won't minimally relat
-Original Message-
From: Janusz Krzysztofik
Sent: Wednesday, May 29, 2024 4:37 AM
To: intel-gfx@lists.freedesktop.org
Cc: dri-de...@lists.freedesktop.org; Jani Nikula ;
Joonas Lahtinen ; Vivi, Rodrigo
; Tvrtko Ursulin ; Andi Shyti
; Cavitt, Jonathan ;
Janusz Krzysztofik
Subject
-Original Message-
From: Das, Nirmoy
Sent: Thursday, May 16, 2024 8:14 AM
To: intel-gfx@lists.freedesktop.org
Cc: dri-de...@lists.freedesktop.org; Das, Nirmoy ; Andi
Shyti ; Janusz Krzysztofik
; Cavitt, Jonathan
Subject: [PATCH] drm/i915/selftests: Set always_coherent to false when
-Original Message-
From: Jani Nikula
Sent: Monday, April 22, 2024 1:29 AM
To: Cavitt, Jonathan ;
intel-gfx@lists.freedesktop.org
Cc: Gupta, saurabhg ; Cavitt, Jonathan
; Harrison, John C ;
chris.p.wil...@linux.intel.com; andi.sh...@linux.intel.com; Das, Nirmoy
Subject: Re: [PATCH
-Original Message-
From: Vivekanandan, Balasubramani
Sent: Sunday, April 21, 2024 11:29 PM
To: Cavitt, Jonathan ;
intel-gfx@lists.freedesktop.org
Cc: Gupta, saurabhg ; Harrison, John C
; chris.p.wil...@linux.intel.com;
andi.sh...@linux.intel.com; Das, Nirmoy
Subject: Re: [PATCH] drm
-Original Message-
From: Janusz Krzysztofik
Sent: Monday, March 18, 2024 3:13 AM
To: igt-...@lists.freedesktop.org
Cc: intel-gfx@lists.freedesktop.org; intel...@lists.freedesktop.org; Kamil
Konieczny ; Mauro Carvalho Chehab
; Cavitt, Jonathan ; De Marchi,
Lucas
Subject: [PATCH i-g-t
-Original Message-
From: Das, Nirmoy
Sent: Tuesday, March 12, 2024 4:18 AM
To: intel-gfx@lists.freedesktop.org
Cc: dri-de...@lists.freedesktop.org; Das, Nirmoy ; Andi
Shyti ; Janusz Krzysztofik
; Cavitt, Jonathan
Subject: [PATCH] drm/i915/selftests: Pick correct caching mode
All patches LGTM
Acked-by: Jonathan Cavitt
-Jonathan Cavitt
-Original Message-
From: Intel-gfx On Behalf Of Janusz
Krzysztofik
Sent: Tuesday, February 27, 2024 7:11 AM
To: igt-...@lists.freedesktop.org
Cc: intel-gfx@lists.freedesktop.org; intel...@lists.freedesktop.org; Kamil
-Original Message-
From: Andi Shyti
Sent: Monday, December 18, 2023 8:06 AM
To: Cavitt, Jonathan
Cc: intel-gfx@lists.freedesktop.org; Gupta, saurabhg
; chris.p.wil...@linux.intel.com
Subject: Re: [Intel-gfx] [PATCH] drm/i915/gem: Atomically invalidate userptr on
mmu-notifier
>
&
-Original Message-
From: Sripada, Radhakrishna
Sent: Friday, November 3, 2023 1:02 PM
To: Cavitt, Jonathan ;
intel-gfx@lists.freedesktop.org
Cc: Gupta, saurabhg ; Cavitt, Jonathan
; chris.p.wil...@linux.intel.com
Subject: RE: [Intel-gfx] [PATCH] drm/i915/gt: Temporarily disable CPU
-Original Message-
From: Sripada, Radhakrishna
Sent: Friday, October 20, 2023 2:32 PM
To: Roper, Matthew D ;
intel-gfx@lists.freedesktop.org
Cc: Cavitt, Jonathan
Subject: RE: [PATCH v2] drm/i915/mcr: Hold GT forcewake during steering
operations
> > -Original Message-
&g
-Original Message-
From: Hajda, Andrzej
Sent: Friday, October 20, 2023 5:09 AM
To: intel-gfx@lists.freedesktop.org
Cc: Nirmoy Das ; Shyti, Andi
; Cavitt, Jonathan ; Das,
Nirmoy ; Hajda, Andrzej
Subject: [PATCH v2 3/4] drm/i915: Add WABB blit for Wa_16018031267 /
Wa_16018063123
-Original Message-
From: Hajda, Andrzej
Sent: Friday, October 20, 2023 5:09 AM
To: intel-gfx@lists.freedesktop.org
Cc: Nirmoy Das ; Shyti, Andi
; Cavitt, Jonathan ; Das,
Nirmoy
Subject: [PATCH v2 4/4] drm/i915: Set copy engine arbitration for
Wa_16018031267 / Wa_16018063123
>
>
-Original Message-
From: Hajda, Andrzej
Sent: Friday, October 20, 2023 5:09 AM
To: intel-gfx@lists.freedesktop.org
Cc: Nirmoy Das ; Shyti, Andi
; Cavitt, Jonathan ; Chris
Wilson ; Hajda, Andrzej
Subject: [PATCH v2 1/4] drm/i915: Enable NULL PTE support for vm scratch
>
>
1 - 100 of 129 matches
Mail list logo