RE: [PATCH] drm/i915/selftest_hangcheck: Fix potential UAF after HW fence revoke

2024-05-29 Thread Cavitt, Jonathan
-Original Message- From: Janusz Krzysztofik Sent: Wednesday, May 29, 2024 4:37 AM To: intel-gfx@lists.freedesktop.org Cc: dri-de...@lists.freedesktop.org; Jani Nikula ; Joonas Lahtinen ; Vivi, Rodrigo ; Tvrtko Ursulin ; Andi Shyti ; Cavitt, Jonathan ; Janusz Krzysztofik Subject

RE: [PATCH] drm/i915/selftests: Set always_coherent to false when reading from CPU

2024-05-16 Thread Cavitt, Jonathan
-Original Message- From: Das, Nirmoy Sent: Thursday, May 16, 2024 8:14 AM To: intel-gfx@lists.freedesktop.org Cc: dri-de...@lists.freedesktop.org; Das, Nirmoy ; Andi Shyti ; Janusz Krzysztofik ; Cavitt, Jonathan Subject: [PATCH] drm/i915/selftests: Set always_coherent to false when

RE: [PATCH] drm/i915/gem: Downgrade stolen lmem setup warning

2024-04-25 Thread Cavitt, Jonathan
-Original Message- From: Jani Nikula Sent: Monday, April 22, 2024 1:29 AM To: Cavitt, Jonathan ; intel-gfx@lists.freedesktop.org Cc: Gupta, saurabhg ; Cavitt, Jonathan ; Harrison, John C ; chris.p.wil...@linux.intel.com; andi.sh...@linux.intel.com; Das, Nirmoy Subject: Re: [PATCH

RE: [PATCH] drm/i915/gem: Downgrade stolen lmem setup warning

2024-04-25 Thread Cavitt, Jonathan
-Original Message- From: Vivekanandan, Balasubramani Sent: Sunday, April 21, 2024 11:29 PM To: Cavitt, Jonathan ; intel-gfx@lists.freedesktop.org Cc: Gupta, saurabhg ; Harrison, John C ; chris.p.wil...@linux.intel.com; andi.sh...@linux.intel.com; Das, Nirmoy Subject: Re: [PATCH] drm

RE: [PATCH i-g-t v3 0/5] lib/kunit: Execute test cases synchronously

2024-03-19 Thread Cavitt, Jonathan
-Original Message- From: Janusz Krzysztofik Sent: Monday, March 18, 2024 3:13 AM To: igt-...@lists.freedesktop.org Cc: intel-gfx@lists.freedesktop.org; intel...@lists.freedesktop.org; Kamil Konieczny ; Mauro Carvalho Chehab ; Cavitt, Jonathan ; De Marchi, Lucas Subject: [PATCH i-g-t

RE: [PATCH] drm/i915/selftests: Pick correct caching mode.

2024-03-12 Thread Cavitt, Jonathan
-Original Message- From: Das, Nirmoy Sent: Tuesday, March 12, 2024 4:18 AM To: intel-gfx@lists.freedesktop.org Cc: dri-de...@lists.freedesktop.org; Das, Nirmoy ; Andi Shyti ; Janusz Krzysztofik ; Cavitt, Jonathan Subject: [PATCH] drm/i915/selftests: Pick correct caching mode

RE: [PATCH i-g-t v2 0/2] lib/kunit: Execute test cases synchronously

2024-03-07 Thread Cavitt, Jonathan
All patches LGTM Acked-by: Jonathan Cavitt -Jonathan Cavitt -Original Message- From: Intel-gfx On Behalf Of Janusz Krzysztofik Sent: Tuesday, February 27, 2024 7:11 AM To: igt-...@lists.freedesktop.org Cc: intel-gfx@lists.freedesktop.org; intel...@lists.freedesktop.org; Kamil

RE: [Intel-gfx] [PATCH] drm/i915/gem: Atomically invalidate userptr on mmu-notifier

2023-12-18 Thread Cavitt, Jonathan
-Original Message- From: Andi Shyti Sent: Monday, December 18, 2023 8:06 AM To: Cavitt, Jonathan Cc: intel-gfx@lists.freedesktop.org; Gupta, saurabhg ; chris.p.wil...@linux.intel.com Subject: Re: [Intel-gfx] [PATCH] drm/i915/gem: Atomically invalidate userptr on mmu-notifier > &

Re: [Intel-gfx] [PATCH] drm/i915/gt: Temporarily disable CPU caching into DMA for MTL

2023-11-03 Thread Cavitt, Jonathan
-Original Message- From: Sripada, Radhakrishna Sent: Friday, November 3, 2023 1:02 PM To: Cavitt, Jonathan ; intel-gfx@lists.freedesktop.org Cc: Gupta, saurabhg ; Cavitt, Jonathan ; chris.p.wil...@linux.intel.com Subject: RE: [Intel-gfx] [PATCH] drm/i915/gt: Temporarily disable CPU

Re: [Intel-gfx] [PATCH v2] drm/i915/mcr: Hold GT forcewake during steering operations

2023-10-20 Thread Cavitt, Jonathan
-Original Message- From: Sripada, Radhakrishna Sent: Friday, October 20, 2023 2:32 PM To: Roper, Matthew D ; intel-gfx@lists.freedesktop.org Cc: Cavitt, Jonathan Subject: RE: [PATCH v2] drm/i915/mcr: Hold GT forcewake during steering operations > > -Original Message- &g

Re: [Intel-gfx] [PATCH v2 3/4] drm/i915: Add WABB blit for Wa_16018031267 / Wa_16018063123

2023-10-20 Thread Cavitt, Jonathan
-Original Message- From: Hajda, Andrzej Sent: Friday, October 20, 2023 5:09 AM To: intel-gfx@lists.freedesktop.org Cc: Nirmoy Das ; Shyti, Andi ; Cavitt, Jonathan ; Das, Nirmoy ; Hajda, Andrzej Subject: [PATCH v2 3/4] drm/i915: Add WABB blit for Wa_16018031267 / Wa_16018063123

Re: [Intel-gfx] [PATCH v2 4/4] drm/i915: Set copy engine arbitration for Wa_16018031267 / Wa_16018063123

2023-10-20 Thread Cavitt, Jonathan
-Original Message- From: Hajda, Andrzej Sent: Friday, October 20, 2023 5:09 AM To: intel-gfx@lists.freedesktop.org Cc: Nirmoy Das ; Shyti, Andi ; Cavitt, Jonathan ; Das, Nirmoy Subject: [PATCH v2 4/4] drm/i915: Set copy engine arbitration for Wa_16018031267 / Wa_16018063123 > >

Re: [Intel-gfx] [PATCH v2 1/4] drm/i915: Enable NULL PTE support for vm scratch

2023-10-20 Thread Cavitt, Jonathan
-Original Message- From: Hajda, Andrzej Sent: Friday, October 20, 2023 5:09 AM To: intel-gfx@lists.freedesktop.org Cc: Nirmoy Das ; Shyti, Andi ; Cavitt, Jonathan ; Chris Wilson ; Hajda, Andrzej Subject: [PATCH v2 1/4] drm/i915: Enable NULL PTE support for vm scratch > >

Re: [Intel-gfx] [PATCH v2 2/4] drm/i915: Reserve some kernel space per vm

2023-10-20 Thread Cavitt, Jonathan
-Original Message- From: Hajda, Andrzej Sent: Friday, October 20, 2023 5:09 AM To: intel-gfx@lists.freedesktop.org Cc: Nirmoy Das ; Shyti, Andi ; Cavitt, Jonathan ; Hajda, Andrzej ; Chris Wilson Subject: [PATCH v2 2/4] drm/i915: Reserve some kernel space per vm > > Reserve two

Re: [Intel-gfx] [PATCH v16 0/7] drm/i915: Define and use GuC and CTB TLB invalidation routines

2023-10-16 Thread Cavitt, Jonathan
-Original Message- From: Cavitt, Jonathan Sent: Monday, October 16, 2023 7:51 AM To: intel-gfx@lists.freedesktop.org Cc: Gupta, saurabhg ; Cavitt, Jonathan ; chris.p.wil...@linux.intel.com; Iddamsetty, Aravind ; Yang, Fei ; Shyti, Andi ; Harrison, John C ; Das, Nirmoy ; Krzysztofik

Re: [Intel-gfx] [PATCH v13 3/7] drm/i915: Define and use GuC and CTB TLB invalidation routines

2023-10-13 Thread Cavitt, Jonathan
-Original Message- From: Harrison, John C Sent: Thursday, October 12, 2023 6:11 PM To: Cavitt, Jonathan ; intel-gfx@lists.freedesktop.org Cc: Gupta, saurabhg ; chris.p.wil...@linux.intel.com; Iddamsetty, Aravind ; Yang, Fei ; Shyti, Andi ; Das, Nirmoy ; Krzysztofik, Janusz ; Roper

Re: [Intel-gfx] [PATCH v13 4/7] drm/i915: No TLB invalidation on suspended GT

2023-10-13 Thread Cavitt, Jonathan
-Original Message- From: Harrison, John C Sent: Thursday, October 12, 2023 6:08 PM To: Cavitt, Jonathan ; intel-gfx@lists.freedesktop.org Cc: Gupta, saurabhg ; chris.p.wil...@linux.intel.com; Iddamsetty, Aravind ; Yang, Fei ; Shyti, Andi ; Das, Nirmoy ; Krzysztofik, Janusz ; Roper

Re: [Intel-gfx] [PATCH v12 3/7] drm/i915: Define and use GuC and CTB TLB invalidation routines

2023-10-11 Thread Cavitt, Jonathan
-Original Message- From: Cavitt, Jonathan Sent: Wednesday, October 11, 2023 1:53 PM To: intel-gfx@lists.freedesktop.org Cc: Gupta, saurabhg ; Cavitt, Jonathan ; chris.p.wil...@linux.intel.com; Iddamsetty, Aravind ; Yang, Fei ; Shyti, Andi ; Harrison, John C ; Das, Nirmoy

Re: [Intel-gfx] [PATCH v10 3/7] drm/i915: Define and use GuC and CTB TLB invalidation routines

2023-10-10 Thread Cavitt, Jonathan
-Original Message- From: Harrison, John C Sent: Tuesday, October 10, 2023 2:51 PM To: Cavitt, Jonathan ; intel-gfx@lists.freedesktop.org Cc: Gupta, saurabhg ; chris.p.wil...@linux.intel.com; Iddamsetty, Aravind ; Yang, Fei ; Shyti, Andi ; Das, Nirmoy ; Krzysztofik, Janusz ; Roper

Re: [Intel-gfx] [PATCH v10 4/7] drm/i915: No TLB invalidation on suspended GT

2023-10-10 Thread Cavitt, Jonathan
-Original Message- From: Harrison, John C Sent: Tuesday, October 10, 2023 2:57 PM To: Cavitt, Jonathan ; intel-gfx@lists.freedesktop.org Cc: Gupta, saurabhg ; chris.p.wil...@linux.intel.com; Iddamsetty, Aravind ; Yang, Fei ; Shyti, Andi ; Das, Nirmoy ; Krzysztofik, Janusz ; Roper

Re: [Intel-gfx] [PATCH dii-client 2/2] drm/i915: Use selective tlb invalidations where supported

2023-10-10 Thread Cavitt, Jonathan
, Jonathan Sent: Tuesday, October 10, 2023 11:44 AM To: intel-gfx@lists.freedesktop.org Cc: Gupta, saurabhg ; Cavitt, Jonathan ; Das, Nirmoy ; Shyti, Andi ; tvrtko.ursu...@linux.intel.com; Harrison, John C Subject: [PATCH dii-client 2/2] drm/i915: Use selective tlb invalidations where supported

Re: [Intel-gfx] [PATCH dii-client v10 1/7] drm/i915: Add GuC TLB Invalidation device info flags

2023-10-10 Thread Cavitt, Jonathan
-Original Message- From: Cavitt, Jonathan Sent: Tuesday, October 10, 2023 8:01 AM To: intel-gfx@lists.freedesktop.org Cc: Gupta, saurabhg ; Cavitt, Jonathan ; chris.p.wil...@linux.intel.com; Iddamsetty, Aravind ; Yang, Fei ; Shyti, Andi ; Harrison, John C ; Das, Nirmoy ; Krzysztofik

Re: [Intel-gfx] [PATCH v9 6/7] drm/i915/gt: Increase sleep in gt_tlb selftest sanitycheck

2023-10-10 Thread Cavitt, Jonathan
-Original Message- From: Andi Shyti Sent: Tuesday, October 10, 2023 6:04 AM To: Tvrtko Ursulin Cc: Cavitt, Jonathan ; intel-gfx@lists.freedesktop.org; Gupta, saurabhg ; yu.bruce.ch...@intel.com; chris.p.wil...@linux.intel.com; Iddamsetty, Aravind ; Yang, Fei ; Harrison, John C ; Das

Re: [Intel-gfx] [PATCH v8 3/7] drm/i915: Define and use GuC and CTB TLB invalidation routines

2023-10-09 Thread Cavitt, Jonathan
-Original Message- From: Tvrtko Ursulin Sent: Monday, October 9, 2023 1:57 AM To: Cavitt, Jonathan ; intel-gfx@lists.freedesktop.org Cc: Dutt, Sudeep ; Chang, Yu bruce ; chris.p.wil...@linux.intel.com; Iddamsetty, Aravind ; Yang, Fei ; Shyti, Andi ; Harrison, John C ; Das, Nirmoy

Re: [Intel-gfx] [PATCH v7 2/5] drm/i915: Define and use GuC and CTB TLB invalidation routines

2023-10-06 Thread Cavitt, Jonathan
As far as I can tell, most if not all of the below comments have now been addressed in version 8. Please check to verify this is correct. -Jonathan Cavitt -Original Message- From: Tvrtko Ursulin Sent: Friday, October 6, 2023 6:05 AM To: Cavitt, Jonathan ; intel-gfx

Re: [Intel-gfx] [PATCH v5 2/4] drm/i915: Define and use GuC and CTB TLB invalidation routines

2023-10-05 Thread Cavitt, Jonathan
-Original Message- From: Tvrtko Ursulin Sent: Thursday, October 5, 2023 1:55 AM To: Cavitt, Jonathan ; intel-gfx@lists.freedesktop.org Cc: Dutt, Sudeep ; Chang, Yu bruce ; chris.p.wil...@linux.intel.com; Iddamsetty, Aravind ; Yang, Fei ; Shyti, Andi ; Harrison, John C ; Das, Nirmoy

Re: [Intel-gfx] [PATCH v2 1/2] drm/i915: Add WABB blit for Wa_16018031267 / Wa_16018063123

2023-08-24 Thread Cavitt, Jonathan
-Original Message- From: Andi Shyti Sent: Thursday, August 24, 2023 7:54 AM To: Cavitt, Jonathan Cc: intel-gfx@lists.freedesktop.org; Mistat, Tomasz ; Vivi, Rodrigo ; Germano, Gregory F ; Roper, Matthew D ; Das, Nirmoy Subject: Re: [Intel-gfx] [PATCH v2 1/2] drm/i915: Add WABB blit

Re: [Intel-gfx] [CI] drm/i915/gt: Refactor hangcheck selftest to use igt_spinner

2023-08-21 Thread Cavitt, Jonathan
-Original Message- From: Andi Shyti Sent: Saturday, August 19, 2023 3:50 PM To: Cavitt, Jonathan Cc: intel-gfx Subject: [CI] drm/i915/gt: Refactor hangcheck selftest to use igt_spinner > > From: Jonathan Cavitt > > The hangcheck live selftest contains duplicate declarat

Re: [Intel-gfx] [PATCH 1/2] drm/i915/selftests: Align igt_spinner_create_request with hangcheck

2023-08-16 Thread Cavitt, Jonathan
-Original Message- From: Roper, Matthew D Sent: Tuesday, August 15, 2023 12:29 PM To: Cavitt, Jonathan Cc: intel-gfx@lists.freedesktop.org; Dutt, Sudeep ; chris.p.wil...@linux.intel.com; Gupta, saurabhg ; Shyti, Andi ; Summers, Stuart ; Das, Nirmoy ; Belgaumkar, Vinay ; Winiarski

Re: [Intel-gfx] [PATCH dii-client 1/2] drm/i915: Make i915_coherent_map_type GT-centric

2023-07-25 Thread Cavitt, Jonathan
-Original Message- From: Tvrtko Ursulin Sent: Tuesday, July 25, 2023 9:23 AM To: Cavitt, Jonathan ; intel-gfx@lists.freedesktop.org Cc: Shyti, Andi ; Roper, Matthew D ; chris.p.wil...@linux.intel.com; Das, Nirmoy Subject: Re: [Intel-gfx] [PATCH dii-client 1/2] drm/i915: Make

Re: [Intel-gfx] [PATCH v2 2/4] drm/i915/gt: Ensure memory quiesced before invalidation

2023-07-13 Thread Cavitt, Jonathan
-Original Message- From: Nirmoy Das Sent: Thursday, July 13, 2023 7:12 AM To: Andi Shyti Cc: Cavitt, Jonathan ; Intel GFX ; Roper, Matthew D ; Chris Wilson ; Mika Kuoppala Subject: Re: [Intel-gfx] [PATCH v2 2/4] drm/i915/gt: Ensure memory quiesced before invalidation > >H

Re: [Intel-gfx] [PATCH v2 2/4] drm/i915/gt: Ensure memory quiesced before invalidation

2023-07-12 Thread Cavitt, Jonathan
-Original Message- From: Nirmoy Das Sent: Wednesday, July 12, 2023 7:18 AM To: Andi Shyti ; Cavitt, Jonathan Cc: Intel GFX ; Roper, Matthew D ; Chris Wilson ; Mika Kuoppala Subject: Re: [Intel-gfx] [PATCH v2 2/4] drm/i915/gt: Ensure memory quiesced before invalidation > >H

Re: [Intel-gfx] [PATCH v7 0/2] drm/i915: Hugepage manager and test for MTL

2023-04-26 Thread Cavitt, Jonathan
-Original Message- From: Hajda, Andrzej Sent: Wednesday, April 26, 2023 2:37 PM To: Cavitt, Jonathan ; intel-gfx@lists.freedesktop.org; linux-ker...@vger.kernel.org; Auld, Matthew Subject: Re: [PATCH v7 0/2] drm/i915: Hugepage manager and test for MTL > >On 26.04.2023 17:31,

Re: [Intel-gfx] [PATCH v7 0/2] drm/i915: Hugepage manager and test for MTL

2023-04-26 Thread Cavitt, Jonathan
-Original Message- From: Hajda, Andrzej Sent: Wednesday, April 26, 2023 8:14 AM To: intel-gfx@lists.freedesktop.org; linux-ker...@vger.kernel.org; Cavitt, Jonathan ; Hajda, Andrzej ; Auld, Matthew Subject: [PATCH v7 0/2] drm/i915: Hugepage manager and test for MTL > >This pa

Re: [Intel-gfx] [PATCH v5 1/2] drm/i915: Migrate platform-dependent mock hugepage selftests to live

2023-03-13 Thread Cavitt, Jonathan
-Original Message- From: Auld, Matthew Sent: Thursday, March 2, 2023 2:36 AM To: Cavitt, Jonathan ; intel-gfx@lists.freedesktop.org Cc: Dutt, Sudeep ; thomas.hellst...@linux.intel.com; maarten.lankho...@linux.intel.com; Vetter, Daniel ; De Marchi, Lucas ; chris.p.wil

Re: [Intel-gfx] [PATCH v5 1/2] drm/i915: Migrate platform-dependent mock hugepage selftests to live

2023-03-02 Thread Cavitt, Jonathan
-Original Message- From: Auld, Matthew Sent: Thursday, March 2, 2023 2:36 AM To: Cavitt, Jonathan ; intel-gfx@lists.freedesktop.org Cc: Dutt, Sudeep ; thomas.hellst...@linux.intel.com; maarten.lankho...@linux.intel.com; Vetter, Daniel ; De Marchi, Lucas ; chris.p.wil

Re: [Intel-gfx] [PATCH] drm/i915: Use correct huge page manager for MTL

2023-02-27 Thread Cavitt, Jonathan
-Original Message- From: Auld, Matthew Sent: Monday, February 27, 2023 3:20 AM To: Cavitt, Jonathan ; intel-gfx@lists.freedesktop.org Cc: Dutt, Sudeep ; thomas.hellst...@linux.intel.com; maarten.lankho...@linux.intel.com; Vetter, Daniel ; De Marchi, Lucas ; chris.p.wil

Re: [Intel-gfx] [PATCH] drm/i915: Use correct huge page manager for MTL

2023-02-24 Thread Cavitt, Jonathan
-Original Message- From: Auld, Matthew Sent: Friday, February 24, 2023 7:51 AM To: Cavitt, Jonathan ; intel-gfx@lists.freedesktop.org Cc: Dutt, Sudeep ; thomas.hellst...@linux.intel.com; maarten.lankho...@linux.intel.com; Vetter, Daniel ; De Marchi, Lucas ; chris.p.wil

Re: [Intel-gfx] [PATCH] gen8_ppgtt: Use correct huge page manager for MTL

2023-02-21 Thread Cavitt, Jonathan
-Original Message- From: Auld, Matthew Sent: Tuesday, February 21, 2023 9:46 AM To: Cavitt, Jonathan Cc: Dutt, Sudeep ; Siddiqui, Ayaz A ; intel-gfx@lists.freedesktop.org Subject: Re: [PATCH] gen8_ppgtt: Use correct huge page manager for MTL > > On 21/02/2023 17:14, Cavitt, Jo

Re: [Intel-gfx] [PATCH] gen8_ppgtt: Use correct huge page manager for MTL

2023-02-21 Thread Cavitt, Jonathan
-Original Message- From: Auld, Matthew Sent: Tuesday, February 21, 2023 8:33 AM To: Cavitt, Jonathan Cc: Dutt, Sudeep ; Siddiqui, Ayaz A ; intel-gfx@lists.freedesktop.org Subject: Re: [PATCH] gen8_ppgtt: Use correct huge page manager for MTL > > On 21/02/2023 16:28, Cavitt, Jo

Re: [Intel-gfx] [PATCH] gen8_ppgtt: Use correct huge page manager for MTL

2023-02-21 Thread Cavitt, Jonathan
-Original Message- From: Auld, Matthew Sent: Tuesday, February 21, 2023 8:06 AM To: Cavitt, Jonathan ; intel-gfx@lists.freedesktop.org Cc: Dutt, Sudeep ; Siddiqui, Ayaz A Subject: Re: [PATCH] gen8_ppgtt: Use correct huge page manager for MTL > > On 17/02/2023 19:18, Jonathan

Re: [Intel-gfx] [PATCH] drm/i915: Use uabi engines for the default engine map

2023-01-23 Thread Cavitt, Jonathan
-Original Message- From: Cavitt, Jonathan Sent: Monday, January 23, 2023 7:25 AM To: intel-gfx@lists.freedesktop.org Cc: Cavitt, Jonathan ; Dutt, Sudeep Subject: [PATCH] drm/i915: Use uabi engines for the default engine map > > From: Tvrtko Ursulin > > Default engine ma