Re: [Intel-gfx] [PATCH i-g-t] tests: Fix compilation when some gcc configurations

On Thu, Jul 14, 2016 at 06:48:26PM +0100, Chris Wilson wrote: > On Thu, Jul 14, 2016 at 06:44:59PM +0100, Chris Wilson wrote: > > On Thu, Jul 14, 2016 at 06:31:37PM +0100, Damien Lespiau wrote: > > > Depending how the gcc was compiled it may be necessary to enable SSE4

[Intel-gfx] [PATCH i-g-t] tests: Fix compilation when some gcc configurations

; # error "SSE4.1 instruction set not enabled" ^ v2: Use a pragma directive (Chris) Cc: Chris Wilson <ch...@chris-wilson.co.uk> Signed-off-by: Damien Lespiau <damien.lesp...@intel.com> --- tests/gem_exec_flush.c | 1 + tests/gem_gtt_speed.c | 1 + 2 files changed, 2 i

[Intel-gfx] [PATCH i-g-t] tests: Fix compilation when some gcc configurations

ilson.co.uk> Signed-off-by: Damien Lespiau <damien.lesp...@intel.com> --- tests/Makefile.am | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/Makefile.am b/tests/Makefile.am index 102b8a6..8c6b0a3 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -76,6 +76,7 @@ ge

[Intel-gfx] [PATCH] drm/i915: Eliminate dead code in intel_sanitize_enable_ppgtt()

We exit early if has_aliasing_ppgtt is 0, so towards the end of the function has_aliasing_ppgtt can only be 1. Also: if (foo) return 1; else return 0; when foo is already a bool is really just: return foo; Signed-off-by: Damien Lespiau

Re: [Intel-gfx] [PATCH i-g-t] assembler/: Fix lex warnings for %empty and %nonassoc.

On Thu, May 19, 2016 at 07:02:40AM -0700, Ben Widawsky wrote: > On Thu, May 19, 2016 at 12:28:10PM +0100, Damien Lespiau wrote: > > On Mon, May 16, 2016 at 01:39:10PM +0300, Marius Vlad wrote: > > > Signed-off-by: Marius Vlad <marius.c.v...@intel.com> > > >

Re: [Intel-gfx] [PATCH i-g-t] assembler/: Fix lex warnings for %empty and %nonassoc.

ay to test the change is to regenerate the vaapi shaders from source and check for differences in the generated opcodes. https://cgit.freedesktop.org/vaapi/intel-driver/ If all the shaders do compile and there's no difference in the generated code, this is: Acked-by: Damien Lespiau <damien.lesp..

Re: [Intel-gfx] [PATCH i-g-t] benchmarks/, overlay/, demos/, tools/, tests/: Add optional Werror.

On Tue, May 10, 2016 at 05:32:15PM +0300, Marius Vlad wrote: > v2: Initially added Werror by default. Make it optional so it doesn't > break android build and (potential) distros maintaing the package > (Hinted by Damien Lespiau). > > --enable-werror will enable -Werror compiler fl

Re: [Intel-gfx] [PATCH i-g-t] benchmarks/, overlay/, demos/, tools/, tests/: Add Werror by default.

On Mon, May 09, 2016 at 06:55:12PM +0300, Marius Vlad wrote: > > Adding a test (with patchwork integration!) that ensures each commit > > posted on this mailing-list compiles without new warning with a chosen > > toolchain (and even passes distcheck!) would be nice. > We have this for check and

Re: [Intel-gfx] [PATCH i-g-t] benchmarks/, overlay/, demos/, tools/, tests/: Add Werror by default.

On Mon, May 09, 2016 at 04:23:44PM +0300, Marius Vlad wrote: > Easier to catch compilation errors. Having -Werror by default is a no go as you cannot control/predict the set of warnings (and the quality of those) of all previous and future gcc/clang versions. Always using this flag will cause

Re: [Intel-gfx] [PATCH RESEND FOR CI] drm/i915: Fix races on fbdev

Hi Lukas, I'm sorry I haven't reacted sooner. I've enabled the option to only consider git send-email patches on intel-gfx as we were having a lot of false positives (ie patchwork considering emails were people were making suggestions with diffs as patches to test). I'm not sure how you send

Re: [Intel-gfx] [Mesa-dev] [PATCH v2 i-g-t] igt/list-workarounds: Extend the script to Mesa

On Fri, Feb 05, 2016 at 04:12:08PM -0800, Dylan Baker wrote: > > > parse(work_arounds) > > > + print "\nList of workarounds found in %s:" % project > > Hey Damien, the script says it's python 3, and this ^^^ is broken syntax > in python 3 (but not in 2). :( I did notice the python2

[Intel-gfx] [PATCH i-g-t] list-workarounds: Fix python 2 print statement

m> Signed-off-by: Damien Lespiau <damien.lesp...@intel.com> --- scripts/list-workarounds | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/list-workarounds b/scripts/list-workarounds index 8b41ae5..70c026d 100755 --- a/scripts/list-workarounds +++ b/script

Re: [Intel-gfx] [PATCH] list-workarounds: Extend the script to Mesa

On Thu, Feb 04, 2016 at 06:14:02PM +, Kibey, Sameer wrote: > Updated the list-workarounds script so that it > can parse Mesa directory if provided. Moved the > common code to a separate function to allow > reuse for both kernel and mesa. > > The new command line is: > Usage: list-workarounds

Re: [Intel-gfx] [PATCH v2 i-g-t] igt/list-workarounds: Extend the script to Mesa

On Fri, Feb 05, 2016 at 01:55:19PM -0800, Sameer Kibey wrote: > Updated the list-workarounds script so that it > can parse Mesa directory if provided. Moved the > common code to a separate function to allow > reuse for both kernel and mesa. > > The new command line is: > Usage: list-workarounds

[Intel-gfx] [PATCH xf86-video-intel] Sync PCI ids with latest kernel, adding more BXT devices

commit 985dd4360fdf2533fe48a33a4a2094f2e4718dc0 Author: Imre Deak <imre.d...@intel.com> Date: Thu Jan 28 16:04:12 2016 +0200 drm/i915/bxt: update list of PCIIDs Signed-off-by: Damien Lespiau <damien.lesp...@intel.com> --- src/i915_pciids.h | 4 +++- 1 file changed,

Re: [Intel-gfx] [PATCH v3] drm/i915/skl/kbl: Add support for pipe fusing

t; v2: Don't store the pipe disabled mask in device info (Damien) > > v3: Don't check FUSE_STRAP register for pipe c disabled > > Cc: Damien Lespiau <damien.lesp...@intel.com> > Signed-off-by: Patrik Jakobsson <patrik.jakobs...@linux.intel.com> Reviewed-by: Damien

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for MAINTAINERS: Add "B:" preferred bug reporting method (rev3)

On Wed, Jan 27, 2016 at 09:16:24AM -0800, Joe Perches wrote: > On Wed, 2016-01-27 at 16:47 +, Patchwork wrote: > > == Summary == > > > > Built on 5ae916607e3e12ba18c848dff42baaad5b118c4b drm-intel-nightly: > > 2016y-01m-27d-12h-48m-36s UTC integration manifest > > I've no idea what this

Re: [Intel-gfx] ✗ Fi.CI.BAT: warning for FBC crtc/fb locking + smaller fixes

On Thu, Jan 21, 2016 at 08:14:34PM +, Zanoni, Paulo R wrote: > Em Ter, 2016-01-19 às 14:50 +, Patchwork escreveu: > > == Summary == > > > > Built on 20c388faff9d8c41ab27e825c685526561b892a2 drm-intel-nightly: > > 2016y-01m-19d-13h-31m-46s UTC integration manifest > > > > Test kms_flip: >

[Intel-gfx] [PATCH libdrm] xf86drm: Bound strstr() to the allocated data

We are reading at most sizeof(data) bytes, but then data may not contain a terminating '\0', at least in theory, so strstr() may overflow the stack allocated array. Make sure that data always contains at least one '\0'. Signed-off-by: Damien Lespiau <damien.lesp...@intel.com> --- xf86drm

Re: [Intel-gfx] [PATCH libdrm] xf86drm: Bound strstr() to the allocated data

On Fri, Jan 22, 2016 at 04:48:05PM +0200, Ville Syrjälä wrote: > On Fri, Jan 22, 2016 at 12:51:23PM +0000, Damien Lespiau wrote: > > We are reading at most sizeof(data) bytes, but then data may not contain > > a terminating '\0', at least in theory, so strstr() may overflow the >

Re: [Intel-gfx] [PATCH i-g-t] tools/Android.mk: Add zlib support

On Fri, Jan 15, 2016 at 03:49:00PM +, Morton, Derek J wrote: > Can this be merged so IGT on Android builds? No one has raise any > objections since Monday about this patch. Merged, thanks for the patch. -- Damien ___ Intel-gfx mailing list

Re: [Intel-gfx] [PATCH 7/7] drm/i915/skl: WA for watermark calculation based on Arbitrated Display BW

On Thu, Jan 14, 2016 at 11:30:31PM +0800, kbuild test robot wrote: > Hi Mahesh, > > [auto build test ERROR on drm-intel/for-linux-next] > [also build test ERROR on next-20160114] > [cannot apply to v4.4] > [if your patch is applied to the wrong git tree, please drop us a note to > help improving

Re: [Intel-gfx] [PATCH v2] drm/i915: Handle PipeC fused off on GEN7+

On Wed, Jan 13, 2016 at 04:46:43PM +0200, Gabriel Feceoru wrote: > Starting with Gen7 (IVB) Display PipeC can be fused off on some production > parts. When disabled, display hardware will prevent the pipe C register bit > from being set to 1. > > Fixed by adjusting pipe_count to reflect this.

Re: [Intel-gfx] [PATCH] drm/i915: Demote user facing DMC firmware load failure message

ed to load DMC firmware > [https://01.org/linuxgraphics/intel-linux-graphics-firmwares], disabling > runtime power management. > > Signed-off-by: Chris Wilson <ch...@chris-wilson.co.uk> > Cc: Damien Lespiau <damien.lesp...@intel.com> > Cc: Imre Deak <imre.d...@i

[Intel-gfx] [PATCH xf86-video-intel] Sync PCI ids with latest kernel, adding SKL GT4

Syncs with: commit 15620206ae87ba9643ffa6f5ddb5471be7192006 Author: Mika Kuoppala <mika.kuopp...@linux.intel.com> Date: Fri Nov 6 14:11:16 2015 +0200 drm/i915/skl: Add SKL GT4 PCI IDs Signed-off-by: Damien Lespiau <damien.lesp...@intel.com> --- src/i915_p

Re: [Intel-gfx] [PATCH] drm/i915/kbl: Enable PW1 and Misc I/O power wells

On Wed, Jan 06, 2016 at 12:08:36PM +, Michel Thierry wrote: > My kbl stopped working because of this. > > Fixes regression from > commit 2f693e28b8df69f67beced5e18bb2b91c2bfcec2 > Author: Damien Lespiau <damien.lesp...@intel.com> > Date: Wed Nov 4 19:24:12 2015 +0

Re: [Intel-gfx] [PATCH] drm/i915: Restore skl_gt3 device info

On Fri, Dec 04, 2015 at 04:19:49PM +0100, Daniel Vetter wrote: > This was broken in > > commit 6a8beeffed3b2d33151150e3a03696e697f16d46 > Author: Wayne Boyer > Date: Wed Dec 2 13:28:14 2015 -0800 > > drm/i915: Clean up device info structure definitions > > and I

Re: [Intel-gfx] [PATCH] drm/i915/skl: Add SKL GT4 PCI IDs

On Fri, Dec 04, 2015 at 07:00:36PM +, Damien Lespiau wrote: > On Fri, Nov 06, 2015 at 02:11:16PM +0200, Mika Kuoppala wrote: > > From: Mika Kuoppala <mika.kuopp...@linux.intel.com> > > > > Add Skylake Intel Graphics GT4 PCI IDs > > > > v2: Rebas

Re: [Intel-gfx] [PATCH] drm/i915/skl: Add SKL GT4 PCI IDs

On Fri, Nov 06, 2015 at 02:11:16PM +0200, Mika Kuoppala wrote: > From: Mika Kuoppala <mika.kuopp...@linux.intel.com> > > Add Skylake Intel Graphics GT4 PCI IDs > > v2: Rebase > > Signed-off-by: Mika Kuoppala <mika.kuopp...@intel.com> > --- Reviewed-by: Dami

Re: [Intel-gfx] [PATCH 1/2] drm/i915: PSR: Let's rely more on frontbuffer tracking.

ting. That said, I think we need to extend the language we use for review and make patchwork understand it. For instance, being able to review several patches in one go could be done with: Patches 1-3,6: Reviewed-by: Damien Lespiau damien.lesp...@intel.com (See: https://github.com/dl

Re: [Intel-gfx] i-g-t/libdrm email tagging & patchwork

On Thu, Nov 19, 2015 at 12:44:07PM +0200, Jani Nikula wrote: > On Wed, 18 Nov 2015, Daniel Vetter <dan...@ffwll.ch> wrote: > > On Sun, Nov 08, 2015 at 12:31:36AM +, Damien Lespiau wrote: > >> Hi all, > >> > >> I've added a feature to sort the pat

Re: [Intel-gfx] [PATCH] lib: Add Skylake Intel Graphics GT4 PCI IDs

On Fri, Nov 06, 2015 at 04:42:10PM +0200, Mika Kuoppala wrote: > Add Skylake Intel Graphics GT4 PCI IDs. > > Signed-off-by: Mika Kuoppala <mika.kuopp...@intel.com> Reviewed-by: Damien Lespiau <damien.lesp...@intel.com> -- Damien > --- > lib/intel_chipset.h | 12 +++

Re: [Intel-gfx] i-g-t/libdrm email tagging & patchwork

On Mon, Nov 09, 2015 at 10:45:14AM +0200, Jani Nikula wrote: > On Sun, 08 Nov 2015, Damien Lespiau <damien.lesp...@intel.com> wrote: > > There are two new patchwork projects then: > > > > http://patchwork.freedesktop.org/project/intel-gpu-tools/ > > http://

Re: [Intel-gfx] i-g-t/libdrm email tagging & patchwork

On Mon, Nov 09, 2015 at 01:21:33PM +0200, Jani Nikula wrote: > On Mon, 09 Nov 2015, Damien Lespiau <damien.lesp...@intel.com> wrote: > > That would work for us, but not in the general case (for other > > projects). I was thinking of using some kind of other heuristic, eg.

[Intel-gfx] i-g-t/libdrm email tagging & patchwork

Hi all, I've added a feature to sort the patches sent to intel-gfx into 3 buckets: i915, intel-gpu-tools and libdrm. This sorting relies on tagging patches, using the subject prefixes (which is what most people do already anyway). - i915 (intel-gfx): catchall project, all mails not matching

Re: [Intel-gfx] HDMI 4k modes VIC

On Wed, Oct 28, 2015 at 01:58:55PM +, Sharma, Shashank wrote: >Hi Damien > >This is regarding one of the patches: >drm: Add support for alternate clocks of 4k modes >(3f2f653378112c1453c0d83c81746a9225e4bc75) > >I am seeing that from function drm_match_hdmi_mode we are

Re: [Intel-gfx] HDMI 4k modes VIC

On Wed, Oct 28, 2015 at 06:38:21PM +0200, Jani Nikula wrote: > > Are you seeing a bug? it's totally possible, I've never used an actual > > conformance tool when I wrote that code, so it's likely buggy and the > > VIC in the AVI infoframe may well be wrong. > > Possibly relevant >

Re: [Intel-gfx] [PATCH] drm/i915: Use dpcd read wake for sink crc calls.

On Thu, Oct 22, 2015 at 12:01:21AM +0530, Thulasimani, Sivakumar wrote: > > > On 8/25/2015 2:50 AM, Vivi, Rodrigo wrote: > >On Mon, 2015-08-24 at 19:54 +, Zanoni, Paulo R wrote: > >>Em Qui, 2015-08-20 às 16:23 -0700, Rodrigo Vivi escreveu: > >>>Let's use a native read with retry as suggested

Re: [Intel-gfx] [PATCH 1/5] drm/i915: Store and print dmc firmware version

On Fri, Sep 18, 2015 at 06:17:05PM +0300, Mika Kuoppala wrote: > Parse csr/dmc firmware version and augment debug message > by printing it. > > Cc: Animesh Manna > Signed-off-by: Mika Kuoppala FWIW I did something similar in the past, but that

Re: [Intel-gfx] [PATCH 1/5] drm/i915: Store and print dmc firmware version

On Thu, Oct 08, 2015 at 12:03:30PM +0100, Damien Lespiau wrote: > The DMC firmware version decoding was different in my patch and I'm sure > it worked then. Maye the header has changed :( By the way, if this is indeed the case, could you fix intel_firmware_decode as well?

[Intel-gfx] [Patchwork] The infrequent patchwork update #1

Hi all, You may have noticed already, patchwork.freedesktop.org looks different. That new version includes: - Some re-design. Design is very much an iterative process, thoughts and comments are welcome, - Showing the number of Reviewed-by, Acked-by, Tested-by tags, - Some cleanup of

Re: [Intel-gfx] [PATCH] drm/i915/skl: Don't clear all watermarks when updating. (v2)

ged. > > v2: Make sure all the dirty flags are cleared. Damien > Clear all values assoicated with crtc/pipe being updated. Damien > > Signed-off-by: Bob Paauwe <bob.j.paa...@intel.com> Reviewed-by: Damien Lespiau <damien.lesp...@intel.com> - Moving to a &qu

[Intel-gfx] [PATCH] drm/i915/bxt: Fix wrongly placed ')' in I915_READ()

e.d...@intel.com> Signed-off-by: Damien Lespiau <damien.lesp...@intel.com> --- drivers/gpu/drm/i915/intel_ddi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/intel_ddi.c b/drivers/gpu/drm/i915/intel_ddi.c index 4823184..5b600bf 100644 --- a/drivers/

Re: [Intel-gfx] [PATCH] drm/i915: make CSR firmware messages less verbose

roblem(s): http://lists.freedesktop.org/archives/intel-gfx/2015-June/070093.html and: https://bugs.freedesktop.org/show_bug.cgi?id=90461 But, WARN_ONCE() is not awful I guess: Acked-by: Damien Lespiau <damien.lesp...@intel.com> -- Damien > --- > drivers/gpu/drm/i915/intel_csr.c

Re: [Intel-gfx] [PATCH] drm/i915: set CDCLK if DPLL0 enabled during resuming from S3

rodrigo.v...@intel.com Reviewed-by: Damien Lespiau damien.lesp...@intel.com Reviewed-by: Cooper Chiou cooper.ch...@intel.com Reviewed-by: Wei Shun Chang wei.shun.ch...@intel.com Tested-by: Gary Wang gary.c.w...@intel.com Cc: Daniel Vetter daniel.vet...@ffwll.ch Cc: Gavin Hindman gavin.hind

Re: [Intel-gfx] [PATCH libdrm] intel: Serialize drmPrimeFDToHandle with struct_mutex

On Fri, Jul 24, 2015 at 11:51:01AM +0100, Chris Wilson wrote: On Fri, Jul 24, 2015 at 11:22:34AM +0200, Michał Winiarski wrote: From: Rafał Sapała rafal.a.sap...@intel.com It is possible to hit a race condition in create_from_prime, when trying to import a BO that's currently being

Re: [Intel-gfx] [PATCH v3] tests/gem_reg_read: Extend and check for valid 36b counter

On Tue, Jul 21, 2015 at 08:48:05AM +0200, Daniel Vetter wrote: On Thu, Jul 16, 2015 at 2:04 PM, Damien Lespiau damien.lesp...@intel.com wrote: On Thu, Jul 16, 2015 at 12:24:19PM +0100, Chris Wilson wrote: On Thu, Jul 16, 2015 at 01:19:09PM +0200, Michał Winiarski wrote: When reading

Re: [Intel-gfx] [PATCH] drm/i915: Update HAS_PSR macro to include all gen=8 platforms

On Tue, Jul 21, 2015 at 02:48:31PM +0530, Sonika Jindal wrote: This is to get PSR support for bxt. Signed-off-by: Sonika Jindal sonika.jin...@intel.com Maybe with a drm/i915/bxt prefix: Reviewed-by: Damien Lespiau damien.lesp...@intel.com -- Damien --- drivers/gpu/drm/i915/i915_drv.h

Re: [Intel-gfx] [PATCH] drm/i915: Fix divide by zero on watermark update

On Thu, Jul 16, 2015 at 05:44:17PM +0100, Damien Lespiau wrote: On Thu, Jul 16, 2015 at 07:36:51PM +0300, Mika Kuoppala wrote: Fix divide by zero if we end up updating the watermarks with zero dotclock. This is a stop gap measure to allow module load in cases where our state keeping

Re: [Intel-gfx] [PATCH] drm/i915: Don't clear all watermarks when updating.

On Wed, Jul 08, 2015 at 09:05:53AM -0700, Bob Paauwe wrote: Clearing the watermarks for all pipes/planes when updating the watermarks for a single CRTC change seems like the wrong thing to do here. As is, this code will update any pipe/plane watermarks that need updating and leave the

Re: [Intel-gfx] [PATCH v3] tests/gem_reg_read: Extend and check for valid 36b counter

On Thu, Jul 16, 2015 at 12:24:19PM +0100, Chris Wilson wrote: On Thu, Jul 16, 2015 at 01:19:09PM +0200, Michał Winiarski wrote: When reading the timestamp register with single 64b read, we are observing invalid values on x86_64: [f = valid counter value | X = garbage] i386:

Re: [Intel-gfx] [PATCH] drm/i915: Don't clear all watermarks when updating.

On Wed, Jul 08, 2015 at 09:05:53AM -0700, Bob Paauwe wrote: Clearing the watermarks for all pipes/planes when updating the watermarks for a single CRTC change seems like the wrong thing to do here. As is, this code will update any pipe/plane watermarks that need updating and leave the

Re: [Intel-gfx] [PATCH] drm/i915: Fix divide by zero on watermark update

...@gmail.com Cc: Damien Lespiau damien.lesp...@intel.com Signed-off-by: Mika Kuoppala mika.kuopp...@intel.com I want to say a loading module is more important than a proper fix, so: Reviewed-by: Damien Lespiau damien.lesp...@intel.com -- Damien --- drivers/gpu/drm/i915/intel_pm.c | 4 +++- 1 file

[Intel-gfx] [PATCH 1/2] drm/i915/skl: Don't expose the top most plane on gen9 display

flag. Unfortunately noone has had the time to finish this yet, but lifting the prelimary_hw_support flag is long overdue. As an intermediate solution we can merely not expose the top most plane Cc: Imre Deak imre.d...@intel.com Signed-off-by: Damien Lespiau damien.lesp...@intel.com --- drivers/gpu

[Intel-gfx] [PATCH 2/2] drm/i915/skl: Drop the preliminary_hw_support flag

Time to light a candle and remove the preliminary_hw_support flag. Signed-off-by: Damien Lespiau damien.lesp...@intel.com --- drivers/gpu/drm/i915/i915_drv.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c index e44dc0d

Re: [Intel-gfx] [PATCHv9] drm/i915: Added Programming of the MOCS

values. By trying to keep the registers consistent across the different engines it should make the programming for the registers consistent. v2: -'static const' for private data structures and style changes.(Matt Turner) v3: - Make the tables slightly more readable. (Damien Lespiau

Re: [Intel-gfx] [PATCH v2] drm/i915: Don't forget to mark crtc as inactive after disable

On Mon, Jul 13, 2015 at 11:49:49AM +0200, Daniel Vetter wrote: On Mon, Jul 13, 2015 at 11:10:51AM +0200, Maarten Lankhorst wrote: Op 10-07-15 om 13:22 schreef Damien Lespiau: Hi Patrik, Please do Cc the patch author and reviewer when finding a regression, they are superb candidates

Re: [Intel-gfx] [PATCH v2] drm/i915: Don't forget to mark crtc as inactive after disable

Hi Patrik, Please do Cc the patch author and reviewer when finding a regression, they are superb candidates for the review, especially when they are busy rewriting the display code. On Wed, Jul 08, 2015 at 03:31:52PM +0200, Patrik Jakobsson wrote: Watermark calculations depend on the

Re: [Intel-gfx] [PATCH] drm/i915: Adjust BXT HDMI port clock limits

On Fri, Jul 10, 2015 at 04:21:27PM +0300, Ville Syrjälä wrote: On Fri, Jul 10, 2015 at 02:18:57PM +0100, Damien Lespiau wrote: On Fri, Jul 10, 2015 at 04:09:42PM +0300, Imre Deak wrote: On ma, 2015-07-06 at 14:44 +0300, ville.syrj...@linux.intel.com wrote: From: Ville Syrjälä ville.syrj

Re: [Intel-gfx] [PATCH] drm/i915: Adjust BXT HDMI port clock limits

On Fri, Jul 10, 2015 at 04:09:42PM +0300, Imre Deak wrote: On ma, 2015-07-06 at 14:44 +0300, ville.syrj...@linux.intel.com wrote: From: Ville Syrjälä ville.syrj...@linux.intel.com Since commit e62925567c7926e78bc8ca976cde5c28ea265a49 Author: Vandana Kannan vandana.kan...@intel.com

[Intel-gfx] [PATCH i-g-t 06/16] plot: Add a way to color plots

It can look pretty and allows to differenciate between several plots drawn on the same canvas. Signed-off-by: Damien Lespiau damien.lesp...@intel.com --- lib/igt_plot.c | 24 lib/igt_plot.h | 3 +++ lib/tests/igt_plot.c | 1 + 3 files changed, 28 insertions

[Intel-gfx] [PATCH i-g-t 12/16] plot: Add a way to draw debug hints to help layouting

Signed-off-by: Damien Lespiau damien.lesp...@intel.com --- lib/igt_plot.c | 16 +++- lib/igt_plot.h | 1 + 2 files changed, 16 insertions(+), 1 deletion(-) diff --git a/lib/igt_plot.c b/lib/igt_plot.c index 2ca005e..763c000 100644 --- a/lib/igt_plot.c +++ b/lib/igt_plot.c @@ -443,7

[Intel-gfx] [PATCH i-g-t 15/16] plot: Test we can draw more than one graph

Signed-off-by: Damien Lespiau damien.lesp...@intel.com --- lib/tests/igt_plot.c | 30 ++ 1 file changed, 30 insertions(+) diff --git a/lib/tests/igt_plot.c b/lib/tests/igt_plot.c index 7091cef..1706912 100644 --- a/lib/tests/igt_plot.c +++ b/lib/tests/igt_plot.c

[Intel-gfx] [PATCH i-g-t 09/16] plot: Draw a grid in the background

Signed-off-by: Damien Lespiau damien.lesp...@intel.com --- lib/igt_plot.c | 34 ++ 1 file changed, 34 insertions(+) diff --git a/lib/igt_plot.c b/lib/igt_plot.c index 126f160..c8d6dcb 100644 --- a/lib/igt_plot.c +++ b/lib/igt_plot.c @@ -452,6 +452,37

[Intel-gfx] [PATCH i-g-t 14/16] plot: Write simple plot with debug rectangles as well

Not only useful for inspection but also to check we can re-start a drawing just fine. Signed-off-by: Damien Lespiau damien.lesp...@intel.com --- lib/tests/igt_plot.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/lib/tests/igt_plot.c b/lib/tests/igt_plot.c index a178fbf..7091cef 100644

[Intel-gfx] [PATCH i-g-t 02/16] stats: Add an igt_stats_init_from_array() variant

Signed-off-by: Damien Lespiau damien.lesp...@intel.com --- lib/igt_stats.c | 22 ++ lib/igt_stats.h | 2 ++ 2 files changed, 24 insertions(+) diff --git a/lib/igt_stats.c b/lib/igt_stats.c index 37fcc23..1103a7b 100644 --- a/lib/igt_stats.c +++ b/lib/igt_stats.c @@ -133,6

[Intel-gfx] [PATCH i-g-t 05/16] plot: Draw nice plots!

Signed-off-by: Damien Lespiau damien.lesp...@intel.com --- .../intel-gpu-tools/intel-gpu-tools-docs.xml | 1 + lib/Makefile.sources | 2 + lib/igt_plot.c | 607 + lib/igt_plot.h

[Intel-gfx] [PATCH i-g-t 01/16] stats: Add a way to generate values following a normal distribution

Signed-off-by: Damien Lespiau damien.lesp...@intel.com --- lib/igt_stats.c | 68 + lib/igt_stats.h | 3 +++ 2 files changed, 71 insertions(+) diff --git a/lib/igt_stats.c b/lib/igt_stats.c index 70650ec..37fcc23 100644 --- a/lib

[Intel-gfx] [PATCH i-g-t 07/16] plot: Add a map() to igt_vector_t

Can use to reduce typing a bit, at the expense of a function call. Signed-off-by: Damien Lespiau damien.lesp...@intel.com --- lib/igt_plot.c | 21 - lib/igt_plot.h | 9 + lib/tests/igt_plot.c | 11 ++- 3 files changed, 35 insertions(+), 6

[Intel-gfx] [PATCH i-g-t 03/16] stats: Add an histogram object

Histograms are a great way to have a look at a dataset to understand how the values are distributed. Signed-off-by: Damien Lespiau damien.lesp...@intel.com --- lib/igt_stats.c | 105 ++ lib/igt_stats.h | 23 +++ lib/tests

[Intel-gfx] [PATCH i-g-t 11/16] plot: Add a title to plots

Signed-off-by: Damien Lespiau damien.lesp...@intel.com --- lib/igt_plot.c | 59 lib/igt_plot.h | 2 ++ lib/tests/igt_plot.c | 1 + 3 files changed, 62 insertions(+) diff --git a/lib/igt_plot.c b/lib/igt_plot.c index afe4a1c

[Intel-gfx] [PATCH i-g-t 08/16] plot: Add top and right axes

This frames a bit more the plot will look nice with a background grid. Signed-off-by: Damien Lespiau damien.lesp...@intel.com --- lib/igt_plot.c | 46 +- lib/igt_plot.h | 2 ++ lib/igt_types.h | 14 ++ 3 files changed, 53 insertions

[Intel-gfx] [PATCH i-g-t 04/16] lib: Add some basic types

Might as well start to define some igt wide types. I'll need them for igt_plot, but other things belong here, like a color type. Signed-off-by: Damien Lespiau damien.lesp...@intel.com --- .../intel-gpu-tools/intel-gpu-tools-docs.xml | 1 + lib/Makefile.sources

[Intel-gfx] [PATCH i-g-t 10/16] plot: Make sure to have a color in the background

Until now we had transparent black. Signed-off-by: Damien Lespiau damien.lesp...@intel.com --- lib/igt_plot.c | 20 +++- 1 file changed, 19 insertions(+), 1 deletion(-) diff --git a/lib/igt_plot.c b/lib/igt_plot.c index c8d6dcb..afe4a1c 100644 --- a/lib/igt_plot.c +++ b/lib

[Intel-gfx] [PATCH i-g-t 13/16] plot: Add axis titles

Signed-off-by: Damien Lespiau damien.lesp...@intel.com --- lib/igt_plot.c | 100 +-- lib/igt_plot.h | 9 - lib/tests/igt_plot.c | 2 ++ 3 files changed, 100 insertions(+), 11 deletions(-) diff --git a/lib/igt_plot.c b/lib

[Intel-gfx] [PATCH i-g-t 16/16] plot: Add an example of the plotting API

Unfortunately, I didn't manage to make the image inclusion work... Signed-off-by: Damien Lespiau damien.lesp...@intel.com --- lib/igt_plot.c | 29 - 1 file changed, 28 insertions(+), 1 deletion(-) diff --git a/lib/igt_plot.c b/lib/igt_plot.c index b3d4bc7..bc7bce1

Re: [Intel-gfx] [PATCH] drm/i915: RMW register cycles considered evil

, and if it's required we need a special mask. Cc: Damien Lespiau damien.lesp...@intel.com Cc: Imre Deak imre.d...@intel.com Cc: Nick Hoath nicholas.ho...@intel.com Signed-off-by: Daniel Vetter daniel.vet...@intel.com Eeek. Let's take the problem the other way around: have you verified it's OK

Re: [Intel-gfx] [PATCH i-g-t 00/16] Introduction of plotting support

On Mon, Jul 06, 2015 at 08:25:56PM +0200, Daniel Vetter wrote: atm QA rolls their own thing, developers on mesa side have ministat, and it looks like you want to create something in igt. I know it's easier, but I'd like to share as much tooling between QA and devs as possible. And that kinda

Re: [Intel-gfx] [PATCH i-g-t 00/16] Introduction of plotting support

On Mon, Jul 06, 2015 at 11:32:47PM +0200, Daniel Vetter wrote: Why don't we have some of those benchmarks they have in i-g-t? (using OpenGL? they are not open source?) I have the feeling we should at least have a single point of contribution, let's make sure it's i-g-t when it's about low

Re: [Intel-gfx] [PATCH] drm/i915: RMW register cycles considered evil

On Mon, Jul 06, 2015 at 04:58:19PM +0200, Daniel Vetter wrote: On Mon, Jul 06, 2015 at 01:46:19PM +0100, Damien Lespiau wrote: On Mon, Jul 06, 2015 at 02:42:02PM +0200, Daniel Vetter wrote: Especially for workarounds which is stuff that's almost impossible to verify: The initial state

Re: [Intel-gfx] [PATCH i-g-t 00/16] Introduction of plotting support

On Mon, Jul 06, 2015 at 04:54:48PM +0200, Daniel Vetter wrote: On Mon, Jul 06, 2015 at 01:35:28PM +0100, Damien Lespiau wrote: Long story short: http://entropy.lespiau.name/intel-gpu-tools/test_simple_plot.png http://entropy.lespiau.name/intel-gpu-tools/test_two_plots.png I had fun

Re: [Intel-gfx] [PATCH v2] drm/i915: Per-DDI I_boost override

On Fri, Jul 03, 2015 at 06:21:58PM +0300, Ville Syrjälä wrote: In the old VBT spec I have, each child_dev_config is supposed to have only 33 bytes. But in this patch you're increasing it to 38. I believe this is what's causing the errors I see when I boot my BDW. Are you sure they

Re: [Intel-gfx] [PATCH v2] drm/i915: Per-DDI I_boost override

On Fri, Jul 03, 2015 at 06:37:59PM +0300, Antti Koskipää wrote: @@ -239,8 +243,13 @@ struct common_child_dev_config { u8 not_common2[2]; u8 ddc_pin; u16 edid_ptr; + u8 obsolete; + u8 flags_1; + u8 not_common3[13]; + u8 iboost_level;

Re: [Intel-gfx] [PATCH 04/12] drm: Add structures for querying color capabilities

On Fri, Jul 03, 2015 at 08:41:31AM +0200, Daniel Vetter wrote: Yeah. My first idea for the gamma stuff was that we'd simply have the blob property for the data, and then a separate enum property which decides how we interpret the blob contents. The default for the enum would be the

[Intel-gfx] [PATCH i-g-t] build: Add -lm to tests

Since the introduction of igt_stats and its usage in gem_exec_nop, we need to link the tests against libm. My rebasing bot complained when linking gem_exec_nop: lib/igt_stats.c:492: undefined reference to `sqrt' Signed-off-by: Damien Lespiau damien.lesp...@intel.com --- tests/Makefile.am | 2

[Intel-gfx] [PATCH i-g-t] build: Don't use automake's conditional in a Makefile.sources

regex-based checks. Signed-off-by: Damien Lespiau damien.lesp...@intel.com --- configure.ac | 2 +- lib/Makefile.sources | 7 --- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/configure.ac b/configure.ac index a69a381..77b595b 100644 --- a/configure.ac +++ b

Re: [Intel-gfx] [PATCH 03/12] drm/i915: Attach color properties to CRTC

On Wed, Jul 01, 2015 at 09:18:13PM +0530, Kausal Malladi wrote: From: Kausal Malladi kausal.mall...@intel.com This patch does the following: 1. Adds new files intel_color_manager(.c/.h) 2. Attaches color properties to CRTC while initialization A small note that we could remove manager from

Re: [Intel-gfx] [PATCH 04/12] drm: Add structures for querying color capabilities

On Wed, Jul 01, 2015 at 09:18:14PM +0530, Kausal Malladi wrote: From: Kausal Malladi kausal.mall...@intel.com The DRM color management framework is targeting various hardware platforms and drivers. Different platforms can have different color correction and enhancement capabilities. A

Re: [Intel-gfx] [PATCH 09/12] drm/i915: Add pipe level Gamma correction for CHV/BSW

On Wed, Jul 01, 2015 at 09:18:19PM +0530, Kausal Malladi wrote: From: Kausal Malladi kausal.mall...@intel.com CHV/BSW platform supports various Gamma correction modes, which are: 1. Legacy 8-bit mode 2. 10-bit CGM (Color Gamut Mapping) mode This patch does the following: 1. Adds the core

Re: [Intel-gfx] [PATCH 08/12] drm: Export drm_property_replace_global_blob function

On Wed, Jul 01, 2015 at 09:18:18PM +0530, Kausal Malladi wrote: From: Kausal Malladi kausal.mall...@intel.com drm_property_replace_global_blob() is getting used by many wrapper functions to replace an existing blob with new values. Because this function was static, modules are forced to

Re: [Intel-gfx] [PATCH 04/12] drm: Add structures for querying color capabilities

On Thu, Jul 02, 2015 at 05:20:45PM +0100, Damien Lespiau wrote: On Wed, Jul 01, 2015 at 09:18:14PM +0530, Kausal Malladi wrote: From: Kausal Malladi kausal.mall...@intel.com The DRM color management framework is targeting various hardware platforms and drivers. Different platforms can

Re: [Intel-gfx] [PATCH 07/12] drm: Add structures to set/get a palette color property

On Wed, Jul 01, 2015 at 09:18:17PM +0530, Kausal Malladi wrote: From: Kausal Malladi kausal.mall...@intel.com This patch adds new structures in DRM layer for Palette color correction. These structures will be used by user space agents to configure appropriate number of samples and Palette

Re: [Intel-gfx] [PATCH 03/12] drm/i915: Attach color properties to CRTC

On Wed, Jul 01, 2015 at 09:18:13PM +0530, Kausal Malladi wrote: From: Kausal Malladi kausal.mall...@intel.com This patch does the following: 1. Adds new files intel_color_manager(.c/.h) 2. Attaches color properties to CRTC while initialization We usually order the series so that it always

Re: [Intel-gfx] [PATCH 1/6] drm/i915/skl: Print the DMC firmware status in debugfs

On Wed, Jul 01, 2015 at 03:16:24PM +0200, Daniel Vetter wrote: On Tue, Jun 30, 2015 at 07:28:54PM +0100, Damien Lespiau wrote: Create a new debufs file for it, we'll have a few more things to add there. Signed-off-by: Damien Lespiau damien.lesp...@intel.com --- drivers/gpu/drm/i915

[Intel-gfx] [PATCH i-g-t 4/4] build: Add an option to not use the git hash in version

-by: Damien Lespiau damien.lesp...@intel.com --- configure.ac | 7 +++ lib/Makefile.sources | 5 + 2 files changed, 12 insertions(+) diff --git a/configure.ac b/configure.ac index 4208f00..caa3f50 100644 --- a/configure.ac +++ b/configure.ac @@ -212,6 +212,13 @@ if test x$enable_debug

[Intel-gfx] [PATCH i-g-t 2/4] aux: Don't evaluate several times the arguments of min() and max()

Signed-off-by: Damien Lespiau damien.lesp...@intel.com --- lib/igt_aux.h | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/lib/igt_aux.h b/lib/igt_aux.h index 9ea50de..2979314 100644 --- a/lib/igt_aux.h +++ b/lib/igt_aux.h @@ -91,8 +91,16 @@ void

[Intel-gfx] [PATCH i-g-t 3/4] build: Add DEBUG_FLAGS to tools and self-tests

Makes using GDB better on those binaries. Signed-off-by: Damien Lespiau damien.lesp...@intel.com --- lib/tests/Makefile.am | 2 +- tools/Makefile.am | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/tests/Makefile.am b/lib/tests/Makefile.am index 938d2ab..f09d2fe

[Intel-gfx] [PATCH i-g-t 1/4] stats: Add wikipedia links to get_trimean() and get_iqm()

Useful knowledge for anyone looking at the documentation and following the linkes. Signed-off-by: Damien Lespiau damien.lesp...@intel.com --- lib/igt_stats.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/lib/igt_stats.c b/lib/igt_stats.c index b7053c3..70650ec

Re: [Intel-gfx] [PATCH i-g-t] tools Add a intel_fw_dump tool

On Tue, Jun 30, 2015 at 05:49:12PM +0300, Jani Nikula wrote: On Tue, 30 Jun 2015, Damien Lespiau damien.lesp...@intel.com wrote: So we can inspect fw headers. Sample output: Nitpick on the tool name, I'd like to make a distinction between tools that dump some blob from the driver/hardware

[Intel-gfx] [PATCH i-g-t] tools Add a intel_fw_dump tool

, 0xc003b400) Signed-off-by: Damien Lespiau damien.lesp...@intel.com --- tools/.gitignore | 1 + tools/Makefile.sources | 1 + tools/intel_fw_dump.c | 287 + 3 files changed, 289 insertions(+) create mode 100644 tools/intel_fw_dump.c diff

  1   2   3   4   5   6   7   8   9   10   >