[Intel-gfx] [PATCH 3/9] drm/i915/dp: Fix buffer size for sink_irq_esi read

The buffer size defined is 16 bytes whereas only 14 bytes are read. Add a macro to avoid this discrepancy. Signed-off-by: Dhinakaran Pandiyan --- drivers/gpu/drm/i915/intel_dp.c | 15 +-- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_dp.c

[Intel-gfx] [PATCH 6/9] drm/i915/dp: Handle check_mst_status() failure in one place

The caller already has code to handle failure, no need to duplicate that. Signed-off-by: Dhinakaran Pandiyan --- drivers/gpu/drm/i915/intel_dp.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c index 3f2ca10ccbcd

[Intel-gfx] [PATCH 7/9] drm/i915/dp: Avoid double-printing esi regs

We debug log the esi dpcd's twice after reading them back, which is not necessary. Signed-off-by: Dhinakaran Pandiyan --- drivers/gpu/drm/i915/intel_dp.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel

[Intel-gfx] [PATCH 9/9] drm/i915/dp: Remove redundant can_mst checks in intel_dp_configure_mst()

intel_dp_can_mst() performs these checks. Signed-off-by: Dhinakaran Pandiyan --- drivers/gpu/drm/i915/intel_dp.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c index 644463ba313e..a4465b46bb27 100644 --- a/drivers/gpu

[Intel-gfx] [PATCH 4/9] drm/i915/dp: Avoid more dpcd transactions after resume failure

drm_dp_mst_topology_mgr_resume() fails if there are dpcd failures, so there's no need to try that again in _check_mst_status() Signed-off-by: Dhinakaran Pandiyan --- drivers/gpu/drm/i915/intel_dp.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers/gp

[Intel-gfx] [PATCH 8/9] drm/i915/dp: Protect link training with connection mutex

The other instances of link training are protected with connection_mutex, so do the same in check_mst_status() too. Signed-off-by: Dhinakaran Pandiyan --- drivers/gpu/drm/i915/intel_dp.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm

[Intel-gfx] [PATCH 2/9] drm/i915/mst: Print active mst links after update

. Signed-off-by: Dhinakaran Pandiyan --- drivers/gpu/drm/i915/intel_dp_mst.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_dp_mst.c b/drivers/gpu/drm/i915/intel_dp_mst.c index 88d1d2b9ac56..9a396f483f8b 100644 --- a/drivers/gpu/drm/i915

[Intel-gfx] [PATCH 1/9] drm/i915/mst: Debug log connector name in destroy_connector()

Print connector name in destroy_connect() and this doesn't add any extra lines to dmesg. The debug macro has been moved before the unregister call so that we don't lose the connector name and id. Signed-off-by: Dhinakaran Pandiyan --- drivers/gpu/drm/i915/intel_dp_mst.c | 2 +- 1 fi

[Intel-gfx] [PATCH] drm/i915/spt+: Don't reset invalid AUX channel interrupt bits in SDEIMR

The SDE interrupt bits 25, 26 and 27 are either reserved or meant for DDI E hotplug in SPT+. These bits are meant for AUX channels only in LPT and CPT, so add the appropriate checks. Signed-off-by: Dhinakaran Pandiyan --- drivers/gpu/drm/i915/i915_irq.c | 4 +++- 1 file changed, 3 insertions

[Intel-gfx] [PATCH v2] drm/dp/mst: Sideband message transaction to power up/down nodes

. Secondly, since the request-reply protocol waits for an ACK, we can be sure that a downstream sink has enough time to respond to a power up/down request. v2: Fix memory leak (Lyude) Cc: Lyude Cc: Ville Syrjälä Cc: Harry Wentland Signed-off-by: Dhinakaran Pandiyan --- drivers/gpu/drm

[Intel-gfx] [PATCH 1/2] drm/dp/mst: Sideband message transaction to power up/down nodes

. Secondly, since the request-reply protocol waits for an ACK, we can be sure that a downstream sink has enough time to respond to a power up/down request. Cc: Lyude Cc: Ville Syrjälä Cc: Harry Wentland Signed-off-by: Dhinakaran Pandiyan --- drivers/gpu/drm/drm_dp_mst_topology.c | 73

[Intel-gfx] [PATCH 2/2] drm/i915/mst: Use MST sideband message transaction for dpms

-2-2-1 --off $ xrandr --display :0 --output DP-2-2-8 --auto #Black screen $ xrandr --display :0 --output DP-2-2-1 --auto Cc: Ville Syrjälä Cc: Lyude Signed-off-by: Dhinakaran Pandiyan --- drivers/gpu/drm/i915/intel_ddi.c| 6 -- drivers/gpu/drm/i915/intel_dp_mst.c | 8 2 files

Re: [Intel-gfx] [PATCH] drm/i915: Do not do link training fallback or prune modes for eDP

On Thursday, August 17, 2017 1:44:14 PM PDT Rodrigo Vivi wrote: > On Thu, Aug 17, 2017 at 1:11 PM, Pandiyan, Dhinakaran > > wrote: > > On Thu, 2017-08-17 at 12:46 -0700, Manasi Navare wrote: > >> On Thu, Aug 17, 2017 at 07:01:05AM +, Rodrigo Vivi wrote: > >> >On Wed, Aug 16, 2017 at 11:51

[Intel-gfx] [PATCH v2 1/2] drm/dp: Bit definition for D3 power state that keeps AUX fully powered

MST monitor configuration that doesn't wake up from D3 state. v2: Use spaces instead of tabs (Jani) Signed-off-by: Dhinakaran Pandiyan --- include/drm/drm_dp_helper.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h index b17476a

[Intel-gfx] [PATCH 2/2] drm/i915/dp: Leave the AUX block powered on for MST

: https://bugs.freedesktop.org/show_bug.cgi?id=90963 Cc: Ethan Hsieh Cc: Lyude Signed-off-by: Dhinakaran Pandiyan --- drivers/gpu/drm/i915/intel_dp.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c index

[Intel-gfx] [PATCH 1/2] drm/dp: Bit definition for D3 power state that keeps AUX fully powered

MST monitor configuration that doesn't wake up from D3 state. Signed-off-by: Dhinakaran Pandiyan --- include/drm/drm_dp_helper.h | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h index b17476a..d77e0f5 100

[Intel-gfx] [PATCH] drm/i915/vbt: Assume port A is connected to eDP when there's no VBT

: Imre Deak Cc: Rodrigo Vivi Cc: Clint Taylor Signed-off-by: Dhinakaran Pandiyan --- drivers/gpu/drm/i915/intel_bios.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/i915/intel_bios.c b/drivers/gpu/drm/i915/intel_bios.c index 82b144c..89a405e 100644 --- a/drivers/gpu/drm/i915/int

[Intel-gfx] [PATCH] drm/i915: s/INTEL_INFO(dev_priv)->gen/INTEL_GEN(dev_priv) in i915_irq

INTEL_GEN() appears to be the new way of doing these platform checks, so convert this i915_irq.c too. Signed-off-by: Dhinakaran Pandiyan --- drivers/gpu/drm/i915/i915_irq.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/gpu/drm/i915

Re: [Intel-gfx] [PATCH v3 2/4] drm/i915/psr: Account for sink CRC raciness on some panels

On Tuesday, July 11, 2017 3:19:54 PM PDT Jim Bride wrote: > According to the eDP spec, when the count field in TEST_SINK_MISC > increments then the six bytes of sink CRC information in the DPCD > should be valid. Unfortunately, this doesn't seem to be the case > on some panels, and as a result we

Re: [Intel-gfx] [PATCH v3 1/4] drm/i915/psr: Clean-up intel_enable_source_psr1()

On Tuesday, July 11, 2017 3:19:53 PM PDT Jim Bride wrote: > On SKL+ there is a bit in SRD_CTL that software is not supposed to > modify, but we currently clobber that bit when we enable PSR. In > order to preserve the value of that bit, go ahead and read SRD_CTL And which bit is that? > and > d

Re: [Intel-gfx] [PATCH] drm/i915/cnl: Add missing type case.

; let clear who trigger that path. > > However DK had a better idea that is to handle the > missed type sooner before it might take to that path. > So this v2 here uses his approach. > > v2: Handle missed type sooner. > > Cc: Dhinakaran Pandiyan > Cc: Paulo Zanoni >

Re: [Intel-gfx] [PATCH v3 1/2] drm/i915: Track minimum acceptable cdclk instead of "minimum dotclock"

ep cdclk higher on CNL to workaround missing DDI clock voltage > handling v3: Squash with the CNL cdclk limits patch (DK) > Looks good to me, I only have some bikesheds and nitpicks below. Will leave it to you to decide if you want to address them. Reviewed-by: Dhinakaran Pandiyan &g

[Intel-gfx] [PATCH] drm/i915: Don't enable backlight at setup time.

do during _setup_backlight() is read the current brightness state instead of modifying it. v2: Rewrote commit message. Cc: Ville Syrjala Cc: Maarten Lankhorst Cc: Jani Nikula Cc: Yetunde Adebisi Signed-off-by: Dhinakaran Pandiyan Reviewed-by: Maarten Lankhorst Acked-by: Jani Nikula Tested-by:

Re: [Intel-gfx] [PATCH] drm/i915/cnl: Add information to missing case.

On Friday, June 16, 2017 10:18:28 PM PDT Vivi, Rodrigo wrote: > On Fri, 2017-06-16 at 21:54 +, Navare, Manasi D wrote: > > > On Fri, 2017-06-16 at 21:26 +, Vivi, Rodrigo wrote: > > > > > On Fri, 2017-06-16 at 21:21 +, Pandiyan, Dhinakaran wrote: > > > > > > > On Fri, 2017-06-16 at 14

[Intel-gfx] [PATCH v2] drm/i915: Store 9 bits of PCI Device ID for platforms with a LP PCH

ula Cc: Imre Deak Fixes: commit ec7e0bb35f8d ("drm/i915/cnp: Add PCI ID for Cannonpoint LP PCH") Reported-by: Imre Deak Reviewed-by: Imre Deak Signed-off-by: Dhinakaran Pandiyan --- drivers/gpu/drm/i915/i915_drv.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-)

[Intel-gfx] [PATCH] drm/i915: Store 9 bits of PCI Device ID for platforms with a LP PCH

igo Vivi Cc: Jani Nikula Cc: Imre Deak Fixes: commit ec7e0bb35f8d ("drm/i915/cnp: Add PCI ID for Cannonpoint LP PCH") Reported-by: Imre Deak Signed-off-by: Dhinakaran Pandiyan --- drivers/gpu/drm/i915/i915_drv.c | 15 --- 1 file changed, 12 insertions(+), 3 deletions(-)

[Intel-gfx] [PATCH v2] drm/i915: Don't enable backlight at setup time.

do during _setup_backlight() is read the current brightness state instead of modifying it. v2: Rewrote commit message. Cc: Ville Syrjala Cc: Maarten Lankhorst Cc: Jani Nikula Cc: Yetunde Adebisi Signed-off-by: Dhinakaran Pandiyan Reviewed-by: Maarten Lankhorst Acked-by: Jani Nikula --- drivers/gp

[Intel-gfx] [PATCH] drm/i915: Don't enable backlight at setup time.

ed to _enable_backlight() from _setup_backlight(). Cc: Ville Syrjala Cc: Maarten Lankhorst Cc: Jani Nikula Signed-off-by: Dhinakaran Pandiyan --- drivers/gpu/drm/i915/intel_dp_aux_backlight.c | 10 -- 1 file changed, 10 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_dp_aux_backlight

[Intel-gfx] [PATCH] Revert "drm/i915/dp: reduce link M/N parameters"

by: Rafael Ristovski Signed-off-by: Dhinakaran Pandiyan --- drivers/gpu/drm/i915/intel_display.c | 11 --- 1 file changed, 11 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c index 85b9e2f5..0b05e87 100644 --- a/drivers/gpu/drm/i915/intel

[Intel-gfx] [RESEND FOR CI PATCH v8 2/4] drm/dp: Introduce MST topology state to track available link bandwidth

iewed-by: Harry Wentland Signed-off-by: Dhinakaran Pandiyan --- drivers/gpu/drm/drm_dp_mst_topology.c | 75 +++ include/drm/drm_dp_mst_helper.h | 20 ++ 2 files changed, 95 insertions(+) diff --git a/drivers/gpu/drm/drm_dp_mst_topology.c b/

[Intel-gfx] [RESEND FOR CI PATCH v8 3/4] drm/dp: Add DP MST helpers to atomically find and release vcpi slots

to not depend on current allocation Cc: Daniel Vetter Cc: Maarten Lankhorst Cc: Archit Taneja Cc: Chris Wilson Cc: Harry Wentland Reviewed-by: Maarten Lankhorst Reviewed-by: Harry Wentland Signed-off-by: Dhinakaran Pandiyan --- drivers/gpu/drm/drm_dp_mst_topology.c | 75

[Intel-gfx] [RESEND FOR CI PATCH v8 1/4] drm: Add driver-private objects to atomic state

t Suggested-by: Daniel Vetter Signed-off-by: Dhinakaran Pandiyan --- drivers/gpu/drm/drm_atomic.c| 65 + drivers/gpu/drm/drm_atomic_helper.c | 5 ++ include/drm/drm_atomic.h| 95 + 3 files changed, 165 insertions(+

[Intel-gfx] [RESEND FOR CI PATCH v8 4/4] drm/dp: Track MST link bandwidth

Taneja Cc: Chris Wilson Cc: Harry Wentland Acked-by: Harry Wentland Reviewed-by: Maarten Lankhorst Signed-off-by: Dhinakaran Pandiyan --- drivers/gpu/drm/i915/intel_dp_mst.c | 48 - 1 file changed, 42 insertions(+), 6 deletions(-) diff --git a/drivers/gp

[Intel-gfx] [RESEND FOR CI PATCH v8 0/4] Adding driver-private objects to atomic state

Resending for CI. Pandiyan, Dhinakaran (4): drm: Add driver-private objects to atomic state drm/dp: Introduce MST topology state to track available link bandwidth drm/dp: Add DP MST helpers to atomically find and release vcpi slots drm/dp: Track MST link bandwidth drivers/gpu/drm/drm_ato

[Intel-gfx] [PATCH v8 4/4] drm/dp: Track MST link bandwidth

Taneja Cc: Chris Wilson Cc: Harry Wentland Signed-off-by: Dhinakaran Pandiyan --- drivers/gpu/drm/i915/intel_dp_mst.c | 48 - 1 file changed, 42 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_dp_mst.c b/drivers/gpu/drm/i915/int

[Intel-gfx] [PATCH v8 1/4] drm: Add driver-private objects to atomic state

rator to filter private objects (Daniel) Cc: Daniel Vetter Cc: Maarten Lankhorst Cc: Archit Taneja Cc: Chris Wilson Cc: Harry Wentland Acked-by: Harry Wentland Suggested-by: Daniel Vetter Signed-off-by: Dhinakaran Pandiyan --- drivers/gpu/drm/drm_atomic.c| 65 +++

[Intel-gfx] [PATCH v7 4/4] drm/dp: Track MST link bandwidth

ilson Cc: Harry Wentland Signed-off-by: Dhinakaran Pandiyan --- drivers/gpu/drm/i915/intel_dp_mst.c | 57 + 1 file changed, 51 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_dp_mst.c b/drivers/gpu/drm/i915/intel_dp_mst.c index 5af22a7..20c

[Intel-gfx] [PATCH v7 1/4] drm: Add driver-private objects to atomic state

rator to filter private objects (Daniel) Cc: Daniel Vetter Cc: Maarten Lankhorst Cc: Archit Taneja Cc: Chris Wilson Cc: Harry Wentland Acked-by: Harry Wentland Suggested-by: Daniel Vetter Signed-off-by: Dhinakaran Pandiyan --- drivers/gpu/drm/drm_atomic.c| 65 +

[Intel-gfx] [PATCH v7 3/4] drm/dp: Add DP MST helpers to atomically find and release vcpi slots

to not depend on current allocation Cc: Daniel Vetter Cc: Maarten Lankhorst Cc: Archit Taneja Cc: Chris Wilson Cc: Harry Wentland Signed-off-by: Dhinakaran Pandiyan --- drivers/gpu/drm/drm_dp_mst_topology.c | 75 +++ include/drm/drm_dp_mst_helper.h | 6

[Intel-gfx] [PATCH v7 0/4] Adding driver-private objects to atomic state

Changes in this version: Used connector->atomic_check() to release vcpi slots instead of the atomic_release() callback. This series introduces void * type driver-private objects in core and adds helper functions that operate on these private objects. Drivers need to implement object-specific funct

[Intel-gfx] [PATCH v7 2/4] drm/dp: Introduce MST topology state to track available link bandwidth

k. v3: WARN_ON() if connection_mutex is not held (Archit) v2: Included kernel doc, moved state initialization and switched to kmemdup() for allocation (Daniel) Cc: Daniel Vetter Cc: Maarten Lankhorst Cc: Archit Taneja Cc: Chris Wilson Cc: Harry Wentland Reviewed-by: Maarten Lankhorst Signed-off

Re: [Intel-gfx] [PATCH] drm/atomic: Add connector atomic_check function.

_helper_vtables.h > b/include/drm/drm_modeset_helper_vtables.h > >>> index b304950b402d..7b5dd909f189 100644 > >>> --- a/include/drm/drm_modeset_helper_vtables.h > >>> +++ b/include/drm/drm_modeset_helper_vtables.h > >>> @@ -860,6 +860,43 @@ s

[Intel-gfx] [PATCH v6 4/5] drm: Connector helper function to release resources

y Wentland Reviewed-by: Maarten Lankhorst Reviewed-by: Daniel Vetter Suggested-by: Daniel Vetter Signed-off-by: Dhinakaran Pandiyan --- drivers/gpu/drm/drm_atomic_helper.c | 22 ++ include/drm/drm_modeset_helper_vtables.h | 20 2 files changed, 42 in

[Intel-gfx] [PATCH v6 2/5] drm/dp: Introduce MST topology state to track available link bandwidth

k. v3: WARN_ON() if connection_mutex is not held (Archit) v2: Included kernel doc, moved state initialization and switched to kmemdup() for allocation (Daniel) Cc: Daniel Vetter Cc: Maarten Lankhorst Cc: Archit Taneja Cc: Chris Wilson Cc: Harry Wentland Reviewed-by: Maarten Lankhorst Signed-off

[Intel-gfx] [PATCH v6 1/5] drm: Add driver-private objects to atomic state

rator to filter private objects (Daniel) Cc: Daniel Vetter Cc: Maarten Lankhorst Cc: Archit Taneja Cc: Chris Wilson Cc: Harry Wentland Acked-by: Harry Wentland Suggested-by: Daniel Vetter Signed-off-by: Dhinakaran Pandiyan --- drivers/gpu/drm/drm_atomic.c| 65 +

[Intel-gfx] [PATCH v6 3/5] drm/dp: Add DP MST helpers to atomically find and release vcpi slots

to not depend on current allocation Cc: Daniel Vetter Cc: Maarten Lankhorst Cc: Archit Taneja Cc: Chris Wilson Cc: Harry Wentland Reviewed-by: Maarten Lankhorst Signed-off-by: Dhinakaran Pandiyan --- drivers/gpu/drm/drm_dp_mst_topology.c | 76 +++ include

[Intel-gfx] [PATCH v6 5/5] drm/dp: Track MST link bandwidth

quashed atomic_release() implementation and caller (Daniel) Fixed logic for connector-crtc switching case (Daniel) Fixed logic for suspend-resume case. Cc: Daniel Vetter Cc: Maarten Lankhorst Cc: Archit Taneja Cc: Chris Wilson Cc: Harry Wentland Signed-off-by: Dhinakaran Pandiyan ---

[Intel-gfx] [PATCH] drm/i915: Typo fix - 'pipe bpc' to 'pipe bpp'

Noticed this while I was looking at some debug output, [drm:intel_hdmi_compute_config [i915]] picking bpc to 12 for HDMI output [drm:intel_hdmi_compute_config [i915]] forcing pipe bpc to 36 for HDMI I believe the second line should be pipe *bpp* Signed-off-by: Dhinakaran Pandiyan --- drivers

[Intel-gfx] [PATCH v5 0/5] Adding driver-private objects to atomic state

Changes in this version: Included the 5 left over patches. Patches 1 and 5 have changed, so I have removed Maarten's R-B for patch 5. 1/5: Added NULL checks 5/5: Fixed vcpi slot accounting when atomic_release() is called multiple times within an atomic_check() This series

[Intel-gfx] [PATCH v5 2/5] drm/dp: Introduce MST topology state to track available link bandwidth

k. v3: WARN_ON() if connection_mutex is not held (Archit) v2: Included kernel doc, moved state initialization and switched to kmemdup() for allocation (Daniel) Cc: Daniel Vetter Cc: Maarten Lankhorst Cc: Archit Taneja Cc: Chris Wilson Cc: Harry Wentland Reviewed-by: Maarten Lankhorst Signed-off

[Intel-gfx] [PATCH v5 1/5] drm: Add driver-private objects to atomic state

el) Cc: Daniel Vetter Cc: Maarten Lankhorst Cc: Archit Taneja Cc: Chris Wilson Cc: Harry Wentland Acked-by: Harry Wentland Suggested-by: Daniel Vetter Signed-off-by: Dhinakaran Pandiyan --- drivers/gpu/drm/drm_atomic.c| 65 ++ drivers/gpu/drm/drm_atomi

[Intel-gfx] [PATCH v5 4/5] drm: Connector helper function to release resources

ten Lankhorst Reviewed-by: Daniel Vetter Suggested-by: Daniel Vetter Signed-off-by: Dhinakaran Pandiyan --- drivers/gpu/drm/drm_atomic_helper.c | 19 +++ include/drm/drm_modeset_helper_vtables.h | 16 2 files changed, 35 insertions(+) diff

[Intel-gfx] [PATCH v5 3/5] drm/dp: Add DP MST helpers to atomically find and release vcpi slots

nd Reviewed-by: Maarten Lankhorst Signed-off-by: Dhinakaran Pandiyan --- drivers/gpu/drm/drm_dp_mst_topology.c | 75 +++ include/drm/drm_dp_mst_helper.h | 6 +++ 2 files changed, 81 insertions(+) diff --git a/drivers/gpu/drm/drm_dp_mst_topology.c b/drivers/gpu/d

[Intel-gfx] [PATCH v5 5/5] drm/dp: Track MST link bandwidth

gic for connector-crtc switching case (Daniel) Fixed logic for suspend-resume case. Cc: Daniel Vetter Cc: Maarten Lankhorst Cc: Archit Taneja Cc: Chris Wilson Cc: Harry Wentland Signed-off-by: Dhinakaran Pandiyan --- drivers/gpu/drm/i915/intel_dp_mst.c | 48 +++

[Intel-gfx] [PATCH v5 4/8] drm: Add driver-private objects to atomic state

: Daniel Vetter Signed-off-by: Dhinakaran Pandiyan --- drivers/gpu/drm/drm_atomic.c| 69 +++ drivers/gpu/drm/drm_atomic_helper.c | 5 ++ include/drm/drm_atomic.h| 93 + 3 files changed, 167 insertions(+) diff --gi

[Intel-gfx] [PATCH v5 7/8] drm: Connector helper function to release resources

conditionally called and before other atomic_checks() (Daniel) v3: Use the new 'for_each_oldnew_connector_in_state()' macro. v2: Moved the caller hunk to this patch (Daniel) Reviewed-by: Daniel Vetter Suggested-by: Daniel Vetter Signed-off-by: Dhinakaran Pandiyan --- drivers/gpu/

[Intel-gfx] [PATCH v4 5/8] drm/dp: Introduce MST topology state to track available link bandwidth

k. v3: WARN_ON() if connection_mutex is not held (Archit) v2: Included kernel doc, moved state initialization and switched to kmemdup() for allocation (Daniel) Cc: Daniel Vetter Cc: Archit Taneja Cc: Maarten Lankhorst Cc: Chris Wilson Cc: Harry Wentland Signed-off-by: Dhinakaran Pandiyan ---

[Intel-gfx] [PATCH v4 4/8] drm: Add driver-private objects to atomic state

Harry Wentland Suggested-by: Daniel Vetter Signed-off-by: Dhinakaran Pandiyan --- drivers/gpu/drm/drm_atomic.c| 68 +++ drivers/gpu/drm/drm_atomic_helper.c | 5 ++ include/drm/drm_atomic.h| 93 + 3 files changed,

[Intel-gfx] [PATCH v4 3/8] drm/dp: Split drm_dp_mst_allocate_vcpi

Signed-off-by: Dhinakaran Pandiyan Reviewed-by: Dave Airlie --- drivers/gpu/drm/drm_dp_mst_topology.c | 21 ++--- drivers/gpu/drm/i915/intel_dp_mst.c| 4 ++-- drivers/gpu/drm/nouveau/nv50_display.c | 3 ++- drivers/gpu/drm/radeon/radeon_dp_mst.c | 4 +++- include/drm/drm_

[Intel-gfx] [PATCH v4 8/8] drm/dp: Track MST link bandwidth

Taneja Cc: Maarten Lankhorst Cc: Chris Wilson Cc: Harry Wentland Signed-off-by: Dhinakaran Pandiyan --- drivers/gpu/drm/i915/intel_dp_mst.c | 38 ++--- 1 file changed, 31 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_dp_mst.c b/d

[Intel-gfx] [PATCH v4 6/8] drm/dp: Add DP MST helpers to atomically find and release vcpi slots

mst_allocate_vcpi(). v2: Added checks for verifying the port reference is valid Moved get_mst_topology_state() into the helpers (Daniel) Changed find_vcpi_slots() to not depend on current allocation Cc: Daniel Vetter Cc: Archit Taneja Cc: Maarten Lankhorst Cc: Chris Wilson Cc: Harry Wentland S

[Intel-gfx] [PATCH v4 0/8] Adding driver-private objects to atomic state

Link bandwidth is a shared resource between multiple displays in DP MST configurations. For atomic modesetting drivers, checking if there is sufficient link bandwidth for a mode needs to be done during the atomic_check phase to avoid failed modesets when multiple CRTC's and connectors are involved.

[Intel-gfx] [PATCH v4 7/8] drm: Connector helper function to release resources

connector_in_state()' macro. v2: Moved the caller hunk to this patch (Daniel) Cc: Daniel Vetter Cc: Archit Taneja Cc: Maarten Lankhorst Cc: Chris Wilson Cc: Harry Wentland Suggested-by: Daniel Vetter Signed-off-by: Dhinakaran Pandiyan --- drivers/gpu/drm/drm_at

[Intel-gfx] [PATCH v4 1/8] drm/dp: Kill total_pbn and total_slots in struct drm_dp_mst_topology_mgr

nds on the link rate and is not a constant. So, fix this by removing the total_pbn member itself. Cc: Daniel Vetter Cc: Archit Taneja Cc: Maarten Lankhorst Cc: Chris Wilson Cc: Harry Wentland Signed-off-by: Dhinakaran Pandiyan --- drivers/gpu/drm/drm_dp_mst_topology.c | 5 ++--- i

[Intel-gfx] [PATCH v4 2/8] drm/dp: Kill unused MST vcpi slot availability tracking

escriptive. Cc: Daniel Vetter Cc: Archit Taneja Cc: Maarten Lankhorst Cc: Chris Wilson Cc: Harry Wentland Signed-off-by: Dhinakaran Pandiyan --- drivers/gpu/drm/drm_dp_mst_topology.c | 15 --- include/drm/drm_dp_mst_helper.h | 5 - 2 files changed, 8 insertions(+

[Intel-gfx] [PATCH v3 2/2] drm/i915: Implement cdclk restrictions based on Azalia BCLK

ess.(Paulo) Cc: Paulo Zanoni Signed-off-by: Dhinakaran Pandiyan --- drivers/gpu/drm/i915/intel_cdclk.c | 12 1 file changed, 12 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_cdclk.c b/drivers/gpu/drm/i915/intel_cdclk.c index dd350642..dd3ad52 100644 --- a/drivers/gp

[Intel-gfx] [PATCH v2 1/2] drm/i915/glk: Apply cdclk workaround for DP audio

x27;s defer that to future and fix the GLK bug for now. Signed-off-by: Dhinakaran Pandiyan --- drivers/gpu/drm/i915/intel_cdclk.c | 17 +++-- 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_cdclk.c b/drivers/gpu/drm/i915/intel_cdclk.c index de

[Intel-gfx] [PATCH v2 2/2] drm/i915: Implement cdclk restrictions based on Azalia BCLK

According to BSpec, "The CD clock frequency must be at least twice the frequency of the Azalia BCLK." and BCLK is configured to 96 MHz by default. This check is needed because BXT and GLK support cdclk frequencies less than 192 MHz. Signed-off-by: Dhinakaran Pandiyan --- drivers/gp

[Intel-gfx] [PATCH 1/2] drm/i915/glk: Apply cdclk workaround for DP audio

ff-by: Dhinakaran Pandiyan --- drivers/gpu/drm/i915/intel_cdclk.c | 83 -- 1 file changed, 52 insertions(+), 31 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_cdclk.c b/drivers/gpu/drm/i915/intel_cdclk.c index d643c0c..8fc0f72 100644 --- a/drivers/gpu/drm

[Intel-gfx] [PATCH 2/2] drm/i915: Implement BXT and GLK cdclk restriction based on Azalia BCLK

According to BSpec, "The CD clock frequency must be at least twice the frequency of the Azalia BCLK." and BCLK is configured to 96 MHz by default. BXT and GLK both have cdclk frequencies that are less han 192 MHz, so apply the check conditionally for these platforms. Signed-off-by:

[Intel-gfx] [PATCH v3 0/8] Adding driver-private objects to atomic state

fixes vcpi slot accounting logic for suspend-resume and connector switching Dhinakaran Pandiyan (8): drm/dp: Kill total_pbn and total_slots in struct drm_dp_mst_topology_mgr drm/dp: Kill unused MST vcpi slot availability tracking drm/dp: Split drm_dp_mst_allocate_vcpi drm: Add

[Intel-gfx] [PATCH v3 7/8] drm: Connector helper function to release resources

ter Signed-off-by: Dhinakaran Pandiyan --- drivers/gpu/drm/drm_atomic_helper.c | 19 +++ include/drm/drm_modeset_helper_vtables.h | 13 + 2 files changed, 32 insertions(+) diff --git a/drivers/gpu/drm/drm_atomic_helper.c b/drivers/gpu/drm/drm_atomic_helper.c in

[Intel-gfx] [PATCH v3 4/8] drm: Add driver-private objects to atomic state

erent types can be managed in the same state array. v2: Added docs and new iterator to filter private objects (Daniel) Suggested-by: Daniel Vetter Signed-off-by: Dhinakaran Pandiyan --- drivers/gpu/drm/drm_atomic.c| 68 +++ drivers/gpu/drm/drm_atomic_helper.c

[Intel-gfx] [PATCH v3 6/8] drm/dp: Add DP MST helpers to atomically find and release vcpi slots

verifying the port reference is valid Moved get_mst_topology_state() into the helpers (Daniel) Changed find_vcpi_slots() to not depend on current allocation Signed-off-by: Dhinakaran Pandiyan --- drivers/gpu/drm/drm_dp_mst_topology.c | 75 +++ include/drm/drm_d

[Intel-gfx] [PATCH v3 5/8] drm/dp: Introduce MST topology state to track available link bandwidth

state initialization and switched to kmemdup() for allocation (Daniel) Signed-off-by: Dhinakaran Pandiyan --- drivers/gpu/drm/drm_dp_mst_topology.c | 71 +++ include/drm/drm_dp_mst_helper.h | 20 ++ 2 files changed, 91 insertions(+) diff --git a/drivers/gp

[Intel-gfx] [PATCH v3 2/8] drm/dp: Kill unused MST vcpi slot availability tracking

The avail_slots member in the MST topology manager is never updated to reflect the available vcpi slots. The check is effectively against total slots, 63. So, let's make that check obvious and remove avail_slots. While at it, make debug messages more descriptive. Signed-off-by: Dhina

[Intel-gfx] [PATCH v3 1/8] drm/dp: Kill total_pbn and total_slots in struct drm_dp_mst_topology_mgr

. So, fix this by removing the total_pbn member itself. Signed-off-by: Dhinakaran Pandiyan --- drivers/gpu/drm/drm_dp_mst_topology.c | 5 ++--- include/drm/drm_dp_mst_helper.h | 9 + 2 files changed, 3 insertions(+), 11 deletions(-) diff --git a/drivers/gpu/drm/drm_dp_mst_topology.c

[Intel-gfx] [PATCH v3 3/8] drm/dp: Split drm_dp_mst_allocate_vcpi

ck if there are enough vcpi slots before allocating them. This brings the check to one place. Additionally drivers that will use MST state tracking for atomic modesets can use the atomic version of find_vcpi_slots() and reuse drm_dp_mst_allocate_vcpi() Signed-off-by: Dhinakaran Pandiyan Reviewed-by:

[Intel-gfx] [PATCH v3 8/8] drm/dp: Track MST link bandwidth

helper callback ->atomic_release() when CRTCs are disabled. v2: Squashed atomic_release() implementation and caller (Daniel) Fixed logic for connector-crtc switching case (Daniel) Fixed logic for suspend-resume case. Signed-off-by: Dhinakaran Pandiyan --- drivers/gpu/drm/i915/intel_dp_m

[Intel-gfx] [PATCH] drm/docs: Fix documentation for drm_atomic_set_mode_for_crtc

drm_atomic_set_mode_for_crtc() modifies the .enable member of CRTC state but documentation claims otherwise, fix that. Signed-off-by: Dhinakaran Pandiyan --- drivers/gpu/drm/drm_atomic.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/drm_atomic.c b

[Intel-gfx] [PATCH v2 6/9] drm/dp: Add DP MST helpers to atomically find and release vcpi slots

e port. drm_dp_atomic_release_vcpi_slots() should be called from ->atomic_check() to release a port's vcpi slot allocation from the state. Drivers that do not make use of this atomic helper are expected to call drm_dp_find_vcpi_slots() instead before calling drm_dp_mst_allocate_vcpi(). Signed-off-by: Dhina

[Intel-gfx] [PATCH v2 4/9] drm: Add driver private objects to atomic state

erent types can be managed in the same state array. Suggested-by: Daniel Vetter Signed-off-by: Dhinakaran Pandiyan --- drivers/gpu/drm/drm_atomic.c| 55 + drivers/gpu/drm/drm_atomic_helper.c | 6 include/drm/drm_atomic.h

[Intel-gfx] [PATCH v2 1/9] drm/dp: Store drm_device in MST topology manager

struct drm_dp_mst_topology_mgr currently stores a pointer to struct dev. Changing this to instead hold a pointer to drm_device is more useful as it gives access to DRM structures. This also makes it consistent with other DRM structures like drm_crtc, drm_connector etc. Signed-off-by: Dhinakaran

[Intel-gfx] [PATCH v2 5/9] drm/dp: Introduce MST topology state

needs to be done during the atomic_check phase to avoid failed modesets. Let's encsapsulate the available link bw information in a private state structure so that bw can be allocated and released atomically for each of the ports sharing the primary link. Signed-off-by: Dhinakaran Pan

[Intel-gfx] [PATCH v2 3/9] drm/dp: Split drm_dp_mst_allocate_vcpi

ck if there are enough vcpi slots before allocating them. This brings the check to one place. Additionally drivers that will use MST state tracking for atomic modesets can use the atomic version of find_vcpi_slots() and reuse drm_dp_mst_allocate_vcpi() Signed-off-by: Dhinakaran Pandiyan --- driver

[Intel-gfx] [PATCH v2 8/9] drm/dp: Release DP MST shared link bandwidth

Implement the ->atomic_release() callback to release the shared link bandwidth that was originally acquired during compute_config() Signed-off-by: Dhinakaran Pandiyan --- drivers/gpu/drm/i915/intel_dp_mst.c | 28 1 file changed, 28 insertions(+) diff --gi

[Intel-gfx] [PATCH v2 2/9] drm/dp: Kill unused MST vcpi slot availability tracking

more descriptive. Signed-off-by: Dhinakaran Pandiyan --- drivers/gpu/drm/drm_dp_mst_topology.c | 16 include/drm/drm_dp_mst_helper.h | 12 2 files changed, 8 insertions(+), 20 deletions(-) diff --git a/drivers/gpu/drm/drm_dp_mst_topology.c b/drivers/gp

[Intel-gfx] [PATCH v2 9/9] drm/dp: Track MST link bandwidth

helper callback ->atomic_release() when CRTCs are disabled. Signed-off-by: Dhinakaran Pandiyan --- drivers/gpu/drm/drm_atomic_helper.c | 9 - drivers/gpu/drm/i915/intel_dp_mst.c | 13 - 2 files changed, 20 insertions(+), 2 deletions(-) diff --git a/driver

[Intel-gfx] [PATCH v2 7/9] drm: Connector helper function to release atomic state

Having a ->atomic_release callback is useful to release shared resources that get allocated in compute_config(). Suggested-by: Daniel Vetter Signed-off-by: Dhinakaran Pandiyan --- include/drm/drm_modeset_helper_vtables.h | 15 +++ 1 file changed, 15 insertions(+) diff --gi

[Intel-gfx] [PATCH v2 0/9] Adding private objects to atomic state

erent types can be managed in the same state array. This series also includes some necessary cleanups. Dhinakaran Pandiyan (9): drm/dp: Store drm_device in MST topology manager drm/dp: Kill unused MST vcpi slot availability tracking drm/dp: Split drm_dp_mst_allocate_vcpi drm: Add driver pr

[Intel-gfx] [PATCH 6/6] drm/i915/dp: Track available DP MST vcpi time slots

Make use of the added MST helpers to find, allocate and release link bw for atomic modesets. Signed-off-by: Dhinakaran Pandiyan --- drivers/gpu/drm/i915/intel_display.c | 39 +++- drivers/gpu/drm/i915/intel_dp_mst.c | 36

[Intel-gfx] [PATCH 4/6] drm/dp: Introduce DP MST topology manager state to track DP link bw

needs to be done during the atomic_check phase to avoid failed modesets. Let's encsapsulate the available link bw information in a state structure so that bw can be allocated and released atomically for each of the ports sharing the primary link. Signed-off-by: Dhinakaran Pandiyan --- driver

[Intel-gfx] [PATCH 3/6] drm/dp: Split drm_dp_mst_allocate_vcpi

ck if there are enough vcpi slots before allocating them. This brings the check to one place. Additionally drivers that will use MST state tracking for atomic modesets can uses the atomic version of find_vcpi_slots() and reuse drm_dp_mst_allocate_vcpi() Signed-off-by: Dhinakaran Pandiyan --- driver

[Intel-gfx] [PATCH 5/6] drm/dp: Add DP MST helpers to atomically find and release vcpi slots

e port. drm_dp_atomic_release_vcpi_slots() should be called from ->atomic_check() to release a port's vcpi slot allocation from the state. Drivers that do not make use of this atomic helper are expected to call drm_dp_find_vcpi_slots() instead before calling drm_dp_mst_allocate_vcpi(). Signed-off-by: Dhina

[Intel-gfx] [PATCH 1/6] drm/dp: Store drm_device in MST topology manager

etc. Signed-off-by: Dhinakaran Pandiyan --- drivers/gpu/drm/drm_dp_mst_topology.c | 6 +++--- drivers/gpu/drm/i915/intel_dp_mst.c| 3 ++- drivers/gpu/drm/nouveau/nv50_display.c | 2 +- drivers/gpu/drm/radeon/radeon_dp_mst.c | 2 +- include/drm/drm_dp_mst_helper.h| 7 +-- 5 files

[Intel-gfx] [PATCH 0/6] Introduce DP MST Topology state

i915 changes to use the helpers . Dhinakaran Pandiyan (6): drm/dp: Store drm_device in MST topology manager drm/dp: Kill unused MST vcpi slot availability tracking drm/dp: Split drm_dp_mst_allocate_vcpi drm/dp: Introduce DP MST topology manager state to track DP link bw drm/dp: Add DP MST he

[Intel-gfx] [PATCH 2/6] drm/dp: Kill unused MST vcpi slot availability tracking

more informative. Signed-off-by: Dhinakaran Pandiyan --- drivers/gpu/drm/drm_dp_mst_topology.c | 14 ++ include/drm/drm_dp_mst_helper.h | 12 2 files changed, 6 insertions(+), 20 deletions(-) diff --git a/drivers/gpu/drm/drm_dp_mst_topology.c b/drivers/gp

[Intel-gfx] [PATCH v3] drm/i915/dp: Do not reset detect_done flag in intel_dp_detect

la Cc: Ander Conselvande Oliveira Cc: Jani Nikula Fixes: commit 7d23e3c37bb3 ("drm/i915: Cleaning up intel_dp_hpd_pulse") Signed-off-by: Manasi Navare Signed-off-by: Dhinakaran Pandiyan --- drivers/gpu/drm/i915/intel_dp.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-)

[Intel-gfx] [PATCH 5/6] drm/dp: Add DP MST helpers to atomically find and release vcpi slots

e port. drm_dp_atomic_release_vcpi_slots() should be called from ->atomic_check() to release a port's vcpi slot allocation from the state. Drivers that do not make use of this atomic helper are expected to call drm_dp_find_vcpi_slots() instead before calling drm_dp_mst_allocate_vcpi(). Signed-off-by: Dhina

[Intel-gfx] [PATCH 3/6] drm/dp: Split drm_dp_mst_allocate_vcpi

ck if there are enough vcpi slots before allocating them. This brings the check to one place. Additionally drivers that will use MST state tracking for atomic modesets can uses the atomic version of find_vcpi_slots() and reuse drm_dp_mst_allocate_vcpi() Signed-off-by: Dhinakaran Pandiyan --- driver

<    2   3   4   5   6   7   8   9   >