drm/i915: Split intel_ddi_pre_enable() into DP and HDMI versions
Durgadoss R (2):
drm/i915: Split bxt_ddi_pll_select()
drm/i915/dp: Enable Upfront link training for typeC DP support on BXT
drivers/gpu/drm/i915/intel_ddi.c | 162 --
drivers/gpu/dr
From: Ander Conselvan de Oliveira <ander.conselvan.de.olive...@intel.com>
Decouple intel_dp_set_link_params() from struct intel_crtc_state. This
will be useful for implementing DP upfront link training.
Reviewed-by: Durgadoss R <durgados...@intel.com>
Signed-off-by: Ander Conselvan
t link training.
Reviewed-by: Durgadoss R <durgados...@intel.com>
Signed-off-by: Ander Conselvan de Oliveira
<ander.conselvan.de.olive...@intel.com>
---
drivers/gpu/drm/i915/intel_ddi.c | 75 +++-
1 file changed, 44 insertions(+), 31 deletions(-)
diff -
)
v1:
* Rebased on top of intel_dpll_mgr.c (Durga)
* Initial version from Ander on top of intel_ddi.c
Signed-off-by: Ander Conselvan de Oliveira
<ander.conselvan.de.olive...@intel.com>
Signed-off-by: Durgadoss R <durgados...@intel.com>
---
drivers/gpu/drm/i915/intel_dpll
related clean ups.
* Corrected return values from upfront (Ander)
* Corrected atomic locking for upfront in intel_dp.c (Ville)
Changes since v1:
* all pll related functions inside ddi.c
Signed-off-by: Durgadoss R <durgados...@intel.com>
---
drivers/gpu/drm/i915/intel_ddi.c
From: Ander Conselvan de Oliveira <ander.conselvan.de.olive...@intel.com>
The value of ddi_pll_sel is derived from the selection of shared dpll,
so just calculate the final value when necessary.
v2: Actually remove it from crtc state and delete remaining usages. (CI)
Reviewed-by: Durga
from upfront (Ander)
* Corrected atomic locking for upfront in intel_dp.c (Ville)
Changes since v1:
* all pll related functions inside ddi.c
Signed-off-by: Durgadoss R <durgados...@intel.com>
---
drivers/gpu/drm/i915/intel_ddi.c | 45 ++
drivers/gpu/drm/i915/intel_dp.c
From: Ander Conselvan de Oliveira <ander.conselvan.de.olive...@intel.com>
Decouple intel_dp_set_link_params() from struct intel_crtc_state. This
will be useful for implementing DP upfront link training.
Reviewed-by: Durgadoss R <durgados...@intel.com>
Signed-off-by: Ander Conselvan
)
v1:
* Rebased on top of intel_dpll_mgr.c (Durga)
* Initial version from Ander on top of intel_ddi.c
Signed-off-by: Ander Conselvan de Oliveira
<ander.conselvan.de.olive...@intel.com>
Signed-off-by: Durgadoss R <durgados...@intel.com>
---
drivers/gpu/drm/i915/intel_dpll
From: Ander Conselvan de Oliveira <ander.conselvan.de.olive...@intel.com>
The value of ddi_pll_sel is derived from the selection of shared dpll,
so just calculate the final value when necessary.
Reviewed-by: Durgadoss R <durgados...@intel.com>
Signed-off-by: Ander Conselvan
drm/i915: Don't pass crtc_state to intel_dp_set_link_params()
drm/i915: Remove ddi_pll_sel from intel_crtc_state
drm/i915: Split intel_ddi_pre_enable() into DP and HDMI versions
Durgadoss R (2):
drm/i915: Split bxt_ddi_pll_select()
drm/i915/dp: Enable Upfront link training for typeC DP s
t link training.
Reviewed-by: Durgadoss R <durgados...@intel.com>
Signed-off-by: Ander Conselvan de Oliveira
<ander.conselvan.de.olive...@intel.com>
---
drivers/gpu/drm/i915/intel_ddi.c | 75 +++-
1 file changed, 44 insertions(+), 31 deletions(-)
diff -
From: Ander Conselvan de Oliveira <ander.conselvan.de.olive...@intel.com>
The value of ddi_pll_sel is derived from the selection of shared dpll,
so just calculate the final value when necessary.
Reviewed-by: Durgadoss R <durgados...@intel.com>
Signed-off-by: Ander Conselvan
pll related functions inside ddi.c
Signed-off-by: Durgadoss R <durgados...@intel.com>
---
drivers/gpu/drm/i915/intel_ddi.c | 58 +
drivers/gpu/drm/i915/intel_dp.c | 183 +--
drivers/gpu/drm/i915/intel_drv.h | 12 +++
3 files change
From: Ander Conselvan de Oliveira <ander.conselvan.de.olive...@intel.com>
Decouple intel_dp_set_link_params() from struct intel_crtc_state. This
will be useful for implementing DP upfront link training.
Reviewed-by: Durgadoss R <durgados...@intel.com>
Signed-off-by: Ander Conselvan
t link training.
Reviewed-by: Durgadoss R <durgados...@intel.com>
Signed-off-by: Ander Conselvan de Oliveira
<ander.conselvan.de.olive...@intel.com>
---
drivers/gpu/drm/i915/intel_ddi.c | 75 +++-
1 file changed, 44 insertions(+), 31 deletions(-)
diff -
Split intel_ddi_pre_enable() into DP and HDMI versions
Durgadoss R (2):
drm/i915: Split bxt_ddi_pll_select()
drm/i915/dp: Enable Upfront link training for typeC DP support on BXT
drivers/gpu/drm/i915/intel_ddi.c | 163 ++---
drivers/gpu/drm/i915/intel_display.c
)
v1:
* Rebased on top of intel_dpll_mgr.c (Durga)
* Initial version from Ander on top of intel_ddi.c
Signed-off-by: Ander Conselvan de Oliveira
<ander.conselvan.de.olive...@intel.com>
Signed-off-by: Durgadoss R <durgados...@intel.com>
---
drivers/gpu/drm/i915/intel_dpll
https://patchwork.freedesktop.org/patch/67784/
Link for RFCv2: https://patchwork.freedesktop.org/patch/61776/
Link for RFCv1: https://patchwork.freedesktop.org/patch/59589/
Durgadoss R (3):
drm/i915: Make finding unused crtc as a generic function
drm/i915: Split bxt_ddi_pll_select()
drm/i915/dp: Enable Upfron
from Ander on top of intel_ddi.c
Signed-off-by: Ander Conselvan de Oliveira
<ander.conselvan.de.olive...@intel.com>
Signed-off-by: Durgadoss R <durgados...@intel.com>
---
drivers/gpu/drm/i915/intel_dpll_mgr.c | 166 +++---
drivers/gpu/drm/i915/intel_dpll
in intel_dp.c (Ville)
Changes since v1:
* all pll related functions inside ddi.c
Signed-off-by: Durgadoss R <durgados...@intel.com>
---
drivers/gpu/drm/i915/intel_ddi.c | 73
drivers/gpu/drm/i915/intel_dp.c | 180 ++-
drivers/gpu/dr
on top of latest code which includes locking
for state->enable usage.
v2:
* Made this as a separate function instead of having it
inside upfront link train code.
Signed-off-by: Durgadoss R <durgados...@intel.com>
---
drivers/gpu/drm/i915/intel_displ
BXT Shared DPLL hw_state config uses values that are
different from other platforms. This patch prints the
right values for BXT through debugfs which helps during
debug.
Signed-off-by: Durgadoss R <durgados...@intel.com>
---
drivers/gpu/drm/i915/i915_debugfs.c | 26 ---
age.
v2:
* Made this as a separate function instead of having it
inside upfront link train code.
Signed-off-by: Durgadoss R <durgados...@intel.com>
---
drivers/gpu/drm/i915/intel_display.c | 74 +---
drivers/gpu/drm/i915/intel_drv.h | 2 +
2 files ch
that by letting the
update happen as long as the crtc_mask stays same.
Signed-off-by: Durgadoss R <durgados...@intel.com>
---
drivers/gpu/drm/i915/intel_dpll_mgr.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_dpll_mgr.c
b/drivers/g
Currently, the required shared dpll is saved in the crtc_state.
Similarly, this patch saves the dpll config values also, so that
these values (through crtc_state->shared_dpll->config.hw_state)
can be used for upfront link training.
Signed-off-by: Durgadoss R <durgados...@intel.com>
.
* Corrected return values from upfront (Ander)
* Corrected atomic locking for upfront in intel_dp.c (Ville)
Changes since v1:
* all pll related functions inside ddi.c
Signed-off-by: Durgadoss R <durgados...@intel.com>
---
drivers/gpu/drm/i915/intel_ddi.c | 46 ++
drivers/gpu/drm/i915/inte
patch,
to facilitate easy review.
Link for v2:https://patchwork.freedesktop.org/patch/72207/
Link for v1:https://patchwork.freedesktop.org/patch/67784/
Link for RFCv2: https://patchwork.freedesktop.org/patch/61776/
Link for RFCv1: https://patchwork.freedesktop.org/patch/59589/
Durgados
local changes made for upfront link training are reset
to their previous values once it is done; so that the
subsequent modeset is not aware of these changes.
Signed-off-by: Durgadoss R <durgados...@intel.com>
---
drivers/gpu/drm/i915/intel_ddi.c | 102 +
d
This patch exports the intel_{enable/disable}_shared_dpll
methods so that they can be called from other files also.
Subsequent patches need to call this from intel_ddi.c
Signed-off-by: Durgadoss R <durgados...@intel.com>
---
drivers/gpu/drm/i915/intel_display.c | 4 ++--
drivers/gpu/dr
tps://patchwork.freedesktop.org/patch/67784/
Link for RFCv2: https://patchwork.freedesktop.org/patch/61776/
Link for RFCv1: https://patchwork.freedesktop.org/patch/59589/
Durgadoss R (4):
drm/i915/dp: Export enable/disable_shared_dpll methods
drm/i915: Make finding unused crtc as a generic function
This patch makes intel_crtc_get_new_crtc_encoder use get_crtc_encoder
when called from non-atomic paths. This helps when intel_get_shared_dpll
is called from non-atomic context.
Signed-off-by: Durgadoss R <durgados...@intel.com>
---
drivers/gpu/drm/i915/intel_ddi.c | 3 +++
1 file chan
Looping over the crtc list and finding an unused crtc
has users other than load_detect(). Hence move it to
a common function so that we can re-use the logic.
Signed-off-by: Durgadoss R <durgados...@intel.com>
---
drivers/gpu/drm/i915/intel_display.
Do not call intel_get_shared_dpll() if there exists a
valid shared DPLL already.
Signed-off-by: Durgadoss R <durgados...@intel.com>
---
drivers/gpu/drm/i915/intel_ddi.c | 70
drivers/gpu/drm/i915/intel_display.c | 2 +-
drivers/gpu/drm/i915/intel
Looping over the crtc list and finding an unused crtc
has users other than load_detect(). Hence move it to
a common function so that we can re-use the logic.
Signed-off-by: Durgadoss R <durgados...@intel.com>
---
drivers/gpu/drm/i915/intel_display.
We do not need to loop through crtc_state to get the
encoder if we already have a valid one available.
Signed-off-by: Durgadoss R <durgados...@intel.com>
---
drivers/gpu/drm/i915/intel_ddi.c | 11 ---
drivers/gpu/drm/i915/intel_display.c | 2 +-
drivers/gpu/drm/i915/intel
Retrying with reduced lanes/bw and updating the final
available lanes/bw to DPCD is needed for upfront link
train logic. Hence, this patch adds these methods
and exports them so that these can be called from
other files like ddi.c/display.c.
Signed-off-by: Durgadoss R <durgados...@intel.
play.c, since that aligned better with other
ddi* functions.
* Kept the CHV implementation in display.c as of now
since we are using some pll functions defined in display.c
We can discuss and finalize an appropriate place for this
and then refactor/export required functions.
Durgadoss R (7):
local changes made for upfront link training are reset
to their previous values once it is done; so that the
subsequent modeset is not aware of these changes.
Signed-off-by: Durgadoss R <durgados...@intel.com>
---
drivers/gpu/drm/i915/intel_ddi.
We do not need to loop through crtc_state to get the
encoder if we already have a valid one available.
Signed-off-by: Durgadoss R <durgados...@intel.com>
---
drivers/gpu/drm/i915/intel_ddi.c | 11 ---
drivers/gpu/drm/i915/intel_display.c | 2 +-
drivers/gpu/drm/i915/intel
This patch wraps the get_ddi_pll() methods for
SKL/BXT/HSW+ with a common intel_get_ddi_pll()
method, and exports it, so that it can be shared
by other users also.
Signed-off-by: Durgadoss R <durgados...@intel.com>
---
drivers/gpu/drm/i915/intel_display.c | 18 --
drivers/g
/export required functions.
Durgadoss R (6):
drm/i915/dp: Reuse encoder if it is already available
drm/i915/dp: Reuse shared DPLL if it exists already
drm/i915/dp: Abstract all get_ddi_pll methods
drm/i915/dp: Export enable/disable_shared_dpll methods
drm/i915/dp: Enable Upfront link training
ing sequence.
* As of now, this is tested only on BXT A1 platform, on
kernel 4.2-rc2.
Signed-off-by: Durgadoss R <durgados...@intel.com>
---
drivers/gpu/drm/i915/intel_ddi.c | 152 +++
drivers/gpu/drm/i915/intel_dp.c | 41 ++-
drivers/gpu/drm/i915/in
This patch exports the intel_{enable/disable}_shared_dpll
methods so that they can be called from other files also.
Subsequent patches need to call this from intel_ddi.c
Signed-off-by: Durgadoss R <durgados...@intel.com>
---
drivers/gpu/drm/i915/intel_display.c | 4 ++--
drivers/gpu/dr
Do not call intel_get_shared_dpll() if there exists a
valid shared DPLL already.
Signed-off-by: Durgadoss R <durgados...@intel.com>
---
drivers/gpu/drm/i915/intel_ddi.c | 70
drivers/gpu/drm/i915/intel_display.c | 2 +-
drivers/gpu/drm/i915/intel
, the encoder and its PLLs are disabled; so that
the subsequent modeset is not aware of these changes.
* As of now, this is tested only on CHV.
Signed-off-by: Durgadoss R <durgados...@intel.com>
---
drivers/gpu/drm/i915/intel_display.c | 135 +++
drivers/gpu/dr
also think
of a virtual func for this, inside intel_encoder.
Durgadoss R (2):
drm/i915/dp: Make bxt_ddi_pll_select non-static
drm/i915/dp: Enable Upfront link training for type-C DP support
drivers/gpu/drm/i915/intel_ddi.c | 11 +--
drivers/gpu/drm/i915/intel_display.c | 130
-by: Durgadoss R <durgados...@intel.com>
---
drivers/gpu/drm/i915/intel_ddi.c | 11 +++
drivers/gpu/drm/i915/intel_drv.h | 4
2 files changed, 11 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_ddi.c b/drivers/gpu/drm/i915/intel_ddi.c
index 4823184..5326d60
ing sequence.
* As of now, this is tested only on BXT A1 platform, on
kernel 4.2-rc2.
Signed-off-by: Durgadoss R <durgados...@intel.com>
---
drivers/gpu/drm/i915/intel_display.c | 130 +++
drivers/gpu/drm/i915/intel_dp.c | 22 ++
drivers/gpu/drm/i915/in
).
Signed-off-by: Durgadoss R durgados...@intel.com
---
drivers/gpu/drm/i915/intel_dp.c | 17 -
1 file changed, 16 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
index a1dac9c..821d770 100644
--- a/drivers/gpu/drm/i915
i915_dpcd_val
DPCD[0x70]:0x1
Signed-off-by: Durgadoss R durgados...@intel.com
---
This patch is based on top of Jani's patch:
add i915 specific connector debugfs file for DPCD
[https://freedesktop.org/patch/43332/]
drivers/gpu/drm/i915/i915_debugfs.c | 102
i915_dpcd_val
0x1
v2: Address Jani's comments.
Signed-off-by: Durgadoss R durgados...@intel.com
---
drivers/gpu/drm/i915/i915_debugfs.c | 88 -
drivers/gpu/drm/i915/intel_drv.h| 1 +
2 files changed, 88 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu
BSpec recommends to keep the main link state consistent
between the source and the sink. As per that, update
the main link state in sink DPCD register to 'active',
for Valleyview based platforms.
Signed-off-by: Durgadoss R durgados...@intel.com
---
drivers/gpu/drm/i915/intel_psr.c | 2 +-
1 file
53 matches
Mail list logo
