Re: [Intel-gfx] [PATCH driver/intel] sna/cursor: Make sure hw cursors are disabled before disabling secondary planes

On Tue, Jun 21, 2016 at 09:25:36PM +0100, Chris Wilson wrote: > On Tue, Jun 21, 2016 at 07:34:34PM +0200, Egbert Eich wrote: > > When the hw cursors are not disabled before the cursor planes get disabled > > we may lose the cursor later on. Thus make sure the cursors are disa

[Intel-gfx] [PATCH driver/intel] sna/cursor: Make sure hw cursors are disabled before disabling secondary planes

When the hw cursors are not disabled before the cursor planes get disabled we may lose the cursor later on. Thus make sure the cursors are disabled before the cursor planes are. Signed-off-by: Egbert Eich <e...@freedesktop.org> --- src/sna/sna_display.c | 3 +++ 1 file changed, 3 inse

Re: [Intel-gfx] [RFC 3/8] drm/i915/ivb: Move WaCxSRDisabledForSpriteScaling w/a to atomic check

Regarding commit 7809e5ae35b9d8d0710f0874b2e3f10be144e38b On Wed, Jul 01, 2015 at 07:25:56PM -0700, Matt Roper wrote: > Determine whether we need to apply this workaround at atomic check time > and just set a flag that will be used by the main watermark update > routine. > > Moving this

Re: [Intel-gfx] [drm-intel:for-linux-next-fixes 3/4] DockBook: drivers/gpu/drm/drm_probe_helper.c:107: warning: Excess function parameter 'dev' description in 'DRM_OUTPUT_POLL_PERIOD'

Jani Nikula writes: > On Wed, 30 Sep 2015, Daniel Vetter wrote: > > On Wed, Sep 30, 2015 at 05:09:04PM +0800, kbuild test robot wrote: > >> tree: git://anongit.freedesktop.org/drm-intel for-linux-next-fixes > >> head: ad96c5f13442b17fafccc30f81efae2f08351f99 > >> commit:

[Intel-gfx] [PATCH] drm/i915: On reset/suspend disable hpd pins & cancel pending delayed work

This makes sure no hpd interrupt or reenable worker fires when resetting or suspending. We already call intel_hpd_init() in most cases on resume and after reset to undo this. Signed-off-by: Egbert Eich <e...@suse.de> --- drivers/gpu/drm/i915/i915_drv.c | 3 +++ drivers/gpu/dr

Re: [Intel-gfx] [PATCH 1/2] drm: Add a non-locking version of drm_kms_helper_poll_enable(), v2

Jani Nikula writes: > > Shouldn't this be _unlocked? > > I thought the convention was that functions that do not acquire locks > are called _unlocked (although they may require a lock to be held when > called). And you might have foo() that grabs locks around a call to > foo_unlocked().

[Intel-gfx] [PATCH 2/2] drm/i915: Call non-locking version of drm_kms_helper_poll_enable(), v2

k occurred. Call the newly implemented non-locking version of this function. Changes since v1: - use function name suffix '_locked' for the function that is to be called from a locked context. Signed-off-by: Egbert Eich <e...@suse.de> Reviewed-by: Daniel Vetter <daniel.vet...@ffwll.ch>

[Intel-gfx] [PATCH 1/2] drm: Add a non-locking version of drm_kms_helper_poll_enable(), v2

ady locked. Add a non-locking version as well. Changes since v1: - use function name suffix '_locked' for the function that is to be called from a locked context. Signed-off-by: Egbert Eich <e...@suse.de> --- drivers/gpu/drm/drm_probe_helper.c | 19 --- include/drm/d

[Intel-gfx] [PATCH] drm/i915: Avoid race of intel_crt_detect_hotplug() with HPD interrupt, v2

the rmw cycles with IRQ save spinlocks. Changes since v1: - Implement a function which takes care of accessing PORT_HOTPLUG_EN. Signed-off-by: Egbert Eich <e...@suse.de> --- drivers/gpu/drm/i915/i915_drv.h | 3 ++ drivers/gpu/drm/i915/i915_irq.c

Re: [Intel-gfx] [PATCH] drm/i915: Avoid race of intel_crt_detect_hotplug() with HPD interrupt, v2

Daniel Vetter writes: > On Wed, Sep 23, 2015 at 04:15:27PM +0200, Egbert Eich wrote: > > An HPD interrupt may fire while we are in a function that changes > > the PORT_HOTPLUG_EN register - especially when an HPD interrupt > > storm occurs. > > Since the interrupt

Re: [Intel-gfx] [PATCH 4/4] drm/i915: Avoid race of intel_crt_detect_hotplug() with HPD interrupt

Daniel Vetter writes: > On Wed, Sep 02, 2015 at 04:19:00PM +0200, Egbert Eich wrote: > > Hm I missed that this same register is also accessed by the irq handler > code, and it's not just that touching these bits can cause interrupts. So > yeah we need your patch, but it need

Re: [Intel-gfx] [PATCH 4/4] drm/i915: Avoid race of intel_crt_detect_hotplug() with HPD interrupt

Jani Nikula writes: > On Wed, 02 Sep 2015, Egbert Eich <e...@suse.com> wrote: > > This is exactly the scenatio I'm getting here. I get HPD interrupts at an > > order of 10^4 / sec. > > Makes you wonder if either you have faulty hardware or we are > conf

Re: [Intel-gfx] [PATCH 4/4] drm/i915: Avoid race of intel_crt_detect_hotplug() with HPD interrupt

Daniel Vetter writes: > On Tue, Sep 01, 2015 at 10:21:35PM +0200, Egbert Eich wrote: > > A HPD interrupt may fire during intel_crt_detect_hotplug() - especially > > when HPD interrupt storms occur. > > Since the interrupt handler changes the enabled interrupt lines when it

[Intel-gfx] [PATCH 1/4] drm: Add a non-locking version of drm_kms_helper_poll_enable().

ady locked. Add a non-locking version as well. Signed-off-by: Egbert Eich <e...@suse.de> --- drivers/gpu/drm/drm_probe_helper.c | 19 --- include/drm/drm_crtc_helper.h | 1 + 2 files changed, 17 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/drm_probe_hel

[Intel-gfx] [PATCH 0/4] Fix numerous issues with HPDstorm handling

rupts on gmch platforms") and commit 3432087ef846d760427eceff0ff4e7d0a2565b8a ("drm/i915: Only WARN about a stuck hotplug irq ONCE") may actually become obsolete now. Egbert Eich (4): drm: Add a non-locking version of drm_kms_helper_poll_enable(). drm/i915: Call

[Intel-gfx] [PATCH 3/4] drm/i915: Use the correct hpd_status list for non-G4xx/VLV

This copy-and-past error was introduced in: commit fd63e2a972c670887e5e8a08440111d3812c0996 Author: Imre Deak <imre.d...@intel.com> Date: Tue Jul 21 15:32:44 2015 -0700 drm/i915: combine i9xx_get_hpd_pins and pch_get_hpd_pins Signed-off-by: Egbert Eich <e...@suse.de> --- dri

[Intel-gfx] [PATCH 2/4] drm/i915: Call non-locking version of drm_kms_helper_poll_enable()

; Date: Thu Jul 9 23:44:26 2015 +0200 drm/probe-helper: Grab mode_config.mutex in poll_init/enable a deadlock occurred. Call the newly implemented non-locking version of this function. Signed-off-by: Egbert Eich <e...@suse.de> --- drivers/gpu/drm/i915/intel_hotplug.c | 2 +- 1 fil

[Intel-gfx] [PATCH 4/4] drm/i915: Avoid race of intel_crt_detect_hotplug() with HPD interrupt

. Signed-off-by: Egbert Eich <e...@suse.de> --- drivers/gpu/drm/i915/intel_crt.c | 17 - 1 file changed, 12 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_crt.c b/drivers/gpu/drm/i915/intel_crt.c index af5e43b..685f3de 100644 --- a/drivers/gpu/dr

Re: [Intel-gfx] [PATCH 1/4] drm: Add a non-locking version of drm_kms_helper_poll_enable().

Lukas Wunner writes: > > It seems DRM convention is to append _locked or _unlocked, e.g.: > drm_fb_helper_restore_fbdev_mode_unlocked > drm_gem_object_unreference_unlocked > Oh, I missed that. Did you check what these functions actually do - and compare it to what I try to achieve?

Re: [Intel-gfx] [PATCH 1/4] drm: Add a non-locking version of drm_kms_helper_poll_enable().

Lukas Wunner writes: > Hi Egbert, > > On Tue, Sep 01, 2015 at 10:21:32PM +0200, Egbert Eich wrote: > > drm_kms_helper_poll_enable() was converted to lock the mode_config > > mutex in commit 8c4ccc4ab6f64e859d4ff8d7c02c2ed2e956e07f > > ("drm/probe-helper: Gra

Re: [Intel-gfx] [PATCH 1/4] drm: Add a non-locking version of drm_kms_helper_poll_enable().

Lukas Wunner writes: > Hi Egbert, > > On Wed, Sep 02, 2015 at 12:10:19AM +0200, Egbert Eich wrote: > > Lukas Wunner writes: > > > On Tue, Sep 01, 2015 at 10:21:32PM +0200, Egbert Eich wrote: > > > > drm_kms_helper_poll_enable() was converted to

Re: [Intel-gfx] [PATCH] drm/i915/eDP: When enabling panel VDD cancel pending disable worker

Daniel Vetter writes: On Mon, Nov 24, 2014 at 5:56 PM, Egbert Eich e...@suse.de wrote: Before testing if the panel VDD is enabled on eDP cancel any pending disable worker. This makes sure the worker doesn't fire when we expect VDD to be enabled. https://bugs.freedesktop.org

[Intel-gfx] [PATCH v2] drm/i915/eDP: When enabling panel VDD cancel pending disable worker

. Signed-off-by: Egbert Eich e...@suse.de --- drivers/gpu/drm/i915/intel_dp.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c index 70bb8d0b..7ab39d4 100644 --- a/drivers/gpu/drm/i915/intel_dp.c +++ b/drivers/gpu/drm/i915/intel_dp.c

Re: [Intel-gfx] [PATCH 0/5] drm/i915 Avoid long delays when reading EDID on eDP

Daniel Vetter writes: Imo this approach with overwrite all the entry points won't scale since besides i2c and dpcd there will be more sooner or later (oui, dp mst, some debugfs userspace dp aux tools, ...). I think what we need is the same as in the i2c layer has with the

[Intel-gfx] [PATCH] drm/i915/eDP: When enabling panel VDD cancel pending disable worker

Before testing if the panel VDD is enabled on eDP cancel any pending disable worker. This makes sure the worker doesn't fire when we expect VDD to be enabled. https://bugs.freedesktop.org/show_bug.cgi?id=86201 Signed-off-by: Egbert Eich e...@suse.de --- drivers/gpu/drm/i915/intel_dp.c | 1 + 1

[Intel-gfx] [PATCH 3/5] drm/DP: Export drm_dp_i2c_xfer() DP helper function

It may be required to wrap the generic DP I2C transfer function to perfrom certain operations before of after this function is called. Make this function available to the driver. Signed-off-by: Egbert Eich e...@suse.de --- drivers/gpu/drm/drm_dp_helper.c | 3 ++- include/drm/drm_dp_helper.h

[Intel-gfx] [PATCH 2/5] drm/DP: Create pointer to generic DPCD access function

This way a driver can replace this function with its own version. Signed-off-by: Egbert Eich e...@suse.de --- drivers/gpu/drm/drm_dp_helper.c | 5 +++-- include/drm/drm_dp_helper.h | 8 2 files changed, 11 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/drm_dp_helper.c b

[Intel-gfx] [PATCH 1/5] drm/i915: Try to avoid pps_{lock, unlock}() on DP ports

From: Ville Syrjälä ville.syrj...@linux.intel.com Signed-off-by: Ville Syrjälä ville.syrj...@linux.intel.com --- drivers/gpu/drm/i915/intel_dp.c | 48 - 1 file changed, 28 insertions(+), 20 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_dp.c

[Intel-gfx] [PATCH 5/5] drm/i915/eDP: Move pps_lock() and edp_panel_vdd_on() to top

enablement to the top so that it is performed only once per master_xfer() or dpcd_access(). This fixes https://bugs.freedesktop.org/show_bug.cgi?id=86201 Signed-off-by: Egbert Eich e...@suse.de --- drivers/gpu/drm/i915/intel_dp.c | 116 --- drivers/gpu/drm/i915

[Intel-gfx] [PATCH 0/5] drm/i915 Avoid long delays when reading EDID on eDP

. This fixes the long delay observed in https://bugs.freedesktop.org/show_bug.cgi?id=86201 Egbert Eich (4): drm/DP: Create pointer to generic DPCD access function drm/DP: Export drm_dp_i2c_xfer

Re: [Intel-gfx] [PATCH] drm/i915/eDP: When enabling panel VDD cancel pending disable worker

Ville Syrjälä writes: On Mon, Nov 24, 2014 at 07:32:49PM +0200, Ville Syrjälä wrote: On Mon, Nov 24, 2014 at 05:56:20PM +0100, Egbert Eich wrote: Before testing if the panel VDD is enabled on eDP cancel any pending disable worker. This makes sure the worker doesn't fire when we expect

[Intel-gfx] [PATCH] DRM/i915: Remove magic to prevent blank screen on gen4 chipsets

chipsets introduced with commit commit 61bc95c1fbbb6a08b55bbe161fdf1ea5493fc595 Author: Egbert Eich e...@suse.com Date: Mon Mar 4 09:24:38 2013 -0500 DRM/i915: On G45 enable cursor plane briefly after enabling the display plane. to avoided occasional screen blanking on mode

Re: [Intel-gfx] [PATCH v2 3/3] drm/i915: gmch: fix stuck primary plane due to memory self-refresh mode

Chris Wilson writes: On Fri, Jun 27, 2014 at 12:07:47AM +0200, Egbert Eich wrote: Hi Daniel, hi Imre, Daniel Vetter writes: Adding Egbert since he's done the original hack here. Imre please keep him on cc. -Daniel I finally managed to get this set of patches

Re: [Intel-gfx] [PATCH v2 3/3] drm/i915: gmch: fix stuck primary plane due to memory self-refresh mode

Hi Daniel, hi Imre, Daniel Vetter writes: Adding Egbert since he's done the original hack here. Imre please keep him on cc. -Daniel I finally managed to get this set of patches tested on the platform that exhibited the intermittent blanking problem when terminating the Xserver. I can

[Intel-gfx] [PATCH v3] drm/i915: Break encoder-crtc link separately in intel_sanitize_crtc()

out the modeset hw state at load and resume time so goes back to the very beginning of the modeset rework. Signed-off-by: Egbert Eich e...@suse.de Reviewed-by: Daniel Vetter daniel.vet...@ffwll.ch Cc: sta...@vger.kernel.org Cc: Jani Nikula jani.nik...@linux.intel.com v2: This patch takes care

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Set up SDVO encoder type only at detect

Daniel Vetter writes: On Mon, Apr 14, 2014 at 07:26:09PM +0200, Egbert Eich wrote: Depending on the SDVO output_flags SDVO may have multiple connectors. These are all initialized in intel_sdvo_output_setup(). The connector that is initialized later will override the encoder_type

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Only break encoder linked when linked to connector

Daniel Vetter writes: Hm, I think to address Chris' concern we should split this into two pieces: connector_break_all links which only breaks connector-encoder stuff, used in both places as is. And a new encoder_break_all links which we'll use in sanitize_crtc in a new encoder loop.

[Intel-gfx] [PATCH] drm/i915: Break encoder-crtc link separately in intel_sanitize_crtc()

break the crtc link separatly after the links to the encoders have been broken which avoids above problem. Signed-off-by: Egbert Eich e...@suse.de v2: This patch takes care of the concernes voiced by Chris Wilson and Daniel Vetter that only breaking links if the drm_connector is linked

[Intel-gfx] [PATCH] drm/i915: Resurrect warning from intel_encoder_crtc_ok()

Bail out if crtc is NULL to keep the driver from crashing. Signed-off-by: Egbert Eich e...@suse.de --- drivers/gpu/drm/i915/intel_display.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c index c276733..dfebced

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Only break encoder linked when linked to connector

Chris Wilson writes: On Mon, Apr 14, 2014 at 07:26:08PM +0200, Egbert Eich wrote: Depending on the SDVO output_flags SDVO may have multiple connectors linking to the same encoder (in intel_connector-encoder-base). Only one of those connectors should be active (ie link to the encoder

[Intel-gfx] [PATCH v2] drm/i915: Set up SDVO encoder type only at detect

in the SDVO connector setup functions as suggested by Chris Wilson ch...@chris-wilson.co.uk. Signed-off-by: Egbert Eich e...@suse.de --- drivers/gpu/drm/i915/intel_sdvo.c | 21 +++-- 1 file changed, 15 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_sdvo.c b

[Intel-gfx] [PATCH 2/2] drm/i915: Set up SDVO encoder type only at detect

wins. Eventually when intel_sdvo_detect() is called the active connector is determined. Delay encoder type initialization until the active connector is known and set it to the type that corresponds to this connector. Signed-off-by: Egbert Eich e...@suse.de --- drivers/gpu/drm/i915/intel_sdvo.c

[Intel-gfx] [PATCH 0/2] Fix if multiple SDVO outputs are flagged

intel_connector_break_all_links() is called) where this may lead to an inconsistent driver state. The following two patches fix both situations. Egbert Eich (2): drm/i915: Only break encoder linked when linked to connector drm/i915: Set up SDVO encoder type only at detect drivers/gpu/drm/i915

[Intel-gfx] [PATCH 1/2] drm/i915: Only break encoder linked when linked to connector

the encoder links only if the connector is active (ie. has drm_connector-encoder set). Signed-off-by: Egbert Eich e...@suse.de --- drivers/gpu/drm/i915/intel_display.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c

Re: [Intel-gfx] [PATCH] drm/i915: Don't WARN about unexpected hpd interrupts on gmch platforms

scheme. This WARN has been introduced in commit b8f102e8bf71cacf33326360fdf9dcfd1a63925b Author: Egbert Eich e...@suse.de Date: Fri Jul 26 14:14:24 2013 +0200 drm/i915: Add messages useful for HPD storm detection debugging (v2) Cc: Egbert Eich e...@suse.de Cc: bitlord

[Intel-gfx] [PATCH] drm/i915/SDVO: For sysfs link put directory and target in correct order

: add i2c sysfs symlink to the connector's directory This is the same what we do for DP connectors, so make things more consistent. Signed-off-by: Egbert Eich e...@suse.de --- drivers/gpu/drm/i915/intel_sdvo.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers

Re: [Intel-gfx] HPD flood warning since b8f102e8b

Jiri Kosina writes: On Mon, 21 Oct 2013, Egbert Eich wrote: On Thu, 3 Oct 2013, Daniel Vetter wrote: Can you please attach full dmesg from boot up to the first WARN with drm.debug=0xe? This really shouldn't happen and indicates a bug somewhere ... A bit

Re: [Intel-gfx] HPD flood warning since b8f102e8b

Hi Jiri, Just found your email, it got missed do to a temporary inaccessibility to my email. Jiri Kosina writes: On Thu, 3 Oct 2013, Daniel Vetter wrote: Can you please attach full dmesg from boot up to the first WARN with drm.debug=0xe? This really shouldn't happen and indicates a

[Intel-gfx] [PATCH] drm/i915: Add messages usful for HPD strom detection debugging

For HPD storm detection we now mask out individual interrupt source bits. We have already seen a case where HPD interrupt enable bits were assigned to the wrong pins. To track these conditions more easily add some debugging messages. Signed-off-by: Egbert Eich e...@suse.de --- drivers/gpu/drm

[Intel-gfx] [PATCH] drm/i915: Make sure PORT_HOTPLUG_EN is written

Add posting read to make sure PORT_HOTPLUG_EN is written in i915_hpd_irq_setup(). Signed-off-by: Egbert Eich e...@suse.de --- drivers/gpu/drm/i915/i915_irq.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c index 1f3a971

Re: [Intel-gfx] [PATCH] drm/i915: Make sure PORT_HOTPLUG_EN is written

Chris Wilson writes: On Fri, Jul 26, 2013 at 12:31:30PM +0200, Egbert Eich wrote: Add posting read to make sure PORT_HOTPLUG_EN is written in i915_hpd_irq_setup(). It's not vital that the write be flushed here. On the deferred reenable path a further delay in rearming

[Intel-gfx] [PATCH V2] drm/i915: Add messages useful for HPD storm detection debugging (v2)

...@linux.intel.com Signed-off-by: Egbert Eich e...@suse.de --- drivers/gpu/drm/i915/i915_irq.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c index ee3e49c..6a1c207 100644 --- a/drivers/gpu/drm/i915/i915_irq.c +++ b/drivers/gpu

Re: [Intel-gfx] i915 irq storm mitigation in 3.10

Hi Jan! Jan Niggemann writes: Hi Egbert, [...] Thanks for generating the logs! Hope you had a nice birthday dinner :) I applied this patch (but not the one you sent on Monday), recompiled and logged: uncompressed (8,2M) http://files.hz6.de/kern_20130724.log bz2 (288 KB)

Re: [Intel-gfx] i915 irq storm mitigation in 3.10

Daniel Vetter writes: I've checked the docs again for gm45 and we seem to have the right values. But on early gen4 (i.e. i965g/gm) the Bspec has been wrong about these, so I wouldn't be surprised at all if they're wrong for the digital ports on gm45, too. Iirc we've already had a

Re: [Intel-gfx] i915 irq storm mitigation in 3.10

Jan Niggemann writes: Hi Daniel, Am 25.07.2013 11:58, schrieb Daniel Vetter: Can you pls try the below patch (on top of Egbert's debug stuff)? diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h index 6caa748..2d4c884 100644 ---

Re: [Intel-gfx] i915 irq storm mitigation in 3.10

Hi Jan - Jan Niggemann writes: As to the log: I messed up the kernel parameters this morning... was out of coffee this morning and my 1,5y daughter played around me :-) Here's my kernel log with drm.debug and printk.time enabled: Uncompressed (22M):

Re: [Intel-gfx] i915 irq storm mitigation in 3.10

Daniel Vetter writes: On Sun, Jul 21, 2013 at 10:23 PM, Jan Niggemann j...@hz6.de wrote: But every time this happens we only let through a few interrupts, so this shouldn't affect you badly. Can you please check whether those slowdowns line up with 2 minute intervalls? I observed

Re: [Intel-gfx] [PATCH 04/24] drm/i915: s/hotplug_irq_storm_detect/intel_hpd_irq_handler/

is the very first step since in the end the irq storm handling code will handle all hotplug logic (and so also encapsulate the locking nicely). Cc: Egbert Eich e...@suse.de Signed-off-by: Daniel Vetter daniel.vet...@ffwll.ch --- drivers/gpu/drm/i915/i915_irq.c | 16 1

Re: [Intel-gfx] [PATCH 06/24] drm/i915: fold the queue_work into intel_hpd_irq_handler

Daniel Vetter writes: Everywhere the same. Cc: Egbert Eich e...@suse.de Signed-off-by: Daniel Vetter daniel.vet...@ffwll.ch --- drivers/gpu/drm/i915/i915_irq.c | 11 +++ 1 file changed, 3 insertions(+), 8 deletions(-) [reviewed code deleted] Reviewed-by: Egbert Eich e

Re: [Intel-gfx] [PATCH 08/24] drm/i915: fix hpd interrupt register locking

: Egbert Eich e...@suse.de Signed-off-by: Daniel Vetter daniel.vet...@ffwll.ch --- drivers/gpu/drm/i915/i915_irq.c | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c index 1815891..95e15cd

Re: [Intel-gfx] [PATCH 05/24] drm/i915: fold the hpd_irq_setup call into intel_hpd_irq_handler

Daniel Vetter writes: We already have a vfunc for this (and other parts of the hpd storm handling code already use it). Cc: Egbert Eich e...@suse.de Signed-off-by: Daniel Vetter daniel.vet...@ffwll.ch --- drivers/gpu/drm/i915/i915_irq.c | 29 +++-- 1 file

Re: [Intel-gfx] [PATCH] drm/i915: prefer VBT modes for SVDO-LVDS over EDID

53d3b4d7778daf15900867336c85d3f8dd70600c Author: Egbert Eich e...@suse.de Date: Tue Jun 4 17:13:21 2013 +0200 drm/i915/sdvo: Use intel_sdvo-ddc instead of intel_sdvo-i2c for DDC Ebgert Eich fixed a long-standing bug where we simply used a non-working i2c controller to read the EDID for SDVO-LVDS

Re: [Intel-gfx] [PATCH 2/6] drm/i915: Always enable the cursor right after the primary plane

On Tue, May 21, 2013 at 05:17:27PM +0200, Egbert Eich wrote: On Wed, May 08, 2013 at 12:50:24PM +0300, ville.syrj...@linux.intel.com wrote: From: Ville Syrjälä ville.syrj...@linux.intel.com Follow the same sequence when enabling the cursor plane during modeset. No point in doing

[Intel-gfx] [PATCH] drm/i915/sdvo: Use intel_sdvo-ddc instead of intel_sdvo-i2c for DDC.

In intel_sdvo_get_lvds_modes() the wrong i2c adapter record is used for DDC. Thus the code will always have to rely on a LVDS panel mode supplied by VBT. In most cases this succeeds, so this didn't get detected for quite a while. Signed-off-by: Egbert Eich e...@suse.de --- drivers/gpu/drm/i915

Re: [Intel-gfx] [PATCH 2/6] drm/i915: Always enable the cursor right after the primary plane

this may interfere with commit 61bc95c1fbbb6a08b55bbe161fdf1ea5493fc595 Author: Egbert Eich e...@suse.com Date: Mon Mar 4 09:24:38 2013 -0500 DRM/i915: On G45 enable cursor plane briefly after enabling the display plane. described in https://bugs.freedesktop.org/show_bug.cgi?id=61457 I

Re: [Intel-gfx] [PATCH] drm/i915: force full modeset if the connector is in DPMS OFF mode

On Fri, May 03, 2013 at 02:22:09PM +0300, Imre Deak wrote: Currently the driver's assumed behavior for a modeset with an attached FB is that the corresponding connector will be switched to DPMS ON mode if it happened to be in DPMS OFF (or another power save mode). This wasn't enforced though

Re: [Intel-gfx] [PATCH v3 1/7] drm/i915: Add HPD IRQ storm detection (v4)

reply - last week I was quite busy with other stuff, this week i'm a bit preoccupied. On Tue, 09 Apr 2013, Egbert Eich e...@freedesktop.org wrote: From: Egbert Eich e...@suse.de Add a hotplug IRQ storm detection (triggered when a hotplug interrupt fires more than 5 times / sec). Okay

Re: [Intel-gfx] [PATCH v3 1/7] drm/i915: Add HPD IRQ storm detection (v4)

Hi Jani, I've rebased and regenerated all the patches now, as there were some other bikesheds i had not adressed. I've also included all Reviewed-By: This should make it easier to integrate the patches. Some comments below: On Thu, Apr 11, 2013 at 12:32:29PM +0300, Jani Nikula wrote: +

[Intel-gfx] [PATCH 1/7] drm/i915: Add HPD IRQ storm detection (v5)

..() macro. v5: Fixed coding style as suggested by Jani Nikula. Signed-off-by: Egbert Eich e...@suse.de Acked-by: Chris Wilson ch...@chris-wilson.co.uk Reviewed-by: Jesse Barnes jbar...@virtuousgeek.org --- drivers/gpu/drm/i915/i915_drv.h | 9 ++ drivers/gpu/drm/i915/i915_irq.c | 69

[Intel-gfx] [PATCH 2/7] drm/i915: (re)init HPD interrupt storm statistics

to the default value, the HPD interrupts are marked enabled. Signed-off-by: Egbert Eich e...@suse.de Reviewed-by: Jani Nikula jani.nik...@intel.com --- drivers/gpu/drm/i915/i915_irq.c | 14 ++ drivers/gpu/drm/i915/intel_crt.c | 6 ++ drivers/gpu/drm/i915/intel_dp.c | 1 - drivers

[Intel-gfx] [PATCH 3/7] drm/i915: Mask out the HPD irq bits before setting them individually.

To disable previously enabled HPD IRQs we need to reset them and set the enabled ones individually. Signed-off-by: Egbert Eich e...@suse.de Reviewed-by: Jani Nikula jani.nik...@intel.com --- drivers/gpu/drm/i915/i915_irq.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm

[Intel-gfx] [PATCH 4/7] drm/i915: Disable HPD interrupt on pin when irq storm is detected (v3)

back to periodic device polling. v2: Fixed cleanup typo. v3: Fixed format issues, clarified a variable name, changed pr_warn() to DRM_INFO() as suggested by Jani Nikula jani.nik...@linux.intel.com. Signed-off-by: Egbert Eich e...@suse.de Reviewed-by: Jani Nikula jani.nik...@intel.com

[Intel-gfx] [PATCH 5/7] drm/i915: Add Reenable Timer to turn Hotplug Detection back on (v4)

and Haswell, Restructured loop to avoid deep nesting (all suggested by Ville Syrjälä) v4: Fixed two bugs pointed out by Jani Nikula. Signed-off-by: Egbert Eich e...@suse.de Reviewed-by: Jani Nikula jani.nik...@intel.com --- drivers/gpu/drm/i915/i915_drv.h | 1 + drivers/gpu/drm/i915/i915_irq.c

[Intel-gfx] [PATCH 6/7] drm/i915: Add bit field to record which pins have received HPD events (v3)

Nikula. Signed-off-by: Egbert Eich e...@suse.de Reviewed-by: Jani Nikula jani.nik...@intel.com --- drivers/gpu/drm/i915/i915_drv.h | 1 + drivers/gpu/drm/i915/i915_irq.c | 11 +++ 2 files changed, 12 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h

[Intel-gfx] [PATCH 7/7] drm/i915: Only reprobe display on encoder which has received an HPD event (v2)

Instead of calling into the DRM helper layer to poll all connectors for changes in connected displays probe only those connectors which have received a hotplug event. Signed-off-by: Egbert Eich e...@suse.de Reviewed-by: Jani Nikula jani.nik...@intel.com v2: Resolved conflicts with changes

Re: [Intel-gfx] [PATCH 5/7] drm/i915: Add Reenable Timer to turn Hotplug Detection back on (v4)

On Tue, Apr 16, 2013 at 08:07:09PM +0200, Daniel Vetter wrote: On Tue, Apr 16, 2013 at 01:36:58PM +0200, Egbert Eich wrote: We disable hoptplug detection when we encounter a hotplug event storm. Still hotplug detection is required on some outputs (like Display Port). The interrupt storm may

Re: [Intel-gfx] [PATCH v3 5/7] drm/i915: Add Reenable Timer to turn Hotplug Detection back on (v3)

On Thu, Apr 11, 2013 at 01:44:51PM +0300, Jani Nikula wrote: + + spin_lock_irqsave(dev_priv-irq_lock, irqflags); + for (i = (HPD_NONE + 1); i HPD_NUM_PINS; i++) { + struct drm_connector *connector; + + if (dev_priv-hpd_stats[i].hpd_mark != HPD_MARK_DISABLED)

[Intel-gfx] [PATCH v3] drm/i915: Disable HPD interrupt on pin when irq storm is detected (v3)

back to periodic device polling. v2: Fixed cleanup typo. v3: Fixed format issues, clarified a variable name, changed pr_warn() to DRM_INFO() as suggested by Jani Nikula jani.nik...@linux.intel.com. Signed-off-by: Egbert Eich e...@suse.de --- drivers/gpu/drm/i915/i915_irq.c | 75

[Intel-gfx] [PATCH v4] drm/i915: Add Reenable Timer to turn Hotplug Detection back on (v4)

and Haswell, Restructured loop to avoid deep nesting (all suggested by Ville Syrjälä) v4: Fixed two bugs pointed out by Jani Nikula. Signed-off-by: Egbert Eich e...@suse.de --- drivers/gpu/drm/i915/i915_drv.h | 1 + drivers/gpu/drm/i915/i915_irq.c | 50

Re: [Intel-gfx] [PATCH v3 6/7] drm/i915: Add bit field to record which pins have received HPD events (v2)

On Thu, Apr 11, 2013 at 04:21:54PM +0300, Jani Nikula wrote: } + if (hpd_event_bits (1 intel_encoder-hpd_pin)) { + DRM_DEBUG_KMS(Connector %s (pin %i) received hotplug event.\n, +

[Intel-gfx] [PATCH v3] drm/i915: Add bit field to record which pins have received HPD events (v3)

This way it is possible to limit 're'-detect() of displays to connectors which have received an HPD event. v2: Reordered drm_i915_private: Move hpd_event_bits to hpd state tracking. v3: Fixed merge conflicts with previous patches. Signed-off-by: Egbert Eich e...@suse.de --- drivers/gpu/drm/i915

[Intel-gfx] [PATCH v2] drm/i915: Only reprobe display on encoder which has received an HPD event (v2)

Instead of calling into the DRM helper layer to poll all connectors for changes in connected displays probe only those connectors which have received a hotplug event. Signed-off-by: Egbert Eich e...@suse.de Reviewed-by: Jani Nikula jani.nik...@intel.com v2: Resolved conflicts with changes

[Intel-gfx] [PATCH v3 Update] drm/i915: Add bit field to record which pins have received HPD events (v3)

Nikula. Signed-off-by: Egbert Eich e...@suse.de --- (Sorry for the spam, I had accidenty went the wrong version of this patch) drivers/gpu/drm/i915/i915_drv.h | 1 + drivers/gpu/drm/i915/i915_irq.c | 12 2 files changed, 13 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_drv.h b

[Intel-gfx] [PATCH v3 0/7] Add HPD interrupt storm detection.

This set of patches contains the remaining bits to add IRQ strom detection and disabling. Daniel has asked me to send this batch as soon as possible even though this latest batch has not yet been retested, yet. Egbert Eich (7): drm/i915: Add HPD IRQ storm detection (v4) drm/i915: (re)init

[Intel-gfx] [PATCH v3 1/7] drm/i915: Add HPD IRQ storm detection (v4)

From: Egbert Eich e...@suse.de Add a hotplug IRQ storm detection (triggered when a hotplug interrupt fires more than 5 times / sec). Rationale: Despite of the many attempts to fix the problem with noisy hotplug interrupt lines we are still seeing systems which have issues: Once cause of noise

[Intel-gfx] [PATCH v3 2/7] drm/i915: (re)init HPD interrupt storm statistics

From: Egbert Eich e...@suse.de When an encoder is shared on several connectors there is only one hotplug line, thus this line needs to be shared among these connectors. If HPD detect only works reliably on a subset of those connectors, we want to poll the others. Thus we need to make sure

[Intel-gfx] [PATCH v3 3/7] drm/i915: Mask out the HPD irq bits before setting them individually.

From: Egbert Eich e...@suse.de To disable previously enabled HPD IRQs we need to reset them and set the enabled ones individually. Signed-off-by: Egbert Eich e...@suse.de --- drivers/gpu/drm/i915/i915_irq.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_irq.c b

[Intel-gfx] [PATCH v3 6/7] drm/i915: Add bit field to record which pins have received HPD events (v2)

From: Egbert Eich e...@suse.de This way it is possible to limit 're'-detect() of displays to connectors which have received an HPD event. v2: Reordered drm_i915_private: Move hpd_event_bits to hpd state tracking. Signed-off-by: Egbert Eich e...@suse.de --- drivers/gpu/drm/i915/i915_drv.h | 1

[Intel-gfx] [PATCH v3 7/7] drm/i915: Only reprobe display on encoder which has received an HPD event

From: Egbert Eich e...@suse.de Instead of calling into the DRM helper layer to poll all connectors for changes in connected displays probe only those connectors which have received a hotplug event. Signed-off-by: Egbert Eich e...@suse.de --- drivers/gpu/drm/i915/i915_irq.c | 37

[Intel-gfx] [PATCH v3 5/7] drm/i915: Add Reenable Timer to turn Hotplug Detection back on (v3)

From: Egbert Eich e...@suse.de We disable hoptplug detection when we encounter a hotplug event storm. Still hotplug detection is required on some outputs (like Display Port). The interrupt storm may be only temporary (on certain Dell Laptops for instance it happens at certain charging states

[Intel-gfx] [PATCH v3 4/7] drm/i915: Disable HPD interrupt on pin when irq storm is detected (v2)

From: Egbert Eich e...@suse.de This patch disables hotplug interrupts if an 'interrupt storm' has been detected. Noise on the interrupt line renders the hotplug interrupt useless: each hotplug event causes the devices to be rescanned which will will only increase the system load. Thus disable

[Intel-gfx] [PATCH] drm/i915: Fix SDVO connector and encoder get_hw_state functions

From: Egbert Eich e...@suse.de The connector associated with the encoder is considered active when the output associtated with this connector is active on the encoder. The encoder itself is considered active when either there is an active output on it or the respective SDVO channel is active

Re: [Intel-gfx] [PATCH] drm/i915: implement ibx_hpd_irq_setup

Hi Daniel, Daniel Vetter writes: On Fri, Mar 29, 2013 at 5:35 PM, Egbert Eich e...@suse.com wrote: Yeah, makes sense now that I think about it - I've simply didn't look ahead in your patch series while writing this little fixup ;-) Can you just re-add this when resending your patches

Re: [Intel-gfx] [PATCH] drm/i915: implement ibx_hpd_irq_setup

Sorry for replying so late, I wasn't able to task switch my brain towards this when it was discussed: Daniel Vetter writes: diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c index 43436e0..1279a44 100644 --- a/drivers/gpu/drm/i915/i915_irq.c +++

Re: [Intel-gfx] [PATCH v.2 05/12] DRM/i915: Get rid if the 'hotplug_supported_mask' in struct drm_i915_private.

Daniel Vetter writes: On Mon, Feb 25, 2013 at 12:06:52PM -0500, Egbert Eich wrote: Now since we have replaced the bits to show interest in hotplug IRQs we can go and nuke the 'hotplug_supported_mask'. Signed-off-by: Egbert Eich e...@suse.de I've applied your patch up

[Intel-gfx] [PATCH v.3 06/12] DRM/i915: Add HPD IRQ storm detection (v3)

duing battery charging when the battery is at a certain charge levels. Thus we add a simple algorithm here that detects an 'interrupt storm' condition. v2: Fixed comment. v3: Reordered drm_i915_private: moved hpd state tracking to hotplug work stuff. Signed-off-by: Egbert Eich e...@suse.de Acked

[Intel-gfx] [PATCH v.2 10/12] DRM/i915: Add Reenable Timer to turn Hotplug Detection back on (v2).

it after a certain grace period (2 minutes). Should the interrupt storm persist it will be detected immediately and it will be disabled again. v2: Reordered drm_i915_private: moved hotplug_reenable_timer to hpd state tracker. Signed-off-by: Egbert Eich e...@suse.de --- drivers/gpu/drm/i915/i915_drv.h

[Intel-gfx] [PATCH v.3 10/12] DRM/i915: Add Reenable Timer to turn Hotplug Detection back on (v3).

and Haswell, Restructured loop to avoid deep nesting (all suggested by Ville Syrjälä) Signed-off-by: Egbert Eich e...@suse.de --- drivers/gpu/drm/i915/i915_drv.h |2 + drivers/gpu/drm/i915/i915_irq.c | 53 ++- 2 files changed, 54 insertions(+), 1

[Intel-gfx] [PATCH v.2 09/12] DRM/i915: Disable HPD interrupt on pin when irq storm is detected (v2)

back to periodic device polling. v2: Fixed cleanup typo. Signed-off-by: Egbert Eich e...@suse.de --- drivers/gpu/drm/i915/i915_irq.c | 69 ++- 1 files changed, 53 insertions(+), 16 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915

[Intel-gfx] [PATCH v.3 11/12] DRM/i915: Add bit field to record which pins have received HPD events (v3)

This way it is possible to limit 're'-detect() of displays to connectors which have received an HPD event. v2: Reordered drm_i915_private: Move hpd_event_bits to hpd state tracking. v3: Fix patch. Signed-off-by: Egbert Eich e...@suse.de --- drivers/gpu/drm/i915/i915_drv.h |1 + drivers/gpu

  1   2   >