Re: [Intel-gfx] [PATCH 40/44] drm/cirrus: Don't use drm_device->dev_private

"Noralf Trønnes" > Cc: Sam Ravnborg Acked-by: Eric Anholt ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH 11/44] drm/v3d: Don't set drm_device->dev_private

On Fri, Apr 3, 2020 at 6:58 AM Daniel Vetter wrote: > > And switch the helper over to container_of, which is a bunch faster > than chasing a pointer. Plus allows gcc to see through this maze. > > Signed-off-by: Daniel Vetter Acked-

Re: [Intel-gfx] [PATCH 24/44] drm/hx8357d: Use devm_drm_dev_alloc

On Fri, Apr 3, 2020 at 6:59 AM Daniel Vetter wrote: > > Already using devm_drm_dev_init, so very simple replacment. > > Signed-off-by: Daniel Vetter Acked-by: Eric Anholt ___ Intel-gfx mailing list Intel-gfx@lists.freedeskt

Re: [Intel-gfx] [PATCH 12/44] drm/v3d: Use devm_drm_dev_alloc

On Fri, Apr 3, 2020 at 6:58 AM Daniel Vetter wrote: > > Also allows us to simplify the unroll code since the drm_dev_put > disappears. > > Signed-off-by: Daniel Vetter Acked-by: Eric Anholt ___ Intel-gfx mailing list Intel-gfx@lists.

Re: [Intel-gfx] [PATCH 13/44] drm/v3d: Delete v3d_dev->dev

; different objects if there's multiple > - compilers have an easier time too > > But also a bit a bikeshed, so feel free to ignore. > > Signed-off-by: Daniel Vetter > Cc: Eric Anholt a-b. ___ Intel-gfx mailing list Intel-gfx@lists.freede

Re: [Intel-gfx] [PATCH 14/44] drm/v3d: Delete v3d_dev->pdev

ed, so feel free to ignore. > > Signed-off-by: Daniel Vetter > Cc: Eric Anholt ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [Mesa-dev] gitlab.fd.o financial situation and impact on services

On Fri, Feb 28, 2020 at 12:48 AM Dave Airlie wrote: > > On Fri, 28 Feb 2020 at 18:18, Daniel Stone wrote: > > > > On Fri, 28 Feb 2020 at 03:38, Dave Airlie wrote: > > > b) we probably need to take a large step back here. > > > > > > Look at this from a sponsor POV, why would I give X.org/fd.o >

Re: [Intel-gfx] [PATCH 11/52] drm/v3d: Use drmm_add_final_kfree

r the setup to fix this issue. > > After a bit more prep in drivers and drm core v3d should be able to > switch over to devm_drm_dev_init, which should clean this up further. > > Signed-off-by: Daniel Vetter > Cc: Eric Anholt Acked-by: Eric Anholt _

Re: [Intel-gfx] [PATCH 3/4] drm/msm: Use dma_resv locking wrappers

base.resv->lock, > > - >ticket); > > + ret = dma_resv_lock_slow_interruptible(msm_obj->base.resv, > > +>ticket); > > if (!ret) { > > submit->bos[contended].flags |= BO_LOCKED; > > slow_locked = contended; > > -- > > 2.24.0 > > Reviewed-by: Eric Anholt ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH 4/4] drm/vc4: Use dma_resv locking wrappers

bo = >bo[j]->base; > > - ww_mutex_unlock(>resv->lock); > > + dma_resv_unlock(bo->resv); > > } > > > > if (contended_lock != -1 && contended_lock &g

Re: [Intel-gfx] [PATCH v3 3/3] drm/vgem: use normal cached mmap'ings

Rob Clark writes: > From: Rob Clark > > Since there is no real device associated with VGEM, it is impossible to > end up with appropriate dev->dma_ops, meaning that we have no way to > invalidate the shmem pages allocated by VGEM. So, at least on platforms > without drm_cflush_pages(), we end

Re: [Intel-gfx] [PATCH v3 1/3] drm/gem: don't force writecombine mmap'ing

Rob Clark writes: > From: Rob Clark > > The driver should be in control of this. > > Signed-off-by: Rob Clark > --- > It is possible that this was masking bugs (ie. not setting appropriate > pgprot) in drivers. I don't have a particularly good idea for tracking > those down (since I don't

Re: [Intel-gfx] [PATCH 01/59] drm/todo: Improve drm_gem_object funcs todo

cleanup. I took a look at a lot of it. Patch 1-2, 4-10, 41-47, 49-50, and all the gem_prime_import/export drop patches are: Reviewed-by: Eric Anholt I don't currently have a plan for reading the shuffle in patch 3. signature.asc Description: PGP signature _

Re: [Intel-gfx] [PATCH 16/16] drm/vc4: Call drm_dev_register() after all setup is done

Noralf Trønnes writes: > drm_dev_register() initializes internal clients like bootsplash as the > last thing it does, so all setup needs to be done at this point. > > Fix by calling vc4_kms_load() before registering. > Also check the error code returned from that function. >

Re: [Intel-gfx] [PATCH 15/17] drm/vc4: Convert to using __drm_atomic_helper_crtc_reset() for reset.

Maarten Lankhorst writes: > Convert vc4 to using __drm_atomic_helper_crtc_reset(), instead of > writing its own version. Instead of open coding destroy_state(), > call it directly for freeing the old state. > > Signed-off-by: Maarten Lankhorst > Cc: Eric Anholt > --- &

Re: [Intel-gfx] [PATCH 01/17] drm/vc4: Fix memory leak during gpu reset.

Maarten Lankhorst writes: > __drm_atomic_helper_crtc_destroy_state does not free memory, it only > cleans it up. Fix this by calling the functions own destroy function. Reviewed-by: Eric Anholt signature.asc Description: PGP signature ___ Int

Re: [Intel-gfx] [PATCH 2/6] drm/drv: Prepare to remove drm_dev_unplug()

Daniel Vetter writes: > > Zooming out more looking at the big picture I'd say all your work in the > past few years has enormously simplified drm for simple drivers already. > If we can't resolve this one here right now that just means you "only" > made drm 98% simpler instead of maybe 99%. It's

Re: [Intel-gfx] [PATCH v5 4/5] drm: Add library for shmem backed GEM objects

Noralf Trønnes writes: > Den 28.01.2019 21.57, skrev Rob Herring: >> On Sun, Dec 2, 2018 at 9:59 AM Noralf Trønnes wrote: >>> >>> >>> Den 30.11.2018 00.58, skrev Eric Anholt: >>>> Daniel Vetter writes: >>>> >>>>> On Wed

Re: [Intel-gfx] [PATCH] dma-buf: Enhance dma-fence tracing

ses where they have unique dma_fence_ops, and >> > preferring to have descriptors for the whole fence context). strings do >> > not pack as well into the ftrace ringbuffer and we would prefer to >> > reduce the amount of indirect callbacks required for frequent tracepoint >

Re: [Intel-gfx] [PATCH v3 2/3] drm: Add CRTC background color property (v3)

Brian Starkey writes: > Hi Matt, > > On Thu, Nov 15, 2018 at 02:13:45PM -0800, Matt Roper wrote: >>Some display controllers can be programmed to present non-black colors >>for pixels not covered by any plane (or pixels covered by the >>transparent regions of higher planes). Compositors that

Re: [Intel-gfx] [PATCH v5 4/5] drm: Add library for shmem backed GEM objects

Daniel Vetter writes: > On Wed, Nov 28, 2018 at 01:52:56PM -0800, Eric Anholt wrote: >> Daniel Vetter writes: >> >> > On Tue, Nov 27, 2018 at 12:38:44PM -0800, Eric Anholt wrote: >> >> Daniel Vetter writes: >> >> >> >> &

Re: [Intel-gfx] [PATCH v5 4/5] drm: Add library for shmem backed GEM objects

Daniel Vetter writes: > On Tue, Nov 27, 2018 at 12:38:44PM -0800, Eric Anholt wrote: >> Daniel Vetter writes: >> >> > On Mon, Nov 26, 2018 at 04:36:21PM -0800, Eric Anholt wrote: >> >> Noralf Trønnes writes: >> >> > +static voi

Re: [Intel-gfx] [PATCH 4/4] drm/edid: Add display_info.rgb_quant_range_selectable

Ville Syrjala writes: > From: Ville Syrjälä > > Move the CEA-861 QS bit handling entirely into the edid code. No > need to bother the drivers with this. > > Cc: Alex Deucher > Cc: "Christian König" > Cc: "David (ChunMing) Zhou" > Cc:

Re: [Intel-gfx] [PATCH i-g-t 4/4] igt/v3d_*: Add new tests for the V3D UABI.

Petri Latvala writes: > On Mon, Nov 26, 2018 at 12:46:46PM -0800, Eric Anholt wrote: >> Petri Latvala writes: >> >> > On Wed, Nov 14, 2018 at 02:28:32PM -0800, Eric Anholt wrote: >> >> These are basic non-rendering tests of the UABI. >

Re: [Intel-gfx] [PATCH v5 4/5] drm: Add library for shmem backed GEM objects

Daniel Vetter writes: > On Mon, Nov 26, 2018 at 04:36:21PM -0800, Eric Anholt wrote: >> Noralf Trønnes writes: >> > +static void drm_gem_shmem_vm_close(struct vm_area_struct *vma) >> > +{ >> > + struct drm_gem_object *obj = vma->vm_private_data; >

Re: [Intel-gfx] [PATCH v5 4/5] drm: Add library for shmem backed GEM objects

Noralf Trønnes writes: > +static void drm_gem_shmem_vm_close(struct vm_area_struct *vma) > +{ > + struct drm_gem_object *obj = vma->vm_private_data; > + struct drm_gem_shmem_object *shmem = to_drm_gem_shmem_obj(obj); > + > + drm_gem_shmem_put_pages(shmem); > +

Re: [Intel-gfx] [PATCH i-g-t 4/4] igt/v3d_*: Add new tests for the V3D UABI.

Petri Latvala writes: > On Wed, Nov 14, 2018 at 02:28:32PM -0800, Eric Anholt wrote: >> These are basic non-rendering tests of the UABI. >> >> Signed-off-by: Eric Anholt >> --- >> lib/igt_v3d.c | 4 -- >> tests/Makefile.am |

Re: [Intel-gfx] [PATCH RFC 4/5] drm/amdgpu: Add accounting of command submission via DRM cgroup

Christian König writes: > Am 20.11.18 um 21:57 schrieb Eric Anholt: >> Kenny Ho writes: >> >>> Account for the number of command submitted to amdgpu by type on a per >>> cgroup basis, for the purpose of profiling/monitoring applications. >> For

Re: [Intel-gfx] [PATCH RFC 4/5] drm/amdgpu: Add accounting of command submission via DRM cgroup

Kenny Ho writes: > Account for the number of command submitted to amdgpu by type on a per > cgroup basis, for the purpose of profiling/monitoring applications. For profiling other drivers, I've used perf tracepoints, which let you get useful timelines of multiple events in the driver. Have you

Re: [Intel-gfx] [PATCH RFC 5/5] drm/amdgpu: Add accounting of buffer object creation request via DRM cgroup

Kenny Ho writes: > Account for the total size of buffer object requested to amdgpu by > buffer type on a per cgroup basis. > > x prefix in the control file name x.bo_requested.amd.stat signify > experimental. Why is a counting of the size of buffer objects ever allocated useful, as opposed to

Re: [Intel-gfx] [PATCH 4/5] drm/cma-helper: Add DRM_GEM_CMA_VMAP_DRIVER_OPS

ng the conditional dma_buf_vunmap() call in > drm_gem_cma_free_object() safe. > > Signed-off-by: Noralf Trønnes I didn't look through 1-3 much since they had acks, but 4/5 get my: Reviewed-by: Eric Anholt signature.asc Description: PGP signature ___ Intel

Re: [Intel-gfx] [PATCH i-g-t 1/4] kms_content_protection: Fix log bug on 32-bit platforms.

Ville Syrjälä writes: > On Wed, Nov 14, 2018 at 02:28:29PM -0800, Eric Anholt wrote: >> long is different between 32 and 64 and should basically never be >> used. Fixes compiler warning about passing the wrong type. >> >> Signed-off-by: Eric Anholt >> --- &

[Intel-gfx] [PATCH i-g-t 3/4] Add v3d helper library

Just a few little ioctl wrappers that v3d tests will use. Signed-off-by: Eric Anholt --- lib/Makefile.sources | 2 + lib/drmtest.c| 3 + lib/drmtest.h| 1 + lib/igt_v3d.c| 130 +++ lib/igt_v3d.h| 46

[Intel-gfx] [PATCH i-g-t 4/4] igt/v3d_*: Add new tests for the V3D UABI.

These are basic non-rendering tests of the UABI. Signed-off-by: Eric Anholt --- lib/igt_v3d.c | 4 -- tests/Makefile.am | 2 + tests/Makefile.sources| 6 +++ tests/meson.build | 3 ++ tests/v3d_ci/README | 26 + tests/v3d_ci/v3d.testlist

[Intel-gfx] [PATCH i-g-t 1/4] kms_content_protection: Fix log bug on 32-bit platforms.

long is different between 32 and 64 and should basically never be used. Fixes compiler warning about passing the wrong type. Signed-off-by: Eric Anholt --- tests/kms_content_protection.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/kms_content_protection.c b

[Intel-gfx] [PATCH i-g-t 2/4] v3d: Import the V3D DRM UAPI header.

Copied from make headers_install at drm-misc-next 783195ec1cad ("drm/syncobj: disable the timeline UAPI for now v2") Signed-off-by: Eric Anholt --- include/drm-uapi/v3d_drm.h | 204 + 1 file changed, 204 insertions(+) create mode 100644 includ

Re: [Intel-gfx] [PATCH v4 1/2] drm: Add drm_any_plane_has_format()

function and let drivers > call it themselves > > Cc: Eric Anholt > Cc: Dhinakaran Pandiyan > Signed-off-by: Ville Syrjälä > Reviewed-by: Dhinakaran Pandiyan I don't particularly see the point in having FB creation duplicate the validation that atomic check will ev

Re: [Intel-gfx] [igt-dev] [PATCH] RFC: Make igts for cross-driver stuff mandatory?

Sean Paul writes: > On Fri, Oct 19, 2018 at 10:50:49AM +0200, Daniel Vetter wrote: >> Hi all, >> >> This is just to collect feedback on this idea, and see whether the >> overall dri-devel community stands on all this. I think the past few >> cross-vendor uapi extensions all came with igts

Re: [Intel-gfx] [PATCH 13/18] drm/vc4: Use drm_atomic_helper_shutdown

Daniel Vetter writes: > drm_plane_helper_disable is a non-atomic drivers only function, and > will blow up (since no one passes the locking context it needs). > > Atomic drivers which want to quiescent their hw on unload should > use drm_atomic_helper_shutdown() instead. > > v2: Rebase. I've

Re: [Intel-gfx] [PATCH 09/10] drm/vc4: Use drm_crtc_mask()

Ville Syrjala writes: > From: Ville Syrjälä > > Use drm_crtc_mask() where appropriate. Reviewed-by: Eric Anholt signature.asc Description: PGP signature ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freede

Re: [Intel-gfx] [PATCH v2 12/13] drm/vc4: Stop updating plane->fb/crtc

Ville Syrjala writes: > From: Ville Syrjälä > > We want to get rid of plane->fb/crtc on atomic drivers. Stop setting > them. > > Cc: Eric Anholt > Signed-off-by: Ville Syrjälä > Reviewed-by: Maarten Lankhorst > Reviewed-by: Daniel Vetter Reviewed-by

Re: [Intel-gfx] [PATCH 6/9] drm/pl111: Set .gem_prime_vmap and .gem_prime_mmap

Noralf Trønnes writes: > These are needed for pl111 to use the generic fbdev emulation. Reviewed-by: Eric Anholt signature.asc Description: PGP signature ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.

Re: [Intel-gfx] [PATCH v2] drm/i915: Promote .format_mod_supported() to the lead role

Ville Syrjälä writes: > On Mon, May 21, 2018 at 12:21:01PM -0700, Eric Anholt wrote: >> Ville Syrjala writes: >> >> > From: Ville Syrjälä >> > >> > Up to now we've used the plane's modifier list as the primary >> > source of information for

Re: [Intel-gfx] [PATCH v2] drm/i915: Promote .format_mod_supported() to the lead role

it would be a lot shorter if you just had a helper to check if your format and modifier was in drm_plane->format_types and drm_plane->modifiers, since then you wouldn't be duplicating your tables and you wouldn't need has_ccs either. However, it's not my driver and it unblocks vc4's patch

Re: [Intel-gfx] [PULL] drm-misc-next

Maarten Lankhorst writes: > Hey, > > Another pull request for drm-misc-next. Previous one was not applied yet, > but only sending delta since last request: > https://lists.freedesktop.org/archives/dri-devel/2018-May/175722.html Note, I think this PR has a UABI

Re: [Intel-gfx] [PATCH] dma-fence: remove fill_driver_data callback

unately. > > Cc: Eric Anholt <e...@anholt.net> Reviewed-by: Eric Anholt <e...@anholt.net> signature.asc Description: PGP signature ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH 16/17] drm/virtio: Remove unecessary dma_fence_ops

Daniel Vetter <daniel.vet...@ffwll.ch> writes: > dma_fence_default_wait is the default now, same for the trivial > enable_signaling implementation. Reviewed-by: Eric Anholt <e...@anholt.net> signature.asc Description: PGP signature ___

Re: [Intel-gfx] [PATCH 12/17] drm/qxl: Remove unecessary dma_fence_ops

Daniel Vetter <daniel.vet...@ffwll.ch> writes: > dma_fence_default_wait is the default now, same for the trivial > enable_signaling implementation. Drop the mention of dma_fence_default_wait, since this one doesn't use that? Other than that, Reviewed-by: Eric Anholt <

Re: [Intel-gfx] [PATCH 07/17] drm: Remove unecessary dma_fence_ops

Daniel Vetter <daniel.vet...@ffwll.ch> writes: > dma_fence_default_wait is the default now, same for the trivial > enable_signaling implementation. > > Signed-off-by: Daniel Vetter <daniel.vet...@ffwll.ch> Reviewed-by: Eric Anholt <e...@anholt.net> signature.

Re: [Intel-gfx] [PATCH 14/17] drm/vc4: Remove unecessary dma_fence_ops

Daniel Vetter <daniel.vet...@ffwll.ch> writes: > dma_fence_default_wait is the default now, same for the trivial > enable_signaling implementation. > > Signed-off-by: Daniel Vetter <daniel.vet...@ffwll.ch> Reviewed-by: Eric Anholt <e...@anholt.net> signature.

Re: [Intel-gfx] [PATCH 02/17] dma-fence: remove fill_driver_data callback

Daniel Vetter writes: > Noticed while I was typing docs. Entirely unused. > > Signed-off-by: Daniel Vetter > --- > include/linux/dma-fence.h | 10 -- > 1 file changed, 10 deletions(-) > > diff --git a/include/linux/dma-fence.h

Re: [Intel-gfx] [PATCH 01/17] dma-fence: Some kerneldoc polish for dma-fence.h

be on a new line? Or at least a '.' in between. Other than that, Reviewed-by: Eric Anholt <e...@anholt.net> Thanks! signature.asc Description: PGP signature ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [Freedreno] [PATCH 01/10] include: Move ascii85 functions from i915 to linux/ascii85.h

Chris Wilson writes: > Quoting Jordan Crouse (2018-04-05 23:06:53) >> On Thu, Apr 05, 2018 at 04:00:47PM -0600, Jordan Crouse wrote: >> > The i915 DRM driver very cleverly used ascii85 encoding for their >> > GPU state file. Move the encode functions to a general header

Re: [Intel-gfx] [PATCH] drm/i915: Promote .format_mod_supported() to the lead role

hink you have the chance to delete a whole ton of code if you keep the assumption that the core will check that the format is one of plane->format_types. > > Cc: Eric Anholt <e...@anholt.net> > References: > https://lists.freedesktop.org/archives/dri-devel/20

Re: [Intel-gfx] [RFC PATCH i-g-t 0/3] Test the plane formats on the Chamelium

Maxime Ripard writes: > [ Unknown signature status ] > Hi, > > On Mon, Mar 05, 2018 at 03:21:26PM +0100, Maxime Ripard wrote: >> Here is an RFC at starting to test the plane formats using the >> Chamelium over the HDMI. This was tested using the vc4 DRM driver >> found

Re: [Intel-gfx] [PATCH 2/3] drm: Make sure at least one plane supports the fb format

Ville Syrjälä <ville.syrj...@linux.intel.com> writes: > On Thu, Mar 15, 2018 at 08:03:44PM +0200, Ville Syrjälä wrote: >> On Thu, Mar 15, 2018 at 07:48:02PM +0200, Ville Syrjälä wrote: >> > On Thu, Mar 15, 2018 at 10:42:17AM -0700, Eric Anholt wrote: >>

Re: [Intel-gfx] [PATCH 2/3] drm: Make sure at least one plane supports the fb format

check in the core since we may not know the > modifier yet, instead export the function and let drivers > call it themselves > v4: Unexport the functiona and put the format_default check back > since this will again be called by the core, ie. undo v3 ;) > > Cc: Eric A

Re: [Intel-gfx] [RFC PATCH i-g-t 2/3] tests/chamelium: Add test case for plane formats

Maxime Ripard writes: > KMS can support a lot of different plane formats that are not being tested > by the current chamelium tests. > > Add some preliminary tests to exert the RGB formats exposed by the KMS > planes. I'm really excited for this test. A few

Re: [Intel-gfx] [PATCH 4/4] drm/vc4: Validate framebuffer pixel format/modifier

Ville Syrjala writes: > From: Ville Syrjälä > > Only create framebuffers with supported format/modifier combinations by > checking that at least one plane supports the requested combination. > > Using drm_any_plane_has_format() is

Re: [Intel-gfx] [PATCH 1/3] drm: Make sure at least one plane supports the fb format

Ville Syrjälä <ville.syrj...@linux.intel.com> writes: > On Mon, Mar 05, 2018 at 12:59:00PM -0800, Eric Anholt wrote: >> Ville Syrjala <ville.syrj...@linux.intel.com> writes: >> >> > From: Ville Syrjälä <ville.syrj...@linux.intel.com> >> > >&g

Re: [Intel-gfx] [PATCH 1/3] drm: Make sure at least one plane supports the fb format

Ville Syrjala writes: > From: Ville Syrjälä > > To make life easier for drivers, let's have the core check that the > requested pixel format is supported by at least one plane when creating > a new framebuffer. > > Signed-off-by:

Re: [Intel-gfx] [PATCH i-g-t 2/3] meson: gtkdoc support

Daniel Vetter writes: > Bunch of neat improvements: > > - xml generates correctly depend upon the test binaries > - no need to re-run autogen.sh when new chapters/functions get added, > all handed by meson I just rebased on top of this commit, and now my cross build

Re: [Intel-gfx] [PATCH i-g-t 2/2] automake: include drm-uapi headers in EXTRA_DIST

Petri Latvala writes: > Series is reviewed and tested and pushed, thanks. Thanks, sorry for the fallout! signature.asc Description: PGP signature ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org

Re: [Intel-gfx] [PATCH i-g-t v2 3/3] igt: Add VC4 purgeable BO tests

Boris Brezillon writes: > Signed-off-by: Boris Brezillon > --- > Changes in v2: > - Add a rule to build vc4 purgeable tests when using Meson (suggested by > Petri) > - Rework the subtests to avoid uncertainty (suggested

Re: [Intel-gfx] [PATCH i-g-t 0/5] Import drm UAPI headers.

Petri Latvala writes: > On Sat, Nov 11, 2017 at 12:27:15AM +, Lionel Landwerlin wrote: >> Hey Eric, >> >> Like it did for Mesa I think this makes developers' lives easier. >> Not having to update libdrm and then compile against the right version just >> for the

Re: [Intel-gfx] [PATCH i-g-t 2/5] tests: Convert to using the imported drm-uapi headers.

Lionel Landwerlin <lionel.g.landwer...@intel.com> writes: > On 10/11/17 21:26, Eric Anholt wrote: >> Tested by dropping garbage in my libdrm's headers and rebuilding. >> >> Signed-off-by: Eric Anholt <e...@anholt.net> >> --- >> lib/Makef

[Intel-gfx] [PATCH i-g-t 2/5] tests: Convert to using the imported drm-uapi headers.

Tested by dropping garbage in my libdrm's headers and rebuilding. Signed-off-by: Eric Anholt <e...@anholt.net> --- lib/Makefile.am | 5 - meson.build | 2 +- tests/Makefile.am | 1 + 3 files changed, 6 insertions(+), 2 deletions(-) diff --git a/lib/Makefile.am b/lib/Makef

[Intel-gfx] [PATCH i-g-t 5/5] lib: Use drm-uapi/i915_drm.h instead of local defines.

The MMAP_V2 is replaced by just using MMAP, since the official header has the updated struct. The gem_create_v2 and gem_get_aperture are left as is, because they seem to not be reflected in the UABI header! Signed-off-by: Eric Anholt <e...@anholt.net> --- benchmarks/Makefile.a

[Intel-gfx] [PATCH i-g-t 4/5] lib: Use the imported uapi's addfb2 defines.

Signed-off-by: Eric Anholt <e...@anholt.net> --- lib/ioctl_wrappers.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/ioctl_wrappers.c b/lib/ioctl_wrappers.c index 7ad2b7b007c4..d98e7660a96f 100644 --- a/lib/ioctl_wrappers.c +++ b/lib/ioctl_wrappers.c @@ -

[Intel-gfx] [PATCH i-g-t 3/5] tests: Remove libdrm_vc4 dependency.

The autotools build retains the configure.ac option, while meson folds vc4 into the default build since we don't have any meson_options.txt to control parts of the build. Signed-off-by: Eric Anholt <e...@anholt.net> --- configure.ac | 12 lib/Makefile.am | 2 +

[Intel-gfx] [PATCH i-g-t 0/5] Import drm UAPI headers.

* define hacks that have been proliferating in the tree) I started on converting i915 to not use LOCAL_*, but it's more than I'm willing to complete. Eric Anholt (5): headers: Import drm-next uapi headers. tests: Convert to using the imported drm-uapi headers. tests: Remove libdrm_vc4

Re: [Intel-gfx] [PATCH] drm/edid: Don't send non-zero YQ in AVI infoframe for HDMI 1.x sinks

Daniel Vetter <dan...@ffwll.ch> writes: > On Wed, Nov 08, 2017 at 02:21:08PM -0800, Eric Anholt wrote: >> Ville Syrjälä <ville.syrj...@linux.intel.com> writes: >> >> > On Wed, Nov 08, 2017 at 12:17:28PM -0800, Eric Anholt wrote: >> >> Vill

Re: [Intel-gfx] [PATCH] drm/edid: Don't send non-zero YQ in AVI infoframe for HDMI 1.x sinks

Ville Syrjälä <ville.syrj...@linux.intel.com> writes: > On Wed, Nov 08, 2017 at 12:17:28PM -0800, Eric Anholt wrote: >> Ville Syrjala <ville.syrj...@linux.intel.com> writes: >> >> > From: Ville Syrjälä <ville.syrj...@linux.intel.com> >> > >&

Re: [Intel-gfx] [PATCH] drm/edid: Don't send non-zero YQ in AVI infoframe for HDMI 1.x sinks

> > The alternative would of course be to always set YQ=0. And if > we ever encounter a HDMI 2.0+ sink with this bug that's what > we'll probably have to do. Should vc4 be doing anything special for HDMI2 sinks, if it's an HDMI1.4 source? That said, as far as vc4, this patch is Acked-by: Eri

Re: [Intel-gfx] [maintainer-tools PATCH] dim: Sign commits in addition to tags

Sean Paul writes: > On Wed, Nov 1, 2017 at 7:12 AM, Gustavo Padovan wrote: >> 2017-10-31 Sean Paul : >> >>> On Tue, Oct 31, 2017 at 1:31 PM, Daniel Vetter wrote: >>> > On Tue, Oct 31, 2017 at 5:14 PM, Sean Paul

Re: [Intel-gfx] [PATCH 6/7] drm/drivers: drop redundant drm_edid_to_eld() calls

d_modes() call. Nice! For vc4, Acked-by: Eric Anholt <e...@anholt.net> signature.asc Description: PGP signature ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH i-g-t v2 3/3] igt: Add VC4 purgeable BO tests

Boris Brezillon writes: > Signed-off-by: Boris Brezillon I got a build error without including . Rebased branch with that changed is "purgeable" in my tree. signature.asc Description: PGP signature

[Intel-gfx] [PATCH i-g-t 1/3] Fix rlim_cur compiler warnings when building on ARM.

Signed-off-by: Eric Anholt <e...@anholt.net> --- benchmarks/prime_lookup.c | 2 +- tests/gem_exec_reuse.c| 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/benchmarks/prime_lookup.c b/benchmarks/prime_lookup.c index e995b766a173..d6c397299fcb 100644 --- a/benc

[Intel-gfx] [PATCH i-g-t 2/3] meson: Fix build of igt_x86-using tests on non-x86 platforms.

Just stub out the features return value, and return an empty string. Signed-off-by: Eric Anholt <e...@anholt.net> --- lib/igt_x86.h | 12 lib/meson.build | 5 - 2 files changed, 16 insertions(+), 1 deletion(-) diff --git a/lib/igt_x86.h b/lib/igt_x86.h index 589d22

[Intel-gfx] [PATCH i-g-t 3/3] meson: Disable the intel overlay on non-x86 builds.

It's got calls to rmb/wmb that end up not linking successfully. Signed-off-by: Eric Anholt <e...@anholt.net> --- meson.build | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/meson.build b/meson.build index 1cc501f3062f..7a09228292fd 100644 --- a/meson.build

Re: [Intel-gfx] [PATCH i-g-t 2/2] igt: Add VC4 purgeable BO tests

Boris Brezillon writes: > Signed-off-by: Boris Brezillon Another test we should have: Queue up a big rendering job (Copy a 2048x2048@32bpp BO?), mark the source purgeable, force the purge, wait for rendering, make sure we

Re: [Intel-gfx] [PATCH i-g-t 2/2] igt: Add VC4 purgeable BO tests

Boris Brezillon writes: > On Wed, 27 Sep 2017 13:50:30 +0100 > Chris Wilson wrote: > >> Quoting Boris Brezillon (2017-09-27 13:41:41) >> > Hi Chris, >> > >> > On Wed, 27 Sep 2017 13:07:28 +0100 >> > Chris Wilson

Re: [Intel-gfx] [PATCH i-g-t 05/12] tests/gem_spin_batch: Fix warning

Daniel Vetter <daniel.vet...@ffwll.ch> writes: > Signed-off-by: Daniel Vetter <daniel.vet...@ffwll.ch> 1-5 are: Reviewed-by: Eric Anholt <e...@anholt.net> My meson branch has some stuff you probably want to squash into your meson build system commit. signature.asc Descr

[Intel-gfx] [PATCH i-g-t 1/3] Use PATH_MAX to fix some sprintf-into-short-buffers warnings.

Signed-off-by: Eric Anholt <e...@anholt.net> --- This little series cleans up many compiler warnings I saw when testing danvet's meson branch. lib/igt_debugfs.c | 4 ++-- lib/igt_sysfs.c | 4 ++-- tests/kms_hdmi_inject.c | 2 +- tests/pm_rpm.c | 4 ++-- 4 files chan

[Intel-gfx] [PATCH i-g-t 3/3] intel_display_poller: Fix truncation of a test name.

Signed-off-by: Eric Anholt <e...@anholt.net> --- tools/intel_display_poller.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/intel_display_poller.c b/tools/intel_display_poller.c index c501c79d6367..828ca52b35ee 100644 --- a/tools/intel_display_poller.c +++ b

[Intel-gfx] [PATCH i-g-t 2/3] intel_watermark: Fix a warning about "const char" return being silly.

Signed-off-by: Eric Anholt <e...@anholt.net> --- tools/intel_watermark.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/intel_watermark.c b/tools/intel_watermark.c index d98ef19b0abd..d8c784802c5b 100644 --- a/tools/intel_watermark.c +++ b/tools/intel_water

Re: [Intel-gfx] [PATCH i-g-t] CONTRIBUTING: formalize review rules

. > + In this case patches must still be submitted to the mailing list first. > + Testcase should preferrably be cross-reviewed by the same people who write > and > + review the kernel feature itself. Thanks for considering my case here :) Acked-by: Eric Anholt <e...@anholt.net> signature.asc Description: PGP signature ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] [PATCH i-g-t] vc4: Test setting labels of BOs.

So far this test is basically making sure that we throw appropriate errors, and don't oops the kernel with silly inputs. Signed-off-by: Eric Anholt <e...@anholt.net> --- tests/Makefile.am | 2 ++ tests/Makefile.sources | 1 + tests/vc4_label_bo.c

[Intel-gfx] [PATCH v2 6/6 squash] drm/vc4: Fixup for the drm core async changes.

With this squashed in, the vc4 patch is: Reviewed-by: Eric Anholt <e...@anholt.net> Signed-off-by: Eric Anholt <e...@anholt.net> --- Without this, the cursor never moved :) drivers/gpu/drm/vc4/vc4_plane.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/vc4/v

[Intel-gfx] [PATCH i-g-t] Make autogen.sh set the default format.subjectPrefix

CONTRIBUTING requests that people do this, but it's a lot easier if we just set it up by default for them. Signed-off-by: Eric Anholt <e...@anholt.net> --- I missed this step on my previous two patches, so let's just prevent that in the future. :( autogen.sh | 3 +++ 1 file chan

[Intel-gfx] [PATCH 2/2] igt/vc4_tiling: Test vc4's new set/get_tiling ioctls.

, so no need to test that. Signed-off-by: Eric Anholt <e...@anholt.net> --- lib/igt_vc4.c | 21 lib/igt_vc4.h | 3 ++ tests/Makefile.am | 2 + tests/Makefile.sources | 1 + tests/vc4_tiling.c | 137 + 5

[Intel-gfx] [PATCH 1/2] Add an editorconfig file for the basics of igt style.

This makes my emacs default to consistent indentation for the project. Signed-off-by: Eric Anholt <e...@anholt.net> --- .editorconfig | 9 + 1 file changed, 9 insertions(+) create mode 100644 .editorconfig diff --git a/.editorconfig b/.editorconfig new file mode 100644

Re: [Intel-gfx] [PATCH igt] igt/vc4_dmabuf_poll: Add a test for polling to wait for dmabuf fences.

Daniel Vetter <dan...@ffwll.ch> writes: > On Mon, Apr 10, 2017 at 06:24:32PM -0700, Eric Anholt wrote: >> This successfully catches vc4's lack of dmabuf fencing. >> >> Signed-off-by: Eric Anholt <e...@anholt.net> >> --- >> >> Has anyone looke

Re: [Intel-gfx] [PATCH RESEND 1/6] drm/atomic: initial support for asynchronous plane update

return false; > + Could you add a comment here like: /* Don't do an async update if there is an outstanding commit modifying * the plane. This prevents our async update's changes from getting * overridden by a previous synchronous update's state. */ (assuming I understand its inten

Re: [Intel-gfx] [PATCH RESEND 6/6] drm/vc4: update cursors asynchronously through atomic

t; vc4_update_plane() did but through atomic. > > v3: move size checks back to drivers (Ville Syrjälä) > > v2: move fb setting to core and use new state (Eric Anholt) Given that vc4 isn't using drm_atomic_helper_commit(), isn't this effectively disabling async cursor updates o

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Deal with upside-down mounted LCD panels

Hans de Goede writes: > HI, > > On 08-05-17 14:27, Chris Wilson wrote: >> On Sun, May 07, 2017 at 11:10:56AM +0200, Hans de Goede wrote: >>> On some (Bay Trail) devices the LCD panel is mounted upside-down. >>> >>> This commit uses the code to read back the initial rotation

Re: [Intel-gfx] [PATCH] drm: Document code of conduct

commit/?id=0eefe99fe0683ae409b665a8b18cc7eb648c6c0c With the other wording nitpicks fixed, Reviewed-by: Eric Anholt <e...@anholt.net> I'm pleased to be part of a community that's working on building an inclusive, welcoming, productive environment. signature.asc Description: PGP signature

[Intel-gfx] [PATCH igt] igt/vc4_dmabuf_poll: Add a test for polling to wait for dmabuf fences.

This successfully catches vc4's lack of dmabuf fencing. Signed-off-by: Eric Anholt <e...@anholt.net> --- Has anyone looked into shared infrastructure for tests to do KMS/dmabuf/etc. things with a generic "get a BO that's being rendered to for this driver" call? tests/Makefi

Re: [Intel-gfx] [PATCH 12/15] drm: Add acquire ctx to ->gamma_set hook

Daniel Vetter writes: > Atomic helpers really want this instead of the hacked-up legacy > backoff trick, which unfortunately prevents drivers from using their > own private drm_modeset_locks. > > Aside: There's a few atomic drivers (nv50, vc4, soon vmwgfx) which > don't

Re: [Intel-gfx] [PATCH 2/5] drm/edid: Introduce drm_default_rgb_quant_range()

ville.syrj...@linux.intel.com writes: > From: Ville Syrjälä > > Make the code selecting the RGB quantization range a little less magicy > by wrapping it up in a small helper. This series seems good. I won't have the ability to test it on vc4 within a reasonable

  1   2   3   4   5   6   >