Re: [Intel-gfx] [PATCH libdrm] intel: drm_intel_bo_gem_create_from_* on platforms w/o HW tiling

t = drmIoctl(bufmgr_gem->fd, > +DRM_IOCTL_I915_GEM_GET_TILING, > +_tiling); You're missing `get_tiling.handle = gem_handle;` Or better yet, just initialise `get_tiling` and get rid of the memclear(): struct drm_i915_gem_get_tiling get_tiling = { .handle = gem_hand

Re: [Intel-gfx] [PATCH v3] drm/print: add drm_debug_enabled()

r conditions (Eric) > > Cc: Eric Engestrom Reviewed-by: Eric Engestrom > Acked-by: Alex Deucher > Signed-off-by: Jani Nikula > --- > drivers/gpu/drm/drm_atomic_uapi.c | 2 +- > drivers/gpu/drm/drm_dp_mst_topology.c | 6 +++--- > drivers/gpu/drm/drm_edid.c

Re: [Intel-gfx] [PATCH v2 0/9] drm/print: add and use drm_debug_enabled()

On Tuesday, 2019-10-01 14:03:55 +0300, Jani Nikula wrote: > On Thu, 26 Sep 2019, Eric Engestrom wrote: > > On Tuesday, 2019-09-24 15:58:56 +0300, Jani Nikula wrote: > >> Hi all, v2 of [1], a little refactoring around drm_debug access to > >> abstract it better. There

Re: [Intel-gfx] [PATCH v2 0/9] drm/print: add and use drm_debug_enabled()

to that, we'll need to postpone the last patch until > everything has been merged and converted in drm-next. > > BR, > Jani. > > Cc: Eric Engestrom > Cc: Alex Deucher > Cc: Christian König > Cc: David (ChunMing) Zhou > Cc: amd-...@lists.freedesktop.org > Cc: Ben

Re: [Intel-gfx] [PATCH 2/9] drm/print: add drm_debug_enabled()

On Monday, 2019-09-16 16:23:13 +0300, Jani Nikula wrote: > On Mon, 16 Sep 2019, Eric Engestrom wrote: > > On Monday, 2019-09-16 11:53:24 +0300, Jani Nikula wrote: > >> On Fri, 13 Sep 2019, Eric Engestrom wrote: > >> > On Friday, 2019-09-13 14:51:39 +0300, Jani Ni

Re: [Intel-gfx] [PATCH 2/9] drm/print: add drm_debug_enabled()

On Monday, 2019-09-16 11:53:24 +0300, Jani Nikula wrote: > On Fri, 13 Sep 2019, Eric Engestrom wrote: > > On Friday, 2019-09-13 14:51:39 +0300, Jani Nikula wrote: > >> Add helper to check if a drm debug category is enabled. Convert drm core > >> to use it. No functional

Re: [Intel-gfx] [PATCH 2/9] drm/print: add drm_debug_enabled()

On Friday, 2019-09-13 14:51:39 +0300, Jani Nikula wrote: > Add helper to check if a drm debug category is enabled. Convert drm core > to use it. No functional changes. > > Signed-off-by: Jani Nikula > --- > drivers/gpu/drm/drm_atomic_uapi.c | 2 +- > drivers/gpu/drm/drm_dp_mst_topology.c |

Re: [Intel-gfx] [PATCH] drm/todo: Update drm_gem_object_funcs todo even more

On Tuesday, 2019-06-18 16:02:41 +0200, Daniel Vetter wrote: > I rushed merging this a bit too much, and Noralf pointed out that > we're a lot better already and have made great progress. > > Let's try again. > > Fixes: 42dbbb4b54a3 ("drm/todo: Add new debugfs todo") > Cc: Greg Kroah-Hartman >

Re: [Intel-gfx] [PATCH libdrm] headers: Sync with drm-next

On Wednesday, 2019-04-10 21:49:33 -0400, Rob Clark wrote: > On Tue, Apr 9, 2019 at 8:27 AM Eric Engestrom > wrote: > > > > diff --git a/include/drm/msm_drm.h b/include/drm/msm_drm.h > > > > index c06d0a5..91a16b3 100644 > > > > --- a/include/drm/msm

Re: [Intel-gfx] [PATCH libdrm] headers: Sync with drm-next

On Tuesday, 2019-04-09 12:59:13 +0100, Eric Engestrom wrote: > On Tuesday, 2019-04-09 11:35:14 +, Ayan Halder wrote: > > Generated using make headers_install from the drm-next > > tree - git://anongit.freedesktop.org/drm/drm > > branch

Re: [Intel-gfx] [PATCH libdrm] headers: Sync with drm-next

> > msm: > - Added various get or set GEM buffer info flags > - Added some MSM_SUBMIT_BO_ macros > - Modified 'struct drm_msm_gem_info' > > Signed-off-by: Ayan Kumar halder This looks sane, and applies cleanly :) Acked-by: Eric Engestrom

Re: [Intel-gfx] [PATCH libdrm] headers: Sync with drm-next

On Monday, 2019-04-08 13:44:17 +, Ayan Halder wrote: > Generated using make headers_install from the drm-next > tree - git://anongit.freedesktop.org/drm/drm > branch - drm-next > commit - 14d2bd53a47a7e1cb3e03d00a6b952734cf90f3f > > The changes were as follows :- > > core: (drm.h,

[Intel-gfx] [PATCH 2/2] i915: rename modifiers to follow the naming convention

$ sed -i s/I915_FORMAT_MOD_/DRM_FORMAT_MOD_INTEL_/g $(git grep -l I915_FORMAT_MOD_) $ git checkout include/uapi/drm/drm_fourcc.h Signed-off-by: Eric Engestrom --- drivers/gpu/drm/i915/intel_atomic_plane.c | 12 +- drivers/gpu/drm/i915/intel_display.c | 128 +++--- drivers

Re: [Intel-gfx] [Mesa-dev] [PATCH libdrm] Add basic CONTRIBUTING file

On Tuesday, 2018-09-04 16:24:44 +1000, Dave Airlie wrote: > On Mon, 3 Sep 2018 at 18:47, Daniel Vetter wrote: > > > > I picked up a bunch of the pieces from wayland's version: > > > > https://gitlab.freedesktop.org/wayland/wayland/blob/master/CONTRIBUTING.md > > > > The weston one is fairly

Re: [Intel-gfx] [PATCH 04/12] cpufreq: use for_each_if

On Monday, 2018-07-09 10:36:42 +0200, Daniel Vetter wrote: > Avoids the inverted condition compared to the open coded version. > > Signed-off-by: Daniel Vetter > Cc: "Rafael J. Wysocki" > Cc: Viresh Kumar > Cc: linux...@vger.kernel.org > --- > include/linux/cpufreq.h | 8 ++-- > 1 file

[Intel-gfx] [maintainer-tools PATCH 6/7] dim: split out 'is email cc'ed in latest commit' to a function

Signed-off-by: Eric Engestrom <eric.engest...@imgtec.com> --- dim | 46 ++ 1 file changed, 26 insertions(+), 20 deletions(-) diff --git a/dim b/dim index 481a53e23035..2e22fefa8867 100755 --- a/dim +++ b/dim @@ -1970,6 +1970,31 @@ fu

[Intel-gfx] [maintainer-tools PATCH 7/7] dim: protect against escaped chars when reading cc'ed emails

Suggested by shellcheck (`make check`). Signed-off-by: Eric Engestrom <eric.engest...@imgtec.com> --- dim | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dim b/dim index 2e22fefa8867..75ce55188af4 100755 --- a/dim +++ b/dim @@ -2002,7 +2002,7 @@ function dim_add_miss

[Intel-gfx] [maintainer-tools PATCH 3/7] dim: split out email parsing functions

Signed-off-by: Eric Engestrom <eric.engest...@imgtec.com> --- dim | 18 ++ 1 file changed, 14 insertions(+), 4 deletions(-) diff --git a/dim b/dim index eaabcec43c8f..a656afa0d255 100755 --- a/dim +++ b/dim @@ -1958,6 +1958,16 @@ function dim_fixes fi } +fu

[Intel-gfx] [maintainer-tools PATCH 4/7] dim: merge string substitutions

Signed-off-by: Eric Engestrom <eric.engest...@imgtec.com> --- dim | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dim b/dim index a656afa0d255..4ffac497c621 100755 --- a/dim +++ b/dim @@ -1965,7 +1965,7 @@ function email_get_address function email_get_name { -

[Intel-gfx] [maintainer-tools PATCH 5/7] dim: move empty name logic to function

Fair warning: this slightly changes the behaviour, as $testname would previously contain the email if $testcc didn't contain a name. Shouldn't affect anything though. Signed-off-by: Eric Engestrom <eric.engest...@imgtec.com> --- dim | 10 -- 1 file changed, 4 insertions(+), 6 del

[Intel-gfx] [maintainer-tools PATCH 2/7] dim: fix end-of-line in regex

Signed-off-by: Eric Engestrom <eric.engest...@imgtec.com> --- dim | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/dim b/dim index af1baa11c7b2..eaabcec43c8f 100755 --- a/dim +++ b/dim @@ -1970,7 +1970,7 @@ function dim_add_missing_cc

[Intel-gfx] [maintainer-tools PATCH 1/7] dim: don't run add-missing-cc on merge commits

get_maintainer.pl needs a diff, so this script can't run on a merge commit. Signed-off-by: Eric Engestrom <eric.engest...@imgtec.com> --- dim | 5 + 1 file changed, 5 insertions(+) diff --git a/dim b/dim index 619d855b321b..af1baa11c7b2 100755 --- a/dim +++ b/dim @@ -1960,6 +1

[Intel-gfx] [PATCH maintainer-tools 1/3] make: run check on current `dim`, not the installed one

Signed-off-by: Eric Engestrom <eric.engest...@imgtec.com> --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index b4cea98..4291049 100644 --- a/Makefile +++ b/Makefile @@ -33,7 +33,7 @@ shellcheck: shellcheck $(SC_EXCLUD

[Intel-gfx] [PATCH maintainer-tools 3/3] dim.rst: update CONTRIBUTING instructions

Suggest using git-config instead of a flag on format-patch. While at it, use the more common "PATCH foo" subject prefix. Signed-off-by: Eric Engestrom <eric.engest...@imgtec.com> --- dim.rst | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/dim.rst b/dim.r

[Intel-gfx] [PATCH maintainer-tools 2/3] dim: send 'not configured' error to stderr

This fixes `make check` when dim is not configured. Signed-off-by: Eric Engestrom <eric.engest...@imgtec.com> --- dim | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dim b/dim index 588e859..b373901 100755 --- a/dim +++ b/dim @@ -197,7 +197,7 @@ export __dim_run

Re: [Intel-gfx] [PATCH 1/3] drm: Document maintainer duties

On Monday, 2017-03-27 10:45:44 +0200, Daniel Vetter wrote: > I wanted to get Sean Paul to run the drm-misc show for a bit, for > training reasons and to increase the bus factor. And then realized > there's no docs about what maintainers are doing. > > Fix that. > > v2: Add backmerges and taking

Re: [Intel-gfx] [PATCH i-g-t v1] lib/drmtest: Add comment explaining DRIVER_ANY excluding DRIVER_VGEM

vgem as well as a supported driver, you can end up with a > + * near-100% skip rate if you don't explicitly specify the device, > + * depending on device-load ordering. > + */ > #define DRIVER_ANY ~(DRIVER_VGEM) Brilliant, cheers :) Reviewed-by: Eric Engestrom <eric.engest.

Re: [Intel-gfx] [PATCH i-g-t] lib/drmtest: make DRIVER_ANY match any driver

On Monday, 2017-01-30 11:50:52 +, Daniel Stone wrote: > Hi, > > On 30 January 2017 at 11:46, Petri Latvala wrote: > > NAK. > > > > DRIVER_VGEM is omitted from DRIVER_ANY intentionally. Vgem is unable > > to modeset, unable to render, practically it only supports the

Re: [Intel-gfx] [PATCH 15/15] drm: Update kerneldoc for drm_crtc.[hc]

e, nowadays extensions to the KMS > + * userspace interface should be done using _property. > + */ > static inline struct drm_crtc *drm_crtc_find(struct drm_device *dev, > uint32_t id) > { > @@ -841,6 +847,13 @@ static inline struct drm_crtc *drm_crtc_find(struct > drm_device *dev, >

Re: [Intel-gfx] [PATCH 03/15] drm/kms-core: Use recommened kerneldoc for struct member refs

On Wednesday, 2017-01-25 07:26:45 +0100, Daniel Vetter wrote: > I just learned that _name.member_name works and looks pretty > even. It doesn't (yet) link to the member directly though, which would > be really good for big structures or vfunc tables (where the > per-member kerneldoc tends to be

[Intel-gfx] [PATCH i-g-t] lib/drmtest: make DRIVER_ANY match any driver

Signed-off-by: Eric Engestrom <eric.engest...@imgtec.com> --- Not tested or anything, I just happened to notice this code and it looked wrong, but maybe I misunderstood what it was meant to do. An alternative would be to just set the bits the the drivers that are defined already, but that

Re: [Intel-gfx] [PATCH v4] drm: add fourcc codes for 16bit R and RG

On Wednesday, 2017-01-04 14:50:02 +0100, Rainer Hochecker wrote: > From: Rainer Hochecker > > Signed-off-by: Rainer Hochecker > --- > include/uapi/drm/drm_fourcc.h | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git

Re: [Intel-gfx] [PATCH v2] drm: add fourcc codes for 16bit R and GR

On Wednesday, 2017-01-04 11:06:09 +0200, Jani Nikula wrote: > On Wed, 04 Jan 2017, Daniel Vetter wrote: > > On Tue, Jan 03, 2017 at 08:02:07PM +0100, Rainer Hochecker wrote: > >> From: Rainer Hochecker > >> > >> Now sent with git send-email: > >> > >>

Re: [Intel-gfx] [PATCH] drm: add fourcc codes for 16bit R and GR

On Tuesday, 2017-01-03 17:56:10 +0100, Rainer Hochecker wrote: > On Mon, Jan 2, 2017 at 3:31 PM, Rainer Hochecker wrote: > > > > I chose GR16 because that matches with Mesa texture formats. Unfortunately > > RG16 is already taken by DRM_FORMAT_RGB565 > > So GR32 / RG32 might

Re: [Intel-gfx] [PATCH] drm: Don't block the kworker waiting for mode_config.lock in output_poll()

he system is deadlocked, but it will also lessen > the load (in such extreme cases). > > Signed-off-by: Chris Wilson <ch...@chris-wilson.co.uk> Reviewed-by: Eric Engestrom <eric.engest...@imgtec.com> > --- > drivers/gpu/drm/drm_probe_helper.c | 6 +- > 1 file changed, 5

[Intel-gfx] [PATCH] drm/i915/gvt: fix deadlock in dispatch_workload()'s error path

90d27a1 moved the lock before this error path but forgot to add an unlock here. Fixes: 90d27a1b180e51ef0713 ("drm/i915/gvt: fix deadlock in workload_thread") Cc: Pei Zhang <pei.zh...@intel.com> Cc: Zhenyu Wang <zhen...@linux.intel.com> Signed-off-by: Eric Engest

[Intel-gfx] [PATCH v4] drm: move allocation out of drm_get_format_name()

<robdcl...@gmail.com> Acked-by: Sinclair Yeh <s...@vmware.com> (vmwgfx) Reviewed-by: Jani Nikula <jani.nik...@intel.com> Suggested-by: Ville Syrjälä <ville.syrj...@linux.intel.com> Signed-off-by: Eric Engestrom <e...@engestrom.ch> --- v4 - rebase on drm-next (d8c1abd968f

Re: [Intel-gfx] [PATCH v3] drm: move allocation out of drm_get_format_name()

On Wednesday, 2016-11-09 14:13:40 +0100, Daniel Vetter wrote: > On Wed, Nov 9, 2016 at 12:42 PM, Eric Engestrom > <eric.engest...@imgtec.com> wrote: > >> Well, had to drop it again since it didn't compile: > >> > >> > >> CC [M] drivers/gpu/d

Re: [Intel-gfx] [PATCH v3] drm: move allocation out of drm_get_format_name()

On Wednesday, 2016-11-09 02:13:25 +0100, Daniel Vetter wrote: > On Wed, Nov 09, 2016 at 02:09:16AM +0100, Daniel Vetter wrote: > > On Wed, Nov 09, 2016 at 12:17:52AM +0000, Eric Engestrom wrote: > > > The function's behaviour was changed in 90844f00049e, without changing &

[Intel-gfx] [PATCH v3] drm: move allocation out of drm_get_format_name()

<robdcl...@gmail.com> Acked-by: Sinclair Yeh <s...@vmware.com> (vmwgfx) Reviewed-by: Jani Nikula <jani.nik...@intel.com> Suggested-by: Ville Syrjälä <ville.syrj...@linux.intel.com> Signed-off-by: Eric Engestrom <e...@engestrom.ch> --- v3 - fix "Fixes" tag, repla

Re: [Intel-gfx] [PATCH v2] drm: move allocation out of drm_get_format_name()

On Monday, 2016-11-07 10:10:13 +0200, Jani Nikula wrote: > On Mon, 07 Nov 2016, Eric Engestrom <e...@engestrom.ch> wrote: > > Fixes: 90844f00049e9f42573fd31d7c32e8fd31d3fd07 > > > > drm: make drm_get_format_name thread-safe > > > > Signed-of

[Intel-gfx] [PATCH v2] drm: move allocation out of drm_get_format_name()

Fixes: 90844f00049e9f42573fd31d7c32e8fd31d3fd07 drm: make drm_get_format_name thread-safe Signed-off-by: Eric Engestrom <e...@engestrom.ch> [danvet: Clarify that the returned pointer must be freed with kfree().] Signed-off-by: Daniel Vetter <daniel.vet...@ffwll.ch&

Re: [Intel-gfx] [PATCH] drm: move allocation out of drm_get_format_name()

On Sunday, 2016-11-06 08:03:47 -0500, Rob Clark wrote: > On Sun, Nov 6, 2016 at 4:47 AM, Christian König > <christian.koe...@amd.com> wrote: > > Am 05.11.2016 um 17:49 schrieb Rob Clark: > >> > >> On Sat, Nov 5, 2016 at 12:38 PM, Eric Engestrom <e...@enges

Re: [Intel-gfx] [PATCH] drm: move allocation out of drm_get_format_name()

On Saturday, 2016-11-05 13:11:36 +0100, Christian König wrote: > Am 05.11.2016 um 02:33 schrieb Eric Engestrom: > > +typedef char drm_format_name_buf[32]; > > Please don't use a typedef for this, just define the maximum size of > characters the function might write somewhere. &

[Intel-gfx] [PATCH] drm: move allocation out of drm_get_format_name()

Fixes: 90844f00049e9f42573fd31d7c32e8fd31d3fd07 drm: make drm_get_format_name thread-safe Signed-off-by: Eric Engestrom <e...@engestrom.ch> [danvet: Clarify that the returned pointer must be freed with kfree().] Signed-off-by: Daniel Vetter <daniel.vet...@ffwll.ch>

Re: [Intel-gfx] [PATCH] i915: don't call drm_atomic_state_put on invalid pointer

> Fixes: 0853695c3ba4 ("drm: Add reference counting to drm_atomic_state") > Cc: Chris Wilson <ch...@chris-wilson.co.uk> > Cc: Daniel Vetter <daniel.vet...@ffwll.ch> > Signed-off-by: Arnd Bergmann <a...@arndb.de> Reviewed-by: Eric Engestrom <eric.engest.

Re: [Intel-gfx] [patch] drm/i915: fix a read size argument

fe5a66f91c88 ("drm/i915: Read PSR caps/intermediate freqs/etc. only > once on eDP") > Signed-off-by: Dan Carpenter <dan.carpen...@oracle.com> Good catch! What tool did you use to find it, or did you find it by inspection? Reviewed-by: Eric Engestrom <eric.engest...@i

Re: [Intel-gfx] [PATCH v5 1/4] drm: two more (drm_)printk() wrapper macros

e additional levels. We don't provide _DEV_ or _ONCE or RATELIMITED > versions yet as it seems unlikely that they'll be as useful. > > v2: > Fix whitespace, missing ## (Eric Engestrom) > v5: > Much simplified after underlying functions were reworked. > > Sig

Re: [Intel-gfx] [PATCH v2] drm: Add reference counting to drm_atomic_state

drm_atomic_state_free - free all memory for an atomic state > + * __drm_atomic_state_free - free all memory for an atomic state > * @state: atomic state to deallocate Doc line needs updating as well. Other than that, this looks good to me: Reviewed-by: Eric Engestrom <eric.engest...@imgtec

Re: [Intel-gfx] [Mesa-dev] [PATCH v1 00/13] Implement sw_sync test

c.c > create mode 100644 lib/sw_sync.h > create mode 100644 tests/sw_sync.c > > -- > 2.7.4 Thanks for your work! I sent some specific comments directly to a few patches, but everything else looks good to me. With the issues raised in patches

Re: [Intel-gfx] [Mesa-dev] [PATCH v1 11/13] tests/sw_sync: Add subtest test_sync_random_merge

On Tue, Aug 23, 2016 at 01:56:13PM -0400, robert.f...@collabora.com wrote: > From: Robert Foss > > This subtest verifies that creating many timelines and merging random fences > from each timeline with eachother results in merged fences that are fully > functional. >

Re: [Intel-gfx] [Mesa-dev] [PATCH v1 02/13] tests/sw_sync: Add sw_sync test

On Tue, Aug 23, 2016 at 01:56:04PM -0400, robert.f...@collabora.com wrote: > From: Robert Foss > > Add initial tests for sw_sync. > > Signed-off-by: Gustavo Padovan > Signed-off-by: Robert Foss > --- >

Re: [Intel-gfx] [Mesa-dev] [PATCH v1 01/13] lib/sw_sync: Add helper functions for managing synchronization primitives

On Tue, Aug 23, 2016 at 01:56:03PM -0400, robert.f...@collabora.com wrote: > From: Robert Foss > > Base functions to help testing the Sync File Framework (explicit fencing > mechanism ported from Android). > These functions allow you to create, use and destroy

[Intel-gfx] [FIXUP] drm: remove `const` attribute to hint at caller that they now own the memory

Signed-off-by: Eric Engestrom <eric.engest...@imgtec.com> --- drivers/gpu/drm/amd/amdgpu/dce_v10_0.c | 2 +- drivers/gpu/drm/amd/amdgpu/dce_v11_0.c | 2 +- drivers/gpu/drm/amd/amdgpu/dce_v8_0.c | 2 +- drivers/gpu/drm/drm_atomic.c| 2 +- drive

Re: [Intel-gfx] [PATCH] drm: make drm_get_format_name thread-safe

On Mon, Aug 15, 2016 at 03:52:07PM +0200, Daniel Vetter wrote: > On Mon, Aug 15, 2016 at 04:13:54PM +0300, Jani Nikula wrote: > > On Mon, 15 Aug 2016, Eric Engestrom <eric.engest...@imgtec.com> wrote: > > > On Mon, Aug 15, 2016 at 12:54:01PM +0300, Jani Nikula wrote: &g

Re: [Intel-gfx] [PATCH] drm: make drm_get_format_name thread-safe

On Mon, Aug 15, 2016 at 12:54:01PM +0300, Jani Nikula wrote: > On Mon, 15 Aug 2016, Eric Engestrom <e...@engestrom.ch> wrote: > > Signed-off-by: Eric Engestrom <e...@engestrom.ch> > > --- > > > > I moved the main bits to be the first diffs, shouldn't affe

[Intel-gfx] [PATCH] drm: make drm_get_format_name thread-safe

Signed-off-by: Eric Engestrom <e...@engestrom.ch> --- I moved the main bits to be the first diffs, shouldn't affect anything when applying the patch, but I wanted to ask: I don't like the hard-coded `32` the appears in both kmalloc() and snprintf(), what do you think? If you don't like it

Re: [Intel-gfx] [PATCH 1/3] drm: extra printk() wrapper macros

O_ONCE(fmt, ...) > \ > + _DRM_PRINTK(_once, INFO, fmt, __VA_ARGS__) Missing ## here; should be: ##__VA_ARGS__ The rest looks good. Reviewed-by: Eric Engestrom <eric.engest...@imgtec.com> > +#defi

Re: [Intel-gfx] [PATCH] drm: Prevent NULL deref in drm_name_info()

: Chris Wilson <ch...@chris-wilson.co.uk> > Cc: Daniel Vetter <daniel.vet...@ffwll.ch> Reviewed-by: Eric Engestrom <eric.engest...@imgtec.com> ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH] drm/atomic: Add __drm_atomic_get_current_plane_state

On Thu, Jun 02, 2016 at 04:21:44PM +0200, Daniel Vetter wrote: > ... and use it in msm Again just want to encapsulate > drm_atomic_state internals a bit. > > The const threading is a bit awkward in vc4 since C sucks, but I still > think it's worth to enforce this. Eventually I want to make all

Re: [Intel-gfx] [Mesa-dev] [PATCH v2 mesa] vk/intel: use negative VK_NO_PROTOTYPES scheme

On Sun, May 01, 2016 at 09:39:58PM -0700, Jason Ekstrand wrote: > On May 1, 2016 6:04 PM, "Kenneth Graunke" wrote: > > On Sunday, May 1, 2016 9:51:00 AM PDT Emil Velikov wrote: > > > Adding the anv authors. > > > > > > Jason, Chad, is there a canonical place where changes

Re: [Intel-gfx] [Mesa-dev] [PATCH v2 mesa] vk/intel: use negative VK_NO_PROTOTYPES scheme

On Mon, Apr 25, 2016 at 05:08:18PM +0100, Emil Velikov wrote: > On 21 April 2016 at 11:24, Eric Engestrom <eric.engest...@imgtec.com> wrote: > > Commit 3d0fac7aca237bbe8ed8e2a362d3b42d0ef8c46c changed all the > > VK_PROTOTYPES to VK_NO_PROTOTYPES > > This brin

[Intel-gfx] [PATCH i-g-t 4/5] tests: fix spelling mistakes

Signed-off-by: Eric Engestrom <e...@engestrom.ch> --- tests/gem_concurrent_all.c | 2 +- tests/gem_cpu_reloc.c | 2 +- tests/gem_flink_race.c | 2 +- tests/gem_seqno_wrap.c | 2 +- tests/gem_tiled_wb.c | 2 +- tests/prime_nv_api.c | 2 +- tests/prime_nv_pcopy.c

[Intel-gfx] [PATCH i-g-t 2/5] assembler: fix spelling mistakes

Signed-off-by: Eric Engestrom <e...@engestrom.ch> --- assembler/brw_defines.h| 2 +- assembler/brw_eu_compact.c | 2 +- assembler/brw_eu_emit.c| 4 ++-- assembler/gen4asm.h| 4 ++-- 4 files changed, 6 insertions(+), 6 deletions(-) diff --git a/assembler/brw_defines.h b/ass

[Intel-gfx] [PATCH i-g-t 5/5] tools: fix spelling mistakes

Signed-off-by: Eric Engestrom <e...@engestrom.ch> --- tools/intel_audio_dump.c | 14 +++--- tools/intel_bios.h| 6 +++--- tools/intel_display_poller.c | 2 +- tools/intel_dump_decode.c | 2 +-

[Intel-gfx] [PATCH i-g-t 3/5] lib: fix spelling mistakes

Signed-off-by: Eric Engestrom <e...@engestrom.ch> --- lib/gpgpu_fill.c | 4 ++-- lib/igt_aux.h| 2 +- lib/igt_core.c | 6 +++--- lib/igt_core.h | 4 ++-- lib/intel_reg.h | 2 +- lib/ioctl_wrappers.c | 2 +- lib/media_fill_gen8.c| 2 +

[Intel-gfx] [PATCH i-g-t 1/5] README: fix spelling mistakes

Signed-off-by: Eric Engestrom <e...@engestrom.ch> --- README | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README b/README index d302af3..cfb6ab2 100644 --- a/README +++ b/README @@ -29,7 +29,7 @@ tests/ changes. Many of the tests have subtests, which can be

[Intel-gfx] [PATCH 1/2] drm/i915: remove left over dead code

ae80152ddad252f33893b92dd69f00cc53c5949f ("drm/i915: Rewrite VLV/CHV watermark code") removed everything that would have used those vars. Signed-off-by: Eric Engestrom <eric.engest...@imgtec.com> --- drivers/gpu/drm/i915/intel_pm.c | 14 -- 1 file changed, 14 deletion

[Intel-gfx] [PATCH 2/2] drm/i915: remove dead code

79e539453b34e35f39299a899d263b0a1f1670bd ("DRM: i915: add mode setting support") added those variables but never used them. Signed-off-by: Eric Engestrom <eric.engest...@imgtec.com> --- drivers/gpu/drm/i915/intel_tv.c | 12 1 file changed, 12 deletions(-) diff --g

Re: [Intel-gfx] [PATCH] drm/i915: fix itnull.cocci warnings (fwd)

I expect this is the script she mentions: https://github.com/coccinelle/coccinellery/blob/master/itnull/itnull.cocci Julia is one of the authors of Coccinelle, and the author of that script :) On 18/01/16 17:20, Daniel Vetter wrote: > On Mon, Jan 18, 2016 at 04:49:06PM +0100, Julia Lawall