arma
> ---
>
> Changes in v2:
> - Replace kmap() with kmap_local_page().
> - Change commit subject and message.
With the changes that Ira suggested and the minor fix I'm proposing to the
commit message, it looks good to me too, so this patch is...
Reviewed-by: Fabio M. De Francesco
How
On mercoledì 21 giugno 2023 11:06:51 CEST Thomas Hellström (Intel) wrote:
>
> I think one thing worth mentioning in the context of this patch is that
> IIRC kmap_local_page() will block offlining of the mapping CPU until
> kunmap_local(),
Migration is disabled.
> so while I haven't seen any
the above-mentioned constraint, so it should be
preferred to kmap().
Therefore, replace kmap() with kmap_local_page() in i915/gem and use
memcpy_to_page() where it is possible to avoid the open coding of
mapping + memcpy() + un-mapping.
Suggested-by: Ira Weiny
Signed-off-by: Fabio M. De Francesco
the above-mentioned constraint, so it should be
preferred to kmap().
Therefore, replace kmap() with kmap_local_page() in i915/gt.
Suggested-by: Ira Weiny
Signed-off-by: Fabio M. De Francesco
---
drivers/gpu/drm/i915/gt/intel_ggtt_fencing.c | 4 ++--
drivers/gpu/drm/i915/gt/shmem_utils.c
the above-mentioned constraint, so it should be
preferred to kmap().
Therefore, replace kmap() with kmap_local_page() in i915_gem.c
Suggested-by: Ira Weiny
Signed-off-by: Fabio M. De Francesco
---
drivers/gpu/drm/i915/i915_gem.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff
-by: Fabio M. De Francesco
v1->v2: Do some changes in the text of the cover letter and in the
commit messages. There are no changes in the code of any of the three
patches.
Fabio M. De Francesco (3):
drm/i915: Replace kmap() with kmap_local_page()
drm/i915/gt: Replace kmap() with kmap_local_p
>
> >> Convert the calls of kmap_atomic() / kunmap_atomic() to
> >> kmap_local_page() / kunmap_local().
> >>
> >> [1]:
> >> https://lore.kernel.org/all/20220813220034.806698-1-ira.we...@intel.com
> >>
> >> v2: No code change since v1. Added descript
in full.
I don't see things to improve (except all those "kamp_atomic()" typo in the
patches summary; however, typos are only in the cover so I'm sure they won't
hurt anybody).
Each of the nine patches listed above looks good to me, so they are all…
Reviewed-by: Fabio M. De Francesco
Tha
xplains clearly and the changes to the code look good. The
necessity to reuse pagefault_disable() / pagefault_enable() from the main
kmap_atomic() side effect is a nice catch.
Reviewed-by: Fabio M. De Francesco
Thanks!
> diff --git a/drivers/gpu/drm/i915/gem/i915_gem_shmem.c
> b/drivers/gpu/drm/i915/g
On giovedì 3 novembre 2022 17:51:23 CET Ira Weiny wrote:
> On Sat, Oct 29, 2022 at 01:17:03PM +0200, Fabio M. De Francesco wrote:
> > On lunedì 17 ottobre 2022 11:37:17 CEST Zhao Liu wrote:
> > > From: Zhao Liu
> > >
> > > The use of kmap_a
On lunedì 17 ottobre 2022 22:23:30 CET Patchwork wrote:
> == Series Details ==
>
> Series: drm/i915: Replace kmap() with kmap_local_page() (rev2)
> URL : https://patchwork.freedesktop.org/series/107277/
> State : warning
>
> == Summary ==
>
> Error: dim sparse failed
> Sparse version: v0.6.2
On lunedì 17 ottobre 2022 22:23:30 CET Patchwork wrote:
> == Series Details ==
>
> Series: drm/i915: Replace kmap() with kmap_local_page() (rev2)
> URL : https://patchwork.freedesktop.org/series/107277/
> State : warning
>
> == Summary ==
>
> Error: dim sparse failed
> Sparse version: v0.6.2
On lunedì 17 ottobre 2022 22:34:44 CET Patchwork wrote:
> == Series Details ==
>
> Series: drm/i915: Replace kmap() with kmap_local_page() (rev2)
> URL : https://patchwork.freedesktop.org/series/107277/
> State : success
>
> == Summary ==
>
> CI Bug Log - changes from CI_DRM_12252 ->
local().
>
I have here the same questions as in 1/9.
> [1]: https://lore.kernel.org/all/20220813220034.806698-1-ira.we...@intel.com
>
> Suggested-by: Dave Hansen
> Suggested-by: Ira Weiny
> Suggested-by: Fabio M. De Francesco
> Signed-off-by: Zhao Liu
> ---
> Suggeste
pped
> page since kunmap_local() can accept any pointer within the page.
>
> [1]: https://lore.kernel.org/all/20220813220034.806698-1-ira.we...@intel.com
>
> Suggested-by: Dave Hansen
> Suggested-by: Ira Weiny
> Suggested-by: Fabio M. De Francesco
> Signed-off-by: Zhao Liu
> ---
On lunedì 17 ottobre 2022 11:37:16 CEST Zhao Liu wrote:
> From: Zhao Liu
>
> The use of kmap_atomic() is being deprecated in favor of
> kmap_local_page()[1].
Some words to explain why kmap_atomic was deprecated won't hurt. Many
maintainers and reviewers, and also casual readers might not yet
irudh"
Suggested-by: Ira Weiny
Signed-off-by: Fabio M. De Francesco
---
drivers/gpu/drm/i915/i915_gem.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c
index 702e5b89be22..43effce60e1b 100644
--- a/d
+ memcpy + local unmap, use memcpy_to_page() in a
suited call site.
Cc: "Venkataramanan, Anirudh"
Suggested-by: Ira Weiny
Signed-off-by: Fabio M. De Francesco
---
drivers/gpu/drm/i915/gem/i915_gem_shmem.c | 6 ++
drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c | 8 +
adding one more recipient (Anirudh) who is helping, along with others, Ira
and me with these conversions / removals of kmap() and kmap_atomic()
Cc: "Venkataramanan, Anirudh"
Suggested-by: Ira Weiny
Signed-off-by: Fabio M. De Francesco
Fabio M. De Francesco (3):
drm/i915: Re
+ memcpy() + local unmappings, use
the memcpy_{from,to}_page() helpers where these are better suited.
Cc: "Venkataramanan, Anirudh"
Suggested-by: Ira Weiny
Signed-off-by: Fabio M. De Francesco
---
drivers/gpu/drm/i915/gt/intel_ggtt_fencing.c | 4 ++--
drivers/gpu/drm/i915/gt/shm
-by: Fabio M. De Francesco
---
drivers/gpu/drm/i915/gt/intel_ggtt_fencing.c | 4 ++--
drivers/gpu/drm/i915/gt/shmem_utils.c| 11 ---
2 files changed, 6 insertions(+), 9 deletions(-)
diff --git a/drivers/gpu/drm/i915/gt/intel_ggtt_fencing.c
b/drivers/gpu/drm/i915/gt
-off-by: Fabio M. De Francesco
---
drivers/gpu/drm/i915/i915_gem.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c
index 702e5b89be22..43effce60e1b 100644
--- a/drivers/gpu/drm/i915/i915_gem.c
+++ b
-off-by: Fabio M. De Francesco
---
drivers/gpu/drm/i915/gem/i915_gem_shmem.c | 6 ++
drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c | 8
2 files changed, 6 insertions(+), 8 deletions(-)
diff --git a/drivers/gpu/drm/i915/gem/i915_gem_shmem.c
b/drivers/gpu/drm/i915/gem
in an 32 bits system, booting a kernel
with HIGHMEM enabled. Unfortunately I have no i915 based hardware,
therefore any help with testing would be greatly appreciated.
Suggested-by: Ira Weiny
Signed-off-by: Fabio M. De Francesco
Fabio M. De Francesco (3):
drm/i915: Replace kmap() with kmap_local_page
24 matches
Mail list logo
