Hi,
On 4/15/20 9:39 AM, Daniel Vetter wrote:
Straightforward conversion.
Signed-off-by: Daniel Vetter
Cc: Hans de Goede
LGTM:
Reviewed-by: Hans de Goede
Regards,
Hans
---
drivers/gpu/drm/vboxvideo/vbox_drv.c | 19 +--
1 file changed, 5 insertions(+), 14 deletions
Hi,
On 4/15/20 9:39 AM, Daniel Vetter wrote:
We use the baseclass pattern here, so lets to the proper (and more
typesafe) upcasting.
Acked-by: Sam Ravnborg
Acked-by: Thomas Zimmermann
Signed-off-by: Daniel Vetter
Cc: Hans de Goede
LGTM:
Reviewed-by: Hans de Goede
Regards,
Hans
Hi,
On 4/15/20 9:39 AM, Daniel Vetter wrote:
Doesn't apply to upstream kernels since a rather long time.
Acked-by: Sam Ravnborg
Signed-off-by: Daniel Vetter
Cc: Hans de Goede
LGTM:
Reviewed-by: Hans de Goede
Regards,
Hans
---
drivers/gpu/drm/vboxvideo/vbox_ttm.c
Hi,
On 3/19/20 5:38 PM, Ville Syrjala wrote:
From: Ville Syrjälä
Some new eDP panels don't like to operate at the max parameters, and
instead we need to go for an optimal confiugration. That unfortunately
doesn't work with older eDP panels which are generally only guaranteed
to work at the max
Hi Lyude,
On 3/7/20 12:54 AM, Lyude Paul wrote:
On Wed, 2020-02-26 at 18:52 +0100, Hans de Goede wrote:
Hi,
On 2/26/20 5:05 PM, Alex Deucher wrote:
On Wed, Feb 26, 2020 at 10:43 AM Hans de Goede
wrote:
Hi,
On 2/26/20 4:29 PM, Alex Deucher wrote:
On Wed, Feb 26, 2020 at 10:16 AM Hans de
Hi All,
On 2/21/20 6:29 PM, Hans de Goede wrote:
Use intel_panel_compute_brightness() from pwm_setup_backlight() so that
we correctly take i915_modparams.invert_brightness and/or
QUIRK_INVERT_BRIGHTNESS into account when setting + getting the initial
brightness value.
Signed-off-by: Hans de
show
the image the right way up on devices with an upside-down mounted panel.
This fixes the image being upside-down on a Teclast X89 tablet.
Signed-off-by: Hans de Goede
---
drivers/gpu/drm/i915/display/intel_dp.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpu/
Hi All,
This is a resend of 2 patches which I submitted a while ago, rebased
on top of the latest dinq to fix some conflicts.
The first patch has already been reviewed.
There were some questions about the second patch, which I have answered,
see: https://patchwork.freedesktop.org/patch/345305/?s
ices.
Reviewed-by: Ville Syrjälä
Signed-off-by: Hans de Goede
---
drivers/gpu/drm/i915/display/vlv_dsi.c | 55 +-
1 file changed, 1 insertion(+), 54 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/vlv_dsi.c
b/drivers/gpu/drm/i915/display/vlv_dsi.c
index d07cfad8
fy the timeout when the work is
already scheduled. Which is exactly what we want if the work races
with a plane update.
- Switch to system_long_wq, Hans says on usb2 a plane upload can take
80 ms.
Signed-off-by: Daniel Vetter
Cc: Hans de Goede
Cc: "Noralf Trønnes"
Patch looks
e 5.6 ships. I think rushing things
never is a good idea. So my vote on this goes to just reverting the commit
triggering this for now and taking our time to get this right.
Regards,
Hans
On Wed, 2020-02-26 at 16:15 +0100, Hans de Goede wrote:
Hi Lyude and everyone else,
Lyude I'm maili
Hi,
On 2/26/20 5:05 PM, Alex Deucher wrote:
On Wed, Feb 26, 2020 at 10:43 AM Hans de Goede wrote:
Hi,
On 2/26/20 4:29 PM, Alex Deucher wrote:
On Wed, Feb 26, 2020 at 10:16 AM Hans de Goede wrote:
Hi Lyude and everyone else,
Lyude I'm mailing you about this because you have done
Hi,
On 2/26/20 4:29 PM, Alex Deucher wrote:
On Wed, Feb 26, 2020 at 10:16 AM Hans de Goede wrote:
Hi Lyude and everyone else,
Lyude I'm mailing you about this because you have done a lot of
work on DP MST, but if this rings a bell to anyone else feel
free to weigh in on this.
Might
Hi Lyude and everyone else,
Lyude I'm mailing you about this because you have done a lot of
work on DP MST, but if this rings a bell to anyone else feel
free to weigh in on this.
I'm currently using a Lenovo X1 7th gen + a Lenovo TB3 gen 2 dock
as my daily rider for testing purposes. When 5.6-rc
the changes, biggest chunk is reindenting the
work fn because it lost its while loop.
Lots of code deleting as consequence all over. Specifically we can
delete the drm_driver.release code now!
Signed-off-by: Daniel Vetter
Cc: Hans de Goede
Cc: "Noralf Trønnes"
---
cking.
Patch looks good to me:
Reviewed-by: Hans de Goede
Regards,
Hans
Signed-off-by: Daniel Vetter
Cc: Hans de Goede
Cc: "Noralf Trønnes"
---
drivers/gpu/drm/tiny/gm12u320.c | 16 +++-
1 file changed, 3 insertions(+), 13 deletions(-)
diff --git a/drivers/gpu/drm/ti
Hi,
On 2/21/20 10:03 PM, Daniel Vetter wrote:
Only drops the drm_dev_put, but hey a few lines!
Signed-off-by: Daniel Vetter
Cc: Hans de Goede
Cc: "Noralf Trønnes"
Patch looks good to me:
Reviewed-by: Hans de Goede
Regards,
Hans
---
drivers/gpu/drm/tiny/gm12u
tter
Cc: Hans de Goede
Cc: "Noralf Trønnes"
Patch looks good to me:
Reviewed-by: Hans de Goede
Regards,
Hans
---
drivers/gpu/drm/tiny/gm12u320.c | 18 +++---
1 file changed, 7 insertions(+), 11 deletions(-)
diff --git a/drivers/gpu/drm/tiny/gm12u320.c b/dr
Hi,
On 2/21/20 10:02 PM, Daniel Vetter wrote:
With this we can drop the final kfree from the release function.
Signed-off-by: Daniel Vetter
Cc: Hans de Goede
Patch looks good to me:
Reviewed-by: Hans de Goede
Regards,
Hans
---
drivers/gpu/drm/tiny/gm12u320.c | 3 ++-
1 file
s not matter in this case.
Signed-off-by: Hans de Goede
---
drivers/gpu/drm/i915/display/intel_quirks.c | 10 ++
1 file changed, 10 insertions(+)
diff --git a/drivers/gpu/drm/i915/display/intel_quirks.c
b/drivers/gpu/drm/i915/display/intel_quirks.c
index 399b1542509f..54dba152ead8 100644
Use intel_panel_compute_brightness() from pwm_setup_backlight() so that
we correctly take i915_modparams.invert_brightness and/or
QUIRK_INVERT_BRIGHTNESS into account when setting + getting the initial
brightness value.
Signed-off-by: Hans de Goede
---
drivers/gpu/drm/i915/display/intel_panel.c
Hi,
On 2/3/20 2:12 PM, Ville Syrjälä wrote:
On Sat, Feb 01, 2020 at 10:31:59AM +, Chris Wilson wrote:
To write to the DISPLAY_PHY_CONTROL requires holding the powerwells,
which during early resume we have not yet acquired until later in
intel_display_power_init_hw(). So compute the initial
Hi Jani,
I need your help merging this series, as it touches files in both drm-intel and
drm-misc:
https://patchwork.freedesktop.org/series/71637/
The first patch touches some i915 files, and applies cleanly to both
dinq and drm-misc-next.
The second patch relies on the first patch as well as
From: Derek Basehore
Not every platform needs quirk detection for panel orientation, so
split the drm_connector_init_panel_orientation_property into two
functions. One for platforms without the need for quirks, and the
other for platforms that need quirks.
Hans de Goede (changes in v2):
Rename
ink: https://gitlab.freedesktop.org/plymouth/plymouth/merge_requests/83
Acked-by: Maxime Ripard
Signed-off-by: Hans de Goede
---
drivers/gpu/drm/drm_connector.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/drivers/gpu/drm/drm_connector.c b/drivers/gpu/drm/drm_connector.c
index de5031c4aa49..f6
Hi,
On 03-01-2020 20:38, Rodrigo Vivi wrote:
On Mon, Dec 16, 2019 at 12:51:58PM +0100, Hans de Goede wrote:
If the new video=... panel_orientation option is set for a connector, honor
it and setup a matching "panel orientation" property on the connector.
BugL
invalid adapter and failed transfer and also
drop the DRM_DEBUG that existed originally. (Hans)
- Add two gotos instead of one to clean things up properly.
CC: Hans de Goede
Cc: Nabendu Maiti
Cc: Matt Roper
Cc: Bob Paauwe
Signed-off-by: Vivek Kasireddy
v2 looks good to me:
Reviewed-by
Hi,
On 04-01-2020 01:00, Vivek Kasireddy wrote:
On Fri, 3 Jan 2020 12:05:11 +0100
Hans de Goede wrote:
Hi Hans,
Hi Vivek,
On 03-01-2020 01:00, Vivek Kasireddy wrote:
Parsing the i2c element is mainly done to transfer the payload from
the MIPI sequence block to the relevant slave device. In
Hi Vivek,
On 03-01-2020 01:00, Vivek Kasireddy wrote:
Parsing the i2c element is mainly done to transfer the payload from the
MIPI sequence block to the relevant slave device. In some cases, the
commands that are part of the payload can be used to turn on the backlight.
This patch is actually a
Hi Rodrigo,
Thank you for the review.
On 02-01-2020 19:17, Rodrigo Vivi wrote:
On Mon, Dec 16, 2019 at 12:51:57PM +0100, Hans de Goede wrote:
From: Derek Basehore
Not every platform needs quirk detection for panel orientation, so
split the drm_connector_init_panel_orientation_property into
n 16-12-2019 12:51, Hans de Goede wrote:
Hi All,
This is a resend of the last 2 remaining patches of my series for adding
support for specifying panel_orientation on the kernel cmdline.
I've already pushed the other 11 patches which were mostly cleanups /
bug-fixes to the cmdline-parsing code
Hi,
On 30-12-2019 14:31, Linus Walleij wrote:
On Mon, Dec 16, 2019 at 9:51 PM Hans de Goede wrote:
Currently only the drivers/pinctrl/devicetree.c code allows registering
pinctrl-mappings which may later be unregistered, all other mappings
are assumed to be permanent.
Non-dt platforms may
Hi all,
On 16-12-2019 21:55, Patchwork wrote:
== Series Details ==
Series: series starting with [1/2] drm/i915/dsi: Remove readback of panel
orientation on BYT / CHT (rev2)
URL : https://patchwork.freedesktop.org/series/70952/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_
its
pinctrl_register_mappings counter-part and exports it.
Together these 2 changes will allow non-dt platform code to
register pinctrl-mappings from modules without breaking things on
module unload (as they can now unregister the mapping on unload).
Signed-off-by: Hans de Goede
---
Changes in v2
: Ville Syrjälä
Signed-off-by: Hans de Goede
---
drivers/gpu/drm/i915/display/intel_dsi.h | 2 +
drivers/gpu/drm/i915/display/intel_dsi_vbt.c | 46 +++-
drivers/gpu/drm/i915/display/vlv_dsi.c | 27 +---
3 files changed, 48 insertions(+), 27 deletions(-)
diff --git a
external monitor connected over HDMI.
Changes in v2:
- Call intel_dsi_get_hw_state() to check if the panel is on instead of
relying on the current_mode pointer
Reviewed-by: Linus Walleij
Signed-off-by: Hans de Goede
---
drivers/gpu/drm/i915/display/intel_dsi.h | 2 +-
drivers/gpu/drm/i915
Point of View MOBII TAB-P1005W
Terra Pad 1061
Yours Y8W81
Reviewed-by: Linus Walleij
Reviewed-by: Ville Syrjälä
Signed-off-by: Hans de Goede
---
drivers/gpu/drm/i915/display/intel_dsi.h | 3 +-
drivers/gpu/drm/i915/display/intel_dsi_vbt.c | 64
2 files changed, 66
Hi All,
Here is v2 of my patch-series to make the
i915 code control the SoC panel- and backlight-enable GPIOs on Bay Trail
devices when the VBT indicates that the SoC should be used for backlight
control. This fixes the panel not lighting up on various devices when
booted with a HDMI monitor conne
, this will also allow us to extend
it with GPIOs from other sources when necessary.
Acked-by: Linus Walleij
Reviewed-by: Andy Shevchenko
Reviewed-by: Ville Syrjälä
Signed-off-by: Hans de Goede
---
drivers/gpu/drm/i915/display/intel_dsi_vbt.c | 23 +++-
drivers/mfd
d-by: Andy Shevchenko
Acked-by: Rafael J. Wysocki
Signed-off-by: Hans de Goede
---
drivers/acpi/acpi_lpss.c | 11 +++
1 file changed, 3 insertions(+), 8 deletions(-)
diff --git a/drivers/acpi/acpi_lpss.c b/drivers/acpi/acpi_lpss.c
index 70f740b09684..db18df6cb330 100644
--- a/drivers/acpi/ac
ed-by: Jani Nikula
Reviewed-by: Andy Shevchenko
Signed-off-by: Hans de Goede
---
drivers/gpu/drm/i915/display/intel_panel.c | 16 +---
1 file changed, 13 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_panel.c
b/drivers/gpu/drm/i915/display/intel_panel
Hi All,
Somehow the CI system did not pick up this series the first time, there
are no test results recorded for it:
https://patchwork.freedesktop.org/series/69685
So this is a resend for CI to do its thing. As soon as CI is happy with
this I will push this to drm-intel-next-queued.
Regards,
Ha
ntroller to "pwm_pmic_backlight" so that the i915 driver can do a
pwm_get() for the right controller depending on the VBT bit, instead of
the i915 driver relying on a "pwm_backlight" lookup getting registered
which magically points to the right controller.
Acked-by: Jani Nikul
Hi,
On 16-12-2019 14:39, Ville Syrjälä wrote:
On Sun, Dec 15, 2019 at 10:33:07PM +0100, Hans de Goede wrote:
Some devices with a builtin panel have the panel mounted upside down,
this is indicated by the rotate_180 bit in the BDB_GENERAL_FEATURES VBT
block.
We store this info in dev_priv
Hi,
On 16-12-2019 15:14, Ville Syrjälä wrote:
On Mon, Dec 16, 2019 at 02:51:54PM +0100, Hans de Goede wrote:
Hi,
Thank you for the reviews.
On 16-12-2019 14:45, Ville Syrjälä wrote:
On Sun, Dec 15, 2019 at 05:38:08PM +0100, Hans de Goede wrote:
When the LCD has not been turned on by the
Hi,
On 15-12-2019 21:08, Patchwork wrote:
== Series Details ==
Series: drm/i915: opregion: set opregion chpd value to indicate the driver
handles hotplug (rev4)
URL : https://patchwork.freedesktop.org/series/69902/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_7569_full ->
Hi,
On 16-12-2019 15:04, Ville Syrjälä wrote:
On Sun, Dec 15, 2019 at 05:38:10PM +0100, Hans de Goede wrote:
On Bay Trail devices the MIPI power on/off sequences for DSI LCD panels
do not control the LCD panel- and backlight-enable GPIOs. So far, when
the VBT indicates we should use the SoC
Hi,
On 16-12-2019 14:56, Ville Syrjälä wrote:
On Sun, Dec 15, 2019 at 05:38:09PM +0100, Hans de Goede wrote:
Move the Crystal Cove PMIC panel GPIO lookup-table from
drivers/mfd/intel_soc_pmic_core.c to the i915 driver.
The moved looked-up table is adding a GPIO lookup to the i915 PCI
device
Hi,
Thank you for the reviews.
On 16-12-2019 14:45, Ville Syrjälä wrote:
On Sun, Dec 15, 2019 at 05:38:08PM +0100, Hans de Goede wrote:
When the LCD has not been turned on by the firmware/GOP, because e.g. the
device was booted with an external monitor connected over HDMI, we should
not turn
Hi,
On 16-12-2019 13:16, Linus Walleij wrote:
On Mon, Dec 16, 2019 at 12:11 PM Hans de Goede wrote:
Ugh, taking one last look at the "pinctrl: Export pinctrl_unregister_mappings"
patch it is no good, sorry.
Ooops!
Linus, can you please drop this from your -next ?
Sure, done.
Hi,
On 16-12-2019 13:16, Andy Shevchenko wrote:
On Sun, Dec 15, 2019 at 05:38:09PM +0100, Hans de Goede wrote:
Move the Crystal Cove PMIC panel GPIO lookup-table from
drivers/mfd/intel_soc_pmic_core.c to the i915 driver.
The moved looked-up table is adding a GPIO lookup to the i915 PCI
device
s not matter in this case.
Signed-off-by: Hans de Goede
---
drivers/gpu/drm/i915/display/intel_quirks.c | 10 ++
1 file changed, 10 insertions(+)
diff --git a/drivers/gpu/drm/i915/display/intel_quirks.c
b/drivers/gpu/drm/i915/display/intel_quirks.c
index 399b1542509f..54dba152ead8 100644
Hi All,
Here is a resend of my series to fix the brightness being inverted on
Thundersoft TST178 tablets. This resend is based on top of dinq so that
the CI can properly test it. No changes other then the rebase on top of
dinq.
Regards,
Hans
___
Intel
Use intel_panel_compute_brightness() from pwm_setup_backlight() so that
we correctly take i915_modparams.invert_brightness and/or
QUIRK_INVERT_BRIGHTNESS into account when setting + getting the initial
brightness value.
Signed-off-by: Hans de Goede
---
drivers/gpu/drm/i915/display/intel_panel.c
From: Derek Basehore
Not every platform needs quirk detection for panel orientation, so
split the drm_connector_init_panel_orientation_property into two
functions. One for platforms without the need for quirks, and the
other for platforms that need quirks.
Hans de Goede (changes in v2):
Rename
If the new video=... panel_orientation option is set for a connector, honor
it and setup a matching "panel orientation" property on the connector.
BugLink: https://gitlab.freedesktop.org/plymouth/plymouth/merge_requests/83
Acked-by: Maxime Ripard
Signed-off-by: Hans de Goede
---
d
Hi All,
This is a resend of the last 2 remaining patches of my series for adding
support for specifying panel_orientation on the kernel cmdline.
I've already pushed the other 11 patches which were mostly cleanups /
bug-fixes to the cmdline-parsing code and where all acked by Maxime
to drm-misc-ne
Hi,
On 16-12-2019 11:26, Linus Walleij wrote:
On Sun, Dec 15, 2019 at 5:38 PM Hans de Goede wrote:
Linus, this series starts with the already discussed pinctrl change to
export the function to unregister a pinctrl-map. We can either merge this
through drm-intel, or you could pick it up and
Hi,
On 16-12-2019 11:26, Linus Walleij wrote:
On Sun, Dec 15, 2019 at 5:38 PM Hans de Goede wrote:
Linus, this series starts with the already discussed pinctrl change to
export the function to unregister a pinctrl-map. We can either merge this
through drm-intel, or you could pick it up and
which magically points to the right controller.
Signed-off-by: Hans de Goede
---
drivers/mfd/intel_soc_pmic_core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
For my own reference:
Acked-for-MFD-by: Lee Jones
As mentioned in the cover-letter, to avoid breaking
let,
so using the generic intel_dsi_get_panel_orientation() helper there does
the right thing without needing any extra readback of hw state.
This commit removes the special handling of the panel orientation for
DSI panels on BYT/CHT devices, bringing the handling in line with the
handling of DSI panels on other devices
show
the image the right way up on devices with an upside-down mounted panel.
This fixes the image being upside-down on a Teclast X89 tablet.
Signed-off-by: Hans de Goede
---
drivers/gpu/drm/i915/display/intel_dp.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/
Is there say an email address I can forward CI failure reports which
I believe to be false-positives to for this? What is the best (non IRC /
non real-time) method to contact "your bug team" ?
On 15-12-2019 22:09, Hans de Goede wrote:
Hi All,
I'm wondering if there are any (
Hi All,
I'm wondering if there are any (unwritten) guidelines for how to deal with CI
failures. Although it is great to have such an extensive CI systems, it seems
to result in quite many false-positives.
After a couple of resubmits I've gotten 2 patch-sets to pass the BAT tests,
but both have f
root device
by setting CHPD to 1, so that the broken if condition in the AML never
gets checked as notifications of type 0x00 are disabled altogether.
Reviewed-by: Ville Syrjälä
Signed-off-by: Hans de Goede
---
drivers/gpu/drm/i915/display/intel_opregion.c | 7 +++
1 file changed, 7 inserti
the VBT MIPI-sequences, intel_dsi_vbt.c is a better place for this,
so move it there.
This is a preparation patch for adding panel-enable and backlight-enable
GPIO support for BYT devices where instead of the PMIC the SoC is used
for backlight control.
Signed-off-by: Hans de Goede
---
drivers
Hi All,
This is a new (completely rewritten) version of my patches to make the
i915 code control the SoC panel- and backlight-enable GPIOs on Bay Trail
devices when the VBT indicates that the SoC should be used for backlight
control. This fixes the panel not lighting up on various devices when
boo
unregister the mapping when the module is unloaded to
avoid dangling pointers; and to avoid registering the mapping multiple
times, when the module gets reloaded later.
Signed-off-by: Hans de Goede
---
drivers/pinctrl/core.c | 11 ++-
drivers/pinctrl/core.h | 3
Point of View MOBII TAB-P1005W
Terra Pad 1061
Yours Y8W81
Signed-off-by: Hans de Goede
---
drivers/gpu/drm/i915/display/intel_dsi.h | 3 +-
drivers/gpu/drm/i915/display/intel_dsi_vbt.c | 63
2 files changed, 65 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915
, this will also allow us to extend
it with GPIOs from other sources when necessary.
Signed-off-by: Hans de Goede
---
drivers/gpu/drm/i915/display/intel_dsi_vbt.c | 23 +++-
drivers/mfd/intel_soc_pmic_core.c| 19
2 files changed, 22 insertions(+), 20
external monitor connected over HDMI.
Signed-off-by: Hans de Goede
---
drivers/gpu/drm/i915/display/intel_dsi.h | 2 +-
drivers/gpu/drm/i915/display/intel_dsi_vbt.c | 7 +++
drivers/gpu/drm/i915/display/vlv_dsi.c | 2 +-
3 files changed, 5 insertions(+), 6 deletions(-)
diff --git a
Hi,
On 13-12-2019 09:27, Lee Jones wrote:
On Thu, 12 Dec 2019, Hans de Goede wrote:
Hi,
On 12-12-2019 16:52, Lee Jones wrote:
On Thu, 12 Dec 2019, Hans de Goede wrote:
Hi,
On 12-12-2019 09:45, Lee Jones wrote:
On Wed, 11 Dec 2019, Hans de Goede wrote:
Hi Lee,
On 10-12-2019 09:51, Lee
root device
by setting CHPD to 1, so that the broken if condition in the AML never
gets checked as notifications of type 0x00 are disabled altogether.
Reviewed-by: Ville Syrjälä
Signed-off-by: Hans de Goede
---
drivers/gpu/drm/i915/display/intel_opregion.c | 7 +++
1 file changed, 7 inserti
s not matter in this case.
Signed-off-by: Hans de Goede
---
drivers/gpu/drm/i915/display/intel_quirks.c | 10 ++
1 file changed, 10 insertions(+)
diff --git a/drivers/gpu/drm/i915/display/intel_quirks.c
b/drivers/gpu/drm/i915/display/intel_quirks.c
index 399b1542509f..54dba152ead8 100644
Use intel_panel_compute_brightness() from pwm_setup_backlight() so that
we correctly take i915_modparams.invert_brightness and/or
QUIRK_INVERT_BRIGHTNESS into account when setting + getting the initial
brightness value.
Signed-off-by: Hans de Goede
---
drivers/gpu/drm/i915/display/intel_panel.c
Hi,
On 12-12-2019 16:52, Lee Jones wrote:
On Thu, 12 Dec 2019, Hans de Goede wrote:
Hi,
On 12-12-2019 09:45, Lee Jones wrote:
On Wed, 11 Dec 2019, Hans de Goede wrote:
Hi Lee,
On 10-12-2019 09:51, Lee Jones wrote:
On Tue, 19 Nov 2019, Hans de Goede wrote:
At least Bay Trail (BYT) and
Hi,
On 12-12-2019 09:45, Lee Jones wrote:
On Wed, 11 Dec 2019, Hans de Goede wrote:
Hi Lee,
On 10-12-2019 09:51, Lee Jones wrote:
On Tue, 19 Nov 2019, Hans de Goede wrote:
At least Bay Trail (BYT) and Cherry Trail (CHT) devices can use 1 of 2
different PWM controllers for controlling the
Hi,
On 11-12-2019 01:24, Linus Walleij wrote:
On Mon, Dec 2, 2019 at 4:49 PM Hans de Goede wrote:
There is only one problem, currently is is not possible to
unregister a mapping added with pinctrl_register_mappings
and the i915 driver is typically a module which can be unloaded
and I believe
Hi Lee,
On 10-12-2019 09:51, Lee Jones wrote:
On Tue, 19 Nov 2019, Hans de Goede wrote:
At least Bay Trail (BYT) and Cherry Trail (CHT) devices can use 1 of 2
different PWM controllers for controlling the LCD's backlight brightness.
Either the one integrated into the PMIC or th
HI,
On 02-12-2019 12:53, Jani Nikula wrote:
On Mon, 02 Dec 2019, Linus Walleij wrote:
Hi Hans,
thank you for your patch!
On Fri, Nov 29, 2019 at 7:58 PM Hans de Goede wrote:
- /* GPIO Desc for CRC based Panel control */
+ /* GPIO Desc for panel and backlight control
Hi All,
On Bay Trail devices the MIPI power on/off sequences for DSI LCD panels
do not control the LCD panel- and backlight-enable GPIOs. So far, when
the VBT indicates we should use the SoC for backlight control, we have
been relying on these GPIOs being configured as output and driven high by
th
the i915 driver,
so that it can set the PWM0 pinmux. Doing this from the LPSS PWM driver
would be more logical. But the only thing telling us that the pin should
definitely be muxed to the PWM controller is the VBT to which the PWM
driver does not have access.
Signed-off-by: Hans de Goede
Point of View MOBII TAB-P1005W
Terra Pad 1061
Yours Y8W81
Signed-off-by: Hans de Goede
---
drivers/gpu/drm/i915/display/intel_dsi.h | 3 +-
drivers/gpu/drm/i915/display/vlv_dsi.c | 44 ++--
2 files changed, 43 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/i915
Hi all,
On 22-11-2019 21:45, Patchwork wrote:
== Series Details ==
Series: drm/i915: opregion: set opregion chpd value to indicate the driver
handles hotplug
URL : https://patchwork.freedesktop.org/series/69902/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_7409 -> Patchwo
root device
by setting CHPD to 1, so that the broken if condition in the AML never
gets checked as notifications of type 0x00 are disabled altogether.
Signed-off-by: Hans de Goede
---
drivers/gpu/drm/i915/display/intel_opregion.c | 7 +++
1 file changed, 7 insertions(+)
diff --gi
Hi,
On 19-11-2019 20:33, Patchwork wrote:
== Series Details ==
Series: drm/i915 / LPSS / mfd: Select correct PWM controller to use based on VBT
URL : https://patchwork.freedesktop.org/series/69686/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_7377 -> Patchwork_15332
==
Hi,
On 19-11-2019 16:47, Ville Syrjälä wrote:
On Tue, Nov 19, 2019 at 04:18:18PM +0100, Hans de Goede wrote:
At least Bay Trail (BYT) and Cherry Trail (CHT) devices can use 1 of 2
different PWM controllers for controlling the LCD's backlight brightness.
Either the one integrated into the
Note this is part of a series which contains 2 other patches which renames
the PWM lookup for the 1st SoC/LPSS PWM from "pwm_backlight" to
"pwm_pmic_backlight" and the PWM lookup for the Crystal Cove PMIC PWM
from "pwm_backlight" to "pwm_pmic_backlight".
Sig
Hi All,
This series needs to be merged through a single tree, to keep things
bisectable. I have even considered just squashing all 3 patches into 1,
but having separate commits seems better, but that does lead to an
intermediate state where the backlight sysfs interface will be broken
(and fixed 2
ntroller to "pwm_pmic_backlight" so that the i915 driver can do a
pwm_get() for the right controller depending on the VBT bit, instead of
the i915 driver relying on a "pwm_backlight" lookup getting registered
which magically points to the right controller.
Signed-off-by: Hans de
to "pwm_soc_backlight" so that the i915 driver can do a pwm_get() for
the right controller depending on the VBT bit, instead of the i915 driver
relying on a "pwm_backlight" lookup getting registered which magically
points to the right controller.
Signed-off-by: Hans de Goede
---
ns is seeing ugly colored flash on VLV/CHV macchines (GPD win
and Asus T100HA) when the gamma LUT gets loaded for the first
time as the BIOS has left some junk in the LUT memory.
Cc: Hans de Goede
Fixes: 051a6d8d3ca0 ("drm/i915: Move LUT programming to happen after vblank
waits")
Signed-off-
>gamma_enable)
Fixes: 051a6d8d3ca0 ("drm/i915: Move LUT programming to happen after vblank
waits")
Signed-off-by: Hans de Goede
---
drivers/gpu/drm/i915/display/intel_color.c | 14 ++
drivers/gpu/drm/i915/display/intel_display.c | 6 +-
drivers/gpu/drm/i915/
Hi,
On 25-10-2019 21:45, Ville Syrjälä wrote:
On Fri, Oct 25, 2019 at 09:23:47PM +0200, Hans de Goede wrote:
Hi,
On 21-10-2019 16:39, Ville Syrjälä wrote:
On Sun, Oct 20, 2019 at 08:19:33PM +0200, Hans de Goede wrote:
Since commit 051a6d8d3ca0 ("drm/i915: Move LUT programming to h
Hi,
On 21-10-2019 16:39, Ville Syrjälä wrote:
On Sun, Oct 20, 2019 at 08:19:33PM +0200, Hans de Goede wrote:
Since commit 051a6d8d3ca0 ("drm/i915: Move LUT programming to happen after
vblank waits"), I am seeing an ugly colored flash of the first few display
lines on 2 Cherry Tra
Hi,
On 20-10-2019 20:19, Hans de Goede wrote:
Since commit 051a6d8d3ca0 ("drm/i915: Move LUT programming to happen after
vblank waits"), I am seeing an ugly colored flash of the first few display
lines on 2 Cherry Trail devices when the gamma table gets set for the first
time. A blue
ctrl and div values inside
config->dsi_pll, so they are set to the GOP / previous values after
calling it.
Signed-off-by: Hans de Goede
---
drivers/gpu/drm/i915/display/vlv_dsi_pll.c | 26 +++---
1 file changed, 18 insertions(+), 8 deletions(-)
diff --git a/drivers/gpu/drm/i
rtc_commit to load the luts earlier if this is set,
and setting this from intel_color_check when a LUT table was not in use
before (and thus may contain bogus values), or when the table size
changes.
Fixes: 051a6d8d3ca0 ("drm/i915: Move LUT programming to happen after vblank
waits")
Si
Hi Jani,
During plumbers I had some discussions with Daniel about supporting
OLED screens. Userspace may need to know that a panel is OLED for 2
reasons:
1) To avoid screen burn-in
2) OLED screens do not have a classic backlight, so in some cases
some sort of brightness/contrast emulation throug
Hi,
On 01-07-19 15:32, Ville Syrjälä wrote:
On Sun, Jun 30, 2019 at 04:23:47PM +0200, Przemysław Hołubowski wrote:
Hello,
immediately after I have upgraded my system from Fedora 28 x64 to 29
graphics' issue started. Mouse leaves a trail composed of multiple
blinking cursors and sometimes recta
701 - 800 of 1441 matches
Mail list logo
