Re: [Intel-gfx] [PATCH 1/2] drm/i915: Stop lying about the WOPCM size

2018-07-17 Thread Jackie Li
On 07/17/2018 05:53 AM, Ville Syrjala wrote: From: Ville Syrjälä Most plattforms don't have a fixed 1MiB WOPCM so stop saying that they do. Also toss in a FIXME about actually using the WOPCM size we probed from the hardware instead of assuming the fixed 1MiB size. Cc: Jackie Li Signed-off

[Intel-gfx] [PATCH v4 4/4] HAX enable guc for CI

2018-04-18 Thread Jackie Li
Signed-off-by: Jackie Li <yaodong...@intel.com> --- drivers/gpu/drm/i915/i915_params.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_params.h b/drivers/gpu/drm/i915/i915_params.h index c963603..53037b5 100644 --- a/drivers/gpu/dr

[Intel-gfx] [PATCH v4 2/4] drm/i915: Always set HUC_LOADING_AGENT_GUC bit in WOPCM offset register

2018-04-18 Thread Jackie Li
will further take care of the locked values in the following enhancement patch. v4: - Fixed typo in commit message (Michal Wajdeczko) Signed-off-by: Jackie Li <yaodong...@intel.com> Cc: Michal Wajdeczko <michal.wajdec...@intel.com> Cc: Sagar Arun Kamble <sagar.a.kam...@intel.com> Cc

[Intel-gfx] [PATCH v4 1/4] drm/i915: Always do WOPCM partitioning based on real firmware sizes

2018-04-18 Thread Jackie Li
making any assumptions to the GuC and HuC firmware sizes. v3: - Rebase v4: - Renamed the new parameter add to intel_uc_fw_fetch (Michal) Signed-off-by: Jackie Li <yaodong...@intel.com> Cc: Michal Wajdeczko <michal.wajdec...@intel.com> Cc: Sagar Arun Kamble <sagar.a.kam...@intel.

[Intel-gfx] [PATCH v4 3/4] drm/i915: Add code to accept valid locked WOPCM register values

2018-04-18 Thread Jackie Li
only if it's not locked v4: - Fixed typo in code comments (Michal) - Refined function names and parameters (Michal) - Avoided duplicated function calls (Michal) - Refined register updating ordering (Michal) Signed-off-by: Jackie Li <yaodong...@intel.com> Cc: Michal Wajdeczko <mich

[Intel-gfx] [PATCH v3 2/4] drm/i915: Always set HUC_LOADING_AGENT_GUC bit in WOPCM offset register

2018-04-09 Thread Jackie Li
will further take care of the locked values in the following enhancement patch. Signed-off-by: Jackie Li <yaodong...@intel.com> Cc: Michal Wajdeczko <michal.wajdec...@intel.com> Cc: Sagar Arun Kamble <sagar.a.kam...@intel.com> Cc: Michal Winiarski <michal.winiar...@intel.co

[Intel-gfx] [PATCH v3 3/4] drm/i915: Add code to accept valid locked WOPCM register values

2018-04-09 Thread Jackie Li
only if it's not locked Signed-off-by: Jackie Li <yaodong...@intel.com> Cc: Michal Wajdeczko <michal.wajdec...@intel.com> Cc: Sagar Arun Kamble <sagar.a.kam...@intel.com> Cc: Michal Winiarski <michal.winiar...@intel.com> Cc: John Spotswood <john.a.spotsw...@int

[Intel-gfx] [PATCH v3 4/4] HAX enable guc for CI

2018-04-09 Thread Jackie Li
Signed-off-by: Jackie Li <yaodong...@intel.com> --- drivers/gpu/drm/i915/i915_params.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_params.h b/drivers/gpu/drm/i915/i915_params.h index c963603..53037b5 100644 --- a/drivers/gpu/dr

[Intel-gfx] [PATCH v3 1/4] drm/i915: Always do WOPCM partitioning based on real firmware sizes

2018-04-09 Thread Jackie Li
making any assumptions to the GuC and HuC firmware sizes. v3: - Rebase Signed-off-by: Jackie Li <yaodong...@intel.com> Cc: Michal Wajdeczko <michal.wajdec...@intel.com> Cc: Sagar Arun Kamble <sagar.a.kam...@intel.com> Cc: Michal Winiarski <michal.winiar...@intel.co

[Intel-gfx] [PATCH v2 1/4] drm/i915: Always do WOPCM partitioning based on real firmware sizes

2018-03-22 Thread Jackie Li
making any assumptions to the GuC and HuC firmware sizes. Signed-off-by: Jackie Li <yaodong...@intel.com> Cc: Michal Wajdeczko <michal.wajdec...@intel.com> Cc: Sagar Arun Kamble <sagar.a.kam...@intel.com> Cc: Michal Winiarski <michal.winiar...@intel.com> Cc: John Spotswood <

[Intel-gfx] [PATCH v2 3/4] drm/i915: Add code to accept valid locked WOPCM register values

2018-03-22 Thread Jackie Li
only if it's not locked Signed-off-by: Jackie Li <yaodong...@intel.com> Cc: Michal Wajdeczko <michal.wajdec...@intel.com> Cc: Sagar Arun Kamble <sagar.a.kam...@intel.com> Cc: Michal Winiarski <michal.winiar...@intel.com> Cc: John Spotswood <john.a.spotsw...@intel.com

[Intel-gfx] [PATCH v2 4/4] HAX enable guc for CI

2018-03-22 Thread Jackie Li
Signed-off-by: Jackie Li <yaodong...@intel.com> --- drivers/gpu/drm/i915/i915_params.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_params.h b/drivers/gpu/drm/i915/i915_params.h index c963603..53037b5 100644 --- a/drivers/gpu/dr

[Intel-gfx] [PATCH v2 2/4] drm/i915: Always set HUC_LOADING_AGENT_GUC bit in WOPCM offset register

2018-03-22 Thread Jackie Li
will further take care of the locked values in the following enhancement patch. Signed-off-by: Jackie Li <yaodong...@intel.com> Cc: Michal Wajdeczko <michal.wajdec...@intel.com> Cc: Sagar Arun Kamble <sagar.a.kam...@intel.com> Cc: Michal Winiarski <michal.winiar...@intel.co

[Intel-gfx] [PATCH v4] drm/i915: Use correct reST syntax for WOPCM and GuC kernel-doc diagrams

2018-03-22 Thread Jackie Li
description. v2: - Fixed errors in diagram description v3: - Updated GuC Address Space kernel-doc based on Michal's suggestion v4: - Added WOPCM layout and GuC address space docs into i915.rst (Joonas) Signed-off-by: Jackie Li <yaodong...@intel.com> Cc: Michal Wajdeczko <michal.wajdec...@

[Intel-gfx] [PATCH 2/2] HAX enable guc for CI

2018-03-20 Thread Jackie Li
Signed-off-by: Jackie Li <yaodong...@intel.com> --- drivers/gpu/drm/i915/i915_params.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_params.h b/drivers/gpu/drm/i915/i915_params.h index c963603..53037b5 100644 --- a/drivers/gpu/dr

[Intel-gfx] [PATCH 1/2] drm/i915: Add code to accept valid locked WOPCM register values

2018-03-20 Thread Jackie Li
register values can be used for GuC/HuC firmware loading, it will recalculate the verify the new values if these registers were partially locked, so that we won't fail the GuC/HuC firmware loading even if the locked register values are different from the calculated ones. Signed-off-by: Jackie Li

[Intel-gfx] [PATCH v3] drm/i915: Use correct reST syntax for WOPCM and GuC kernel-doc diagrams

2018-03-15 Thread Jackie Li
description. v2: - Fixed errors in diagram description v3: - Updated GuC Address Space kernel-doc based on Michal's suggestion Signed-off-by: Jackie Li <yaodong...@intel.com> Cc: Michal Wajdeczko <michal.wajdec...@intel.com> Cc: Sagar Arun Kamble <sagar.a.kam...@intel.com> C

[Intel-gfx] [PATCH v2] drm/i915: Use correct reST syntax for WOPCM and GuC kernel-doc diagrams

2018-03-14 Thread Jackie Li
description. v2: - Fixed errors in diagram description Signed-off-by: Jackie Li <yaodong...@intel.com> Cc: Michal Wajdeczko <michal.wajdec...@intel.com> Cc: Sagar Arun Kamble <sagar.a.kam...@intel.com> Cc: Joonas Lahtinen <joonas.lahti...@linux.intel.com> --- drivers/gpu/drm

[Intel-gfx] [PATCH] drm/i915: Use correct reST syntax for WOPCM and GuC kernel-doc diagrams

2018-03-14 Thread Jackie Li
GuC Address Space and WOPCM Layout diagrams won't be generated correctly by sphinx build if not using proper reST syntax. This patch uses reST literal blocks to make sure GuC Address Space and WOPCM Layout diagrams to be generated correctly. Signed-off-by: Jackie Li <yaodong...@intel.com&

[Intel-gfx] [PATCH v13 4/6] drm/i915: Add HuC firmware size related restriction for Gen9 and CNL A0

2018-03-13 Thread Jackie Li
comments (Joonas) v11: - Fixed logic error in size check (Michal) v12: - Add space between "HuC FW" and "(%uKiB)" in error message (Michal) v13: - Updated the ordering of s-o-b/cc/r-b tags (Sagar) BSpec: 10875 Signed-off-by: Jackie Li <yaodong...@intel.co

[Intel-gfx] [PATCH v13 1/6] drm/i915/guc: Rename guc_ggtt_offset to intel_guc_ggtt_offset

2018-03-13 Thread Jackie Li
e ordering of s-o-b/cc/r-b tags (Sagar) Signed-off-by: Jackie Li <yaodong...@intel.com> Cc: Michal Wajdeczko <michal.wajdec...@intel.com> Cc: Sagar Arun Kamble <sagar.a.kam...@intel.com> Cc: Chris Wilson <ch...@chris-wilson.co.uk> Cc: Joonas Lahtinen <joonas.lahti...@lin

[Intel-gfx] [PATCH v13 5/6] drm/i915/guc: Check the locking status of GuC WOPCM registers

2018-03-13 Thread Jackie Li
Signed-off-by: Jackie Li <yaodong...@intel.com> Cc: Michal Wajdeczko <michal.wajdec...@intel.com> Cc: Chris Wilson <ch...@chris-wilson.co.uk> Cc: Joonas Lahtinen <joonas.lahti...@linux.intel.com> Reviewed-by: Michal Wajdeczko <michal.wajdec...@intel.com> (v11

[Intel-gfx] [PATCH v13 2/6] drm/i915: Implement dynamic GuC WOPCM offset and size calculation

2018-03-13 Thread Jackie Li
(Michal) v12: - Updated naming, function kernel-doc to align with new changes (Michal) v13: - Updated the ordering of s-o-b/cc/r-b tags (Sagar) - Corrected one tense error in comment (Sagar) - Corrected typos and removed spurious comments (Joonas) Bspec: 12690 Signed-off-by: Jackie Li <yaod

[Intel-gfx] [PATCH v13 6/6] HAX Enable GuC Submission for CI

2018-03-13 Thread Jackie Li
Signed-off-by: Jackie Li <yaodong...@intel.com> --- drivers/gpu/drm/i915/i915_params.c | 2 +- drivers/gpu/drm/i915/i915_params.h | 2 +- drivers/gpu/drm/i915/intel_uc.c| 2 ++ 3 files changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_params.c b/drivers/g

[Intel-gfx] [PATCH v13 3/6] drm/i915: Add support to return CNL specific reserved WOPCM size

2018-03-13 Thread Jackie Li
-by: Jackie Li <yaodong...@intel.com> Cc: Sagar Arun Kamble <sagar.a.kam...@intel.com> Cc: Michal Wajdeczko <michal.wajdec...@intel.com> Cc: Chris Wilson <ch...@chris-wilson.co.uk> Cc: Joonas Lahtinen <joonas.lahti...@linux.intel.com> Reviewed-by: Joonas Lahtinen <joo

[Intel-gfx] [PATCH v12 6/6] HAX Enable GuC Submission for CI

2018-03-01 Thread Jackie Li
Signed-off-by: Jackie Li <yaodong...@intel.com> --- drivers/gpu/drm/i915/i915_params.c | 2 +- drivers/gpu/drm/i915/i915_params.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_params.c b/drivers/gpu/drm/i915/i915_params.c index 08108ce..b

[Intel-gfx] [PATCH v12 3/6] drm/i915: Add support to return CNL specific reserved WOPCM size

2018-03-01 Thread Jackie Li
deczko <michal.wajdec...@intel.com> Cc: Chris Wilson <ch...@chris-wilson.co.uk> Cc: Joonas Lahtinen <joonas.lahti...@linux.intel.com> Reviewed-by: Joonas Lahtinen <joonas.lahti...@linux.intel.com> (v9) Signed-off-by: Jackie Li <yaodong...@intel.com> Reviewed-by: Michal Wajdecz

[Intel-gfx] [PATCH v12 1/6] drm/i915/guc: Rename guc_ggtt_offset to intel_guc_ggtt_offset

2018-03-01 Thread Jackie Li
en <joonas.lahti...@linux.intel.com> (v9) Signed-off-by: Jackie Li <yaodong...@intel.com> Reviewed-by: Michal Wajdeczko <michal.wajdec...@intel.com> (v11) --- drivers/gpu/drm/i915/intel_guc.c| 11 ++- drivers/gpu/drm/i915/intel_guc.h| 14 ++

[Intel-gfx] [PATCH v12 5/6] drm/i915/guc: Check the locking status of GuC WOPCM registers

2018-03-01 Thread Jackie Li
Chris Wilson <ch...@chris-wilson.co.uk> Cc: Joonas Lahtinen <joonas.lahti...@linux.intel.com> Reviewed-by: Michal Wajdeczko <michal.wajdec...@intel.com> (v11) Signed-off-by: Jackie Li <yaodong...@intel.com> --- drivers/gpu/drm/i915/i915_gem.c | 6 drivers/gpu

[Intel-gfx] [PATCH v12 2/6] drm/i915: Implement dynamic GuC WOPCM offset and size calculation

2018-03-01 Thread Jackie Li
kam...@intel.com> (v8) Reviewed-by: Joonas Lahtinen <joonas.lahti...@linux.intel.com> (v9) Reviewed-by: Michal Wajdeczko <michal.wajdec...@intel.com> (v11) Signed-off-by: Jackie Li <yaodong...@intel.com> --- drivers/gpu/drm/i915/Makefile | 3 +- drivers/gpu/drm/i915/i

[Intel-gfx] [PATCH v12 4/6] drm/i915: Add HuC firmware size related restriction for Gen9 and CNL A0

2018-03-01 Thread Jackie Li
c: John Spotswood <john.a.spotsw...@intel.com> Cc: Jeff McGee <jeff.mc...@intel.com> Cc: Chris Wilson <ch...@chris-wilson.co.uk> Cc: Joonas Lahtinen <joonas.lahti...@linux.intel.com> Reviewed-by: Sagar Arun Kamble <sagar.a.kam...@intel.com> (v8) Reviewed-by: Michal Wajdecz

[Intel-gfx] [PATCH v11 1/6] drm/i915/guc: Rename guc_ggtt_offset to intel_guc_ggtt_offset

2018-02-28 Thread Jackie Li
en <joonas.lahti...@linux.intel.com> (v9) Signed-off-by: Jackie Li <yaodong...@intel.com> --- drivers/gpu/drm/i915/intel_guc.c| 11 ++- drivers/gpu/drm/i915/intel_guc.h| 14 -- drivers/gpu/drm/i915/intel_guc_ads.c| 8 drivers/gpu

[Intel-gfx] [PATCH v11 5/6] drm/i915/guc: Check the locking status of GuC WOPCM registers

2018-02-28 Thread Jackie Li
intel_gem_init_hw() to do GuC WOPCM register setup instead of calling from intel_uc_init_hw() (Michal) BSpec: 10875, 10833 Cc: Michal Wajdeczko <michal.wajdec...@intel.com> Cc: Chris Wilson <ch...@chris-wilson.co.uk> Cc: Joonas Lahtinen <joonas.lahti...@linux.intel.com> Signed

[Intel-gfx] [PATCH v11 4/6] drm/i915: Add HuC firmware size related restriction for Gen9 and CNL A0

2018-02-28 Thread Jackie Li
hris Wilson <ch...@chris-wilson.co.uk> Cc: Joonas Lahtinen <joonas.lahti...@linux.intel.com> Reviewed-by: Sagar Arun Kamble <sagar.a.kam...@intel.com> (v8) Signed-off-by: Jackie Li <yaodong...@intel.com> --- drivers/gpu/drm/i915/intel_wopcm.c | 28 +--

[Intel-gfx] [PATCH v11 2/6] drm/i915: Implement dynamic GuC WOPCM offset and size calculation

2018-02-28 Thread Jackie Li
@intel.com> Cc: Oscar Mateo <oscar.ma...@intel.com> Cc: Chris Wilson <ch...@chris-wilson.co.uk> Cc: Joonas Lahtinen <joonas.lahti...@linux.intel.com> Reviewed-by: Sagar Arun Kamble <sagar.a.kam...@intel.com> (v8) Reviewed-by: Joonas Lahtinen <joonas.lahti...@linux.intel

[Intel-gfx] [PATCH v11 3/6] drm/i915: Add support to return CNL specific reserved WOPCM size

2018-02-28 Thread Jackie Li
deczko <michal.wajdec...@intel.com> Cc: Chris Wilson <ch...@chris-wilson.co.uk> Cc: Joonas Lahtinen <joonas.lahti...@linux.intel.com> Reviewed-by: Joonas Lahtinen <joonas.lahti...@linux.intel.com> (v9) Signed-off-by: Jackie Li <yaodong...@intel.com> --- drivers/gpu/drm/i915/intel

[Intel-gfx] [PATCH v11 6/6] HAX Enable GuC Submission for CI

2018-02-28 Thread Jackie Li
Signed-off-by: Jackie Li <yaodong...@intel.com> --- drivers/gpu/drm/i915/i915_params.c | 2 +- drivers/gpu/drm/i915/i915_params.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_params.c b/drivers/gpu/drm/i915/i915_params.c index 08108ce..b

[Intel-gfx] [PATCH v10 2/7] drm/i915/guc: Rename guc_ggtt_offset to intel_guc_ggtt_offset

2018-02-12 Thread Jackie Li
en <joonas.lahti...@linux.intel.com> (v9) Signed-off-by: Jackie Li <yaodong...@intel.com> --- drivers/gpu/drm/i915/intel_guc.c| 11 ++- drivers/gpu/drm/i915/intel_guc.h| 14 -- drivers/gpu/drm/i915/intel_guc_ads.c| 27

[Intel-gfx] [PATCH v10 6/7] drm/i915/guc: Check the locking status of GuC WOPCM registers

2018-02-12 Thread Jackie Li
paths (Michal) - Removed hw_updated flag and only relies on real hardware status Cc: Michal Wajdeczko <michal.wajdec...@intel.com> Cc: Chris Wilson <ch...@chris-wilson.co.uk> Cc: Joonas Lahtinen <joonas.lahti...@linux.intel.com> Signed-off-by: Jackie Li <yaodong...@intel.com&

[Intel-gfx] [PATCH v10 5/7] drm/i915/guc: Add HuC firmware size related restriction for Gen9 and CNL A0

2018-02-12 Thread Jackie Li
t;joonas.lahti...@linux.intel.com> Reviewed-by: Sagar Arun Kamble <sagar.a.kam...@intel.com> (v8) Signed-off-by: Jackie Li <yaodong...@intel.com> --- drivers/gpu/drm/i915/intel_guc_wopcm.c | 26 ++ 1 file changed, 22 insertions(+), 4 deletions(-) diff -

[Intel-gfx] [PATCH v10 7/7] HAX Enable GuC Submission for CI

2018-02-12 Thread Jackie Li
Signed-off-by: Jackie Li <yaodong...@intel.com> --- drivers/gpu/drm/i915/i915_params.c | 2 +- drivers/gpu/drm/i915/i915_params.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_params.c b/drivers/gpu/drm/i915/i915_params.c index 08108ce..b

[Intel-gfx] [PATCH v10 3/7] drm/i915/guc: Implement dynamic GuC WOPCM offset and size

2018-02-12 Thread Jackie Li
> Reviewed-by: Sagar Arun Kamble <sagar.a.kam...@intel.com> (v8) Reviewed-by: Joonas Lahtinen <joonas.lahti...@linux.intel.com> (v9) Signed-off-by: Jackie Li <yaodong...@intel.com> --- drivers/gpu/drm/i915/i915_gem_context.c | 5 +- drivers/gpu/drm/i915/intel_guc.c| 5

[Intel-gfx] [PATCH v10 1/7] drm/i915/guc: Move GuC WOPCM related code into separate files

2018-02-12 Thread Jackie Li
r Arun Kamble <sagar.a.kam...@intel.com> Cc: Chris Wilson <ch...@chris-wilson.co.uk> Cc: Joonas Lahtinen <joonas.lahti...@linux.intel.com> Cc: Michel Thierry <michel.thie...@intel.com> Reviewed-by: Sagar Arun Kamble <sagar.a.kam...@intel.com> (v8) Signed-off

[Intel-gfx] [PATCH v10 4/7] drm/i915/guc: Add support to return CNL specific reserved GuC WOPCM size

2018-02-12 Thread Jackie Li
.uk> Cc: Joonas Lahtinen <joonas.lahti...@linux.intel.com> Reviewed-by: Joonas Lahtinen <joonas.lahti...@linux.intel.com> (v9) Signed-off-by: Jackie Li <yaodong...@intel.com> --- drivers/gpu/drm/i915/intel_guc_wopcm.c | 6 -- drivers/gpu/drm/i915/intel_guc_wopcm.h | 2 ++

[Intel-gfx] [PATCH v9 6/7] drm/i915/guc: Check the locking status of GuC WOPCM registers

2018-02-08 Thread Jackie Li
Wajdeczko <michal.wajdec...@intel.com> Cc: Chris Wilson <ch...@chris-wilson.co.uk> Cc: Joonas Lahtinen <joonas.lahti...@linux.intel.com> Signed-off-by: Jackie Li <yaodong...@intel.com> --- drivers/gpu/drm/i915/intel_guc_reg.h | 2 + drivers/gpu/drm/i915

[Intel-gfx] [PATCH v9 5/7] drm/i915/guc: Add HuC firmware size related restriction for Gen9 and CNL A0

2018-02-08 Thread Jackie Li
hn Spotswood <john.a.spotsw...@intel.com> Cc: Jeff McGee <jeff.mc...@intel.com> Cc: Chris Wilson <ch...@chris-wilson.co.uk> Cc: Joonas Lahtinen <joonas.lahti...@linux.intel.com> Reviewed-by: Sagar Arun Kamble <sagar.a.kam...@intel.com> (v8) Signed-off-by: Jackie Li <ya

[Intel-gfx] [PATCH v9 7/7] HAX Enable GuC Submission for CI

2018-02-08 Thread Jackie Li
Signed-off-by: Jackie Li <yaodong...@intel.com> --- drivers/gpu/drm/i915/i915_params.c | 2 +- drivers/gpu/drm/i915/i915_params.h | 2 +- drivers/gpu/drm/i915/intel_guc_wopcm.c | 6 ++ 3 files changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_param

[Intel-gfx] [PATCH v9 3/7] drm/i915/guc: Implement dynamic GuC WOPCM offset and size

2018-02-08 Thread Jackie Li
> Cc: Oscar Mateo <oscar.ma...@intel.com> Cc: Chris Wilson <ch...@chris-wilson.co.uk> Cc: Joonas Lahtinen <joonas.lahti...@linux.intel.com> Reviewed-by: Sagar Arun Kamble <sagar.a.kam...@intel.com> (v8) Signed-off-by: Jackie Li <yaodong...@intel.com> --- drivers/gp

[Intel-gfx] [PATCH v9 4/7] drm/i915/guc: Add support to return CNL specific reserved GuC WOPCM size

2018-02-08 Thread Jackie Li
for these changes originally made in v8 4/6 patch of this series (Sagar/Michal) Cc: Sagar Arun Kamble <sagar.a.kam...@intel.com> Cc: Michal Wajdeczko <michal.wajdec...@intel.com> Cc: Chris Wilson <ch...@chris-wilson.co.uk> Cc: Joonas Lahtinen <joonas.lahti...@linux.intel.com>

[Intel-gfx] [PATCH v9 1/7] drm/i915/guc: Move GuC WOPCM related code into separate files

2018-02-08 Thread Jackie Li
s Wilson <ch...@chris-wilson.co.uk> Cc: Joonas Lahtinen <joonas.lahti...@linux.intel.com> Reviewed-by: Sagar Arun Kamble <sagar.a.kam...@intel.com> (v8) Signed-off-by: Jackie Li <yaodong...@intel.com> --- drivers/gpu/drm/i915/Makefile | 1 + drivers/gpu/drm/i915/inte

[Intel-gfx] [PATCH v9 2/7] drm/i915/guc: Rename guc_ggtt_offset to intel_guc_ggtt_offset

2018-02-08 Thread Jackie Li
..@chris-wilson.co.uk> Cc: Joonas Lahtinen <joonas.lahti...@linux.intel.com> Reviewed-by: Sagar Arun Kamble <sagar.a.kam...@intel.com> (v8) Signed-off-by: Jackie Li <yaodong...@intel.com> --- drivers/gpu/drm/i915/intel_guc.c| 12 +++- drivers/gpu/drm/i915/intel

[Intel-gfx] [PATCH v8 4/6] drm/i915/guc: Add dynamic GuC WOPCM offset and size support for CNL

2018-02-05 Thread Jackie Li
.@intel.com> Cc: Jeff McGee <jeff.mc...@intel.com> Cc: Chris Wilson <ch...@chris-wilson.co.uk> Cc: Joonas Lahtinen <joonas.lahti...@linux.intel.com> Signed-off-by: Jackie Li <yaodong...@intel.com> --- drivers/gpu/drm/i915/intel_guc_wopcm.c | 24 +++- d

[Intel-gfx] [PATCH v8 3/6] drm/i915/guc: Implement dynamic GuC WOPCM offset and size

2018-02-05 Thread Jackie Li
om> Cc: Daniele Ceraolo Spurio <daniele.ceraolospu...@intel.com> Cc: John Spotswood <john.a.spotsw...@intel.com> Cc: Oscar Mateo <oscar.ma...@intel.com> Cc: Chris Wilson <ch...@chris-wilson.co.uk> Cc: Joonas Lahtinen <joonas.lahti...@linux.intel.com> Signed-off-by: J

[Intel-gfx] [PATCH v8 5/6] drm/i915/guc: Check the locking status of GuC WOPCM registers

2018-02-05 Thread Jackie Li
status checking v7: - Fixed patch format issues v8: - Fixed coding style issue on register lock bit macro definition (Sagar) Cc: Michal Wajdeczko <michal.wajdec...@intel.com> Cc: Chris Wilson <ch...@chris-wilson.co.uk> Cc: Joonas Lahtinen <joonas.lahti...@linux.intel.com> Sig

[Intel-gfx] [PATCH v8 6/6] HAX Enable GuC Submission for CI

2018-02-05 Thread Jackie Li
Signed-off-by: Jackie Li <yaodong...@intel.com> --- drivers/gpu/drm/i915/i915_params.c | 2 +- drivers/gpu/drm/i915/i915_params.h | 2 +- drivers/gpu/drm/i915/intel_guc_wopcm.c | 6 ++ 3 files changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_param

[Intel-gfx] [PATCH v8 2/6] drm/i915/guc: Rename guc_ggtt_offset to intel_guc_ggtt_offset

2018-02-05 Thread Jackie Li
...@linux.intel.com> Signed-off-by: Jackie Li <yaodong...@intel.com> --- drivers/gpu/drm/i915/intel_guc.c| 12 +++- drivers/gpu/drm/i915/intel_guc.h| 14 -- drivers/gpu/drm/i915/intel_guc_ads.c| 25 + drivers/

[Intel-gfx] [PATCH v8 1/6] drm/i915/guc: Move GuC WOPCM related code into separate files

2018-02-05 Thread Jackie Li
Reviewed-by: Sagar Arun Kamble <sagar.a.kam...@intel.com> (v7) Signed-off-by: Jackie Li <yaodong...@intel.com> --- drivers/gpu/drm/i915/Makefile | 1 + drivers/gpu/drm/i915/intel_guc.c | 11 drivers/gpu/drm/i915/intel_guc.h | 2 +- drivers/gpu/drm/i915/int

[Intel-gfx] [RFC] drm/i915: cpufreq based dynamic ring freqency table on Gen9

2018-01-30 Thread Jackie Li
frequency. Cc: Chris Wilson <ch...@chris-wilson.co.uk> Cc: Sagar Arun Kamble <sagar.a.kam...@intel.com> Cc: Dmitry Rogozhkin <dmitry.v.rogozh...@intel.com> Signed-off-by: Jackie Li <yaodong...@intel.com> --- drivers/gpu/drm/i915/i915_drv.h | 4 ++ drivers/gpu/d

[Intel-gfx] [PATCH v7 2/6] drm/i915/guc: Rename guc_ggtt_offset to intel_guc_ggtt_offset

2018-01-18 Thread Jackie Li
joonas.lahti...@linux.intel.com> Signed-off-by: Jackie Li <yaodong...@intel.com> --- drivers/gpu/drm/i915/intel_guc.c| 12 +++- drivers/gpu/drm/i915/intel_guc.h| 10 -- drivers/gpu/drm/i915/intel_guc_ads.c| 25 + drivers/

[Intel-gfx] [PATCH v7 1/6] drm/i915/guc: Move GuC WOPCM related code into separate files

2018-01-18 Thread Jackie Li
WOPCM related functions to a new source file intel_guc_wopcm.c Cc: Michal Wajdeczko <michal.wajdec...@intel.com> Cc: Sagar Arun Kamble <sagar.a.kam...@intel.com> Cc: Chris Wilson <ch...@chris-wilson.co.uk> Cc: Joonas Lahtinen <joonas.lahti...@linux.intel.com> Signed-of

[Intel-gfx] [PATCH v7 4/6] drm/i915/guc: Add WOPCM partitioning support for CNL

2018-01-18 Thread Jackie Li
ti...@linux.intel.com> Signed-off-by: Jackie Li <yaodong...@intel.com> --- drivers/gpu/drm/i915/intel_guc_wopcm.c | 23 ++- drivers/gpu/drm/i915/intel_guc_wopcm.h | 4 2 files changed, 26 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915

[Intel-gfx] [PATCH v7 5/6] drm/i915/guc: Check the locking status of GuC WOPCM registers

2018-01-18 Thread Jackie Li
status checking v7: - Fixed patch format issues Cc: Michal Wajdeczko <michal.wajdec...@intel.com> Cc: Chris Wilson <ch...@chris-wilson.co.uk> Cc: Joonas Lahtinen <joonas.lahti...@linux.intel.com> Signed-off-by: Jackie Li <yaodong...@intel.com> --- drivers/gpu/drm/i91

[Intel-gfx] [PATCH v7 3/6] drm/i915/guc: Implement dynamic GuC WOPCM offset and size

2018-01-18 Thread Jackie Li
n.a.spotsw...@intel.com> Cc: Oscar Mateo <oscar.ma...@intel.com> Cc: Chris Wilson <ch...@chris-wilson.co.uk> Cc: Joonas Lahtinen <joonas.lahti...@linux.intel.com> Signed-off-by: Jackie Li <yaodong...@intel.com> --- drivers/gpu/drm/i915/i915_gem_context.c | 9 +-- drivers

[Intel-gfx] [PATCH v7 6/6] HAX Enable GuC Submission for CI

2018-01-18 Thread Jackie Li
Signed-off-by: Jackie Li <yaodong...@intel.com> --- drivers/gpu/drm/i915/i915_gem_gtt.c| 4 ++-- drivers/gpu/drm/i915/i915_params.c | 2 +- drivers/gpu/drm/i915/i915_params.h | 2 +- drivers/gpu/drm/i915/intel_guc_wopcm.c | 6 ++ 4 files changed, 10 insertions(+), 4 del

[Intel-gfx] [PATCH v6 3/6] drm/i915/guc: Implement dynamic GuC WOPCM offset and size

2018-01-08 Thread Jackie Li
n.a.spotsw...@intel.com> Cc: Oscar Mateo <oscar.ma...@intel.com> Cc: Chris Wilson <ch...@chris-wilson.co.uk> Cc: Joonas Lahtinen <joonas.lahti...@linux.intel.com> Signed-off-by: Jackie Li <yaodong...@intel.com> --- drivers/gpu/drm/i915/i915_gem_context.c | 9 +-- drivers

[Intel-gfx] [PATCH v6 2/6] drm/i915/guc: Rename guc_ggtt_offset to intel_guc_ggtt_offset

2018-01-08 Thread Jackie Li
joonas.lahti...@linux.intel.com> Signed-off-by: Jackie Li <yaodong...@intel.com> --- drivers/gpu/drm/i915/intel_guc.c| 12 +++- drivers/gpu/drm/i915/intel_guc.h| 10 -- drivers/gpu/drm/i915/intel_guc_ads.c| 25 + drivers/

[Intel-gfx] [PATCH v6 6/6] HAX Enable GuC Submission for CI

2018-01-08 Thread Jackie Li
Signed-off-by: Jackie Li <yaodong...@intel.com> --- drivers/gpu/drm/i915/i915_gem_gtt.c| 4 ++-- drivers/gpu/drm/i915/i915_params.c | 2 +- drivers/gpu/drm/i915/i915_params.h | 2 +- drivers/gpu/drm/i915/intel_guc_wopcm.c | 6 ++ 4 files changed, 10 insertions(+), 4 del

[Intel-gfx] [PATCH v6 5/6] drm/i915/guc: Check the locking status of GuC WOPCM registers

2018-01-08 Thread Jackie Li
status checking Cc: Michal Wajdeczko <michal.wajdec...@intel.com> Cc: Chris Wilson <ch...@chris-wilson.co.uk> Cc: Joonas Lahtinen <joonas.lahti...@linux.intel.com> Signed-off-by: Jackie Li <yaodong...@intel.com> --- drivers/gpu/drm/i915/intel_guc.h | 2

[Intel-gfx] [PATCH v6 1/6] drm/i915/guc: Move GuC WOPCM related code into separate files

2018-01-08 Thread Jackie Li
WOPCM related functions to a new source file intel_guc_wopcm.c Cc: Michal Wajdeczko <michal.wajdec...@intel.com> Cc: Sagar Arun Kamble <sagar.a.kam...@intel.com> Cc: Chris Wilson <ch...@chris-wilson.co.uk> Cc: Joonas Lahtinen <joonas.lahti...@linux.intel.com> Signed-of

[Intel-gfx] [PATCH v6 4/6] drm/i915/guc: Add WOPCM partitioning support for CNL

2018-01-08 Thread Jackie Li
<michal.wajdec...@intel.com> Cc: Sagar Arun Kamble <sagar.a.kam...@intel.com> Cc: John Spotswood <john.a.spotsw...@intel.com> Cc: Jeff McGee <jeff.mc...@intel.com> Cc: Chris Wilson <ch...@chris-wilson.co.uk> Cc: Joonas Lahtinen <joonas.lahti...@linux.intel.com&g

[Intel-gfx] [PATCH v5 5/6] drm/i915/guc: Check the locking status of GuC WOPCM registers

2018-01-08 Thread Jackie Li
on <ch...@chris-wilson.co.uk> Cc: Joonas Lahtinen <joonas.lahti...@linux.intel.com> Signed-off-by: Jackie Li <yaodong...@intel.com> --- drivers/gpu/drm/i915/intel_guc.h | 2 +- drivers/gpu/drm/i915/intel_guc_reg.h | 1 + drivers/gpu/drm/i91

[Intel-gfx] [PATCH v5 6/6] HAX Enable GuC Submission for CI

2018-01-08 Thread Jackie Li
Signed-off-by: Jackie Li <yaodong...@intel.com> --- drivers/gpu/drm/i915/i915_gem_gtt.c| 4 ++-- drivers/gpu/drm/i915/i915_params.c | 2 +- drivers/gpu/drm/i915/i915_params.h | 2 +- drivers/gpu/drm/i915/intel_guc_wopcm.c | 6 ++ 4 files changed, 10 insertions(+), 4 del

[Intel-gfx] [PATCH v5 1/6] drm/i915/guc: Move GuC WOPCM related code into separate files

2018-01-08 Thread Jackie Li
WOPCM related functions to a new source file intel_guc_wopcm.c Cc: Michal Wajdeczko <michal.wajdec...@intel.com> Cc: Sagar Arun Kamble <sagar.a.kam...@intel.com> Cc: Chris Wilson <ch...@chris-wilson.co.uk> Cc: Joonas Lahtinen <joonas.lahti...@linux.intel.com> Signed-of

[Intel-gfx] [PATCH v5 4/6] drm/i915/guc: Add WOPCM partitioning support for CNL

2018-01-08 Thread Jackie Li
hn Spotswood <john.a.spotsw...@intel.com> Cc: Jeff McGee <jeff.mc...@intel.com> Cc: Chris Wilson <ch...@chris-wilson.co.uk> Cc: Joonas Lahtinen <joonas.lahti...@linux.intel.com> Signed-off-by: Jackie Li <yaodong...@intel.com> --- drivers/gpu/drm/i915/intel_guc_wopcm.c |

[Intel-gfx] [PATCH v5 2/6] drm/i915/guc: Rename guc_ggtt_offset to intel_guc_ggtt_offset

2018-01-08 Thread Jackie Li
joonas.lahti...@linux.intel.com> Signed-off-by: Jackie Li <yaodong...@intel.com> --- drivers/gpu/drm/i915/intel_guc.c| 12 +++- drivers/gpu/drm/i915/intel_guc.h| 10 -- drivers/gpu/drm/i915/intel_guc_ads.c| 25 + drivers/

[Intel-gfx] [PATCH v5 3/6] drm/i915/guc: Implement dynamic GuC WOPCM offset and size

2018-01-08 Thread Jackie Li
om> Cc: Chris Wilson <ch...@chris-wilson.co.uk> Cc: Joonas Lahtinen <joonas.lahti...@linux.intel.com> Signed-off-by: Jackie Li <yaodong...@intel.com> --- drivers/gpu/drm/i915/i915_gem_context.c | 9 +-- drivers/gpu/drm/i915/intel_guc.c| 5 +- drivers/gpu/drm/i9

[Intel-gfx] [RFC] drm/i915: Add a new modparam for customized ring multiplier

2017-12-18 Thread Jackie Li
tforms. Cc: Ben Widawsky <benjamin.widaw...@intel.com> Cc: Chris Wilson <ch...@chris-wilson.co.uk> Cc: Oscar Mateo <oscar.ma...@intel.com> Cc: Sagar Arun Kamble <sagar.a.kam...@intel.com> Cc: Dmitry Rogozhkin <dmitry.v.rogozh...@intel.com> Cc: Zhipeng Gong <zhipeng.g

[Intel-gfx] [PATCH v4 2/5] drm/i915/guc: Rename guc_ggtt_offset to intel_guc_ggtt_offset

2017-12-12 Thread Jackie Li
joonas.lahti...@linux.intel.com> Signed-off-by: Jackie Li <yaodong...@intel.com> --- drivers/gpu/drm/i915/intel_guc.c| 12 +++- drivers/gpu/drm/i915/intel_guc.h| 10 -- drivers/gpu/drm/i915/intel_guc_ct.c | 5 +++-- drivers/gpu/drm/i915/intel_g

[Intel-gfx] [PATCH v4 3/5] drm/i915/guc: Implement dynamic WOPCM partitioning

2017-12-12 Thread Jackie Li
ele Ceraolo Spurio <daniele.ceraolospu...@intel.com> Cc: John Spotswood <john.a.spotsw...@intel.com> Cc: Oscar Mateo <oscar.ma...@intel.com> Cc: Chris Wilson <ch...@chris-wilson.co.uk> Cc: Joonas Lahtinen <joonas.lahti...@linux.intel.com> Signed-off-by: Jackie Li <yaodong...@inte

[Intel-gfx] [PATCH v4 5/5] HAX Enable GuC Submission for CI

2017-12-12 Thread Jackie Li
Signed-off-by: Jackie Li <yaodong...@intel.com> --- drivers/gpu/drm/i915/i915_params.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_params.h b/drivers/gpu/drm/i915/i915_params.h index 792ce26..9725c5a 100644 --- a/drivers/gpu/dr

[Intel-gfx] [PATCH v4 1/5] drm/i915/guc: Move GuC WOPCM related code into separate files

2017-12-12 Thread Jackie Li
WOPCM related functions to a new source file intel_guc_wopcm.c Cc: Michal Wajdeczko <michal.wajdec...@intel.com> Cc: Sagar Arun Kamble <sagar.a.kam...@intel.com> Cc: Chris Wilson <ch...@chris-wilson.co.uk> Cc: Joonas Lahtinen <joonas.lahti...@linux.intel.com> Signed-of

[Intel-gfx] [PATCH v4 4/5] drm/i915/guc: Add WOPCM partitioning support for CNL

2017-12-12 Thread Jackie Li
hn Spotswood <john.a.spotsw...@intel.com> Cc: Jeff McGee <jeff.mc...@intel.com> Cc: Chris Wilson <ch...@chris-wilson.co.uk> Cc: Joonas Lahtinen <joonas.lahti...@linux.intel.com> Signed-off-by: Jackie Li <yaodong...@intel.com> --- drivers/gpu/drm/i915/intel_guc_wopcm.c |

[Intel-gfx] [PATCH v3 5/5] HAX Enable GuC Submission for CI

2017-12-08 Thread Jackie Li
Signed-off-by: Jackie Li <yaodong...@intel.com> --- drivers/gpu/drm/i915/i915_params.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_params.h b/drivers/gpu/drm/i915/i915_params.h index 792ce26..0ab0733 100644 --- a/drivers/gpu/dr

[Intel-gfx] [PATCH v3 4/5] drm/i915/guc: Add WOPCM partitioning support for CNL

2017-12-08 Thread Jackie Li
hn Spotswood <john.a.spotsw...@intel.com> Cc: Jeff McGee <jeff.mc...@intel.com> Signed-off-by: Jackie Li <yaodong...@intel.com> --- drivers/gpu/drm/i915/intel_guc_wopcm.c | 21 + drivers/gpu/drm/i915/intel_guc_wopcm.h | 3 +++ 2 files changed, 24 insertions(+) dif

[Intel-gfx] [PATCH v3 1/5] drm/i915/guc: Move GuC WOPCM related code into separate files

2017-12-08 Thread Jackie Li
WOPCM related functions to a new source file intel_guc_wopcm.c Cc: Michal Wajdeczko <michal.wajdec...@intel.com> Cc: Sagar Arun Kamble <sagar.a.kam...@intel.com> Signed-off-by: Jackie Li <yaodong...@intel.com> --- drivers/gpu/drm/i915/Makefile | 1 + drivers/gpu/dr

[Intel-gfx] [PATCH v3 2/5] drm/i915/guc: Rename guc_ggtt_offset to intel_guc_ggtt_offset

2017-12-08 Thread Jackie Li
lated code to pass intel_guc pointer to this function call. so that we have a unified coding style for GuC code. Cc: Michal Wajdeczko <michal.wajdec...@intel.com> Cc: Sagar Arun Kamble <sagar.a.kam...@intel.com> Signed-off-by: Jackie Li <yaodong...@intel.com> --- drivers/gpu/drm/i915

[Intel-gfx] [PATCH v3 3/5] drm/i915/guc: Implement dynamic WOPCM partitioning

2017-12-08 Thread Jackie Li
<michal.wajdec...@intel.com> Cc: Sagar Arun Kamble <sagar.a.kam...@intel.com> Cc: Sujaritha Sundaresan <sujaritha.sundare...@intel.com> Cc: Daniele Ceraolo Spurio <daniele.ceraolospu...@intel.com> Cc: John Spotswood <john.a.spotsw...@intel.com> Cc: Oscar Mateo <oscar.ma...@in

[Intel-gfx] [PATCH v2 1/2] drm/i915: Impletments dynamic WOPCM partitioning.

2017-11-15 Thread Jackie Li
the intel_wopcm_partition into intel_guc (Sagar) - Removed unnecessary function calls (Joonas) - Init GuC WOPCM partition as soon as firmware fetching is completed Signed-off-by: Jackie Li <yaodong...@intel.com> Cc: Michal Wajdeczko <michal.wajdec...@intel.com> Cc: Sagar Arun Kamble

[Intel-gfx] [PATCH v2 2/2] HAX enable guc submission for CI

2017-11-15 Thread Jackie Li
Signed-off-by: Jackie Li <yaodong...@intel.com> --- drivers/gpu/drm/i915/i915_gem_gtt.c | 8 ++-- drivers/gpu/drm/i915/i915_params.h | 4 ++-- 2 files changed, 4 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c b/drivers/gpu/drm/i915/i915_gem_gtt.c

[Intel-gfx] [PATCH 1/2] drm/i915: implemented dynamic WOPCM partition.

2017-11-03 Thread Jackie Li
WOPCM size was set to total WOPCM size - GuC WOPCM offset - RC6CTX size. Signed-off-by: Jackie Li <yaodong...@intel.com> Cc: Michal Wajdeczko <michal.wajdec...@intel.com> Cc: Sagar Arun Kamble <sagar.a.kam...@intel.com> Cc: Sujaritha Sundaresan <sujaritha.sundare...@intel.com

[Intel-gfx] [PATCH 2/2] HAX enable guc submission for CI

2017-11-03 Thread Jackie Li
Signed-off-by: Jackie Li <yaodong...@intel.com> --- drivers/gpu/drm/i915/i915_gem_gtt.c | 8 ++-- drivers/gpu/drm/i915/i915_params.h | 4 ++-- 2 files changed, 4 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c b/drivers/gpu/drm/i915/i915_gem_gtt.c

[Intel-gfx] [PATCH 2/2] HAX enable guc submission for CI

2017-11-03 Thread Jackie Li
Signed-off-by: Jackie Li <yaodong...@intel.com> --- drivers/gpu/drm/i915/i915_gem_gtt.c | 8 ++-- drivers/gpu/drm/i915/i915_params.h | 4 ++-- 2 files changed, 4 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c b/drivers/gpu/drm/i915/i915_gem_gtt.c

[Intel-gfx] [PATCH 1/2] drm/i915: implemented dynamic WOPCM partition.

2017-11-03 Thread Jackie Li
WOPCM size was set to total WOPCM size - GuC WOPCM offset - RC6CTX size. Signed-off-by: Jackie Li <yaodong...@intel.com> Cc: Michal Wajdeczko <michal.wajdec...@intel.com> Cc: Sagar Arun Kamble <sagar.a.kam...@intel.com> Cc: Sujaritha Sundaresan <sujaritha.sundare...@intel.com&