Re: [Intel-gfx] v4.20-rc1: list_del corruption on thinkpad x220

2018-11-23 Thread Joonas Lahtinen
Quoting Pavel Machek (2018-11-21 13:54:49) > Hi! > > > > My machine locked hard (thinkpad x220). After reboot, I found this in > > > syslog: > > > > > > Sounds like memory corruption..? Does not sound like easy to debug. > > > > Were you doing something GPU intense when you experienced the hard

Re: [Intel-gfx] [PATCH 2/2] gpu/i915: use HMM mirror for userptr buffer object.

2018-11-22 Thread Joonas Lahtinen
that it does no longer > have a fast path with get_user_pages_fast() this can eventually added > back through HMM. > > Signed-off-by: Jérôme Glisse > Cc: dri-de...@lists.freedesktop.org > Cc: David Airlie > Cc: Daniel Vetter > Cc: Chris Wilson > Cc: Lionel Landwerli

[Intel-gfx] [PULL] drm-intel-fixes

2018-11-22 Thread Joonas Lahtinen
Hi Dave, Here's the -fixes for 4.20-rc4. Stuck backlight/flickering fix for DSI screen and GPU hang fix for SNB are the main user visible ones. Then two more fixes to prevent GPU hangs in more rare scenarios. Regards, Joonas *** drm-intel-fixes-2018-11-22: - Fix for fastboot DSI panel boot

Re: [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: avoid rebuilding i915_gpu_error.o on version string updates

2018-11-22 Thread Joonas Lahtinen
Merged now, thanks for the patch and reviews. Quoting Patchwork (2018-11-22 02:05:03) > == Series Details == > > Series: drm/i915: avoid rebuilding i915_gpu_error.o on version string updates > URL : https://patchwork.freedesktop.org/series/52822/ > State : success > > == Summary == > > = CI

Re: [Intel-gfx] [PATCH] drm/i915: avoid rebuilding i915_gpu_error.o on version string updates

2018-11-21 Thread Joonas Lahtinen
Quoting Hans Holmberg (2018-11-21 13:35:19) > On Wed, Nov 21, 2018 at 11:10 AM Joonas Lahtinen > wrote: > > > > Quoting Hans Holmberg (2018-11-21 11:54:23) > > > From: Hans Holmberg > > > > > > There is no need to rebuild i915_gpu_error.o when th

Re: [Intel-gfx] v4.20-rc1: list_del corruption on thinkpad x220

2018-11-21 Thread Joonas Lahtinen
+ Chris Quoting Pavel Machek (2018-11-08 19:58:03) > Hi! > > My machine locked hard (thinkpad x220). After reboot, I found this in > syslog: > > Sounds like memory corruption..? Does not sound like easy to debug. Were you doing something GPU intense when you experienced the hard hang? And if

Re: [Intel-gfx] [PATCH] drm/i915: avoid rebuilding i915_gpu_error.o on version string updates

2018-11-21 Thread Joonas Lahtinen
Quoting Hans Holmberg (2018-11-21 11:54:23) > From: Hans Holmberg > > There is no need to rebuild i915_gpu_error.o when the version string > changes as the version is available in init_utsname()->release. > > Signed-off-by: Hans Holmberg Seems reasonable to me. Reviewe

Re: [Intel-gfx] [PATCH] drm/i915/selftests: Hold task reference to reset worker

2018-11-20 Thread Joonas Lahtinen
ug of the above bug, I'm not seeing other connection. Reviewed-by: Joonas Lahtinen Regards, Joonas ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH i-g-t 3/4] tests/gem_media_vme: Simple test to exercise the VME block

2018-11-20 Thread Joonas Lahtinen
+ Haihaho who's been involved with gem_media_fill test, if you could provide review, too. Quoting Tvrtko Ursulin (2018-11-13 16:36:28) > From: Tony Ye > > Simple test which exercises the VME fixed function block. > > v2: (Tvrtko Ursulin) > * Small cleanups like copyright date, tabs, remove

Re: [Intel-gfx] [igt-dev] [PATCH v17 2/4] tests/gem_ctx_sseu: Dynamic (sub)slice programming tests

2018-11-20 Thread Joonas Lahtinen
.size = sizeof(sseu), > + .value = to_user_pointer() }; ... and this don't seem to be consitent with kernel coding style, which I thought we try to use in IGT? There seems to be some other strangely indented structs too, with those fixed this is; Reviewed-by: Joonas L

Re: [Intel-gfx] [PATCH] drm/i915: Write GPU relocs harder with gen3

2018-11-20 Thread Joonas Lahtinen
lits # blb/pnv > Signed-off-by: Chris Wilson > Cc: Joonas Lahtinen > +++ b/drivers/gpu/drm/i915/i915_gem_execbuffer.c > @@ -1268,7 +1268,7 @@ relocate_entry(struct i915_vma *vma, > else if (gen >= 4) > len = 4

Re: [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Hide enable_gvt modparam when not compiled in

2018-11-19 Thread Joonas Lahtinen
Thanks for the reviews, pushed now. Regards, Joonas Quoting Patchwork (2018-11-16 17:31:58) > == Series Details == > > Series: drm/i915: Hide enable_gvt modparam when not compiled in > URL : https://patchwork.freedesktop.org/series/52616/ > State : success > > == Summary == > > = CI Bug Log

Re: [Intel-gfx] [PATCH 1/2] Revert "drm/i915/perf: add a parameter to control the size of OA buffer"

2018-11-19 Thread Joonas Lahtinen
Quoting Matthew Auld (2018-11-19 12:36:00) > On Fri, 16 Nov 2018 at 13:55, Joonas Lahtinen > wrote: > > > > Userspace portion is still missing. > > > > This reverts commit cd956bfcd0f58d20485ac0a785415f7d9327a95f. > > > > Cc: Lionel Landwerlin >

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Downgrade unknown CSR firmware warnings

2018-11-19 Thread Joonas Lahtinen
no firmware yet for a platform, stop scaring the > > consumer and merely note its expected absence. > > > > By simply removing the warning and early return we hit the condition > > with the appropriate message. > > > > Cc: Chris Wilson > > Cc: Joonas Lahtin

Re: [Intel-gfx] [PATCH] drm/i915: Downgrade unknown firmware warnings

2018-11-16 Thread Joonas Lahtinen
Quoting Chris Wilson (2018-10-09 14:12:59) > If we have released no firmware yet for a platform, stop scaring the > consumer and merely note its expected absence. > > Signed-off-by: Chris Wilson > Cc: Petri Latvala Reviewed-by: Joonas Lahtinen

Re: [Intel-gfx] [PATCH v3] drm/i915: Remove partial attempt to swizzle on pread/pwrite

2018-11-16 Thread Joonas Lahtinen
nt pwrite without struct-mutex") > Signed-off-by: Chris Wilson > Cc: Joonas Lahtinen > Cc: Tvrtko Ursulin > --- > drivers/gpu/drm/i915/i915_gem.c | 195 > 1 file changed, 25 insertions(+), 170 deletions(-) > > diff --git a/drivers/g

[Intel-gfx] [PATCH] drm/i915: Hide enable_gvt modparam when not compiled in

2018-11-16 Thread Joonas Lahtinen
Hide the enable_gvt modparam in the default scenario where support has not been compiled in. Cc: Zhenyu Wang Cc: Zhi Wang Cc: Chris Wilson Signed-off-by: Joonas Lahtinen --- drivers/gpu/drm/i915/i915_params.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/i915

Re: [Intel-gfx] [GVT-g] [ANNOUNCE] 2018-Q3 release of KVMGT (Intel GVT-g for KVM)

2018-11-16 Thread Joonas Lahtinen
Quoting Xu, Terrence (2018-10-19 10:04:47) > Platform Support: > > -Server platforms: Intel(r) Xeon(r) E3_v4, E3_v5 and E3_v6 with Intel > Graphics processor > > -Client platforms: Intel(r) Core(tm) 5th generation (code name: > Broadwell), > 6th generation (code name: Skylake), 7th

[Intel-gfx] [PATCH 1/2] Revert "drm/i915/perf: add a parameter to control the size of OA buffer"

2018-11-16 Thread Joonas Lahtinen
Userspace portion is still missing. This reverts commit cd956bfcd0f58d20485ac0a785415f7d9327a95f. Cc: Lionel Landwerlin Cc: Matthew Auld Signed-off-by: Joonas Lahtinen --- drivers/gpu/drm/i915/i915_drv.h | 1 - drivers/gpu/drm/i915/i915_perf.c | 99 +++- drivers

[Intel-gfx] [PATCH 2/2] Revert "drm/i915/perf: Fix warning in documentation"

2018-11-16 Thread Joonas Lahtinen
Userspace portion is still missing. This reverts commit 9fa6e2f7609fdbb7d6f86be86371a5719bec0376. Cc: Lionel Landwerlin Cc: Matthew Auld Signed-off-by: Joonas Lahtinen --- drivers/gpu/drm/i915/i915_perf.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_perf.c b

Re: [Intel-gfx] [PATCH v4 4/4] drm/i915/perf: add a parameter to control the size of OA buffer

2018-11-16 Thread Joonas Lahtinen
Quoting Lionel Landwerlin (2018-10-23 13:07:07) > The way our hardware is designed doesn't seem to let us use the > MI_RECORD_PERF_COUNT command without setting up a circular buffer. > > In the case where the user didn't request OA reports to be available > through the i915 perf stream, we can

Re: [Intel-gfx] [PATCH 05/25] drm/i915: Prevent machine hang from Broxton's vtd w/a and error capture

2018-11-16 Thread Joonas Lahtinen
Cc: John Harrison > Cc: Tvrtko Ursulin > Cc: Joonas Lahtinen > Cc: Daniel Vetter Might be worthy splurting something to the dmesg? Reviewed-by: Joonas Lahtinen Regards, Joonas ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH 36/36] drm/i915: Support per-context user requests for GPU frequency control

2018-11-16 Thread Joonas Lahtinen
st > > their request (and not restrict raising the minimum to privileged > > CAP_SYS_NICE clients). > > > > Testcase: igt/gem_ctx_freq > > Signed-off-by: Chris Wilson > > Cc: Joonas Lahtinen > > Cc: Tvrtko Ursulin > > Cc: Praveen Paneri >

Re: [Intel-gfx] [PATCH 5/5] drm/i915/fixed: cosmetic cleanup

2018-11-16 Thread Joonas Lahtinen
gt; WARN_ON(val > U32_MAX); > - fp.val = (u32)val; Reviewed-by: Joonas Lahtinen Regards, Joonas ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH 4/5] drm/i915/fixed: simplify is_fixed16_zero()

2018-11-16 Thread Joonas Lahtinen
Quoting Jani Nikula (2018-11-15 14:01:25) > Simply return the condition. No functional changes. > > Signed-off-by: Jani Nikula Reviewed-by: Joonas Lahtinen Regards, Joonas ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.

Re: [Intel-gfx] [PATCH 3/5] drm/i915/fixed: simplify FP_16_16_MAX definition

2018-11-16 Thread Joonas Lahtinen
Quoting Jani Nikula (2018-11-15 14:01:24) > No need to use a compound statement enclosed in parenthesis where a C99 > compound literal will do. No functional changes. > > Signed-off-by: Jani Nikula Out of curiosity, did this have an effect on asm generation? Presumably not. Reviewe

Re: [Intel-gfx] [PATCH 2/5] drm/i915/fixed: prefer kernel types over stdint types

2018-11-16 Thread Joonas Lahtinen
Quoting Jani Nikula (2018-11-15 14:01:23) > While at it, conform to kernel spacing (i.e. no space) after cast. No > functional changes. > > Signed-off-by: Jani Nikula Reviewed-by: Joonas Lahtinen Regards, Joonas ___ Intel-gfx mailing li

Re: [Intel-gfx] [PATCH 1/5] drm/i915: extract fixed point math to i915_fixed.h

2018-11-16 Thread Joonas Lahtinen
Quoting Jani Nikula (2018-11-15 14:01:22) > Reduce bloat in one of the bigger header files. Fix some indentation > while at it. No functional changes. > > Signed-off-by: Jani Nikula Do add include guards. Then this is: Reviewed-by: Joonas Lahtinen Reg

[Intel-gfx] [PULL] drm-intel-fixes

2018-11-15 Thread Joonas Lahtinen
Hi Dave, Most importantly we have a fix for an incorrect EU count reported from kernel, Gen9+ scaled output fix, and avoiding OOPS on MST display systems. So looking pretty stable. Regards, Joonas PS. Had some CI turbulence for this PR as we raised the bar so that now a loss of lockdep

Re: [Intel-gfx] Backports for drm-intel-fixes

2018-11-14 Thread Joonas Lahtinen
Quoting Joonas Lahtinen (2018-11-12 14:49:14) > The following patches with Fixes: do not cleanly apply > to drm-intel-fixes: > > - 5a3aeca97af1 ("drm/i915: Fix hpd handling for pins with two encoders") One more: - e7a278a329dd ("drm/i915: Account for scale factor when

Re: [Intel-gfx] [PATCH -fixes] drm/i915: Fix hpd handling for pins with two encoders

2018-11-12 Thread Joonas Lahtinen
Thanks for a quick backport, applied this now. Regards, Joonas ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] Backports for drm-intel-fixes

2018-11-12 Thread Joonas Lahtinen
The following patches with Fixes: do not cleanly apply to drm-intel-fixes: - 5a3aeca97af1 ("drm/i915: Fix hpd handling for pins with two encoders") Please provide a backported patch ASAP, if they are relevant to be backported. If they should not be included in drm-intel-fixes, please confirm

[Intel-gfx] [PULL] drm-intel-fixes

2018-11-08 Thread Joonas Lahtinen
/gvt: support inconsecutive partial gtt entry write Joonas Lahtinen (1): Merge tag 'gvt-fixes-2018-11-07' of https://github.com/intel/gvt-linux into drm-intel-fixes Longhe Zheng (1): drm/i915/gvt: Handle values of EDP_PSR_IMR and EDP_PSR_IIR Manasi Navare (1): drm/i915/icl: Fix

Re: [Intel-gfx] [PULL] gvt-fixes for 4.20-rc2

2018-11-07 Thread Joonas Lahtinen
Quoting Zhenyu Wang (2018-11-07 04:31:37) > > Hi, > > Here's re-generated -fixes pull for 4.20. Mostly on fixing > possible guest arbitrary update of GGTT entries, with one mask > fix for chicken register, and with one to fix eDP warning in guest. > > Thanks. Pulled. Thanks for re-spinning.

Re: [Intel-gfx] [PULL] gvt-next-fixes for 4.20

2018-11-06 Thread Joonas Lahtinen
Quoting Zhenyu Wang (2018-10-26 09:43:20) > On 2018.10.25 16:07:14 +0300, Joonas Lahtinen wrote: > > Quoting Zhenyu Wang (2018-10-23 06:46:59) > > > > > > Hi, > > > > > > Here's gvt-next-fixes for 4.20 with three changes. Mostly > > >

Re: [Intel-gfx] [PATCH] drm/i915: Break long iterations for get/put shmemfs pages

2018-11-06 Thread Joonas Lahtinen
> Testcase: igt/benchmarks/gem_syslatency > Signed-off-by: Chris Wilson > Cc: Kuo-Hsin Yang > Cc: Matthew Auld > Cc: Joonas Lahtinen Reviewed-by: Joonas Lahtinen Regards, Joonas ___ Intel-gfx mailing list Intel-g

Re: [Intel-gfx] [PATCH v4 2/2] drm/i915/icl: Define MOCS table for Icelake

2018-11-06 Thread Joonas Lahtinen
Quoting Tomasz Lis (2018-11-05 15:50:21) > +++ b/drivers/gpu/drm/i915/intel_mocs.c > @@ -44,6 +44,8 @@ struct drm_i915_mocs_table { > #define LE_SCC(value) ((value) << 8) > #define LE_PFM(value) ((value) << 11) > #define LE_SCF(value) ((value) << 14) > +#define

[Intel-gfx] [PULL] drm-intel-next-fixes

2018-10-25 Thread Joonas Lahtinen
Hi Dave, One fix to avoid applying link retraining workaround on eDP monitors that was missing Fixes: (kindly pointed out by Jani) in addition to the patches in previous PR. I also got GVT PR for -next-fixes, but it had an issue with S-o-bs, so I'll include it then in -fixes pull. Regards,

Re: [Intel-gfx] [PULL] gvt-next-fixes for 4.20

2018-10-25 Thread Joonas Lahtinen
Quoting Zhenyu Wang (2018-10-23 06:46:59) > > Hi, > > Here's gvt-next-fixes for 4.20 with three changes. Mostly > to fix possible arbitrary update on guest GGTT entry and > with proper invalidate of old entry. Another one for one > chicken reg mask fix. > > thanks Hi, DIM seems to be

Re: [Intel-gfx] [PATCH v2 2/6] drm/i915/dp: Restrict link retrain workaround to external monitors

2018-10-24 Thread Joonas Lahtinen
Quoting Jani Nikula (2018-10-23 14:56:13) > On Mon, 01 Oct 2018, Dhinakaran Pandiyan > wrote: > > On Mon, 2018-10-01 at 12:49 -0700, Rodrigo Vivi wrote: > >> On Mon, Sep 24, 2018 at 03:45:24PM -0700, Dhinakaran Pandiyan wrote: > >> > Commit '3cf71bc9904d ("drm/i915: Re-apply "Perform link

Re: [Intel-gfx] [PATCH v5] drm/i915/icl: Preempt-to-idle support in execlists.

2018-10-23 Thread Joonas Lahtinen
Quoting Lis, Tomasz (2018-10-19 19:00:15) > > > On 2018-10-16 12:53, Joonas Lahtinen wrote: > > Quoting Tomasz Lis (2018-10-15 20:29:18) > >> The patch adds support of preempt-to-idle requesting by setting a proper > >> bit within Execlist Control Register, and

Re: [Intel-gfx] [PATCH v2 2/2] drm/i915/icl: Add IOCTL for getting MOCS table version

2018-10-23 Thread Joonas Lahtinen
oduces a parameter which allows getting max version number > of the MOCS entries currently supported, ie. value of 2 would mean > only version 1 and version 2 entries are initialized and can be used > by the user mode clients. > > BSpec: 34007 > Signed-off-by: Tomasz Lis > Cc: Jo

[Intel-gfx] [PULL] drm-intel-next-fixes

2018-10-19 Thread Joonas Lahtinen
Hi Dave, Here are the promised MST fixes that were missing due to being in i915 tree, yet outside i915 directory. Further explanation in the previous PR's thread. Regards, Joonas *** drm-intel-next-fixes-2018-10-19: - The missing 4 MST patches that tooling didn't pick from drm core/nouveau

Re: [Intel-gfx] [PULL] drm-intel-next-fixes

2018-10-19 Thread Joonas Lahtinen
Quoting Daniel Vetter (2018-10-19 10:05:32) > On Fri, Oct 19, 2018 at 8:59 AM Joonas Lahtinen > wrote: > > > > Quoting Daniel Vetter (2018-10-18 22:32:00) > > > On Thu, Oct 18, 2018 at 6:57 PM Joonas Lahtinen > > > wrote: > > > > > > > >

Re: [Intel-gfx] [RFC 4/8] drm/i915: Group gen 10 display.

2018-10-19 Thread Joonas Lahtinen
Quoting Daniel Vetter (2018-10-19 11:30:46) > On Fri, Oct 19, 2018 at 11:03:53AM +0300, Jani Nikula wrote: > > On Thu, 18 Oct 2018, Rodrigo Vivi wrote: > > > Continuing with the goal of use less platform codenames: > > > let's group platforms who has gen10 display. > > > > Ahah, so this answers

Re: [Intel-gfx] [PULL] drm-intel-next-fixes

2018-10-19 Thread Joonas Lahtinen
Quoting Daniel Vetter (2018-10-18 22:32:00) > On Thu, Oct 18, 2018 at 6:57 PM Joonas Lahtinen > wrote: > > > > Hi Dave, > > > > Here comes the final set of fixes under -next-fixes umbrella. > > Next one will be then from -fixes, assuming a release next Sun

[Intel-gfx] [PULL] drm-intel-next-fixes

2018-10-18 Thread Joonas Lahtinen
Hi Dave, Here comes the final set of fixes under -next-fixes umbrella. Next one will be then from -fixes, assuming a release next Sun. Fixes for bunch of display related issues reported by users, then the MST fixes that were dropped from Rodrigos PR + further Icelake fixes and proactive

Re: [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Drop rpm wakeref on error in debugfs/i915_drop_caches_set

2018-10-18 Thread Joonas Lahtinen
Pushed, because I need to get this cherry picked and included in PR. Thanks for the review. Regards, Joonas Quoting Patchwork (2018-10-18 13:12:43) > == Series Details == > > Series: drm/i915: Drop rpm wakeref on error in debugfs/i915_drop_caches_set > URL :

[Intel-gfx] [PATCH] drm/i915: Drop rpm wakeref on error in debugfs/i915_drop_caches_set

2018-10-18 Thread Joonas Lahtinen
Use single exit point to drop rpm wakeref in case of an error. Fixes: 9d3eb2c33f03 ("drm/i915: Hold rpm wakeref for debugfs/i915_drop_caches_set") Signed-off-by: Joonas Lahtinen Cc: Chris Wilson Cc: Ville Syrjälä --- drivers/gpu/drm/i915/i915_debugfs.c | 3 ++- 1 file changed, 2

Re: [Intel-gfx] [PATCH v8] drm/i915: Add IOCTL Param to control data port coherency.

2018-10-16 Thread Joonas Lahtinen
erency (submissions that use CL_MEM_SVM_FINE_GRAIN_BUFFER resources) > * don't care about coherency at GEN ISA granularity (no performance impact) Might be worthy mentioning that this address space compatibility can be achieved with userptr + soft-pinning allocations to their process space addr

Re: [Intel-gfx] [RFC] GuC firmware versioning change

2018-10-16 Thread Joonas Lahtinen
Quoting Jeff McGee (2018-10-13 00:46:05) > On Fri, Oct 12, 2018 at 02:33:26PM -0700, Jeff McGee wrote: > > On Fri, Oct 12, 2018 at 01:51:46PM -0700, Rodrigo Vivi wrote: > > > On Fri, Oct 12, 2018 at 01:24:30PM -0700, Jeff McGee wrote: > > > > The GuC firmware team is proposing a change to the

Re: [Intel-gfx] [PATCH v5] drm/i915/icl: Preempt-to-idle support in execlists.

2018-10-16 Thread Joonas Lahtinen
pt_context() change. (Daniele) > Removed clearing HWACK flag in idle-to-idle preempt. (Daniele) > > v5: Renamed inject_preempt_context(). (Daniele) > Removed duplicated GEM_BUG_ON() on HWACK (Daniele) > > Bspec: 18922 > Cc: Joonas Lahtinen > Cc: Chris Wilson &

Re: [Intel-gfx] [PATCH v7] drm/i915: Engine discovery query

2018-10-05 Thread Joonas Lahtinen
Quoting Chris Wilson (2018-10-05 12:21:12) > Quoting Tvrtko Ursulin (2018-10-05 09:34:35) > > > > On 04/10/2018 15:32, Joonas Lahtinen wrote: > > > Some comments below, mostly related to trying to keep the uapi header > > > nice and tidy. > > > > &g

Re: [Intel-gfx] [PATCH] drm/i915: Only reset seqno if actually idle

2018-10-05 Thread Joonas Lahtinen
interrupted. > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108133 > Fixes: 6b048706f407 ("drm/i915: Forcibly flush unwanted requests in > drop-caches") > Signed-off-by: Chris Wilson > Cc: Joonas Lahtinen Review

Re: [Intel-gfx] [PATCH v7] drm/i915: Engine discovery query

2018-10-04 Thread Joonas Lahtinen
Some comments below, mostly related to trying to keep the uapi header nice and tidy. Quoting Tvrtko Ursulin (2018-10-04 14:32:48) > @@ -1747,6 +1748,52 @@ struct drm_i915_query_topology_info { > __u8 data[]; > }; > > +/** > + * struct drm_i915_engine_info > + * > + * Describes one

[Intel-gfx] [PULL] drm-intel-next-fixes

2018-10-04 Thread Joonas Lahtinen
Hi Dave, Here comes -fixes for drm-next. One compiler warning fix and adding back a removed max stride check, nothing end user visible. Regards, Joonas PS. Travelling next week, so I'll skip PR unless there's something big. --- drm-intel-next-fixes-2018-10-04: Compiler warning fix and

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t 1/5] igt/kms_getfb: Check the iface exists before use

2018-10-03 Thread Joonas Lahtinen
Quoting Antonio Argenziano (2018-10-02 23:27:46) > > > On 02/10/18 01:30, Joonas Lahtinen wrote: > > Quoting Antonio Argenziano (2018-10-01 22:53:46) > >> Fair enough. > >> > >> Acked-by: Antonio Argenziano > >> > >> for the s

Re: [Intel-gfx] Backports for drm-intel-next-fixes

2018-10-03 Thread Joonas Lahtinen
Quoting Ville Syrjälä (2018-10-02 16:43:00) > On Tue, Oct 02, 2018 at 12:56:02PM +0300, Joonas Lahtinen wrote: > > The following patches with Fixes: do not cleanly apply > > to drm-intel-next-fixes: > > > > 47658556da85 ("drm/i915/dp: Do not grab crtc mode

[Intel-gfx] Backports for drm-intel-next-fixes

2018-10-02 Thread Joonas Lahtinen
The following patches with Fixes: do not cleanly apply to drm-intel-next-fixes: 47658556da85 ("drm/i915/dp: Do not grab crtc modeset lock in intel_dp_detect()") Please provide a backported patch ASAP, if they are relevant to be backported. If they should not be included in drm-intel-next-fixes,

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t 1/5] igt/kms_getfb: Check the iface exists before use

2018-10-02 Thread Joonas Lahtinen
Quoting Antonio Argenziano (2018-10-01 22:53:46) > Fair enough. > > Acked-by: Antonio Argenziano > > for the series. Please, read the following chapters (they're applicable for the patch tag meanings in IGT, too):

Re: [Intel-gfx] [PATCH 4/7] drm/i915/icl: WaSendPushConstantsFromMMIO

2018-10-01 Thread Joonas Lahtinen
Why is this mixed with display workarounds? These were already once on the list and were decided not to be included as there are no known users. Regards, Joonas Quoting Radhakrishna Sripada (2018-09-28 19:47:35) > From: Oscar Mateo > > Allows UMDs to set 'Disable Gather at Set Shader Common

Re: [Intel-gfx] [PATCH 0/4][RFC] Dynamic EU configuration of Slice/Subslice/EU.

2018-09-27 Thread Joonas Lahtinen
+ Tvrtko for adding the right media contacts Quoting kedar.j.kara...@intel.com (2018-09-21 12:13:46) > From: "Kedar J. Karanje" > > drm/i915: Context aware user agnostic EU/Slice/Sub-slice control within kernel > > Current GPU configuration code for i915 does not allow us to change >

Re: [Intel-gfx] [RFC 4/4] drm/i915/registers: define field values using FIELD_PREP()

2018-09-27 Thread Joonas Lahtinen
Quoting Chris Wilson (2018-09-27 13:35:47) > Quoting Jani Nikula (2018-09-27 10:40:23) > > Slightly verbose, but does away with hand rolled shifts and provides > > static checking that the values fit the mask. > > > > Signed-off-by: Jani Nikula > > --- > > @@ -4650,11 +4650,11 @@ enum { > >

Re: [Intel-gfx] [RFC 03/10] drm/i915/gvt: context submission pvmmio optimization

2018-09-27 Thread Joonas Lahtinen
Quoting Xiaolin Zhang (2018-09-27 19:37:48) > It is performance optimization to reduce mmio trap numbers from 4 to > 1 durning ELSP porting writing (context submission). > > When context subission, to cache elsp_data[4] values in > the shared page, the last elsp_data[0] port writing will be

Re: [Intel-gfx] [RFC 00/10] i915 pvmmio to improve GVTg performance

2018-09-27 Thread Joonas Lahtinen
Quoting Xiaolin Zhang (2018-09-27 19:37:45) > To improve GVTg performance, it could reduce the mmio access trap > numbers within guest driver in some certain scenarios since mmio > access trap will introuduce vm exit/vm enter cost. > > the solution in this patch set is to setup a shared memory

Re: [Intel-gfx] [RFC 01/10] drm/i915/gvt: add module parameter enable_pvmmio

2018-09-27 Thread Joonas Lahtinen
Quoting Xiaolin Zhang (2018-09-27 19:37:46) > This int type module parameter is used to control the different > level pvmmio feature for MMIO emulation in GVT. > > This parameter is default zero, no pvmmio feature enabled. > > Its permission type is 0400 which means user could only change its >

Re: [Intel-gfx] [PATCH v5] drm/i915: Remove i915.enable_ppgtt override

2018-09-27 Thread Joonas Lahtinen
Quoting Chris Wilson (2018-09-27 11:55:03) > Quoting Joonas Lahtinen (2018-09-27 09:20:06) > > Quoting Chris Wilson (2018-09-26 23:12:22) > > > Now that we are confident in providing full-ppgtt where supported, > > > remove the ability to override the context isolati

[Intel-gfx] [PULL] drm-intel-next

2018-09-27 Thread Joonas Lahtinen
ext across S3/S4 drm/i915/selftests: Live tests emit requests and so require rpm drm/i915: Park the GPU on module load drm/i915/execlists: Onion unwind for logical_ring_init() failure Dhinakaran Pandiyan (1): drm/i915/psr: Enable AUX-A IO power well on ICL for PSR Joo

Re: [Intel-gfx] [PATCH v5] drm/i915: Remove i915.enable_ppgtt override

2018-09-27 Thread Joonas Lahtinen
. > > Signed-off-by: Chris Wilson > Cc: Joonas Lahtinen > Cc: Matthew Auld > Reviewed-by: Joonas Lahtinen #v3 + Jani for awareness when handling dinq, this solidifies existing uAPI And drops the reporting of 48-bit ppGTT through this getparam as we already have co

Re: [Intel-gfx] [PATCH i-g-t] lib: Unexport gem_gtt_type()

2018-09-26 Thread Joonas Lahtinen
Quoting Chris Wilson (2018-09-26 16:13:53) > Nobody uses the function directly, instead using the various helpers to > determine if ppgtt is present. > > Signed-off-by: Chris Wilson > Cc: Joonas Lahtinen Reviewed-by: Joonas Lahtinen

Re: [Intel-gfx] [PATCH i-g-t 2/2] igt/perf: gem.has_ppgtt is no longer used

2018-09-26 Thread Joonas Lahtinen
Quoting Chris Wilson (2018-09-26 16:09:09) > Remove gem.has_ppgtt as the information is no longer used. > > Signed-off-by: Chris Wilson > Cc: Joonas Lahtinen Reviewed-by: Joonas Lahtinen Regards, Joonas ___ Intel-gfx mailing li

Re: [Intel-gfx] [PATCH i-g-t 1/2] igt/pm_sseu: gem.has_ppgtt is no longer used

2018-09-26 Thread Joonas Lahtinen
Quoting Chris Wilson (2018-09-26 16:09:08) > Remove gem.has_ppgtt as the information is no longer used. > > Signed-off-by: Chris Wilson > Cc: Joonas Lahtinen Reviewed-by: Joonas Lahtinen Regards, Joonas ___ Intel-gfx mailing li

Re: [Intel-gfx] [PATCH v4] drm/i915: Remove i915.enable_ppgtt override

2018-09-26 Thread Joonas Lahtinen
Quoting Joonas Lahtinen (2018-09-25 16:27:47) > Quoting Chris Wilson (2018-09-25 14:48:20) > > Now that we are confident in providing full-ppgtt where supported, > > remove the ability to override the context isolation. > > > > v2: Remove faked aliasing-ppgtt

Re: [Intel-gfx] [PATCH v4] drm/i915: Remove i915.enable_ppgtt override

2018-09-26 Thread Joonas Lahtinen
t; From: Wang, Zhi A > > Sent: Wednesday, September 26, 2018 2:01 AM > > To: Joonas Lahtinen ; Chris Wilson > > ; intel-gfx@lists.freedesktop.org; Zhenyu Wang > > > > Cc: Auld, Matthew ; He, Min > > Subject: Re: [PATCH v4] drm/i915: Remove i915.enable_ppgtt ov

Re: [Intel-gfx] [PATCH v4] drm/i915: Remove i915.enable_ppgtt override

2018-09-25 Thread Joonas Lahtinen
reject attempts to load the module on > old GVT-g setups that do not provide support for full-ppgtt. > > Signed-off-by: Chris Wilson > Cc: Joonas Lahtinen > Cc: Matthew Auld > +++ b/drivers/gpu/drm/i915/i915_drv.c > @@ -345,7 +345,7 @@ static int i915_getparam_ioctl(s

Re: [Intel-gfx] [PATCH v4] drm/i915: Remove i915.enable_ppgtt override

2018-09-25 Thread Joonas Lahtinen
lation. > > v2: Remove faked aliasing-ppgtt for testing as it no longer is accepted. > v3: s/USES/HAS/ to match usage and reject attempts to load the module on > old GVT-g setups that do not provide support for full-ppgtt. > > Signed-off-by: Chris Wilson > Cc: Joonas L

Re: [Intel-gfx] [PATCH v2 2/2] drm/i915: Remove i915.enable_ppgtt override

2018-09-24 Thread Joonas Lahtinen
Quoting Chris Wilson (2018-09-22 17:18:04) > Now that we are confident in providing full-ppgtt where supported, > remove the ability to override the context isolation. > > v2: Remove faked aliasing-ppgtt for testing as it no longer is accepted. > > Signed-off-by: Chris Wi

Re: [Intel-gfx] [PATCH v2 1/2] drm/i915: Match code to comment and enforce ppgtt for execlists

2018-09-24 Thread Joonas Lahtinen
acy path; so rewrite the code to match the > comment by using HAS_EXECLISTS() feature instead of the gen. > > Signed-off-by: Chris Wilson > Cc: Matthew Auld Reviewed-by: Joonas Lahtinen Regards, Joonas ___ Intel-gfx mailing list Intel-g

[Intel-gfx] Updated drm-intel-testing

2018-09-21 Thread Joonas Lahtinen
Hi all, This is the final set of changes going for kernel v4.20, as per agreement with Dave, I did the tagging now before -rc5, and we should run some heavy testing on this during the beginning of next week. Regards, Joonas The following changes tagged drm-intel-testing-2018-09-21:

Re: [Intel-gfx] [PULL] gvt-fixes for 4.19-rc5

2018-09-19 Thread Joonas Lahtinen
Just a reminder, if you are still planning have gvt-next PR, tomorrow is your day :) Regards, Joonas Quoting Rodrigo Vivi (2018-09-18 18:53:10) > On Tue, Sep 18, 2018 at 03:33:49PM +0800, Zhenyu Wang wrote: > > > > Hi, > > > > Here's more gvt fixes for 4.19. Two more BXT fixes from Colin, > >

Re: [Intel-gfx] [PATCH 02/26] drm/i915: Reorder execobject[] to insert non-48b objects into the low 4G

2018-09-12 Thread Joonas Lahtinen
gesting 4GB region required for last object. */ Reviewed-by: Joonas Lahtinen Regards, Joonas > --- > drivers/gpu/drm/i915/i915_gem_execbuffer.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/i915/i915_gem_execbuffer.c > b/drivers/gpu/drm/i915/i9

Re: [Intel-gfx] [PATCH 01/26] drm/i915/ringbuffer: Reload PDs harder on byt/bcs

2018-09-12 Thread Joonas Lahtinen
(engine->id == BCS && IS_VALLEYVIEW(engine->i915)) > + loops = 32; > + > + do { > + ret = load_pd_dir(rq, ppgtt); > + if (ret) > +

Re: [Intel-gfx] [PATCH i-g-t] igt/gem_exec_capture: Fix command emission for gen3

2018-09-10 Thread Joonas Lahtinen
t target) > batch[++i] = 0; > } > batch[++i] = 0xc0ffee; > - if (gen < 3) > + if (gen <= 3) "gen < 4" would be more consistent with the usual checks. One would assume the evolution of the code to be that this if was added during development o

[Intel-gfx] [PULL] drm-intel-next

2018-09-07 Thread Joonas Lahtinen
t_offset_bias from i915_gem_context drm/i915: Add a fault injection point to WOPCM init Jan-Marek Glogowski (1): drm/i915: Re-apply "Perform link quality check, unconditionally during long pulse" Jani Nikula (1): drm/i915: set DP Main Stream Attribute for color range o

Re: [Intel-gfx] [PATCH 1/1] firmware/dmc/icl: load v1.07 on icelake.

2018-09-07 Thread Joonas Lahtinen
Quoting Rodrigo Vivi (2018-09-06 20:35:19) > On Thu, Sep 06, 2018 at 09:46:13AM +0300, Jani Nikula wrote: > > On Wed, 05 Sep 2018, Rodrigo Vivi wrote: > > > On Wed, Sep 05, 2018 at 12:07:43PM +0300, Joonas Lahtinen wrote: > > >> Was not the decision that we only

[Intel-gfx] Updated drm-intel-testing (this time its done right)

2018-09-06 Thread Joonas Lahtinen
Hi all, Disregard the previous message, and look at this tag instead :P I'll still apply the gvt-next pull and do one more tag. Regards, Joonas The following changes tagged drm-intel-testing-2018-09-06-1: drm-intel-next-2018-09-06-1: UAPI Changes: - GGTT coherency GETPARAM: GGTT has turned

Re: [Intel-gfx] [PULL] gvt-next for 4.20

2018-09-06 Thread Joonas Lahtinen
Quoting Zhenyu Wang (2018-09-04 06:01:54) > > Hi, > > Here's initial gvt-next for 4.20 with two optimization for > guest context shadowing and command parser, and with W=1 build fixes. Thanks, pulled this, but it had one merge conflict (in gvt/reg.h). Please make sure the resolution I put in

[Intel-gfx] Updated drm-intel-testing

2018-09-06 Thread Joonas Lahtinen
Hi all, The following changes tagged drm-intel-testing-2018-09-06: drm-intel-next-2018-09-06: UAPI Changes: - GGTT coherency GETPARAM: GGTT has turned out to be non-coherent for some platforms, which we've failed to communicate to userspace so far. SNA was modified to do extra flushing on

Re: [Intel-gfx] [PATCH 1/1] firmware/dmc/icl: load v1.07 on icelake.

2018-09-06 Thread Joonas Lahtinen
Quoting Rodrigo Vivi (2018-09-05 19:42:28) > On Wed, Sep 05, 2018 at 12:07:43PM +0300, Joonas Lahtinen wrote: > > Quoting Rodrigo Vivi (2018-09-04 08:27:14) > > > On Mon, Sep 03, 2018 at 01:00:39PM +0300, Imre Deak wrote: > > > > On Mon, Aug 27, 2018 at 05:38:44P

Re: [Intel-gfx] [PATCH 06/21] drm/i915/guc: Use guc_class instead of engine_class in fw interface

2018-09-06 Thread Joonas Lahtinen
Quoting Michal Wajdeczko (2018-08-29 22:10:40) > Until now the GuC and HW engine class has been the same, which allowed > us to use them interchangeable. But it is better to start doing the > right thing and use the GuC definitions for the firmware interface. > > We also keep the same class id in

Re: [Intel-gfx] [PATCH 04/21] drm/i915/guc: Support dual Gen9/Gen11 parameters block

2018-09-06 Thread Joonas Lahtinen
Quoting Michal Wajdeczko (2018-08-29 22:10:38) > Gen11 GuC boot parameter definitions are different than previously > used for Gen9. Try to support both definitions until new firmwares > for pre-Gen11 will be available. This is exactly the kind of branching we want to avoid. Purpose of the GuC is

Re: [Intel-gfx] [PATCH 03/21] drm/i915/guc: Simplify preparation of GuC parameter block

2018-09-06 Thread Joonas Lahtinen
Quoting Michal Wajdeczko (2018-08-29 22:10:37) > Definition of the parameters block passed to GuC is about to change. > Slightly refactor code now to make upcoming patch smaller. > > Signed-off-by: Michal Wajdeczko > Cc: Joonas Lahtinen > Cc: John Spotswood Reviewed-b

Re: [Intel-gfx] [PATCH 02/21] drm/i915/guc: Don't allow GuC submission on pre-Gen11

2018-09-06 Thread Joonas Lahtinen
n enable HuC authentication but nothing else on pre-Gen11. > > Signed-off-by: Michal Wajdeczko > Cc: Joonas Lahtinen > Cc: Rodrigo Vivi > Cc: Daniele Ceraolo Spurio > Cc: Michel Thierry > Cc: John Spotswood > Cc: Vinay Belgaumkar > Cc: Tony Ye > Cc: Anusha Srivatsa > C

Re: [Intel-gfx] [PATCH 02/21] drm/i915/guc: Don't allow GuC submission on pre-Gen11

2018-09-06 Thread Joonas Lahtinen
Quoting Michal Wajdeczko (2018-08-29 22:10:36) > Upcoming Gen11 GuC firmware requires new interface that is incompatible > with existing pre-Gen11 firmwares. Updated firmwares for pre-Gen11 will > arrive later. In the meantime sanitize the enable_guc option so that we > can enable HuC

Re: [Intel-gfx] [PATCH 1/1] firmware/dmc/icl: load v1.07 on icelake.

2018-09-05 Thread Joonas Lahtinen
Quoting Rodrigo Vivi (2018-09-04 08:27:14) > On Mon, Sep 03, 2018 at 01:00:39PM +0300, Imre Deak wrote: > > On Mon, Aug 27, 2018 at 05:38:44PM -0700, Anusha Srivatsa wrote: > > > Add Support to load DMC on Icelake. > > > > > > While at it, also add support to load the firmware > > > during system

Re: [Intel-gfx] [PATCH 2/2] drm/i915/tracepoints: Remove DRM_I915_LOW_LEVEL_TRACEPOINTS Kconfig option

2018-09-04 Thread Joonas Lahtinen
ping up to develop and maintain the tool. So I'll stop here until that happens. Regards, Joonas > -Original Message- > From: Joonas Lahtinen [mailto:joonas.lahti...@linux.intel.com] > Sent: Wednesday, August 29, 2018 5:52 PM > To: Intel-gfx@lists.freedesktop.org; Kukanova, Sve

Re: [Intel-gfx] [PATCH 2/5] drm/i915: Flag any possible writes for a GTT fault

2018-09-03 Thread Joonas Lahtinen
y be written to, although this is supposed to be > indicated by set-domain there are cases (e.g. after swap) where > userspace may not be aware of the implicit domain change. > > Signed-off-by: Chris Wilson Reviewed-by: Joonas Lahtinen Regards, Joonas _

Re: [Intel-gfx] [PATCH 5/5] drm/i915: Forcibly flush unwanted requests in drop-caches

2018-09-03 Thread Joonas Lahtinen
trip through hangcheck for each. > > It reduces the inter-test operation to just a write into drop-caches to > reset driver/GPU state between tests. > > Signed-off-by: Chris Wilson Reviewed-by: Joonas Lahtinen Regards, Joonas ___ Intel

Re: [Intel-gfx] [PATCH 4/5] drm/i915: Early rejection of buffer allocations larger than RAM

2018-09-03 Thread Joonas Lahtinen
s obviously too large, error out early. We opt to do > this in the backend to make it easy to use alternate paths that do not > require the entire object pinned, or may easily handle proxy objects > that are larger than physical memory. > > Signed-off-by: Chris Wilson Reviewed

Re: [Intel-gfx] [PATCH 3/5] drm/i915: Force the slow path after a user-write error

2018-09-03 Thread Joonas Lahtinen
batch to use the correct offset, it no longer matches the > presumed_offset in the relocation, so a second pass may miss any changes > in layout. > > Signed-off-by: Chris Wilson Reviewed-by: Joonas Lahtinen Regards, Joonas ___ Intel-gf

<    1   2   3   4   5   6   7   8   9   10   >