Re: [Intel-gfx] [PATCH for stable 3.14 only 1/1] drm/i915: restore QUIRK_NO_PCH_PWM_ENABLE

2014-04-29 Thread Kamal Mostafa
QUIRK_NO_PCH_PWM_ENABLE for a couple of Dell XPS models which broke in 3.14. Confirmed: This patch (restore QUIRK_NO_PCH_PWM_ENABLE) on top of 3.14.2 does fix it again for the two affected models. Tested-by: Kamal Mostafa ka...@canonical.com Thanks, Jani! -Kamal There is no such revert upstream. We

Re: [Intel-gfx] [PATCH 2/2] drm/i915: do not setup backlight if not available according to VBT

2014-04-09 Thread Kamal Mostafa
quirk. Tested-by: Kamal Mostafa ka...@canonical.com Thanks Jani! -Kamal AFAICT the quirk removed by the above commit effectively resulted in i915 not driving the backlight PWM output, thus not messing things up. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=76276 Reference: https

Re: [Intel-gfx] [PATCH 15/19] drm/i915: i915.quirks_set/quirks_mask overrides dmi match

2013-09-17 Thread Kamal Mostafa
On Wed, 2013-09-11 at 11:21 +0300, Jani Nikula wrote: On Wed, 11 Sep 2013, Rodrigo Vivi rodrigo.v...@gmail.com wrote: From: Kamal Mostafa ka...@canonical.com Boot params quirks_set and quirks_mask allow the user to enable or inhibit any dmi-matched quirks, overriding the dmi match table

[Intel-gfx] [PATCH] drm/i915: i915.quirks_set/quirks_mask overrides dmi match

2013-09-04 Thread Kamal Mostafa
QUIRK_NO_PCH_PWM_ENABLE i915.quirks_mask=0xFF - disables all quirks Signed-off-by: Kamal Mostafa ka...@canonical.com Cc: sta...@vger.kernel.org --- drivers/gpu/drm/i915/intel_display.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers

[Intel-gfx] [PATCH] drm/i915: i915.disable_pch_pwm overrides PCH_PWM_ENABLE quirk

2013-09-03 Thread Kamal Mostafa
: auto (default; allows the disabling of pch_pwm by dmi quirk table match) 0: inhibits the disabling of pch_pwm (overrides dmi quirk table match) 1: forces the disabling of pch_pwm Signed-off-by: Kamal Mostafa ka...@canonical.com --- drivers/gpu/drm/i915/i915_drv.c | 4 drivers/gpu/drm

Re: [Intel-gfx] [PATCH] drm/i915: i915.disable_pch_pwm overrides PCH_PWM_ENABLE quirk

2013-09-03 Thread Kamal Mostafa
On Tue, 2013-09-03 at 19:50 +0200, Daniel Vetter wrote: On Tue, Sep 3, 2013 at 7:37 PM, Kamal Mostafa ka...@canonical.com wrote: BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=47941 Some BIOS configurations of Dell XPS13 are adversely affected by e85843b (drm/i915: quirk

Re: [Intel-gfx] Linux 3.11-rc2 (acpi backlight, revert)

2013-07-25 Thread Kamal Mostafa
Reported-by: James Hogan ja...@albanarts.com Reported-by: Steven Newbury st...@snewbury.org.uk Reported-by: Kamal Mostafa ka...@canonical.com Reported-by: Martin Steigerwald mar...@lichtvoll.de Reported-by: Jörg Otte jrg.o...@gmail.com Reported-by: Kalle Valo kv...@adurom.com Signed-off-by: Rafael J

Re: [Intel-gfx] Linux 3.11-rc2 (acpi backlight, revert)

2013-07-25 Thread Kamal Mostafa
On Thu, 2013-07-25 at 16:46 +0200, Daniel Vetter wrote: On Thu, Jul 25, 2013 at 07:43:17AM -0700, Kamal Mostafa wrote: On Thu, 2013-07-25 at 15:00 +0200, Rafael J. Wysocki wrote: On Monday, July 22, 2013 09:54:21 PM Rafael J. Wysocki wrote: On Monday, July 22, 2013 11:11:54 AM Linus

[Intel-gfx] [PATCH] drm/i915: quirk no PCH_PWM_ENABLE for Dell XPS13 backlight

2013-07-19 Thread Kamal Mostafa
this quirk to Dell XPS 13 models. Tested-by: Eric Griffith egriffit...@gmail.com Tested-by: Kent Baxley kent.bax...@canonical.com Cc: sta...@vger.kernel.org # v3.8+ Signed-off-by: Kamal Mostafa ka...@canonical.com --- drivers/gpu/drm/i915/i915_drv.h | 1 + drivers/gpu/drm/i915/intel_display.c | 16

Re: [Intel-gfx] i915 PCH backlight vs. Dell XPS13

2013-02-12 Thread Kamal Mostafa
On Fri, Feb 8, 2013 at 8:36 PM, Kamal Mostafa ka...@canonical.com wrote: Daniel's backlight fixes which landed in 3.6 did enable working backlight controls on the XPS13, but it appears that this commit from Paolo broke it again: a4f32fc drm/i915: don't forget the PCH backlight

Re: [Intel-gfx] [PATCH 1/2] drm/i915: i915.enable_backlight=0 disables intel_backlight

2012-05-14 Thread Kamal Mostafa
consider applying this patch 1/2. Thanks, -Kamal [0] https://bugs.launchpad.net/ubuntu/+source/linux/+bug/954661/comments/27 On Thu, 2012-04-26 at 22:07 +0200, Daniel Vetter wrote: On Wed, Apr 25, 2012 at 10:28:41AM -0700, Kamal Mostafa wrote: i915.enable_backlight=0 can be used to disable

Re: [Intel-gfx] [PATCH 2/2] drm/i915: quirk disable i915 backlight on Dell XPS 13z

2012-05-14 Thread Kamal Mostafa
Hi Daniel- Reminding you of this issue... I've sent the register dump you asked for... You said you had an idea? Thanks very much for looking into it, -Kamal On Fri, 2012-04-27 at 14:55 -0700, Kamal Mostafa wrote: On Fri, 2012-04-27 at 23:25 +0200, Daniel Vetter wrote: Hm. Can you please

Re: [Intel-gfx] [PATCH 1/2] drm/i915: i915.enable_backlight=0 disables intel_backlight

2012-04-27 Thread Kamal Mostafa
On Thu, 2012-04-26 at 22:07 +0200, Daniel Vetter wrote: On Wed, Apr 25, 2012 at 10:28:41AM -0700, Kamal Mostafa wrote: i915.enable_backlight=0 can be used to disable i915 backlight control and the /sys/class/backlight/intel_backlight interface -- useful for systems where intel_backight

Re: [Intel-gfx] [PATCH 2/2] drm/i915: quirk disable i915 backlight on Dell XPS 13z

2012-04-27 Thread Kamal Mostafa
intel_backlight fix, but in the meantime disabling it by quirk seems appropriate for this machine, since that allows the acpi_video0 interface to work out of the box. Thanks for considering it, -Kamal On Wed, 2012-04-25 at 10:28 -0700, Kamal Mostafa wrote: From: Robert Hooker robert.hoo

Re: [Intel-gfx] [PATCH 2/2] drm/i915: quirk disable i915 backlight on Dell XPS 13z

2012-04-27 Thread Kamal Mostafa
On Fri, 2012-04-27 at 23:25 +0200, Daniel Vetter wrote: Hm. Can you please install intel-gpu-tools and attach the output of intel_reg_dumper? I have an idea ... Here it is with intel_backlight/brightness set to 1 (strobe light behavior occurring): PGETBL_CTL: 0x

[Intel-gfx] [PATCH 1/2] drm/i915: i915.enable_backlight=0 disables intel_backlight

2012-04-25 Thread Kamal Mostafa
i915.enable_backlight=0 can be used to disable i915 backlight control and the /sys/class/backlight/intel_backlight interface -- useful for systems where intel_backight conflicts with BIOS backlight control. BugLink: https://launchpad.net/bugs/954661 Signed-off-by: Kamal Mostafa ka

[Intel-gfx] [PATCH 2/2] drm/i915: quirk disable i915 backlight on Dell XPS 13z

2012-04-25 Thread Kamal Mostafa
From: Robert Hooker robert.hoo...@canonical.com Dell XPS 13z exhibits problems (backlight flashing/pulsating) when intel_backlight is enabled at all, so disable it. BugLink: https://launchpad.net/bugs/954661 Signed-off-by: Robert Hooker robert.hoo...@canonical.com Signed-off-by: Kamal Mostafa ka

Re: [Intel-gfx] [PATCH] i915: Fix bug where screen brightness is not restored

2011-11-15 Thread Kamal Mostafa
allows the correct brightness value to be saved. Signed-off-by: Alex Davis alex14...@yahoo.com Tested-by: Kamal Mostafa ka...@canonical.com - diff --git a/drivers/gpu/drm/i915/intel_panel.c b/drivers/gpu/drm/i915/intel_panel.c index a9e0c7b..6f56676 100644 --- a/drivers/gpu/drm/i915

Re: [Intel-gfx] [PATCH] i915: Fix bug where screen brightness is not restored

2011-11-15 Thread Kamal Mostafa
indeed fix the problem[1] for me. Thanks! Tested-by: Kamal Mostafa ka...@canonical.com -Kamal [0] f52c619a590fa75276c07dfcaf380dee53e4ea4c drm/i915/panel: Always record the backlight level again (but cleverly) [1] https://bugs.launchpad.net/ubuntu/+source/linux/+bug/872652 --- diff

[Intel-gfx] [PATCH] i915: do not setup intel_backlight twice

2011-08-22 Thread Kamal Mostafa
://bugs.launchpad.net/bugs/831542 Signed-off-by: Kamal Mostafa ka...@canonical.com --- drivers/gpu/drm/i915/intel_display.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c index ee1d701..5a1ae9f 100644

Re: [Intel-gfx] i915 native backlight never got merged

2011-08-12 Thread Kamal Mostafa
fa7419eee713b989e2c268c7b06ec9a544a2b647 Mon Sep 17 00:00:00 2001 I'll merge this version, with the change to make intel_panel_init_backlight static (it's not declared in a header, and isn't used outside of intel_panel.c). That version works also works fine for me. Tested-by: Kamal Mostafa ka...@canonical.com -Kamal

Re: [Intel-gfx] i915 native backlight never got merged

2011-08-11 Thread Kamal Mostafa
). My thanks to you and Matthew! Tested-by: Kamal Mostafa ka...@canonical.com -Kamal From 2c17b1ae587289501029daa5c0692818b88d21a6 Mon Sep 17 00:00:00 2001 From: Matthew Garrett m...@redhat.com Date: Fri, 14 Jan 2011 14:24:22 -0500 Subject: [PATCH] i915: Add native backlight control Not all

Re: [Intel-gfx] [RFC PATCH 0/2] i915 brightness control

2010-09-24 Thread Kamal Mostafa
includes your patches, plus my dell_laptop tweaks to inhibit the broken dell_backlight by a module param or dmi blacklist table (in lieu of a yet to be implemented more fine-grained check). -Kamal Mostafa ka...@canonical.com [1] 2010-09-08 [Intel-gfx] [PATCH] i915: Add native backlight control

[Intel-gfx] [RFC PATCH 1/2] acpi/video: acpi_brightness_hook API

2010-06-02 Thread Kamal Mostafa
BugLink: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/568611 New acpi_brightness_hook_register lets another driver (e.g. i915) override the often-dysfunctional native acpi brightness control methods. Signed-off-by: Kamal Mostafa ka...@canonical.com --- drivers/acpi/video.c | 149

[Intel-gfx] [RFC PATCH 2/2] drm/i915: override acpi brightness control

2010-06-02 Thread Kamal Mostafa
BugLink: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/568611 Override acpi brightness control with i915-opregion method. Signed-off-by: Kamal Mostafa ka...@canonical.com --- drivers/gpu/drm/i915/i915_opregion.c | 19 +++ 1 files changed, 19 insertions(+), 0 deletions