Re: [Intel-gfx] [PATCH v3 04/27] drm: Don't test for IRQ support in VBLANK ioctls

v, DRIVER_LEGACY))) > > > > > > return dev->irq_enabled; > > > > > > #endif > > > return drm_dev_has_vblank(dev); > > > > > > } > > > > > > > > > ? > > > > &g

Re: [Intel-gfx] [PATCH 44/53] docs: gpu: avoid using UTF-8 chars

as much as possible between different products. > To > achieve this, split the komeda device into two layers: CORE and CHIP. > > - CORE: for common features and capabilities handling. Acked-by: Liviu Dudau Best regards, Liviu > -- > 2.30.2 > -- =

Re: [Intel-gfx] [PATCH 2/8] drm/arm/malidp: Always list modifiers

On Tue, Apr 27, 2021 at 11:20:12AM +0200, Daniel Vetter wrote: > Even when all we support is linear, make that explicit. Otherwise the > uapi is rather confusing. :) > > Cc: sta...@vger.kernel.org > Cc: Pekka Paalanen > Cc: Liviu Dudau > Cc: Brian Starkey > Sign

Re: [Intel-gfx] [PATCH 1/8] drm/arm: Don't set allow_fb_modifiers explicitly

nit > > this is done automatically as part of plane init, if drivers set the > modifier list correctly. Which is the case here for both komeda and > malidp. > > Signed-off-by: Daniel Vetter > Cc: "James (Qian) Wang" > Cc: Liviu Dudau Acked-by: Liviu Dudau Best rega

Re: [Intel-gfx] [PATCH 10/65] drm/malidp: Annotate dma-fence critical section in commit path

Vetter > Cc: "James (Qian) Wang" > Cc: Liviu Dudau Acked-by: Liviu Dudau Thanks for the patch! Best regards, Liviu > Cc: Mihail Atanassov > --- > drivers/gpu/drm/arm/malidp_drv.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/gpu/drm

Re: [Intel-gfx] [PATCH i-g-t v9 0/4] Add support for testing writeback connectors

On Fri, Sep 04, 2020 at 02:56:05PM +0300, Petri Latvala wrote: > On Fri, Sep 04, 2020 at 12:09:18PM +0100, Liviu Dudau wrote: > > On Sun, Aug 30, 2020 at 01:44:06PM -0400, Rodrigo Siqueira wrote: > > > Hi, > > > > Hi, > > > > Can this series be merged?

Re: [Intel-gfx] [PATCH i-g-t v9 0/4] Add support for testing writeback connectors

hset made by > Brian Starkey and Liviu Dudau for adding a writeback connectors test to > IGT. It is important to highlight that DRM already have writeback > connectors support, which is a way to expose in DRM the hardware > functionality from display engines that allows writing back int

Re: [Intel-gfx] [PATCH 08/25] drm/malidp: Annotate dma-fence critical section in commit path

to do a testing for this patch but when I dug out the series from the ML it looked like it has extra dependencies, so I was waiting for the dust to settle. Otherwise, LGTM. Best regards, Liviu > > Signed-off-by: Daniel Vetter > Cc: "James (Qian) Wang" > Cc: Liviu Dudau > Cc

Re: [Intel-gfx] [PATCH] drm/malidp: Don't call drm_crtc_vblank_off on unbind

reordered. Got confused by the subject not having any version of the patch, so I've acked the other one, but this is the one I've meant to Ack. So, Acked-by: Liviu Dudau Best regards, Liviu > > Signed-off-by: Daniel Vetter > Cc: Liviu Dudau > Cc: Brian Starkey > --- > dri

Re: [Intel-gfx] [PATCH 3/3] drm/hdlcd: Don't call drm_crtc_vblank_off on unbind

n crtc, so need to reorder that. > > Signed-off-by: Daniel Vetter > Cc: Liviu Dudau Acked-by: Liviu Dudau Best regards, Liviu > Cc: Brian Starkey > Cc: > --- > drivers/gpu/drm/arm/hdlcd_drv.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/

Re: [Intel-gfx] [PATCH 2/3] drm/malidp: Don't call drm_crtc_vblank_off on unbind

s hitting warnings from 84014b0a39eef6df ("drm/atomic-helper: check that drivers call drm_crtc_vblank_off"), but I'm happy that things have now been fixed. > Signed-off-by: Daniel Vetter > Cc: Liviu Dudau Acked-by: Liviu Dudau Best regards, Liviu > Cc: Brian Starkey > C

Re: [Intel-gfx] [PATCH] drm/atomic-helper: reset vblank on crtc reset

474800f076c7cb > Reported-by: Tetsuo Handa > Reported-by: syzbot+0871b14ca2e2fb64f...@syzkaller.appspotmail.com > Cc: Tetsuo Handa > Cc: "James (Qian) Wang" > Cc: Liviu Dudau > Cc: Mihail Atanassov > Cc: Brian Starkey > Cc: Sam Ravnborg > Cc: Boris Brezillon

Re: [Intel-gfx] [PATCH] drm/atomic-helper: reset vblank on crtc reset

On Wed, May 27, 2020 at 01:07:05PM +0200, Daniel Vetter wrote: > On Wed, May 27, 2020 at 12:57 PM Liviu Dudau wrote: > > > > Hi Daniel, > > > > On Wed, May 27, 2020 at 11:53:32AM +0200, Daniel Vetter wrote: > > > Only when vblanks are supported ofc. >

Re: [Intel-gfx] [PATCH] drm/atomic-helper: reset vblank on crtc reset

/bug?id=0ba17d70d062b2595e1f061231474800f076c7cb > Reported-by: Tetsuo Handa > Reported-by: syzbot+0871b14ca2e2fb64f...@syzkaller.appspotmail.com > Cc: Tetsuo Handa > Cc: "James (Qian) Wang" > Cc: Liviu Dudau > Cc: Mihail Atanassov > Cc: Brian Starkey > Cc: Sam Ravnborg > Cc: Bor

Re: [Intel-gfx] [PATCH 18/51] drm/: Use drmm_add_final_kfree

On Thu, Feb 27, 2020 at 07:14:49PM +0100, Daniel Vetter wrote: > These are the leftover drivers that didn't have a ->release hook that > needed to be updated. > > Signed-off-by: Daniel Vetter > Cc: "James (Qian) Wang" > Cc: Liviu Dudau > Cc: Mihail Atanassov

Re: [Intel-gfx] [PATCH v7 i-g-t 0/4] Add support for testing writeback connectors

patchset made by > Brian Starkey and Liviu Dudau for adding a writeback connectors test to > IGT. It is important to highlight that DRM already have writeback > connectors support, which is a way to expose in DRM the hardware > functionality from display engines that allows wri

Re: [Intel-gfx] [PATCH 11/59] drm/arm: Drop drm_gem_prime_export/import

On Fri, Jun 14, 2019 at 10:35:27PM +0200, Daniel Vetter wrote: > They're the default. > > Aside: Would be really nice to switch the others over to > drm_gem_object_funcs. > > Signed-off-by: Daniel Vetter > Cc: "James (Qian) Wang" > Cc: Liviu Dudau > Cc:

Re: [Intel-gfx] [PATCH 07/59] drm/arm/komeda: Remove DRIVER_HAVE_IRQ

On Fri, Jun 14, 2019 at 10:35:23PM +0200, Daniel Vetter wrote: > Read the docs, komeda is not an old enough driver for this :-) > > Signed-off-by: Daniel Vetter > Cc: "James (Qian) Wang" > Cc: Liviu Dudau Acked-by: Liviu Dudau I'm assuming the whole series goes thr

Re: [Intel-gfx] [PATCH V6 i-g-t 1/6] lib/igt_kms: Add writeback support

On Wed, Jun 12, 2019 at 11:16:02PM -0300, Brian Starkey wrote: > Add support in igt_kms for writeback connectors, with the ability > to attach framebuffers. > > v5: Rebase and add DRM_CLIENT_CAP_WRITEBACK_CONNECTORS before > drmModeGetResources() Reviewed-by: Liviu Dudau Than

Re: [Intel-gfx] [PATCH] drm/gamma: Clarify gamma lut uapi

Anholt > Cc: Maarten Lankhorst > Cc: Harry Wentland > Cc: Leo Li > Cc: amd-...@lists.freedesktop.org > Cc: James (Qian) Wang > Cc: Liviu Dudau > Cc: Mali DP Maintainers > Cc: CK Hu > Cc: Philipp Zabel > Cc: Yannick Fertre > Cc: Philippe Cornu > Cc

Re: [Intel-gfx] [PATCH v2] drm: prefix header search paths with $(srctree)/

da/Makefile > b/drivers/gpu/drm/arm/display/komeda/Makefile > index 1b875e5..a72e30c 100644 > --- a/drivers/gpu/drm/arm/display/komeda/Makefile > +++ b/drivers/gpu/drm/arm/display/komeda/Makefile > @@ -1,8 +1,8 @@ > # SPDX-License-Identifier: GPL-2.0 > > ccflags-y :=

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t v5 1/6] lib/igt_kms: Add writeback support

On Mon, Mar 18, 2019 at 07:05:29PM -0300, Rodrigo Siqueira wrote: > On 03/18, Liviu Dudau wrote: > > On Wed, Mar 06, 2019 at 06:30:05PM -0300, Rodrigo Siqueira wrote: > > > Hi Liviu, > > > > > > I’m using your patchset to guide my implementation of writeback

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t v5 1/6] lib/igt_kms: Add writeback support

play->drm_fd); > igt_assert(plane_resources); > > I'm not 100% confident about this issue, because of this I will send an > RFC and see if I can get more details about this issue. It actually looks correct to me, so Acked-by: Liviu Dudau > > Additionally, if you n

Re: [Intel-gfx] [PATCH 05/17] drm/mali: Convert to using __drm_atomic_helper_crtc_reset() for reset.

> Signed-off-by: Maarten Lankhorst > Cc: Liviu Dudau Acked-by: Liviu Dudau If you need me to take this patch into malidp tree let me know, otherwise I expect is going to show up in drm-misc-next at some moment. Best regards, Liviu > Cc: Brian Starkey > --- > drivers/gpu

[Intel-gfx] [PATCH i-g-t v6] lib: Add function to hash a framebuffer

API] Signed-off-by: Liviu Dudau --- lib/igt_fb.c | 66 lib/igt_fb.h | 3 +++ 2 files changed, 69 insertions(+) diff --git a/lib/igt_fb.c b/lib/igt_fb.c index 5cd1829a3..044fd57de 100644 --- a/lib/igt_fb.c +++ b/lib/igt_fb.c @@ -2379,6 +2379,72

Re: [Intel-gfx] [PATCH i-g-t v5 3/6] lib: Add function to hash a framebuffer

On Tue, Jan 15, 2019 at 06:47:47PM +, Chris Wilson wrote: > Quoting Liviu Dudau (2019-01-15 17:47:44) > > +int igt_fb_get_crc(struct igt_fb *fb, igt_crc_t *crc) > > +{ > > +#define FNV1a_OFFSET_BIAS 2166136261 > > +#define FNV1a_PRIME 16777619 > > + uin

[Intel-gfx] [PATCH i-g-t v5 2/6] kms_writeback: Add initial writeback tests

-by: Liviu Dudau --- tests/Makefile.sources | 1 + tests/kms_writeback.c | 314 + tests/meson.build | 1 + 3 files changed, 316 insertions(+) create mode 100644 tests/kms_writeback.c diff --git a/tests/Makefile.sources b/tests/Makefile.sources index

[Intel-gfx] [PATCH i-g-t v5 4/6] kms_writeback: Add writeback-check-output

From: Brian Starkey Add a test which makes commits using the writeback connector, and checks the output buffer hash to make sure it is/isn't written as appropriate. Signed-off-by: Brian Starkey --- tests/kms_writeback.c | 124 ++ 1 file changed, 124

[Intel-gfx] [PATCH i-g-t v5 6/6] kms_writeback: Add tests using a cloned output

] Signed-off-by: Liviu Dudau --- tests/kms_writeback.c | 64 +++ 1 file changed, 59 insertions(+), 5 deletions(-) diff --git a/tests/kms_writeback.c b/tests/kms_writeback.c index 0f20dadd2..ae536bbfa 100644 --- a/tests/kms_writeback.c +++ b/tests

[Intel-gfx] [PATCH i-g-t v5 0/6] igt: Add support for testing writeback connectors

We're trying to introduce support for writeback connectors, a way to expose in DRM the hardware functionality from display engines that allows to write back into memory the result of the DE's composition of supported planes. Although this is a rebase of v4 with all the comments addressed, I'm not

[Intel-gfx] [PATCH i-g-t v5 5/6] lib/igt_kms: Add igt_output_clone_pipe for cloning

From: Brian Starkey An output can be added as a clone of any other output(s) attached to a pipe using igt_output_clone_pipe() Signed-off-by: Brian Starkey --- lib/igt_kms.c | 100 +++--- lib/igt_kms.h | 5 +++ 2 files changed, 67 insertions(+), 38

[Intel-gfx] [PATCH i-g-t v5 1/6] lib/igt_kms: Add writeback support

From: Brian Starkey Add support in igt_kms for writeback connectors, with the ability to attach framebuffers. Signed-off-by: Brian Starkey [rebased and updated to the latest igt style] Signed-off-by: Liviu Dudau --- lib/igt_kms.c | 57 +++ lib

[Intel-gfx] [PATCH i-g-t v5 3/6] lib: Add function to hash a framebuffer

(which can take advantage of word-access speedup), we can do the hash on a cached copy, which is much faster (10x speedup on my platform). Signed-off-by: Brian Starkey [rebased and updated to the most recent API] Signed-off-by: Liviu Dudau --- lib/igt_fb.c | 66

Re: [Intel-gfx] [v4 01/12] drm: Add HDR source metadata property

On Tue, Jan 08, 2019 at 02:41:16PM +0530, Uma Shankar wrote: > This patch adds a blob property to get HDR metadata > information from userspace. This will be send as part > of AVI Infoframe to panel. > > v2: Rebase and modified the metadata structure elements > as per Ville's POC changes. > >

Re: [Intel-gfx] [v4 05/12] drm: Add HDR capability field to plane structure

Hi Uma, On Tue, Jan 08, 2019 at 02:41:20PM +0530, Uma Shankar wrote: > Hardware may have HDR capability on certain plane > engines. Enabling the same in drm plane structure > so that this can be communicated to user space. > > Each drm driver should set this flag to true for planes > which

Re: [Intel-gfx] [PATCH 2/2] drm/atomic: Create and use __drm_atomic_helper_crtc_reset() everywhere

emented its own __drm_atomic_helper_crtc_reset(), > convert it to the common one. > > Signed-off-by: Maarten Lankhorst > Cc: Harry Wentland > Cc: Leo Li > Cc: Alex Deucher > Cc: "Christian König" > Cc: "David (ChunMing) Zhou" > Cc: David Airlie >

Re: [Intel-gfx] [PATCH] RFC: Make igts for cross-driver stuff mandatory?

On Fri, Oct 19, 2018 at 10:50:49AM +0200, Daniel Vetter wrote: > Hi all, Hi, (Replying from my personal address as the work email seems to have let this one go to /dev/null) > > This is just to collect feedback on this idea, and see whether the > overall dri-devel community stands on all this.

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t 2/6] kms_writeback: Add initial writeback tests

On Mon, Jun 25, 2018 at 02:48:47PM +0200, Maarten Lankhorst wrote: > Op 01-03-18 om 18:38 schreef Liviu Dudau: > > From: Brian Starkey > > > > Add tests for the WRITEBACK_PIXEL_FORMATS, WRITEBACK_OUT_FENCE_PTR and > > WRITEBACK_FB_ID properties on wri

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t 1/6] lib/igt_kms: Add writeback support in lib/

wrote: > Op 01-03-18 om 18:38 schreef Liviu Dudau: > > From: Brian Starkey > > > > Add support in igt_kms for Writeback connectors, with the ability to > > attach framebuffers and retrieve fences. > > > > Signed-off-by: Brian S

[Intel-gfx] [PATCH i-g-t 4/6] kms_writeback: Add writeback-check-output

From: Brian Starkey Add a test which makes commits using the writeback connector, and checks the output buffer hash to make sure it is/isn't written as appropriate. Signed-off-by: Brian Starkey --- tests/kms_writeback.c | 123

[Intel-gfx] [PATCH i-g-t 5/6] lib/igt_kms: Add igt_output_clone_pipe for cloning

From: Brian Starkey An output can be added as a clone of any other output(s) attached to a pipe using igt_output_clone_pipe() Signed-off-by: Brian Starkey --- lib/igt_kms.c | 99 ---

[Intel-gfx] [PATCH i-g-t 2/6] kms_writeback: Add initial writeback tests

From: Brian Starkey Add tests for the WRITEBACK_PIXEL_FORMATS, WRITEBACK_OUT_FENCE_PTR and WRITEBACK_FB_ID properties on writeback connectors, ensuring their behaviour is correct. Signed-off-by: Brian Starkey --- lib/igt_kms.c | 7 +-

[Intel-gfx] [PATCH i-g-t 0/6] igt: Add support for testing writeback connectors

We're trying to introduce support for writeback connectors, a way to expose in DRM the hardware functionality from display engines that allows to write back into memory the result of the DE's composition of supported planes. Changelog: - This is basically a v3 of the i-g-t tests, except I've now

[Intel-gfx] [PATCH i-g-t 3/6] lib: Add function to hash a framebuffer

From: Brian Starkey To use writeback buffers as a CRC source, we need to be able to hash them. Implement a simple FVA-1a hashing routine for this purpose. Doing a bytewise hash on the framebuffer directly can be very slow if the memory is noncached. By making a copy of

[Intel-gfx] [PATCH i-g-t 1/6] lib/igt_kms: Add writeback support in lib/

From: Brian Starkey Add support in igt_kms for Writeback connectors, with the ability to attach framebuffers and retrieve fences. Signed-off-by: Brian Starkey --- lib/igt_kms.c | 72 ++-

[Intel-gfx] [PATCH i-g-t 6/6] kms_writeback: Add tests using a cloned output

From: Brian Starkey Update the connector search to also optionally attempt to find a non-writeback connector to clone to. Add a subtest which is the same as writeback-check-output, but also clones to the second connector. Signed-off-by: Brian Starkey

Re: [Intel-gfx] [PATCH 0/5] Fix deadlock on runtime suspend in DRM drivers

On Tue, Feb 13, 2018 at 12:52:06PM +0100, Lukas Wunner wrote: > On Tue, Feb 13, 2018 at 10:55:06AM +0000, Liviu Dudau wrote: > > On Sun, Feb 11, 2018 at 10:38:28AM +0100, Lukas Wunner wrote: > > > DRM drivers poll connectors in 10 sec intervals. The poll worke

Re: [Intel-gfx] [PATCH 0/5] Fix deadlock on runtime suspend in DRM drivers

Hi Lukas, On Sun, Feb 11, 2018 at 10:38:28AM +0100, Lukas Wunner wrote: > Fix a deadlock on hybrid graphics laptops that's been present since 2013: > > DRM drivers poll connectors in 10 sec intervals. The poll worker is > stopped on ->runtime_suspend with cancel_delayed_work_sync(). However >

Re: [Intel-gfx] [PATCH 15/15] drm: Don't pass clip to drm_atomic_helper_check_plane_state()

On Fri, Nov 24, 2017 at 04:08:28PM +0200, Ville Syrjälä wrote: > On Fri, Nov 24, 2017 at 11:59:45AM +0000, Liviu Dudau wrote: > > On Thu, Nov 23, 2017 at 09:05:02PM +0200, Ville Syrjala wrote: > > > From: Ville Syrjälä <ville.syrj...@linux.intel.com> > > > &

Re: [Intel-gfx] [PATCH 15/15] drm: Don't pass clip to drm_atomic_helper_check_plane_state()

ret = drm_atomic_helper_check_plane_state(state, crtc_state, , > + ret = drm_atomic_helper_check_plane_state(state, crtc_state, > 0, INT_MAX, true, true); > if (ret) > return ret; For the hdlcd and malidp changes

Re: [Intel-gfx] [PATCH 15/15] drm: Don't pass clip to drm_atomic_helper_check_plane_state()

On Thu, Nov 23, 2017 at 09:05:02PM +0200, Ville Syrjala wrote: > From: Ville Syrjälä Hi Ville, > > Move the plane clip rectangle handling into > drm_atomic_helper_check_plane_state(). Drivers no longer > have to worry about such mundane details. This is quite an

Re: [Intel-gfx] [PATCH 04/15] drm/arm/mali-dp: Use drm_mode_get_hv_timing() to populate plane clip rectangle

t Pinchart <laurent.pinch...@ideasonboard.com> > Cc: Liviu Dudau <liviu.du...@arm.com> > Cc: Brian Starkey <brian.star...@arm.com> > Cc: Mali DP Maintainers <mal...@foss.arm.com> > Signed-off-by: Ville Syrjälä <ville.syrj...@linux.intel.com> Acked-by: Liviu Du

Re: [Intel-gfx] [PATCH 03/15] drm/arm/hdlcd: Use drm_mode_get_hv_timing() to populate plane clip rectangle

t Pinchart <laurent.pinch...@ideasonboard.com> > Cc: Liviu Dudau <liviu.du...@arm.com> > Cc: Brian Starkey <brian.star...@arm.com> > Cc: Mali DP Maintainers <mal...@foss.arm.com> > Signed-off-by: Ville Syrjälä <ville.syrj...@linux.intel.com> Acked-by: Liviu Dud

Re: [Intel-gfx] [PATCH v2] drm: gem_cma_helper.c: Allow importing of contiguous scatterlists with nents > 1

On Wed, Nov 15, 2017 at 03:24:41PM +0100, Noralf Trønnes wrote: > > Den 15.11.2017 14.04, skrev Liviu Dudau: > > Hi, > > > > On Sat, Nov 11, 2017 at 02:47:35PM +0200, Laurent Pinchart wrote: > > > Hi Liviu, > > > > > > Thank you for the patch

Re: [Intel-gfx] [PATCH v2] drm: gem_cma_helper.c: Allow importing of contiguous scatterlists with nents > 1

Hi, On Sat, Nov 11, 2017 at 02:47:35PM +0200, Laurent Pinchart wrote: > Hi Liviu, > > Thank you for the patch. > > On Friday, 10 November 2017 15:33:10 EET Liviu Dudau wrote: > > drm_gem_cma_prime_import_sg_table() will fail if the number of entries > > in the sg_

[Intel-gfx] [PATCH v2] drm: gem_cma_helper.c: Allow importing of contiguous scatterlists with nents > 1

low for that scenario by testing the entries in the sg_table for contiguous coverage. Reviewed-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com> Signed-off-by: Liviu Dudau <liviu.du...@arm.com> --- Laurent, Thanks for the review! I would like to ask for one more favour: if you are OK wi

[Intel-gfx] [PATCH v2] drm/drm_vma_manager.c: Remove useless goto statement

eliminate the need for the goto and associated label. v2: rewrite function to remove all goto statements. Fixes: db2395eccf08i ("drm: Convert drm_vma_manager to embedded interval-tree in drm_mm") Cc: Chris Wilson <ch...@chris-wilson.co.uk> Signed-off-by: Liviu Dudau <liviu.du...@

Re: [Intel-gfx] [PATCH 5/8] drm: Nuke drm_atomic_helper_plane_set_property

On Tue, Jul 25, 2017 at 10:01:19AM +0200, Daniel Vetter wrote: > It's dead code, the core handles all this directly now. This also > allows us to unexport drm_atomic_helper_plane_set_property. > > Signed-off-by: Daniel Vetter <daniel.vet...@intel.com> > Cc: Liviu Dudau <l

Re: [Intel-gfx] [PATCH i-g-t 1/7] igt: lib/igt_crc: Split out CRC functionality

On Mon, Jul 17, 2017 at 04:50:27PM +0300, Arkadiusz Hiler wrote: > On Thu, Jul 06, 2017 at 05:14:18PM +0100, Liviu Dudau wrote: > > From: Brian Starkey <brian.star...@arm.com> > > > > Separate out the CRC code for better compartmentalisation. Should ease > > t

Re: [Intel-gfx] [PATCH i-g-t] lib/igt_debugfs: Update documentation and clenup

all the current cases), so let's put that in the doc too. > > While I was at it I got rid of strdup() in favor of an early allocation. > > Cc: Martin Peres <martin.pe...@intel.com> > Cc: Liviu Dudau <liviu.du...@arm.com> Reviewed-by: Liviu Dudau <liviu.du.

[Intel-gfx] [PATCH i-g-t v2 1/7] igt: lib/igt_crc: Split out CRC functionality

From: Brian Starkey Separate out the CRC code for better compartmentalisation. Should ease the addition of more/different CRC sources in the future. Signed-off-by: Brian Starkey --- lib/Makefile.sources | 2 + lib/igt_chamelium.h

[Intel-gfx] [PATCH i-g-t v2 0/7] igt: Add support for testing writeback connectors

We're trying to introduce support for writeback connectors, a way to expose in DRM the hardware functionality from display engines that allows to write back into memory the result of the DE's composition of supported planes. Generic DRM support is available here [1] and will be merged once this

[Intel-gfx] [PATCH i-g-t v2 3/7] kms_writeback: Add initial writeback tests

From: Brian Starkey Add tests for the WRITEBACK_PIXEL_FORMATS, WRITEBACK_OUT_FENCE_PTR and WRITEBACK_FB_ID properties on writeback connectors, ensuring their behaviour is correct. Signed-off-by: Brian Starkey --- lib/igt_kms.c | 6 +-

[Intel-gfx] [PATCH i-g-t v2 6/7] lib/igt_kms: Add igt_output_clone_pipe for cloning

From: Brian Starkey An output can be added as a clone of any other output(s) attached to a pipe using igt_output_clone_pipe() Signed-off-by: Brian Starkey --- lib/igt_kms.c | 90 +--

[Intel-gfx] [PATCH i-g-t v2 2/7] lib/igt_kms: Add writeback support in lib/

From: Brian Starkey Add support in igt_kms for Writeback connectors, with the ability to attach framebuffers and retrieve fences. Signed-off-by: Brian Starkey --- lib/igt_aux.c | 1 + lib/igt_kms.c | 76

[Intel-gfx] [PATCH i-g-t v2 5/7] kms_writeback: Add writeback-check-output

From: Brian Starkey Add a test which makes commits using the writeback connector, and checks the output buffer hash to make sure it is/isn't written as appropriate. Signed-off-by: Brian Starkey --- tests/kms_writeback.c | 123

[Intel-gfx] [PATCH i-g-t v2 7/7] kms_writeback: Add tests using a cloned output

From: Brian Starkey Update the connector search to also optionally attempt to find a non-writeback connector to clone to. Add a subtest which is the same as writeback-check-output, but also clones to the second connector. Signed-off-by: Brian Starkey

[Intel-gfx] [PATCH i-g-t v2 4/7] lib: Add function to hash a framebuffer

From: Brian Starkey To use writeback buffers as a CRC source, we need to be able to hash them. Implement a simple FVA-1a hashing routine for this purpose. Doing a bytewise hash on the framebuffer directly can be very slow if the memory is noncached. By making a copy of

Re: [Intel-gfx] [PATCH 11/16] drm/mali: Use new atomic iterator macros

On Wed, Jul 12, 2017 at 12:00:40PM +0200, Maarten Lankhorst wrote: > Op 12-07-17 om 11:44 schreef Liviu Dudau: > > On Wed, Jul 12, 2017 at 10:13:39AM +0200, Maarten Lankhorst wrote: > >> for_each_obj_in_state is about to be removed, so use the new iterator > >> m

Re: [Intel-gfx] [PATCH 11/16] drm/mali: Use new atomic iterator macros

On Wed, Jul 12, 2017 at 10:13:39AM +0200, Maarten Lankhorst wrote: > for_each_obj_in_state is about to be removed, so use the new iterator > macros. > > Signed-off-by: Maarten Lankhorst <maarten.lankho...@linux.intel.com> > Cc: Liviu Dudau <liviu.du...@arm.com> >

[Intel-gfx] [PATCH i-g-t 0/7] igt: Add support for testing writeback connectors

We're trying to introduce support for writeback connectors, a way to expose in DRM the hardware functionality from display engines that allows to write back into memory the result of the DE's composition of supported planes. Generic DRM support is available here [1] and will be merged once this

[Intel-gfx] [PATCH i-g-t 5/7] kms_writeback: Add writeback-check-output

From: Brian Starkey <brian.star...@arm.com> Add a test which makes commits using the writeback connector, and checks the output buffer hash to make sure it is/isn't written as appropriate. Signed-off-by: Brian Starkey <brian.star...@arm.com> Signed-off-by: Liviu Dudau <livi

[Intel-gfx] [PATCH i-g-t 2/7] lib/igt_kms: Add writeback support in lib/

From: Brian Starkey <brian.star...@arm.com> Add support in igt_kms for Writeback connectors, with the ability to attach framebuffers and retrieve fences. Signed-off-by: Brian Starkey <brian.star...@arm.com> Signed-off-by: Liviu Dudau <liviu.du...@arm.com> --- lib/igt

[Intel-gfx] [PATCH i-g-t 3/7] kms_writeback: Add initial writeback tests

From: Brian Starkey <brian.star...@arm.com> Add tests for the WRITEBACK_PIXEL_FORMATS, WRITEBACK_OUT_FENCE_PTR and WRITEBACK_FB_ID properties on writeback connectors, ensuring their behaviour is correct. Signed-off-by: Brian Starkey <brian.star...@arm.com> Signed-off-by: Liviu Dud

[Intel-gfx] [PATCH i-g-t 7/7] kms_writeback: Add tests using a cloned output

rian.star...@arm.com> Signed-off-by: Liviu Dudau <liviu.du...@arm.com> --- tests/kms_writeback.c | 63 --- 1 file changed, 55 insertions(+), 8 deletions(-) diff --git a/tests/kms_writeback.c b/tests/kms_writeback.c index 8201a81c..9a34bca0

[Intel-gfx] [PATCH i-g-t 4/7] lib: Add function to hash a framebuffer

a copy of each line in the FB first (which can take advantage of word-access speedup), we can do the hash on a cached copy, which is much faster (10x speedup on my platform). Signed-off-by: Brian Starkey <brian.star...@arm.com> Signed-off-by: Liviu Dudau <liviu.du...@arm.com> ---

[Intel-gfx] [PATCH i-g-t 1/7] igt: lib/igt_crc: Split out CRC functionality

From: Brian Starkey <brian.star...@arm.com> Separate out the CRC code for better compartmentalisation. Should ease the addition of more/different CRC sources in the future. Signed-off-by: Brian Starkey <brian.star...@arm.com> Signed-off-by: Liviu Dudau <liviu.du...@arm

[Intel-gfx] [PATCH i-g-t 6/7] lib/igt_kms: Add igt_output_clone_pipe for cloning

From: Brian Starkey <brian.star...@arm.com> An output can be added as a clone of any other output(s) attached to a pipe using igt_output_clone_pipe() Signed-off-by: Brian Starkey <brian.star...@arm.com> Signed-off-by: Liviu Dudau <liviu.du...@arm.com> ---

Re: [Intel-gfx] [PATCH 10/13] drm/fb-helper: Support deferred setup

), we can stick much closer to the existing code. And update > some comments I've spotted that are outdated. > > v5: Don't pass -EAGAIN to drivers, it's just an internal error code > (Liviu). > > v6: Add _and_unlock suffix to clarify locking (Maarten) > > Cc: Liviu

Re: [Intel-gfx] [PATCH] drm/fb-helper: Restore first connection behaviour on deferred setup

On Fri, Jun 30, 2017 at 08:13:58PM +0200, Daniel Vetter wrote: > On Fri, Jun 30, 2017 at 6:51 PM, Liviu Dudau <liviu.du...@arm.com> wrote: > > Prior to commit b0aa06e9a7fd ("drm/fb-helper: Support deferred setup"), > > if no output is connected at framebuff

[Intel-gfx] [PATCH] drm/fb-helper: Restore first connection behaviour on deferred setup

behaviour by checking in the drm_fb_helper_hotplug_event() function if the deferred setup is still active. If not, that means we now have a valid framebuffer that can be used for setting the correct mode. Fixes: b0aa06e9a7fd ("drm/fb-helper: Support deferred setup") Signed-off-by: Liviu Dudau <

Re: [Intel-gfx] [PATCH] drm/fb-helper: Support deferred setup

), we can stick much closer to the existing code. And update > some comments I've spotted that are outdated. > > v5: Don't pass -EAGAIN to drivers, it's just an internal error code > (Liviu). > > Cc: Liviu Dudau <li...@dudau.co.uk> > Cc: John Stultz <john.stu...@linaro.

Re: [Intel-gfx] [PATCH 00/12] fbdev helper locking rework and deferred setup

On Fri, Jun 23, 2017 at 09:38:49AM +0200, Daniel Vetter wrote: > On Thu, Jun 22, 2017 at 4:54 PM, Liviu Dudau <li...@dudau.co.uk> wrote: > > On Wed, Jun 21, 2017 at 08:28:03PM +0200, Daniel Vetter wrote: > >> Hi all, > >> > >> This is Thierry's deferred f

Re: [Intel-gfx] [PATCH 00/12] fbdev helper locking rework and deferred setup

On Wed, Jun 21, 2017 at 08:28:03PM +0200, Daniel Vetter wrote: > Hi all, > > This is Thierry's deferred fbdev setup series, with the locking rework almost > entirely redone. The much wider scope is to get rid of drm_modeset_lock_all > calls for atomic drivers and remove users of the fairly nasty

Re: [Intel-gfx] [PATCH v2] lib/igt_kms: Fix override_mode handling

On Tue, Jun 20, 2017 at 04:28:14PM +0300, Arkadiusz Hiler wrote: > On Fri, Jun 16, 2017 at 03:00:06PM +0100, Liviu Dudau wrote: > > From: Brian Starkey <brian.star...@arm.com> > > > > Changelog: > > - v2: removed the forced overwrite of output->config.defaul

[Intel-gfx] [PATCH v2] lib/igt_kms: Fix override_mode handling

rect mode, without needing the output to be reprobed. This change means that output->config.default_mode always contains the "non-overridden" default mode. Signed-off-by: Brian Starkey <brian.star...@arm.com> Signed-off-by: Liviu Dudau <liviu.du...@arm.com> --- lib/i

Re: [Intel-gfx] [PATCH 0/4] Cleanups and fixes

On Fri, Jun 16, 2017 at 02:08:25PM +0300, Arkadiusz Hiler wrote: > On Mon, Jun 12, 2017 at 11:33:13AM +0100, Liviu Dudau wrote: > > On Fri, Jun 09, 2017 at 03:37:54PM +0300, Arkadiusz Hiler wrote: > > > On Fri, Jun 09, 2017 at 03:34:42PM +0300, Arkadiusz Hiler wrote: > >

Re: [Intel-gfx] [PATCH 0/4] Cleanups and fixes

On Fri, Jun 09, 2017 at 03:37:54PM +0300, Arkadiusz Hiler wrote: > On Fri, Jun 09, 2017 at 03:34:42PM +0300, Arkadiusz Hiler wrote: > > On Mon, Jun 05, 2017 at 02:28:36PM +0100, Liviu Dudau wrote: > > > From: Liviu Dudau <liviu.du...@arm.com> > > > > > &g

Re: [Intel-gfx] [PATCH 0/4] Cleanups and fixes

On Fri, Jun 09, 2017 at 03:37:54PM +0300, Arkadiusz Hiler wrote: > On Fri, Jun 09, 2017 at 03:34:42PM +0300, Arkadiusz Hiler wrote: > > On Mon, Jun 05, 2017 at 02:28:36PM +0100, Liviu Dudau wrote: > > > From: Liviu Dudau <liviu.du...@arm.com> > > > > > &g

Re: [Intel-gfx] [PATCH 2/4] lib/igt_kms: Fix override_mode handling

On Tue, Jun 06, 2017 at 01:30:28PM +0300, Arkadiusz Hiler wrote: > On Mon, Jun 05, 2017 at 02:28:38PM +0100, Liviu Dudau wrote: > > From: Brian Starkey <brian.star...@arm.com> > > > > igt_display_commit isn't refreshing all outputs anymore, which means > > th

[Intel-gfx] [PATCH 2/4] lib/igt_kms: Fix override_mode handling

From: Brian Starkey igt_display_commit isn't refreshing all outputs anymore, which means that an override mode may never get picked up. Instead of forcing a reprobe to handle copying the override_mode into default_mode, just change igt_output_get_mode() to return the

[Intel-gfx] [PATCH 0/4] Cleanups and fixes

From: Liviu Dudau <liviu.du...@arm.com> Hello, I believe Brian has sent these patches before, but he did not had any luck getting them accepted, so it is now my turn :) These fixes were found while developing code for memory writeback testing and general use of igt with Mali DP KMS

[Intel-gfx] [PATCH 1/4] lib/igt_kms: Fix erroneous assert

From: Brian Starkey In trying to fix igt_display_init() for devices without cursors, I actually made matters worse. Fix the assert. Fixes: 545aa3398223 lib/igt_kms: Remove redundant cursor code Signed-off-by: Brian Starkey --- lib/igt_kms.c | 10

[Intel-gfx] [PATCH 4/4] lib/igt_debugfs: Only use valid values in igt_crc_to_str()

From: Brian Starkey Not all elements in the crc array may be valid, so only use the valid ones to generate the string. Signed-off-by: Brian Starkey --- lib/igt_debugfs.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git

[Intel-gfx] [PATCH 3/4] lib/igt_debugfs: Remove igt_debugfs_t

From: Brian Starkey It's not used anymore, so remove it. Signed-off-by: Brian Starkey --- lib/igt_debugfs.c | 5 - 1 file changed, 5 deletions(-) diff --git a/lib/igt_debugfs.c b/lib/igt_debugfs.c index 7584be5f..f5ed3daf 100644 ---

Re: [Intel-gfx] [PATCH 16/37] drm/hdlcd|mali: Drop drm_vblank_cleanup

On Wed, May 31, 2017 at 06:41:05PM +0200, Daniel Vetter wrote: > On Wed, May 31, 2017 at 1:22 PM, Liviu Dudau <liviu.du...@arm.com> wrote: > > On Wed, May 31, 2017 at 01:03:34PM +0200, Daniel Vetter wrote: > >> On Wed, May 31, 2017 at 12:57 PM, Liviu Dudau <

Re: [Intel-gfx] [PATCH 16/37] drm/hdlcd|mali: Drop drm_vblank_cleanup

things gets stopped. So no harm in removing the > drm_vblank_cleanup here really. > > Same story for both hdlcd and mali. > > v2: Move misplaced malidp hunk to this patch (Liviu). > > Cc: Liviu Dudau <liviu.du...@arm.com> > Cc: Brian Starkey <brian.star...@arm.co

Re: [Intel-gfx] [PATCH 16/37] drm/hdlcd|mali: Drop drm_vblank_cleanup

On Wed, May 31, 2017 at 01:03:34PM +0200, Daniel Vetter wrote: > On Wed, May 31, 2017 at 12:57 PM, Liviu Dudau <liviu.du...@arm.com> wrote: > > On Wed, May 24, 2017 at 04:51:51PM +0200, Daniel Vetter wrote: > >> IRQs are properly shut down, so it almost works as race-fr

Re: [Intel-gfx] [PATCH 16/37] drm/hdlcd|mali: Drop drm_vblank_cleanup

> Same story for both hdlcd and mali. > > v2: Move misplaced malidp hunk to this patch (Liviu). > > Cc: Liviu Dudau <liviu.du...@arm.com> > Cc: Brian Starkey <brian.star...@arm.com> > Signed-off-by: Daniel Vetter <daniel.vet...@intel.com> > --- > driver

Re: [Intel-gfx] [PATCH v3] drm: Add DRM_MODE_ROTATE_ and DRM_MODE_REFLECT_ to UAPI

RM_MODE_ROTATE_180 | > + DRM_MODE_ROTATE_270 | DRM_MODE_REFLECT_X | > DRM_MODE_REFLECT_Y; > u32 *formats; > int ret, i, j, n; > > @@ -420,7 +420,7 @@ int malidp_de_planes_init(struct drm_device *drm) > continue; &g

  1   2   >