Some small improvements to future-proof the initialization around the
register state context.
Lucas De Marchi (3):
drm/i915: Fix __gen125_emit_bb_start() without WA
drm/i915/gt: Document function to decode register state context
drm/i915/gt: Fix platform prefix
drivers/gpu/drm/i915/gt
T_BB` to be invalid since wa_offset is
not correct.
As in other places in the driver, check for graphics version "greater or
equal" to future-proof the support for new platforms.
Cc: Matt Roper
Cc: Matthew Auld
Cc: Chris Wilson
Signed-off-by: Lucas De Marchi
---
drivers/gpu/drm/i91
Different handling for XeHP and later platforms should be using the
xehp prefix, not gen125. Rename them.
Signed-off-by: Lucas De Marchi
---
drivers/gpu/drm/i915/gt/gen8_engine_cs.c | 24 +--
drivers/gpu/drm/i915/gt/gen8_engine_cs.h | 12 +-
.../drm/i915/gt
It's no obviously clear how the encode/decode of the per platform tables
is done. Document it so while adding tables for new platforms people can
be confident they right things is being done.
Signed-off-by: Lucas De Marchi
---
drivers/gpu/drm/i915/gt/intel_lrc.c | 24 ++
Sripada
Reviewed-by: Lucas De Marchi
Lucas De Marchi
On Mon, Sep 26, 2022 at 01:11:36PM +0300, Jani Nikula wrote:
On Tue, 20 Sep 2022, Lucas De Marchi wrote:
On Mon, Sep 19, 2022 at 11:10:53AM +0300, Jani Nikula wrote:
On Fri, 16 Sep 2022, Lucas De Marchi wrote:
On Fri, Sep 16, 2022 at 11:26:42AM +0300, Jani Nikula wrote:
Commit 00c6cbfd4e8a
Nikula
CC: Lucas De Marchi
Signed-off-by: Gustavo Sousa
Reviewed-by: Jani Nikula
applied, thanks
Lucas De Marchi
REG16(0x2b4),
+ REG(0x120),
+ REG(0x124),
+
+ NOP(1),
+ LRI(9, POSTED),
humn... set_offsets() is forcing MI_LRI_LRM_CS_MMIO
for ver >= 11, although here bspec shows this MI_LOAD_REGISTER_IMM
doesn't have it set.
+Mika, +Chris
Lucas De Marchi
+ REG16(0x3a
render gmd_to_intel_step() invalid
with that added: Reviewed-by: Lucas De Marchi
Lucas De Marchi
ed that it's not
hardcoded somewhere in the ro data
I'd just make this paragrapho read like:
/*
* Single "graphics" IP version that represents
* render, compute, and copy behavior.
*/
A few nits above, but this is in general good to
On Wed, Sep 21, 2022 at 12:00:38PM +0530, Iddamsetty, Aravind wrote:
replying here for earlier comments too.
On 21-09-2022 01:35, Lucas De Marchi wrote:
On Tue, Sep 20, 2022 at 01:31:49AM -0700, Lucas De Marchi wrote:
On Tue, Sep 20, 2022 at 12:49:40PM +0530, Aravind Iddamsetty wrote:
As an
tglb3/igt@kms_plane_alpha_bl...@pipe-d-alpha-7efc.html
[2]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108620v3/shard-tglb8/igt@kms_plane_alpha_bl...@pipe-d-alpha-7efc.html
unrelated failure in display
Lucas De Marchi
On Tue, Sep 20, 2022 at 01:31:49AM -0700, Lucas De Marchi wrote:
On Tue, Sep 20, 2022 at 12:49:40PM +0530, Aravind Iddamsetty wrote:
As an integrated GPU, MTL does not have local memory and
HAS_LMEM() returns false. However the platform's stolen memory
is presented via BAR2 (i.e., the B
eturn 1536;
+ case 0x40:
+ return 2048;
+ case 0xf0 ... 0xfe:
just a bit puzzled by the fact that case ranges are not standard
and are supported only by GCC, unless, of course, I miss
clang also supports it and can build the kernel (or a great portion of
it).
Lucas De Marchi
ld be to just let the caller handle the if/else
decision, passing the bits (and possibly register) to invert. The noise
in xxx_hpd_irq_setup() function may be avoid by
#define INVERT_DII_HPD (INVERT_DDIA_HPD | INVERT_DDIB_HPD |
INVERT_DDIC_HPD | INVERT_DDID_HPD)
#define XXX_INVERT_DII_HPD (...)
Third possibility since the function is already very small is to just go
ahead and use another _setup() for the next platforms.
Lucas De Marchi
ed by the driver the same
way that local memory is on dgpu platforms (which includes
setting the "lmem" bit on page table entries). We use the term
"local stolen memory" to refer to this model.
Cc: Matt Roper
Cc: Lucas De Marchi
Signed-off-by: CQ Tang
Signed-off-by: Ara
On Mon, Sep 19, 2022 at 11:10:53AM +0300, Jani Nikula wrote:
On Fri, 16 Sep 2022, Lucas De Marchi wrote:
On Fri, Sep 16, 2022 at 11:26:42AM +0300, Jani Nikula wrote:
Commit 00c6cbfd4e8a ("drm/i915: move pipe_mask and cpu_transcoder_mask
to runtime info") moved the pipe_mask member f
drm_i915_private
*dev_priv)
spin_unlock_irq(&dev_priv->irq_lock);
}
+static void setup_hotplug_inversion(struct drm_i915_private *dev_priv)
new users of drm_i915_private should use "i915" as variable name rather
than dev_priv.
other than that, Reviewed-by: Lucas De M
On Fri, Sep 16, 2022 at 02:24:00PM +0200, Karolina Drobnik wrote:
On 14.09.2022 17:54, Robin Murphy wrote:
On 2022-09-14 16:01, Lucas De Marchi wrote:
On Wed, Sep 14, 2022 at 02:40:45PM +0200, Karolina Drobnik wrote:
This reverts commit ac9a5d522bb80be50ea84965699e1c8257d745ce.
This change
often per platform and is a big source
of confusion when handling stolen memory.
Signed-off-by: Lucas De Marchi
diff --git a/drivers/gpu/drm/i915/gem/i915_gem_stolen.c
b/drivers/gpu/drm/i915/gem/i915_gem_stolen.c
index 3665f9b035bb..6edf4e374f54 100644
--- a/drivers/gpu/drm/i915/gem
-off-by: Lucas De Marchi
diff --git a/drivers/gpu/drm/i915/gem/i915_gem_stolen.c
b/drivers/gpu/drm/i915/gem/i915_gem_stolen.c
index acc561c0f0aa..3665f9b035bb 100644
--- a/drivers/gpu/drm/i915/gem/i915_gem_stolen.c
+++ b/drivers/gpu/drm/i915/gem/i915_gem_stolen.c
@@ -814,7 +814,7
drm:/dev/dri/renderD128
Signed-off-by: Lucas De Marchi
diff --git a/drivers/gpu/drm/i915/gem/i915_gem_stolen.c
b/drivers/gpu/drm/i915/gem/i915_gem_stolen.c
index 6edf4e374f54..c5a4035c99cd 100644
--- a/drivers/gpu/drm/i915/gem/i915_gem_stolen.c
+++ b/drivers/gpu/drm/i915/gem/i915_gem_stolen.c
Better split, document, and make the code paths for integrated and discrete
more similar.
v2:
- s/GENMASK/REG_GENMASK64/ where appropriate
- Fix comment
Signed-off-by: Lucas De Marchi
---
Lucas De Marchi (3):
drm/i915: Add missing mask when reading GEN12_DSMBASE
drm/i915: Split
On Fri, Sep 16, 2022 at 05:50:33PM +0530, Iddamsetty, Aravind wrote:
On 16-09-2022 02:09, Lucas De Marchi wrote:
Add some helpers: adjust_stolen(), request_smem_stolen_() and
init_reserved_stolen() that are now called by i915_gem_init_stolen() to
initialize each part of the Data Stolen Memory
("drm/i915: move pipe_mask and cpu_transcoder_mask to runtime
info")
Cc: Lucas De Marchi
Cc: Maarten Lankhort
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/i915_pci.c | 11 ++-
drivers/gpu/drm/i915/intel_device_info.c | 6 ++
2 files changed, 12 insertions(+), 5 deletio
.
No change in behavior.
Signed-off-by: Lucas De Marchi
---
drivers/gpu/drm/i915/gem/i915_gem_stolen.c | 143 -
1 file changed, 85 insertions(+), 58 deletions(-)
diff --git a/drivers/gpu/drm/i915/gem/i915_gem_stolen.c
b/drivers/gpu/drm/i915/gem/i915_gem_stolen.c
index
-gfx-ci.01.org/tree/drm-tip/Patchwork_108620v1/fi-snb-2520m/igt@i915_selftest@l...@reset.html
/me procures a ilk and snb for proper test next.
Lucas De Marchi
Suppressed
The following results come from untrusted machines, tests, or statuses.
They do not affect the overall result.
drm:/dev/dri/renderD128
Signed-off-by: Lucas De Marchi
diff --git a/drivers/gpu/drm/i915/gem/i915_gem_stolen.c
b/drivers/gpu/drm/i915/gem/i915_gem_stolen.c
index 0e57a6d81534..4f1bac7ce522 100644
--- a/drivers/gpu/drm/i915/gem/i915_gem_stolen.c
+++ b/drivers/gpu/drm/i915/gem/i915_gem_stolen.c
.
This also fixes a bug in graphics version < 5 (in theory, not tested,
due to no machine available): it would bail out on stolen creation due
to "Stolen reserved area outside stolen memory". Other than that, no
change in behavior.
Signed-off-by: Lucas De Marchi
diff --git a/drivers
DSMBASE register is defined so BDSM bitfield contains the bits 63 to 20
of the base address of stolen. For the supported platforms bits 0-19 are
zero but that may not be true in future. Add the missing mask.
Signed-off-by: Lucas De Marchi
diff --git a/drivers/gpu/drm/i915/gem/i915_gem_stolen.c
Better split, document, and make the code paths for integrated and discrete
more similar.
Signed-off-by: Lucas De Marchi
---
Lucas De Marchi (4):
drm/i915: Move dsm assignment to be after adjustment
drm/i915: Add missing mask when reading GEN12_DSMBASE
drm/i915: Split
Reduce possible side effects of assigning the region and bailing out due
to errors.
Signed-off-by: Lucas De Marchi
diff --git a/drivers/gpu/drm/i915/gem/i915_gem_stolen.c
b/drivers/gpu/drm/i915/gem/i915_gem_stolen.c
index acc561c0f0aa..42f4769bb4ac 100644
--- a/drivers/gpu/drm/i915/gem
On Thu, Sep 15, 2022 at 09:23:52AM +0100, Tvrtko Ursulin wrote:
On 15/09/2022 09:09, Lucas De Marchi wrote:
On Thu, Sep 15, 2022 at 08:53:16AM +0100, Tvrtko Ursulin wrote:
On 14/09/2022 21:35, Lucas De Marchi wrote:
This reverts commit 58f44e349cfc10a4f2208fd806829c8fd046480b.
To be
g37b0cd34584f"
# CONFIG_LOCALVERSION_AUTO is not set
CONFIG_BUILD_SALT=""
CONFIG_HAVE_KERNEL_GZIP=y
Applying with ack by Petri.
Lucas De Marchi
On Thu, Sep 15, 2022 at 08:53:16AM +0100, Tvrtko Ursulin wrote:
On 14/09/2022 21:35, Lucas De Marchi wrote:
This reverts commit 58f44e349cfc10a4f2208fd806829c8fd046480b.
To be removed from the topic/core-for-CI branch. If CI's config is
setting that, it just shouldn't do it. Lo
d, thanks for reviews.
Lucas De Marchi
CONFIG_INTEL_IOMMU_DEFAULT_ON=y. And if it's somewhere else and my
premise is false, we will know from the CI execution of this patch.
Signed-off-by: Lucas De Marchi
---
drivers/gpu/drm/i915/Kconfig.debug | 8
1 file changed, 8 deletions(-)
diff --git a/drivers/gpu/drm/i915/Kconfig.debug
b/dr
/nvme0n1p2 \
rootwait fsck.repair=yes nmi_watchdog=panic,auto panic=5 \
softdog.soft_panic=5 drm.debug=0xe log_buf_len=1M trace_clock=global 3 \
modprobe.blacklist=i915,snd_hda_intel ro
So it should be safe to remove this commit.
Signed-off-by: Lucas De Marchi
---
drivers/i
already on rc5. Are iommu authors involved aware of this issue?
We could do this in our "for CI only" branch, but it's equally important
that this is fixed for 6.0
Cc'ing them.
thanks
Lucas De Marchi
kernel log:
==
WARNIN
other function and there is no version 10. Remove that function and
the caller.
v2: Correctly handle intel_gt_check_clock_frequency() that also calls
the function to read clock frequency (Gustavo)
Cc: Ville Syrjälä
Cc: Gustavo Sousa
Signed-off-by: Lucas De Marchi
diff --git a/drivers/gpu/drm/i9
Continue converting the driver to the convention of last version first,
extending it to the future platforms. Now, any GRAPHICS_VER >= 11 will
be handled by the first branch.
Reviewed-by: Gustavo Sousa
Signed-off-by: Lucas De Marchi
diff --git a/drivers/gpu/drm/i915/gem/i915_gem_stolen.c
the branch taken for GRAPHICS_VER == 10
is also different, but currently there is no such platform in i915.
Signed-off-by: Lucas De Marchi
Reviewed-by: Matt Roper
diff --git a/drivers/gpu/drm/i915/gt/intel_gt_clock_utils.c
b/drivers/gpu/drm/i915/gt/intel_gt_clock_utils.c
index d5d1b04dbcad..9
Marchi
---
Lucas De Marchi (3):
drm/i915: Invert if/else ladder for frequency read
drm/i915/gt: Extract per-platform function for frequency read
drm/i915: Invert if/else ladder for stolen init
drivers/gpu/drm/i915/gem/i915_gem_stolen.c | 51 +++-
drivers/gpu/drm/i915/gt
On Tue, Sep 13, 2022 at 08:17:02AM -0300, Gustavo Sousa wrote:
Hi, Lucas.
On Thu, Sep 08, 2022 at 01:08:15PM -0700, Lucas De Marchi wrote:
Instead of calling read_clock_frequency() to walk the if/else ladder
per platform, move the ladder to intel_gt_init_clock_frequency() and
use one function
er: */
+ if (fw_blobs[i].blob.patch <= fw_blobs[i -
1].blob.patch)
+ continue;
+
+bad:
+ drm_err(&i915->drm, "\x1B[35;1mInvalid FW blob order: %s r%u
%s%d.%d.%d comes before %s r%u %s%d.%d.%d\n",
what is t
On Mon, Sep 12, 2022 at 10:12:57PM +0200, Andi Shyti wrote:
Hi Lucas,
On Mon, Sep 12, 2022 at 11:12:47AM -0700, Lucas De Marchi wrote:
On Mon, Sep 12, 2022 at 06:59:53PM +0200, Andi Shyti wrote:
> Hi Lucas,
>
> On Mon, Sep 12, 2022 at 09:19:38AM -0700, Lucas De Marchi wrote:
> &
On Mon, Sep 12, 2022 at 06:59:53PM +0200, Andi Shyti wrote:
Hi Lucas,
On Mon, Sep 12, 2022 at 09:19:38AM -0700, Lucas De Marchi wrote:
Support for reading the fuses to check what are the Link Copy engines
was added in commit ad5f74f34201 ("drm/i915/pvc: read fuses for link
copy en
Fix missing IP version when applying copy engine fuses.
Signed-off-by: Lucas De Marchi
---
Lucas De Marchi (1):
drm/i915: Skip applying copy engine fuses
drivers/gpu/drm/i915/gt/intel_engine_cs.c | 4
1 file changed, 4 insertions(+)
---
base-commit
unction later if it's needed to fuse off copy engines.
Currently it's harmless as the Link Copy engines are still not exported:
info->engine_mask only has BCS0 set and the register is only read for
platforms that do have it.
Signed-off-by: Lucas De Marchi
diff --git a/drivers/gpu/drm
On Fri, Sep 09, 2022 at 04:18:14PM -0700, Lucas De Marchi wrote:
Update fuse handling for media to future-proof it.
Signed-off-by: Lucas De Marchi
Thanks Matt Roper and Andrzej for the review. Applied.
Lucas De Marchi
On Mon, Sep 12, 2022 at 10:56:16AM +0200, Andrzej Hajda wrote:
On 10.09.2022 01:18, Lucas De Marchi wrote:
Just like is done for compute and copy engines, extract a function to
handle media engines. While at it, be consistent on using or not the
uncore/gt/info variable aliases.
Reviewed-by
Just like is done for compute and copy engines, extract a function to
handle media engines. While at it, be consistent on using or not the
uncore/gt/info variable aliases.
Reviewed-by: Matt Roper
Signed-off-by: Lucas De Marchi
diff --git a/drivers/gpu/drm/i915/gt/intel_engine_cs.c
b/drivers
rsion which then includes that platform.
Reviewed-by: Matt Roper
Signed-off-by: Lucas De Marchi
diff --git a/drivers/gpu/drm/i915/gt/intel_engine_cs.c
b/drivers/gpu/drm/i915/gt/intel_engine_cs.c
index 6e0122b3dca2..b6602439224d 100644
--- a/drivers/gpu/drm/i915/gt/intel_engine_cs.c
+++ b/driver
Update fuse handling for media to future-proof it.
Signed-off-by: Lucas De Marchi
---
Lucas De Marchi (2):
drm/i915/gt: Use MEDIA_VER() when handling media fuses
drm/i915/gt: Extract function to apply media fuses
drivers/gpu/drm/i915/gt/intel_engine_cs.c | 142
On Wed, Sep 07, 2022 at 04:25:42PM -0700, Lucas De Marchi wrote:
This reverts commit 487970e8bb776c989013bb59d6cbb22e45b9afc6.
Updated bspec and workaround database note Wa_1409120013 is not needed
for DG2 (or any Xe_LPD) platform. Simply check by display version 12.
v2: Simplify condition
e people should be using it
more instead of relying on patchwork.
Should the Acked-by be recorded on each patch? That is what is usually
done, but if preference would be for a merge commit to be created and
Acked-by recorded in the merge commit, dim would need to learn a
few things. b4 is already prepared:
$ b4 shazam -M -P1-15 yxdlfwjillqqh...@kroah.com
Lucas De Marchi
other function and there is no version 10. Remove that function and
the caller.
Cc: Ville Syrjälä
Signed-off-by: Lucas De Marchi
diff --git a/drivers/gpu/drm/i915/gt/intel_gt_clock_utils.c
b/drivers/gpu/drm/i915/gt/intel_gt_clock_utils.c
index 93608c9349fd..ebddbf7542bc 100644
--- a/drivers/gpu/drm
the branch taken for GRAPHICS_VER == 10
is also different, but currently there is no such platform in i915.
Signed-off-by: Lucas De Marchi
Reviewed-by: Matt Roper
diff --git a/drivers/gpu/drm/i915/gt/intel_gt_clock_utils.c
b/drivers/gpu/drm/i915/gt/intel_gt_clock_utils.c
index d5d1b04dbcad..9
Continue converting the driver to the convention of last version first,
extending it to the future platforms. Now, any GRAPHICS_VER >= 11 will
be handled by the first branch.
Signed-off-by: Lucas De Marchi
diff --git a/drivers/gpu/drm/i915/gem/i915_gem_stolen.c
b/drivers/gpu/drm/i915/
Refactor code to follow the same convention as last platform first. This
series includes one patch that had already been reviewed, for frequency read
and 2 more refactors.
Signed-off-by: Lucas De Marchi
---
Lucas De Marchi (3):
drm/i915: Invert if/else ladder for frequency read
drm
On Thu, Sep 08, 2022 at 02:08:55PM +0300, Ville Syrjälä wrote:
On Wed, Sep 07, 2022 at 01:30:41PM -0700, Lucas De Marchi wrote:
Continue converting the driver to the convention of last version first,
extending it to the future platforms. Now, any GRAPHICS_VER >= 11 will
be handled by the fi
Taylor
Signed-off-by: Lucas De Marchi
Reviewed-by: Matt Roper
---
drivers/gpu/drm/i915/intel_pm.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
index 210c1f78cc90..eb9c54bbf51f 100644
--- a/drivers/gpu/drm
On Wed, Sep 07, 2022 at 03:28:30PM -0700, Matt Roper wrote:
On Wed, Sep 07, 2022 at 01:26:06PM -0700, Lucas De Marchi wrote:
This reverts commit 487970e8bb776c989013bb59d6cbb22e45b9afc6.
Updated bspec and workaround database note Wa_1409120013 is not needed
for DG2 (or any Display 13) platform
) is false.
Signed-off-by: Lucas De Marchi
---
drivers/gpu/drm/i915/gt/intel_lrc.c | 16
1 file changed, 4 insertions(+), 12 deletions(-)
diff --git a/drivers/gpu/drm/i915/gt/intel_lrc.c
b/drivers/gpu/drm/i915/gt/intel_lrc.c
index 070cec4ff8a4..43fa7b3422c4 100644
--- a/drive
On Wed, Sep 07, 2022 at 03:18:00PM -0700, Matt Roper wrote:
On Wed, Sep 07, 2022 at 01:39:10PM -0700, Lucas De Marchi wrote:
Check for media IP version instead of graphics since this is figuring
out the media engines' configuration. Currently the only platform with
non-matching graphics/
On Wed, Sep 07, 2022 at 03:13:31PM -0700, Matt Roper wrote:
On Wed, Sep 07, 2022 at 01:49:25PM -0700, Lucas De Marchi wrote:
On Thu, Sep 01, 2022 at 11:03:33PM -0700, Radhakrishna Sripada wrote:
> From: Matt Roper
>
> Going forward, the hardware teams no longer consider new platforms
, ip->rel == 1
ver == 12, rel == 0
we will print
Hardware reports GMD IP version 12.1 but minimum expected is 12.0"
should it be `|| ip->rel < rel`? Once we land the static number in
device info, we can only expect new .rel versions greater than that.
Lucas De Marchi
Just like is done for compute and copy engines, extract a function to
handle media engines. While at it, be consistent on using or not the
uncore/gt/info variable aliases.
Cc: Matt Roper
Signed-off-by: Lucas De Marchi
---
drivers/gpu/drm/i915/gt/intel_engine_cs.c | 136
rsion which then includes that platform.
Cc: Matt Roper
Signed-off-by: Lucas De Marchi
---
drivers/gpu/drm/i915/gt/intel_engine_cs.c | 11 ++-
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/i915/gt/intel_engine_cs.c
b/drivers/gpu/drm/i915/gt/intel_engine
the branch taken for GRAPHICS_VER == 10
is also different, but currently there is no such platform in i915.
Cc: Matt Roper
Signed-off-by: Lucas De Marchi
---
.../gpu/drm/i915/gt/intel_gt_clock_utils.c| 77 +--
1 file changed, 37 insertions(+), 40 deletions(-)
diff --git a/driv
This reverts commit 487970e8bb776c989013bb59d6cbb22e45b9afc6.
Updated bspec and workaround database note Wa_1409120013 is not needed
for DG2 (or any Display 13) platform.
Cc: Matt Roper
Cc: Matt Atwood
Cc: Clint Taylor
Signed-off-by: Lucas De Marchi
---
drivers/gpu/drm/i915/intel_pm.c | 4
o the device lifetime, so we don't need to
explicitly free them (and kfree would be incorrect anyway).
Signed-off-by: Matt Roper
Reviewed-by: Lucas De Marchi
Lucas De Marchi
Bspec: 68331
Cc: Lucas De Marchi
Cc: Lionel Landwerlin
Signed-off-by: Matt Roper
Reviewed-by: Lucas De Marchi
Lucas De Marchi
y, so maybe this could be
intel_display_set_quirk()? similar for other functions
anyway:
Reviewed-by: Lucas De Marchi
until this patch, except patch 5
Lucas De Marchi
On Thu, Aug 11, 2022 at 06:07:23PM +0300, Jani Nikula wrote:
Move display related members under drm_i915_private display sub-struct.
Split audio funcs to display.funcs to follow the same pattern as all the
other display functions.
Signed-off-by: Jani Nikula
Reviewed-by: Lucas De Marchi
On Wed, Aug 17, 2022 at 11:07:46AM +0300, Jani Nikula wrote:
On Wed, 17 Aug 2022, Jani Nikula wrote:
On Tue, 16 Aug 2022, Lucas De Marchi wrote:
On Thu, Aug 11, 2022 at 06:07:12PM +0300, Jani Nikula wrote:
In another long-overdue cleanup, add a display sub-struct to
drm_i915_private, and
On Wed, Aug 17, 2022 at 10:00:01AM +0300, Jani Nikula wrote:
On Tue, 16 Aug 2022, Lucas De Marchi wrote:
On Thu, Aug 11, 2022 at 06:07:35PM +0300, Jani Nikula wrote:
Move display related members under drm_i915_private display sub-struct.
Prefer adding anonymous sub-structs even for single
On Wed, Aug 17, 2022 at 09:50:52AM +0300, Jani Nikula wrote:
On Tue, 16 Aug 2022, Lucas De Marchi wrote:
On Thu, Aug 11, 2022 at 06:07:16PM +0300, Jani Nikula wrote:
Move display related members under drm_i915_private display sub-struct.
Rename struct i915_clock_gating_funcs to
dd my Reviewed-by: Lucas De Marchi
on all of them, except patch 5.
For patch 5, movingo clock_gating_funcs, I'm not really sure it's what
we want.
thanks
Lucas De Marchi
he struct to display_power_domains?
Reviewed-by: Lucas De Marchi
for all patches til this, expect patch 5
Lucas De Marchi
dn't have so many implicit params anymore.
Mind adding a "TODO: remove implicit dev_priv parameter" ?
Reviewed-by: Lucas De Marchi
Lucas De Marchi
xcept patch 5, for
clock_gating_funcs):
Reviewed-by: Lucas De Marchi
Lucas De Marchi
Marchi
Lucas De Marchi
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/g4x_dp.c | 4 +-
drivers/gpu/drm/i915/display/intel_ddi.c | 6 +-
.../gpu/drm/i915/display/intel_display_core.h | 40 ++
.../drm/i915/display/intel_display_debugfs.c | 16 +--
drivers/gpu/drm
ore.h
+++ b/drivers/gpu/drm/i915/display/intel_display_core.h
@@ -12,6 +12,7 @@
#include "intel_display.h"
#include "intel_dmc.h"
+#include "intel_dpll_mgr.h"
#include "intel_gmbus.h"
struct drm_i915_private;
@@ -24,6 +25,7 @@ struct intel_color_funcs;
struct intel_crtc;
struct intel_crtc_state;
struct intel_dpll_funcs;
+struct intel_dpll_mgr;
if you include intel_dpll_mgr.h you don't need the fwd declaration?
Reviewed-by: Lucas De Marchi
Lucas De Marchi
On Thu, Aug 11, 2022 at 06:07:21PM +0300, Jani Nikula wrote:
Move display related members under drm_i915_private display sub-struct.
Signed-off-by: Jani Nikula
Reviewed-by: Lucas De Marchi
Lucas De Marchi
ing using anonymous structs. Keep sorted. */
this maybe deserves to be a comment on top of struct intel_display.
Maybe alsos s/Grouping/Group/
regardless,
Reviewed-by: Lucas De Marchi
Lucas De Marchi
dev_priv->color_funcs->color_commit_noarm(crtc_state);
+ if (dev_priv->display.funcs.color->color_commit_noarm)
+ dev_priv->display.funcs.color->color_commit_noarm(crtc_state);
similar comment as for crtc. Maybe later we can remove the color_
prefix?
Reviewed-by: Lucas De Marchi
Lucas De Marchi
On Thu, Aug 11, 2022 at 06:07:18PM +0300, Jani Nikula wrote:
Move display related members under drm_i915_private display sub-struct.
Signed-off-by: Jani Nikula
Reviewed-by: Lucas De Marchi
Lucas De Marchi
On Thu, Aug 11, 2022 at 06:07:17PM +0300, Jani Nikula wrote:
Move display related members under drm_i915_private display sub-struct.
Rename struct drm_i915_wm_disp_funcs to intel_wm_funcs while at it.
Signed-off-by: Jani Nikula
Reviewed-by: Lucas De Marchi
Lucas De Marchi
ing I'd have is regarding the registers it touches.
And here they are not from display.
So, I don't really understand the reason for moving clock_gating here,
except that there are indeed several functions doing display-related
things. Should we rather split one for i915 and one for i915-display?
Lucas De Marchi
dev_priv->display.funcs.hotplug = &ilk_hpd_funcs;
pass by comment: eventually we will want to move all these irq related
to display to display/, right?
Reviewed-by: Lucas De Marchi
Lucas De Marchi
}
}
--
2.34.1
cs.crtc->get_initial_plane_nfig()
display->funcs.crtc->enable()
display->funcs.crtc->disable()
display->funcs.crtc->commit_modeset_enables()
and then call this `struct intel_crtc_funcs`.
This can be done later as this commit itself is basically moving things
with the same name inside a substruct.
Reviewed-by: Lucas De Marchi
Lucas De Marchi
uning setting
applies to all DG2 variants and steppings, making it a superset of the
workaround.
Bspec: 68331
Cc: Lucas De Marchi
Cc: Lionel Landwerlin
Signed-off-by: Matt Roper
---
drivers/gpu/drm/i915/gt/intel_gt_regs.h | 8 ++
drivers/gpu/drm/i915/gt/intel_workarounds.c
ere to implement new ones.
Cc: Lucas De Marchi
Signed-off-by: Matt Roper
Reviewed-by: Lucas De Marchi
Lucas De Marchi
---
drivers/gpu/drm/i915/gt/intel_workarounds.c | 42 ++---
1 file changed, 28 insertions(+), 14 deletions(-)
diff --git a/drivers/gpu/drm/i915/gt/intel_workaro
DG2 as the previous test makes igt@i915_pm_rpm to cause a
module reload.
Signed-off-by: Lucas De Marchi
---
lib/drmtest.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/lib/drmtest.c b/lib/drmtest.c
index 09a9a229..4f9d8a11 100644
--- a/lib/drmtest.c
+++ b/lib/drmtest.c
@@ -313,6 +313,7
?
Signed-off-by: Balasubramani Vivekanandan
Reviewed-by: Lucas De Marchi
Reviewed-by: Nirmoy Das
---
drivers/gpu/drm/drm_cache.c | 55 +
include/drm/drm_cache.h | 3 ++
2 files changed, 58 insertions(+)
diff --git a/drivers/gpu/drm/drm_cache.c b/drivers
DSS steering iterator to
intel_gt_mcr")
Signed-off-by: Matt Roper
Reviewed-by: Lucas De Marchi
Lucas De Marchi
---
drivers/gpu/drm/i915/gt/intel_gt_mcr.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/gt/intel_gt_mcr.c
b/drivers/gpu/drm/i915/gt/int
On Mon, Jul 04, 2022 at 08:30:08AM +0200, Christian König wrote:
Am 28.06.22 um 00:47 schrieb Lucas De Marchi:
Instead of always falling back to memcpy_fromio() for any size, prefer
using read{b,w,l}(). When reading struct members it's common to read
individual integer variables individ
etting confused, we send it as an explicit revert on
the mailing list.
ack on the approach
Lucas De Marchi
as De Marchi
Signed-off-by: Matt Roper
Reviewed-by: Lucas De Marchi
Lucas De Marchi
601 - 700 of 3163 matches
Mail list logo
